Timeline



Dec 7, 2005:

11:42 PM Changeset in webkit [11489] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Landed by Darin.

  • fast/text/atsui-pointtooffset-calls-cg-expected.checksum: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.png: Added.
  • fast/text/atsui-pointtooffset-calls-cg-expected.txt: Added.
  • fast/text/atsui-pointtooffset-calls-cg.html: Added.
11:41 PM Changeset in webkit [11488] by darin
  • 2 edits in trunk/WebKit

Reviewed by Maciej, landed by Darin.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer pointToOffset:style:position:reversed:includePartialGlyphs:]): Added the missing "return".
4:19 PM Changeset in webkit [11487] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • <rdar://problem/4331488> TOT Assertion failure in -[WebHTMLView nextValidKeyView] @ home.netscape.com
  • WebView.subproj/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assert that I added a while back. In this case at least, the assertion is overzealous, and I can't recreate the tortured chain of logic that led me to adding this assertion in the first place.
3:19 PM Changeset in webkit [11486] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Add Radar bug # to an old commit.

2:48 PM Changeset in webkit [11485] by hyatt
  • 2 edits in trunk/WebCore

Fix for Radar bug #4333923, typing tab character into empty
document in Mail doesn't work. This was just a silly regression
from my pre-wrap/pre-line implementation. I accidentally changed
code to examine the wrong style().

Reviewed by harrison

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak):
1:24 PM Changeset in webkit [11484] by hyatt
  • 2 edits in trunk/WebCore

Fix the DHTML menus on monster.com. offsetParent should only return RenderObjects that
have corresponding DOM elements.

Reviewed by Eric Seidel

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
2:31 AM Changeset in webkit [11483] by eseidel
  • 1 edit
    2 deletes in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: no review needed.

Removing unused files.

  • kcanvas/KCanvasRegistry.cpp: Removed.
  • kcanvas/KCanvasRegistry.h: Removed.

Dec 6, 2005:

5:16 PM Changeset in webkit [11482] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Removed change marker.

5:12 PM Changeset in webkit [11481] by hyatt
  • 16 edits in trunk/WebCore

Add support for more methods for exposing more useful style information.

getMatchedCSSRules can be used to obtain the matched sheet rules for an element. In Obj-C
it will also include user/user agent sheet rules.

Also add support for tracking the original shorthand in which a property was declared, as well
as whether the property was just implicitly set rather than explicitly mentioned (e.g., if it was
an omitted piece of a shorthand). The new methods on CSSStyleDeclaration are getPropertyShorthand
and isPropertyImplicit.

Reviewed by mjs

Test: fast/inspector/style.html

  • khtml/css/css_computedstyle.h: (DOM::CSSComputedStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSComputedStyleDeclarationImpl::isPropertyImplicit):
  • khtml/css/css_valueimpl.cpp: (DOM::CSSStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSMutableStyleDeclarationImpl::getPropertyPriority): (DOM::CSSMutableStyleDeclarationImpl::getPropertyShorthand): (DOM::CSSMutableStyleDeclarationImpl::isPropertyImplicit): (DOM::CSSProperty::cssText): (DOM::operator==):
  • khtml/css/css_valueimpl.h: (DOM::CSSProperty::CSSProperty): (DOM::CSSProperty::operator=): (DOM::CSSProperty::~CSSProperty): (DOM::CSSProperty::setValue): (DOM::CSSProperty::shorthandID): (DOM::CSSProperty::isImportant): (DOM::CSSProperty::isImplicit):
  • khtml/css/cssparser.cpp: (CSSParser::CSSParser): (CSSParser::addProperty): (CSSParser::parseValue): (CSSParser::parseBackgroundShorthand): (CSSParser::parseShorthand): (CSSParser::parse4Values): (CSSParser::parseBackgroundPosition): (CSSParser::parseBackgroundProperty):
  • khtml/css/cssparser.h: (DOM::CSSParser::enterShorthand): (DOM::CSSParser::exitShorthand): (DOM::CSSParser::inShorthand):
  • khtml/css/cssstyleselector.cpp: (khtml::CSSStyleSelector::CSSStyleSelector): (khtml::CSSStyleSelector::matchRules): (khtml::CSSStyleSelector::matchRulesForList): (khtml::CSSStyleSelector::initForStyleResolve): (khtml::CSSStyleSelector::styleRulesForElement): (khtml::CSSStyleSelector::pseudoStyleRulesForElement):
  • khtml/css/cssstyleselector.h:
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction):
  • khtml/ecma/kjs_css.h: (KJS::DOMCSSStyleDeclaration::):
  • khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
  • khtml/ecma/kjs_views.h: (KJS::DOMAbstractView::):
  • khtml/xml/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getComputedStyle): (DOM::AbstractViewImpl::getMatchedCSSRules):
  • khtml/xml/dom2_viewsimpl.h:
  • kwq/DOM-CSS.mm: (-[DOMCSSStyleDeclaration getPropertyShorthand:]): (-[DOMCSSStyleDeclaration isPropertyImplicit:]): (-[DOMDocument getMatchedCSSRules::]):
  • kwq/DOMPrivate.h:
5:11 PM Changeset in webkit [11480] by hyatt
  • 3 adds in trunk/LayoutTests/fast/inspector

Land layout test for style inspection.

3:34 PM Changeset in webkit [11479]
  • 55 copies
    22 deletes in tags/WebKit-417~7

This commit was manufactured by cvs2svn to create tag 'WebKit-417~7'.

3:34 PM Changeset in webkit [11478]
  • 211 copies
    17 deletes in tags/WebCore-417~10

This commit was manufactured by cvs2svn to create tag
'WebCore-417~10'.

3:34 PM Changeset in webkit [11477] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning to WebKit-417.7 and WebCore-417.10

2:12 PM Changeset in webkit [11476] by harrison
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
2:06 PM Changeset in webkit [11475] by harrison
  • 2 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Darin.

  • fix <rdar://problem/4365308> Glendale Regression: Floating dictionary doesn't work well in Safari text areas/fields

Add use of NSAccessibilityHitTest to the list of exceptions.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView hitTest:]): check for NSFlagsChanged event.
1:54 PM Changeset in webkit [11474] by sullivan
  • 2 edits in trunk/WebKitTools

Reviewed by Darin Adler.

  • Scripts/prepare-ChangeLog: Remove special-case handling for nib files. This avoided trouble with cvs diff when we were using wrappers for nib files. Now that we aren't using wrappers, there's no reason to avoid adding the modified nib files to the file list that gets diffed.
11:38 AM Changeset in webkit [11473] by andersca
  • 3 edits in trunk/JavaScriptCore

2005-12-06 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • fix build when using gcc 4
  • kjs/ustring.h: Make Rep public.
  • kxmlcore/PassRefPtr.h: (KXMLCore::::operator): Fix a typo.
1:21 AM Changeset in webkit [11472] by mjs
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • cleaned up UString a little so that it doesn't need to have so many friend classes
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kjs/identifier.h: (KJS::Identifier::Identifier): (KJS::Identifier::equal):
  • kjs/property_map.cpp: (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::remove):
  • kjs/ustring.cpp: (KJS::UCharReference::operator=): (KJS::UCharReference::ref): (KJS::UString::Rep::createCopying): (KJS::UString::Rep::create): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::spliceSubstringsWithSeparators): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::toStrictUInt32): (KJS::UString::substr): (KJS::UString::copyForWriting): (KJS::operator==):
  • kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString): (KJS::UString::data): (KJS::UString::isNull): (KJS::UString::isEmpty): (KJS::UString::size): (KJS::UString::rep):
  • kxmlcore/RefPtr.h: (KXMLCore::RefPtr::RefPtr): (KXMLCore::RefPtr::operator*): (KXMLCore::::operator): (KXMLCore::operator==): (KXMLCore::operator!=): (KXMLCore::static_pointer_cast): (KXMLCore::const_pointer_cast):

WebCore:

Reviewed by Eric.

  • add PassRefPtr, a smart pointer class that works in conjunction with RefPtr but has transfer-of-ownership semantics
  • apply RefPtr and PassRefPtr to UString
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):

Dec 5, 2005:

11:20 PM Changeset in webkit [11471] by eseidel
  • 4 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Script updates for SVG files move (remove references to SVGSupport)

  • Scripts/build-webkit: remove SVGSupport
  • Scripts/run-webkit-tests: Resources -> resources for --svg
  • Scripts/update-webkit: remove SVGSupport
10:29 PM Changeset in webkit [11470] by eseidel
  • 28 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Changed "Resources" to "resources" to match other layout tests.

  • svg/W3C-SVG-1.1/color-prof-01-f.svg:
  • svg/W3C-SVG-1.1/filters-conv-01-f.svg:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f.svg:
  • svg/W3C-SVG-1.1/filters-displace-01-f.svg:
  • svg/W3C-SVG-1.1/filters-image-01-b.svg:
  • svg/W3C-SVG-1.1/filters-light-01-f.svg:
  • svg/W3C-SVG-1.1/filters-specular-01-f.svg:
  • svg/W3C-SVG-1.1/fonts-elem-03-b.svg:
  • svg/W3C-SVG-1.1/fonts-elem-04-b.svg:
  • svg/W3C-SVG-1.1/interact-cursor-01-f.svg:
  • svg/W3C-SVG-1.1/interact-order-02-b.svg:
  • svg/W3C-SVG-1.1/interact-order-03-b.svg:
  • svg/W3C-SVG-1.1/linking-a-01-b.svg:
  • svg/W3C-SVG-1.1/linking-a-02-b.svg:
  • svg/W3C-SVG-1.1/linking-a-03-b.svg:
  • svg/W3C-SVG-1.1/linking-a-04-t.svg:
  • svg/W3C-SVG-1.1/linking-uri-02-b.svg:
  • svg/W3C-SVG-1.1/linking-uri-03-t.svg:
  • svg/W3C-SVG-1.1/masking-path-04-b.svg:
  • svg/W3C-SVG-1.1/render-groups-01-b.svg:
  • svg/W3C-SVG-1.1/render-groups-03-t.svg:
  • svg/W3C-SVG-1.1/struct-image-01-t.svg:
  • svg/W3C-SVG-1.1/struct-image-02-b.svg:
  • svg/W3C-SVG-1.1/struct-image-03-t.svg:
  • svg/W3C-SVG-1.1/struct-image-05-b.svg:
  • svg/W3C-SVG-1.1/struct-symbol-01-b.svg:
  • svg/W3C-SVG-1.1/text-tref-01-b.svg:
10:08 PM Changeset in webkit [11469] by eseidel
  • 81 edits in trunk/LayoutTests

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

Updating all the SVG tests with their latest post-merger results.
There are still issues which will prevent these from passing on
all machines:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4515
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5962

  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.checksum:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.checksum:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.png:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.png:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.png:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.checksum:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.png:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.png:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-frag-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.png:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.png:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.png:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.checksum:
  • svg/custom/fill-update-expected.checksum:
  • svg/custom/fill-update-expected.png:
  • svg/custom/path-bad-data-expected.checksum:
  • svg/custom/path-bad-data-expected.png:
  • svg/custom/path-update-expected.checksum:
  • svg/custom/path-update-expected.png:
  • svg/custom/simpleCDF-expected.checksum:
  • svg/custom/simpleCDF-expected.png:
  • svg/custom/use-forward-refs-expected.checksum:
  • svg/custom/use-forward-refs-expected.png:
  • svg/custom/use-forward-refs-expected.txt:
8:29 PM Changeset in webkit [11468] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
REGRESSION: selection keeps growing after double-click
Also filed as <rdar://problem/4364425>

Reviewed by darin, harrsion

  • editing/selection/paragraph-granularity-expected.checksum: Added.
  • editing/selection/paragraph-granularity-expected.png: Added.
  • editing/selection/paragraph-granularity-expected.txt: Added.
  • editing/selection/paragraph-granularity.html: Added.
  • editing/selection/word-granularity-expected.checksum: Added.
  • editing/selection/word-granularity-expected.png: Added.
  • editing/selection/word-granularity-expected.txt: Added.
  • editing/selection/word-granularity.html: Added.
8:29 PM Changeset in webkit [11467] by justing
  • 4 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5936>
REGRESSION: selection keeps growing after double-click
Also filed as <rdar://problem/4364425>

Reviewed by darin, harrison

Rolled back previous change, simplified expansion, fixed
adjustForEditableContent to work in cases where start/end are
distinct from base/extent, renamed m_baseIsStart to m_baseIsFirst.

Added two new layout tests in editing/selection to test
modifying selections created with double and triple clicks.

  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::SelectionController): (khtml::SelectionController::init): (khtml::SelectionController::operator=): (khtml::SelectionController::expandUsingGranularity): (khtml::SelectionController::adjustForEditableContent): (khtml::SelectionController::validate):
  • khtml/editing/SelectionController.h:
  • khtml/khtml_part.cpp: (KHTMLPart::handleMouseMoveEventSelection): (KHTMLPart::khtmlMouseMoveEvent):
6:41 PM Changeset in webkit [11466] by eseidel
  • 2 edits in trunk/WebCore

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

  • WebCore.xcodeproj/project.pbxproj: updated paths for SVG move.
6:35 PM Changeset in webkit [12217] by mjs
  • 1 edit
    2 adds in trunk/JavaScriptGlue
  • added new forwarding headers
  • kxmlcore/PassRefPtr.h: Added.
  • kxmlcore/RefPtr.h: Added.
6:16 PM Changeset in webkit [11465] by eseidel
  • 2 edits in trunk/WebKitTools

Bug #: none
Submitted by: eseidel
Reviewed by: mjs

  • checkout: remove --svg support, SVG is now checked out by default
6:04 PM Changeset in webkit [11464] by eseidel
  • 6 edits in trunk/LayoutTests

Bug #: 5747
Submitted by: eseidel
Reviewed by: timo

Updated results for KCanvaPath changes:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
5:53 PM Changeset in webkit [11463] by eseidel
  • 54 edits
    1 add
    6 deletes in trunk/WebCore

Bug #: 5942, 5943
Submitted by: eseidel
Reviewed by: darin

No test cases possible/necessary.

Removing unused ForwardingHeaders, as well as header cleanup in SVG
Fixed KSVG2 files to include proper KDOM headers.
Fixed KDOM forwarding headers to point to correct khtml headers.
Added DataRef.h to hold khtml::DataRef.
Made SVGRenderStyle a DataRef on RenderStyle.
(Landing two bugs at once as their project file changes intertwine)

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5942
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5943

  • ForwardingHeaders/kdom/DOMString.h:
  • ForwardingHeaders/kdom/KDOMSettings.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedDocument.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedImage.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedObject.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h:
  • ForwardingHeaders/kdom/cache/KDOMCachedScript.h:
  • ForwardingHeaders/kdom/cache/KDOMLoader.h:
  • ForwardingHeaders/kdom/core/AttrImpl.h:
  • ForwardingHeaders/kdom/core/CDFInterface.h: Removed.
  • ForwardingHeaders/kdom/core/DOMImplementationImpl.h:
  • ForwardingHeaders/kdom/core/DOMStringImpl.h:
  • ForwardingHeaders/kdom/core/DocumentImpl.h:
  • ForwardingHeaders/kdom/core/ElementImpl.h:
  • ForwardingHeaders/kdom/core/NodeImpl.h:
  • ForwardingHeaders/kdom/core/XMLElementImpl.h:
  • ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h:
  • ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h:
  • ForwardingHeaders/kdom/css/CSSStyleSelector.h:
  • ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h:
  • ForwardingHeaders/kdom/css/CSSValueImpl.h:
  • ForwardingHeaders/kdom/css/KDOMCSSParser.h:
  • ForwardingHeaders/kdom/css/RGBColorImpl.h:
  • ForwardingHeaders/kdom/events/UIEventImpl.h:
  • ForwardingHeaders/kdom/events/kdomevents.h:
  • ForwardingHeaders/kdom/kdom.h:
  • ForwardingHeaders/ksvg2/KSVGPart.h:
  • ForwardingHeaders/ksvg2/KSVGView.h:
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/KDOMStubClasses.h: Removed.
  • WebCore+SVG/kdomcss.h: Removed.
  • WebCore+SVG/kdomls.h: Removed.
  • WebCore+SVG/kdomrange.h: Removed.
  • WebCore+SVG/kdomtraversal.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/KCanvasTreeDebug.cpp: (writeStyle):
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::drawMarkersIfNeeded):
  • khtml/rendering/DataRef.h: Added. (khtml::DataRef::DataRef): (khtml::DataRef::~DataRef): (khtml::DataRef::operator->): (khtml::DataRef::get): (khtml::DataRef::access): (khtml::DataRef::init): (khtml::DataRef::operator=): (khtml::DataRef::operator == ): (khtml::DataRef::operator != ):
  • khtml/rendering/render_style.cpp: (m_affectedByAttributeSelectors): (RenderStyle::RenderStyle): (RenderStyle::inheritFrom): (RenderStyle::~RenderStyle): (RenderStyle::operator==): (RenderStyle::inheritedNotEqual): (RenderStyle::diff):
  • khtml/rendering/render_style.h: (khtml::RenderStyle::svgStyle): (khtml::RenderStyle::accessSVGStyle):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp: (SVGRenderStyle::SVGRenderStyle): (SVGRenderStyle::inheritedNotEqual):
  • ksvg2/css/SVGRenderStyle.h: (KSVG::SVGRenderStyle::operator!=):
  • ksvg2/css/SVGRenderStyleDefs.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler):
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGClipPathElementImpl.cpp:
  • ksvg2/svg/SVGCursorElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGElementImpl.h:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGGradientElementImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/SVGZoomAndPanImpl.h:
5:46 PM Changeset in webkit [11462] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • WebView.subproj/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): one more tweak: moved jumpToSelection: to be validated the same way as centerSelectionInVisibleArea:, since it now calls the same code. Might not make a difference in any real code, but you never know.
5:23 PM Changeset in webkit [11461] by eseidel
  • 39 edits
    2 adds in trunk/WebCore

Bug #: 5747
Submitted by: eseidel
Reviewed by: timo

5 test cases updated, no additional tests needed.

Removed KCPathData, KCPathDataList and KCanvasUserData.
Added KCanvasPath and KCanvasPathQuartz instead.
Updated methods to expect KCanvasPath* types and use RefPtr.
Removed no longer needed KCPathDataList -> KCanvasUserData routines
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5747

  • WebCore.xcodeproj/project.pbxproj: added KCanvasPath(Quartz)
  • kcanvas/KCanvasCreator.cpp: (KCanvasCreator::createRoundedRectangle): updated to KCanvasPath* (KCanvasCreator::createRectangle): updated to KCanvasPath* (KCanvasCreator::createEllipse): updated to KCanvasPath* (KCanvasCreator::createCircle): updated to KCanvasPath* (KCanvasCreator::createLine): updated to KCanvasPath*
  • kcanvas/KCanvasCreator.h:
  • kcanvas/KCanvasItem.cpp: (RenderPath::Private::Private): updated to KCanvasPath* (RenderPath::~RenderPath): (RenderPath::changePath): (RenderPath::path): updated to KCanvasPath*
  • kcanvas/KCanvasItem.h:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp: (operator<<): updated to call device->stringForPath()
  • kcanvas/KCanvasPath.h: (KCanvasPath::~KCanvasPath): (KCClipDataList::addPath): updated to KCanvasPath*
  • kcanvas/KCanvasResources.cpp: (KCanvasClipper::addClipData): updated to KCanvasPath*
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTypes.h:
  • kcanvas/device/KRenderingDevice.cpp: (KCanvasCommonArgs::path): updated to KCanvasPath* (KCanvasCommonArgs::setPath): updated to KCanvasPath* (KRenderingDevice::KRenderingDevice):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::paint): updated to KCanvasPath* (KCanvasItemQuartz::bboxForPath): updated to KCanvasPath* (KCanvasItemQuartz::hitsPath): updated to KCanvasPath*
  • kcanvas/device/quartz/KCanvasPathQuartz.h: Added. (KCanvasPathQuartz::cgPath): updated to KCanvasPath*
  • kcanvas/device/quartz/KCanvasPathQuartz.mm: Added. (KCanvasPathQuartz::KCanvasPathQuartz): added (KCanvasPathQuartz::~KCanvasPathQuartz): added (KCanvasPathQuartz::isEmpty): added (KCanvasPathQuartz::moveTo): added (KCanvasPathQuartz::lineTo): added (KCanvasPathQuartz::curveTo): added (KCanvasPathQuartz::closeSubpath): added
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasClipperQuartz::applyClip): updated to KCanvasPath*
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (KRenderingDeviceQuartz::createPath): added (KRenderingDeviceQuartz::stringForPath): updated to KCanvasPath* (KRenderingDeviceQuartz::createItem): updated to KCanvasPath*
  • kcanvas/device/quartz/QuartzSupport.h:
  • kcanvas/device/quartz/QuartzSupport.mm:
  • ksvg2/svg/SVGCircleElementImpl.cpp: (SVGCircleElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGCircleElementImpl.h:
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource): updated to KCanvasPath*
  • ksvg2/svg/SVGEllipseElementImpl.cpp: (KSVG::SVGEllipseElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGEllipseElementImpl.h:
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::createRenderer): updated to KCanvasPath*
  • ksvg2/svg/SVGLineElementImpl.cpp: (SVGLineElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGLineElementImpl.h:
  • ksvg2/svg/SVGPathElementImpl.cpp: (KSVG::SVGPathElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPathElementImpl.h:
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPolygonElementImpl.h:
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGPolylineElementImpl.h:
  • ksvg2/svg/SVGRectElementImpl.cpp: (SVGRectElementImpl::toPathData): updated to KCanvasPath*
  • ksvg2/svg/SVGRectElementImpl.h:
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer): updated to KCanvasPath* (SVGStyledElementImpl::updateCanvasItem): updated to KCanvasPath* (SVGStyledElementImpl::pushAttributeContext):
  • ksvg2/svg/SVGStyledElementImpl.h: (KSVG::SVGStyledElementImpl::toPathData): updated to KCanvasPath*
5:10 PM Changeset in webkit [11460] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/khtmlview.cpp: (KHTMLView::dispatchMouseEvent): Do the same "skip text node" logic for the "oldUnder" variable as for the "targetNode" variable.
4:23 PM Changeset in webkit [11459] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed a problem from the patch to fix <rdar://problem/4365690>. After that checkin, KWQKHTMLPart was
inadvertently left with both centerSelectionInVisibleArea() and centerSelectionInVisibleArea() const.

  • kwq/KWQKHTMLPart.h: renamed centerSelectionInVisibleArea() to revealSelection(). This is the method that was named jumpToSelection() before my recent checkin.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): call revealSelection() rather than centerSelectionInVisibleArea(); this restores the behavior from before my recent checkin. (KWQKHTMLPart::revealSelection): renamed from centerSelectionInVisibleArea() (KWQKHTMLPart::advanceToNextMisspelling): call revealSelection() rather than centerSelectionInVisibleArea(); this restores the behavior from before my recent checkin.
  • kwq/WebCoreBridge.h: removed one of the two declarations of centerSelectionInVisibleArea()
4:14 PM Changeset in webkit [11458] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • WebView.subproj/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): removed double handling of centerSelectionInVisibleArea
3:48 PM Changeset in webkit [11457] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Tim Omernick.

  • WebKit part of fix for <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView jumpToSelection:]): Reimplement jumpToSelection: to call centerSelectionInVisibleArea:, and added a comment explaining why jumpToSelection: exists at all. Note that centerSelectionInVisibleArea: was already implemented here; it was added as part of HTML editing implementation without us realizing that it was the API replacement for jumpToSelection:. (-[WebHTMLView validateUserInterfaceItem:]): validate centerSelectionInVisibleArea: the same way we validate jumpToSelection: (we should have done this when centerSelectionInVisibleArea: was implemented)
  • WebView.subproj/WebPDFView.m: (-[WebPDFView centerSelectionInVisibleArea:]): new method, same code that jumpToSelection: used to have (-[WebPDFView jumpToSelection:]): now calls centerSelectionInVisibleArea:, and there's now a comment about why it exists at all. (-[WebPDFView validateUserInterfaceItem:]): validate centerSelectionInVisibleArea: the same way we validate jumpToSelection:
2:56 PM Changeset in webkit [11456] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Justin Garcia <​justin.garcia@apple.com>

<rdar://problem/4345030>
Denver REGRESSION (10.4.2-10.4.3): Two identical warnings on "Back" from Amazon's package tracker

Before checking the navigation policy for a request, the request is compared
against the last checked request. If the two are the same, no check is done.
In the bug, the two requests are identical except for the boolean on
NSURLRequests that tells Foundation to support multipart loads for that request.
One request was the one that was used to start servicing "Back" operation, and
the second was being used to start loading the page (it needed to be reloaded
because it was the result of a form submission). Set the boolean on all
NSURLRequests, not just one's that are about to be used to start a load.

Reviewed by harrison

  • WebView.subproj/WebDataSource.m: (-[WebDataSource _startLoading:]): (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
2:31 PM Changeset in webkit [11455] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison, John Sullivan.

<rdar://problem/4364847> REGRESSION: QuickTime movies open without controller or don't open at all (5928)

I changed WebFrameView on 2005-11-29 so that it avoids creating duplicate WebPluginDocumentViews.
Unfortunately, this change caused a regression due to the fact that it subtly changed when plugins are
initialized. Certain plugins (e.g. QuickTime) expect to be initialized after the WebPluginDocumentView
has been "committed" (inserted into the view hierarchy).

My fix is to ensure that the plugin is initialized where we previously would have created that second
WebPluginDocumentView -- that is, the plugin is created after the WebPluginDocumentView has been committed.

  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): Don't initialize the plugin if the WebPluginDocumentView has not been inserted into the view hierarchy. We assume here that a later call to -setDataSource: will pass this conditional, once the WebDocumentView has been committed.
2:19 PM Changeset in webkit [11454] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Tim Omernick.

Removed some dead code I happened to stumble across. No test cases added.

  • kwq/KWQTimer.h: removed unused immediateSingleShotOnMainThread()
  • kwq/KWQTimer.mm: removed unused immediateSingleShotOnMainThread() and the class KWQMainThreadPerformTarget that was used to implement it.
2:01 PM Changeset in webkit [11453] by sullivan
  • 5 edits in trunk/WebCore

Reviewed by Tim Omernick.

  • WebCore part of fix for <rdar://problem/4365690> Find > Jump to Selection does nothing on plain-text documents (inc. source HTML)

No behavioral changes here. This patch just eliminates the name "jumpToSelection" in favor of
"centerSelectionInVisibleArea" to match WebKit and AppKit.

  • kwq/KWQKHTMLPart.h: eliminate jumpToSelection(); add centerSelectionInVisibleArea()
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::findString): use centerSelectionInVisibleArea() instead of jumpToSelection() (KWQKHTMLPart::centerSelectionInVisibleArea): renamed from jumpToSelection (KWQKHTMLPart::advanceToNextMisspelling): use centerSelectionInVisibleArea() instead of jumpToSelection()
  • kwq/WebCoreBridge.h: eliminate jumpToSelection; add centerSelectionInVisibleArea
  • kwq/WebCoreBridge.mm: eliminate jumpToSelection. We had been implementing both jumpToSelection and centerSelectionInVisibleArea here, but jumpToSelection now has no more callers.
11:57 AM Changeset in webkit [11452] by thatcher
  • 4 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-05 Vicki Murley <​vicki@apple.com>

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
11:56 AM Changeset in webkit [11451] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-05 Vicki Murley <​vicki@apple.com>

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling
9:40 AM Changeset in webkit [11450] by vicki
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fix <rdar://problem/4363132> Regression: status bar shows wrong text when mousing over links in wacky frameset at directory.apple.com
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): reuse point to work with nested frames; add the overflow clip to accommodate any scrolling

Dec 4, 2005:

3:45 PM Changeset in webkit [11449] by ggaren
  • 2 edits in trunk/JavaScriptCore

Update test results to match Anders's last checkin.

  • tests/mozilla/expected.html:
3:30 PM Changeset in webkit [11448] by andersca
  • 1 edit
    2 adds in trunk/LayoutTests

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

Add new tests for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=3999>

  • fast/js/test-propertyIsEnumerable-expected.txt: Added.
  • fast/js/test-propertyIsEnumerable.html: Added.
3:28 PM Changeset in webkit [11447] by andersca
  • 5 edits in trunk/JavaScriptCore

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Geoffrey.

  • kjs/object.cpp: (KJS::ObjectImp::canPut): Refactor to use getPropertyAttributes.

(KJS::ObjectImp::propertyIsEnumerable):
New function which checks if a property is enumerable.

(KJS::ObjectImp::getPropertyAttributes):

  • kjs/object.h: Add getPropertyAttributes and propertyIsEnumerable.
  • kjs/object_object.cpp: (ObjectPrototypeImp::ObjectPrototypeImp): (ObjectProtoFuncImp::callAsFunction):
  • kjs/object_object.h: (KJS::ObjectProtoFuncImp::): Add propertyIsEnumerable to the Object prototype.
3:14 PM Changeset in webkit [11446] by eseidel
  • 11 edits
    60 deletes in trunk/WebCore

Bug #: 5930
Submitted by: eseidel
Reviewed by: ggaren

No additional test cases needed (or possible).

Further dom/* cleanup, also removing extra forwarding headers
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5930

  • ForwardingHeaders/dom/dom2_views.h: Removed.
  • ForwardingHeaders/dom/dom_core.h: Removed.
  • ForwardingHeaders/dom/dom_doc.h: Removed.
  • ForwardingHeaders/dom/dom_element.h: Removed.
  • ForwardingHeaders/dom/dom_misc.h: Removed.
  • ForwardingHeaders/dom/dom_text.h: Removed.
  • ForwardingHeaders/dom/dom_xml.h: Removed.
  • ForwardingHeaders/dom/html_base.h: Removed.
  • ForwardingHeaders/dom/html_block.h: Removed.
  • ForwardingHeaders/dom/html_document.h: Removed.
  • ForwardingHeaders/dom/html_element.h: Removed.
  • ForwardingHeaders/dom/html_form.h: Removed.
  • ForwardingHeaders/dom/html_head.h: Removed.
  • ForwardingHeaders/dom/html_image.h: Removed.
  • ForwardingHeaders/dom/html_inline.h: Removed.
  • ForwardingHeaders/dom/html_list.h: Removed.
  • ForwardingHeaders/dom/html_misc.h: Removed.
  • ForwardingHeaders/dom/html_object.h: Removed.
  • ForwardingHeaders/dom/html_table.h: Removed.
  • ForwardingHeaders/ecma/kjs_css.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.h: Removed.
  • ForwardingHeaders/ecma/kjs_html.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.h: Removed.
  • ForwardingHeaders/ecma/kjs_views.lut.h: Removed.
  • ForwardingHeaders/ecma/kjs_window.h: Removed.
  • ForwardingHeaders/html/dtd.h: Removed.
  • ForwardingHeaders/kdom/KDOMPart.h: Removed.
  • ForwardingHeaders/kdom/KDOMView.h: Removed.
  • ForwardingHeaders/kdom/core/NodeListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSMediaRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleImpl.h: Removed.
  • ForwardingHeaders/kdom/css/CSSRuleListImpl.h: Removed.
  • ForwardingHeaders/kdom/css/cssproperties.h: Removed.
  • ForwardingHeaders/kdom/css/cssvalues.h: Removed.
  • ForwardingHeaders/kdom/events/DocumentEventImpl.h: Removed.
  • ForwardingHeaders/kdom/parser/KDOMDocumentBuilder.h: Removed.
  • ForwardingHeaders/kdomcssproperties.h: Removed.
  • ForwardingHeaders/kdomcssvalues.h: Removed.
  • ForwardingHeaders/kinstance.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/property_map.h: Removed.
  • ForwardingHeaders/kjs/protected_object.h: Removed.
  • ForwardingHeaders/kjs/scope_chain.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/kjs/value.h: Removed.
  • ForwardingHeaders/ksvg2/svg/svgtags.h: Removed.
  • ForwardingHeaders/q3intdict.h: Removed.
  • ForwardingHeaders/q3memarray.h: Removed.
  • ForwardingHeaders/q3ptrcollection.h: Removed.
  • ForwardingHeaders/q3ptrdict.h: Removed.
  • ForwardingHeaders/qcstring.h: Removed.
  • ForwardingHeaders/qcursor.h: Removed.
  • ForwardingHeaders/qintdict.h: Removed.
  • ForwardingHeaders/qpair.h: Removed.
  • ForwardingHeaders/qprinter.h: Removed.
  • ForwardingHeaders/qptrcollection.h: Removed.
  • ForwardingHeaders/qsize.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
  • ForwardingHeaders/qvaluevector.h: Removed.
  • ForwardingHeaders/xml/dom_positioniterator.h: Removed.
  • khtml/css/css_ruleimpl.cpp:
  • khtml/dom/css_value.h:
  • khtml/dom/dom2_events.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_range.h:
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_node.h:
  • khtml/dom/dom_string.cpp:
  • khtml/ecma/kjs_traversal.cpp:
3:07 PM Changeset in webkit [11445]
  • 210 copies
    17 deletes in tags/WebCore-417~9

This commit was manufactured by cvs2svn to create tag
'WebCore-417~9'.

3:07 PM Changeset in webkit [11444] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning to WebCore-417.9

2:01 PM Changeset in webkit [11443]
  • 26 copies
    3 deletes in tags/WebKit-312~7

This commit was manufactured by cvs2svn to create tag 'WebKit-312~7'.

2:01 PM Changeset in webkit [11442] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebKit

Versioning to WebKit-312.7

1:59 PM Changeset in webkit [11441]
  • 118 copies
    5 deletes in tags/WebCore-315~12

This commit was manufactured by cvs2svn to create tag
'WebCore-315~12'.

1:59 PM Changeset in webkit [11440] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning to WebCore-315.12

1:58 PM Changeset in webkit [11439] by thatcher
  • 1 edit in branches/Safari-1-3-branch/WebCore/khtml/ecma/kjs_html.cpp

Build fix.

1:56 PM Changeset in webkit [11438]
  • 10 copies
    3 deletes in tags/JavaScriptCore-312~3

This commit was manufactured by cvs2svn to create tag
'JavaScriptCore-312~3'.

1:56 PM Changeset in webkit [11437] by thatcher
  • 2 edits in branches/Safari-1-3-branch/JavaScriptCore

Versioning to JavaScriptCore-312.3

1:12 PM Changeset in webkit [11436] by thatcher
  • 4 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2005-12-02 Adele Peterson <​adele@apple.com>

Reviewed by Hyatt.

  • fixed <rdar://problem/4360657> Regression: Seed: WebKit image scaling broken

Removed fix for <rdar://problem/3952698> Function buttons do not display
properly with Telia Webmail (3488). For a more conservative fix, we've added
RenderButton::calcMinMaxWidth to avoid setting the minWidth to 0 for buttons.

  • khtml/rendering/render_form.cpp: (RenderButton::calcMinMaxWidth): (RenderLineEdit::calcMinMaxWidth): (RenderTextArea::calcMinMaxWidth):
  • khtml/rendering/render_form.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::calcMinMaxWidth):
1:02 PM Changeset in webkit [11435] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Merged fix from TOT to Safari-1-3-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at ​http://www.pixar.com/shorts/index.html and
​http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
1:01 PM Changeset in webkit [11434] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-12-02 Darin Adler <Darin Adler>

Reviewed by Beth

Fix for <rdar://problem/4358898> TOT/GLENDALE REGRESSION: Table
layout issue occurs at ​http://www.pixar.com/shorts/index.html and
​http://www.mitzpettel.com.

This fix rolls a line from the fix for <rdar://problem/3871165>
text box in nested table disappears when you click on it (3452)
(Safari PSOFT: US EDU PS8: Lead List searches). This line causes
the above regressions. To fix the original problem, we realized
that TableLayout::calcEffectiveWidth() essentially ignored setting
the minimum and maximum widths of cells of width 0 (thereby ignoring
cells in colspans).

  • khtml/rendering/render_table.cpp: (RenderTableSection::addCell): Roll out from the original fix.
  • khtml/rendering/table_layout.cpp: (AutoTableLayout::calcEffectiveWidth): Set effMinWidth and effMaxWidth of a cell even when maxw or maxWidth is 0.
12:55 PM Changeset in webkit [11433] by andersca
  • 4 edits
    1 add in trunk/WebCore

2005-12-04 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin and Geoffrey.

  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setFocusNode): Don't send onblur to a node if m_inDetach is true.
  • khtml/xml/dom_nodeimpl.cpp: (DOM::NodeImpl::detach): Set m_inDetach to true while calling RenderObject::destroy.
  • khtml/xml/dom_nodeimpl.h:

Add m_inDetach flag.

  • manual-tests/onblur-remove.html: Added.
5:08 AM Changeset in webkit [11432] by eseidel
  • 2 edits in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: No review needed, WebCore+SVG build fix only.

I broke the WebCore+SVG build when removing dom_misc.h, fixing.

  • WebCore+SVG/KDOMHeaders.h: remove reference to dom_misc.h
4:43 AM Changeset in webkit [11431] by eseidel
  • 10 edits
    2 deletes in trunk/WebCore

Bug #: 5929
Submitted by: eseidel
Reviewed by: darin

No functionality changes, no test cases possible or necessary.

Removed dom_misc.* and changed to use Shared instead of DOMShared.
Also removed FilterNode typedef, now using NodeImpl* directly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5929

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/css/css_base.h:
  • khtml/dom/dom2_events.h:
  • khtml/dom/dom2_traversal.cpp: (DOM::NodeFilterCondition::acceptNode):
  • khtml/dom/dom2_traversal.h:
  • khtml/dom/dom_exception.h:
  • khtml/dom/dom_misc.cpp: Removed.
  • khtml/dom/dom_misc.h: Removed.
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_traversal.h:
  • kwq/DOM.mm: (ObjCNodeFilterCondition::acceptNode):
3:35 AM Changeset in webkit [11430] by eseidel
  • 21 edits in trunk/WebCore

Bug #: 5877
Submitted by: eseidel
Reviewed by: mjs

No test cases needed/possible, only removing dead code.

Remove rotten #ifdef'd code from the source:
APPLE_CHANGES & KHTML_NO_CPLUSPLUS_DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5877

  • khtml/dom/css_rule.h: (DOM::CSSRule::):
  • khtml/dom/css_stylesheet.h:
  • khtml/dom/css_value.h: (DOM::CSSValue::): (DOM::CSSPrimitiveValue::):
  • khtml/dom/dom2_events.cpp: (DOM::EventListener::handleEventImpl):
  • khtml/dom/dom2_events.h: (DOM::Event::): (DOM::EventException::): (DOM::MutationEvent::):
  • khtml/dom/dom2_range.h: (DOM::RangeException::): (DOM::Range::):
  • khtml/dom/dom2_traversal.cpp:
  • khtml/dom/dom2_traversal.h: (DOM::NodeFilter::):
  • khtml/dom/dom_exception.h: (DOM::DOMException::):
  • khtml/dom/dom_misc.cpp: (DOM::DomShared::~DomShared):
  • khtml/dom/dom_misc.h: (DOM::DomShared::deleteMe):
  • khtml/dom/dom_node.h: (DOM::Node::):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/khtml_part.cpp: (KHTMLPart::stopLoading):
  • khtml/khtml_part.h:
  • khtml/khtmlview.cpp: (KHTMLView::viewportMousePressEvent): (KHTMLView::focusNextPrevNode):
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKHTMLPageCache.h:
  • kwq/KWQPointArray.h:

Dec 3, 2005:

5:22 PM Changeset in webkit [11429] by ggaren
  • 1 edit
    2 adds in trunk/LayoutTests

Layout test for <rdar://problem/4364302> leftmargin and topmargin
should match marginwidth and marginheight respectively

  • fast/block/positioning/leftmargin-topmargin-expected.txt: Added.
  • fast/block/positioning/leftmargin-topmargin.html: Added.
5:21 PM Changeset in webkit [11428] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4364302> leftmargin and topmargin should match
marginwidth and marginheight respectively

Layout test added:
positioning/leftmargin-topmargin-expected.txt
positioning/leftmargin-topmargin.html

  • khtml/html/html_baseimpl.cpp: (HTMLBodyElementImpl::parseMappedAttribute): Merged leftmargin/marginwidth, topmargin/marginheight
4:53 PM Changeset in webkit [11427] by justing
  • 1 edit
    8 adds in trunk/LayoutTests

New layout tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

Reviewed by darin

  • editing/selection/expanding-selections-expected.checksum: Added.
  • editing/selection/expanding-selections-expected.png: Added.
  • editing/selection/expanding-selections-expected.txt: Added.
  • editing/selection/expanding-selections.html: Added.
  • editing/selection/expanding-selections2-expected.checksum: Added.
  • editing/selection/expanding-selections2-expected.png: Added.
  • editing/selection/expanding-selections2-expected.txt: Added.
  • editing/selection/expanding-selections2.html: Added.
4:48 PM Changeset in webkit [11426] by justing
  • 3 edits in trunk/WebCore

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=5856>
Selection based in an editable block can extend outside

validate() used to do expansion of the selection. The expansion
itself wasn't validated, so it could create a selection
that extended outside an editable area. Also m_base and
m_extent weren't updated with the results of the expansion.

Reviewed by darin

Layout tests added:

  • editing/selection/expanding-selections
  • editing/selection/expanding-selections2
  • khtml/editing/SelectionController.cpp: (khtml::SelectionController::expandUsingGranularity): Does the expansion. (khtml::SelectionController::validate): Removed the granularity parameter.
  • khtml/editing/SelectionController.h:
4:32 PM Changeset in webkit [11425] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Kevin.

Fixed <rdar://problem/3918897> trailer windows at haroldandkumar.com
show up wrong size (with scroll bars)

We had the wrong default features for new windows. The IE rule is:
all features except for channelmode and fullscreen default to YES, but
if the user specifies a feature string, all features default to NO.
(There is no public standard that applies to this method.)

<​http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/open_0.asp>

No test case because testing requires a call to window.open, which
DumpRenderTree can't simulate.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • kwq/KWQKPartsBrowserExtension.h: (KParts::WindowArgs::WindowArgs):
12:26 PM Changeset in webkit [11424] by andersca
  • 5 edits in trunk/WebCore/khtml

Didn't mean to commit this.

12:16 PM Changeset in webkit [11423] by andersca
  • 11 edits
    1 add in trunk/WebCore

2005-12-01 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

  • khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Update calls to append functions to set the enabled state of items.
  • kwq/KWQComboBox.h: (QComboBox::appendItem): (QComboBox::appendGroupLabel): (QComboBox::appendSeparator): Add enabled parameter to append functions.
  • kwq/KWQComboBox.mm: (QComboBox::QComboBox): Don't autoenable menu items on the popup button since that's handled manually now.

(QComboBox::setTitle):
Set enabled state on menu items.

(QComboBox::appendItem):
Add enabled parameter.

  • kwq/KWQListBox.h: (KWQListBoxItem::KWQListBoxItem): Add enabled variable to item struct.

(QListBox::appendItem):
(QListBox::appendGroupLabel):
Add enabled parameter to append functions.

  • kwq/KWQListBox.mm: (QListBox::appendItem): Add enabled parameter.

(-[KWQTableView tableView:shouldSelectRow:]):
Only select the row if the item is enabled.

(-[KWQTableView drawRow:clipRect:]):
Draw using the disabled color if the row is disabled.

  • manual-tests/disabled-option-elements.html: Added.
8:56 AM Changeset in webkit [11422] by darin
  • 1 edit in trunk/WebCore/ChangeLog-2005-12-19

Improved ChangeLog comment.

Note: See TracTimeline for information about the timeline view.