Timeline



Jan 30, 2006:

11:41 PM Changeset in webkit [12490] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Update test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6907
REGRESSION: United.com menus messed up due to document.all/MSIE sniff


  • fast/dom/undetectable-document-all.html: Test that typeof document.all is undefined.
11:41 PM Changeset in webkit [12489] by andersca
  • 6 edits in trunk

2006-01-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6907
REGRESSION: United.com menus messed up due to document.all/MSIE sniff


  • kjs/nodes.cpp: (typeStringForValue): Return "undefined" if the given object should masquerade as undefined.


  • kjs/object.h: (KJS::JSObject::masqueradeAsUndefined): Rename from isEqualToNull.


  • kjs/operations.cpp: (KJS::equal): Update for name change.
10:08 PM Changeset in webkit [12488] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/svn-apply: Added comments about things we should do to improve.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
10:08 PM Changeset in webkit [12487] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Pointed out by Dave Kilzer.

  • added test result I forgot to check in
  • fast/dom/Range/range-exceptions-expected.txt: Added.
6:52 PM Changeset in webkit [12486] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by mjs.

  • Speculative fix for <rdar://problem/4135845> Crash executing cross-frame script on timeout in KJS::ScheduledAction::execute

If we ever get a reproducible case of 4135845, I'll add a test for it.

This is a re-working of Maciej's fix for 3157014 (circa 2003!). Since
you can't reliably predict what the state of the page will be when
a timer fires, I've made the timer responsbile for making sure that
everything is OK to execute.

I tested @ ​http://www.javascriptkit.com/script/cut3.shtml with various
combinations of reload, back, and regular navigations with JS enabled/
disabled to ensure that the previous crash didn't return. I also ran a
leaks test and discovered some, but none unique to this patch. (See
<rdar://problem/4427420> TOT REGRESSION: Leaks seen on page with
JavaScript timer.)

  • khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Return early if there's no window object. (This happens when JavaScript is disabled.) (KJS::Window::retrieveWindow): Reversed a backwards ASSERT, increased prettiness. (The assert fired while I was testing. Not sure why we haven't seen it before.)
  • page/Frame.cpp: (Frame::didOpenURL): Returned setting of JavaScript enabled/disabled preference to its rightful place. This introduces a new behavior: now, the unload event does not fire after you've disabled JavaScript. That seems like a good thing. (See <rdar://problem/4426506> Disabling JavaScript should immediately end JavaScript execution.) (Frame::begin): Ditto.
5:03 PM Changeset in webkit [12485] by thatcher
  • 9 copies in tags/Safari-521.6.2

New tag.

5:00 PM Changeset in webkit [12484] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning and updated the copyright dates.

4:52 PM Changeset in webkit [12483] by thatcher
  • 1 delete in tags/Safari-521.6.2

Redoing this tag.

3:51 PM Changeset in webkit [12482] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

Add -Wno-deprecated-declarations to the compile flags for WebNetscapePluginPackage.m.
<rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment now deprecated.
When we workaround these we can remove this compile flag.

  • WebKit.xcodeproj/project.pbxproj:
3:45 PM Changeset in webkit [12481] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Remove the only use of -[NSFont glyphPacking]. This method was deprecated in Tiger
and always returns NSNativeShortGlyphPacking.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:]):
12:14 PM Changeset in webkit [12480] by ggaren
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Dave Harrison.

  • Fixed <rdar://problem/4378159> crash in KWQKHTMLPart::userGestureHint from javascript enabled/disabled inconsistency when pasting webpage into email or blot
  • page/Frame.cpp: (Frame::userGestureHint): Check root frame's jScript() for NULL instead of checking inner frame's jScript().


After init() has been called on a frame, but before begin() has been
called, the frame can have JavaScript enabled when its parent doesn't.
(That seems wrong, so I've filed <rdar://problem/4426499> Child frame
momentarily has JavaScript enabled even though parent frame doesn't.)


Regardless, it's better programming practice to NULL check the actual
pointer you're going to use, so that's what I've done here.

  • manual-tests/paste-crash.html: Added. (No automated test because the crash depends on JavaScript being disabled.)
10:56 AM Changeset in webkit [12479] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4298052> Crash in
KWQCheckIfReloading at ​http://www.inquisitorx.com/beta/

10:45 AM Changeset in webkit [12478] by bdakin
  • 3 edits in trunk/WebCore

eviewed by Geoff

Fix for <rdar://problem/4298052> Crash in KWQCheckIfReloading at
​http://www.inquisitorx.com/beta/

It is possible for the DocLoader's frame to be nil when the
DocLoader is not nil, so we need nil checks.

10:31 AM Changeset in webkit [12477] by eseidel
  • 2 edits in trunk/WebCore

2006-01-30 Eric Seidel <​eseidel@apple.com>

Add #import "KWQFontMetrics.h" to fix no-svg build.

  • kwq/KWQPainter.mm:
1:03 AM Changeset in webkit [12476] by darin
  • 78 edits in trunk

LayoutTests:

  • updated test result for rect changes
  • fast/box-sizing/percentage-height-expected.txt: A bunch of strange empty clip rects are now dumping as (0,0) 0x0.

WebCore:

Reviewed by Eric.

  • cleanup of Int/Float-Size/Point/Rect classes

I did this as part of a redo of QMatrix, but I decided I should
land this part separately.

Eliminated the concept of a null rect or point, which used to be
indicated by negative width and height.

Changed right and bottom to to be, e.g., 2 for a rect at (0,0) 2x2.
The old code followed Qt's system that says right is 1 in those cases,
which is inappropriate for floating point, and old fashioned because
modern graphics systems use coordinates for lines between pixels, not
the pixels themselves.

Other API improvements to the point, size, and rect classes. For example,
functions named with verbs now always modify the object itself.

  • rendering/render_theme_mac.mm: (RenderThemeMac::paintButton): Fixed a bug where it said x() where it should say y().
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • kcanvas/KCanvasContainer.cpp:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/misc/khtmllayout.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegion.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQScrollView.mm:
  • kwq/KWQWMatrix.cpp:
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm:
  • kwq/KWQWindowWidget.mm:
  • loader/CachedImage.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/FloatPoint.cpp:
  • platform/FloatPoint.h:
  • platform/FloatRect.cpp:
  • platform/FloatRect.h:
  • platform/FloatSize.cpp:
  • platform/FloatSize.h:
  • platform/Image.h:
  • platform/IntPoint.cpp:
  • platform/IntPoint.h:
  • platform/IntPointArray.cpp:
  • platform/IntPointArray.h:
  • platform/IntRect.cpp:
  • platform/IntRect.h:
  • platform/IntSize.cpp:
  • platform/IntSize.h:
  • platform/mac/FloatPoint.mm:
  • platform/mac/FloatRect.mm:
  • platform/mac/FloatSize.mm:
  • platform/mac/Image.mm:
  • platform/mac/IntPoint.mm:
  • platform/mac/IntRect.mm:
  • platform/mac/IntSize.mm:
  • platform/mac/Screen.mm:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderText.cpp:
  • rendering/render_box.cpp:
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp:
  • rendering/render_flow.cpp:
  • rendering/render_form.cpp:
  • rendering/render_frames.cpp:
  • rendering/render_layer.cpp:
  • rendering/render_line.cpp:
  • rendering/render_list.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
12:42 AM Changeset in webkit [12475] by mjs
  • 15 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (operator<<): Implement for Vector<KCGradientStop> (KRenderingPaintServerGradient::gradientStops): Use a Vector, not a subclass of QPtrList that sorts on every insert (compareStopOffset): Comparison function for sorting. (KRenderingPaintServerGradient::setGradientStops): Add a version that takes a Vector which sorts, and another which knows how to copy from another gradient paint server.
  • kcanvas/device/KRenderingPaintServerGradient.h: (makeGradientStop): Make a gradient stop pair.
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): use delete on stops cache (KRenderingPaintServerGradientQuartz::updateQuartzGradientStopsCache): adapt to Vector
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • khtml/editing/visible_text.cpp: (khtml::compareBoxStart): Comparison function for sorting. (khtml::TextIterator::handleTextNode): Use Vector and std::sort instead of QSortedList for sorting. Keep current position as an index. (khtml::TextIterator::handleTextBox): Adapt for Vector use.
  • khtml/editing/visible_text.h:
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::rebuildStops): Use a Vector. Instead of modifying the existing one, make a fresh one and assign it.
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient): don't copy item by item, just assign directly.
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): ditto
  • ksvg2/svg/SVGStopElementImpl.h:
  • kwq/KWQListImpl.cpp:
  • kwq/KWQPtrList.h: (QPtrList::sort): Removed.
  • kwq/KWQSortedList.h: Removed.
  • rendering/InlineTextBox.h: Remove now unneeded operator< and operator=

Jan 29, 2006:

11:27 PM Changeset in webkit [12474] by darin
  • 32 edits
    6 deletes in trunk/WebCore

Reviewed by Maciej.

  • killed more KWQ, KWinModule and QVariant
  • ForwardingHeaders/kwinmodule.h: Removed.
  • ForwardingHeaders/qvariant.h: Removed.
  • kwq/KWQKWinModule.h: Removed.
  • kwq/KWQKWinModule.mm: Removed.
  • kwq/KWQVariant.cpp: Removed.
  • kwq/KWQVariant.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removal.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_binding.cpp: Remove QVariant stuff.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
  • page/Frame.h:
  • page/Frame.cpp: (getString): (Frame::replaceContentsWithScriptResult): (Frame::executeScript): (Frame::executeScheduledScript): (Frame::changeLocation): (Frame::urlSelected): (Frame::submitForm): Changed to use JSValue instead of QVariant for result of executing JavaScript.
  • kwq/KWQObject.h: Removed a bunch of unneeded includes and forward declarations.
  • bridge/mac/MacFrame.mm:
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQObject.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextField.mm:
  • loader/CachedImage.h:
  • page/FrameView.h:
  • page/FrameView.cpp:
  • rendering/render_form.cpp: Updated includes, since KWQObject.h now includes less. Also updated callers to executeScript since one overload was removed.
11:18 PM Changeset in webkit [12473] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • properly define Vector assignment operator; the private version was accidentally left in, and the template version is not enough to replace the default
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator=):
11:13 PM Changeset in webkit [12472] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Added back #include <qvaluelist.h> to fix WIN32 build.

  • rendering/render_style.h:
10:06 PM Changeset in webkit [12471] by darin
  • 50 edits
    2 adds
    11 deletes in trunk/WebCore

Reviewed by Hyatt (drag image fix) and Maciej (the rest).

  • fixed just-introduced crash dragging images

I don't know how to make a layout test for this.

  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): Fixed crash on dragging by initializing m_dragImage to 0.
  • kwq/KWQApplication.h: Removed.
  • kwq/KWQApplication.mm: Removed.
  • kwq/KWQGlobal.cpp: Removed.
  • kwq/KWQKPartsEvent.cpp: Removed.
  • kwq/KWQKPartsEvent.h: Removed.
  • kwq/KWQPair.h: Removed.
  • kwq/KWQStyle.cpp: Removed.
  • kwq/KWQStyle.h: Removed.
  • ForwardingHeaders/kparts/event.h: Removed.
  • ForwardingHeaders/qapplication.h: Removed.
  • ForwardingHeaders/qstyle.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Screen.h: Added. Replaces the desktop widget stuff in KWQApplication.mm.
  • platform/mac/Screen.mm: Added.
  • kwq/KWQDef.h: Removed everything except for kMin and kMax from here. We should port to std::min and std::max, and then we can get rid of this header altogether.
  • kwq/KWQKCursor.h: Removed setAutoHideCursor.
  • kwq/KWQKCursor.mm: Ditto.
  • kwq/KWQWidget.h: Removed style() and setStyle() functions.
  • kwq/KWQWidget.mm: Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::Screen): Store a pointer to the Frame. (KJS::Screen::getValueProperty): Port to use the new Screen.h functions. (KJS::showModalDialog): Ditto. (KJS::Window::getValueProperty): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/khtml_events.h:
  • khtml/khtml_events.cpp: Removed much of the code here. This can be cut down even more.
  • khtml/misc/khtmllayout.h: Removed unused stuff and updated for KWQ changes.
  • kwq/KWQCString.cpp:
  • kwq/KWQKURL.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextCodec.cpp:
  • WebCore+SVG/KDOMSettings.cpp:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssparser.cpp:
  • kcanvas/KCanvasItem.cpp:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • page/Frame.h:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/IntPointArray.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderTable.cpp:
  • rendering/bidi.cpp:
  • rendering/bidi.h:
  • rendering/render_form.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
  • rendering/render_style.h:
  • rendering/table_layout.cpp: Updated for above KWQ changes. Changed tabs to spaces.
9:58 PM Changeset in webkit [12470] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix the build by applying a GCC-specific namespace hack.

  • kjs/lookup.h:
8:52 PM Changeset in webkit [12469] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
8:50 PM Changeset in webkit [12468] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build on Win32.

  • kjs/lookup.h: fixed ::cacheGlobalObject
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): use unsigned long
4:54 PM Changeset in webkit [12467] by hyatt
  • 15 edits in trunk/WebCore

Fix for bug 6910, don't let Image be assignable or copiable. It will soon represent the actual
original Image (including the data) and as such must remain unique.

Reviewed by darin

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEImage::~KCanvasFEImage): (KCanvasFEImage::setCachedImage):
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::KCanvasFEImage): (KCanvasFEImage::cachedImage):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::~ImagePattern): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::cachedImage):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::cachedImage):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::~SVGCursorElementImpl): (SVGCursorElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::cachedImage):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::~SVGFEImageElementImpl): (SVGFEImageElementImpl::parseMappedAttribute): (SVGFEImageElementImpl::notifyFinished):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement): (WebCore::KWQClipboard::imageChanged): (WebCore::KWQClipboard::dragNSImage):
  • platform/Image.h:
3:40 PM Changeset in webkit [12466] by darin
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • rendering/render_image.h: (WebCore::RenderImage::image): Return a null image when m_cachedImage is 0. (WebCore::RenderImage::errorOccurred): Return false when m_cachedImage is 0.
  • rendering/render_image.cpp: (WebCore::RenderImage::nullImage): Added. Returns a global null image for use when we have no cached image.
  • rendering/render_object.h: Renamed the old setImage to imageChanged, the new name for the same function.
  • rendering/render_object.cpp: (WebCore::RenderObject::imageChanged): Ditto.
  • rendering/render_list.cpp: (RenderListMarker::imageChanged): Changed the call to parent to call the new imageChanged instead of the old setImage.
  • fixed something else that was causing some layout test crashes
  • kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Rearrange so we won't ever dereference a null pointer here.
2:24 PM Changeset in webkit [12465] by darin
  • 15 edits
    3 adds in trunk/LayoutTests

Reviewed by Darin.

  • fixed some tests that were missing test images
  • fast/replaced/resources/sample.gif: Added.
  • fast/replaced/resources/1x1-green.png: Added.
  • fast/replaced/resources/1x1-red.png: Added.
  • fast/replaced/001.html: Changed images to point to actual images.
  • fast/replaced/002.html: Ditto.
  • fast/replaced/003.html: Ditto.
  • fast/replaced/004.html: Ditto.
  • fast/replaced/002-expected.txt: Updated.
  • fast/replaced/003-expected.txt: Updated.
  • fast/replaced/001-expected.png: Updated.
  • fast/replaced/001-expected.checksum: Updated.
  • fast/replaced/002-expected.png: Updated.
  • fast/replaced/002-expected.checksum: Updated.
  • fast/replaced/003-expected.png: Updated.
  • fast/replaced/003-expected.checksum: Updated.
  • fast/replaced/004-expected.png: Updated.
  • fast/replaced/004-expected.checksum: Updated.
1:12 PM Changeset in webkit [12464] by mjs
  • 17 edits
    7 deletes in trunk/WebCore

Reviewed by Darin.

  • ForwardingHeaders/q3valuevector.h: Removed.
  • ForwardingHeaders/qptrvector.h: Removed.
  • ForwardingHeaders/qvector.h: Removed.
  • WebCore+SVG/KDOMSettings.cpp: (KDOMSettings::init): (KDOMSettings::isAdFiltered):
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]): (-[WebCoreFrameBridge controlsInForm:]):
  • css/cssstyleselector.h:
  • khtml/html/HTMLCollectionImpl.cpp: (WebCore::HTMLCollectionImpl::updateNameCache): (WebCore::HTMLCollectionImpl::namedItems):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::HTMLFormCollectionImpl): (WebCore::HTMLFormCollectionImpl::calcLength): (WebCore::HTMLFormCollectionImpl::item): (WebCore::HTMLFormCollectionImpl::getNamedFormItem): (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::~HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::length): (WebCore::HTMLFormElementImpl::submitClick): (WebCore::HTMLFormElementImpl::formData): (WebCore::HTMLFormElementImpl::submit): (WebCore::HTMLFormElementImpl::reset): (WebCore::insertIntoVector): (WebCore::removeFromVector): (WebCore::HTMLFormElementImpl::formElementIndex): (WebCore::HTMLFormElementImpl::registerImgElement):
  • khtml/html/HTMLFormElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
  • kwq/KWQComboBox.h:
  • kwq/KWQListBox.h:
  • kwq/KWQPtrVector.h: Removed.
  • kwq/KWQRenderTreeDebug.cpp: (writeLayers):
  • kwq/KWQValueVector.h: Removed.
  • kwq/KWQVectorImpl.cpp: Removed.
  • kwq/KWQVectorImpl.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::compareZIndex): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/render_layer.h: (khtml::RenderLayer::posZOrderList): (khtml::RenderLayer::negZOrderList):
10:59 AM Changeset in webkit [12463] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/border-collapsing/rtl-border-collapsing.html: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.checksum: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.png: Added.
10:59 AM Changeset in webkit [12462] by darin
  • 5 edits in trunk/WebCore

Test: fast/table/border-collapsing/rtl-border-collapsing.html

Reviewed by Darin.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::cellBefore): Renamed cellLeft to this. (WebCore::RenderTable::cellAfter): Renamed cellRight to this.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): Added the RTL case. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::borderLeft): (WebCore::RenderTableCell::borderRight): (WebCore::RenderTableCell::collectBorders): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
10:19 AM Changeset in webkit [12461] by darin
  • 1 edit
    10 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • fast/dom/Window/resources: Added.
  • fast/dom/Window/resources/destination.html: Added.
  • fast/dom/Window/window-open-parent-expected.txt: Added.
  • fast/dom/Window/window-open-parent-no-parent-expected.txt: Added.
  • fast/dom/Window/window-open-self-expected.txt: Added.
  • fast/dom/Window/window-open-top-expected.txt: Added.
10:18 AM Changeset in webkit [12460] by darin
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Roll out file that was checked in by accident.

10:15 AM Changeset in webkit [12459] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fix check for special frame names. These special frame names are supposed to always be unaffected by pop-up blocking. But the code instead was saying that the special frame names are always blocked. Oops!
10:11 AM Changeset in webkit [12458] by darin
  • 2 edits
    5 adds in trunk/LayoutTests
  • added a test for the names of range exceptions, which were wrong in my last commit until I made the fix Alexey suggested
  • fast/dom/Range: Added.
  • fast/dom/Range/range-exceptions.html: Added.
  • fast/dom/Range/resources: Added.
  • fast/dom/Range/resources/range-exceptions.js: Added.
  • fast/dom/Range/resources/TEMPLATE.html: Added.
  • fast/js/resources/js-test-pre.js: Escape & and < characters in the output so you can have tests with HTML fragments as expected results.
10:10 AM Changeset in webkit [12457] by darin
  • 2 edits in trunk/WebCore

Suggested by Alexey.

  • fixed something Alexey noticed in the new exception names

Test: fast/dom/Range/range-exceptions.html

  • khtml/ecma/kjs_binding.cpp: Added 0 to fix an off-by-one error for the names of the two DOM range exceptions.
7:11 AM Changeset in webkit [12456] by harrison
  • 1 edit
    8 adds in trunk/LayoutTests

Adding test cases for:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

  • editing/selection/move-by-line-002-expected.png: Added.
  • editing/selection/move-by-line-002-expected.checksum: Added.
  • editing/selection/move-by-line-002-expected.txt: Added.
  • editing/selection/move-by-line-002.html: Added.
  • editing/deleting/delete-listitem-002-expected.checksum: Added.
  • editing/deleting/delete-listitem-002-expected.png: Added.
  • editing/deleting/delete-listitem-002-expected.txt: Added.
  • editing/deleting/delete-listitem-002.html: Added.
7:06 AM Changeset in webkit [12455] by harrison
  • 4 edits in trunk/WebCore

Reviewed by John.

Fix two problems with editing around empty list items:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

Added tests:

  • selection/move-by-line-002.html
  • deleting/delete-listitem-002.html


  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • special check for empty list item because list marker assures non-zero height()


  • khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent):
  • fix check wrt BRs because text box is not required


  • rendering/bidi.cpp: (khtml::RenderBlock::constructLine):
  • make sure that br by itself in a list item gets a text-style box


(khtml::RenderBlock::findNextLineBreak):

  • make sure that br by itself in a list item gets a box at all
6:40 AM Changeset in webkit [12454] by eseidel
  • 78 edits in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt & darin.

There are a few small, but intertwined fixes in this patch:

Remaining fixes for SVGTetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6905

Fix for CDF support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

Updated test: svg/custom/simpleCDF.xml

Fix for filter updating:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6849

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6904

Also, as a side effect of 6849, fixed double-apply of filters, improving:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6713

Results updated for most tests, pixel results improved for filter tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFilter::filterBBoxForItemBBox): moved into baseclass
  • kcanvas/KCanvasFilters.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): use relativeBBox (RenderSVGImage::relativeBBox): added (RenderSVGImage::imageChanged): added (RenderSVGImage::getAbsoluteRepaintRect): fixed
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::imageChanged): added.
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): use new baseclass method (KCanvasFEFloodQuartz::getCIFilter): fixed.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout): update width/height (KCanvasItemQuartz::getAbsoluteRepaintRect): fixed. (KCanvasItemQuartz::requiresLayer): moved to .cpp (KCanvasItemQuartz::lineHeight): added. (KCanvasItemQuartz::baselinePosition): added.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::canHaveChildren): moved to .cpp (KCanvasContainerQuartz::requiresLayer): moved to .cpp (KCanvasContainerQuartz::lineHeight): added. (KCanvasContainerQuartz::baselinePosition): added. (KCanvasContainerQuartz::paint): fixed. (KCanvasContainerQuartz::viewportTransform): fixed. (KCanvasContainerQuartz::getAbsoluteRepaintRect): fixed. (KCanvasContainerQuartz::absoluteTransform): fixed.
  • rendering/render_object.cpp: (WebCore::RenderObject::absoluteTransform): fixed apply order.
3:19 AM Changeset in webkit [12453] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave Hyatt.

  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): Add unsigned overload
1:40 AM Changeset in webkit [12452] by eseidel
  • 4 edits
    4 adds in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

First set of fixes for SVG Tetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Tests:

  • bridge/mac/MacFrame.mm: (MacFrame::keyEvent): pass key events to things other than HTML
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::parseMappedAttribute): update viewport
1:09 AM Changeset in webkit [12451] by darin
  • 1 delete in trunk/LayoutTests/dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt

Somehow this file was missed in the last commit. Since it's just a delete, do it without a new ChangeLog entry.

12:57 AM Changeset in webkit [12450] by darin
  • 21 edits
    10 deletes in trunk/LayoutTests
  • dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
  • dom/xhtml/level3/core/canonicalform06-expected.txt:
  • dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
  • dom/xhtml/level3/core/infoset06-expected.txt:
  • dom/xhtml/level3/core/infoset07-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore05-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode17-expected.txt:
  • dom/xhtml/level3/core/noderemovechild04-expected.txt:
  • dom/xhtml/level3/core/noderemovechild05-expected.txt:
  • dom/xhtml/level3/core/nodereplacechild13-expected.txt:
  • dom/xhtml/level3/core/wellformed01-expected.txt:
  • dom/xhtml/level3/core/wellformed02-expected.txt:
  • dom/xhtml/level3/core/wellformed03-expected.txt:
  • dom/xhtml/level3/core/wellformed04-expected.txt:
  • for these, also changed the tests to be dumpAsText at the same time
  • fast/dom/outerText-no-element.html:
  • fast/dom/outerText-no-element-expected.txt:
  • fast/dynamic/outerHTML-no-element.html:
  • fast/dynamic/outerHTML-no-element-expected.txt:
  • fast/dom/outerText-no-element-expected.checksum: Removed.
  • fast/dom/outerText-no-element-expected.png: Removed.
  • fast/dynamic/outerHTML-no-element-expected.checksum: Removed.
  • fast/dynamic/outerHTML-no-element-expected.png: Removed.
  • removed test results for tests that are either disabled or not checked in
  • dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: Removed.
  • dom/xhtml/level3/core/documentadoptnode22-expected.txt: Removed.
  • editing/execCommand/boldCharacter-expected.txt: Removed.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
  • fast/parser/remove-block-in-residual-style-expected.png: Removed.
  • fast/parser/remove-block-in-residual-style-expected.txt: Removed.
  • fast/plugins: Removed.
  • fast/plugins/netscape-back-forward-expected.txt: Removed.
  • fast/plugins/resources: Removed.
  • fast/plugins/resources/go-back.html: Removed.
12:26 AM Changeset in webkit [12449] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix SVG layout tests crash due to Vector change.

  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): check isEmpty, return 0
12:04 AM Changeset in webkit [12448] by eseidel
  • 2 edits in trunk/WebCore

2006-01-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove bogus IntRect operator.

  • platform/FloatRect.h:

Jan 28, 2006:

11:45 PM Changeset in webkit [12447] by hyatt
  • 27 edits in trunk

WebCore:

Cleanup of RenderImage. Eliminate unneeded members and methods.

Reviewed by darin

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern):
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::attach):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::attach):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::compositeOperator):
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::attach):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/WebCoreImageRenderer.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged):
  • platform/Image.h: (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::Image::Image): (WebCore::Image::resetAnimation): (WebCore::Image::operator=): (WebCore::Image::stopAnimations): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::cachedImage): (WebCore::RenderImage::image): (WebCore::RenderImage::errorOccurred):
  • rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:

WebKit:

Clean up RenderImage, eliminating unneeded members and methods.


Reviewed by darin

  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer size]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
11:42 PM Changeset in webkit [12446] by darin
  • 2 edits
    3 adds in trunk/LayoutTests

Reviewed by John Sullivan.

  • fast/js/date-constructor.html: Added.
  • fast/js/date-constructor-expected.txt: Added.
  • fast/js/resources/date-constructor.js: Added.
  • fast/js/resources/date-big-constructor.js: Formatting tweak.
11:42 PM Changeset in webkit [12445] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
11:38 PM Changeset in webkit [12444] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/events/dispatch-to-handle-event.html: Added.
  • fast/events/dispatch-to-handle-event-expected.txt: Added.

WebCore:

Reviewed by Eric.

Test: fast/events/dispatch-to-handle-event.html

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Remove boolean that is always false, and correct the one place that was checking it to check the correct pointer instead.
10:52 PM Changeset in webkit [12443] by mjs
  • 9 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • remove QPtrStack, replace with Vector or traverseNextNode as appropriate
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): (KRenderingDevice::popContext): (KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]):
  • kwq/KWQPainter.mm: (WebCore::QPainter::save): (WebCore::QPainter::restore):
  • kwq/KWQPtrStack.h: Removed.
  • ForwardingHeaders/qptrstack.h: Removed.
  • ForwardingHeaders/q3ptrstack.h: Removed.
10:47 PM Changeset in webkit [12442] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • miscellaneous Vector improvements
  • kxmlcore/Vector.h: (KXMLCore::Vector::at): Add range-checking asserts. (KXMLCore::Vector::first): Added as a convenience. (KXMLCore::Vector::last): Convenience for stack-style use. (KXMLCore::Vector::removeLast): ditto
10:25 PM Changeset in webkit [12441] by mjs
  • 1 edit
    1 add
    2 deletes in trunk/WebCore
  • added missing forwarding header to fix build.


  • ForwardingHeaders/kxmlcore/Vector.h: Added.
9:26 PM Changeset in webkit [12440] by darin
  • 2 edits in trunk/WebCore
  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Removed extra parameter to fix the build.
9:23 PM Changeset in webkit [12439] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • converted KWQKURL to use Vector :bugzilla.opendarwin.org/show_bug.cgi?id=6900

Use Vector in place of Array, and in place of the custom stack
buffers with overflow.


  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::decode_string): (KURL::parse): (KURL::encode_string): (findHostnamesInMailToURL): (encodeHostnames):
8:30 PM Changeset in webkit [12438] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
8:18 PM Changeset in webkit [12437] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/create_hash_table: Added missing license.
8:17 PM Changeset in webkit [12436] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dump): Dump the image if it's not already there, even if the checksum is correct.
8:12 PM Changeset in webkit [12435] by mjs
  • 6 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Dave Hyatt.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/internal.cpp: (KJS::Parser::saveNewNode): Apply Vector. (KJS::clearNewNodes): ditto
  • kjs/number_object.cpp: (integer_part_noexp): ditto (char_sequence): ditto
  • kjs/ustring.cpp: (KJS::UString::UTF8String): ditto
  • kxmlcore/HashMap.h: (KXMLCore::deleteAllValues): Tweaked this to only apply to HashMap, other versions are useful for other containers.
  • kxmlcore/Vector.h: Added. Implemented a Vector class, which should be usable for all Array/QVector style purposes, and also as a stack buffer with oversize handling. Also some helper classes to make vector operations as efficient as possible for POD types and for simple non-PODs like RefPtr. (KXMLCore::): (KXMLCore::VectorTypeOperations::destruct): (KXMLCore::VectorTypeOperations::initialize): (KXMLCore::VectorTypeOperations::move): (KXMLCore::VectorTypeOperations::uninitializedCopy): (KXMLCore::VectorTypeOperations::uninitializedFill): (KXMLCore::VectorBuffer::VectorBuffer): (KXMLCore::VectorBuffer::~VectorBuffer): (KXMLCore::VectorBuffer::deallocateBuffer): (KXMLCore::VectorBuffer::inlineBuffer): (KXMLCore::Vector::Vector): (KXMLCore::Vector::~Vector): (KXMLCore::Vector::size): (KXMLCore::Vector::capacity): (KXMLCore::Vector::isEmpty): (KXMLCore::Vector::at): (KXMLCore::Vector::operator[]): (KXMLCore::Vector::data): (KXMLCore::Vector::operator T*): (KXMLCore::Vector::operator const T*): (KXMLCore::Vector::begin): (KXMLCore::Vector::end): (KXMLCore::Vector::clear): (KXMLCore::Vector::fill): (KXMLCore::Vector::operator=): (KXMLCore::::Vector): (KXMLCore::::operator): (KXMLCore::::fill): (KXMLCore::::expandCapacity): (KXMLCore::::resize): (KXMLCore::::reserveCapacity): (KXMLCore::::append): (KXMLCore::deleteAllValues):
  • kxmlcore/VectorTraits.h: Added. (KXMLCore::VectorTraits): Traits to enable making Vector efficient for simple types.
5:50 PM Changeset in webkit [12434] by hyatt
  • 6 edits in trunk/WebCore

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:50 PM Changeset in webkit [12433] by hyatt
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebImageRenderer.m

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:32 PM Changeset in webkit [12432] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/add-before-anonymous-child.html: Added.
  • fast/table/add-before-anonymous-child-expected.txt: Added.
  • fast/table/add-before-anonymous-child-expected.png: Added.
  • fast/table/add-before-anonymous-child-expected.checksum: Added.
5:29 PM Changeset in webkit [12431] by darin
  • 3 edits in trunk/WebCore

Test: fast/table/add-before-anonymous-child.html

Reviewed by Darin.

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): If beforeChild is inside an anonymous cell, insert into the cell.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed comment.
4:58 PM Changeset in webkit [12430] by hyatt
  • 3 edits in trunk/WebCore

Eliminate the mask() method on Image. It's unused.

  • platform/Image.h:
  • platform/mac/Image.mm:
4:16 PM Changeset in webkit [12429] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix Changelog typo.

4:15 PM Changeset in webkit [12428] by hyatt
  • 7 edits in trunk/WebCore

Clean up the Image class. Eliminate the MIME type memebr variable.
Eliminate an unused constructor. Fix the constructor to take
a QString rather than an NSString so that it's portable. Rename
the receivedData method to decode. Move canRenderImageType into
the Image class as a static method.

Reviewed by mjs

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::isImageType):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQResponseMIMEType):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::supportsType): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::decode): (WebCore::Image::operator=):
2:18 AM Changeset in webkit [12427] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-28 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

SourceAlpha does not display until window is redrawn (resized)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6375

Test: svg/custom/filter-source-alpha.svg

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::inputImage):`
12:53 AM Changeset in webkit [12426] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fallback to kCFStringEncodingWindowsLatin1 if the passed buffer is not valid UTF-8, preventing crashes.
12:52 AM Changeset in webkit [12425] by hyatt
  • 13 edits
    2 deletes in trunk/WebCore

Fix CachedImage.h/.cpp up. Lots of cleanup. Eliminated
unused code and cleaned up method and member names.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::deref): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::decodedRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::clear): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify):
  • loader/CachedImage.h: (WebCore::CachedImage::isDecoded): (WebCore::CachedImage::isErrorImage): (WebCore::CachedImage::schedule): (WebCore::CachedImage::isImage):
  • loader/CachedImageCallback.cpp: Removed.
  • loader/CachedImageCallback.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::receivedData):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::setImage):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):

Jan 27, 2006:

7:26 PM Changeset in webkit [12424] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • ForwardingHeaders/JSLock.h: added
  • page/Page.cpp: (Page::~Page): In debug mode, when destroying the last page, 0 out m_mainFrame to destroy the very last frame and then garbage collect, so a GC happens at a time when the stack won't have references into the JS heap for the conservative GC to catch.
7:07 PM Changeset in webkit [12423] by mjs
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Eric.

  • ForwardingHeaders/kjs/JSLock.h: Added.
  • bridge/mac/MacFrame.mm: (Plugin::Plugin): renamed from KWQPluginPart, make it able to store a view. (Plugin::view): And return the QWidget* view. (MacFrame::createPart): Use Plugin instead of KWQPluginPart, avoid setWidget. (MacFrame::setView): Don't use m_url directly so much, and use through d-> if needed. (MacFrame::userAgent): ditto (MacFrame::openURLFromPageCache): ditto
  • kwq/KWQObject.cpp: (QObject::inherits): Removed case for ObjectContents, which is not long for this world.
  • kwq/KWQObject.h:
  • page/Frame.cpp: (Frame::init): Don't pass parent() to FramePrivate, we can't possibly have one yet. (Frame::restoreURL): d->m_url, not m_url (Frame::didOpenURL): ditto (Frame::executeScript): ditto (Frame::receivedFirstData): ditto (Frame::begin): ditto (Frame::gotoAnchor): ditto (Frame::requestObject): ditto, plus only use Frame methods when we really have a Frame. (Frame::processObjectRequest): ditto, also get view() not widget(). (Frame::childFrame): remove excess spaces and pointless assert. (Frame::parentFrame): just call parent() (could probably remove this). (Frame::reparseConfiguration): d->m_url not m_url (Frame::canCachePage): ditto (Frame::updatePolicyBaseURL): ditto (Frame::scrollToAnchor): ditto (Frame::setName): set in FramePrivate (Frame::name): get from FramePrivate (Frame::setParent): similarly (Frame::parent): similarly (Frame::url): similarly
  • page/Frame.h:
  • page/FramePrivate.h: (FramePrivate::FramePrivate): Added m_parent, m_name and m_url.
  • page/FrameView.cpp: (FrameView::viewportMousePressEvent): Call frame directly instead of sending through QApplication. (FrameView::viewportMouseDoubleClickEvent): ditto (FrameView::viewportMouseMoveEvent): ditto (FrameView::viewportMouseReleaseEvent): ditto
  • page/ObjectContents.h: (ObjectContents::ObjectContents): Removed url, setParent, parent, name, setName, openURL, closeURL, widget, setWidget, event and customEvent methods, and corresponding fields. Add pure virtual view() method.
5:19 PM Changeset in webkit [12422] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adele.

  • fast/events/related-target-expected.txt: Added.
  • fast/events/related-target.html: Added.
5:18 PM Changeset in webkit [12421] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

Test: fast/events/related-target.html

  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Added a relatedTarget parameter to a couple overloads.
  • page/FrameView.cpp: (FrameView::viewportMouseMoveEvent): Moved code to set prevMouseX/Y out of here and into dispatchMouseEvent, because it now handles mouseout and mouseover events, and that's what these globals are used for. This fixes DumpRenderTree to work properly with mouseout and mouseover (because it delivers only mouse down and up, no mouse move events). (FrameView::dispatchMouseEvent): Passed in the "other" node as the related target for mouseout and mouseover events. Also set prevMouseX/Y.
5:05 PM Changeset in webkit [12420] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: make new tests use absolute urls
3:41 PM Changeset in webkit [12419] by adele
  • 2 edits
    4 adds in trunk

LayoutTests:

Adding test for
<rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com

  • fast/forms/input-no-renderer-expected.checksum: Added.
  • fast/forms/input-no-renderer-expected.png: Added.
  • fast/forms/input-no-renderer-expected.txt: Added.
  • fast/forms/input-no-renderer.html: Added.

WebCore:

Adding comment for added layout test.

3:06 PM Changeset in webkit [12418] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog to mention layout tests landed with previous commits.

2:39 PM Changeset in webkit [12417] by adele
  • 1 edit in trunk/WebCore/ChangeLog

Updating ChangeLog with explanation of missing test case.

1:18 PM Changeset in webkit [12416] by tomernic
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog to explain why my last commit did not include a test case.

2:52 AM Changeset in webkit [12415] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

make run-webkit-tests output total leaks count

  • Scripts/run-webkit-tests:
2:22 AM Changeset in webkit [12414] by hyatt
  • 76 edits
    2 moves
    7 deletes in trunk/WebCore

Fix for 6867. Rename QPixmap to Image and move it to platform/.
Eliminate QPaintDevice and QPaintDeviceMetrics completely, since
they aren't necessary.

Reviewed by anders

  • ForwardingHeaders/q3paintdevicemetrics.h: Removed.
  • ForwardingHeaders/qpaintdevice.h: Removed.
  • ForwardingHeaders/qpaintdevicemetrics.h: Removed.
  • ForwardingHeaders/qpixmap.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::fileWrapperForElement):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge elementAtPoint:]):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLength): (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/css_valueimpl.h:
  • css/csshelper.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • css/cssstyleselector.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::image): (KCanvasFEImage::setImage):
  • kcanvas/KCanvasImage.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasImageQuartz::init):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::image):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::image):
  • khtml/misc/helper.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::~DocumentImpl): (WebCore::DocumentImpl::recalcStyle): (WebCore::DocumentImpl::attach): (WebCore::DocumentImpl::detach):
  • khtml/xml/DocumentImpl.h: (WebCore::DocumentImpl::printing): (WebCore::DocumentImpl::setPrinting):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): (WebCore::KSVGPainterFactory::strokePainter):
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::notifyFinished):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::image):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::SVGDocumentImpl):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::notifyFinished):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • kwq/KWQApplication.h:
  • kwq/KWQApplication.mm: (QDesktopWidget::screenDepth):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement):
  • kwq/KWQComboBox.mm:
  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor): (WebCore::QCursor::QCursor):
  • kwq/KWQKPartsEvent.h:
  • kwq/KWQObject.h:
  • kwq/KWQPaintDevice.h: Removed.
  • kwq/KWQPaintDeviceMetrics.h: Removed.
  • kwq/KWQPaintDeviceMetrics.mm: Removed.
  • kwq/KWQPainter.h: (WebCore::QPainter::printing):
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/KWQPixmap.h: Removed.
  • kwq/KWQPixmap.mm: Removed.
  • kwq/KWQPrinter.h: (QPrinter::QPrinter):
  • kwq/KWQWidget.h:
  • loader/Cache.cpp: (khtml::Cache::init): (khtml::Cache::clear): (khtml::Cache::requestImage): (khtml::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::tiled_image): (WebCore::CachedImage::image): (WebCore::CachedImage::image_size): (WebCore::CachedImage::do_notify): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedImageCallback.cpp: (WebCore::CachedImageCallback::notifyUpdate): (WebCore::CachedImageCallback::notifyFinished): (WebCore::CachedImageCallback::handleError):
  • loader/CachedObject.h: (WebCore::CachedObject::):
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::setImage):
  • loader/DocLoader.cpp: (khtml::DocLoader::setAutoloadImages): (khtml::DocLoader::setShowAnimations):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • page/Frame.cpp: (Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (selectCursor):
  • page/FrameView.h:
  • platform/Image.h: Added.
  • platform/mac/Image.mm: Added. (WebCore::Image::loadResource): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::imageRef): (WebCore::Image::resetAnimation): (WebCore::Image::setAnimationRect): (-[WebImageCallback initWithCallback:WebCore::]): (WebCore::Image::shouldUseThreadedDecoding): (WebCore::Image::receivedData): (WebCore::Image::mask): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::Image::resize): (WebCore::Image::operator=): (WebCore::Image::increaseUseCount): (WebCore::Image::decreaseUseCount): (WebCore::Image::stopAnimations): (WebCore::Image::flushRasterCache):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject):
  • rendering/RenderText.h:
  • rendering/font.cpp: (khtml::Font::update):
  • rendering/font.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (RenderFlow::paintLines):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::image): (WebCore::RenderImage::getImage):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::setImage): (RenderListMarker::calcMinMaxWidth):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
  • rendering/render_replaced.h:
  • rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setFontFromControlSize):
2:20 AM Changeset in webkit [12413] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

run-webkit-test --leaks crashes (malloc logging runs out of memory)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6869

  • Scripts/run-webkit-tests: fix --leaks to not crash
1:39 AM Changeset in webkit [12412] by andersca
  • 2 edits in trunk

Somehow these ChangeLog entries weren't committed

1:35 AM Changeset in webkit [12411] by darin
  • 3 edits in trunk/LayoutTests
  • fast/forms/radio-button-no-change-event.html: Updated to add a second radio button.
  • fast/forms/radio-button-no-change-event-expected.txt: Updated.
1:29 AM Changeset in webkit [12410] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Revised test: fast/forms/radio-button-no-change-event.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked): Don't send a change event for a radio button getting unchecked (matches Gecko at least).
12:10 AM Changeset in webkit [12409] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

run-webkit-tests should produce a self-contained results directory
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6864

  • Scripts/run-webkit-tests: copy failing items to results dir.

Jan 26, 2006:

10:55 PM Changeset in webkit [12408] by eseidel
  • 4 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Leak fixes in SVG code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6588

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (teardownShadingWithStyle): delete image and context when through. (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): zero out cached mask (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): destroy cached mask image. (KRenderingPaintServerLinearGradientQuartz::setup): delete mask before making new (KRenderingPaintServerRadialGradientQuartz::setup): delete mask before making new
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer): forgot "static" keyword
  • ksvg2/svg/SVGPolyElementImpl.cpp: (SVGPolyElementImpl::notifyAttributeChange): use RefPtr
10:05 PM Changeset in webkit [12407] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • various leaks on "fast" LayoutTests


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6824


It turns out these all had the same cause.


  • page/Frame.cpp: (Frame::clear): If we have a document, make sure to cancel parsing, in case it has a tokenizer and parser that are keeping it alive. Use cancelParsing to avoid possibly accidentally firing the onload handler.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen. (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
  • khtml/xml/DocumentImpl.h:
9:42 PM Changeset in webkit [12406] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Tim Omernick.


(This bug was fixed independently by Dave Harrison but I'm landing the test
case anyway.)

  • fast/lists/list-style-none-crash-expected.checksum: Added.
  • fast/lists/list-style-none-crash-expected.png: Added.
  • fast/lists/list-style-none-crash-expected.txt: Added.
  • fast/lists/list-style-none-crash.html: Added.
5:35 PM Changeset in webkit [12405] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Test case for <rdar://problem/4256504>
khtml::RenderBlock::skipWhitespace crashes upon interaction with
radio buttons

5:12 PM Changeset in webkit [12404] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4256504> khtml::RenderBlock::skipWhitespace
crashes upon interaction with radio buttons.

The old code held an assumption that positioned elements would
always have line boxes. This is not necessarily the case, so this
patch makes sure that the lines are dirtied appropriately.

3:56 PM Changeset in webkit [12403] by andersca
  • 1 edit
    2 adds in trunk

2006-01-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Test: fast/dom/HTMLImageElement/image-without-renderer-width.html

Reviewed and landed by Anders.


  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): Return the image's dimensions only if it isn't null, but even if it hasn't finished loading. (WebCore::HTMLImageElementImpl::height): Ditto.
3:32 PM Changeset in webkit [12402] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4422365>

  • WebView.subproj/WebHTMLView.m: (-[NSArray addSuperviewObservers]): In addition to registering for frame/bounds change notifications, call -_frameOrBoundsChanged. It will check the current size/scroll against the previous layout's size/scroll. We need to do this here to catch the case where the WebView is laid out at one size, removed from its window, resized, and inserted into another window. Our frame/bounds changed notifications will not be sent in that situation, since we only watch for changes while in the view hierarchy.

I have verified that this does not cause unnecessary layouts while running the PLT.

2:45 PM Changeset in webkit [12401] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt and Vicki.

Fix for broken layout tests.

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus):
2:00 PM Changeset in webkit [12400] by andersca
  • 10 edits
    3 adds
    2 deletes in trunk

2006-01-26 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.


This makes DocumentType and DOMImplementation autogenerated.


  • JSCore.cpp: Added.


  • WebCore.xcodeproj/project.pbxproj: Add JSCore.cpp


  • bindings/scripts/CodeGeneratorJS.pm: Add attributes for controlling how null values should be converted to and from DOMString objects.


  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm: Remove the extended attributes hash on attribute objects and use the one on the signature.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction): For isSupported, just convert the version argument to an empty string if null is passed in. The reason for this change is that the autogenerated binding for DOMImplementation::hasFeature does the same thing. This also makes us behave like Mozilla and Opera.


(KJS::toDocumentType):
(KJS::getDOMNode):
Use JSDocumentType.


(KJS::getDOMDOMImplementation):
Use JSDOMImplementation.


  • khtml/ecma/kjs_dom.h: Remove DOMDOMImplementation and DOMDocumentType


  • khtml/xml/DOMImplementation.idl: Added.
  • khtml/xml/DocumentType.idl: Added.
1:40 PM Changeset in webkit [12399] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-26 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

<text> elements with a scale on a parent <g> breaks nodeAtPoint
Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6843

  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint):
12:32 PM Changeset in webkit [12398] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Geoff.

There were three basic problems here, any one of which was enough
to cause the leak.


1) If the filter function for a NodeFilter, NodeIterator or TreeWalker
had that object in scope, it would cause a GC reference cycle. I fixed
this by making these JS functions get marked by the corresponding JS object,
as for XMLHttpRequest.


2) The TraversalImpl class that's a base class for NodeIteratorImpl and
TreeWalkerImpl did not have a virtual destructor, leading the Shared
template to call the base class destructor on deref.


3) ref/deref on the document were mismatched, I fixed all that sort of nonsense
by using RefPtr instead of manual ref/deref.


  • khtml/dom/dom2_traversal.h: (DOM::NodeFilterCondition::mark): Add no-op virtual mark method, JS subclass will do something useful here.
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::mark): Mark the DOM-level filter. (KJS::DOMNodeFilter::mark): ditto (KJS::DOMTreeWalker::mark): ditto (KJS::JSNodeFilterCondition::JSNodeFilterCondition): reformatted. (KJS::JSNodeFilterCondition::mark): Mark the filter function.
  • khtml/ecma/kjs_traversal.h:
  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeFilterImpl::NodeFilterImpl): diligently applied RefPtr (DOM::TraversalImpl::TraversalImpl): ditto (DOM::TraversalImpl::~TraversalImpl): ditto (DOM::NodeIteratorImpl::NodeIteratorImpl): ditto (DOM::NodeIteratorImpl::~NodeIteratorImpl): ditto (DOM::NodeIteratorImpl::setReferenceNode): ditto (DOM::TreeWalkerImpl::TreeWalkerImpl): ditto (DOM::TreeWalkerImpl::setCurrentNode): ditto
  • khtml/xml/dom2_traversalimpl.h: (DOM::NodeFilterImpl::mark): call mark() on the codition (DOM::TraversalImpl::root): Use .get() (DOM::TraversalImpl::filter): ditto (DOM::NodeIteratorImpl::referenceNode): ditto (DOM::NodeIteratorImpl::document): ditto (DOM::TreeWalkerImpl::currentNode): ditto
12:18 PM Changeset in webkit [12397] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQPageState.mm: (-[KWQPageState clear]): Garbage collect after deleting a bunch of stuff that holds onto JS objects. This should avoid false positive leaks and is good in any case since page state deallocation is already deferred.
10:46 AM Changeset in webkit [12396] by adele
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fix for <rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus): Nil check for renderer.
8:59 AM Changeset in webkit [12395] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Adding test case for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6835

  • editing/deleting/delete-listitem-001-expected.checksum: Added.
  • editing/deleting/delete-listitem-001-expected.png: Added.
  • editing/deleting/delete-listitem-001-expected.txt: Added.
  • editing/deleting/delete-listitem-001.html: Added.
8:58 AM Changeset in webkit [12394] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Test added:
editing/deleting/delete-listitem-001.html


  • rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::resetMarkerValue): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
4:06 AM Changeset in webkit [12393] by ap
  • 3 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin, landed by ap.


  • manual-tests/bugzilla-6388.html: Added.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::computeRepaintRects): Cache the object's absolute position before update. (WebCore::RenderLayer::updateLayerPositions): Use the cached position to determine if the object moved. If it did, do a full repaint.
  • rendering/render_layer.h:
3:32 AM Changeset in webkit [12392] by eseidel
  • 2 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Adding additional test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

  • svg/custom/percentage-rect2-expected.checksum: Added.
  • svg/custom/percentage-rect2-expected.png: Added.
  • svg/custom/percentage-rect2-expected.txt: Added.
  • svg/custom/percentage-rect2.svg: Added.
3:11 AM Changeset in webkit [12391] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-26 Eric Seidel <​eseidel@apple.com>

Adding additional test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

  • svg/custom/percentage-rect2-expected.checksum: Added.
  • svg/custom/percentage-rect2-expected.png: Added.
  • svg/custom/percentage-rect2-expected.txt: Added.
  • svg/custom/percentage-rect2.svg: Added.
2:57 AM Changeset in webkit [12390] by ap
  • 2 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin, committed by ap.


  • manual-tests/bugzilla-6278.html: Added.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): If during layout a cell changes from not needing layout to needing layout, call repaintObjectsBeforeLayout on it.
2:53 AM Changeset in webkit [12389] by eseidel
  • 9 edits
    4 adds in trunk

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

SVG shows up blank in WebKit+SVG
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6620

  • css/svg.css: default to width/height 100% for <svg>
1:53 AM Changeset in webkit [12388] by andersca
  • 1 edit in trunk/WebCore/khtml/xml/WheelEvent.idl

Force this to be re-generated

1:43 AM Changeset in webkit [12387] by andersca
  • 9 edits
    1 add in trunk/WebCore

2006-01-26 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6805
Support constants in IDL files

  • bindings/scripts/CodeGeneratorJS.pm: If an interface has constants, generate a constructor object and add the constants as properties. Also add a getConstructor method to the interface object.


  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/generate-bindings.pl: Add a --force-generation flag to force regeneration of files even though nothing has changed.


  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_events.h: Remove MutationEventConstructor and DOMMutationEvent, those are autogenerated now.


  • bindings/js/JSEvents.cpp: Include JSMutationEvent.cpp
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/ecma/kjs_window.h: (KJS::Window::): Add MutationEvent property.


  • khtml/xml/MutationEvent.idl: Added.
1:32 AM Changeset in webkit [12386] by eseidel
  • 34 edits
    4 adds in trunk

2006-01-25 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Percentage values for width, height are not rendered correctly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5331

Create items for even empty paths to prevent an empty render tree.
Calculate the viewport element on the fly rather than caching it,
unless there is no context from which to calculate it. Call
notifyAttributeChange() on layout to fix usage of viewport
percentages for lengths. Remove portion of code which appears to
do nothing but worsen the situation.

  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer):
1:23 AM Changeset in webkit [12385] by eseidel
  • 2 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Disable <animateTransform> to stop layout test crashes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6780

  • ksvg2/misc/KSVGTimeScheduler.cpp: hack out animateTransform.
12:37 AM Changeset in webkit [12384] by eseidel
  • 16 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Deploy RefPtr throughout more of WebCore
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

  • bridge/mac/MacFrame.mm: (MacFrame::shouldClose): no need to call .get()
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::remove):
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::HTMLBodyElementImpl): (WebCore::HTMLBodyElementImpl::~HTMLBodyElementImpl): (WebCore::HTMLBodyElementImpl::createLinkDecl): (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::HTMLLinkElementImpl): (WebCore::HTMLLinkElementImpl::~HTMLLinkElementImpl): (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading): (WebCore::HTMLStyleElementImpl::HTMLStyleElementImpl): (WebCore::HTMLStyleElementImpl::childrenChanged): (WebCore::HTMLStyleElementImpl::isLoading):
  • khtml/html/html_headimpl.h: (DOM::HTMLLinkElementImpl::sheet): (DOM::HTMLStyleElementImpl::sheet):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::parseMappedAttribute): (WebCore::HTMLTableSectionElementImpl::insertRow): (WebCore::HTMLTableSectionElementImpl::deleteRow): (WebCore::HTMLTableRowElementImpl::deleteCell):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent): (WebCore::NodeImpl::dispatchMouseEvent): (WebCore::NodeImpl::dispatchKeyEvent): (WebCore::NodeImpl::createRendererIfNeeded):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeImpl::clone): (WebCore::StyledElementImpl::StyledElementImpl): (WebCore::StyledElementImpl::createInlineStyleDecl): (WebCore::StyledElementImpl::destroyInlineStyleDecl): (WebCore::StyledElementImpl::getInlineStyleDecl):
  • khtml/xml/dom_elementimpl.h: (DOM::MappedAttributeImpl::MappedAttributeImpl): (DOM::MappedAttributeImpl::style): (DOM::MappedAttributeImpl::decl): (DOM::MappedAttributeImpl::setDecl): (DOM::StyledElementImpl::inlineStyleDecl):
  • khtml/xml/dom_position.cpp: (DOM::Position::Position): (DOM::Position::clear):
  • khtml/xml/dom_position.h: (DOM::Position::node):
Note: See TracTimeline for information about the timeline view.