Timeline



Feb 28, 2006:

11:49 PM Changeset in webkit [13067] by darin
  • 106 edits
    2 copies
    2 moves
    1 delete in trunk/WebCore

Reviewed by Eric.

  • platform/GraphicsContext.h: Added.
  • platform/TextDirection.h: Added.
  • platform/cg/GraphicsContextCG.cpp: Added.
  • platform/mac/GraphicsContextMac.mm: Added.
  • kwq/KWQPainter.h: Removed.
  • kwq/KWQPainter.mm: Removed.
  • ForwardingHeaders/qpainter.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for moved files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for moved files.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::setDisplaysWithFocusAttributes):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • editing/SelectionController.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::Context2D::putValueProperty): (KJS::drawPattern):
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::paint): (WebCore::Frame::adjustPageHeight):
  • page/FrameView.h:
  • platform/Font.h:
  • platform/Font.cpp: (WebCore::Font::selectionRectForText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawText):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
  • rendering/InlineTextBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintAllMarkersOfType): (WebCore::InlineTextBox::paintMarkedTextUnderline): (WebCore::InlineTextBox::offsetForPosition):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox): (WebCore::RenderTableCell::paintCollapsedBorder): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/RenderTableCell.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_box.h:
  • rendering/render_button.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::paintObject):
  • rendering/render_button.h: (WebCore::RenderButton::removeLeftoverAnonymousBoxes):
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::addFocusRingRects): (WebCore::RenderFlow::paintFocusRing): (WebCore::RenderFlow::paintOutlines): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/render_flow.h:
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setStyle): (WebCore::RenderFieldset::paintBorderMinusLegend): (WebCore::RenderSelect::setWidgetWritingDirection): (WebCore::RenderTextArea::setStyle):
  • rendering/render_form.h: (WebCore::RenderFieldset::renderName):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintScrollbars): (WebCore::RenderLayer::paint): (WebCore::setClip): (WebCore::restoreClip): (WebCore::RenderLayer::paintLayer): (WebCore::Marquee::direction):
  • rendering/render_layer.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_line.h:
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::addFocusRingRects): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::selectionColor):
  • rendering/render_object.h: (WebCore::RenderObject::element): (WebCore::RenderObject::document): (WebCore::RenderObject::setNode): (WebCore::RenderObject::node): (WebCore::RenderObject::PaintInfo::PaintInfo): (WebCore::RenderObject::paintBoxDecorations): (WebCore::RenderObject::paintBackgroundExtended): (WebCore::RenderObject::printBoxDecorations):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionColor):
  • rendering/render_replaced.h: Updated to use GraphicsContext instead of QPainter.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setWritingDirection):
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (QLineEdit::setWritingDirection):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::setWritingDirection):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setWritingDirection):
  • rendering/bidi.cpp: (khtml::bidiNext): (khtml::bidiFirst): Updated to use TextDirection instead of QPainter::TextDirection and EDirection.
  • kcanvas/device/KRenderingDevice.h: Added renderingDevice here to replace QPainter::renderingDevice for now.
  • khtml/ecma/kjs_html.h: Fixed comments to mention GraphicsContext.
  • khtml/html/html_imageimpl.h:
  • page/FrameView.cpp:
  • rendering/RenderBlock.cpp: Added include needed since I reduced includes elsewhere.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::checkSelectionPoint): Changed QChar* to be const QChar*.
  • platform/FontDescription.h: Added include that was missing.
  • rendering/render_theme.cpp: Ditto.
  • platform/Image.h: Removed unnecessary forward declaration of QPainter.
  • rendering/RenderText.h: Clean up types, use const.
  • rendering/render_style.h: Removed EDirection and replaced it with TextDirection.
  • kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle): (WebCore::KCanvasCreator::createRectangle): (WebCore::KCanvasCreator::createEllipse): (WebCore::KCanvasCreator::createLine):
  • kcanvas/KCanvasPath.cpp: (WebCore::operator<<):
  • kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::paint):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::translateForAttributes):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::prepareFilter): (WebCore::KCanvasFilterQuartz::applyFilter):
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm: (WebCore::KCanvasMaskerQuartz::applyMask):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (WebCore::KCanvasContainerQuartz::paint): (WebCore::KCanvasClipperQuartz::applyClip):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceQuartz::pushContext): (WebCore::KRenderingDeviceQuartz::popContext): (WebCore::renderingDevice):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer):
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::createRenderer):
  • ksvg2/svg/SVGClipPathElementImpl.cpp: (SVGClipPathElementImpl::canvasResource):
  • ksvg2/svg/SVGFEBlendElementImpl.cpp: (SVGFEBlendElementImpl::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp: (SVGFEColorMatrixElementImpl::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp: (SVGFEComponentTransferElementImpl::filterEffect):
  • ksvg2/svg/SVGFECompositeElementImpl.cpp: (SVGFECompositeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp: (WebCore::SVGFEDiffuseLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp: (SVGFEDisplacementMapElementImpl::filterEffect):
  • ksvg2/svg/SVGFEFloodElementImpl.cpp: (SVGFEFloodElementImpl::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp: (SVGFEGaussianBlurElementImpl::filterEffect):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::filterEffect):
  • ksvg2/svg/SVGFEMergeElementImpl.cpp: (SVGFEMergeElementImpl::filterEffect):
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp: (SVGFEOffsetElementImpl::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp: (SVGFESpecularLightingElementImpl::filterEffect):
  • ksvg2/svg/SVGFETileElementImpl.cpp: (SVGFETileElementImpl::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp: (SVGFETurbulenceElementImpl::filterEffect):
  • ksvg2/svg/SVGFilterElementImpl.cpp: (SVGFilterElementImpl::canvasResource):
  • ksvg2/svg/SVGGElementImpl.cpp: (SVGGElementImpl::createRenderer):
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::canvasResource):
  • ksvg2/svg/SVGMarkerElementImpl.cpp: (WebCore::SVGMarkerElementImpl::canvasResource): (WebCore::SVGMarkerElementImpl::createRenderer):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (WebCore::SVGMaskElementImpl::drawMaskerContent): (WebCore::SVGMaskElementImpl::createRenderer): (WebCore::SVGMaskElementImpl::canvasResource):
  • ksvg2/svg/SVGPathElementImpl.cpp: (WebCore::SVGPathElementImpl::toPathData):
  • ksvg2/svg/SVGPatternElementImpl.cpp: (WebCore::SVGPatternElementImpl::drawPatternContentIntoTile): (WebCore::SVGPatternElementImpl::createRenderer): (WebCore::SVGPatternElementImpl::canvasResource):
  • ksvg2/svg/SVGPolygonElementImpl.cpp: (SVGPolygonElementImpl::toPathData):
  • ksvg2/svg/SVGPolylineElementImpl.cpp: (SVGPolylineElementImpl::toPathData):
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::createRenderer):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (WebCore::SVGStyledElementImpl::createRenderer):
  • ksvg2/svg/SVGSwitchElementImpl.cpp: (SVGSwitchElementImpl::createRenderer):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::createRenderer): Updated to use renderingDevice instead of QPainter::renderingDevice.
11:19 PM Changeset in webkit [13066] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Fixed <rdar://problem/4448098> Switch PropertyMap deleted entry placeholder to -1 from UString::Rep::null

This turned out to be only a small speedup (.12%). That's within the
margin of error for super accurate JS iBench, but Shark confirms the
same, so I think it's worth landing.

FYI, I also confirmed that the single entry optimization in
PropertyMap is a 3.2% speedup.

  • kjs/property_map.cpp: (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::addSparseArrayPropertiesToReferenceList): (KJS::PropertyMap::checkConsistency):
  • kjs/property_map.h: (KJS::PropertyMap::deletedSentinel):
10:37 PM Changeset in webkit [13065] by darin
  • 2 edits in trunk/WebCore
  • fixed part of the reason the build is broken
  • WebCore.xcodeproj/project.pbxproj: Updated project file.
10:23 PM Changeset in webkit [13064] by darin
  • 2 edits
    37 moves in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved the WebCoreXXX files from kwq to appropriate directories

No changes to the contents of the files.

  • WebCore.xcodeproj/project.pbxproj: Updated project file.
  • bridge/mac/WebCoreCache.h: Added.
  • bridge/mac/WebCoreCache.mm: Added.
  • bridge/mac/WebCoreEncodings.h: Added.
  • bridge/mac/WebCoreEncodings.mm: Added.
  • bridge/mac/WebCoreFrameNamespaces.h: Added.
  • bridge/mac/WebCoreFrameNamespaces.m: Added.
  • bridge/mac/WebCoreFrameView.h: Added.
  • bridge/mac/WebCoreJavaScript.h: Added.
  • bridge/mac/WebCoreJavaScript.mm: Added.
  • bridge/mac/WebCoreKeyboardAccess.h: Added.
  • bridge/mac/WebCoreResourceLoader.h: Added.
  • bridge/mac/WebCoreScriptDebugger.h: Added.
  • bridge/mac/WebCoreScriptDebugger.mm: Added.
  • bridge/mac/WebCoreSettings.h: Added.
  • bridge/mac/WebCoreSettings.mm: Added.
  • bridge/mac/WebCoreTextDecoder.h: Added.
  • bridge/mac/WebCoreTextDecoder.mm: Added.
  • bridge/mac/WebCoreViewFactory.h: Added.
  • bridge/mac/WebCoreViewFactory.m: Added.
  • bridge/mac/WebDashboardRegion.h: Added.
  • bridge/mac/WebDashboardRegion.m: Added.
  • kwq/WebCoreCache.h: Removed.
  • kwq/WebCoreCache.mm: Removed.
  • kwq/WebCoreCookieAdapter.h: Removed.
  • kwq/WebCoreCookieAdapter.m: Removed.
  • kwq/WebCoreEncodings.h: Removed.
  • kwq/WebCoreEncodings.mm: Removed.
  • kwq/WebCoreFrameNamespaces.h: Removed.
  • kwq/WebCoreFrameNamespaces.m: Removed.
  • kwq/WebCoreFrameView.h: Removed.
  • kwq/WebCoreGraphicsBridge.h: Removed.
  • kwq/WebCoreGraphicsBridge.m: Removed.
  • kwq/WebCoreHistory.h: Removed.
  • kwq/WebCoreHistory.m: Removed.
  • kwq/WebCoreImageRenderer.h: Removed.
  • kwq/WebCoreImageRendererFactory.h: Removed.
  • kwq/WebCoreImageRendererFactory.m: Removed.
  • kwq/WebCoreJavaScript.h: Removed.
  • kwq/WebCoreJavaScript.mm: Removed.
  • kwq/WebCoreKeyGenerator.h: Removed.
  • kwq/WebCoreKeyGenerator.m: Removed.
  • kwq/WebCoreKeyboardAccess.h: Removed.
  • kwq/WebCoreResourceLoader.h: Removed.
  • kwq/WebCoreScriptDebugger.h: Removed.
  • kwq/WebCoreScriptDebugger.mm: Removed.
  • kwq/WebCoreSettings.h: Removed.
  • kwq/WebCoreSettings.mm: Removed.
  • kwq/WebCoreTextDecoder.h: Removed.
  • kwq/WebCoreTextDecoder.mm: Removed.
  • kwq/WebCoreTextRenderer.h: Removed.
  • kwq/WebCoreTextRendererFactory.h: Removed.
  • kwq/WebCoreTextRendererFactory.mm: Removed.
  • kwq/WebCoreView.h: Removed.
  • kwq/WebCoreView.m: Removed.
  • kwq/WebCoreViewFactory.h: Removed.
  • kwq/WebCoreViewFactory.m: Removed.
  • kwq/WebDashboardRegion.h: Removed.
  • kwq/WebDashboardRegion.m: Removed.
  • platform/mac/WebCoreCookieAdapter.h: Added.
  • platform/mac/WebCoreCookieAdapter.m: Added.
  • platform/mac/WebCoreGraphicsBridge.h: Added.
  • platform/mac/WebCoreGraphicsBridge.m: Added.
  • platform/mac/WebCoreHistory.h: Added.
  • platform/mac/WebCoreHistory.m: Added.
  • platform/mac/WebCoreImageRenderer.h: Added.
  • platform/mac/WebCoreImageRendererFactory.h: Added.
  • platform/mac/WebCoreImageRendererFactory.m: Added.
  • platform/mac/WebCoreKeyGenerator.h: Added.
  • platform/mac/WebCoreKeyGenerator.m: Added.
  • platform/mac/WebCoreTextRenderer.h: Added.
  • platform/mac/WebCoreTextRendererFactory.h: Added.
  • platform/mac/WebCoreTextRendererFactory.mm: Added.
  • platform/mac/WebCoreView.h: Added.
  • platform/mac/WebCoreView.m: Added.
10:16 PM Changeset in webkit [13063] by hyatt
  • 46 edits
    3 deletes in trunk/WebCore

Fold QFont into Font and eliminate QFont completely.

Reviewed by eric

  • ForwardingHeaders/qfont.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • kwq/KWQComboBox.h:
  • kwq/KWQComboBox.mm: (QComboBox::setFont):
  • kwq/KWQFont.h: Removed.
  • kwq/KWQFont.mm: Removed.
  • kwq/KWQFontMetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetricsPrivate::QFontMetricsPrivate): (QFontMetricsPrivate::~QFontMetricsPrivate): (QFontMetricsPrivate::getRenderer): (QFontMetricsPrivate::fontDescription): (QFontMetricsPrivate::setFontDescription): (QFontMetricsPrivate::getWebCoreFont): (QFontMetricsPrivate::isFixedPitch): (QFontMetricsPrivate::determinePitch): (QFontMetrics::QFontMetrics): (QFontMetrics::setFontDescription): (QFontMetrics::width): (QFontMetrics::floatWidth): (QFontMetrics::selectionRectForText): (QFontMetrics::checkSelectionPoint): (QFontMetrics::getWebCoreFont): (QFontMetrics::isFixedPitch):
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQLineEdit.mm: (-[NSSearchField _addStringToRecentSearches:]): (QLineEdit::setFont):
  • kwq/KWQListBox.h:
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): (QListBox::setFont): (-[KWQTableView drawRow:clipRect:]):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::font): (WebCore::QPainter::setFont): (WebCore::QPainter::fontMetrics): (WebCore::QPainter::_updateRenderer): (WebCore::QPainter::drawText): (WebCore::QPainter::drawHighlightForText):
  • kwq/KWQSlider.h:
  • kwq/KWQSlider.mm: (QSlider::setFont):
  • kwq/KWQTextEdit.h:
  • kwq/KWQTextEdit.mm: (QTextEdit::setFont):
  • platform/Font.cpp: (khtml::Font::update):
  • platform/Font.h: (WebCore::): (WebCore::Font::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::operator!=): (WebCore::Font::fontMetrics): (WebCore::Font::pixelSize): (WebCore::Font::size): (WebCore::Font::letterSpacing): (WebCore::Font::setWordSpacing): (WebCore::Font::setLetterSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::isPrinterFont): (WebCore::Font::firstFamily): (WebCore::Font::family): (WebCore::Font::italic): (WebCore::Font::weight): (WebCore::Font::getNSFamily): (WebCore::Font::getNSFont): (WebCore::Font::getWebCoreFont):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription):
  • platform/FontFamily.h:
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::font): (WebCore::Widget::setFont):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace):
  • rendering/RenderText.cpp: (WebCore::RenderText::cacheWidths): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::font): (WebCore::RenderText::width):
  • rendering/RenderText.h:
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::findNextLineBreak):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::fontSize): (khtml::RenderStyle::fontMetrics): (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
9:31 PM Changeset in webkit [13062] by darin
  • 9 edits
    2 deletes in trunk

WebCore:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebCore.exp: Remove WebCoreScrollView class name.
  • kwq/WebCoreScrollView.h: Removed.
  • kwq/WebCoreScrollView.m: Removed.
  • WebCore.xcodeproj/project.pbxproj: Remove WebCoreScrollView source files.
  • kwq/KWQListBox.mm: (-[KWQListBoxScrollView autoforwardsScrollWheelEvents]): Added.
  • kwq/KWQTextArea.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView autoforwardsScrollWheelEvents]): Ditto.

WebKit:

Reviewed by Adele.

  • remove obsolete WebCoreScrollView class
  • WebView/WebDynamicScrollBarsView.h: Change base class to NSScrollView instead of WebCoreScrollView.
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView autoforwardsScrollWheelEvents]): Added.
6:54 PM Changeset in webkit [13061] by justing
  • 1 edit in trunk/LayoutTests/editing/editing.js

Forgot to check in my changes to editing.js

5:14 PM Changeset in webkit [13060] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): add ability to dump render tree and read from a local file.
5:14 PM Changeset in webkit [13059] by eseidel
  • 6 edits in trunk/WebCore

2006-02-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix spacing/style on several of the stubs.
Reorganize stubs, separating empty stubs.
Remove the abort from certain stubs blocking DRT.
Add a virtual setView call to Frame baseclass.

  • bridge/mac/MacFrame.h: mark setView virtual
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): remove no-renderer hack
  • page/Frame.cpp: (WebCore::Frame::view): fix spacing (WebCore::Frame::setView): added.
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (notImplemented): make break directly into debugger. Moved, modified several other stubs not mentioned here.
1:00 PM Changeset in webkit [13058] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by mjs


Tests for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/editing.js:
  • editing/execCommand/insertHTML-expected.checksum: Added.
  • editing/execCommand/insertHTML-expected.png: Added.
  • editing/execCommand/insertHTML-expected.txt: Added.
  • editing/execCommand/insertHTML.html: Added.

WebCore:

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6647>
TinyMCE: document.execCommand("insertHTML", ...) unimplemented

  • editing/jsediting.cpp:
11:22 AM Changeset in webkit [13057] by mjs
  • 12 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.h: Added.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): Initialize browser extension and settings.
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::attach): Don't create renderers for now.
  • dom/EventNames.cpp: (WebCore::EventNames::init): use placement new even when not avoiding static constructors.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): ditto
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): ditto
  • dom/QualifiedName.h: (WebCore::QualifiedName::QualifiedName): Added default constructor but only in ifdef.
  • page/Frame.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init): use placement new even when not avoiding static constructors
  • platform/StaticConstructors.h: don't initialize when not avoiding static constructors, just default construct and let initialization happen normally
  • platform/win/TemporaryLinkStubs.cpp: Stub out some more things (Cursor::~Cursor): (QFont::~QFont): (QFontMetrics::~QFontMetrics): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::createEmptyDocument): (WebCore::BrowserExtensionWin::getHistoryLength): (WebCore::BrowserExtensionWin::canRunModal): (WebCore::BrowserExtensionWin::openURLNotify): (WebCore::BrowserExtensionWin::canRunModalNow): (WebCore::BrowserExtensionWin::runModal): (WebCore::BrowserExtensionWin::goBackOrForward):
10:57 AM Changeset in webkit [13056] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h: Removed WKMouseIsDown()
  • libWebKitSystemInterface.a: ditto
10:48 AM Changeset in webkit [13055] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Eric Seidel


Wean WebKit from one more SPI call. We learned about this new-to-Tiger
API from filing Radar 4433222.

  • WebView/WebHTMLView.m: (-[WebHTMLView _autoscroll]): use public CGEventSourceButtonState() instead of WKMouseIsDown() (which was using SPI internally)
12:30 AM Changeset in webkit [13054] by eseidel
  • 121 edits in trunk

Fix line endings in two files, and apply svn:eol-style=native to all source files w/o it.

12:02 AM Changeset in webkit [13053] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove abort() from constructors to allow DRT to run.

  • platform/win/TemporaryLinkStubs.cpp: (QFont::QFont): (QFontMetrics::QFontMetrics):

Feb 27, 2006:

11:56 PM Changeset in webkit [13052] by eseidel
  • 1 edit in trunk/WebKitLibraries

Add svn:ignore property to ignore zip files

11:52 PM Changeset in webkit [13051] by justing
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped

  • fast/forms/textarea-hard-linewrap-expected.txt: Added.
  • fast/forms/textarea-hard-linewrap.html: Added.
  • fast/forms/textarea-setvalue-submit-expected.txt: Added.
  • fast/forms/textarea-setvalue-submit.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6893>
REGRESSION: Major bug with TinyMCE, no value submitted from textarea
<rdar://problem/3465857> value from textarea form field inside of hidden div isn't submitted
<rdar://problem/3968059> Textarea with hard-wrap: pre-filled text doesn't get hard-wrapped


Canonicalize line endings in textareas to avoid the workarounds that were a source of bugs,
Also call textWithHardLineWraps inside appendFormData (and nowhere else) if wrap="hard".

  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::HTMLTextAreaElementImpl): (WebCore::HTMLTextAreaElementImpl::select): (WebCore::HTMLTextAreaElementImpl::appendFormData): (WebCore::HTMLTextAreaElementImpl::rendererWillBeDestroyed): (WebCore::HTMLTextAreaElementImpl::updateValue): (WebCore::HTMLTextAreaElementImpl::value): (WebCore::HTMLTextAreaElementImpl::setValue): (WebCore::HTMLTextAreaElementImpl::defaultValue):
  • khtml/html/HTMLTextAreaElementImpl.h: (DOM::HTMLTextAreaElementImpl::invalidateValue):
  • kwq/KWQTextArea.h:
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView textDidChange:]): (-[KWQTextAreaTextView text]): (-[KWQTextAreaTextView textWithHardLineBreaks]): (-[KWQTextAreaTextView setSelectedRange:]): (-[KWQTextAreaTextView selectedRange]): (-[KWQTextAreaTextView getCursorPositionAsIndex:inParagraph:]): (RangeOfParagraph): (-[KWQTextAreaTextView textView:shouldChangeTextInRange:replacementString:]):
  • rendering/render_form.cpp: (WebCore::RenderTextArea::destroy): (WebCore::RenderTextArea::updateFromElement): (WebCore::RenderTextArea::text): (WebCore::RenderTextArea::textWithHardLineBreaks):
  • rendering/render_form.h:
11:06 PM Changeset in webkit [13050] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

  • Scripts/install-win-extras: fix dll permissions & download zlib too.
11:05 PM Changeset in webkit [13049] by eseidel
  • 5 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Copy missing dlls to build directory.

  • Viewer.cpp: fix line endings
  • Viewer/ImageView.cpp: fix line endings
  • Viewer/stdafx.cpp: fix line endings
  • WebCore.vcproj/WebCore/build-generated-files.sh:
10:39 PM Changeset in webkit [13048] by darin
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/css-selectorText-expected.checksum: Updated.
  • fast/dom/css-selectorText-expected.png: Updated.
  • fast/dom/css-selectorText-expected.txt: Updated.
  • fast/dom/css-selectorText.html: Added a case with multiple subselectors.

WebCore:

Test: added to fast/dom/css-selectorText.html

Reviewed by Darin.

  • css/css_base.cpp: (CSSSelector::selectorText): Iterate over subselectors
10:27 PM Changeset in webkit [13047] by darin
  • 1 edit in trunk/LayoutTests/editing/inserting/editing-empty-divs-expected.txt

Oops, this was in change log, but not committed.

10:17 PM Changeset in webkit [13046] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • write a portable ICU version of TextEncoding::fromUnicode for use on win32
  • platform/StreamingTextDecoder.h:
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::fromUnicode): added (WebCore::getConverter): helper (WebCore::cacheConverter): ditto (WebCore::effectiveEncoding): ditto
  • platform/mac/TextEncodingMac.cpp: Add comment
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode): remove
9:55 PM Changeset in webkit [13045] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/text/in-rendered-text-rtl-expected.checksum: Added.
  • fast/text/in-rendered-text-rtl-expected.png: Added.
  • fast/text/in-rendered-text-rtl-expected.txt: Added.
  • fast/text/in-rendered-text-rtl.html: Added.

WebCore:

Test: fast/text/in-rendered-text-rtl.html

Reviewed by Darin.

  • dom/dom_position.cpp: (WebCore::Position::inRenderedText): If the RenderText contains reversed text, the text boxes are not necessarily ordered by start position, so iterate through all of them. (WebCore::Position::isRenderedCharacter): Ditto.
9:44 PM Changeset in webkit [13044] by darin
  • 3 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

The head-check.html document uses an iframe as a laboratory for loading each
head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's
Live DOM Viewer: ​http://software.hixie.ch/utilities/js/live-dom-viewer/

Each of the four head-check-N.html files tests a different code path for
creating a document's head element in WebCore/khtml/html/htmlparser.cpp.

  • editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child index for <body> since the document previously had two <head> nodes.
  • fast/dom/HTMLHeadElement: Added.
  • fast/dom/HTMLHeadElement/head-check-expected.txt: Added.
  • fast/dom/HTMLHeadElement/head-check.html: Added.
  • fast/dom/HTMLHeadElement/resources: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-1.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-2.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-3.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check-4.html: Added.
  • fast/dom/HTMLHeadElement/resources/head-check.js: Added.

WebCore:

Reviewed by Darin.

  • khtml/html/htmlparser.cpp: Handle the head node like form and map nodes. (WebCore::HTMLParser::parseToken): (WebCore::HTMLParser::headCreateErrorCheck):
9:38 PM Changeset in webkit [13043] by eseidel
  • 3 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add stub to make DRT link.
Make WebCore copy libxml.dll into build directory when building.

  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TextEncoding::fromUnicode):
9:03 PM Changeset in webkit [13042] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix regression in layout tests
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength): Fix some code that was not properly truncating. I broke it in my string change this morning.
9:02 PM Changeset in webkit [13041] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Remove fpconst.cpp, unused on win32 and the cause of linker warnings.

8:55 PM Changeset in webkit [13040] by mjs
  • 3 edits in trunk/WebCore

Rubber stamped by Eric.

  • add stubs for FrameWin overrides of pure virtual Frame methods
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::FrameWin::respondToChangedContents): (WebCore::FrameWin::unfocusWindow): (WebCore::FrameWin::locationbarVisible): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::issueRedoCommand): (WebCore::FrameWin::canRedo): (WebCore::FrameWin::restoreDocumentState): (WebCore::FrameWin::canUndo): (WebCore::FrameWin::overrideMediaType): (WebCore::FrameWin::saveDocumentState): (WebCore::FrameWin::print): (WebCore::FrameWin::issueCutCommand): (WebCore::FrameWin::issueCopyCommand): (WebCore::FrameWin::partClearedInBegin): (WebCore::FrameWin::issueUndoCommand): (WebCore::FrameWin::clearRecordedFormValues): (WebCore::FrameWin::issuePasteCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::scheduleClose): (WebCore::FrameWin::menubarVisible): (WebCore::FrameWin::personalbarVisible): (WebCore::FrameWin::createEmptyDocument): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::statusbarVisible): (WebCore::FrameWin::toolbarVisible): (WebCore::FrameWin::issueTransposeCommand): (WebCore::FrameWin::userAgent): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::incomingReferrer): (WebCore::FrameWin::canGoBackOrForward): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::handledOnloadEvents): (WebCore::FrameWin::generateFrameName):
8:27 PM Changeset in webkit [13039] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add constructor and destructor.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::~FrameWin):
8:23 PM Changeset in webkit [13038] by mjs
  • 2 edits in trunk/WebCore

Rubber stamped by Eric (sorta).

  • add return values where needed
  • platform/win/TemporaryLinkStubs.cpp: (KWQServeRequest): (KWQServeSynchronousRequest):
8:13 PM Changeset in webkit [13037] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix Assertions.cpp to compile on win32.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • kxmlcore/Assertions.cpp:
8:12 PM Changeset in webkit [13036] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add a couple more stubs to make Win32 link.

  • platform/win/TemporaryLinkStubs.cpp: (KWQServeSynchronousRequest): (WebCore::FrameView::topLevelWidget):
7:56 PM Changeset in webkit [13035] by eseidel
  • 6 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Move mac-specific logging logic up into WebCore (from JavaScriptCore).
Remove KWQ prefixes from default log channels.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

  • bridge/mac/WebCorePageBridge.mm: (initializeLogChannel): (initializeLoggingChannelsIfNecessary): (-[WebCorePageBridge init]):
  • page/Frame.h:
  • platform/Logging.cpp:
  • platform/Logging.h:
7:51 PM Changeset in webkit [13034] by eseidel
  • 3 edits
    1 move in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Made Assertions.cpp platform independent.
Moved mac-specific logging logic up into WebCore.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7503

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kxmlcore/Assertions.cpp: Added.
  • kxmlcore/Assertions.h:
  • kxmlcore/Assertions.mm: Removed.
7:41 PM Changeset in webkit [13033] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4104575> hang due to slow saveDocumentState method
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]): Change code that iterates a QStringList with indices to use iterator instead.
7:38 PM Changeset in webkit [13032] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Eric.

  • portable version of QString::utf8
  • platform/QString.cpp: (QString::utf8): moved here, rewritten to use TextCodec
  • platform/mac/QStringMac.mm: (QString::utf8): removed from here
6:53 PM Changeset in webkit [13031] by eseidel
  • 3 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by mjs.

Fix FrameWin.h to use consistant line endings.
Fix TemporaryLinkStubs to better match style guidelines.

  • bridge/win/FrameWin.h: (WebCore::Win):
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectAll): (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (Widget::mapFromGlobal): (QPainter::addClip): (QLineEdit::cursorPosition): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (QPainter::drawFocusRing): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (QComboBox::clear): (QPainter::misspellingLineThickness): (QComboBox::setFrameGeometry): (QLineEdit::maxLength): (Widget::isEnabled): (KWQServeRequest): (QTextEdit::setText): (Widget::paint): (QPainter::addRoundedRectClip): (FrameView::viewportToGlobal): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (QPainter::drawEllipse): (QTextEdit::setReadOnly): (QListBox::appendItem): (QLineEdit::setPlaceholderString): (Cursor::Cursor): (Widget::focusPolicy): (ScrollView::removeChild): (QTextEdit::selectAll): (QPainter::fillRect): (QPainter::endTransparencyLayer): (QFont::QFont): (ScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (Widget::~Widget): (QPainter::xForm): (QListBox::sizeForNumberOfLines): (ScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (FrameView::updateBorder): (QLineEdit::hasSelectedText): (QScrollBar::QScrollBar): (QListBox::doneAppendingItems): (QTextEdit::QTextEdit): (ScrollView::inWindow): (QScrollBar::setValue): (QFont::setFirstFamily): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (ScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (QTextEdit::setLineHeight): (QScrollBar::setKnobProportion): (KWQFileButton::KWQFileButton): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (QPainter::beginTransparencyLayer): (QFontMetrics::setFont): (QComboBox::setFont): (Widget::frameGeometry): (QListBox::setSelected): (QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (QPainter::restore): (QFontMetrics::width): (Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (ScrollView::setStaticBackground): (QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (QPainter::drawText): (QPainter::pen): (KJavaAppletWidget::KJavaAppletWidget): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (Widget::setIsSelected): (QLineEdit::text): (Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (QPainter::paintingDisabled): (QComboBox::QComboBox): (QPainter::drawConvexPolygon): (Widget::setFont): (QSlider::setMaxValue): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QTextEdit::setSelectionRange): (ScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (ScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (Widget::setCursor): (QLineEdit::setAutoSaveName): (QComboBox::baselinePosition): (QComboBox::appendItem): (QPainter::setShadow): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (QSlider::QSlider): (ScrollView::setVScrollBarMode): (QPainter::drawScaledAndTiledImage): (ScrollView::scrollYOffset): (QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (ScrollView::setScrollBarsMode): (QComboBox::sizeHint): (QPainter::drawRect): (QFont::setPixelSize): (Widget::setFrameGeometry): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (QFont::operator==): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (QPainter::setFont): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (QPainter::drawLineForMisspelling): (QLineEdit::setText): (QSlider::value): (QListBox::setSelectionMode): (KWQFileButton::setFilename): (QFontMetrics::QFontMetrics): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (ScrollView::updateContents): (QFontMetrics::floatWidth): (ScrollView::setHScrollBarMode): (KWQFileButton::focusPolicy): (QListBox::setFont): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (KWQFileButton::setFrameGeometry): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (QTextEdit::setFont): (QLineEdit::setFont): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QSlider::setFont): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar): (Path::operator=): (QLineEdit::setColors): (QTextEdit::setColors): (searchableIndexIntroduction): (KWQKCookieJar::setCookie): (KWQKCookieJar::cookie): (WebCore::screenRect): (WebCore::Widget::clearFocus): (WebCore::historyContains): (KWQFindNextSentenceFromIndex): (KWQFindSentenceBoundary): (KWQFindNextWordFromIndex): (KWQFindWordBoundary): (submitButtonDefaultLabel): (inputElementAltText): (resetButtonDefaultLabel): (KWQKCookieJar::cookieEnabled): (WebCore::Widget::setFocus): (WebCore::QPainter::fillRect): (WebCore::QPainter::~QPainter): (WebCore::ScrollView::viewportToContents): (WebCore::TransferJob::kill): (WebCore::TransferJob::addMetaData): (WebCore::TransferJob::queryMetaData): (WebCore::TransferJob::error): (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::TransferJob::TransferJob): (WebCore::Widget::hide): (KLocale::language): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::screenDepth): (QFont::italic): (QFontMetrics::operator=): (QFontMetrics::xHeight): (WebCore::usableScreenRect): (QFont::operator=): (Widget::setActiveWindow): (KWQCheckIfReloading): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (KWQCheckCacheObjectStatus):
5:17 PM Changeset in webkit [13030] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Adele.

<rdar://problem/4222043> Safari should reduce null events sent to invisible plugins

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]): Check to see if the plugin view is completely obscured (scrolled out of view, for example). If it is obscured and it wasn't before, or the other way around, then restart the null event timer so it can fire at the appropriate rate. (-[WebBaseNetscapePluginView viewHasMoved:]): If a plugin is obscured, send it null events as if it were in an inactive window.
5:00 PM Changeset in webkit [13029] by eseidel
  • 14 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Fix xcode project after previous KWQLogging move.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Logging.h:
4:41 PM Changeset in webkit [13028] by justing
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by darin


Test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker

  • fast/events/onclick-list-marker-expected.txt: Added.
  • fast/events/onclick-list-marker.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
elementAtPoint returns the list when the point is over a list marker


Consider the case of outside list markers in nodeAtPoint. Had to pull
the code out of RenderListMarker::paint that computed the position/size
of the list marker.

Added:

  • fast/events/onclick-list-marker.html
  • rendering/render_list.cpp: (RenderListItem::nodeAtPoint): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::nodeAtPoint): (RenderListMarker::getRelativeMarkerRect):
  • rendering/render_list.h:
  • rendering/render_object.h:
4:19 PM Changeset in webkit [13027] by eseidel
  • 15 edits
    2 moves in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Move KWQLogging to platform and rename as Logging.*, fix headers.
This will break the mac build, which I will fix on my next commit.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • dom/DocumentImpl.cpp:
  • dom/dom_position.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/VisiblePosition.cpp:
  • editing/markup.cpp:
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQLogging.h: Removed.
  • kwq/KWQLogging.m: Removed.
  • kwq/KWQRegExp.cpp:
  • kwq/KWQTextStream.cpp:
  • platform/Logging.cpp: Added.
  • platform/Logging.h: Added.
  • platform/QString.cpp:
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ScrollView::vScrollBarMode): (WebCore::theme):
4:05 PM Changeset in webkit [13026] by eseidel
  • 7 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix a bunch more link errors in the win32 build, mostly by adding stubs.

  • WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
  • WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
  • platform/PlugInInfoStore.h:
  • platform/mac/PlugInInfoStoreMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs. (WebCore::TransferJob::errorText): (WebCore::TransferJob::isErrorPage): (WebCore::Widget::hide): (PlugInInfoStore::createPluginInfoForPluginAtIndex): (PlugInInfoStore::pluginCount): (WebCore::refreshPlugins): (QFont::QFont): (QFont::~QFont): (QFont::italic): (QFont::weight): (QFontMetrics::QFontMetrics): (QFontMetrics::~QFontMetrics): (QFontMetrics::xHeight): (Widget::setActiveWindow): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode):
3:47 PM Changeset in webkit [13025] by thatcher
  • 6 copies in tags/Safari-521.8

New tag.

3:43 PM Changeset in webkit [13024] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning

3:23 PM Changeset in webkit [13023] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by timo.

Add missing include to fix build.

  • platform/win/TemporaryLinkStubs.cpp:
3:08 PM Changeset in webkit [13022] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

2006-02-25 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.


Test new PlugInInfoStore class (used to be KConfig).


  • plugins/plugin-javascript-access-expected.txt: Added.
  • plugins/plugin-javascript-access.html: Added.
3:08 PM Changeset in webkit [13021] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Test new KConfig -> PlugInInfoStore change.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

  • DumpRenderTree/DumpRenderTree.m: (main): load test netscape plugin
  • Scripts/run-webkit-tests: style update
3:07 PM Changeset in webkit [13020] by eseidel
  • 4 edits
    2 moves
    1 delete in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Move KConfig to platform/PlugInInfoStore and add test.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7498

Test: plugins/plugin-javascript-access.html

  • ForwardingHeaders/kconfig.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase):
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQKConfigBase.h: Removed.
  • kwq/KWQKConfigBase.mm: Removed.
  • platform/PlugInInfoStore.h: Added.
  • platform/mac/PlugInInfoStoreMac.mm: Added. (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::refreshPlugins):
2:43 PM Changeset in webkit [13019] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.
2:42 PM Changeset in webkit [13018] by thatcher
  • 1 edit in trunk/WebCore/platform/mac/CursorMac.mm

Build fix for i386. Workaround for 4213314

1:55 PM Changeset in webkit [13017] by darin
  • 3 edits in trunk/JavaScriptCore
  • fixed Mac Debug build, there was an unused parameter
  • kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread): Remove parameter name.
  • kjs/debugger.h: Fixed comment.
1:40 PM Changeset in webkit [13016] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

  • kxmlcore/Vector.h: (KXMLCore::deleteAllValues): fix unused variable warning
1:36 PM Changeset in webkit [13015] by mjs
  • 44 edits
    1 add in trunk/JavaScriptCore

Reviewed by Darin.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/NP_jsobject.cpp: (jsAllocate): (_NPN_InvokeDefault): (_NPN_Evaluate): (_NPN_GetProperty): (_NPN_SetProperty): (_NPN_RemoveProperty): (_NPN_HasProperty): (_NPN_HasMethod):
  • bindings/c/c_class.h: (KJS::Bindings::CClass::constructorAt):
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertNPVariantToValue):
  • bindings/jni/jni_class.cpp: (JavaClass::methodsNamed): (JavaClass::fieldNamed):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeDefaultMethod):
  • bindings/jni/jni_jsobject.cpp:
  • bindings/jni/jni_objc.mm: (-[NSObject KJS::Bindings::]):
  • bindings/objc/WebScriptObject.mm: (+[WebUndefined allocWithZone:]): (-[WebUndefined initWithCoder:]): (-[WebUndefined encodeWithCoder:]): (-[WebUndefined copyWithZone:]):
  • bindings/objc/objc_class.h: (KJS::Bindings::ObjcClass::constructorAt):
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fallbackObject):
  • bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::getOwnPropertySlot): (ObjcFallbackObjectImp::put): (ObjcFallbackObjectImp::canPut): (ObjcFallbackObjectImp::deleteProperty): (ObjcFallbackObjectImp::toBoolean):
  • bindings/runtime.cpp: (KJS::Bindings::Instance::createLanguageInstanceForValue):
  • bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField): (KJS::Bindings::Instance::setValueOfUndefinedField):
  • bindings/runtime_array.cpp: (RuntimeArray::lengthGetter): (RuntimeArray::indexGetter): (RuntimeArray::put): (RuntimeArray::deleteProperty):
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::execute):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::fallbackObjectGetter): (RuntimeObjectImp::fieldGetter): (RuntimeObjectImp::methodGetter): (RuntimeObjectImp::put): (RuntimeObjectImp::canPut): (RuntimeObjectImp::deleteProperty): (RuntimeObjectImp::defaultValue): (RuntimeObjectImp::callAsFunction):
  • bindings/runtime_root.cpp: (performJavaScriptAccess):
  • kjs/array_object.cpp: (ArrayInstance::lengthGetter): (ArrayInstance::getOwnPropertySlot): (ArrayPrototype::ArrayPrototype): (ArrayPrototype::getOwnPropertySlot):
  • kjs/bool_object.cpp: (BooleanObjectImp::BooleanObjectImp):
  • kjs/date_object.cpp: (KJS::DateObjectFuncImp::DateObjectFuncImp): (KJS::DateObjectFuncImp::callAsFunction):
  • kjs/error_object.cpp: (ErrorObjectImp::ErrorObjectImp): (NativeErrorPrototype::NativeErrorPrototype): (NativeErrorImp::NativeErrorImp):
  • kjs/function.cpp: (KJS::FunctionImp::argumentsGetter): (KJS::FunctionImp::lengthGetter): (KJS::Arguments::mappedIndexGetter): (KJS::ActivationImp::argumentsGetter): (KJS::ActivationImp::put):
  • kjs/function_object.cpp: (FunctionObjectImp::FunctionObjectImp):
  • kjs/internal.cpp: (KJS::GetterSetterImp::toPrimitive): (KJS::GetterSetterImp::toBoolean):
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/interpreter.h: (KJS::Interpreter::isGlobalObject): (KJS::Interpreter::interpreterForGlobalObject): (KJS::Interpreter::isSafeScript):
  • kjs/lexer.cpp: (Lexer::makeIdentifier): (Lexer::makeUString):
  • kjs/lookup.h: (KJS::staticFunctionGetter): (KJS::staticValueGetter):
  • kjs/nodes.cpp: (StatementNode::processFuncDecl): (PropertyNode::evaluate): (PropertyNameNode::evaluate):
  • kjs/number_object.cpp: (NumberObjectImp::NumberObjectImp): (NumberObjectImp::getOwnPropertySlot):
  • kjs/object.cpp: (KJS::JSObject::defineGetter): (KJS::JSObject::defineSetter): (KJS::JSObject::hasInstance): (KJS::JSObject::propertyIsEnumerable):
  • kjs/object_object.cpp: (ObjectObjectImp::ObjectObjectImp):
  • kjs/property_slot.cpp: (KJS::PropertySlot::undefinedGetter): (KJS::PropertySlot::functionGetter):
  • kjs/reference.cpp: (KJS::Reference::getPropertyName):
  • kjs/reference_list.cpp: (ReferenceListIterator::operator++):
  • kjs/regexp_object.cpp: (RegExpObjectImp::RegExpObjectImp): (RegExpObjectImp::getValueProperty): (RegExpObjectImp::putValueProperty):
  • kjs/string_object.cpp: (StringInstance::lengthGetter): (StringInstance::indexGetter): (StringPrototype::StringPrototype):
  • kxmlcore/Assertions.mm:
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_PageHeap::CheckList):
  • kxmlcore/HashTable.h: (KXMLCore::HashTableConstIterator::checkValidity): (KXMLCore::IdentityHashTranslator::translate):
  • pcre/pcre_get.c: (pcre_get_stringnumber):
1:31 PM Changeset in webkit [13014] by eseidel
  • 6 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Reworked KConfig and plugin architecture to be much more sane.
This is part one. Once this lands, I'll move it under platform with a better name.

Darin had several great suggested further improvements as part of:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
I'll make some of those when I move this to platform.

No layout test possible (no way to control which plugins DRT sees).

  • khtml/ecma/kjs_navigator.cpp: (KJS::PluginBase::PluginBase): (KJS::PluginBase::~PluginBase): (KJS::PluginBase::refresh): (KJS::Plugins::getValueProperty): (KJS::Plugins::nameGetter): (KJS::Plugins::getOwnPropertySlot): (KJS::MimeTypes::getValueProperty): (KJS::MimeTypes::nameGetter): (KJS::MimeTypes::getOwnPropertySlot): (KJS::Plugin::getValueProperty): (KJS::Plugin::nameGetter): (KJS::Plugin::getOwnPropertySlot):
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_window.cpp:
  • kwq/KWQKConfigBase.h: (WebCore::PluginInfoStore::PluginInfoStore):
  • kwq/KWQKConfigBase.mm: (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PluginInfoStore::pluginCount): (WebCore::refreshPlugins):
1:01 PM Changeset in webkit [13013] by eseidel
  • 2 edits in trunk/WebCore

2006-02-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Build fix: cast to unsigned from size_t.

  • platform/StreamingTextDecoder.cpp:
12:17 PM Changeset in webkit [13012] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
12:11 PM Changeset in webkit [13011] by mjs
  • 2 edits in trunk/WebCore
  • use proper header for std::min.
  • platform/StreamingTextDecoder.cpp:
11:30 AM Changeset in webkit [13010] by mjs
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convertUTF16):
  • platform/TextEncoding.cpp:
9:58 AM Changeset in webkit [13009] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.
9:23 AM Changeset in webkit [13008] by darin
  • 2 edits in trunk/WebCore
  • css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling back to that; apologies for the churn.
9:06 AM Changeset in webkit [13007] by darin
  • 2 edits in trunk/WebCore
  • css/csshelper.cpp: (WebCore::parseURL): Third time's the charm.
9:00 AM Changeset in webkit [13006] by darin
  • 2 edits in trunk/WebCore
  • css/csshelper.cpp: (WebCore::parseURL): Oops! Checked in fixed version of this file.
8:55 AM Changeset in webkit [13005] by darin
  • 16 edits in trunk/WebCore

Reviewed by Maciej.

  • css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than manipulating the characters directly inside a StringImpl buffer.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse it rather than going out of our way to hack StringImpl to not copy the data. It would be better not to copy, but this is one-time work.
  • dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
  • dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
  • dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
  • dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
  • platform/AtomicString.cpp: (WebCore::CStringTranslator::equal): (WebCore::QCharBufferTranslator::equal): (WebCore::AtomicString::add):
  • platform/StringImpl.h: (WebCore::StringImpl::unicode): Added. (KXMLCore::CaseInsensitiveHash::hash): (KXMLCore::CaseInsensitiveHash::equal):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
  • rendering/RenderText.cpp: (WebCore::getCharacterBreakIterator): (WebCore::RenderText::RenderText): (WebCore::RenderText::atLineWrap): (WebCore::RenderText::allAscii): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::setSelectionState): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setText): (WebCore::RenderText::width): (WebCore::RenderText::selectionRect): (WebCore::RenderText::caretMaxOffset):
  • rendering/RenderTextFragment.cpp: (khtml::RenderTextFragment::RenderTextFragment): (khtml::RenderTextFragment::originalString): Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Use const. (WebCore::endOfParagraph): Ditto.
2:49 AM Changeset in webkit [13004] by mjs
  • 2 edits in trunk/WebCore
  • fix problem with a prototype that broke win32 build
  • platform/StreamingTextDecoder.h: (WebCore::StreamingTextDecoder::convert):
2:02 AM Changeset in webkit [13003] by mjs
  • 2 edits in trunk/WebCore
  • fix debug build (broken by my last commit)
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::StreamingTextDecoder::convertUsingICU):
1:17 AM Changeset in webkit [13002] by mjs
  • 27 edits
    3 copies
    8 moves
    2 adds
    1 delete in trunk/WebCore

Reviewed by Darin.


I renamed QTextCodec to TextEncoding and QTextDecoder to
StreamingTextDecoder. I also made a bunch of other changes to make
the API more sensible.


  • ForwardingHeaders/qtextcodec.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge URLWithAttributeString:]): (-[WebCoreFrameBridge textEncoding]): (+[WebCoreFrameBridge stringWithData:textEncoding:]): (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::completeURL):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMDocument::getValueProperty): (KJS::DOMDocument::putValueProperty):
  • khtml/html/FormDataList.cpp: (DOM::FormDataList::FormDataList): (DOM::FormDataList::appendString):
  • khtml/html/FormDataList.h:
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::formData):
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::encodingName): (Decoder::decode):
  • khtml/misc/decoder.h: (khtml::Decoder::): (khtml::Decoder::visuallyOrdered): (khtml::Decoder::encoding):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource):
  • kwq/KWQCharsets.cpp: Removed.
  • kwq/KWQCharsets.h: Removed.
  • kwq/KWQTextCodec.cpp: Removed.
  • kwq/KWQTextCodec.h: Removed.
  • kwq/WebCoreTextDecoder.h:
  • kwq/WebCoreTextDecoder.mm:
  • kwq/can-convert.mm: Removed.
  • kwq/character-sets.txt: Removed.
  • kwq/mac-encodings.txt: Removed.
  • kwq/make-charset-table.pl: Removed.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): (WebCore::CachedScript::setCharset): (WebCore::CachedScript::data):
  • loader/CachedScript.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setCharset):
  • page/Frame.cpp: (WebCore::Frame::write): (WebCore::Frame::gotoAnchor): (WebCore::Frame::encoding): (WebCore::Frame::backslashAsCurrencySymbol):
  • platform/CharsetNames.cpp: Added. (KXMLCore::): (WebCore::EncodingHash::equal): (WebCore::EncodingHash::hash): (WebCore::buildDictionaries): (WebCore::textEncodingIDFromCharsetName): (WebCore::charsetNameFromTextEncodingID):
  • platform/CharsetNames.h: Added.
  • platform/KURL.cpp: (KURL::KURL): (KURL::decode_string): (encodeRelativeString):
  • platform/KURL.h:
  • platform/QString.cpp: (QString::fromUtf8):
  • platform/StreamingTextDecoder.cpp: Added. (WebCore::StreamingTextDecoder::StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertLatin1): (WebCore::StreamingTextDecoder::~StreamingTextDecoder): (WebCore::StreamingTextDecoder::convertUTF16): (WebCore::effectiveEncoding): (WebCore::StreamingTextDecoder::createICUConverter): (WebCore::unwanted): (WebCore::StreamingTextDecoder::appendOmittingUnwanted): (WebCore::StreamingTextDecoder::convertUsingICU): (WebCore::StreamingTextDecoder::convert): (WebCore::StreamingTextDecoder::toUnicode):
  • platform/StreamingTextDecoder.h: Added. (WebCore::StreamingTextDecoder::convert):
  • platform/TextEncoding.cpp: Added. (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::name): (WebCore::effectiveEncoding): (WebCore::TextEncoding::backslashAsCurrencySymbol): (WebCore::TextEncoding::toUnicode):
  • platform/TextEncoding.h: Added. (WebCore::): (WebCore::TextEncoding::): (WebCore::TextEncoding::TextEncoding): (WebCore::TextEncoding::isValid): (WebCore::TextEncoding::usesVisualOrdering): (WebCore::TextEncoding::isJapanese): (WebCore::TextEncoding::encodingID): (WebCore::TextEncoding::flags): (WebCore::operator==): (WebCore::operator!=):
  • platform/character-sets.txt: Added.
  • platform/mac/ExtraCFEncodings.h: Added.
  • platform/mac/QStringMac.mm:
  • platform/mac/TextEncodingMac.cpp: Added. (WebCore::effectiveEncoding): (WebCore::TextEncoding::fromUnicode):
  • platform/mac/can-convert.mm: Added.
  • platform/mac/mac-encodings.txt: Added.
  • platform/make-charset-table.pl: Added.
  • platform/win/win-encodings.txt: Added.
  • rendering/render_object.cpp: (WebCore::RenderObject::backslashAsCurrencySymbol):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::slotData):
12:24 AM Changeset in webkit [13001] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Change KIO::TransferJob to WebCore::TransferJob.
12:13 AM Changeset in webkit [13000] by darin
  • 26 edits
    1 add
    1 delete in trunk/WebCore

Reviewed by Maciej.

  • merged Job and TransferJob into TransferJob and moved it to WebCore namespace
  • changed TransferJob to use a TransferJobClient object instead of signals
  • ForwardingHeaders/kio/job.h: Changed to point to "KWQKJobClasses.h".
  • kwq/KWQKJob.h: Removed.
  • kwq/TransferJobClient.h: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/xml_tokenizer.cpp: (WebCore::openFunc):
  • khtml/xsl/xslt_processorimpl.cpp: (DOM::docLoaderFunc): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post".
  • kwq/KWQKJobClasses.h: Eliminate Job. Add a TransferJobClient* parameter to TransferJob. Eliminate the deliverAllData parameter to TransferJob constructor. Remove the signals from TransferJob.
  • kwq/KWQKJobClasses.mm: (WebCore::TransferJobPrivate::TransferJobPrivate): Store a client pointer. (WebCore::TransferJob::TransferJob): Store a client pointer, remove the deliverAllData boolean. (WebCore::TransferJob::receivedResponse): Added. Replaces the old emitReceivedResponse function; uses client instead of a signal. (WebCore::TransferJob::client): Added.
  • kwq/KWQLoader.h: Switched things to mention the WebCore namespace. Changed KIO::TransferJob to WebCore::TransferJob.
  • kwq/KWQLoader.mm: Ditto.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Removed isKHTMLLoader.
  • kwq/KWQResourceLoader.h: Changed KIO::TransferJob to WebCore::TransferJob.
  • kwq/KWQResourceLoader.mm: (-[KWQResourceLoader receivedResponse:]): Call receivedResponse function on the job instead of emitReceivedResponse. (-[KWQResourceLoader redirectedToURL:]): Call receivedRedirect function on the client directly instead of emitRedirection on the job. (-[KWQResourceLoader addData:]): Call receivedData function on the client directly instead of emitData on the job. (-[KWQResourceLoader finishJobAndHandle:]): Call receivedAllData function on the client directly instead of emitResult on the job. Also fixed a potential memory leak where the handle was not released if the job was 0.
  • kwq/KWQSignal.h:
  • kwq/KWQSignal.cpp:
  • kwq/KWQSlot.h:
  • kwq/KWQSlot.cpp: Removed the job-related signals and slots.
  • loader/CachedObject.h: Removed unneeded declaration of TransferJob.
  • loader/loader.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): Use "new TransferJob" instead of "KIO::get". Also don't connect signals. (WebCore::Loader::receivedAllData): New name for slotFinished. (WebCore::Loader::receivedResponse): New name for slotReceivedResponse. (WebCore::Loader::receivedData): New name for slotData. (WebCore::Loader::cancelRequests): Changed KIO::Job to TransferJob. (WebCore::Loader::jobForRequest): Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::Frame::receivedAllData): Renamed from slotFinished. Also slightly cleaned up the logic. (WebCore::Frame::receivedRedirect): Renamed from slotRedirection.
  • page/FramePrivate.h: Changed KIO::TransferJob to WebCore::TransferJob.
  • xml/xmlhttprequest.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Eliminate XMLHttpRequestQObject. (WebCore::XMLHttpRequest::send): Use "new TransferJob" instead of "KIO::get" and "KIO::http_post". Also don't connect signals. (WebCore::XMLHttpRequest::processSyncLoadResults): Change to call the functions by their new names (names changed to use with TransferJobClient). (WebCore::XMLHttpRequest::receivedAllData): Renamed from slotFinished. (WebCore::XMLHttpRequest::receivedRedirect): Renamed from slotRedirection. (WebCore::XMLHttpRequest::receivedData): Renamed from slotData.

Feb 26, 2006:

10:34 PM Changeset in webkit [12999] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej, landed by Geoff.

Change "Deployment" to "Release" and "Development" to "Debug".
Update latest Xcode version from 2.2 to 2.2.1.

  • building/build.html
10:30 PM Changeset in webkit [12998] by ggaren
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Maciej, landed by Geoff.

  • fast/forms/form-hides-table-expected.checksum: Added.
  • fast/forms/form-hides-table-expected.png: Added.
  • fast/forms/form-hides-table-expected.txt: Added.
  • fast/forms/form-hides-table.html: Added.
10:22 PM Changeset in webkit [12997] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Test by Geoff, automated by me, reviewed by Darin.

  • fast/frames/empty-frame-document-expected.txt: Added.
  • fast/frames/empty-frame-document.html: Added.

WebKit:

Test: fast/frames/empty-frame-document.html

Reviewed by Darin.

The crash happened because an empty frame did not have a document.

  • WebView/WebFrame.m: (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty frames. This causes a document to be created for the frame.
8:08 PM Changeset in webkit [12996] by darin
  • 3 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data): Add APPLE ifdefs to two more uses of response.
7:50 PM Changeset in webkit [12995] by darin
  • 5 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • loader/CachedObject.cpp: (WebCore::CachedObject::~CachedObject):
  • loader/CachedObject.h: (WebCore::CachedObject::CachedObject):
  • loader/loader.cpp: Add APPLE ifdefs to calls to setResponse and setAllData.
  • platform/win/TemporaryLinkStubs.cpp: Add missing includes.
7:31 PM Changeset in webkit [12994] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • more Win32 link fixes
  • loader/CachedObject.h: Put some Mac-specific stuff inside APPLE ifdefs.
  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.
7:08 PM Changeset in webkit [12993] by darin
  • 2 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • platform/win/TemporaryLinkStubs.cpp: Added more includes.
7:08 PM Changeset in webkit [12992] by darin
  • 2 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • platform/win/TemporaryLinkStubs.cpp: Added more includes.
7:03 PM Changeset in webkit [12991] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • work toward getting the Win32 build to link
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added KWQObject.cpp.
  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.

Feb 25, 2006:

8:51 PM Changeset in webkit [12990] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added reviewer to an old change; I just noticed it was missing.

5:14 PM Changeset in webkit [12989] by ggaren
  • 9 edits
    18 adds in trunk/LayoutTests

RS by mjs.

-tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
Re-landing results after adding missing png's to the test.

  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.
  • fast/replaced/maxheight-percent-expected.checksum: Added.
  • fast/replaced/maxheight-percent-expected.png: Added.
  • fast/replaced/maxheight-percent-expected.txt:
  • fast/replaced/maxheight-pxs-expected.checksum: Added.
  • fast/replaced/maxheight-pxs-expected.png: Added.
  • fast/replaced/maxheight-pxs-expected.txt:
  • fast/replaced/maxwidth-percent-expected.checksum: Added.
  • fast/replaced/maxwidth-percent-expected.png: Added.
  • fast/replaced/maxwidth-percent-expected.txt:
  • fast/replaced/maxwidth-pxs-expected.checksum: Added.
  • fast/replaced/maxwidth-pxs-expected.png: Added.
  • fast/replaced/maxwidth-pxs-expected.txt:
  • fast/replaced/minheight-percent-expected.checksum: Added.
  • fast/replaced/minheight-percent-expected.png: Added.
  • fast/replaced/minheight-percent-expected.txt:
  • fast/replaced/minheight-pxs-expected.checksum: Added.
  • fast/replaced/minheight-pxs-expected.png: Added.
  • fast/replaced/minheight-pxs-expected.txt:
  • fast/replaced/minwidth-percent-expected.checksum: Added.
  • fast/replaced/minwidth-percent-expected.png: Added.
  • fast/replaced/minwidth-percent-expected.txt:
  • fast/replaced/minwidth-pxs-expected.checksum: Added.
  • fast/replaced/minwidth-pxs-expected.png: Added.
  • fast/replaced/minwidth-pxs-expected.txt:

Feb 24, 2006:

7:48 PM Changeset in webkit [12988] by antti
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/float/multiple-float-positioning-expected.checksum: Added.
  • fast/block/float/multiple-float-positioning-expected.png: Added.
  • fast/block/float/multiple-float-positioning-expected.txt: Added.
  • fast/block/float/multiple-float-positioning.html: Added.
7:46 PM Changeset in webkit [12987] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Test: fast/block/float/multiple-float-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list
6:57 PM Changeset in webkit [12986] by justing
  • 9 edits in trunk

LayoutTests:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:

WebCore:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

Reviewed by justin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their own selection gaps.
6:25 PM Changeset in webkit [12985] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
  • fast/dom/Window/redirect-with-timer.html: Added.
  • fast/dom/Window/redirect-with-timer-expected.txt: Added.

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)

Test: fast/dom/Window/redirect-with-timer.html

  • platform/Timer.h: Made isActive no longer inline. Added inHeap function.
  • platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are.
5:07 PM Changeset in webkit [12984] by justing
  • 58 edits in trunk

LayoutTests:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.txt:
  • editing/deleting/delete-line-end-ws-002-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/selection/extend-by-character-003-expected.txt:
  • editing/selection/extend-by-character-005-expected.txt:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-character-003-expected.txt:
  • editing/selection/move-by-character-005-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:
  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
  • fast/text/justified-text-rect-expected.txt:
  • fast/text/justified-text-rect.html:

WebCore:

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::setContentEditable):
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement):
2:48 PM Changeset in webkit [12983] by eseidel
  • 11 edits
    3 moves in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/css_base.h:
  • dom/AtomicStringList.h: Added. (WebCore::AtomicStringList::AtomicStringList):
  • dom/QualifiedName.cpp: Added.
  • dom/QualifiedName.h: Added.
  • dom/dom_atomicstringlist.h: Removed.
  • dom/dom_elementimpl.h:
  • dom/dom_qname.cpp: Removed.
  • dom/dom_qname.h: Removed.
  • editing/RemoveNodeAttributeCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • khtml/html/htmlnames.h:
  • khtml/html/htmltokenizer.h:
  • ksvg2/scripts/make_names.pl: update for new headers
2:36 PM Changeset in webkit [12982] by eseidel
  • 6 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Made a few methods on frame pure virtual.
Added a bunch of stub functions for win32 linking.

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::print): (WebCore::MacFrame::canUndo): (WebCore::MacFrame::canRedo): (WebCore::MacFrame::canPaste):
  • bridge/win/FrameWin.h:
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (QLineEdit::maxLength): (QPainter::drawEllipse): (QTextEdit::setLineHeight): (QPainter::beginTransparencyLayer): (QLineEdit::selectedText): (Widget::setIsSelected): (QPainter::paintingDisabled): (QFontMetrics::selectionRectForText): (QTextEdit::getCursorPosition): (QSlider::QSlider): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
2:07 PM Changeset in webkit [12981] by ggaren
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by Hyatt.

-tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

  • fast/replaced/maxheight-percent.html: Added.
  • fast/replaced/maxheight-pxs.html: Added.
  • fast/replaced/maxwidth-percent.html: Added.
  • fast/replaced/maxwidth-pxs.html: Added.
  • fast/replaced/minheight-percent.html: Added.
  • fast/replaced/minheight-pxs.html: Added.
  • fast/replaced/minwidth-percent.html: Added.
  • fast/replaced/minwidth-pxs.html: Added.
  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.

WebCore:

Reviewed by Hyatt, tweaked and landed by ggaren.

This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
patch of ​http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
modifications to suit the Webcore tree. Makes images respect min/max
sizes and their intrinsic aspect ratios at the same time according to
CSS 2.1 (​http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).

Test: fast/replaced/maxheight-percent.html
Test: fast/replaced/maxheight-pxs.html
Test: fast/replaced/maxwidth-percent.html
Test: fast/replaced/maxwidth-pxs.html
Test: fast/replaced/minheight-percent.html
Test: fast/replaced/minheight-pxs.html
Test: fast/replaced/minwidth-percent.html
Test: fast/replaced/minwidth-pxs.html

  • rendering/render_box.cpp: (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
  • rendering/render_image.cpp: Respect aspect ratios and calculate max/min (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): Added (WebCore::RenderImage::calcAspectRatioHeight): Added (WebCore::RenderImage::calcMinMaxWidth): Added
  • rendering/render_image.h:
1:47 PM Changeset in webkit [12980] by vicki
  • 1 edit
    2 adds in trunk/WebCore
  • add missing resources for manual-tests/scrolling-nestedframesets.html
  • manual-tests/resources/testframe-link_text.html: Added.
  • manual-tests/resources/testframeset.html: Added.
1:31 PM Changeset in webkit [12979] by vicki
  • 1 edit
    1 add in trunk/WebCore
  • test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
  • manual-tests/onbeforeunload-close_with_javascript.html: Added.
1:25 PM Changeset in webkit [12978] by eseidel
  • 3 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add Path stubs for Win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (Path::Path): (Path::~Path): (Path::operator=): (Path::contains): (Path::translate): (Path::boundingRect):
1:13 PM Changeset in webkit [12977] by hyatt
  • 26 edits in trunk/WebCore

In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle. htmlFont() becomes simply
font(). The old font() method turns into qfont(). Also added a helper for obtaining the fontDescription() directly from
the RenderStyle (without first obtaining the htmlFont()).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::offsetForPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::shouldUseMonospaceCache): (WebCore::RenderText::font): (WebCore::RenderText::width): (WebCore::RenderText::htmlFont):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::font): (khtml::RenderStyle::fontDescription): (khtml::RenderStyle::qfont):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
11:49 AM Changeset in webkit [12976] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • add link stubs for symbols only referenced from the link stubs file
  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::focusPolicy): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar):
11:44 AM Changeset in webkit [12975] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • fix up font.h inclues to be Font.h to fix build.
  • css/css_computedstyle.cpp:
  • css/css_valueimpl.cpp:
  • platform/Font.cpp:
  • rendering/render_style.h:
11:28 AM Changeset in webkit [12974] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix mac build by changing constants to an enum.

  • khtml/dom/dom2_events.h: (DOM::KeyboardEvent::):
11:19 AM Changeset in webkit [12973] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against icu.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
11:15 AM Changeset in webkit [12972] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Move rendering/font to platform/Font.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp:
  • platform/Font.cpp: Added.
  • platform/Font.h: Added.
  • rendering/font.cpp: Removed.
  • rendering/font.h: Removed.
  • rendering/render_theme_mac.mm:
11:11 AM Changeset in webkit [12971] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove delcarations causing duplicate symbols on win32.

  • khtml/dom/dom2_events.cpp:
11:02 AM Changeset in webkit [12970] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

  • bridge/win/FrameWin.cpp: fix line endings
10:54 AM Changeset in webkit [12969] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against libxml, etc.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
10:36 AM Changeset in webkit [12968] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Removed WebCore
prefixes added using namespace WebCore, fixes win32 build.
  • platform/win/TemporaryLinkStubs.cpp: (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QTextEdit::textWithHardLineBreaks): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (iBeamCursor): (QPainter::misspellingLineThickness): (westResizeCursor): (Widget::isEnabled): (northWestResizeCursor): (QPainter::drawEllipse): (southWestResizeCursor): (Widget::focusPolicy): (waitCursor): (QPainter::endTransparencyLayer): (ScrollView::addChild): (Widget::~Widget): (QListBox::sizeForNumberOfLines): (FrameView::updateBorder): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (eastResizeCursor): (QFontMetrics::boundingRect): (QPainter::beginTransparencyLayer): (northEastResizeCursor): (Widget::frameGeometry): (QPainter::addFocusRingRect): (QPainter::restore): (Widget::setEnabled): (QPainter::font): (QPainter::pen): (crossCursor): (Widget::setIsSelected): (handCursor): (QLineEdit::text): (Widget::unlockDrawingFocus): (QPainter::paintingDisabled): (northResizeCursor): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QPainter::drawText): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (southResizeCursor): (moveCursor): (FrameView::isFrameView): (helpCursor): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (southEastResizeCursor): (QPainter::drawScaledAndTiledImage): (QPainter::drawImage): (QComboBox::setWritingDirection): (QComboBox::sizeHint): (QPainter::drawRect): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QPainter::drawLineForMisspelling): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (ScrollView::updateContents):
8:24 AM Changeset in webkit [12967] by darin
  • 20 edits
    1 copy
    2 moves in trunk/WebCore

Reviewed by Hyatt.

  • moved QScrollView from kwq to platform directory
  • kwq/KWQScrollView.h: Removed.
  • kwq/KWQScrollView.mm: Removed.
  • platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
  • platform/ScrollView.h: Added. The rest of the former QScrollView.
  • platform/mac/ScrollViewMac.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::init): (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::scrollbarsVisible): Changed scrolling constants to use new names.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter): Use FrameView instead of QScrollView for a local variable.
  • khtml/html/html_baseimpl.h: Use ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQListBox.h: Use WebCore::ScrollView instead of QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Ditto. (QTextEdit::focusPolicy): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode instead of QScrollView::ScrollBarMode. (WebCore::FrameView::FrameView): Remove mention of QScrollView. (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView. (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView. (WebCore::FrameView::setVScrollBarMode): Ditto. (WebCore::FrameView::setHScrollBarMode): Ditto. (WebCore::FrameView::restoreScrollBar): Ditto.
  • platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
  • platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle): Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to updateContents so we can remove the overload. (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView. (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto. (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
4:59 AM Changeset in webkit [12966] by andersca
  • 2 edits in trunk/WebKitTools

2006-02-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
getting called from the run loop, making the view render each test and thus slowing
down the tests.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the offscreen window to not autodisplay.
1:14 AM Changeset in webkit [12965] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <​eseidel@apple.com>

Reviewed by anders.

Fix the win32 build.

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
1:10 AM Changeset in webkit [12964] by ap
  • 2 edits
    60 adds in trunk/LayoutTests

Reviewed by Darin.

  • http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
  • http/tests/xmlhttprequest/web-apps: Added (recursively).
12:01 AM Changeset in webkit [12963] by hyatt
  • 17 edits
    1 add in trunk/WebCore

Rename FontDef to FontDescription and move it into the platform directory.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::setFontSize):
  • css/cssstyleselector.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • platform/FontDescription.h: Added. (WebCore::FontDescription::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::operator!=): (WebCore::FontDescription::family): (WebCore::FontDescription::firstFamily): (WebCore::FontDescription::specifiedSize): (WebCore::FontDescription::computedSize): (WebCore::FontDescription::italic): (WebCore::FontDescription::computedPixelSize): (WebCore::FontDescription::smallCaps): (WebCore::FontDescription::isAbsoluteSize): (WebCore::FontDescription::weight): (WebCore::FontDescription::genericFamily): (WebCore::FontDescription::usePrinterFont): (WebCore::FontDescription::setFamily): (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize): (WebCore::FontDescription::setItalic): (WebCore::FontDescription::setSmallCaps): (WebCore::FontDescription::setIsAbsoluteSize): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::setGenericFamily): (WebCore::FontDescription::setUsePrinterFont): (WebCore::FontDescription::operator==):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
  • rendering/font.cpp: (khtml::Font::selectionRectForText): (khtml::Font::drawHighlightForText): (khtml::Font::drawText): (khtml::Font::update):
  • rendering/font.h: (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::fontDescription): (WebCore::Font::isSmallCaps): (WebCore::Font::wordSpacing): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint): (WebCore::Font::width):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect):
  • rendering/render_style.h: (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
Note: See TracTimeline for information about the timeline view.