Timeline



Mar 27, 2006:

10:32 PM Changeset in webkit [13527] by eseidel
  • 14 edits in trunk/WebCore

2006-03-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Give StringImpl a little privacy.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8022

  • dom/CharacterData.cpp: (WebCore::CharacterData::length): (WebCore::CharacterData::appendData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::rendererIsNeeded):
  • dom/Range.cpp: (WebCore::Range::compareBoundaryPoints):
  • dom/Text.cpp: (WebCore::Text::splitText):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken):
  • platform/AtomicString.cpp: (WebCore::operator==):
  • platform/String.cpp: (WebCore::String::operator[]): (WebCore::String::length): (WebCore::String::percentage): (WebCore::String::unicode): (WebCore::String::deprecatedString): (WebCore::String::isEmpty):
  • platform/StringImpl.cpp: (WebCore::equal): (WebCore::equalIgnoringCase):
  • platform/StringImpl.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):
10:30 PM Changeset in webkit [13526] by mjs
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by Beth.


  • test cases for <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)
  • fast/block/float/float-in-float-hit-testing-expected.checksum: Added.
  • fast/block/float/float-in-float-hit-testing-expected.png: Added.
  • fast/block/float/float-in-float-hit-testing-expected.txt: Added.
  • fast/block/float/float-in-float-hit-testing.html: Added.
  • fast/block/float/float-in-float-painting-expected.checksum: Added.
  • fast/block/float/float-in-float-painting-expected.png: Added.
  • fast/block/float/float-in-float-painting-expected.txt: Added.
  • fast/block/float/float-in-float-painting.html: Added.
  • fast/events/capture-on-target.html:

WebCore:

Reviewed by Beth.

  • fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects as well as their overflowRects.
  • platform/IntRect.h: (WebCore::unionRect): useful helper
  • platform/FloatRect.h: (WebCore::unionRect): added same for FloatRect just because
8:26 PM Changeset in webkit [13525] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

  • ChangeLog:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Instead of calling -stop, assert that the plugin is not running. A plugin view cannot be deallocated until it is removed from its window. When a plugin view is removed from its window, it calls -stop on itself. Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the assertion will help catch any edge cases. (-[WebBaseNetscapePluginView finalize]): ditto
8:15 PM Changeset in webkit [13524] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694086> -[WebBaseNetscapePluginStream finalize] is incorrect; design change needed

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that the stream file path either never existed, or was deleted and NULL-ed out. The stream file is now deleted immediately after calling NPP_StreamAsFile(). (-[WebBaseNetscapePluginStream finalize]): ditto (-[WebBaseNetscapePluginStream _destroyStream]): Delete the file after calling NPP_StreamAsFile(), instead of in -dealloc/-finalize. It should be OK to delete the file here -- NPP_StreamAsFile() is always called immediately before NPP_DestroyStream() (the stream destruction function), so there can be no expectation that a plugin will read the stream file asynchronously after NPP_StreamAsFile() is called.
8:13 PM Changeset in webkit [13523] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694093> -[WebBasePluginPackage finalize] is incorrect; design change needed

Call -unload on plug-in packages instead of relying on -dealloc/-finalize to do it. Currently
the only place plug-in packages are deallocated is when refreshing the set of plugins, as when
handling JavaScript's navigator.plugins.refresh().

  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that the plug-in has been unloaded by the time -dealloc is called. (-[WebBasePluginPackage finalize]): ditto
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -unload on the plug-in packages before releasing them.
5:07 PM Changeset in webkit [13522] by darin
  • 2 edits in trunk/WebCore

Based on a patch by Michael Emmel <​mike.emmel@gmail.com>.

  • platform/TransferJob.cpp: Remove unneeded include of "String.h".
4:57 PM Changeset in webkit [13521] by harrison
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

  • editing/deleting/delete-block-merge-contents-022.html: Added.
  • editing/deleting/delete-block-merge-contents-023.html: Added.
  • editing/selection/selectNode-expected.checksum: Added.
  • editing/selection/selectNode-expected.png: Added.
  • editing/selection/selectNode-expected.txt: Added.
  • editing/selection/selectNode.html: Added.
  • editing/selection/selectNodeContents-expected.checksum: Added.
  • editing/selection/selectNodeContents-expected.png: Added.
  • editing/selection/selectNodeContents-expected.txt: Added.
  • editing/selection/selectNodeContents.html: Added.
4:54 PM Changeset in webkit [13520] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Better fix than previous checkin, since maxDeepOffset is really an editing hack.

  • editing/selection/selectNodeContents-textNode.html: Added.
  • dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxOffset if offsetInCharacters, otherwise use childNodeCount.
4:07 PM Changeset in webkit [13519] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebKit

Release tag for Mac OS X Update 10.4.3.

4:07 PM Changeset in webkit [13518] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebCore

Release tag for Mac OS X Update 10.4.3.

4:05 PM Changeset in webkit [13517] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/JavaScriptCore

Release tag for Mac OS X Update 10.4.3.

3:34 PM Changeset in webkit [13516] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13515] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebKit

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13514] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptGlue

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13513] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13512] by thatcher
  • 2 adds in releases/Apple/Tiger

New release directories.

3:29 PM Changeset in webkit [13511] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebKit

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13510] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebCore

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13509] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptGlue

Release tag for Mac OS X Update 10.4.5.

3:28 PM Changeset in webkit [13508] by thatcher
  • 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptCore

Release tag for Mac OS X Update 10.4.5.

3:24 PM Changeset in webkit [13507] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/WebKit

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13506] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/WebCore

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13505] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptGlue

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13504] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptCore

Release tag for Security Update 2006-001.

3:15 PM Changeset in webkit [13503] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/WebKit

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13502] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/WebCore

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13501] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptGlue

Release tag for Security Update 2006-002.

3:14 PM Changeset in webkit [13500] by thatcher
  • 1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptCore

Release tag for Security Update 2006-002.

3:01 PM Changeset in webkit [13499] by thatcher
  • 5 adds in releases/Apple

New release directories. Will do server copies for the actual files.

2:21 PM Changeset in webkit [13498] by darin
  • 2 edits in trunk/WebCore

At the request of Michael Emmel <​mike.emmel@gmail.com>.

  • rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked
formatting a bit and removed some extraneous WebCore
prefixes.
2:09 PM Changeset in webkit [13497] by thatcher
  • 1 add in releases

New releases folder to hold tags of all WebKit versions released to the public. Reviewed by Darin.

2:07 PM Changeset in webkit [13496] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Part of <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore,
WebKit and WebBrowser

  • Carbon/HIViewAdapter.h: HIViewAdapter is no longer an NSView subclass, since we no longer pose it as NSView.
  • Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): Replace individual NSView methods instead of posing as NSView. (_webkit_NSView_setNeedsDisplay): Replacement implementation of -[NSView setNeedsDisplay:]. (_webkit_NSView_setNeedsDisplayInRect): Replacement implementation of -[NSView setNeedsDisplayInRect:] (_webkit_NSView_nextValidKeyView): Replacement implementation of -[NSView nextValidKeyView]
1:44 PM Changeset in webkit [13495] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler and Tim Omernick


  • fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly confirmed while typing on Safari.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _displayedValue]): Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but for now it fixes this regression.
1:33 PM Changeset in webkit [13494] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.


Removed two overzealous assertions that the steps to reproduce 4451831 were running into.
Improved comments to match.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): Remove assertion that _inNextKeyViewOutsideWebFrameViews should always be false here.


  • WebView/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assertion that the frame should never be the main frame here.
1:20 PM Changeset in webkit [13493] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Removed tabs & reformatted code.


  • Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): (+[NSView getHIViewForNSView:]): (+[NSView unbindNSView:]): (-[NSView setNeedsDisplay:]): (-[NSView setNeedsDisplayInRect:]): (-[NSView nextValidKeyView]): (SetViewNeedsDisplay):
1:10 PM Changeset in webkit [13492] by lypanov
  • 6 edits
    2 adds in trunk

2006-03-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by darin

  • fast/dynamic/insertAdjacentElement.html: Added.

2006-03-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by darin

Implement the IE extension insertAdjacentElement
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6520

  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Element.cpp: (WebCore::ElementImpl::insertAdjacentElement):
  • dom/Element.h:
  • dom/Element.idl:
9:34 AM Changeset in webkit [13491] by justing
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by beth and geoff

  • editing/selection/6476-expected.checksum: Added.
  • editing/selection/6476-expected.png: Added.
  • editing/selection/6476-expected.txt: Added.
  • editing/selection/6476.html: Added.
8:23 AM Changeset in webkit [13490] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
nodes. Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
selectNodeContents on a text node.

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxDeepOffset instead of childNodeCount, so that text node content is selected.
5:17 AM Changeset in webkit [13489] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page


  • fast/css/outline-auto-empty-rects-expected.checksum: Added.
  • fast/css/outline-auto-empty-rects-expected.png: Added.
  • fast/css/outline-auto-empty-rects-expected.txt: Added.
  • fast/css/outline-auto-empty-rects.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page


  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.
3:29 AM Changeset in webkit [13488] by mjs
  • 3 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Anders.


  • kjs/nodes.cpp: (Node::deref): take into account the case where the extra refcount table was never created

WebCore:

Reviewed by Anders.


  • manual-tests/empty-script-crash.html: Added.
1:32 AM Changeset in webkit [13487] by mjs
  • 2 edits in trunk/WebCore

Build fix:


  • reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node It turns out that the behavior we had was standards-compliant and Moz will be changing to match.


Also added a note so this doesn't get reverted again.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
12:34 AM Changeset in webkit [13486] by justing
  • 8 edits in trunk

WebCore:

Reviewed by darn


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

  • bridge/mac/WebCoreFrameBridge.h:
  • editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::editingAction):
  • editing/EditAction.h:
  • editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):

WebKit:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):

Mar 26, 2006:

7:29 PM Changeset in webkit [13485] by eseidel
  • 5 edits in trunk/WebCore

2006-03-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • editing/CompositeEditCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • generate-derived-sources:
5:30 PM Changeset in webkit [13484] by eseidel
  • 2 edits in trunk/WebCore

2006-03-26 Eric Seidel <​eseidel@apple.com>

  • dom/Element.cpp: fix include case, fixing build.
2:58 PM Changeset in webkit [13483] by eseidel
  • 9 edits
    1 add in trunk/WebCore

2006-03-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

  • manual-tests/left-overflow-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
  • rendering/RenderTableCell.cpp: Removed subclass implementation of getAbsoluteRepaintRect().
  • rendering/RenderTableCell.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.

Mar 25, 2006:

3:52 PM Changeset in webkit [13482] by eseidel
  • 2 edits in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Build fix.

  • bindings/scripts/CodeGeneratorJS.pm: include Element.h
2:24 PM Changeset in webkit [13481] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

  • DumpRenderTree/DumpRenderTree.m: (main): Added --repaint and --horizontal-sweep options. (dump): Repaint line-by-line or column-by-column when the appropriate option is selected. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint() and repaintSweepHorizontally() methods to layoutTestController. (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (dumpRenderTree):
  • Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options to force these settings on tests that do not ask for them.
2:20 PM Changeset in webkit [13480] by eseidel
  • 111 edits
    15 copies
    2 moves
    3 deletes in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Split dom_elementimpl.* into multiple files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

  • ForwardingHeaders/kdom/core/Attr.h: Removed.
  • ForwardingHeaders/kdom/core/Element.h: Removed.
  • ForwardingHeaders/kdom/core/XMLElement.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/AbstractView.cpp:
  • dom/Attr.cpp: Added.
  • dom/Attr.h: Added.
  • dom/Attribute.cpp: Added.
  • dom/Attribute.h: Added.
  • dom/CSSMappedAttributeDeclaration.cpp: Added.
  • dom/CSSMappedAttributeDeclaration.h: Added.
  • dom/DOMImplementation.cpp:
  • dom/Document.h:
  • dom/DocumentType.cpp:
  • dom/Element.cpp: Added. (WebCore::Element::Element): (WebCore::Element::~Element):
  • dom/Element.h: Added.
  • dom/EventNames.cpp:
  • dom/EventTargetNode.cpp:
  • dom/MappedAttribute.cpp: Added.
  • dom/MappedAttribute.h: Added.
  • dom/MappedAttributeEntry.h: Added. (WebCore::):
  • dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
  • dom/NamedAttrMap.cpp: Added.
  • dom/NamedAttrMap.h: Added.
  • dom/NamedMappedAttrMap.cpp: Added. (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
  • dom/NamedMappedAttrMap.h: Added.
  • dom/Node.cpp:
  • dom/NodeList.cpp:
  • dom/Position.cpp:
  • dom/StyledElement.cpp: Added.
  • dom/StyledElement.h: Added.
  • dom/dom_elementimpl.cpp: Removed.
  • dom/dom_elementimpl.h: Removed.
  • editing/BreakBlockquoteCommand.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteFromTextNodeCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/InsertLineBreakCommand.cpp:
  • editing/InsertParagraphSeparatorCommand.cpp:
  • editing/InsertTextCommand.cpp:
  • editing/MergeIdenticalElementsCommand.cpp:
  • editing/ModifySelectionListLevelCommand.cpp:
  • editing/MoveSelectionCommand.cpp:
  • editing/RemoveCSSPropertyCommand.cpp:
  • editing/RemoveNodeAttributeCommand.cpp:
  • editing/Selection.cpp:
  • editing/SelectionController.cpp:
  • editing/SetNodeAttributeCommand.cpp:
  • editing/SplitElementCommand.cpp:
  • editing/SplitTextNodeContainingElementCommand.cpp:
  • editing/TextIterator.cpp:
  • editing/TypingCommand.cpp:
  • editing/VisiblePosition.cpp:
  • editing/visible_units.cpp:
  • html/HTMLElement.h:
  • html/HTMLTokenizer.h:
  • html/html_baseimpl.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • khtml/ecma/kjs_views.cpp:
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/xbl/xbl_binding_manager.cpp:
  • khtml/xbl/xbl_tokenizer.cpp:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAnimateTransformElement.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement):
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.cpp:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEFloodElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEMergeNodeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLangSpace.cpp:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGPathElement.cpp:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGPolyElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGScriptElement.cpp:
  • ksvg2/svg/SVGStopElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGSwitchElement.cpp:
  • ksvg2/svg/SVGTests.cpp:
  • ksvg2/svg/SVGTextContentElement.cpp:
  • ksvg2/svg/SVGTextPositioningElement.cpp:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGURIReference.cpp:
  • ksvg2/svg/SVGUseElement.cpp:
  • ksvg2/svg/SVGViewElement.cpp:
  • ksvg2/svg/SVGZoomAndPan.cpp:
  • kwq/WebCoreTextArea.mm:
  • platform/Widget.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderCanvas.cpp:
  • rendering/RenderContainer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTextField.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/bidi.cpp:
  • rendering/render_replaced.cpp:
3:22 AM Changeset in webkit [13479] by eseidel
  • 11 edits in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix RenderStyle creation to avoid floating RenderStyle objects.
This also fixes a bug, were SVG to ever start sharing RenderStyles
between elements, code would have crashed as there were improperly
paired style->deref() statements in SVG code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

No test possible (no functionality change).

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
  • css/cssstyleselector.h:
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::createStyleForRenderer):
  • dom/Node.h:
  • dom/dom_elementimpl.cpp: (WebCore::Element::createStyleForRenderer): (WebCore::Element::recalcStyle):
  • dom/dom_elementimpl.h:
  • ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
  • ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::selectStartNode): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::getPseudoStyle):
2:46 AM Changeset in webkit [13478] by eseidel
  • 3 edits
    2 adds in trunk

2006-03-23 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Shave .2% on PLT by removing bogus strcmp.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

Test: fast/parser/tag-with-exclamation-point.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp
2:17 AM Changeset in webkit [13477] by justing
  • 16 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

  • editing/editing.js:
  • editing/execCommand/createLink-expected.checksum: Removed.
  • editing/execCommand/createLink-expected.png: Removed.
  • editing/execCommand/createLink-expected.txt:
  • editing/execCommand/createLink.html:
  • editing/execCommand/unlink-expected.txt: Added.
  • editing/execCommand/unlink.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented


Added code to push partially selected anchor elements down before
creating or removing links to create fully selected chunks that can be removed.
Changed create_link_command_h to CreateLinkCommand_h
Gave styled element application/removal its own ApplyStyleCommand constructor.
Still need to add new EditActions (7974).


  • WebCore.xcodeproj/project.pbxproj:
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/ApplyStyleCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::enclosingAnchorElement): (WebCore::CompositeEditCommand::pushAnchorElementDown): (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
  • editing/CompositeEditCommand.h:
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
  • editing/CreateLinkCommand.h:
  • editing/JSEditor.cpp:
  • editing/Selection.cpp: (WebCore::Selection::selectionFromContentsOfNode):
  • editing/Selection.h:
  • editing/UnlinkCommand.cpp: Added. (WebCore::UnlinkCommand::UnlinkCommand): (WebCore::UnlinkCommand::doApply):
  • editing/UnlinkCommand.h: Added.
  • page/Frame.cpp: (WebCore::Frame::selectContentsOfNode): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):

Mar 24, 2006:

7:34 PM Changeset in webkit [13476] by justing
  • 1 edit in trunk/WebCore/ChangeLog
7:28 PM Changeset in webkit [13475] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document


  • editing/pasteboard/7955-expected.checksum: Added.
  • editing/pasteboard/7955-expected.png: Added.
  • editing/pasteboard/7955-expected.txt: Added.
  • editing/pasteboard/7955.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
REGRESSION: Content with an interchange newline lost when pasted at the end of the document


There's no safe place in the document to keep the fragment while pasting, so I avoid
isProbablyBlock by saving whether or not something was blockFlow during the test
insertion.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::~ReplacementFragment): (WebCore::ReplacementFragment::firstChild): (WebCore::ReplacementFragment::lastChild): (WebCore::ReplacementFragment::mergeStartNode): (WebCore::ReplacementFragment::enclosingBlock): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment): (WebCore::ReplacementFragment::isBlockFlow): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode): (WebCore::ReplacementFragment::saveRenderingInfo): (WebCore::ReplacementFragment::removeUnrenderedNodes): (WebCore::ReplacementFragment::renderedBlocks): (WebCore::ReplacementFragment::removeStyleNodes): (WebCore::RenderingInfo::RenderingInfo): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::RenderingInfo::isBlockFlow): (WebCore::ReplacementFragment::renderingInfo): (WebCore::ReplacementFragment::nodes):
7:11 PM Changeset in webkit [13474] by eseidel
  • 3 edits in trunk/WebCore

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by justing.

  • generate-derived-sources: fix clean builds on mac.
5:47 PM Changeset in webkit [13473] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dave Harrison.

  • fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
  • fast/dom/Range/create-contextual-fragment-expected.png: Added.
  • fast/dom/Range/create-contextual-fragment-expected.txt: Added.
  • fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

Reviewed by Dave Harrison.

Test: fast/dom/Range/create-contextual-fragment.html

  • dom/Range.idl: Add createContextualFragment.
2:42 AM Changeset in webkit [13472] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Fix typo

2:41 AM Changeset in webkit [13471] by eseidel
  • 2 edits in trunk/WebKitTools

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Build fix.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::openURL): replace QString with DeprecatedString
2:40 AM Changeset in webkit [13470] by eseidel
  • 13 edits in trunk/WebCore

2006-03-24 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.
Uninify mac/win dependency handling.
Fix class vs. struct linker problem for win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
  • WebCore.vcproj/WebCore/build-generated-files.sh:
  • bridge/win/BrowserExtensionWin.h:
  • bridge/win/FrameWin.h:
  • generate-derived-sources:
  • kwq/AccessibilityObjectCache.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::createGraphicsContextPrivate): (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp:
  • platform/mac/GraphicsContextMac.mm:
  • platform/win/TemporaryLinkStubs.cpp: (QLineEdit::selectedText): (FrameWin::createPlugin): (BrowserExtensionWin::setTypedIconURL):

Mar 23, 2006:

11:17 PM Changeset in webkit [13469] by darin
  • 2 edits in trunk/WebKitSite

Reviewed by Darin.

  • coding/coding-style.html: Changed &emdash; to &mdash;.
11:15 PM Changeset in webkit [13468] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • bindings/jni_jsobject.cpp: (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base class, and the GetFieldID was using the wrong signature.
11:07 PM Changeset in webkit [13467] by darin
  • 10 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4484787> KWQAccObject dangles under GC
  • kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change from CF dictionaries to HashMap and HashSet.
  • kwq/AccessibilityObjectCache.mm: (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects and call CFRelease on all of them. (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting them in the HashMap, rather than assuming that retain == CFRetain. This is what fixes the GC issue. (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing. (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before. (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet. (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes. (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto. (WebCore::AccessibilityObjectCache::childrenChanged): Ditto. (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto. (WebCore::AccessibilityObjectCache::postNotification): Ditto.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]): Change to use functions by new names.
  • dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace. getAccObjectCache and ownerElement are const member functions, and m_accCache is a mutable data member.
  • dom/Document.cpp: (WebCore::Document::getAccObjectCache): Make const. (WebCore::Document::ownerElement): Make const.
  • kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
  • kwq/WebCoreAXObject.mm: (-[WebCoreAXObject anchorElement]): Update for function name change. (-[WebCoreAXObject firstChild]): Ditto. (-[WebCoreAXObject lastChild]): Ditto. (-[WebCoreAXObject previousSibling]): Ditto. (-[WebCoreAXObject nextSibling]): Ditto. (-[WebCoreAXObject parentObject]): Ditto. (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto. (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto. (AXLinkElementForNode): Ditto. (AXAttributedStringAppendReplaced): Ditto. (-[WebCoreAXObject accessibilityHitTest:]): Ditto. (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto. (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto. (-[WebCoreAXObject axObjectID]): Change field name to m_id. (-[WebCoreAXObject setAXObjectID:]): Ditto. (-[WebCoreAXObject removeAXObjectID]): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Remove ifdefs. (WebCore::RenderContainer::appendChildNode): Ditto. (WebCore::RenderContainer::insertChildNode): Ditto.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.
11:05 PM Changeset in webkit [13466] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • fix buildbot
10:28 PM Changeset in webkit [13465] by darin
  • 23 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.

  • kjs/object.h: Take function name, as well as source URL and line number, when using the special overloaded construct for making functions.
  • kjs/object.cpp: (KJS::JSObject::construct): Ditto.
  • kjs/function_object.h: Ditto.
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when constructing the function rather than null. Use "anonymous" when making a function using the default function constructor.
  • kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before a function declaration.
  • unrelated fix
  • kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

  • fast/js/resources/function-names.js: Added.
  • fast/js/function-names.html: Generated.
  • fast/js/function-names-expected.txt: Generated.

WebCore:

Reviewed by Maciej.

Test: fast/js/function-names.html

  • dom/Document.h: Add function name parameter to createHTMLEventListener.
  • dom/Document.cpp: (WebCore::Document::createHTMLEventListener): Pass function name when calling createHTMLEventHandler. (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name when calling createHTMLEventListener.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute name as function name when calling createHTMLEventListener.
  • khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name. (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.
  • khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and createSVGEventHandler.
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating a JSLazyEventListener. (WebCore::KJSProxy::createSVGEventHandler): Ditto.
  • ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to JSSVGLazyEventListener.
  • ksvg2/events/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name on to the base class constructor.
  • ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when calling createSVGEventHandler.
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner): Pass attribute name as function name when calling createSVGEventListener.
  • WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.
5:51 PM Changeset in webkit [13464] by tomernic
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Layout test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

  • fast/forms/button-default-title-expected.checksum: Added.
  • fast/forms/button-default-title-expected.png: Added.
  • fast/forms/button-default-title-expected.txt: Added.
  • fast/forms/button-default-title.html: Added.

WebCore:

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::valueWithDefault): Only use the default button title if no title was specified; previously we'd use the default button title if the specified title was empty, which is not what Firefox does.
5:20 PM Changeset in webkit [13463] by darin
  • 14 edits in trunk/LayoutTests
  • removed merge artifacts from .checksum files
  • fast/block/float/vertical-move-relayout-expected.checksum:
  • fast/css/first-letter-detach-expected.checksum:
  • fast/css/hover-subselector-expected.checksum:
  • fast/dom/Element/class-attribute-whitespace-expected.checksum:
  • fast/events/event-sender-mouse-moved-expected.checksum:
  • fast/forms/form-hides-table-expected.checksum:
  • fast/invalid/missing-address-end-tag-expected.checksum:
  • fast/invalid/missing-dl-end-tag-expected.checksum:
  • fast/invalid/missing-dt-end-tag-expected.checksum:
  • fast/invalid/missing-font-end-tag-expected.checksum:
  • fast/text/in-rendered-text-rtl-expected.checksum:
  • fast/tokenizer/missing-title-end-tag-1-expected.checksum:
  • fast/tokenizer/missing-title-end-tag-2-expected.checksum:
5:08 PM Changeset in webkit [13462] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Beth.

  • test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • fast/css/max-height-none-expected.checksum: Added.
  • fast/css/max-height-none-expected.txt: Added.
  • fast/css/max-height-none.html: Added.
  • fast/css/max-height-none-expected.png: Added.

WebCore:

Reviewed by Beth.

  • fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): For max-height of none, set it to Length(undefinedLength, Fixed), which is the correct value (same as the default). Also did some formatting fixes to the height section.
2:44 PM Changeset in webkit [13461] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed, tweaked, and landed by Beth.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

2:27 PM Changeset in webkit [13460] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Darin

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
REGRESSION: style change where :hover changes only an :after style
doesn't work

  • dom/Node.cpp: (WebCore::Node::diff): Need to call diff() on the before and after styles if we have them.
2:07 PM Changeset in webkit [13459] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

  • WebView/WebFramePrivate.h: Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is cancelled and when a redirect is successfully committed.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge reportClientRedirectCancelled:]): Call renamed WebFrame method.
  • WebView/WebFrame.m: Added sentRedirectNotification flag to WebFramePrivate. This flag is set when we notify the frame load delegate that a redirect will occur. We check this flag when committing a provisional load to ensure that the frame load delegate is notified that the redirect finished. (-[WebFrame _commitProvisionalLoad:]): After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending redirect. (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): Set the new sentRedirectNotification flag. (-[WebFrame _clientRedirectCancelledOrFinished:]): Renamed method. Clear the sentRedirectNotification flag. (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): Call renamed method.
1:58 PM Changeset in webkit [13458] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Added:

  • fast/forms/button-table-styles.txt: Added.
  • fast/forms/button-table-styles.png: Added.
  • fast/forms/button-table-styles.checksum: Added.
  • fast/forms/button-table-styles.html: Added.

WebCore:

Reviewed by Hyatt.

Test:
fast/forms/button-table-styles.html

  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): The theme should disallow table display styles form elements.
1:28 PM Changeset in webkit [13457] by tomernic
  • 1 edit in trunk/WebKit/ChangeLog

Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

1:17 PM Changeset in webkit [13456] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu
  • WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.
8:31 AM Changeset in webkit [13455] by darin
  • 12 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT, BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in one case and remove a _NPN_ReleaseObject in another because this should return a retained value. (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN, NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.
  • bindings/c/c_runtime.h: Removed implementations of CMethod::name and CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
  • bindings/c/c_runtime.cpp: (KJS::Bindings::CMethod::name): Added. Returns the string from inside the method object. (KJS::Bindings::CField::name): Added. Returns the string from inside the field object. (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue on the result of getProperty after using it to fix a storage leak. (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue after pasing a value to setProperty now that the conversion function does a retain.
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local stack buffer. Removed special case for NPVARIANT_IS_VOID because the convertNPVariantToValue function handles that properly. (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.
  • bindings/NP_jsobject.h: Formatting changes only.
  • bindings/NP_jsobject.cpp: (jsDeallocate): Changed parameter type so we don't need a function cast. (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT. (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT. (_NPN_Evaluate): Use VOID_TO_NPVARIANT. (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.
  • bindings/c/c_class.cpp: Formatting changes only.
  • bindings/c/c_class.h: Formatting changes only.
  • bindings/npruntime_priv.h: Removed obsolete and now-unused functions: NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined, NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble, NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool, NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString, NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid, NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined, NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32, NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString, NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
  • bindings/npruntime.cpp: (getIntIdentifierDictionary): Don't bother creating custom callbacks for the integer dictionary since the default behavior is fine for integers.
8:08 AM Changeset in webkit [13454] by darin
  • 2 edits in trunk/WebCore
  • generate-derived-sources: Tweaked formatting a tiny bit and removed a stray touch that was left in here.
7:36 AM Changeset in webkit [13453] by darin
  • 2 edits in trunk/WebKit

Reviewed by Eric.

  • fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu
  • WebView/WebDataSource.m: (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil. (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.
12:21 AM Changeset in webkit [13452] by eseidel
  • 3 edits in trunk/WebCore

2006-03-23 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

REGRESSION: Dashed borders paint with the wrong phase
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7879

Test: Already covered by css1/box_properties/border_style.html

  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLine):
Note: See TracTimeline for information about the timeline view.