Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Mar 29, 2006:

10:45 PM Changeset in webkit [13571] by justing

• 1 edit in trunk/WebCore/ChangeLog

Fixed a bug number.

10:38 PM Changeset in webkit [13570] by justing

• 15 edits
  8 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
REGRESSION: selectionRect includes next/previous replaced elements
<rdar://problems/4402375&4474871&4474871>

• editing/selection/4402375-expected.checksum: Added.
• editing/selection/4402375-expected.png: Added.
• editing/selection/4402375-expected.txt: Added.
• editing/selection/4402375.html: Added. Turned on dumpSelectionRect for these tests:
• editing/selection/replaced-boundaries-1-expected.checksum:
• editing/selection/replaced-boundaries-1-expected.png:
• editing/selection/replaced-boundaries-1.html:
• editing/selection/replaced-boundaries-2-expected.checksum:
• editing/selection/replaced-boundaries-2-expected.png:
• editing/selection/replaced-boundaries-2.html:
• editing/selection/replaced-boundaries-3-expected.checksum:
• editing/selection/replaced-boundaries-3-expected.png:
• editing/selection/replaced-boundaries-3.html:
• editing/selection/image-before-linebreak-expected.checksum: Added.
• editing/selection/image-before-linebreak-expected.png: Added.
• editing/selection/image-before-linebreak-expected.txt: Added.
• editing/selection/image-before-linebreak.html: Added.

WebCore:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
REGRESSION: selectionRect includes next/previous replaced elements
Also fixes: <rdar://problems/4402375&4474871&4474871>

In the case where a selection starts at the end or ends at the start
of o, o->selectionState() != SelectionNone, but o isn't really selected.
Constraining the selection with upstream and downstream eliminates these
types of endpoints, but constraining endpoints that occur at the
start or end of a paragraph creates positions inside containers - some
of which the selection painting code isn't equipped to handle.

• dom/Document.cpp: (WebCore::Document::updateSelection):
• rendering/render_replaced.cpp: (WebCore::RenderReplaced::shouldPaint): (WebCore::RenderReplaced::selectionRect): (WebCore::RenderReplaced::setSelectionState): (WebCore::RenderWidget::setSelectionState):

WebKitTools:

Reviewed by darin

<rdar://problem/4402375>
REGRESSION (417.8-TOT): selectionRect sometimes includes adjacent images

Added an option to draw the selectionRect.

• DumpRenderTree/DumpRenderTree.m: (dump): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (-[LayoutTestController dumpSelectionRect]): (dumpRenderTree):

10:16 PM Changeset in webkit [13569] by adele

• 3 edits in trunk/LayoutTests

Justin pointed out that this test should use an old-style form element,
so I changed the test to use <input type="password">.

• fast/events/event-sender-mouse-click-expected.txt:
• fast/events/event-sender-mouse-click.html:

6:39 PM Changeset in webkit [13568] by ggaren

• 20 edits in trunk

JavaScriptCore:

Reviewed by Darin.

• JavaScriptCore side of fix for <rdar://problem/4308243> 8F36 Regression: crash in malloc_consolidate if you use a .PAC file

The crash was a result of threaded deallocation of thread-unsafe
objects. Pure JS objects are thread-safe because all JS execution
is synchronized through JSLock. However, JS objects that wrap WebCore
objects are thread-unsafe because JS and WebCore execution are not
synchronized. That unsafety comes into play when the collector
deallocates a JS object that wraps a WebCore object, thus causing the
WebCore object to be deallocated.

The solution here is to have each JSCell know whether it is safe to
collect on a non-main thread, and to avoid collecting unsafe cells
when on a non-main thread.

We don't have a way to test PAC files yet, so there's no test
attached to this patch.

• kjs/collector.cpp: (KJS::Collector::collect):

(1) Added the test "currentThreadIsMainThread

imp->m_destructorIsThreadSafe".

• kjs/protect.h: (KJS::gcProtectNullTolerant): (KJS::gcUnprotectNullTolerant):
• kjs/value.h: (KJS::JSCell::JSCell): The bools here must be bitfields, otherwise m_destructorIsThreadSafe becomes another whole word, ruining the collector optimizations we've made based on the size of a JSObject.
• kxmlcore/FastMalloc.cpp: (KXMLCore::currentThreadIsMainThread): (KXMLCore::fastMallocRegisterThread):
• kxmlcore/FastMalloc.h:

WebCore:

Reviewed by Hyatt.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6986 Switch to use new text field implementation for <input type="text">

• css/html4.css: Added default style info for new text fields.
• rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla. (WebCore::RenderTextField::updateFromElement): Removed some outdated comments. Cleaned up the way we add text nodes to the div. (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange. (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred. (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
• rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border. (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css. We also add intrinsic margins here if the font size is large enough.
• html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): ditto. (WebCore::HTMLInputElement::focus): ditto. (WebCore::HTMLInputElement::selectionStart): ditto. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setSelectionStart): ditto. (WebCore::HTMLInputElement::setSelectionEnd): ditto. (WebCore::HTMLInputElement::select): ditto. (WebCore::HTMLInputElement::setSelectionRange): ditto. (WebCore::HTMLInputElement::createRenderer): ditto. (WebCore::HTMLInputElement::defaultEventHandler): ditto. (WebCore::HTMLInputElement::isMouseFocusable): Added. Old text fields relied on the widget to provide a focus policy. A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
• html/HTMLInputElement.h: Added isMouseFocusable.
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable): Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
• dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

5:49 PM Changeset in webkit [13567] by adele

• 118 edits in trunk

LayoutTests:

Reviewed by Hyatt.

Updated tests for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
Switch to use new text field implementation for <input type="text">

The new text field implementation uses RenderTextFielda instead of RenderLineEdits,
and this accounts for many of the changes here.

Also, background color and border properties are now dumped as part of the RenderTextField.

There is also an outstanding bug that affects many tests that make a selection in a text field.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8068
Editing delegate should not be notified when selection change involved new text field

Now that we support box-sizing, we count border and padding when calculating size, so some
of the tests that specify border size have different text field sizes.

• editing/selection/3690703-2-expected.checksum:
• editing/selection/3690703-2-expected.png:
• editing/selection/3690703-2-expected.txt:
• editing/selection/3690703-expected.checksum:
• editing/selection/3690703-expected.png:
• editing/selection/3690703-expected.txt:
• editing/selection/3690719-expected.checksum:
• editing/selection/3690719-expected.png:
• editing/selection/3690719-expected.txt:
• fast/block/float/032-expected.checksum:
• fast/block/float/032-expected.png:
• fast/block/float/032-expected.txt:
• fast/block/margin-collapse/103-expected.txt:
• fast/events/div-focus-expected.txt:
• fast/events/event-sender-mouse-click-expected.txt:
• fast/forms/access-key-expected.txt:
• fast/forms/element-by-name-expected.txt:
• fast/forms/focus-expected.txt:
• fast/forms/form-element-geometry-expected.checksum:
• fast/forms/form-element-geometry-expected.png:
• fast/forms/form-element-geometry-expected.txt:
• fast/forms/indeterminate-expected.checksum:
• fast/forms/indeterminate-expected.png:
• fast/forms/input-appearance-bkcolor-expected.checksum:
• fast/forms/input-appearance-bkcolor-expected.png:
• fast/forms/input-appearance-bkcolor-expected.txt:
• fast/forms/input-appearance-default-bkcolor-expected.checksum:
• fast/forms/input-appearance-default-bkcolor-expected.png:
• fast/forms/input-appearance-default-bkcolor-expected.txt:
• fast/forms/input-appearance-disabled-expected.checksum:
• fast/forms/input-appearance-disabled-expected.png:
• fast/forms/input-appearance-disabled-expected.txt:
• fast/forms/input-appearance-focus-expected.checksum:
• fast/forms/input-appearance-focus-expected.png:
• fast/forms/input-appearance-focus-expected.txt:
• fast/forms/input-appearance-maxlength-expected.txt:
• fast/forms/input-appearance-maxlength.html:
• fast/forms/input-appearance-minWidth-expected.checksum:
• fast/forms/input-appearance-minWidth-expected.png:
• fast/forms/input-appearance-minWidth-expected.txt:
• fast/forms/input-appearance-preventDefault-expected.checksum:
• fast/forms/input-appearance-preventDefault-expected.png:
• fast/forms/input-appearance-preventDefault-expected.txt:
• fast/forms/input-appearance-selection-expected.checksum:
• fast/forms/input-appearance-selection-expected.png:
• fast/forms/input-appearance-selection-expected.txt:
• fast/forms/input-appearance-visibility-expected.checksum:
• fast/forms/input-appearance-visibility-expected.png:
• fast/forms/input-appearance-visibility-expected.txt:
• fast/forms/input-appearance-width-expected.checksum:
• fast/forms/input-appearance-width-expected.png:
• fast/forms/input-appearance-width-expected.txt:
• fast/forms/input-baseline-expected.checksum:
• fast/forms/input-baseline-expected.png:
• fast/forms/input-baseline-expected.txt:
• fast/forms/input-changing-value-expected.txt:
• fast/forms/input-value-expected.txt:
• fast/forms/input-width-expected.txt:
• fast/forms/legend-access-key-expected.txt:
• fast/forms/selection-functions-expected.txt:
• fast/forms/textfield-focus-out-expected.txt:
• fast/replaced/width100percent-expected.checksum:
• fast/replaced/width100percent-expected.png:
• fast/replaced/width100percent-expected.txt:
• fast/table/003-expected.txt:
• fast/table/colspanMinWidth-expected.txt:
• fast/table/spanOverlapRepaint-expected.txt:
• tables/mozilla/bugs/45621-expected.txt:
• tables/mozilla/bugs/bug1188-expected.checksum:
• tables/mozilla/bugs/bug1188-expected.png:
• tables/mozilla/bugs/bug1188-expected.txt:
• tables/mozilla/bugs/bug12384-expected.checksum:
• tables/mozilla/bugs/bug12384-expected.png:
• tables/mozilla/bugs/bug12384-expected.txt:
• tables/mozilla/bugs/bug18359-expected.checksum:
• tables/mozilla/bugs/bug18359-expected.png:
• tables/mozilla/bugs/bug18359-expected.txt:
• tables/mozilla/bugs/bug24200-expected.txt:
• tables/mozilla/bugs/bug2479-3-expected.txt:
• tables/mozilla/bugs/bug2479-4-expected.txt:
• tables/mozilla/bugs/bug28928-expected.txt:
• tables/mozilla/bugs/bug4382-expected.txt:
• tables/mozilla/bugs/bug4527-expected.txt:
• tables/mozilla/bugs/bug46368-1-expected.txt:
• tables/mozilla/bugs/bug46368-2-expected.txt:
• tables/mozilla/bugs/bug51037-expected.txt:
• tables/mozilla/bugs/bug55545-expected.checksum:
• tables/mozilla/bugs/bug55545-expected.png:
• tables/mozilla/bugs/bug55545-expected.txt:
• tables/mozilla/bugs/bug59354-expected.txt:
• tables/mozilla/bugs/bug7342-expected.checksum:
• tables/mozilla/bugs/bug7342-expected.png:
• tables/mozilla/bugs/bug7342-expected.txt:
• tables/mozilla/bugs/bug96334-expected.checksum:
• tables/mozilla/bugs/bug96334-expected.png:
• tables/mozilla/bugs/bug96334-expected.txt:
• tables/mozilla/bugs/bug99948-expected.txt:
• tables/mozilla/dom/tableDom-expected.txt:
• tables/mozilla/other/move_row-expected.txt:
• tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
• tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
• tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
• tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
• tables/mozilla_expected_failures/bugs/bug45621-expected.checksum:
• tables/mozilla_expected_failures/bugs/bug45621-expected.png:
• tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
• tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

Reviewed by Hyatt.

• Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6986 Switch to use new text field implementation for <input type="text">

• css/html4.css: Added default style info for new text fields.
• rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla. (WebCore::RenderTextField::updateFromElement): Removed some outdated comments. Cleaned up the way we add text nodes to the div. (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange. (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred. (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
• rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
• rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border. (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css. We also add intrinsic margins here if the font size is large enough.
• html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): ditto. (WebCore::HTMLInputElement::focus): ditto. (WebCore::HTMLInputElement::selectionStart): ditto. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setSelectionStart): ditto. (WebCore::HTMLInputElement::setSelectionEnd): ditto. (WebCore::HTMLInputElement::select): ditto. (WebCore::HTMLInputElement::setSelectionRange): ditto. (WebCore::HTMLInputElement::createRenderer): ditto. (WebCore::HTMLInputElement::defaultEventHandler): ditto. (WebCore::HTMLInputElement::isMouseFocusable): Added. Old text fields relied on the widget to provide a focus policy. A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
• html/HTMLInputElement.h: Added isMouseFocusable.
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable): Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
• dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

3:47 PM Changeset in webkit [13566] by darin

• 5 edits
  4 adds in trunk

LayoutTests:

Reviewed by Eric.

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8026 A particular animated SVG crashes in filter code <rdar://problem/4494775> A particular animated SVG crashes in filter code

• svg/custom/empty-merge-expected.checksum: Added.
• svg/custom/empty-merge-expected.png: Added.
• svg/custom/empty-merge-expected.txt: Added.
• svg/custom/empty-merge.svg: Added.

WebCore:

Reviewed by Eric.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8026 A particular animated SVG crashes in filter code <rdar://problem/4494775> A particular animated SVG crashes in filter code

• fix some code that is not handling references correctly for GC

Test: svg/custom/empty-merge.svg

• kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): Use KWQRetainNSRelease to properly retain a reference to an Objective-C object in a C++ class. (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): Use KWQRelease instead of release. (WebCore::KCanvasFilterQuartz::prepareFilter): Use KWQRetain instead of retain. (WebCore::KCanvasFilterQuartz::applyFilter): Use KWQRelease instead of release. (WebCore::KCanvasFilterQuartz::imageForName): Use objectForKey: instead of valueForKey: on the dictionary to sidestep a bug in valueForKey: on empty strings and because what we're doing with a dictionary here has nothing to do with key value encoding.

• kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz): Use KWQRelease instead of release. (WebCore::KRenderingDeviceContextQuartz::nsGraphicsContext): Use KWQRetain instead of retain to properly retain a reference to an Objective-C object in a C++ class.

• platform/mac/ImageMac.mm: (WebCore::Image::invalidateNativeData): Use CFRelease instead of release. (WebCore::Image::getNSImage): Use KWQRetainNSRelease to properly retain a reference to an Objective-C object in a C++ class.

3:42 PM Changeset in webkit [13565] by darin

• 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

• make the global initializer check work on Xcode 2.1 (although it's better on 2.2)

• Scripts/check-for-global-initializers: Use NATIVE_ARCH if there is no CURRENT_ARCH.

2:13 PM Changeset in webkit [13564] by tomernic

• 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4495316> REGRESSION (420+): After page has loaded, spinning progress indicator is displayed on
tab at versiontracker.com

• WebView/WebFrame.m: (-[WebFrame _receivedMainResourceError:]): Call -_clientRedirectCancelledOrFinished: here so that the frame load delegate is notified that the redirect's status has changed, if there was a redirect. The frame load delegate may have saved some state about the redirect in its -webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:. Since we are definitely not going to use this provisional resource, as it was cancelled, notify the frame load delegate that the redirect has ended. The fix for 4432562 was similar to this, but only took care of the case where the redirect load was actually committed to the frame. The new call to -_clientRedirectCancelledOrFinished: handles the case where the redirect load was successful, but was not committed. This happens with downloads.

2:11 PM Changeset in webkit [13563] by ggaren

• 5 edits
  2 adds in trunk

LayoutTests:

• Layout test for <rdar://problem/4477126> TOT REGRESSION: with release build, maps.google.com zoom slider always zooms fully out

• fast/events/mouseclick-target-and-positioning-expected.txt: Added.
• fast/events/mouseclick-target-and-positioning.html: Added.

WebCore:

Reviewed by Darin.

• Fixed <rdar://problem/4477126> TOT REGRESSION: with release build, maps.google.com zoom slider always zooms fully out

There were 2 problems: (1) A syntax error in the UIEvent IDL file
prevented some things from showing up in the bindings; (2)
MouseEvent had a duplicate isSimulated property that shadowed
MouseRelatedEvent's isSimulated property, and MouseEvent failed to
initialize MouseRelatedEvent's isSimulated property.

• dom/UIEvent.idl:
• dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEvent::MouseRelatedEvent): (WebCore::MouseEvent::MouseEvent):
• dom/dom2_eventsimpl.h:

1:42 PM Changeset in webkit [13562] by tomernic

• 2 edits in trunk/WebCore

Reviewed by Darin.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setInputType): If the input type is dynamically changed, reevaluate whether the element maintains its state (this decision is based on the input's type). Fixes an assertion error when leaving a page with a text field that had been dynamically changed to a password field.

1:41 PM Changeset in webkit [13561] by sullivan

• 5 edits in trunk/WebKit

Reviewed by Tim Omernick.

• fixed these bugs: <rdar://problem/4483806> REGRESSION (417.8-TOT): PDFs don't scale correctly with auto-size (5356) <rdar://problem/3874856> Safari PDF display should be full width by default rather than sized to show the entire page

• WebView/WebPDFRepresentation.m: (-[WebPDFRepresentation finishedLoadingWithDataSource:]): Let the WebPDFView handle setting the document, because that's the best time to apply the sizing-related preferences.

• WebView/WebPDFView.h: eliminated firstLayoutDone ivar and -PDFSubview public method; added -setPDFDocument:

• WebView/WebPDFView.m: (-[WebPDFView initWithFrame:]): eliminate use of obsolete firstLayoutDone ivar (-[WebPDFView _applyPDFDefaults]): renamed from _readPDFDefaults for clarity (-[WebPDFView layout]): removed code that applied the preferences here. This was too early to handle auto-sizing correctly, because -layout can be called before the document exists, and calling setAutoSize:YES at that point confuses PDFView into setting the scale factor to 20 (the maximum). (-[WebPDFView setPDFDocument:]): New method, does what WebPDFRepresentation used to do and also applies the preferences here. This is a good place to apply them because the document is guaranteed to now exist (of course). (-[WebPDFView PDFSubview]): Moved this into a new FileInternal category because it's still needed by another class in this file but no longer needs to be public.

• WebView/WebPreferences.m: (+[WebPreferences initialize]): Change WebKitPDFScaleFactorPreferenceKey to 0, which represents auto-size. This fixes 3874856, but wasn't feasible until 4483806 was fixed.

9:37 AM Changeset in webkit [13560] by ap

• 2 edits in trunk/WebCore

Reviewed by Darin.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8055 Fix most CSS grammar conflicts.

Gets the number of shift/reduce and reduce/reduce conflicts down from 37+4 to 7+0.

I have fixed the reduce/reduce conflicts, then noticed that two of the fixes
were already made in KDE tree (the other two are different because declaration
blocks are described in quite different ways). Shift/reduce fixes are just
merged from KDE, r332845 by Michael Matz.

• css/CSSGrammar.y:

7:57 AM Changeset in webkit [13559] by ap

• 3 edits
  4 adds in trunk

Reviewed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7157 An asterisk in a CSS property name breaks CSS handling (Many layout problems at letras.terra.com.br)

Test: fast/css/error-in-last-decl.html

• css/CSSGrammar.y: Added a rule for the case when the last CSS rule has a syntax error, and doesn't end with a semicolon.

7:09 AM Changeset in webkit [13558] by darin

• 6 edits
  1 add in trunk/WebCore

2006-03-29 Darin Adler <Darin Adler>

Reviewed by Anders.

• another cut at fixing the buildbot

• generate-derived-sources: Fix if statement that was always following the Windows case. I believe this is the main problem.

• WebCore.xcodeproj/project.pbxproj: Added CharsetData.h and added CharsetData.cpp to the target.
• WebCore.vcproj/WebCore/WebCore.vcproj: Similar changes.

• platform/CharsetData.h: Added.
• platform/CharsetNames.cpp: Moved the actual character set data out into a separate source file instead of include a .cpp file.

• platform/make-charset-table.pl: Changed to generate a file that can stand alone.

6:29 AM Changeset in webkit [13557] by darin

• 2 edits in trunk/WebCore

2006-03-29 Darin Adler <Darin Adler>

• an attempt to fix the buildbot

• platform/mac/mac-encodings.txt: Touched this file so the character encodings files will be regenerated.

3:22 AM Changeset in webkit [13556] by darin

• 2 edits in trunk/WebCore

2006-03-29 Darin Adler <Darin Adler>

• a quick cut at fixing the windows build

• WebCore.vcproj/WebCore/WebCore.vcproj: Added a few recently-added files.

1:38 AM Changeset in webkit [13555] by mjs

• 7 edits
  3 adds in trunk

LayoutTests:

Reviewed by Anders.

Test cases for Element.contains, including testing fix for
<rdar://problem/4405353> JavaScript flickers popups onmouseover

• fast/dom/Element/contains-method-expected.txt: Added.
• fast/dom/Element/contains-method.html: Added.
• fast/dom/Element/resources/contains-method.js: Added.
• fast/events/capture-on-target.html:

WebCore:

Reviewed by Anders.

• fixed <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating

Also fixed other issues with contains. The problem that caused the bug was:

• contains should return true for the element itself, unlike isAncestor

Other problems I fixed:

• contains shouldn't be present on non-Element nodes
• contains should return false when passed a non-Element node
• contains should return false when passed a non-Node

• bindings/scripts/CodeGeneratorJS.pm: Handle Element as a parameter.
• dom/Element.cpp: (WebCore::Element::contains): Added new implementation.
• dom/Element.h: Added prototype for contains.
• dom/Element.idl: Added IDL declaration for contains.
• khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction): Added old wrong contains().

Mar 28, 2006:

9:11 PM Changeset in webkit [13554] by bdakin

• 1 edit in trunk/WebCore/ChangeLog

Fixing typo from last commit.

9:07 PM Changeset in webkit [13553] by bdakin

• 7 edits
  4 adds in trunk

Reviewed by Maciej

Fix for <rdar://problem/4493218> repro crash in
khtml::RenderBlock::repaintFloatingDescendants with giant
cellspacing value

Some callers of CSSPrimitiveValue::computeLength() expect an int,
and others a short. This patch splits computerLength() into
computeIntLength() and computeShortLength() so that the appropriate
bounds can be checked.

8:23 PM Changeset in webkit [13552] by ap

• 3 edits
  2 adds in trunk

Reviewed by Maciej.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4616 Setting nodeValue on a textnode with collapsed whitespace only has no visual effect

Test: fast/dom/space-to-text.html

• dom/CharacterData.cpp: (WebCore::CharacterData::setData): Create a renderer if it's needed, but missing. (WebCore::CharacterData::appendData): Ditto. (WebCore::CharacterData::insertData): Ditto. (WebCore::CharacterData::replaceData): Ditto.

7:02 PM Changeset in webkit [13551] by tomernic

• 2 edits
  2 adds in trunk/WebCore

Reviewed by Maciej.

<rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating
to another page while selecting inside textarea inside iframe

• kwq/WebCoreTextArea.mm: (-[WebCoreTextArea mouseDown:]): Guard super's -mouseDown: with calls to Widget::beforeMouseDown() and Widget::afterMouseDown(). Other widgets do this to protect against being removed from the page and deallocated while handling mouse down events. (-[WebCoreTextView mouseDown:]): ditto

• manual-tests/textarea-iframe-navigation.html: Added.
• manual-tests/textarea-iframe-navigation2.html: Added. Manual test case for this fix.

6:48 PM Changeset in webkit [13550] by eseidel

• 2 edits in trunk/WebCore

2006-03-28 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4402170> CrashTracer: 499 crashes in Safari at com.apple.WebCore: DOM::DocumentImpl::open + 16

• dom/Document.cpp: (WebCore::Document::write): Fix unreproducible infinite recursion.

6:46 PM Changeset in webkit [13549] by eseidel

• 8 edits in trunk

2006-03-28 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Remove global initializers.

• kcanvas/device/quartz/KCanvasFilterQuartz.mm:
• ksvg2/svg/SVGAngle.cpp:
• ksvg2/svg/SVGColor.cpp:
• ksvg2/svg/SVGLength.cpp:

6:35 PM Changeset in webkit [13548] by eseidel

• 15 edits
  3 adds in trunk

2006-03-28 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Switch UIEvent, MouseEvent and KeyboardEvent over to
be new auto-generated bindings.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7928

Updated test: fast/dom/prototype-chain.html

• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOMEvents.mm: (-[DOMEvent ::]): (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
• bindings/scripts/CodeGeneratorJS.pm:
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
• dom/KeyboardEvent.idl: Added.
• dom/MouseEvent.idl: Added.
• dom/UIEvent.idl: Added.
• dom/WheelEvent.idl:
• dom/dom2_eventsimpl.cpp: (WebCore::MouseEvent::MouseEvent): (WebCore::MouseEvent::initMouseEvent):
• dom/dom2_eventsimpl.h: (WebCore::MouseEvent::relatedTarget): (WebCore::MouseEvent::clipboard):
• generate-derived-sources:
• khtml/ecma/kjs_dom.cpp: (KJS::toEventTargetNode):
• khtml/ecma/kjs_dom.h:
• khtml/ecma/kjs_events.cpp: (KJS::toJS):
• khtml/ecma/kjs_events.h:

6:23 PM Changeset in webkit [13547] by darin

• 9 edits in trunk/WebCore

Reviewed by Eric.

• replace getDocument with document in a few places that Geoff missed

• WebCore.xcodeproj/project.pbxproj:
• dom/Attr.cpp: (WebCore::Attr::createTextChild): (WebCore::Attr::setValue): (WebCore::Attr::cloneNode):
• dom/Attribute.cpp: (WebCore::Attribute::createAttrIfNeeded):
• dom/Element.cpp: (WebCore::Element::cloneNode): (WebCore::inHTMLDocument): (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::createStyleForRenderer): (WebCore::Element::createRenderer): (WebCore::Element::recalcStyle): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::updateId): (WebCore::Element::removeAttributeNode): (WebCore::Element::focus): (WebCore::Element::blur):
• dom/NamedAttrMap.cpp: (WebCore::inHTMLDocument): (WebCore::NamedAttrMap::setNamedItem):
• dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::parseClassAttribute):
• dom/StyledElement.cpp: (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::parseMappedAttribute): (WebCore::StyledElement::createMappedDecl):

• added missing include that seems to be breaking the Windows build

• platform/String.cpp: Include <stdarg.h>.

6:10 PM Changeset in webkit [13546] by eseidel

• 3 edits in trunk/LayoutTests

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

Make plug-ins test dump as test.

• fast/dom/Window/Plug-ins-expected.txt:
• fast/dom/Window/Plug-ins.html:

6:01 PM Changeset in webkit [13545] by thatcher

• 2 edits in trunk/WebKitTools

Reviewed by Darin.

Exit gracefully if $ENV{'CURRENT_ARCH'} is undefined. Rolling out my previous change.

• Scripts/check-for-global-initializers:

5:50 PM Changeset in webkit [13544] by thatcher

• 2 edits in trunk/WebKitTools

Build fix. Turn off uninitialized warnings for the first block of code.

• Scripts/check-for-global-initializers:

4:21 PM Changeset in webkit [13543] by ggaren

• 94 edits in trunk/WebCore

Reviewed by Beth.

• Global replace of getDocument() with document(). Darin suggested this in his review of my EventTargetNode patch. It matches the style of methods like ownerDocument().

• Changed getDocument() to document(); changed data member document to m_document; changed stack variable document to doc.

• bindings/objc/DOM.mm: (-[DOMNode ownerDocument]): (-[DOMNode KJS::Bindings::]): (-[DOMElement _getURLAttribute:]):
• bindings/objc/DOMHTML.mm: (-[DOMHTMLElement titleDisplayString]): (-[DOMHTMLInputElement altDisplayString]): (-[DOMHTMLAnchorElement blur]): (-[DOMHTMLAnchorElement focus]): (-[DOMHTMLImageElement altDisplayString]): (-[DOMHTMLAppletElement altDisplayString]): (-[DOMHTMLAreaElement altDisplayString]):
• bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
• bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateDashboardRegions):
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge initSubframeWithRenderer:]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
• css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/css_base.cpp: (WebCore::StyleBase::baseURL):
• css/css_stylesheetimpl.cpp: (WebCore::CSSStyleSheet::CSSStyleSheet):
• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::locateSharedStyle): (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement): (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
• dom/AbstractView.cpp: (WebCore::AbstractView::AbstractView):
• dom/CDATASection.cpp: (WebCore::CDATASection::cloneNode): (WebCore::CDATASection::createNew):
• dom/CharacterData.cpp: (WebCore::CharacterData::setData): (WebCore::CharacterData::insertData): (WebCore::CharacterData::deleteData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::dispatchModifiedEvent):
• dom/Comment.cpp: (WebCore::Comment::cloneNode):
• dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::getUpperLeftCorner): (WebCore::dispatchChildInsertionEvents): (WebCore::dispatchChildRemovalEvents):
• dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
• dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::createDocumentFragment): (WebCore::Document::adoptNode): (WebCore::Document::createElementNS): (WebCore::Document::nodeAbsIndex): (WebCore::Document::setFocusNode): (WebCore::Document::topDocument):
• dom/DocumentFragment.cpp: (WebCore::DocumentFragment::cloneNode):
• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::~EventTargetNode): (WebCore::EventTargetNode::insertedIntoDocument): (WebCore::EventTargetNode::removedFromDocument): (WebCore::EventTargetNode::addEventListener): (WebCore::EventTargetNode::removeEventListener): (WebCore::EventTargetNode::dispatchGenericEvent): (WebCore::EventTargetNode::dispatchEvent): (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent): (WebCore::EventTargetNode::dispatchWindowEvent): (WebCore::EventTargetNode::dispatchUIEvent): (WebCore::EventTargetNode::dispatchKeyEvent): (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent): (WebCore::EventTargetNode::removeHTMLEventListener):
• dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::setDocument): (WebCore::Node::setChanged): (WebCore::Node::checkSetPrefix): (WebCore::Node::checkAddChild): (WebCore::Node::attach): (WebCore::Node::detach): (WebCore::Node::createRendererIfNeeded): (WebCore::Node::rendererIsNeeded): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::ownerDocument): (WebCore::Node::setTextContent):
• dom/Node.h: (WebCore::Node::document): (WebCore::Node::inDocument):
• dom/NodeList.cpp: (WebCore::NodeList::itemById):
• dom/Position.cpp: (WebCore::Position::documentElement):
• dom/Range.cpp: (WebCore::Range::commonAncestorContainer): (WebCore::Range::setStart): (WebCore::Range::setEnd): (WebCore::Range::compareBoundaryPoints): (WebCore::Range::insertNode): (WebCore::Range::text): (WebCore::Range::setStartAfter): (WebCore::Range::setEndBefore): (WebCore::Range::setEndAfter): (WebCore::Range::surroundContents): (WebCore::Range::setStartBefore): (WebCore::rangeOfContents):
• dom/Text.cpp: (WebCore::Text::cloneNode): (WebCore::Text::createNew):
• dom/dom2_eventsimpl.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
• dom/dom2_traversalimpl.cpp: (WebCore::NodeIterator::NodeIterator):
• dom/dom_elementimpl.cpp: (WebCore::Attribute::createAttrIfNeeded): (WebCore::Attr::createTextChild): (WebCore::Attr::setValue): (WebCore::Attr::cloneNode): (WebCore::Element::cloneNode): (WebCore::inHTMLDocument): (WebCore::Element::setAttribute): (WebCore::Element::setAttributeMap): (WebCore::Element::createStyleForRenderer): (WebCore::Element::createRenderer): (WebCore::Element::recalcStyle): (WebCore::Element::dispatchAttrRemovalEvent): (WebCore::Element::dispatchAttrAdditionEvent): (WebCore::Element::updateId): (WebCore::Element::removeAttributeNode): (WebCore::Element::focus): (WebCore::Element::blur): (WebCore::NamedAttrMap::setNamedItem): (WebCore::NamedMappedAttrMap::parseClassAttribute): (WebCore::StyledElement::createInlineStyleDecl): (WebCore::StyledElement::parseMappedAttribute): (WebCore::StyledElement::createMappedDecl):
• dom/dom_xmlimpl.cpp: (WebCore::EntityReference::cloneNode): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::sheetLoaded): (WebCore::ProcessingInstruction::setStyleSheet):
• dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
• editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode):
• editing/Selection.cpp: (WebCore::Selection::toRange):
• editing/SelectionController.cpp: (WebCore::SelectionController::~SelectionController): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): (WebCore::SelectionController::frame): (WebCore::SelectionController::layout): (WebCore::SelectionController::needsCaretRepaint):
• editing/TextIterator.cpp: (WebCore::TextIterator::range): (WebCore::SimplifiedBackwardsTextIterator::range):
• editing/VisiblePosition.cpp: (WebCore::VisiblePosition::init): (WebCore::makeRange):
• editing/markup.cpp: (WebCore::startMarkup): (WebCore::shouldSelfClose): (WebCore::markup): (WebCore::createMarkup):
• editing/visible_units.cpp: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::inSameDocument):
• html/HTMLCollection.cpp: (WebCore::HTMLCollection::HTMLCollection): (WebCore::HTMLCollection::resetCollectionInfo):
• html/HTMLElement.cpp: (WebCore::HTMLElement::nodeName): (WebCore::HTMLElement::cloneNode): (WebCore::HTMLElement::innerText): (WebCore::HTMLElement::createContextualFragment): (WebCore::HTMLElement::setInnerText): (WebCore::HTMLElement::setOuterText): (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::contentEditable): (WebCore::HTMLElement::toString): (WebCore::HTMLElement::childAllowed): (WebCore::HTMLElement::setHTMLEventListener):
• html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formWouldHaveSecureSubmission): (WebCore::HTMLFormElement::attach): (WebCore::HTMLFormElement::insertedIntoDocument): (WebCore::HTMLFormElement::removedFromDocument): (WebCore::HTMLFormElement::formData): (WebCore::HTMLFormElement::prepareSubmit): (WebCore::HTMLFormElement::submit): (WebCore::HTMLFormElement::reset): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement):
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::attach): (WebCore::HTMLGenericFormElement::insertedIntoTree): (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::defaultEventHandler): (WebCore::HTMLInputElement::src):
• html/HTMLKeygenElement.cpp: (WebCore::HTMLKeygenElement::appendFormData):
• html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::formElement):
• html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::text): (WebCore::HTMLOptionElement::setText):
• html/HTMLParser.cpp: (WebCore::HTMLParser::HTMLParser):
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::~HTMLSelectElement):
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement): (WebCore::HTMLTextAreaElement::setDefaultValue):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer):
• html/html_baseimpl.cpp: (WebCore::HTMLBodyElement::createLinkDecl): (WebCore::HTMLBodyElement::mapToEntry): (WebCore::HTMLBodyElement::parseMappedAttribute): (WebCore::HTMLBodyElement::insertedIntoDocument): (WebCore::HTMLFrameElement::isURLAllowed): (WebCore::HTMLFrameElement::openURL): (WebCore::HTMLFrameElement::attach): (WebCore::HTMLFrameElement::close): (WebCore::HTMLFrameElement::contentFrame): (WebCore::HTMLFrameElement::frameWidth): (WebCore::HTMLFrameElement::frameHeight): (WebCore::HTMLFrameSetElement::parseMappedAttribute): (WebCore::HTMLIFrameElement::parseMappedAttribute): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach): (WebCore::HTMLIFrameElement::src):
• html/html_blockimpl.cpp: (WebCore::HTMLParagraphElement::checkDTD):
• html/html_headimpl.cpp: (WebCore::HTMLBaseElement::removedFromDocument): (WebCore::HTMLBaseElement::process): (WebCore::HTMLLinkElement::setDisabledState): (WebCore::HTMLLinkElement::parseMappedAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::setStyleSheet): (WebCore::HTMLLinkElement::sheetLoaded): (WebCore::HTMLLinkElement::href): (WebCore::HTMLMetaElement::process): (WebCore::HTMLScriptElement::childrenChanged): (WebCore::HTMLScriptElement::parseMappedAttribute): (WebCore::HTMLScriptElement::insertedIntoDocument): (WebCore::HTMLScriptElement::evaluateScript): (WebCore::HTMLScriptElement::setText): (WebCore::HTMLScriptElement::src): (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::removedFromDocument): (WebCore::HTMLStyleElement::childrenChanged): (WebCore::HTMLStyleElement::sheetLoaded): (WebCore::HTMLTitleElement::insertedIntoDocument): (WebCore::HTMLTitleElement::removedFromDocument): (WebCore::HTMLTitleElement::childrenChanged): (WebCore::HTMLTitleElement::setText):
• html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::~HTMLImageLoader): (WebCore::HTMLImageLoader::updateFromElement): (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElement::parseMappedAttribute): (WebCore::HTMLImageElement::insertedIntoDocument): (WebCore::HTMLImageElement::removedFromDocument): (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::src): (WebCore::HTMLMapElement::~HTMLMapElement): (WebCore::HTMLMapElement::parseMappedAttribute): (WebCore::HTMLAreaElement::href):
• html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::href): (WebCore::HTMLAnchorElement::blur): (WebCore::HTMLAnchorElement::focus):
• html/html_objectimpl.cpp: (WebCore::HTMLAppletElement::parseMappedAttribute): (WebCore::HTMLAppletElement::insertedIntoDocument): (WebCore::HTMLAppletElement::removedFromDocument): (WebCore::HTMLAppletElement::createRenderer): (WebCore::HTMLAppletElement::getAppletInstance): (WebCore::HTMLEmbedElement::getEmbedInstance): (WebCore::HTMLEmbedElement::parseMappedAttribute): (WebCore::HTMLEmbedElement::rendererIsNeeded): (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::removedFromDocument): (WebCore::HTMLObjectElement::getObjectInstance): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::rendererIsNeeded): (WebCore::HTMLObjectElement::insertedIntoDocument): (WebCore::HTMLObjectElement::removedFromDocument): (WebCore::HTMLObjectElement::updateDocNamedItem): (WebCore::HTMLParamElement::parseMappedAttribute):
• html/html_tableimpl.cpp: (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTablePartElement::mapToEntry): (WebCore::HTMLTablePartElement::parseMappedAttribute): (WebCore::HTMLTableSectionElement::insertRow): (WebCore::HTMLTableRowElement::insertCell):
• khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::~DOMNode): (KJS::DOMNode::mark): (KJS::DOMElement::getValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity): (KJS::toJS):
• khtml/ecma/kjs_html.cpp: (KJS::JSHTMLElement::implementsCall): (KJS::JSHTMLElement::bodyGetter): (KJS::JSHTMLElement::anchorGetter): (KJS::JSHTMLElement::getValueProperty): (KJS::JSHTMLElement::bodySetter):
• khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
• khtml/ecma/kjs_views.cpp: (KJS::DOMAbstractViewProtoFunc::callAsFunction):
• khtml/xbl/xbl_binding.cpp: (XBL::XBLBindingChain::failed): (XBL::m_nextBinding): (XBL::XBLBinding::setXBLDocument):
• khtml/xbl/xbl_protobinding.cpp: (XBL::XBLPrototypeBinding::document):
• khtml/xsl/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet):
• khtml/xsl/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): (WebCore::xmlDocPtrFromNode): (WebCore::XSLTProcessor::transformToString):
• ksvg2/svg/SVGAElement.cpp: (SVGAElement::defaultEventHandler):
• ksvg2/svg/SVGAnimateColorElement.cpp: (SVGAnimateColorElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateElement.cpp: (SVGAnimateElement::handleTimerEvent):
• ksvg2/svg/SVGAnimateTransformElement.cpp: (SVGAnimateTransformElement::handleTimerEvent):
• ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::closeRenderer):
• ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
• ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
• ksvg2/svg/SVGHelper.cpp: (SVGHelper::PercentageOfViewport):
• ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
• ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
• ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
• ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::addSVGWindowEventListner):
• ksvg2/svg/SVGSetElement.cpp: (SVGSetElement::handleTimerEvent):
• ksvg2/svg/SVGStyleElement.cpp: (SVGStyleElement::childrenChanged):
• ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::canvas):
• ksvg2/svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::closeRenderer): (WebCore::SVGTitleElement::insertedIntoDocument): (WebCore::SVGTitleElement::removedFromDocument): (WebCore::SVGTitleElement::childrenChanged):
• ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):
• kwq/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]): (-[WebCoreAXObject accessibilityAttributeValue:]):
• page/Frame.cpp: (WebCore::parentFromOwnerRenderer): (WebCore::Frame::frameForNode): (WebCore::Frame::clearDocumentFocus):
• page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent):
• rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
• rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::RenderCanvas): (WebCore::RenderCanvas::paintBoxDecorations): (WebCore::RenderCanvas::repaintViewRectangle):
• rendering/RenderImage.cpp: (WebCore::RenderImage::imageMap):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
• rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::isRoot): (WebCore::RenderObject::backslashAsCurrencySymbol):
• rendering/RenderObject.h: (WebCore::RenderObject::document):
• rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused):
• rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
• rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): (WebCore::RenderWidget::focusIn): (WebCore::RenderWidget::focusOut):

4:11 PM Changeset in webkit [13542] by darin

• 6 edits in trunk

JavaScriptGlue:

Reviewed by Geoff.

• added a build step that checks for init routines

• JavaScriptGlue.xcodeproj/project.pbxproj: Added a custom build phase that invokes the check-for-global-initializers script.

WebCore:

Reviewed by Geoff.

• added a build step that checks for init routines

• WebCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that was replaced by the generate-derived-sources script a while back. Added a custom build phase that invokes the check-for-global-initializers script.

WebKit:

Reviewed by Geoff.

• added a build step that checks for init routines

• WebKit.xcodeproj/project.pbxproj: Added a custom build phase that invokes the check-for-global-initializers script.

4:09 PM Changeset in webkit [13541] by darin

• 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

• change some code that resulted in init routines on Mac OS X -- if the framework has init routines it will use memory and slow down applications that link with WebKit even in cases where those applications don't use WebKit

• kjs/date_object.cpp: Changed constants that were derived by multiplying other constants to use immediate numbers instead. Apparently, double constant expressions of the type we had here are evaluated at load time.

• kjs/list.cpp: Can't use OwnArrayPtr in ListImp because of the global instances of ListImp, so go back to using a plain old pointer. (KJS::List::List): Set overflow to 0 when initializing ListImp. (KJS::List::release): Replace a clear call with a delete and explicit set to 0. (KJS::List::append): Use raw pointers, and do a delete [] instead of finessing it with a swap of OwnArrayPtr. (KJS::List::copyFrom): Remove now-unneeded get(). (KJS::List::copyTail): Ditto.

• kjs/ustring.cpp: Changed UString::Rep::empty initializer a bit so that it doesn't get a static initializer routine. Had to get rid of one level of constant to get the compiler to understand it could initialize without any code.

• added a build step that checks for init routines

• JavaScriptCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that was replaced by the generate-derived-sources script a while back. Added a custom build phase that invokes the check-for-global-initializers script.

4:03 PM Changeset in webkit [13540] by thatcher

• 5 copies in tags/Safari-521.9

New tag.

3:59 PM Changeset in webkit [13539] by darin

• 1 edit
  1 add in trunk/WebKitTools

Reviewed by Geoff.

• Scripts/check-for-global-initializers: Added.

3:58 PM Changeset in webkit [13538] by thatcher

• 1 delete in tags/Safari-521.9

Old tag that was never used. Will replace

3:52 PM Changeset in webkit [13537] by thatcher

• 2 edits in trunk/JavaScriptCore

Reviewed by Eric.

fixes <rdar://problem/4458539> Unable to include Security(public) and WebKit(private) headers

• bindings/npapi.h: added #defines after the #ifndefs

3:37 PM Changeset in webkit [13536] by thatcher

• 3 edits in trunk/WebCore

Reviewed by Maciej.

Moved the derived sources script to an agregate target. Fixes internal builds.

• WebCore.xcodeproj/project.pbxproj:
• generate-derived-sources: was missing a use of $CREATE_HASH_TABLE

1:36 PM Changeset in webkit [13535] by eseidel

• 3 edits in trunk/WebCore

2006-03-28 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Build fix.

• dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::error):

1:07 PM Changeset in webkit [13534] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView initWithFrame:]): Don't observe preferences changes here -- we only want to observe preferences while the view is installed in the view hierarchy. Plugins will appropriately start and stop themselves when added to or removed from a window. (-[WebBaseNetscapePluginView dealloc]): Don't remove observers here -- they should have been removed when the view was removed from its window. (-[WebBaseNetscapePluginView finalize]): ditto (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): Stop observing preferences when the view is removed from its window. (-[WebBaseNetscapePluginView viewDidMoveToWindow]): Start observing preferences when the view is added to a window.

11:07 AM Changeset in webkit [13533] by darin

• 4 edits in trunk/WebCore

Reviewed, tweaked, landed by Darin.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8023 Attribute.h missing class predeclaration

• dom/Attribute.h: Add declarations for classes so that the friend declaration is not the only one. There's an issue with either an earlier or later version of gcc, which is why we see this only on certain platforms.

• dom/Attr.cpp: (WebCore::Attr::Attr): (WebCore::Attr::~Attr):
• dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::clearAttributes): (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute): Change places where practical to use attr() instead of m_impl in the vain hope of removing the need for the friend declarations.

10:34 AM Changeset in webkit [13532] by eseidel

• 50 edits in trunk/WebCore

2006-03-27 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Replace more DeprecatedString with String.
Add String::sprintf() and String::number()
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8009

• bindings/objc/DOMHTML.mm: (-[DOMHTMLTextAreaElement setCols:]): (-[DOMHTMLTextAreaElement setRows:]): (-[DOMHTMLOListElement setStart:]): (-[DOMHTMLPreElement setWidth:]): (-[DOMHTMLImageElement setHeight:]): (-[DOMHTMLImageElement setHspace:]): (-[DOMHTMLImageElement setVspace:]): (-[DOMHTMLImageElement setWidth:]): (-[DOMHTMLObjectElement setHspace:]): (-[DOMHTMLObjectElement setTabIndex:]): (-[DOMHTMLObjectElement setVspace:]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAreaElement setTabIndex:]): (-[DOMHTMLTableColElement setSpan:]): (-[DOMHTMLTableCellElement setColSpan:]): (-[DOMHTMLTableCellElement setRowSpan:]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement setWidth:]):
• bindings/objc/DOMInternal.mm: (String::String):
• css/CSSComputedStyleDeclaration.cpp: (WebCore::numberAsString): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
• css/css_valueimpl.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSPrimitiveValue::cssText):
• dom/Position.cpp: (WebCore::Position::formatForDebugger):
• dom/Range.cpp: (WebCore::Range::formatForDebugger):
• dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
• dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::error):
• editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
• html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::findMatchingState): (WebCore::HTMLGenericFormElement::setTabIndex):
• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setMaxLength): (WebCore::HTMLInputElement::setSize):
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSize):
• html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setCols): (WebCore::HTMLTextAreaElement::setRows):
• html/html_baseimpl.cpp: (WebCore::HTMLBodyElement::insertedIntoDocument):
• html/html_blockimpl.cpp: (WebCore::HTMLHRElement::parseMappedAttribute): (WebCore::HTMLPreElement::setWidth):
• html/html_imageimpl.cpp: (WebCore::HTMLImageElement::width): (WebCore::HTMLImageElement::height): (WebCore::HTMLImageElement::setBorder): (WebCore::HTMLImageElement::setHeight): (WebCore::HTMLImageElement::setHspace): (WebCore::HTMLImageElement::setVspace): (WebCore::HTMLImageElement::setWidth): (WebCore::HTMLAreaElement::setTabIndex):
• html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElement::setTabIndex):
• html/html_listimpl.cpp: (WebCore::HTMLOListElement::setStart): (WebCore::HTMLLIElement::setValue):
• html/html_objectimpl.cpp: (WebCore::HTMLObjectElement::setTabIndex):
• html/html_tableimpl.cpp: (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableCellElement::setColSpan): (WebCore::HTMLTableCellElement::setRowSpan): (WebCore::HTMLTableColElement::setSpan):
• khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): (KJS::Location::getValueProperty):
• ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
• ksvg2/svg/SVGAngle.cpp: (SVGAngle::setValueAsString): (SVGAngle::valueAsString):
• ksvg2/svg/SVGAngle.h:
• ksvg2/svg/SVGLength.cpp: (SVGLength::setValueAsString): (SVGLength::valueAsString):
• ksvg2/svg/SVGLength.h:
• ksvg2/svg/SVGPathSeg.h: (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString):
• ksvg2/svg/SVGPathSegArc.h: (WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegArcAbs::toString): (WebCore::SVGPathSegArcRel::pathSegTypeAsLetter): (WebCore::SVGPathSegArcRel::toString):
• ksvg2/svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter): (WebCore::SVGPathSegClosePath::toString):
• ksvg2/svg/SVGPathSegCurvetoCubic.h: (WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicAbs::toString): (WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicRel::toString):
• ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h: (WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString): (WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
• ksvg2/svg/SVGPathSegCurvetoQuadratic.h: (WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
• ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h: (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter): (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
• ksvg2/svg/SVGPathSegLineto.h: (WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoAbs::toString): (WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoRel::toString):
• ksvg2/svg/SVGPathSegLinetoHorizontal.h: (WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoHorizontalAbs::toString): (WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoHorizontalRel::toString):
• ksvg2/svg/SVGPathSegLinetoVertical.h: (WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoVerticalAbs::toString): (WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter): (WebCore::SVGPathSegLinetoVerticalRel::toString):
• ksvg2/svg/SVGPathSegMoveto.h: (WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter): (WebCore::SVGPathSegMovetoAbs::toString): (WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter): (WebCore::SVGPathSegMovetoRel::toString):
• ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::notifyAttributeChange):
• ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::parseMappedAttribute):
• ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):
• platform/AtomicString.h: (WebCore::AtomicString::toInt):
• platform/Color.cpp: (WebCore::Color::name):
• platform/Color.h:
• platform/PlatformString.h:
• platform/String.cpp: (WebCore::String::sprintf): (WebCore::String::number):
• platform/StringImpl.cpp: (WebCore::StringImpl::StringImpl): (WebCore::StringImpl::initWithChar): (WebCore::StringImpl::initWithQChar): (WebCore::StringImpl::containsOnlyWhitespace):
• platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent):
• rendering/render_form.cpp: (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::valueChanged):

3:30 AM Changeset in webkit [13531] by justing

• 6 edits
  8 adds in trunk

LayoutTests:

Reviewed by mjs

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7152>
REGRESSION: Select All does not highlight table if it's last in the document

• editing/selection/7152-1-expected.checksum: Added.
• editing/selection/7152-1-expected.png: Added.
• editing/selection/7152-1-expected.txt: Added.
• editing/selection/7152-1.html: Added.
• editing/selection/7152-2-expected.checksum: Added.
• editing/selection/7152-2-expected.png: Added.
• editing/selection/7152-2-expected.txt: Added.
• editing/selection/7152-2.html: Added.

WebCore:

Reviewed by mjs

<​http://bugzilla.opendarwin.org/attachment.cgi?id=7322>
REGRESSION: Select All does not highlight table if it's last in the document

• rendering/RenderCanvas.cpp: (WebCore::rendererAfterPosition): Added, returns the render object that a pre-order traversal over a range of render objects ending at the input position should stop at. (WebCore::RenderCanvas::selectionRect): Stop at rendererAfterPosition(m_selectionEnd, m_selectionEndPos), moved code for traversal to nextInPreOrder. Also, the travesal doesn't need to fetch the next object before doing work, since the work it does will never change what the next object in the traversal will be. (WebCore::RenderCanvas::setSelection): Ditto.
• rendering/RenderObject.cpp: (WebCore::RenderObject::nextInPreOrder): Renamed from nextRenderer, cleaned up the logic a little. (WebCore::RenderObject::nextInPreOrderAfterChildren): Added. (WebCore::RenderObject::previousInPreOrder): Renamed from previousRenderer. (WebCore::RenderObject::childAt): Added.
• rendering/RenderObject.h:
• rendering/RenderText.cpp: (WebCore::RenderText::setText):

2:37 AM Changeset in webkit [13530] by mjs

• 2 edits
  1 add in trunk/WebCore

Reviewed by Justin.

• fixed <rdar://problem/4483851> REGRESSION: parse mode gets set to strict after going back from non-HTML content (7102)

Reshuffled things to arrange for m_doc to be cleared somewhat earlier than before.

• page/Frame.cpp: (WebCore::Frame::didOpenURL): (WebCore::Frame::receivedFirstData): (WebCore::Frame::begin): (WebCore::Frame::endIfNotLoading):
• manual-tests/accidental-strict-mode.html: Added. I don't think an automated test is possible.

1:33 AM Changeset in webkit [13529] by justing

• 3 adds in trunk/LayoutTests/editing/selection

Forgot to check in these results earlier today.

1:02 AM Changeset in webkit [13528] by eseidel

• 6 edits in trunk/WebCore

2006-03-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Convert a couple DeprecatedPtrList<T> to Vector<T*> and HashSet<T*>

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::regExpForLabels): (WebCore::FrameMac::addPluginRootObject): (WebCore::FrameMac::cleanupPluginRootObjects):
• loader/Cache.cpp: (WebCore::Cache::init): (WebCore::Cache::clear): (WebCore::Cache::remove):
• loader/Cache.h:
• loader/DocLoader.cpp: (WebCore::DocLoader::DocLoader): (WebCore::DocLoader::~DocLoader):

Mar 27, 2006:

10:32 PM Changeset in webkit [13527] by eseidel

• 14 edits in trunk/WebCore

2006-03-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Give StringImpl a little privacy.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8022

• dom/CharacterData.cpp: (WebCore::CharacterData::length): (WebCore::CharacterData::appendData): (WebCore::CharacterData::replaceData): (WebCore::CharacterData::checkCharDataOperation): (WebCore::CharacterData::rendererIsNeeded):
• dom/Range.cpp: (WebCore::Range::compareBoundaryPoints):
• dom/Text.cpp: (WebCore::Text::splitText):
• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::processToken):
• platform/AtomicString.cpp: (WebCore::operator==):
• platform/String.cpp: (WebCore::String::operator[]): (WebCore::String::length): (WebCore::String::percentage): (WebCore::String::unicode): (WebCore::String::deprecatedString): (WebCore::String::isEmpty):
• platform/StringImpl.cpp: (WebCore::equal): (WebCore::equalIgnoringCase):
• platform/StringImpl.h:
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
• rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::width):

10:30 PM Changeset in webkit [13526] by mjs

• 5 edits
  8 adds in trunk

LayoutTests:

Reviewed by Beth.

• test cases for <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

• fast/block/float/float-in-float-hit-testing-expected.checksum: Added.
• fast/block/float/float-in-float-hit-testing-expected.png: Added.
• fast/block/float/float-in-float-hit-testing-expected.txt: Added.
• fast/block/float/float-in-float-hit-testing.html: Added.
• fast/block/float/float-in-float-painting-expected.checksum: Added.
• fast/block/float/float-in-float-painting-expected.png: Added.
• fast/block/float/float-in-float-painting-expected.txt: Added.
• fast/block/float/float-in-float-painting.html: Added.
• fast/events/capture-on-target.html:

WebCore:

Reviewed by Beth.

• fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects as well as their overflowRects.
• platform/IntRect.h: (WebCore::unionRect): useful helper
• platform/FloatRect.h: (WebCore::unionRect): added same for FloatRect just because

8:26 PM Changeset in webkit [13525] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

• ChangeLog:
• Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Instead of calling -stop, assert that the plugin is not running. A plugin view cannot be deallocated until it is removed from its window. When a plugin view is removed from its window, it calls -stop on itself. Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the assertion will help catch any edge cases. (-[WebBaseNetscapePluginView finalize]): ditto

8:15 PM Changeset in webkit [13524] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694086> -[WebBaseNetscapePluginStream finalize] is incorrect; design change needed

• Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that the stream file path either never existed, or was deleted and NULL-ed out. The stream file is now deleted immediately after calling NPP_StreamAsFile(). (-[WebBaseNetscapePluginStream finalize]): ditto (-[WebBaseNetscapePluginStream _destroyStream]): Delete the file after calling NPP_StreamAsFile(), instead of in -dealloc/-finalize. It should be OK to delete the file here -- NPP_StreamAsFile() is always called immediately before NPP_DestroyStream() (the stream destruction function), so there can be no expectation that a plugin will read the stream file asynchronously after NPP_StreamAsFile() is called.

8:13 PM Changeset in webkit [13523] by tomernic

• 3 edits in trunk/WebKit

Reviewed by Eric.

<rdar://problem/3694093> -[WebBasePluginPackage finalize] is incorrect; design change needed

Call -unload on plug-in packages instead of relying on -dealloc/-finalize to do it. Currently
the only place plug-in packages are deallocated is when refreshing the set of plugins, as when
handling JavaScript's navigator.plugins.refresh().

• Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Assert that the plug-in has been unloaded by the time -dealloc is called. (-[WebBasePluginPackage finalize]): ditto

• Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Call -unload on the plug-in packages before releasing them.

5:07 PM Changeset in webkit [13522] by darin

• 2 edits in trunk/WebCore

Based on a patch by Michael Emmel <​mike.emmel@gmail.com>.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8012 TransferJob.cpp includes non-existent "String.h" (capital S)

• platform/TransferJob.cpp: Remove unneeded include of "String.h".

4:57 PM Changeset in webkit [13521] by harrison

• 1 edit
  8 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

• editing/deleting/delete-block-merge-contents-022.html: Added.
• editing/deleting/delete-block-merge-contents-023.html: Added.
• editing/selection/selectNode-expected.checksum: Added.
• editing/selection/selectNode-expected.png: Added.
• editing/selection/selectNode-expected.txt: Added.
• editing/selection/selectNode.html: Added.
• editing/selection/selectNodeContents-expected.checksum: Added.
• editing/selection/selectNodeContents-expected.png: Added.
• editing/selection/selectNodeContents-expected.txt: Added.
• editing/selection/selectNodeContents.html: Added.

4:54 PM Changeset in webkit [13520] by harrison

• 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Better fix than previous checkin, since maxDeepOffset is really an editing hack.

• editing/selection/selectNodeContents-textNode.html: Added.

• dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxOffset if offsetInCharacters, otherwise use childNodeCount.

4:07 PM Changeset in webkit [13519] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebKit

Release tag for Mac OS X Update 10.4.3.

4:07 PM Changeset in webkit [13518] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/WebCore

Release tag for Mac OS X Update 10.4.3.

4:05 PM Changeset in webkit [13517] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.3/JavaScriptCore

Release tag for Mac OS X Update 10.4.3.

3:34 PM Changeset in webkit [13516] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13515] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/WebKit

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13514] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptGlue

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13513] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.4/JavaScriptCore

Release tag for Mac OS X Update 10.4.4.

3:33 PM Changeset in webkit [13512] by thatcher

• 2 adds in releases/Apple/Tiger

New release directories.

3:29 PM Changeset in webkit [13511] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebKit

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13510] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/WebCore

Release tag for Mac OS X Update 10.4.5.

3:29 PM Changeset in webkit [13509] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptGlue

Release tag for Mac OS X Update 10.4.5.

3:28 PM Changeset in webkit [13508] by thatcher

• 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.5/JavaScriptCore

Release tag for Mac OS X Update 10.4.5.

3:24 PM Changeset in webkit [13507] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-001/WebKit

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13506] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-001/WebCore

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13505] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptGlue

Release tag for Security Update 2006-001.

3:24 PM Changeset in webkit [13504] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-001/JavaScriptCore

Release tag for Security Update 2006-001.

3:15 PM Changeset in webkit [13503] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-002/WebKit

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13502] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-002/WebCore

Release tag for Security Update 2006-002.

3:15 PM Changeset in webkit [13501] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptGlue

Release tag for Security Update 2006-002.

3:14 PM Changeset in webkit [13500] by thatcher

• 1 copy in releases/Apple/Tiger/Security Update 2006-002/JavaScriptCore

Release tag for Security Update 2006-002.

3:01 PM Changeset in webkit [13499] by thatcher

• 5 adds in releases/Apple

New release directories. Will do server copies for the actual files.

2:21 PM Changeset in webkit [13498] by darin

• 2 edits in trunk/WebCore

At the request of Michael Emmel <​mike.emmel@gmail.com>.

• fix compilation for Linux ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8013

• rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked

formatting a bit and removed some extraneous WebCore

prefixes.

2:09 PM Changeset in webkit [13497] by thatcher

• 1 add in releases

New releases folder to hold tags of all WebKit versions released to the public. Reviewed by Darin.

2:07 PM Changeset in webkit [13496] by tomernic

• 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Part of <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore,
WebKit and WebBrowser

• Carbon/HIViewAdapter.h: HIViewAdapter is no longer an NSView subclass, since we no longer pose it as NSView.
• Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): Replace individual NSView methods instead of posing as NSView. (_webkit_NSView_setNeedsDisplay): Replacement implementation of -[NSView setNeedsDisplay:]. (_webkit_NSView_setNeedsDisplayInRect): Replacement implementation of -[NSView setNeedsDisplayInRect:] (_webkit_NSView_nextValidKeyView): Replacement implementation of -[NSView nextValidKeyView]

1:44 PM Changeset in webkit [13495] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Darin Adler and Tim Omernick

• fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly confirmed while typing on Safari.

• bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _displayedValue]): Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but for now it fixes this regression.

1:33 PM Changeset in webkit [13494] by sullivan

• 3 edits in trunk/WebKit

Reviewed by Darin Adler.

Removed two overzealous assertions that the steps to reproduce 4451831 were running into.
Improved comments to match.

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): Remove assertion that _inNextKeyViewOutsideWebFrameViews should always be false here.

• WebView/WebHTMLView.m: (-[NSArray nextValidKeyView]): Removed assertion that the frame should never be the main frame here.

1:20 PM Changeset in webkit [13493] by tomernic

• 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

Removed tabs & reformatted code.

• Carbon/HIViewAdapter.m: (+[NSView bindHIViewToNSView:nsView:]): (+[NSView getHIViewForNSView:]): (+[NSView unbindNSView:]): (-[NSView setNeedsDisplay:]): (-[NSView setNeedsDisplayInRect:]): (-[NSView nextValidKeyView]): (SetViewNeedsDisplay):

1:10 PM Changeset in webkit [13492] by lypanov

• 6 edits
  2 adds in trunk

2006-03-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by darin

• test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6520 the IE extension insertAdjacentElement

• fast/dynamic/insertAdjacentElement.html: Added.

2006-03-27 Alexander Kellett <​lypanov@kde.org>

Reviewed by darin

Implement the IE extension insertAdjacentElement
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6520

• bindings/scripts/CodeGeneratorJS.pm:
• dom/Element.cpp: (WebCore::ElementImpl::insertAdjacentElement):
• dom/Element.h:
• dom/Element.idl:

9:34 AM Changeset in webkit [13491] by justing

• 1 edit
  1 add in trunk/LayoutTests

Reviewed by beth and geoff

• editing/selection/6476-expected.checksum: Added.
• editing/selection/6476-expected.png: Added.
• editing/selection/6476-expected.txt: Added.
• editing/selection/6476.html: Added.

8:23 AM Changeset in webkit [13490] by harrison

• 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

<rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
nodes. Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
selectNodeContents on a text node.

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

• dom/Range.cpp: (WebCore::Range::selectNodeContents): Use maxDeepOffset instead of childNodeCount, so that text node content is selected.

5:17 AM Changeset in webkit [13489] by justing

• 3 edits
  4 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page

• fast/css/outline-auto-empty-rects-expected.checksum: Added.
• fast/css/outline-auto-empty-rects-expected.png: Added.
• fast/css/outline-auto-empty-rects-expected.txt: Added.
• fast/css/outline-auto-empty-rects.html: Added.

WebCore:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
REGRESSION: Extraneous focus ring drawn at the end of the page

• platform/GraphicsContext.cpp: (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.

3:29 AM Changeset in webkit [13488] by mjs

• 3 edits
  1 add in trunk

JavaScriptCore:

Reviewed by Anders.

• fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display ​http://www.lgphilips-lcd.com/

• kjs/nodes.cpp: (Node::deref): take into account the case where the extra refcount table was never created

WebCore:

Reviewed by Anders.

• fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display ​http://www.lgphilips-lcd.com/

• manual-tests/empty-script-crash.html: Added.

1:32 AM Changeset in webkit [13487] by mjs

• 2 edits in trunk/WebCore

Build fix:

• reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node It turns out that the behavior we had was standards-compliant and Moz will be changing to match.

Also added a note so this doesn't get reverted again.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):

12:34 AM Changeset in webkit [13486] by justing

• 8 edits in trunk

WebCore:

Reviewed by darn

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

• bridge/mac/WebCoreFrameBridge.h:
• editing/CreateLinkCommand.h: (WebCore::CreateLinkCommand::editingAction):
• editing/EditAction.h:
• editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):

WebKit:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
Add EditActions and WebUndoActions for CreateLink and Unlink

• English.lproj/Localizable.strings:
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):

Mar 26, 2006:

7:29 PM Changeset in webkit [13485] by eseidel

• 5 edits in trunk/WebCore

2006-03-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix win32 build.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• editing/CompositeEditCommand.cpp:
• editing/InsertTextCommand.cpp:
• generate-derived-sources:

5:30 PM Changeset in webkit [13484] by eseidel

• 2 edits in trunk/WebCore

2006-03-26 Eric Seidel <​eseidel@apple.com>

• dom/Element.cpp: fix include case, fixing build.

2:58 PM Changeset in webkit [13483] by eseidel

• 9 edits
  1 add in trunk/WebCore

2006-03-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

• fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7916 Box repaint rect does not include the left overflow

• manual-tests/left-overflow-repaint.html: Added.
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
• rendering/RenderBox.cpp: (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
• rendering/RenderFlow.cpp: (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
• rendering/RenderTableCell.cpp: Removed subclass implementation of getAbsoluteRepaintRect().
• rendering/RenderTableCell.h:
• rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.

Mar 25, 2006:

3:52 PM Changeset in webkit [13482] by eseidel

• 2 edits in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Build fix.

• bindings/scripts/CodeGeneratorJS.pm: include Element.h

2:24 PM Changeset in webkit [13481] by eseidel

• 3 edits in trunk/WebKitTools

2006-03-24 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by darin. Landed by eseidel.

• ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7947 Add repaint testing support to run-webkit-tests

• DumpRenderTree/DumpRenderTree.m: (main): Added --repaint and --horizontal-sweep options. (dump): Repaint line-by-line or column-by-column when the appropriate option is selected. (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint() and repaintSweepHorizontally() methods to layoutTestController. (-[LayoutTestController testRepaint]): (-[LayoutTestController repaintSweepHorizontally]): (dumpRenderTree):
• Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options to force these settings on tests that do not ask for them.

2:20 PM Changeset in webkit [13480] by eseidel

• 111 edits
  15 copies
  2 moves
  3 deletes in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Split dom_elementimpl.* into multiple files (one per class).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

• ForwardingHeaders/kdom/core/Attr.h: Removed.
• ForwardingHeaders/kdom/core/Element.h: Removed.
• ForwardingHeaders/kdom/core/XMLElement.h: Removed.
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm:
• bindings/objc/DOMHTML.mm:
• bindings/scripts/CodeGeneratorJS.pm:
• dom/AbstractView.cpp:
• dom/Attr.cpp: Added.
• dom/Attr.h: Added.
• dom/Attribute.cpp: Added.
• dom/Attribute.h: Added.
• dom/CSSMappedAttributeDeclaration.cpp: Added.
• dom/CSSMappedAttributeDeclaration.h: Added.
• dom/DOMImplementation.cpp:
• dom/Document.h:
• dom/DocumentType.cpp:
• dom/Element.cpp: Added. (WebCore::Element::Element): (WebCore::Element::~Element):
• dom/Element.h: Added.
• dom/EventNames.cpp:
• dom/EventTargetNode.cpp:
• dom/MappedAttribute.cpp: Added.
• dom/MappedAttribute.h: Added.
• dom/MappedAttributeEntry.h: Added. (WebCore::):
• dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
• dom/NamedAttrMap.cpp: Added.
• dom/NamedAttrMap.h: Added.
• dom/NamedMappedAttrMap.cpp: Added. (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
• dom/NamedMappedAttrMap.h: Added.
• dom/Node.cpp:
• dom/NodeList.cpp:
• dom/Position.cpp:
• dom/StyledElement.cpp: Added.
• dom/StyledElement.h: Added.
• dom/dom_elementimpl.cpp: Removed.
• dom/dom_elementimpl.h: Removed.
• editing/BreakBlockquoteCommand.cpp:
• editing/CompositeEditCommand.cpp:
• editing/DeleteFromTextNodeCommand.cpp:
• editing/DeleteSelectionCommand.cpp:
• editing/InsertLineBreakCommand.cpp:
• editing/InsertParagraphSeparatorCommand.cpp:
• editing/InsertTextCommand.cpp:
• editing/MergeIdenticalElementsCommand.cpp:
• editing/ModifySelectionListLevelCommand.cpp:
• editing/MoveSelectionCommand.cpp:
• editing/RemoveCSSPropertyCommand.cpp:
• editing/RemoveNodeAttributeCommand.cpp:
• editing/Selection.cpp:
• editing/SelectionController.cpp:
• editing/SetNodeAttributeCommand.cpp:
• editing/SplitElementCommand.cpp:
• editing/SplitTextNodeContainingElementCommand.cpp:
• editing/TextIterator.cpp:
• editing/TypingCommand.cpp:
• editing/VisiblePosition.cpp:
• editing/visible_units.cpp:
• html/HTMLElement.h:
• html/HTMLTokenizer.h:
• html/html_baseimpl.cpp:
• kcanvas/RenderSVGImage.cpp:
• khtml/ecma/kjs_views.cpp:
• khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
• khtml/xbl/xbl_binding_manager.cpp:
• khtml/xbl/xbl_tokenizer.cpp:
• ksvg2/misc/SVGImageLoader.cpp:
• ksvg2/svg/SVGAElement.cpp:
• ksvg2/svg/SVGAnimateTransformElement.cpp:
• ksvg2/svg/SVGAnimationElement.cpp:
• ksvg2/svg/SVGCircleElement.cpp:
• ksvg2/svg/SVGClipPathElement.cpp:
• ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
• ksvg2/svg/SVGCursorElement.cpp:
• ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement):
• ksvg2/svg/SVGElement.h:
• ksvg2/svg/SVGEllipseElement.cpp:
• ksvg2/svg/SVGExternalResourcesRequired.cpp:
• ksvg2/svg/SVGFEBlendElement.cpp:
• ksvg2/svg/SVGFEColorMatrixElement.cpp:
• ksvg2/svg/SVGFEComponentTransferElement.cpp:
• ksvg2/svg/SVGFECompositeElement.cpp:
• ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
• ksvg2/svg/SVGFEDisplacementMapElement.cpp:
• ksvg2/svg/SVGFEFloodElement.cpp:
• ksvg2/svg/SVGFEGaussianBlurElement.cpp:
• ksvg2/svg/SVGFEImageElement.cpp:
• ksvg2/svg/SVGFELightElement.cpp:
• ksvg2/svg/SVGFEMergeElement.cpp:
• ksvg2/svg/SVGFEMergeNodeElement.cpp:
• ksvg2/svg/SVGFEOffsetElement.cpp:
• ksvg2/svg/SVGFESpecularLightingElement.cpp:
• ksvg2/svg/SVGFETileElement.cpp:
• ksvg2/svg/SVGFETurbulenceElement.cpp:
• ksvg2/svg/SVGFilterElement.cpp:
• ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
• ksvg2/svg/SVGFitToViewBox.cpp:
• ksvg2/svg/SVGGradientElement.cpp:
• ksvg2/svg/SVGImageElement.cpp:
• ksvg2/svg/SVGLangSpace.cpp:
• ksvg2/svg/SVGLineElement.cpp:
• ksvg2/svg/SVGLinearGradientElement.cpp:
• ksvg2/svg/SVGMarkerElement.cpp:
• ksvg2/svg/SVGMaskElement.cpp:
• ksvg2/svg/SVGPathElement.cpp:
• ksvg2/svg/SVGPatternElement.cpp:
• ksvg2/svg/SVGPolyElement.cpp:
• ksvg2/svg/SVGRadialGradientElement.cpp:
• ksvg2/svg/SVGRectElement.cpp:
• ksvg2/svg/SVGSVGElement.cpp:
• ksvg2/svg/SVGScriptElement.cpp:
• ksvg2/svg/SVGStopElement.cpp:
• ksvg2/svg/SVGStyledElement.cpp:
• ksvg2/svg/SVGStyledTransformableElement.cpp:
• ksvg2/svg/SVGSwitchElement.cpp:
• ksvg2/svg/SVGTests.cpp:
• ksvg2/svg/SVGTextContentElement.cpp:
• ksvg2/svg/SVGTextPositioningElement.cpp:
• ksvg2/svg/SVGTransformable.cpp:
• ksvg2/svg/SVGURIReference.cpp:
• ksvg2/svg/SVGUseElement.cpp:
• ksvg2/svg/SVGViewElement.cpp:
• ksvg2/svg/SVGZoomAndPan.cpp:
• kwq/WebCoreTextArea.mm:
• platform/Widget.h:
• rendering/RenderBlock.cpp:
• rendering/RenderCanvas.cpp:
• rendering/RenderContainer.cpp:
• rendering/RenderObject.cpp:
• rendering/RenderTextField.cpp:
• rendering/RenderThemeMac.mm:
• rendering/bidi.cpp:
• rendering/render_replaced.cpp:

3:22 AM Changeset in webkit [13479] by eseidel

• 11 edits in trunk/WebCore

2006-03-25 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix RenderStyle creation to avoid floating RenderStyle objects.
This also fixes a bug, were SVG to ever start sharing RenderStyles
between elements, code would have crashed as there were improperly
paired style->deref() statements in SVG code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

No test possible (no functionality change).

• css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::createStyleForElement): (WebCore::CSSStyleSelector::createPseudoStyleForElement):
• css/cssstyleselector.h:
• dom/Node.cpp: (WebCore::Node::createRendererIfNeeded): (WebCore::Node::createStyleForRenderer):
• dom/Node.h:
• dom/dom_elementimpl.cpp: (WebCore::Element::createStyleForRenderer): (WebCore::Element::recalcStyle):
• dom/dom_elementimpl.h:
• ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
• ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
• ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
• rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): (WebCore::RenderObject::RenderObject): (WebCore::selectStartNode): (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::getPseudoStyle):

2:46 AM Changeset in webkit [13478] by eseidel

• 3 edits
  2 adds in trunk

2006-03-23 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Shave .2% on PLT by removing bogus strcmp.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

Test: fast/parser/tag-with-exclamation-point.html

• html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp

2:17 AM Changeset in webkit [13477] by justing

• 16 edits
  4 adds
  2 deletes in trunk

LayoutTests:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

• editing/editing.js:
• editing/execCommand/createLink-expected.checksum: Removed.
• editing/execCommand/createLink-expected.png: Removed.
• editing/execCommand/createLink-expected.txt:
• editing/execCommand/createLink.html:
• editing/execCommand/unlink-expected.txt: Added.
• editing/execCommand/unlink.html: Added.

WebCore:

Reviewed by harrison

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
TinyMCE: execCommand("Unlink") unimplemented

Added code to push partially selected anchor elements down before
creating or removing links to create fully selected chunks that can be removed.
Changed create_link_command_h to CreateLinkCommand_h
Gave styled element application/removal its own ApplyStyleCommand constructor.
Still need to add new EditActions (7974).

• WebCore.xcodeproj/project.pbxproj:
• editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): (WebCore::ApplyStyleCommand::applyBlockStyle): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
• editing/ApplyStyleCommand.h:
• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::applyStyle): (WebCore::CompositeEditCommand::applyStyledElement): (WebCore::CompositeEditCommand::removeStyledElement): (WebCore::enclosingAnchorElement): (WebCore::CompositeEditCommand::pushAnchorElementDown): (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
• editing/CompositeEditCommand.h:
• editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply):
• editing/CreateLinkCommand.h:
• editing/JSEditor.cpp:
• editing/Selection.cpp: (WebCore::Selection::selectionFromContentsOfNode):
• editing/Selection.h:
• editing/UnlinkCommand.cpp: Added. (WebCore::UnlinkCommand::UnlinkCommand): (WebCore::UnlinkCommand::doApply):
• editing/UnlinkCommand.h: Added.
• page/Frame.cpp: (WebCore::Frame::selectContentsOfNode): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle):