Timeline



Apr 4, 2006:

11:42 PM Changeset in webkit [13761] by eseidel
  • 1 edit in branches/temp-tree-code/trunk/JavaScriptCore/JavaScriptCore.xcodeproj

Make svn ignore xcode internal files

11:41 PM Changeset in webkit [13760] by eseidel
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore/kjs

roll evaluateList into the loop, fix exception handling

8:55 PM Changeset in webkit [13699] by darin
  • 10 edits
    1 delete in trunk

LayoutTests:

Reviewed by Justin and Adele.

  • fast/forms/plaintext-mode-2-expected.txt: Updated because there's no longer and extra <div> element added.

WebCore:

Reviewed by Justin (editing parts) and Adele (the rest).

The smart paste code was getting confused and adding extra spaces.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Use isStartOfParagraph instead of isStartOfLine. (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::enclosingEmptyListItem): Change to call isStart/EndOfParagraph instead of Line.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Add a comment about how isStartOfLine is almost certainly wrong here.
  • clean up some loose ends in the Frame class from the recent renaming
  • page/Frame.h: Removed declarations of deleteMe1, deleteMe2, and handleMouseMoveEventPart2.
  • page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): Removed handleMouseMoveEventPart2 by renaming it to handleMouseMoveEvent and removing handleMouseMoveEvent itself.
  • invoke the makefile directly, removing the generate-derived-sources script
  • WebCore.vcproj/WebCore/build-generated-files.sh: Call make directly.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • generate-derived-sources: Removed.
7:26 PM Changeset in webkit [13698] by hyatt
  • 2 edits in trunk/LayoutTests/tables

Update table results after my change to create fewer RenderTexts.

7:19 PM Changeset in webkit [13697] by hyatt
  • 14 edits in trunk/LayoutTests/fast

Update fast results after my change to create fewer RenderTexts.

7:06 PM Changeset in webkit [13696] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

  • editing/selection/caret-rtl-expected.checksum: Added.
  • editing/selection/caret-rtl-expected.png: Added.
  • editing/selection/caret-rtl-expected.txt: Added.
  • editing/selection/caret-rtl.html: Added.
  • editing/selection/caret-rtl-2-expected.checksum: Added.
  • editing/selection/caret-rtl-2-expected.png: Added.
  • editing/selection/caret-rtl-2-expected.txt: Added.
  • editing/selection/caret-rtl-2.html: Added.

WebCore:

Reviewed by Justin.

Tests:
editing/selection/caret-rtl.html
editing/selection/caret-rtl-2.html

  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): When calculating the position for the beginning or end of an InlineTextBox, we now use offsetForPosition instead of just using m_start and m_len, because offsetForPosition will take rtl text into account. I also made some formatting changes.
6:49 PM Changeset in webkit [13695] by adele
  • 2 edits in trunk/LayoutTests

New results for

  • fast/forms/input-truncate-newline-expected.txt

Filed bug:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8187
input-truncate-newline layout test fails when run as part of larger set of tests

5:47 PM Changeset in webkit [13759] by ggaren
  • 1 add in branches/temp-tree-code/trunk/JavaScriptCore/kjs/NodeType.h

forgot this file

5:47 PM Changeset in webkit [13758] by ggaren
  • 5 edits in branches/temp-tree-code/trunk/JavaScriptCore

converted all executes to giant switch statement -- nothing is integrated with the evaluate loop yet, but it builds and passes all the tests

4:47 PM Changeset in webkit [13694] by thatcher
  • 1 move in tags/JavaScriptCore-521.9.1/JavaScriptCore

Correct place.

4:47 PM Changeset in webkit [13693] by thatcher
  • 1 add in tags/JavaScriptCore-521.9.1

New tag.

4:46 PM Changeset in webkit [13692] by thatcher
  • 1 move in tags/JavaScriptCore-521.9.1-temp

Move. This was in the wrong place.

4:42 PM Changeset in webkit [13691] by thatcher
  • 5 edits in tags/JavaScriptCore-521.9.1

Reviewed by Adele.

Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
Other 64 bit build fixes.

  • kjs/collector.cpp: (KJS::Collector::markOtherThreadConservatively): test for DARWIN_UNIX03 and use r1
  • kjs/dtoa.cpp: (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
4:34 PM Changeset in webkit [13690] by thatcher
  • 1 copy in tags/JavaScriptCore-521.9.1

new tag.

4:34 PM Changeset in webkit [13689] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8065, inline blocks incorrectly loses spaces between them.

Reviewed by beth

  • dom/Text.cpp: (WebCore::Text::rendererIsNeeded):
3:23 PM Changeset in webkit [13688] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for:

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
REGRESSION (NativeTextField): table contents misaligned in Netflix queue

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
REGRESSION: Native text field fails to wrap inside table

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
REGRESSION: text fields at connect.apple.com spill out of the containing box

  • fast/forms/input-table-expected.checksum: Added.
  • fast/forms/input-table-expected.png: Added.
  • fast/forms/input-table-expected.txt: Added.
  • fast/forms/input-table.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
REGRESSION: Native text field fails to wrap inside table

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
REGRESSION: text fields at connect.apple.com spill out of the containing box

Test: fast/forms/input-table.html

Rewrote calcMinMaxWidth for text fields so it considers width,
min-width, and max-width settings as well as the size attribute.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):
3:11 PM Changeset in webkit [13687] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Darin.

This is a followup to my fix for <rdar://problem/4493218>


This patch re-names computeIntLength() and computerShortLength() to
be computeLengthInt() and computeLengthShort(), respectively, to
match the pre-existing computeLengthFloat(). This patch also adds
the slightly confusing-ly named computeLengthIntForLength() which
uses the max and min values of a 28-bit integer as bounds for
overflow. This function is necessary because Length objects expect
28-bit integers.

2:21 PM Changeset in webkit [13686] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

JavaScriptGlue:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Darin.

The Debug and Release frameworks are now built with install paths relative to the build products directory.
This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

  • WebKit.xcodeproj/project.pbxproj:
1:52 PM Changeset in webkit [13685] by justing
  • 17 edits
    12 adds in trunk

LayoutTests:

Reviewed by darin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting

Added:

  • editing/deleting/merge-different-styles-expected.checksum: Added.
  • editing/deleting/merge-different-styles-expected.png: Added.
  • editing/deleting/merge-different-styles-expected.txt: Added.
  • editing/deleting/merge-different-styles.html: Added.
  • editing/deleting/merge-no-br-expected.checksum: Added.
  • editing/deleting/merge-no-br-expected.png: Added.
  • editing/deleting/merge-no-br-expected.txt: Added.
  • editing/deleting/merge-no-br.html: Added.
  • editing/deleting/merge-whitespace-pre-expected.checksum: Added.
  • editing/deleting/merge-whitespace-pre-expected.png: Added.
  • editing/deleting/merge-whitespace-pre-expected.txt: Added.
  • editing/deleting/merge-whitespace-pre.html: Added.

Fixes (not enough style on nodes for the fixes to be reflected in pixel results):

  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:

Equivalent render trees:

  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:


Forgot to checkin these new expected results after fixing the DRT bug:

  • fast/lists/drag-into-marker-expected.checksum:
  • fast/lists/drag-into-marker-expected.png:
  • fast/lists/drag-into-marker-expected.txt:

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
REGRESSION: Line disappears when deleting


Rewrote moveNodesAfterNode to address these problems:
It moved nodes without preserving their style.
It traversed over siblings looking for a br to know when
to stop merging. If the br was burried inside a span, it
wouldn't find it. If the text is whitespace:pre, it wouldn't
stop.
In theory it would crash if the "enclosingInlineElements" of the start of the
selection to delete and the end of the selection to delete were the
same. We think that this will fix these:
<rdar://problems/3950559&4498113>
CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
But we haven't been able to construct a reproducible case.


  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand. (WebCore::CompositeEditCommand::prune): Ditto.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply):
  • editing/DeleteSelectionCommand.h:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h: (WebCore::):
  • editing/markup.cpp: (WebCore::createMarkup): Was crashing when passed a collapsed range. I early return an empty string instead.
11:10 AM Changeset in webkit [13684] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren.

Fix win32 build.
Disable ASSERT redefinition warnings for now.

10:48 AM Changeset in webkit [13683] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Adele Peterson.

  • WebKit part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
  • WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]): Pass private browsing setting down to WebCore.
10:47 AM Changeset in webkit [13682] by sullivan
  • 6 edits in trunk/WebCore

Reviewed by Adele Peterson.


  • WebCore part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setPrivateBrowsingEnabled:]): (-[WebCoreSettings privateBrowsingEnabled]): Teach WebCoreSettings about private browsing (WebKit knew, but WebCore didn't)


  • kwq/KWQKHTMLSettings.h: (KHTMLSettings::privateBrowsingEnabled): (KHTMLSettings::setPrivateBrowsingEnabled): Teach KHTMLSettings about private browsing


  • kwq/KWQLineEdit.mm: Fix wrong class in a category method declaration; the compiler didn't seem to mind.


  • kwq/WebCoreTextField.mm: (-[KWQSearchFieldCell _addStringToRecentSearches:]): Override this method to bail out if private browsing is enabled.
9:15 AM Changeset in webkit [13681] by darin
  • 4 edits in trunk/WebCore

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7951
REGRESSION: Safari crashes when printing a google map w/directions

Tests: none, because I believe it only happens when printing, due to the relayouts

  • rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSectionsIfNeeded): Add new utility to let the cells ensure the sections' grid data is up to date.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::calcMinMaxWidth): Call above method.
5:11 AM Changeset in webkit [13680] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-04-04 Bjrn Graf <​bjoern.graf@gmail.com>

Reviewed by ggaren & darin. Landed by eseidel.

Integrate CURL version of gettimeofday
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7399
Disable crash report dialogs for testkjs.exe in Release mode
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8113

  • kjs/testkjs.cpp: (StopWatch::start): (StopWatch::stop): (StopWatch::getElapsedMS): (main): (kjsmain):
4:54 AM Changeset in webkit [13679] by eseidel
  • 2 edits in trunk/WebCore

2006-04-03 Justin Haygood <​jhaygood@spsu.edu>

Reviewed by eseidel. Landed by eseidel.

  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollBars):
4:48 AM Changeset in webkit [13678] by eseidel
  • 3 edits in trunk/WebCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Work-around spaces-in-pathnames issue in gnumake on win32.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8173

  • WebCore.vcproj/WebCore/build-generated-files.sh:
3:08 AM Changeset in webkit [13677] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

  • kjs/number_object.cpp: (NumberProtoFunc::callAsFunction): remove trunc() to fix win32.
2:03 AM Changeset in webkit [13676] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • kjs/number_object.cpp: (intPow10): Compute integer powers of 10 using exponentiation by squaring. (NumberProtoFunc::callAsFunction): Use intPow10(n) in place of all pow(10.0, n), plus a bit of refactoring.

Apr 3, 2006:

11:54 PM Changeset in webkit [13675] by darin
  • 3 edits in trunk/WebCore
  • tried to fix build again
  • WebCore.xcodeproj/project.pbxproj: Removed JSStyleSheet files.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
11:30 PM Changeset in webkit [13674] by darin
  • 56 edits in trunk/WebCore
  • fixed properties on a bunch of files (removed allow-tabs and svn:executable from many)
  • css/css_base.cpp:
  • html/html_headimpl.cpp:
  • khtml/ecma/kjs_traversal.cpp:
  • kwq/DeprecatedPtrListImpl.cpp:
  • kwq/DeprecatedValueListImpl.cpp:
  • loader/CachedScript.h:
  • platform/ArrayImpl.cpp:
  • platform/StringImpl.cpp:
  • rendering/DataRef.h:
  • rendering/RenderContainer.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/bidi.h:
  • rendering/render_list.cpp:
  • rendering/render_style.cpp:
  • rendering/table_layout.h: Converted tabs to spaces.
10:21 PM Changeset in webkit [13673] by ap
  • 8 edits
    12 adds in trunk

Reviewed by Darin.

Tests: fast/css/invalidation-errors.html

fast/css/invalidation-errors-2.html
fast/css/invalidation-errors-3.html

  • css/CSSGrammar.y: Rollback the properties added by parseValue() when it returns false.
  • css/cssparser.h: Moved shorthand counting to ShorthandScope, a new class in cssparser.cpp.
  • css/cssparser.cpp: (WebCore::CSSParser::rollbackLastProperties): Added. (WebCore::CSSParser::parseValue): Return false if there are too many properties in the list. (WebCore::CSSParser::parseBackgroundShorthand): Use ShorthandScope. (WebCore::CSSParser::parseShorthand): Ditto. (WebCore::CSSParser::parse4Values): Ditto.
9:47 PM Changeset in webkit [13672] by thatcher
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Bumping the PLT count back to 5.

9:07 PM Changeset in webkit [13671] by darin
  • 4 edits
    1 delete in trunk/WebCore
  • changed StyleSheet back to hand-generated since the generated toJS function was not making the right type of wrapper for CSS style sheets (fixes failing layout tests)
  • DerivedSources.make: Removed JSStyleSheet.h.
  • css/StyleSheet.idl: Removed.
  • khtml/ecma/kjs_css.cpp: Added DOMStyleSheet back in.
  • khtml/ecma/kjs_css.h: Ditto.
8:55 PM Changeset in webkit [13670] by darin
  • 3 edits in trunk/JavaScriptCore
  • tweak config.h and Platform.h to try to get buildbot working (making some small changes at the same time)
  • kjs/config.h: Removed now-unneeded HAVE_ICU.
  • kxmlcore/Platform.h: Tweak how platform gets set up. Move all the USE stuff to the end.
8:34 PM Changeset in webkit [13669] by darin
  • 2 edits in trunk/WebCore
  • fixed Macintosh build
  • WebCore.xcodeproj/project.pbxproj: Fixed paths of some files that were absolute paths from my machine.
8:14 PM Changeset in webkit [13668] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Add three new generated files as source files.
7:45 PM Changeset in webkit [13667] by staikos
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Fix Win32 build breakage and remove an unused forward.

6:54 PM Changeset in webkit [13666] by darin
  • 7 edits in trunk

LayoutTests:

  • add a test of RTL to the test for bug 8106
  • fast/forms/input-text-scroll-left-on-blur-expected.png: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum: Updated.
  • fast/forms/input-text-scroll-left-on-blur.html: Updated.

WebCore:

Reviewed by Maciej.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll to the right if RTL.
6:50 PM Changeset in webkit [13665] by darin
  • 6 edits
    4 adds in trunk/WebCore

Reviewed by Maciej.

  • DerivedSources.make: Added.
  • css/CSSPrimitiveValue.idl: Added.
  • css/Counter.idl: Added.
  • css/StyleSheet.idl: Added.
  • WebCore.xcodeproj/project.pbxproj: Added new generated files, IDLs, and the makefile.
  • bindings/scripts/CodeGeneratorJS.pm:
  • generate-derived-sources: Added license header. Removed most of the script, except for a single invocation of make.
  • khtml/ecma/kjs_css.h: Removed DOMStyleSheet, DOMCSSPrimitiveValue, CSSPrimitiveValueConstructor, and DOMCounter.
  • khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): Changed to use JSStyleSheet as the base class. (KJS::DOMCSSStyleSheet::getOwnPropertySlot): Ditto. (KJS::DOMCSSValueProtoFunc::callAsFunction): Added. (KJS::toJS): Changed to use JSCSSPrimitiveValue. (KJS::DOMRGBColor::getValueProperty): Changed to call toJS instead of making a DOMCSSPrimitiveValue directly.
5:30 PM Changeset in webkit [13757] by eseidel
  • 5 edits
    1 copy
    1 add in branches/temp-tree-code/trunk/JavaScriptCore

Initial commit

4:58 PM Changeset in webkit [13664] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
A drag and drop in DumpRenderTree copies the source, instead of cutting it

  • editing/pasteboard/drag-drop-modifies-page-expected.checksum: Added.
  • editing/pasteboard/drag-drop-modifies-page-expected.png: Added.
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
  • editing/pasteboard/drag-drop-modifies-page.html: Added.

Updated:

  • fast/lists/drag-onto-marker.html:
  • fast/lists/drag-onto-marker-expected.txt:
  • fast/lists/drag-onto-marker-expected.png:
  • fast/lists/drag-onto-marker-expected.checksum:

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page


The frame's selection is only set after all sub-commands have been
performed. When we send the khtmlBeforeTextInsertedEvent to the root
editable element we were using frame->selection(), which may no longer
be in the document.


Had to move the construction of the ReplacementFragment to when the
replace operation is applied, because endingSelection isn't the
endingSelection of the last operation when the replace operation
is constructed.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): (WebCore::ReplaceSelectionCommand::doApply):
  • editing/ReplaceSelectionCommand.h:

WebKitTools:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
A drag and drop in DumpRenderTree copies the source, instead of cutting it


Tell the source that the drag is over after the drag is performed, not before.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController mouseUp]):
4:49 PM Changeset in webkit [13663] by staikos
  • 5 edits
    9 adds in trunk/JavaScriptCore

Reviewed by Maciej.

Implement a unicode abstraction layer to make JavaScriptCore much more
easily ported to other platforms without having to take in libicu. Also
makes the unicode related code easier to understand.

4:46 PM Changeset in webkit [13662] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4495644> crash when mousing over
links at nationalrealestateinvestors.com in
WebCore::RenderBlock::findNextLineBreak

4:17 PM Changeset in webkit [13661] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.


  • re-fixed <rdar://problem/4481198> REGRESSION (TOT): search results list in bookmarks view remains when search text is deleted
  • WebView/WebView.m: (-[WebView searchFor:direction:caseSensitive:wrap:]): I fixed this recently, but then broke it again by adding an early bail-out to this method. So now I'm removing the early bail-out.
4:08 PM Changeset in webkit [13756] by eseidel
  • 1502 adds in branches/temp-tree-code

initial import

3:30 PM Changeset in webkit [13660] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4495644> crash when mousing over links at
nationalrealestateinvestors.com in
WebCore::RenderBlock::findNextLineBreak

This is a fix for a repro crasher where a rootLineBox had a stale
pointer to a render object.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::dirtyLinesFromChangedChild): Only break from the function because of selfNeedsLayout() if we are not an inline flow, because if we are, we will not re-layout before bad things can happen.
3:26 PM Changeset in webkit [13659] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Removing idl files and some scripts from the WebCore target to prevent
them from being copied into the Resources.

  • WebCore.xcodeproj/project.pbxproj:
3:06 PM Changeset in webkit [13658] by thatcher
  • 5 edits in trunk/JavaScriptCore

Reviewed by Adele.

Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
Other 64 bit build fixes.

  • kjs/collector.cpp: (KJS::Collector::markOtherThreadConservatively): test for DARWIN_UNIX03 and use r1
  • kjs/dtoa.cpp: (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
  • bindings/jni/jni_utility.cpp: (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
  • bindings/runtime_root.cpp: (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
2:58 PM Changeset in webkit [13657] by hyatt
  • 10 edits in trunk/WebCore

Win32 theme work. Bug 8162. r=anders

2:55 PM Changeset in webkit [13656] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

  • fast/dom/Element/offsetTop-table-cell-expected.txt: Added.
  • fast/dom/Element/offsetTop-table-cell.html: Added.

WebCore:

Reviewed by Beth.

Test: fast/dom/Element/offsetTop-table-cell.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetTop): Skip table rows when adding up the offsets, since a table cell's yPos() is relative to the table section, not the row.
2:42 PM Changeset in webkit [13655] by adele
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/inline-block-overflow-expected.png: Added.
  • fast/repaint/layer-outline-expected.checksum: Added.
  • fast/repaint/layer-outline-expected.png: Added.
  • fast/repaint/layer-outline-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal-expected.checksum: Added.
  • fast/repaint/layer-outline-horizontal-expected.png: Added.
  • fast/repaint/layer-outline-horizontal-expected.txt: Added.
  • fast/repaint/layer-outline-horizontal.html: Added.
  • fast/repaint/layer-outline.html: Added.

WebCore:

Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html

Reviewed by Darin.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Use the outlineRect for the outline phase and do it only if the outlineRect isn't empty. (WebCore::RenderLayer::calculateRects): Actually add the outline width to the outline rect.
2:14 PM Changeset in webkit [13654] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Justin.

  • fast/forms/input-truncate-newline-expected.txt: Added.
  • fast/forms/input-truncate-newline.html: Added.

WebCore:

Reviewed by Justin.

Test: fast/forms/input-truncate-newline.html

  • html/HTMLInputElement.cpp: (WebCore::minPosition): Added helper function. (WebCore::HTMLInputElement::defaultEventHandler): Searches for /r or /n and truncates the text to be inserted to the earliest newline.
10:46 AM Changeset in webkit [13653] by ap
  • 2 edits in trunk/WebCore

Fixed a comment (forgot to save the file before the previous commit).

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open):
9:36 AM Changeset in webkit [13652] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Test: http/tests/xmlhttprequest/methods-lower-case.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): Uppercase some HTTP method names, to match a Firefox quirk. (WebCore::XMLHttpRequest::send): Account for the above change.
9:28 AM Changeset in webkit [13651] by darin
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): When an element changes size, the delta rectangles that need to be invalidated must be inflated by the outline size to ensure that the previous outline is erased, and the space where the new outline is to be drawn is also invalidated. This behaviour is identical to the behaviour of borders that was fixed in bug 6301.
  • manual-tests/outline-repaint-glitch.html: Added. Manual testcase. This is just an outline version of border-repaint-glitch.html
9:25 AM Changeset in webkit [13650] by darin
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Adding tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed
and ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

In addition I tweaked the httpd conf file to allow us to exec perl CGI scripts.

  • http/conf/httpd.conf:
  • http/tests/misc/error404-expected.checksum: Added.
  • http/tests/misc/error404-expected.png: Added.
  • http/tests/misc/error404-expected.txt: Added.
  • http/tests/misc/error404.pl: Added.
  • http/tests/misc/iframe404-expected.checksum: Added.
  • http/tests/misc/iframe404-expected.png: Added.
  • http/tests/misc/iframe404-expected.txt: Added.
  • http/tests/misc/iframe404.html: Added.

WebCore:

Reviewed by Maciej.

Support for fixing ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge currentForm]): Nuke redundant nil check. (-[WebCoreFrameBridge frameElement]): Tweak to not rely on our document, which gives a correct result even at the start of our loading process.
  • bindings/objc/DOM.mm: (-[DOMDocument _ownerElement]): Nuke redundant nil check.

WebKit:

Reviewed by Maciej.

fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
REGRESSION: 404s are not displayed

  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]): Only cancel failed loads for object elements, not for frames or a whole page.
9:04 AM Changeset in webkit [13649] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • page/Frame.cpp: (WebCore::Frame::reparseConfiguration): Added back updateStyleSelector call that was removed as part of the patch for bug 7907.
12:06 AM Changeset in webkit [13648] by mjs
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Tests for:

  • fast/forms/focus-control-to-page-expected.txt: Added.
  • fast/forms/focus-control-to-page.html: Added.

WebCore:

Reviewed by Hyatt.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame):
  • bridge/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Hyatt.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willMakeFirstResponderForNodeFocus]): New method
  • let WebHTMLView know that the next time it becomes first responder, it's to change focus within the page and the right node has already been set, so it should not move focus forward or backward inside it.
  • WebView/WebHTMLView.m: (-[NSArray needsPanelToBecomeKey]): Override to return YES, oddly enough this is the right way to tell AppKit that you should be in the tab cycle loop. (-[NSArray becomeFirstResponder]): Don't move forward or back in tab cycle when this becomeFirstResponder is for tabbing from a control in the page. (-[WebHTMLView _willMakeFirstResponderForNodeFocus]): Note that the next time this view becomes first responder, it will be for in-page focus navigation.
  • WebView/WebHTMLViewInternal.h:

Apr 2, 2006:

6:52 PM Changeset in webkit [13647] by darin
  • 3 edits in trunk/LayoutTests
  • updated one more result for change in focus ring appearance
  • fast/forms/plaintext-mode-2-expected.checksum: Updated.
  • fast/forms/plaintext-mode-2-expected.png: Ditto.
6:39 PM Changeset in webkit [13646] by darin
  • 2 edits in trunk/WebCore
  • add a few stubs to get Windows closer to building
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles):
6:26 PM Changeset in webkit [13645] by darin
  • 2 edits in trunk/WebCore
  • fix the build
  • WebCore.xcodeproj/project.pbxproj: Removed a bunch of files that should not have been mentioned at all, and a bunch of others that should be in the project but not in the target.
6:17 PM Changeset in webkit [13644] by darin
  • 178 edits in trunk/LayoutTests
  • updated layout test results, mostly for the change in focus ring appearance
  • editing/input/range-for-empty-document-expected.txt:
  • editing/selection/3690703-2-expected.checksum:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-2-expected.txt:
  • fast/overflow/scrollRevealButton-expected.checksum:
  • fast/overflow/scrollRevealButton-expected.png:
  • fast/overflow/scrollRevealButton-expected.txt:
  • editing/deleting/collapse-whitespace-3587601-fix-expected.checksum:
  • editing/deleting/collapse-whitespace-3587601-fix-expected.png:
  • editing/deleting/delete-3608430-fix-expected.checksum:
  • editing/deleting/delete-3608430-fix-expected.png:
  • editing/deleting/delete-3608445-fix-expected.checksum:
  • editing/deleting/delete-3608445-fix-expected.png:
  • editing/deleting/delete-3608462-fix-expected.checksum:
  • editing/deleting/delete-3608462-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-4038408-fix-expected.checksum:
  • editing/deleting/delete-4038408-fix-expected.png:
  • editing/deleting/delete-4083333-fix-expected.checksum:
  • editing/deleting/delete-4083333-fix-expected.png:
  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-and-undo-expected.checksum:
  • editing/deleting/delete-and-undo-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-008-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • editing/deleting/delete-block-contents-001-expected.checksum:
  • editing/deleting/delete-block-contents-001-expected.png:
  • editing/deleting/delete-block-contents-002-expected.checksum:
  • editing/deleting/delete-block-contents-002-expected.png:
  • editing/deleting/delete-block-contents-003-expected.checksum:
  • editing/deleting/delete-block-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-001-expected.checksum:
  • editing/deleting/delete-block-merge-contents-001-expected.png:
  • editing/deleting/delete-block-merge-contents-002-expected.checksum:
  • editing/deleting/delete-block-merge-contents-002-expected.png:
  • editing/deleting/delete-block-merge-contents-003-expected.checksum:
  • editing/deleting/delete-block-merge-contents-003-expected.png:
  • editing/deleting/delete-block-merge-contents-004-expected.checksum:
  • editing/deleting/delete-block-merge-contents-004-expected.png:
  • editing/deleting/delete-block-merge-contents-005-expected.checksum:
  • editing/deleting/delete-block-merge-contents-005-expected.png:
  • editing/deleting/delete-block-merge-contents-006-expected.checksum:
  • editing/deleting/delete-block-merge-contents-006-expected.png:
  • editing/deleting/delete-block-merge-contents-007-expected.checksum:
  • editing/deleting/delete-block-merge-contents-007-expected.png:
  • editing/deleting/delete-block-merge-contents-008-expected.checksum:
  • editing/deleting/delete-block-merge-contents-008-expected.png:
  • editing/deleting/delete-block-merge-contents-009-expected.checksum:
  • editing/deleting/delete-block-merge-contents-009-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/delete-block-merge-contents-011-expected.checksum:
  • editing/deleting/delete-block-merge-contents-011-expected.png:
  • editing/deleting/delete-block-merge-contents-012-expected.checksum:
  • editing/deleting/delete-block-merge-contents-012-expected.png:
  • editing/deleting/delete-block-merge-contents-013-expected.checksum:
  • editing/deleting/delete-block-merge-contents-013-expected.png:
  • editing/deleting/delete-block-merge-contents-014-expected.checksum:
  • editing/deleting/delete-block-merge-contents-014-expected.png:
  • editing/deleting/delete-block-merge-contents-015-expected.checksum:
  • editing/deleting/delete-block-merge-contents-015-expected.png:
  • editing/deleting/delete-block-merge-contents-016-expected.checksum:
  • editing/deleting/delete-block-merge-contents-016-expected.png:
  • editing/deleting/delete-block-merge-contents-017-expected.checksum:
  • editing/deleting/delete-block-merge-contents-017-expected.png:
  • editing/deleting/delete-br-001-expected.checksum:
  • editing/deleting/delete-br-001-expected.png:
  • editing/deleting/delete-br-002-expected.checksum:
  • editing/deleting/delete-br-002-expected.png:
  • editing/deleting/delete-br-003-expected.checksum:
  • editing/deleting/delete-br-003-expected.png:
  • editing/deleting/delete-br-004-expected.checksum:
  • editing/deleting/delete-br-004-expected.png:
  • editing/deleting/delete-br-005-expected.checksum:
  • editing/deleting/delete-br-005-expected.png:
  • editing/deleting/delete-br-006-expected.checksum:
  • editing/deleting/delete-br-006-expected.png:
  • editing/deleting/delete-br-007-expected.checksum:
  • editing/deleting/delete-br-007-expected.png:
  • editing/deleting/delete-character-001-expected.checksum:
  • editing/deleting/delete-character-001-expected.png:
  • editing/deleting/delete-contiguous-ws-001-expected.checksum:
  • editing/deleting/delete-contiguous-ws-001-expected.png:
  • editing/deleting/delete-image-001-expected.checksum:
  • editing/deleting/delete-image-001-expected.png:
  • editing/deleting/delete-image-002-expected.checksum:
  • editing/deleting/delete-image-002-expected.png:
  • editing/deleting/delete-image-003-expected.checksum:
  • editing/deleting/delete-image-003-expected.png:
  • editing/deleting/delete-image-004-expected.checksum:
  • editing/deleting/delete-image-004-expected.png:
  • editing/deleting/delete-leading-ws-001-expected.checksum:
  • editing/deleting/delete-leading-ws-001-expected.png:
  • editing/deleting/delete-line-015-expected.checksum:
  • editing/deleting/delete-line-015-expected.png:
  • editing/deleting/delete-line-016-expected.checksum:
  • editing/deleting/delete-line-016-expected.png:
  • editing/deleting/delete-line-017-expected.checksum:
  • editing/deleting/delete-line-017-expected.png:
  • editing/deleting/delete-line-end-ws-001-expected.checksum:
  • editing/deleting/delete-line-end-ws-001-expected.png:
  • editing/deleting/delete-line-end-ws-002-expected.checksum:
  • editing/deleting/delete-line-end-ws-002-expected.png:
  • editing/deleting/delete-listitem-001-expected.checksum:
  • editing/deleting/delete-listitem-001-expected.png:
  • editing/deleting/delete-listitem-002-expected.checksum:
  • editing/deleting/delete-listitem-002-expected.png:
  • editing/deleting/delete-select-all-001-expected.checksum:
  • editing/deleting/delete-select-all-001-expected.png:
  • editing/deleting/delete-select-all-002-expected.checksum:
  • editing/deleting/delete-select-all-002-expected.png:
  • editing/deleting/delete-select-all-003-expected.checksum:
  • editing/deleting/delete-select-all-003-expected.png:
  • editing/deleting/delete-selection-001-expected.checksum:
  • editing/deleting/delete-selection-001-expected.png:
  • editing/deleting/delete-tab-001-expected.checksum:
  • editing/deleting/delete-tab-001-expected.png:
  • editing/deleting/delete-tab-002-expected.checksum:
  • editing/deleting/delete-tab-002-expected.png:
  • editing/deleting/delete-tab-003-expected.checksum:
  • editing/deleting/delete-tab-003-expected.png:
  • editing/deleting/delete-tab-004-expected.checksum:
  • editing/deleting/delete-tab-004-expected.png:
  • editing/deleting/delete-trailing-ws-001-expected.checksum:
  • editing/deleting/delete-trailing-ws-001-expected.png:
  • editing/deleting/delete-trailing-ws-002-expected.checksum:
  • editing/deleting/delete-trailing-ws-002-expected.png:
  • editing/deleting/delete-ws-fixup-001-expected.checksum:
  • editing/deleting/delete-ws-fixup-001-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-003-expected.checksum:
  • editing/deleting/delete-ws-fixup-003-expected.png:
  • editing/deleting/delete-ws-fixup-004-expected.checksum:
  • editing/deleting/delete-ws-fixup-004-expected.png:
  • editing/deleting/smart-delete-001-expected.checksum:
  • editing/deleting/smart-delete-001-expected.png:
  • editing/deleting/smart-delete-002-expected.checksum:
  • editing/deleting/smart-delete-002-expected.png:
  • editing/execCommand/boldSelection-expected.checksum:
  • editing/execCommand/boldSelection-expected.png:
  • editing/execCommand/insertHTML-expected.checksum:
  • editing/execCommand/insertHTML-expected.png:
  • editing/execCommand/insertImage-expected.checksum:
  • editing/execCommand/insertImage-expected.png:
  • editing/execCommand/italicizeByCharacter-expected.checksum:
  • editing/execCommand/italicizeByCharacter-expected.png:
  • editing/execCommand/modifyForeColorByCharacter-expected.checksum:
  • editing/execCommand/modifyForeColorByCharacter-expected.png:
  • editing/execCommand/print-expected.checksum:
  • editing/execCommand/print-expected.png:
  • editing/execCommand/selectAll-expected.checksum:
  • editing/execCommand/selectAll-expected.png:
  • editing/execCommand/strikethroughSelection-expected.checksum:
  • editing/execCommand/strikethroughSelection-expected.png:
  • editing/inserting/4278698-expected.checksum:
  • editing/inserting/4278698-expected.png:
  • editing/inserting/editing-empty-divs-expected.checksum:
  • editing/inserting/editing-empty-divs-expected.png:
  • editing/inserting/insert-3659587-fix-expected.checksum:
  • editing/inserting/insert-3659587-fix-expected.png:
  • editing/inserting/insert-3775316-fix-expected.checksum:
  • editing/inserting/insert-3775316-fix-expected.png:
  • editing/inserting/insert-3778059-fix-expected.checksum:
  • editing/inserting/insert-3778059-fix-expected.png:
  • editing/inserting/insert-3800346-fix-expected.checksum:
  • editing/inserting/insert-3800346-fix-expected.png:
  • editing/inserting/insert-after-delete-001-expected.checksum:
  • editing/inserting/insert-after-delete-001-expected.png:
  • editing/inserting/insert-at-end-01-expected.checksum:
  • editing/inserting/insert-at-end-01-expected.png:
  • editing/inserting/insert-at-end-02-expected.checksum:
  • editing/inserting/insert-at-end-02-expected.png:
  • editing/inserting/insert-br-001-expected.checksum:
  • editing/inserting/insert-br-001-expected.png:
  • editing/inserting/insert-br-002-expected.checksum:
  • editing/inserting/insert-br-002-expected.png:
  • editing/inserting/insert-br-003-expected.checksum:
  • editing/inserting/insert-br-003-expected.png:
  • editing/inserting/insert-br-004-expected.checksum:
  • editing/inserting/insert-br-004-expected.png:
  • editing/inserting/insert-br-005-expected.checksum:
  • editing/inserting/insert-br-005-expected.png:
  • editing/inserting/insert-br-006-expected.checksum:
  • editing/inserting/insert-br-006-expected.png:
  • editing/inserting/insert-br-007-expected.checksum:
  • editing/inserting/insert-br-007-expected.png:
  • editing/inserting/insert-br-008-expected.checksum:
  • editing/inserting/insert-br-008-expected.png:
  • editing/inserting/insert-br-at-tabspan-001-expected.checksum:
  • editing/inserting/insert-br-at-tabspan-001-expected.png:
  • editing/inserting/insert-br-at-tabspan-002-expected.checksum:
  • editing/inserting/insert-br-at-tabspan-002-expected.png:
  • editing/inserting/insert-br-at-tabspan-003-expected.checksum:
  • editing/inserting/insert-br-at-tabspan-003-expected.png:
  • editing/inserting/insert-br-quoted-001-expected.checksum:
  • editing/inserting/insert-br-quoted-001-expected.png:
  • editing/inserting/insert-br-quoted-002-expected.checksum:
  • editing/inserting/insert-br-quoted-002-expected.png:
  • editing/inserting/insert-br-quoted-003-expected.checksum:
  • editing/inserting/insert-br-quoted-003-expected.png:
  • editing/inserting/insert-br-quoted-004-expected.checksum:
  • editing/inserting/insert-br-quoted-004-expected.png:
  • editing/inserting/insert-br-quoted-005-expected.checksum:
  • editing/inserting/insert-br-quoted-005-expected.png:
  • editing/inserting/insert-br-quoted-006-expected.checksum:
  • editing/inserting/insert-br-quoted-006-expected.png:
  • editing/inserting/insert-div-025-expected.checksum:
  • editing/inserting/insert-div-025-expected.png:
  • editing/inserting/insert-div-026-expected.checksum:
  • editing/inserting/insert-div-026-expected.png:
  • editing/inserting/insert-space-in-empty-doc-expected.checksum:
  • editing/inserting/insert-space-in-empty-doc-expected.png:
  • editing/inserting/insert-tab-001-expected.checksum:
  • editing/inserting/insert-tab-001-expected.png:
  • editing/inserting/insert-tab-002-expected.checksum:
  • editing/inserting/insert-tab-002-expected.png:
  • editing/inserting/insert-tab-003-expected.checksum:
  • editing/inserting/insert-tab-003-expected.png:
  • editing/inserting/insert-tab-004-expected.checksum:
  • editing/inserting/insert-tab-004-expected.png:
  • editing/inserting/insert-text-at-tabspan-001-expected.checksum:
  • editing/inserting/insert-text-at-tabspan-001-expected.png:
  • editing/inserting/insert-text-at-tabspan-002-expected.checksum:
  • editing/inserting/insert-text-at-tabspan-002-expected.png:
  • editing/inserting/insert-text-at-tabspan-003-expected.checksum:
  • editing/inserting/insert-text-at-tabspan-003-expected.png:
  • editing/inserting/insert-text-with-newlines-expected.checksum:
  • editing/inserting/insert-text-with-newlines-expected.png:
  • editing/inserting/return-key-with-selection-001-expected.checksum:
  • editing/inserting/return-key-with-selection-001-expected.png:
  • editing/inserting/return-key-with-selection-002-expected.checksum:
  • editing/inserting/return-key-with-selection-002-expected.png:
  • editing/inserting/return-key-with-selection-003-expected.checksum:
  • editing/inserting/return-key-with-selection-003-expected.png:
  • editing/inserting/typing-001-expected.checksum:
  • editing/inserting/typing-001-expected.png:
  • editing/inserting/typing-002-expected.checksum:
  • editing/inserting/typing-002-expected.png:
  • editing/inserting/typing-003-expected.checksum:
  • editing/inserting/typing-003-expected.png:
  • editing/inserting/typing-around-br-001-expected.checksum:
  • editing/inserting/typing-around-br-001-expected.png:
  • editing/inserting/typing-around-image-001-expected.checksum:
  • editing/inserting/typing-around-image-001-expected.png:
  • editing/pasteboard/3976872-expected.checksum:
  • editing/pasteboard/3976872-expected.png:
  • editing/pasteboard/4076267-2-expected.checksum:
  • editing/pasteboard/4076267-2-expected.png:
  • editing/pasteboard/4076267-3-expected.checksum:
  • editing/pasteboard/4076267-3-expected.png:
  • editing/pasteboard/4076267-expected.checksum:
  • editing/pasteboard/4076267-expected.png:
  • editing/pasteboard/block-wrappers-necessary-expected.checksum:
  • editing/pasteboard/block-wrappers-necessary-expected.png:
  • editing/pasteboard/cut-text-001-expected.checksum:
  • editing/pasteboard/cut-text-001-expected.png:
  • editing/pasteboard/display-block-on-spans-expected.checksum:
  • editing/pasteboard/display-block-on-spans-expected.png:
  • editing/pasteboard/paste-4035648-fix-expected.checksum:
  • editing/pasteboard/paste-4035648-fix-expected.png:
  • editing/pasteboard/paste-4038267-fix-expected.checksum:
  • editing/pasteboard/paste-4038267-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-line-endings-001-expected.checksum:
  • editing/pasteboard/paste-line-endings-001-expected.png:
  • editing/pasteboard/paste-line-endings-002-expected.checksum:
  • editing/pasteboard/paste-line-endings-002-expected.png:
  • editing/pasteboard/paste-line-endings-003-expected.checksum:
  • editing/pasteboard/paste-line-endings-003-expected.png:
  • editing/pasteboard/paste-line-endings-004-expected.checksum:
  • editing/pasteboard/paste-line-endings-004-expected.png:
  • editing/pasteboard/paste-line-endings-005-expected.checksum:
  • editing/pasteboard/paste-line-endings-005-expected.png:
  • editing/pasteboard/paste-line-endings-006-expected.checksum:
  • editing/pasteboard/paste-line-endings-006-expected.png:
  • editing/pasteboard/paste-line-endings-007-expected.checksum:
  • editing/pasteboard/paste-line-endings-007-expected.png:
  • editing/pasteboard/paste-line-endings-008-expected.checksum:
  • editing/pasteboard/paste-line-endings-008-expected.png:
  • editing/pasteboard/paste-line-endings-009-expected.checksum:
  • editing/pasteboard/paste-line-endings-009-expected.png:
  • editing/pasteboard/paste-line-endings-010-expected.checksum:
  • editing/pasteboard/paste-line-endings-010-expected.png:
  • editing/pasteboard/paste-list-001-expected.checksum:
  • editing/pasteboard/paste-list-001-expected.png:
  • editing/pasteboard/paste-match-style-001-expected.checksum:
  • editing/pasteboard/paste-match-style-001-expected.png:
  • editing/pasteboard/paste-match-style-002-expected.checksum:
  • editing/pasteboard/paste-match-style-002-expected.png:
  • editing/pasteboard/paste-pre-001-expected.checksum:
  • editing/pasteboard/paste-pre-001-expected.png:
  • editing/pasteboard/paste-pre-002-expected.checksum:
  • editing/pasteboard/paste-pre-002-expected.png:
  • editing/pasteboard/paste-table-001-expected.checksum:
  • editing/pasteboard/paste-table-001-expected.png:
  • editing/pasteboard/paste-text-001-expected.checksum:
  • editing/pasteboard/paste-text-001-expected.png:
  • editing/pasteboard/paste-text-017-expected.checksum:
  • editing/pasteboard/paste-text-017-expected.png:
  • editing/pasteboard/paste-text-018-expected.checksum:
  • editing/pasteboard/paste-text-018-expected.png:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.checksum:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.png:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.checksum:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.png:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.checksum:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.png:
  • editing/pasteboard/smart-paste-001-expected.checksum:
  • editing/pasteboard/smart-paste-001-expected.png:
  • editing/pasteboard/smart-paste-002-expected.checksum:
  • editing/pasteboard/smart-paste-002-expected.png:
  • editing/pasteboard/smart-paste-003-expected.checksum:
  • editing/pasteboard/smart-paste-003-expected.png:
  • editing/pasteboard/smart-paste-004-expected.checksum:
  • editing/pasteboard/smart-paste-004-expected.png:
  • editing/pasteboard/smart-paste-005-expected.checksum:
  • editing/pasteboard/smart-paste-005-expected.png:
  • editing/pasteboard/smart-paste-006-expected.checksum:
  • editing/pasteboard/smart-paste-006-expected.png:
  • editing/pasteboard/smart-paste-007-expected.checksum:
  • editing/pasteboard/smart-paste-007-expected.png:
  • editing/selection/3690703-expected.checksum:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690719-expected.checksum:
  • editing/selection/3690719-expected.png:
  • editing/selection/6476-expected.checksum:
  • editing/selection/6476-expected.png:
  • editing/selection/after-line-wrap-expected.checksum:
  • editing/selection/after-line-wrap-expected.png:
  • editing/selection/end-of-document-expected.checksum:
  • editing/selection/end-of-document-expected.png:
  • editing/selection/expanding-selections-expected.checksum:
  • editing/selection/expanding-selections-expected.png:
  • editing/selection/expanding-selections2-expected.checksum:
  • editing/selection/expanding-selections2-expected.png:
  • editing/selection/extend-by-character-001-expected.checksum:
  • editing/selection/extend-by-character-001-expected.png:
  • editing/selection/extend-by-character-002-expected.checksum:
  • editing/selection/extend-by-character-002-expected.png:
  • editing/selection/extend-by-character-003-expected.checksum:
  • editing/selection/extend-by-character-003-expected.png:
  • editing/selection/extend-by-character-004-expected.checksum:
  • editing/selection/extend-by-character-004-expected.png:
  • editing/selection/extend-by-character-005-expected.checksum:
  • editing/selection/extend-by-character-005-expected.png:
  • editing/selection/extend-by-character-006-expected.checksum:
  • editing/selection/extend-by-character-006-expected.png:
  • editing/selection/extend-by-word-001-expected.checksum:
  • editing/selection/extend-by-word-001-expected.png:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/fake-doubleclick-expected.checksum:
  • editing/selection/fake-doubleclick-expected.png:
  • editing/selection/fake-drag-expected.checksum:
  • editing/selection/fake-drag-expected.png:
  • editing/selection/iframe-expected.checksum:
  • editing/selection/iframe-expected.png:
  • editing/selection/image-before-linebreak-expected.checksum:
  • editing/selection/image-before-linebreak-expected.png:
  • editing/selection/inline-table-expected.checksum:
  • editing/selection/inline-table-expected.png:
  • editing/selection/leave-requested-block-expected.checksum:
  • editing/selection/leave-requested-block-expected.png:
  • editing/selection/move-backwords-by-word-001-expected.checksum:
  • editing/selection/move-backwords-by-word-001-expected.png:
  • editing/selection/move-between-blocks-no-001-expected.checksum:
  • editing/selection/move-between-blocks-no-001-expected.png:
  • editing/selection/move-by-character-001-expected.checksum:
  • editing/selection/move-by-character-001-expected.png:
  • editing/selection/move-by-character-002-expected.checksum:
  • editing/selection/move-by-character-002-expected.png:
  • editing/selection/move-by-character-003-expected.checksum:
  • editing/selection/move-by-character-003-expected.png:
  • editing/selection/move-by-character-004-expected.checksum:
  • editing/selection/move-by-character-004-expected.png:
  • editing/selection/move-by-character-005-expected.checksum:
  • editing/selection/move-by-character-005-expected.png:
  • editing/selection/move-by-character-6-expected.checksum:
  • editing/selection/move-by-character-6-expected.png:
  • editing/selection/move-by-line-001-expected.checksum:
  • editing/selection/move-by-line-001-expected.png:
  • editing/selection/move-by-line-002-expected.checksum:
  • editing/selection/move-by-line-002-expected.png:
  • editing/selection/move-by-word-001-expected.checksum:
  • editing/selection/move-by-word-001-expected.png:
  • editing/selection/previous-line-position-expected.checksum:
  • editing/selection/previous-line-position-expected.png:
  • editing/selection/replaced-boundaries-1-expected.checksum:
  • editing/selection/replaced-boundaries-1-expected.png:
  • editing/selection/replaced-boundaries-2-expected.checksum:
  • editing/selection/replaced-boundaries-2-expected.png:
  • editing/selection/replaced-boundaries-3-expected.checksum:
  • editing/selection/replaced-boundaries-3-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-box-expected.checksum:
  • editing/selection/select-box-expected.png:
  • editing/selection/selection-3748164-fix-expected.checksum:
  • editing/selection/selection-3748164-fix-expected.png:
  • editing/selection/triple-click-in-pre-expected.checksum:
  • editing/selection/triple-click-in-pre-expected.png:
  • editing/selection/unrendered-001-expected.checksum:
  • editing/selection/unrendered-001-expected.png:
  • editing/selection/unrendered-002-expected.checksum:
  • editing/selection/unrendered-002-expected.png:
  • editing/selection/unrendered-003-expected.checksum:
  • editing/selection/unrendered-003-expected.png:
  • editing/selection/unrendered-004-expected.checksum:
  • editing/selection/unrendered-004-expected.png:
  • editing/selection/unrendered-005-expected.checksum:
  • editing/selection/unrendered-005-expected.png:
  • editing/style/block-style-004-expected.checksum:
  • editing/style/block-style-004-expected.png:
  • editing/style/block-style-005-expected.checksum:
  • editing/style/block-style-005-expected.png:
  • editing/style/block-style-006-expected.checksum:
  • editing/style/block-style-006-expected.png:
  • editing/style/block-styles-007-expected.checksum:
  • editing/style/block-styles-007-expected.png:
  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.png:
  • editing/style/remove-underline-after-paragraph-expected.checksum:
  • editing/style/remove-underline-after-paragraph-expected.png:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.png:
  • editing/style/remove-underline-expected.checksum:
  • editing/style/remove-underline-expected.png:
  • editing/style/remove-underline-from-stylesheet-expected.checksum:
  • editing/style/remove-underline-from-stylesheet-expected.png:
  • editing/style/remove-underline-in-bold-expected.checksum:
  • editing/style/remove-underline-in-bold-expected.png:
  • editing/style/smoosh-styles-001-expected.checksum:
  • editing/style/smoosh-styles-001-expected.png:
  • editing/style/smoosh-styles-002-expected.checksum:
  • editing/style/smoosh-styles-002-expected.png:
  • editing/style/smoosh-styles-003-expected.checksum:
  • editing/style/smoosh-styles-003-expected.png:
  • editing/style/style-3681552-fix-001-expected.checksum:
  • editing/style/style-3681552-fix-001-expected.png:
  • editing/style/style-3681552-fix-002-expected.checksum:
  • editing/style/style-3681552-fix-002-expected.png:
  • editing/style/style-3690704-fix-expected.checksum:
  • editing/style/style-3690704-fix-expected.png:
  • editing/style/style-3998892-fix-expected.checksum:
  • editing/style/style-3998892-fix-expected.png:
  • editing/style/style-boundary-001-expected.checksum:
  • editing/style/style-boundary-001-expected.png:
  • editing/style/style-boundary-002-expected.checksum:
  • editing/style/style-boundary-002-expected.png:
  • editing/style/style-boundary-003-expected.checksum:
  • editing/style/style-boundary-003-expected.png:
  • editing/style/style-boundary-004-expected.checksum:
  • editing/style/style-boundary-004-expected.png:
  • editing/style/typing-style-001-expected.checksum:
  • editing/style/typing-style-001-expected.png:
  • editing/style/typing-style-002-expected.checksum:
  • editing/style/typing-style-002-expected.png:
  • editing/style/typing-style-003-expected.checksum:
  • editing/style/typing-style-003-expected.png:
  • editing/style/unbold-in-bold-expected.checksum:
  • editing/style/unbold-in-bold-expected.png:
  • editing/style/underline-expected.checksum:
  • editing/style/underline-expected.png:
  • editing/undo/4063751-expected.checksum:
  • editing/undo/4063751-expected.png:
  • editing/undo/redo-typing-001-expected.checksum:
  • editing/undo/redo-typing-001-expected.png:
  • editing/undo/undo-typing-001-expected.checksum:
  • editing/undo/undo-typing-001-expected.png:
  • editing/unsupported-content/list-delete-001-expected.checksum:
  • editing/unsupported-content/list-delete-001-expected.png:
  • editing/unsupported-content/list-delete-002-expected.checksum:
  • editing/unsupported-content/list-delete-002-expected.png:
  • editing/unsupported-content/list-delete-003-expected.checksum:
  • editing/unsupported-content/list-delete-003-expected.png:
  • editing/unsupported-content/list-type-after-expected.checksum:
  • editing/unsupported-content/list-type-after-expected.png:
  • editing/unsupported-content/list-type-before-expected.checksum:
  • editing/unsupported-content/list-type-before-expected.png:
  • editing/unsupported-content/table-delete-001-expected.checksum:
  • editing/unsupported-content/table-delete-001-expected.png:
  • editing/unsupported-content/table-delete-002-expected.checksum:
  • editing/unsupported-content/table-delete-002-expected.png:
  • editing/unsupported-content/table-delete-003-expected.checksum:
  • editing/unsupported-content/table-delete-003-expected.png:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.png:
  • fast/css/outline-auto-empty-rects-expected.checksum:
  • fast/css/outline-auto-empty-rects-expected.png:
  • fast/css/outline-auto-location-expected.checksum:
  • fast/css/outline-auto-location-expected.png:
  • fast/dom/focus-contenteditable-expected.checksum:
  • fast/dom/focus-contenteditable-expected.png:
  • fast/encoding/utf-16-big-endian-expected.checksum:
  • fast/encoding/utf-16-big-endian-expected.png:
  • fast/encoding/utf-16-little-endian-expected.checksum:
  • fast/encoding/utf-16-little-endian-expected.png:
  • fast/events/focusingUnloadedFrame-expected.checksum:
  • fast/events/focusingUnloadedFrame-expected.png:
  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-focus-expected.png:
  • fast/forms/input-appearance-readonly-expected.checksum: Added.
  • fast/forms/input-appearance-readonly-expected.png: Added.
  • fast/forms/input-appearance-selection-expected.checksum:
  • fast/forms/input-appearance-selection-expected.png:
  • fast/forms/input-paste-undo-expected.checksum: Added.
  • fast/forms/input-paste-undo-expected.png: Added.
  • fast/forms/input-text-double-click-expected.checksum:
  • fast/forms/input-text-double-click-expected.png:
  • fast/forms/input-text-option-delete-expected.checksum:
  • fast/forms/input-text-option-delete-expected.png:
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum:
  • fast/forms/input-text-scroll-left-on-blur-expected.png:
  • fast/lists/drag-into-marker-expected.checksum:
  • fast/lists/drag-into-marker-expected.png:
  • fast/overflow/childFocusRingClip-expected.checksum:
  • fast/overflow/childFocusRingClip-expected.png:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
6:16 PM Changeset in webkit [13643] by darin
  • 95 edits in trunk/LayoutTests/editing/selection
  • updated layout test results, mostly for the change in focus ring appearance
6:15 PM Changeset in webkit [13642] by darin
  • 90 edits in trunk/LayoutTests/editing/inserting
  • updated layout test results, mostly for the change in focus ring appearance
6:14 PM Changeset in webkit [13641] by darin
  • 158 edits in trunk/LayoutTests/editing/deleting
  • updated layout test results, mostly for the change in focus ring appearance
6:12 PM Changeset in webkit [13640] by darin
  • 33 edits
    4 adds in trunk/LayoutTests/fast
  • updated layout test results, mostly for the change in focus ring appearance
6:11 PM Changeset in webkit [13639] by darin
  • 23 edits in trunk/WebCore

Reviewed by Adele.

  • some cleanup to how we parse user agent style sheets
  • css/CSSValueKeywords.in: Added -webkit-focus-ring-color.
  • css/cssstyleselector.cpp: (WebCore::parseUASheet): Parse an array of chars instead of UTF-16. Cuts the size of the style sheet in half. (WebCore::CSSStyleSelector::applyProperty): Allow negative value for outline-offset. Changed shadow parsing to use getColorFromPrimitiveValue instead of repeating the same logic. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Added a case for the focus ring color.
  • rendering/render_style.h: (WebCore::RenderStyle::setOutlineOffset): Changed to allow negative values.
  • css/html4.css: Removed a lot of excess spaces. Changed color of focus to -webkit-focus-ring-color. Changed width of focus to 5px. Added an outline-offset for <input type=text> of -2px.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Added focus ring color as an outline color all the time, and as any other color when not in strict mode. I'm confused about what's best for this whole strict mode policy, and I may need advice on Hyatt to perfect this one later. (WebCore::CSSParser::parseColorFromValue): Removed code to pin r, g, and b because the functions in platform already take care of that. Kept the pinning of a, though because that's done in floating point before converting to an integer. (WebCore::CSSParser::parseShadow): Allow focus ring color when not in strict mode.
  • bridge/mac/FrameMac.h: Eliminated the virtual detachFromView function.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Eliminated code to maintain the frame instances list. (WebCore::FrameMac::~FrameMac): Ditto. (WebCore::Frame::setNeedsReapplyStyles): Added.
  • bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
  • platform/mac/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): Changed to call the new Page::setNeedsReapplyStylesForSettingsChange instead of using the obsolete Frame::instances.
  • page/Frame.h: Removed instances, mutableInstances, and detachFromView.
  • page/Frame.cpp: Ditto.
  • page/FrameTree.cpp: (WebCore::FrameTree::~FrameTree): Call setView(0) instead of detachFromView(). (WebCore::FrameTree::removeChild): Ditto.
  • page/Page.h:
  • page/Page.cpp: (WebCore::Page::init): Added a set of pages instead of a page count. Also register a function for when the focus ring color changes the first time this is called. (WebCore::Page::~Page): Call setView(0) instead of detachFromView. Also update to manager the set of pages. (WebCore::Page::setNeedsReapplyStyles): Call setNeedsReapplyStyles on all frames. (WebCore::Page::setNeedsReapplyStylesForSettingsChange): Call setNeedsReapplyStyles on all frames with the passed-in settings.
  • css/make-css-file-arrays.pl: Changed to run the C preprocessor on the input files and to generate an array of char instead of unsigned short.
  • platform/PlatformString.h: Added a constructor that takes a char* and a length.
  • platform/String.cpp: (WebCore::String::String): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Just some tweaks; adding in a few files like the user agent style sheets.
  • platform/Color.h: Removed all use of DeprecatedString. Cleaned up a bit. Added focusRingColor and setFocusRingColorChangeFunction.
  • platform/Color.cpp: (WebCore::makeRGB): Rewrote using max and min. (WebCore::makeRGBA): Ditto. (WebCore::parseHexColor): Cleaned up a bit; changed partway to String instead of DeprecatedString. (WebCore::Color::Color): Changed to use String and to call setNamedColor to save code. (WebCore::Color::setNamedColor): Changed to use String in the interface.
  • platform/mac/ColorMac.mm: (WebCore::observeTheme): Added. Function used to start up the observer. (WebCore::setFocusRingColorChangeFunction): Added. Used to get a call back so we can update all the views when the color changes (including recomputing style to get the color change in). (WebCore::setFocusRingColorChangeFunction): Added. Returns one of the two focus ring colors. Both of these match what AppKit uses -- neither matches what we used to have in the html4.css file. (+[WebCoreControlTintObserver controlTintDidChange]): Added. Used to update when the appearance is changed from blue to graphite and back. We keep a global so we don't have to call over to AppKit every time; that's probably overkill but we need the obsever for the color change function anyway.
12:54 PM Changeset in webkit [13638] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/inline-block/overflow-clip-expected.checksum: Added.
  • fast/inline-block/overflow-clip-expected.png: Added.
  • fast/inline-block/overflow-clip-expected.txt: Added.
  • fast/inline-block/overflow-clip.html: Added.

WebCore:

Test: fast/inline-block/overflow-clip.html

Reviewed by Darin.

  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): Don't look at interior overflow when calculating the contribution to the inline's vertical overflows.
5:13 AM Changeset in webkit [13637] by eseidel
  • 11 edits in trunk/WebCore

2006-04-02 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Make WebCore safe against KJS::Node in JavaScriptCore private headers.

  • editing/ReplaceSelectionCommand.h:
  • khtml/ecma/JSXMLSerializer.cpp: (KJS::XMLSerializerProtoFunc::callAsFunction):
  • khtml/ecma/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNode::mark): (KJS::DOMNode::getValueProperty): (KJS::DOMNode::putValueProperty): (KJS::DOMNodeProtoFunc::callAsFunction): (KJS::toNode): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMDocumentProtoFunc::callAsFunction): (KJS::DOMElement::putValueProperty): (KJS::DOMElementProtoFunc::callAsFunction): (KJS::checkNodeSecurity): (KJS::toJS): (KJS::getRuntimeObject): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
  • khtml/ecma/kjs_events.cpp: (KJS::JSLazyEventListener::JSLazyEventListener): (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::framesetNameGetter): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::JSHTMLElement::pushEventHandlerScope): (KJS::JSHTMLCollection::callAsFunction): (KJS::JSHTMLCollection::getNamedItems): (KJS::JSHTMLSelectCollection::put):
  • khtml/ecma/kjs_traversal.cpp: (KJS::JSNodeFilterCondition::acceptNode):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::put):
  • kwq/KWQPageState.mm: (-[KWQPageState WebCore::]):
4:41 AM Changeset in webkit [13636] by eseidel
  • 1 edit
    1 add in trunk/JavaScriptGlue

2006-04-02 Eric Seidel <​eseidel@apple.com>

Reviewed by andersca.

Add missing forwarding header.

  • kxmlcore/Vector.h: Added.
12:55 AM Changeset in webkit [13635] by ggaren
  • 5 edits
    1 add in trunk/JavaScriptGlue

Reviewed by Darin.

  • Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz Composer

JSValueWrappers used to hold on to the ExecState that pertained at
the time of their creation. Since ExecStates are transient, that
design was totally bogus, and it would crash once the ExecState had
been deallocated.

Unfortunately, there's no clean solution to this problem, since
the JSGlue API has no notion of state. The solution here is to use
a shared, global ExecState for the purpose of JSGlue calls. Given
the pre-existing limitations in the JSGlue API, this design
shouldn't actually introduce any new limitations (see comments in
JSValueWrapper.cpp).

I tested with Quartz Composer and PAC files, neither of which are
layout-testable.


  • JSUtils.cpp: (KJSValueToJSObject):
  • JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): (JSValueWrapper::GetValue): (getProcessGlobalExecState): (JSValueWrapper::JSObjectCopyPropertyNames): (JSValueWrapper::JSObjectCopyProperty): (JSValueWrapper::JSObjectSetProperty): (JSValueWrapper::JSObjectCallFunction): (JSValueWrapper::JSObjectCopyCFValue):
  • JSValueWrapper.h:

Also added a test harness file. It was helpful while I was testing,
and may come in handy in the future:


  • JavaScriptGlue.xcodeproj/project.pbxproj: testjsglue.cpp: Added.

Apr 1, 2006:

6:41 PM Changeset in webkit [13634] by darin
  • 75 edits
    6 deletes in trunk/WebCore

Reviewed by Eric.

  • removed a bunch of unneeded ForwardingHeaders and WebCore+SVG headers
  • ForwardingHeaders/kcanvas: Removed.
  • ForwardingHeaders/kcanvas/KCanvas.h: Removed.
  • ForwardingHeaders/kdom: Removed.
  • ForwardingHeaders/kdom/DOMString.h: Removed.
  • ForwardingHeaders/kdom/Helper.h: Removed.
  • ForwardingHeaders/kdom/KDOMSettings.h: Removed.
  • ForwardingHeaders/kdom/Namespace.h: Removed.
  • ForwardingHeaders/kdom/cache: Removed.
  • ForwardingHeaders/kdom/cache/KDOMCachedImage.h: Removed.
  • ForwardingHeaders/kdom/cache/KDOMCachedObject.h: Removed.
  • ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h: Removed.
  • ForwardingHeaders/kdom/cache/KDOMCachedScript.h: Removed.
  • ForwardingHeaders/kdom/cache/KDOMLoader.h: Removed.
  • ForwardingHeaders/kdom/core: Removed.
  • ForwardingHeaders/kdom/core/DOMConfiguration.h: Removed.
  • ForwardingHeaders/kdom/core/DOMException.h: Removed.
  • ForwardingHeaders/kdom/core/DOMList.h: Removed.
  • ForwardingHeaders/kdom/core/DOMString.h: Removed.
  • ForwardingHeaders/kdom/core/NamedAttrMap.h: Removed.
  • ForwardingHeaders/kdom/core/ProcessingInstruction.h: Removed.
  • ForwardingHeaders/kdom/core/domattrs.h: Removed.
  • ForwardingHeaders/kdom/ecma: Removed.
  • ForwardingHeaders/kdom/ecma/GlobalObject.h: Removed.
  • ForwardingHeaders/kdom/events: Removed.
  • ForwardingHeaders/kdom/events/Event.h: Removed.
  • ForwardingHeaders/kdom/events/EventListener.h: Removed.
  • ForwardingHeaders/kdom/events/EventTarget.h: Removed.
  • ForwardingHeaders/kdom/events/KeyboardEvent.h: Removed.
  • ForwardingHeaders/kdom/events/MouseEvent.h: Removed.
  • ForwardingHeaders/kdom/events/UIEvent.h: Removed.
  • ForwardingHeaders/kdom/events/kdomevents.h: Removed.
  • ForwardingHeaders/kdom/kdom.h: Removed.
  • ForwardingHeaders/kdom/parser: Removed.
  • ForwardingHeaders/kdom/parser/KDOMParser.h: Removed.
  • ForwardingHeaders/ksvg2: Removed.
  • ForwardingHeaders/ksvg2/KSVGPart.h: Removed.
  • ForwardingHeaders/ksvg2/KSVGView.h: Removed.
  • ForwardingHeaders/ksvg2/css: Removed.
  • ForwardingHeaders/ksvg2/css/CSSPropertyNames.h: Removed.
  • ForwardingHeaders/ksvg2/css/CSSValueKeywords.h: Removed.
  • WebCore+SVG/KDOMHeaders.h: Removed.
  • WebCore+SVG/Namespace.h: Removed.
  • WebCore+SVG/kdom.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed headers.
  • kcanvas/KCanvasCreator.cpp:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasTreeDebug.cpp:
  • kcanvas/RenderPath.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/misc/KSVGTimeScheduler.cpp:
  • ksvg2/misc/SVGImageLoader.cpp:
  • ksvg2/svg/SVGAElement.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp:
  • ksvg2/svg/SVGCircleElement.cpp:
  • ksvg2/svg/SVGClipPathElement.cpp:
  • ksvg2/svg/SVGCursorElement.cpp:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDOMImplementation.cpp:
  • ksvg2/svg/SVGDocument.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.cpp:
  • ksvg2/svg/SVGEllipseElement.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.cpp:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEFloodElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFEImageElement.cpp:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFilterElement.cpp:
  • ksvg2/svg/SVGGradientElement.cpp:
  • ksvg2/svg/SVGHelper.cpp:
  • ksvg2/svg/SVGImageElement.cpp:
  • ksvg2/svg/SVGLangSpace.cpp:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLineElement.cpp:
  • ksvg2/svg/SVGLinearGradientElement.cpp:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGLocatable.cpp:
  • ksvg2/svg/SVGMarkerElement.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.cpp:
  • ksvg2/svg/SVGPathElement.cpp:
  • ksvg2/svg/SVGPatternElement.cpp:
  • ksvg2/svg/SVGPolyElement.cpp:
  • ksvg2/svg/SVGPolygonElement.cpp:
  • ksvg2/svg/SVGPolylineElement.cpp:
  • ksvg2/svg/SVGRadialGradientElement.cpp:
  • ksvg2/svg/SVGRectElement.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGStopElement.cpp:
  • ksvg2/svg/SVGStyleElement.cpp:
  • ksvg2/svg/SVGStyledElement.cpp:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGTextElement.cpp:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGUseElement.cpp:
  • ksvg2/svg/SVGViewElement.cpp: Updated includes.
5:57 PM Changeset in webkit [13633] by eseidel
  • 2 edits in trunk/WebKitLibraries

2006-04-01 Eric Seidel <​eseidel@apple.com>

  • libWebKitSystemInterface.a: commit a universal binary.
4:14 PM Changeset in webkit [13632] by darin
  • 1 add in trunk/LayoutTests/fast/forms/input-text-scroll-left-on-blur-expected.png

Oops. File was in change log, but not in commit.

4:04 PM Changeset in webkit [13631] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Need a way to make a test for this. No obvious way at the moment.

  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Consider border, padding, and the width of the caret properly in the calculation of the caret's X position.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect): Fixed some similar issues and rewrote this function for clarity. However, I suspect this function was and remains broken and is almost never called.
3:35 PM Changeset in webkit [13630] by darin
  • 9 edits
    3 adds in trunk

LayoutTests:

Reviewed by Justin.

  • fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
  • fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
  • fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
  • fast/forms/input-text-scroll-left-on-blur.html: Added.

WebCore:

Reviewed by Justin.

Test: fast/forms/input-text-scroll-left-on-blur.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Pass blur events through to the RenderTextField, as well as mouse, drag, and wheel events.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll all the way to the left on a blur.
  • unrelated small changes
  • html/HTMLTextFieldInnerElement.cpp: Removed excess includes. (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Tweaked comments a bit.
  • dom/Element.cpp: (WebCore::Element::scrollIntoView): Removed unneeded this-> before function call. (WebCore::Element::scrollIntoViewIfNeeded): Ditto.
  • page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): Removed obsolete comment.

WebKitTools:

Reviewed by Justin.

  • DumpRenderTree/EventSendingController.m: (-[EventSendingController keyDown:withModifiers:]): Fixed keyDown function so that it will work if you don't pass an array of modifiers or if elements in that array are not strings.
2:27 PM Changeset in webkit [13629] by darin
  • 2 edits in trunk/WebKitLibraries

Reviewed by Beth.

  • libWebKitSystemInterface.a: Changed alpha in the focus-ring drawing code to use the system default alpha.
12:59 PM Changeset in webkit [13628] by mjs
  • 1 edit in trunk/WebCore/editing/ReplaceSelectionCommand.cpp

Ooops, actually land the fix with this ChangeLog entry:

2006-03-31 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Adele.


<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into an empty editable subtree.
11:39 AM Changeset in webkit [13627] by darin
  • 62 edits in trunk/LayoutTests
  • re-updated many pixel results to try to create a new baseline
2:14 AM Changeset in webkit [13626] by mjs
  • 2 edits
    2 adds in trunk

LayoutTests:

Test cases for:


<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

  • fast/forms/input-paste-undo-expected.txt: Added.
  • fast/forms/input-paste-undo.html: Added.

WebCore:

Reviewed by Adele.


<rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into an empty editable subtree.
1:40 AM Changeset in webkit [13625] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/input-text-double-click-expected.checksum: Added.
  • fast/forms/input-text-double-click-expected.png: Added.
  • fast/forms/input-text-double-click-expected.txt: Added.
  • fast/forms/input-text-double-click.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/forms/input-text-double-click.html

  • editing/visible_units.cpp: (WebCore::nextBoundary): Set the end of the range by calling selectNodeContents rather than by calling setEndAfter. The problem with setEndAfter is that it doesn't do anything when the parent of the node is 0, and also it's not really what we want, since the boundary node is one with editable contents -- we want to stay inside the boundary node.
  • editing/Selection.cpp: (WebCore::Selection::validate): Fix a tiny formatting glitch I noticed at the same time.
1:32 AM Changeset in webkit [13624] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/input-text-option-delete-expected.checksum: Added.
  • fast/forms/input-text-option-delete-expected.png: Added.
  • fast/forms/input-text-option-delete-expected.txt: Added.
  • fast/forms/input-text-option-delete.html: Added.

WebKit:

Reviewed by Maciej.

Test: fast/forms/input-text-option-delete.html

  • WebView/WebHTMLView.m: (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Pass NO for smartDeleteOK. Smart deletion only applies to deleting a word at a time, and none of the callers of this function that delete a word at a time want smart deletion. (-[WebHTMLView deleteToEndOfLine:]): Fixed tiny formatting glitch.

Mar 31, 2006:

4:40 PM Changeset in webkit [13623] by thatcher
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Knocking the number of PLTs we run down to 3 to see if we come in under the BuildBot timeout.

4:12 PM Changeset in webkit [13622] by thatcher
  • 1 edit in trunk/WebKitTools/BuildSlaveSupport/run-performance-tests

Knocking the number of PLTs we run down to 4 to see if we come in under the BuildBot timeout.

3:14 PM Changeset in webkit [13621] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.


  • fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word doesn't select it or offer corrections (first click only)
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): Rolled in this one-line change that Hyatt wrote ages ago.
2:39 PM Changeset in webkit [13620] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

We need to set reachedTerminalState to YES before we release
the resources to prevent a double dealloc of WebView

Fixes <rdar://problem/4372628> crash deallocating a WebView in -[WebFrame stopLoading]

  • WebView/WebLoader.m: (-[NSURLProtocol releaseResources]): set reachedTerminalState earlier
1:50 PM Changeset in webkit [13619] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by John.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8108
REGRESSION (r13590-r13593): Floating table's cells don't paint
their background

This is a regression from my painting patch yesterday. Just a silly
error I didn't catch.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint): Change the phase of our new PaintInfo, not our old one.
1:36 PM Changeset in webkit [13618] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


Some cleanup in the WebIconDatabase code in a fruitless search for the cause
of the mysterious -[WebFileDatabase performSetObject:forKey] crash

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): removed obsolete comment (-[WebIconDatabase _loadIconDictionaries]): Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until the end of the method where they are retained, so that the early returns don't leak; added ASSERTs that the _private->dictionary values aren't being leaked. (-[WebIconDatabase _updateFileDatabase]): Added an ERROR for an unexpected early return, and made a trivial style fix.
12:58 PM Changeset in webkit [13617] by tomernic
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

Layout test for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
<rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

  • fast/forms/input-appearance-readonly-expected.txt: Added.
  • fast/forms/input-appearance-readonly.html: Added.

WebCore:

Reviewed by Adele.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
<rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute


  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): Set user modify based on the form element's readOnly(). (WebCore::RenderTextField::updateFromElement): ditto
12:44 PM Changeset in webkit [13616] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim Omernick.

Updating shadowAncestorNode so it doesn't check for rootEditableElement. Now we just walk
up the tree to look for a shadowNode, and then we find the shadowParent.

  • dom/Node.cpp: (WebCore::Node::shadowAncestorNode):
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Updated assertion to check for shadowAncestorNode instead of rootEditableElement.
12:30 PM Changeset in webkit [13615] by ap
  • 3 edits
    2 copies
    7 adds in trunk

Fix by Trey Matteson, reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

Tests: http/tests/misc/acid2.html, http/tests/misc/acid2-pixel.html

The gist of this change is that we must cancel the load from the Webkit side when we
realize we're switching to the fallback content. This is somewhat a temp workaround
since control of loading will be moving to WebCore.

  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
12:12 PM Changeset in webkit [13614] by adele
  • 3 edits in trunk/WebCore

Reviewed by John Sullivan.


  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesVertically): Change top and bottom positions only if childAffectsTopBottomPos is true.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Redo a part of the patch for bug 7031 that wasn't committed with the rest of the patch.
11:16 AM Changeset in webkit [13613] by bdakin
  • 3 edits
    4 adds in trunk

Reviewed by Darin, landed by Beth.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8081
REGRESSION: Drop-down menu has gap at top

  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcAbsoluteVerticalValues): When calculating the hypothetical vertical position in normal flow, skip table rows in the ancestor chain, since a table cell's Y position is relative to the table section, not the row.
11:03 AM Changeset in webkit [13612] by hyatt
  • 4 edits in trunk/WebCore

FIx theme borders on win32.

10:51 AM Changeset in webkit [13611] by darin
  • 14 edits
    2 adds in trunk

LayoutTests:

  • updated results for tests that involve scrolling
  • editing/selection/focus_editable_html-expected.txt: Added expected scroll position.
  • fast/dom/focus-contenteditable-expected.txt: Ditto.
  • fast/overflow/scrollRevealButton.html: Ditto.
  • updated results for tests that involve new exception names
  • fast/dom/Element/attr-param-typechecking-expected.txt: Updated.
  • fast/dynamic/insertAdjacentElement-expected.txt: Updated.
  • fast/dynamic/insertAdjacentElement-expected.png: Added.
  • fast/dynamic/insertAdjacentElement-expected.checksum: Added.

WebCore:

Reviewed by John Sullivan.

  • khtml/ecma/kjs_binding.cpp: Added names for VALIDATION_ERR and TYPE_MISMATCH_ERR; new DOM Level 3 errors that need to be listed in the mapping from error code to error name.
  • dom/Element.idl: Removed comment from bad old days where we had to touch these files to make them rebuild.

WebKitTools:

Reviewed by John Sullivan.

  • added a "--reset-results" option to run-webkit-tests so you can reset the results without first deleting expected results
  • <rdar://problem/4185878> add scroll position to dumpRenderTree
  • Scripts/run-webkit-tests: Rearranged the code a bit to make the sequence more logical. Moved all the subroutines to the end of the file. Added a "--force" option.
  • DumpRenderTree/DumpRenderTree.m: (main): Added a new --dump-all-pixels option, used when forcing run-webkit-tests to generate new output for all tests it runs. (dump): Dump the scroll position if it's non-zero. Always dump the image when the --dump-all-pixels option is passed. Also tightened up the image dumping code and replaced the incorrect use of +[NSGraphicsContext saveGraphicsState] with code to save and restore the context.
  • DumpRenderTree/DumpRenderTree.h: Tweaked includes a bit and added (void).
  • DumpRenderTree/EventSendingController.m: Added now-needed include.
10:02 AM Changeset in webkit [13610] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • <rdar://problem/4395622> API: WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript returns NO by default
  • bindings/objc/WebScriptObject.h: Fixed comment.
9:40 AM Changeset in webkit [13609] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
Focus ring around link in overflow:auto div isn't clipped to div

8:39 AM Changeset in webkit [13608] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Removed all the tabs and cleared the "allow tabs" bit.

3:45 AM Changeset in webkit [13607] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderTheme.cpp

Fix my build bustage with themes.

3:32 AM Changeset in webkit [13606] by mjs
  • 4 edits in trunk/WebCore
  • fixed Windows build breakage from previous change
  • platform/ScrollView.h:
  • platform/win/FontWin.cpp: (WebCore::Font::drawLineForText):
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollBy):
3:24 AM Changeset in webkit [13605] by mjs
  • 22 edits in trunk/WebCore

Reviewed by Eric.


  • various Point / Size related cleanup


First, I clarified the semantics of some operations to keep a
better distinction between IntPoint and IntSize:


  • platform/IntPoint.h: (WebCore::IntPoint::move): new convenience to move a point by separate x and y deltas. (WebCore::operator+=): You can't add a point to a point, you can only add a size to a point. (WebCore::operator+): ditto (WebCore::operator-): point - point = size; point - size = point (WebCore::operator-=): only allow subtracting a size for the mutating version
  • platform/IntRect.h: (WebCore::IntRect::move): tweaked to use IntPoint::move, also, move by an IntSize, not an IntPoint.
  • platform/IntSize.h: (WebCore::IntSize::shrunkTo): analog to expandedTo (WebCore::IntSize::clampNegativeToZero): a handy helper (WebCore::operator-): Added unary minus operator

Made the same changes for FloatPoint:


  • platform/FloatPoint.h: (WebCore::FloatPoint::move): (WebCore::operator+=): (WebCore::operator-=): (WebCore::operator+): (WebCore::operator-):
  • platform/FloatRect.h: (WebCore::FloatRect::move):
  • platform/FloatSize.h: (WebCore::operator-):

Then I changed a bunch of stuff to pass around IntPoint instead of separate x and y
coordinates. The main one was:


  • platform/ScrollView.h:
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::scrollOffset): new method, return an IntSize (WebCore::ScrollView::contentsToViewport): take and return an IntPoint (WebCore::ScrollView::viewportToContents): take and return an IntPoint
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateContents): handle things in terms of scrollOffset, not scrollPoint (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::scrollOffset): (WebCore::ScrollView::maximumScroll): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::updateScrollBars):

The rest is mainly updates for these changes.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::eventMayStartDrag): (WebCore::FrameMac::dragHysteresisExceeded): (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::mouseDown): (WebCore::FrameMac::shouldDragAutoNode): (WebCore::FrameMac::sendContextMenuEvent):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isPointInsideSelection:]):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent): (WebCore::EventTargetNode::dispatchWheelEvent):
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • page/Frame.cpp: (WebCore::Frame::shouldDragAutoNode): (WebCore::Frame::isPointInsideSelection): (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventDoubleClick): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEventPart2): (WebCore::Frame::handleMouseReleaseEvent):
  • page/Frame.h:
  • page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): (WebCore::FrameView::prepareMouseEvent): (WebCore::FrameView::handleWheelEvent):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode):
  • rendering/RenderObject.h: (WebCore::RenderObject::positionForPoint):
  • rendering/render_list.cpp: (WebCore::RenderListMarker::paint):
3:18 AM Changeset in webkit [13604] by mjs
  • 2 edits in trunk/WebCore
  • fixed windows build
  • platform/win/TemporaryLinkStubs.cpp: (Widget::unlockDrawingFocus):
1:15 AM Changeset in webkit [13603] by eseidel
  • 8 edits in trunk/JavaScriptCore

2006-03-31 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

A bit more code cleanup.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
  • bindings/objc/objc_runtime.mm: (convertValueToObjcObject):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue):
  • kjs/function.cpp: (KJS::GlobalFuncImp::callAsFunction):
  • kjs/interpreter.cpp: (KJS::ExecState::lexicalInterpreter):
  • kjs/interpreter.h:
  • kjs/operations.cpp: (KJS::equal):
1:14 AM Changeset in webkit [13602] by eseidel
  • 9 edits in trunk/WebCore

2006-03-31 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

A bit more code cleanup.

  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue):
  • kwq/WebCoreTextField.mm: (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQSecureTextField selectText:]):
  • page/Frame.cpp: (WebCore::Frame::submitForm):
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm:
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
Note: See TracTimeline for information about the timeline view.