Timeline



Apr 16, 2006:

11:50 PM Changeset in webkit [13893] by darin
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/selection/extend-by-word-002-expected.checksum: Updated.
  • editing/selection/extend-by-word-002-expected.png: Updated.
  • fast/lists/markers-in-selection-expected.checksum: Added.
  • fast/lists/markers-in-selection-expected.png: Added.
  • fast/lists/markers-in-selection-expected.txt: Added.
  • fast/lists/markers-in-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/lists/markers-in-selection.html

  • rendering/RenderObject.h: Added selectionColorImageOverlayAlpha constant - the maximum opacity of the selection color when painted over images.
  • rendering/render_list.cpp: (WebCore::RenderListMarker::RenderListMarker): (WebCore::RenderListMarker::paint): Paint the selection highlight if selected: over the marker for image markers, under the marker for all other markers. (WebCore::RenderListMarker::setSelectionState): Added. (WebCore::RenderListMarker::selectionRect): Added. (WebCore::RenderListMarker::selectionColor): Added. Ensures that the selection color is transparent for image markers.
  • rendering/render_list.h: (WebCore::RenderListMarker::selectionState): (WebCore::RenderListMarker::canBeSelectionLeaf):
  • rendering/render_replaced.cpp (WebCore::RenderReplaced::selectionColor): Changed to use the selectionColorImageOverlayAlpha constant.
11:15 PM Changeset in webkit [13892] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/button-inner-block-reuse-expected.checksum: Added.
  • fast/forms/button-inner-block-reuse-expected.png: Added.
  • fast/forms/button-inner-block-reuse-expected.txt: Added.
  • fast/forms/button-inner-block-reuse.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/button-inner-block-reuse.html

Buttons have a distinguished anonymous child that holds all their other
descendants. Descendants ended up in a sibling anonymous block as the
initial anonymous child was being reused to hold the initial part of an
inline that got split.

  • rendering/RenderInline.cpp: (WebCore::RenderInline::splitFlow): Check if the anonymous block's parent allows us to reuse it.
  • rendering/RenderObject.h: (WebCore::RenderObject::allowsReusingAnonymousChild): Added. Returns true.
  • rendering/render_button.h: (WebCore::RenderButton::allowsReusingAnonymousChild): Added. Returns false.
11:01 PM Changeset in webkit [13891] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

  • editing/pasteboard/drop-text-without-selection-expected.checksum: Added.
  • editing/pasteboard/drop-text-without-selection-expected.png: Added.
  • editing/pasteboard/drop-text-without-selection-expected.txt: Added.
  • editing/pasteboard/drop-text-without-selection.html: Added.

WebCore:

Reviewed by Justin.

Test: editing/pasteboard/drop-text-without-selection.html

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithText:]): Changed to allow creating a fragment regardless of the selection.
10:46 PM Changeset in webkit [13890] by darin
  • 11 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • bridge/mac/WebCoreFrameBridge.h:
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder:. (-[KWQPopUpButton resignFirstResponder]): Cleaned up.
  • kwq/KWQListBox.mm: Ditto. (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder: and cleaned up. (-[KWQSlider resignFirstResponder]): Cleaned up.
  • platform/mac/WebCoreTextArea.mm: (-[WebCoreTextView becomeFirstResponder]): Added call to formControlIsBecomingFirstResponder:. (-[WebCoreTextView resignFirstResponder]): Cleaned up.
  • platform/mac/WebCoreTextField.mm: (-[KWQTextFieldController setHasFocus:]): Added call to formControlIsBecomingFirstResponder:.
  • manual-tests/textarea-focus.html: Added.

WebKit:

Reviewed by Darin.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge formControlIsBecomingFirstResponder:]): Added. Calls the ancestor WebHTMLView's _formControlIsBecomingFirstResponder:
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateFocusState:]): If a descendant is becoming first responder, enable focused appearance. (-[WebHTMLView _formControlIsBecomingFirstResponder:]): Added. Calls _updateFocusState, causing the frame to display with focus attributes.
  • WebView/WebHTMLViewInternal.h:
10:34 PM Changeset in webkit [13889] by darin
  • 7 edits
    1 add in trunk/WebCore

Reviewed by Adele and Justin.

Calling SelectionController::nodeWillBeRemoved from Document::notifyBeforeNodeRemoval
fixes the crash, which was happening because the call that was removing the text
node, removeChildren, does not send a "node removed" mutation event (it sends a
"subtree modified" mutation event instead). So this change alone fixes the crash.

But I also changed setInnerText to not blow away the text node each time the value
is changed, and that makes the test case behave even better -- you don't even lose
the selection; it works as it did with the NSTextField-based text field.

  • manual-tests/input-empty-on-focus.html: Added.
  • page/Frame.h: Tweaked a few comments and functions related to selection.
  • page/Frame.cpp: (WebCore::Frame::dragCaret): Made non-const.
  • dom/Document.cpp: (WebCore::Document::notifyBeforeNodeRemoval): Call nodeWillBeRemoved on the two selection controllers before removing a node from the document.
  • editing/SelectionController.h: Tweak formatting. Remove MutationListener class and m_mutationListener field.
  • editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): Remove code to set up the mutation event listener. (WebCore::SelectionController::setSelection): Remove code to maintain the mutation event listener.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setInnerHTML): In cases where the container has only a single child use replaceChild, and in cases where the HTML being inserted also has only a single child and both are text nodes use setData. It's common to use setInnerHTML to set something that's just text. (WebCore::HTMLElement::setInnerText): Same as above, but simpler since the thing we're replacing with is always text.
8:10 PM Changeset in webkit [13888] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • css/make-css-file-arrays.pl: Remove the "-" parameter from the invocation of cpp, which means "send output to stdout". It's optional on Mac OS X, and is causing a hang on Linux.
  • rendering/RenderArena.cpp: Added a missing include of <assert.h>.
2:36 PM Changeset in webkit [13887] by jdevalk
  • 3 edits in trunk/WebKitSite
  • Small textual change to my contact info;
  • Added bugreporting URL for non ADC members.
2:22 PM Changeset in webkit [13886] by jdevalk
  • 2 edits in trunk/WebKitSite

Added info on CIA, trac, build bot and webkit-unassigned

2:29 AM Changeset in webkit [13885] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (crashHandler): Added a handler for signals that are raised on a crash. Keeping separate from the existing handler for manual interruption (SIGINT/SIGHUP/SIGTERM), because I'm trying to find a way to prevent the Crash Reporter dialog from appearing on crash, and this code may change significantly.

(main): Install crashHandler.

(setDefaultColorProfileToRGB): Properly convert CFStringRef to a char buffer
(CFStringGetCStringPtr should NEVER EVER be used!).

Apr 15, 2006:

8:05 PM Changeset in webkit [13884] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/install-win-extras: Try to fix the Windows build by fixing the URLs here. Seems xmlsoft.org's HTTP no longer has what we need.
7:28 PM Changeset in webkit [13883] by darin
  • 2 edits in trunk/WebCore
  • removed references to a couple files that are obsolete but were still in the Windows project file
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove kjs_views.h and .cpp.
7:20 PM Changeset in webkit [13882] by mjs
  • 8 edits
    1 move in branches/treecode/JavaScriptCore

Reviewed by Darin.


  • rename InterpreterState to Opcode
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/InterpreterState.h: Removed.
  • kjs/Opcode.h: Added. (KJS::):
  • kjs/TreeCode.cpp: (KJS::): (KJS::isEvaluateOpcode): (KJS::isEvaluateListOpcode): (KJS::isExecuteState): (KJS::pushEvaluate): (KJS::pushEvaluateList): (KJS::pushExecute): (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/internal.cpp: (KJS::printUnwindBarrier): (KJS::InterpreterImp::printStateStack): (KJS::InterpreterImp::unwindToNextBarrier):
  • kjs/internal.h: (KJS::InterpreterImp::State::State):
  • kjs/nodes.cpp: (Node::Node):
  • kjs/nodes.h: (KJS::Node::opcode): (KJS::ExprNode::ExprNode): (KJS::StatementNode::StatementNode): (KJS::JumpNode::JumpNode): (KJS::ForExprEndNode::ForExprEndNode):
6:26 PM Changeset in webkit [13881] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • more results for tests landed without pixel-test results
  • fast/text/whitespace/pre-newline-box-test-expected.checksum: Added.
  • fast/text/whitespace/pre-newline-box-test-expected.png: Added.
12:27 PM Changeset in webkit [13880] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript): Use isEmpty() instead of isNull() for checking the domain to determine if the document in a local file.
11:13 AM Changeset in webkit [13879] by darin
  • 1 edit
    7 adds in trunk/LayoutTests
  • added some results for some tests people added without expected results
  • svg/custom/class-selector-expected.txt: Added.
  • svg/custom/class-selector-expected.checksum: Added.
  • svg/custom/class-selector-expected.png: Added.
  • editing/selection/extend-by-sentence-001-expected.checksum: Added.
  • editing/selection/extend-by-sentence-001-expected.png: Added.
  • fast/dom/Element/null-offset-parent-expected.checksum: Added.
  • fast/dom/Element/null-offset-parent-expected.png: Added.
11:10 AM Changeset in webkit [13878] by darin
  • 2 edits in trunk/LayoutTests
  • updated a layout test result for Hyatt's prefix change
  • fast/inspector/style-expected.txt: Some background properties now have the "-webkit" prefix.

Apr 14, 2006:

10:38 PM Changeset in webkit [13877] by thatcher
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Timothy.

Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Adds a category to WebScriptObject with array accessors for KVC/KVO.

If super valueForKey: fails it will call valueForUndefinedKey:, which is
important because it causes the right behavior to happen with bindings using
the "Raises for Not Applicable Keys" flag and the "Not Applicable Placeholder"

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject valueForKey:]): (-[WebScriptObject count]): (-[WebScriptObject objectAtIndex:]): (-[WebUndefined description]): return "undefined"

WebKit:

Reviewed by Timothy.

Bug 8389: support for Cocoa bindings - binding an NSTreeController to the WebView's DOM
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Added a controller class, WebController, that is a subclass of
NSTreeController that has a new outlet/binding for the WebView.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]): notify bindings about the document change
  • WebView/WebView.m: (-[WebView _progressStarted:]): notify bindings about the document change (-[WebView _finalProgressComplete]): notify bindings about the document change (-[WebView _declaredKeys]): added a key for the main frame document (-[WebController init]): (-[WebController exposedBindings]): (-[WebController valueClassForBinding:]): (-[WebController setContent:]): (-[WebController webView]): (-[WebController setWebView:]): (-[WebView mainFrameDocument]): get the main frame's DOMDocument
  • WebView/WebViewPrivate.h: Adds mainFrameDocument to pending public.
5:53 PM Changeset in webkit [13876] by mjs
  • 1 edit
    1 add in branches/treecode/JavaScriptCore
  • missing part of last commit
  • kjs/Expr.h: Added.
5:28 PM Changeset in webkit [13875] by eseidel
  • 2 edits in branches/treecode/JavaScriptCore/kjs

Mark the list stack, fix assertion hit when collector runs out of memory. r=mjs

3:50 PM Changeset in webkit [13874] by hyatt
  • 31 edits in trunk/WebCore

CSS vendor-specific property/value cleanup. Properly qualify background-clip,
background-origin, border-image and the border-radius properties. Make sure
our overflow extensions of marquee and overlay are qualified as well. Rename
the -khtml- extension to -webkit.

Reviewed by beth

  • bindings/js/kjs_css.cpp: (KJS::cssPropertyName):
  • bindings/objc/DOMCSS.mm: (-[DOMCSSStyleDeclaration _fontSizeDelta]): (-[DOMCSSStyleDeclaration _setFontSizeDelta:]):
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _setAutofilled:]):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::valueForTextAlign): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSGrammar.y:
  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/css_valueimpl.cpp: (WebCore::):
  • css/css_valueimpl.h:
  • css/cssparser.cpp: (WebCore::CSSParser::parseRule): (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseColor): (WebCore::CSSParser::parseDeclaration): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseBackgroundColor): (WebCore::CSSParser::parseBackgroundProperty): (WebCore::CSSParser::parseFontFamily): (WebCore::CSSParser::parseShadow):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/html4.css:
  • css/quirks.css:
  • css/tokenizer.flex:
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init): (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): (WebCore::ApplyStyleCommand::removeInlineStyle):
  • editing/CompositeEditCommand.cpp: (WebCore::blockPlaceholderClassString):
  • editing/JSEditor.cpp:
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::fixupNodeStyles): (WebCore::styleForNode):
  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode):
  • html/HTMLElement.cpp: (WebCore::HTMLElement::addHTMLAlignment): (WebCore::HTMLElement::setContentEditable):
  • html/html_blockimpl.cpp: (WebCore::HTMLDivElement::parseMappedAttribute): (WebCore::HTMLParagraphElement::parseMappedAttribute): (WebCore::HTMLMarqueeElement::parseMappedAttribute):
  • html/html_inlineimpl.cpp: (WebCore::HTMLFontElement::parseMappedAttribute):
  • html/html_tableimpl.cpp: (WebCore::HTMLTablePartElement::parseMappedAttribute): (WebCore::HTMLTableCellElement::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::canMouseDownStartSelect):
  • page/Frame.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode):
3:01 PM Changeset in webkit [13873] by eseidel
  • 3 edits in trunk/WebCore

2006-04-14 Eric Seidel <​eseidel@apple.com>

Reviewed by beth.

Fix win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • page/FramePrivate.h:
2:37 PM Changeset in webkit [13872] by eseidel
  • 4 edits in trunk/WebCore

2006-04-04 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix build-warnings in cairo code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8176

  • platform/cairo/cairo/src/cairo-win32-surface.c: (_cairo_win32_print_gdi_error): (_cairo_win32_surface_create_for_dc): (_composite_alpha_blend): (cairo_win32_surface_create):
  • platform/cairo/pixman/src/iccolor.c: (pixman_pixel_to_color):
2:25 PM Changeset in webkit [13871] by mjs
  • 1 edit in branches/treecode/JavaScriptCore/ChangeLog

Updated ChangeLog to note this:

Makes treecode branch 10% faster.

2:25 PM Changeset in webkit [13870] by mjs
  • 11 edits in branches/treecode/JavaScriptCore

Reviewed by Darin.


  • changed expression grammar production rules to make flattened output


Expressions now form lists instead of trees, so that use of the
state stack can be avoided.

  • kjs/InterpreterState.h:
  • kjs/TreeCode.cpp: (KJS::InterpreterImp::runInterpreterLoop):
  • kjs/grammar.y:
  • kjs/internal.cpp:
  • kjs/internal.h: (KJS::Stack::fromLast): (KJS::Stack::swapLastTwo):
  • kjs/lexer.cpp:
  • kjs/nodes.cpp: (Node::throwError): (ForNode::processVarDecls): (ForInNode::ForInNode):
  • kjs/nodes.h: (KJS::ExprNode::ExprNode): (KJS::ExprNode::next): (KJS::ExprStatementEndNode::ExprStatementEndNode): (KJS::ExprStatementEndNode::streamTo): (KJS::ArgumentEndNode::ArgumentEndNode): (KJS::ArgumentEndNode::streamTo): (KJS::PropertyEndNode::PropertyEndNode): (KJS::PropertyEndNode::streamTo): (KJS::ElementEndNode::ElementEndNode): (KJS::ElementEndNode::streamTo): (KJS::NullNode::NullNode): (KJS::BooleanNode::BooleanNode): (KJS::NumberNode::NumberNode): (KJS::StringNode::StringNode): (KJS::RegExpNode::RegExpNode): (KJS::ThisNode::ThisNode): (KJS::ResolveNode::ResolveNode): (KJS::ArrayNode::ArrayNode): (KJS::PropertyNode::PropertyNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::BracketAccessorNode::BracketAccessorNode): (KJS::BracketAccessorNode::isBracketAccessorNode): (KJS::DotAccessorNode::DotAccessorNode): (KJS::DotAccessorNode::isDotAccessorNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentListNode::streamTo): (KJS::ArgumentsNode::streamTo): (KJS::NewExprNode::NewExprNode): (KJS::FunctionCallNode::FunctionCallNode): (KJS::PostfixNode::PostfixNode): (KJS::PostfixBracketNode::PostfixBracketNode): (KJS::DeleteNode::DeleteNode): (KJS::DeleteBracketNode::DeleteBracketNode): (KJS::DeleteValueNode::DeleteValueNode): (KJS::VoidNode::VoidNode): (KJS::TypeOfResolveNode::TypeOfResolveNode): (KJS::TypeOfValueNode::TypeOfValueNode): (KJS::PrefixNode::PrefixNode): (KJS::PrefixBracketNode::PrefixBracketNode): (KJS::UnaryPlusNode::UnaryPlusNode): (KJS::NegateNode::NegateNode): (KJS::BitwiseNotNode::BitwiseNotNode): (KJS::LogicalNotNode::LogicalNotNode): (KJS::MultNode::MultNode): (KJS::AddNode::AddNode): (KJS::ShiftNode::ShiftNode): (KJS::RelationalNode::RelationalNode): (KJS::EqualNode::EqualNode): (KJS::BitOperNode::BitOperNode): (KJS::JumpNode::JumpNode): (KJS::NoOpNode::NoOpNode): (KJS::ReadModifyAssignNode::ReadModifyAssignNode): (KJS::AssignNode::AssignNode): (KJS::ReadModifyAssignBracketNode::ReadModifyAssignBracketNode): (KJS::AssignBracketNode::AssignBracketNode): (KJS::CommaNode::CommaNode): (KJS::VarDeclNode::VarDeclNode::VarDeclNode): (KJS::VarDeclEndNode::VarDeclEndNode): (KJS::VarDeclEndNode::streamTo): (KJS::ExprStatementNode::ExprStatementNode): (KJS::IfConditionEndNode::IfConditionEndNode): (KJS::IfConditionEndNode::streamTo): (KJS::DoWhileTestExprEndNode::DoWhileTestExprEndNode): (KJS::DoWhileTestExprEndNode::streamTo): (KJS::WhileTestExprEndNode::WhileTestExprEndNode): (KJS::WhileTestExprEndNode::streamTo): (KJS::ForNode::ForNode): (KJS::ForExprEndNode::ForExprEndNode): (KJS::ForExprEndNode::streamTo): (KJS::ReturnNode::ReturnNode): (KJS::ValueReturnEndNode::ValueReturnEndNode): (KJS::WithExprEndNode::WithExprEndNode): (KJS::WithExprEndNode::streamTo): (KJS::ThrowEndNode::ThrowEndNode): (KJS::FuncExprNode::FuncExprNode):
  • kjs/nodes2string.cpp: (ExprNode::streamTo): (ReturnNode::streamTo):
  • kjs/testkjs.cpp: (TestFunctionImp::callAsFunction): bug fix (doIt): fix to avoid false positive leak reports (kjsmain): ditto
1:22 AM Changeset in webkit [13869] by hyatt
  • 2696 edits
    2 adds in trunk/LayoutTests

Land updated layout tests.

1:15 AM Changeset in webkit [13868] by hyatt
  • 13 edits in trunk/WebCore

Fix for 8333, make sure newlines in whitespace:pre (and friends) get
line boxes created for them. This resolves all the weird selection/navigation
issues that arise by not creating lines (and thus not having navigable positions
on those lines).

This checkin is also removing all of the layout test hacks that have piled
up, so layout test results are being regenerated completely.

Reviewed by eric

  • dom/Position.cpp: (WebCore::Position::downstream):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph):
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
  • editing/visible_units.cpp: (WebCore::startOfParagraph): (WebCore::endOfParagraph):
  • kwq/RenderTreeAsText.cpp: (getTagName): (operator<<):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionState): (WebCore::InlineTextBox::isLineBreak): (WebCore::InlineTextBox::nodeAtPoint): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::offsetForPosition): (WebCore::InlineTextBox::positionForOffset):
  • rendering/InlineTextBox.h:
  • rendering/RenderBR.cpp:
  • rendering/RenderBR.h:
  • rendering/RenderText.cpp: (WebCore::RenderText::atLineWrap): (WebCore::RenderText::caretRect): (WebCore::RenderText::height): (WebCore::RenderText::inlineBox):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::findNextLineBreak):
  • rendering/render_line.h: (WebCore::InlineBox::isLineBreak):

Apr 13, 2006:

6:17 PM Changeset in webkit [13867] by darin
  • 5 edits
    2 copies
    8 moves in trunk/WebCore

Reviewed by Geoff.

  • moved a few things out of kwq and cleaned up the Java-applet-related renderers
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file location and name changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/JavaAppletWidget.h: Moved.
  • kwq/JavaAppletWidget.mm: Moved.
  • kwq/RegularExpression.cpp: Moved.
  • kwq/RegularExpression.h: Moved.
  • kwq/RenderTreeAsText.cpp: Moved.
  • kwq/RenderTreeAsText.h: Moved.
  • rendering/render_applet.cpp: Moved.
  • rendering/render_applet.h: Moved.
  • bridge/JavaAppletWidget.h: Moved here.
  • bridge/mac/JavaAppletWidget.mm: Moved here.
  • platform/RegularExpression.cpp: Moved here.
  • platform/RegularExpression.h: Moved here.
  • rendering/RenderTreeAsText.cpp: Moved here.
  • rendering/RenderTreeAsText.h: Moved here.
  • rendering/RenderApplet.h: Moved here and made changes. Removed unused element() function.
  • rendering/RenderApplet.cpp: Moved here and made changes. (WebCore::RenderApplet::RenderApplet): Changed parameter type to be more precise (HTMLAppletElement). (WebCore::RenderApplet::intrinsicWidth): Removed unnecessary type cast and simplified. (WebCore::RenderApplet::intrinsicHeight): Ditto. (WebCore::RenderApplet::createWidgetIfNecessary): Straightened out the if statements and changed to use node() instead of element(). (WebCore::RenderApplet::layout): Removed unneeded check before calling createWidgetIfNecessary.
  • rendering/RenderEmptyApplet.h: Moved here and made changes. Removed unneeded overrides of intrinsicWidth and intrinsicHeight.
  • rendering/RenderEmptyApplet.cpp: Moved here and made changes. (WebCore::RenderEmptyApplet::RenderEmptyApplet): Added code to set the intrinsic width and height.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::RenderWidget): Initialize m_widget with contructor syntax. (WebCore::RenderWidget::paint): Changed _tx and _ty to be just tx and ty. Rearranged the code so the transparent wash will draw even if m_widget is 0.
  • html/html_objectimpl.cpp: Update includes for new file names.
4:06 PM Changeset in webkit [13866] by eseidel
  • 10 edits in branches/treecode/JavaScriptCore

Removed (most) macros from TreeCode.cpp
Removed Imp from state names
Removed Interpreter ring (using interpreter map instead)
Removed push/pop/peek accessors for stacks.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8363
Reviewed by Darin.

2:24 PM Changeset in webkit [13865] by ggaren
  • 29 edits
    8 adds
    4 deletes in trunk

JavaScriptCore:

Reviewed by Darin.

  • kjs/internal.cpp: (KJS::InterpreterImp::initGlobalObject): Add the built-in object prototype to the end of the global object's prototype chain instead of just blowing away its existing prototype. We need to do this because the window object has a meaningful prototype now.

LayoutTests:

Layout test for document.defaultView

  • fast/dom/defaultView-expected.txt: Added.
  • fast/dom/defaultView.html: Added.
  • fast/events/event-view-toString-expected.txt: Updated to reflect new prototype chain for defaultView.

WebCore:

Reviewed by Darin.

  • Fixed <rdar://problem/4478467> document.defaultView should return the window object


Also made part of the window object autogenerated by IDL file.


  • DerivedSources.make: Added /page to IDL file search path, added JSDOMWindow.h, removed kjs_views.lut.h
  • WebCore.xcodeproj/project.pbxproj: Added missing files, removed obsolete files
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded):
  • bindings/js/kjs_views.cpp: Removed.
  • bindings/js/kjs_views.h: Removed.
  • bindings/js/kjs_window.cpp: Removed document property -- it now belongs to JSDOMWindow. Added toJS and toDOMWindow. (KJS::Window::Window): (KJS::Window::impl): (KJS::Window::getValueProperty): (KJS::Window::clear): Added call to setPrototype to ensure that the prototype gets cleared during navigation. (Previously this wasn't an issue because the window object had no real prototype.) (WebCore::toJS): (WebCore::toDOMWindow):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • bindings/objc/DOMCSS.mm: Added NULL checks for the AbstractView (Presumably this is an issue after the window is closed.) Typedef-ed AbstractView as DOMWindow. I could have just replaced AbstractView with DOMWindow, but I think it's clearer to say, "There's this thing called the AbstractView, but really it's just the window." (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMViews.mm:
  • bindings/objc/DOMViewsInternal.h:
  • bindings/scripts/CodeGeneratorJS.pm: Removed unused GetLegacyImplementationIncludes. Added support for DOMWindow and new "DoNotCache" attribute. Replaced C macros with text because (1) it makes the generated source easier to read and debug and (2) it made it much easier to implement the DoNotCache attribute.
  • bindings/scripts/IDLParser.pm: Return a hash reference instead of a hash, because otherwise an interface with more than one attribute returns too many arguments to be processed.
  • bridge/mac/FrameMac.mm:
  • dom/AbstractView.cpp: Removed.
  • dom/AbstractView.h: Removed.
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultView):
  • dom/Document.h:
  • dom/Document.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/Position.cpp:
  • dom/UIEvent.idl:
  • dom/dom2_eventsimpl.h:
  • page/DOMWindow.cpp: Added. (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::frame): (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::document): (WebCore::DOMWindow::getComputedStyle): (WebCore::DOMWindow::getMatchedCSSRules):
  • page/DOMWindow.h: Added.
  • page/DOMWindow.idl: Added.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Disconnect the new DOMWindow object in addition to the Window object. Maybe we can unify this in the future. (WebCore::Frame::tree): (WebCore::Frame::domWindow):
  • page/Frame.h:
  • page/FramePrivate.h:
1:52 PM Changeset in webkit [13864] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej.

  • projects/compat/hitlist.html: Added Google Calendar to the list in place of www.hangseng.com/ebanking
10:03 AM Changeset in webkit [13863] by ap
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

  • html/HTMLTokenizer.cpp: Only use fixUpChar() when handling entities. (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseText): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::write):
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::convert): Remove the special case for Latin-1, because it is already handled via effectiveEncoding().
  • platform/StreamingTextDecoder.h: Remove convertLatin1().

LayoutTests:

Tests that Latin-1 is handled as windows-1252
(see ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7602). Some existing tests
already did cover this, but only indirectly.

  • fast/encoding/latin1-winlatin-expected.txt: Added.
  • fast/encoding/latin1-winlatin.html: Added.
8:50 AM Changeset in webkit [13862] by darin
  • 2 edits in trunk/WebCore
  • platform/mac/GraphicsContextMac.mm: Fix one no-SVG compile problem by adding a "using namespace std".
3:33 AM Changeset in webkit [13861] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • fix testkjs to not show false-positive KJS::Node leaks in debug builds
  • kjs/testkjs.cpp: (doIt): (kjsmain):
12:48 AM Changeset in webkit [13860] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Refining the list of renames to be done soon.

12:07 AM Changeset in webkit [13859] by darin
  • 54 edits
    1 delete in trunk/WebCore

Rubber-stamped by Anders.

  • fix Windows build
  • WebCore.vcproj/Image\ Viewer/Image\ Viewer.vcproj: Add loader directory.
  • use std::min/max exclusively intead of kMin/Max
  • eliminate KWQDef.h since all it had left in it was kMin/Max
  • WebCore.vcproj/WebCore/WebCore.vcproj: Remove KWQDef.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/KWQDef.h: Removed.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize): (WebCore::CSSStyleSelector::fontSizeForKeyword):
  • dom/Document.cpp: (WebCore::Document::minimumLayoutDelay): (WebCore::Document::addMarker):
  • dom/StyledElement.cpp: (WebCore::StyledElement::addCSSColor):
  • dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::readOutBytes):
  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::CharacterIterator::string): (WebCore::findPlainText):
  • editing/htmlediting.cpp: (WebCore::rangeCompliantEquivalent):
  • editing/markup.cpp: (WebCore::renderedText):
  • editing/visible_units.cpp: (WebCore::startOfParagraph):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseComment): (WebCore::HTMLTokenizer::parseEntity): (WebCore::HTMLTokenizer::parseTag): (WebCore::HTMLTokenizer::enlargeBuffer): (WebCore::HTMLTokenizer::enlargeScriptBuffer):
  • html/html_imageimpl.cpp: (WebCore::HTMLAreaElement::getRegion):
  • html/html_tableimpl.cpp: (WebCore::HTMLTableElement::parseMappedAttribute):
  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):
  • kwq/KWQComboBox.mm: (QComboBox::sizeHint):
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
  • kwq/KWQSlider.mm: (QSlider::setValue):
  • loader/Cache.cpp: (WebCore::Cache::setSize):
  • page/Frame.cpp: (WebCore::Frame::forceLayoutWithPageWidthRange):
  • platform/DeprecatedPtrListImpl.h:
  • platform/DeprecatedString.cpp: (ucstrcmp):
  • platform/DeprecatedString.h:
  • platform/DeprecatedValueListImpl.h:
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::addRoundedRectClip):
  • platform/mac/WebCoreTextArea.mm: (-[WebCoreTextView _trackResizeFromMouseDown:]):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::isSelected): (WebCore::InlineTextBox::selectionRect): (WebCore::InlineTextBox::placeEllipsisBox): (WebCore::InlineTextBox::selectionStartEnd): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintSpellingMarker): (WebCore::InlineTextBox::paintTextMatchMarker): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowRect): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::estimateVerticalPosition): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::setCollapsedBottomMargin): (WebCore::RenderBlock::handleBottomOfBlock): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap): (WebCore::RenderBlock::positionNewFloats): (WebCore::RenderBlock::nearestFloatBottom): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::getClearDelta): (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcInlineMinMaxWidth): (WebCore::RenderBlock::calcBlocminMaxWidth):
  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/RenderCanvas.cpp: (WebCore::RenderCanvas::layout):
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::calcMinMaxWidth): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox): (WebCore::RenderFlexibleBox::allowedChildFlex):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition): (WebCore::RenderFlow::paintOutlineForLine):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::computeScrollDimensions): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::RenderLayer::absoluteBoundingBox): (WebCore::Marquee::marqueeSpeed): (WebCore::Marquee::computePosition): (WebCore::Marquee::timerFired):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout): (WebCore::RenderTable::paintBoxDecorations):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows): (WebCore::RenderTableSection::lowestPosition): (WebCore::RenderTableSection::rightmostPosition): (WebCore::RenderTableSection::leftmostPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): (WebCore::RenderText::calcMinMaxWidth): (WebCore::RenderText::minXPos): (WebCore::RenderText::width): (WebCore::RenderText::caretMinOffset): (WebCore::RenderText::caretMaxOffset):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::checkLinesForOverflow):
  • rendering/render_form.cpp: (WebCore::RenderLineEdit::setSelectionStart): (WebCore::RenderLineEdit::setSelectionEnd): (WebCore::RenderLineEdit::setSelectionRange): (WebCore::RenderFieldset::layoutLegend): (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderSelect::layout): (WebCore::RenderTextArea::calcMinMaxWidth): (WebCore::RenderSlider::updateFromElement):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): (WebCore::InlineFlowBox::verticallyAlignBoxes): (WebCore::InlineFlowBox::adjustMaxAscentAndDescent): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_line.h: (WebCore::RootInlineBox::selectionHeight):
  • rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::shouldPaint):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): Use min/max instead of kMin/kMax.

Apr 12, 2006:

11:32 PM Changeset in webkit [13858] by darin
  • 97 edits
    18 deletes in trunk/WebCore

Rubber-stamped by Anders.

  • get ready for some more de-KWQ-ing done by the renaming script in two ways

1) stop using forwarding headers for things within WebCore
2) remove a bit of unused stuff

  • loader/CachedImage.h:
  • loader/CachedImage.cpp:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • xml/XSLTProcessor.cpp: Removed unused showAnimations functions and data. We can add back later if we need it. And if we do, we won't use a typedef from KHTMLSettings.
  • ForwardingHeaders/java: Removed.
  • ForwardingHeaders/java/kjavaappletwidget.h: Removed.
  • ForwardingHeaders/khtml_settings.h: Removed.
  • ForwardingHeaders/kio: Removed.
  • ForwardingHeaders/kio/global.h: Removed.
  • ForwardingHeaders/ksslkeygen.h: Removed.
  • ForwardingHeaders/q3ptrlist.h: Removed.
  • ForwardingHeaders/q3valuelist.h: Removed.
  • ForwardingHeaders/qcombobox.h: Removed.
  • ForwardingHeaders/qfontmetrics.h: Removed.
  • ForwardingHeaders/qlineedit.h: Removed.
  • ForwardingHeaders/qmatrix.h: Removed.
  • ForwardingHeaders/qptrlist.h: Removed.
  • ForwardingHeaders/qptrqueue.h: Removed.
  • ForwardingHeaders/qregexp.h: Removed.
  • ForwardingHeaders/qscrollbar.h: Removed.
  • ForwardingHeaders/qtextedit.h: Removed.
  • ForwardingHeaders/qtextstream.h: Removed.
  • ForwardingHeaders/qvaluelist.h: Removed.
  • ForwardingHeaders/qwmatrix.h: Removed.
  • WebCore+SVG/DOMList.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp:
  • css/css_stylesheetimpl.h:
  • css/css_valueimpl.cpp:
  • css/css_valueimpl.h:
  • css/cssstyleselector.cpp:
  • dom/CharacterData.cpp:
  • dom/Document.cpp:
  • dom/Document.h:
  • dom/EventTargetNode.cpp:
  • dom/Node.cpp:
  • editing/BreakBlockquoteCommand.h:
  • editing/htmlediting.cpp:
  • html/FormDataList.h:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLTokenizer.h:
  • html/html_objectimpl.cpp:
  • kcanvas/KCanvasFilters.cpp:
  • kcanvas/KCanvasMatrix.cpp:
  • kcanvas/KCanvasMatrix.h:
  • kcanvas/KCanvasPath.cpp:
  • kcanvas/KCanvasPath.h:
  • kcanvas/KCanvasResources.cpp:
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderPath.h:
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp:
  • kcanvas/device/KRenderingPaintServerPattern.cpp:
  • kcanvas/device/KRenderingPaintServerSolid.cpp:
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • ksvg2/svg/SVGColor.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGFEBlendElement.cpp:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp:
  • ksvg2/svg/SVGFEComponentTransferElement.cpp:
  • ksvg2/svg/SVGFECompositeElement.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp:
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp:
  • ksvg2/svg/SVGFEOffsetElement.cpp:
  • ksvg2/svg/SVGFESpecularLightingElement.cpp:
  • ksvg2/svg/SVGFETileElement.cpp:
  • ksvg2/svg/SVGFETurbulenceElement.cpp:
  • ksvg2/svg/SVGFitToViewBox.cpp:
  • ksvg2/svg/SVGLengthList.cpp:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGNumberList.cpp:
  • ksvg2/svg/SVGPreserveAspectRatio.cpp:
  • ksvg2/svg/SVGSVGElement.cpp:
  • ksvg2/svg/SVGStringList.cpp:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGTransformable.cpp:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/svgpathparser.cpp:
  • kwq/KWQKHTMLSettings.h:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/Decoder.cpp:
  • loader/FormData.h:
  • loader/loader.h:
  • page/Frame.h:
  • page/FramePrivate.h:
  • platform/Font.cpp:
  • platform/SegmentedString.h:
  • platform/mac/FontMac.mm:
  • platform/mac/WebCoreTextField.mm:
  • rendering/RenderBlock.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableSection.cpp:
  • rendering/bidi.h:
  • rendering/break_lines.cpp:
  • rendering/render_applet.cpp:
  • rendering/render_form.cpp:
  • rendering/render_form.h:
  • rendering/render_frames.cpp:
  • rendering/render_style.h:
  • xml/xmlhttprequest.cpp: Updated includes.
  • WebCore.xcodeproj/project.pbxproj: Resorted a couple things.
10:43 PM Changeset in webkit [13857] by darin
  • 1 edit in trunk/WebKitTools/Scripts/do-webcore-rename

Plans for another round of renaming (eliminating KWQ).

8:19 PM Changeset in webkit [13856] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Fixes the build.

7:00 PM Changeset in webkit [13855] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison


Layout test for the changes made to VisiblePosition::init in r13825.


  • editing/selection/unrendered-space.html
  • editing/selection/unrendered-space-expected.png
  • editing/selection/unrendered-space-expected.checksum
  • editing/selection/unrendered-space-expected.txt
6:50 PM Changeset in webkit [13854] by adele
  • 24 edits
    2 adds in trunk

LayoutTests:

Test for setSelectionRange bug in text fields.

  • fast/forms/input-delete-expected.txt: Added.
  • fast/forms/input-delete.html: Added.

WebCore:

Reviewed by Darin and Tim O.

WebCore part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8061
REGRESSION: New text fields need to send callbacks used by autocomplete

Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8156
FrameMac::submitForm is busted after Vector changes

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _rectOnScreen]): Use boundingBox method so this no longer relies on an NSTextField. The old code is no longer needed because this method was used by autocomplete, and that was not enabled for password or search fields. (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): New implementation that uses setValue and setSelectionRange instead of NSTextField specific code. (-[DOMHTMLInputElement _selectedRange]): Creates range by calling selectionStart and selectionEnd on the input element. (-[DOMHTMLInputElement _setAutofilled:]): Provides a way for the autofill code to set a flag on the input element so it knows when its value is set by autofill. This is how we change the background color.
  • bindings/objc/DOMPrivate.h: Removed _displayedValue, _setDisplayedValue, _setBackgroundColor since these are no longer needed for the new text field implementation, and aren't used for remaining NSView-style password and search fields. Added _setAutofilled method.
  • bridge/mac/FrameMac.h: Added virtual clearRecordedFormValues and recordFormValue. These were moved into Frame.cpp recently, which broke how Safari asked to add form values to the keychain.
  • bridge/mac/FrameMac.mm: (WebCore::createNSDictionary): Added. Converts a hashmap to an NSDictionary for m_formValuesAboutToBeSubmitted. This is needed to fix the submit form bug. (WebCore::selectorForKeyEvent): Added. This helper function converts key events into selectors that the autocomplete code needs to know about. (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::submitForm): Convert saved form and formValues into DOMElement and NSMutableDictionary. (WebCore::FrameMac::textFieldDidBeginEditing): Added so the input element can send this notification over the bridge. (WebCore::FrameMac::textFieldDidEndEditing): ditto. (WebCore::FrameMac::textDidChangeInTextField): ditto. (WebCore::FrameMac::doTextFieldCommandFromEvent): ditto. Also calls selectorForKeyEvent. (WebCore::FrameMac::textWillBeDeletedInTextField): ditto.
  • page/Frame.cpp: (WebCore::Frame::textFieldDidBeginEditing): ditto. (WebCore::Frame::textFieldDidEndEditing): ditto. (WebCore::Frame::textDidChangeInTextField): ditto. (WebCore::Frame::doTextFieldCommandFromEvent): ditto. (WebCore::Frame::textWillBeDeletedInTextField): ditto.
  • page/Frame.h: ditto.
  • platform/PlatformString.h: (WebCore::String::replace): Added to use an existing version of StringImpl::replace.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): Setting the selection here should close the typing command. (WebCore::RenderTextField::subtreeHasChanged): Calls textDidChangeInTextField.
  • dom/Document.cpp: (WebCore::Document::setFocusNode): Calls dispatchFocusEvent and dispatchBlurEvent instead of directly dispatching the events. This gives the node a chance to do other work before dispatching the event.
  • dom/EventTargetNode.cpp:
(WebCore
EventTargetNode::dispatchFocusEvent): Added.
(WebCore
EventTargetNode::dispatchBlurEvent): Added.
  • dom/EventTargetNode.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): initializes m_autofilled. (WebCore::HTMLInputElement::dispatchFocusEvent): Calls textFieldDidBeginEditing and then calls up to the base class (WebCore::HTMLInputElement::dispatchBlurEvent): Calls textFieldDidEndEditing and then calls up to the base class (WebCore::HTMLInputElement::defaultEventHandler): For keypress events, calls doTextFieldCommandFromEvent so the form delegate will have a chance to say whether or not it is going to handle the event.

(WebCore::HTMLInputElement::isKeyboardFocusable): Uses isNonWidgetTextField instead of checking the inputType.

(WebCore::HTMLInputElement::isMouseFocusable): ditto.
(WebCore::HTMLInputElement::focus): ditto.
(WebCore::HTMLInputElement::constrainValue): Uses isTextField instead of checking inputType.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): ditto.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTextField): Added. Checks for TEXT, PASSWORD, and SEARCH (WebCore::HTMLInputElement::isNonWidgetTextField): Added. Checks for all converted controls. (WebCore::HTMLInputElement::autofilled): Added. (WebCore::HTMLInputElement::setAutofilled): Added.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Uses isNonWidgetTextField instead of checking the inputType.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): If the deletion is occuring in a text field, call textWillBeDeletedInTextField so the frame can call across the bridge to notify the form delegate.
  • css/css_base.cpp: (WebCore::CSSSelector::extractPseudoType): Added autofill string for "-khtml-autofill".
  • css/css_base.h: (WebCore::CSSSelector::): Added PseudoAutofill to enum.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added case for PseudoAutofill that checks the input element's autofilled flag. (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
  • css/html4.css: Added background-color and background-image for input:-khtml-autofill style. Changed -webkit-focus-ring-color to -khtml-focus-ring-color for consistency.
  • css/CSSValueKeywords.in: ditto.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto. (WebCore::CSSParser::parseShadow): ditto.
6:31 PM Changeset in webkit [13853] by justing
  • 110 edits in trunk

LayoutTests:

Reviewed by hyatt



  • css1/basic/class_as_selector-expected.txt:
  • css1/basic/containment-expected.txt:
  • css1/basic/contextual_selectors-expected.txt:
  • css1/basic/id_as_selector-expected.txt:
  • css1/box_properties/border_bottom-expected.txt:
  • css1/box_properties/border_left-expected.txt:
  • css1/box_properties/border_right_inline-expected.txt:
  • css1/box_properties/border_top-expected.txt:
  • css1/box_properties/clear_float-expected.txt:
  • css1/box_properties/margin-expected.txt:
  • css1/box_properties/margin_bottom-expected.txt:
  • css1/box_properties/margin_left-expected.txt:
  • css1/box_properties/margin_right-expected.txt:
  • css1/box_properties/margin_top-expected.txt:
  • css1/box_properties/padding_left-expected.txt:
  • css1/box_properties/padding_right-expected.txt:
  • css1/cascade/cascade_order-expected.txt:
  • css1/classification/display-expected.txt:
  • css1/classification/list_style-expected.txt:
  • css1/classification/list_style_image-expected.txt:
  • css1/classification/list_style_position-expected.txt:
  • css1/classification/list_style_type-expected.txt:
  • css1/conformance/forward_compatible_parsing-expected.txt:
  • css1/pseudo/anchor-expected.txt:
  • css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
  • css2.1/t0505-c16-descendant-01-e-expected.txt:
  • css2.1/t050803-c14-classes-00-e-expected.txt:
  • css2.1/t0509-c15-ids-01-e-expected.txt:
  • css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • css2.1/t0805-c5519-brdr-r-02-e-expected.txt:
  • css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • css2.1/t0805-c5521-brdr-l-02-e-expected.txt:
  • css2.1/t1205-c561-list-displ-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-00-b-expected.txt:
  • css2.1/t1205-c563-list-type-01-b-expected.txt:
  • css2.1/t1205-c564-list-img-00-b-g-expected.txt:
  • css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
  • css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
  • editing/deleting/delete-listitem-002-expected.txt:
  • editing/execCommand/insertHTML-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-line-002-expected.txt:
  • editing/selection/select-all-iframe-expected.txt:
  • editing/selection/selectNode-expected.txt:
  • editing/selection/selectNodeContents-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-before-expected.txt:
  • fast/block/float/014-expected.txt:
  • fast/css-generated-content/009-expected.txt:
  • fast/css/001-expected.txt:
  • fast/css/001-expected.png:
  • fast/css/001-expected.checksum:
  • fast/css/continuationCrash-expected.txt:
  • fast/css/list-outline-expected.txt:
  • fast/doctypes/001-expected.txt:
  • fast/doctypes/002-expected.txt:
  • fast/doctypes/003-expected.txt:
  • fast/doctypes/004-expected.txt:
  • fast/dom/window-onFocus-expected.txt:
  • fast/forms/form-hides-table-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/lists/001-expected.checksum:
  • fast/lists/001-expected.png:
  • fast/lists/001-expected.txt:
  • fast/lists/002-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/lists/004-expected.txt:
  • fast/lists/005-expected.txt:
  • fast/lists/006-expected.txt:
  • fast/lists/007-expected.txt:
  • fast/lists/008-expected.txt:
  • fast/lists/009-expected.txt:
  • fast/lists/drag-into-marker-expected.txt:
  • fast/lists/li-br-expected.txt:
  • fast/lists/ol-display-types-expected.txt:
  • fast/lists/olstart-expected.txt:
  • fast/lists/scrolled-marker-paint-expected.txt:
  • fast/overflow/overflow-rtl-expected.txt:
  • fast/parser/entities-in-xhtml-expected.txt:
  • fast/selectors/001-expected.txt:
  • fast/selectors/013-expected.txt:
  • fast/selectors/015-expected.txt:
  • fast/selectors/166-expected.txt:
  • fast/table/018-expected.txt:
  • fast/table/form-with-table-style-expected.txt:
  • fast/text/whitespace/tab-character-basics-expected.txt:
  • fast/tokenizer/004-expected.txt:
  • tables/mozilla/bugs/bug23235-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.txt:
  • tables/mozilla/bugs/bug3191-expected.txt:
  • tables/mozilla/bugs/bug32205-2-expected.txt:
  • tables/mozilla/marvin/backgr_index-expected.txt:
  • tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • tables/mozilla/marvin/x_table-expected.txt:
  • tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • tables/mozilla/other/wa_table_tr_align-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:

WebCore:

Reviewed by hyatt



  • manual-tests/list-marker-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Call positionListMarker() after laying out the children. (WebCore::RenderBlock::calcInlineMinMaxWidth): Call calcWidth() on the child if we are going to use its marginLeft() or marginRight(), which is if they are given as a percentage or if the child is a list marker.
  • rendering/RenderBlock.h: (WebCore::RenderBlock::positionListMarker): Added this virtual function which RenderListItem implements and which is called from layoutBlock().
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects): Avoid adding focus rings around outside list markers. Previously it did not matter since the markers had zero width.
  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Outside list markers should not contribute to the line width, even now that they have width.
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Skip outside list markers.
  • rendering/render_list.cpp: (WebCore::RenderListItem::positionListMarker): Added. (WebCore::RenderListMarker::paint): Removed code that was used to right-align outside text markers, since that is achieved by margins now. (WebCore::RenderListMarker::calcMinMaxWidth): Changed the marker height to be the font height. Made the width of outside list markers non-zero and equal to the width of inside markers. Changed the width to include only the marker and not any padding. Increased the width of bullets by 2 to contain spillage due to antialiasing. (WebCore::RenderListMarker::calcWidth): Calculate horizontal margins. Padding that was previously included in the width is now part of the margins. (WebCore::RenderListMarker::getRelativeMarkerRect): Adjusted for the changes to width and margins.
  • rendering/render_list.h:
5:36 PM Changeset in webkit [13852] by darin
  • 3 edits
    14 moves in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved some more files out of KWQ to more-permanent homes
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • kwq/BlockExceptions.h: Removed.
  • kwq/BlockExceptions.mm: Removed.
  • kwq/ClipboardMac.h: Removed.
  • kwq/ClipboardMac.mm: Removed.
  • kwq/DeprecatedPtrList.h: Removed.
  • kwq/DeprecatedPtrListImpl.cpp: Removed.
  • kwq/DeprecatedPtrListImpl.h: Removed.
  • kwq/DeprecatedValueList.h: Removed.
  • kwq/DeprecatedValueListImpl.cpp: Removed.
  • kwq/DeprecatedValueListImpl.h: Removed.
  • kwq/WebCoreTextArea.h: Removed.
  • kwq/WebCoreTextArea.mm: Removed.
  • kwq/WebCoreTextField.h: Removed.
  • kwq/WebCoreTextField.mm: Removed.
  • platform/DeprecatedPtrList.h: Added.
  • platform/DeprecatedPtrListImpl.cpp: Added.
  • platform/DeprecatedPtrListImpl.h: Added.
  • platform/DeprecatedValueList.h: Added.
  • platform/DeprecatedValueListImpl.cpp: Added.
  • platform/DeprecatedValueListImpl.h: Added.
  • platform/mac/BlockExceptions.h: Added.
  • platform/mac/BlockExceptions.mm: Added.
  • platform/mac/ClipboardMac.h: Added.
  • platform/mac/ClipboardMac.mm: Added.
  • platform/mac/WebCoreTextArea.h: Added.
  • platform/mac/WebCoreTextArea.mm: Added.
  • platform/mac/WebCoreTextField.h: Added.
  • platform/mac/WebCoreTextField.mm: Added.
5:21 PM Changeset in webkit [13851] by harrison
  • 10 edits
    4 adds in trunk/LayoutTests

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

  • editing/editing.js: Add sentence navigation/selection.


  • editing/selection/extend-by-sentence-001-expected.txt: Added.
  • editing/selection/extend-by-sentence-001.html: Added. Test for both <rdar://problem/4386640> and <rdar://problem/4414575>.


  • fast/dom/inner-text-001-expected.txt: Added.
  • fast/dom/inner-text-001.html: Added. Tests innerText on a variety of elements.


  • fast/dom/HTMLObjectElement/form/test1-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/forms/button-in-forms-collection-expected.txt:
  • fast/forms/focus-control-to-page-expected.txt:
  • fast/forms/focus-expected.txt:
  • fast/forms/textarea-hard-linewrap-expected.txt:
  • fast/forms/textarea-setvalue-submit-expected.txt:
  • fast/loader/loadInProgress-expected.txt: Updated for innerText changes that emit newlines for more kinds of blocks.
5:18 PM Changeset in webkit [13850] by harrison
  • 4 edits in trunk/WebKit

Reviewed by Darin.


<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app


(see related changes in WebCore)


Tests added:

  • editing/selection/extend-by-sentence-001.html: Added.
  • fast/dom/inner-text-001.html: Added.
  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray selectSentence:]):
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h: Add sentence navigation and selection.
5:14 PM Changeset in webkit [13849] by harrison
  • 10 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4386640> AX: AXPreviousSentenceStartTextMarkerForTextMarker does not respect paragraph boundary
<rdar://problem/4414575> AX: Dictionary popup cannot find some words on Dictionary.app

AXPreviousSentenceStartTextMarkerForTextMarker failed to stop at the beginning a block because
SimplifiedBackwardsTextIterator::handleNonTextNode() emitted a space when exiting the block.
Fixed by emitting a newline instead.


Word boundary failed to stop at the beginning of a block because no character at all was emitted
when leaving the block, because the exitNode was checking specific html tags to decide whether the
node is block, but the node was xml. Fixed by using the node's renderer, if present.


(see related changes in WebKit)


Tests added:

  • editing/selection/extend-by-sentence-001.html: Added.
  • fast/dom/inner-text-001.html: Added.


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Add sentence navigation/selection.


  • editing/Selection.cpp: (WebCore::Selection::validate): Add sentence navigation/selection.
  • editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): (WebCore::SelectionController::modifyMovingRightForward): (WebCore::SelectionController::modifyExtendingLeftBackward): (WebCore::SelectionController::modifyMovingLeftBackward): (WebCore::SelectionController::modify): Add sentence navigation/selection.
  • editing/TextGranularity.h: (WebCore::): Add SentenceGranularity and SentenceBoundary.
  • editing/TextIterator.cpp: (WebCore::isTableCell): (WebCore::shouldEmitTabBeforeNode): (WebCore::shouldEmitNewlineForNode): (WebCore::shouldEmitNewlinesBeforeAndAfterNode): (WebCore::shouldEmitExtraNewlineForNode): New utility functions that prefer renderers over html tag names.

(WebCore::TextIterator::handleNonTextNode):
(WebCore::TextIterator::exitNode):
(WebCore::SimplifiedBackwardsTextIterator::advance):
Use new utility functions.


(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
Use new utility functions. Also emit linefeed instead of space,
so sentence parsing works across block boundaries.


(WebCore::SimplifiedBackwardsTextIterator::exitNode):
Use new utility functions.

(WebCore::SimplifiedBackwardsTextIterator::emitNewline):
Renamed from emitNewlineForBROrText because it is not always for BR or text.


  • editing/TextIterator.h: Renamed emitNewlineForBROrText to emitNewline.


  • editing/visible_units.cpp:
  • editing/visible_units.h: (WebCore::previousBoundary): (WebCore::nextBoundary): (WebCore::previousSentencePosition): (WebCore::nextSentencePosition): Add sentence navigation/selection.
4:54 PM Changeset in webkit [13848] by darin
  • 11 edits
    4 copies
    1 move
    1 delete in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved Decoder and FormData classes into loader directory (Decoder, because it's part of the loading process.

FormData, because it's used as a parameter when specifying
what to load. Arguably either could be in page instead.)

  • moved Length.h from css to renderer, cause that's where Hyatt says it belongs
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml: Removed.
  • loader/Decoder.cpp: Added.
  • loader/Decoder.h: Added.
  • loader/FormData.cpp: Added.
  • loader/FormData.h: Added.
  • css/Length.h: Removed.
  • rendering/Length.h: Added.
  • bridge/mac/WebCoreEncodings.mm:
  • dom/Document.h:
  • kwq/KWQFormData.mm:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXSLStyleSheet.cpp:
  • page/ResourceRequest.h:
  • platform/TransferJobInternal.h:
  • xml/xmlhttprequest.cpp: Updated includes.
4:49 PM Changeset in webkit [13847] by darin
  • 2 edits in trunk/WebKitTools

Rubber-stamped by Darin.

  • BuildSlaveSupport/build-launcher-dmg: Use the -srcfolder option to 'hdiutil create'. This creates the initial disk image based on the size of the source folder, and copies the contents to the new disk image. The file extension on the temporary uncompressed disk image has also been altered from ".uncompressed" to ".uncompressed.dmg" as hdiutil on 10.4.6 Intel fails when the extension is not ".dmg".
4:13 PM Changeset in webkit [13846] by justing
  • 2 edits
    1 add in trunk/WebCore

Reviewed by darin

  • manual-tests/inline-outline-repaint.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Add the maximal outline width to the inlines' repaint rect.
4:01 PM Changeset in webkit [13845] by hyatt
  • 2 edits in trunk/LayoutTests/http/tests/misc

Fix broken test results.

2:54 PM Changeset in webkit [13844] by justing
  • 1 edit in trunk/WebCore/editing/JSEditor.cpp

Removed unnecessary check for an empty string.

2:51 PM Changeset in webkit [13843] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

  • editing/deleting/merge-unrendered-space.html:
  • editing/execCommand/insertHorizontalRule-expected.checksum: Added.
  • editing/execCommand/insertHorizontalRule-expected.png: Added.
  • editing/execCommand/insertHorizontalRule-expected.txt: Added.
  • editing/execCommand/insertHorizontalRule.html: Added.

WebCore:

Reviewed by darin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8335>
Implement execCommand(InsertHorizontalRule)

  • editing/JSEditor.cpp:
2:50 PM Changeset in webkit [13842] by eseidel
  • 1 copy in branches/treecode-stable

Make a "stable" copy of treecode, which ggaren and I can drive towards TOT, independent of mjs' re-working.

2:43 PM Changeset in webkit [13841] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Part of <rdar://problem/4482530>

  • WebView/WebView.m: (-[WebView _focusedFrame]): Fixed up the logic here to take into account immediate subviews of WebView, which are not actually in a WebFrameView (they are peers to the main frame's WebFrameView).
1:21 PM Changeset in webkit [13840] by hyatt
  • 7 edits in trunk/LayoutTests/fast

Land updated results for overflow changes.

1:02 PM Changeset in webkit [13839] by darin
  • 3 edits
    4 copies
    2 deletes in trunk/WebCore

Rubber-stamped by Hyatt.

  • moved xsl files into xml directory, removed xbl files (for now)
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for new locations.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/xbl: Removed.
  • khtml/xsl: Removed.
  • xml/XSLStyleSheet.cpp: Added.
  • xml/XSLStyleSheet.h: Added.
  • xml/XSLTProcessor.cpp: Added.
  • xml/XSLTProcessor.h: Added.
12:52 PM Changeset in webkit [13838] by hyatt
  • 4 edits in trunk/WebCore

Fix for 5283, make sure overflow doesn't paint on top of positioned elements.

Reviewed by beth

  • kwq/RenderTreeAsText.cpp: (writeLayers):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::addChild): (WebCore::RenderLayer::removeChild): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::dirtyOverflowList): (WebCore::RenderLayer::updateOverflowList): (WebCore::RenderLayer::collectLayers): (WebCore::RenderLayer::shouldBeOverflowOnly): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h: (WebCore::RenderLayer::isOverflowOnly): (WebCore::RenderLayer::overflowList):
11:31 AM Changeset in webkit [13837] by eseidel
  • 2 edits in trunk/WebKitTools

2006-04-12 Eric Seidel <​eseidel@apple.com>

Reviewed by Tim H.

  • Scripts/update-webkit: Make this return non-zero when svn fails.
9:32 AM Changeset in webkit [13836] by darin
  • 2 edits in trunk/WebCore
  • WebCore.xcodeproj/project.pbxproj: Turn SVG support back on. I accidentally checked in this file with SVG off last night.
9:22 AM Changeset in webkit [13835] by darin
  • 4 edits in trunk/WebCore
  • try to fix Windows build
  • platform/TransferJobInternal.h: Declare HANDLE.
  • platform/image-decoders/gif/GIFImageReader.h: Include GIFImageDecoder.h.
  • rendering/RenderThemeWin.h: Declare HANDLE and HMODULE.
9:08 AM Changeset in webkit [13834] by darin
  • 3 edits in trunk/WebCore
  • another attempt to get things building
  • bindings/js/kjs_proxy.cpp: Add "kjs_events.h" include, needed when not building SVG (so for Windows too).
  • editing/TextIterator.h: Add back include of Vector.h.
Note: See TracTimeline for information about the timeline view.