Timeline



May 27, 2006:

11:33 AM Changeset in webkit [14619] by andersca
  • 2 edits in trunk/WebCore

2006-05-27 Anders Carlsson <​acarlsson@apple.com>

  • bindings/js/JSHTMLElementWrapperFactory.cpp: Correct include file names.

May 26, 2006:

7:23 PM Changeset in webkit [14618] by justing
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

Added, test for the crash by focusing an editable html element and then
inserting a tab

  • editing/selection/editable-html-element-expected.checksum: Added.
  • editing/selection/editable-html-element-expected.png: Added.
  • editing/selection/editable-html-element-expected.txt: Added.
  • editing/selection/editable-html-element.html: Added. Fixed:
  • editing/selection/focus_editable_html-expected.checksum:
  • editing/selection/focus_editable_html-expected.png:
  • editing/selection/focus_editable_html-expected.txt:

WebCore:

Reviewed by levi


<rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message

  • dom/Position.cpp: (WebCore::Position::inRenderedContent): Removed a candidate at [html, 0].
  • editing/CreateLinkCommand.cpp: (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Ditto.
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto.
  • editing/Selection.cpp: (WebCore::Selection::validate): If visible positions can't be created from the endpoints, then create a null selection. Not doing this was making editing code think there was a valid, editable selection even though there wasn't.
  • editing/UnlinkCommand.cpp: (WebCore::UnlinkCommand::doApply): Early return.
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary. It looks like a non-editable/editable boundary since rootEditableElement stops at the body even if the html element is editable.
3:17 PM Changeset in webkit [14617] by adele
  • 2 edits in trunk/WebCore

Reviewed by Justin.

Fixes a mistake in my last checkin. Uses maxDeepOffset to get the end position for
the textarea's inner div.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::textWithHardLineBreaks):
2:13 PM Changeset in webkit [14616] by adele
  • 8 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Added test for new textarea implementation. Tests
wrap attributes and form submission.

  • fast/forms/textarea-appearance-wrap-expected.txt: Added.
  • fast/forms/textarea-appearance-wrap.html: Added.

WebCore:

Reviewed by Hyatt.

Added support for wrap=hard for new textarea implementation.

Tests: fast/forms/textarea-appearance-wrap.html

  • dom/Range.h: Added version of toString that will convert BRs to newlines.
  • dom/Range.cpp: (WebCore::Range::toString):
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): When in plain-text mode, and a white-space mode that doesn't collapse whitespace, create a fragment with one text node.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Subtract scroll offset so the absolute position for the containing block is correct. (WebCore::nextLinePosition): ditto.
  • rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates): If the position is equal to the left edge of the box, make the affinity downstream so the position doesn't jump back to the previous line. (WebCore::RenderText::atLineWrap): The logic was reversed here in a recent change. If the box is not at a line break, then its at a line wrap. (WebCore::RenderText::caretRect): Only go to the next text box if its at a line wrap and the affinity is also downstream. If its upstream, then the correct box is on the current line. (WebCore::RenderText::inlineBox): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::updateFromElement): multi line controls don't need to check valueMatchesRenderer before updating the renderer. For textareas, the renderer should always try to update. This matches our old textarea behavior. (WebCore::RenderTextField::text): Pass true to textContent so it converts BRs to newlines. (WebCore::RenderTextField::textWithHardLineBreaks): Iterate through the RootLineBoxes to find the soft wraps and replace them with newlines.
1:30 PM Changeset in webkit [14615] by andersca
  • 5 edits
    2 adds in trunk

WebCore:

2006-05-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET


  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::handleLocalEvents): Invoke capturing event listeners for the AT_TARGET phase. This violates the DOM spec but it's what Mozilla does.

LayoutTests:

2006-05-26 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9127
Invoke capturing event listeners when AT_TARGET

  • dom/html/level2/events/dispatchEvent09-expected.txt:
  • dom/xhtml/level2/events/dispatchEvent09-expected.txt: These fail now.


  • fast/dom/capturing-event-listeners-expected.txt: Added.
  • fast/dom/capturing-event-listeners.html: Added.


12:34 PM Changeset in webkit [14614] by harrison
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel

  • WebView/WebHTMLView.m: (-[WebHTMLView _increaseSelectionListLevel]):
  • Now returns DOMNode*

(-[WebHTMLView _increaseSelectionListLevelOrdered]):
(-[WebHTMLView _increaseSelectionListLevelUnordered]):

  • Added. These also return DOMNode*
  • WebView/WebHTMLViewPrivate.h:
  • Updated as above
12:31 PM Changeset in webkit [14613] by harrison
  • 7 edits
    2 moves in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4514529> Add a list type parameter and a return value to _increaseSelectionListLevel


  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • Renamed ModifySelectionListLevelCommand .cpp and .h to ModifySelectionListLevel .cpp and .h


  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canIncreaseSelectionListLevel]): (-[WebCoreFrameBridge canDecreaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge decreaseSelectionListLevel]):
  • Call functions in IncreaseSelectionListLevelCommand or DecreaseSelectionListLevelCommand instead of ModifySelectionListLevelCommand.


(-[WebCoreFrameBridge increaseSelectionListLevelOrdered]):
(-[WebCoreFrameBridge increaseSelectionListLevelUnordered]):

  • Added.


  • editing/ModifySelectionListLevel.cpp: Added.
  • Renamed from ModifySelectionListLevelCommand.cpp
  • Made ModifySelectionListLevelCommand class into a useful base class for new classes IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand.


(WebCore::ModifySelectionListLevelCommand::ModifySelectionListLevelCommand):
(WebCore::getStartEndListChildren):
(WebCore::ModifySelectionListLevelCommand::insertSiblingNodeRangeBefore):
(WebCore::ModifySelectionListLevelCommand::appendSiblingNodeRange):

  • ModifySelectionListLevelCommand is base class for IncreaseSelectionListLevelCommand and DecreaseSelectionListLevelCommand


(WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand):
(WebCore::IncreaseSelectionListLevelCommand::listElement):
(WebCore::canIncreaseListLevel):
(WebCore::IncreaseSelectionListLevelCommand::doApply):
(WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
(WebCore::increaseSelectionListLevelWithType):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevel):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelOrdered):
(WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelUnordered):

  • Now a subclass of ModifySelectionListLevelCommand
  • Added Ordered and Unordered increaser functions
  • Increaser functions return the list element that the items were moved into


(WebCore::DecreaseSelectionListLevelCommand::DecreaseSelectionListLevelCommand):
(WebCore::canDecreaseListLevel):
(WebCore::DecreaseSelectionListLevelCommand::doApply):
(WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
(WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel):

  • No functional changes other than to become a subclass of ModifySelectionListLevelCommand
  • editing/ModifySelectionListLevel.h: Added. (WebCore::):
    • Renamed from ModifySelectionListLevelCommand.cpp


  • editing/ModifySelectionListLevelCommand.cpp: Removed.
  • Renamed to ModifySelectionListLevel.cpp


  • editing/ModifySelectionListLevelCommand.h: Removed.
  • Renamed to ModifySelectionListLevel.h
  • editing/htmlediting.cpp: (WebCore::createOrderedListElement): (WebCore::createUnorderedListElement):
  • editing/htmlediting.h:
12:26 PM Changeset in webkit [14612] by brmorris
  • 1 edit in S60/trunk/build.bat

S60Webkit:

2006-05-25 Bradley <​bradley.morrison@nokia.com>

Reviewed by dacarson.

build.bat now deletes outdated headers.
(fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9126)

11:58 AM Changeset in webkit [14611] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8347>
REGRESSION: Flash movie audible but not visible until window is resized

  • Plugins/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView dataSourceUpdated:]): Layout if needed here. Maciej recently removed the "LayoutAcceptable" frame state, which used to cause plugin document views to lay out immediately upon receiving data. This call to -layout has the same effect.
11:11 AM Changeset in webkit [14610] by sfalken
  • 4 edits in trunk/WebCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Build fixes/tweaks

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
  • ksvg2/scripts/make_names.pl:
1:12 AM Changeset in webkit [14609] by sfalken
  • 2 edits in trunk/JavaScriptCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

1:10 AM Changeset in webkit [14608] by sfalken
  • 2 edits in trunk/WebKitWin

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

  • WebKitWin.vcproj/WebKitWin/WebKitWin.vcproj:
1:07 AM Changeset in webkit [14607] by sfalken
  • 3 edits in trunk/WebKitTools

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Build fixes/tweaks

  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.vcproj:

May 25, 2006:

5:36 PM Changeset in webkit [14606] by sfalken
  • 3 edits in trunk/WebCore

2006-05-26 Steve Falkenburg <​sfalken@apple.com>

Reviewed by adele.

Fix build

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
5:28 PM Changeset in webkit [14605] by hyatt
  • 2 edits in trunk/WebCore

Set the fixed pitch hardcoded default to 13 on windows.

5:24 PM Changeset in webkit [14604] by hyatt
  • 1 edit in trunk/WebKitTools/Spinneret/Spinneret/Spinneret.cpp

Make sure Spinneret inits and shuts down COM like a good boy.

5:19 PM Changeset in webkit [14603] by aliceli1
  • 2 adds in trunk/LayoutTests/fast/forms
5:15 PM Changeset in webkit [14602] by aliceli1
  • 5 edits in trunk/WebCore

Reviewed by Adele.

  • bindings/js/kjs_html.cpp: added bindings (KJS::HTMLElementFunction::callAsFunction): added case to handle namedItem for select elements
  • bindings/js/kjs_html.h: added enum value for bindings (KJS::JSHTMLElement::):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): implemented namedItem method
  • html/HTMLSelectElement.h: added prototype for namedItem method
4:45 PM Changeset in webkit [14601] by hyatt
  • 2 edits in trunk/WebCore

Add soft hyphen support for Win32.

4:18 PM Changeset in webkit [14600] by hyatt
  • 2 edits in trunk/WebCore

Implement containsCharacters method on Win32 for determining if a fallback font has the necessary glyphs to be used.

3:42 PM Changeset in webkit [14599] by hyatt
  • 7 edits
    1 add
    1 delete in trunk/WebCore

Remove the logical scale factor from Cairo Win32 fonts.

3:17 PM Changeset in webkit [14598] by eseidel
  • 5 edits
    3 adds in trunk

2006-05-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

Test: fast/table/border-collapsing/border-collapsing-head-foot.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::sectionAbove): Added. (WebCore::RenderTable::sectionBelow): Added. (WebCore::RenderTable::cellAbove): Changed to call sectionAbove. (WebCore::RenderTable::cellBelow): Changed to call sectionBelow.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedTopBorder): Changed to call sectionAbove. (WebCore::RenderTableCell::collapsedBottomBorder): Changed to call sectionBelow.
3:11 PM Changeset in webkit [14597] by eseidel
  • 39 edits in trunk

2006-05-25 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by hyatt. Landed by eseidel.

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Assign the row renderer to the grid row. (WebCore::RenderTableSection::calcRowHeight): Fix off-by-one index bug and add vertical spacing only for grid rows that have a renderer. (WebCore::RenderTableSection::recalcCells): Assign row renderers to grid rows.
3:05 PM Changeset in webkit [14596] by eseidel
  • 1 delete in trunk/WebCore/WebCore

Remove bogus directory

3:00 PM Changeset in webkit [14595] by eseidel
  • 9 edits in trunk/WebCore

2006-05-19 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5978
WebKIt+SVG should use SVGDocumentImpl for image/svg+xml

Make sure SVGDocument is created for standalone svg
documents.

  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::instance): (SVGDOMImplementation::createDocument):
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::SVGDocument): (WebCore::SVGDocument::~SVGDocument):
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • page/Frame.cpp: (WebCore::Frame::begin):
2:55 PM Changeset in webkit [14594] by eseidel
  • 5 edits
    6 adds
    2 deletes in trunk/WebCore

2006-05-17 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5889
HTMLNames.* should be generated using make_names.pl

Use a patched make_names.pl to autogenerate HTMLNames.*

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLNames.cpp: Removed.
  • html/HTMLNames.h: Removed.
  • html/HTMLTagNames.in: Added.
  • html/HTMLAttributeNames.in: Added.
  • ksvg2/scripts/make_names.pl:
2:41 PM Changeset in webkit [14593] by eseidel
  • 24 edits
    5 adds in trunk

2006-05-23 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

Add "HasIndexGetter" support to bindings autogen system.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9057

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLInputElementBase.cpp:
  • bindings/js/kjs_css.cpp: (KJS::toJS):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodeMap::getOwnPropertySlot):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSValueList.idl: Added.
1:15 PM Changeset in webkit [14592] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix

12:10 PM Changeset in webkit [14591] by thatcher
  • 3 copies in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:09 PM Changeset in webkit [14590] by thatcher
  • 1 delete in tags/WebKit-521.11.1/WebKit

Bad tag.

12:09 PM Changeset in webkit [14589] by thatcher
  • 1 copy in tags/WebKit-521.11.1/WebKit

Tag for WebKit 521.11.1 (part 2 of 2.)

12:07 PM Changeset in webkit [14588] by thatcher
  • 1 add in tags/WebKit-521.11.1

Tag for WebKit 521.11.1 (part 1 of 2.)

12:06 PM Changeset in webkit [14587] by thatcher
  • 2 edits in /

Versioning

12:00 PM Changeset in webkit [14586] by thatcher
  • 27 edits
    1 add in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4559808> WebKit fails to compile for ppc64
<rdar://problem/4522085> 64-bit: WebKit uses FSSpec which is not available in 64-bit
Gets WebKit building under 64-bit. Rename WebNSInt and WebNSUInt to WebNSInteger and WebNSUInteger.
Start using WebNSInteger where we need to match AppKit API usage of NSInteger.

HIWebView and a couple of helper functions are disabled until they can be moved off of QuickDraw.
<rdar://problem/4561772> HIWebView needs to be reworked to not use QuickDraw, needed for 64-bit

  • Carbon/CarbonUtils.m: disabled this file in 64-bit <rdar://problem/4561772>
  • Carbon/CarbonWindowAdapter.m: (-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]):
  • Carbon/CarbonWindowFrame.m: (+[CarbonWindowFrame frameRectForContentRect:styleMask:]): (+[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (+[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]): (-[CarbonWindowFrame frameRectForContentRect:styleMask:]): (-[CarbonWindowFrame contentRectForFrameRect:styleMask:]): (-[CarbonWindowFrame minFrameSizeForMinContentSize:styleMask:]):
  • Carbon/HIViewAdapter.m: disabled this file in 64-bit <rdar://problem/4561772>
  • Carbon/HIWebView.m: disabled this file in 64-bit <rdar://problem/4561772> (HIWebViewEventHandler):
  • DefaultDelegates/WebDefaultResourceLoadDelegate.m: (-[WebDefaultResourceLoadDelegate webView:resource:didReceiveContentLength:fromDataSource:]):
  • History/WebBackForwardList.m: (-[WebBackForwardList removeItem:]): (-[WebBackForwardList goToItem:]):
  • Misc/WebDownload.m: (-[WebDownloadInternal download:didReceiveDataOfLength:]):
  • Misc/WebFileDatabase.m: (UniqueFilePathForKey):
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _totalRetainCountForIconURLString:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]):
  • Misc/WebSearchableTextView.m: (-[NSString selectionRect]):
  • Misc/WebTypesInternal.h: Added.
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _destroyStream]): (CarbonPathFromPOSIXPath):
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (TSMEventHandler): (-[WebBaseNetscapePluginView _postURL:target:len:buf:file:notifyData:sendNotification:allowHeaders:]): (-[WebBaseNetscapePluginView _printedPluginBitmap]): (-[NSData _web_locationAfterFirstBlankLine]):
  • Plugins/WebBasePluginPackage.m: (-[WebBasePluginPackage hash]):
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): (functionPointerForTVector):
  • WebInspector/WebInspector.m: (-_updateSystemColors):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSource _didReceiveData:contentLength:forResource:]):
  • WebView/WebFrame.m: (-[WebFrame _sendRemainingDelegateMessagesWithIdentifier:response:length:error:]):
  • WebView/WebHTMLView.m: (-[NSArray drawRect:]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView conversationIdentifier]):
  • WebView/WebResourceLoadDelegate.h:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.h:
  • WebView/WebView.m: (-[WebView _mouseDidMoveOverElement:modifierFlags:]): (-[WebView spellCheckerDocumentTag]):
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
10:57 AM Changeset in webkit [14585] by brmorris
  • 1 edit in S60/trunk/runATF.bat

S60Webkit:

2006-05-25 Bradley <​bradley.morrison@nokia.com>

Reviewed by Franklin.

runATF.bat sets compile environment
(fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9106)

1:08 AM Changeset in webkit [14584] by hyatt
  • 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests

Modify DumpRenderTree so it will be able to spit out expected-win.txt files for win32 layout test results.

12:35 AM Changeset in webkit [14583] by hyatt
  • 2 edits in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree

Fix DumpRenderTree so that it works again.

May 24, 2006:

10:52 PM Changeset in webkit [14582] by hyatt
  • 4 edits in trunk/WebCore

Implement font aliasing of family names for Courier/Courier New,
Arial/Helvetica, and Times/Times New Roman. This behavior matches
WinIE and Firefox.

Reviewed by maciej

Test cases not really possible, since they would have to rely on people
not having the fonts installed (so not having installed Office).

  • platform/FontCache.cpp: (WebCore::alternateFamilyName): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontCache.h:
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeLeftoverAnonymousBoxes):
5:43 PM Changeset in webkit [14581] by bdakin
  • 1 edit
    1 move
    3 adds
    3 deletes in trunk/LayoutTests

Reviewed by Geoff.

This layout test is now correct, so I moved it into the expected
successes directory and generated new results.

  • tables/mozilla/bugs/bug222846-expected.checksum: Added.
  • tables/mozilla/bugs/bug222846-expected.png: Added.
  • tables/mozilla/bugs/bug222846-expected.txt: Added.
  • tables/mozilla/bugs/bug222846.html: Added.
  • tables/mozilla_expected_failures/bugs/bug222846- expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug222846.html: Removed.
5:40 PM Changeset in webkit [14580] by thatcher
  • 8 copies in tags/Safari-521.11

Tag

5:34 PM Changeset in webkit [14579] by thatcher
  • 6 edits in /

Versioning

4:49 PM Changeset in webkit [14578] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi

  • editing/selection/designmode-no-caret-expected.checksum: Added.
  • editing/selection/designmode-no-caret-expected.png: Added.
  • editing/selection/designmode-no-caret-expected.txt: Added.
  • editing/selection/designmode-no-caret.html: Added.

WebCore:

Reviewed by levi


<rdar://problem/4549610> REGRESSION: No initial cursor in Mail reply or Blot document
<rdar://problem/4560698> Mail is very crashy in Leopard9A182, WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int)

  • page/Frame.cpp: (WebCore::Frame::setSelectionFromNone): Find the body and stick a caret in it.
4:41 PM Changeset in webkit [14577] by sullivan
  • 2 edits in trunk/WebKitSite

Reviewed by John Sullivan.

  • quality/lifecycle.html: mentions case of PlatformOnly bugs

and 'other' bug databases.

4:33 PM Changeset in webkit [14576] by hyatt
  • 4 edits in trunk/WebCore/platform

Add support for IMLangFontLink2 to map to a similar font that has missing characters on Win32.

4:18 PM Changeset in webkit [14575] by ggaren
  • 4 edits in trunk/WebCore

Rubber stamped by Anders.


Removed meaningless 'dom::' prefix in IDL files.

  • dom/Range.idl:
  • html/CanvasRenderingContext2D.idl:
  • html/HTMLOptionElement.idl:
4:13 PM Changeset in webkit [14574] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

  • fast/dom/option-properties-expected.txt: Added.
  • fast/dom/option-properties.html: Added.

WebCore:

Reviewed by andersca.



'text' and 'selected' were erroneously marked read-only for option elements.


  • html/HTMLOptionElement.idl:
4:02 PM Changeset in webkit [14573] by brmorris
  • 7 edits in S60/trunk

S60Webkit:

2006-05-25 Mario Borges

Reviewed by bradleym.

  • better support for SISX using ARMV5
  • updated def files
3:57 PM Changeset in webkit [14572] by thatcher
  • 1 copy in tags/WebCore-418.9/WebCore

Tag for WebCore 418.9 (part 2 of 2.)

3:56 PM Changeset in webkit [14571] by thatcher
  • 1 add in tags/WebCore-418.9

Tag for WebCore 418.9 (part 1 of 2.)

3:56 PM Changeset in webkit [14570] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:42 PM Changeset in webkit [14569] by ggaren
  • 19 edits
    6 adds in trunk

JavaScriptCore:

Reviewed by mjs.


  • JSC half of fix for <rdar://problem/4557926> TOT REGRESSSION: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.


I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed <rdar://problem/4561439> about that, and I'm moving on
with my life.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/internal.cpp: (KJS::InterpreterImp::mark):
  • kjs/internal.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::mark):
  • kjs/interpreter.h:

LayoutTests:

Layout tests for DOM object cache and garbage collection,
<rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting
to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716
( KJS::IfNode::execute (KJS::ExecState*) + 312) if you use a PAC file

  • fast/dom/gc-8-expected.txt: Added.
  • fast/dom/gc-8.html: Added.
  • fast/dom/gc-9-expected.txt: Added.
  • fast/dom/gc-9.html: Added.

WebCore:

Reviewed by mjs.

  • WebCore half of fix for <rdar://problem/4557926> TOT REGRESSION: Crash occurs when attempting to view image in slideshow mode at ​http://d.smugmug.com/gallery/581716 ( KJS::IfNode::execute (KJS::ExecState*) + 312)

On alternate threads, DOMObjects remain in the
ScriptInterpreter's cache because they're not collected. So, they
need an opportunity to mark their children.


I'm not particularly happy with this solution because it fails to
resolve many outstanding issues with the DOM object cache. Since none
of those issues is a crasher or a serious compatibility concern,
and since the behavior of other browsers is not much to go on in this
case, I've filed <rdar://problem/4561439> about that, and I'm moving
on with my life.

Also added functionality for testing garbage collection from inside
DumpRenderTree.


Also removed XMLHttpRequest from the DOM object cache because XMLHttpRequest
objects aren't accessed through the DOM.


Also added JS locking around access to some shared data structures in
WebCoreJavaScript, even though it probably doesn't matter in practice.

  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCoreJavaScript.mm: (collect): (+[WebCoreJavaScript objectCount]): (+[WebCoreJavaScript interpreterCount]): (+[WebCoreJavaScript protectedObjectCount]): (+[WebCoreJavaScript garbageCollect]): (+[WebCoreJavaScript garbageCollectOnAlternateThread:]): (+[WebCoreJavaScript shouldPrintExceptions]): (+[WebCoreJavaScript setShouldPrintExceptions:]):

WebKitTools:

Reviewed by mjs.


Added 'GCController' to DRT to support garbage collection layout tests.


GCController.collect() and GCController.collectOnAlternateThread() do
what you would expect. The latter takes a boolean argument sepcifying
whether to wait for garbage collection to finish before continuing to
execute script.

  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/GCController.h: Added.
  • DumpRenderTree/GCController.mm: Added. (+[GCController isSelectorExcludedFromWebScript:]): (+[GCController webScriptNameForSelector:]): (-[GCController collect]): (-[GCController collectOnAlternateThread:]):
3:39 PM Changeset in webkit [14568] by kdecker
  • 2 edits in branches/Safari-2-0-branch/WebCore
3:32 PM Changeset in webkit [14567] by jdevalk
  • 3 edits in trunk/WebKitSite

Adding Google Analytics code, to create visitor stats of our site.

2:54 PM Changeset in webkit [14566] by hyatt
  • 3 edits in trunk/WebCore

Move font destruction for HFONTs and cairo objects into FontData.

1:48 PM Changeset in webkit [14565] by brmorris
  • 1 edit in S60/trunk/WebKit/Plugin/inc/jri.h

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

  • Removing JRE dependency in Plugin/inc/jri.h
12:26 PM Changeset in webkit [14564] by andersca
  • 7 edits
    2 adds in trunk

WebCore:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts


  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty): Return document.scripts() instead of a placeholder object.


  • dom/Document.cpp: (WebCore::Document::scripts):
  • dom/Document.h: Add Document::scripts.


  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::traverseNextItem):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::): Add scripts collection type which traverses all script elements.


LayoutTests:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Add tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9093
Implement document.scripts


  • fast/dom/document-scripts-expected.txt: Added.
  • fast/dom/document-scripts.html: Added.
12:02 PM Changeset in webkit [14563] by brmorris
  • 1 edit
    8 deletes in S60/trunk

S60WebKit:

Reviewed by mario

2006-05-24 brmorris <​bradley.morrison@nokia.com>

  • Purged unneeded source
  • Updated README.txt
11:57 AM Changeset in webkit [14562] by brmorris
  • 5 edits
    1 delete in S60/trunk/WebKit/Plugin/inc

S60WebKit:

Reviewed by bradleym

2006-05-24 Pat

  • More lawyer-speak:

MPL 1.1 license on the Netscape Plugins.

11:51 AM Changeset in webkit [14561] by andersca
  • 5 edits
    2 adds in trunk

WebCore:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
innerText is empty for elements without renderers

  • dom/Node.cpp: (WebCore::Node::textContent):
  • dom/Node.h: Add optional convertBRsToNewlines argument for textContent.


  • html/HTMLElement.cpp: (WebCore::HTMLElement::innerText): If the element doesn't have a renderer, return textContent.

LayoutTests:

2006-05-24 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

Add test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9092
innerText is empty for elements without renderers.


  • fast/dom/inner-text-with-no-renderer-expected.txt: Added.
  • fast/dom/inner-text-with-no-renderer.html: Added.
2:25 AM Changeset in webkit [14560] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderThemeWin.cpp

Fix the Win32 themed controls so that they honor Cairo transforms.

1:33 AM Changeset in webkit [14559] by hyatt
  • 3 edits in trunk/WebCore

Fix a minor bug with the computation of glyph offsets in Cairo/Win32.

1:28 AM Changeset in webkit [14558] by hyatt
  • 2 edits in trunk/WebKitWin

Switch the cairo win32 create similar call over to createdib instead. Avoids wasted fills.

1:23 AM Changeset in webkit [14557] by hyatt
  • 1 edit
    1 add in trunk/WebCore/platform/cairo

Check in some temporary hacks to Cairo for speed.

12:15 AM Changeset in webkit [14556] by hyatt
  • 1 edit in trunk/WebKitWin/WebFramePrivate.cpp

Make sure the font options set on the context match what we draw.

May 23, 2006:

6:21 PM Changeset in webkit [14555] by brmorris
  • 1 edit
    2 deletes in S60/trunk

S60WebKit:

  • Corrected build.bat usage statement
  • Removed some irrelevant config files
6:08 PM Changeset in webkit [14554] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Correct reviewer from me to Tim.

5:59 PM Changeset in webkit [14553] by mjs
  • 9 edits in trunk/WebKit

Reviewed by Maciej.


  • more loader refactoring to simplify things and remove knowledge of WebView from WebSubresourceLoader
  • WebCoreSupport/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]): (-[WebSubresourceLoader didReceiveResponse:]):
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]): (-[WebDataSource _startLoading]):
  • WebView/WebFrame.m: (-[WebFrame _loadRequest:archive:]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader initWithDataSource:]): (-[WebMainResourceLoader didReceiveResponse:]):
5:24 PM Changeset in webkit [14552] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Timothy.

  • index.html: Link to Nokia's S60 WebKit.
4:32 PM Changeset in webkit [14551] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Remove the recent idl files from the WebCore target to prevent them
from being copied into the framework resources.

  • WebCore.xcodeproj/project.pbxproj:
4:31 PM Changeset in webkit [14550] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Justin Garcia and Levi Weintraub.


  • fixed Bug 9072: REGRESSION: Misspelling marker incorrect in editing/deleting/delete-and-undo.html
  • dom/Document.cpp: (WebCore::Document::removeMarkers): One more time to get this right, ugh. There is still one case where we don't want to advance the iterator, and that's when we remove a marker and do not insert a replacement marker. So I undid my previous patch, and added it++ to each of the two cases that insert a replacement marker. Now the layout tests pass even with the pixel tests enabled.
3:48 PM Changeset in webkit [14549] by brmorris
  • 372 edits
    2668 adds in S60/trunk

S60WebKit ... migrated!

3:11 PM Changeset in webkit [14548] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Implement CookieJar on Win32.

2:37 PM Changeset in webkit [14547] by thatcher
  • 1 copy in tags/WebKit-418.8/WebKit

Tag for WebKit 418.8 (part 2 of 2.)

2:37 PM Changeset in webkit [14546] by thatcher
  • 1 add in tags/WebKit-418.8

Tag for WebKit 418.8 (part 1 of 2.)

2:36 PM Changeset in webkit [14545] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning

2:36 PM Changeset in webkit [14544] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Merged fix from TOT to Safari-2-0-branch

2006-05-23 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
2:21 PM Changeset in webkit [14543] by hyatt
  • 1 edit in trunk/WebCore/bridge/win/FrameWin.cpp

Fix post form submission on Win32.

1:45 PM Changeset in webkit [14542] by sullivan
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Newer Xcode removed some obsolete cruft


  • DumpRenderTree/TextInputController.m: (-[TextInputController textInput]): added (id) cast to make newer compiler happy
1:31 PM Changeset in webkit [14541] by hyatt
  • 7 edits in trunk/WebCore

Fix glyph width access on win32 to not depend on the UChar.

12:27 PM Changeset in webkit [14540] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4558301> REGRESSION (420+): After clearing history and closing bookmark view window,
attempting to select Safari's menu bar results in a crash

  • Misc/WebNSWindowExtras.m: (replacementPostWindowNeedsDisplay): My fix yesterday for 4557117 was not quite good enough. Now that we cancel the display timer for a window *before* it deallocates, we need to make sure that while a window deallocates, no new display timers are scheduled for that window. This is actually possible, as 4558301 demonstrates. Luckily, NSWindow sets a handy "windowDying" flag when it deallocates, so we can just check that flag and bail out of the throttle hack if it is set. This should fix the last of the crashes involving display timers scheduled for deallocated or deallocating windows.
12:18 PM Changeset in webkit [14539] by brmorris
  • 1 add in S60/trunk/patentlicense.txt

S60WebKit: adding patentlicense.txt

12:15 PM Changeset in webkit [14538] by thatcher
  • 4 edits in tags/Safari-521.10.1

Versioning

10:51 AM Changeset in webkit [14537] by lweintraub
  • 5 edits in trunk/WebCore

Reviewed by Hyatt.

Cleaned up changes to markup by adding the non-virtual
nodeNamePreservingCase accessor function.

  • dom/Element.cpp: (WebCore::Element::nodeNamePreservingCase):
  • dom/Element.h:
  • editing/markup.cpp: (WebCore::startMarkup): (WebCore::endMarkup):
10:47 AM Changeset in webkit [14536] by thatcher
  • 1 copy in tags/Safari-521.10.1

New tag.

10:35 AM Changeset in webkit [14535] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • dom/Document.cpp: (WebCore::Document::removeMarkers): Fix to my previous checkin (which broke a layout test). Advance the iterator position every time through the loop; formerly it was not advanced in the case where a marker was actually removed, causing an infinite loop in certain cases. Also modified a comment that was confusing the situation by falsely claiming that iterating over a just-inserted node would always be OK.
9:27 AM Changeset in webkit [14534] by andersca
  • 12 edits
    2 adds in trunk

WebCore:

2006-05-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/Element.cpp: (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute): Use new getAttributeItem method.


  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem): Use new getAttributeItem method.


(WebCore::NamedAttrMap::getAttributeItem):

  • dom/NamedAttrMap.h: New method which returns the attribute based on the nodeName.

LayoutTests:

2006-05-23 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Update tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9017
Weather2.css incorrectly treated as JavaScript file @ www.live.com


  • dom/svg/level3/xpath/XPathNSResolver_lookupNamespaceURI_nist_dmstc-expected.txt: This fails in a different way now.


  • dom/xhtml/level3/core/nodelookupnamespaceuri17-expected.txt:
  • dom/xhtml/level3/core/nodelookupnamespaceuri20-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix17-expected.txt:
  • dom/xhtml/level3/core/nodelookupprefix20-expected.txt:
  • dom/xhtml/level3/core/noderemovechild28-expected.txt:
  • dom/xhtml/level3/core/noderemovechild29-expected.txt: These now pass.


  • fast/dom/attribute-namespaces-get-set-expected.txt: Added.
  • fast/dom/attribute-namespaces-get-set.html: Added. Add new tests.
8:40 AM Changeset in webkit [14533] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Eric.


  • remove knowledge of WebView from WebLoader in preparation for moving the code down
  • WebView/WebDataSource.m: (-[WebDataSource _defersCallbacks]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _privateBrowsingEnabled]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebLoader.h:
  • WebView/WebLoader.m: (-[WebLoader releaseResources]): (-[WebLoader setDataSource:]): (-[WebLoader willSendRequest:redirectResponse:]): (-[WebLoader didReceiveAuthenticationChallenge:]): (-[WebLoader didCancelAuthenticationChallenge:]): (-[WebLoader didReceiveResponse:]): (-[WebLoader didReceiveData:lengthReceived:]): (-[WebLoader signalFinish]): (-[WebLoader didFinishLoading]): (-[WebLoader didFailWithError:]): (-[WebLoader willCacheResponse:]): (-[WebLoader cancelWithError:]):
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
  • WebView/WebView.m: (-[WebView _incrementProgressForIdentifier:response:]): (-[WebView _incrementProgressForIdentifier:data:]): (-[WebView _completeProgressForIdentifier:]):
  • WebView/WebViewInternal.h:
Note: See TracTimeline for information about the timeline view.