Timeline



Jun 18, 2006:

5:00 PM Changeset in webkit [14909] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
Teach svn-apply and svn-unapply to use full path names

  • Scripts/svn-apply: Changed to use full path names. Cleaned up code.
  • Scripts/svn-unapply: Ditto.
4:54 PM Changeset in webkit [14908] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.
3:20 PM Changeset in webkit [14907] by ddkilzer
  • 4 edits in trunk

LayoutTests:

Reviewed by ggaren.

  • fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.

WebCore:

Reviewed by ggaren.

  • manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.
10:58 AM Changeset in webkit [14906] by ddkilzer
  • 5 edits in trunk/WebKit

WebKit:

Reviewed by xenon.

  • WebInspector/WebInspector.m: (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame the inspector is (no longer) targeting. (-_webFrameDetached:): Added. Moved the code that was previously in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it is detached from its parent.
  • WebInspector/WebInspectorInternal.h:
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors that the WebFrame is detaching. (-[WebFrame _addInspector:]): Added. (-[WebFrame _removeInspector:]): Added.
  • WebView/WebFrameInternal.h:
10:54 AM Changeset in webkit [14905] by ddkilzer
  • 7 edits
    7 adds in trunk

LayoutTests:

Reviewed by ggaren.

  • fast/history/clicked-link-is-visited-expected.checksum: Added.
  • fast/history/clicked-link-is-visited-expected.png: Added.
  • fast/history/clicked-link-is-visited-expected.txt: Added.
  • fast/history/clicked-link-is-visited.html: Added.
  • fast/history/resources/clicked-link-is-visited-2.html: Added.

WebCore:

Reviewed by ggaren.

  • manual-tests/redraw-page-cache-visited-links.html: Added note about window.history hack. Fixed coordinates for mouse events. Added call to keepWebHistory().
  • manual-tests/resources/redraw-page-cache-visited-links-2.html: Added note about window.history hack.

WebKitTools:

Reviewed by ggaren.

Test: LayoutTests/fast/history/clicked-link-is-visited.html

  • DumpRenderTree/DumpRenderTree.m: Add keepWebHistory function to layoutTestController (+[LayoutTestController isSelectorExcludedFromWebScript:]): Updated for keepWebHistory. (-[LayoutTestController keepWebHistory]): Added. We only set optional shared history if it is currently nil since keepWebHistory() might be called more than once incidentally for the same test. (dumpRenderTree): Set optional shared history in WebHistory to nil by default.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode 2.3 clean up.
10:11 AM Changeset in webkit [14904] by andersca
  • 16 edits in trunk

JavaScriptCore:

2006-06-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): Do nothing if the timeout check hasn't been started.


(KJS::TimeoutChecker::resumeTimeoutCheck):
Do nothing if the timeout check hasn't been started.
Use the right signal handler when unblocking.


(KJS::Interpreter::handleTimeout):
pause/resume the timeout check around the call to
shouldInterruptScript().


WebCore:

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Set the default script timeout.


(KJS::ScriptInterpreter::shouldInterruptScript):
New function which asks the frame if the script should be interrupted.


  • bindings/js/kjs_binding.h:


  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add calls to startTimeoutCheck/stopTimeoutCheck


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add calls to pauseTimeoutCheck/unpauseTimeoutCheck


(KJS::ScheduledAction::execute):
Add calls to startTimeoutCheck/stopTimeoutCheck


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldInterruptJavaScript): New function which asks the bridge if the script should be interrupted.


  • bridge/mac/WebCoreFrameBridge.h:
  • page/Frame.h: Add function declarations.


WebKit:

2006-06-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge shouldInterruptJavaScript]): Ask the UI delegate if the script should be interrupted.


  • WebView/WebUIDelegatePrivate.h: Declare webViewShouldInterruptJavaScript: delegate method
12:00 AM Changeset in webkit [14903] by ap
  • 3 edits
    2 adds in trunk

Reviewed by ggaren.

Most of the properties were already fixed, this just adds adds a prototype to window.debug.

Test: fast/dom/everything-to-string.html

  • bindings/js/kjs_proxy.cpp: (WebCore::TestFunctionImp::TestFunctionImp): (WebCore::KJSProxy::initScriptIfNeeded):

Jun 17, 2006:

11:25 PM Changeset in webkit [14902] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9491
Windows build breaks in interpreter.cpp

  • kjs/interpreter.cpp (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): Make sure to only assert equality with s_executingInterpreter when it is being used (i.e. when HAVE(SYS_TIME_H) == true)
9:22 PM Changeset in webkit [14901] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

  • Fix capitalization issue for case-sensitive filesystems.
  • icon/SQLStatement.cpp: Change assertions.h to Assertions.h.
5:30 PM Changeset in webkit [14900] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9477
REGRESSION: fast/dom/replaceChild.html crashes on WebKit ToT in debug build

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Refetch the debugger after executing the function in case the WebFrame it was running in has since been destroyed.
8:54 AM Changeset in webkit [14899] by adele
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Updated.
  • css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Updated.
  • css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Updated.
  • fast/block/float/table-relayout-expected.checksum: Added.
  • fast/block/float/table-relayout-expected.png: Added.
  • fast/block/float/table-relayout-expected.txt: Added.
  • fast/block/float/table-relayout.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/block/float/table-relayout.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): Added marking of children that use lineWidth.
  • rendering/RenderBlock.h: Added a FIXME.
8:37 AM Changeset in webkit [14898] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6282>

  • fast/dom/select-selectedIndex-multiple.html: Added.
  • fast/dom/select-selectedIndex.html: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6282:
Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex

Update selectedIndex when a new option is added using javascript.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLSelectCollection::put):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
  • html/HTMLSelectElement.h:
8:29 AM Changeset in webkit [14897] by adele
  • 4 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/reset-initiatedDrag.html: Added.

WebKit:

Reviewed by Darin.

  • WebView/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Reset the WebView's initiatedDrag flag when the document view is changed.
  • WebView/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): Changed the ASSERT to allow for drags that end after the view has been removed from the WebView.
3:48 AM Changeset in webkit [14896] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by ggaren.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9476
REGRESSION: Reproducible crash after closing window after viewing
css2.1/t0803-c5501-imrgn-t-00-b-ag.html

  • kjs/debugger.cpp: (Debugger::detach): Call setDebugger(0) for all interpreters removed from the 'attached to a debugger' list.

Jun 16, 2006:

6:15 PM Changeset in webkit [14895] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9463
REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector()
(m_floatingSelectors.contains(selector)) in some CSS tests

  • css/CSSGrammar.y: Create CSSSelector for FUNCTION using CSSParser::createFloatingSelector() instead of the bare constructor.
6:08 PM Changeset in webkit [14894] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4565312> Mail has a weird drawing artifact with dotted red lines running across the window

Problem was that revision lost a check to not draw the markers
when paintingDisabled(). This led the markers to be drawn when
the window deactivated, at which time the view happens to be flipped.

It is similar but not the same as the Mail ToDo highlighting
issue, which is due to the custom highlight method
drawing when the focusView is nil. Mail team knows this
and has tested the fix.

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): Early return if paintingDisabled().
4:47 PM Changeset in webkit [14893] by andersca
  • 6 edits in trunk/JavaScriptCore

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej and Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7080
Provide some way to stop a JavaScript infinite loop


  • kjs/completion.h: (KJS::): Add Interrupted completion type.


  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction): Only set the exception on the new ExecState if the current one has had one.


  • kjs/interpreter.cpp: (KJS::TimeoutChecker::startTimeoutCheck): (KJS::TimeoutChecker::stopTimeoutCheck): (KJS::TimeoutChecker::alarmHandler): (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): New TimeoutChecker class which handles setting Interpreter::m_timedOut flag after a given period of time. This currently only works on Unix platforms where setitimer and signals are used.


(KJS::Interpreter::Interpreter):
Initialize new member variables.


(KJS::Interpreter::~Interpreter):
Destroy the timeout checker.


(KJS::Interpreter::startTimeoutCheck):
(KJS::Interpreter::stopTimeoutCheck):
(KJS::Interpreter::pauseTimeoutCheck):
(KJS::Interpreter::resumeTimeoutCheck):
Call the timeout checker.


(KJS::Interpreter::handleTimeout):
Called on timeout. Resets the m_timedOut flag and calls shouldInterruptScript.


  • kjs/interpreter.h: (KJS::Interpreter::setTimeoutTime): New function for setting the timeout time.


(KJS::Interpreter::shouldInterruptScript):
New function. The idea is that this should be overridden by subclasses in order to for example
pop up a dialog asking the user if the script should be interrupted.


(KJS::Interpreter::checkTimeout):
New function which checks the m_timedOut flag and calls handleTimeout if it's set.


  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): Call Interpreter::checkTimeout after each iteration of the loop.
4:45 PM Changeset in webkit [14892] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Adjust padding of inner div so text lines up with text fields.
Adjust height of textarea so it only leaves room for the horizontal
scrollbar if overflow is set to scroll, or if overflow is set to
auto and there's no word wrap.

These changes will be tested by current layout tests when the
new textarea implementation takes effect.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight):
2:49 PM Changeset in webkit [14891] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4590062> crash in marker code with particular set of steps on daringfireball.net
  • dom/Document.cpp: (WebCore::Document::addMarker): Store [it - markers.begin()] in a local variable before modifying markers, since modifying markers can change value of [it - markers.begin()].
2:10 PM Changeset in webkit [14890] by thatcher
  • 7 edits
    3 adds in trunk/WebKit

Reviewed by Tim O.

Exposes a distributed objects server for clients to register for script debugger calls.
For preformance concerns this is disabled by default, you will need to enable this per application.
To enable for Safari do this: defaults write com.apple.Safari WebKitScriptDebuggerEnabled -bool true

Clients will need to listen to the following distributed notification to discover servers:
WebScriptDebugServerDidLoadNotification

To discover servers that previously loaded before the client, the client needs to send the following notification:
WebScriptDebugServerQueryNotification

All servers will reply with the WebScriptDebugServerQueryReplyNotification notification that contains the
registered server connection name to use with distributed objects.

  • DefaultDelegates/WebScriptDebugServer.h: Added.
  • DefaultDelegates/WebScriptDebugServer.m: Added. (+[WebScriptDebugServer sharedScriptDebugServer]): (-[WebScriptDebugServer init]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h: Added.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebView.m: (+[WebView _developerExtrasEnabled]): (+[WebView _scriptDebuggerEnabled]): (-[WebView _menuForElement:defaultItems:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
  • WebView/WebViewPrivate.h:
11:27 AM Changeset in webkit [14889] by adele
  • 12 edits in trunk

WebCore:

Reviewed by Alice.

Added code to draw Cocoa-like border for textareas instead of just using CSS.

  • WebCore.exp:
  • css/html4.css: Sets a 1px solid border.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderThemeMac.h: Formatting changes.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextArea): Uses new wkDrawBezeledTextArea to draw border.

WebKit:

Reviewed by Alice.

Added initialization for WKDrawBezeledTextArea.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Alice.

  • WebKitSystemInterface.h: Added WKDrawBezeledTextArea().
  • libWebKitSystemInterface.a: ditto.
10:02 AM Changeset in webkit [14888] by adele
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Maciej.

Adding missing expected result for test from yesterday.

  • fast/events/window-load-capture-expected.txt: Added.
6:13 AM Changeset in webkit [14887] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/text/capitalize-empty-generated-string-expected.checksum: Added.
  • fast/text/capitalize-empty-generated-string-expected.png: Added.
  • fast/text/capitalize-empty-generated-string-expected.txt: Added.
  • fast/text/capitalize-empty-generated-string.html: Added.

WebCore:

Reviewed by hyatt.

Test: fast/text/capitalize-empty-generated-string.html

  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Skip empty-string text renderers when looking for the previous character.

Jun 15, 2006:

5:45 PM Changeset in webkit [14886] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • fast/repaint/selection-after-delete-expected.checksum: Added.
  • fast/repaint/selection-after-delete-expected.png: Added.
  • fast/repaint/selection-after-delete-expected.txt: Added.
  • fast/repaint/selection-after-delete.html: Added.
  • fast/repaint/selection-after-remove-expected.checksum: Added.
  • fast/repaint/selection-after-remove-expected.png: Added.
  • fast/repaint/selection-after-remove-expected.txt: Added.
  • fast/repaint/selection-after-remove.html: Added.

WebCore:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Invalidate the selection so that selection gaps are invalidated.
3:44 PM Changeset in webkit [14885] by thatcher
  • 1 copy in tags/WebCore-418.19/WebCore

Tag for WebCore 418.19 (part 2 of 2.)

3:44 PM Changeset in webkit [14884] by thatcher
  • 1 add in tags/WebCore-418.19

Tag for WebCore 418.19 (part 1 of 2.)

3:33 PM Changeset in webkit [14883] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

JavaScriptGlue:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebKit.xcodeproj/project.pbxproj:
3:31 PM Changeset in webkit [14882] by jdevalk
  • 4 edits in trunk/LayoutTests/fast/css

And now with the ugly line gone, and the proper expected test results

3:28 PM Changeset in webkit [14881] by jdevalk
  • 1 edit
    2 adds in trunk/LayoutTests/fast/css

update testresults

3:26 PM Changeset in webkit [14880] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/pruning-after-merge-2-expected.checksum: Added.
  • editing/deleting/pruning-after-merge-2-expected.png: Added.
  • editing/deleting/pruning-after-merge-2-expected.txt: Added.
  • editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

Reviewed by harrison


  • editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): Ascend using the DOM (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion during deletion is fixed, removing the fall back.
2:37 PM Changeset in webkit [14879] by jdevalk
  • 8 edits
    2 adds in trunk

Adding :lang support, patch by Nicholas Shanks, review by Hyatt

2:09 PM Changeset in webkit [14878] by jdevalk
  • 2 edits in trunk/WebKitSite

Improve wording of first paragraph of index.html

1:05 PM Changeset in webkit [14877] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

  • editing/execCommand/findString-2-expected.checksum: Added.
  • editing/execCommand/findString-2-expected.png: Added.
  • editing/execCommand/findString-2-expected.txt: Added.
  • editing/execCommand/findString-2.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E


  • page/Frame.cpp: (WebCore::Frame::findString): When comparing the found range with what's currently selected a) build a selection with the found range to remove collapsed whitespace and b) compare ranges instead of selection objects to ignore the way that the current selection was made (to ignore the base and extent).
11:56 AM Changeset in webkit [14876] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:51 AM Changeset in webkit [14875] by justing
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by thatcher, harrison


<rdar://problem/4585175> 10.4.7 regression: Text from end of signature unexpectedly removed


Merged fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

  • khtml/editing/htmlediting.cpp: (khtml::hasARenderedDescendant): Added. (khtml::CompositeEditCommand::prune): Don't prune a leaf, the root editable element, or a container with one or more rendered descendants.
10:37 AM Changeset in webkit [14874] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


Fixed bug in WebKit support for computing but not highlighting rects for text matches.

  • WebView/WebView.m: (-[WebView rectsForTextMatches]): leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch of autoreleased NSValue objects, use a local autorelease pool
6:37 AM Changeset in webkit [14873] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Plugins/WebPluginController.m: (-[WebPluginController _cancelOutstandingChecks]): add nil check before calling CFSetApplyFunction
4:12 AM Changeset in webkit [14872] by ddkilzer
  • 108 edits in trunk/WebCore

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
IDL files missing copyright/license headers

Add Apple BSD license and copyright to IDL files.

  • ksvg2/bindings/idl/svg/GetSVGDocument.idl:
  • ksvg2/bindings/idl/svg/SVGAElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
  • ksvg2/bindings/idl/svg/SVGCircleElement.idl:
  • ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
  • ksvg2/bindings/idl/svg/SVGCursorElement.idl:
  • ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
  • ksvg2/bindings/idl/svg/SVGDefsElement.idl:
  • ksvg2/bindings/idl/svg/SVGDescElement.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstance.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
  • ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
  • ksvg2/bindings/idl/svg/SVGEvent.idl:
  • ksvg2/bindings/idl/svg/SVGException.idl:
  • ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
  • ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETileElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
  • ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
  • ksvg2/bindings/idl/svg/SVGGElement.idl:
  • ksvg2/bindings/idl/svg/SVGGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGICCColor.idl:
  • ksvg2/bindings/idl/svg/SVGImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGLangSpace.idl:
  • ksvg2/bindings/idl/svg/SVGLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGLineElement.idl:
  • ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGLocatable.idl:
  • ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
  • ksvg2/bindings/idl/svg/SVGNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGPaint.idl:
  • ksvg2/bindings/idl/svg/SVGPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
  • ksvg2/bindings/idl/svg/SVGPatternElement.idl:
  • ksvg2/bindings/idl/svg/SVGPointList.idl:
  • ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
  • ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
  • ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGRectElement.idl:
  • ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
  • ksvg2/bindings/idl/svg/SVGScriptElement.idl:
  • ksvg2/bindings/idl/svg/SVGSetElement.idl:
  • ksvg2/bindings/idl/svg/SVGStopElement.idl:
  • ksvg2/bindings/idl/svg/SVGStringList.idl:
  • ksvg2/bindings/idl/svg/SVGStylable.idl:
  • ksvg2/bindings/idl/svg/SVGStyleElement.idl:
  • ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
  • ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
  • ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
  • ksvg2/bindings/idl/svg/SVGTests.idl:
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
  • ksvg2/bindings/idl/svg/SVGTitleElement.idl:
  • ksvg2/bindings/idl/svg/SVGTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGTransformable.idl:
  • ksvg2/bindings/idl/svg/SVGURIReference.idl:
  • ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
  • ksvg2/bindings/idl/svg/SVGUseElement.idl:
  • ksvg2/bindings/idl/svg/SVGViewElement.idl:
  • ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
  • ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
  • ksvg2/svg/SVGAnimatedLength.idl:

Jun 14, 2006:

5:14 PM Changeset in webkit [14871] by thatcher
  • 1 copy in tags/WebCore-418.18/WebCore

New tag part 2.

5:12 PM Changeset in webkit [14870] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
  • editing/pasteboard/copy-paste-bidi-expected.png: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt: Added.
  • editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/markup.cpp: (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.
5:12 PM Changeset in webkit [14869] by thatcher
  • 1 add in tags/WebCore-418.18

Tag for WebCore 418.18 (part 1 of 2.)

4:23 PM Changeset in webkit [14868] by justing
  • 22 edits
    10 adds in trunk

LayoutTests:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-002.html:
  • editing/execCommand/format-block-expected.checksum: Added.
  • editing/execCommand/format-block-expected.png: Added.
  • editing/execCommand/format-block-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
  • editing/execCommand/format-block-from-range-selection-expected.png: Added.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Added.
  • editing/execCommand/format-block.html: Added.

WebCore:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. downstream() the start or else we'll move collapsed whitespace and uncollapse it.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition because that's removeNode's responsibility. (WebCore::updatePositionForNodeRemoval): Added. (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual overload of removeNode so that we can update positions as we remove nodes. (WebCore::updatePositionForTextRemoval): Added. (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid since m_trailingWhitespace is always valid (we update it as we remove nodes). (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should be fixed if they have collapsed before merging paragraphs.
  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h: (WebCore::):
  • editing/FormatBlockCommand.cpp: Added. (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange(). (WebCore::FormatBlockCommand::doApply):
  • editing/FormatBlockCommand.h: Added. (WebCore::FormatBlockCommand::editingAction):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::editingAction):
  • editing/JSEditor.cpp:
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::validBlockTag): (WebCore::createElement):
  • editing/htmlediting.h:

WebKit:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)


  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
3:59 PM Changeset in webkit [14867] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

  • Plugins/WebPluginController.m: (cancelOutstandingCheck): (-[WebPluginController _cancelOutstandingChecks]): Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.
3:50 PM Changeset in webkit [14866] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:21 PM Changeset in webkit [14865] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Test case by Anders, reviewed and tweaked by Maciej.


  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work


  • fast/events/window-load-capture.html: Added.

WebCore:

Reviewed by Anders.

  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWindowEvent):
2:51 PM Changeset in webkit [14864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Written by mjs, reviewed by Tim H.

<rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Call window capturing event handlers, not just bubbling event handlers.
2:45 PM Changeset in webkit [14863] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Beth.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"
2:17 PM Changeset in webkit [14862] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Rename RenderSlider to DeprecatedSlider, so that I can start work on
the new NSView-less slider.

Reviewed by john

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/DeprecatedSlider.cpp: Added. (WebCore::DeprecatedSlider::DeprecatedSlider): (WebCore::DeprecatedSlider::calcMinMaxWidth): (WebCore::DeprecatedSlider::updateFromElement): (WebCore::DeprecatedSlider::valueChanged):
  • rendering/DeprecatedSlider.h: Added. (WebCore::DeprecatedSlider::renderName):
  • rendering/RenderSlider.cpp: Removed.
  • rendering/RenderSlider.h: Removed.
10:04 AM Changeset in webkit [14861] by antti
  • 4 edits
    1 delete in S60/trunk

Reviewed by dacarson.

  • S60Internals/S60Headers.zip:
  • S60Internals/S60Libs.zip:
  • S60Internals/S60LibsGcce.zip:
  • S60Internals/SDK_GCCE_Patch.zip: Removed.
Note: See TracTimeline for information about the timeline view.