Timeline



Jul 15, 2006:

10:45 PM Changeset in webkit [15467] by thatcher
  • 1 edit in trunk/JavaScriptGlue/JavaScriptGlue.xcodeproj/project.pbxproj

JavaScriptGlue has no need to look for frameworks in WebKit's umbrella framework path anymore.

10:22 PM Changeset in webkit [15466] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

WebCore has no need to look for frameworks in WebKit's umbrella framework path anymore.

7:26 PM Changeset in webkit [15465] by darin
  • 6 edits in trunk/JavaScriptCore
  • oops, missed a few more arrays that had to be const
  • API/JSNode.c: (JSNodePrototype_appendChild): Added const. (JSNodePrototype_removeChild): Ditto. (JSNodePrototype_replaceChild): Ditto. (JSNode_construct): Ditto.
  • API/JSNodeList.c: (JSNodeListPrototype_item): Ditto.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody): Ditto. (JSObjectCallAsFunction): Ditto. (JSObjectCallAsConstructor): Ditto.
  • API/minidom.c: (print): Ditto.
  • API/testapi.c: (MyObject_callAsFunction): Ditto. (MyObject_callAsConstructor): Ditto. (print_callAsFunction): Ditto. (myConstructor_callAsConstructor): Ditto.
7:18 PM Changeset in webkit [15464] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • API/JSNode.h: Made an array parameter const.
  • API/JSObjectRef.h: Made array parameters const. Fixed a comment.
6:40 PM Changeset in webkit [15463] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • JSObjectMakeFunctionWithBody includes a function name and named parameters now.
  • API/JSObjectRef.cpp: (JSObjectMakeFunctionWithBody):
  • API/JSObjectRef.h:
  • API/testapi.c: (assertEqualsAsUTF8String): More informative failure reporting. (main): Test more function cases.
6:28 PM Changeset in webkit [15462] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • Moved the arguments passed to JSClassCreate into a single structure, called JSClassDefinition. This will enable easier structure migration/versioning in the future, if necessary.


  • Added support for class names.


  • kJSClassDefinitionNull replaces kJSObjectCallbacksNone.


  • JSClass is becoming a fairly complex struct, so I migrated all of its implementation other than reference counting to the sruct.


  • Also moved JSClass* functions in the API to JSObjectRef.cpp, since they're declared in JSObjectRef.h


  • Also added some more informative explanation to the class structure doc.
2:03 PM Changeset in webkit [15461] by darin
  • 2 edits in trunk/WebCore
  • fix mistake from fix for 8952 that was breaking layout tests
  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Justin was right! I changed the behavior of the function by accident. Changed it back so that it doesn't blow away the selection on the DOM side in the case where it didn't before.

I will write 100 times on the blackboard: "When Justin says something about editing,
assume he is right."

1:00 PM Changeset in webkit [15460] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added StreamingTextDecoderICU.cpp/h.
12:41 PM Changeset in webkit [15459] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/dynamic/move-node-with-selection-expected.checksum: Added.
  • fast/dynamic/move-node-with-selection-expected.png: Added.
  • fast/dynamic/move-node-with-selection-expected.txt: Added.
  • fast/dynamic/move-node-with-selection.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/dynamic/move-node-with-selection.html

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Call updateRendering before calling clearSelection(), since it's important to do any work beforehand, and there are calls inside clearSelection that will indirectly do an updateRendering. Also change code to make fewer assumptions about object lifetime.
12:27 PM Changeset in webkit [15458] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/lists/numeric-markers-outside-list-expected.checksum: Added.
  • fast/lists/numeric-markers-outside-list-expected.png: Added.
  • fast/lists/numeric-markers-outside-list-expected.txt: Added.
  • fast/lists/numeric-markers-outside-list.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/lists/numeric-markers-outside-list.html

  • rendering/RenderListItem.cpp: (WebCore::previousListItem): Look for list items, even when we're outside any list.
10:22 AM Changeset in webkit [15457] by adele
  • 7 edits in trunk/WebCore

Reviewed by John.

  • Fix for <rdar://problem/4593970> REGRESSION (NativeTextField): autofill menu disappears after typing a 2nd character

This was caused by composite editing commands, (like typing or pasting) that include a DeleteCommand, being
interpreted by the form delegate as an actual delete. This fix doesn't notify the form delegate if the deletion is
part of an editing command to replace the selected text.

  • editing/DeleteSelectionCommand.h: Added m_replace to keep track of whether this deletion is part of a composite command to replace the text being deleted.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Initialize m_replace. (WebCore::DeleteSelectionCommand::doApply): Only notify the form delegate of the deletion if the text is not being replaced.
  • editing/CompositeEditCommand.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Added replace argument to construct DeleteSelectionCommand.


  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Call deleteSelection with replace argument.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): ditto.
9:31 AM Changeset in webkit [15456] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.


Layout test for crash when setting the dir property on a document with no body.

  • fast/dom/dir-no-body-expected.txt: Added.
  • fast/dom/dir-no-body.html: Added.

WebCore:

Reviewed by Maciej, tweaked to match Darin's patch.


  • Fixed <rdar://problem/4631837> REGRESSION: Reproducible crash on FCKeditor demo (9911)


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Check for a null body element before forwarding the put request to it. I confirmed that no other parts of the file use 'body' or 'bodyElement' without checking for null.


Also, use 'body' rather than 'bodyElement' because dir can bet set on
any element, not just HTMLBodyElement.

8:30 AM Changeset in webkit [15455] by darin
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoff.

Test: fast/js/regexp-extended-characters-more.html

  • pcre/pcre_exec.c: (match): Got rid of utf16Length local variable to guarantee there's no extra stack usage in recursive calls. Fixed two places in the PCRE_UTF16 code that were using the length variable, which is the UTF-8 length of a character in the pattern, to move in the UTF-16 subject string. Instead they hardcode lengths of 1 and 2 since the code already handles BMP characters and surrogate pairs separately. Also fixed some DPRINTF so I could compile with DEBUG on. (pcre_exec): Changed a place that was checking for multibyte characters in the subject string to use ISMIDCHAR. Instead it was using hardcoded logic that was right for UTF-8 but wrong for UTF-16.
  • pcre/pcre_compile.c: (pcre_compile2): Fixed a DPRINTF so I could compile with DEBUG on.

LayoutTests:

Reviewed by Geoff.

  • fast/js/regexp-extended-characters-more-expected.txt: Added.
  • fast/js/regexp-extended-characters-more.html: Added.
  • fast/js/resources/regexp-extended-characters-more.js: Added.
8:21 AM Changeset in webkit [15454] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/input-text-enter-expected.txt: Added.
  • fast/forms/input-text-enter.html: Added.

WebCore:

Reviewed by Adele.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Add a null check to fix the crash, and a FIXME explaining why this is not necessarily enough for the future.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Consume Enter key keypress events even if the element is not in a form.
  • platform/mac/KeyEventMac.mm: (WebCore::keyIdentifierForKeyEvent): Added \n to the characters that turn into "Enter". Actual keyboard events always are \r or \003 on the Macintosh, but in layout tests we can use \n, and everything other than the code path here works, so worth fixing.
8:14 AM Changeset in webkit [15453] by darin
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/forms/select-selected-expected.checksum: Added.
  • fast/forms/select-selected-expected.png: Added.
  • fast/forms/select-selected-expected.txt: Added.
  • fast/forms/select-selected.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/forms/select-selected.html

  • rendering/RenderMenuList.h:
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Added code to map the selected option index to a list index before using it to index into the list. (WebCore::RenderMenuList::showPopup): Added code to map the selection option index to a list index before passing it to the menu renderer. (WebCore::RenderMenuList::valueChanged): Added code to map the list index back to a option index before calling setSelectedIndex (that function takes an option index).
8:09 AM Changeset in webkit [15452] by darin
  • 6 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • bindings/objc/DOM.mm: (-[DOMNode addEventListener:::]): Moved into DOMEventTarget category. (-[DOMNode removeEventListener:::]): Ditto. (-[DOMNode dispatchEvent:]): Ditto.
  • WebCore.xcodeproj/project.pbxproj: Allow Xcode to do its thing.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.m: (-[WebHTMLView _documentRange]): Moved into WebHTMLViewFileInternal category. (-[WebHTMLView selectionRect]): Moved into WebDocumentPrivateProtocols category. (-[WebHTMLView selectionView]): Ditto. (-[WebHTMLView selectionImageForcingWhiteText:]): Ditto. (-[WebHTMLView selectionImageRect]): Ditto. (-[WebHTMLView pasteboardTypesForSelection]): Ditto. (-[WebHTMLView selectAll]): Ditto. (-[WebHTMLView deselectAll]): Ditto. (-[WebHTMLView string]): Ditto. (-[WebHTMLView _attributeStringFromDOMRange:]): Ditto. (-[WebHTMLView attributedString]): Ditto. (-[WebHTMLView selectedString]): Ditto. (-[WebHTMLView selectedAttributedString]): Ditto. (-[WebHTMLView supportsTextEncoding]): Ditto. (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Moved into WebDocumentInternalProtocols. (-[WebHTMLView _isMoveDrag]): Ditto. (-[WebHTMLView _isNSColorDrag:]): Ditto. (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView draggingCancelledWithDraggingInfo:]): Ditto. (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]): Ditto. (-[WebHTMLView elementAtPoint:]): Ditto. (-[WebHTMLView elementAtPoint:allowShadowContent:]): Ditto.
  • WebKit.xcodeproj/project.pbxproj: Let Xcode 2.3 do its thing.
2:36 AM Changeset in webkit [15451] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Anders.

<rdar://problem/4632144> REGRESSION: table column tests failing as a result of very recent fix

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): columns and colgroups are valid children of a table too, not just table sections!
2:04 AM Changeset in webkit [15450] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-07-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Add null check for contentFrame() since content frames won't be created for invalid URLs.

LayoutTests:

2006-07-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9866
<rdar://problem/4631561>
REGRESSION: Repro crash from mangleme using iframe, only from server.

  • http/tests/misc/iframe-invalid-source-crash-expected.txt: Added.
  • http/tests/misc/iframe-invalid-source-crash.html: Added.

Jul 14, 2006:

11:53 PM Changeset in webkit [15449] by ap
  • 9 edits
    2 copies
    12 adds
    3 deletes in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=4195
REGRESSION: KOI8-U encoding no longer supported.

Tests:

  • http/tests/misc/BOM-override.pl
  • http/tests/misc/BOM-override-script.html
  • fast/encoding/charset-koi8-u.html
  • fast/encoding/charset-x-nextstep.html

Restored a TEC code path for encodings that are not supported by ICU (but which currently
passes all layout tests even by itself with ICU disabled). A lot of refactoring is
still needed - most importantly, round-tripping encoding names via CFStringEncoding
makes little sense now.

  • WebCore.exp:
  • bridge/mac/WebCoreTextDecoder.h: Removed.
  • bridge/mac/WebCoreTextDecoder.mm: Removed. WebCoreTextDecoder was not used anywhere since WebTextView was moved into WebCore.
  • loader/Decoder.cpp: (Decoder::Decoder): (Decoder::setEncodingName): (Decoder::decode): Use StreamingTextDecoder::create().
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::create): (WebCore::StreamingTextDecoder::~StreamingTextDecoder):
  • platform/StreamingTextDecoder.h: StreamingTextDecoder is just an abstract interface to implementations now.
  • platform/StreamingTextDecoderICU.cpp: Added. (WebCore::StreamingTextDecoderICU::StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::~StreamingTextDecoderICU): (WebCore::StreamingTextDecoderICU::releaseICUConverter): (WebCore::StreamingTextDecoderICU::textEncodingSupported): (WebCore::StreamingTextDecoderICU::convertUTF16): (WebCore::StreamingTextDecoderICU::convertIfASCII): (WebCore::StreamingTextDecoderICU::createICUConverter): (WebCore::StreamingTextDecoderICU::appendOmittingBOM): (WebCore::StreamingTextDecoderICU::convertUsingICU): (WebCore::StreamingTextDecoderICU::convert): (WebCore::StreamingTextDecoderICU::toUnicode): (WebCore::StreamingTextDecoderICU::fromUnicode):
  • platform/StreamingTextDecoderICU.h: Added. Renamed from StreamingTextDecoder; added a way to tell whether the encoding is actually supported by the decoder; minor cleanup.
  • platform/TextEncoding.cpp: (WebCore::TextEncoding::effectiveEncoding): Moved from StreamingTextDecoder. (WebCore::TextEncoding::toUnicode): Use StreamingTextDecoder::create(). (WebCore::TextEncoding::fromUnicode): Moved to StreamingTextDecoderICU.


  • platform/TextEncoding.h: Changed APPLE to PLATFORM(MAC); added effectiveEncoding().
  • platform/mac/StreamingTextDecoderMac.cpp: Added. (WebCore::StreamingTextDecoderMac::StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::~StreamingTextDecoderMac): (WebCore::StreamingTextDecoderMac::releaseTECConverter): (WebCore::StreamingTextDecoderMac::textEncodingSupported): (WebCore::StreamingTextDecoderMac::convertUTF16): (WebCore::StreamingTextDecoderMac::convertIfASCII): (WebCore::StreamingTextDecoderMac::createTECConverter): (WebCore::StreamingTextDecoderMac::appendOmittingBOM): (WebCore::StreamingTextDecoderMac::convertOneChunkUsingTEC): (WebCore::StreamingTextDecoderMac::convertUsingTEC): (WebCore::StreamingTextDecoderMac::convert): (WebCore::StreamingTextDecoderMac::toUnicode): (WebCore::StreamingTextDecoderMac::fromUnicode):
  • platform/mac/StreamingTextDecoderMac.h: Added. (WebCore::StreamingTextDecoderMac::convert): This is a TEC+CFString code path for decoding, basically restored from a year-old revision.
  • platform/mac/TextEncodingMac.cpp: Removed. Code moved to StreamingTextDecoderMac.
  • WebCore.xcodeproj/project.pbxproj:
11:37 PM Changeset in webkit [15448] by thatcher
  • 2 edits in tags/JavaScriptCore-521.17.1/JavaScriptCore

Build fix and versioning.

11:36 PM Changeset in webkit [15447] by thatcher
  • 1 copy in tags/JavaScriptCore-521.17.1/JavaScriptCore

New tag (part 2)

11:35 PM Changeset in webkit [15446] by thatcher
  • 1 add in tags/JavaScriptCore-521.17.1

new tag.

11:32 PM Changeset in webkit [15445] by thatcher
  • 1 edit in trunk/JavaScriptCore/API/JSBase.cpp

Build fix for case-sensitive file systems.

9:16 PM Changeset in webkit [15444] by ggaren
  • 11 edits in trunk/JavaScriptCore

RS by Maciej.


Global replace in the API of argc/argv with argumentCount/arguments.

9:10 PM Changeset in webkit [15443] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Finalized exception handling in the API.


setProperty can throw because it throws for built-in arrays. getProperty
and deleteProperty can throw because setProperty can throw and we want
to be consistent, and also because they seem like "actions." callAsFunction,
callAsConstructor, and hasInstance can throw, because they caan throw for
all built-ins.


toBoolean can't throw because it's defined that way in the spec.


  • Documented that toBoolean and toObject can't be overridden by custom objects because they're defined that way in the spec.
7:32 PM Changeset in webkit [15442] by thatcher
  • 5 copies in tags/Safari-521.17

New tag.

7:25 PM Changeset in webkit [15441] by thatcher
  • 5 edits
    4 deletes in trunk

LayoutTests:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by levi & thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.checksum: Added.
  • editing/selection/subframe-with-selection-expected.png: Added.
  • editing/selection/subframe-with-selection-expected.txt: Added.
  • editing/selection/subframe-with-selection.html: Added.

WebKit:

Rolling out this fix from r15358 since it isn't resolved.

2006-07-11 Justin Garcia <​justin.garcia@apple.com>

Reviewed by levi & thatcher

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
7:14 PM Changeset in webkit [15440] by thatcher
  • 8 edits in /

Versioning

5:53 PM Changeset in webkit [15439] by thatcher
  • 9 edits in trunk/WebKit

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Build fix with the new GCC. Removes forward declarations of protocols.

  • Misc/WebSearchableTextView.h:
  • WebCoreSupport/WebSubresourceLoader.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h:
  • WebView/WebDocumentPrivate.h:
  • WebView/WebHTMLView.h:
  • WebView/WebPDFView.h:
  • WebView/WebScriptDebugDelegatePrivate.h:
5:24 PM Changeset in webkit [15438] by thatcher
  • 34 edits in trunk/WebCore

<rdar://problem/4623957> SWB: gcc-5412 (new?) objc warning causes WebCore project failure

Made a DOMNode category in DOMEvents.h that lets DOMNode conform to the
DOMEventTarget protocol that works with GCC 5412.

Removed forward declarations of WebCoreWidgetHolder and imported WebCoreWidgetHolder.h.

Removed all <Cocoa/Cocoa.h> and <Foundation/Foundation.h> imports in other headers,
we import <Cocoa/Cocoa.h> in the prefix header for ObjC.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEvents.h:
  • bridge/mac/FormDataMac.h:
  • bridge/mac/WebCoreAXObject.h:
  • bridge/mac/WebCoreCache.h:
  • bridge/mac/WebCoreEncodings.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameNamespaces.h:
  • bridge/mac/WebCoreJavaScript.h:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageState.h:
  • bridge/mac/WebCoreResourceLoader.h:
  • bridge/mac/WebCoreScriptDebugger.h:
  • bridge/mac/WebCoreSettings.h:
  • bridge/mac/WebCoreStringTruncator.h:
  • bridge/mac/WebCoreStringTruncator.mm:
  • bridge/mac/WebCoreTextDecoder.h:
  • bridge/mac/WebDashboardRegion.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
  • platform/mac/CookieJar.mm:
  • platform/mac/DeprecatedStringMac.mm:
  • platform/mac/FontDataMac.mm:
  • platform/mac/FoundationExtras.h:
  • platform/mac/TextBoundaries.mm:
  • platform/mac/WebCoreHistory.h:
  • platform/mac/WebCoreHistory.m:
  • platform/mac/WebCoreKeyGenerator.h:
  • platform/mac/WebCoreTextArea.h:
  • platform/mac/WebCoreTextField.h:
  • platform/mac/WebCoreTextRenderer.h:
  • platform/mac/WebCoreView.h:
  • platform/mac/WebCoreWidgetHolder.h:
3:39 PM Changeset in webkit [15437] by ggaren
  • 22 edits in trunk

JavaScriptCore:

Reviewed by Maciej.


  • Implemented ref-counting of JSContexts by splitting into two datatypes: JSGlobalContext, which you can create/retain/release, and JSContext, which you can't.


Internally, you retain a JSGlobalContext/ExecState by retaining its
interpreter, which, in the case of a global ExecState, owns it.


  • Also made ~Interpreter() protected to catch places where Interpreter is manually deleted. (Can't make it private because some crazy fool decided it would be a good idea to subclass Interpreter in other frameworks. I pity da fool.)
  • API/APICast.h: (toJS): Added cast for new JSGlobalContext
  • API/JSStringRef.h: Changed vague "you must" language to more specific (but, ultimately, equally vague) "behavior is undefined if you don't" language. (KJS::Interpreter::Interpreter): Factored more common initialization into init()
  • kjs/interpreter.h: (KJS::Interpreter::ref): new (KJS::Interpreter::deref): new (KJS::Interpreter::refCount): new
  • kjs/testkjs.cpp: (doIt): Ref-count the interpreter.

JavaScriptGlue:

Reviewed by Maciej.


  • Updated JSInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(JSInterpreter::JSInterpreter::~JSInterpreter): Now protected to catch
manual delete.

WebCore:

Reviewed by Maciej.

  • Updated ScriptInterpreter to work with Interpreter ref-counting in JavaScriptCore.

(KJS::ScriptInterpreter::~ScriptInterpreter): Now protected to catch
manual delete.

2:21 PM Changeset in webkit [15436] by brmorris
  • 2 edits
    1 add in S60/trunk/S60Tools

2006-07-14 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com. Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9919


  • prepare-ChangeLog.bat: Match Changelog subdir location on '/'
  • refresh_zips.bat: Added.
1:54 PM Changeset in webkit [15435] by andersca
  • 3 edits
    1 add in trunk/WebCore

2006-07-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele and Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9658
<rdar://problem/4613948>
REGRESSION: Check Spelling does not work in textarea elements


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): Don't use setStartBefore or setEndAfter on the search range because for shadow trees, there is no notion of before and after. Instead, use setStart and setEnd and pass in the start and end indices respectively.


  • dom/Range.cpp: (WebCore::Range::checkNodeBA): Allow range operations on shadow trees.
  • manual-tests/form-element-spelling.html: Added.
1:53 PM Changeset in webkit [15434] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.


  • removed bool return value from JSObjectSetProperty, since it is inefficient and also doesn't work quite right
  • added JSObjectGetPropertyAtIndex and JSObjectSetPropertyAtIndex
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Removed return value and canPut stuff. (JSObjectGetPropertyAtIndex): Added. (JSObjectSetPropertyAtIndex): Added.
  • API/JSObjectRef.h: Prototyped and documented new functions.
1:35 PM Changeset in webkit [15433] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4621660> REGRESSION: Safari crashing in
WebCore::FrameView::updateOverflowStatus

m_viewportRenderer is never initialized for framesets, and it
shouldn't be. So we just need to nil-check for it in
updateOverflowStatus() and return early.

  • page/FrameView.cpp: (WebCore::FrameView::updateOverflowStatus): Nil check.
1:29 PM Changeset in webkit [15432] by brmorris
  • 3 edits
    7 adds in S60/trunk

2006-07-11 brmorris <​bradley.morrison@nokia.com>

Reviewed by dacarson.


Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9755


  • ChangeLog: Re-arranged all ChangeLog entry locations.
  • JavaScriptCore/ChangeLog: Stripped to S60WebKit only.
  • MemoryManager/ChangeLog: Added.
  • S60Internals/ChangeLog: Added.
  • S60Tools/ChangeLog: Added.
  • S60WebUi/ChangeLog: Added.
  • WebCore/ChangeLog: Added.
  • WebKit/ChangeLog: Re-arranged.
1:07 PM Changeset in webkit [15431] by brmorris
  • 3 edits in S60/trunk

2006-07-11 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.


Fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9852


  • runATF.bat: Now supports SDK 3rd ed maintenance release.

Calls Epoc.exe directly

  • emu.bat: Calls Epoc.exe directly
12:09 PM Changeset in webkit [15430] by adele
  • 4 edits in trunk

WebCore:

RS by Darin.

Backing out fix for <rdar://problem/4604703>
REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Darin had a better fix in WebKit for this.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):

WebKit:

Reviewed by Adele.

  • WebView/WebHTMLView.m: (-[NSArray menuForEvent:]): Set handlingMouseDownEvent to YES while calling sendContextMenuEvent: on the bridge.
11:53 AM Changeset in webkit [15429] by adele
  • 5 edits in trunk/WebCore

Reviewed by Darin.

  • Fix for <rdar://problem/4614054> REGRESSION: Safari submits forms when the Return key is hit to complete inline inputs
  • page/Frame.h: (WebCore::Frame::inputManagerHasMarkedText): Added.
  • bridge/mac/FrameMac.h: ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::inputManagerHasMarkedText): Added. Asks the input manager if there's marked text.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): For text fields, don't submit the form on Enter if the input manager says there's marked text. I added this code for all text field paths. For widgets, WebCoreTextField.mm has code to deal with this case. But as we convert search, password, and isindex, they will need to do this check too.
10:41 AM Changeset in webkit [15428] by ggaren
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by Beth.


Moved JSCheckScriptSyntax, JSEvaluateScript, and JSGarbageCollect into
JSBase.h/.cpp. They don't belong in the value-specific or context-specific
files because they're not part of the value or context implementations.

  • API/JSBase.h:
  • API/JSContextRef.cpp: (JSContextGetGlobalObject):
  • API/JSContextRef.h:
  • API/JSValueRef.cpp: (JSValueUnprotect):
  • API/JSValueRef.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
6:18 AM Changeset in webkit [15427] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Mitz.

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed the calculation of the max/min allowed caret position.
6:14 AM Changeset in webkit [15426] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • editing/deleting/delete-at-start-or-end-expected.checksum: Added.
  • editing/deleting/delete-at-start-or-end-expected.png: Added.
  • editing/deleting/delete-at-start-or-end-expected.txt: Added.
  • editing/deleting/delete-at-start-or-end.html: Added.

WebCore:

Reviewed by Darin.

Test: editing/deleting/delete-at-start-or-end.html

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Added null check. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
5:33 AM Changeset in webkit [15425] by ddkilzer
  • 1 edit
    4 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

NOTE: Only the layout test part of this patch was landed since an alternate
fix was committed in r15401: <rdar://problem/4509393> selected DOM range
starts with <object>, 0 offset but selection should include the <object>

  • fast/table/click-near-anonymous-table-expected.checksum: Added.
  • fast/table/click-near-anonymous-table-expected.png: Added.
  • fast/table/click-near-anonymous-table-expected.txt: Added.
  • fast/table/click-near-anonymous-table.html: Added.
5:05 AM Changeset in webkit [15424] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Geoffrey.

No test cases since there is no change in functionality.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::setLength): Simplified logic by using the no-argument getNumber() method.
1:07 AM Changeset in webkit [15423] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • Build fix: don't need BLOCK_OBJC_EXCEPTIONS because we already have one surrounding this function, and the nested one makes the compiler think our local variable is volatile (seems like a compiler bug to me).


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent):
12:46 AM Changeset in webkit [15422] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Make JavaScriptCore a public framework. Adjusted the paths.

  • WebCore.xcodeproj/project.pbxproj:
12:45 AM Changeset in webkit [15421] by mjs
  • 5 edits
    24 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Test cases for <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I included the test case from the bug plus variants for other broken cases that
were similar but needed separate fixes.

  • fast/table/cell-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/cell-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-row-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-row-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-table-before-misnested-text-crash.xhtml: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/form-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash-expected.txt: Added.
  • fast/table/row-in-tbody-before-misnested-text-crash.xhtml: Added.
  • fast/table/section-in-table-before-misnested-text-crash-expected.txt: Added.
  • fast/table/section-in-table-before-misnested-text-crash.xhtml: Added.

WebCore:

Reviewed by Hyatt.

  • fixed <rdar://problem/4567031> REGRESSION: Crash at WebCore::RenderBlock::createLineBoxes (seems to be a security hole?)


I also fixed all the similar crash / assertion failure cases I could think of.

  • dom/Node.cpp: (WebCore::Node::nextRendererWithSameParent): Helper function for some of the above.
  • dom/Node.h:
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Don't allow inserting forms when not in an HTML document, since we don't need that quirk and because parsing won't do certain render tree fixups. Also watch out for case when inserting before the renderer of a misnested child.
  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): ditto
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): ditto
12:15 AM Changeset in webkit [15420] by thatcher
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

WebKit:

Reviewed by Maciej.

Moved JavaScriptCore to be a public framework.

  • WebKit.xcodeproj/project.pbxproj:

Jul 13, 2006:

11:48 PM Changeset in webkit [15419] by adele
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Maciej.

  • Fix for <rdar://problem/4604703> REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field

Test:

  • manual-tests/password-ctrl-click-lose-focus.html: Added.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): If we're about to set a selection in the current view, make sure its the first responder. In this case, this will cause the password field to resign first responder at the right time.
9:42 PM Changeset in webkit [15418] by ddkilzer
  • 20 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

  • editing/deleting/delete-to-select-table-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/selection/after-line-wrap-expected.txt:
  • editing/selection/mixed-editability-1-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/text/international/rtl-white-space-pre-wrap-expected.checksum: Added.
  • fast/text/international/rtl-white-space-pre-wrap-expected.png: Added.
  • fast/text/international/rtl-white-space-pre-wrap-expected.txt: Added.
  • fast/text/international/rtl-white-space-pre-wrap.html: Added.
  • fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
  • fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

Test: fast/text/international/rtl-white-space-pre-wrap.html

  • rendering/RenderText.cpp: (WebCore::RenderText::caretRect): Fixed LTR case and added the RTL case of clipping the caret position to the text box when the caret is after the trailing space of an autowrapped line.
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to truncate- to-fit the logically last text box if it contains the trailing spaces of an autowrapped line. (WebCore::RenderBlock::bidiReorderLine): Remember the logically last text run. In the case of autowrapped text with white space that overflows beyond the line, the last text run is the one containing the overflowing white space. (WebCore::RenderBlock::findNextLineBreak): Split overflowing white space on a line that autowraps only after white space into a separate text run.
8:29 PM Changeset in webkit [15417] by ddkilzer
  • 7 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Geoffrey. Patch by Mark Rowe.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <​http://www.vtbook.com>

  • kjs/value.h: (KJS::JSValue::getUInt32): Only types tagged as numeric can be converted to UInt32.

LayoutTests:

Reviewed by Geoffrey. Patch by Mark Rowe.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9742
Bug 9742: REGRESSION: WebKit hangs when loading <​http://www.vtbook.com>

This includes tests for indexing an array with immediate types, and for
setting selectField.options.length to immediate types.

  • fast/dom/select-selectedIndex-expected.txt:
  • fast/dom/select-selectedIndex-multiple-expected.txt:
  • fast/dom/select-selectedIndex-multiple.html: Update to test setting length to true and false.
  • fast/dom/select-selectedIndex.html: Ditto.
  • fast/js/array-index-immediate-types-expected.txt: Added.
  • fast/js/array-index-immediate-types.html: Added.
  • fast/js/resources/array-index-immediate-types.js: Added.
7:37 PM Changeset in webkit [15416] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Darin.

  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): Return immediately if the view has already been closed.
4:17 PM Changeset in webkit [15415] by harrison
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

<rdar://problem/4624203> -webkit-highlight should be behind images

  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Call custom highlighter before painting the image, marker, or widget.
2:08 PM Changeset in webkit [15414] by harrison
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • editing/deleting/delete-by-word-001-expected.checksum: Added.
  • editing/deleting/delete-by-word-001-expected.png: Added.
  • editing/deleting/delete-by-word-001-expected.txt: Added.
  • editing/deleting/delete-by-word-001.html: Added.
  • editing/deleting/delete-by-word-002-expected.checksum: Added.
  • editing/deleting/delete-by-word-002-expected.png: Added.
  • editing/deleting/delete-by-word-002-expected.txt: Added.
  • editing/deleting/delete-by-word-002.html: Added.

WebCore:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed): (WebCore::TypingCommand::doApply):
  • editing/TypingCommand.h: Delete and forward delete to use specified granularity. Undo of delete and forward delete to select what had been deleted (non-char granularity only).


  • page/Frame.cpp: (WebCore::Frame::setSelection): Close typing and end style even if selection is not changing.
  • page/Frame.h: Remove unused setSelection parameter keepTypingStyle.

WebKit:

Reviewed by Justin and Levi.

<rdar://problem/4620743> REGRESSION: Option-Delete doesn't delete words during typing

  • Tests: editing/deleting/delete-by-word-001.html editing/deleting/delete-by-word-002.html
  • WebView/WebHTMLView.m: (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
11:45 AM Changeset in webkit [15413] by thatcher
  • 3 edits in tags/WebKit-521.16.4/WebKit

Reviewed by Darin.

<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.

Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.

  • WebView/WebView.m: (-[WebView setEditable:]):
11:44 AM Changeset in webkit [15412] by thatcher
  • 3 edits in tags/WebCore-521.16.1/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
  • dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
11:34 AM Changeset in webkit [15411] by thatcher
  • 1 copy in tags/WebKit-521.16.4

New tag.

11:33 AM Changeset in webkit [15410] by thatcher
  • 1 copy in tags/WebCore-521.16.1/WebCore

New tag (part 2)

11:32 AM Changeset in webkit [15409] by thatcher
  • 1 add in tags/WebCore-521.16.1

New tag.

11:28 AM Changeset in webkit [15408] by lweintraub
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by justin

<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

  • editing/deleting/delete-block-table-expected.checksum: Added.
  • editing/deleting/delete-block-table-expected.png: Added.
  • editing/deleting/delete-block-table-expected.txt: Added.
  • editing/deleting/delete-block-table.html: Added.
  • editing/deleting/delete-hr-expected.checksum: Added.
  • editing/deleting/delete-hr-expected.png: Added.
  • editing/deleting/delete-hr-expected.txt: Added.
  • editing/deleting/delete-hr.html: Added.
  • editing/deleting/delete-to-select-table-expected.png:
  • editing/execCommand/insertHorizontalRule-expected.txt:
  • fast/lists/markers-in-selection-expected.txt:

WebCore:

Reviewed by justin

<rdar://problem/4622763> Deleting from beginning of paragraph following a table deletes rather than selects the table

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializeStartEnd): Added selection expansion for HRs. (WebCore::DeleteSelectionCommand::initializePositionData): Now uses enclosingBlockFlowOrTableElement instead of enclosingBlockFlowElement. (WebCore::DeleteSelectionCommand::removeNode): Use to identify that we need a placeholder when the start or end block is removed. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Added check for canHaveChildrenForEditing to keep things like HRs from being given children. (WebCore::DeleteSelectionCommand::doApply): Switched to use member variable for needPlaceholder.
  • editing/DeleteSelectionCommand.h: Made needPlaceholder a member variable.
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Fixed selection bug for tables and open typing commands. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added check for HRs, since it's not considered a widget.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Fix for HRs and tables. (WebCore::endOfParagraph): Ditto.
11:27 AM Changeset in webkit [15407] by thatcher
  • 3 edits in trunk/WebKit

Rolling out this earlier change (r15378) now that it is fixed on AGL's end.
Fixes <rdar://problem/4624865> Restore 64-bit OpenGL plug-in support once AGL is 64-bit

<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m:
11:06 AM Changeset in webkit [15406] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4616920> REGRESSION: tabbing in mail moves focus
to next control instead of inserting a tab space.

Change editible WebView's tabKeyCyclesThroughElements to NO only
if the setTabKeyCyclesThroughElements SPI wasn't called.

  • WebView/WebView.m: (-[WebView setEditable:]):
8:54 AM Changeset in webkit [15405] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

No change in behavior, thus no test included.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setStatusBarText): Use a local autorelease pool to release the temporaries - the test runs non-stop, and the enclosing pool doesn't get a chance to be drained.
1:56 AM Changeset in webkit [15404] by ggaren
  • 14 edits in trunk/JavaScriptCore

Pleasing to Maciej.


  • Renamed JSEvaluate -> JSEvaluateScript, JSCheckSyntax -> JSCheckScriptSyntax
  • Added exception out parameters to JSValueTo* and JSValueIsEqual because they can throw
  • Removed JSObjectGetDescription because it's useless and vague, and JSValueToString/JSValueIsObjectOfClass do a better job, anyway
  • Clarified comments about "IsFunction/Constructor" to indicate that they are true of all functions/constructors, not just those created by JSObjectMake*
12:11 AM Changeset in webkit [15403] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Timothy.

Bug 9889: [Drosera] Stepping out when paused after last statement in function skips a frame
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9889

  • Drosera/debugger.js: Track whether we paused during the execution of willLeaveFrame. If so, have stepOut pause on the next call to willExecuteStatement rather than second.

Jul 12, 2006:

9:52 PM Changeset in webkit [15402] by ddkilzer
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Adele. Patch by Mitz.

Test: fast/frames/repaint-display-none-crash.html

  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle): Added null checking of the owner element's renderer, which can be null if the iframe is set to display:none.

LayoutTests:

Reviewed by Adele. Patch by Mitz.

  • fast/frames/repaint-display-none-crash-expected.txt: Added.
  • fast/frames/repaint-display-none-crash.html: Added.
7:31 PM Changeset in webkit [15401] by justing
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4509393>
selected DOM range starts with <object>, 0 offset but selection should include the <object>

  • editing/selection/legal-positions-expected.txt: Added.
  • editing/selection/legal-positions.html: Added.
  • editing/deleting/delete-3608430-fix-expected.txt:
  • editing/deleting/delete-image-001-expected.txt:
  • editing/deleting/delete-image-002-expected.txt:
  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/selection/select-box-expected.txt:

WebCore:

Reviewed by levi


<rdar://problem/4509393>
selected DOM range starts with <object>, 0 offset but selection should include the <object>

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Don't pull content out of a table cell.
  • editing/htmlediting.cpp: (WebCore::editingIgnoresContent): Added <select> nodes. (WebCore::rangeCompliantEquivalent): Convert [node, 0] positions to positionBeforeNode(node) for more types of nodes.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::positionForCoordinates): Fix a crasher when right clicking on an anonymous table.
7:15 PM Changeset in webkit [15400] by ggaren
  • 4 edits
    2 moves in trunk/JavaScriptCore

RS by Beth.


Finished previously approved JSInternalString -> JSString conversion
by renaming the files.

  • API/JSCallbackObject.cpp:
  • API/JSInternalStringRef.cpp: Removed.
  • API/JSInternalStringRef.h: Removed.
  • API/JSStringRef.cpp: Added.
  • API/JSStringRef.h: Added.
  • API/JavaScriptCore.h:
  • JavaScriptCore.xcodeproj/project.pbxproj:
5:36 PM Changeset in webkit [15399] by sullivan
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Brady Eidson (and written by Justin Garcia)


  • layout test corresponding to <rdar://problem/4611164>
  • editing/undo/undo-misspellings-expected.checksum: Added.
  • editing/undo/undo-misspellings-expected.png: Added.
  • editing/undo/undo-misspellings-expected.txt: Added.
  • editing/undo/undo-misspellings.html: Added.
5:29 PM Changeset in webkit [15398] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson


  • fixed <rdar://problem/4611164> REGRESSION: Crash occurs when undoing a series of misspelled words (WebCore::RenderObject::repaint(bool)
  • dom/Document.cpp: (WebCore::Document::removeMarkers): put (it - markers.begin()) in a local variable before altering markers, in every case where this was happening. One of the cases like this was fixed a while back, but other cases were either missed at that time or crept in since.
5:20 PM Changeset in webkit [15397] by andersca
  • 3 edits
    4 adds in trunk

WebCore:

2006-07-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus


  • dom/Document.cpp: (WebCore::Document::updateSelection): Don't return early if the selection is empty.

LayoutTests:

2006-07-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Justin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9663
REGRESSION (r14948-r14956): Selection in text field remains highlighted when the text field loses focus

  • editing/selection/clear-selection-expected.checksum: Added.
  • editing/selection/clear-selection-expected.png: Added.
  • editing/selection/clear-selection-expected.txt: Added.
  • editing/selection/clear-selection.html: Added.
2:47 PM Changeset in webkit [15396] by andersca
  • 2 edits in trunk/WebKit

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9624
REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items


  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Don't create Dictionary, Spotlight or Google lookup items if there's no selection.
10:31 AM Changeset in webkit [15395] by andersca
  • 2 edits
    1 add in trunk/WebCore

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adele.

<rdar://problem/4614656> REGRESSION: onpaste() handlers don't run for textarea elements


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::dispatchCPPEvent): If the element is a shadow node, dispatch the event to its real parent.
  • manual-tests/textarea-onpaste.html: Added.
10:00 AM Changeset in webkit [15394] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Anders.

Fix for layout test regressions after my check-in last night. Just
a silly mistake where I should have asked if we were NOT printing
instead of if we were in the listbox code.

  • WebCore.xcodeproj/project.pbxproj: Project file wars. Back to XCode 2.3
  • platform/mac/ListBoxMac.mm: (itemTextRenderer): Inverted check. (groupLabelTextRenderer): Inverted check.
9:15 AM Changeset in webkit [15393] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

  • Scripts/svn-apply: Added fixChangeLogPatch() and invoked it in the proper place.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
9:09 AM Changeset in webkit [15392] by ddkilzer
  • 3 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (layout test fix).

Remove property information left in files from svn-apply.

  • fast/table/large-rowspan-crash-expected.txt:
  • fast/table/large-rowspan-crash.html:
8:52 AM Changeset in webkit [15391] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fix date.

8:30 AM Changeset in webkit [15390] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • another large rowspan test case
  • fast/table/large-rowspan-crash-expected.txt: Added.
  • fast/table/large-rowspan-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/table/large-rowspan-crash.html

  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::ensureRows): Use sizeof(RowStruct) instead of sizeof(int). Clearly we'll need something better to solve this completely. I expect another smaller, but still huge, value will still cause a problem.
6:32 AM Changeset in webkit [15389] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by ggaren.

Bug 9869: [Drosera] JS Console fails to evaluate input when paused in global scope
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9869

  • Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): Include the global frame in the stack.
4:28 AM Changeset in webkit [15388] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by ggaren.

Bug 9863: Drosera needs to show something at launch
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9863

  • Drosera/DebuggerApplication.m: (-[DebuggerApplication applicationDidFinishLaunching:]): Show the attach window on launch.
3:33 AM Changeset in webkit [15387] by andersca
  • 5 edits
    4 adds in trunk

WebCore:

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const

  • bridge/mac/FrameMac.h: Add focusCallResultedInViewBeingCreated argument.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::nextKeyViewInFrame): If the call to focus() caused the node to get a native widget, set focusCallResultedInViewBeingCreated to true.


(WebCore::FrameMac::nextKeyViewInFrameHierarchy):
Don't reset the focus node if focusCallResultedInViewBeingCreated is true. Also, add magic to prevent setting
a text field as the first responder if its field editor already is the current first responder.


  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): In some cases, get the event target node again after dispatching the mouse event.

LayoutTests:

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4586665> REGRESSION: autorestore.apple.com: Crashes Safari in WebCore::Widget::client() const

  • fast/forms/input-type-change-in-onfocus-keyboard-expected.txt: Added.
  • fast/forms/input-type-change-in-onfocus-keyboard.html: Added.
  • fast/forms/input-type-change-in-onfocus-mouse-expected.txt: Added.
  • fast/forms/input-type-change-in-onfocus-mouse.html: Added.
3:18 AM Changeset in webkit [15386] by andersca
  • 4 edits in trunk/JavaScriptGlue

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Build fix


  • JSUtils.cpp: (KJSValueToCFTypeInternal):
  • JSValueWrapper.cpp: (JSValueWrapper::JSObjectCopyPropertyNames):
  • UserObjectImp.cpp: (UserObjectImp::getPropertyList):
3:01 AM Changeset in webkit [15385] by ggaren
  • 16 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Removed context and exception parameters from JSObjectGetPropertyEnumerator, removing the spurious use of ExecState inside JavaScriptCore that made us think this was necessary in the first place.

(StringInstance::getPropertyList): Use getString instead of toString because
we know we're dealing with a string -- we put it there in the first place.
While we're at it, store the string's size instead of retrieving it each time
through the loop, to avoid the unnecessary killing of puppies.

  • kjs/string_object.h:
2:55 AM Changeset in webkit [15384] by mjs
  • 7 edits in trunk/JavaScriptCore

4eviewed by Geoff.


  • add handling of hasInstance callback for API objects
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::implementsHasInstance): Check if callback is present. (KJS::JSCallbackObject::hasInstance): Invoke appropriate callback.
  • API/JSCallbackObject.h:
  • API/JSClassRef.cpp:
  • API/JSObjectRef.h:
  • API/testapi.c: (MyObject_hasInstance): Test case; should match what construct would do.
  • API/testapi.js:
2:52 AM Changeset in webkit [15383] by bdakin
  • 6 edits in trunk/WebCore

--This Reviewed by Adele.

Fix for <rdar://problem/4615765> Input[type='search' fields
initially render too large in Widgets

Fundamentally, the problem here is that we were miscalculating
things because [NSGraphicsContext currentContextDrawingToScreen]
was evaluating to false when widgets first load. We only ever used
this check, however, to determine if we were printing or not, so it
should not have evaluated to false for loading in Dashbaord.
Instead, if we query the RenderView about whether or not we are
printing, we will get the right answer.

No test case added since this appears only to affect Dashboard.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]): Ask the RenderView if we are printing instead. This is not part of the actual bug fix, but it seems wise to get rid of all calls to [NSGraphicsContext currentContextDrawingToScreen] when we are just trying to determine if we are printing or not.
  • platform/mac/ListBoxMac.mm: (itemTextRenderer):This function now takes a boolean, isPrinting. (groupLabelTextRenderer): Same as above. (ListBox::sizeForNumberOfLines): Ask the RenderView if we are printing. (-[WebCoreTableView drawRow:clipRect:]): Same as above.
  • platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint): Same as above.
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
  • rendering/RenderLineEdit.cpp: Same as above.

M WebCore/platform/mac/TextFieldMac.mm
M WebCore/platform/mac/PopUpButtonMac.mm
M WebCore/platform/mac/ListBoxMac.mm
M WebCore/rendering/RenderLineEdit.cpp
M WebCore/ChangeLog
M WebCore/bridge/mac/WebCoreFrameBridge.mm

2:32 AM Changeset in webkit [15382] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9868
Applications shown in Drosera's "Attach" window remain after exit

  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer init]): Register for NSApplicationWillTerminateNotification so we will know when the application is being exited. (-[WebScriptDebugServer dealloc]): Unregister notification before we are deallocated. (-[WebScriptDebugServer applicationTerminating:]): Inform anyone listening that we are going away.
1:55 AM Changeset in webkit [15381] by thatcher
  • 3 edits in trunk/WebKitTools

Reviewed by Timothy.


Lets Drosera build universal for the nightlies. Right now it is not
possible to build a universal binary on a PPC machine because of a
conflict with the universal SDK.

  • BuildSlaveSupport/build-launcher-app:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1:31 AM Changeset in webkit [15380] by thatcher
  • 3 edits in tags/WebKit-521.16.3/WebKit

Build fix for AGL. Versioning.

1:26 AM Changeset in webkit [15379] by thatcher
  • 1 copy in tags/WebKit-521.16.3

new tag.

1:25 AM Changeset in webkit [15378] by tomernic
  • 3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4624858> AGL isn't 64-bit yet; temporarily remove it from WebKit 64-bit build

Also, fixed a LOG_ERROR() so that it uses the CGL error instead of the AGL error; Tim H missed this in his build fix
from earlier.

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m:
1:17 AM Changeset in webkit [15377] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
OPTION text can paint over select element's scrollbar

  • fast/forms/option-text-clip-expected.checksum: Added.
  • fast/forms/option-text-clip-expected.png: Added.
  • fast/forms/option-text-clip-expected.txt: Added.
  • fast/forms/option-text-clip.html: Added.

WebCore:

Reviewed by Maciej.

Fix for: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9813
OPTION text can paint over select element's scrollbar

Test: fast/forms/option-text-clip.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject): When calculating the clip to apply to the button text, also consider padding. In the future, we may have separate renderers for the text part, and the arrow part of the control, and then the separation should be natural. For now, we use padding.
1:12 AM Changeset in webkit [15376] by ggaren
  • 23 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Implemented a vast number of renames and comment clarifications suggested during API review.


JSInternalString -> JSString
JS*Make -> JSValueMake*, JSObjectMake*
JSTypeCode -> JSType
JSValueIsInstanceOf -> JSValueIsInstanceOfConstructor (reads strangely well in client code)
JSGC*Protect -> JSValue*Protect
JS*Callback -> JSObject*Callback
JSGetPropertyListCallback -> JSObjectAddPropertiesToListCallback
JSPropertyEnumeratorGetNext -> JSPropertyEnumeratorGetNextName
JSString* ->

JSStringCreateWithUTF8CString, JSStringGetUTF8CString,
JSStringGetMaximumUTF8CStringSize JSStringIsEqualToUTF8CString,
JSStringCreateWithCFString, JSStringCopyCFString, JSStringCreateWithCharacters.


  • Changed functions taking a JSValue out arg and returning a bool indicating whether it was set to simply return a JSValue or NULL.


  • Removed JSStringGetCharacters because it's more documentation than code, and it's just a glorified memcpy built on existing API functionality.


  • Moved standard library includes into the headers that actually require them.


  • Standardized use of the phrase "Create Rule."


  • Removed JSLock from make functions that don't allocate.


  • Added exception handling to JSValueToBoolean, since we now allow callback objects to throw exceptions upon converting to boolean.


  • Renamed JSGCCollect to JSGarbageCollect.

Jul 11, 2006:

11:04 PM Changeset in webkit [15375] by thatcher
  • 2 edits in tags/WebKit-521.16.2/WebKit

Build fix and versioning.

11:02 PM Changeset in webkit [15374] by thatcher
  • 1 copy in tags/WebKit-521.16.2

New good tag.

11:02 PM Changeset in webkit [15373] by thatcher
  • 1 delete in tags/WebKit-521.16.2

Bad tag.

11:01 PM Changeset in webkit [15372] by thatcher
  • 1 copy in tags/WebKit-521.16.2/WebKit-521.16.1

new tag (part 2)

11:01 PM Changeset in webkit [15371] by thatcher
  • 1 add in tags/WebKit-521.16.2

New tag.

11:00 PM Changeset in webkit [15370] by thatcher
  • 1 edit in trunk/WebKit/Plugins/WebBaseNetscapePluginView.m

More build fixes for the deprecated AGL functions.

9:26 PM Changeset in webkit [15369] by thatcher
  • 1 edit in trunk/WebKitTools/Drosera/debugger.js

Forgot to commit a file this morning that actually makes the Drosera console open. Thanks bdash!

8:31 PM Changeset in webkit [15368] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Windows build fix. Reviewed by NOBODY.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Added JSHTMLOptionsCollection.cpp/h and JSHTMLOptionsCollectionCuston.cpp. VC++ Express realphabetized the file list.
7:55 PM Changeset in webkit [15367] by darin
  • 10 edits in trunk/WebCore

Reviewed by Adele.

  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::index): Use a const reference for the list items, so we don't have to copy a vector.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectedIndex): Ditto. (WebCore::HTMLSelectElement::setSelectedIndex): Ditto. (WebCore::HTMLSelectElement::length): Ditto. (WebCore::HTMLSelectElement::remove): Ditto. (WebCore::HTMLSelectElement::value): Ditto. (WebCore::HTMLSelectElement::setValue): Ditto. (WebCore::HTMLSelectElement::stateValue): Ditto. (WebCore::HTMLSelectElement::restoreState): Ditto. (WebCore::HTMLSelectElement::appendFormData): Ditto. (WebCore::HTMLSelectElement::optionToListIndex): Ditto. (WebCore::HTMLSelectElement::listToOptionIndex): Ditto. (WebCore::HTMLSelectElement::recalcListItems): Made const, with the appropriate fields mutable. (WebCore::HTMLSelectElement::reset): Use a const reference for the list items, so we don't have to copy the vector. Remove the call to setSelectionChanged for the RenderMenuList case. (WebCore::HTMLSelectElement::notifyOptionSelected): Ditto, on both counts. (WebCore::HTMLSelectElement::defaultEventHandler): Call focus() before showing the pop-up.
  • html/HTMLSelectElement.h: The RenderMenuList class is no longer a friend. Changed the listItems function to return a const reference to the vector so it no longer copies the vector. Removed the const_cast to the call to recalcListItems and changed it to a const member function. Made m_recalcListItems mutable.
  • rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::updateFromElement): Removed an unnecessary call to recalcListItems, which is called automatically. Use a const reference for the list items so we don't have to copy a vector. (WebCore::DeprecatedRenderSelect::layout): Ditto. (WebCore::DeprecatedRenderSelect::selectionChanged): Ditto. (WebCore::DeprecatedRenderSelect::updateSelection): Ditto.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): Updated for renamed data members. (WebCore::RenderMenuList::createInnerBlock): Ditto. (WebCore::RenderMenuList::addChild): Ditto. (WebCore::RenderMenuList::removeChild): Ditto. (WebCore::RenderMenuList::setStyle): Ditto. Also removed code to set the style on the pop-up menu, because it's created with the correct style and destroyed before it a style change could occur. (WebCore::RenderMenuList::updateFromElement): Rearranged code to compute the maximum width in a simpler fashion, and to not bother trying to maintain the "selected" flags on the elements, since the HTMLSelectElement class takes care of that. Store the width as an int. Call setText to set the text based on the selected element's option text. (WebCore::RenderMenuList::paintObject): Don't check m_inner when setting up the clip -- always set up the clip. (WebCore::RenderMenuList::calcMinMaxWidth): Use m_optionsWidth directly instead of calling ceilf on m_longestWidth. (WebCore::RenderMenuList::showPopup): Don't use m_popupMenu to store the menu -- instead keep the pointer in a local variable. Get the selected index from the HTMLSelectElement. (WebCore::RenderMenuList::valueChanged): Call HTMLSelectElement::setSelectedIndex to do most of the work.
  • rendering/RenderMenuList.h: Renamed m_inner to m_innerBlock. Removed m_popupMenu, m_size, m_selectionChanged, and m_selectedIndex. Renamed m_longestWidth to m_optionsWidth and changed it to be an int. Removed unneeded override of removeLeftoverAnonymousBoxes function. Removed unneeded selectionChanged, setSelectionChanged, updateSelection, and hasPopupMenu functions. Removed extra includes.
  • rendering/RenderPopupMenu.cpp: (WebCore::RenderPopupMenu::populate): Change to iterate the list items instead of iterating all children of the select node.
  • rendering/RenderPopupMenu.h: Renamed getRenderMenuList to menuList.
  • rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::populate): Moved code to clear and create the pop-up here from the caller. Removed an extra retain that would cause the NSPopUpButtonCell to leak. (WebCore::RenderPopupMenuMac::showPopup): Removed unnecessary code to create the pop-up, which is now in populate, and also the call to the clear function, for the same reason. Reorganized code to make it a bit more readable. Removed an unnecessary if to check if frame is nil. Used a RefPtr to make sure we don't make a call on a frame after it's deleted. As part of the reorganization fixed a problem where we'd retain the event and then return early without releasing it in one case. (WebCore::RenderPopupMenuMac::addSeparator): Tweaked a little. (WebCore::RenderPopupMenuMac::addGroupLabel): Grouped all the code to manage the NSMenu at the bottom of the function. (WebCore::RenderPopupMenuMac::addOption): Ditto.
7:21 PM Changeset in webkit [15366] by justing
  • 14 edits in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

  • editing/deleting/delete-after-span-ws-001-expected.checksum:
  • editing/deleting/delete-after-span-ws-001-expected.png:
  • editing/deleting/delete-after-span-ws-002-expected.checksum:
  • editing/deleting/delete-after-span-ws-002-expected.png:
  • editing/deleting/delete-after-span-ws-003-expected.checksum:
  • editing/deleting/delete-after-span-ws-003-expected.png:
  • editing/deleting/delete-block-merge-contents-010-expected.checksum:
  • editing/deleting/delete-block-merge-contents-010-expected.png:
  • editing/deleting/merge-unrendered-space-expected.checksum:
  • editing/deleting/merge-unrendered-space-expected.png:

WebCore:

Reviewed by levi


<rdar://problem/4620686>
REGRESSION: Mispelling markers are still displayed when using the delete key to place caret into a misspelled word

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedSelection): Remove markers from newAdjacentWords even if oldAdjacentWords is equal to newAdjacentWords. This happens during a deletion.
5:45 PM Changeset in webkit [15365] by thatcher
  • 2 edits in trunk/WebCore/bindings/objc

better build fix since other projects that include DOMPrivate.h can't included JavaScriptCore/npruntime.h.

5:40 PM Changeset in webkit [15364] by tomernic
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (build fix)

  • bindings/objc/DOMPrivate.h: Don't @class NPObject; that breaks files that actually #import <JavaScriptCore/npruntime.h>, since the NPObject there is of a different type. Also clarified a highly misleading comment from my last commit. I meant to clarify the comment before landing.
5:27 PM Changeset in webkit [15363] by andersca
  • 2 edits
    3 adds in trunk/WebCore

2006-07-12 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9635
REGRESSION: Crash when adding to cart at <​http://www.yemeksepeti.com/>


  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Don't load external scripts if the parser is stopped.


  • manual-tests/open-close-tokenizer-crash.html: Added.
  • manual-tests/resources/empty-file.js: Added.
  • manual-tests/resources/open-close-tokenizer-crash.html: Added. Add manual test.
5:00 PM Changeset in webkit [15362] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Kevin and Tim O

  • added support for creating a selection image with white text
  • WebView/WebDocumentPrivate.h: added -selectionImageForcingWhiteText: and -selectionImageRect to the private <WebDocumentSelection> protocol
  • Misc/WebSearchableTextView.m: (-[NSString selectionImageForcingWhiteText:]): added stub for this new method to this obsolete class to satisfy the compiler (-[NSString selectionImageRect]): ditto


  • WebView/WebHTMLView.m: (-[WebHTMLView _selectionDraggingImage]): now calls -selectionImageForcingWhiteText:NO instead of just -selectionImage (-[WebHTMLView _selectionDraggingRect]): now calls selectionImageRect, to which the implementation moved (-[WebHTMLView selectionImageForcingWhiteText:]): implemented this new method by calling through to new bridge method selectionImageForcingWhiteText: (-[WebHTMLView selectionImageRect]): implemented this new method by using existing _selectionDraggingRect implementation


  • WebView/WebPDFView.m: (-[WebPDFView selectionImageForcingWhiteText:]): implemented by using code that was formerly in Safari (-[WebPDFView selectionImageRect]): implemented by returning selectionRect
4:59 PM Changeset in webkit [15361] by sullivan
  • 15 edits in trunk/WebCore

Reviewed by Kevin, Timo O, Brady, Darin, and Hyatt (whee!)

  • added support for creating a selection image with white text
  • rendering/RenderObject.h: (WebCore::): add PaintRestriction enum (WebCore::RenderObject::PaintInfo::PaintInfo): add forceWhiteText boolean to PaintInfo struct
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): replaced m_selectionOnly bool with m_paintRestriction, which also handles forcing the text to white
  • page/Frame.cpp: (WebCore::Frame::paint): updated to use & pass m_paintRestriction where it used to use & pass just m_selectionOnly
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::selectionImage): now takes forceWhiteText parameter, stored in FramePrivate as part of PaintRestriction
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge selectionImageForcingWhiteText:]): renamed from selectionImage, now takes forceWhiteText parameter, which is passed down into Frame
  • rendering/RenderLayer.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paint): use a PaintRestriction value where we used to use a selectionOnly bool (WebCore::RenderLayer::paintLayer): ditto; also stores forceWhiteText in PaintInfo struct
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasMarker::draw): updated for changed signature of PaintInfo constructor
  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::drawMaskerContent): ditto
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::drawPatternContentIntoTile): ditto
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): paint with white text color if forceWhiteText is set in PaintInfo struct
4:58 PM Changeset in webkit [15360] by tomernic
  • 18 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoff.

Test case for <​http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

  • plugins/netscape-dom-access-expected.checksum: Added.
  • plugins/netscape-dom-access-expected.png: Added.
  • plugins/netscape-dom-access-expected.txt: Added.
  • plugins/netscape-dom-access.html: Added.

WebCore:

Reviewed by Anders.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

  • html/HTMLPlugInElement.h: Just import JSC headers on Mac. The NPObject and Bindings::Instance stuff is only used on Mac anyway. Changed APPLE to PLATFORM(MAC). Added m_NPObject ivar.
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): Initialize the NPObject. (WebCore::HTMLPlugInElement::~HTMLPlugInElement): Release the NPObject when the element is destroyed. (WebCore::HTMLPlugInElement::createNPObject): Creates an NPObject for the element. (WebCore::HTMLPlugInElement::getNPObject): Returns the NPObject for the element, creating and caching it if necessary.
  • html/HTMLAppletElement.h: Changed APPLE to PLATFORM(MAC).
  • html/HTMLAppletElement.cpp: ditto
  • html/HTMLEmbedElement.h: ditto
  • html/HTMLEmbedElement.cpp: ditto
  • html/HTMLObjectElement.h: ditto
  • html/HTMLObjectElement.cpp: ditto
  • bindings/objc/DOMPrivate.h: Added -[DOMElement _NPObject].
  • bindings/objc/DOM.mm: (-[DOMElement _NPObject]): Returns the NPObject for the element. Since this is only needed by the Netscape plug-in API, you can only get the NPObject for applet, embed, and object elements.

WebKit:

Reviewed by Geoff.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9843>:
Give Netscape plug-ins access to their own DOM element

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView dealloc]): Release DOM element. (-[WebBaseNetscapePluginView getVariable:value:]): Return NPObject for plugin DOM element.
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Now takes a DOMElement, in much the same way that WebKit plug-in views take a DOMElement.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]): Pass DOMElement to Netscape plug-ins. (-[WebFrameBridge viewForJavaAppletWithFrame:attributeNames:attributeValues:baseURL:DOMElement:]): ditto
4:32 PM Changeset in webkit [15359] by adele
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Tests for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9861
REGRESSION: Can't dynamically change list box to popup

  • fast/forms/select-change-listbox-to-popup-expected.checksum: Added.
  • fast/forms/select-change-listbox-to-popup-expected.png: Added.
  • fast/forms/select-change-listbox-to-popup-expected.txt: Added.
  • fast/forms/select-change-listbox-to-popup.html: Added.
  • fast/forms/select-change-popup-to-listbox.html:

WebCore:

Reviewed by Hyatt.


and updated fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

The original fix for 9859 was in the renderer, and I think we can catch the change
earlier in the element to detach and reattach.

I also did some cleanup to remove the PopupButton code path from DeprecatedRenderSelect

Test: fast/forms/select-change-listbox-to-popup.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the new attribute value is going to require us to change from listbox to popup or vice versa, and we're already attached, then detach and reattach to create the correct renderer. If we're not attached, then we'll create the correct renderer when we attach. (WebCore::HTMLSelectElement::recalcStyle): Updated shouldUseMenuList since it no longer takes a RenderStyle. (WebCore::HTMLSelectElement::isKeyboardFocusable): ditto. (WebCore::HTMLSelectElement::isMouseFocusable): ditto. (WebCore::HTMLSelectElement::createRenderer): ditto. (WebCore::HTMLSelectElement::setRecalcListItems): ditto. (WebCore::HTMLSelectElement::reset): ditto. (WebCore::HTMLSelectElement::notifyOptionSelected): ditto. (WebCore::HTMLSelectElement::defaultEventHandler): ditto.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::shouldUseMenuList): This method no longer takes a RenderStyle. That was leftover from when we used to use the appearance to determine whether or not to use the new menu list implementation.
  • rendering/DeprecatedRenderSelect.h: Removed PopupButton code path.
  • rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::updateSelection):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): Backed out previous fix since this is now done in HTMLSelectElement.
3:35 PM Changeset in webkit [15358] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi & thatcher


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/selection/subframe-with-selection-expected.checksum: Added.
  • editing/selection/subframe-with-selection-expected.png: Added.
  • editing/selection/subframe-with-selection-expected.txt: Added.
  • editing/selection/subframe-with-selection.html: Added.

WebKit:

Reviewed by levi & thatcher


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9642>
GMail Editor: Operations that use drop down menus blow away the selection


  • WebView/WebHTMLView.m: (-[NSArray maintainsInactiveSelection]): Maintain an inactive selection when resigning as first responder if the selection is editable or if the WebView tells us to.
  • WebView/WebView.m: (-[WebView maintainsInactiveSelection]): Just because a WebView is editable doesn't mean selections inside subframes will be. Return NO by default.
3:13 PM Changeset in webkit [15357] by thatcher
  • 1 copy in tags/WebCore-315.14.5/WebCore

Tag for WebCore 315.14.5 (part 2 of 2.)

3:13 PM Changeset in webkit [15356] by thatcher
  • 1 add in tags/WebCore-315.14.5

Tag for WebCore 315.14.5 (part 1 of 2.)

3:13 PM Changeset in webkit [15355] by thatcher
  • 1 delete in tags/WebCore-===

bad tag.

3:13 PM Changeset in webkit [15354] by thatcher
  • 1 delete in tags/WebCore-315.14.4/WebCore/WebCore

bad tag.

3:12 PM Changeset in webkit [15353] by thatcher
  • 1 copy in tags/WebCore-315.14.4/WebCore/WebCore

Tag for WebCore 315.14.4 (part 2 of 2.)

3:11 PM Changeset in webkit [15352] by thatcher
  • 1 add in tags/WebCore-===

Tag for WebCore === (part 1 of 2.)

3:10 PM Changeset in webkit [15351] by thatcher
  • 2 edits in branches/Safari-1-3-branch/WebCore

Versioning

3:08 PM Changeset in webkit [15350] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-07-06 Adele Peterson <​adele@apple.com>

Reviewed by Tim Hatcher.

  • Speculative fix for <rdar://problem/4605532> unrepro crash at cnn.com after upgrading to 10.4.7 (but happening with $
  • khtml/khtmlview.cpp: (KHTMLView::layout): Ref's the view during layout, since a recalcStyle could cause the view to $ If we get back from recalcStyle, and there's only one ref, return early since the the view will be deleted when we exi$
  • khtml/khtmlview.h: (KHTMLView::hasOneRef): Added.
2:42 PM Changeset in webkit [15349] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

  • fast/forms/select-change-popup-to-listbox-expected.checksum: Added.
  • fast/forms/select-change-popup-to-listbox-expected.png: Added.
  • fast/forms/select-change-popup-to-listbox-expected.txt: Added.
  • fast/forms/select-change-popup-to-listbox.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9859
REGRESSION: Can't dynamically change popup to list box

Test: fast/forms/select-change-popup-to-listbox.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): If the select element has the multiple property set, or has a size > 1, then it really should be a list box, so we detach and attach the element so it creates the correct type of renderer.
2:31 PM Changeset in webkit [15348] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Beth Dakin and Tim Omernick

  • fixed <rdar://problem/4622794> HiDPI: dragging the selection in Safari can show pixel cracks at non-integral scale factors
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::imageFromRect): round image rect in window coordinate space
2:30 PM Changeset in webkit [15347] by thatcher
  • 1 copy in tags/WebCore-418.20.1/WebCore

New tag (part 2).

2:28 PM Changeset in webkit [15346] by thatcher
  • 1 add in tags/WebCore-418.20.1

Tag for WebCore 418.20.1 (part 1 of 2.)

2:23 PM Changeset in webkit [15345] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:08 PM Changeset in webkit [15344] by thatcher
  • 2 edits in tags/WebKit-521.16.1/WebKit

Build fix.

2:06 PM Changeset in webkit [15343] by thatcher
  • 1 copy in tags/WebKit-521.16.1/WebKit

New tag (part 2)

2:05 PM Changeset in webkit [15342] by thatcher
  • 1 add in tags/WebKit-521.16.1

New tag.

1:58 PM Changeset in webkit [15341] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4622748> WebKit now uses deprecated AGL functions

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView _createWindowedAGLContext]): aglSetDrawable() is deprecated in AGL 3.0. Use aglSetWindowRef() instead. (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): aglSetOffScreen() is deprecated in AGL 3.0. Use CGLSetOffScreen(), which does the same thing.
12:07 PM Changeset in webkit [15340] by ap
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

The fix itself was landed on 2006-07-09, but I forgot about the test.

  • http/tests/misc/xhtml-expected.txt: Added.
  • http/tests/misc/xhtml.php: Added.
11:54 AM Changeset in webkit [15339] by bdakin
  • 4 edits in trunk/LayoutTests

Reviewed by Adele.

Adele checked in new results for this test when you could style
selects, but the styling of selects is turned off for now, so back
to the original results.

  • fast/forms/001-expected.checksum:
  • fast/forms/001-expected.png:
  • fast/forms/001-expected.txt:
11:40 AM Changeset in webkit [15338] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Adding the radar to a change.

11:21 AM Changeset in webkit [15337] by ap
  • 5 edits
    2 adds in trunk

Reviewed by Tim O.

WebKit:

  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]): Remove the early return when requesting an invalid (unsupported) URL.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginInvoke): treat getURL() with one parameter as if the second parameter were NULL - should open a new stream and deliver the data to the current instance.

LayoutTests:

  • plugins/get-empty-url-expected.txt: Added.
  • plugins/get-empty-url.html: Added.
11:13 AM Changeset in webkit [15336] by thatcher
  • 6 edits
    4 adds in trunk/WebKitTools

Reviewed by Darin.

Bug 9598: [Drosera] add a JavaScript evaluator console
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9598

  • Drosera/DebuggerApplication.h:
  • Drosera/DebuggerApplication.m: (-[DebuggerApplication knownServers]):
  • Drosera/DebuggerDocument.h:
  • Drosera/DebuggerDocument.m: (-[WebScriptObject evaluateScript:inCallFrame:]): (-[WebScriptObject showConsole:]): (-[WebScriptObject toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): (-[WebScriptObject toolbarDefaultItemIdentifiers:]): (-[WebScriptObject toolbarAllowedItemIdentifiers:]): (-[WebScriptObject webView:createWebViewWithRequest:]): (-[WebScriptObject webViewShow:]): (-[WebScriptObject webViewAreToolbarsVisible:]): (-[WebScriptObject webView:setToolbarsVisible:]): (-[WebScriptObject webView:setResizable:]): (-[WebScriptObject webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject scriptConfirmSheetDidEnd:returnCode:contextInfo:]): (-[WebScriptObject webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:]): (-[WebScriptObject webView:windowScriptObjectAvailable:]): (-[WebScriptObject webView:didFinishLoadForFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]):
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Images/console.png: Added.
  • Drosera/console.css: Added.
  • Drosera/console.html: Added.
  • Drosera/console.js: Added.
11:02 AM Changeset in webkit [15335] by spadma
  • 2 edits
    1 add in S60/trunk/WebKit

2006-07-11 zalan <​zbujtas@gmail.com>

Reviewed by Sachin/David. Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9401

Fix resource file directories. Missing #include <data_caging_paths.hrh>


8:00 AM Changeset in webkit [15334] by zbujtas
  • 2 edits in S60/trunk

2006-07-07 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com.

  • S60Internals/S60Headers.zip: data_caging_paths to \epoc32\include


Fix for:


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9776

7:21 AM Changeset in webkit [15333] by zbujtas
  • 2 edits in S60/trunk

2006-07-07 brmorris <​bradley.morrison@nokia.com>

Reviewed by ​zbujtas@gmail.com

12:51 AM Changeset in webkit [15332] by thatcher
  • 5 edits in trunk/WebKitTools

Reviewed by a tired Geoff.

Bug 9597: [Drosera] hook up the variables table to show stack variables
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9597

  • Drosera/DebuggerDocument.m: (-[WebScriptObject isSelectorExcludedFromWebScript:]): (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): (-[WebScriptObject localScopeVariableNamesForCallFrame:]): (-[WebScriptObject valueForScopeVariableNamed:inCallFrame:]): (-[WebScriptObject webView:didReceiveTitle:forFrame:]): (-[WebScriptObject webView:didLoadMainResourceForDataSource:]): (-[WebScriptObject webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptObject webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptObject webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/debugger.css:
  • Drosera/debugger.html:
  • Drosera/debugger.js:
12:30 AM Changeset in webkit [15331] by tomernic
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9844>:
Add DOM access test to DumpRenderTree's Netscape plug-in

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (testDOMAccess): (pluginInvoke):
Note: See TracTimeline for information about the timeline view.