Timeline



Oct 16, 2006:

5:51 PM Changeset in webkit [22371] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin.

Fix: <rdar://problem/4758923> <select> menu text doesn't draw right
aligned on right-to-left sites

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Pass appropriate styles to CreateWindowEx so that we get a left-aligned scrollbar in RTL popups. (WebCore::PopupMenu::drawItem): Set text to be right-aligned and draw RTL when direction:rtl is set. (WebCore::PopupWndProc): Add 1px of vertical height to each menu item to match RenderListBox.
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Draw the dropdown button on the left when in RTL. (WebCore::RenderThemeWin::adjustMenuListStyle): Set padding to allow for the dropdown button being on the left in RTL.
5:48 PM Changeset in webkit [17074] by justing
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

  • editing/execCommand/nsresponder-indent-expected.checksum: Added.
  • editing/execCommand/nsresponder-indent-expected.png: Added.
  • editing/execCommand/nsresponder-indent-expected.txt: Added.
  • editing/execCommand/nsresponder-indent.html: Added.
  • editing/execCommand/nsresponder-outdent-expected.checksum: Added.
  • editing/execCommand/nsresponder-outdent-expected.png: Added.
  • editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • editing/execCommand/nsresponder-outdent.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

Added Frame and bridge methods.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge indent]): (-[WebCoreFrameBridge outdent]):
  • page/Frame.cpp: (WebCore::Frame::indent): (WebCore::Frame::outdent):
  • page/Frame.h:

WebKit:

Reviewed by harrison


<rdar://problem/3655385>
Editing: -indent: method unimplemented

  • WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in richly editable areas. (-[NSArray indent:]): (-[NSArray outdent:]):
5:35 PM Changeset in webkit [17073] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Removed unecessary global specifiers.

  • kjs/math_object.cpp: (MathFuncImp::callAsFunction):
5:10 PM Changeset in webkit [22370] by lamadio
  • 2 edits in branches/WindowsMerge/WebKitWin
4:12 PM Changeset in webkit [17072] by kmccullo
  • 2 edits in trunk/JavaScriptCore

Reviewed by John.

Fixes a compile order issue for testkjs on win.

2:57 PM Changeset in webkit [22369] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Added forgotten <rdar://problem/4710456> reference to old entry.

2:54 PM Changeset in webkit [22368] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Forgot to save these changes John suggested before checking in.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::drawItem):
2:52 PM Changeset in webkit [22367] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Fix: <rdar://problem/4709480> Implement option groups
Fix: <rdar://problem/4785693> Use CG to draw popup menu items
Fix: <rdar://problem/4709487> Implement separators in <select> popups
Fix: <rdar://problem/4709358> Move CreateWindowEx calls out of PopupMenu constructor

  • platform/win/PopupMenuWin.cpp: Added some now-required #includes, moved some constants into the WebCore namespace. (WebCore::PopupMenu::PopupMenu): Moved CreateWindowEx calls into PopupMenu::show(). (WebCore::PopupMenu::show): Pass LBS_OWNERDRAWFIXED to CreateWindowEx to assume responsibility for drawing menu itesm. Removed call to set the font on the popup menu, as CG will take care of this. (WebCore::addString): Added to help with the PopupMenu::add* methods. (WebCore::PopupMenu::addOption): Use addString. (WebCore::PopupMenu::addGroupLabel): Ditto, and moved from TemporaryLinkStubs.cpp. (WebCore::PopupMenu::addSeparator): Ditto. (WebCore::PopupMenu::down): Skip items that are not enabled <option> elements, and tell the popup menu to set the selection to the element we end up on. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::drawItem): Added. This is the method that is called to draw each item in the menu. (WebCore::PopupWndProc): Add cases for WM_MEASUREITEM and WM_DRAWITEM messages (required now that we're drawing the menu items ourselves). In the cases for arrow key presses, return -2 to signify that we're handling all aspects of changing the selection.
  • platform/win/TemporaryLinkStubs.cpp: Removed PopupMenu::addSeparator and PopupMenu::addGroupLabel.
2:44 PM Changeset in webkit [17071] by aroben
  • 4 edits in trunk/WebCore

Reviewed by John.

More menulist cleanup/tweaking.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index' parameter to 'optionIndex' for clarity. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over items that are not enabled <option> elements when using arrow keys, and make sure we pass an option index to setSelectedIndex.
  • platform/PopupMenu.h: (WebCore::PopupMenu::setWasClicked): Specify default argument.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from option text before setting the control text so that options within <optgroup>s don't appear indented in the actual control.
1:52 PM Changeset in webkit [17070] by weinig
  • 9 edits in trunk/WebCore

Reviewed by Adam.

Win32 build fix.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
  • bridge/win/FrameWin.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURLRequest): (WebCore::ServeSynchronousRequest): (WebCore::CheckIfReloading): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (CachedResource::setResponse): (CachedResource::setAllData):
  • rendering/RenderThemeWin.cpp: (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):
11:17 AM Changeset in webkit [17069] by brmorris
  • 2 edits in S60/trunk/WebCore

2006-10-16 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fix build break in render_frames.cpp caused by r17066


  • kwq/KWQWidget.h: (QWidget::focusable): Is available when not RD_32_BROWSER
1:29 AM Changeset in webkit [17068] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to
CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned
element is the initial containing block (our RenderView).

Reviewed by mjs

Test cases added to fast/block/positioning for quirks and strict modes.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteVertical):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
1:27 AM Changeset in webkit [17067] by hyatt
  • 8 adds in trunk/LayoutTests/fast/block/positioning

Add test cases for bug 9347.

Oct 15, 2006:

7:00 PM Changeset in webkit [17066] by zbujtas
  • 7 edits in S60/trunk/WebCore

2006-10-13 sareen <​shyam.sareen@nokia.com>

Reviewed by bujtas <​zbujtas@gmail.com>
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

​http://bugs.webkit.org/show_bug.cgi?id=11281

WARNING: NO TEST CASES ADDED OR CHANGED

  • bridge/WebCoreWidget.h:
  • khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::isFocusable):
  • khtml/rendering/render_frames.cpp:
  • khtml/rendering/render_frames.h:
  • kwq/KWQObjectWidget.cpp:
  • kwq/KWQObjectWidget.h:
6:33 PM Changeset in webkit [17065] by bdash
  • 16 edits in trunk

2006-10-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Anders.

Remove junk (as gcc calls it) after #else clause.

  • wtf/FastMalloc.cpp: (WTF::do_free):

2006-10-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Anders.

Misc Gdk/Linux build fixes.

  • platform/gdk/BrowserExtensionGdk.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/RenderThemeGdk.cpp:
  • platform/gdk/RenderThemeGdk.h: (WebCore::RenderThemeGdk::RenderThemeGdk):
  • platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): (BrowserExtensionGdk::BrowserExtensionGdk): (BrowserExtensionGdk::setTypedIconURL): (BrowserExtensionGdk::setIconURL): (BrowserExtensionGdk::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CacheObjectExpiresTime): (WebCore::ResponseURL): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): (FileChooser::disconnectUploadControl):
  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:

2006-10-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Anders.

Make compiler not complain about unused gk. SpinneretWebHost was not setting
initial refcount upon creation, so it is completely bogus.

  • GdkLauncher/main.cpp: (main):
  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::SpinneretWebHost):
3:22 PM Changeset in webkit [17064] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11294
Add getModifierState method to KeyboardEvent

  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/PublicDOMInterfaces.h:
  • dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::getModifierState):
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.idl:
2:44 PM Changeset in webkit [22366] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Geoff, Anders.

Fix crash on startup.

We were crashing somewhere inside Frame::setResourceRequest. I'm not
sure what change made this start crashing.

  • WebFrame.cpp: (WebFrame::receivedResponse): Remove useless calls to Frame::resourceRequest and Frame::setResourceRequest.
1:52 PM Changeset in webkit [22365] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

Merge OpenSource r17056 to TemporaryLinkStubs.cpp.

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
12:20 PM Changeset in webkit [17063] by ap
  • 14 edits
    1 add in trunk/WebCore

2006-10-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Changed PlatformResponse handling for Qt. Don't just store
a QString object containing the data but a new PlatformResponseQt struct
containing data and url, and store it as pointer. This is compatible
to the OS X handling and removes the Qt plaform specific hacks from
CachedCSSStyleSheet, CachedResource & loader.

Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
all methods from TemporaryLinkStubs related to loading in there, and implement
some like ServeSynchronousRequest (yay for xslt handling!).

  • CMakeLists.txt:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • platform/ResourceLoaderClient.h:
  • platform/ResourceLoaderInternal.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::createEmptyDocument):
  • platform/qt/FrameQt.h: (WebCore::QtFrame):
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::loadFinished): (WebCore::FrameQtClientDefault::receivedAllData):
  • platform/qt/FrameQtClient.h:
  • platform/qt/LoaderFunctionsQt.cpp: Added. (WebCore::ServeSynchronousRequest): (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::remove):
  • platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::receivedResponse):
  • platform/qt/TemporaryLinkStubs.cpp:
3:00 AM Changeset in webkit [17062] by rwlbuis
  • 31 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg basic datastructure classes.

Oct 14, 2006:

5:31 PM Changeset in webkit [17061] by oliver
  • 10 edits in trunk/WebCore

2006-10-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Implement some functions in FrameQt / ScrollViewQt.

Added comments what needs to be done in quite some places,
marked some functions as no-ops.

  • CMakeLists.txt:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::bindingRootObject): (WebCore::FrameQt::addPluginRootObject): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo):
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt): (WebCore::FrameQtClientDefault::menubarVisible): (WebCore::FrameQtClientDefault::toolbarVisible): (WebCore::FrameQtClientDefault::statusbarVisible): (WebCore::FrameQtClientDefault::personalbarVisible): (WebCore::FrameQtClientDefault::locationbarVisible):
  • platform/qt/FrameQtClient.h:
  • platform/qt/ImageSourceQt.cpp:
  • platform/qt/RenderThemeQt.cpp:
  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollPointRecursively):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
5:04 PM Changeset in webkit [17060] by oliver
  • 2 edits in trunk/WebKitTools

2006-10-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Oliver.

Add another hanging test, to the "to be skipped" list.

  • DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:
10:38 AM Changeset in webkit [17059] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
<rdar://problem/4783926> REGRESSION: Typing tab key enters no text

The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
of whether frame->view()->advanceFocus() actually changed the focus.

Trivial fix is to preventDefault() only if advanceFocus() returns true.

  • No test is possible because DumpRenderTree sets the WebView preference to tab to links, and that preference cannot be changed dynamically after the webview is initialized. Also, the "tab from last link" is not testable because DumpRenderTree uses the WebView for the whole window, so tabs can't shift focus out of the WebView regardless.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
10:21 AM Changeset in webkit [17058] by weinig
  • 3 edits in trunk/WebKitTools

Reviewed by Anders.

Some fixes to get the Qt BuildSlave to run the LayoutTests.

  • Scripts/build-dumprendertree: No need to call cmake again.
  • Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.
5:53 AM Changeset in webkit [17057] by weinig
  • 10 edits in trunk/WebCore

Reviewed by Mitz.

Fix Qt/Linux build & some little fixes:

  • Adapt to Maciej's FrameLoadRequest changes.
  • Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
  • Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
  • Fix CacheObjectExpiresTime/ResponseIsMultipart signature.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
  • loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
  • platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
  • platform/qt/BrowserExtensionQt.h:
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::openURLRequest):
  • platform/qt/FrameQt.h:
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setURLForRect):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
2:42 AM Changeset in webkit [17056] by bdash
  • 10 edits in trunk/WebCore

2006-10-14 David Carson <​dacarson@gmail.com>

Reviewed by Maciej.

Fix: ​http://bugs.webkit.org/show_bug.cgi?id=11257
Removed Mac platform dependance, changed WebCore functions to
use PlatformResponse/PlatformData rather than NSURLResponse/
NSData.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
  • loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::response): (WebCore::CachedResource::allData):
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::receivedResponse):
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
  • platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
2:39 AM Changeset in webkit [17055] by bdash
  • 7 edits in trunk

2006-10-14 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
networking, and set it for GDK build

  • wtf/Platform.h:

2006-10-14 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
Pure virtual classes require non-pure destructor, who knew.

Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
so that other platforms can also use CURL, if they wish.

Silence compiler warning about unused variable in SharedTimerLinux.cpp

  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/gdk/FrameGdk.h: (WebCore::FrameGdkClient::~FrameGdkClient):
  • platform/gdk/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::downloadTimerCallback):
  • platform/gdk/SharedTimerLinux.cpp: (WebCore::stopSharedTimer):

Oct 13, 2006:

7:44 PM Changeset in webkit [17054] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

Build fix from my last check-in. Make hasOutlineAnnotation() non-
inline so that we don't have to include Document.h in
RenderObject.h
Doing so causes a build failure in WebKit, and it probably isn't a
good idea anyway.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::hasOutlineAnnotation):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasOutline):
6:37 PM Changeset in webkit [17053] by ggaren
  • 3 edits
    2 adds in trunk/WebKitSite

Reviewed by Beth.


Split build, run, and debug steps into separate pages. Darin recommended
this a while back.

  • building/build.html:
  • building/checkout.html:
  • building/debug.html: Added.
  • building/run.html: Added.
  • nav.inc:
6:12 PM Changeset in webkit [17052] by bdakin
  • 12 edits in trunk/WebCore

Patch written mostly by Ken Kraisler, but also by me.

Reviewed by Hyatt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
problem/3391162> PDF created by printing should have live
hyperlinks

  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::focusRingBoundingRect):
  • platform/GraphicsContext.h:
  • platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setURLForRect):
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setURLForRect): Implement method to add URL link to PDF document.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of querying the outline width
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): Same as above.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Call the new paintOutline() (WebCore::RenderFlow::paintOutline): Take care of focus ring and pdf url rects, and outline painting.
  • rendering/RenderFlow.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF link to a rectanglular region. (WebCore::RenderObject::paintOutline): Take care of pdf rects as well as focus ring painting.
  • rendering/RenderObject.h: (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the element is a link and we are printing. (WebCore::RenderObject::hasOutline): Returns true is the style has an outline and hasOutlineAnnotation() is true.
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is greater than 0 and outlineStyle is greater than BHIDDEN.
4:58 PM Changeset in webkit [17051] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by ggaren and harrison


<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari


  • editing/pasteboard/4744008-expected.txt: Added.
  • editing/pasteboard/4744008.html: Added.

WebCore:

Reviewed by ggaren and harrison


<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Even though we put nodes in the hash map in pre-order, they don't necessary come out of the iterator that way. If a node is a redundant style span and one of its pruned ancestors comes off the hash map after it, and that ancestor is a redundant style span or font tag, we will try to remove it even though it has already been removed and we'll crash. The test case added with the fix depends on our hash map implementation because it requires that a particular redundant style span come out of the iterator before its parent. So, it may eventually not provide coverage for the fix.
4:56 PM Changeset in webkit [22364] by mjs
  • 5 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

  • split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): (IconLoader::notifyIconChanged):
4:54 PM Changeset in webkit [17050] by mjs
  • 12 edits
    1 add in trunk/WebCore

Reviewed by Darin.

  • split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
  • bridge/win/BrowserExtensionWin.h:
  • page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
  • page/Frame.h:
  • page/FrameLoadRequest.h: Added. (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::lockHistory): (WebCore::FrameLoadRequest::setLockHistory):
  • page/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
4:50 PM Changeset in webkit [17049] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Maciej

  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadDocumentLoader:]): Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can happen when loading a page during a decidePolicyForNavigationAction callback.
4:45 PM Changeset in webkit [17048] by mjs
  • 1 edit
    1 copy in trunk/WebKit

Not reviewed, build fix.


  • icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
4:16 PM Changeset in webkit [17047] by mjs
  • 1 edit
    1 copy in trunk/WebKit

Not reviewed, build fix.


  • icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
3:14 PM Changeset in webkit [22363] by hyatt
  • 5 edits in branches/WindowsMerge/WebCore

Make form controls work in transparency layers.

3:12 PM Changeset in webkit [22362] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Make sure the backing store flushes properly when the theme changes.

3:09 PM Changeset in webkit [17046] by hyatt
  • 4 edits in trunk/WebCore

Transparency layer work.

2:45 PM Changeset in webkit [17045] by spadma
  • 2 edits in S60/trunk/WebKit

2006-10-13 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Don't need to set the focus. The listbox itself will set the focus when receiving key event.
Otherwise, it will cause problem in input. Here is a little explaination: When the form data saving is enabled,
the CControlSelectWidget::FilterContentL is called whenever a 'letter' is committed.
The function calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in
CAknFepManager. If users press the key in a normal speed, there is no problem because there is nothing
for committing. But if users press two keys(not two letters on the same key) very quickly, the second key
will be commited by the SetFocus() of the first key and the cursor in the editbox will move to the third
key position. The result is that it seems not letting you insert some key in the second position.

​http://bugs.webkit.org/show_bug.cgi?id=11192

  • BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::FilterContentL):
2:42 PM Changeset in webkit [17044] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Anders.


  • add a bunch of casts to get this compiling with older Xcode versions


(I used static_cast so it will be easier to find and remove these once we have completely moved
on to a new enough compiler version.)

  • Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView fixWindowPort]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): (-[WebBaseNetscapePluginView _reshapeAGLWindow]): (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
  • WebKit.xcodeproj/project.pbxproj:
2:35 PM Changeset in webkit [17043] by brmorris
  • 2 edits
    1 move in S60/trunk/S60WebUi

2006-10-13 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Updates to reindeer sisx installation.
​http://bugs.webkit.org/show_bug.cgi?id=9435

  • WebUi/install/Reindeer.pkg: Added.
  • WebUi/install/WebUi.pkg: Removed.
  • WebUi/install/buildsis.bat:
2:18 PM Changeset in webkit [17042] by spadma
  • 7 edits in S60/trunk/WebKit

2006-10-13 sareen <​shyam.sareen@nokia.com>

Reviewed by (​Sachin.padma@nokia.com).
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

​http://bugs.webkit.org/show_bug.cgi?id=11281.

  • Plugin/inc/PluginAdapterInterface.h: (MPluginAdapter::SetOptionMenuHandler):
  • Plugin/inc/PluginSkin.h:
  • Plugin/inc/PluginWin.h:
  • Plugin/inc/npapi.h:
  • Plugin/src/PluginSkin.cpp:
  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::IsContentInteractive):
2:04 PM Changeset in webkit [17041] by rwlbuis
  • 11 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg paint server classes.

1:22 PM Changeset in webkit [17040] by ggaren
  • 10 edits
    4 adds in trunk

LayoutTests:

Tests for accessing renderer-dependent properties from a javascript: URL.


  • fast/frames/frame-js-url-clientWidth-expected.txt: Added.
  • fast/frames/frame-js-url-clientWidth.html: Added.
  • fast/frames/iframe-js-url-clientWidth-expected.txt: Added.
  • fast/frames/iframe-js-url-clientWidth.html: Added.

WebCore:

Reviewed by Darin, John.

  • Merged more frame and iframe code
  • Fixed a bug where iframes returned incorrect values for renderer-dependent properties during javascript: loads because they didn't have renderers at load time


PLT insists this is a small performance win. Don't believe its lies.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to width and height, for consistency with the rest of the DOM.
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback queue that gets drained after the render tree is fully constructed. Currently, this is only used for frame loading. (WebCore::ContainerNode::attach):
  • dom/ContainerNode.h:
  • html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from attach() because loading iframes during attach() causes a crash. Moved frame loading logic into insertedIntoDocument(). That's a more logical place for it because document insertion is what triggers frame loading. Made frame loading a post-attach callback, instead of an immediate action, to fix the incorrect values bug. (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon require this call, once I remove the call from WebKit. (WebCore::HTMLFrameElement::setLocation): (WebCore::HTMLFrameElement::width): (WebCore::HTMLFrameElement::height):
  • html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary killing of puppies.
  • html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement (WebCore::HTMLIFrameElement::rendererIsNeeded): (WebCore::HTMLIFrameElement::createRenderer): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach):
  • page/FrameView.h: Removed unused method.
12:21 PM Changeset in webkit [17039] by rwlbuis
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

Force --no-http on Qt/Linux.

12:10 PM Changeset in webkit [17038] by rwlbuis
  • 1 add
    2 deletes in trunk/WebCore/platform/qt

Add PopupMenuQt.cpp, remove RenderPopupMenuQt.*, as per WildFox' request.

11:56 AM Changeset in webkit [17037] by kmccullo
  • 4 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11283
Fixes Qt/Linux and Windows build

  • kjs/DateMath.cpp:
  • kjs/DateMath.h:
  • kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction):
11:17 AM Changeset in webkit [17036] by harrison
  • 12 edits
    4 adds in trunk

LayoutTests:

Reviewed by Justin.

<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

  • editing/style/style-boundary-005.html: Added. Matches steps from bug.
  • editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
  • editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
  • editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

WebCore:

Reviewed by Justin.

<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

Tests added or changed:

  • editing/style/style-boundary-005.html: Added. Matches steps from bug.
  • editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
  • editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
  • editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
  • dom/Text.cpp: (WebCore::Text::splitText): Comment changes.


  • editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): Renamed from isEmptyStyleSpan.


(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
Rename emptySpans local to unstyledSpans.


(WebCore::dummySpanAncestorForNode):
New. To locate Apple style span created when splitting a text node.


(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
of dummy span's parents, rather than traversing up from start and
end locations. Old algorithm would miss empty spans in the bug case.


(WebCore::ApplyStyleCommand::applyInlineStyle):
Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().


(WebCore::ApplyStyleCommand::removeCSSStyle):
Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().


(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
Comment changes.


  • editing/ApplyStyleCommand.h: Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Allow for Apple style span to be unstyled, because old email may have this in the DOM. Use !node->hasChildNodes() instead of !node->firstChild().


  • editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Comment changes.


  • rendering/RenderTreeAsText.cpp: (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::operator<<): Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
11:14 AM Changeset in webkit [17035] by rwlbuis
  • 1 add in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt

Adding a file that should have gone in in r17021, as requested by WildFox.

11:08 AM Changeset in webkit [17034] by adele
  • 6 edits in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build after Adele's popup menu changes.

  • CMakeLists.txt:
  • platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::disconnectUploadControl):
  • platform/qt/PopupMenuQt.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
  • platform/qt/RenderPopupMenuQt.cpp: Removed.
  • platform/qt/RenderPopupMenuQt.h: Removed.
  • platform/qt/RenderThemeQt.cpp:
10:57 AM Changeset in webkit [17033] by kmccullo
  • 3 edits in trunk/WebKitTools

Reviewed by Adam.

Gets JavaScripCore tests running on windows.

  • Scripts/run-javascriptcore-tests:
  • Scripts/webkitdirs.pm:
10:48 AM Changeset in webkit [17032] by kmccullo
  • 3 edits in trunk/WebCore

Reviewed by Darin.

fixed build failure

  • WebCore.xcodeproj/project.pbxproj:
  • loader/mac/WebFrameLoader.mm:
10:31 AM Changeset in webkit [17031] by kmccullo
  • 5 edits in trunk/JavaScriptCore

Reviewed by Adam, Geoff, Darin.

Fixed displaying the UTC offset and time zone string, as well as renamed the GregorianDateTime structure and clean up.

  • ChangeLog:
  • kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
  • kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): (KJS::GregorianDateTime::~GregorianDateTime): (KJS::GregorianDateTime::toTM):
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
  • kjs/date_object.h:
10:22 AM Changeset in webkit [17030] by kmccullo
  • 2 edits in trunk/WebKit

Changed by Darin, reviewed by me.

  • Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on case-sensitive file system.
10:07 AM Changeset in webkit [17029] by darin
  • 14 edits
    1 copy
    1 add in trunk

WebCore:

Reviewed by Adele.

  • converted WebFormState from Objective-C to C++
  • WebCore.exp: Added a new symbol, changed one symbol from C to C++.
  • WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project". Added UChar.h and FrameLoaderTypes.h.
  • loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
  • loader/mac/WebFormState.h: Converted class to C++.
  • loader/mac/WebFormState.mm: Ditto.
  • loader/mac/WebFrameLoader.h:
  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Changed Objective-C WebFormState uses to C++ WebCore::FormState.

WebKit:

Reviewed by Adele.

  • converted WebFormState from Objective-C to C++
  • ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here. We should eventually come up with a more-elegant solution.
  • WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths. Converted many files from Objective-C to Objective-C++. In a later check-in, I'll rename them to .mm instead of .m. Removed C-only warning options for now. In a later check-in I will add these back in a way that omits them for C++.
  • Plugins/WebPluginContainerCheck.m: Updated for header changes.
  • WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category so this file can still be used by Objective-C code (not just Objective-C++).
  • WebView/WebFrame.m: Put WebFrameLoaderClient category in here. (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed enum code for C++ compatibility. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here. (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility. (-[WebFrame _updateHistoryForReload]): Ditto.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto. (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility. (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
  • WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
7:36 AM Changeset in webkit [17028] by adele
  • 5 edits in trunk/WebCore

Reviewed by Maciej.

  • Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
5:56 AM Changeset in webkit [17027] by rwlbuis
  • 23 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg structure classes.

Oct 12, 2006:

11:33 PM Changeset in webkit [17026] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders.

  • fast/forms/listbox-width-change-expected.txt: Added.
  • fast/forms/listbox-width-change-expected.png: Added.
  • fast/forms/listbox-width-change-expected.checksum: Added.
  • fast/forms/listbox-width-change.html: Added.

WebCore:

Reviewed by Anders.


Test: fast/forms/listbox-width-change.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.
10:52 PM Changeset in webkit [22361] by hyatt
  • 10 edits
    2 deletes in branches/WindowsMerge/WebCore

Vote Cairo off the island.

10:49 PM Changeset in webkit [22360] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebFrame.cpp

Remove Cairo files from WebFrame.cpp now that the Cairo paint method is gone.

10:22 PM Changeset in webkit [17025] by mjs
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver.

  • moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (stringByCollapsingNonPrintingCharacters): (-[WebCoreFrameBridge setTitle:]): (-[WebCoreFrameBridge didFirstLayout]): (-[WebCoreFrameBridge notifyIconChanged:]): (-[WebCoreFrameBridge originalRequestURL]): (-[WebCoreFrameBridge isLoadTypeReload]): (-[WebCoreFrameBridge frameDetached]): (-[WebCoreFrameBridge tokenizerProcessedData]): (-[WebCoreFrameBridge receivedData:textEncodingName:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]): (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]): (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]): (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebCoreFrameBridge reportClientRedirectCancelled:]): (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebCoreFrameBridge incomingReferrer]): (-[WebCoreFrameBridge isReloading]): (-[WebCoreFrameBridge handledOnloadEvents]): (-[WebCoreFrameBridge mainResourceURLResponse]): (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
  • loader/mac/LoaderNSURLExtras.h:
  • loader/mac/LoaderNSURLRequestExtras.h: Added.
  • loader/mac/LoaderNSURLRequestExtras.m: Added. (isConditionalRequest): (setHTTPReferrer):
  • loader/mac/WebFrameLoader.mm:
  • loader/mac/WebSubresourceLoader.mm:

WebKit:

Reviewed by Oliver.


  • liberate more WebKit code down to WebCore
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m:
8:53 PM Changeset in webkit [22359] by hyatt
  • 2 edits in branches/WindowsMerge/WebKitWin

Add code that will delete the backing store if our window gets hidden. (We are dependent on the app to make sure we get the message.)

7:29 PM Changeset in webkit [22358] by adele
  • 2 edits in branches/WindowsMerge/WebCore

RS by Geoff.

Renamed uploadControlDetaching to disconnectUploadControl.

  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::disconnectUploadControl):
7:28 PM Changeset in webkit [17024] by adele
  • 7 edits in trunk/WebCore

RS by Geoff.

Renamed menuListIsDetaching to disconnectMenuList,
uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.
These names match similar methods in WebCore a little better.

  • platform/FileChooser.h:
  • platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
  • platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]): (WebCore::FileChooser::disconnectUploadControl):
  • platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
7:13 PM Changeset in webkit [17023] by adele
  • 9 edits in trunk

WebCore:

Reviewed by Maciej.

WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
  • bridge/mac/WebCoreFrameBridge.h:
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.

WebKit:

Reviewed by Maciej.

WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML

Added private delegate method for clients that want access to a PopupMenu's NSMenu.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
  • WebView/WebUIDelegatePrivate.h:
6:39 PM Changeset in webkit [17022] by adele
  • 4 edits in trunk/WebCore

Reviewed by Alice.

  • Fix for <rdar://problem/4707372> After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
  • platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up, in case the RenderMenuList goes away. Also, checks the pointer to the menu list immediately afterwards.
6:33 PM Changeset in webkit [17021] by bdash
  • 3 edits in trunk/WebKitTools

2006-10-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Maciej.

Exclude some tests which crash or hang from Qt/Linux DRT.
These are known to fail, and will be fixed at some point :-)

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::readSkipFile): (WebCore::DumpRenderTree::checkLoaded):
  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.
6:31 PM Changeset in webkit [17020] by bdash
  • 3 edits in trunk/WebCore

2006-10-12 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Maciej.

Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
document.open(); document.write(..); and NO document.close(). On the Qt platform this
leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.

Hmpf, this took me nine hours to debug today.
Result: Couldn't find the real fix, going for a workaround for now.


540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.

  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
  • platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
6:27 PM Changeset in webkit [22357] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Alice.

Fixed a small oversight from the last checkin. The populate method was calling itself,
instead of the newly renamed addItems method.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::populate):
4:04 PM Changeset in webkit [22356] by aroben
  • 3 edits
    1 move
    1 delete in branches/WindowsMerge/WebCore

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

  • WebCore.vcproj/WebCore.vcproj: Move files within project.
  • platform/win/PopupMenuWin.cpp: Moved from rendering/RenderPopupMenuWin.cpp. Rename RenderPopupMenuWin to PopupMenu. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::setPositionAndSize): (WebCore::PopupMenu::addOption): (WebCore::PopupMenu::focusedIndex): New method to get the index of the element that is currently highlighted. This won't always be the same as the selectedIndex because of mouse hot-tracking. (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::registerPopup): (WebCore::PopupWndProc): Use focusedIndex() instead of sending messages to the popup window.
  • platform/win/TemporaryLinkStubs.cpp: Rename RenderPopupMenuWin to PopupMenu. (PopupMenu::addSeparator): (PopupMenu::addGroupLabel):
  • rendering/RenderPopupMenuWin.cpp: Removed.
  • rendering/RenderPopupMenuWin.h: Removed.
  • rendering/RenderThemeWin.cpp: Get rid of createPopupMenu() method.
  • rendering/RenderThemeWin.h: Ditto.
4:02 PM Changeset in webkit [17019] by aroben
  • 13 edits
    3 moves
    2 deletes in trunk/WebCore

Reviewed by Adele.

Move popup menu code out of rendering/ and into platform/.
RenderPopupMenu becomes PopupMenu, the
RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
virtual methods go away, RenderTheme gets to stop worrying about popup
menus, PopupMenu becomes ref-counted, and everyone becomes happy.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • html/HTMLSelectElement.cpp: Remove unnecessary #include.
  • platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp. Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate from RenderMenuList::showPopup/hidePopup. (WebCore::PopupMenu::create): New static creation method to hand back a PassRefPtr<PopupMenu>. (WebCore::PopupMenu::addItems): This platform-independent method should be called by PopupMenu::populate when the platform-specific implementation is ready to receive the menu items. Fixed an ASSERT while I was at it.
  • platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more need for virtual methods. (WebCore::PopupMenu::wasClicked): (WebCore::PopupMenu::setWasClicked): (WebCore::PopupMenu::popupHandle):
  • platform/mac/PopupMenuMac.mm: Moved from rendering/RenderPopupMenuMac.mm. Much renaming ensues. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): Since we don't have our own RenderStyle anymore, just pick up the style from our RenderMenuList. (WebCore::PopupMenu::addOption): Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Rename-fest. (PopupMenu::PopupMenu): (PopupMenu::~PopupMenu): (PopupMenu::clear): (PopupMenu::populate): (PopupMenu::show): (PopupMenu::hide): (PopupMenu::addSeparator): (PopupMenu::addGroupLabel): (PopupMenu::addOption):
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): Use nice new simple PopupMenu::create to make the popup. (WebCore::RenderMenuList::hidePopup):
  • rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a RenderPopupMenu*. (WebCore::RenderMenuList::popup):
  • rendering/RenderPopupMenu.cpp: Removed.
  • rendering/RenderPopupMenu.h: Removed.
  • rendering/RenderPopupMenuMac.h: Removed.
  • rendering/RenderPopupMenuMac.mm: Removed.
  • rendering/RenderPopupMenuWin.h: Removed.
  • rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
  • rendering/RenderTheme.h: Ditto.
  • rendering/RenderThemeMac.h: Ditto.
  • rendering/RenderThemeMac.mm: Ditto.
  • rendering/RenderThemeWin.cpp: Ditto.
  • rendering/RenderThemeWin.h: Ditto.
2:44 PM Changeset in webkit [17018] by adele
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

  • Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Make subtree layouts work for textareas as well as text fields.
1:42 PM Changeset in webkit [17017] by ggaren
  • 7 edits in trunk/JavaScriptCore

Reviewed by Maciej.


Removed JSObjectMakeWithPrototype, clarified some comments. We really
don't want people to manage their own prototypes, so we don't want an
extra function in the API devoted to just that. People can still manage
their own prototypes if they really want by using JSObjectSetPrototype.

  • API/JSClassRef.cpp: (OpaqueJSClass::createNoAutomaticPrototype): (OpaqueJSClass::create):
  • API/JSClassRef.h:
  • API/JSObjectRef.cpp: (JSClassCreate): (JSObjectMake):
  • API/JSObjectRef.h:
  • API/testapi.c: (main):
  • JavaScriptCore.exp:
1:29 PM Changeset in webkit [17016] by rwlbuis
  • 9 edits in trunk/WebCore

Reviewed by MacDome.

Finally found a way to remove our begin() trickery in FrameQt.
The (probably misnamed) Frame::setEncoding() function automatically
calls Frame::receivedFirstData() which calls being on the working
url, which has been passed to didOpenUrl(). Took me some hours
to figure out that the missing charset logic, forced us to do hacks.

1:19 PM Changeset in webkit [17015] by kmccullo
  • 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

Build breakage fix

  • kjs/DateMath.cpp: (KJS::msToTM):
  • kjs/date_object.cpp: (KJS::gmtoffset):
12:49 PM Changeset in webkit [17014] by brmorris
  • 2 edits in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Bradley.
DESC: Replace winscw MemMan.dll with MemMan_sdk.dll if ! -e MemMan.dll

12:22 PM Changeset in webkit [17013] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Bandaid-ing a null-dereference crash until a real fix is made.

  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect):
11:46 AM Changeset in webkit [17012] by brmorris
  • 4 edits in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Generate/check only the correct WebKit icons depending on build flavour
​http://bugs.webkit.org/show_bug.cgi?id=11266

  • group/icons.mk: Work off BROWSER_SDK evar to check/create correct icons.
11:34 AM Changeset in webkit [17011] by aroben
  • 2 edits in trunk/WebKit

2006-10-12 MorganL <​morganl.webkit@yahoo.com>

Reviewed/landed by Adam.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11264
Windows build busted

  • COM/WebFrame.cpp: (WebFrame::receivedResponse):
10:58 AM Changeset in webkit [17010] by kmccullo
  • 5 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Added our own tm struct to have a consistent set of fields, which lets us display the DST offset and timezone strings correctly. Also there is some code cleanup.

  • kjs/DateMath.cpp: (KJS::timeToMS): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::dateToMS): (KJS::msToTM): (KJS::tmToKJStm): (KJS::KJStmToTm):
  • kjs/DateMath.h:
  • kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
  • kjs/date_object.h:
10:10 AM Changeset in webkit [22355] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix (broken by OpenSource r17006)

  • WebFrame.cpp: (WebFrame::receivedResponse):
10:04 AM Changeset in webkit [17009] by brmorris
  • 9 edits
    3 adds in S60/trunk

2006-10-12 brmorris <​thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fixes for GCCE compilation.
​http://bugs.webkit.org/show_bug.cgi?id=9435

8:07 AM Changeset in webkit [17008] by rwlbuis
  • 11 edits in trunk/WebCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg text classes.

5:44 AM Changeset in webkit [17007] by rwlbuis
  • 7 edits in trunk

WebCore:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

WebKitTools:

Reviewed by Maciej.

Specialization of alert() for DumpRenderTree - just log the output, don't show any message box.

4:50 AM Changeset in webkit [17006] by mjs
  • 9 edits in trunk/WebCore

Reviewed by Eric.

  • move m_responseMIMEType out of ResourceRequest, where it doesn't belong
  • page/FramePrivate.h: Add m_responseMIMEType
  • page/ResourceRequest.h: Remove m_responseMIMEType
  • page/Frame.cpp: (WebCore::Frame::setResponseMIMEType): added (WebCore::Frame::responseMIMEType): added (WebCore::Frame::begin): get MIME type from the right place (WebCore::Frame::write): ditto
  • page/Frame.h:
  • bindings/js/kjs_window.cpp: (KJS::createNewWindow): updated to use new Frame methods (KJS::WindowFunc::callAsFunction): ditto
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): ditto (-[WebCoreFrameBridge canProvideDocumentSource]): ditto
  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): ditto
3:36 AM Changeset in webkit [17005] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.


<rdar://problem/4774321> REGRESSION: "Can't find the server" error page contains unstyled text and missing image

We really need some way to test loadHTMLString since it keeps breaking!


  • loader/mac/WebFrameLoader.mm: (-[WebFrameLoader commitProvisionalLoad:]): Set stuff up on the proper data source.
3:22 AM Changeset in webkit [17004] by rwlbuis
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build.

2:36 AM Changeset in webkit [17003] by bdash
  • 6 edits in trunk

2006-10-12 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Update Gdk\Linux build for recent changes, based on Qt code

  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdkClientDefault::FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::~FrameGdkClientDefault): (WebCore::FrameGdkClientDefault::setFrame): (WebCore::FrameGdkClientDefault::openURL): (WebCore::FrameGdkClientDefault::submitForm): (WebCore::FrameGdkClientDefault::receivedResponse): (WebCore::FrameGdkClientDefault::receivedData): (WebCore::FrameGdkClientDefault::receivedAllData): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::createJavaAppletWidget): (FileChooser::create):

2006-10-12 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Also regenerate GdkLauncher makefiles, since not doing that might
lead to mismatch between WebCore and GdkLauncher compiler settings.

  • Scripts/regenerate-makefiles:
2:03 AM Changeset in webkit [22354] by hyatt
  • 12 edits in branches/WindowsMerge

Implement full-blown double buffering.

2:01 AM Changeset in webkit [17002] by hyatt
  • 13 edits in trunk/WebCore

Add more clipping retrieval functionality for widgets.

Note: See TracTimeline for information about the timeline view.