Timeline



Dec 24, 2006:

10:02 AM Changeset in webkit [18412] by ddkilzer
  • 1 edit
    1 delete in trunk/WebKit

2006-12-24 David Kilzer <​ddkilzer@webkit.org>

Removed empty directory.

  • WebKit/Loader: Removed.
8:46 AM Changeset in webkit [18411] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Maciej and Geoff.

  • remove unused member variable m_styleSelectorDirty

No test possible (no functionality change)

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
7:48 AM Changeset in webkit [18410] by weinig
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

  • fast/dom/css-mediarule-deleteRule-update-expected.checksum: Added.
  • fast/dom/css-mediarule-deleteRule-update-expected.png: Added.
  • fast/dom/css-mediarule-deleteRule-update-expected.txt: Added.
  • fast/dom/css-mediarule-deleteRule-update.html: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.checksum: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.png: Added.
  • fast/dom/css-mediarule-insertRule-update-expected.txt: Added.
  • fast/dom/css-mediarule-insertRule-update.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11952
style changes made through CSSMediaRule functions insertRule()
and deleteRule do not show up on the screen

Tests added:

  • fast/dom/css-mediarule-deleteRule-update.html
  • fast/dom/css-mediarule-insertRule-update.html
  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
7:45 AM Changeset in webkit [18409] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Alexey.

Get rid of unused variable.

Dec 23, 2006:

11:39 PM Changeset in webkit [18408] by ap
  • 5 edits in trunk/LayoutTests

​http://bugs.webkit.org/show_bug.cgi?id=9801
fast/encoding/utf-16-big-endian-diffs.html pixel test fails

  • fast/encoding/utf-16-big-endian-expected.checksum:
  • fast/encoding/utf-16-big-endian-expected.png:
  • fast/encoding/utf-16-little-endian-expected.checksum:
  • fast/encoding/utf-16-little-endian-expected.png: Updated the pixel results, which weren't landed with the fix for bug 3297.
11:19 PM Changeset in webkit [18407] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej Stachowiak.


Added --threaded support to run-webkit-tests and DumpRenderTree.


In "threaded" mode, DRT runs a concurrent JavaScript thread with each test,
stressing the thread safety of JavaScriptCore and the JavaScriptCore/WebCore
interface. This is useful for tracking down bugs you might see on a system
configured to use a PAC file.


Ironically, I can proudly state that very few layout tests pass.

  • DumpRenderTree/DumpRenderTree.m: Added javaScriptThread and helper functions for starting and stopping it. (runJavaScriptThread): helper function (startJavaScriptThread): helper function (stopJavaScriptThread): helper function

(dumpRenderTree): Added --threaded command line argument.

  • Scripts/run-webkit-tests: ditto
11:09 PM Changeset in webkit [18406] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11933
REGRESSION: trying to change a property in a computed style declaration results in a crash

Test: fast/dom/computed-style-set-property.html

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): Added a check for null m_impl->stylesheet(). Also, fixed incorrect logic in Dashboard branch - it didn't return in time if removeProperty() raised an exception (credit for noticing this bug goes to Geoff).
7:19 PM Changeset in webkit [18405] by weinig
  • 7 edits in trunk/WebCore

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11940
Bad transparency in some cursor pointer images

  • Resources/northEastResizeCursor.png:
  • Resources/northEastSouthWestResizeCursor.png:
  • Resources/northWestResizeCursor.png:
  • Resources/northWestSouthEastResizeCursor.png:
  • Resources/southEastResizeCursor.png:
  • Resources/southWestResizeCursor.png:
4:48 PM Changeset in webkit [18404] by weinig
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11876
CSSMediaRule functions insertRule and deleteRule don't raise exceptions

  • fast/dom/css-mediarule-functions-expected.txt: Added.
  • fast/dom/css-mediarule-functions.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11876
CSSMediaRule functions insertRule and deleteRule don't raise exceptions

Test added:

  • fast/dom/css-mediarule-functions.html
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSRuleFunc::callAsFunction):
  • css/CSSMediaRule.cpp: add exception handling (WebCore::CSSMediaRule::insertRule): (WebCore::CSSMediaRule::deleteRule):
  • css/CSSMediaRule.h: add ExceptionCode arguments
  • css/CSSMediaRule.idl: un-comment exceptions
10:18 AM Changeset in webkit [18403] by hyatt
  • 1 edit in trunk/LayoutTests/editing/pasteboard/paste-table-002-expected.txt

Update editing/pasteboard/paste-table-002 results now that the two style decl arrays are in sync.

8:19 AM Changeset in webkit [18402] by ddkilzer
  • 3 edits in trunk/LayoutTests

2006-12-23 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Mitz.

Regenerate test results with default fonts installed.

  • svg/custom/js-font-test-expected.png: Regenerated.
  • svg/custom/js-font-test-expected.txt: Regenerated.
4:39 AM Changeset in webkit [18401] by hyatt
  • 3 edits in trunk/WebCore

Fix 11942. The inheritable properties array is duplicated (lame). Make
sure to keep both in sync.

Reviewed by mitz

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::):

Dec 22, 2006:

10:01 PM Changeset in webkit [18400] by bdash
  • 2 edits in trunk/WebKitTools

2006-12-22 Mark Rowe <​bdash@webkit.org>

Reviewed by Brady.

Fix for <rdar://problem/4265976>
prepare-ChangeLog sometimes lists the wrong Objective-C class name for a changed method

  • Scripts/prepare-ChangeLog: Treat @end as the end of both the interface and the method declaration.
6:29 PM Changeset in webkit [22714] by aliceli1
  • 7 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Geoff.

Fixed <rdar://4766681> and <rdar://4766685> concerning editable link behavior

  • Interfaces/IWebPreferences.idl:
  • WebHistoryItem.cpp: (WebHistoryItem::dictionaryRepresentation):
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::initialize): (WebPreferences::editableLinkBehavior): (WebPreferences::setEditableLinkBehavior):
  • WebPreferences.h:
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences):
4:19 PM Changeset in webkit [18399] by ggaren
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.


Test for <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)


Tests an onload handler for a synchronously loaded iframe removing the iframe
from the document.

  • fast/frames/onload-remove-iframe-crash-expected.txt: Added.
  • fast/frames/onload-remove-iframe-crash.html: Added.

WebCore:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::createFrame): Updated to reflect the fact that createChildFrameNamed: now returns a WebCore::Frame* instead of a WebCoreFrameBridge *.
  • page/mac/WebCoreFrameBridge.h:

WebKit:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4871518> Leopard9A321: Crash visiting www.audible.com
(WebCore::FrameLoader::loadSubframe)

  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:ownerElement:allowsScrolling:marginWidth:marginHeight:]):
  • The fix:

Changed to re-fetch the child frame we're trying to load before returning it,
since its onload handler may have removed it from the document. This
allows us to treat a removed frame like a frame that never loaded.


  • Plus some cleanup:
    • Changed to return a WebCore::Frame* instead of a WebFrameBridge *, to simplify some code.
    • Grouped ObjC objects by usage, and moved calls to -release so that they immediately follow the calls that retain.
4:03 PM Changeset in webkit [22713] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-22 Ada Chan <​adachan@apple.com>

Reviewed by Anders.

Build fix.

3:28 PM Changeset in webkit [18398] by hyatt
  • 3 edits in trunk/WebCore

Make sure to actually set the stroke thickness for text decorations.
Covered by bugzilla bug 11921.

Reviewed by mitz

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration):
2:06 PM Changeset in webkit [18397] by thatcher
  • 2 edits in tags/WebCore-521.32.1/WebCore

Versioning

2:04 PM Changeset in webkit [18396] by thatcher
  • 5 edits in tags/WebCore-521.32.1/WebCore

Merging fix r18328 and r18386.

1:52 PM Changeset in webkit [18395] by thatcher
  • 1 copy in tags/WebCore-521.32.1/WebCore

New tag (part 2.)

1:52 PM Changeset in webkit [18394] by thatcher
  • 1 add in tags/WebCore-521.32.1

New tag. (part 1).

12:49 PM Changeset in webkit [22712] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
11:35 AM Changeset in webkit [18393] by zimmermann
  • 33 edits
    5 adds
    1 delete in trunk

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11934

Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList
interface) has live update problems, as the notifyAttributeChange() function
isn't called anywhere. The context param is currently stored per SVGPathSeg,
which is not needed - as it can be done using SVGPathSegList completely. It
wastes memory, that is fixed. In order to get rid of the context param in
SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement*
objects ("context element"). That is done using a new HashMap in the
SVGDocumentExtensions class.

11:26 AM Changeset in webkit [18392] by ap
  • 2 edits in trunk/WebCore

2006-12-22 Mitz Pettel <​mitz@webkit.org>

Reviewed by Beth.

This fixes a bunch of existing pixel tests.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
10:57 AM Changeset in webkit [22711] by sullivan
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin Decker

Renamed stub method name to match change in WebCore

  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords
10:49 AM Changeset in webkit [18391] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Kevin Decker

  • renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition in anticipation of fixing it to work more correctly with grammar checking, where only checking adjacent words isn't good enough.
  • editing/Editor.h: renamed markMisspellingsInAdjacentWords to markMisspellingsAfterTypingToPosition
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::markMisspellingsAfterTyping): updated for name change
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): renamed from markMisspellingsInAdjacentWords and added FIXME comment
9:43 AM Changeset in webkit [18390] by eseidel
  • 3 edits
    16 adds in trunk

2006-12-22 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.

​http://bugs.webkit.org/show_bug.cgi?id=11912
Overriding visibility does not behave as expected.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): allow children to draw when container is visibility='hidden'
8:51 AM Changeset in webkit [18389] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-22 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Steve Winship and Yongjun Zhang.
DESC: TSW ID# SRAY-6WQKA6: Formdataautofill: If the form field contains single or double quotes the SQL query to insert, delete data does not work.
​http://bugs.webkit.org/show_bug.cgi?id=11927

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::NewL): (CFormDataAutoFillStore::ConstructL): (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteDataL): (CFormDataAutoFillStore::InsertDataL): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::OpenTableForUse): (CFormDataAutoFillStore::CloseTableAfterUse): (CFormDataAutoFillStore::CreateFormDataTableL): (CFormDataAutoFillStore::WriteLongTextL): (CFormDataAutoFillStore::ReadLongTextL):
6:11 AM Changeset in webkit [18388] by sullivan
  • 5 edits in trunk/WebKit

Reviewed by Geoff Garen

  • improved concept and implementation of my previous checkin after discussing with Darin
  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (-[WebView setHoverFeedbackSuspended:]): renamed from setIgnoresMouseMovedEvents, and now tells the main WebHTMLView (if any) that this state has changed. Telling just the main WebHTMLView is a bit of an implementation hack. Hopefully someday we can rework the document architecture and make this kind of thing less hacky (but this is following existing customs, so I don't feel too bad) (-[WebView isHoverFeedbackSuspended]): renamed from ignoresMouseMovedEvents
  • WebView/WebHTMLViewInternal.h: declare _hoverFeedbackSuspendedChanged
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): test the webView's state of the hit-tested WebHTMLView rather than self (-[WebHTMLView _hoverFeedbackSuspendedChanged]): generate a fake mouse-moved event, which simulates the mouse moving away from the current element or back over it
1:30 AM Changeset in webkit [18387] by zimmermann
  • 4 edits
    5 adds in trunk

Reviewed by Rob.

Fix SVGPathSeg JS object creation. SVGPathSegList has to return
the actual SVGPathSegLineToAbs/MoveToRel... object instead of a pure
SVGPathSeg JS object.

Dec 21, 2006:

10:06 PM Changeset in webkit [22710] by wallis
  • 1 edit in branches/WindowsMerge/WebKitWin/WebView.cpp

Print by spooling PDF

9:53 PM Changeset in webkit [18386] by bdakin
  • 10 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/4897162> REGRESSION: Attempting to create a
new message in .Mac web mail causes Safari to crash
( KJS::DOMCSSStyleDeclaration::put() + 368 )

This was a regression from my clone-node change. This fix is very
simple.

  • dom/StyledElement.cpp: (WebCore::StyledElement::copyNonAttributeProperties): Must set the data that getInlineStyleDecl() points to instead of setting m_inlineStyleDecl directly. I also changed some variable names.
  • dom/StyledElement.h: Don't need parameter name here.

Layout Tests:

Reviewed by Beth. (Geoff wrote the new test.)

New test for <rdar://problem/4897162>. This also reverts the layout
test changes that were caused by the first rev of the clone-node
style change.

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-expected.checksum:
  • editing/style/remove-underline-expected.png:
  • editing/style/remove-underline-expected.txt:
  • fast/dom/clone-node-style-expected.txt: Added.
  • fast/dom/clone-node-style.html: Added.
9:46 PM Changeset in webkit [22709] by wallis
  • 1 edit in branches/WindowsMerge/WebKitWin/WebView.h

Print by spooling PDF

9:46 PM Changeset in webkit [22708] by wallis
  • 1 edit in branches/WindowsMerge/WebKitWin/Interfaces/IWebViewPrivate.idl

Print by spooling PDF

6:20 PM Changeset in webkit [18385] by bdash
  • 2 edits in trunk/WebKitTools

2006-12-21 Mark Rowe <​bdash@webkit.org>

Reviewed by Tim Hatcher.

​http://bugs.webkit.org/show_bug.cgi?id=11922
Bug 11922: REGRESSION(r17128): Drosera no longer shows local variables in stack frame

  • Drosera/DebuggerDocument.m: (-[WebScriptObject webScriptAttributeKeysForScriptObject:]): Use an anonymous function with function.call to ensure that the properties are being retrieved from the correct scope object.
5:53 PM Changeset in webkit [18384] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

  • fast/events/onsearch-enter-expected.txt: Added.
  • fast/events/onsearch-enter.html: Added.

WebCore:

Reviewed by Geoff.

  • Fix for <rdar://problem/4895716> REGRESSION: Pressing return key in search field doesn't begin search

Test: fast/events/onsearch-enter.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Calls onSearch when handling "Enter". Also removed special case for AppKit search fields, so now the enter event is considered handled here. (WebCore::HTMLInputElement::onSearch): Added. Dispatches search event.
  • html/HTMLInputElement.h: Added onSearch.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::onSearch): Calls onSearch on the node.
5:26 PM Changeset in webkit [18383] by darin
  • 2 edits in trunk/WebKit

Reviewed by Oliver.

  • WebInspector/webInspector/inspector.js: Added default values for the new CSS properties so they don't appear in the inspector when their values are uninteresting.
4:03 PM Changeset in webkit [22707] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:56 PM Changeset in webkit [18382] by sfalken
  • 1 copy in tags/Safari-521.32.7b

New tag.

3:02 PM Changeset in webkit [18381] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Geoff Garen

  • added WebKit support for making a web page temporarily ignore mouse movements
  • WebView/WebViewPrivate.h: declare ignoresMouseMovedEvents and setIgnoresMouseMovedEvents:
  • WebView/WebView.mm: added ignoresMouseMovedEvents boolean field to _private data structure (-[WebView setIgnoresMouseMovedEvents:]): set new boolean field (-[WebView ignoresMouseMovedEvents]): return new boolean field
  • WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): bail out right away if [[self _webView] ignoresMouseMovedEvents]
2:39 PM Changeset in webkit [18380] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady Eidson.


<rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
when creating an iframe from an iframe onload handler

Test for adding an iframe to the document from another iframe's onload handler.

  • fast/loader/iframe-recursive-synchronous-load-expected.txt: Added.
  • fast/loader/iframe-recursive-synchronous-load.html: Added.

WebCore:

Reviewed by Brady Eidson.


Fixed <rdar://problem/4897205> ASSERTION FAILURE in ContainerNode::queuePostAttachCallback
when creating an iframe from an iframe onload handler

I added that assertion to try to "keep things simple," but I've found a
testcase that demonstrates why things need to be complicated.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback):
2:37 PM Changeset in webkit [18379] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-21 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>.
DESC: TSW# SPIO-6W7GCZ: News Ticker dialog: With a not white background, blinking moving between messages.
​http://bugs.webkit.org/show_bug.cgi?id=11881

  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
2:25 PM Changeset in webkit [18378] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-21 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by <​yongjun.zhang@nokia.com>.
DESC: TSW# SPIO-6W7GCZ: News Ticker dialog: With a not white background, blinking moving between messages.
​http://bugs.webkit.org/show_bug.cgi?id=11881

  • BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
12:16 PM Changeset in webkit [18377] by ap
  • 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11919
Allow setting CSS values to null.

WebCore:

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put): (KJS::DOMCSSStyleDeclarationProtoFunc::callAsFunction): Convert null values to null strings.

LayoutTests:

  • fast/dom/css-set-property-exception-expected.txt:
  • fast/dom/css-set-property-exception.html:
11:45 AM Changeset in webkit [18376] by rwlbuis
  • 3 edits
    2 adds in trunk

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=11898
CSSMediaRule functions insertRule and deleteRule assert when called from js in debug builds

Test explicitly for the two media rule functions so it ends up calling callAsFunction.

5:46 AM Changeset in webkit [18375] by lars
  • 15 edits
    19 adds in trunk

Add support for the layoutTestController JavaScript object
to be able to get textOnly dumps.
Added a Qt specific hack to always get the same fonts (the ones
added in this submit) and the same dpi when running the layout tests.
Modified the run-webkit-tests script to also do a comparison to the
Mac generated outputs (by stripping out positioning information).

12:08 AM Changeset in webkit [18374] by bdash
  • 4 edits in trunk

2006-12-21 Mark Rowe <​bdash@webkit.org>

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11888
Bug 11888: REGRESSION (r18320): Web Inspector panes broken

  • WebInspector/webInspector/inspector.js: Use removeProperty to reset a style property to its initial value. Bail out early from updateNodePane if Inspector has not yet been set.

2006-12-21 Mark Rowe <​bdash@webkit.org>

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=11888
Bug 11888: REGRESSION (r18320): Web Inspector panes broken

  • Drosera/debugger.js: Use removeProperty to reset a style property to its initial value.

Dec 20, 2006:

11:53 PM Changeset in webkit [18373] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Land updated results for computed style test.

11:41 PM Changeset in webkit [18372] by hyatt
  • 3 edits in trunk/WebCore

Make sure the execrable match-nearest-mail-blockquote-color CSS property is actually initialized (amazingly
it started off with the value "match", since it wasn't even initialized). Now that it is actually being
initialized and properly copied and assigned to, tests have failed. It seems that we were getting the
behavior of "match" by default, when the initial value was supposed to be "normal."

Because this property really should not exist at all, it's unclear to me what the right solution is here.


  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
  • rendering/RenderStyle.h:
9:43 PM Changeset in webkit [18371] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adam's rubberstamp

Accidentally left a logging channel on in my checkin

  • platform/Logging.cpp: (WebCore::):
8:13 PM Changeset in webkit [22706] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Mark Rowe.

Fix: <rdar://4895655> Status bar doesn't display correct text when
WebView is scrolled.

  • WebView.cpp: (WebView::handleMouseEvent): Convert the event coordinates to document coordinates before calling elementAtPoint.
5:42 PM Changeset in webkit [18370] by zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Fix removeItem recursively calling itself (!). It was meant to call m_vector.remove(index)
not removeItem(index, ec). This bug is in SVN for quite some time now :-)

5:29 PM Changeset in webkit [18369] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4893376> REGRESSION: Crash occurs at WebCoreFrameBridge fontForSelection: when drag selecting from a line break


No layout test added because crash only happens in path where editing window is key,
which is never the case for the automated tests.

  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge fontForSelection:]): Add nil check of fontForSelection() result.
4:53 PM Changeset in webkit [18368] by zimmermann
  • 6 edits
    4 adds in trunk/LayoutTests

Reviewed by Adam.

Adding new test js-update-style.svg, testing
dynamic style updates via JS (here: stroke-width change)

Setting eol-style native property for all the js-update*.svg
files, as requested by Adam.

4:50 PM Changeset in webkit [22705] by aroben
  • 3 edits in branches/WindowsMerge/WebCore
4:26 PM Changeset in webkit [18367] by zimmermann
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Beth.

Adding new test js-update-pattern.svg, testing
dynamic pattern updates via JS.

4:13 PM Changeset in webkit [18366] by zimmermann
  • 6 edits in trunk

Reviewed by Maciej.

Fix dynamic gradient changes, via JS. It actually worked before, but it
wasn't repainted. Behave just like the pattern notifyAttributeChange() code now.

3:57 PM Changeset in webkit [18365] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed <rdar://problem/4809825>. We need to check isSafeScript when converting
a Location to string.


It's really a bug, and poor design, for objects to override toString.
Subclasses that want custom toString implementations should add a toString
function to their prototypes instead of overriding the JavaScript ToString
operation. Following this design pattern would have avoided this bug in the
first place.


  • bindings/js/kjs_window.cpp: (KJS::Location::toString):
3:09 PM Changeset in webkit [18364] by zimmermann
  • 1 edit
    24 adds in trunk/LayoutTests

Reviewed by Sam.
Add a new set of SVG JavaScript testcases, mostly using SVG DOM.

2:54 PM Changeset in webkit [18363] by yongjzha
  • 3 edits in S60/trunk/WebKit

2006-12-20 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin and Yongjun.
DESC: Links on sonera.fi when loaded opens toolbar.
​http://bugs.webkit.org/show_bug.cgi?id=11843

  • BrowserView/inc/KeyEventHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
2:43 PM Changeset in webkit [18362] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-20 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun & Sachin.
DESC: Links on www.sonera.fi don't work and open floating Toolbar
​http://bugs.webkit.org/show_bug.cgi?id=11843

  • BrowserView/inc/KeyEventHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
2:34 PM Changeset in webkit [22704] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Remove line width setting in font rendering now that GraphicsContext sets
it for us.

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
2:30 PM Changeset in webkit [18361] by hyatt
  • 1 edit in trunk/LayoutTests/fast/css/computed-style-expected.txt

Update computed style layout test results.

2:25 PM Changeset in webkit [18360] by hyatt
  • 7 edits in trunk/WebCore

Fix SVG stroking. Make strokeThickness() get pushed into CG immediately
when set in the GraphicsContext. Remove setLineWidth since it is
redundant with setStrokeThickness now.

Reviewed by mitz

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::setLineWidth):
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setPlatformStrokeThickness): (WebCore::GraphicsContext::setPlatformStrokeStyle):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/graphics/qt/GraphicsContextQt.cpp:
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
1:55 PM Changeset in webkit [18359] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 11893, white text on form controls. Just make sure that
all form control drawing in RenderTheme is bracketed by save/restore
calls.

Reviewed by adele

  • platform/mac/LocalCurrentGraphicsContext.h:
  • platform/mac/LocalCurrentGraphicsContext.mm: (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):
1:54 PM Changeset in webkit [18358] by bdash
  • 2 edits in trunk/WebCore

2006-12-20 Mark Rowe <​bdash@webkit.org>

Reviewed by Anders.

Fix leak of CGContextRef from GraphicsContext::createImageBuffer.

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::createImageBuffer): Release newly-created CGContextRef after passing it to GraphicsContext.
1:28 PM Changeset in webkit [18357] by bdakin
  • 4 edits in trunk/LayoutTests

Rubber-stamped by Darin.

This test also needs updated results after my clone node check-in.
Somehow, the fix to clone node eliminated the dummy spans in both
of these tests. This is an improvement.

  • editing/style/remove-underline-expected.checksum:
  • editing/style/remove-underline-expected.png:
  • editing/style/remove-underline-expected.txt:
12:25 PM Changeset in webkit [18356] by andersca
  • 2 edits in trunk/JavaScriptCore
  • kjs/string_object.cpp: (localeCompare): Another speculative Win32 fix.
12:20 PM Changeset in webkit [18355] by andersca
  • 2 edits in trunk/JavaScriptCore
  • kjs/string_object.cpp: (localeCompare): Speculative Win32 fix.
12:11 PM Changeset in webkit [18354] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

<rdar://problem/4235733>
<​http://bugs.webkit.org/?show_bug.cgi?id=10193>
support String.localeCompare.


Implement localeCompare.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/string_object.cpp: (localeCompare): (StringProtoFunc::callAsFunction):
  • kjs/string_object.h: (KJS::StringProtoFunc::):
11:20 AM Changeset in webkit [18353] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

  • JavaScriptCore.xcodeproj/project.pbxproj: use GCC 4.0 for all the other test targets
10:54 AM Changeset in webkit [18352] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4871993> WebCore-421.31 build fails with "Public API change" error when gcc 3.3 is the default compiler

  • bindings/scripts/CodeGeneratorObjC.pm: ignore blank lines in the public API check
10:50 AM Changeset in webkit [18351] by bdakin
  • 4 edits in trunk/LayoutTests

Rubber stamped by Darin.

Updated results for this test after my clone node check-in
yesterday.

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-expected.txt:
10:41 AM Changeset in webkit [18350] by harrison
  • 2 edits in trunk/LayoutTests

Updated for Justin's checkin that added properties.

  • fast/dom/Window/window-properties-expected.txt:
10:36 AM Changeset in webkit [18349] by thatcher
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

<rdar://problem/4871613> JavaScriptCore-421.31's dftables target needs to override default compiler and use gcc-4.0

10:31 AM Changeset in webkit [18348] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-20 sareen <set EMAIL_ADDRESS environment variable>

Reviewed Sachin Padma.
DESC:BrowserNG: Opening and closing cover while in text input fields causes

input text to be displaced.

​http://bugs.webkit.org/show_bug.cgi?id=11886

  • BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
10:25 AM Changeset in webkit [18347] by spadma
  • 2 edits in S60/trunk/WebKit

2006-12-20 sareen <set EMAIL_ADDRESS environment variable>

Reviewed Sachin Padma.
DESC:BrowserNG: Opening and closing cover while in text input fields causes

input text to be displaced.

​http://bugs.webkit.org/show_bug.cgi?id=11886

  • BrowserView/src/WebKitView.cpp: (CWebKitView::SizeChanged):
8:14 AM Changeset in webkit [18346] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-19 vbradley <​vincent.bradley@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com
DESC: TSW ID: IRON-6WAAWZ. crash on aol.co.uk
​http://bugs.webkit.org/show_bug.cgi?id=11875

  • BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::TileInRect):
7:40 AM Changeset in webkit [18345] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

Test for <rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

  • editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
  • editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
  • editing/deleting/delete-to-end-of-paragraph-expected.txt: Added.
  • editing/deleting/delete-to-end-of-paragraph.html: Added.

WebCore:

Reviewed by John Sullivan.

<rdar://problem/4570218> REGRESSION (?-10.4.7): cntl-K only works the first time

Test:

  • editing/deleting/delete-to-end-of-paragraph.html


  • editing/TypingCommand.cpp: (WebCore::TypingCommand::forwardDeleteKeyPressed): If the selection was a caret at the end of the paragraph, extend selection so it wraps to the start of next paragraph (if any),
6:16 AM Changeset in webkit [18344] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, reviewed by Mitz.
Fix mac build, by using proper float -> int conversion.

3:32 AM Changeset in webkit [18343] by hyatt
  • 1 edit in trunk/WebCore/rendering/InlineTextBox.cpp

Fix warning on buildbot on mac.

3:16 AM Changeset in webkit [18342] by hyatt
  • 3 edits
    4 adds in trunk

Make sure text decoration colors prefer stroke over fill (and honor both of the new CSS properties added
for these values over color).

Reviewed by mitz

Added fast/text/stroking-decorations.html

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/RenderObject.cpp: (WebCore::decorationColor): (WebCore::RenderObject::getTextDecorationColors):
3:05 AM Changeset in webkit [18341] by ddkilzer
  • 9 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11746
REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

  • editing/selection/move-begin-end-expected.txt: Updated editing delegate results.
  • fast/forms/onselect-textarea-expected.txt: Updated selection start/end positions.
  • fast/forms/textarea-initial-caret-position-expected.txt: Added.
  • fast/forms/textarea-initial-caret-position.html: Added.
  • fast/forms/textarea-no-scroll-on-blur.html: Updated to position caret at end of text to match previous initial focus behavior for this test.
  • fast/forms/textarea-scrollbar.html: Ditto.
  • fast/forms/textarea-scrolled-endline-caret.html: Ditto.
  • fast/forms/textarea-scrolled-type.html: Ditto.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11746
REGRESSION(r14931): Outlook Web Access incorrectly positions the insertion point when replying to e-mail

Set caret at beginning of text on initial focus.

Test: fast/forms/textarea-initial-caret-position.html

  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance):
2:40 AM Changeset in webkit [22703] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Add support for stroking and filling of text to CSS. Boomer side. Same code as in FontMac.

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
2:31 AM Changeset in webkit [18340] by hyatt
  • 13 edits
    4 adds in trunk

Fix for bug 11889, support stroking and filling of HTML text from CSS. This patch adds four new CSS properties:
text-fill-color, text-stroke-color, text-stroke-width and text-stroke (a shorthand for the other two). Text
is filled and not stroked by default and does so using the text-fill-color. If this property is not set, then
color is used.

Stroking is accomplished by setting a stroke width. Stroke color, if omitted, will be picked up from the color
property. You can set either color to be transparent or partially transparent. A fully transparent fill color is
the way to achieve an "outline" effect where only stroking happens.

Stroking and filling are both customizable inside the ::selection pseudo-element, and so when selecting you can
vary colors and widths.

text-shadow applies to both the stroke and the fill.

text-decorations do not yet respect the stroke/fill colors. This will follow in a later patch.

Reviewed by mitz

Added fast/text/stroking.html as a layout test. Enhanced RenderTreeAsText.cpp to dump fill and stroke information.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPropertyNames.in:
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/InlineFlowBox.h: (WebCore::InlineFlowBox::InlineFlowBox): (WebCore::InlineFlowBox::maxHorizontalVisualOverflow):
  • rendering/InlineTextBox.cpp: (WebCore::updateGraphicsContext): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::selectionForegroundColor):
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): (WebCore::StyleCSS3InheritedData::operator==): (WebCore::RenderStyle::diff):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::textStrokeColor): (WebCore::RenderStyle::textStrokeWidth): (WebCore::RenderStyle::textFillColor): (WebCore::RenderStyle::setTextStrokeColor): (WebCore::RenderStyle::setTextStrokeWidth): (WebCore::RenderStyle::setTextFillColor): (WebCore::RenderStyle::initialTextStrokeWidth):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<):
2:05 AM Changeset in webkit [18339] by lars
  • 4 edits
    9 adds in trunk/JavaScriptCore

Added support to bind QObject's to JavaScript.

Note: See TracTimeline for information about the timeline view.