Context Navigation

← Previous Period
Next Period →

Timeline

May 22, 2007:

10:37 PM Changeset in webkit [23397] by aliceli1

5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Enabling smartInsertDelete to resolve
<rdar://problem/5082891> editing/deleting/smart-delete-003.html (and 004) fail

Interfaces/IWebView.idl:
WebEditorClient.cpp: (WebEditorClient::smartInsertDeleteEnabled):
WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (WebView::toggleSmartInsertDelete): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled):
WebView.h:

10:02 PM Changeset in webkit [21660] by bdash

1 edit in tags/Safari-5522.7.1/WebKit/Configurations/Version.xcconfig

Versioning.

9:52 PM Changeset in webkit [21659] by bdash

3 edits in tags/Safari-5522.7.1/WebKit

Merge in r21576.

9:46 PM Changeset in webkit [21658] by bdash

3 edits in tags/Safari-5522.7.1/WebKit

Merge in r21569.

9:05 PM Changeset in webkit [21657] by bdash

1 copy in tags/Safari-5522.7.1

New tag.

8:38 PM Changeset in webkit [21656] by weinig

2 edits in trunk/WebCore

Rubber stamped by Adam.

Fix license.

bindings/js/JSHTMLAnchorElementCustom.cpp:

6:26 PM Changeset in webkit [21655] by weinig

13 edits in trunk

LayoutTests:

Reviewed by Adam.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

fast/dom/wrapper-classes-expected.txt:
fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement

WebCore:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

Also adds missing DOMHTMLFramePrivate.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (WebCore::createElementClassMap):
bindings/objc/DOMHTML.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Adam.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
Add ObjC DOM binding for HTMLMarqeeElement

Also adds missing DOMHTMLFramePrivate.

MigrateHeaders.make:

6:19 PM Changeset in webkit [21654] by justing

3 edits
7 adds in trunk

LayoutTests:

Reviewed by darin

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

editing/selection/13804-expected.checksum: Added.
editing/selection/13804-expected.png: Added.
editing/selection/13804-expected.txt: Added.
editing/selection/13804.html: Added. These were missing:
editing/selection/5076323-1-expected.png: Added.
editing/selection/5076323-2-expected.png: Added.
editing/selection/5076323-3-expected.png: Added.

WebCore:

Reviewed by darin, who found the fix independently.

http://bugs.webkit.org/show_bug.cgi?id=13804
REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)

r21611 exposed a bug in the way removeMarkers computes
the end of the range to remove markers from. It also
introduced a bug: removeMarkers expects a startOffset
and a length, not a startOffset and an endOffset (added
a layout test).

dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation.

5:55 PM Changeset in webkit [21653] by hyatt

2 adds in trunk/LayoutTests/fast/dom

Add layout test for better background dumping.

5:43 PM Changeset in webkit [21652] by hyatt

6 edits in trunk/WebCore

Fix for bug 13802, background colors can't be reset to default
color. Fix the value cssText method to do the right thing for background
and background-position values.

Reviewed by beth

fast/dom/background-shorthand-csstext.html

css/CSSInitialValue.h: (WebCore::CSSInitialValue:::m_implicit): (WebCore::CSSInitialValue::isImplicitInitialValue):
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
css/CSSMutableStyleDeclaration.h:
css/CSSValue.h: (WebCore::CSSValue::isImplicitInitialValue):
css/cssparser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseBackgroundShorthand): (WebCore::CSSParser::parseShorthand):

4:47 PM Changeset in webkit [21651] by darin

10 edits in trunk

LayoutTests:

Reviewed by Geoff.

test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

fast/dom/iframe-document.html: Updated test to expect no document property.
fast/dom/iframe-document-expected.txt: Updated.

fast/forms/focus2.html: Changed test to use ownerDocument instead of document.

WebCore:

Reviewed by Geoff.

fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong

The code on ebay was looking for the "document" property on a iframe.
We changed that to be the ownerDocument rather than the contentDocument,
which was not what ebay was expecting. The best fix seems to be removing
the document property altogether.

Test: fast/dom/iframe-document.html

bindings/js/kjs_html.h: Remove ElementDocument.
bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.

WebKit:

Reviewed by Geoff.

WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property.

4:43 PM Changeset in webkit [21650] by adele

3 edits in trunk/WebCore

Reviewed by Darin.

A little cleanup from my last checkin.

page/Chrome.h: Formatting change.
page/mac/ChromeMac.mm: Fixed copyright.

4:21 PM Changeset in webkit [21649] by adele

6 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

fast/frames/frame-display-none-focus-expected.txt: Added.
fast/frames/frame-display-none-focus.html: Added.
fast/frames/resources/iframe-focus.html: Added.

WebCore:

Reviewed by Darin.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
Crash in [NSInputContext currentInputContext] when you click on this map

This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

Test: fast/frames/frame-display-none-focus.html

WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
page/Chrome.h:
page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.

4:18 PM Changeset in webkit [21648] by justing

10 edits
4 adds
4 deletes in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters

Moved from unsupported-content because we've supported editing lists
for a while now:

editing/deleting/4875189-expected.checksum: Added.
editing/deleting/4875189-expected.png: Added.
editing/deleting/4875189-expected.txt: Added.
editing/deleting/4875189.html: Added.
editing/unsupported-content/list-delete-002-expected.checksum: Removed.
editing/unsupported-content/list-delete-002-expected.png: Removed.
editing/unsupported-content/list-delete-002-expected.txt: Removed.
editing/unsupported-content/list-delete-002.html: Removed.

Reflects new behavior:

editing/deleting/delete-select-all-003-expected.checksum:
editing/deleting/delete-select-all-003-expected.png:
editing/deleting/delete-select-all-003-expected.txt:

Ditto and also removed a FIXME:

editing/deleting/list-item-1-expected.checksum:
editing/deleting/list-item-1-expected.png:
editing/deleting/list-item-1-expected.txt:
editing/deleting/list-item-1.html:

WebCore:

Reviewed by darin

<rdar://problem/4875189>
List is deleted when replacing contents with Chinese/Japanese characters

editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region.

4:02 PM Changeset in webkit [21647] by adele

2 edits in trunk/WebKit

Reviewed by Darin.

Adding some asserts to help detect other cases of <rdar://problem/5171145>

WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):

3:59 PM Changeset in webkit [21646] by darin

3 edits in trunk/WebCore

Reviewed by Tim Hatcher.

fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories" tab makes page content disappear

The contentWindow property was doing a cross-frame security check, but it shouldn't.
Window objects are responsible for protecting themselves from cross-frame activity.
Because contentWindow returned undefined, we then ended up setting visibility on the
body of the main frame to "hidden".

No layout test yet. When we make cross-domain tests, we should include this one.

html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
html/HTMLIFrameElement.idl: Ditto.

3:53 PM Changeset in webkit [23396] by adachan

2 edits in branches/WindowsMerge/WebCore

2007-05-22 Ada Chan <adachan@apple.com>

Fix build.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

3:52 PM Changeset in webkit [21645] by kmccullo

1 edit
4 adds in trunk/LayoutTests

Reviewed by.

Forgot to checkin for fix for rdar://problem/4981886

fast/dom/open-and-close-by-DOM-expected.txt: Added.
fast/dom/open-and-close-by-DOM.html: Added.
fast/dom/resources/close.html: Added.
fast/dom/resources/middle.html: Added.
http/tests/security/local-image-from-remote.html:

2:57 PM Changeset in webkit [23395] by aliceli1

2 edits in branches/WindowsMerge/LayoutTests

Reviewed by.

win/Skipped: removed fixed tests

2:38 PM Changeset in webkit [23394] by justing

4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by oliver

Build fix.

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent):

WebKitWin:

Reviewed by oliver

Build fix.

WebView.cpp: (WebView::clearFocusNode):

2:17 PM Changeset in webkit [23393] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada.

Added 3 view-related methods to IWebFramePrivate.

Interfaces/IWebFramePrivate.idl: Added 3 new methods
WebFrame.cpp: (WebFrame::hasScrollBars): Added. (WebFrame::contentBounds): Added. (WebFrame::frameBounds): Added.
WebFrame.h:

1:49 PM Changeset in webkit [21644] by yongjzha

4 edits in S60/trunk/JavaScriptCore

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

pcre/internal.h:
pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
pcre/study.c: (set_bit): (set_start_bits):

1:43 PM Changeset in webkit [21643] by yongjzha

4 edits in S60/branches/3.1m/JavaScriptCore

2007-05-22 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun
DESC: fix out of boundary crah in prce
http://bugs.webkit.org/show_bug.cgi?id=13826

pcre/internal.h:
pcre/pcre.c: (check_escape): (is_counted_repeat): (read_repeat_counts): (check_posix_syntax): (compile_branch): (pcre_compile): (match):
pcre/study.c: (set_bit): (set_start_bits):

12:02 PM Changeset in webkit [21642] by justing

11 edits
4 adds in trunk

LayoutTests:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

Demonstrates bug:

editing/selection/5213963-expected.checksum: Added.
editing/selection/5213963-expected.png: Added.
editing/selection/5213963-expected.txt: Added.
editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired):
fast/forms/focus-selection-input-expected.txt:
fast/forms/focus-selection-textarea-expected.txt:

WebCore:

Reviewed by oliver

<rdar://problem/5213963>
REGRESSION(r21467): Active selection remains in text field after clicking on a button

page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame.
page/FocusController.h:

12:02 PM Changeset in webkit [21641] by beidson

2 edits in trunk/WebKit

Reviewed by Kevin (Sarge)

<rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/

This regressed in http://trac.webkit.org/projects/webkit/changeset/21618

WebView/WebFrame.mm: (-[WebFrame dataSource]): Null check the frameloader

8:11 AM Changeset in webkit [21640] by staikos

2 edits in trunk/WebKitQt

back this out for zack

1:53 AM Changeset in webkit [21639] by zack

2 edits in trunk/WebCore

Path implementing more Cliboard from Marius Bugge Monsen.

Adding implementations of some of the missing methods.
r=me

12:31 AM Changeset in webkit [21638] by hausmann

2 edits in trunk/WebKitQt

Fix http headers for POST.

May 21, 2007:

11:53 PM Changeset in webkit [21637] by justing

2 edits in trunk/LayoutTests/editing/execCommand

Updating expected results for r21074.

8:50 PM Changeset in webkit [23392] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam, Ada.

Added IWebFramePrivate::size().

Interfaces/IWebFramePrivate.idl: Added size.
WebFrame.cpp: (WebFrame::size): Added.
WebFrame.h: Added size.

8:10 PM Changeset in webkit [21636] by oliver

4 edits
4 adds in trunk

2007-05-21 Oliver Hunt <oliver@apple.com>

LayoutTests:

Reviewed by Sam.

Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789

svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
svg/custom/getscreenctm-in-mixed-content.xhtml: Added.

WebCore:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13789
-- SVGLocatable::getScreenCTM() faulty

Needed to update SVGLength to handle the case where the SVGElement is
not the root document element -- we do this by falling back on the
renderer for the context.

For <svg> elements embedded as mixed content in xhtml we consider the
absolutePosition of the parent to be the origin for the <svg> element.

ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM):

7:14 PM Changeset in webkit [23391] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Build fix.

WebCore.vcproj/WebCore.vcproj:

7:14 PM Changeset in webkit [21635] by thatcher

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created

Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.

bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]): (-[DOMRange boundingBox]): (-[DOMRange lineBoxRects]):

6:42 PM Changeset in webkit [21634] by weinig

2 edits in trunk/WebCore

Reviewed by George Staikos.

Fix Qt build.

WebCore.pro: add missing IDL files.

6:29 PM Changeset in webkit [21633] by weinig

14 edits
1 add in trunk

LayoutTests:

Reviewed by Darin.

update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803 to account for the new JSHTMLMarquee that is being autogenerated and can now produce a constructor.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/element-constructors-on-window.html:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
Autogenerate the JS bindings for the HTMLMarqueeElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue.
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop):
html/HTMLMarqueeElement.h: Add start() and stop() functions.
html/HTMLMarqueeElement.idl: Added.
page/DOMWindow.idl: Add marquee constructor.

5:08 PM Changeset in webkit [21632] by adele

4 edits in trunk

WebCore:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

platform/mac/WidgetMac.mm: (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it. (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window. (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview. (WebCore::Widget::afterMouseDown): ditto.

WebKit:

Fix by Darin, reviewed by me.

Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts

WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder, then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.

4:13 PM Changeset in webkit [21631] by weinig

4 edits in trunk/LayoutTests

3:03 PM Changeset in webkit [21630] by hyatt

3 edits in trunk/WebCore

Make a line gutter backdrop so that tiny view source docs don't look
bad.

Reviewed by aroben

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::createContainingTable):

2:45 PM Changeset in webkit [23390] by adachan

4 edits in branches/WindowsMerge/WebKitWin

2007-05-21 Ada Chan <adachan@apple.com>

Reviewed by Steve.

Added IWebViewPrivate::loadBackForwardListFromOtherView(). It replicates the backforward
list from another webview and loads that in the current webview.

Interfaces/IWebViewPrivate.idl:
WebView.cpp: (WebView::loadBackForwardListFromOtherView):
WebView.h:

2:32 PM Changeset in webkit [21629] by hyatt

4 edits in trunk/WebCore

Make sure to distinguish between links to internal resources and
real links (anchors) in view source mode.

Reviewed by aroben

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addLink):
html/HTMLViewSourceDocument.h:

1:00 PM Changeset in webkit [23389] by weinig

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Build fix.

WebCore.vcproj/WebCore.vcproj:

12:37 PM S60CheckoutAndBuild edited by bradley.morrison@nokia.com

(diff)

12:35 PM S60IDE created by bradley.morrison@nokia.com

initial revision

12:07 PM Changeset in webkit [21628] by beidson

2 edits in trunk/WebKit

Making the importance of my last change more clear

WebView/WebViewPrivate.h: "Leave for Dashboard, people!"

11:55 AM S60ConfigureComputer edited by bradley.morrison@nokia.com

link to s60IDE page (diff)

11:45 AM Changeset in webkit [21627] by beidson

3 edits in trunk/WebKit

Reviewed by Kevin (Sarge)

<rdar://problem/5217124> - Re-add mistakenly removed SPI

WebView/WebView.mm: (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
WebView/WebViewPrivate.h:

11:32 AM Changeset in webkit [21626] by spadma

2 edits in S60/branches/3.1m/WebKit

spadma

DESC: Update loc file layout

data/Webkit.loc:

11:32 AM Changeset in webkit [21625] by spadma

2 edits in S60/trunk/WebKit

spadma

DESC: Update loc file layout

data/Webkit.loc:

11:19 AM Changeset in webkit [21624] by weinig

17 edits in trunk

LayoutTests:

Reviewed by Adam and Darin.

update results for http://bugs.webkit.org/show_bug.cgi?id=13791 to account for new JSHTMLElements that are being autogenerated and can now produce constructors.

fast/dom/Window/element-constructors-on-window-expected.txt:
fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Adam and Darin.

Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSHTMLAnchorElementCustom.cpp:
bindings/js/JSHTMLElementWrapperFactory.cpp:
bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction):
bindings/js/kjs_html.h: (KJS::JSHTMLElement::):
bindings/scripts/CodeGeneratorJS.pm:
html/HTMLFrameElement.idl:
html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location):
html/HTMLFrameElementBase.h:
html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow):
html/HTMLIFrameElement.idl:
page/DOMWindow.idl:

10:57 AM Changeset in webkit [21623] by andersca

2 edits in trunk/WebKit

Reviewed by Ada.

<rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )

Null check the request.

WebView/WebView.mm: (+[WebView _canHandleRequest:]):

6:57 AM Changeset in webkit [21622] by lars

8 edits
6 adds in trunk/LayoutTestResults

Updating and adding test cases.

6:36 AM Changeset in webkit [21621] by lars

4 edits in trunk/WebKitQt

Reviewed by Simon

Remove the userHandle methods from QWebnetworkJob again.
They don't really give us anything and just clutter the API.

6:09 AM Changeset in webkit [21620] by hausmann

2 edits in trunk/WebKitQt

Export the new qt network API.

5:33 AM Changeset in webkit [21619] by lars

5 edits
3 adds
4 deletes in trunk

Reviewed by Zack.

Add an API layer for network downloads. Basically QWebnetworkInterface
is an interface class for downloading resources. QWebnetworkJob describes
the actual object to download.

QWebNetworkInterface has a default implementation that replaces the
old ResourceHandleManager class in the Qt port.

Remove the ResourceHandleManager class, it is now part of
QWebNetworkInterface. Adapt ResourceHandle to the new way
of things.

4:04 AM Changeset in webkit [21618] by mjs

15 edits in trunk/WebKit

Reviewed by Geoff.

<rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit

The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
empty initial document. However, WebKit still needs the real data source internally, so I also
added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.

Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView dataSource]):
Plugins/WebNullPluginView.mm: (-[WebNullPluginView viewDidMoveToWindow]):
Plugins/WebPluginController.mm: (-[WebPluginController URLPolicyCheckReferrer]):
WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge dataSource]): (-[WebFrameBridge redirectDataToPlugin:]):
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::canCachePage):
WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory bridgeForView:]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebArchiver.mm: (+[WebArchiver archiveFrame:]): (+[WebArchiver archiveMainResourceForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveSelectionInFrame:]):
WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _addChild:]): (-[WebFrame _dataSource]): (-[WebFrame DOMDocument]): (-[WebFrame dataSource]):
WebView/WebFrameInternal.h:
WebView/WebHTMLView.mm: (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
WebView/WebRenderNode.mm: (-[WebRenderNode initWithWebFrameView:]):
WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): (-[WebView mainFrameURL]): (-[WebView mainFrameTitle]): (-[WebView mainFrameIcon]): (-[WebView validateUserInterfaceItemWithoutDelegate:]): (-[WebView replaceSelectionWithArchive:]): (-[WebView _isLoading]): (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]): (-[WebView _notifyTextSizeMultiplierChanged]):

12:40 AM Changeset in webkit [21617] by hyatt

28 edits in trunk/LayoutTests/tables

Update test results for improved colgroup span handling.

12:31 AM Changeset in webkit [21616] by hyatt

4 adds in trunk/LayoutTests/fast/table

Add new layout test for spanning colgroup rules=groups bug.

12:30 AM Changeset in webkit [21615] by hyatt

5 edits in trunk/WebCore

Second half of fix for 13793, make sure rules=groups works properly with
spanning colgroups.

Also make sure colgroups get an actual span of 1 (instead of incorrectly
giving them a span of 0).

Reviewed by mitz

fast/table/colgroup-spanning-groups-rules.html

html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::HTMLTableColElement):
rendering/RenderTable.cpp: (WebCore::RenderTable::colElement):
rendering/RenderTable.h:
rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder):

May 20, 2007:

11:29 PM Changeset in webkit [21614] by hyatt

2 edits in trunk/WebCore

Half of a fix for 13793, make sure rules=groups and border behave properly
together.

Reviewed by mitz

No tests added, two Mozilla table tests now pass that failed before.

html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

5:44 PM Changeset in webkit [21613] by bdash

1 edit in trunk/WebCore/loader/icon/IconLoader.cpp

Fix spelling.

3:55 PM Changeset in webkit [21612] by beidson

3 edits in trunk/WebCore

Reviewed by Geoose Garen

<rdar://problem/4758919> - Incorrect favicon shown for URL after going back

When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing
shenanigans with the icon url -> page url mapping.

loader/FrameLoader.cpp: (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)

loader/icon/IconLoader.cpp: (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down

2:14 PM Changeset in webkit [21611] by darin

6 edits in trunk/WebCore

Reviewed by Oliver Hunt.

fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow

dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common case where there are no markers. Changed code to iterate over all the nodes in the range instead of using TextIterator, which is more efficient.

page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable, so we don't bother doing work related to spell checking and grammar checking when changing the selection in non-editable text. Also rearranged the code so we only compute the old word boundaries and sentence boundaries when actually needed, and don't do the sentence range checks unless grammar checking is enabled.

platform/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID. (WebCore::characterBreakIterator): Removed local parameter. (WebCore::wordBreakIterator): Ditto. (WebCore::lineBreakIterator): Ditto. (WebCore::sentenceBreakIterator): Ditto.

platform/mac/TextBreakIteratorInternalICUMac.mm: (WebCore::getTextBreakLocale): Broke out the code to actually get the locale. (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls getTextBreakLocale to actually figure it out.

editing/visible_units.cpp: Added lots of FIXME comments, but no code change.

11:36 AM Changeset in webkit [21610] by staikos

2 edits in trunk/WebCore

add -f to cp for some obscure build systems.

10:45 AM Changeset in webkit [21609] by staikos

2 edits in trunk/WebCore

Add missing include for auto_ptr

7:12 AM Changeset in webkit [21608] by ddkilzer

3 edits in trunk/WebKitTools

2007-05-20 David Kilzer <ddkilzer@webkit.org>

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=13565 Change svn-create-patch to put LayoutTests in the end

In addition to reordering test files under the LayoutTests directory so that they
appear after source code files, this patch fixes an issue with prepare-ChangeLog
if the first argument passed to it is a file name instead of a directory name.

Scripts/prepare-ChangeLog: (isGIT()): If first value in @dirs array is a file, use dirname() to get the directory. (isSVN()): Ditto.
Scripts/svn-create-patch: (generateFileList($\%\%\%)): Differentiate test files in the LayoutTests directory from source code files.

May 19, 2007:

6:19 PM Changeset in webkit [21607] by zimmermann

23 edits
134 adds in branches/feature-branch

Reviewed by Oliver.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12698 (SVG text needs a special per-character layout mode.)
Finally land the new SVG text engine.

5:20 PM Changeset in webkit [21606] by hyatt

2 edits in trunk/WebCore

Fix for bug 13785, O(n^{2) counter creation.}

Reviewed by darin

rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): (WebCore::RenderCounter::originalText):

5:16 PM Changeset in webkit [21605] by bdash

12 edits
12 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under

Tests: fast/repaint/box-shadow-dynamic.html

fast/repaint/box-shadow-h.html
fast/repaint/box-shadow-v.html

rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Account for box shadow when checking if the damage rect intersects.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked for the "exterior" overflow, add box shadow overflow. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for the "exterior" extreme position, add box shadow. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint the box shadow when an edge with a shadow moves. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function that expands a given rectangle to encompass outline and box shadow. (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
rendering/RenderObject.h:

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under

fast/box-shadow/basic-shadows-expected.checksum:
fast/box-shadow/basic-shadows-expected.png:
fast/box-shadow/basic-shadows-expected.txt:
fast/repaint/box-shadow-dynamic-expected.checksum: Added.
fast/repaint/box-shadow-dynamic-expected.png: Added.
fast/repaint/box-shadow-dynamic-expected.txt: Added.
fast/repaint/box-shadow-dynamic.html: Added.
fast/repaint/box-shadow-h-expected.checksum: Added.
fast/repaint/box-shadow-h-expected.png: Added.
fast/repaint/box-shadow-h-expected.txt: Added.
fast/repaint/box-shadow-h.html: Added.
fast/repaint/box-shadow-v-expected.checksum: Added.
fast/repaint/box-shadow-v-expected.png: Added.
fast/repaint/box-shadow-v-expected.txt: Added.
fast/repaint/box-shadow-v.html: Added.

4:42 PM Changeset in webkit [21604] by bdash

4 edits in trunk/LayoutTests

2007-05-20 Mark Rowe <mrowe@apple.com>

Update test results after r21597.

fast/frames/viewsource-attribute-expected.checksum:
fast/frames/viewsource-attribute-expected.png:
fast/frames/viewsource-attribute-expected.txt:

4:11 PM Changeset in webkit [21603] by bdash

2 edits in trunk/WebCore

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=13783 REGRESSION (r21120): Frame resizers not repainted properly when dragged

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::layout):

4:09 PM Changeset in webkit [21602] by bdash

4 edits
4 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader

Test: fast/table/stale-grid-crash.html

rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Made const and replaced setNeedsLayout(true) with an assertion that the table is already marked for layout. (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded(). (WebCore::RenderTable::sectionBelow): Ditto. (WebCore::RenderTable::cellAbove): Ditto. (WebCore::RenderTable::cellBelow): Ditto. (WebCore::RenderTable::cellBefore): Ditto. (WebCore::RenderTable::cellAfter): Ditto.
rendering/RenderTable.h: Made some private member variables which are used in section recalc mutable. (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to setNeedsLayout() from recalcSections() into here, because I made recalcSections() const. (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader

fast/table/stale-grid-crash-expected.checksum: Added.
fast/table/stale-grid-crash-expected.png: Added.
fast/table/stale-grid-crash-expected.txt: Added.
fast/table/stale-grid-crash.html: Added.

3:54 PM Changeset in webkit [21601] by bdash

9 edits
4 adds in trunk

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow

Test for a rendering bug fixed by this patch:

fast/box-shadow/border-radius-big.html

No test for the performance ingredient.

platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform. Changed to use a single clipping path. If all the radii cannot be accommodated, clips to a rect. (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single clipping path. If all the radii cannot be accommodated, clips out a rect.
platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle with the specified radii. If all the radii cannot be accommodated, returns a rectangular path.
platform/graphics/Path.h:
platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut): Added.
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path. (WebCore::GraphicsContext::clipOut): Added.
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Added.

2007-05-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow

fast/box-shadow/border-radius-big-expected.checksum: Added.
fast/box-shadow/border-radius-big-expected.png: Added.
fast/box-shadow/border-radius-big-expected.txt: Added.
fast/box-shadow/border-radius-big.html: Added.

6:14 AM Changeset in webkit [21600] by andersca

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

fast/frames/inline-object-inside-frameset-expected.txt: Added.
fast/frames/inline-object-inside-frameset.html: Added.

WebCore:

Reviewed by Mitz.

Test: fast/frames/inline-object-inside-frameset.html

http://bugs.webkit.org/show_bug.cgi?id=13771
Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester

Don't paint inline objects.

rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint):

12:42 AM Changeset in webkit [21599] by hyatt

6 edits in trunk/WebCore

Add support for plain text MIME types (CSS/JS/TXT) to view source mode.
CSS/JS will eventually tokenize via their own special tokenizers so that
they can also be syntax-highlighted, but for now just treat them as
plain text.

Reviewed by aroben

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument):
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument): (WebCore::HTMLViewSourceDocument::createTokenizer): (WebCore::HTMLViewSourceDocument::createContainingTable): (WebCore::HTMLViewSourceDocument::addViewSourceText): (WebCore::HTMLViewSourceDocument::addViewSourceToken):
html/HTMLViewSourceDocument.h:
loader/TextDocument.cpp: (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write):
loader/TextDocument.h: (WebCore::TextTokenizer::checkBuffer):

May 18, 2007:

11:48 PM Changeset in webkit [21598] by hyatt

2 edits in trunk/WebCore

Fix a glitch in view source mode attribute names.

html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken):

10:16 PM Changeset in webkit [21597] by hyatt

4 edits in trunk/WebCore

"Linkify" view source mode links.

Reviewed by andersca

css/view-source.css:
html/HTMLViewSourceDocument.cpp: (WebCore::HTMLViewSourceDocument::addViewSourceToken): (WebCore::HTMLViewSourceDocument::addSpanWithClassName): (WebCore::HTMLViewSourceDocument::addLink):
html/HTMLViewSourceDocument.h:

7:05 PM Changeset in webkit [21596] by oliver

10 edits in trunk

2007-05-18 Oliver Hunt <oliver@apple.com>

WebCore:

Reviewed by Sam

No longer need to pass HTMLImageElement and HTMLImageLoader on to WebKit
Need to expose CachedResourceClient constructor

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Sam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13782
REGRESSION (r21528-r21533): Failing editing/selection/drag-in-iframe in pixel mode

r21533 made used a DOMElement as the source for promise data, this meant it had to
clear the dragging pasteboard following the drag. In DRT a drag is non-blocking
so this resulted in us prematurely clearing the pasteboard.

This patch avoids this problem by referencing the source CachedImage rather than the
DOMElement, so we don't need to worry about retaining an entire document forever, so
we don't need to clear the dragging pasteboard following the drag.

Misc/WebNSPasteboardExtras.mm: (imageFromElement): Extract the underlying CachedImage from a DOMElement (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:source:]): Use a CachedImage instead of a DOMElement

WebCoreSupport/WebDragClient.mm: (WebDragClient::startDrag):

WebKit.xcodeproj/project.pbxproj:

WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView pasteboardChangedOwner:]): (-[WebHTMLView pasteboard:provideDataForType:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView WebCore::]): (-[WebHTMLView setPromisedDragTIFFDataSource:WebCore::]): Use CachedImage rather than DOMElement as promised data source

WebView/WebHTMLViewInternal.h:
WebView/WebHTMLViewPrivate.h:

4:32 PM Changeset in webkit [21595] by hyatt

1 edit in trunk/LayoutTests/http/tests/security/local-JavaScript-from-remote.html

Fix more malformed test cases.

4:32 PM Changeset in webkit [21594] by hyatt

2 edits in trunk/LayoutTests/fast/tokenizer

Fix more malformed test cases.

4:31 PM Changeset in webkit [21593] by hyatt

2 edits in trunk/LayoutTests/fast/parser

Fix more malformed test cases.

4:29 PM Changeset in webkit [21592] by hyatt

1 edit in trunk/LayoutTests/fast/loader/local-JavaScript-from-local.html

Fix more malformed test cases.

4:26 PM Changeset in webkit [21591] by hyatt

2 edits in trunk/LayoutTests/fast/dom/HTMLScriptElement

Fix more malformed test cases.

4:12 PM Changeset in webkit [21590] by hyatt

26 edits in trunk/LayoutTests/http/tests/navigation