23:56 Changeset [23486] by oliver


Reviewed by Darin.

Use correct size for BITMAPINFOHEADER -- whoops.

  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):


Reviewed by Darin.

Use correct size for BITMAPINFOHEADER -- whoops.

  • win/WebIconDatabase.cpp: (createDIB): (WebIconDatabase::getOrCreateDefaultIconBitmap):
23:53 Changeset [23485] by sfalken

Merged fix from r21529.

23:20 Changeset [23484] by sfalken

Branched Safari-522 from r21983.

21:57 Changeset [23483] by andersca

Another build fix.

  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::invokeMethod):
21:52 Changeset [23482] by andersca

Reviewed by Geoff.

Move the notion of field type to the JNI runtime since that's the only
one that was actually using it.

  • bindings/c/c_runtime.h: (KJS::Bindings::CField::CField):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm:
  • bindings/qt/qt_runtime.h:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp:
21:43 Changeset [23481] by andersca

Build fix.

  • bindings/qt/qt_class.cpp: (KJS::Bindings::QtClass::methodsNamed):
  • bindings/qt/qt_instance.cpp: (KJS::Bindings::QtInstance::invokeMethod):
21:42 Changeset [23480] by staikos

Fix from Lars to remove duplicate symbols.

21:25 Changeset [23479] by andersca

Reviewed by Oliver.

Get rid of the MethodList class and use a good ol' Vector instead.

  • bindings/c/c_class.cpp: (KJS::Bindings::CClass::methodsNamed):
  • bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::invokeMethod):
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed):
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
  • bindings/runtime.cpp:
  • bindings/runtime.h:
  • bindings/runtime_method.cpp: (RuntimeMethod::lengthGetter): (RuntimeMethod::callAsFunction):
  • bindings/runtime_object.cpp: (RuntimeObjectImp::getOwnPropertySlot):
21:06 Changeset [23478] by andersca

Reviewed by Geoff.

Make RuntimeMethod's method list a pointer so that the object size doesn't
grow beyond 32 bytes when we later will replace MethodList with a Vector.

  • bindings/runtime_method.cpp: (RuntimeMethod::RuntimeMethod): (RuntimeMethod::lengthGetter): (RuntimeMethod::callAsFunction):
  • bindings/runtime_method.h:
20:57 Changeset [23477] by andersca

Reviewed by Geoff.

Get rid of the Parameter class.

  • bindings/jni/jni_instance.cpp: (JavaInstance::invokeMethod):
  • bindings/jni/jni_runtime.cpp: (JavaMethod::signature):
  • bindings/jni/jni_runtime.h: (KJS::Bindings::JavaParameter::JavaParameter): (KJS::Bindings::JavaParameter::~JavaParameter): (KJS::Bindings::JavaParameter::type): (KJS::Bindings::JavaMethod::parameterAt): (KJS::Bindings::JavaMethod::numParameters):
  • bindings/runtime.h:
20:54 Changeset [23476] by andersca
20:54 Changeset [23475] by andersca

Build fix.

  • bindings/qt/qt_class.h:
20:49 Changeset [23474] by bdash

2007-06-12 Mark Rowe <mrowe@apple.com>

Build fix.

  • bindings/objc/objc_runtime.h:
20:43 Changeset [23473] by andersca

Reviewed by Geoff.

Get rid of Constructor and its only subclass JavaConstructor.

  • bindings/c/c_class.h:
  • bindings/jni/jni_class.cpp: (JavaClass::JavaClass): (JavaClass::~JavaClass):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.h:
  • bindings/runtime.h:
20:24 Changeset [23472] by andersca

Reviewed by Geoff.

Use RetainPtr throughout the bindings code.

  • bindings/objc/objc_class.h:
  • bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::ObjcClass): (KJS::Bindings::ObjcClass::methodsNamed): (KJS::Bindings::ObjcClass::fieldNamed):
  • bindings/objc/objc_instance.h: (KJS::Bindings::ObjcInstance::getObject):
  • bindings/objc/objc_instance.mm: (ObjcInstance::ObjcInstance): (ObjcInstance::~ObjcInstance): (ObjcInstance::implementsCall): (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::defaultValue):
  • bindings/objc/objc_runtime.h: (KJS::Bindings::ObjcMethod::setJavaScriptName): (KJS::Bindings::ObjcMethod::javaScriptName): (KJS::Bindings::ObjcArray::getObjcArray):
  • bindings/objc/objc_runtime.mm: (ObjcField::name): (ObjcArray::ObjcArray): (ObjcArray::setValueAt): (ObjcArray::valueAt): (ObjcArray::getLength):
  • wtf/RetainPtr.h:
19:40 Changeset [23471] by weinig

Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14109
Cleanup JSEvent and JSClipboard in preperation for autogeneration

  • bindings/js/kjs_events.cpp: (KJS::DOMEvent::DOMEvent): (KJS::DOMEvent::getValueProperty): (KJS::DOMEvent::put): (KJS::DOMEvent::putValueProperty): (KJS::DOMEventPrototypeFunction::callAsFunction): (KJS::toJS): (KJS::toEvent): (KJS::): (KJS::JSClipboard::JSClipboard): (KJS::JSClipboard::~JSClipboard): (KJS::JSClipboard::getOwnPropertySlot): (KJS::JSClipboard::getValueProperty): (KJS::JSClipboard::put): (KJS::JSClipboard::putValueProperty): (KJS::JSClipboardPrototypeFunction::callAsFunction): (KJS::toClipboard):
  • bindings/js/kjs_events.h: (KJS::DOMEvent::): (KJS::DOMEvent::impl): (KJS::JSClipboard::impl):
  • dom/ClipboardEvent.h:
  • dom/Event.h: (WebCore::Event::srcElement): (WebCore::Event::returnValue): (WebCore::Event::clipboardData): (WebCore::Event::dataTransfer): (WebCore::Event::clipboard):
  • dom/MouseEvent.h:
18:48 Changeset [23470] by andersca

Reviewed by Maciej.

Have JSCell inherit from Noncopyable.

  • bindings/objc/objc_runtime.h:
  • bindings/runtime_object.h:
  • kjs/value.h:
18:22 Changeset [23469] by lars

Fix compilation, and remove dependency on Qt
private header.

17:39 Changeset [23468] by lars

Parts of the patch done by Zack.
Fix up some parts in the implementation of QWebNetworkInterface
so it can be used by plugins.
Change the plugin API so we can actually get all the information
required by the JS bridge from them as well.
Implement the parts required for the JS bridge
to know about the plugins.

17:22 Changeset [23467] by andersca

Reviewed by Darin and Maciej.

More cleanup. Use our Noncopyable WTF class, add a root object member
to the Array class.

  • bindings/c/c_class.h:
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.h:
  • bindings/jni/jni_runtime.cpp: (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h:
  • bindings/objc/objc_class.h:
  • bindings/objc/objc_runtime.h:
  • bindings/objc/objc_runtime.mm: (ObjcArray::ObjcArray):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue):
  • bindings/runtime.cpp: (KJS::Bindings::Array::Array): (KJS::Bindings::Array::~Array):
  • bindings/runtime.h:
  • bindings/runtime_object.h:
  • bindings/runtime_root.h:
16:58 Changeset [23466] by aroben


Land CygwinDownloader.

Rubberstamped by Hyatt.

  • CygwinDownloader/cygwin-downloader.py: Added.
  • CygwinDownloader/cygwin-downloader.zip: Added.
  • CygwinDownloader/make-zip.sh: Added.
  • CygwinDownloader/setup.py: Added.


Update the location of cygwin-downloader.zip.

Rubberstamped by Hyatt.

  • building/tools.html:
15:40 Changeset [23465] by hyatt

Fix build bustage.

14:53 Changeset [23464] by aroben

Add Windows checkout/build instructions to website.

14:51 Changeset [23463] by aroben

Update scripts and project paths to make the Windows build work.

14:50 Changeset [23462] by aroben

Merge WindowsMerge to trunk

00:46 Changeset [23461] by aroben

Check in WebKitSystemInterface


15:45 Changeset [22098] by zimmermann

Reviewed by Eric.
Fix regression: SVG images drawn in the wrong paint phase.

13:33 Known incompatibilities between open-source WebKit and Safari edited by pewtermoose@gmail.com
08:37 Changeset [22097] by rwlbuis

Reviewed by weinig.

fill property is reported as type SVGColor

Do the checks in the right order.

06:49 Changeset [22096] by hausmann

Added a QWebPage::open overload to allow specifying the http header and post data.
(it's an overload instead of a merged openUrl to avoid including qhttp.h in qwebpage.h,
which would imply that one has to have QT += network in the .pro file for using WebKitQt)

06:49 Changeset [22095] by hausmann

Added the possibility to intercept url requests through QWebPage::navigationRequested.

06:49 Changeset [22094] by hausmann

Added a QWebNetworkRequest::init overload that takes a WebCore::ResourceRequest,
to be called from FrameLoaderClientQt in the near future.

06:49 Changeset [22093] by hausmann

Moved the postData setup into QWebNetworkRequest::init.

06:49 Changeset [22092] by hausmann

Moved HTTP header field propagation to QWebNetworkRequest::init.

06:48 Changeset [22091] by hausmann

Started moving the code to separate a WebCore::ResourceRequest into a QUrl, postData
and QHttpRequestHeader into a separate little QWebNetworkRequest struct.

00:30 Changeset [22090] by zack

Forgot to export the plugin exporter. Fixing it.


18:02 Changeset [22089] by ggaren

Reviewed by Beth Dakin.

Made confusing work-around to ObjC bindings bug <rdar://problem/5262101>
less confusing.

Fixed test to actually call queueReload.

  • fast/frames/resources/iframe-focus.html:
15:58 Changeset [22088] by bdash

2007-06-10 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Maciej.

Disable whole-view editing for the Gdk port in order to improve the browsing experience.

  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::isEditable): Return false to disable whole-view editing
15:18 Changeset [22087] by bdakin

Reviewed by Adele.

Fix for http://bugs.webkit.org/show_bug.cgi?id=13933 REGRESSION:
fast/history/clicked-link-is-visited is failing

  • fast/frames/resources/iframe-focus.html: Cause the page to reload with layoutTestController.queueReload instead of using JavaScript to reload. Using JS seems to get DRT's history all messed up (off by one?!).
13:50 Changeset [22086] by sfalken

New tag.

12:41 Changeset [22085] by ggaren

Reviewed by Beth Dakin.

Cleaned up formatting on the check out page.

  • building/checkout.html:
00:14 Changeset [22084] by hyatt

Fix for bug 14037, make sure respondsToSelector does the write thing
when invoked on a WebKit plugin's container view.

Reviewed by Mark Rowe

  • Plugins/WebKitPluginContainerView.mm: (-[WebKitPluginContainerView respondsToSelector:]):


23:24 Changeset [23460] by sfalken

Reviewed by Adam.

Workaround: <rdar://problem/5213266> schwab.com menu is ridiculously big.

  • WebView.cpp: (WebView::userAgentForKURL): Add schwab to spoof list to fix gigantic menus.
15:14 Changeset [22083] by sfalken

New tag.

15:12 Changeset [22082] by sfalken

Remove unnecessary tag.

14:56 Changeset [22081] by sfalken

New tag.

12:48 Changeset [23459] by weinig

Build fix.

  • WebCore.vcproj/WebCore.vcproj:


23:00 Changeset [22080] by weinig


Reviewed by Oliver.

Update test for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection.

  • tables/mozilla/bugs/bug53690-1-expected.txt: Now throws Undefined Error instead of Null Error


Reviewed by Oliver.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection

  • also moves JSHTMLAllCollection into it's own file.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAllCollection.h: Added. (WebCore::JSHTMLAllCollection::JSHTMLAllCollection): (WebCore::JSHTMLAllCollection::toBoolean): (WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
  • bindings/js/JSHTMLCollectionCustom.cpp: Added. (WebCore::getNamedItems): (WebCore::JSHTMLCollection::callAsFunction): (WebCore::JSHTMLCollection::implementsCall): (WebCore::JSHTMLCollection::canGetItemsForName): (WebCore::JSHTMLCollection::nameGetter): (WebCore::JSHTMLCollection::item): (WebCore::JSHTMLCollection::namedItem): (WebCore::toJS):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all):
  • bindings/js/JSXMLHttpRequest.cpp:
  • bindings/js/kjs_html.cpp: (WebCore::ImageConstructorImp::ImageConstructorImp): (WebCore::ImageConstructorImp::construct):
  • bindings/js/kjs_html.h: (WebCore::ImageConstructorImp::implementsConstruct):
  • bindings/js/kjs_window.cpp: (KJS::Window::namedItemGetter):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::tags):
  • html/HTMLCollection.h: (WebCore::HTMLCollection::collectionType):
  • html/HTMLCollection.idl:
  • html/HTMLOptionsCollection.idl:
20:13 Changeset [22079] by sfalken

New tag.

20:12 Changeset [22078] by sfalken

Remove unnecessary tag.

20:07 Changeset [22077] by sfalken

New tag.

19:46 Changeset [23458] by adachan

2007-06-08 Ada Chan <adachan@apple.com>

Reviewed by Hyatt, Adam, and Steve.

Fixed WebView::selectedText to get the selected text out of the focused frame or main frame.

  • WebView.cpp: (WebView::selectedText):
18:12 Changeset [23457] by aroben

Get rid of the Safari part of the query string used for Google searches.

Reviewed by Steve and Ada.

  • WebContextMenuClient.cpp:


17:25 Changeset [23456] by andersca

Reviewed by Adam.

If both the old and new WMP plugins are present, remove the old one
so we won't end up choosing it.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::getPluginsInPaths):
16:37 Changeset [23455] by kmccullo

Reviewed by Kevin Decker, and Sam.

  • Added and updated licenses.
16:10 Changeset [23454] by hyatt

Update licenses/copyrights for WebCoreWin.

Reviewed by mccullough

15:54 Changeset [23453] by kmccullo


Reviewed by Hyatt.

  • Added license.
  • win/Skipped:


Reviewed by Hyatt.

  • Updated license.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.h:
13:03 Changeset [22076] by bdakin

Reviewed by Brady.

Fix for http://trac.webkit.org/projects/webkit/changeset/21738

This test started failing after Adele's r21738. After investigating
this, it turns out that it just needs updated results. This test
happened to tickle the very bug that Adele fixed.

  • http/tests/navigation/relativeanchor-goback-expected.txt:
11:10 Changeset [22075] by justing


Reviewed by John.

<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

  • editing/selection/5232159-expected.checksum: Added.
  • editing/selection/5232159-expected.png: Added.
  • editing/selection/5232159-expected.txt: Added.
  • editing/selection/5232159.html: Added.


Reviewed by John.

<rdar://problem/5232159> REGRESSION: Cannot select text in RSS view

The selection is updated both on mouse movement and
when the autoscroll timer fires. The autoscroll
code wasn't converting mouse coordinates to layer
coordinates correctly, and was then using those
coordinates to create a bad selection.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.
09:38 Changeset [22074] by sullivan
  • WebView/WebViewPrivate.h: Added a FIXME
09:37 Changeset [22073] by kevino

Set <debug-runtime-libs> usually defers to <debug-info> for its setting, but in case we have release wx libs, or wxPython libs, we have to adjust the settings to match those.

09:09 Changeset [22072] by kevino

Check to make sure the window is fully initialized before running.

08:17 Changeset [22071] by andersca

Reviewed by Geoff.

Store the root object in a hash set, keyed by the plugin view. This is in preparation for
letting plugins invalidate the root object upon destruction

  • page/Frame.cpp: (WebCore::Frame::createRootObject): (WebCore::Frame::cleanupScriptObjects):
  • page/FramePrivate.h:
06:01 Changeset [22070] by lars

Forgot to checkin this part in my last submit.

05:44 Changeset [22069] by lars

Reviewed by Zack.

Add a QWebObjectPluginConnector class. The class will
facility communication between the plugin and WebKit.
Currently it's used to make the plugin network capable.

04:40 Changeset [22068] by rwlbuis

Reviewed by Eric.

SVGPathElement should not inherit from SVGPathParser

Use path builders for building Path and PathSegLists.

03:08 Changeset [22067] by zack

Fix the Qt build

02:18 Changeset [22066] by eseidel

2007-06-06 Eric Seidel <eric@webkit.org>

Reviewed by olliej.

Add support for tabbing between links in an SVG file
Also add support for drawing a focus ring around focused svg content.

Layout test is blocked by http://bugs.webkit.org/show_bug.cgi?id=14027

  • css/svg.css:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): (WebCore::SVGAElement::supportsFocus): (WebCore::SVGAElement::isFocusable): (WebCore::SVGAElement::isMouseFocusable): (WebCore::SVGAElement::isKeyboardFocusable):
  • ksvg2/svg/SVGAElement.h:
00:17 Changeset [22065] by justing


Reviewed by Tristan.

<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

  • WebCore.exp: Added clearUndoRedoOperations.
  • page/Page.cpp: (WebCore::Page::clearUndoRedoOperations): Added.
  • page/Page.h:


Reviewed by Tristan.

<rdar://problem/5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab

  • WebView/WebView.mm: (-[WebView _clearUndoRedoOperations]): Added.
  • WebView/WebViewPrivate.h:
Note: See TracTimeline for information about the timeline view.