Timeline



Aug 21, 2007:

11:33 PM Changeset in webkit [25183] by rwlbuis
  • 10 edits in branches/feature-branch

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)

Reuse the css parser as much as possible in setRGBColor.

6:35 PM Changeset in webkit [25182] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added a couple more failures.
4:40 PM Changeset in webkit [25181] by aroben
  • 2 edits in trunk/LayoutTests
  • platform/win/Skipped: Added some more failing tests.
3:32 PM Changeset in webkit [25180] by adachan
  • 2 edits in trunk/WebKit/win

Fix <rdar://problem/5416630> Accelerator to open link in window in background opens window in foreground instead
Placing tooltip window at the topmost in z-order brought windows that were opened in the
background to the front. Use HWND_TOP instead.

Reviewed by Adam.


  • WebView.cpp: (WebView::initializeToolTipWindow):
3:08 PM Changeset in webkit [25179] by aroben
  • 3 edits in trunk/WebCore

Build fix for Mac

Keep FrameView::layoutIfNeededRecursive Windows- and Gtk-only for now
(sadly). This will have to wait until we merge ScrollView and FrameView.

Reviewed by NOBODY.

  • page/FrameView.cpp:
  • page/FrameView.h:
2:49 PM Changeset in webkit [25178] by aroben
  • 2 edits in trunk/WebCore

Fix an ASSERT when using Find in Page

Reviewed by Darin.

No test possible.

  • bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Make sure to update layout before painting so we don't hit an ASSERT in painting code (Frame::selectionImage in FrameMac.mm does this as well).
2:49 PM Changeset in webkit [25177] by aroben
  • 7 edits in trunk

Switch Windows to using FrameView::layoutIfNeededRecursive

WebCore:

Made FrameView::layoutIfNeededRecursive available to all platforms

Currently it's only used on Gtk+ and Windows.

Reviewed by Darin.

  • page/FrameView.cpp: Removed #ifdef.
  • page/FrameView.h: Ditto.

WebKit/win:

Switch Windows to using FrameView::layoutIfNeededRecursive

Reviewed by Darin.

  • WebFrame.cpp: Removed layoutIfNeededRecursive.
  • WebFrame.h: Ditto.
  • WebView.cpp: (WebView::updateBackingStore): Call FrameView::layoutIfNeededRecursive.
2:44 PM Changeset in webkit [25176] by zimmermann
  • 2 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Allow to pass a filename to dumpOutputImage via debugger.
Make it only available in debug builds and remove the runtime define: DEBUG_OUTPUT_IMAGE.

2:28 PM Changeset in webkit [25175] by zimmermann
  • 195 edits in branches/feature-branch

Reviewed by Oliver.

Large SVG filter rework. Bring it back in a useable state.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)

filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.

In detail:

  • flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
  • sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
  • add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
  • WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
  • Correctly specify default values for all filter primitives in ksvg2/svg!
  • Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
  • Fix 'flood-color' initial value (was set to the _stop_ color initial value)

-> both initial values were pointing to 'black' though, so it was no visible problem.

  • Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.

-> Correct it's initial from black to white value fixes SVG lighting filters!

  • Add diffuseConstant support to feDiffuseLighting filter.
  • Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)
12:12 PM Changeset in webkit [25174] by adele
  • 2 edits in trunk/WebCore

Build fix for release build.

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):
11:01 AM Changeset in webkit [25173] by spadma
  • 2 edits in S60/trunk/WebKit

2007-08-02 vmalaiya, <​vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: ZBUS-744GX5 - No key events for text input
​http://bugs.webkit.org/show_bug.cgi?id=13877

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
10:59 AM Changeset in webkit [25172] by spadma
  • 3 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin>

DESC: Fast display mode must be turned OFF for widgets
​http://bugs.webkit.org/show_bug.cgi?id=14966

  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
  • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):
10:57 AM Changeset in webkit [25171] by adele
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Darin.

Test: fast/table/max-width-integer-overflow.html

Avoid integer overflows when dealing with maximum widths by
1) using floating point arithmetic when summing or multiplying column max widths
2) capping max widths at INT_MAX / 2

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):

LayoutTests:

Reviewed by Darin.

  • fast/table/max-width-integer-overflow.html: Added.
  • platform/mac/fast/table: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.checksum: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.png: Added.
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt: Added.
9:28 AM Changeset in webkit [25170] by sullivan
  • 1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

7:32 AM Changeset in webkit [25169] by sullivan
  • 17 edits
    1 add in trunk

WebCore:

Reviewed by Adam Roben

WebCore part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings


Adele wrote the first version of this patch. No test cases added because I made sure the
layout tests are unaffected. Two additional bug fixes were made in passing, but neither
of them had any effect on any known real-world case, and both were too difficult to write
test cases for to be worthwhile.

  • WebCore.exp: added symbols for these new functions so WebKit can call them


  • WebCore.xcodeproj/project.pbxproj: updated for new file


  • platform/graphics/mac/ColorMac.h: Added. New file to hold the increasing amount of Mac-specific color stuff.


  • platform/graphics/Color.h: removed #if PLATFORM(MAC) code, which is now in ColorMac.h


  • platform/graphics/mac/ColorMac.mm: (WebCore::makeRGBAFromNSColor): new static function to convert an NSColor object to an RGBA32 struct (WebCore::colorFromNSColor): new public function to convert an NSColor object to a WebCore-style Color object (WebCore::focusRingColor): Uses (cached) systemFocusRingColor instead of hardwired values, unless usesTestModeFocusRingColor is true, in which case it uses the old hardwired color (WebCore::usesTestModeFocusRingColor): returns value of global var (WebCore::setUsesTestModeFocusRingColor): sets value of global var (+[WebCoreControlTintObserver controlTintDidChange]): Uses [NSColor keyboardFocusIndicatorColor] to set systemFocusRingColor; don't compile if COLORMATCH_EVERYTHING is set since we don't know what it would take to satisfy this state.
  • bindings/objc/DOMRGBColor.mm: now includes ColorMac.h to account for moved declarations
  • bridge/mac/WebCoreAXObject.mm: ditto


  • page/mac/FrameMac.mm: (WebCore::convertAttributesToUnderlines): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only used to convert the color of an input manager's marked text underline, which is always black


  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only called with a grayscale color perhaps containing an alpha value


  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): just updated a comment

WebKit:

Reviewed by Adam Roben


WebKit part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

  • Misc/WebNSAttributedStringExtras.mm: now includes <WebCore/ColorMac.h> to account for moved declaration
  • WebView/WebFrame.mm: ditto


  • WebView/WebViewPrivate.h:
  • WebView/WebView.mm: (+[WebView _setUsesTestModeFocusRingColor:]): new SPI, calls through to new WebCore function. This is used by DumpRenderTree to make sure the focus ring color is always the same when performing layout tests, regardless of OS X version. (+[WebView _usesTestModeFocusRingColor]): new SPI, calls through to new WebCore function

WebKitTools:

Reviewed by Adam Roben

  • DumpRenderTree/DumpRenderTree.m: (runTest): call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors in layout tests on Tiger and Leopard

Aug 20, 2007:

6:37 PM Changeset in webkit [25168] by pewtermoose
  • 3 edits
    6 adds in trunk

WebCore:

2007-08-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/repaint/layer-visibility.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): Cache the layer's rects when it changes to visible.

LayoutTests:

2007-08-20 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/repaint/layer-visibility.html: Added.
  • platform/mac/fast: Added.
  • platform/mac/fast/repaint: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.checksum: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.png: Added.
  • platform/mac/fast/repaint/layer-visibility-expected.txt: Added.
5:14 PM Changeset in webkit [25167] by aroben
  • 2 edits in trunk/WebKitSite

Remove any mention of drwtsn32.log, as it is almost never useful for tracking down crashes

Reviewed by Oliver.

  • quality/crashlogs.html:
5:08 PM Changeset in webkit [25166] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/5325262> REGRESSION (Tiger-Leopard): PictureTalk plug-in doesn't work

The problem was that this particular plug-in handles "text/ptf", but WebCore wasn't giving the plug-in a chance to load
any type with "text/"

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Allow plug-ins to once again use "text/" MIME types, but only if the MIME type is not "text/plain". Disallowing plug-ins to use text/plain prevents plug-ins from hijacking a fundamental type that the browser is expected to handle, and also serves as an optimization to prevent loading the plug-in database in the common case.
4:46 PM Changeset in webkit [25165] by aroben
  • 2 edits in trunk/LayoutTests

Removed a now-working test from the Windows Skipped file

  • platform/win/Skipped:
4:36 PM Changeset in webkit [25164] by aroben
  • 2 edits in trunk/WebKitTools

Put LayoutTests after all other ChangeLogs in commit logs

We use "~" to sort LayoutTests after all the other ChangeLogs because
"~" is the last ASCII character (other than "DEL").

Reviewed by Sam.

  • Scripts/commit-log-editor:
4:18 PM Changeset in webkit [25163] by aroben
  • 2 edits in trunk/WebKitTools

Detect that DRT crashed even if a crash dialog is running

On Windows, when DRT crashes a crash dialog commonly appears. The DRT
process is still running at this point, so run-webkit-tests wouldn't
detect that DRT had crashed. We now record the crash in our SIGPIPE
handler so that we know if DRT crashed even if the crash dialog is up.

Reviewed by Sam.

  • Scripts/run-webkit-tests: (sub catch_pipe): Set the crashed bit. (sub openDumpTool): Reset the crashed bit. (sub dumpToolDidCrash): Check the crashed bit.
4:04 PM Changeset in webkit [25162] by aroben
  • 3 edits
    4 adds in trunk

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

WebCore:

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

Reviewed by Darin.

Tests: fast/loader/local-svg-parsed-as-svg.svg

fast/loader/local-xhtml-parsed-as-xhtml.xhtml

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Removed hackish workaround.

LayoutTests:

Tests to ensure that local .xhtml and .svg files end up being parsed as XHTML and SVG, respectively

Reviewed by Darin.

  • fast/loader/local-svg-parsed-as-svg-expected.txt: Added.
  • fast/loader/local-svg-parsed-as-svg.svg: Added.
  • fast/loader/local-xhtml-parsed-as-xhtml-expected.txt: Added.
  • fast/loader/local-xhtml-parsed-as-xhtml.xhtml: Added.
3:05 PM Changeset in webkit [25161] by kmccullo
  • 3 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Geoff and Adam.

  • Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)
  • kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

  • Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).
  • fast/js/deep-recursion-test-expected.txt: Added.
  • fast/js/deep-recursion-test.html: Added.
2:41 PM Changeset in webkit [25160] by aroben
  • 2 edits in trunk/WebKitTools

Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog

​http://bugs.webkit.org/show_bug.cgi?id=15026

Reviewed by NOBODY (OOPS!).

  • Scripts/prepare-ChangeLog: (sub isModifiedStatus): Split out from isModifiedOrAddedStatus. (sub isAddedStatus): Ditto. (sub testListForChangeLog): Added.
1:32 PM Changeset in webkit [25159] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5412988>
Crash when visiting ​http://www.rockonflash.com/blog/?p=58


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Just return if the plugin view hasn't been inserted in the hierarchy yet.
11:10 AM Changeset in webkit [25158] by antti
  • 2 edits in trunk/WebKit

Reviewed by John.


Fix <rdar://problem/5378390>
Crash at Range::startContainer() when creating multiple ToDos on the same line


Null check range.


No layout test, this only happens with ObjC API.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]):
6:30 AM Changeset in webkit [25157] by zecke
  • 2 edits in trunk/WebCore

2007-08-20 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Zack.

Do not define svg as ImageMIMEType if we can use ksvg2.

  • platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
12:11 AM Changeset in webkit [25156] by mjs
  • 2 edits in trunk/WebKit

Not reviewed, fix for crash on launch bug in last patch.

  • WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): Remove an assertion, fix code to work right in the face of that condition.
12:04 AM Changeset in webkit [25155] by rwlbuis
  • 3 edits
    4 adds in branches/feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly

Use the bounding box before transformation.

12:01 AM Changeset in webkit [25154] by mjs
  • 6 edits in trunk/LayoutTests

Not reviewed - test case fixes.


  • fix some test cases where expected results were altered by the last change (I reviewed all the new results.)
  • fast/events/focusingUnloadedFrame-expected.txt:
  • http/tests/loading/simple-subframe-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
  • webarchive/loading/test-loading-archive-expected.txt:

Aug 19, 2007:

5:04 PM Changeset in webkit [25153] by aroben
  • 2 edits in trunk/WebCore

Gtk+ build fix.

  • platform/gdk/TemporaryLinkStubs.cpp: Removed const.
3:07 PM Changeset in webkit [25152] by aroben
  • 7 edits in trunk/WebCore

Fix <rdar://5395835> REGRESSION (r24527): Context menu for edit fields is missing "Font & Writing Direction"

The problem was that ContextMenuItem::setSubMenu was just copying the
HMENU from the ContextMenu passed in on Windows, but that HMENU was
later getting destroyed when the ContextMenu went out of scope.

I added a new ContextMenu::releasePlatformDescription method that is
used in setSubMenu instead. I think an ultimately better design would
be for setSubMenu to take ownership of the ContextMenu that's passed in
(as should insertItem and appendItem), but I decided to be conservative
and just make the changes needed to fix the bug.

Reviewed by Darin.

No test possible.

  • platform/ContextMenu.h: Added releasePlatformDescription.
  • platform/gdk/TemporaryLinkStubs.cpp: Added stub implementation.
  • platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::releasePlatformDescription): Implemented, though it's never called on this platform.
  • platform/qt/ContextMenuQt.cpp: (WebCore::ContextMenu::releasePlatformDescription): Ditto.
  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::setSubMenu): Call releasePlatformDescription since we need to take ownership of the HMENU.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::releasePlatformDescription): Implemented.
2:40 PM Changeset in webkit [25151] by mjs
  • 11 edits in trunk

LayoutTests:

Reviewed by Darin.

  • update for fix to <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)


No longer expect windowScriptObject delegate method in frames that never
use script.

  • http/tests/loading/bad-scheme-subframe-expected.txt:
  • http/tests/loading/bad-server-subframe-expected.txt:
  • http/tests/loading/empty-subframe-expected.txt:
  • http/tests/loading/slow-parsing-subframe-expected.txt:

WebCore:

Reviewed by Darin.

  • fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)


There were three main cuases of extra time due to creating the initial empty document:


1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.


The WebCore part of the fixes addresses 2 and 3.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Don't parse "<html><body>" for the initial empty document; it turns out not to be needed. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Don't dispatch the delegate if we haven't created a ScriptInterpreter yet.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Dispatch the window object delegate when we first create the interpreter, since that is now done lazily.
  • loader/FrameLoader.h: (WebCore::FrameLoader::committingFirstRealLoad): Helper for WebKit to know when to reuse a WebHTMLView.

WebKit:

Reviewed by Darin.


  • fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:


1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.


The WebKit part of the fixes addresses 1.

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): When switching from the initial empty document to the first real document, reuse the WebHTMLView.


It might actually be a significant performance improvement to always
reuse the WebHTMLView, but that is a much riskier change and not
needed to fix the regression right now.

11:26 AM Changeset in webkit [25150] by pewtermoose
  • 3 edits
    2 adds in trunk

LayoutTests:

2007-08-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam Roben.

  • fast/images/text-content-crash-2-expected.txt: Added.
  • fast/images/text-content-crash-2.html: Added.

WebCore:

2007-08-19 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam Roben.

Test: fast/images/text-content-crash-2.html

  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): Added a check that the renderer is an image. (WebCore::HTMLImageLoader::updateFromElement): Ditto. (WebCore::HTMLImageLoader::notifyFinished): Ditto.
10:10 AM Changeset in webkit [25149] by staikos
  • 2 edits in trunk/WebKitQt

Don't export ICO symbols

9:51 AM Changeset in webkit [25148] by ddkilzer
  • 1 edit
    2 adds in trunk/LayoutTests

LayoutTests:

Reviewed by Adam and Geoff within one minute of each other.

Tests that the '-apple-opacity', '-khtml-opacity' and '-webkit-opacity' styles
all map to the 'opacity' style.

  • fast/css/legacy-opacity-styles-expected.txt: Added.
  • fast/css/legacy-opacity-styles.html: Added.
5:07 AM Changeset in webkit [25147] by bdash
  • 2 edits in trunk/LayoutTests

2007-08-19 Mark Rowe <​mrowe@apple.com>

Update expected results. The results that were landed with the test did not match the wording
in the test that was landed.

  • fast/encoding/namespace-tolerance-expected.txt:
4:13 AM Changeset in webkit [25146] by zecke
  • 2 edits in trunk/WebKitTools

2007-08-19 Oleg Sukhodolsky <​son.two@gmail.com>

Reviewed by Mark.

-fixes ​http://bugs.webkit.org/show_bug.cgi?id=14632

  • Scripts/webkitdirs.pm: qt and gtk ports now explicitly pass debug (or release) mode to qmake.
1:05 AM Changeset in webkit [25145] by rwlbuis
  • 33 edits
    4 adds in branches/feature-branch

Reviewed by Nikolas.

​http://bugs.webkit.org/show_bug.cgi?id=14926
WebKit has 'em' length handling problems related to CSS properties

Parse the properties in inline style attributes non-strict for SVG.

Aug 18, 2007:

10:15 PM Changeset in webkit [25144] by staikos
  • 3 edits in trunk/WebKitQt

Fix compilation

11:20 AM Changeset in webkit [25143] by zecke
  • 2 edits in trunk/WebKit/gtk

2007-08-18 Holger Hans Peter Freyther <​zecke@selfish.org>

Build fix. Add const to the first parameter of createPlugin

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

Aug 17, 2007:

8:48 PM Changeset in webkit [25142] by mjs
  • 4 edits in trunk

WebCore:

Reviewed by Darin.

  • WebCore part of fix to scrollbar suppression hack for Leopard
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Suppress scrollbars earlier, so it happens before any potential view swap.

WebKit:

Reviewed by Darin.

  • WebKit part of fix to scrollbar suppression hack for Leopard
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView reflectScrolledClipView:]): Don't call the superclass method when scrollbars are suppressed. (-[WebDynamicScrollBarsView setScrollBarsSuppressed:repaintOnUnsuppress:]): Instead call it here, when unsuppressing.
7:41 PM Changeset in webkit [25141] by bdash
  • 1 copy in tags/Safari-4523.1

New tag.

7:00 PM Changeset in webkit [25140] by aroben
  • 8 edits
    1 add in trunk/WebKit/win

Fix <rdar://5192578> Inspect Element should not appear in context menu in non-debug mode

We now follow the same logic as Mac WebKit for displaying the Inspect Element item:

1) If DisableWebKitDeveloperExtras is set to true, don't display it
2) If not, and we're in a debug build, display it
3) If not, and we're in a release build, display it if

WebKitDeveloperExtras is set to true

Reviewed by Ada.

  • Interfaces/IWebPreferencesPrivate.idl: Added.
  • WebKit.vcproj/Interfaces.vcproj: Add new IWebPreferencesPrivate.idl file to project.
  • WebKit.vcproj/WebKitGUID.vcproj: Added generated .c file for IWebPreferencesPrivate to project.
  • WebPreferenceKeysPrivate.h: Added new keys.
  • WebPreferences.cpp: Added IID_WebPreferences. (WebPreferences::postPreferencesChangesNotification): Added an explicit cast needed now that WebPreferences implements two interfaces. (WebPreferences::QueryInterface): Added new cases. (WebPreferences::setDeveloperExtrasEnabled): Added. (WebPreferences::developerExtrasEnabled): Added. (WebPreferences::developerExtrasDisabledByOverride): Added.
  • WebPreferences.h: Now implements IWebPreferencesPrivate.
  • WebView.cpp: (WebView::updateWebCoreSettingsFromPreferences): Call developerExtrasEnabled. (WebView::developerExtrasEnabled): Ported from -[WebView _developerExtrasEnabled].
  • WebView.h:
7:00 PM Changeset in webkit [25139] by aroben
  • 6 edits in trunk/WebKit/win

Add WebPreferences::sharedStandardPreferences

This is a convenience method to get the standard preferences object so
that within WebKit we don't have to deal with the fact that COM doesn't
support static methods.

Reviewed by Ada.

  • WebHistory.cpp: (WebHistory::WebHistory): Use sharedStandardPreferences.
  • WebIconDatabase.cpp: (WebIconDatabase::init): Ditto.
  • WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): Added. (WebPreferences::getInstanceForIdentifier): Use sharedStandardPreferences. (WebPreferences::standardPreferences): Ditto.
  • WebPreferences.h:
  • WebView.cpp: (WebView::preferences): Ditto.
6:23 PM Changeset in webkit [25138] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Oliver Hunt.

  • don't look for Apple-style localizable strings in the GTK version of WebKit
  • Scripts/extract-localizable-strings: Add a feature where you can pass in the name of subdirectories to skip.
  • Scripts/update-webkit-localizable-strings: Pass WebKit/gtk as a subdirectory to skip.
6:08 PM Changeset in webkit [25137] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • fix <rdar://problem/5414518> Use root URL as origin URL when quarantining downloads
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setOriginalURLForDownload): Extract only the scheme and host name and make the originating URL from that.
  • WebKit/StringsNotToBeLocalized.txt: Updated for recent changes.
5:04 PM Changeset in webkit [25136] by andersca
  • 3 edits in trunk/WebKit/gtk

Build fix.


  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createPlugin):
  • WebCoreSupport/FrameLoaderClientGtk.h:
5:01 PM Changeset in webkit [25135] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Fix a spelling mistake.

4:53 PM Changeset in webkit [25134] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5398301> Xcode threw mutation exception while enumerating subviews (GC only)

I was never able to reproduce this exception. But there can be cases where layout will
trigger JavaScript or plugin code that can modify the WebView view hierarchy during a
recursive enumeration of all the subviews.

This patch does two things:
1) Adds a check in debug builds that will LOG when any view is added or removed during layout.
Noting that added views will not recieve layout this round and might paint without first recieving layout.

2) Recursivly builds up an array of descendant WebHTMLViews before calling layout on them.
This matches the behavior of makeObjectsPerformSelector: in the non-GC case (making a copy
before enumerating.)

  • WebView/WebHTMLView.mm: (-[WebHTMLView _web_setPrintingModeRecursive]): Use _web_addDescendantWebHTMLViewsToArray to build up an array of WebHTMLViews to enumerate. (-[WebHTMLView _web_clearPrintingModeRecursive]): Ditto. (-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]): Ditto. (-[WebHTMLView _web_layoutIfNeededRecursive]): Ditto. (-[WebHTMLView _layoutIfNeeded]): Moved to WebHTMLViewFileInternal category. (-[WebHTMLView didAddSubview:]): LOG in debug builds. (-[WebHTMLView willRemoveSubview:]): Ditto. (-[NSView _web_addDescendantWebHTMLViewsToArray:]): Recursivly build an array of descendant WebHTMLViews.
  • WebView/WebHTMLViewInternal.h: Added a BOOL in WebHTMLViewPrivate to track subview changes (debug only.)
4:45 PM Changeset in webkit [25133] by andersca
  • 2 edits in trunk/WebKitTools

Build fix.


  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_SetWindow):
4:29 PM Changeset in webkit [25132] by antti
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/5403773>
CrashTracer: [USER] 88 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 846


Changed results for fast/dynamic/containing-block-change.html are progression
(even though new results don't match Firefox and old ones did!)

  • fast/dynamic/ancestor-to-absolute-expected.txt: Added.
  • fast/dynamic/ancestor-to-absolute.html: Added.
  • fast/dynamic/containing-block-change-expected.checksum:
  • fast/dynamic/containing-block-change-expected.png:
  • fast/dynamic/containing-block-change-expected.txt:

WebCore:

Reviewed by Hyatt.


Fix <rdar://problem/5403773>
CrashTracer: [USER] 88 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::paint + 846

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::removePositionedObjects):


Fix crash in ​http://www.infobae.com/interior/home.html
Positioned objects removed from m_positionedObjects would in some cases not get added back to any
positioned objects list. Adding objects happens in block layout but since layout was not invalidated
correctly in removePositionedObjects() it would not get invoked. As a result some positioned objects
would stay in layout dirty state leading to crashes and other bad things.


  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paint):


Add needLayout() guard to eliminate this class of crashes from release builds.
Assert commented out for now since one existing layout test can't handle it.

3:58 PM Changeset in webkit [25131] by andersca
  • 3 edits in trunk/WebKit/win

Build fix.


  • WebFrame.cpp: (WebFrame::createPlugin):
  • WebFrame.h:
3:48 PM Changeset in webkit [25130] by kdecker
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

<rdar://problem/5252836> Adobe Help Viewer: Japanese characters in the Help Tree structure are shown as garbage
This test ensures a UTF-8 encoding is properly set. The code tests compatibility of documents which:

(1) use namespace prefixes on HTML elements
(2) specify a non-latin charset
(3) contain non-latin characters


If this test passes, the UTF-8 character below should exactly match the character the character in namespace-tolerance-expected.txt.

  • fast/encoding/namespace-tolerance-expected.txt: Added.
  • fast/encoding/namespace-tolerance.html: Added.
3:45 PM Changeset in webkit [25129] by kdecker
  • 2 edits in trunk/WebCore

2007-08-17 Kevin Decker <​kdecker@apple.com>

Code change by Darin, landed and reviewed by me.

Fixed: <rdar://problem/5252836> Adobe Help Viewer: Japanese characters in the Help Tree structure are shown as garbage
Added fast/encoding/namespace-tolerance.html test.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Slightly loosen the charset decoder heuristic by tweaking it to ignore namespaces. This restores compatibility to documents which (1) use namespace prefixes on HTML elements (2) specify a non-latin charset and (3) contain non-latin characters.


Added fast/encoding/namespace-tolerance.html test.

3:12 PM Changeset in webkit [25128] by andersca
  • 21 edits
    2 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.

<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes


Add test.


  • plugins/netscape-plugin-setwindow-size-expected.txt: Added.
  • plugins/netscape-plugin-setwindow-size.html: Added.

WebCore:

Reviewed by Dave Hyatt.


<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes

Instantiate plug-ins during the first layout instead of doing so when creating the renderer.
This ensures that the plug-in widget will have a correct initial size.


  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance): Force a layout if the plug-in doesn't have an instance.


(WebCore::HTMLEmbedElement::attach):
Pass true to updateWidget, causing it to only create a widget if it won't be a plug-in.


  • html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Pass false to updateWidget, this will only create subframes anyway.


  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance): Force a layout if the plug-in doesn't have an instance.


(WebCore::HTMLObjectElement::attach):
Pass true to updateWidget, causing it to only create a widget if it won't be a plug-in.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin): Get the size from the renderer and pass it to the client.


  • loader/FrameLoaderClient.h:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::createPlugin): Update declarations.


  • rendering/RenderPart.cpp: (WebCore::RenderPart::setWidget): No need to mark the renderer as dirty here.


  • rendering/RenderPartObject.h:
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Add a parameter, onlyCreateNonPlugins. If this is true the widget will only be created if it's not a plug-in.


(WebCore::RenderPartObject::layout):
Call updateWidget here if m_widget is 0, causing the plug-in to be instantiated.

WebKit:

Reviewed by Dave Hyatt.

<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes


Pass the right size when creating the views.


  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge viewForPluginWithFrame:URL:attributeNames:attributeValues:MIMEType:DOMElement:loadManually:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::createPlugin):

WebKitTools:

Reviewed by Dave Hyatt.

<rdar://problem/5379040>
REGRESSION (Tiger-Leopard): ADOBE: Safari calls NPP_SetWindow with bad values sometimes

Add a way for the plug-in to dump the width and height when it gets its NPP_SetWindow call.


  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_New): (NPP_SetWindow):
1:50 PM Changeset in webkit [25127] by zbujtas
  • 3 edits in S60/trunk/WebCore

rathnasa, reviewed by Zbujtas

DESC: TSW Id SJUN-73XBVC document.write does not work in onload, onclick events
​http://bugs.webkit.org/show_bug.cgi?id=14915

WARNING: NO TEST CASES ADDED OR CHANGED

1:48 PM Changeset in webkit [25126] by zbujtas
  • 3 edits in S60/branches/3.1m/WebCore

2007-08-09 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by zbujtas
DESC: TSW Id SJUN-73XBVC document.write does not work in onload, onclick events

​http://bugs.webkit.org/show_bug.cgi?id=14915

1:10 PM Changeset in webkit [25125] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Correct ChangeLog to reference correct person

1:42 AM Changeset in webkit [25124] by oliver
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Simple test to ensure we don't crash when creating a pattern

  • fast/canvas/create-pattern-does-not-crash-expected.txt: Added.
  • fast/canvas/create-pattern-does-not-crash.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=14189
<rdar://problem/5319511> REPRODUCIBLE CRASH: Canvas createPattern(canvas, ...) crashes on Windows (14189)

Ensure that we actually retain the CG pattern correctly.

Credit to Philip Taylor <​excors@gmail.com> for finding the cause of this.

  • html/CanvasPattern.cpp: (WebCore::CanvasPattern::~CanvasPattern): (WebCore::CanvasPattern::createPattern):
  • html/CanvasPattern.h: (WebCore::CanvasPattern::platformImage):
Note: See TracTimeline for information about the timeline view.