Timeline



May 27, 2008:

9:31 PM Changeset in webkit [34168] by mrowe@apple.com
  • 3 edits in tags/Safari-6526.8.1/JavaScriptCore

Merge r34165.

9:28 PM Changeset in webkit [34167] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.8.1

New tag.

9:20 PM Changeset in webkit [34166] by justin.garcia@apple.com
  • 6 edits in trunk

WebCore:

2008-05-27 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Oliver.

<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)


It wasn't enough to break out of the header, to match other browsers we
also need to not preserve the typing style.

  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertParagraphSeparatorCommand.h:

LayoutTests:

2008-05-27 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Oliver.


<rdar://problem/5803706> Pressing return at the end of a header doesn't break out of header (17460)

  • editing/inserting/5803706-1-expected.txt: Adjust this already checked-in test to reflect the new expected behavior.
  • editing/inserting/5803706-1.html:
8:54 PM Changeset in webkit [34165] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Remove code that appended Cygwin's /bin directory to PATH.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Prepend Cygwin's /bin directory to PATH. We prepend instead of append so that Cygwin's utilities will win out over Win32 versions of the same utilities (particularly perl). We do the prepend here instead of in the Makefile because nmake doesn't seem to like prepending to PATH inside the Makefile. This also matches the way WebCoreGenerated works.
8:54 PM Changeset in webkit [34164] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Roll out r34163

A better fix is on the way.

  • DerivedSources.make:
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh:
8:31 PM Changeset in webkit [34163] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Windows build fix

  • DerivedSources.make: Don't generate the bytecode docs if OMIT_BYTECODE_DOCS is set to 1.
  • JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Set OMIT_BYTECODE_DOCS for production builds.
7:45 PM Changeset in webkit [34162] by timothy@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/5966961> REGRESSION: Font previews in the Web
Inspector always show in Lucida Grande (not the real font)

Reviewed by Adam Roben.

  • page/inspector/FontView.js: Add a style element that loads the

@font-face rule that is excepted by the preview element.

7:45 PM Changeset in webkit [34161] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a regression where the Image and Font preview views do not
size correctly.

<rdar://problem/5966723> REGRESSION (r33991): Image and font previews
are shrunken and can't be made larger (19281)

Reviewed by Adam Roben.

  • page/inspector/FontView.js: Adjust the font size based only on the

container width minus padding.

  • page/inspector/inspector.css: Updated styles for the image and

font views.

5:44 PM Changeset in webkit [34160] by andersca@apple.com
  • 3 edits
    3 adds in trunk

JavaScriptCore:

2008-05-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff and Maciej.

<rdar://problem/5806428>
​https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto

Set slotIsWriteable to false for proto, we want setting proto to go through JSObject::put instead.


  • kjs/object.h: (KJS::JSObject::getOwnPropertySlotForWrite):

LayoutTests:

2008-05-27 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff and Maciej.

<rdar://problem/5806428>
​https://bugs.webkit.org/show_bug.cgi?id=17925
Crash in KJS::JSObject::put after setting this.proto

  • fast/js/resources/this-non-object-proto.js: Added.
  • fast/js/this-non-object-proto-expected.txt: Added.
  • fast/js/this-non-object-proto.html: Added.
4:38 PM Changeset in webkit [34159] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/html/HTMLTokenizer.h

Fix typo in comment.

4:33 PM Changeset in webkit [34158] by Adam Roben
  • 3 edits in trunk/WebCore

Fix Bug 19276: XHR resources are classified as "Other" until Inspector is closed and reopened

<​https://bugs.webkit.org/show_bug.cgi?id=19276>
<rdar://problem/5965742>

Reviewed by Tim Hatcher.

  • page/InspectorController.cpp: (WebCore::InspectorController::updateScriptResourceResponse): Moved code that updates the resource's type from here... (WebCore::InspectorController::updateScriptResourceType): ...to here. (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): Call updateScriptResourceType now that we know this resource was retrieved via an XHR.
  • page/InspectorController.h:
4:25 PM Changeset in webkit [34157] by Adam Roben
  • 1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp

Roll out r34156, which was accidentally checked in

4:22 PM Changeset in webkit [34156] by Adam Roben
  • 1 edit in trunk/JavaScriptCore/VM/CodeBlock.cpp

add printInstruction

2:50 PM Changeset in webkit [34155] by timothy@apple.com
  • 2 edits in trunk/WebCore

Removes a redundant call to InspectorController::stopDebugging().

Rubber-stamped by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::showWindow):

1:44 PM Changeset in webkit [34154] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fixes a bug where unplugging the monitor from a video card and
moving it to another video card would no longer show OpenGL plugins
until you relaunched Safari.

<rdar://problem/5790983> Add AllowOfflineDisplays pixel format
attribute to OpenGL contexts

Reviewed by Kevin Decker.

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView _createWindowedAGLContext]): Added
AGL_ALLOW_OFFLINE_RENDERERS for non-Tiger builds.
(-[WebBaseNetscapePluginView _createWindowlessAGLContext]): Ditto.

11:46 AM Changeset in webkit [34153] by kmccullough@apple.com
  • 4 edits
    2 adds in trunk/WebCore

2008-05-27 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

  • Added and updated some manual test for the profiler.
  • manual-tests/inspector/profiler-test-anonymous-function-calls-eval.html:
  • manual-tests/inspector/profiler-test-apply.html:
  • manual-tests/inspector/profiler-test-call.html:
  • manual-tests/inspector/profiler-test-deep-recursion.html: Added.
  • manual-tests/inspector/profiler-test-simple-event-call.html: Added.
10:49 AM Changeset in webkit [34152] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

wx build fix. Update the sample app after wxWebFrame->wxWebBrowserShell rename.

9:29 AM Changeset in webkit [34151] by kevino@webkit.org
  • 4 edits in trunk

wx build fix. Accidently left a couple fixes out of the previous commit.

9:12 AM Changeset in webkit [34150] by kevino@webkit.org
  • 6 edits in trunk

wx build fixes after introduction of SquirrelFish and other updates.

7:43 AM Changeset in webkit [34149] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

2008-05-27 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

Add immediate number cases for the &, |, and operators.
Makes standalone SunSpider 1.010x faster.

  • VM/Machine.cpp: (KJS::Machine::privateExecute): Add areBothImmediateNumbers special cases for the &, |, and operators.
  • kjs/JSImmediate.h: (KJS::JSImmediate::xorImmediateNumbers): Added. (KJS::JSImmediate::orImmediateNumbers): Added.
3:31 AM Changeset in webkit [34148] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix linking error (missing gdi32 and user32 libraries).

  • WebCore.pro:
2:49 AM Changeset in webkit [34147] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-05-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix web inspector does not returns its state properly after its window is minimized.

As hinted by Holger, InspectorClientView::hideEvent is not needed.
This fixes bug ​https://bugs.webkit.org/show_bug.cgi?id=18967

2:02 AM Changeset in webkit [34146] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-05-27 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Update the WebKit.qrc so that Web Inspector is functional again.

  • page/inspector/WebKit.qrc:

May 26, 2008:

10:04 PM Changeset in webkit [34145] by Stephanie Lewis
  • 2 edits in trunk/JavaScriptCore

2008-05-26 Stephanie Lewis <Stephanie Lewis>

Windows build fix.

  • kjs/testkjs.cpp:
7:48 PM Changeset in webkit [34144] by alp@webkit.org
  • 3 edits in trunk/WebCore

2008-05-26 Alp Toker <​alp@nuanti.com>

Reviewed by Anders.

​http://bugs.webkit.org/show_bug.cgi?id=16495
[GTK] Accessibility support with ATK/AT-SPI

Implement basic action, text and editable text accessibility.

Provide utility functions to simplify const string return and casting
and add some more stubs.

It's now possible to navigate and manipulate forms and text using
assistive technologies.

  • page/gtk/AccessibilityObjectWrapperAtk.cpp: (returnString): (core):
  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::AXButtonActionVerb): (WebCore::AXRadioButtonActionVerb): (WebCore::AXTextFieldActionVerb): (WebCore::AXCheckedCheckBoxActionVerb): (WebCore::AXUncheckedCheckBoxActionVerb): (WebCore::AXLinkActionVerb): (WebCore::imageTitle):
7:10 PM Changeset in webkit [34143] by mjs@apple.com
  • 14 edits in trunk

JavaScriptCore:

2008-05-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders.


  • make addStaticGlobals protected instead of private so subclasses can use it

WebCore:

2008-05-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders.

  • bind the window's "document" and "window" properties to static slots 1.7% speedup on Acid3 test 26


Only the "document" part matters for Acid3, but since I was doing
this anyway, "window" also seemed like a good one to optimize.

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::JSDOMWindowBase): Allocate variable slots for document and window; but just put null in the document slot for now. (WebCore::JSDOMWindowBase::updateDocument): Fill in the document slot. (WebCore::JSDOMWindowBase::~JSDOMWindowBase): Make our shell stop tracking us.
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::JSDOMWindowShell): Allocate HashSet for our still-not-dead inner windows. (WebCore::JSDOMWindowShell::updateDocument): Update all our inner windows ever (to make sure the update to the document property shows up everywhere).
  • bindings/js/JSDOMWindowShell.h: (WebCore::JSDOMWindowShell::setWindow): Update our hash. (WebCore::JSDOMWindowShell::clearFormerWindow): Ditto.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Don't set self as a property map property of the window, this is no longer necessary.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScript): Update document for the newly created window.
  • bindings/js/kjs_proxy.h:
  • page/Frame.cpp: (WebCore::Frame::setDocument): If the document is not null, update our window.

LayoutTests:

2008-05-26 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Anders.


  • update test result for document/window being allocated to var slots
  • http/tests/security/cross-frame-access-put-expected.txt:
4:49 PM Changeset in webkit [34142] by collinj@webkit.org
  • 13 edits in trunk/LayoutTests

2008-05-26 James Ren <​jamesjren@gmail.com>

Reviewed by Sam Weinig, landed by Collin Jackson.

​http://bugs.webkit.org/show_bug.cgi?id=19163

Modified some http/security layout tests to allow them to run in Firefox.

  • http/tests/security/aboutBlank/xss-DENIED-set-opener.html:
  • http/tests/security/frameNavigation/xss-ALLOWED-targeted-subframe-navigation-change.html:
  • http/tests/security/resources/localhost-accesssor.html: Added a workaround for ​https://bugzilla.mozilla.org/show_bug.cgi?id=434912
  • http/tests/security/resources/cross-frame-access.js: Changed shouldBe to also gracefully handle exceptions


  • http/tests/security/resources/foreign-domain-iframe-for-selection-test.html: Added feature detection for setBaseAndExtent and selectAllChildren
  • http/tests/security/cross-frame-access-enumeration-expected.txt:
  • http/tests/security/cross-frame-access-enumeration.html: Fixed typo (missing '.html')
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-frame-access-first-time.html:
  • http/tests/security/cross-frame-access-put.html:
  • http/tests/security/cross-frame-access-selection.html: Caught exceptions that Firefox throws, to allow the test to run to completion.
2:13 PM Changeset in webkit [34141] by andersca@apple.com
  • 7 edits
    1 add in trunk/WebCore

2008-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

This patch does two things:


  • It adds a toJSNewlyCreated function for creating JS wrappers for nodes where we know that the node doesn't have a wrapper. This avoids a hash lookup.


  • It adds toJSNewlyCreated methods for JSElement and JSText.


All in all this is a 4.3% speedup on Acid 3 test 26.


  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSElementCustom.cpp: (WebCore::toJSNewlyCreated):
  • bindings/js/JSNodeCustom.cpp: (WebCore::createWrapper): (WebCore::toJSNewlyCreated): (WebCore::toJS):
  • bindings/js/JSTextCustom.cpp: Added. (WebCore::toJSNewlyCreated):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
1:53 PM Changeset in webkit [34140] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Fixed date of ChangeLog entry.

1:41 PM Changeset in webkit [34139] by weinig@apple.com
  • 7 edits in trunk/WebCore

2008-05-26 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Inline the getOwnPropertySlot for JSNode, JSEventTargetNode, JSElement,
and JSDocument for a 1-2% speedup on Acide 3 test 26.

  • bindings/js/JSEventTargetNode.cpp:
  • bindings/js/JSEventTargetNode.h: (WebCore::JSEventTargetNode::getOwnPropertySlot): (WebCore::JSEventTargetNode::getValueProperty): (WebCore::JSEventTargetNode::put): (WebCore::JSEventTargetNode::putValueProperty):
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
1:07 PM Changeset in webkit [34138] by Darin Adler
  • 16 edits in trunk/WebCore

2008-05-25 Darin Adler <Darin Adler>

Reviewed by Maciej.

Removed code that would only useful if if there was any way to create an Entity
node or if we populated EntityReference nodes. It's likely that we'll remove
these node types entirely in some future version of WebKit, depending in part
on what happens with these in HTML 5.

1.8% speedup of Acid3 test 26.

The only read-only nodes we ever create are EntityReference nodes.
These are only created by explicit calls to the Document.createEntityReference
function. Since the created nodes are read-only, there can be no children of
these nodes, so no other types of nodes can be read-only despite the rule that
makes descendants of Entity and EntityReference nodes read-only.

  • bindings/objc/DOM.mm: Removed unneeded include.
  • dom/Attr.cpp: (WebCore::Attr::setValue): Removed unnecessary isReadOnlyNode check. (WebCore::Attr::setNodeValue): Ditto.
  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::substringData): Don't initialize the ec variable before calling checkCharDataOperation, since that function already does it. (WebCore::CharacterData::appendData): Removed unnecessary isReadOnlyNode check. (WebCore::CharacterData::insertData): Don't initialize ec. (WebCore::CharacterData::deleteData): Ditto. (WebCore::CharacterData::replaceData): Ditto. (WebCore::CharacterData::setNodeValue): Removed now-misleading comment. (WebCore::CharacterData::checkCharDataOperation): Removed unnecessary isReadOnlyNode check.
  • dom/CharacterData.h: Made checkCharDataOperation private and non-virtual since it's never used or defined in any other class.
  • dom/Element.cpp: (WebCore::Element::setAttribute): Removed unneeded isReadOnlyNode check.
  • dom/Entity.cpp: Removed the entire contents of this file.
  • dom/Entity.h: Replaced the class with a stub -- just enough to keep the public bindings (JavaScript and Objective-C compiling), but the class is abstract and can't be instantianted.
  • dom/EntityReference.cpp: Removed unused constructor. (WebCore::EntityReference::cloneNode): Removed unneeded code and comments to clone nonexistent child nodes.
  • dom/EntityReference.h: Removed unused constructor and unnecessary override of childTypeAllowed, since no children are allowed at all.
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::setNamedItem): Removed unneeded isReadOnlyNode check. (WebCore::NamedAttrMap::removeNamedItem): Ditto.
  • dom/NamedAttrMap.h: Removed isReadOnlyNode function.
  • dom/Node.cpp: Removed the old isReadOnlyNode function. It made lots of virtual nodeType function calls.
  • dom/Node.h: (WebCore::Node::isReadOnlyNode): Replaced the old virtual isReadOnlyNode function with a new simple non-virtual one.
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::setData): Removed unneeded isReadOnlyNode check.
  • dom/Text.cpp: (WebCore::Text::splitText): Removed unneeded isReadOnlyNode check. (WebCore::Text::replaceWholeText): Removed unnecessary isReadOnlyNode assertion. There is no reason for this function to go out of its way to mention the read-only node issue when none of the other DOM mutation functions do.
12:38 PM Changeset in webkit [34137] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2008-05-26 Adam Barth <​abarth@webkit.org>

Reviewed by Sam.

Cleanup SecurityOrigin::canAccess. Removed comment referring to an
old version of the code. Removed some useless code.

  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
11:57 AM Changeset in webkit [34136] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

ChangeLog fixup: 'prevent subtle errors' is a little more reassuring than 'lead to subtle errors'

11:50 AM Changeset in webkit [34135] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-05-26 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler.


Fixed <rdar://problem/5960859> After an eval of a non-string or a syntax
error, all profile stack frames are incorrect


SunSpider reports a .3% speedup, possibly because eval of a string is a
little more efficient now.

  • VM/Machine.cpp: (KJS::callEval): Make sure to call didExecute when returning early. I simplified this function to remove one early return, making the job of adding special code to early returns easier.

(KJS::Machine::execute): Use the new function ExecState when notifying
the profiler. (This doesn't change behavior now, but it might lead to
subtle errors in the future.)

11:43 AM Changeset in webkit [34134] by andersca@apple.com
  • 3 edits in trunk/LayoutTests

2008-05-26 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

Add a name to the source frame.


  • fast/frames/viewsource-empty-attribute-value-expected.txt:
  • fast/frames/viewsource-empty-attribute-value.html:
5:45 AM Changeset in webkit [34133] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-05-26 Gwenole Beauchesne <​gbeauchesne@splitted-desktop.org>

Reviewed by Alp Toker.

  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::contextMenuItemTagSelectAll): Fix GTK+ version check.
5:29 AM Changeset in webkit [34132] by Simon Hausmann
  • 4 edits in trunk

JavaScriptCore:

2008-05-23 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Fixed toLower and toUpper implementations to allow being called
with a null result pointer and resultLength, to determine the
number of characters needed for the case conversion.

LayoutTests:

008-05-23 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon.

Added a comment to the skipping of fast/css/case-transform.html that
mentions the reason of failure being a Qt bug.

4:39 AM Changeset in webkit [34131] by Simon Hausmann
  • 2 edits in trunk/LayoutTests

2008-05-26 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Update QtWebkit layout-tests in accordance with bug 18976

​https://bugs.webkit.org/show_bug.cgi?id=18976

The test fast/xsl/xslt-text.xml is on our skipped list due to
missing XSLT support in Qt.

May 25, 2008:

7:57 PM ApplicationsGtk edited by alp@atoker.com
Update an entry (diff)
7:29 PM Changeset in webkit [34130] by mrowe@apple.com
  • 4 edits in trunk/WebKit/mac

<rdar://problem/5840884> _recursive_resumeNullEventsForAllNetscapePlugins and _pauseNullEvents not defined

Follow-up for r33052. _recursive_resumeNullEventsForAllNetscapePlugins and _recursive_pauseNullEventsForAllNetscapePlugins
need to be declared in WebFramePrivate.h rather than WebFrameInternal.h so they can be used from outside of WebKit.

Reviewed by Darin Adler.

  • WebView/WebFrame.mm:

(-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
(-[WebFrame _recursive_pauseNullEventsForAllNetscapePlugins]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFramePrivate.h:
4:55 PM Changeset in webkit [34129] by Chris Fleizach
  • 5 edits in trunk/WebCore

<rdar://problem/3582905> elements on separate pages need to be distinct

4:23 PM Changeset in webkit [34128] by mjs@apple.com
  • 4 edits in trunk/WebCore

2008-05-25 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Darin.

  • don't repaint nodes that are removed before layout 4.3% speedup on Acid3 test 26

Mitz points out the new flag can also be used to optimize other
cases of needless repaint such as
<​https://bugs.webkit.org/show_bug.cgi?id=15129>.


  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): If the child has never had a layout, don't bother to repaint it, since there's nothing to dirty.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): Initialize m_everHadLayout to false. (WebCore::RenderObject::setNeedsLayout): Set m_everHadLayout to true if we are being marked as not needing layout.
  • rendering/RenderObject.h:
1:13 PM Changeset in webkit [34127] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/caret-outside-block.html

  • editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Restored this function which was removed in r28523, but changed it to inflate only the width. (WebCore::SelectionController::caretRepaintRect): Changed back to use repaintRectForCaret(). (WebCore::SelectionController::recomputeCaretRect): Ditto.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/caret-outside-block.html: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.checksum: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.png: Added.
  • platform/mac/fast/repaint/caret-outside-block-expected.txt: Added.
7:36 AM Changeset in webkit [34126] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-25 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18940
[CURL] Allow \n as line terminator for headers

The line terminator for message-header fields should be CRLF. However,
it is recommended to recognise as a line terminator also a single LF.

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::headerCallback): Allow headers to be terminated by "\n" and not just by "\r\n".
7:14 AM Changeset in webkit [34125] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-25 Alp Toker <​alp@nuanti.com>

Reviewed by Niko.

Drop WebView focus when the widget is focused out.

  • webkit/webkitwebview.cpp:
4:30 AM Changeset in webkit [34124] by rwlbuis@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Alexey.

Fix the test.

4:15 AM Changeset in webkit [34123] by jmalonzo@webkit.org
  • 4 edits in trunk

2008-05-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=19142
[Gtk] Remove build options --svg-experimental and --cross-document-messaging

  • configure.ac
  • WebCore/GNUmakefile.am:
3:41 AM Changeset in webkit [34122] by rwlbuis@webkit.org
  • 12 edits in trunk/LayoutTests

RS=Oliver

Fix SVG test results for tiger buildbot.

2:55 AM Changeset in webkit [34121] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-25 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=18935
[Gtk] Plugin Load crashes with NP_FULL mode

Fix crash due to uninitialized variable.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient):
12:46 AM Changeset in webkit [34120] by oliver@apple.com
  • 12 edits in trunk/LayoutTests

Fix leopard results following changes to SVG path dumping.

RS=Alexey

12:35 AM Changeset in webkit [34119] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Fixing a typo in the previous commit made as a last minute change.

  • kjs/regexp_object.cpp:
12:15 AM Changeset in webkit [34118] by ap@webkit.org
  • 4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Changed regular expression matching result array to be lazily filled, because many callers
only care about it being non-null.

2% improvement on Acid3 test 26.

  • kjs/array_instance.cpp: Added a void* member to ArrayStorage for ArrayInstance subclasses to use.
  • kjs/array_instance.h: (KJS::ArrayInstance::lazyCreationData): (KJS::ArrayInstance::setLazyCreationData): Added methods to access it from subclasses.
  • kjs/regexp_object.cpp: (KJS::RegExpMatchesArray::RegExpMatchesArray): (KJS::RegExpMatchesArray::getOwnPropertySlot): (KJS::RegExpMatchesArray::put): (KJS::RegExpMatchesArray::deleteProperty): (KJS::RegExpMatchesArray::getPropertyNames): (KJS::RegExpMatchesArray::fillArrayInstanceIfNeeded): (KJS::RegExpMatchesArray::~RegExpMatchesArray): (KJS::RegExpObjectImp::arrayOfMatches): RegExpMatchesArray is a subclass of ArrayInstance that isn't filled until accessed for the first time.
12:11 AM Changeset in webkit [34117] by rwlbuis@webkit.org
  • 595 edits in trunk

Reviewed by Eric.

​https://bugs.webkit.org/show_bug.cgi?id=18927
Unify path data debug output

Implement unified path data output for Mac svg tests.

May 24, 2008:

10:25 PM Changeset in webkit [34116] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-05-24 Andreia Gaita <​shana@isninja.com>

Reviewed by Alp Toker.

cygwin-downloader.py fixes.

Remove two non-working mirrors. Add a check for missing dependency
packages to avoid bailing out on an inconsistent Cygwin package list.

  • CygwinDownloader/cygwin-downloader.py:
9:47 PM Changeset in webkit [34115] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a huge leak with the Inspector where it was protecting
a large object that was not being unprotected.

<rdar://problem/5961999> Inspector protects a large JavaScript
object and never unprotects it (large leak)

Reviewed by Darin Adler.

  • page/InspectorController.cpp:

(WebCore::InspectorController::inspectedPageDestroyed): Call close()
and removed a call to stopDebugging() and moved it to close().
(WebCore::InspectorController::close): Add stopDebugging() and
stopUserInitiatedProfiling(). Removed an ASSERT and added an
if statement before calling JSValueUnprotect. We don't always have
a m_scriptContext and m_scriptObject.

9:24 PM Changeset in webkit [34114] by Darin Adler
  • 1 edit in trunk/JavaScriptCore/docs

Ignore generated bytecode.html file.

9:19 PM Changeset in webkit [34113] by alp@webkit.org
  • 2 edits in trunk

2008-05-24 Alp Toker <​alp@nuanti.com>

GTK+/Win32 build fixes. Link against Windows ICU without using
icu-config since it's not available on that platform.

Link against Ws2_32 when the curl http backend is chosen since we
use select() directly.

  • configure.ac:
8:45 PM Changeset in webkit [34112] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-05-24 Alp Toker <​alp@nuanti.com>

Win32/gcc3 build fix in Pango font backend. UChar needs to be
explicitly cast to gunichar2.

  • platform/graphics/gtk/FontGtk.cpp: (WebCore::utf16_to_utf8):
6:58 PM Changeset in webkit [34111] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-05-24 Alp Toker <​alp@nuanti.com>

Win32/gcc build fix. Remove MSVC assumption.

  • wtf/TCSpinLock.h: (TCMalloc_SlowLock):
6:51 PM Changeset in webkit [34110] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-05-24 Alp Toker <​alp@nuanti.com>

​https://bugs.webkit.org/show_bug.cgi?id=18825
webkitgtk fails to build from source: "Database Tracker" has not been declared

GTK+ fix for building without database support.
exceededDatabaseQuota() still needs to be present, just a no-op.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::exceededDatabaseQuota):
6:01 PM Changeset in webkit [34109] by timothy@apple.com
  • 3 edits in trunk/WebCore

Fixes a crash where a new Inspector would get an old
JSInspectedObjectWrapper for a user agent CSSStyleDeclaration.
Since these style objects shared between pages, the wrapper cache
would have a wrapper for the object still. But the wrapper was
for a previous global object and with a disconnected frame. This
fixes the wrapper cache so wrappers are remembered per global object
and the object they are wrapping.

<rdar://problem/5958567> repro crash in WebCore::Frame::keepAlive()
opening inspector window after closing it

Reviewed by Darin Adler.

  • bindings/js/JSInspectedObjectWrapper.cpp:

(WebCore::wrappers): Return a GlobalObjectWrapperMap reference.
(WebCore::JSInspectedObjectWrapper::wrap): Find the WrapperMap
by the dynamicGlobalObject then find the wrapper for unwrappedObject.
(WebCore::JSInspectedObjectWrapper::JSInspectedObjectWrapper): Changes
how the wrapper is added to the wrapper cache.
(WebCore::JSInspectedObjectWrapper::~JSInspectedObjectWrapper): Changes
how the wrapper is removed from the wrapper cache.

  • bindings/js/JSQuarantinedObjectWrapper.h:

(WebCore::JSQuarantinedObjectWrapper:unwrappedGlobalObject): Added.

2:12 PM Changeset in webkit [34108] by ap@webkit.org
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Maciej.

Optimize Node::textContent() to avoid O(n2) string appending behavior.

1.6% speedup at Acid3 test 26.

  • WebCore.xcodeproj/project.pbxproj:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/text/StringBuilder.cpp: Added. (WebCore::StringBuilder::append): (WebCore::StringBuilder::toString):
  • platform/text/StringBuilder.h: Added. (WebCore::StringBuilder::StringBuilder): (WebCore::StringBuilder::isNull): Added a simple class to efficiently build a string by appending. Potentially, it can be extended to be more like java.lang.StringBuilder, but we don't need that much flexibility now.
  • dom/Node.cpp: (WebCore::Node::appendTextContent): (WebCore::Node::textContent):
  • dom/Node.h: Changed to use StringBuilder.
6:26 AM Changeset in webkit [34107] by jchaffraix@webkit.org
  • 8 edits
    4 deletes in trunk/WebCore

2008-05-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 9191: JS*ElementWrapperFactory should be autogenerated
​https://bugs.webkit.org/show_bug.cgi?id=9191

This is a first pass for generation of JS*ElementWrapperFactory, in the long term we should move the make_names.pl
intelligence to the *.in files.

  • Add a new parameter to make_names.pl --wrapperFactory which works like --wrapper but generates the JS*ElementWrapperFactory files.
  • Removed JS*ElementWrapperFactory files in WebCore/bindings/js, replaced by the generated ones.
  • Updated the build systems to account for the previous changes.
  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Removed.
  • bindings/js/JSHTMLElementWrapperFactory.h: Removed.
  • bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
  • bindings/js/JSSVGElementWrapperFactory.h: Removed.
  • dom/make_names.pl:
5:48 AM Changeset in webkit [34106] by ap@webkit.org
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fixed ChangeLog.

5:43 AM Changeset in webkit [34105] by ap@webkit.org
  • 5 edits in trunk

Rubber-stamped, tweaked and landed by Alexey.

Build fix for gcc 4.3. Added missing standard includes.

May 23, 2008:

11:34 PM Changeset in webkit [34104] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where a timer would keep firing after the Inspector
was closed. It turns out this timer wasn't needed anymore now
that we can add an event listener to the inspected page and have
it get called in the Inspector's context.

​https://bugs.webkit.org/show_bug.cgi?id=18577

Reviewed by Mark Rowe.

  • page/inspector/ElementsPanel.js:
9:18 PM Changeset in webkit [34103] by mrowe@apple.com
  • 3 edits
    2 copies in tags/Safari-6526.8

Merge r34097.

8:52 PM Changeset in webkit [34102] by pewtermoose@webkit.org
  • 3 edits in trunk/WebCore

2008-05-23 Anthony Ricaud <​rik24d@gmail.com>

Changes the largerResourcesButton tooltip to toggle.

​https://bugs.webkit.org/show_bug.cgi?id=19210

Reviewed by Tim Hatcher.

  • WebCore/English.lproj/localizedStrings.js: New string and clean an double string "Dock to main window."
  • WebCore/page/inspector/ResourcesPanel.js: Toggle the tooltip and change the default tooltip
7:47 PM Changeset in webkit [34101] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

7:44 PM Changeset in webkit [34100] by mrowe@apple.com
  • 1 copy in tags/Safari-6526.8

New tag.

6:33 PM Changeset in webkit [34099] by jmalonzo@webkit.org
  • 6 edits in trunk/WebKitTools

2008-05-24 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Darin Adler.

Remove useQmake usage. QMake build doesn't support Gtk port
anymore.

Also fix 2 occurences of "Web Kit". Should be WebKit.

  • Scripts/build-webkit:
  • Scripts/run-javascriptcore-tests:
  • Scripts/run-launcher:
  • Scripts/run-webkit-tests:
  • Scripts/webkitdirs.pm:
5:56 PM Changeset in webkit [34098] by justin.garcia@apple.com
  • 2 edits in trunk/LayoutTests/editing/execCommand

Check Paste, instead of checking Copy twice.

5:29 PM Changeset in webkit [34097] by justin.garcia@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2008-05-23 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin.

<rdar://problem/5939887> REGRESSION: With no selection, copy does not fire oncopy handler (affects CIFilterBrowser widget)


Execute cut, copy and paste if they are invoked explicitly, via execCommand or -[WebView copy:], even
if they are disabled. This will fire oncopy, oncut and onpaste, but won't perform any other work, like
writing to the pasteboard during cut/copy or deleting the selection during cut/paste. This matches FF3,
which actually goes further and fires oncopy on any Command-C.


  • editing/EditorCommand.cpp: (WebCore::CommandEntry::): (WebCore::Editor::Command::execute):

LayoutTests:

2008-05-23 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Darin.

<rdar://problem/5939887> REGRESSION: With no selection, copy does not fire oncopy handler (affects CIFilterBrowser widget)

  • editing/execCommand/5939887-expected.txt: Added.
  • editing/execCommand/5939887.html: Added.
4:51 PM Changeset in webkit [34096] by timothy@apple.com
  • 4 edits
    1 add in trunk/WebCore

Adds a percentage toggle button the profile view status bar that
changes the time columns between absolute and percents.

​https://bugs.webkit.org/show_bug.cgi?id=19224

Reviewed by Kevin McCullough.

  • English.lproj/localizedStrings.js: New strings.
  • page/inspector/Images/percentButtons.png: Added.
  • page/inspector/ProfileView.js: Make the button and add it to the

status bar. Make clicking toggle the showAsPercent* properties.

  • page/inspector/inspector.css: New styles.
4:44 PM Changeset in webkit [34095] by andersca@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-05-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/5959886> REGRESSION: Assertion failure in JSImmediate::toString when loading GMail (19217)


Change List to store a JSValue* pointer + an offset instead of a JSValue pointer to protect against the case where
a register file changes while a list object points to its buffer.


  • VM/Machine.cpp: (KJS::Machine::privateExecute):
  • kjs/JSActivation.cpp: (KJS::JSActivation::createArgumentsObject):
  • kjs/list.cpp: (KJS::List::getSlice):
  • kjs/list.h: (KJS::List::List): (KJS::List::at): (KJS::List::append): (KJS::List::begin): (KJS::List::end): (KJS::List::buffer):
4:41 PM Changeset in webkit [34094] by mrowe@apple.com
  • 3 edits in trunk/WebKitSite

2008-05-23 William Siegrist <​wsiegrist@apple.com>

Reviewed by Mark Rowe

Rename duplicated "notice" id to "terms".

  • css/main.css:
  • nav.inc:
4:37 PM Changeset in webkit [34093] by weinig@apple.com
  • 3 edits in trunk/LayoutTests

2008-05-23 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

LayoutTests that send an OPTIONS request don't work on Tiger or Window due
to a bug in Apache 1.3

  • platform/mac-tiger/Skipped:
  • platform/win/Skipped:
4:07 PM Changeset in webkit [34092] by kmccullough@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-05-23 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

<rdar://problem/5960012> JSProfiler: Stack overflow if recursion is
too deep.
-Use a simple depth limit to restrict too deep of recursion.

  • profiler/Profile.cpp: (KJS::Profile::willExecute): (KJS::Profile::didExecute):
  • profiler/Profile.h:
2:30 PM Changeset in webkit [34091] by ggaren@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Removed terrible lie from ChangeLog.

2:28 PM Changeset in webkit [34090] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-05-23 Geoffrey Garen <​ggaren@apple.com>

Rolling back in r34085, with performance resolved.


Apparently, passing the eval function to callEval gave GCC a hernia.

Reviewed by Darin Adler, Kevin McCullough, and Oliver Hunt.


Fixed <rdar://problem/5959447> Crashes and incorrect reporting in the
JavaScript profiler

  • VM/Machine.cpp: (KJS::callEval): Made this profiler hooks slightly faster by passing in the eval function.


(KJS::Machine::unwindCallFrame): Fixed incorrect reporting / a crash
when unwinding from inside eval and/or program code: detect the
difference, and do the right thing. Also, be sure to notify the profiler
*before* deref'ing the scope chain, since the profiler uses the scope chain.

(KJS::Machine::execute): Fixed incorrect reporting / crash when calling
a JS function re-entrently: Machine::execute(FunctionBodyNode*...)
should not invoke the didExecute hook, because op_ret already does that.
Also, use the new function's ExecState when calling out to the profiler.
(Not important now, but could have become a subtle bug later.)

(KJS::Machine::privateExecute): Fixed a hard to reproduce crash when
profiling JS functions: notify the profiler *before* deref'ing the scope
chain, since the profiler uses the scope chain.

  • kjs/object.cpp: (KJS::JSObject::call): Removed these hooks, because they are now unnecessary.
  • profiler/Profile.cpp: Added a comment to explain a subtlety that only Kevin and I understood previously. (Now, the whole world can understand!)
  • profiler/Profiler.cpp: (KJS::shouldExcludeFunction): Don't exclude .call and .apply. That was a hack to fix bugs that no longer exist.

Finally, sped things up a little bit by changing the "Is the profiler
running?" check into an ASSERT, since we only call into the profiler
when it's running:

(KJS::Profiler::willExecute):
(KJS::Profiler::didExecute):

1:49 PM Changeset in webkit [34089] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

2008-05-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.

  • fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com


SunSpider reports no change.


This is a reworking of r34073, which I rolled out because it caused
lots of crashes.

  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Use removeDirect to nix old properties whose names collide with new functions. (Don't use putWithAttributes because that tries to write to the register file, which hasn't grown to fit this program yet.)

LayoutTests:

2008-05-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
  • fast/js/function-redefinition-expected.txt: Added.
  • fast/js/function-redefinition.html: Added.
12:42 PM Changeset in webkit [34088] by mrowe@apple.com
  • 6 edits in trunk/JavaScriptCore

2008-05-23 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

As allocateNumber is used via jsNumberCell outside of JavaScriptCore,
we need to provide a non-inlined version of it to avoid creating a
weak external symbol.

  • JavaScriptCore.exp:
  • kjs/AllInOneFile.cpp:
  • kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::allocateNumber):
  • kjs/collector.h: (KJS::Collector::allocate): (KJS::Collector::inlineAllocateNumber):
  • kjs/value.h: (KJS::NumberImp::operator new):
12:34 PM Changeset in webkit [34087] by ggaren@apple.com
  • 3 edits
    2 deletes in trunk

JavaScriptCore:

2008-05-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r34073 because it caused lots of layout test crashes.

LayoutTests:

2008-05-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r34073 because it caused lots of layout test crashes.

12:12 PM Changeset in webkit [34086] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-05-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r34085 because it measured as a 7.6% performance regression.

10:50 AM Changeset in webkit [34085] by ggaren@apple.com
  • 5 edits in trunk/JavaScriptCore

2008-05-23 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Darin Adler, Kevin McCullough, and Oliver Hunt.


Fixed <rdar://problem/5959447> Crashes and incorrect reporting in the
JavaScript profiler

  • VM/Machine.cpp: (KJS::callEval): Made this profiler hooks slightly faster by passing in the eval function.


(KJS::Machine::unwindCallFrame): Fixed incorrect reporting / a crash
when unwinding from inside eval and/or program code: detect the
difference, and do the right thing. Also, be sure to notify the profiler
*before* deref'ing the scope chain, since the profiler uses the scope chain.

(KJS::Machine::execute): Fixed incorrect reporting / crash when calling
a JS function re-entrently: Machine::execute(FunctionBodyNode*...)
should not invoke the didExecute hook, because op_ret already does that.
Also, use the new function's ExecState when calling out to the profiler.
(Not important now, but could have become a subtle bug later.)

(KJS::Machine::privateExecute): Fixed a hard to reproduce crash when
profiling JS functions: notify the profiler *before* deref'ing the scope
chain, since the profiler uses the scope chain.

  • kjs/object.cpp: (KJS::JSObject::call): Removed these hooks, because they are now unnecessary.
  • profiler/Profile.cpp: Added a comment to explain a subtlety that only Kevin and I understood previously. (Now, the whole world can understand!)
  • profiler/Profiler.cpp: (KJS::shouldExcludeFunction): Don't exclude .call and .apply. That was a hack to fix bugs that no longer exist.

Finally, sped things up a little bit by changing the "Is the profiler
running?" check into an ASSERT, since we only call into the profiler
when it's running:

(KJS::Profiler::willExecute):
(KJS::Profiler::didExecute):

10:48 AM Changeset in webkit [34084] by alp@webkit.org
  • 4 edits in trunk

2008-05-23 Alp Toker <​alp@nuanti.com>

GTK+ fixes for building without database support.

10:41 AM Changeset in webkit [34083] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where excluding nodes from the profile could
show an empty parent node.

<rdar://problem/5959573> Excluding nodes from the profile could show
an empty parent node

Reviewed by Kevin McCullough.

  • page/inspector/ProfileView.js: Only say we have children if

all of our children nodes are visible.

10:19 AM Changeset in webkit [34082] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-05-23 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Add IconFetcher to project.


  • WebCore.vcproj/WebCore.vcproj:
10:15 AM Changeset in webkit [34081] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes a bug where the Web Insepctor would jump back to
Elements each time it is opened instead of staying at the
last selected panel.

<rdar://problem/5959475> Inspector jumps to the Elements panel
each time it is opened, instead of staying at the previous panel

Reviewed by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::setWindowVisible): Reset
m_showAfterVisible to CurrentPanel, so the next time setWindowVisible
is called it will use CurrentPanel unless showPanel was called again.

10:03 AM Changeset in webkit [34080] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add the profiler directory to the include path.
9:54 AM Changeset in webkit [34079] by Chris Fleizach
  • 2 edits in trunk/WebCore

<rdar://problem/5933759> REGRESSION: Frames don't appear as AX children of the top level web area

9:38 AM Changeset in webkit [34078] by andersca@apple.com
  • 6 edits
    3 adds in trunk/WebKit/win

2008-05-22 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

Add IWebIconFetcher interface and implementation.


  • Interfaces/IWebFramePrivate.idl:
  • Interfaces/IWebIconFetcher.idl: Added.
  • Interfaces/WebKit.idl:
  • WebFrame.cpp:
  • WebFrame.h:
  • WebIconFetcher.cpp: Added.
  • WebIconFetcher.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
8:23 AM Changeset in webkit [34077] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-05-21 Siraj Razick <​siraj.razick@collabora.co.uk>

Reviewed by Simon.

Add <param name="classid"/> support for application/x-qt-object plugins

7:24 AM Changeset in webkit [34076] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-05-23 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

For Qt port, support painting to native Windows HDC.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
7:23 AM Changeset in webkit [34075] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

SQUIRRELFISH: JavaScript error messages are missing informative text

Reviewed by Anders

Partial fix.
Tidy up error messages, makes a couple of them provide slightly more info.
Inexplicably leads to a 1% SunSpider Progression.

4:37 AM Changeset in webkit [34074] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Fix call stack reported by profiler when entering event handlers.

Reviewed by Tim H

JSObject::call was arbitrarily notifying the profiler when it was
called, even if it was JS code, which notifies the profile on entry
in any case.

3:43 AM Changeset in webkit [34073] by mjs@apple.com
  • 3 edits
    2 adds in trunk

JavaScriptCore:

2008-05-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • fixed <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
  • VM/CodeGenerator.cpp: (KJS::CodeGenerator::CodeGenerator): Delete any existing properties before creating the function (this should really be done at execution time not codegen time).

LayoutTests:

2008-05-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Oliver.


  • test case <rdar://problem/5957662> REGRESSION(r33943-r33980): Can't send email , attach file or save as draft from hotmail.com
  • fast/js/function-redefinition-expected.txt: Added.
  • fast/js/function-redefinition.html: Added.
3:12 AM Changeset in webkit [34072] by timothy@apple.com
  • 5 edits in trunk/WebCore

Fixes a bug where the Inspector could have 0ms timers firing
even after it is closed.

​https://bugs.webkit.org/show_bug.cgi?id=18577

Reviewed by Oliver Hunt.

  • page/inspector/DatabasesPanel.js: Removes setTimeouts that call

the same function with a 0ms delay. These we not doing any good anyway,
so they weren't needed and just caused problems.

  • page/inspector/ElementsPanel.js: Ditto.
  • page/inspector/ProfilesPanel.js: Ditto.
  • page/inspector/ResourcesPanel.js: Ditto.
2:54 AM Changeset in webkit [34071] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

+2008-05-16 Alp Toker <​alp@nuanti.com>

Build fix for gcc 3. Default constructor required in ExecState,
used by OldInterpreterExecState.

  • kjs/ExecState.h: (KJS::ExecState::ExecState):
2:41 AM Changeset in webkit [34070] by timothy@apple.com
  • 4 edits in trunk/WebCore

Make the Inspector correctly populate the profiles when
closed and re-opened.

Reviewed by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::populateScriptObjects): Call populateInterface
in inspector.js.

  • page/inspector/ProfilesPanel.js:

(WebInspector.ProfilesPanel.prototype.populateInterface): If visible,
call _populateProfiles. Else just set this._shouldPopulateProfiles to true.
(WebInspector.ProfilesPanel.prototype.reset): Don't call _populateProfiles.
Just set this._shouldPopulateProfiles to true.
(WebInspector.ProfilesPanel.prototype._populateProfiles): Delete
this._shouldPopulateProfiles.

  • page/inspector/inspector.js:

(WebInspector.populateInterface): Added. Call populateInterface on all the
panels if they implement it.

2:38 AM Changeset in webkit [34069] by mrowe@apple.com
  • 5 edits in trunk

Fix <rdar://problem/5954997> global-recursion-on-full-stack.html crashes under guardmalloc.

Growing the register file with uncheckedGrow from within Machine::execute is not safe as the
register file may be too close to its maximum size to grow successfully. By using grow,
checking the result and throwing a stack overflow error we can avoid crashing.

Reviewed by Oliver Hunt.

  • VM/Machine.cpp:

(KJS::Machine::execute):

  • VM/RegisterFile.h: Remove the now-unused uncheckedGrow.
2:32 AM Changeset in webkit [34068] by kmccullough@apple.com
  • 6 edits in trunk/WebCore

2008-05-23 Kevin McCullough <​kmccullough@apple.com>

RS = Adam.

Editorial changes

  • manual-tests/inspector/profiler-test-apply.html:
  • manual-tests/inspector/profiler-test-document-dot-write.html:
  • manual-tests/inspector/profiler-test-execution-context-and-eval-on-same-line.html:
  • manual-tests/inspector/profiler-test-one-execution-context.html:
  • manual-tests/inspector/profiler-test-two-execution-contexts.html:
2:07 AM Changeset in webkit [34067] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

Remove JAVASCRIPT_PROFILER define

RS=Kevin McCullough

2:01 AM Changeset in webkit [34066] by timothy@apple.com
  • 2 edits in trunk/WebCore

Fixes the bug where the profile was not added when finished.

<rdar://problem/5958851> Stop Profiling from the Develop menu does
not add the Profile to the Inspector

Reviewed by Adam Roben.

  • page/InspectorController.cpp:

(WebCore::InspectorController::stopUserInitiatedProfiling): Call
addProfile with the result of stopProfiling.

1:56 AM Changeset in webkit [34065] by oliver@apple.com
  • 5 edits in trunk/JavaScriptCore

<rdar://problem/5951561> Turn on JavaScript Profiler

Reviewed by Kevin McCullough

Flipped the switch on the profiler, rearranged how we
signal the the profiler is active so that calls aren't
needed in the general case.

Also fixed the entry point for Machine::execute(FunctionBodyNode..)
to correctly indicate function exit.

Results in a 0.7-1.0% regression in SunSpider :-(

1:35 AM Changeset in webkit [34064] by timothy@apple.com
  • 2 edits in trunk/WebCore

Tweak the Web Insector toolbar look to be smaller when attached to
the inspected page.

Reviewed by Adam Roben.

  • page/inspector/inspector.css:
1:03 AM Changeset in webkit [34063] by timothy@apple.com
  • 2 edits in trunk/WebKit/mac

Fix attaching and detaching the Web Inspector. This change removes
the clunky animation that never looked right and was causing issues
where the inspected WebView would get into a no useable state.

<rdar://problem/5958812> Attaching and Detaching the Web Inspector
can cause the inspected WebVIew to be unusable

Reviewed by Adam Roben.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController close]): Removes animation code.
Sets the frame directly and does a displayIfNeeded to prevent
showing the Inspector in the page and in the Inspector window.
(-[WebInspectorWindowController showWindow:]): Removes animation code.
Sets the frame directly.
(-[WebInspectorWindowController attach]): Simplified.
(-[WebInspectorWindowController detach]): Ditto.

12:58 AM Changeset in webkit [34062] by Simon Hausmann
  • 4 edits in trunk

Fix the Qt build by adding profiler/ to the include path and providing
an empty stub for AXObjectCache::handleAriaRoleChanged to build without
accessibility.

12:05 AM Changeset in webkit [34061] by alice.liu@apple.com
  • 3 edits in trunk/WebCore

2008-05-23 Alice Liu <​alice.liu@apple.com>

Reviewed by Mark Rowe.

Remove call to function whose body was commented out. Returning the
children for a menu button by the normal calculation works just as well.

  • page/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::addChildren):
  • page/AccessibilityRenderObject.h:
Note: See TracTimeline for information about the timeline view.