Timeline



Nov 5, 2008:

11:28 PM Changeset in webkit [38153] by alp@webkit.org
  • 2 edits in trunk/WebKitTools

2008-11-05 Alp Toker <​alp@nuanti.com>

GTK build script tweak.

Make the path relative since it will appear in all -I compiler flags.
Long argument lists cause bizarre slowdowns in libtool and result
in huge build logs.

  • Scripts/webkitdirs.pm:
11:24 PM Changeset in webkit [38152] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptGlue

2008-11-05 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix the JavaScriptGlue build. This wouldn't show up unless one was
doing a clean build, because changes in JavaScriptCore don't cause
anything in JavaScriptGlue to get rebuilt.

  • JSRun.cpp:
  • JSUtils.h:
  • JavaScriptGlue.cpp:
11:07 PM Changeset in webkit [38151] by ap@webkit.org
  • 5 edits in trunk/WebCore

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=22083
MessageEvents cannot be used across threads

  • dom/Event.idl:
  • dom/MessageEvent.idl: Add a NoStaticTables attribute - MessageEvent is used in worker threads, so static tables won't work.
  • dom/MessagePort.cpp: (WebCore::MessagePort::EventData::EventData): (WebCore::MessagePort::EventData::~EventData): (WebCore::MessagePort::clone): (WebCore::MessagePort::postMessage): (WebCore::MessagePort::startConversation): (WebCore::MessagePort::dispatchMessages):
  • dom/MessagePort.h: Don't create a MessageEvent until dispatch time - messages can be posted across threads, but MessageEvents are tied to the thread that they were created in.
11:04 PM Changeset in webkit [38150] by ap@webkit.org
  • 6 edits
    11 adds in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22066
Implement Worker global object

  • DerivedSources.make: Added WorkerLocation IDL and JSWorkerContext lookup table.
  • WebCore.xcodeproj/project.pbxproj: Only adding files to Mac project for now, as Worker support is still disabled by default.
  • bindings/js/JSDOMGlobalObject.cpp: (WebCore::toJSDOMGlobalObject): Implemented Worker case.
  • bindings/js/JSMessageChannelConstructor.cpp: (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Ditto.
  • bindings/js/JSWorkerContext.cpp: Added.
  • bindings/js/JSWorkerContext.h: Added.
  • bindings/js/WorkerScriptController.cpp: Added.
  • bindings/js/WorkerScriptController.h: Added.
  • dom/WorkerContext.cpp: Added.
  • dom/WorkerContext.h: Added. Added an implementation of worker contexts.
  • dom/DedicatedWorker.cpp: (WebCore::DedicatedWorker::startLoad): Fixed a lifetime bug I saw on my tests. (WebCore::DedicatedWorker::notifyFinished): Create a thread. Currently, object ownership and lifetime is not clear at all.
  • dom/WorkerLocation.cpp: Added.
  • dom/WorkerLocation.h: Added.
  • dom/WorkerLocation.idl: Added. Added WorkerLocation, which is one of the objects available to workers.
  • dom/WorkerThread.cpp: Added. (WebCore::WorkerThread::WorkerThread): (WebCore::WorkerThread::start): (WebCore::WorkerThread::workerThreadStart): (WebCore::WorkerThread::workerThread):
  • dom/WorkerThread.h: Added. (WebCore::WorkerThread::create): Run some code in a worker thread (no message loop yet).
8:38 PM Changeset in webkit [38149] by alp@webkit.org
  • 1 edit in trunk/WebKitTools/Scripts/webkitdirs.pm

Attempt to fix the GTK build bot after the latest kjs -> runtime move:
Remove the built products directory completely rather than using distclean.

7:26 PM Changeset in webkit [38148] by barraclough@apple.com
  • 9 edits in trunk

JavaScriptCore:

2008-11-05 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=22094

Fix for bug where the callee incorrectly recieves the caller's lexical
global object as this, rather than its own. Implementation closely
follows the spec, passing jsNull, checking in the callee and replacing
with the global object where necessary.

  • VM/CTI.cpp: (JSC::CTI::compileOpCall):
  • VM/Machine.cpp: (JSC::Machine::cti_op_call_NotJSFunction): (JSC::Machine::cti_op_call_eval):
  • runtime/JSCell.h: (JSC::JSValue::toThisObject):
  • runtime/JSImmediate.cpp: (JSC::JSImmediate::toThisObject):
  • runtime/JSImmediate.h:

LayoutTests:

2008-11-05 Gavin Barraclough <​barraclough@apple.com>

Reviewed by Maciej Stachowiak.

Previosly the test 'cross-site-this' checked that the second level deep method called
across frames recieved the correct this pointer, when no base object is provided.


Test updated so that it check that the code in the child frame, and both the first
and second functions called in the parent frame recieve the correct this values.

  • fast/frames/cross-site-this.html:
  • fast/frames/resources/cross-site-this-helper.html:
6:40 PM Changeset in webkit [38147] by Antti Koivisto
  • 3 edits in trunk/WebCore

2008-11-05 Antti Koivisto <Antti Koivisto>

Reviewed by Dan Bernstein.


​https://bugs.webkit.org/show_bug.cgi?id=22093
Don't keep decoded stylesheet data in cache


<rdar://problem/6343588>

Don't keep decoded stylesheet string around in the cache. There are no sharing benefits and
performance benefits are negligible (no measured PLT impact). Reduces memory consumption of
style sheet data in cache by 2/3 in common case.

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::sheetText): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h:
6:02 PM Changeset in webkit [38146] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

wx build fix after Operations.cpp move.

6:00 PM Changeset in webkit [38145] by ddkilzer@apple.com
  • 11 edits in trunk/WebCore

Bug 21596: WebCore::Cache should use parsed Pragma and Cache-Control headers

<​https://bugs.webkit.org/show_bug.cgi?id=21596>

Reviewed by Antti.

This patch adds real parsing for Pragma and Cache-Control headers
based on RFC 2616, Sections 2, 14.9 and 14.32. It also adds some
new String and StringImpl methods to assist with the parsing.

  • loader/Cache.cpp: (WebCore::Cache::dumpStats): Added. Convenience method for dumping stats outside of Safari.
  • loader/Cache.h: Declared dumpStats().
  • loader/CachedResource.cpp: (WebCore::CachedResource::mustRevalidate): Updated to use ResourceResponseBase::cacheControlDirectives() instead of substring matching of the entire Cache-Control header.
  • loader/loader.cpp: (WebCore::Loader::Host::didReceiveResponse): Used the local 'resource' variable instead of 'request->cachedResource()'.
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::setHTTPHeaderField): Set m_haveParsedCacheControlHeader to false when a "Cache-Control" header is set. Ditto for m_haveParsedPragmaHeader and "Pragma". (WebCore::ResourceResponseBase::parsePragmaDirectives): Added. Provides parsed Pragma header directives. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Added. Provides parsed Cache-Control header directives. (WebCore::isCacheHeaderSeparator): Added. Returns true if a character is a separator character per RFC 2616, Section 2.2, else returns false. (WebCore::isControlCharacter): Added. Returns true if a character is a control character per RFC 2616 Section 2.2, else returns false. (WebCore::trimToNextSeparator): Added. Returns a string truncated at the first separator character per isCacheHeaderSeparator(). (WebCore::parseCacheHeader): Added. This is the main parsing routine for both Cache-Control and Pragma headers. (WebCore::parseCacheControlDirectiveValues): Added. This splits certain Cache-Control directive values into a vector of strings.
  • platform/network/ResourceResponseBase.h: (WebCore::CacheControlDirectiveMap): Added. Typedef for a parsed Cache-Control header. (WebCore::PragmaDirectiveMap): Added. Typedef for a parsed Pragma header. (WebCore::ResourceResponseBase::parsePragmaDirectives): Added declaration. (WebCore::ResourceResponseBase::parseCacheControlDirectives): Ditto. (WebCore::ResourceResponseBase::m_haveParsedCacheControlHeader): Added. Boolean to describe when the "Cache-Control" header needs to be reparsed. (WebCore::ResourceResponseBase::m_haveParsedPragmaHeader): Added. Boolean to describe when the "Pragma" header needs to be reparsed. (WebCore::ResourceResponseBase::m_cacheControlDirectiveMap): Added. Cached map to hold parsed "Cache-Control" headers. (WebCore::ResourceResponseBase::m_pragmaDirectiveMap): Added. Cached map to hold parsed "Pragma" headers.
  • platform/text/PlatformString.h: (WebCore::String::find): Added. Returns the first match based on the character-matching function pointer passed in. (WebCore::String::removeCharacters): Added declaration. (WebCore::find): Added. Inline method that takes a character- matching function pointer. Called by StringImpl::find().
  • platform/text/String.cpp: (WebCore::String::removeCharacters): Added. Calls StringImpl::removeCharacters().
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::removeCharacters): Added. Returns a string with all characters removed that match the character-matching function pointer passed in. If there is no change to the string, it returns itself. Based heavily on StringImpl::simplifyWhitespace(). (WebCore::StringImpl::find): Added. Calls WebCore::find().
  • platform/text/StringImpl.h: (WebCore::FindMatchFunctionPtr): Added. Typedef for a character- matching function pointer. (WebCore::StringImpl::removeCharacters): Added declaration. (WebCore::StringImpl::find): Ditto.
5:48 PM Changeset in webkit [38144] by justin.garcia@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-11-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.

<rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break


As a rule, we don't allow merges out of blockquotes. In the bug, we are inserting a text node
between two blockquotes. Because the start merge moves the text node into a blockquote, when we
determine whether or not we should do the end merge, it incorrectly appears as though the end merge
is merging out of a blockquote. The fix is to determine whether or not we should do the end merge
before we do the start merge, so that the start merge doesn't effect our decision.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Initialize the new boolean. (WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Moved code from doApply() here for clarity. (WebCore::ReplaceSelectionCommand::doApply): Set m_shouldMergeEnd before we do the start merge.
  • editing/ReplaceSelectionCommand.h: Added m_shouldMergeEnd.

LayoutTests:

2008-11-05 Justin Garcia <​justin.garcia@apple.com>

Reviewed by Beth Dakin.


<rdar://problem/5480736> In Mail and Gmail, copied indented text pastes with line break

  • editing/pasteboard/5480736-expected.txt: Added.
  • editing/pasteboard/5480736.html: Added.
5:08 PM Changeset in webkit [38143] by andersca@apple.com
  • 4 edits in trunk/WebKit/mac

2008-11-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark Rowe.

Keep track of which plug-in host architecture would be needed for a given plug-in package.


  • Plugins/WebNetscapePluginPackage.h:
  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
  • WebKitPrefix.h:
4:41 PM Changeset in webkit [38142] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-11-05 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Speculatively fix the Windows build, even though these changes may not
actually matter for anything in the build, because the Windows bots are
behind.

  • WebCore.vcproj/WebCore.vcproj:
4:30 PM Changeset in webkit [38141] by cwzwarich@webkit.org
  • 3 edits in trunk/WebCore

2008-11-05 Cameron <​zwarich@apple.com>

Not reviewed.

Fix the Qt build.

  • bridge/qt/qt_class.cpp:
  • bridge/qt/qt_runtime.h:
4:00 PM Changeset in webkit [38140] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-05 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems and wxWindows.

  • JavaScriptCoreSources.bkl:
  • kjs/create_hash_table:
3:48 PM Changeset in webkit [38139] by cwzwarich@webkit.org
  • 5 edits in trunk/JavaScriptCore

2008-11-05 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems.

  • JavaScriptCoreSources.bkl:
  • kjs/Shell.cpp:
  • runtime/Interpreter.cpp:
  • runtime/JSArray.cpp:
3:37 PM Changeset in webkit [38138] by cwzwarich@webkit.org
  • 14 edits in trunk/JavaScriptCore

2008-11-05 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix the build for case-sensitive build systems.

  • API/JSBase.cpp:
  • API/JSObjectRef.cpp:
  • runtime/CommonIdentifiers.h:
  • runtime/Identifier.cpp:
  • runtime/InitializeThreading.cpp:
  • runtime/InternalFunction.h:
  • runtime/JSString.h:
  • runtime/Lookup.h:
  • runtime/PropertyNameArray.h:
  • runtime/PropertySlot.h:
  • runtime/StructureID.cpp:
  • runtime/StructureID.h:
  • runtime/UString.cpp:
3:21 PM Changeset in webkit [38137] by cwzwarich@webkit.org
  • 95 edits
    26 moves
    5 deletes in trunk

2008-11-05 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move more files to the runtime subdirectory of JavaScriptCore.

JavaScriptCore:

  • API/APICast.h:
  • API/JSBase.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSClassRef.h:
  • API/JSStringRefCF.cpp:
  • API/JSValueRef.cpp:
  • API/OpaqueJSString.cpp:
  • API/OpaqueJSString.h:
  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • VM/CodeBlock.h:
  • VM/CodeGenerator.cpp:
  • VM/Machine.cpp:
  • VM/RegisterFile.h:
  • debugger/Debugger.h:
  • kjs/SourceProvider.h:
  • kjs/TypeInfo.h: Removed.
  • kjs/collector.cpp: Removed.
  • kjs/collector.h: Removed.
  • kjs/completion.h: Removed.
  • kjs/create_hash_table:
  • kjs/identifier.cpp: Removed.
  • kjs/identifier.h: Removed.
  • kjs/interpreter.cpp: Removed.
  • kjs/interpreter.h: Removed.
  • kjs/lexer.cpp:
  • kjs/lexer.h:
  • kjs/lookup.cpp: Removed.
  • kjs/lookup.h: Removed.
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/operations.cpp: Removed.
  • kjs/operations.h: Removed.
  • kjs/protect.h: Removed.
  • kjs/regexp.cpp: Removed.
  • kjs/regexp.h: Removed.
  • kjs/ustring.cpp: Removed.
  • kjs/ustring.h: Removed.
  • pcre/pcre_exec.cpp:
  • profiler/CallIdentifier.h:
  • profiler/Profile.h:
  • runtime/ArrayConstructor.cpp:
  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/Collector.cpp: Copied from kjs/collector.cpp.
  • runtime/Collector.h: Copied from kjs/collector.h.
  • runtime/CollectorHeapIterator.h:
  • runtime/Completion.h: Copied from kjs/completion.h.
  • runtime/ErrorPrototype.cpp:
  • runtime/Identifier.cpp: Copied from kjs/identifier.cpp.
  • runtime/Identifier.h: Copied from kjs/identifier.h.
  • runtime/InitializeThreading.cpp:
  • runtime/Interpreter.cpp: Copied from kjs/interpreter.cpp.
  • runtime/Interpreter.h: Copied from kjs/interpreter.h.
  • runtime/JSCell.h:
  • runtime/JSGlobalData.cpp:
  • runtime/JSGlobalData.h:
  • runtime/JSLock.cpp:
  • runtime/JSNumberCell.cpp:
  • runtime/JSNumberCell.h:
  • runtime/JSObject.cpp:
  • runtime/JSValue.h:
  • runtime/Lookup.cpp: Copied from kjs/lookup.cpp.
  • runtime/Lookup.h: Copied from kjs/lookup.h.
  • runtime/MathObject.cpp:
  • runtime/NativeErrorPrototype.cpp:
  • runtime/NumberPrototype.cpp:
  • runtime/Operations.cpp: Copied from kjs/operations.cpp.
  • runtime/Operations.h: Copied from kjs/operations.h.
  • runtime/PropertyMapHashTable.h:
  • runtime/Protect.h: Copied from kjs/protect.h.
  • runtime/RegExp.cpp: Copied from kjs/regexp.cpp.
  • runtime/RegExp.h: Copied from kjs/regexp.h.
  • runtime/RegExpConstructor.cpp:
  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:
  • runtime/SmallStrings.h:
  • runtime/StringObjectThatMasqueradesAsUndefined.h:
  • runtime/StructureID.cpp:
  • runtime/StructureID.h:
  • runtime/StructureIDTransitionTable.h:
  • runtime/SymbolTable.h:
  • runtime/TypeInfo.h: Copied from kjs/TypeInfo.h.
  • runtime/UString.cpp: Copied from kjs/ustring.cpp.
  • runtime/UString.h: Copied from kjs/ustring.h.
  • wrec/CharacterClassConstructor.h:
  • wrec/WREC.h:

WebCore:

  • ForwardingHeaders/kjs/collector.h: Removed.
  • ForwardingHeaders/kjs/completion.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/interpreter.h: Removed.
  • ForwardingHeaders/kjs/lookup.h: Removed.
  • ForwardingHeaders/kjs/operations.h: Removed.
  • ForwardingHeaders/kjs/protect.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/runtime/Collector.h: Copied from ForwardingHeaders/kjs/collector.h.
  • ForwardingHeaders/runtime/Completion.h: Copied from ForwardingHeaders/kjs/completion.h.
  • ForwardingHeaders/runtime/Identifier.h: Copied from ForwardingHeaders/kjs/identifier.h.
  • ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
  • ForwardingHeaders/runtime/Lookup.h: Copied from ForwardingHeaders/kjs/lookup.h.
  • ForwardingHeaders/runtime/Operations.h: Copied from ForwardingHeaders/kjs/operations.h.
  • ForwardingHeaders/runtime/Protect.h: Copied from ForwardingHeaders/kjs/protect.h.
  • ForwardingHeaders/runtime/UString.h: Copied from ForwardingHeaders/kjs/ustring.h.
  • bindings/js/GCController.cpp:
  • bindings/js/JSCustomPositionCallback.h:
  • bindings/js/JSCustomPositionErrorCallback.h:
  • bindings/js/JSCustomSQLStatementCallback.h:
  • bindings/js/JSCustomSQLStatementErrorCallback.h:
  • bindings/js/JSCustomSQLTransactionErrorCallback.h:
  • bindings/js/JSCustomVoidCallback.h:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSEventListener.h:
  • bindings/js/ScheduledAction.h:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/objc/WebScriptObject.mm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_class.cpp:
  • bridge/jni/jni_class.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/npruntime.cpp:
  • bridge/runtime_root.h:
  • history/CachedPage.h:
  • html/CanvasRenderingContext2D.cpp:
  • html/HTMLCanvasElement.cpp:
  • inspector/InspectorController.cpp:
  • inspector/JavaScriptCallFrame.cpp:
  • page/Console.cpp:
  • page/Page.cpp:
  • platform/text/AtomicString.cpp:
  • platform/text/PlatformString.h:

WebKit/mac:

  • ForwardingHeaders/kjs/collector.h: Removed.
  • ForwardingHeaders/kjs/identifier.h: Removed.
  • ForwardingHeaders/kjs/interpreter.h: Removed.
  • ForwardingHeaders/kjs/lookup.h: Removed.
  • ForwardingHeaders/kjs/operations.h: Removed.
  • ForwardingHeaders/kjs/protect.h: Removed.
  • ForwardingHeaders/runtime/Interpreter.h: Copied from ForwardingHeaders/kjs/interpreter.h.
  • WebView/WebScriptDebugDelegate.mm:

WebKit/wx:

  • WebFrame.cpp:
  • WebView.cpp:
3:19 PM Changeset in webkit [38136] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

2008-11-05 Anders Carlsson <​andersca@apple.com>

Fix 64-bit build.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
12:51 PM Changeset in webkit [38135] by mitz@apple.com
  • 2 edits in trunk/WebKit/win

Reviewed by John Sullivan.

  • make the {protocol,proxyType} argument of WebURLProtectionSpace::initWith{Proxy}Host actually work and fix assertion failures.
  • WebURLProtectionSpace.cpp: (WebURLProtectionSpace::initWithHost): The BString comparisons were applying the BString==BSTR operator to a right hand side that was actually a WCHAR string. Fixed by using BStrings on both sides. (WebURLProtectionSpace::initWithProxyHost): Ditto.
12:03 PM Changeset in webkit [38134] by weinig@apple.com
  • 9 edits in trunk

WebCore:

2008-11-05 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=22085
The Plugin JS object should expose item() and namedItem() methods to match Firefox

  • bindings/js/JSPluginCustom.cpp: (WebCore::JSPlugin::nameGetter):
  • plugins/Plugin.cpp: (WebCore::Plugin::namedItem):
  • plugins/Plugin.h:
  • plugins/Plugin.idl:

LayoutTests:

2008-11-05 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=22085
The Plugin JS object should expose item() and namedItem() methods to match Firefox

  • fast/dom/Window/window-properties-expected.txt:
  • plugins/plugin-javascript-access-expected.txt:
  • plugins/plugin-javascript-access.html:
11:51 AM Changeset in webkit [38133] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-05 Geoffrey Garen <​ggaren@apple.com>

Suggested by Darin Adler.


Removed two copy constructors that the compiler can generate for us
automatically.

  • VM/LabelID.h: (JSC::LabelID::setLocation): (JSC::LabelID::offsetFrom): (JSC::LabelID::ref): (JSC::LabelID::refCount):
  • kjs/LabelScope.h:
11:19 AM Changeset in webkit [38132] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Maciej Stachowiak.

​https://bugs.webkit.org/show_bug.cgi?id=21060
Range#surroundContents incorrectly throws BAD_BOUNDARYPOINTS_ERR

Test: fast/dom/Range/surroundContents-check-boundary-points.html

  • dom/Range.cpp: (WebCore::Range::surroundContents): Fix BAD_BOUNDARYPOINTS_ERR checks.
10:42 AM Changeset in webkit [38131] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-11-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Dan Bernstein.

Remove two global destructors from CoreTextController.


  • platform/graphics/mac/CoreTextController.cpp: (WebCore::CoreTextController::collectCoreTextRunsForCharacters):
10:41 AM Changeset in webkit [38130] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-05 Darin Fisher <​darin@chromium.org>

Reviewed by Darin Adler.

CRASH at Scrollbar::invalidateRect due to null m_client
​https://bugs.webkit.org/show_bug.cgi?id=22080

  • platform/Scrollbar.cpp: (WebCore::Scrollbar::isWindowActive): (WebCore::Scrollbar::invalidateRect):
10:30 AM Changeset in webkit [38129] by weinig@apple.com
  • 17 edits in trunk

WebCore:

2008-11-04 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Hausmann.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=21648
navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

  • Also adds constructors for Plugin, PluginArray, MimeType and MimeTypeArray.
  • bindings/js/JSMimeTypeArrayCustom.cpp: (WebCore::JSMimeTypeArray::nameGetter):
  • bindings/js/JSPluginArrayCustom.cpp: (WebCore::JSPluginArray::nameGetter):
  • page/DOMWindow.idl:
  • plugins/MimeType.idl:
  • plugins/MimeTypeArray.cpp: (WebCore::MimeTypeArray::namedItem):
  • plugins/MimeTypeArray.h:
  • plugins/MimeTypeArray.idl:
  • plugins/Plugin.idl:
  • plugins/PluginArray.cpp: (WebCore::PluginArray::namedItem):
  • plugins/PluginArray.h:
  • plugins/PluginArray.idl:

LayoutTests:

2008-11-04 Sam Weinig <​sam@webkit.org>

Reviewed by Simon Hausmann.

Update tests for ​https://bugs.webkit.org/show_bug.cgi?id=21648
navigator.mimeTypes and navigator.plugins don't expose item and namedItem to JS

  • fast/dom/Window/window-properties-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • plugins/plugin-javascript-access-expected.txt:
  • plugins/plugin-javascript-access.html:
10:24 AM Changeset in webkit [38128] by andersca@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-11-05 Anders Carlsson <​andersca@apple.com>

Fix Snow Leopard build.


10:23 AM Changeset in webkit [38127] by sfalken@apple.com
  • 2 edits in trunk/WebCore

2008-11-05 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • plugins/PluginPackage.cpp:
10:22 AM Changeset in webkit [38126] by andersca@apple.com
  • 4 edits
    1 delete in trunk/WebKit

WebKit:

2008-11-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Remove WebPlugInStreamLoaderDelegate.h


  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-11-05 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Remove WebPlugInStreamLoaderDelegate.h


  • Plugins/WebBaseNetscapePluginStream.h:
  • Plugins/WebPlugInStreamLoaderDelegate.h: Removed.
7:31 AM Changeset in webkit [38125] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-11-05 Jeff Cook <​cookiecaper@gmail.com>

Reviewed by Simon Hausmann and Tor Arne.

Fix crash in the Qt port when unloading swfdec and Flash 10
by reordering window destruction and plugin stop.

See ​https://bugs.webkit.org/show_bug.cgi?id=20779

7:31 AM Changeset in webkit [38124] by Simon Hausmann
  • 4 edits in trunk/WebCore

2008-11-05 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø

Fix loading of Flash 10 in the Qt port by faking the toolkit to be Gtk.

Otherwise Flash refuses to load and function :(

7:31 AM Changeset in webkit [38123] by Simon Hausmann
  • 5 edits in trunk/WebCore

2008-11-05 Simon Hausmann <Simon Hausmann>

Reviewed by Tor Arne Vestbø

Unify determineQuirks between the Qt and the Gtk PluginPackage.
Share the code for parsing the module version from the description.
This is currently used to determine Flash based quirks.

1:25 AM Changeset in webkit [38122] by mitz@apple.com
  • 2687 edits
    2 adds in trunk/LayoutTests

2008-11-05 Pierre-Olivier Latour <​pol@apple.com>

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21821

Another set of updated expected pixel results generated with the same
setup. Includes accessiblity/, animations/, css1/, css2.1/, css3/,
dom/ and editing/.

(file listing elided)

1:07 AM Changeset in webkit [38121] by mitz@apple.com
  • 3868 edits
    18 adds in trunk/LayoutTests

2008-11-05 Pierre-Olivier Latour <​pol@apple.com>

Rubber-stamped by Dan Bernstein.

​https://bugs.webkit.org/show_bug.cgi?id=21821

Imported more image bases for a representative set of pixel tests in order to
fully validate latest DRT and test script changes. These results were generated
by a release build of r38003 on an Intel iMac running Mac OS X 10.5.5 with
QuickTime 7.5.5.

(file listing elided)

12:45 AM Changeset in webkit [38120] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac
  • Tiger build fix
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]):

Nov 4, 2008:

5:44 PM Changeset in webkit [38119] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Don't leak the CALayer.


  • Plugins/WebBaseNetscapePluginView.h: Make the layer a RetainPtr.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView start]):


(-[WebBaseNetscapePluginView stop]):
Make sure to clear out the layer here.

4:58 PM Changeset in webkit [38118] by cwzwarich@webkit.org
  • 3 edits in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Steve Falkenburg.

Move dtoa.cpp and dtoa.h to the WTF Visual Studio project to reflect
their movement in the filesystem.

4:49 PM Changeset in webkit [38117] by cwzwarich@webkit.org
  • 12 edits
    3 moves
    1 delete in trunk

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/dtoa.h to the wtf subdirectory of JavaScriptCore, and remove
its unused forwarding header in WebKit/mac.

JavaScriptCore:

  • AllInOneFile.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/dtoa.cpp: Removed.
  • kjs/dtoa.h: Removed.
  • wtf/dtoa.cpp: Copied from kjs/dtoa.cpp.
  • wtf/dtoa.h: Copied from kjs/dtoa.h.

WebCore:

  • ForwardingHeaders/kjs/dtoa.h: Removed.
  • ForwardingHeaders/wtf/dtoa.h: Copied from ForwardingHeaders/kjs/dtoa.h.
  • css/CSSParser.cpp:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs/dtoa.h: Removed.
4:45 PM Changeset in webkit [38116] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

More cleanup. Make a bunch of instance variables RetainPtrs.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView visibleRect]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView restartTimers]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView didStart]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView pluginPackage]): (-[WebBaseNetscapePluginView setPluginPackage:]): (-[WebBaseNetscapePluginView setAttributeKeys:andValues:]): (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView fini]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView requestWithURLCString:]): (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): (-[WebBaseNetscapePluginView loadPluginRequest:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): (-[WebBaseNetscapePluginView userAgent]): (-[WebBaseNetscapePluginView getVariable:value:]): (-[WebBaseNetscapePluginView setVariable:value:]): (-[WebBaseNetscapePluginView _createPlugin]): (-[WebBaseNetscapePluginView _redeliverStream]):
4:24 PM Changeset in webkit [38115] by pam@chromium.org
  • 5 edits
    4 adds in trunk

2008-11-04 Jonathan Haas <​myrdred@gmail.com>

Addiitonal tweaks and patch prep by Pamela Greene <​pam@chromium.org>

Reviewed by Darin Adler.

Fixed an issue which could cause memory corruption using ToT libxml.
See ​https://bugs.webkit.org/show_bug.cgi?id=15715

Test: fast/xsl/xslt-nested-stylesheets.xml

  • xml/XSLImportRule.cpp: (WebCore::XSLImportRule::setXSLStyleSheet): Set parent rather than owner document
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::XSLStyleSheet): Initialize m_parentStyleSheet (WebCore::XSLStyleSheet::parseString): Make all child stylesheets use parent's dictionary (WebCore::XSLStyleSheet::setParentStyleSheet): Added
  • xml/XSLStyleSheet.h: Added m_parentStyleSheet member

2008-11-04 Pamela Greene <​pam@chromium.org>

Reviewed by Darin Adler.

Added test for crash resulting from nested stylesheets using certain
builds of libxml2. See ​https://bugs.webkit.org/show_bug.cgi?id=15715 .

  • fast/xsl/resources/xslt-nested-stylesheets0.xsl: Added.
  • fast/xsl/resources/xslt-nested-stylesheets1.xsl: Added.
  • fast/xsl/xslt-nested-stylesheets-expected.txt: Added.
  • fast/xsl/xslt-nested-stylesheets.xml: Added.
3:44 PM Changeset in webkit [38114] by cwzwarich@webkit.org
  • 4 edits
    1 move in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Sam Weinig.

Move kjs/config.h to the top level of JavaScriptCore.

  • GNUmakefile.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • config.h: Copied from kjs/config.h.
  • kjs/config.h: Removed.
3:00 PM Changeset in webkit [38113] by Simon Fraser
  • 2 edits in trunk/WebKitTools

2008-11-04 Simon Fraser <Simon Fraser>

Add AccessibilityObject.o to the exclude list for the
check for global destructors.

  • Scripts/check-for-exit-time-destructors:
2:40 PM Changeset in webkit [38112] by Simon Fraser
  • 2 edits in trunk/WebCore

2008-11-04 Simon Fraser <Simon Fraser>

No review.

Improved buid fix: include MathExtras.h to get roundf on all platforms.

  • platform/graphics/FloatPoint.h:
2:08 PM Changeset in webkit [38111] by Darin Adler
  • 2 edits in trunk/WebKitTools

2008-11-04 Darin Adler <Darin Adler>

  • Scripts/check-for-exit-time-destructors: Fix failures seen on the bot, but for some reason not on my computer.
12:55 PM Changeset in webkit [38110] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2008-11-04 Brady Eidson <​beidson@apple.com>

Reviewed by John Sullivan

Add a simple "visited" method to HistoryItem for use by global history

  • WebCore.base.exp:
  • history/HistoryItem.cpp: (WebCore::HistoryItem::visited): Update the title on the item, set last visited time, and bump the visit count. All things that should happen when a url is visited again!
  • history/HistoryItem.h:

WebKit/mac:

2008-11-04 Brady Eidson <​beidson@apple.com>

Reviewed by John Sullivan

Cleanup global history a tad.

Used to _addItemForURL always create a new item and merge it with a previous item if one existed.

It is more efficient and less complicated to update the previous item if one exists.

  • History/WebHistory.mm: (-[WebHistoryPrivate visitedURL:withTitle:]): (-[WebHistory _visitedURL:withTitle:]): Instead of calling the general purpose [WebHistoryPrivate addItem:] with a new history item, call the new special purposed visitedURL:withTitle:
  • History/WebHistoryInternal.h:
  • History/WebHistoryItem.mm: (-[WebHistoryItem _visitedWithTitle:]): Call "visited()" on the WebCore history item with the pertinent info.
  • History/WebHistoryItemInternal.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):
12:08 PM Changeset in webkit [38109] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

​https://bugs.webkit.org/show_bug.cgi?id=22065

Only create the plug-in stream loader when the stream is started.


  • Plugins/WebBaseNetscapePluginStream.mm: (WebNetscapePluginStream::WebNetscapePluginStream): (WebNetscapePluginStream::start):
11:43 AM Changeset in webkit [38108] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-11-04 Jan Michael Alonzo <​jmalonzo@webkit.org>

Build fix. Not reviewed.

  • platform/graphics/FloatPoint.h: include math.h. reported by zdobersek in #webkit.
11:40 AM Changeset in webkit [38107] by darin@chromium.org
  • 2 edits in trunk/WebCore

2008-11-04 Darin Fisher <​darin@chromium.org>

Reviewed by Anders Carlsson.

No need to clobber all ResourceRequest fields in FrameLoader::reload()
​https://bugs.webkit.org/show_bug.cgi?id=21949

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload):
11:00 AM Changeset in webkit [38106] by Darin Adler
  • 2 edits in trunk/WebCore

2008-11-04 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • storage/Database.cpp: (WebCore::databaseVersionKey): Tweaked formatting.
10:59 AM Changeset in webkit [38105] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-11-04 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • wtf/ThreadingNone.cpp: Tweak formatting.
10:58 AM Changeset in webkit [38104] by Darin Adler
  • 8 edits in trunk/WebCore

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • WebCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.
  • html/HTMLAttributeNames.in: Removed some unused attribute names.
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::parseMappedAttribute): Removed code that sets the write-only m_pluginPage.
  • html/HTMLEmbedElement.h: Ditto.
  • platform/mac/CursorMac.mm: (WebCore::leakNamedCursor): Changed to return a Cursor&. (WebCore::pointerCursor): Changed to leak an object to avoid an exit-time destructor. (WebCore::crossCursor): Ditto. (WebCore::handCursor): Ditto. (WebCore::moveCursor): Ditto. (WebCore::verticalTextCursor): Ditto. (WebCore::cellCursor): Ditto. (WebCore::contextMenuCursor): Ditto. (WebCore::aliasCursor): Ditto. (WebCore::zoomInCursor): Ditto. (WebCore::zoomOutCursor): Ditto. (WebCore::copyCursor): Ditto. (WebCore::noneCursor): Ditto. (WebCore::progressCursor): Ditto. (WebCore::noDropCursor): Ditto. (WebCore::notAllowedCursor): Ditto. (WebCore::iBeamCursor): Ditto. (WebCore::waitCursor): Ditto. (WebCore::helpCursor): Ditto. (WebCore::eastResizeCursor): Ditto. (WebCore::northResizeCursor): Ditto. (WebCore::northEastResizeCursor): Ditto. (WebCore::northWestResizeCursor): Ditto. (WebCore::southResizeCursor): Ditto. (WebCore::southEastResizeCursor): Ditto. (WebCore::southWestResizeCursor): Ditto. (WebCore::westResizeCursor): Ditto. (WebCore::northSouthResizeCursor): Ditto. (WebCore::eastWestResizeCursor): Ditto. (WebCore::northEastSouthWestResizeCursor): Ditto. (WebCore::northWestSouthEastResizeCursor): Ditto. (WebCore::columnResizeCursor): Ditto. (WebCore::rowResizeCursor): Ditto. (WebCore::grabCursor): Ditto. (WebCore::grabbingCursor): Ditto.
  • storage/Database.cpp: (WebCore::guidMutex): Changed to leak an object to avoid an exit-time destructor. Also added a comment explaining why it's thread safe. (WebCore::guidToVersionMap): Ditto. (WebCore::guidToDatabaseMap): Ditto. (WebCore::Database::databaseInfoTableName): Ditto. (WebCore::databaseVersionKey): Ditto. (WebCore::Database::getVersionFromDatabase): Ditto. (WebCore::Database::setVersionInDatabase): Ditto. (WebCore::guidForOriginAndName): Ditto.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::tracker): Ditto. (WebCore::notificationMutex): Ditto. (WebCore::notificationQueue): Ditto. (WebCore::DatabaseTracker::notifyDatabasesChanged): Ditto.
10:57 AM Changeset in webkit [38103] by mitz@apple.com
  • 1 edit
    544 deletes in trunk/LayoutTests

2008-11-04 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

  • part of ​https://bugs.webkit.org/show_bug.cgi?id=21821 Removed pixel results in platform/mac-tiger that were only slightly different (within 1% tolerance) from the platform/mac results. Removed results in platform/mac-tiger where the results in platform/mac were also correct for Tiger.

(file listing elided)

10:57 AM Changeset in webkit [38102] by Darin Adler
  • 2 edits in trunk/WebKit

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • WebKit.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.
10:57 AM Changeset in webkit [38101] by Darin Adler
  • 11 edits in trunk/JavaScriptCore

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • JavaScriptCore.exp: Changed to export functions rather than a global for the atomically initialized static mutex.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added a script phase that runs the check-for-exit-time-destructors script.
  • wtf/MainThread.cpp: (WTF::mainThreadFunctionQueueMutex): Changed to leak an object rather than using an exit time destructor. (WTF::functionQueue): Ditto.
  • wtf/unicode/icu/CollatorICU.cpp: (WTF::cachedCollatorMutex): Ditto.
  • wtf/Threading.h: Changed other platforms to share the Windows approach where the mutex is internal and the functions are exported.
  • wtf/ThreadingGtk.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
  • wtf/ThreadingNone.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Ditto. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
  • wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): Changed to leak an object rather than using an exit time destructor. (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto. (WTF::threadMap): Changed to leak an object rather than using an exit time destructor.
  • wtf/ThreadingQt.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Mutex change. (WTF::unlockAtomicallyInitializedStaticMutex): Ditto.
  • wtf/ThreadingWin.cpp: (WTF::lockAtomicallyInitializedStaticMutex): Added an assertion.
10:56 AM Changeset in webkit [38100] by Darin Adler
  • 2 edits
    1 copy in trunk/WebKitTools

2008-11-03 Darin Adler <Darin Adler>

Reviewed by Tim Hatcher.

  • Scripts/check-for-exit-time-destructors: Added. Started as a copy of check-for-global-initializers.
  • Scripts/check-for-global-initializers: Added code to make this script rerun any time it's modified, and also to properly run again after the first time it reports an error.
10:55 AM Changeset in webkit [38099] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-11-04 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.


​https://bugs.webkit.org/show_bug.cgi?id=22065


Remove some old, unused plug-in code.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView setVariable:value:]):
10:54 AM Changeset in webkit [38098] by Simon Fraser
  • 43 edits in trunk

2008-11-04 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=21941

Rename absolutePosition() to localToAbsolute(), and add the ability
to optionally take transforms into account (which will eventually be the
default behavior).

8:22 AM Changeset in webkit [38097] by Simon Hausmann
  • 9 edits in trunk

WebCore:

2008-11-03 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add methods for getting and setting user data on History Item.
This change is limited to QT port only. Tests were added in
the patch for ​https://bugs.webkit.org/show_bug.cgi?id=21864.

Minor change by Simon: made the functions inline and added a missing
const.

WebKit/qt:

2008-10-24 Yael Aharon <​yael.aharon@nokia.com>

Reviewed by Simon Hausmann.

Add userData() and setUserData() to QWebHistoryItem.
Add setMaximumItemCount() and maximumItemCount() to QWebHistory.
Add currentItemIndex() to QWebHistory.

See also ​https://bugs.webkit.org/show_bug.cgi?id=21864

Small cleanup by Simon (docs and forward declaration of QWebHistoryItem in qwebframe.h)

6:15 AM Changeset in webkit [38096] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update the location of JSStaticScopeObject.{cpp,h}.
4:49 AM QtWebKitJournal edited by ariya.hidayat@trolltech.com
update (diff)
2:59 AM Changeset in webkit [38095] by cwzwarich@webkit.org
  • 3 edits
    1 move in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Alexey Proskuryakov.

Move AllInOneFile.cpp to the top level of JavaScriptCore.

  • AllInOneFile.cpp: Copied from kjs/AllInOneFile.cpp.
  • GNUmakefile.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/AllInOneFile.cpp: Removed.
2:46 AM Changeset in webkit [38094] by ap@webkit.org
  • 103 edits in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22030
Make EventNames usable from multiple threads

  • platform/text/AtomicString.cpp: (WebCore::stringTable): (WebCore::AtomicString::add): (WebCore::AtomicString::remove): (WebCore::AtomicString::find): (WebCore::AtomicString::init):
  • platform/text/AtomicString.h: Atomic string table is now per-thread. Individual strings cannot be shared between threads, so global AtomicString constants cannot be used from threads other than the main one.
  • dom/EventNames.cpp: (WebCore::EventNames::EventNames): (WebCore::eventNames): (WebCore::EventNames::init):
  • dom/EventNames.h: Made EventNames a ThreadSpecific struct. Individual event names are now accessed as eventNames().fooEvent, not EventNames::fooEvent. This makes EventNames usable from all threads.
  • <Many files>: Access event names via eventNames() function.
2:40 AM Changeset in webkit [38093] by cwzwarich@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Alexey Proskuryakov.

Add NodeInfo.h to the JavaScriptCore Xcode project.

1:43 AM Changeset in webkit [38092] by cwzwarich@webkit.org
  • 2 edits
    4 deletes in trunk

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Mark Rowe.

Delete unused forwarding headers.

WebCore:

  • ForwardingHeaders/kjs/Activation.h: Removed.
  • ForwardingHeaders/kjs/Register.h: Removed.
  • ForwardingHeaders/kjs/RegisterID.h: Removed.

WebKit/mac:

  • ForwardingHeaders/kjs/string_object.h: Removed.
12:58 AM Changeset in webkit [38091] by cwzwarich@webkit.org
  • 2 edits
    1 copy
    1 add
    1 delete in trunk/JavaScriptGlue

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Mark Rowe.

Remove JavaScriptGlue forwarding headers that are no longer necessary,
and correct the path of the ExecState.h forwarding header.

  • ForwardingHeaders/kjs: Removed.
  • ForwardingHeaders/kjs/CTI.h: Removed.
  • ForwardingHeaders/kjs/ExecState.h: Removed.
  • ForwardingHeaders/kjs/JSValue.h: Removed.
  • ForwardingHeaders/kjs/PutPropertySlot.h: Removed.
  • ForwardingHeaders/kjs/ustring.h: Removed.
  • ForwardingHeaders/runtime: Added.
  • ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • config.h:
12:07 AM Changeset in webkit [38090] by cwzwarich@webkit.org
  • 4 edits in trunk/WebCore

2008-11-04 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix stupid typo in previous build fix.

  • bindings/js/JSStorageCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:

Nov 3, 2008:

11:56 PM Changeset in webkit [38089] by cwzwarich@webkit.org
  • 4 edits
    1 move in trunk/WebCore

2008-11-03 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix the build for all non-Mac platforms.

  • ForwardingHeaders/kjs/PropertyNameArray.h: Removed.
  • ForwardingHeaders/runtime/PropertyNameArray.h: Copied from ForwardingHeaders/kjs/PropertyNameArray.h.
  • bindings/js/JSStorageCustom.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bridge/NP_jsobject.cpp:
11:33 PM Changeset in webkit [38088] by cwzwarich@webkit.org
  • 2 edits in trunk/WebCore

2008-11-03 Cameron Zwarich <​zwarich@apple.com>

Not reviewed.

Fix the wxWindows build.

  • bridge/c/c_instance.cpp:
11:10 PM Changeset in webkit [38087] by cwzwarich@webkit.org
  • 83 edits
    40 moves in trunk

2008-11-03 Cameron Zwarich <​zwarich@apple.com>

Rubber-stamped by Maciej Stachowiak.

Move more files into the runtime subdirectory of JavaScriptCore.

JavaScriptCore:

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSClassRef.cpp:
  • API/OpaqueJSString.cpp:
  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/ArgList.cpp: Removed.
  • kjs/ArgList.h: Removed.
  • kjs/Arguments.cpp: Removed.
  • kjs/Arguments.h: Removed.
  • kjs/BatchedTransitionOptimizer.h: Removed.
  • kjs/CollectorHeapIterator.h: Removed.
  • kjs/CommonIdentifiers.cpp: Removed.
  • kjs/CommonIdentifiers.h: Removed.
  • kjs/ExecState.cpp: Removed.
  • kjs/ExecState.h: Removed.
  • kjs/GetterSetter.cpp: Removed.
  • kjs/GetterSetter.h: Removed.
  • kjs/InitializeThreading.cpp: Removed.
  • kjs/InitializeThreading.h: Removed.
  • kjs/JSActivation.cpp: Removed.
  • kjs/JSActivation.h: Removed.
  • kjs/JSGlobalData.cpp: Removed.
  • kjs/JSGlobalData.h: Removed.
  • kjs/JSLock.cpp: Removed.
  • kjs/JSLock.h: Removed.
  • kjs/JSStaticScopeObject.cpp: Removed.
  • kjs/JSStaticScopeObject.h: Removed.
  • kjs/JSType.h: Removed.
  • kjs/PropertyNameArray.cpp: Removed.
  • kjs/PropertyNameArray.h: Removed.
  • kjs/ScopeChain.cpp: Removed.
  • kjs/ScopeChain.h: Removed.
  • kjs/ScopeChainMark.h: Removed.
  • kjs/SymbolTable.h: Removed.
  • kjs/Tracing.d: Removed.
  • kjs/Tracing.h: Removed.
  • runtime/ArgList.cpp: Copied from kjs/ArgList.cpp.
  • runtime/ArgList.h: Copied from kjs/ArgList.h.
  • runtime/Arguments.cpp: Copied from kjs/Arguments.cpp.
  • runtime/Arguments.h: Copied from kjs/Arguments.h.
  • runtime/BatchedTransitionOptimizer.h: Copied from kjs/BatchedTransitionOptimizer.h.
  • runtime/CollectorHeapIterator.h: Copied from kjs/CollectorHeapIterator.h.
  • runtime/CommonIdentifiers.cpp: Copied from kjs/CommonIdentifiers.cpp.
  • runtime/CommonIdentifiers.h: Copied from kjs/CommonIdentifiers.h.
  • runtime/ExecState.cpp: Copied from kjs/ExecState.cpp.
  • runtime/ExecState.h: Copied from kjs/ExecState.h.
  • runtime/GetterSetter.cpp: Copied from kjs/GetterSetter.cpp.
  • runtime/GetterSetter.h: Copied from kjs/GetterSetter.h.
  • runtime/InitializeThreading.cpp: Copied from kjs/InitializeThreading.cpp.
  • runtime/InitializeThreading.h: Copied from kjs/InitializeThreading.h.
  • runtime/JSActivation.cpp: Copied from kjs/JSActivation.cpp.
  • runtime/JSActivation.h: Copied from kjs/JSActivation.h.
  • runtime/JSGlobalData.cpp: Copied from kjs/JSGlobalData.cpp.
  • runtime/JSGlobalData.h: Copied from kjs/JSGlobalData.h.
  • runtime/JSLock.cpp: Copied from kjs/JSLock.cpp.
  • runtime/JSLock.h: Copied from kjs/JSLock.h.
  • runtime/JSStaticScopeObject.cpp: Copied from kjs/JSStaticScopeObject.cpp.
  • runtime/JSStaticScopeObject.h: Copied from kjs/JSStaticScopeObject.h.
  • runtime/JSType.h: Copied from kjs/JSType.h.
  • runtime/PropertyNameArray.cpp: Copied from kjs/PropertyNameArray.cpp.
  • runtime/PropertyNameArray.h: Copied from kjs/PropertyNameArray.h.
  • runtime/ScopeChain.cpp: Copied from kjs/ScopeChain.cpp.
  • runtime/ScopeChain.h: Copied from kjs/ScopeChain.h.
  • runtime/ScopeChainMark.h: Copied from kjs/ScopeChainMark.h.
  • runtime/SymbolTable.h: Copied from kjs/SymbolTable.h.
  • runtime/Tracing.d: Copied from kjs/Tracing.d.
  • runtime/Tracing.h: Copied from kjs/Tracing.h.

WebCore:

  • ForwardingHeaders/kjs/ArgList.h: Removed.
  • ForwardingHeaders/kjs/CollectorHeapIterator.h: Removed.
  • ForwardingHeaders/kjs/ExecState.h: Removed.
  • ForwardingHeaders/kjs/InitializeThreading.h: Removed.
  • ForwardingHeaders/kjs/JSGlobalData.h: Removed.
  • ForwardingHeaders/kjs/JSLock.h: Removed.
  • ForwardingHeaders/kjs/SymbolTable.h: Removed.
  • ForwardingHeaders/runtime/ArgList.h: Copied from ForwardingHeaders/kjs/ArgList.h.
  • ForwardingHeaders/runtime/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/CollectorHeapIterator.h.
  • ForwardingHeaders/runtime/ExecState.h: Copied from ForwardingHeaders/kjs/ExecState.h.
  • ForwardingHeaders/runtime/InitializeThreading.h: Copied from ForwardingHeaders/kjs/InitializeThreading.h.
  • ForwardingHeaders/runtime/JSGlobalData.h: Copied from ForwardingHeaders/kjs/JSGlobalData.h.
  • ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
  • ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
  • bindings/js/GCController.cpp:
  • bindings/js/JSCustomPositionCallback.cpp:
  • bindings/js/JSCustomPositionErrorCallback.cpp:
  • bindings/js/JSCustomSQLStatementCallback.cpp:
  • bindings/js/JSCustomSQLStatementErrorCallback.cpp:
  • bindings/js/JSCustomSQLTransactionCallback.cpp:
  • bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMWindowBase.cpp:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSNodeFilterCondition.cpp:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptControllerMac.mm:
  • bindings/objc/WebScriptObject.mm:
  • bridge/NP_jsobject.cpp:
  • bridge/c/c_class.cpp:
  • bridge/c/c_instance.cpp:
  • bridge/c/c_runtime.cpp:
  • bridge/c/c_utility.cpp:
  • bridge/jni/jni_class.cpp:
  • bridge/jni/jni_instance.cpp:
  • bridge/jni/jni_jsobject.mm:
  • bridge/jni/jni_objc.mm:
  • bridge/jni/jni_runtime.cpp:
  • bridge/jni/jni_runtime.h:
  • bridge/jni/jni_utility.cpp:
  • bridge/npruntime.cpp:
  • bridge/objc/objc_instance.mm:
  • bridge/objc/objc_runtime.mm:
  • bridge/objc/objc_utility.mm:
  • bridge/runtime.cpp:
  • dom/Document.cpp:
  • dom/Node.cpp:
  • dom/NodeFilter.cpp:
  • dom/NodeIterator.cpp:
  • dom/TreeWalker.cpp:
  • history/CachedPage.cpp:
  • inspector/InspectorController.cpp:
  • inspector/JavaScriptCallFrame.cpp:
  • inspector/JavaScriptCallFrame.h:
  • inspector/JavaScriptDebugServer.cpp:
  • inspector/JavaScriptProfileNode.cpp:
  • loader/FrameLoader.cpp:
  • loader/icon/IconDatabase.cpp:
  • page/Console.cpp:
  • page/Page.cpp:
  • page/mac/FrameMac.mm:
  • plugins/PluginView.cpp:
  • plugins/gtk/PluginViewGtk.cpp:
  • plugins/qt/PluginViewQt.cpp:
  • plugins/win/PluginViewWin.cpp:
  • storage/Database.cpp:
  • xml/XMLHttpRequest.cpp:

WebKit/gtk:

  • webkit/webkitprivate.cpp:

WebKit/mac:

  • ForwardingHeaders/kjs/JSLock.h: Removed.
  • ForwardingHeaders/kjs/SymbolTable.h: Removed.
  • ForwardingHeaders/runtime/JSLock.h: Copied from ForwardingHeaders/kjs/JSLock.h.
  • ForwardingHeaders/runtime/SymbolTable.h: Copied from ForwardingHeaders/kjs/SymbolTable.h.
  • Misc/WebCoreStatistics.mm:
  • Plugins/WebBaseNetscapePluginStream.mm:
  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebPluginController.mm:
  • WebView/WebFrame.mm:
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebView.mm:

WebKit/qt:

  • Api/qwebpage.cpp:

WebKit/win:

  • WebJavaScriptCollector.cpp:
11:01 PM Changeset in webkit [38086] by mitz@apple.com
  • 4 edits in trunk/WebKit/win

Reviewed by Steve Falkenburg.

  • implement WebMutableURLRequest::setHTTPShouldHandleCookies()
  • add and implement WebMutableURLRequest::mutableCopy()
  • Interfaces/IWebURLRequest.idl:
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::setHTTPShouldHandleCookies): (WebMutableURLRequest::mutableCopy):
  • WebMutableURLRequest.h:
10:38 PM Changeset in webkit [38085] by mrowe@apple.com
  • 2 edits in trunk/WebKit/mac

Fix the 64-bit build.

Pull the frequently-made check for drawingModel == NPDrawingModelQuickDraw out into a
helper function to avoid #ifdef'ing all of the new places that this check is made.

A few other #ifdef's are moved inside functions to allow their call sites to remain #ifdef-free,
and we rely on the compiler to optimise out the check (which will always be false in 64-bit) instead.

  • Plugins/WebBaseNetscapePluginView.mm:

(isDrawingModelQuickDraw):
(-[WebBaseNetscapePluginView fixWindowPort]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView sendEvent:isDrawRect:]):
(-[WebBaseNetscapePluginView updateAndSetWindow]):
(-[WebBaseNetscapePluginView start]):
(-[WebBaseNetscapePluginView tellQuickTimeToChill]):
(-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
(-[WebBaseNetscapePluginView _viewHasMoved]):

8:25 PM Changeset in webkit [38084] by alp@webkit.org
  • 2 edits in trunk

2008-11-03 Alp Toker <​alp@nuanti.com>

autotools distcleancheck fix. Add dolt-generated files and
webkitenumtypes.h to the list of files that need to be cleaned.
Unreviewed.

  • GNUmakefile.am:
8:00 PM Changeset in webkit [38083] by cwzwarich@webkit.org
  • 1 edit
    1 delete in trunk/WebCore

2008-11-03 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Sam Weinig.

Remove the forwarding header for FunctionCallProfile, because it was
renamed to ProfileNode in r33466.

  • ForwardingHeaders/kjs/FunctionCallProfile.h: Removed.
6:32 PM Changeset in webkit [38082] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

2008-11-03 Pierre-Olivier Latour <​pol@apple.com>

Reviewed by Dan Bernstein.

Fixed the override of the "AppleScrollBarVariant" system setting to also work with HIToolbox.

​https://bugs.webkit.org/show_bug.cgi?id=22054

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
4:33 PM Changeset in webkit [38081] by mjs@apple.com
  • 2 edits in trunk/WebKit/mac

2008-11-03 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Kevin Decker.


  • fix release build (and unitialized variable for CG drawing model!)
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): initialize portState in all code paths
2:43 PM Changeset in webkit [38080] by weinig@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-11-03 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Move #define to turn on dumping StructureID statistics to StructureID.cpp so that
turning it on does not require a full rebuild.

  • runtime/StructureID.cpp: (JSC::StructureID::dumpStatistics):
  • runtime/StructureID.h:
2:37 PM Changeset in webkit [38079] by Simon Fraser
  • 3 edits
    4 adds in trunk

2008-11-03 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

​https://bugs.webkit.org/show_bug.cgi?id=22026

When computing the bounds of the transparency layer, we need to
map the clipRect through the enclosing transform.

Test: fast/layers/opacity-transforms.html

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox):
12:52 PM Changeset in webkit [38078] by kdecker@apple.com
  • 5 edits in trunk

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=22053


This patch adds initial support for the NPDrawingModelCoreAnimation drawing model.


  • Plugins/WebBaseNetscapePluginView.h: Added _layer ivar.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation. (-[WebBaseNetscapePluginView restorePortState:]): Ditto. (-[WebBaseNetscapePluginView sendEvent:isDrawRect:]): Slightly refactored a small block of code which with the PortState. Plug-ins using the NPDrawingModelCoreAnimation drawing model have no PortState. (-[WebBaseNetscapePluginView isNewWindowEqualToOldWindow]): ASSERT this is not a plug-in using NPDrawingModelCoreAnimation (-[WebBaseNetscapePluginView updateAndSetWindow]): Ditto. (-[WebBaseNetscapePluginView setWindowIfNecessary]): Ditto. (-[WebBaseNetscapePluginView start]): If the plug-in is a plug-in using the Core Animation model, request a layer from it. (-[WebBaseNetscapePluginView drawRect:]): Return early for NPDrawingModelCoreAnimation plug-ins. (-[WebBaseNetscapePluginView getVariable:value:]): Tell plug-ins running on post-Tiger systems WebKit supports NPDrawingModelCoreAnimation. (-[WebBaseNetscapePluginView setVariable:value:]): Added the new NPDrawingModelCoreAnimation case, which initializes drawingMode. (-[WebBaseNetscapePluginView _viewHasMoved]): Reworded the conditional call to updateAndSetWindow to be specific to CoreGraphics and QuickDraw plug-ins.

Reviewed by Anders Carlsson.

​https://bugs.webkit.org/show_bug.cgi?id=22053

Added additional support needed for the NPDrawingModelCoreAnimation drawing model.

  • bridge/npapi.h:
12:47 PM Changeset in webkit [38077] by alp@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-03 Alp Toker <​alp@nuanti.com>

Reviewed by Geoffrey Garen.

Fix warning when building on Darwin without JSC_MULTIPLE_THREADS
enabled.

  • kjs/InitializeThreading.cpp:
12:29 PM Changeset in webkit [38076] by alp@webkit.org
  • 3 edits in trunk/WebKit/gtk

2008-11-03 Alp Toker <​alp@nuanti.com>

Reviewed by Holger Freyther.

Deprecate flawed webkit_web_frame_new() function. This would never
have worked properly when used outside WebCore since Frame::create()
can only be called without an owner element once in the lifetime of a
Page and would result in assertions, leaks and an unusable WebView
instance.

Frame creation may be exposed in API some time later via the DOM
binding but probably not in the WebKit GTK+ core API.

  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
11:15 AM Changeset in webkit [38075] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-03 Xan Lopez <​xan@gnome.org>

Reviewed by Alp Toker.

Update parseDataUrl() function in the libsoup http backend with
the one from the curl backend which has recent correctness and crash
fixes.

  • platform/network/soup/ResourceHandleSoup.cpp: (WebCore::parseDataUrl):
10:37 AM Changeset in webkit [38074] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-03 Alp Toker <​alp@nuanti.com>

Reviewed by Holger Freyther.

Redundant scrollbars appear in frames where they shouldn't be visible
eg. embedded Google adverts.

Call setCanHaveScrollbars() when necessary. The Mac and Win ports
already have this but it was missing in FrameLoaderClientGtk.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
10:26 AM Changeset in webkit [38073] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-11-03 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Sync WebKit GTK+ default UA version string to 528.5+. (We're still
doing this manually!)

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::composeUserAgent):
9:27 AM Changeset in webkit [38072] by alp@webkit.org
  • 2 edits in trunk

2008-11-03 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Do not enable RTTI or exceptions in debug builds, matching release
builds. They don't help much with debugging and significantly slow
down and increase the size of the debug build.

  • GNUmakefile.am:
9:11 AM Changeset in webkit [38071] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-03 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=22041
Fix CURL crashes on the test suite

Fix segfault with setDefersLoading(). Do not call into curl when we
don't have a CURL handle.

It is attempted to defer the loading before the load has been
started (no curl handle was allocated yet). If that happens then
just remember that. ResourceHandleManager::startJob is already taking
care of this and in initResourceHandle the the downloading will
be paused if needed.

Fixes fast/loader/simultaneous-reloads-assert.html

  • platform/network/curl/ResourceHandleCurl.cpp: (WebCore::ResourceHandle::setDefersLoading):
8:50 AM Changeset in webkit [38070] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-11-03 Holger Hans Peter Freyther <​zecke@selfish.org>

Reviewed by Alp Toker.

​https://bugs.webkit.org/show_bug.cgi?id=22041
Fix CURL crashes on the test suite

Do not send "no data" to WebCore in parseDataUrl().

Fixes assert on fast/tokenizer/image-empty-crash.html

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl):
7:59 AM Changeset in webkit [38069] by alp@webkit.org
  • 2 edits in trunk

2008-11-03 Alp Toker <​alp@nuanti.com>

Rubber-stamped by Holger Freyther.

Add mingw32 case to dolt for faster GTK+ Windows builds.

  • acinclude.m4:

Nov 2, 2008:

1:14 PM Changeset in webkit [38068] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-11-02 Matt Lilek <​webkit@mattlilek.com>

Reviewed by Cameron Zwarich.

Bug 22042: REGRESSION(r38066): ASSERTION FAILED: source in CodeBlock
<​https://bugs.webkit.org/show_bug.cgi?id=22042>

Rename parameter name to avoid ASSERT.

  • VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
12:23 PM Changeset in webkit [38067] by christian@webkit.org
  • 4 edits in trunk

2008-11-02 Xan Lopez <​xan@gnome.org>

Reviewed by Holger Freyther

​https://bugs.webkit.org/show_bug.cgi?id=22009
HTML5 Video with GStreamer pulls gnome-vfs without using it.

  • configure.ac: Remove gnome-vfs from configure.ac, it's unused.
3:29 AM Changeset in webkit [38066] by cwzwarich@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-11-02 Cameron Zwarich <​zwarich@apple.com>

Reviewed by Oliver Hunt.

Bug 22035: Remove the '_' suffix on constructor parameter names for structs
<​https://bugs.webkit.org/show_bug.cgi?id=22035>

  • API/JSCallbackObject.h: (JSC::JSCallbackObject::JSCallbackObjectData::JSCallbackObjectData):
  • VM/CodeBlock.h: (JSC::CodeBlock::CodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock):
  • wrec/WREC.h: (JSC::Quantifier::Quantifier):

Nov 1, 2008:

2:31 AM Changeset in webkit [38065] by abarth@webkit.org
  • 6 edits
    6 adds in trunk

WebCore:

2008-11-01 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Be sure to check the final URLs of requested resources to make sure we
don't get fooled by HTTP redirects.

​https://bugs.webkit.org/show_bug.cgi?id=21963

Tests: http/tests/security/xss-DENIED-xsl-document-redirect.xml

http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml

  • dom/XMLTokenizerLibxml2.cpp: (WebCore::openFunc):
  • loader/DocLoader.cpp: (WebCore::DocLoader::canRequest): (WebCore::DocLoader::requestResource):
  • loader/DocLoader.h:
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):

LayoutTests:

2008-11-01 Adam Barth <​abarth@webkit.org>

Reviewed by Sam Weinig.

Test that we properly block non-same-origin redirects for these
esoteric loads.

​https://bugs.webkit.org/show_bug.cgi?id=21963

  • http/tests/security/resources/xsl-using-document-redirect.xsl: Added.
  • http/tests/security/resources/xsl-using-external-entity-redirect.xsl: Added.
  • http/tests/security/xss-DENIED-xsl-document-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-document-expected.txt.
  • http/tests/security/xss-DENIED-xsl-document-redirect.xml: Added.
  • http/tests/security/xss-DENIED-xsl-external-entity-redirect-expected.txt: Copied from LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-expected.txt.
  • http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml: Added.
12:21 AM Changeset in webkit [38064] by ap@webkit.org
  • 10 edits
    2 adds in trunk

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=22001
AtomicStringImpl* keys of event listener maps can outlive their strings

Test: fast/events/destroyed-atomic-string.html

  • dom/MessagePort.cpp: (WebCore::MessagePort::addEventListener): (WebCore::MessagePort::removeEventListener): (WebCore::MessagePort::dispatchEvent):
  • dom/MessagePort.h:
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::addEventListener): (WebCore::DOMApplicationCache::removeEventListener): (WebCore::DOMApplicationCache::dispatchEvent):
  • loader/appcache/DOMApplicationCache.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::addEventListener): (WebCore::XMLHttpRequest::removeEventListener): (WebCore::XMLHttpRequest::dispatchEvent):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::addEventListener): (WebCore::XMLHttpRequestUpload::removeEventListener): (WebCore::XMLHttpRequestUpload::dispatchEvent):
  • xml/XMLHttpRequestUpload.h: Changed EventListenersMap to use AtomicString as key (instead of AtomicStringImpl*).
12:11 AM Changeset in webkit [38063] by ap@webkit.org
  • 22 edits in trunk/WebCore

Reviewed by Darin Adler.

​https://bugs.webkit.org/show_bug.cgi?id=21998
Use JSDOMGlobalObject in EventListener-related bindings

  • dom/MessagePort.idl: Auto-generate bindings for onclose and onmessage.
  • bindings/scripts/CodeGeneratorJS.pm: Use JSDOMGlobalObject instead of JSDOMWindow in JS bindings for inline event handlers.
  • bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::addEventListener): (WebCore::JSDOMApplicationCache::removeEventListener):
  • bindings/js/JSEventTargetNodeCustom.cpp: (WebCore::JSEventTargetNode::addEventListener): (WebCore::JSEventTargetNode::removeEventListener):
  • bindings/js/JSMessagePortCustom.cpp: (WebCore::JSMessagePort::removeEventListener):
  • bindings/js/JSSVGElementInstanceCustom.cpp: (WebCore::JSSVGElementInstance::addEventListener): (WebCore::JSSVGElementInstance::removeEventListener):
  • bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::addEventListener): (WebCore::JSXMLHttpRequest::removeEventListener):
  • bindings/js/JSXMLHttpRequestUploadCustom.cpp: (WebCore::JSXMLHttpRequestUpload::addEventListener): (WebCore::JSXMLHttpRequestUpload::removeEventListener): Use ScriptExecutionContext and JSDOMGlobalObject in bindings.
  • dom/EventTarget.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::scriptExecutionContext):
  • dom/EventTargetNode.h:
  • dom/MessagePort.cpp:
  • dom/MessagePort.h: (WebCore::MessagePort::scriptExecutionContext):
  • loader/appcache/DOMApplicationCache.cpp: (WebCore::DOMApplicationCache::scriptExecutionContext):
  • loader/appcache/DOMApplicationCache.h:
  • svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::scriptExecutionContext):
  • svg/SVGElementInstance.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::scriptExecutionContext):
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.cpp: (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
  • xml/XMLHttpRequestUpload.h: Remove associatedFrame() method, and provide scriptExecutionContext() where it wasn't available yet.
Note: See TracTimeline for information about the timeline view.