Timeline



Jul 5, 2009:

10:22 PM Changeset in webkit [45557] by Darin Adler
  • 2 edits in trunk/WebCore

2009-07-05 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Darin Adler.

REGRESSION (r40499): fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Re-added code removed by commit r40499.
Without this, both Qt and Mac were crashing while running the test.

Note that this does not entirely fix the bug. It fixes the WebCore
crash, but the test no longer seems to work due to loader changes.
So this patch does not reenable the test. The test probably has to
be rewritten.

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::removedFromDocument): Re-added code to set the CSS target of the document to 0.
6:46 PM Changeset in webkit [45556] by Simon Fraser
  • 6 edits
    3 adds in trunk

2009-07-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26943

When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).

Test: transitions/extra-transition.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
12:39 PM Changeset in webkit [45555] by Simon Fraser
  • 6 edits
    3 deletes in trunk

2009-07-05 Simon Fraser <Simon Fraser>

Revert the previous commit because it broke the
animations/transition-and-animation-1.html
testcase.

  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent):
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate): (WebCore::CompositeAnimation::cleanupFinishedAnimations):
  • page/animation/CompositeAnimation.h:
12:18 PM Changeset in webkit [45554] by Simon Fraser
  • 6 edits
    4 adds in trunk

2009-07-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26943

When one transition finishes slightly before another the longer
one will fire a second time. This is because the second
ImplicitAnmation object is culled too early, before its final
RenderStyle is in place. This is done by cleanupFinishedAnimations()
so I got rid of that method completely and now cleanup each
transition or animation at the point where I am setting the final
style, or when I detect that the transition or animation has been
terminated early (which happens when you remove it from the style).

Test: transitions/extra-transition.html

  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions): (WebCore::CompositeAnimation::updateKeyframeAnimations): (WebCore::CompositeAnimation::animate):
  • page/animation/CompositeAnimation.h:
  • page/animation/AnimationBase.cpp: (WebCore::AnimationBase::getTimeToNextEvent): Avoid a divide by zero if m_animation->duration() is zero, which can happen if the duration is changed to zero while the animation is running.
8:45 AM Changeset in webkit [45553] by Simon Hausmann
  • 6 edits in trunk

JavaScriptCore:

2009-07-05 Lars Knoll <lars.knoll@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26843

Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.

The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.

Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.

Based on idea by Norbert Leser.

  • runtime/Lookup.h: Define JSC_CONST_HASHTABLE as const for !WINSCW.
  • create_hash_table: Use JSC_CONST_HASHTABLE for hashtables.
  • runtime/JSGlobalData.cpp: Import various global hashtables via the macro.

WebCore:

2009-07-05 Lars Knoll <lars.knoll@nokia.com>

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=26843

Fix run-time crashes in JavaScriptCore with the Metrowerks compiler on Symbian.

The Metrowerks compiler on the Symbian platform moves the globally
defined Hashtables into read-only memory, despite one of the members
being mutable. This causes crashes at run-time due to write access to
read-only memory.

Avoid the use of const with this compiler by introducing the
JSC_CONST_HASHTABLE macro.

Based on idea by Norbert Leser.

  • bindings/scripts/CodeGeneratorJS.pm: Use JSC_CONST_HASHTABLE for hash tables define in the bindings.
7:53 AM Changeset in webkit [45552] by zecke@webkit.org
  • 7 edits in trunk/WebKit/gtk

2009-07-05 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Xan Lopez.

Always initialize WebCore.

It is possible that WebKitWebSettings and other classes get
constructed before the WebKitWebView. In this case WebCore is
not yet properly initialized. Add webkit_init to every class
that can be constructed by API users.

  • webkit/webkitdownload.cpp: (webkit_download_class_init):
  • webkit/webkitnetworkrequest.cpp: (webkit_network_request_class_init):
  • webkit/webkitwebbackforwardlist.cpp: (webkit_web_back_forward_list_class_init):
  • webkit/webkitwebhistoryitem.cpp: (webkit_web_history_item_class_init):
  • webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
  • webkit/webkitwebwindowfeatures.cpp: (webkit_web_window_features_class_init):
7:33 AM Changeset in webkit [45551] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-07-05 Simon Hausmann <Simon Hausmann>

Reviewed by Holger Freyther.

Fix two qdoc warnings.

Added missing \property for QWebFrame::hasFocus and added \a
tag for pos of QWebPage::frameAt.

  • Api/qwebframe.cpp:
  • Api/qwebpage.cpp:
6:06 AM Changeset in webkit [45550] by rwlbuis@webkit.org
  • 3 edits
    4 adds in trunk

Reviewed by Maciej Stachowiak.

Bug 26897 - Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897

Use repaint() to fix a rendering problem with a SVG image embedded in xhtml.

Test: svg/custom/createImageElement2.xhtml

  • rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
3:43 AM Changeset in webkit [45549] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-05 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26960
[Gtk] caret offset not updated when selecting text

Report the caret offset from the end of the selection so it works
correctly for multi-char selections too (ie, anything that is not
the zero width caret).

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_text_get_caret_offset):
12:28 AM Changeset in webkit [45548] by zecke@webkit.org
  • 2 edits in trunk/WebCore

Fix Qt link error by adding two new localized strings

In r45474 two new strings got added to LocalizedStrings.h add
the definition of them to Qt.

12:27 AM Changeset in webkit [45547] by zecke@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-04 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Simon Hausmann.

Use the recently introduced FocusController::setFocused

Use the recently introduced FocusController::setFocused
in the Qt platform. The SelectionController will be updated
from within the FocusController now.

  • Api/qwebpage.cpp: (QWebPagePrivate::focusInEvent): (QWebPagePrivate::focusOutEvent):

Jul 4, 2009:

10:53 AM Changeset in webkit [45546] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore
  • debug build fix
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::getLastParen):
7:21 AM Changeset in webkit [45545] by mjs@apple.com
  • 5 edits in trunk/JavaScriptCore

2009-07-03 Yong Li <yong.li@torchmobile.com>

Reviewed by Maciej Stachowiak (and revised slightly)

RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957

Allow regexp matching to use Vectors with inline capacity instead of
allocating a new ovector buffer every time.


~5% speedup on SunSpider string-unpack-code test, 0.3% on SunSpider overall.

  • runtime/RegExp.cpp: (JSC::RegExp::match):
  • runtime/RegExp.h:
  • runtime/RegExpConstructor.cpp: (JSC::RegExpConstructorPrivate::RegExpConstructorPrivate): (JSC::RegExpConstructorPrivate::lastOvector): (JSC::RegExpConstructorPrivate::tempOvector): (JSC::RegExpConstructorPrivate::changeLastOvector): (JSC::RegExpConstructor::performMatch): (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC::RegExpMatchesArray::fillArrayInstance): (JSC::RegExpConstructor::getBackref): (JSC::RegExpConstructor::getLastParen): (JSC::RegExpConstructor::getLeftContext): (JSC::RegExpConstructor::getRightContext):
  • runtime/StringPrototype.cpp: (JSC::stringProtoFuncSplit):
7:20 AM Changeset in webkit [45544] by mjs@apple.com
  • 2 edits in trunk/WebKitTools

2009-07-03 Maciej Stachowiak <mjs@apple.com>

Reviewed by Eric Seidel.

bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951

  • Scripts/modules/bugzilla.py:

Jul 3, 2009:

9:50 PM Changeset in webkit [45543] by Darin Adler
  • 1 edit in trunk/WebCore/ChangeLog

Added Radar link I left out by accident the first time.

9:48 PM Changeset in webkit [45542] by Darin Adler
  • 2 edits in trunk/WebCore

2009-07-03 Darin Adler <Darin Adler>

Reviewed by Adele Peterson.

REGRESSION (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=26959

The code to handle iteration boundaries was malfunctioning when the boundary was
at the edge of a shadow tree. This happens all the time with <input> elements.

It's not immediately obvious how to make a regression test for this since the
symptom was a performance problem, not incorrect behavior. I'll add a test if I
figure out a way to make one.

  • editing/TextIterator.cpp: (WebCore::parentCrossingShadowBoundaries): Renamed from parentOrShadowParent. (WebCore::depthCrossingShadowBoundaries): Updated for name change. (WebCore::nextInPreOrderCrossingShadowBoundaries): Added. (WebCore::previousInPostOrderCrossingShadowBoundaries): Added. (WebCore::setUpFullyClippedStack): Updated for name change. (WebCore::TextIterator::TextIterator): Updated for name change. Use nextInPreOrderCrossingShadowBoundaries instead of Range::pastLastNode to fix the bug. (WebCore::TextIterator::advance): Updated for name change. (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::advance): Ditto. Changed code that initializes m_pastStartNode to use previousInPostOrderCrossingShadowBoundaries. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Tweaked formatting. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Ditto.
8:56 PM Changeset in webkit [45541] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Simon Fraser.

  • fix <rdar://problem/6964278> REGRESSION (r42118): Scrolling redraw problem in FileMaker Pro
  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]): Perform layout if needed, even on Mac OS X versions that have -viewWillDraw. This prevents attempts to draw without layout in case -viewWillDraw was not called due to NSView issues or the client did something during the display operation that re-invalidated the layout.
8:27 PM Changeset in webkit [45540] by ddkilzer@apple.com
  • 1 edit
    1 add in trunk/BugsSite

Bug 26958: Change edit link to review link in request messages

<https://bugs.webkit.org/show_bug.cgi?id=26958>

Reviewed by Dan Bernstein.

  • template/en/custom/request/email.txt.tmpl: Copied from BugsSite/template/en/default/request/email.txt.tmpl. Changed link from "action=edit" to "action=review".
6:09 PM Changeset in webkit [45539] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Forgot to land ontimer-inline-event.html results within my last WML commit.

5:19 PM Changeset in webkit [45538] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Bug 26950: Make the summary and alias fields support click-to-edit
<https://bugs.webkit.org/show_bug.cgi?id=26950>

Reviewed by Maciej Stachowiak.

Original patch by Maciej Stachowiak.

  • js/field.js: (hideEditableField): Updated to add click event listeners to the alias and short description elements to make them easier to edit. Renamed field_id parameter to field2_id (short description id) and added a field1_id parameter (alias id). (showEditableField): If a third parameter is passed in the ContainerInputArray parameter, use it to find the element to focus. Otherwise, fall back to the original behavior of focusing the first input field. (hideAliasAndSummary): Changed to pass the id for the alias element to hideEditableField().
1:54 PM Changeset in webkit [45537] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-07-03 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Background audio stops playing when JS GC runs
https://bugs.webkit.org/show_bug.cgi?id=26956

Ensure we keep the Audio object around while it is playing, so that it
doesn't get collected.

Not testable because there's no way to know whether the audio keeps
playing without holding a reference to it.

  • bindings/js/JSDOMBinding.cpp: (WebCore::isObservableThroughDOM):
12:34 PM Changeset in webkit [45536] by abarth@webkit.org
  • 2 edits in trunk/WebKitSite

2009-07-03 Adam Barth <abarth@webkit.org>

Reviewed by Sam Weinig.

Adam and Collin's affiliation is incorrect
https://bugs.webkit.org/show_bug.cgi?id=26954

This change corrects their affiliation.

  • security/security-group-members.html:
7:08 AM Changeset in webkit [45535] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26814
[Gtk] Caret-moved events are not issued for the correct offset
when text is selected forward

Report the caret offset from the end of the selection, otherwise
we'll report the same offset when moving the caret while
modififying the selection (eg, with Shift + Right).

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
7:08 AM Changeset in webkit [45534] by xan@webkit.org
  • 2 edits in trunk/WebCore

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Jan Alonzo.

https://bugs.webkit.org/show_bug.cgi?id=26815
[Gtk] text-selection-changed events are not issued for the correct
object when the selection spans multiple objects

Get the focused node from the end of the selection, not the start,
so we can detect when we cross object boundaries.

  • editing/gtk/SelectionControllerGtk.cpp: (WebCore::SelectionController::notifyAccessibilityForSelectionChange):
3:47 AM Changeset in webkit [45533] by dimich@chromium.org
  • 2 edits in trunk/LayoutTests

2009-07-03 Dmitry Titov <dimich@chromium.org>

Reviewed by Darin Fisher.

Increase delay in worker-terminate layout test to make it more reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917

This test used time delay to see of terminated worker does not return
messages (terminated). In some test conditions, the current delay (500ms)
is too short and test fails. Move setting the delay to the end of initialization
and increase it 2x to make test more reliable.

  • fast/workers/worker-terminate.html:
3:24 AM Changeset in webkit [45532] by jmalonzo@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Skip tests that require expected results that Gtk doesn't have.

  • platform/gtk/Skipped:
2:57 AM Changeset in webkit [45531] by jmalonzo@webkit.org
  • 11 edits
    1 add in trunk

2009-07-03 Jan Michael Alonzo <jmalonzo@webkit.org>

Reviewed by Xan Lopez and Gustavo Noronha.

Set user-agent from application
https://bugs.webkit.org/show_bug.cgi?id=17375

Add 'user-agent' setter/getter API to WebSettings.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::FrameLoaderClient): (WebKit::FrameLoaderClient::userAgent):
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • webkit/webkitprivate.h:
  • webkit/webkitversion.h.in:
  • webkit/webkitwebsettings.cpp: (webkit_get_user_agent): (webkit_web_settings_class_init): (webkit_web_settings_finalize): (webkit_web_settings_set_property): (webkit_web_settings_get_property): (webkit_web_settings_copy): (webkit_web_settings_get_user_agent):
  • webkit/webkitwebsettings.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_dispose):

Define UA version macros to be used by the UA string.
Add new WebSettings unit test for the User-Agent string API.

  • GNUmakefile.am:
  • configure.ac:

Jul 2, 2009:

10:21 PM Changeset in webkit [45530] by pdherbemont@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Edit WebCore/ChangeLog last entry to fix a spelling typo.

Pointed out by Mark Rowe.

10:12 PM Changeset in webkit [45529] by pdherbemont@apple.com
  • 3 edits in trunk/WebCore

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26947

Fix the media controls hit tests. They may loose click events.

Test cases already covered in the video-controls-zoomed tests.

Don't trust wkHitTestMediaUIPart for the tests. We are accurate enough.

  • rendering/RenderThemeMac.h: Remove hitTestMediaControlPart.
  • rendering/RenderThemeMac.mm: Remove hitTestMediaControlPart.
8:34 PM Changeset in webkit [45528] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite/data

Ignore data/template cache directory and update data/params.

8:15 PM Changeset in webkit [45527] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Unreviewed build fix (Cairo this time) for DumpRenderTree.
Put Cairo code back in, but use original include order
for the CG stuff to avoid compile issues.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
7:14 PM Changeset in webkit [45526] by ddkilzer@apple.com
  • 1 edit
    1 add in trunk/BugsSite

Config file for contrib/recode.pl when upgrading bugs.webkit.org

Current as of midday on Wednesday, July 1, 2009.

  • contrib/recode-overrides.txt: Added.
7:14 PM Changeset in webkit [45525] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Workaround for WebKit Bug 9630 when running contrib/recode.pl

A number of WebKit nightly builds included Bug 9630 which caused
non-breaking space characters (0xA0) to be submitted within the
content of textarea elements.

  • contrib/recode.pl: To work around these 0xA0 characters, try an encoding of cp1252 and use it if it works.
7:14 PM Changeset in webkit [45524] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Don't print "Failed to guess" warning if an override is available

  • contrib/recode.pl: Check that %overrides does NOT contain a key matching the current digest before printing out the warning about a failed charset guess.
7:14 PM Changeset in webkit [45523] by ddkilzer@apple.com
  • 2 edits in trunk/BugsSite

Added --[no-]truncate switch to contrib/recode.pl

  • contrib/recode.pl: Added --[no-]truncate switch to make debugging of failed charset guessing easier. Often times the illegal character was truncated in the output.
7:14 PM Changeset in webkit [45522] by ddkilzer@apple.com
  • 75 edits in trunk/BugsSite

Changed Perl scripts to use #!/usr/bin/env perl

perl -pi -e 's@#\!/usr/bin/perl@#\!/usr/bin/env perl@' *.cgi *.pl */*.pl

7:14 PM Changeset in webkit [45521] by ddkilzer@apple.com
  • 2 edits
    1 delete in trunk/BugsSite

Replace Bugzilla favicon with webkit.org favicon

  • favicon.ico: Removed.
  • images/favicon.ico: Replaced. Copied from favicon.ico.
7:14 PM Changeset in webkit [45520] by ddkilzer@apple.com
  • 408 edits
    11 copies
    25 moves
    75 adds
    41 deletes in trunk/BugsSite

Merged BugsSite to Bugzilla-3.2.3

Updated to the latest-and-greatest stable version.

7:13 PM Changeset in webkit [45519] by ddkilzer@apple.com
  • 344 edits
    153 adds
    340 deletes in trunk/BugsSite

Merged BugsSite to Bugzilla-3.0.3

Nothing to see here. Move along.

6:38 PM Changeset in webkit [45518] by pdherbemont@apple.com
  • 4 edits in trunk/WebCore

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26944

Make sure we support full page zoom in video controls.

This is tracked by a the video-controls-zoom test case.

  • css/mediaControlsQT.css: Make sure we don't have any inherited margin.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::updateStyle): Propagate the style to the innertext.
  • rendering/RenderThemeMac.mm: Adjust the painting rect. (WebCore::getUnzoomedRectAndAdjustCurrentContext): (WebCore::RenderThemeMac::paintMediaSliderTrack): (WebCore::RenderThemeMac::paintMediaCurrentTime): (WebCore::RenderThemeMac::paintMediaTimeRemaining):
6:29 PM Changeset in webkit [45517] by eric@webkit.org
  • 10 edits in trunk/WebCore

2009-07-02 Roland Steiner <rolandsteiner@google.com>

Reviewed by Eric Seidel.

RenderBlock and RenderInline have confusingly named object creation methods:
RenderBlock::createRootBox/createRootInlineBox
RenderInline::createFlowBox/createInlineFlowBox
where the 2nd method in both cases just calls the first and then appends the created object.
I therefore renamed those methods to something IMHO more informative:

createRootBox() -> createRootInlineBox()
createRootInlineBox() -> createAndAppendRootInlineBox();
createFlowBox() -> createInlineFlowBox();
createInlineFlowBox() -> createAndAppendInlineFlowBox();

https://bugs.webkit.org/show_bug.cgi?id=26828

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::createRootInlineBox): (WebCore::RenderBlock::createAndAppendRootInlineBox):
  • rendering/RenderBlock.h:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::createInlineFlowBox): (WebCore::RenderInline::createAndAppendInlineFlowBox):
  • rendering/RenderInline.h:
  • rendering/RenderSVGInline.cpp: (WebCore::RenderSVGInline::createInlineFlowBox):
  • rendering/RenderSVGInline.h:
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::createRootInlineBox):
  • rendering/RenderSVGText.h:
  • rendering/bidi.cpp: (WebCore::createInlineBoxForRenderer):
6:23 PM Changeset in webkit [45516] by eric@webkit.org
  • 3 edits in trunk/WebCore

2009-07-02 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Fix typo in the resource panel enabler caption.

https://bugs.webkit.org/show_bug.cgi?id=26753

  • English.lproj/localizedStrings.js:
  • inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel):
6:06 PM Changeset in webkit [45515] by eric@webkit.org
  • 4 edits
    1 add in trunk

2009-07-02 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Roben.

[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

  • manual-tests/drag-escape.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::dragSourceEndedAt):

2009-07-02 Erik Arvidsson <arv@chromium.org>

Reviewed by Adam Roben.

[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

  • WebDropSource.cpp: (WebDropSource::QueryContinueDrag):
5:55 PM Changeset in webkit [45514] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-02 Eric Seidel <eric@webkit.org>

Correct blatant typo (missing []), no review.

  • Scripts/modules/scm.py:
5:54 PM Changeset in webkit [45513] by pdherbemont@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Added the test result of r45511 for platform/mac.

  • platform/mac/media/controls-strict-expected.txt: Added.
5:37 PM Changeset in webkit [45512] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Windows build fix, no review.

Reverting PixelDumpSupportWin.cpp change to avoid strange
error on the build-bot.


  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView):
5:18 PM Changeset in webkit [45511] by pdherbemont@apple.com
  • 2 edits in trunk/WebCore

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Fix the Gtk build after r45474. The localized strings should
have been added there.

  • platform/gtk/LocalizedStringsGtk.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
5:07 PM Changeset in webkit [45510] by pdherbemont@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26939

Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

We fix two things:

  • We use px instead of em, because px is used everywhere else and because 0.09em hit the font size limit.
  • We use -webkit-box instead of inline-block because in strict mode inline-block has a different behavior.

Test: media/controls-strict.html

  • css/mediaControlsQT.css:

LayoutTests:

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

https://bugs.webkit.org/show_bug.cgi?id=26939

Media controller is rendered badly at http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html

Test that the controller renders correctly in strict mode as well.

  • media/controls-strict.html: Added.
  • platform/mac/media/controls-strict-mode-expected.txt: Added.
5:03 PM Changeset in webkit [45509] by bfulgham@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-02 Brent Fulgham <bfulgham@webkit.org>

Build fix, no review.

  • DumpRenderTree/config.h:
4:55 PM Changeset in webkit [45508] by oliver@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
<https://bugs.webkit.org/show_bug.cgi?id=26670>

Reviewed by Anders Carlsson

Make windows loader client match mac behaviour more closely.

4:53 PM Changeset in webkit [45507] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-02 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913

We now exit(1) on login failure.

  • Scripts/modules/bugzilla.py:
4:53 PM Changeset in webkit [45506] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Dan Bernstein.

TextIterator should use hasOverflowClip when checking for overflow instead of looking at the style.
https://bugs.webkit.org/show_bug.cgi?id=26942

  • editing/TextIterator.cpp: (WebCore::fullyClipsContents):
4:49 PM Changeset in webkit [45505] by bfulgham@webkit.org
  • 9 edits
    4 adds in trunk

WebKit/win:

2009-06-30 Brent Fulgham <bfulgham@gmail.com>

Reviewed by Adam Roben.

Build DumpRenderTree under Cairo.
https://bugs.webkit.org/show_bug.cgi?id=26457

  • WebKit.vcproj/WebKit.sln: Add Cairo targets to the DumpRenderTree build, and use the in the Debug_Cairo and Release_Cairo targets.

WebKitTools:

2009-06-30 Brent Fulgham <bfulgham@webkit.org>

Reviewed by Adam Roben.

Add build support for a Windows Cairo version of
DumpRenderTree. Share as much logic between the
CG and Cairo builds as possible.
https://bugs.webkit.org/show_bug.cgi?id=26457

  • DumpRenderTree/PixelDumpSupport.cpp: Added. (dumpWebViewAsPixelsAndCompareWithExpected): Moved common logic from CG-specific file. (printPNG): Moved common logic from CG-specific file.
  • DumpRenderTree/PixelDumpSupport.h: Add declaration for new common printPNG function.
  • DumpRenderTree/cairo: Added.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added. Implement cairo-specific logic for dealing with Cairo surfaces. (writeFunction): (printPNG): Cairo-specific PNG handling logic. (computeMD5HashStringForBitmapContext): New Cairo routine using the generic BitmapContext signature. (dumpBitmap): New function containing Cairo-specific portions of the dumping routine.
  • DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added. Provide Cairo version of the BitmapContext structure so that dumping routines can work on an abstract type. (BitmapContext::createByAdoptingBitmapAndContext): (BitmapContext::~BitmapContext): (BitmapContext::cairoContext): (BitmapContext::BitmapContext):
  • DumpRenderTree/cg/PixelDumpSupportCG.cpp: (printPNG): CG-specific PNG handling logic. (computeMD5HashStringForBitmapContext): Revised to use generic BitmapContext signature. (dumpBitmap): New function containing CG-specific portions of the dumping routine.
  • DumpRenderTree/cg/PixelDumpSupportCG.h: Add new signatures.
  • DumpRenderTree/win/DumpRenderTree.cpp: Disable CFNetwork logic when building the non-CFNetwork version. (main):
  • DumpRenderTree/win/DumpRenderTree.vcproj:
  • DumpRenderTree/win/PixelDumpSupportWin.cpp: (createBitmapContextFromWebView): Provide parallel Cairo implementation of CG bitmap/context setup.
4:45 PM Changeset in webkit [45504] by weinig@apple.com
  • 2 edits in trunk/WebCore

2009-07-02 Sam Weinig <sam@webkit.org>

Reviewed by Dave Hyatt.

Fix for <rdar://problem/5230700>
Remove local .xhtml file workaround

  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): Work around is no longer necessary.
4:36 PM Changeset in webkit [45503] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

4:34 PM Changeset in webkit [45502] by andersca@apple.com
  • 8 edits in trunk

WebCore:

2009-07-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Sort, add functions used by WebKit.


  • WebCore.base.exp:

WebKit/mac:

2009-07-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

<rdar://problem/6978783>
Software-rendered plug-in does not update correctly when inside a hardware layer


Replace calls to setNeedsDisplay: and setNeedsDisplayInRect: with a call to the new method
invalidatePluginContentRect:. This new method will ask WebCore to do the repainting, taking
transforms into account.


  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::invalidateRect):
  • Plugins/Hosted/WebHostedNetscapePluginView.mm: (-[WebHostedNetscapePluginView pluginHostDied]):
  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView preferencesHaveChanged:]): (-[WebBaseNetscapePluginView invalidatePluginContentRect:]):
  • Plugins/WebNetscapePluginView.mm: (-[WebNetscapePluginView invalidateRect:]): (-[WebNetscapePluginView invalidateRegion:]): (-[WebNetscapePluginView forceRedraw]):
4:33 PM Changeset in webkit [45501] by mrowe@apple.com
  • 1 copy in tags/Safari-6531.2

New tag.

4:31 PM Changeset in webkit [45500] by hyatt@apple.com
  • 6 edits in trunk/LayoutTests

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Mark Rowe.

Land new results from my change to make replaced elements no longer be overflow:hidden by
default. This affected plaintext dumping, which is clearly a bug in and of itself. For now
I am just updating the results and will file a followup bug about the fact that text dumping actually
does something different with overflow on replaced elements (when it clearly should not).

  • fast/block/float/crash-replaced-display-block-expected.txt:
  • fast/dom/Range/acid3-surround-contents-expected.txt:
  • fast/dom/object-embed-plugin-scripting-expected.txt:
  • fast/parser/badentity-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
4:28 PM Changeset in webkit [45499] by beidson@apple.com
  • 2 edits in trunk/WebCore

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig.

More of <rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

  • platform/network/mac/WebCoreURLResponse.mm: (webNSURLResponseMIMEType): Give Tiger a chance to query the UTI machinery.
4:18 PM Changeset in webkit [45498] by beidson@apple.com
  • 3 edits
    2 adds in trunk/LayoutTests

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by John Sullivan.

Add Tiger-specific results for these tests.

  • platform/mac-tiger/Skipped:
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/mac-tiger/platform/mac/fast/loader/file-url-mimetypes-expected.txt:
4:01 PM Changeset in webkit [45497] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-02 Brady Eidson <beidson@apple.com>

Skip the correct test names.

  • platform/mac-tiger/Skipped:
3:40 PM Changeset in webkit [45496] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-07-02 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium Linux: fix complex text rendering with line break characters.

https://bugs.webkit.org/show_bug.cgi?id=26935

If the CSS white-space property is inhibiting line breaking, we might
find end-of-line characters rendered via the complex text path. Fonts
don't provide glyphs for these code points so, if we find one, we
simulate the space glyph being interposed in this case. Because the
input is variable-length per code point, we walk the input in step
with the output.

Covered by:

LayoutTests/fast/text/international/bidi-linebreak-002.html
LayoutTests/fast/text/international/bidi-linebreak-003.html
LayoutTests/fast/text/international/hindi-whitespace.html

  • platform/graphics/chromium/HarfbuzzSkia.cpp: (WebCore::stringToGlyphs):
3:25 PM Changeset in webkit [45495] by beidson@apple.com
  • 4 edits
    2 copies
    2 adds in trunk/LayoutTests

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig

Split up file-url-mimetypes.html into 3 tests to avoid any risk of timing out on slower machines.

  • platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes-2.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
  • platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Added.
  • platform/mac/fast/loader/file-url-mimetypes-3.html: Copied from platform/mac/fast/loader/file-url-mimetypes.html.
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac-tiger/Skipped:
3:22 PM Changeset in webkit [45494] by Dimitri Glazkov
  • 3 edits in trunk/WebCore

2009-07-02 Victor Wang <victorw@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=26521
Expose file size to chromium.

Implement getFileSize() for Chromium.

  • platform/chromium/ChromiumBridge.h:
  • platform/chromium/FileSystemChromium.cpp: (WebCore::getFileSize):
3:21 PM Changeset in webkit [45493] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-02 Eric Seidel <eric@webkit.org>

No review, just adding Antti as a reviewer.

  • Scripts/modules/bugzilla.py:
3:21 PM Changeset in webkit [45492] by Nate Chapin
  • 2 edits in trunk/WebCore

2009-07-02 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

  • bindings/v8/V8SVGPODTypeWrapper.h: Lost a space in nested template argument list.
3:19 PM Changeset in webkit [45491] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-07-02 Simon Fraser <Simon Fraser>

Build fix: add missing #include.

  • platform/mac/ThemeMac.mm:
3:17 PM Changeset in webkit [45490] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

2009-07-02 Brady Eidson <beidson@apple.com>

Resolve failing Tiger layout test until I can fix it.

  • platform/mac-tiger/Skipped:
2:56 PM Changeset in webkit [45489] by Simon Fraser
  • 2 edits in trunk/WebCore

2009-07-02 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

<rdar://problem/7028682> ThemeMac::paintRadio() throws Obj-C exceptions when zoomed

Add BEGIN_BLOCK_OBJC_EXCEPTIONS/END_BLOCK_OBJC_EXCEPTIONS guards around code
that can possibly throw Objective-C exceptions when drawing Mac form controls.

  • platform/mac/ThemeMac.mm: (WebCore::paintCheckbox): (WebCore::paintRadio): (WebCore::paintButton): (WebCore::ThemeMac::inflateControlPaintRect):
2:47 PM Changeset in webkit [45488] by Nate Chapin
  • 2 edits
    1 add in trunk/WebCore

2009-07-02 Nate Chapin <Nate Chapin>

Reviewed by David Levin.

Upstream V8SVGPODTypeWrapper.

https://bugs.webkit.org/show_bug.cgi?id=26907

2:40 PM Changeset in webkit [45487] by Dimitri Glazkov
  • 10 edits
    2 adds in trunk/WebCore

2009-07-02 Dumitru Daniliuc <dumi@chromium.org>

Reviewed by Dimitri Glazkov.

Adds an abstraction layer between the DB classes and the file
system, which allows us to add our own logic for storing, opening,
deleting, etc. databases.

The patch was tested using the tests in WebCore/storage.

https://bugs.webkit.org/show_bug.cgi?id=26054

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::open): Delegating the job of opening DB files to SQLiteFileSystem to allow use of custom VFSs.
  • platform/sql/SQLiteFileSystem.cpp: Added.
  • platform/sql/SQLiteFileSystem.h: Added.
  • platform/win/FileSystemWin.cpp: (WebCore::directoryName): Implemented.
  • storage/Database.cpp: (WebCore::Database::databaseSize): The code that returns the size of a DB file moved to SQLiteFileSystem.
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker): Added the ability to register a custom SQLite VFS. (WebCore::DatabaseTracker::trackerDatabasePath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::openTrackerDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::originPath): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::fullPathForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::usageForDatabase): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteOrigin): DB file-related operations moved to SQLiteFileSystem. (WebCore::DatabaseTracker::deleteDatabaseFile): DB file-related operations moved to SQLiteFileSystem.
  • storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::diskUsage): DB file-related operations moved to SQLiteFileSystem.
1:47 PM Changeset in webkit [45486] by hyatt@apple.com
  • 4 edits in trunk/WebCore

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Always clip replaced elements to border radii.
https://bugs.webkit.org/show_bug.cgi?id=26933

Make sure to always clip replaced elements to border radii, even when overflow is visible.
Stop defaulting those elements to overflow:hidden in the UA sheet, since it is now no longer
necessary.

Covered by existing tests (since the UA default changing keeps the behavior exactly the same).

  • css/html.css:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::paint):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint):
1:18 PM Changeset in webkit [45485] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2009-07-02 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Simon Fraser.

convertFromScrollbarToContainingView and friends should be in ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

This is breaking Chromium's build because PopupMenuChromium inherits
from ScrollView, but these functions are pure virtual in it. I could
put it directly in PopupMenuChromium, but that seems a bit silly since
the functions are fairly generic.

Passes existing layout tests.

  • page/FrameView.cpp: Remove the 4 functions Hyatt just added (IntRect WebCore::FrameView::convertFromScrollbarToContainingView): (IntRect WebCore::FrameView::convertFromContainingViewToScrollBar): (IntPoint WebCore::FrameView::convertFromScrollbarToContainingView): (IntPoint WebCore::FrameView::convertFromContainingViewToScrollBar):
  • page/FrameView.h: ditto
  • platform/ScrollView.cpp: Move the 4 functions from FrameView here (IntRect WebCore::ScrollView::convertFromScrollbarToContainingView): (IntRect WebCore::ScrollView::convertFromContainingViewToScrollBar): (IntPoint WebCore::ScrollView::convertFromScrollbarToContainingView): (IntPoint WebCore::ScrollView::convertFromContainingViewToScrollBar):
  • platform/ScrollView.h: ditto
11:39 AM Changeset in webkit [45484] by Adam Roben
  • 4 edits in trunk/WebKit

Fix warnings from update-webkit-localizable-strings

WebKit:

Fix warnings from update-webkit-localizable-strings

Rubber-stamped by Eric Carlson.

  • English.lproj/Localizable.strings: Updated.

WebKit/mac:

Fix warnings from update-webkit-localizable-strings

Rubber-stamped by Eric Carlson.

  • WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]): Changed the localization comments to match the comments in the Windows version of this file, to avoid warnings about different comments for the same localized string.
11:39 AM Changeset in webkit [45483] by Adam Roben
  • 2 edits in trunk/WebKit

Update StringsNotToBeLocalized.txt for (not so) recent changes

Bug 26926: StringsNotToBeLocalized.txt is out-of-date
<https://bugs.webkit.org/show_bug.cgi?id=26926>

Reviewed by John Sullivan.

  • StringsNotToBeLocalized.txt:
11:06 AM Changeset in webkit [45482] by darin@chromium.org
  • 5 edits
    4 adds in trunk

2009-07-02 Dirk Pranke <dpranke@chromium.org>

Reviewed by Darin Fisher.

Fix https://bugs.webkit.org/show_bug.cgi?id=26088 - TransparencyWin
doesn't handle errors well at all; revise it to fail silently
(drawing nothing), and bulletproof FontChromiumWin to handle the
failure accordingly.

Tests: fast/text/text-large-negative-letter-spacing-with-opacity.html

fast/text/text-letter-spacing.html

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI): (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter): (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText):
  • platform/graphics/chromium/TransparencyWin.cpp: (WebCore::TransparencyWin::TransparencyWin): (WebCore::TransparencyWin::setupLayerForNoLayer): (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer): (WebCore::TransparencyWin::setupLayerForWhiteLayer): (WebCore::TransparencyWin::setupTransformForKeepTransform): (WebCore::TransparencyWin::setupTransformForScaleTransform): (WebCore::TransparencyWin::initializeNewContext): (WebCore::TransparencyWin::compositeOpaqueComposite): (WebCore::TransparencyWin::compositeTextComposite): (WebCore::TransparencyWin::makeLayerOpaque):
  • platform/graphics/chromium/TransparencyWin.h: (WebCore::TransparencyWin::platformContext):
10:51 AM Changeset in webkit [45481] by hyatt@apple.com
  • 1 edit in trunk/WebCore/platform/ScrollbarClient.h

Fix build bustage caused by wrong include case.

10:41 AM Changeset in webkit [45480] by eric.carlson@apple.com
  • 4 edits in trunk

2009-07-02 Eric Carlson <eric.carlson@apple.com>

Change #import to #include to fix non-ObjC builds.

  • rendering/MediaControlElements.cpp:

2009-07-02 Eric Carlson <eric.carlson@apple.com>

Fix Windows build by including missing localized string methods.

  • WebCoreLocalizedStrings.cpp: (WebCore::mediaElementLoadingStateText): (WebCore::mediaElementLiveBroadcastStateText):
10:32 AM Changeset in webkit [45479] by andersca@apple.com
  • 2 edits in trunk/WebCore

2009-07-02 Anders Carlsson <andersca@apple.com>

Build fix.


  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree):
10:31 AM Changeset in webkit [45478] by hyatt@apple.com
  • 21 edits
    4 adds in trunk

WebCore:

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Fix for bug 22119, clicks in the scrollbars of transformed content don't work. Add new
conversion methods for going across parent/child widget boundaries that can be implemented
by the FrameView and ScrollbarClient to be transform-aware.

Test cases added in platform/mac/fast/forms and platform/mac/fast/overflow.

  • WebCore.base.exp:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
  • page/FrameView.cpp: (WebCore::FrameView::convertFromScrollbarToContainingView): (WebCore::FrameView::convertFromContainingViewToScrollbar): (WebCore::FrameView::convertFromRenderer): (WebCore::FrameView::convertToRenderer): (WebCore::FrameView::convertToContainingView): (WebCore::FrameView::convertFromContainingView):
  • page/FrameView.h:
  • platform/ScrollView.h:
  • platform/Scrollbar.cpp: (WebCore::Scrollbar::convertToContainingView): (WebCore::Scrollbar::convertFromContainingView):
  • platform/Scrollbar.h:
  • platform/ScrollbarClient.h: (WebCore::ScrollbarClient::convertFromScrollbarToContainingView): (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
  • platform/Widget.cpp: (WebCore::Widget::convertFromContainingWindow): (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot): (WebCore::Widget::convertToContainingView): (WebCore::Widget::convertFromContainingView):
  • platform/Widget.h:
  • platform/graphics/IntPoint.h: (WebCore::IntPoint::move):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::convertFromRootToContainingWindow): (WebCore::Widget::convertFromContainingWindowToRoot):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInOverflowControl):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::convertFromScrollbarToContainingView): (WebCore::RenderDataGrid::convertFromContainingViewToScrollbar):
  • rendering/RenderDataGrid.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertFromScrollbarToContainingView): (WebCore::RenderLayer::convertFromContainingViewToScrollbar): (WebCore::RenderLayer::scrollbarOffset): (WebCore::RenderLayer::hitTestOverflowControls):
  • rendering/RenderLayer.h:
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::isPointInOverflowControl): (WebCore::RenderListBox::convertFromScrollbarToContainingView): (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
  • rendering/RenderListBox.h:

LayoutTests:

2009-07-02 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Test cases for bug 22119, clicks in scrollbar of transformed element don't work.

  • platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt: Added.
  • platform/mac/fast/forms/listbox-scrollbar-hit-test.html: Added.
  • platform/mac/fast/overflow/overflow-scrollbar-hit-test-expected.txt: Added.
  • platform/mac/fast/overflow/overflow-scrollbar-hit-test.html: Added.
10:19 AM Changeset in webkit [45477] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt and Simon Fraser.

  • fix <rdar://problem/6933052> SPOD playing video in a div with a box shadow

Test: fast/box-shadow/transform-fringing.html

  • rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintBoxShadow): Clip out the box even if it has an opaque background, but in that case, inset the clip path by 1 pixel, to avoid antialiasing artifacts. Do not inset the clip rect by 1 pixel if the CTM is purely a translation. Move the shadow-casting path away in the non-rounded-rect case (it was already being done in the rounded-rect case), to avoid a black fringe when the CTM is not purely a translation.

LayoutTests:

Reviewed by Dave Hyatt and Simon Fraser.

  • test for part of <rdar://problem/6933052> SPOD playing video in a div with a box shadow
  • fast/box-shadow/transform-fringing.html: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.checksum: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.png: Added.
  • platform/mac/fast/box-shadow/transform-fringing-expected.txt: Added.
10:00 AM Changeset in webkit [45476] by beidson@apple.com
  • 7 edits
    91 adds in trunk

WebCore:

2009-07-02 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

<rdar://problem/6969425> Safari 4.0 doesn't recognize text/plain files if their extension is unknown.

Walk the CoreTypes UTI tree for extensions with unknown MIME types, using the first MIME type found.

For many types of text files (such as source code files) this ends up being text/plain.

  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): Tweak the logging output.
  • platform/network/mac/WebCoreURLResponse.h:
  • platform/network/mac/WebCoreURLResponse.mm: (mimeTypeFromUTITree): (webNSURLResponseMIMEType): Use mimeTypeFromUTITree() to find a UTI-based MIME type for this file's extension. (-[NSURLResponse _webcore_reportedMIMEType]): Return the actual MIME type that CFNetwork gave us.

LayoutTests:

2009-07-02 Brady Eidson <beidson@apple.com>

Rubberstamped by Sam Weinig.

Add more sample files for extensions we should know the MIME types for.

  • platform/mac/fast/loader/file-url-mimetypes.html:
  • platform/mac/fast/loader/file-url-mimetypes-expected.txt:
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-3fr.3fr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aaf.aaf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ada.ada: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-adb.adb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ads.ads: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-app.app: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-applescript.applescript: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-arw.arw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-as.as: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-aupreset.aupreset: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-c++.c++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-c.c: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-caf.caf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cc.cc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cp.cp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cpp.cpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cr2.cr2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-cxx.cxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-defs.defs: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dfont.dfont: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dlyan.dlyan: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dng.dng: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-dylib.dylib: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exp.exp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-exr.exr: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f.f: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f77.f77: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f90.f90: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-f95.f95: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-fff.fff: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-for.for: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-h++.h++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-h.h: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hh.hh: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hp.hp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hpp.hpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-hxx.hxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icc.icc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icm.icm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-icns.icns: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jav.jav: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-java.java: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-jfx.jfx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-l.l: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lid.lid: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lm.lm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lmm.lmm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lpp.lpp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-lxx.lxx: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m.m: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4a.m4a: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4b.m4b: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-m4v.m4v: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mig.mig: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mm.mm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mos.mos: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-mrw.mrw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-nef.nef: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-o.o: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-omf.omf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-orf.orf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pas.pas: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pch++.pch++: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pch.pch: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pef.pef: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pf.pf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pfa.pfa: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-pfb.pfb: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-plist.plist: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-r.r: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-raf.raf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-raw.raw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-s.s: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-scpt.scpt: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sd2.sd2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-sf2.sf2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-srf.srf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-suit.suit: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz.tbz: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-tbz2.tbz2: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ttc.ttc: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ttf.ttf: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ul.ul: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ulaw.ulaw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ulw.ulw: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-war.war: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-y.y: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ym.ym: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ymm.ymm: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-ypp.ypp: Added.
  • platform/mac/fast/loader/resources/mimeTypeExamples/example-yxx.yxx: Added.
9:33 AM Changeset in webkit [45475] by Simon Fraser
  • 4 edits in trunk/WebKit/mac

2009-07-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Compositing-related preference methods are not public API; should move to WebPreferencesPrivate.h
<rdar://problem/7027363>

Move accelerated-compositing pref to WebPreferencesPrivate.h

  • WebView/WebPreferences.h:
  • WebView/WebPreferences.mm: (-[WebPreferences acceleratedCompositingEnabled]): (-[WebPreferences setAcceleratedCompositingEnabled:]):
  • WebView/WebPreferencesPrivate.h:
8:47 AM Changeset in webkit [45474] by eric.carlson@apple.com
  • 36 edits in trunk

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add a rewind button and hide the timeline for live broadcasts when
in MediaUI mode.

  • css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Add the new pseudo element.
  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Ditto.
  • css/CSSSelector.h:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Ditto.
  • css/CSSValueKeywords.in: Ditto.
  • css/mediaControls.css: Ditto.
  • css/mediaControlsQT.css: Ditto.
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::rewind): New. (WebCore::HTMLMediaElement::returnToRealTime): New. (WebCore::HTMLMediaElement::isStreaming): New.
  • html/HTMLMediaElement.h:
  • page/mac/WebCoreViewFactory.h: Declare mediaElementLoadingStateText and mediaElementLiveBroadcastStateText.
  • platform/LocalizedStrings.h: Add localized media state messages.
  • platform/ThemeTypes.h: Add the new pseudo element.
  • platform/mac/LocalizedStringsMac.mm: (WebCore::mediaElementLoadingStateText): Add localized media state. (WebCore::mediaElementLiveBroadcastStateText): Ditto.
  • platform/mac/WebCoreSystemInterface.h: Change BOOL param wkDrawMediaUIPart to an int to support

multiple states.

  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • rendering/MediaControlElements.cpp: (WebCore::MediaControlElement::MediaControlElement): Deal with new elements. (WebCore::MediaControlElement::attachToParent): Ditto. (WebCore::MediaControlElement::update): Ditto. (WebCore::MediaControlElement::updateStyle): Ditto. (WebCore::MediaControlTimelineContainerElement::MediaControlTimelineContainerElement): Ditto. (WebCore::MediaControlTimelineContainerElement::rendererIsNeeded): Ditto. (WebCore::MediaControlStatusDisplayElement::MediaControlStatusDisplayElement): Ditto. (WebCore::MediaControlStatusDisplayElement::update): Ditto. (WebCore::MediaControlStatusDisplayElement::rendererIsNeeded): Ditto. (WebCore::MediaControlInputElement::MediaControlInputElement): Ditto. (WebCore::MediaControlInputElement::attachToParent): Ditto. (WebCore::MediaControlInputElement::updateStyle): Ditto. (WebCore::MediaControlRewindButtonElement::MediaControlRewindButtonElement): Ditto. (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::MediaControlReturnToRealtimeButtonElement): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto. (WebCore::MediaControlReturnToRealtimeButtonElement::rendererIsNeeded): Ditto. (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto. (WebCore::MediaControlTimelineElement::update): Ditto. (WebCore::MediaControlFullscreenButtonElement::rendererIsNeeded): Ditto.
  • rendering/MediaControlElements.h: Ditto.
  • rendering/RenderMedia.cpp: (WebCore::RenderMedia::styleDidChange): Deal with the new elements. (WebCore::RenderMedia::createPanel): Ditto. (WebCore::RenderMedia::createRewindButton): Ditto. (WebCore::RenderMedia::createReturnToRealtimeButton): Ditto. (WebCore::RenderMedia::createStatusDisplay): Ditto. (WebCore::RenderMedia::createTimelineContainer): Ditto. (WebCore::RenderMedia::createCurrentTimeDisplay): Ditto. (WebCore::RenderMedia::createTimeRemainingDisplay): Ditto. (WebCore::RenderMedia::updateControls): Ditto. (WebCore::RenderMedia::forwardEvent): Ditto.
  • rendering/RenderMedia.h:
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Deal with the new elements.
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderTheme::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderTheme::paintMediaControlsBackground): Ditto.
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMediaRewindButton): Deal with the new elements. (WebCore::RenderThemeMac::paintMediaReturnToRealtimeButton): Ditto. (WebCore::RenderThemeMac::paintMediaControlsBackground): Ditto.
  • rendering/style/RenderStyleConstants.h: Add constants for the new elements.

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add localized strings for media controller status messages.

  • English.lproj/Localizable.strings: Localized text.

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

<rdar://problem/6518119>

Add localized strings for media controller status.

  • WebCoreSupport/WebViewFactory.mm: Add new localized text. (-[WebViewFactory mediaElementLoadingStateText]): (-[WebViewFactory mediaElementLiveBroadcastStateText]):

2009-07-02 Pierre d'Herbemont <pdherbemont@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/6518119>

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
7:15 AM Changeset in webkit [45473] by Simon Hausmann
  • 5 edits in trunk

WebKitTools:

2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26896

[Qt] Set DRT's default fontsize to 13.

  • DumpRenderTree/qt/DumpRenderTree.cpp: (WebCore::WebPage::WebPage):

LayoutTests:

2009-07-02 Antonio Gomes <antonio.gomes@openbossa.org>

Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=26896

Updated computed-style-expected.txt and computed-style-without-renderer-expected.txt
files according to the default font size value (13) set in DumpRenderTree/qt/DumpRenderTree.cpp .

  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
7:00 AM Changeset in webkit [45472] by Simon Hausmann
  • 3 edits in trunk/WebKit/qt

2009-07-02 Simon Hausmann <simon.hausmann@nokia.com>

Reviewed by Ariya Hidayat.

Improve documentation of QWebFrame::setFocus and hasFocus()
Added missing Q_PROPERTY for QWebFrame::hasFocus.

  • Api/qwebframe.cpp: Clarify the docs.
  • Api/qwebframe.h: add Q_PROPERTY(focus).
6:47 AM Changeset in webkit [45471] by Simon Hausmann
  • 4 edits in trunk/WebKit/qt

2009-07-02 Joe Ligman <joseph.ligman@nokia.com>

Reviewed by Simon Hausmann.

Bug 26855: [Qt] New methods for QWebFrame to check and set focus.

Added new public methods QWebFrame::hasFocus() and QWebFrame::setFocus()
Added auto test.

  • Api/qwebframe.cpp: (QWebFrame::hasFocus): (QWebFrame::setFocus):
  • Api/qwebframe.h:
  • tests/qwebframe/tst_qwebframe.cpp:
4:50 AM Changeset in webkit [45470] by xan@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-07-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Holger Freyther.

Update the new boolean property in FocusController that keeps
track of whether or not the Page is focused.

  • webkit/webkitwebview.cpp: (webkit_web_view_focus_in_event): (webkit_web_view_focus_out_event):

Jul 1, 2009:

11:54 PM Changeset in webkit [45469] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

bugzilla-tool fails for SVN users
https://bugs.webkit.org/show_bug.cgi?id=26914

To fix this I moved svn from -F - to using -m
In order for -m to work I had to move us off of shell=True
To move off of shell=True all call sites for run_command
which take args, need to pass their args as an list instead of a string.

In order for the final bug update to work correctly, I had to
abstract the way that we parse out revision numbers from the commit text.

  • Scripts/bugzilla-tool:
  • Scripts/modules/scm.py:
11:30 PM Changeset in webkit [45468] by Simon Fraser
  • 3 edits
    4 adds in trunk

2009-07-01 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<video> fails to show on http://camendesign.com/code/video_for_everybody
<rdar://problem/7026010>
https://bugs.webkit.org/show_bug.cgi?id=26919

Fix an issue introduced in r44961. In that revision we changed to only update
compositing layer geometry when all siblings had been laid out (i.e. we pushed
the updates one level down). However, that left out the root layer, so this
fix ensures that the root layer geometry gets updated at the end.

Test: compositing/geometry/root-layer-update.html

  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateAfterLayout):
11:26 PM Changeset in webkit [45467] by darin@chromium.org
  • 5 edits in trunk/WebCore

2009-07-01 John Abd-El-Malek <jam@chromium.org>

Reviewed by Darin Fisher.

Small refactoring of MessagePortChannel so that PlatformMessagePortChannel
may be defined at the WebKit layer.

https://bugs.webkit.org/show_bug.cgi?id=26905

  • dom/MessageChannel.cpp: (WebCore::MessageChannel::MessageChannel):
  • dom/MessagePortChannel.cpp:
  • dom/MessagePortChannel.h:
  • dom/default/PlatformMessagePortChannel.cpp: (WebCore::MessagePortChannel::createChannel): (WebCore::MessagePortChannel::create): (WebCore::MessagePortChannel::MessagePortChannel): (WebCore::MessagePortChannel::~MessagePortChannel):
11:04 PM Changeset in webkit [45466] by xan@webkit.org
  • 2 edits in trunk/LayoutTests

2009-07-01 Xan Lopez <xlopez@igalia.com>

Disable accessibility tests until we have the accessibility
controller.

  • platform/gtk/Skipped:
10:13 PM Changeset in webkit [45465] by Simon Fraser
  • 3 edits
    6 adds in trunk

2009-07-01 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein

<rdar://problem/7026010> <video> fails to show on http://camendesign.com/code/video_for_everybody

First part of fix: when outline width changes, don't to a synchronous
layer update right away, but just set the flag to say that compositing
layers need updating. The synchronous layer update left the layer geometries
out of whack when it happened in the middle of layout (e.g. when inside ::first-letter).

Test: compositing/geometry/outline-change.html

  • rendering/RenderView.cpp: (WebCore::RenderView::setMaximalOutlineSize):
10:13 PM Changeset in webkit [45464] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Maciej Stachowiak.

prepare-ChangeLog should have a --bug= argument and use it for url autofill
https://bugs.webkit.org/show_bug.cgi?id=26383

prepare-ChangeLog now knows how to grab the bug title from bugs.webkit.org
I also added a bit more template text in an effort to get better ChangeLogs
from casual contributers.

  • Scripts/prepare-ChangeLog:
7:08 PM Changeset in webkit [45463] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-07-01 Robert Hogan <robert@roberthogan.net>

Reviewed by NOBODY.


Fix Qt segfault when javascript disabled.
If clients call addToJavaScriptWindowObject even though JavascriptEnabled is false
webkit will segfault on the assert:

ASSERTION FAILED: _rootObject
(../../../WebCore/bridge/runtime.cpp:52
JSC::Bindings::Instance::Instance(WTF::PassRefPtr<JSC::Bindings::RootObject>))

Fix is to ensure JavaScript is enabled when client calls addToJavaScriptWindowObject.

https://bugs.webkit.org/show_bug.cgi?id=26906

  • Api/qwebframe.cpp: (QWebFrame::addToJavaScriptWindowObject):
7:01 PM Changeset in webkit [45462] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-07-01 Kwang Yul Seo <skyul@company100.net>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=26842
Build fix when ENABLE_DATABASE is off

Move Database.h into ENABLE(DATABASE) guard so toggling ENABLE_DATABASE
off does not break builds.

  • bindings/js/ScriptObjectQuarantine.cpp:
6:35 PM Changeset in webkit [45461] by abarth@webkit.org
  • 6 edits
    4 adds in trunk

WebCore:

2009-07-01 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26899


Modified XSSAuditor::decodeURL to only remove null characters so that
it is consistent with the behavior of HTMLTokenizer and prevents
injected scripts that contain control characters.

Tests: http/tests/security/xssAuditor/script-tag-control-char.html

http/tests/security/xssAuditor/script-tag-null-char.html

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::decodeURL): Modified to only remove null characters.
  • page/XSSAuditor.h: Reverted naming of third argument of method XSSAuditor::decodeURL from allowControlCharacters back to allowNullCharacters.
  • platform/network/ResourceResponseBase.cpp: Reverted back to rev #45003. (WebCore::isControlCharacter):
  • platform/network/ResourceResponseBase.h: Reverted back to rev #45003.

LayoutTests:

2009-07-01 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.


https://bugs.webkit.org/show_bug.cgi?id=26899


Tests that XSSAuditor prevents injected scripts that contain control characters.

  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-control-char.html: Added.
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt: Added.
  • http/tests/security/xssAuditor/script-tag-null-char.html: Added.
6:03 PM Changeset in webkit [45460] by eric@webkit.org
  • 5 edits
    1 add in trunk/WebCore

2009-07-01 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Timothy Hatcher.

  • supported keyboard shortcuts compatible with Firebug in Scripts Debugger: F5, Ctrl+/ (win,lin), Command+/ (mac) - continue F10, Ctrl+' (win, lin), Command+' (mac) - step over F11, Ctrl+; (win, lin), Command+; (mac) - step into Shift+F11, Ctrl+Shift+; (win, lin), Command+Shift+; (mac) - step out
  • added call stack navigation shortcuts: Ctrl+. - next call frame Ctrl+, - previouse call frame

https://bugs.webkit.org/show_bug.cgi?id=23849

  • inspector/front-end/CallStackSidebarPane.js: (WebInspector.CallStackSidebarPane): (WebInspector.CallStackSidebarPane.prototype.handleKeyEvent): (WebInspector.CallStackSidebarPane.prototype._selectNextCallFrameOnStack): (WebInspector.CallStackSidebarPane.prototype._selectPreviousCallFrameOnStack): (WebInspector.CallStackSidebarPane.prototype._selectedPlacardByIndex): (WebInspector.CallStackSidebarPane.prototype._selectedCallFrameIndex):
  • inspector/front-end/KeyboardShortcut.js: Added. (WebInspector.KeyboardShortcut): (WebInspector.KeyboardShortcut.makeKey): (WebInspector.KeyboardShortcut.makeKeyFromEvent): (WebInspector.KeyboardShortcut.makeKeyFromCodeAndModifiers_):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.handleKeyEvent):
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
5:54 PM Changeset in webkit [45459] by agl@chromium.org
  • 7 edits in trunk/WebCore

2009-07-01 Daniel Erat <derat@google.com>

Reviewed by David Levin.

Chromium Linux: Move the scrollbar thumb on middle-click.

https://bugs.webkit.org/show_bug.cgi?id=26910
http://code.google.com/p/chromium/issues/detail?id=11976

Tested by building Chrome and checking that the scrollbar moves as expected.

  • platform/chromium/ScrollbarThemeChromium.cpp:
  • platform/chromium/ScrollbarThemeChromium.h:
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp:
  • platform/chromium/ScrollbarThemeChromiumLinux.h:
  • platform/chromium/ScrollbarThemeChromiumWin.cpp:
  • platform/chromium/ScrollbarThemeChromiumWin.h:
5:38 PM Changeset in webkit [45458] by beidson@apple.com
  • 10 edits in trunk

WebCore:

2009-07-01 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::setLocalFileContentSniffingEnabled):
  • page/Settings.h: (WebCore::Settings::localFileContentSniffingEnabled):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::start): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

WebKit/mac:

2009-07-01 Brady Eidson <beidson@apple.com>

Reviewed by Sam Weinig.

Add a preference/setting to toggle whether content sniffing is enabled for file URLs.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm: (+[WebPreferences initialize]): (-[WebPreferences localFileContentSniffingEnabled]): (-[WebPreferences setLocalFileContentSniffingEnabled:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _preferencesChangedNotification:]):
5:13 PM Changeset in webkit [45457] by weinig@apple.com
  • 3 edits in branches/nitro-extreme/JavaScriptCore

2009-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Gavin Barraclough.

Don't reload values in emitBinaryDoubleOp.

SunSpider reports a 0.6% progression.

  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jnless): (JSC::JIT::emit_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
4:34 PM Changeset in webkit [45456] by Chris Fleizach
  • 4 edits
    2 adds in trunk

Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909

4:31 PM Changeset in webkit [45455] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-07-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

prepare-ChangeLog should fail when EMAIL_ADDRESS or REAL_NAME are missing:
https://bugs.webkit.org/show_bug.cgi?id=26692

I also made prepare-ChangeLog sanity-check names and email addresses a little.
Names must contain a space, and email addresses must contain '@'

Also "fixed" $email_address to $emailAddress. This script uses mixed variable name styles.

  • Scripts/prepare-ChangeLog:
4:15 PM Changeset in webkit [45454] by hyatt@apple.com
  • 6 edits in trunk/WebCore

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Oliver Hunt.

More datagrid columns work. Make sure columns cache both a style for the column header as well
as a style for the column background (behind the cells).

Hook up to CSSStyleSelector methods for obtaining the pseudo styles for columns (stubbed out and
unimplemented).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumn): (WebCore::CSSStyleSelector::pseudoStyleForDataGridColumnHeader):
  • css/CSSStyleSelector.h:
  • html/DataGridColumn.h: (WebCore::DataGridColumn::setColumnList): (WebCore::DataGridColumn::columnStyle): (WebCore::DataGridColumn::setColumnStyle): (WebCore::DataGridColumn::headerStyle): (WebCore::DataGridColumn::setHeaderStyle):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::recalcStyleForColumn): (WebCore::RenderDataGrid::columnStyle): (WebCore::RenderDataGrid::headerStyle): (WebCore::RenderDataGrid::paintColumnHeaders):
  • rendering/RenderDataGrid.h:
4:12 PM JSC edited by bfulgham@webkit.org
(diff)
4:06 PM JSC edited by bfulgham@webkit.org
Add information about built-in functions. (diff)
3:33 PM Changeset in webkit [45453] by eric.carlson@apple.com
  • 3 edits in trunk/WebCore

2009-07-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Oliver Hunt.


<rdar://problem/7009870> After <audio> movie finishes playing, Pause button fails to change
back to Play button

Grab onto the current time when QTKit "ended" notification fires and use it as
duration from that point on as QuickTime sometimes refuses to play all the way to
the time it reports for duration and buffered. HTMLMediaElement assumes that there
more to play in this situation and tries to restart playback, endlessly.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:

Rename m_duration to m_reportedDuration. Declare m_cachedDuration.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):

Rename m_duration to m_reportedDuration. Initialize m_cachedDuration.

(WebCore::MediaPlayerPrivate::duration):

Return m_cachedDuration once it has been set.

(WebCore::MediaPlayerPrivate::updateStates):

Rename m_duration to m_reportedDuration.

(WebCore::MediaPlayerPrivate::didEnd):

Set m_cachedDuration to currentTime().

3:29 PM JSC edited by bfulgham@webkit.org
(diff)
3:01 PM Changeset in webkit [45452] by Chris Fleizach
  • 11 edits
    2 adds in trunk

Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900

2:41 PM Changeset in webkit [45451] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Change how WebKitNightlyEnabler.dylib lies about Safari's identity to LaunchServices.

This makes WebKit.app behave as expected when set as the default web browser on a wider
range of OS versions.

Reviewed by Simon Fraser.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(poseAsWebKitApp):
(enableWebKitNightlyBehaviour):

2:41 PM Changeset in webkit [45450] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

Shuffle some code around in preparation for a change to how poseAsWebKitApp works.

Reviewed by Simon Fraser.

  • WebKitLauncher/WebKitNightlyEnabler.m:

(systemVersion):
(webKitLauncherBundle):
(insideSafari4OnTigerTrampoline):

2:19 PM Changeset in webkit [45449] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Convert op_div to load op1 and op2 up front.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_div):
2:06 PM Changeset in webkit [45448] by levin@chromium.org
  • 4 edits in trunk/WebCore

2009-07-01 David Levin <levin@chromium.org>

Reviewed by Eric Seidel.

Remove unused code in SVGTransformList and SVGTransformDistance
<https://bugs.webkit.org/show_bug.cgi?id=26891>

  • svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance):
  • svg/SVGTransformList.cpp:
  • svg/SVGTransformList.h:
2:02 PM Changeset in webkit [45447] by weinig@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-07-01 Sam Weinig <sam@webkit.org>

Reviewed by Geoffrey Garen.

Don't emit code in emitBinaryDoubleOp if code is unreachable, observable
via an empty (unlinked) jumplist passed in. This only effects op_jnless
and op_jnlesseq at present.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_jnless): (JSC::JIT::emitSlow_op_jnlesseq): (JSC::JIT::emitBinaryDoubleOp):
1:59 PM Changeset in webkit [45446] by hyatt@apple.com
  • 10 edits in trunk/WebCore

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Anders Carlsson.

Begin stubbing out functions for layout, painting and style/geometry caching on columns. Not enough
is implemented for this to do much of anything yet, but it should help keep patch sizes down. :)

  • html/DataGridColumn.cpp: (WebCore::DataGridColumn::columnChanged):
  • html/DataGridColumn.h: (WebCore::DataGridColumn::setId): (WebCore::DataGridColumn::setLabel): (WebCore::DataGridColumn::setType): (WebCore::DataGridColumn::setSortable): (WebCore::DataGridColumn::setSortDirection): (WebCore::DataGridColumn::setColumnList): (WebCore::DataGridColumn::style): (WebCore::DataGridColumn::setStyle): (WebCore::DataGridColumn::rect): (WebCore::DataGridColumn::setRect):
  • html/DataGridColumnList.cpp: (WebCore::DataGridColumnList::DataGridColumnList): (WebCore::DataGridColumnList::setDataGridNeedsLayout): (WebCore::DataGridColumnList::add): (WebCore::DataGridColumnList::remove): (WebCore::DataGridColumnList::move): (WebCore::DataGridColumnList::clear): (WebCore::DataGridColumnList::primaryColumnChanged):
  • html/DataGridColumnList.h: (WebCore::DataGridColumnList::create): (WebCore::DataGridColumnList::dataGrid): (WebCore::DataGridColumnList::clearDataGrid):
  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::HTMLDataGridColElement): (WebCore::HTMLDataGridColElement::findDataGridAncestor): (WebCore::HTMLDataGridColElement::insertedIntoTree): (WebCore::HTMLDataGridColElement::removedFromTree):
  • html/HTMLDataGridColElement.h: (WebCore::HTMLDataGridColElement::dataGrid):
  • html/HTMLDataGridElement.cpp: (WebCore::HTMLDataGridElement::HTMLDataGridElement): (WebCore::HTMLDataGridElement::~HTMLDataGridElement):
  • rendering/RenderDataGrid.cpp: (WebCore::RenderDataGrid::styleDidChange): (WebCore::RenderDataGrid::recalcStyleForColumns): (WebCore::RenderDataGrid::recalcStyleForColumn): (WebCore::RenderDataGrid::styleForColumn): (WebCore::RenderDataGrid::layout): (WebCore::RenderDataGrid::layoutColumns): (WebCore::RenderDataGrid::paintColumnHeaders): (WebCore::RenderDataGrid::paintColumnHeader):
  • rendering/RenderDataGrid.h: (WebCore::RenderDataGrid::renderName): (WebCore::RenderDataGrid::canHaveChildren):
1:41 PM JSC created by bfulgham@webkit.org
Initial entry to document the utility.
1:38 PM Changeset in webkit [45445] by abarth@webkit.org
  • 2 edits in trunk/WebCore

2009-07-01 Daniel Bates <dbates@intudata.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=26807


Fixes this address by checking whether frame->document()->decoder() is null.

  • page/XSSAuditor.cpp: (WebCore::XSSAuditor::findInRequest):
12:01 PM Changeset in webkit [45444] by Nikolas Zimmermann
  • 4 edits
    12 adds in trunk

2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885

Correctly reset history length to '0', not '1'. Old relict from early WML days.
Add some new WML testcases covering the use of history length (by onenterforward event handling)

Tests: wml/onenterforward-event.html

wml/onenterforward-inline-event.html
wml/ontimer-event.html


  • wml/WMLPageState.cpp: (WebCore::WMLPageState::reset):

2009-07-01 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26885

Add new WML testcases covering onenterforward/ontimer support.

  • wml/onenterforward-event-expected.txt: Added.
  • wml/onenterforward-event.html: Added.
  • wml/onenterforward-inline-event-expected.txt: Added.
  • wml/onenterforward-inline-event.html: Added.
  • wml/ontimer-event-expected.txt: Added.
  • wml/ontimer-event.html: Added.
  • wml/resources/onenterforward-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/onenterforward-event.wml: Added.
  • wml/resources/onenterforward-inline-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/onenterforward-inline-event.wml: Added.
  • wml/resources/ontimer-event.js: Added. (setupTestDocument): (prepareTest): (executeTest):
  • wml/resources/ontimer-event.wml: Added.
  • wml/resources/ontimer-inline-event.js:
11:41 AM Changeset in webkit [45443] by hyatt@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Make sure setting attributes on dcol elements properly updates the corresponding DataGridColumn object.

Added new test in fast/dom/HTMLDataGridElement.

  • html/HTMLDataGridColElement.cpp: (WebCore::HTMLDataGridColElement::parseMappedAttribute):
  • html/HTMLDataGridColElement.h:

LayoutTests:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Simon Fraser.

Add layout test for being able to set attributes on dcol elements.


  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Added.
  • fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html: Added.
11:19 AM Changeset in webkit [45442] by Simon Fraser
  • 1 edit
    4 adds in trunk/LayoutTests

2009-07-01 Simon Fraser <Simon Fraser>

Reviewed by Dimitri Glazkov.

Add some missing pixel results for compositing tests.

  • platform/mac/compositing/layers-inside-overflow-scroll-expected.checksum: Added.
  • platform/mac/compositing/layers-inside-overflow-scroll-expected.png: Added.
  • platform/mac/compositing/overflow/overflow-scroll-expected.checksum: Added.
  • platform/mac/compositing/overflow/overflow-scroll-expected.png: Added.
11:12 AM Changeset in webkit [45441] by ggaren@apple.com
  • 2 edits in branches/nitro-extreme/JavaScriptCore

2009-07-01 Geoffrey Garen <ggaren@apple.com>

Reviewed by Sam Weinig.

Converted op_mod to put { tag, payload } in { regT1, regT0 }, and
tidied up its constant case.


SunSpider reports a 0.2% regression, but a micro-benchmark of op_mod
shows a 12% speedup, and the SunSpider test that uses op_mod most should
benefit a lot from result caching in the end, since it almost always
performs (expression) % constant.

  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_mod): (JSC::JIT::emitSlow_op_mod):
11:11 AM Drosera edited by bfulgham@webkit.org
Add link to Web Inspector page. (diff)
9:53 AM Changeset in webkit [45440] by hyatt@apple.com
  • 9 edits in trunk

WebCore:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input


Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically even when the Page itself doesn't
actually happen to have focus at that time.

  • WebCore.base.exp:
  • page/FocusController.cpp: (WebCore::FocusController::FocusController): (WebCore::FocusController::setFocusedFrame): (WebCore::FocusController::setFocused): (WebCore::FocusController::setActive):
  • page/FocusController.h: (WebCore::FocusController::isFocused):

WebKit/mac:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input


Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.

  • WebView/WebHTMLView.mm: (-[WebHTMLView becomeFirstResponder]): (-[WebHTMLView resignFirstResponder]):

WebKit/win:

2009-07-01 David Hyatt <hyatt@apple.com>

Reviewed by Tim Hatcher.

<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input


Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.

  • WebView.cpp: (WebViewWndProc):
9:47 AM Changeset in webkit [45439] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Reviewed by George Staikos.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26884

WMLTestCase.js relies on timing-dependant hacks, making it difficult to predict results on slower machines.
Fix by rewriting and simplifying the testing procedure, which contained unnecessary quirks working around older WML bugs.

9:06 AM Changeset in webkit [45438] by eric.carlson@apple.com
  • 4 edits in trunk/WebKitLibraries

2009-07-01 Eric Carlson <eric.carlson@apple.com>

Reviewed by Simon Fraser.

Update WebKitSystemInterface for <rdar://problem/7014990>

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceSnowLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
8:44 AM Changeset in webkit [45437] by Nikolas Zimmermann
  • 1 edit in trunk/WebKitTools/Scripts/modules

Not reviewed. Ignore *.pyc files to not clutter up 'svn st'.

8:10 AM Changeset in webkit [45436] by Nikolas Zimmermann
  • 6 edits in trunk/LayoutTests

Reviewed by Holger Freyther.
Apply same cleanup to WML testcases living in http/tests/wml/. Forgot about them in my last commit.

8:03 AM Changeset in webkit [45435] by Nikolas Zimmermann
  • 7 edits in trunk/LayoutTests

Reviewed by Holger Freyther.

Slightly cleanup some WML testcases:
Use "anchorElement.textContent = '...'" instead of "anchorElement.appendChild(document.createTextNode('...'))"

5:55 AM Changeset in webkit [45434] by Simon Hausmann
  • 4 edits in trunk

WebCore:

2009-07-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Move some API headers from WebCore.pro to headers.pri so that they
get installed when running make install from the build directory.

  • WebCore.pro:

WebKit/qt:

2009-07-01 Jakub Wieczorek <faw217@gmail.com>

Reviewed by Simon Hausmann.

[Qt] Move some API headers from WebCore.pro to headers.pri so that they
get installed when running make install from the build directory.

  • Api/headers.pri:
4:36 AM Changeset in webkit [45433] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2009-07-01 Balazs Kelemen <kelemen.balazs.3@stud.u-szeged.hu>

Reviewed by Simon Hausmann.

Fixed robotized QtLauncher to work when there is no index.html in the user's home.

  • QtLauncher/main.cpp: (main):
2:40 AM Changeset in webkit [45432] by Simon Hausmann
  • 2 edits in trunk/WebCore

2009-07-01 Simon Hausmann <simon.hausmann@nokia.com>

Rubber-stamped by Ariya Hidayat.

Ran WebKitTools/Scripts/generate-qt-inspector-resource to update the
qrc file with new png files from the web inspector.

  • inspector/front-end/WebKit.qrc:
Note: See TracTimeline for information about the timeline view.