Timeline



Dec 8, 2009:

11:51 PM Changeset in webkit [51888] by eric@webkit.org
  • 11 edits in trunk/WebKitTools

2009-12-08 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

run_command and ScriptError should move into processutils.py
https://bugs.webkit.org/show_bug.cgi?id=32305

Turns out there are a zillion callers to run_command.

  • Scripts/modules/commands/download.py:
  • Scripts/modules/commands/early_warning_system.py:
  • Scripts/modules/commands/queues.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/logging_unittest.py:
  • Scripts/modules/processutils.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/scm_unittest.py:
  • Scripts/modules/workqueue.py:
  • Scripts/modules/workqueue_unittest.py:
7:43 PM Changeset in webkit [51887] by mjs@apple.com
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray conflict marker.

7:39 PM Changeset in webkit [51886] by ukai@chromium.org
  • 7 edits
    3 adds in trunk

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

WebSocket allow space (U+0020) in sub protocol name.
https://bugs.webkit.org/show_bug.cgi?id=32266

Skipped sub-protocol-with-space.html for now until new pywebsocket is
landed.

  • websocket/tests/bad-sub-protocol-expected.txt:
  • websocket/tests/script-tests/bad-sub-protocol.js:
  • websocket/tests/script-tests/sub-protocol-with-space.js: Added.
  • websocket/tests/sub-protocol-with-space-expected.txt: Added.
  • websocket/tests/sub-protocol-with-space.html: Added.

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

WebSocket allow space (U+0020) in sub protocol name.
https://bugs.webkit.org/show_bug.cgi?id=32266

Test: websocket/tests/sub-protocol-with-space.html

  • websockets/WebSocket.cpp: (WebCore::isValidProtocolString):
7:20 PM Changeset in webkit [51885] by ukai@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Add tests that WebSocket-Protocol: is ignored if protocol was not specified.
https://bugs.webkit.org/show_bug.cgi?id=32267

  • websocket/tests/script-tests/websocket-protocol-ignored.js: Added.
  • websocket/tests/websocket-protocol-ignored-expected.txt: Added.
  • websocket/tests/websocket-protocol-ignored.html: Added.
6:38 PM Changeset in webkit [51884] by eric@webkit.org
  • 14 edits
    7 adds in trunk

2009-12-08 Peterson Trethewey <petersont@google.com>

Reviewed by Oliver Hunt.

Implement WebGLUniformLocation and change API to use it.
https://bugs.webkit.org/show_bug.cgi?id=31173

  • fast/canvas/webgl/resources/structUniformShader.vert: Added.
  • fast/canvas/webgl/script-tests/uniform-location.js: Added.
  • fast/canvas/webgl/uniform-location-expected.txt: Added.
  • fast/canvas/webgl/uniform-location.html: Added.

2009-12-08 Peterson Trethewey <petersont@google.com>

Reviewed by Oliver Hunt.

Implement WebGLUniformLocation and change API to use it.
https://bugs.webkit.org/show_bug.cgi?id=31173

Test: fast/canvas/webgl/uniform-location.html

  • DerivedSources.make:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp: (WebCore::JSWebGLRenderingContext::getProgramParameter): (WebCore::JSWebGLRenderingContext::getUniform): (WebCore::functionForUniform): (WebCore::dataFunctionf): (WebCore::dataFunctioni): (WebCore::dataFunctionMatrix):
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/DerivedSourcesAllInOne.cpp:
  • bindings/v8/V8Index.cpp:
  • bindings/v8/V8Index.h:
  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp: (WebCore::toWebGLUniformLocation): (WebCore::): (WebCore::CALLBACK_FUNC_DECL): (WebCore::isFunctionToCallForAttribute): (WebCore::vertexAttribAndUniformHelperf): (WebCore::uniformHelperi): (WebCore::uniformMatrixHelper):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::uniform1f): (WebCore::WebGLRenderingContext::uniform1fv): (WebCore::WebGLRenderingContext::uniform1i): (WebCore::WebGLRenderingContext::uniform1iv): (WebCore::WebGLRenderingContext::uniform2f): (WebCore::WebGLRenderingContext::uniform2fv): (WebCore::WebGLRenderingContext::uniform2i): (WebCore::WebGLRenderingContext::uniform2iv): (WebCore::WebGLRenderingContext::uniform3f): (WebCore::WebGLRenderingContext::uniform3fv): (WebCore::WebGLRenderingContext::uniform3i): (WebCore::WebGLRenderingContext::uniform3iv): (WebCore::WebGLRenderingContext::uniform4f): (WebCore::WebGLRenderingContext::uniform4fv): (WebCore::WebGLRenderingContext::uniform4i): (WebCore::WebGLRenderingContext::uniform4iv): (WebCore::WebGLRenderingContext::uniformMatrix2fv): (WebCore::WebGLRenderingContext::uniformMatrix3fv): (WebCore::WebGLRenderingContext::uniformMatrix4fv):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • html/canvas/WebGLUniformLocation.cpp: Added. (WebCore::WebGLUniformLocation::create): (WebCore::WebGLUniformLocation::WebGLUniformLocation):
  • html/canvas/WebGLUniformLocation.h: Added. (WebCore::WebGLUniformLocation::~WebGLUniformLocation): (WebCore::WebGLUniformLocation::program): (WebCore::WebGLUniformLocation::location):
  • html/canvas/WebGLUniformLocation.idl: Added.
5:43 PM Changeset in webkit [51883] by agl@chromium.org
  • 3 edits
    2 adds in trunk

2009-12-08 Adam Langley <agl@google.com>

Reviewed by Darin Adler.

Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo

startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).

Thanks to Robert Swiecki for the test case.

https://bugs.webkit.org/show_bug.cgi?id=32172
http://code.google.com/p/chromium/issues/detail?id=28880

Test: fast/css/recursive-delay-update-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::finishDelayUpdateScrollInfo):

2009-12-08 Adam Langley <agl@google.com>

Reviewed by Darin Adler.

Fix assertion failure in WebCore::RenderBlock::startDelayUpdateScrollInfo

startDelayUpdateScrollInfo calls a function that can end up calling
startDelayUpdateScrollInfo again. However, it's static state is
inconsistent when this happens leading to an assertion failure (or
probably a memory leak if assertions are off).

Thanks to Robert Swiecki for the test case.

https://bugs.webkit.org/show_bug.cgi?id=32172
http://code.google.com/p/chromium/issues/detail?id=28880

  • fast/css/recursive-delay-update-scroll.html: Added.
  • fast/css/recursive-delay-update-scroll-expected.txt: Added.
5:29 PM Changeset in webkit [51882] by mjs@apple.com
  • 9 edits
    1 copy in trunk/JavaScriptCore

move code generation portions of Nodes.cpp to bytecompiler directory
https://bugs.webkit.org/show_bug.cgi?id=32284

Reviewed by Darin Adler.

  • bytecompiler/NodesCodegen.cpp: Copied from parser/Nodes.cpp. Removed parts that

are not about codegen.

  • parser/Nodes.cpp: Removed everything that is about codegen.

Update build systems:

4:59 PM Changeset in webkit [51881] by sfalken@apple.com
  • 2 edits in trunk/WebCore

WebCore source level debugging on Windows not reliable in some cases
https://bugs.webkit.org/show_bug.cgi?id=32297

Reviewed by Adam Roben.

Customized pdb file name/location for WebCore static library.

  • WebCore.vcproj/WebCoreCommon.vsprops: Add ProgramDataBaseFileName.
4:52 PM Changeset in webkit [51880] by kevino@webkit.org
  • 14 edits
    1 add in trunk

Reviewed by Kevin Ollivier.

[wx] Mac plugins support.

https://bugs.webkit.org/show_bug.cgi?id=32236

4:40 PM Changeset in webkit [51879] by Simon Fraser
  • 2 edits in trunk/WebKit/mac

2009-12-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7295070> WebKit video fullscreen keeps playing after closing the window

Fix a leak of the QTMovieView when exiting fullscreen video, and remove the
old workaround.

  • WebView/WebVideoFullscreenController.mm: (-[WebVideoFullscreenController windowDidLoad]): Set the movie view as the contentView directly. (-[WebVideoFullscreenController setMediaElement:WebCore::]): Cast the contentView to a movie view. (-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the old workaround.
4:14 PM Changeset in webkit [51878] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip another failing media test, that I already mentioned in the bug report.

  • platform/mac-snowleopard/Skipped:
4:08 PM Changeset in webkit [51877] by beidson@apple.com
  • 3 edits
    2 adds in trunk

Navigating to a cached page can result in accessing a destroyed HTMLInputElement.
<rdar://problem/6856662> and https://webkit.org/b/32293

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/input-element-page-cache-crash.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::parseMappedAttribute): Make sure to unregister for the activation

callback after the new m_autocomplete setting has been stored so the unregistration actually
takes place.

LayoutTests:

  • fast/loader/input-element-page-cache-crash-expected.txt: Added.
  • fast/loader/input-element-page-cache-crash.html: Added.
3:54 PM Changeset in webkit [51876] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

[check-webkit-style] False positive for DEFINE_OPCODE(op_jtrue) {
https://bugs.webkit.org/show_bug.cgi?id=32193

Reviewed by Adam Barth.

  • Scripts/modules/cpp_style.py: For the function { rule, if there is space at the beginning of line, ignore lines which then have a macro.
  • Scripts/modules/cpp_style_unittest.py: Add tests to verify the new behavior.
3:27 PM Changeset in webkit [51875] by dimich@chromium.org
  • 14 edits
    5 deletes in trunk

Revert and reopen "Add asserts to RefCounted to make sure ref/deref happens on the right thread."
It may have caused massive increase of reported leaks on the bots.
https://bugs.webkit.org/show_bug.cgi?id=31639

Rubber-stamped by David Levin.

JavaScriptCore:

(JSC::Structure::Structure):

  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):

  • wtf/ThreadVerifier.h: Removed.

JavaScriptGlue:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

WebCore:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
  • loader/icon/IconRecord.cpp:

(WebCore::IconRecord::IconRecord):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer):

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl):

WebKit/mac:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Removed.

WebKitTools:

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Removed.
2:45 PM WebInspector edited by timothy@apple.com
(diff)
2:43 PM Changeset in webkit [51874] by pfeldman@chromium.org
  • 14 edits
    1 copy in trunk

2009-12-08 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Darin Fisher.

Chromium: support custom WebCore context menu items in Chromium port.

https://bugs.webkit.org/show_bug.cgi?id=32277

WebCore:

  • platform/ContextMenu.h:
  • platform/ContextMenuItem.h: (WebCore::PlatformMenuItemDescription::PlatformMenuItemDescription):
  • platform/chromium/ContextMenuChromium.cpp: (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenu::itemWithAction): (WebCore::ContextMenu::itemAtIndex): (WebCore::ContextMenu::platformDescription):
  • platform/chromium/ContextMenuItemChromium.cpp: (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenuItem::releasePlatformDescription): (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::action): (WebCore::ContextMenuItem::title): (WebCore::ContextMenuItem::checked): (WebCore::ContextMenuItem::enabled): (WebCore::ContextMenuItem::setType): (WebCore::ContextMenuItem::setAction): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):

WebKit/chromium:

  • public/WebContextMenuData.h:
  • public/WebPopupMenuInfo.h: (WebKit::WebPopupMenuInfo::Item::):
  • public/WebView.h:
  • src/ContextMenuClientImpl.cpp: (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::executeCustomContextMenuAction):
  • src/WebViewImpl.h:
2:42 PM Changeset in webkit [51873] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip fast/repaint/block-selection-gap-in-table-cell.html (generates new result) to turn Qt/Gtk builds green again.

  • platform/gtk/Skipped:
  • platform/qt/Skipped:
1:58 PM Changeset in webkit [51872] by agl@chromium.org
  • 2 edits in trunk/WebCore

2009-12-08 Adam Langley <agl@google.com>

Reviewed by Dimitri Glazkov.

Chromium Linux: set default scrollbar colours.

This is so that layout tests have sane defaults for the scrollbar
colours, even if the API user doesn't set any.

This is a fix due to r51827.

https://bugs.webkit.org/show_bug.cgi?id=32287

This is very well covered by existing layout tests.

  • rendering/RenderThemeChromiumLinux.cpp:
1:35 PM Changeset in webkit [51871] by kov@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

Make WebKit build correctly on FreeBSD, IA64, and Alpha.
Based on work by Petr Salinger <Petr.Salinger@seznam.cz>,
and Colin Watson <cjwatson@ubuntu.com>.

  • wtf/Platform.h:
1:14 PM Changeset in webkit [51870] by Beth Dakin
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/7397808> Crash occurs at
RenderObject::containingBlock() as I type in the Google Search
field (during page load)

Reviewed by Sam Weinig.

  • editing/Editor.cpp:

(WebCore::Editor::insideVisibleArea): ownerRenderer() needs to be
null checked.

12:25 PM Changeset in webkit [51869] by dimich@chromium.org
  • 14 edits
    5 adds in trunk

Add asserts to RefCounted to make sure ref/deref happens on the right thread.
https://bugs.webkit.org/show_bug.cgi?id=31639

Reviewed by Darin Adler.

JavaScriptCore:

  • runtime/Structure.cpp:

(JSC::Structure::Structure): Disable thread verification on this class since it uses addressOfCount().

  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref): Add ASSERT.
(WTF::RefCountedBase::hasOneRef): Ditto.
(WTF::RefCountedBase::refCount): Ditto.
(WTF::RefCountedBase::derefBase): Ditto.
(WTF::RefCountedBase::disableThreadVerification): delegate to ThreadVerifier method.

  • wtf/ThreadVerifier.h: Added.

(WTF::ThreadVerifier::ThreadVerifier): New Debug-only class to verify that ref/deref of RefCounted is done on the same thread.
(WTF::ThreadVerifier::activate): Activates checks. Called when ref count becomes above 2.
(WTF::ThreadVerifier::deactivate): Deactivates checks. Called when ref count drops below 2.
(WTF::ThreadVerifier::disableThreadVerification): used on objects that should not be checked (StringImpl etc)
(WTF::ThreadVerifier::verifyThread):

JavaScriptGlue:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebCore:

  • loader/icon/IconRecord.cpp:

(WebCore::IconRecord::IconRecord): Disable thread verification for this class because of its cross-thread use in IconDatabase.

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::SharedBuffer): Ditto.

  • platform/text/StringImpl.cpp:

(WebCore::StringImpl::StringImpl): Disable thread verification for this class, add FIXME to enforce proper usage via crossThreadString.

  • ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebKit/mac:

  • ForwardingHeaders/wtf/ThreadVerifier.h: Added.

WebKitTools:

  • DumpRenderTree/ForwardingHeaders/wtf/ThreadVerifier.h: Added.
11:16 AM Changeset in webkit [51868] by ajwong@chromium.org
  • 2 edits in trunk/WebKit/chromium

Not reviewed: Chromium build fix.

r51859 changed the case for some of the ResourceRequest::TargetType
enums.

  • src/FrameLoaderClientImpl.cpp:

(WebKit::determineTargetTypeFromLoader):

10:59 AM Changeset in webkit [51867] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
10:55 AM Changeset in webkit [51866] by levin@chromium.org
  • 3 edits in trunk/WebKitTools

[check-webkit-style] False positive for camel case of JSC op codes
https://bugs.webkit.org/show_bug.cgi?id=32192

Reviewed by Adam Barth.

  • Scripts/modules/cpp_style.py: Added an exception for the JSC op code functions and const_iterator as well since I noticed a false positive there when testing the fix.
  • Scripts/modules/cpp_style_unittest.py: Added tests for these changes.
10:44 AM Changeset in webkit [51865] by abarth@webkit.org
  • 7 edits
    2 adds in trunk

2009-12-08 John Gregg <johnnyg@google.com>

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=31886

Test for accessing the notificationCenter of a window after it's closed.

  • fast/notifications/notification-after-close-expected.txt: Added.
  • fast/notifications/notification-after-close.html: Added.

2009-12-08 John Gregg <johnnyg@google.com>

Reviewed by Adam Barth.

Inform the NotificationCenter when its window goes away in the same
manner as other DOMWindow fields, and prevent invalid operations on
it after that happens.

As part of this, change the V8 bindings for notifications to call
through the NotificationCenter rather than doing those operations
itself.

https://bugs.webkit.org/show_bug.cgi?id=31886

Test: fast/notifications/notification-after-close.html

  • bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
  • notifications/Notification.cpp: (WebCore::Notification::Notification):
  • notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::checkPermission): (WebCore::NotificationCenter::requestPermission):
  • notifications/NotificationCenter.h: (WebCore::NotificationCenter::createHTMLNotification): (WebCore::NotificationCenter::createNotification): (WebCore::NotificationCenter::disconnectFrame):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::clear):
10:44 AM CommitQueue edited by abarth@webkit.org
(diff)
9:37 AM Changeset in webkit [51864] by mitz@apple.com
  • 4 edits
    4 adds in trunk

WebCore: Fixed block selection gap repainting in table cells

Reviewed by John Sullivan.

Test: fast/repaint/block-selection-gap-in-table-cell.html

This recently-introduced regression exposed the fact that
RenderTableCell did not override offsetFromContainer() to adjust for
the fact that table cells’ coordinates are relative to the table
section, not the table row. With this fixed, RenderTableCell no longer
needs to override mapLocalToContainer() and mapAbsoluteToLocalPoint(),
since the base class implementations of those use offsetFromContainer().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::offsetFromContainer):

  • rendering/RenderTableCell.h:

LayoutTests: Added a test of block selection gap repainting in table cells

Reviewed by John Sullivan.

  • fast/repaint/block-selection-gap-in-table-cell.html: Added.
  • platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.checksum: Added.
  • platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.png: Added.
  • platform/mac/fast/repaint/block-selection-gap-in-table-cell-expected.txt: Added.
9:35 AM Changeset in webkit [51863] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Sane way to force a rebuild on all win slaves, according to Adam Roben.

  • WebCorePrefix.h:
9:32 AM Changeset in webkit [51862] by mitz@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Correct Bugzilla link

9:31 AM Changeset in webkit [51861] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix

  • loader/loader.cpp:

(WebCore::cachedResourceTypeToTargetType):

9:08 AM Changeset in webkit [51860] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Touch svgtags.in to eventually fix the win debug build.

  • svg/svgtags.in:
9:04 AM Changeset in webkit [51859] by eric@webkit.org
  • 4 edits in trunk/WebCore

2009-12-08 Mike Belshe <mike@belshe.com>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=32152
Update the ResourceRequest::RequestType. This previously
was specific to Chromium. Moved into ResourceRequestBase, enabling
more specificity about the type (which is otherwise only known to the
loader), and also making this information available to all platforms.
Any platform with a network layer which can utilize this information
may want to use it for prioritization.

Note to Chromium glue: TargetIsSubResource renamed to TargetIsSubresource.

  • loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::CachedResourceTypeToTargetType): (WebCore::Loader::Host::servePendingRequests):
  • platform/network/ResourceRequestBase.h: (WebCore::ResourceRequestBase::): (WebCore::ResourceRequestBase::targetType): (WebCore::ResourceRequestBase::setTargetType): (WebCore::ResourceRequestBase::ResourceRequestBase):
  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):
8:55 AM Changeset in webkit [51858] by eric@webkit.org
  • 4 edits
    7 adds in trunk

2009-12-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325

  • Android.mk: Added.

2009-12-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325

  • Android.mk: Added.
  • Android.v8.wtf.mk: Added.

2009-12-08 Steve Block <steveblock@google.com>

Reviewed by Adam Barth.

[Android] Adds Makefiles for Android port.
https://bugs.webkit.org/show_bug.cgi?id=31325

Build system change only. No tests possible.

  • Android.derived.jscbindings.mk: Added.
  • Android.derived.mk: Added.
  • Android.jscbindings.mk: Added.
  • Android.mk: Added.
  • WebCorePrefix.h: Modified. Sets up some flags and adds a header required for building on Android.
8:55 AM Changeset in webkit [51857] by sullivan@apple.com
  • 2 edits in trunk/WebKit/win

Split two-clause assertions into two separate assertions.

Reviewed by Dan Bernstein

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isTextField):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::rectOnScreen):
Added the two assertions here that all other functions in this group shared.
(DOMHTMLInputElement::selectedRange):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::setAutofilled):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::isAutofilled):
Split a two-clause assertion into two separate assertions.

8:36 AM Changeset in webkit [51856] by christian@webkit.org
  • 4 edits in trunk

2009-12-08 Christian Dywan <christian@twotoasts.de>

Reviewed by Xan Lopez.

  • configure.ac: Require only libSoup 2.27.91 but check for 2.29.3 and define HAVE_LIBSOUP_2_29_3 in that case.
8:28 AM Changeset in webkit [51855] by Nikolas Zimmermann
  • 10 edits in trunk

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Win.
https://bugs.webkit.org/show_bug.cgi?id=32224

8:17 AM Changeset in webkit [51854] by christian@webkit.org
  • 2 edits in trunk/WebKit/gtk

2009-12-08 Christian Dywan <christian@twotoasts.de>

Reviewed by Gustavo Noronha Silva.

Point out the meaning of "Content-Disposition" when implementing the
mime-type-policy-decision-requested signal.

  • webkit/webkitwebview.cpp: (webkit_web_view_class_init):
7:58 AM Changeset in webkit [51853] by kov@webkit.org
  • 2 edits in trunk

Rubber-stamped by Xan Lopez.

Late post-release version bump.

  • configure.ac:
7:33 AM Changeset in webkit [51852] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2009-12-08 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

These test results should not have platform-dependent pixel values.
https://bugs.webkit.org/show_bug.cgi?id=32265

Change is75PercentOf() so that it doesn't show pixel values when
the check is passed.

  • fast/replaced/table-percent-height-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • fast/replaced/table-percent-height-text-controls.html:
  • fast/replaced/table-percent-height.html:
7:20 AM Changeset in webkit [51851] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-08 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS Counter Nesting still does not work according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=31723

  • fast/css/counters/nesting-expected.txt: Added.
  • fast/css/counters/nesting.html: Added. This test tests compliance with the CSS2.1 counter scoping and nesting rules.

2009-12-08 Carol Szabo <carol.szabo@nokia.com>

Reviewed by Darin Adler.

CSS Counter Nesting still does not work according to the spec.
https://bugs.webkit.org/show_bug.cgi?id=31723

Test: fast/css/counters/nesting.html

  • rendering/RenderCounter.cpp: (WebCore::findPlaceForCounter): Replaced the faulty counter insertion algorithm with one that works.
7:08 AM Changeset in webkit [51850] by sullivan@apple.com
  • 7 edits in trunk

Add isAutofilled getter to match existing setter.

Reviewed by Ada Chan.

WebCore:

  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLInputElement _isAutofilled]):
Implemented new cover function.

  • bindings/objc/DOMPrivate.h:

Declared new cover function.

WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLInputElement::isAutofilled):
Implemented new cover function.

  • DOMHTMLClasses.h:

Declared new cover function.

  • Interfaces/DOMPrivate.idl:

Declared new interface.

7:02 AM Changeset in webkit [51849] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Put test into skiplist because of missing layoutTestController.evaluateInWebInspector().

  • platform/qt/Skipped: inspector/cookie-resource-match.html added.
6:58 AM Changeset in webkit [51848] by eric@webkit.org
  • 4 edits
    1 add in trunk

2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
https://bugs.webkit.org/show_bug.cgi?id=31469

Removing hybrid configuration for --with-unicode-backend=glib
ICU not required anymore.

  • autotools/webkit.m4:

2009-12-08 Dominik Röttsches <dominik.roettsches@access-company.com>

Reviewed by Gustavo Noronha Silva.

[Gtk] Create a TextBreakIterator implementation based on GLib (without ICU)
https://bugs.webkit.org/show_bug.cgi?id=31469

Added a TextBreakIterator implementation based on GLib and pango,
which allows compiling WebCore without ICU.

  • GNUmakefile.am:
  • platform/text/gtk/TextBreakIteratorGtk.cpp: Added. (WebCore::): (WebCore::setUpIterator): (WebCore::characterBreakIterator): (WebCore::cursorMovementIterator): (WebCore::wordBreakIterator): (WebCore::lineBreakIterator): (WebCore::sentenceBreakIterator): (WebCore::textBreakFirst): (WebCore::textBreakLast): (WebCore::textBreakNext): (WebCore::textBreakPrevious): (WebCore::textBreakPreceding): (WebCore::textBreakFollowing): (WebCore::textBreakCurrent): (WebCore::isTextBreak):
6:35 AM Changeset in webkit [51847] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Update Gtk's custom prototype-inheritance-2-expected.txt, after enabling filters
(As gtk builds with geolocation, unlike the other platforms, it needs its own results)

This turns the Gtk slave to green again.

  • platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
6:09 AM QtWebKit/CodeCamp200912 edited by tapani.mikola@nokia.com
(diff)
6:02 AM QtWebKit edited by tapani.mikola@nokia.com
(diff)
5:56 AM QtWebKit/CodeCamp200912 created by tapani.mikola@nokia.com
5:21 AM Changeset in webkit [51846] by eric@webkit.org
  • 11 edits
    2 adds in trunk

2009-12-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Change the way cookies are retrieved in the WebInspector frontend.

Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
https://bugs.webkit.org/show_bug.cgi?id=32160

  • inspector/cookie-resource-match-expected.txt: Added.
  • inspector/cookie-resource-match.html: Added.

2009-12-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Pavel Feldman.

Change the way cookies are retrieved in the WebInspector frontend.

Moved the cookie filtering from the native code into the frontend so that
all cookies can be retrieved regardless of the associated domain
(required for certain audits to run.)
https://bugs.webkit.org/show_bug.cgi?id=32160

Test: inspector/cookie-resource-match.html

  • inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getCookies):
  • inspector/InspectorBackend.h:
  • inspector/InspectorBackend.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::getCookies):
  • inspector/InspectorController.h:
  • inspector/front-end/CookieItemsView.js: (WebInspector.CookieItemsView.prototype.update.callback): (WebInspector.CookieItemsView.prototype.update): (WebInspector.CookieItemsView.prototype._cookiesForDomain):
  • inspector/front-end/DOMAgent.js: (WebInspector.Cookies.getCookiesAsync): (WebInspector.Cookies.cookieMatchesResourceURL): (WebInspector.Cookies.cookieDomainMatchesResourceDomain):
  • inspector/front-end/Resource.js: (WebInspector.Resource): (WebInspector.Resource.prototype.get documentURL): (WebInspector.Resource.prototype.set documentURL):
  • inspector/front-end/inspector.js: (WebInspector.addResource):
4:55 AM Changeset in webkit [51845] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Touch svgtags.in, in order to force SVGNames.* regeneration. Praying for gtk bot to be fixed :-)

  • svg/svgtags.in:
4:30 AM Changeset in webkit [51844] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Trying to force a rebuild on the Gtk slave. If that doesn't work, someone must force a rebuild from scratch.

  • bindings/scripts/CodeGeneratorJS.pm:
3:51 AM Changeset in webkit [51843] by Nikolas Zimmermann
  • 6 edits in trunk

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Gtk.
https://bugs.webkit.org/show_bug.cgi?id=32224

3:21 AM Changeset in webkit [51842] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Skip some tests that fail for a longer period on the SnowLeopard bot. Filed two bugs, notifying the authors.

  • platform/mac-snowleopard/Skipped:
2:58 AM Changeset in webkit [51841] by Nikolas Zimmermann
  • 4 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Oops forgot to update three results -> Qt slave green again.

  • platform/qt/svg/filters/feGaussianBlur-expected.txt:
  • platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
  • platform/qt/svg/filters/feOffset-expected.txt:
2:47 AM Changeset in webkit [51840] by Nikolas Zimmermann
  • 11 edits in trunk/LayoutTests

2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Now that the Qt slave has been rebuilt, reenable all tests that failed
because of the build problems (Qt slave didn't rebuild all files with ENABLE_FILTERS set).

Update some Qt specfic filter test results.

  • platform/qt/Skipped:
  • platform/qt/svg/filters/feComposite-expected.txt:
  • platform/qt/svg/filters/feMerge-expected.txt:
  • platform/qt/svg/filters/feTile-expected.txt:
  • platform/qt/svg/filters/shadow-on-filter-expected.txt:
  • platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
  • platform/qt/svg/filters/sourceAlpha-expected.txt:
  • platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
  • platform/qt/svg/filters/subRegion-one-effect-expected.txt:
  • platform/qt/svg/filters/subRegion-two-effects-expected.txt:
2:19 AM Changeset in webkit [51839] by pfeldman@chromium.org
  • 22 edits
    2 copies in trunk/WebCore

2009-12-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: provide custom context menu in the front-end window.

https://bugs.webkit.org/show_bug.cgi?id=32200

  • English.lproj/localizedStrings.js:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::JSInspectorFrontendHost::showContextMenu):
  • inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::contextMenuItemSelected): (WebCore::InspectorFrontend::contextMenuCleared):
  • inspector/InspectorFrontend.h:
  • inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::InspectorFrontendHost): (WebCore::InspectorFrontendHost::~InspectorFrontendHost): (WebCore::InspectorFrontendHost::showContextMenu): (WebCore::InspectorFrontendHost::contextMenuItemSelected): (WebCore::InspectorFrontendHost::contextMenuCleared):
  • inspector/InspectorFrontendHost.h: (WebCore::InspectorFrontendHost::MenuSelectionHandler::create): (WebCore::InspectorFrontendHost::MenuSelectionHandler::~MenuSelectionHandler): (WebCore::InspectorFrontendHost::MenuSelectionHandler::disconnect): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuItemSelected): (WebCore::InspectorFrontendHost::MenuSelectionHandler::contextMenuCleared): (WebCore::InspectorFrontendHost::MenuSelectionHandler::MenuSelectionHandler):
  • inspector/InspectorFrontendHost.idl:
  • inspector/front-end/ContextMenu.js: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.html:
  • inspector/front-end/inspector.js: (WebInspector.loaded): (WebInspector.documentContextMenu):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::clearContextMenu): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::showContextMenu): (WebCore::ContextMenuController::createContextMenu): (WebCore::ContextMenuController::contextMenuItemSelected):
  • page/ContextMenuController.h:
  • page/ContextMenuSelectionHandler.h: Added. (WebCore::ContextMenuSelectionHandler::ContextMenuSelectionHandler): (WebCore::ContextMenuSelectionHandler::~ContextMenuSelectionHandler):
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
  • platform/ContextMenuItem.h:
2:04 AM Changeset in webkit [51838] by Csaba Osztrogonác
  • 2 edits in trunk/WebCore

Rubber-stamped by Kenneth Rohde Christiansen.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-08
[Qt] Build fix of duplicated platform/graphics/filters/FEGaussianBlur.cpp in WebCore.pro after enabled svg filters.

No new tests needed.

  • WebCore.pro:
12:32 AM Changeset in webkit [51837] by ukai@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

2009-12-08 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Add tests that WebSocket protocol argument works.
https://bugs.webkit.org/show_bug.cgi?id=3178

  • websocket/tests/bad-sub-protocol-expected.txt: Added.
  • websocket/tests/bad-sub-protocol.html: Added.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch-expected.txt: Added.
  • websocket/tests/handshake-fail-by-sub-protocol-mismatch.html: Added.
  • websocket/tests/protocol-test_wsh.py: Added.
  • websocket/tests/script-tests/bad-sub-protocol.js: Added.
  • websocket/tests/script-tests/handshake-fail-by-sub-protocol-mismatch.js: Added.
  • websocket/tests/script-tests/sub-protocol.js: Added.
  • websocket/tests/sub-protocol-expected.txt: Added.
  • websocket/tests/sub-protocol.html: Added.

Dec 7, 2009:

10:00 PM Changeset in webkit [51836] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed fix to make QtBuildBot green.
Skip failing tests caused by r51828 (Turn on (SVG) Filters for Qt.)
https://bugs.webkit.org/show_bug.cgi?id=32224
http://build.webkit.org/results/Qt%20Linux%20Release/r51828%20(4620)/results.html

  • platform/qt/Skipped:
9:58 PM Changeset in webkit [51835] by hamaji@chromium.org
  • 3 edits in trunk/WebKitTools

2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Levin.

[check-webkit-style] S_OK is a fine identifier
https://bugs.webkit.org/show_bug.cgi?id=32225

  • Scripts/modules/cpp_style.py:
  • Scripts/modules/cpp_style_unittest.py:
9:48 PM Changeset in webkit [51834] by hamaji@chromium.org
  • 5 edits in trunk/LayoutTests

2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

editing/selection/last-empty-inline is failing in Windows
https://bugs.webkit.org/show_bug.cgi?id=31985

  • editing/selection/last-empty-inline-expected.txt:
  • editing/selection/last-empty-inline.html:
  • platform/qt/Skipped:
  • platform/win/Skipped:
9:29 PM Changeset in webkit [51833] by hamaji@chromium.org
  • 3 edits in trunk/WebCore

2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by Darin Adler.

Add a function to show render tree for debugging
https://bugs.webkit.org/show_bug.cgi?id=31288

No new tests because this just adds a function for debugging.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::showRenderObject): (WebCore::RenderObject::showRenderTreeAndMark): (showRenderTree):
  • rendering/RenderObject.h:
8:55 PM Changeset in webkit [51832] by eric@webkit.org
  • 2 edits in trunk/WebKit/chromium

2009-12-07 Zhe Su <suzhe@chromium.org>

Reviewed by Darin Fisher.

[Chromium] accesskey is not supported on Chromium Mac.
https://bugs.webkit.org/show_bug.cgi?id=32213

This change fixes (partially) the accesskey issue by decoupling the
code for handling accesskeys and system keys. Because on Mac,
the modifiers of accesskeys are ctrl+alt, which are not marked as
system keys.
In order to fully fix this issue, some changes in Chromium code is
also required.

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::charEvent):
8:33 PM Changeset in webkit [51831] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-07 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Implement NamedPropertyEnumerator and IndexedPropertyEnumerator for
V8 NPObject. This should make the object enumerable and fix the
enumeration issue in layout test plugins/netscape-enumerate.html.

Also fix some existing style issues per webkit style guidelines.

https://bugs.webkit.org/show_bug.cgi?id=32254

Test: plugins/netscape-enumerate.html

  • bindings/v8/V8NPObject.cpp: (npObjectInvokeImpl): (npObjectInvokeDefaultHandler): (npObjectGetProperty): (npObjectPropertyEnumerator): (npObjectNamedPropertyEnumerator): (npObjectIndexedPropertyEnumerator): (createV8ObjectForNPObject):
8:19 PM Changeset in webkit [51830] by ukai@chromium.org
  • 5 edits
    3 deletes in trunk

2009-12-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fragments now make WebSocket URL parsing fail.
https://bugs.webkit.org/show_bug.cgi?id=32144

  • websocket/tests/script-tests/url-parsing.js:
  • websocket/tests/script-tests/url-with-fragment.js: Removed.
  • websocket/tests/url-parsing-expected.txt:
  • websocket/tests/url-with-fragment-expected.txt: Removed.
  • websocket/tests/url-with-fragment.html: Removed.

2009-12-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Fragments now make WebSocket URL parsing fail.
https://bugs.webkit.org/show_bug.cgi?id=32144

  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect):
8:03 PM Changeset in webkit [51829] by ukai@chromium.org
  • 5 edits in trunk

2009-12-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Fix wrong length parsing in WebSocket.
https://bugs.webkit.org/show_bug.cgi?id=32203

These two tests assumed wrong length encoding in frame: it parsed
length from bytes with 8th bit on. But spec says length is encoded
as a series of 7-bit bytes stored in octests with the 8th bit on
*but the last byte*.
These tests encodes a frame that has 129 length, so it must be
\x81\0x01 instead of \x81\0x81.

  • websocket/tests/frame-length-longer-than-buffer_wsh.py:
  • websocket/tests/frame-length-skip_wsh.py:

2009-12-07 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Darin Adler.

Fix wrong length parsing in WebSocket.
https://bugs.webkit.org/show_bug.cgi?id=32203

  • websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::didReceiveData):
7:44 PM Changeset in webkit [51828] by Nikolas Zimmermann
  • 6 edits in trunk

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Rubber-stamped by Maciej Stachowiak.

Turn on (SVG) Filters for Qt.
https://bugs.webkit.org/show_bug.cgi?id=32224

6:54 PM Changeset in webkit [51827] by eric@webkit.org
  • 8 edits in trunk

2009-12-07 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Chromium: theme scrollbars to match GTK theme.
Add functions to RenderThemeChromiumLinux to change the scrollbar
color.

Since the change is to the Chromium WebKit API layer, testing will
be in Chromium's test shell.
http://bugs.webkit.org/show_bug.cgi?id=32048

Patch from Markus Gutschke <markus@chromium.org>.

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: (WebCore::saturateAndBrighten): (WebCore::outlineColor): (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece): (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
  • rendering/RenderThemeChromiumLinux.cpp: (WebCore::RenderThemeChromiumLinux::setScrollbarColors):
  • rendering/RenderThemeChromiumLinux.h: (WebCore::RenderThemeChromiumLinux::thumbInactiveColor): (WebCore::RenderThemeChromiumLinux::thumbActiveColor): (WebCore::RenderThemeChromiumLinux::trackColor):

2009-12-07 Evan Martin <evan@chromium.org>

Reviewed by Eric Seidel.

Chromium: theme scrollbars to match GTK theme.
Add API to set the colors.

Since the change is to the Chromium WebKit API layer, testing will
be in Chromium's test shell.
http://bugs.webkit.org/show_bug.cgi?id=32048

Patch from Markus Gutschke <markus@chromium.org>.

  • public/WebView.h:
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setScrollbarColors):
  • src/WebViewImpl.h:
6:50 PM Changeset in webkit [51826] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2009-12-07 Shinichiro Hamaji <hamaji@chromium.org>

Reviewed by David Kilzer.

Bugzilla should show images in git patches
https://bugs.webkit.org/show_bug.cgi?id=31395

Attempt to go r51748 again using --directory option of git-apply.

  • PrettyPatch/PrettyPatch.rb:
6:44 PM Changeset in webkit [51825] by kov@webkit.org
  • 10 edits in trunk

WebCore

Reviewed by Xan Lopez.

[GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
https://bugs.webkit.org/show_bug.cgi?id=32247

Allow creating a ResourceResponse from a SoupMessage.

Covered by API test.

  • platform/network/soup/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/soup/ResourceResponseSoup.cpp: (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

Reviewed by Xan Lopez.

[GTK] Doesn't respect Content-Disposition for downloads, and provides no way for apps to do that
https://bugs.webkit.org/show_bug.cgi?id=32247

Provide a way for applications to respect Content-Disposition, by
fetching the WebKitNetworkResponse from the frame during
mime-type-policy-decision-requested.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForMIMEType): Download content when Content-Disposition is attachment.
  • tests/testmimehandling.c: (server_callback): (mime_type_policy_decision_requested_cb):
  • tests/testwebframe.c: (test_webkit_web_frame_response): (main):
  • webkit/webkitprivate.cpp: (WebKit::core):
  • webkit/webkitwebframe.cpp: (webkit_web_frame_get_network_response):
  • webkit/webkitwebframe.h:
6:40 PM Changeset in webkit [51824] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Make run-webkit-websocketserver log to stderr rather than to a file.
https://bugs.webkit.org/show_bug.cgi?id=32234

  • Scripts/run-webkit-websocketserver:
6:29 PM Changeset in webkit [51823] by Nikolas Zimmermann
  • 3 edits
    3 deletes in trunk

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Reverting problematic patch, causing errors.

Revert r51789 (Avoid zero division during SVGPaintServerPattern::setup()). Crashes on all Windows slaves.
Reopen bug https://bugs.webkit.org/show_bug.cgi?id=29912.

  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):
6:26 PM Changeset in webkit [51822] by tkent@chromium.org
  • 6 edits
    9 adds in trunk

2009-12-07 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add tests for HTMLInputElement::stepUp() and stepDown().
https://bugs.webkit.org/show_bug.cgi?id=27451

  • fast/forms/input-step-number-expected.txt: Added.
  • fast/forms/input-step-number.html: Added.
  • fast/forms/input-step-range-expected.txt: Added.
  • fast/forms/input-step-range.html: Added.
  • fast/forms/input-step-unsupported-expected.txt: Added.
  • fast/forms/input-step-unsupported.html: Added.
  • fast/forms/script-tests/input-step-number.js: Added.
  • fast/forms/script-tests/input-step-range.js: Added.
  • fast/forms/script-tests/input-step-unsupported.js: Added.

2009-12-07 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Add support for HTMLInputElement::stepUp() and stepDown() for
type=number and type=range.
https://bugs.webkit.org/show_bug.cgi?id=27451

Our implementation of stepUp() and stepDown() rounds the resultant
value to conform to the step value.
Change the number-string conversion method for RenderSlider to be
consistent with type=number.

Tests: fast/forms/input-step-number.html

fast/forms/input-step-range.html
fast/forms/input-step-unsupported.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::rangeUnderflow): Unify the code for NUMBER and RANGE. (WebCore::HTMLInputElement::rangeOverflow): Unify the code for NUMBER and RANGE. (WebCore::HTMLInputElement::minimum): Renamed from rangeMinimum(), and support for NUMBER. (WebCore::HTMLInputElement::maximum): Renamed from rangeMaximum(), and support for NUMBER. (WebCore::HTMLInputElement::stepBase): (WebCore::HTMLInputElement::stepMismatch): Use stepBase(). (WebCore::HTMLInputElement::applyStepForNumberOrRange): (WebCore::HTMLInputElement::stepUp): (WebCore::HTMLInputElement::stepDown): (WebCore::HTMLInputElement::formStringFromDouble):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::stepUp): (WebCore::HTMLInputElement::stepDown):
  • html/HTMLInputElement.idl: Add stepUp() and stepDown().
  • rendering/RenderSlider.cpp: (WebCore::SliderRange::SliderRange): Sync with rangeMinimum()/rangeMaximum() renaming. (WebCore::RenderSlider::updateFromElement): Use formStringFromDouble(). (WebCore::RenderSlider::setValueForPosition): Use formStringFromDouble().
6:21 PM Changeset in webkit [51821] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed: Chromium build fix try 2 (dumb error).

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::getString):

5:55 PM Changeset in webkit [51820] by ajwong@chromium.org
  • 3 edits in trunk/WebCore

Not reviewed: Chromium build fix.

Fix Chromium build break caused by an added dependency from

ScriptControllerBase to JSDOMWindowShell, and an API change in
ScriptValue.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/v8/ScriptValue.h:

(WebCore::ScriptValue::getString):

5:31 PM Changeset in webkit [51819] by enrica@apple.com
  • 3 edits
    2 adds in trunk

WebCore: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
https://bugs.webkit.org/show_bug.cgi?id=32233

Reviewed by Darin Adler.

Fixes problem in re-creating the correct hierarchy under the new block.
Added extensive testing to cover all the cases.

Test: editing/execCommand/indent-with-style2.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement):

LayoutTests: REGRESSION(4.0.4-42a12): Indent does not work for twice modified with background text in gmail.
<rdar://problem/7442387>
https://bugs.webkit.org/show_bug.cgi?id=32233

Reviewed by Darin Adler.

  • editing/execCommand/indent-with-style2-expected.txt: Added.
  • editing/execCommand/indent-with-style2.html: Added.
5:22 PM Changeset in webkit [51818] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2009-12-07 Finnur Thorarinsson <finnur.webkit@gmail.com>

Reviewed by Darin Fisher.

A patch for Chromium to restrict the scope of the Gmail focus fix,
where we set the Selection to 0,0 for content-editable fields and
also make sure we set the selection end-state for find to select the
text found (when not focusing a link we found).
WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=32248

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::setFocus):
5:15 PM Changeset in webkit [51817] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Add some missing files that depend on SVG Filters support, only mac supports it for now.
Still one more crash affecting the win slaves, unrelated to the filters patch though.

5:03 PM Changeset in webkit [51816] by Adam Roben
  • 2 edits in trunk/WebKitLibraries

Windows build fix for checkouts with a space in the path

  • win/tools/scripts/auto-version.sh: Quote the output file's directory

before passing it to mkdir.

4:59 PM Changeset in webkit [51815] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed. Skip a timeouter flakey test.

  • platform/qt/Skipped: fast/frames/sandboxed-iframe-plugins.html added.
4:51 PM Changeset in webkit [51814] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Skip yet another test, what a journey...

4:50 PM Changeset in webkit [51813] by dimich@chromium.org
  • 15 edits in trunk

Remove ENABLE_SHARED_SCRIPT flags
https://bugs.webkit.org/show_bug.cgi?id=32245
This patch was obtained by "git revert" command and then un-reverting of ChangeLog files.

Rubber-stamped by Darin Adler.

  • configure.ac:

JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • wtf/Platform.h:

WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • WebCore.pro:

WebKit/chromium:

  • features.gypi:

WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

WebKitTools:

  • Scripts/build-webkit:
4:40 PM Changeset in webkit [51812] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Adjust one layout test to the results of the Leopard Intel slave.

4:37 PM Changeset in webkit [51811] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

Not reviewed. Turn Qt slave green again, after landing filters.

4:10 PM Changeset in webkit [51810] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Force JS binding regeneration, eventually fixing the broken tests on the bots.

  • bindings/scripts/CodeGeneratorJS.pm:
4:04 PM Changeset in webkit [51809] by mitz@apple.com
  • 5 edits in trunk/LayoutTests

Corrected expected results

  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum:
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png:
4:02 PM Changeset in webkit [51808] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubber-stamped by Simon Fraser.

Re-enabled this test now that <rdar://problem/7450481> is fixed.

  • fast/repaint/block-selection-gap-in-composited-layer.html: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.disabled.
  • fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Removed.
4:00 PM Changeset in webkit [51807] by bweinstein@apple.com
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

Add new exported symbols to finally fix the build.

3:53 PM Changeset in webkit [51806] by barraclough@apple.com
  • 2 edits in trunk/WebKit/win
  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix part III).

3:47 PM Changeset in webkit [51805] by barraclough@apple.com
  • 2 edits in trunk/WebKit/win
  • WebView.cpp:

(WebView::stringByEvaluatingJavaScriptFromString):

Reviewed by NOBODY (Windows build fix part II).

3:30 PM Changeset in webkit [51804] by Simon Fraser
  • 11 edits in trunk

2009-12-07 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

<rdar://problem/7450481> One compositing test keeps DRT in "compositing mode", breaks repaint tests

The counter that WebView used to keep track of the number of enclosed WebHTMLViews using
accelerated compositing was hard to manage, and maintained incorrectly in a number of cases.
This caused one compositing test make DumpRenderTree think that all subsequent tests
were compositing too.

Replace this counter with notifications, which are only fired if a client (DRT) requests them. The
notification informs the client that a WebHTMLView entered compositing mode (or an already-
compositing WebHTML was added); it does not say when a view becomes uncomposited, or all
compositing subviews were removed, since this is tricky to get right.

Change -[WebView _isUsingAcceleratedCompositing] to manually walk the frames, and
return YES if any document view is composited.

  • WebKit.exp:
  • WebView/WebHTMLView.mm: (-[WebHTMLView close]): (-[WebHTMLView viewDidMoveToSuperview]): (-[WebHTMLView attachRootLayer:]): (-[WebHTMLView detachRootLayer]):
  • WebView/WebView.mm: (+[WebView automaticallyNotifiesObserversForKey:]): (-[WebView _postsAcceleratedCompositingNotifications]): (-[WebView _setPostsAcceleratedCompositingNotifications:]): (-[WebView _isUsingAcceleratedCompositing]):
  • WebView/WebViewData.h:
  • WebView/WebViewInternal.h:
  • WebView/WebViewPrivate.h:
3:26 PM Changeset in webkit [51803] by barraclough@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (Windows build fixage part I).

3:15 PM Changeset in webkit [51802] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Try to fix mac builds by touching svgtags.in - I only tried from-scratch builds.

  • svg/svgtags.in:
3:14 PM Changeset in webkit [51801] by barraclough@apple.com
  • 42 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=32184
Handle out-of-memory conditions with JSC Ropes with a JS exception, rather than crashing.
Switch from using fastMalloc to tryFastMalloc, pass an ExecState to record the exception on.

Reviewed by Oliver Hunt.

JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::::toString):

  • API/JSValueRef.cpp:

(JSValueIsStrictEqual):

(JSC::BytecodeGenerator::emitEqualityOp):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::functionName):
(JSC::DebuggerCallFrame::calculatedFunctionName):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::callEval):
(JSC::Interpreter::privateExecute):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

  • profiler/Profiler.cpp:

(JSC::Profiler::willExecute):
(JSC::Profiler::didExecute):
(JSC::Profiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):

  • profiler/Profiler.h:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/DateConstructor.cpp:

(JSC::constructDate):

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::name):
(JSC::InternalFunction::displayName):
(JSC::InternalFunction::calculatedDisplayName):

  • runtime/InternalFunction.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::getString):

  • runtime/JSCell.h:

(JSC::JSValue::getString):

  • runtime/JSONObject.cpp:

(JSC::gap):
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectFunction):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::defineOwnProperty):

  • runtime/JSObject.h:
  • runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::get):

  • runtime/JSString.cpp:

(JSC::JSString::Rope::~Rope):
(JSC::JSString::resolveRope):
(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):
(JSC::JSString::toString):
(JSC::JSString::toThisString):
(JSC::JSString::getStringPropertyDescriptor):

  • runtime/JSString.h:

(JSC::JSString::Rope::createOrNull):
(JSC::JSString::Rope::operator new):
(JSC::JSString::value):
(JSC::JSString::tryGetValue):
(JSC::JSString::getIndex):
(JSC::JSString::getStringPropertySlot):
(JSC::JSValue::toString):

  • runtime/JSValue.h:
  • runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::NativeErrorConstructor):

  • runtime/Operations.cpp:

(JSC::JSValue::strictEqualSlowCase):

  • runtime/Operations.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):
(JSC::JSValue::strictEqual):
(JSC::jsLess):
(JSC::jsLessEq):
(JSC::jsAdd):
(JSC::concatenateStrings):

  • runtime/PropertyDescriptor.cpp:

(JSC::PropertyDescriptor::equalTo):

  • runtime/PropertyDescriptor.h:
  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncToLowerCase):
(JSC::stringProtoFuncToUpperCase):

WebCore:

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::toHTMLCanvasStyle):
(WebCore::JSCanvasRenderingContext2D::setFillColor):
(WebCore::JSCanvasRenderingContext2D::setStrokeColor):
(WebCore::JSCanvasRenderingContext2D::setShadow):

  • bindings/js/ScriptCallStack.cpp:

(WebCore::ScriptCallStack::ScriptCallStack):
(WebCore::ScriptCallStack::initialize):

  • bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::getString):

  • bindings/js/ScriptValue.h:
  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializingTreeWalker::convertIfTerminal):

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):

  • page/Console.cpp:

(WebCore::Console::addMessage):

WebKit/mac:

  • WebView/WebView.mm:

(aeDescFromJSValue):

3:03 PM Changeset in webkit [51800] by Nikolas Zimmermann
  • 249 edits
    2 adds in trunk

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Holger Hans Peter Freyther.

Turn on (SVG) Filters support, by default.
https://bugs.webkit.org/show_bug.cgi?id=32224

Only enable filters on mac for now, skipped all affected tests on the other platforms.
Will enable them one after another, to minimize breakage.

  • Configurations/FeatureDefines.xcconfig: Enable FILTERS build flag.
2:50 PM Changeset in webkit [51799] by eric@webkit.org
  • 5 edits in trunk

2009-12-07 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Some changes to ValidityState-typeMismatch-url.html.
https://bugs.webkit.org/show_bug.cgi?id=29913

  • Add more test cases Username, IPv6 address, mailto:, file:, tel:, fragment, and IDN.
  • Handle difference between KURL and KURLGoogle
  • fast/forms/ValidityState-typeMismatch-url-expected.txt:
  • fast/forms/script-tests/ValidityState-typeMismatch-url.js:

2009-12-07 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Fix a bug that KURL rejects a host name which has an IPv4 address
inside an IPv6 form like [::127.0.0.1].
https://bugs.webkit.org/show_bug.cgi?id=29913

  • platform/KURL.cpp: (WebCore::characterClassTable): Add IPv6Char to '.'.
2:43 PM Changeset in webkit [51798] by darin@chromium.org
  • 5 edits in trunk/LayoutTests

2009-12-07 Darin Fisher <darin@chromium.org>

Reviewed by Darin Adler.

http/tests/cache/subresource-failover-to-network.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=32038

Rewrite test to avoid dumpResourceLoadCallbacks, which do not
interleave predictably with the output of dumpFrameLoadCallbacks.
Other things besides resource loading can delay onload.

The newly written test uses a cookie to determine if the test has
passed.

Unskip this test for platform/win.

  • http/tests/cache/resources/subresource-failover-to-network.cgi:
  • http/tests/cache/subresource-failover-to-network-expected.txt:
  • http/tests/cache/subresource-failover-to-network.html:
  • platform/win/Skipped:
2:35 PM Changeset in webkit [51797] by ap@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32244
Test sending and receiving small WebSocket messages of different lengths

  • websocket/tests/frame-lengths-expected.txt: Added.
  • websocket/tests/frame-lengths.html: Added.
2:27 PM Changeset in webkit [51796] by beidson@apple.com
  • 2 edits in trunk/WebCore

<rdar://problem/7443417> - Closing a window opened with "New windows open with: Same Page" results in crash in ::~HistoryItem

Reviewed by Sam Weinig.

The HistoryItem copy constructor has one very specific use case - to support the feature of a WebView copying another WebView's
BackForwardList. That constructor wasn't initializing its m_document pointer, leading to this crash in the destructor.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::~HistoryItem): Change the setDocument(0) to an ASSERT that the document is already 0. A HistoryItem cannot

outlive its Document and Documents will always clear the back-pointer in their ::detach() method.

(WebCore::HistoryItem::HistoryItem): Missed the m_document initializer in the copy constructor. Also remove an invalid assertion

about the original items m_cachedPage object (which is irrelevant to the copy).

1:54 PM Changeset in webkit [51795] by dimich@chromium.org
  • 1 edit in trunk/WebCore/ChangeLog

Not reviewed - fix typo in ChangeLog.

1:52 PM Changeset in webkit [51794] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Chromium buildbots are not red when they fail
https://bugs.webkit.org/show_bug.cgi?id=32235

  • Scripts/build-webkit:
1:51 PM Changeset in webkit [51793] by dimich@chromium.org
  • 8 edits
    9 deletes in trunk/WebCore

Remove partial SharedScript implementation.
https://bugs.webkit.org/show_bug.cgi?id=32237
The patch was obtained by running "git revert" command and then un-reverting WebCore/ChangeLog.

Reviewed by Daring Adler.

  • DerivedSources.make:
  • SharedScript/SharedScriptContext.cpp: Removed.
  • SharedScript/SharedScriptContext.h: Removed.
  • SharedScript/SharedScriptContext.idl: Removed.
  • SharedScript/SharedScriptController.h: Removed.
  • SharedScript/WebKitSharedScript.cpp: Removed.
  • SharedScript/WebKitSharedScript.h: Removed.
  • SharedScript/WebKitSharedScript.idl: Removed.
  • SharedScript/WebKitSharedScriptRepository.cpp: Removed.
  • SharedScript/WebKitSharedScriptRepository.h: Removed.
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::detach):

  • dom/EventTarget.cpp:
  • dom/EventTarget.h:
  • dom/ScriptExecutionContext.h:
1:25 PM Changeset in webkit [51792] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

Typo in chromium linux builder
https://bugs.webkit.org/show_bug.cgi?id=32238

  • Scripts/webkitdirs.pm:
1:06 PM Changeset in webkit [51791] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Add two tests generating new results to gtks collection of tests doing so.

  • platform/gtk/Skipped:
1:05 PM Changeset in webkit [51790] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Nikolas Zimmermann.

https://bugs.webkit.org/show_bug.cgi?id=32226
Random crashes in WebSocket tests on Leopard Debug builbot

  • platform/network/SocketStreamHandleBase.cpp: (WebCore::SocketStreamHandleBase::close): Make sure the object still exists when setting m_state.
12:32 PM Changeset in webkit [51789] by krit@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-07 Shiki Okasaka <shiki@google.com>

Reviewed by Dirk Schulze.

Avoid zero division during SVGPaintServerPattern::setup()
https://bugs.webkit.org/show_bug.cgi?id=29912

Fix zero division bugs in SVGPaintServerPattern::setup() that occurred
if the tile of a pattern was bigger than the pattern and the pattern
size was < 0.5, and if the attribute overflow was set to visible.

Test: svg/custom/small-pattern.html

  • svg/graphics/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::setup):

2009-12-07 Dirk Schulze <krit@webkit.org>

Reviewed by Adam Barth.

If the tile of a pattern is bigger than the pattern and the
pattern size is < 0.5, the SVGPaintServer produced a division
by zero. This also only happens, if the attribute overflow is
set to visible.
This is a test with a pattern size of 0.1 and a tile size of 1.

  • svg/custom/script-tests/small-pattern.js: Added.
  • svg/custom/small-pattern-expected.txt: Added.
  • svg/custom/small-pattern.html: Added.
12:17 PM Changeset in webkit [51788] by eric@webkit.org
  • 6 edits in trunk

2009-12-07 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

fixes to build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=32179

  • DEPS:
  • WebKit.gyp:
  • gyp_webkit:

2009-12-07 Yaar Schnitman <yaar@chromium.org>

Reviewed by Darin Fisher.

fixes to build-webkit --chromium
https://bugs.webkit.org/show_bug.cgi?id=32179

  • Scripts/webkitdirs.pm:
11:46 AM Changeset in webkit [51787] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Eric Seidel <eric@webkit.org>

No review, just adding two recently approved committers.

  • Scripts/modules/committers.py:
11:36 AM Changeset in webkit [51786] by ap@apple.com
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-websocketserver: Added property svn:executable.
11:36 AM Changeset in webkit [51785] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-07 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31889

Fixed bug in handling of zero-argument constructor call.

Test: fast/canvas/webgl/bug-31889.html

  • fast/canvas/webgl/bug-31889-expected.txt: Added.
  • fast/canvas/webgl/bug-31889.html: Added.

2009-12-07 Kenneth Russell <kbr@google.com>

Reviewed by Dimitri Glazkov.

[v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31889

Fixed bug in handling of zero-argument constructor call.

Test: fast/canvas/webgl/bug-31889.html

  • bindings/v8/custom/V8WebGLArrayBufferCustom.cpp: (WebCore::CALLBACK_FUNC_DECL):
11:26 AM Changeset in webkit [51784] by kov@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed. Landing files I forgot to add to my working copy before
committing r51734.

11:22 AM Changeset in webkit [51783] by eric@webkit.org
  • 4 edits in trunk

2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32024
[GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

Fix build errors when javascript-debugger is disabled on GTK

  • GNUmakefile.am:

2009-12-07 Gyuyoung Kim <gyuyoung@gmail.com>

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32024
[GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER

Fix build errors when javascript-debugger is disabled on GTK

  • webkit/webkitwebinspector.cpp: (webkit_web_inspector_set_property): (webkit_web_inspector_get_property):
11:09 AM Changeset in webkit [51782] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Don't skip websocket/tests/url-with-credential.html, it's one of earlier tests that is
to blame.

  • platform/mac/Skipped:
11:06 AM Changeset in webkit [51781] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Steve Falkenburg.

Add one more fast/js test to the Skipped list - also due to:
https://bugs.webkit.org/show_bug.cgi?id=32228.

  • platform/win/Skipped:
10:51 AM Changeset in webkit [51780] by Nikolas Zimmermann
  • 3 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Cleaning up Skipped files in order to make more bots green, as I plan to land changes, that affect all bots (svg filters support).

Remove non-existant animations/3d directory in qt&win Skipped lists.
Skip one more test on windows (see bug #32228, already in radar, just guessing - not yet sure if it's a random crash issue though)
Skip 19 (!) tests on the Qt slave, failing since a longer time. Qt developers: Please investigate.

  • platform/qt/Skipped: Also remove some duplicates I spotted.
  • platform/win/Skipped:
10:34 AM Changeset in webkit [51779] by eric@webkit.org
  • 1 edit
    1 add in trunk/WebKitTools

2009-12-07 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Add run-webkit-websocketserver

https://bugs.webkit.org/show_bug.cgi?id=31390

  • Scripts/run-webkit-websocketserver: Added.
10:23 AM Changeset in webkit [51778] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Disable two flaky SnowLeopard tests, filed bug and notified author.

Tests "plugins/document-open.html" and "plugins/mouse-events.html" are flaky on SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=32229

  • platform/mac-snowleopard/Skipped:
10:23 AM Changeset in webkit [51777] by sfalken@apple.com
  • 4 edits in tags/Safari-532.5.1

Merge r51773.

10:22 AM Changeset in webkit [51776] by mitz@apple.com
  • 7 edits
    8 adds in trunk

WebCore: Fixed <rdar://problem/7437820> Weird selection artifacts

Reviewed by Darin Adler.

Tests: fast/repaint/block-selection-gap-stale-cache-2.html

fast/repaint/block-selection-gap-stale-cache.html

Instead of caching the block selection gaps’ bounds in the RenderView at setSelection()
time, cache them in each RenderLayer at paint time. This prevents the cache from getting
stale due to layout changes and overflow scrolling.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint): Account for overflow scroll.
(WebCore::RenderBlock::paintSelection): Update the enclosing layer’s selection gaps bounds.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::addBlockSelectionGapsBounds): Added. Updates the selection gaps
bounds to include the given rect.
(WebCore::RenderLayer::clearBlockSelectionGapsBounds): Added. Recursively clears the cached
selection gaps bounds.
(WebCore::RenderLayer::repaintBlockSelectionGaps): Added. Recursively invalidates the
selection gaps bounds.

  • rendering/RenderLayer.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::setSelection): Clear the layer-level selection gaps bounds instead
of the view-level cache.
(WebCore::RenderView::clearSelection): Changed to call repaintBlockSelectionGaps().

  • rendering/RenderView.h:

LayoutTests: Tests for <rdar://problem/7437820> Weird selection artifacts

Reviewed by Darin Adler.

  • fast/repaint/block-selection-gap-stale-cache-2.html: Added.
  • fast/repaint/block-selection-gap-stale-cache.html: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.checksum: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-2-expected.txt: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.checksum: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.png: Added.
  • platform/mac/fast/repaint/block-selection-gap-stale-cache-expected.txt: Added.
10:09 AM Changeset in webkit [51775] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed.

REGRESSION: fast/js/excessive-comma-usage.html and fast/js/math-transforms.html fail on win
https://bugs.webkit.org/show_bug.cgi?id=32228

Adding above two tests to the Skipped list on win, attempting to turn the win slave green again.

  • platform/win/Skipped:
10:06 AM Changeset in webkit [51774] by sfalken@apple.com
  • 1 copy in tags/Safari-532.5.1

New tag.

10:03 AM Changeset in webkit [51773] by sfalken@apple.com
  • 4 edits in trunk

Build fix. Be flexible about which version of ICU is used on Windows.

JavaScriptCore:

  • JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Add optional xcopy commands to copy ICU 4.2.

WebKitTools:

  • DumpRenderTree/win/DumpRenderTree.vcproj: Add optional xcopy commands to copy ICU 4.2.
9:43 AM Changeset in webkit [51772] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Remove non-existant files in gtk/Skipped list, and exclude a printing test, without results. Should turn the gtk slave green again.

  • platform/gtk/Skipped:
9:21 AM Changeset in webkit [51771] by Nikolas Zimmermann
  • 2 edits in trunk/LayoutTests

2009-12-07 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Attempt to get all mac build slaves to green again. Disable crashing test, and notify the author of it to fix it.

New test "websocket/tests/url-with-credential.html" crashes in debug builds
https://bugs.webkit.org/show_bug.cgi?id=32226

  • platform/mac/Skipped:
9:10 AM Changeset in webkit [51770] by Nikolas Zimmermann
  • 1 edit
    1 add in trunk/LayoutTests

Not reviewed. Add missing layout test result.

9:07 AM Changeset in webkit [51769] by kov@webkit.org
  • 2 edits in trunk/WebCore

2009-12-07 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

Fixed whitelist comment and removed useless (tags, sdp) mimetypes
from it. Also, GStreamer doesn't handle directly SMIL.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):
7:38 AM Changeset in webkit [51768] by eric@webkit.org
  • 4 edits in trunk

2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Eliminate the segfaults which occur when accessing the text interface now
implemented by text controls.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (getPangoLayoutForAtk):

2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25415
[GTK][ATK] Please implement support for get_text_at_offset

Eliminate the segfaults which occur when accessing the text interface now
implemented by text controls.

  • tests/testatk.c (test_webkit_atk_get_text_at_offset_textarea): (test_webkit_atk_get_text_at_offset_text_input): (main):
7:31 AM Changeset in webkit [51767] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216

Remove the calls to qWait() of the autotest of QWebView

  • tests/qwebview/tst_qwebview.cpp: (tst_QWebView::reusePage):
7:02 AM Changeset in webkit [51766] by eric@webkit.org
  • 3 edits in trunk/WebKit/chromium

2009-12-07 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

[Chromium] Add declarations for DevTools message dispatching on IO thread
(see http://codereview.chromium.org/460018)

https://bugs.webkit.org/show_bug.cgi?id=32217

  • public/WebDevToolsAgent.h:
  • public/WebDevToolsAgentClient.h:
6:52 AM Changeset in webkit [51765] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

2009-12-07 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

op_loop_if_less JIT codegen is broken for 64-bit
https://bugs.webkit.org/show_bug.cgi?id=32221

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_loop_if_false): Fix codegen in this version - test was backwards.
6:35 AM Changeset in webkit [51764] by kov@webkit.org
  • 5 edits
    6 adds in trunk

Reviewed by Xan Lopez.

Build the new API test.

[GTK] REGRESSION: webkit thinks it can render PDFs
https://bugs.webkit.org/show_bug.cgi?id=32183

  • GNUmakefile.am:

WebCore

Reviewed by Xan Lopez.

Turn the MediaPlayer supported types blacklist into a whitelist

[GTK] REGRESSION: webkit thinks it can render PDFs
https://bugs.webkit.org/show_bug.cgi?id=32183

Covered by API test.

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

WebKit/gtk

Reviewed by Xan Lopez.

New test to make sure we do not regress this feature anymore. All
test files were created by me.

[GTK] REGRESSION: webkit thinks it can render PDFs
https://bugs.webkit.org/show_bug.cgi?id=32183

  • tests/resources/test.html: Added.
  • tests/resources/test.ogg: Added.
  • tests/resources/test.pdf: Added.
  • tests/resources/test.txt: Added.
  • tests/testmimehandling.c: Added. (server_callback): (idle_quit_loop_cb): (mime_type_policy_decision_requested_cb): (test_mime_type): (test_mime_pdf): (test_mime_html): (test_mime_text): (test_mime_ogg): (main):
6:34 AM Changeset in webkit [51763] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216

Refactor tst_qwebframe to remove qWait() and use
the function waitForSignal() from util.h

  • tests/qwebframe/tst_qwebframe.cpp:
6:27 AM Changeset in webkit [51762] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

  • platform/gtk/accessibility/title-and-alt.html: Added.
  • platform/gtk/accessibility/title-and-alt-expected.txt: Added.

2009-12-07 Joanmarie Diggs <joanmarie.diggs@gmail.com>

Reviewed by Xan Lopez.

https://bugs.webkit.org/show_bug.cgi?id=25524
[Gtk] Expose the title attribute to assistive technologies

Expose 'alt' attribute from images as accessible name.
Expose the 'title' core HTML attribute as accessible description.
This is a modified version of the original fix submitted by Mario Sanchez Prada,
adjusted so that it doesn't impact other platforms.

  • accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name): (webkit_accessible_get_description):
6:13 AM Changeset in webkit [51761] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-12-07 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Improve the autotests of QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=32216

Refactor the test of QGraphicsWebView:
-make waitForSignal() available to all the tests.
-remove QTest::qWait()

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::crashOnViewlessWebPages):
  • tests/util.h: (waitForSignal):
5:50 AM Changeset in webkit [51760] by oliver@apple.com
  • 5 edits in trunk

Object.create fails if properties on the descriptor are getters
https://bugs.webkit.org/show_bug.cgi?id=32219

Reviewed by Maciej Stachowiak.

Correctly initialise the PropertySlots with the descriptor object.

5:44 AM Changeset in webkit [51759] by Girish Ramakrishnan
  • 2 edits in trunk/WebKit/qt

[Qt] Plugins: Force windowless mode when there is no native window handle

Reviewed by Simon Hausmann.

Inject wmode=opaque while instantiating the plugin for the case when the
webpage is not backed by a native window handle.

https://bugs.webkit.org/show_bug.cgi?id=32059

5:29 AM Changeset in webkit [51758] by vestbo@webkit.org
  • 4 edits in trunk/WebCore

[Qt] Fix support for generic font families

Reviewed by Simon Hausmann.

By not propagating the resolved font family in FontCacheQt and
only concidering the font description we ended up passing the
generic font families to Qt directly. Since most systems don't
have a mapping for these font families we ended up using the
default font in most cases.

  • platform/graphics/qt/FontCacheQt.cpp:
  • platform/graphics/qt/FontPlatformData.h:
  • platform/graphics/qt/FontPlatformDataQt.cpp:
5:06 AM Changeset in webkit [51757] by oliver@apple.com
  • 9 edits
    1 add in trunk

Object.getOwnPropertyDescriptor() allows cross-frame access
https://bugs.webkit.org/show_bug.cgi?id=32119

Reviewed by Maciej Stachowiak.

Make all implementations of getOwnPropertyDescriptor that have
cross domain restrictions simply fail immediately on cross domain
access, rather than trying to mimic the behaviour of normal
property access.

Test: http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html

4:36 AM Changeset in webkit [51756] by steveblock@google.com
  • 9 edits
    3 adds in trunk/WebCore

Moves JSC-specific functions from jni_utility and moves them to new jsc/jni_utility_private files.
https://bugs.webkit.org/show_bug.cgi?id=32157

Reviewed by Adam Barth.

Build fix only, no new tests.

  • WebCore.xcodeproj/project.pbxproj: Modified. Add jni_utility_private.[cpp|h].
  • bridge/jni/jni_instance.cpp: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_jsobject.mm: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_objc.mm: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_runtime.cpp: Modified. Include jni_utility_private.h for JSC.
  • bridge/jni/jni_utility.cpp: Modified. Removed convertValueToJValue and convertArrayInstanceToJavaArray.
  • bridge/jni/jni_utility.h: Modified. Removed convertValueToJValue and dispatchJNICall.
  • bridge/jni/jsc: Added.
  • bridge/jni/jsc/jni_utility_private.cpp: Added.

(JSC::Bindings::convertArrayInstanceToJavaArray):
(JSC::Bindings::convertValueToJValue):

  • bridge/jni/jsc/jni_utility_private.h: Added. Header for convertValueToJValue and dispatchJNICall.
  • platform/android/TemporaryLinkStubs.cpp: Modified. Include jni_utility_private.h for JSC.
4:04 AM Changeset in webkit [51755] by krit@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-07 Dirk Schulze <krit@webkit.org>

Not reviewed, adding myself to the reviewers list.

  • Scripts/modules/committers.py:
12:51 AM QtWebKitMediaElementSupport edited by vestbo@webkit.org
(diff)
12:50 AM QtWebKitMediaElementSupport edited by vestbo@webkit.org
(diff)
12:46 AM QtWebKitMediaElementSupport created by vestbo@webkit.org
12:46 AM QtWebKit edited by vestbo@webkit.org
(diff)

Dec 6, 2009:

11:53 PM Changeset in webkit [51754] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add an API for uploading results files to StatusBot
https://bugs.webkit.org/show_bug.cgi?id=32210

Add Content-Type: plain/text which was forgotten
from the previous commit when I landed with land-patches
instead of land-diff.

  • QueueStatusServer/queue_status.py:
11:45 PM Changeset in webkit [51753] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add an API for uploading results files to StatusBot
https://bugs.webkit.org/show_bug.cgi?id=32210

  • Scripts/modules/statusbot.py:
11:42 PM Changeset in webkit [51752] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-06 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Status Server needs a way to handle uploaded results
https://bugs.webkit.org/show_bug.cgi?id=32209

  • QueueStatusServer/queue_status.py: Add a ShowResults (results/*) command
  • QueueStatusServer/update_status.html: Add file upload.
11:06 PM Changeset in webkit [51751] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2009-12-06 Shinichiro Hamaji <hamaji@chromium.org>

Unreviewed. Revert r51748.

Bugzilla should show images in git patches
https://bugs.webkit.org/show_bug.cgi?id=31395

  • PrettyPatch/PrettyPatch.rb:
10:42 PM Changeset in webkit [51750] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] BuildAttachment should not check the builders
https://bugs.webkit.org/show_bug.cgi?id=32207

This is code that got copied here by accident when the class was created.

  • Scripts/modules/commands/download.py:
10:42 PM Changeset in webkit [51749] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Make LandingSequence.update aware of ports
https://bugs.webkit.org/show_bug.cgi?id=32208

This is required to make build work on the Chromium port because
Chromium has a custom update-webkit.

  • Scripts/modules/landingsequence.py:
10:42 PM Changeset in webkit [51748] by hamaji@chromium.org
  • 2 edits in trunk/BugsSite

2009-12-06 Shinichiro Hamaji <shinichiro.hamaji@gmail.com>

Reviewed by David Kilzer.

Bugzilla should show images in git patches
https://bugs.webkit.org/show_bug.cgi?id=31395

Show images in git patches using git-apply.

  • PrettyPatch/PrettyPatch.rb:
9:20 PM Changeset in webkit [51747] by abarth@webkit.org
  • 4 edits in trunk/WebKitTools

2009-12-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add early warning system commands to bugzilla-tool.

  • Scripts/bugzilla-tool:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/webkitport.py:
9:11 PM Changeset in webkit [51746] by abarth@webkit.org
  • 2 edits
    1 add in trunk/WebKitTools

2009-12-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement Qt EarlyWarningSystem and Chromium EarlyWarningSystem
https://bugs.webkit.org/show_bug.cgi?id=32205

  • Scripts/modules/commands/early_warning_system.py: Added.
  • Scripts/modules/commands/queues.py:
7:27 PM Changeset in webkit [51745] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

REGRESSION (r51728): update-webkit fails when the current directory is
not inside a Subversion working copy
https://bugs.webkit.org/show_bug.cgi?id=32204

Reviewed by Adele Peterson.

  • Scripts/update-webkit: Invoke isSVN() in the correct working

directory.

6:45 PM Changeset in webkit [51744] by eric@webkit.org
  • 5 edits in trunk/LayoutTests

2009-12-06 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Improve portability and readability of table-percent-height* tests.
https://bugs.webkit.org/show_bug.cgi?id=31858

The purpose of these tests is to confirm that an element with
height:N% inside a table cell has non-zero height. We don't need
to check concrete pixel sizes of form controls.

This updates the tests so that they check heights are non-zero and
75% heights are same as corresponding 100% heights or actually 75%.

  • fast/replaced/table-percent-height-expected.txt:
  • fast/replaced/table-percent-height-text-controls-expected.txt:
  • fast/replaced/table-percent-height-text-controls.html:
  • fast/replaced/table-percent-height.html:
6:19 PM Changeset in webkit [51743] by ukai@chromium.org
  • 6 edits
    8 adds in trunk/LayoutTests

2009-12-06 Fumitoshi Ukai <ukai@chromium.org>

Reviewed by Alexey Proskuryakov.

Add tests for cross-origin WebSocket usage
https://bugs.webkit.org/show_bug.cgi?id=32055

  • websocket/tests/cross-origin-expected.txt: Added.
  • websocket/tests/cross-origin.html: Added.
  • websocket/tests/fixed-origin_wsh.py: Added.
  • websocket/tests/handshake-fail-by-cross-origin-expected.txt: Added.
  • websocket/tests/handshake-fail-by-cross-origin.html: Added.
  • websocket/tests/origin-test_wsh.py: Added.
  • websocket/tests/script-tests/cross-origin.js: Added.
  • websocket/tests/script-tests/frame-length-longer-than-buffer.js:
  • websocket/tests/script-tests/frame-length-skip.js:
  • websocket/tests/script-tests/handshake-error.js:
  • websocket/tests/script-tests/handshake-fail-by-cross-origin.js: Added.
  • websocket/tests/script-tests/simple.js:
  • websocket/tests/simple-expected.txt:
5:09 PM Changeset in webkit [51742] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-06 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Rename AbstractTryQueue to AbstractReviewQueue
https://bugs.webkit.org/show_bug.cgi?id=32202

  • Scripts/modules/commands/queues.py:
9:40 AM Changeset in webkit [51741] by eric@webkit.org
  • 3 edits in trunk/WebKit/haiku

2009-12-06 Maxime Simon <Maxime Simon>

Reviewed by Adam Barth.

Build fix. Add in FrameLoaderClientHaiku the declaration of three functions introduced in r51644.

  • WebCoreSupport/FrameLoaderClientHaiku.cpp: (WebCore::FrameLoaderClientHaiku::dispatchDidPushStateWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchDidReplaceStateWithinPage): (WebCore::FrameLoaderClientHaiku::dispatchDidPopStateWithinPage):
  • WebCoreSupport/FrameLoaderClientHaiku.h:
3:37 AM Changeset in webkit [51740] by oliver@apple.com
  • 2 edits in trunk/WebCore

texImage2D pixel junk for transparency
https://bugs.webkit.org/show_bug.cgi?id=32188

Reviewed by Maciej Stachowiak

Use kCGBlendModeCopy when drawing an image to the intermediate context
used to create a GL texture.

No test as we don't currently have any mechanism to retrieve pixel data
from the webgl context.

2:30 AM Changeset in webkit [51739] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Actually tested 64-bit *and* 32-bit build this time.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_if_false):

2:09 AM Changeset in webkit [51738] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Really really fix 64-bit build for prior patch (actually tested this time).

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_loop_if_false):
(JSC::JIT::emitSlow_op_loop_if_false):

1:57 AM Changeset in webkit [51737] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Really fix 64-bit build for prior patch.

  • jit/JITArithmetic.cpp:

(JSC::JIT::emitSlow_op_jless):

1:51 AM Changeset in webkit [51736] by mjs@apple.com
  • 2 edits in trunk/JavaScriptCore

Not reviewed, build fix.

Fix 64-bit build for prior patch.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_loop_if_less):

1:42 AM Changeset in webkit [51735] by mjs@apple.com
  • 17 edits in trunk

2009-12-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

conway benchmark spends half it's time in op_less (jump fusion fails)
https://bugs.webkit.org/show_bug.cgi?id=32190

<1% speedup on SunSpider and V8
2x speedup on "conway" benchmark


Two optimizations:

1) Improve codegen for logical operators &&,
and ! in a condition context


When generating code for combinations of &&,
and !, in a

condition context (i.e. in an if statement or loop condition), we
used to produce a value, and then separately jump based on its
truthiness. Now we pass the false and true targets in, and let the
logical operators generate jumps directly. This helps in four
ways:

a) Individual clauses of a short-circuit logical operator can now
jump directly to the then or else clause of an if statement (or to
the top or exit of a loop) instead of jumping to a jump.


b) It used to be that jump fusion with the condition of the first
clause of a logical operator was inhibited, because the register
was ref'd to be used later, in the actual condition jump; this no
longer happens since a jump straight to the final target is
generated directly.

c) It used to be that jump fusion with the condition of the second
clause of a logical operator was inhibited, because there was a
jump target right after the second clause and before the actual
condition jump. But now it's no longer necessary for the first
clause to jump there so jump fusion is not blocked.

d) We avoid generating excess mov statements in some cases.


As a concrete example this source:


if (!((x < q && y < q)
(t < q && z < q))) {

...

}


Used to generate this bytecode:


[ 34] less r1, r-15, r-19
[ 38] jfalse r1, 7(->45)
[ 41] less r1, r-16, r-19
[ 45] jtrue r1, 14(->59)
[ 48] less r1, r-17, r-19
[ 52] jfalse r1, 7(->59)
[ 55] less r1, r-18, r-19
[ 59] jtrue r1, 17(->76)


And now generates this bytecode (also taking advantage of the second optimization below):


[ 34] jnless r-15, r-19, 8(->42)
[ 38] jless r-16, r-19, 26(->64)
[ 42] jnless r-17, r-19, 8(->50)
[ 46] jless r-18, r-19, 18(->64)


Note the jump fusion and the fact that there's less jump
indirection - three of the four jumps go straight to the target
clause instead of indirecting through another jump.


2) Implement jless opcode to take advantage of the above, since we'll now often generate
a less followed by a jtrue where fusion is not forbidden.


  • parser/Nodes.h: (JSC::ExpressionNode::hasConditionContextCodegen): Helper function to determine whether a node supports special conditional codegen. Return false as this is the default. (JSC::ExpressionNode::emitBytecodeInConditionContext): Assert not reached - only really defined for nodes that do have conditional codegen. (JSC::UnaryOpNode::expr): Add const version. (JSC::LogicalNotNode::hasConditionContextCodegen): Returne true only if subexpression supports it. (JSC::LogicalOpNode::hasConditionContextCodegen): Return true.
  • parser/Nodes.cpp: (JSC::LogicalNotNode::emitBytecodeInConditionContext): Implemented - just swap the true and false targets for the child node. (JSC::LogicalOpNode::emitBytecodeInConditionContext): Implemented - handle jumps directly, improving codegen quality. Also handles further nested conditional codegen. (JSC::ConditionalNode::emitBytecode): Use condition context codegen when available. (JSC::IfNode::emitBytecode): ditto (JSC::IfElseNode::emitBytecode): ditto (JSC::DoWhileNode::emitBytecode): ditto (JSC::WhileNode::emitBytecode): ditto (JSC::ForNode::emitBytecode): ditto
  • bytecode/Opcode.h:
  • Added loop_if_false opcode - needed now that falsey jumps can be backwards.
  • Added jless opcode to take advantage of new fusion opportunities.
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): Handle above.
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitJumpIfTrue): Add peephole for less + jtrue ==> jless. (JSC::BytecodeGenerator::emitJumpIfFalse): Add handling of backwrds falsey jumps.
  • bytecompiler/BytecodeGenerator.h: (JSC::BytecodeGenerator::emitNodeInConditionContext): Wrapper to handle tracking of overly deep expressions etc.
  • interpreter/Interpreter.cpp: (JSC::Interpreter::privateExecute): Implement the two new opcodes (loop_if_false, jless).
  • jit/JIT.cpp: (JSC::JIT::privateCompileMainPass): Implement JIT support for the two new opcodes. (JSC::JIT::privateCompileSlowCases): ditto
  • jit/JIT.h:
  • jit/JITArithmetic.cpp: (JSC::JIT::emit_op_jless): (JSC::JIT::emitSlow_op_jless): ditto (JSC::JIT::emitBinaryDoubleOp): ditto
  • jit/JITOpcodes.cpp: (JSC::JIT::emitSlow_op_loop_if_less): ditto (JSC::JIT::emit_op_loop_if_false): ditto (JSC::JIT::emitSlow_op_loop_if_false): ditto
  • jit/JITStubs.cpp:
  • jit/JITStubs.h: (JSC::):

2009-12-05 Maciej Stachowiak <mjs@apple.com>

Reviewed by Oliver Hunt.

conway benchmark spends half it's time in op_less (jump fusion fails)
https://bugs.webkit.org/show_bug.cgi?id=32190

  • fast/js/codegen-loops-logical-nodes-expected.txt:
  • fast/js/script-tests/codegen-loops-logical-nodes.js: Update to test some newly sensitive cases of codegen that were not already covered.

Dec 5, 2009:

5:50 PM Changeset in webkit [51734] by kov@webkit.org
  • 11 edits in trunk

WebCore

2009-12-03 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

Advertize audio/ogg correctly and refactored mime-type cache
building.

[GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990

Test: media/media-can-play-ogg.html

  • platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::mimeTypeCache):

LayoutTests

2009-12-05 Philippe Normand <pnormand@igalia.com>

Reviewed by Gustavo Noronha.

New test for video.canPlayType and ogg containers.

[GTK] Recognize oga as audio/ogg
https://bugs.webkit.org/show_bug.cgi?id=31990

  • media/media-can-play-ogg-expected.txt: Added.
  • media/media-can-play-ogg.html: Added.
  • platform/mac-leopard/Skipped:
  • platform/mac-snowleopard/Skipped:
  • platform/mac-tiger/Skipped:
  • platform/mac/Skipped:
  • platform/qt-mac/Skipped:
  • platform/qt-win/Skipped:
  • platform/qt/Skipped:
  • platform/win/Skipped:
4:30 PM Changeset in webkit [51733] by eric@webkit.org
  • 7 edits
    1 add in trunk/WebKitSite

2009-12-05 Chris Jerdonek <chris.jerdonek@gmail.com>

Reviewed by Darin Adler.

Refactored web site documentation so that advice to add
WebKitTools/Scripts to your shell path does not appear
on multiple pages.

https://bugs.webkit.org/show_bug.cgi?id=32112

  • building/build.html:
  • building/checkout.html:
  • building/run.html:
  • coding/coding-style.html:
  • coding/contributing.html:
  • coding/scripts.html: Added.
  • quality/testing.html:
3:59 PM Changeset in webkit [51732] by ap@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Eric Seidel.

https://bugs.webkit.org/show_bug.cgi?id=32175
REGRESSION: websocket/tests/url-parsing.html is crashing on Leopard Bot

  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::readStreamCallback): Call platformClose() to unschedule both streams, guaranteeing that there will be no callbacks after SocketStreamHandle is destroyed. (WebCore::SocketStreamHandle::writeStreamCallback): Edited a comment a bit.
3:44 PM Changeset in webkit [51731] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

Disabled a test because it puts the WebView into compositing mode,
which remains in effect for all subsequent repaint tests, causing them
to fail because DumpRenderTree always forces a full repaint when
generating the image of a WebView that is in compositing mode.

  • fast/repaint/block-selection-gap-in-composited-layer.html: Removed.
  • fast/repaint/block-selection-gap-in-composited-layer.html.disabled: Copied from LayoutTests/fast/repaint/block-selection-gap-in-composited-layer.html.
1:55 PM Changeset in webkit [51730] by abarth@webkit.org
  • 3 edits in trunk/WebKitTools

2009-12-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

[bzt] Implement ChromiumPort
https://bugs.webkit.org/show_bug.cgi?id=32182

  • Scripts/modules/webkitport.py:
  • Scripts/modules/webkitport_unittest.py:
1:54 PM Changeset in webkit [51729] by abarth@webkit.org
  • 6 edits in trunk/WebKitTools

2009-12-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move update-webkit into BuildSteps
https://bugs.webkit.org/show_bug.cgi?id=32181

We need to move update-webkit out of SCM.py because SCM isn't supposed to know
that WebKit exists. The proper place for the knowledge of the existence of
update-webkit is in WebKitPort because some ports have specialized update
scripts (analogous to build-webkit).

  • Scripts/modules/buildsteps.py:
  • Scripts/modules/commands/download.py:
  • Scripts/modules/landingsequence.py:
  • Scripts/modules/scm.py:
  • Scripts/modules/webkitport.py:
1:54 PM Changeset in webkit [51728] by abarth@webkit.org
  • 2 edits in trunk/WebKitTools

2009-12-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

update-webkit should call git svn rebase and resolve-ChangeLogs -f
https://bugs.webkit.org/show_bug.cgi?id=27162

Teach update-webkit about Git. I didn't add the call to
resolve-ChangeLogs -f because sometimes that script goes bananas. We
can iterate from here, however.

  • Scripts/update-webkit:
9:50 AM Changeset in webkit [51727] by abarth@webkit.org
  • 3 edits
    2 adds in trunk

2009-12-05 Adam Langley <agl@google.com>

Reviewed by Adam Barth.

Check that a CSS format() argument is of a valid type.

https://bugs.webkit.org/show_bug.cgi?id=31815
http://code.google.com/p/chromium/issues/detail?id=28582

  • fast/css/url-format-non-string-expected.txt: Added
  • fast/css/url-format-non-string.html: Added.

2009-12-05 Adam Langley <agl@google.com>

Reviewed by Adam Barth.

Check that a CSS format() argument is of a valid type.

https://bugs.webkit.org/show_bug.cgi?id=31815
http://code.google.com/p/chromium/issues/detail?id=28582

Test: fast/css/url-format-non-string.html

  • css/CSSParser.cpp: (WebCore::CSSParser::parseFontFaceSrc):
8:56 AM Changeset in webkit [51726] by kov@webkit.org
  • 2 edits in trunk/WebKit/gtk

Reviewed by Xan Lopez.

Use a better URI for the unreachable test. localhost:80 is very
likely to be open.

  • tests/testwebdatasource.c:

(load_finished_unreachable_cb):
(test_webkit_web_data_source_unreachable_uri):

7:35 AM Changeset in webkit [51725] by kov@webkit.org
  • 2 edits in trunk

2009-12-05 Vincent Untz <vuntz@gnome.org>

Reviewed by Gustavo Noronha.

Fixes race for builds with introspection enabled, and parallel
make.

  • GNUmakefile.am:

Dec 4, 2009:

5:21 PM Changeset in webkit [51724] by eric@webkit.org
  • 3 edits
    3 adds in trunk

2009-12-04 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

JavaScript delete operator should return false for string properties
https://bugs.webkit.org/show_bug.cgi?id=32012

  • runtime/StringObject.cpp: (JSC::StringObject::deleteProperty):

2009-12-04 Kent Hansen <kent.hansen@nokia.com>

Reviewed by Darin Adler.

Add test for JavaScript string property deletion
https://bugs.webkit.org/show_bug.cgi?id=32012

  • fast/js/script-tests/string-property-deletion.js: Added.
  • fast/js/string-property-deletion-expected.txt: Added.
  • fast/js/string-property-deletion.html: Added.
4:46 PM Changeset in webkit [51723] by eric@webkit.org
  • 3 edits in trunk/WebKitSite

2009-12-04 Marc-Antoine Ruel <maruel@chromium.org>

Reviewed by Eric Seidel.

Add reference to the GTK and QT build wiki pages

https://bugs.webkit.org/show_bug.cgi?id=32088

  • building/tools.html:
  • css/main.css:
4:39 PM Changeset in webkit [51722] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Adam Langley <agl@google.com>

Reviewed by Eric Seidel.

Chromium: make rounded borders heavier.

Skia draws its rounded corners differently from the other ports.
Whereas they have anti-aliased clipping regions, Skia only has 1-bit
regions. (Which is technically more correct, but somewhat unhelpful
for us.) Instead, with Skia we use a layer and collect all the
clipping paths in effect. When the state is popped, we paint
transparency outside the clipping paths and merge the layer down.

This appears to cause rounded borders to look a little thin, which is
addressed in this patch.

This is well covered by existing tests but will require new baselines
in the Chromium tree.

https://bugs.webkit.org/show_bug.cgi?id=31778

  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::addInnerRoundedRectClip):
4:31 PM Changeset in webkit [51721] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-04 Yuzo Fujishima <yuzo@google.com>

Reviewed by Alexey Proskuryakov.

Add test for web socket send.

https://bugs.webkit.org/show_bug.cgi?id=31337

  • websocket/tests/script-tests/send.js: Added. (endTest): (ws.onopen): (ws.onmessage.ws.onmessage): (ws.onmessage): (ws.onclose): (timeOutCallback):
  • websocket/tests/send-expected.txt: Added.
  • websocket/tests/send.html: Added.
  • websocket/tests/send_wsh.py: Added.
4:24 PM Changeset in webkit [51720] by eric@webkit.org
  • 3 edits
    3 adds in trunk/WebKit/chromium

2009-12-04 James Hawkins <jhawkins@chromium.org>

Reviewed by Darin Fisher.

https://bugs.webkit.org/show_bug.cgi?id=32095
Implement WebRegularExpression, a WebKit API for accessing
WebCore::RegularExpression.

  • WebKit.gyp:
  • public/WebRegularExpression.h: Added.
  • public/WebTextCaseSensitivity.h: Added. (WebKit::):
  • src/AssertMatchingEnums.cpp:
  • src/WebRegularExpression.cpp: Added. (WebKit::WebRegularExpression::WebRegularExpression): (WebKit::WebRegularExpression::~WebRegularExpression): (WebKit::WebRegularExpression::match):
3:56 PM Changeset in webkit [51719] by pkasting@chromium.org
  • 4 edits in trunk/WebKit/chromium

[Chromium] Simplify zoom-related APIs and add a zoom level getter,
part two: Remove deprecated APIs.
https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

  • public/WebView.h:
  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
3:18 PM Changeset in webkit [51718] by Simon Fraser
  • 3 edits
    2 adds in trunk

2009-12-04 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/7441571> Hardware-backed layers are skipped when printing

When printing, set the PaintBehaviorFlattenCompositingLayers flag so that compositing layers
paint. This also causes 3D transforms to be flattened to 2D.

Test: printing/compositing-layer-printing.html

  • page/FrameView.cpp: (WebCore::FrameView::paintContents):
3:13 PM Changeset in webkit [51717] by oliver@apple.com
  • 2 edits in trunk/WebCore

Fix up some issues in my SVGListTraits change from yesterday.

Reviewed by Deth Bakin

2:10 PM Changeset in webkit [51716] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip test that is failing because of new behaviour enforced by
libsoup. Bug reported.

  • platform/gtk/Skipped:
2:00 PM Changeset in webkit [51715] by kenneth@webkit.org
  • 5 edits in trunk/WebKitTools

Add some missing methods for showing and hiding the
Web Inspector.

Reviewed by Adam Treat.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::WebPage):
(WebCore::WebPage::~WebPage):
(WebCore::WebPage::webInspector):

  • DumpRenderTree/qt/DumpRenderTree.h:
  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::showWebInspector):
(LayoutTestController::hideWebInspector):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:
1:54 PM Changeset in webkit [51714] by kov@webkit.org
  • 2 edits in trunk/LayoutTests

Skip tests that require support for frame loader callbacks
reporting, and a new test.

  • platform/gtk/Skipped:
1:45 PM BuildBot edited by maruel@chromium.org
(diff)
1:35 PM Changeset in webkit [51713] by yael.aharon@nokia.com
  • 2 edits in trunk/WebKitTools

Unreviewed build fix.

[Qt] build fix after r51634 removed unused QBoxLayout include which included limits.h.

  • DumpRenderTree/qt/DumpRenderTree.cpp:
1:19 PM Changeset in webkit [51712] by krit@webkit.org
  • 1 edit
    1 move in trunk/LayoutTests

2009-12-04 Dirk Schulze <krit@webkit.org>

Reviewed by Gustavo Noronha Silva.

Move the render result to svg/custom as a cross platform render result.

  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Removed.
  • svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
1:13 PM Changeset in webkit [51711] by ajwong@chromium.org
  • 2 edits in trunk/WebCore

Not reviewed: chromium build fix.

Fix Chromium build break caused by moving of isDefaultPortForProtocol() and
portAllowed() into KURL.h/KURL.cpp. Cloning code.

  • platform/KURLGoogle.cpp:

(WebCore::isDefaultPortForProtocol):
(WebCore::portAllowed):

1:03 PM Changeset in webkit [51710] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Remove suppress highlight when restoring selected node.

https://bugs.webkit.org/show_bug.cgi?id=32152

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.setDocument.selectNode): (WebInspector.ElementsPanel.prototype.setDocument.selectLastSelectedNode): (WebInspector.ElementsPanel.prototype.setDocument):
1:01 PM Changeset in webkit [51709] by kenneth@webkit.org
  • 6 edits in trunk

WebKitTools: Implement the setAllowUniversalAccessFromFileURLs method
for the Qt LayoutTestController.

Reviewed by Adam Treat.

  • DumpRenderTree/qt/DumpRenderTree.cpp:

(WebCore::WebPage::resetSettings):

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::setAllowUniversalAccessFromFileURLs):

  • DumpRenderTree/qt/LayoutTestControllerQt.h:

LayoutTests: Remove test that works after adding setAllowUniversalAccessFromFileURLs
to Qt's version of the LayoutTestController.

Reviewed by Adam Treat.

  • platform/qt/Skipped:
12:50 PM BuildBot edited by maruel@chromium.org
(diff)
12:24 PM BuildBot edited by maruel@chromium.org
(diff)
12:19 PM Changeset in webkit [51708] by krit@webkit.org
  • 5 edits
    4 adds in trunk

2009-12-04 Dirk Schulze <krit@webkit.org>

Reviewed by Nikolas Zimmermann.

Gradient SVG animation demonstrates tearing at animation extremes
https://bugs.webkit.org/show_bug.cgi?id=11929

The focalPoint of a radial gradient is temporarly substracted by
the centralPoint, if the focalPoint is not in the radius of the
gradient. This is needed to calculate a new postion of the focalPoint
according to the specification. But the new focalPoint needs to be
moved by the centralPoint after this calculation, which is not the case
at the moment. This patch fixes this issue. It was also introduced a
deviation of maximal 0.2% for Cairo to get around the fixed point numbers
in Cairo.

W3C-SVG-1.1/pservers-grad-13-b needed an update. The missing adjustment
of the new focalPoint caused wrong results for the last three tests.

Test: svg/custom/radial-gradient-with-outstanding-focalPoint.svg

  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):

Gradient SVG animation demonstrates tearing at animation extremes
https://bugs.webkit.org/show_bug.cgi?id=11929

In SVG a focalPoint must be inside the radius of a radial gradient.
It this isn't the case, we have to move the focalPoint into the radius.
This checks the correct behavior of WebKit on false values for fx, fy.

  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.checksum:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.png:
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.checksum: Added.
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.png: Added.
  • platform/mac/svg/custom/radial-gradient-with-outstanding-focalPoint-expected.txt: Added.
  • svg/custom/radial-gradient-with-outstanding-focalPoint.svg: Added.
12:16 PM Changeset in webkit [51707] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Anton Muhin <antonm@chromium.org>

Reviewed by Dmitry Titov.

Do not use WebCore::String::String(const UChar*, int length) to convert
short v8 strings.

Plus added string traits.
https://bugs.webkit.org/show_bug.cgi?id=31415

  • bindings/v8/V8Binding.cpp: (WebCore::): (WebCore::v8StringToWebCoreString):
12:04 PM Changeset in webkit [51706] by Chris Fleizach
  • 12 edits
    2 adds in trunk

REGRESSION: AX: buttons now extremely repetitive
https://bugs.webkit.org/show_bug.cgi?id=32164

Reviewed by Darin Adler.

WebCore:

Test: platform/mac/accessibility/button-shouldnot-have-axvalue.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isButton):

  • accessibility/mac/AccessibilityObjectWrapper.mm:

(-[AccessibilityObjectWrapper accessibilityAttributeNames]):

WebKitTools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(isAttributeSupportedCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:

(AccessibilityUIElement::isAttributeSupported):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isAttributeSupported):

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::isAttributeSupported):

LayoutTests:

  • platform/mac-leopard/accessibility/table-with-aria-role-expected.txt:
  • platform/mac/accessibility/button-shouldnot-have-axvalue-expected.txt: Added.
  • platform/mac/accessibility/button-shouldnot-have-axvalue.html: Added.
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
12:01 PM Changeset in webkit [51705] by eric@webkit.org
  • 2 edits in trunk/WebCore

2009-12-04 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>

Reviewed by Darin Adler.

Check whether the right side of a string append is non-empty
https://bugs.webkit.org/show_bug.cgi?id=32151

Especially beneficial for CachedScript::script() method
which usually appends an empty string returned by flush()
to its m_script member. m_script is often hundreds of kbytes
which is duplated without reason.

  • platform/text/String.cpp: (WebCore::String::append):
11:51 AM BuildBot edited by maruel@chromium.org
(diff)
11:49 AM Changeset in webkit [51704] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Mail.app crashes when indenting table pasted from Numbers.app.
<rdar://problem/7209507>
https://bugs.webkit.org/show_bug.cgi?id=32166

Reviewed by John Sullivan.

WebCore:

Test: LayoutTests/editing/execCommand/indent-partial-table.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::indentRegion): Added test to verify that the end of the paragraph
after the selection has not been moved.

LayoutTests:

  • editing/execCommand/indent-partial-table-expected.txt: Added.
  • editing/execCommand/indent-partial-table.html: Added.
11:16 AM Changeset in webkit [51703] by ap@apple.com
  • 9 edits
    3 adds in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=32085
WebSocket should block the same ports that are blocked for resource loading

Test: websocket/tests/url-parsing.html

  • page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::localURLSchemes):
  • page/SecurityOrigin.h: Move isDefaultPortForProtocol() to KURL, because that's a better place for it (SecurityOrigin is not even in WebCore/platform directory).
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::host): (WebCore::HTMLAnchorElement::setHost): (WebCore::HTMLAnchorElement::setPort): Updated for the new location of isDefaultPortForProtocol().
  • platform/KURL.cpp: (WebCore::KURL::protocolIs): In an assertion, compare to "javascript" case-insensitively, since the function deosn't require lower case input. (WebCore::isDefaultPortForProtocol): Moved from SecurityOrigin. (WebCore::portAllowed): Moved from ResourceHandle.
  • platform/KURL.h:
  • platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::create): Updated for the new location of portAllowed().
  • websockets/WebSocket.cpp: (WebCore::WebSocket::connect): Per the spec, raise a SECURITY_ERR if trying to connect to a blocked port.
10:12 AM Changeset in webkit [51702] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Corrects QtLauncher style

  • QtLauncher/main.cpp: (WebPage::acceptNavigationRequest): (MainWindow::MainWindow): (MainWindow::webPage): (MainWindow::webView): (MainWindow::changeLocation): (MainWindow::loadFinished): (MainWindow::showLinkHover): (MainWindow::zoomIn): (MainWindow::zoomOut): (MainWindow::print): (MainWindow::setEditable): (MainWindow::dumpHtml): (MainWindow::selectElements): (MainWindow::newWindow): (MainWindow::setupUI): (WebPage::createWindow): (WebPage::createPlugin): (main):
10:04 AM Changeset in webkit [51701] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QtLauncher: add a menu to show or hide the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=32149

  • QtLauncher/main.cpp: (WebInspector::WebInspector): (WebInspector::showEvent): (WebInspector::hideEvent): (MainWindow::MainWindow): (MainWindow::setupUI):
9:57 AM Changeset in webkit [51700] by eric@webkit.org
  • 6 edits in trunk/LayoutTests

2009-12-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443

Update the test results for the new FontCache implementation.

  • platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/qt/css1/font_properties/font_variant-expected.txt:
  • platform/qt/css1/pseudo/firstline-expected.txt:
  • platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
9:50 AM Changeset in webkit [51699] by eric@webkit.org
  • 6 edits
    1 delete in trunk/WebCore

2009-12-04 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443

Remove FontFallbackListQt and rely on the common FontFallbackList
to handle the fonts. FontCache and FontPlatformData have been
updated to work with the common FontFallbackList.

In the previous implementation, FontPlatformDataCacheKey
was a clone of FontPlatformData with the hashing
capabilities added in order to use it as a key in the cache's
hashmap. FontPlatformData has been modified to handle the hashing
function directly so the data are not copied twice in memory.

FontFallbackList::fontDataAt() from FontFallbackListQt was a copy of
code from FontCache::getFontData() and FontFallbackList::fontDataAt().
The behavior is similar except currFamily->family().length() was
not tested and the fallback fonts selector were not used.

Existing tests cover the change.

  • WebCore.pro:
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::getTraitsInFamily): (WebCore::FontCache::createFontPlatformData):
  • platform/graphics/qt/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData):
  • platform/graphics/qt/FontFallbackListQt.cpp: Removed. We now use the implementation from FontFallbackList.cpp
  • platform/graphics/qt/FontPlatformData.h: Add hashing capabilities to be able to use the data with the FontCache. This was previously done in FontCacheQt.cpp (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isHashTableDeletedValue): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::family): (WebCore::FontPlatformData::bold): (WebCore::FontPlatformData::italic): (WebCore::FontPlatformData::smallCaps): (WebCore::FontPlatformData::pixelSize):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::operator==): (WebCore::FontPlatformData::hash):
9:43 AM Changeset in webkit [51698] by eric@webkit.org
  • 3 edits in trunk/WebKit/qt

2009-12-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Antti Koivisto.

Split out the renderPrivate in two methods, one for working on
relative coordinates (relative to the viewport) and one for
working on absolute coordinates. The latter is more effecient
for implementing tiling, as you don't need translate the coords,
and because it avoid clipping to the viewport.

No behaviour changes, so no new tests.

  • Api/qwebframe.cpp: (QWebFramePrivate::renderContentsLayerAbsoluteCoords): (QWebFramePrivate::renderRelativeCoords): (QWebFrame::render):
  • Api/qwebframe_p.h:
9:14 AM Changeset in webkit [51697] by treat@webkit.org
  • 2 edits in trunk/WebCore

Fix wrong assert that was only working through sheer luck.
https://bugs.webkit.org/show_bug.cgi?id=32162

Patch by Adam Treat <atreat@rim.com> on 2009-12-04
Reviewed by Dan Bernstein.

  • platform/text/BidiContext.cpp:

(WebCore::BidiContext::create):

7:36 AM Changeset in webkit [51696] by vestbo@webkit.org
  • 4 edits in trunk

[Qt] Allow removing 'qrc' as a local security origin scheme

Reviewed by Simon Hausmann.

WebCore:

  • page/SecurityOrigin.cpp:

WebKit/qt:

  • tests/qwebpage/tst_qwebpage.cpp:
7:36 AM Changeset in webkit [51695] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

[Qt] Clean up argument parsing in the QtLauncher

Reviewed by Simon Hausmann.

  • QtLauncher/main.cpp:
5:43 AM QtWebKitBackportingFixes edited by Simon Hausmann
(diff)
4:56 AM Changeset in webkit [51694] by eric@webkit.org
  • 2 edits in trunk/WebKit/qt

2009-12-04 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Prevent the inspector from closing its wrapping widget.
This is not necessary anymore since we now hide the embedded
close button.
https://bugs.webkit.org/show_bug.cgi?id=32149

  • WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::showWindow): (WebCore::InspectorClientQt::closeWindow):
4:07 AM Changeset in webkit [51693] by zoltan@webkit.org
  • 2 edits in trunk/WebCore

Allow custom memory allocation control for WebCore's CollectionCache
https://bugs.webkit.org/show_bug.cgi?id=32109

Reviewed by Eric Seidel.

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

struct name - instantiated at: WebCore/'location'

struct CollectionCache - dom/Document.cpp:4029

  • html/CollectionCache.h:
3:30 AM Changeset in webkit [51692] by eric@webkit.org
  • 4 edits
    6 adds in trunk

2009-12-04 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks.
https://bugs.webkit.org/show_bug.cgi?id=32111

  • fast/dom/Geolocation/resources/permission-denied-already-clear-watch.js: Added. Tests clearing the watch from the error callback after a permission denied message when permissions have already been denied.
  • fast/dom/Geolocation/permission-denied-already-clear-watch.html: Added. HTML wrapper for above test.
  • fast/dom/Geolocation/permission-denied-already-clear-watch-expected.txt: Added. Expected result for above test.
  • fast/dom/Geolocation/resources/timeout-clear-watch.js: Added. Tests clearing the watch from the error callback due to a timeout.
  • fast/dom/Geolocation/timeout-clear-watch.html: Added. HTML wrapper for above test.
  • fast/dom/Geolocation/timeout-clear-watch-expected.txt: Added. Expected result for above test.
  • platform/gtk/Skipped: Modified. Skips new tests.

2009-12-04 Steve Block <steveblock@google.com>

Reviewed by Darin Adler.

Fixes a crashing bug in Geolocation when a watch is cleared from some callbacks.
https://bugs.webkit.org/show_bug.cgi?id=32111

In Geolocation::GeoNotifier::timerFired, a JS callback may be invoked if a
fatal error was registered on this GeoNotifier or if this request has timed
out. If the request is a watch, and is cleared by a call to clearWatch in the
callback, the GeoNotifier object will be destroyed. We must therefore cache the
m_geolocation member to allow us to call Geolocation::fatalErrorOccurred or
Geolocation::requestTimedOut.

Tests: fast/dom/Geolocation/permission-denied-already-clear-watch.html

fast/dom/Geolocation/timeout-clear-watch.html

  • page/Geolocation.cpp: Modified. (WebCore::Geolocation::GeoNotifier::timerFired): Modified. Cache the m_geolocation member before invoking the JS callback.
2:37 AM Changeset in webkit [51691] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Re-enable audio/video tests after updated buildbot's Qt
to Phonon supported one, and put 2 bad tests into skiplist.

Reviewed by Simon Hausmann.

  • platform/qt/Skipped:
2:33 AM Changeset in webkit [51690] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

Allow custom memory allocation control for 2 classes of the platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Reviewed by Eric Seidel.

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SharedTimer - (its child class) workers/WorkerRunLoop.cpp:91

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class TransformOperations - rendering/style/RenderStyle.h:1175

Noncopyable.h's include added to SharedTimer.h.

  • platform/SharedTimer.h:
  • platform/graphics/transforms/TransformOperations.h:
2:18 AM Changeset in webkit [51689] by xan@webkit.org
  • 4 edits in trunk

2009-12-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846

Bump libsoup required version to 2.29.3 for DNS prefetching.

  • configure.ac:

WebCore:

2009-12-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846

Enable DNS prefetching.

Based on a patch by José Millán.

  • platform/network/soup/DNSSoup.cpp: (WebCore::prefetchDNS):
12:56 AM Changeset in webkit [51688] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

Roll out r51687 because it breaks the Leopard builds.

12:38 AM Changeset in webkit [51687] by zoltan@webkit.org
  • 3 edits in trunk/WebCore

2009-12-04 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for 2 classes of the platform directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following class from Noncopyable because it is instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

class SharedTimer - (its child class) workers/WorkerRunLoop.cpp:91

Inherits the following class from FastAllocBase because it is
instantiated by 'new':

class TransformOperations - rendering/style/RenderStyle.h:1175

  • platform/SharedTimer.h:
  • platform/graphics/transforms/TransformOperations.h:
12:25 AM Changeset in webkit [51686] by eric@webkit.org
  • 1 edit
    4 adds in trunk/LayoutTests

2009-12-04 Yuzo Fujishima <yuzo@google.com>

Reviewed by Darin Fisher.

Add test to see if unicode messages can be sent over web socket.

https://bugs.webkit.org/show_bug.cgi?id=31341

  • websocket/tests/script-tests/unicode.js: Added. (endTest): (ws.onopen): (ws.onmessage): (ws.onclose): (timeOutCallback):
  • websocket/tests/unicode-expected.txt: Added.
  • websocket/tests/unicode.html: Added.
  • websocket/tests/unicode_wsh.py: Added.
12:15 AM Changeset in webkit [51685] by zoltan@webkit.org
  • 5 edits in trunk/WebCore

2009-12-04 Zoltan Horvath <zoltan@webkit.org>

Reviewed by Eric Seidel.

Allow custom memory allocation control for the svg directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following classes from Noncopyable because these are instantiated
by 'new' and no need to be copyable:

class/struct name - instantiated at: WebCore/'location'

struct ResourceSet - svg/graphics/SVGResource.cpp:148
class SVGFontData - css/CSSFontFaceSource.cpp:156
class SVGDocumentExtensions - dom/Document.cpp:3962
class SVGViewSpec - svg/SVGSVGElement.cpp:191

  • svg/SVGDocumentExtensions.h:
  • svg/SVGFontData.h:
  • svg/SVGViewSpec.h:
  • svg/graphics/SVGResource.cpp:
Note: See TracTimeline for information about the timeline view.