Timeline
Aug 7, 2010:
- 11:58 PM Changeset in webkit [64942] by
-
- 2 edits in trunk/WebCore
2010-08-07 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Empty strings can have more than one ref
https://bugs.webkit.org/show_bug.cgi?id=43666
These asserts are trying to say that we have a thread-safe copy of the
string, but they're not accurate for empty strings because we use a
special static empty string that magically has infinite refs.
- storage/OriginUsageRecord.cpp: (WebCore::OriginUsageRecord::addDatabase): (WebCore::OriginUsageRecord::markDatabase):
- 11:45 PM Changeset in webkit [64941] by
-
- 3 edits in trunk/WebCore
2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[WML] Add KURL parameter to WMLDocument::create()
https://bugs.webkit.org/show_bug.cgi?id=43173
To fix build break in WML, url parameter is added. Because,
Document class has url parameter.
- wml/WMLDocument.cpp: (WebCore::WMLDocument::WMLDocument):
- wml/WMLDocument.h: (WebCore::WMLDocument::create): Add an url parameter to create() method
- 11:32 PM Changeset in webkit [64940] by
-
- 2 edits in trunk/WebCore
2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[WML] Change getIDAttribute() with getIdAttribute()
https://bugs.webkit.org/show_bug.cgi?id=43175
Change getIDAttribute() with getIdAttribute() because function
name was changed.
- wml/WMLCardElement.cpp: (WebCore::WMLCardElement::findNamedCardInDocument): Change getIDAttribute() with getIdAttribute().
- 11:19 PM Changeset in webkit [64939] by
-
- 5 edits3 adds in trunk
2010-08-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
WebTiming does not take page cache into account
https://bugs.webkit.org/show_bug.cgi?id=42772
Adds tests that simulates flow from a page that's in the page cache to
one that's not, and then back to the page cached page (where the
DocumentLoader is reused, but we should have a new DocumentLoadTiming
struct).
- fast/events/onunload-back-to-page-cache-expected.txt: Added.
- fast/events/onunload-back-to-page-cache.html: Added.
2010-08-07 Mihai Parparita <mihaip@chromium.org>
Reviewed by Adam Barth.
WebTiming does not take page cache into account
https://bugs.webkit.org/show_bug.cgi?id=42772
When restoring a page from the page cache, reset its DocumentLoadTiming
struct and record navigationStart.
Test: fast/events/onunload-back-to-page-cache.html
- loader/DocumentLoadTiming.h: removed Noncopyable, since it's just a simple struct.
- loader/DocumentLoader.h: (WebCore::DocumentLoader::resetTiming): Added method.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading): Uncommented assert. (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): Added resetTiming() call.
- 11:04 PM Changeset in webkit [64938] by
-
- 21 edits1 add in trunk/JavaScriptCore
2010-08-07 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Geoffrey Garen.
The JIT code contains a number of direct references to GC'd objects.
When we have movable objects, these references will need to be
updated.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h: (JSC::AbstractMacroAssembler::int32AtLocation): (JSC::AbstractMacroAssembler::pointerAtLocation): (JSC::AbstractMacroAssembler::jumpTarget):
- assembler/MacroAssembler.h: (JSC::MacroAssembler::loadPtrWithPatch):
Normally, loadPtr will optimize when the register is eax. Since
the slightly smaller instruction changes the offsets, it messes up
our ability to repatch the code. We added this new instruction
that garuntees a constant size.
- assembler/MacroAssemblerX86.h: (JSC::MacroAssemblerX86::load32WithPatch):
Changed load32 in the same way described above.
(JSC::MacroAssemblerX86::load32):
Moved the logic to optimize laod32 from movl_mr to load32
(JSC::MacroAssemblerX86::store32):
Moved the logic to optimize store32 from movl_rm to store32
- assembler/X86Assembler.h: (JSC::X86Assembler::movl_rm): (JSC::X86Assembler::movl_mr): (JSC::X86Assembler::int32AtLocation): (JSC::X86Assembler::pointerAtLocation): (JSC::X86Assembler::jumpTarget):
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
- bytecode/Instruction.h:
As described in StructureStubInfo.h, we needed to add additional
fields to both StructureStubInfo and
PolymorphicAccessStructureList so that we can determine the
structure of the JITed code at patch time.
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
- bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::markAggregate):
Added this function to mark the JITed code that correosponds to
this structure stub info.
- bytecode/StructureStubInfo.h: (JSC::StructureStubInfo::initGetByIdProto): (JSC::StructureStubInfo::initGetByIdChain): (JSC::StructureStubInfo::):
- jit/JIT.h:
- jit/JITMarkObjects.cpp: Added. (JSC::JIT::patchPrototypeStructureAddress): (JSC::JIT::patchGetDirectOffset): (JSC::JIT::markGetByIdProto): (JSC::JIT::markGetByIdChain): (JSC::JIT::markGetByIdProtoList): (JSC::JIT::markPutByIdTransition): (JSC::JIT::markGlobalObjectReference):
- jit/JITPropertyAccess.cpp:
Added asserts for the patch offsets.
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::testPrototype):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdProto): (JSC::JIT::privateCompileGetByIdProtoList): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp: (JSC::setupPolymorphicProtoList):
- wtf/Platform.h:
Added ENABLE_MOVABLE_GC_OBJECTS flag
- 10:29 PM Changeset in webkit [64937] by
-
- 5 edits in trunk/JavaScriptCore
2010-08-07 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Revert JSArray to point to the beginning of the contained ArrayStorage
struct. This is described in
https://bugs.webkit.org/show_bug.cgi?id=43526.
- jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::privateCompilePatchGetArrayLength):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::privateCompilePatchGetArrayLength):
- runtime/JSArray.cpp: (JSC::JSArray::JSArray): (JSC::JSArray::~JSArray): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::putSlowCase): (JSC::JSArray::deleteProperty): (JSC::JSArray::getOwnPropertyNames): (JSC::JSArray::getNewVectorLength): (JSC::JSArray::increaseVectorLength): (JSC::JSArray::increaseVectorPrefixLength): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::shiftCount): (JSC::JSArray::unshiftCount): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToRegisters): (JSC::JSArray::compactForSorting): (JSC::JSArray::subclassData): (JSC::JSArray::setSubclassData): (JSC::JSArray::checkConsistency):
- runtime/JSArray.h: (JSC::JSArray::length): (JSC::JSArray::canGetIndex): (JSC::JSArray::getIndex): (JSC::JSArray::setIndex): (JSC::JSArray::uncheckedSetIndex): (JSC::JSArray::markChildrenDirect):
- 10:01 PM Changeset in webkit [64936] by
-
- 2 edits in trunk/WebCore
2010-08-07 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Eric Seidel.
Allow custom memory allocation control for EventHandlingState struct
https://bugs.webkit.org/show_bug.cgi?id=43548
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
struct name - instantiated at: WebCore/
EventHandlingState - html/HTMLInputElement.cpp:2051
- html/HTMLInputElement.cpp:
- 9:47 PM Changeset in webkit [64935] by
-
- 5 edits in trunk
2010-08-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Eric Seidel.
[Chromium] Remove unecessary focus code.
https://bugs.webkit.org/show_bug.cgi?id=43542
- platform/chromium/ChromiumBridge.h:
- platform/chromium/WidgetChromium.cpp: (WebCore::Widget::setFocus):
2010-08-07 Jay Civelli <jcivelli@chromium.org>
Reviewed by Eric Seidel.
Removed unecessary focus code.
https://bugs.webkit.org/show_bug.cgi?id=43542
- src/ChromiumBridge.cpp:
- 8:55 PM Changeset in webkit [64934] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-07 Kwang Yul Seo <skyul@company100.net>
Reviewed by Eric Seidel.
Add ENABLE(YARR) guard around JSGlobalData::m_regexAllocator
https://bugs.webkit.org/show_bug.cgi?id=43399
m_regexAllocator is used only by RegExp::compile which is guarded with ENABLE(YARR).
- runtime/JSGlobalData.h:
- 8:25 PM Changeset in webkit [64933] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-07 Patrick Roland Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
[Qt] Enable JIT on WinCE
https://bugs.webkit.org/show_bug.cgi?id=43303
Add ExtraCompiler for generating GeneratedJITStubs_MSVC.asm.
- DerivedSources.pro:
- 8:13 PM Changeset in webkit [64932] by
-
- 2 edits in trunk/WebCore
2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[WML] Include FormDataBuilder.h in WMLGoElement.h
https://bugs.webkit.org/show_bug.cgi?id=43177
To fix build breaks in WMLGoElement.cpp, FormDataBuilder.h needs to be included.
- wml/WMLGoElement.cpp: Include FormDataBuilder.h
- 8:00 PM Changeset in webkit [64931] by
-
- 2 edits in trunk/WebCore
2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[WML] Add dummy argument to SelectElement::defaultEventHandler() in WMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=43176
- wml/WMLSelectElement.cpp: (WebCore::WMLSelectElement::defaultEventHandler): Sets NULL parameter to SelectElement::defaultEventHandler.
- 7:38 PM Changeset in webkit [64930] by
-
- 2 edits in trunk/WebCore
2010-08-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Eric Seidel.
[WML] Change DocumentParser with ScriptableDocumentParser in WMLDocument
https://bugs.webkit.org/show_bug.cgi?id=43174
- wml/WMLDocument.cpp: (WebCore::WMLDocument::finishedParsing): Change DocumentParser with ScriptableDocumentParser.
- 7:22 PM Changeset in webkit [64929] by
-
- 7 edits in trunk
WebKitTestRunner needs layoutTestController.dumpTitleChanges
<rdar://problem/8213861>
https://bugs.webkit.org/show_bug.cgi?id=42683
Reviewed by Maciej Stachowiak.
WebKitTools:
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpTitleChanges):
(WTR::LayoutTestController::shouldDumpTitleChanges):
LayoutTests:
- platform/mac-wk2/Skipped:
- 6:59 PM Changeset in webkit [64928] by
-
- 9 edits in trunk
WebKitTestRunner needs to print onunload handler information
<rdar://problem/8213831>
https://bugs.webkit.org/show_bug.cgi?id=42703
Reviewed by Anders Carlsson.
WebKit2:
Add SPI to get the number of pending unload events.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetPendingUnloadCount):
- WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::pendingUnloadCount):
- WebProcess/WebPage/WebFrame.h:
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
LayoutTests:
- platform/mac-wk2/Skipped:
- 4:26 PM Changeset in webkit [64927] by
-
- 9 edits in trunk
Add additional loader client functions need to complete WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=43684
Reviewed by Anders Carlsson.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didChangeLocationWithinPageForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
WebKitTools:
Remove unnecessary and jarring underscores as well.
- MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didClearWindowObjectForFrame):
(didCreatePage):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
(WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didCommitLoadForFrame):
(WTR::InjectedBundlePage::didFinishLoadForFrame):
(WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
(WTR::InjectedBundlePage::didReceiveTitleForFrame):
(WTR::InjectedBundlePage::didClearWindowForFrame):
(WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
(WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
(WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
(WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
(WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
(WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
(WTR::InjectedBundlePage::didRunInsecureContentForFrame):
(WTR::InjectedBundlePage::willAddMessageToConsole):
(WTR::InjectedBundlePage::willSetStatusbarText):
(WTR::InjectedBundlePage::willRunJavaScriptAlert):
(WTR::InjectedBundlePage::willRunJavaScriptConfirm):
(WTR::InjectedBundlePage::willRunJavaScriptPrompt):
(WTR::InjectedBundlePage::shouldBeginEditing):
(WTR::InjectedBundlePage::shouldEndEditing):
(WTR::InjectedBundlePage::shouldInsertNode):
(WTR::InjectedBundlePage::shouldInsertText):
(WTR::InjectedBundlePage::shouldDeleteRange):
(WTR::InjectedBundlePage::shouldChangeSelectedRange):
(WTR::InjectedBundlePage::shouldApplyStyle):
(WTR::InjectedBundlePage::didBeginEditing):
(WTR::InjectedBundlePage::didEndEditing):
(WTR::InjectedBundlePage::didChange):
(WTR::InjectedBundlePage::didChangeSelection):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
- 3:47 PM Changeset in webkit [64926] by
-
- 2 edits in trunk/WebCore
Use ctFont() to get the CTFont.
Reviewed by Sam Weinig.
- platform/graphics/mac/FontMac.mm:
(WebCore::showGlyphsWithAdvances):
- 3:40 PM Changeset in webkit [64925] by
-
- 2 edits2 adds in trunk
2010-08-07 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
document->documentElement can always be null
https://bugs.webkit.org/show_bug.cgi?id=43677
This ASSERT is bogus.
- css/StyleMedia.cpp: (WebCore::StyleMedia::matchMedium):
- 3:32 PM Changeset in webkit [64924] by
-
- 2 edits in trunk/WebKit2
Another fix for the windows build.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
- 3:26 PM Changeset in webkit [64923] by
-
- 2 edits in trunk/WebKitTools
Build fix.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Made the references
to JSGCController.{cpp,h} relative to the build root.
- 3:25 PM Changeset in webkit [64922] by
-
- 3 edits in trunk/WebKit2
Fix windows build.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::platformLayer):
- WebProcess/Plugins/PluginView.h:
- 2:42 PM Changeset in webkit [64921] by
-
- 17 edits3 adds in trunk
WebKitTestRunner needs GCController
<rdar://problem/8213834>
https://bugs.webkit.org/show_bug.cgi?id=42701
Reviewed by Anders Carlsson.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleGarbageCollectJavaScriptObjects):
(WKBundleGarbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WKBundleGetJavaScriptObjectsCount):
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::garbageCollectJavaScriptObjects):
(WebKit::InjectedBundle::garbageCollectJavaScriptObjectsOnAlternateThreadForDebugging):
(WebKit::InjectedBundle::javaScriptObjectsCount):
- WebProcess/InjectedBundle/InjectedBundle.h:
WebKitTools:
- WebKitTestRunner/DerivedSources.make:
- WebKitTestRunner/InjectedBundle/Bindings/GCController.idl: Added.
- WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
(WTR::setProperty):
- WebKitTestRunner/InjectedBundle/GCController.cpp: Added.
(WTR::GCController::create):
(WTR::GCController::GCController):
(WTR::GCController::~GCController):
(WTR::GCController::wrapperClass):
(WTR::GCController::collect):
(WTR::GCController::collectOnAlternateThread):
(WTR::GCController::getJSObjectCount):
(WTR::GCController::makeWindowObject):
- WebKitTestRunner/InjectedBundle/GCController.h: Added.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::reset):
- WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(WTR::InjectedBundle::bundle):
(WTR::InjectedBundle::gcController):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::didClearWindowForFrame):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::keepWebHistory):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/win/InjectedBundle.vcproj:
LayoutTests:
- platform/mac-wk2/Skipped: Remove now passing tests and add some failing tests.
- 2:41 PM Changeset in webkit [64920] by
-
- 6 edits4 adds in trunk
<rdar://problem/8285090> First word on a line doesn’t hyphenate properly
https://bugs.webkit.org/show_bug.cgi?id=43679
Reviewed by Anders Carlsson.
WebCore:
Test: fast/text/hyphenate-first-word.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): The character at lastSpace is not necessarily a whitespace character
before the current word. It can also be part of the word, such as when the word is the first
one on the line. Include the charcater at lastSpace in the string passed to lastHyphenLocation().
LayoutTests:
- fast/text/hyphenate-first-word.html: Added.
- platform/mac/fast/text/hyphenate-first-word-expected.checksum: Added.
- platform/mac/fast/text/hyphenate-first-word-expected.png: Added.
- platform/mac/fast/text/hyphenate-first-word-expected.txt: Added.
- platform/mac/fast/text/hyphenate-locale-expected.checksum:
- platform/mac/fast/text/hyphenate-locale-expected.png:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- 1:54 PM Changeset in webkit [64919] by
-
- 9 edits in trunk/WebKit2
CA drawing model support for Mac Plugins
https://bugs.webkit.org/show_bug.cgi?id=43678
<rdar://problem/7929701>
Reviewed by Sam Weinig.
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
Handle WKNVSupportsCompositingCoreAnimationPluginsBool and
NPNVsupportsCoreAnimationBool and return true if accelerated compositing is enabled.
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::isAcceleratedCompositingEnabled):
Call PluginController::isAcceleratedCompositingEnabled.
- WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPostInitialize):
If the plug-in uses the Core Animation drawing model, ask it for its layer.
(WebKit::NetscapePlugin::platformPaint):
Don't send draw events if the Core Animation drawing model is used.
(WebKit::NetscapePlugin::pluginLayer):
Return the plug-in layer.
- WebProcess/Plugins/Plugin.h:
Add a pluginLayer pure virtual member function.
- WebProcess/Plugins/PluginController.h:
Add an isAcceleratedCompositingEnabled pure virtual member function.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
If the plug-in has a layer, enter compositing mode.
(WebKit::PluginView::platformLayer):
Ask the plug-in for its layer.
(WebKit::PluginView::isAcceleratedCompositingEnabled):
Call Settings::acceleratedCompositingEnabled.
- WebProcess/Plugins/PluginView.h:
- 1:45 PM Changeset in webkit [64918] by
-
- 10 edits in trunk/WebKit2
Delete key doesn't go Back in WebKit2
<rdar://problem/8272978>
https://bugs.webkit.org/show_bug.cgi?id=43665
Reviewed by Anders Carlsson.
- Adds support for delete key going back (mac only for now)
- Adds support for command-left/command right going back/forward
- Flesh out scrolling due to arrow keys on the mac to match old webkit.
- Made performDefaultBehaviorForKeyEvent platform specific and added a boolean return value which will be used later to inform the UI process about what events have been processed.
- Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
(WebPageProxyMessage::):
- UIProcess/API/mac/WKView.mm:
(-[WKView _wantsKeyDownForEvent:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveSyncMessage):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::backItem):
(WebKit::WebBackForwardListProxy::forwardItem):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::keyEvent):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
- WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
- 1:07 PM Changeset in webkit [64917] by
-
- 1 edit in trunk/WebKitTools/QtTestBrowser/launcherwindow.cpp
2010-08-07 Antonio Gomes <tonikitoo@webkit.org>
Another unreviewed missing bit of r64673
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- 12:18 PM Changeset in webkit [64916] by
-
- 2 edits in trunk/WebCore
Build fix
- platform/graphics/SimpleFontData.h:
- 11:59 AM Changeset in webkit [64915] by
-
- 12 edits in trunk
Created a separate SimpleFontData constructor exclusively for SVG fonts and moved the CTFontRef
from SimpleFontData to FontPlatformData.
https://bugs.webkit.org/show_bug.cgi?id=43674
Reviewed by Anders Carlsson.
- wtf/Platform.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI here from WebCore/config.h.
WebCore:
- config.h: Moved definitions of WTF_USE_CORE_TEXT and WTF_USE_ATSUI from here to wtf/Platform.h.
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::getFontData): Use new SimpleFontData constructor for SVG fonts.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData): Separated into two constructors, one for
PlatformFontData-based fonts and one for SVG fonts.
- platform/graphics/SimpleFontData.h: Moved the m_CTFont member variable and the getCTFont()
accessor from here…
- platform/graphics/mac/FontPlatformData.h: …to here, renaming the latter ctFont().
- platform/graphics/mac/FontPlatformDataMac.mm:
(WebCore::FontPlatformData::FontPlatformData): Copy m_CTFont.
(WebCore::FontPlatformData::operator=): Copy m_CTFont.
(WebCore::FontPlatformData::setFont): Clear m_CTFont.
(WebCore::FontPlatformData::ctFont): Moved here from SimpleFontDataCoreText.cpp and renamed.
- platform/graphics/mac/SimpleFontDataCoreText.cpp:
(WebCore::SimpleFontData::getCFStringAttributes): Updated to use FontPlatformData::ctFont().
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::SVGFontData): Added an assertion.
- 11:00 AM Changeset in webkit [64914] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fixed typos in the change log
- 10:52 AM Changeset in webkit [64913] by
-
- 6 edits in trunk
2010-08-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Regression: Memory corruption in tree builder
https://bugs.webkit.org/show_bug.cgi?id=43672
Turns out this ASSERT was wrong and we need the branch. Yay for
test-driven development.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
2010-08-07 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
Regression: Memory corruption in tree builder
https://bugs.webkit.org/show_bug.cgi?id=43672
- html5lib/resources/adoption02.dat:
- html5lib/runner-expected-html5.txt:
- html5lib/runner-expected.txt:
- 10:34 AM Changeset in webkit [64912] by
-
- 2 edits in trunk/JavaScriptCore
Bitmap.h has no default constructor
https://bugs.webkit.org/show_bug.cgi?id=43619
Reviewed by Eric Seidel.
Without a constructor, the initial bits of the Bitmap class
are undefinied. If only a few, or zero bits are 0, the memory
area provided by AlignedMemoryAllocator can be easly exhausted.
Csaba Osztrogonác helped to find this bug.
- wtf/Bitmap.h:
(WTF::::Bitmap):
- 8:57 AM Changeset in webkit [64911] by
-
- 5 edits in trunk/WebCore
2010-08-07 Dirk Schulze <krit@webkit.org>
Unreviewed build-fix.
Come up with a more efficient way to represent Path segments
https://bugs.webkit.org/show_bug.cgi?id=41159
Landed wrong version of the patch.
- svg/SVGPathByteStreamSource.cpp: (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::hasMoreData):
- svg/SVGPathByteStreamSource.h: (WebCore::SVGPathByteStreamSource::moveToNextToken):
- svg/SVGPathParserFactory.cpp: (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::createSVGPathByteStreamFromString):
- svg/SVGPathParserFactory.h:
- 8:33 AM Changeset in webkit [64910] by
-
- 1 edit7 adds in trunk/LayoutTests
2010-08-07 Dimitri Glazkov <Dimitri Glazkov>
[Chromium]: Added port-specific expectations after http://trac.webkit.org/changeset/64901.
https://bugs.webkit.org/show_bug.cgi?id=41596
- platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
- platform/chromium-linux/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
- platform/chromium-mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
- platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/chromium-win/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
- 8:17 AM Changeset in webkit [64909] by
-
- 11 edits5 adds in trunk/WebCore
2010-08-07 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Come up with a more efficient way to represent Path segments
https://bugs.webkit.org/show_bug.cgi?id=41159
Introduce SVGPathByteStream as a fast and efficient way to organize the synchronization
of Path, SVG path data string and SVGPathSegList in normalized and unaltered modes.
Extended SVGPathParserFactory to accept SVGPathByteStreams as input source and to create
a SVGPathByteStream from a SVG path data string.
Doesn't affect any tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- svg/SVGAllInOne.cpp:
- svg/SVGPathByteStream.h: Added. (WebCore::): (WebCore::SVGPathByteStream::create): (WebCore::SVGPathByteStream::data): (WebCore::SVGPathByteStream::begin): (WebCore::SVGPathByteStream::end): (WebCore::SVGPathByteStream::append): (WebCore::SVGPathByteStream::clear): (WebCore::SVGPathByteStream::isEmpty): (WebCore::SVGPathByteStream::SVGPathByteStream):
- svg/SVGPathByteStreamBuilder.cpp: Added. (WebCore::SVGPathByteStreamBuilder::SVGPathByteStreamBuilder): (WebCore::SVGPathByteStreamBuilder::moveTo): (WebCore::SVGPathByteStreamBuilder::lineTo): (WebCore::SVGPathByteStreamBuilder::lineToHorizontal): (WebCore::SVGPathByteStreamBuilder::lineToVertical): (WebCore::SVGPathByteStreamBuilder::curveToCubic): (WebCore::SVGPathByteStreamBuilder::curveToCubicSmooth): (WebCore::SVGPathByteStreamBuilder::curveToQuadratic): (WebCore::SVGPathByteStreamBuilder::curveToQuadraticSmooth): (WebCore::SVGPathByteStreamBuilder::arcTo): (WebCore::SVGPathByteStreamBuilder::closePath):
- svg/SVGPathByteStreamBuilder.h: Added. (WebCore::SVGPathByteStreamBuilder::setCurrentByteStream): (WebCore::SVGPathByteStreamBuilder::writeType): (WebCore::SVGPathByteStreamBuilder::writeFlag): (WebCore::SVGPathByteStreamBuilder::writeFloat): (WebCore::SVGPathByteStreamBuilder::writeFloatPoint): (WebCore::SVGPathByteStreamBuilder::writeSegmentType):
- svg/SVGPathByteStreamSource.cpp: Added. (WebCore::SVGPathByteStreamSource::SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::~SVGPathByteStreamSource): (WebCore::SVGPathByteStreamSource::hasMoreData): (WebCore::SVGPathByteStreamSource::parseFloat): (WebCore::SVGPathByteStreamSource::parseFlag): (WebCore::SVGPathByteStreamSource::parseSVGSegmentType): (WebCore::SVGPathByteStreamSource::nextCommand):
- svg/SVGPathByteStreamSource.h: Added. (WebCore::SVGPathByteStreamSource::create): (WebCore::SVGPathByteStreamSource::readType): (WebCore::SVGPathByteStreamSource::readFlag): (WebCore::SVGPathByteStreamSource::readFloat): (WebCore::SVGPathByteStreamSource::readSVGSegmentType): (WebCore::SVGPathByteStreamSource::readFloatPoint):
- svg/SVGPathParserFactory.cpp: (WebCore::globalSVGPathByteStreamBuilder): (WebCore::SVGPathParserFactory::buildPathFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream): (WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
- svg/SVGPathParserFactory.h:
- 6:03 AM Changeset in webkit [64908] by
-
- 2 edits in trunk/WebCore
2010-08-07 Dirk Schulze <krit@webkit.org>
Not reviewed. Sort XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 5:42 AM Changeset in webkit [64907] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-06 Victor Wang <victorw@chromium.org>
Reviewed by Kent Tamura.
[Chromium] Add dllimport/dllexport to WebSpeechInputControllerMock::create
so it works for windows dll build.
- public/WebSpeechInputControllerMock.h:
- 5:22 AM Changeset in webkit [64906] by
-
- 7 edits3 deletes in trunk
2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64904.
http://trac.webkit.org/changeset/64904
https://bugs.webkit.org/show_bug.cgi?id=43671
Broke the Qt Windows builders. (Requested by bbandix on
#webkit).
- WebCore.pri:
- WebCore.pro:
- features.pri: Removed.
2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64904.
http://trac.webkit.org/changeset/64904
https://bugs.webkit.org/show_bug.cgi?id=43671
Broke the Qt Windows builders. (Requested by bbandix on
#webkit).
- WebKit.pro:
2010-08-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64904.
http://trac.webkit.org/changeset/64904
https://bugs.webkit.org/show_bug.cgi?id=43671
Broke the Qt Windows builders. (Requested by bbandix on
#webkit).
- WebKit2.pri: Removed.
- WebKit2.pro:
- WebProcess.pro: Removed.
- 4:47 AM Changeset in webkit [64905] by
-
- 5 edits in trunk/WebKit2
2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Eric Seidel.
NPAPI headers should be included through npruntime_internal.h
- DerivedSources.pro:
- WebProcess/Plugins/NPJSObject.h:
- WebProcess/Plugins/NPRuntimeUtilities.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- 4:44 AM Changeset in webkit [64904] by
-
- 7 edits3 adds in trunk
2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Eric Seidel.
[Qt] Build WebKit2 into a static lib
Just build changes so no new tests.
- WebCore.pri: Moved feature detection logic into features.pri since we need this in WebKit2.pro as well.
- WebCore.pro: Moved the specification of the WebKit2 build to WebKit2.pro. Link against the static lib.
- features.pri: Added.
2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Eric Seidel.
[Qt] Build WebKit2 into a static lib
- WebKit.pro: Moved WebKit2 into the subdirs before WebCore since WebCore links against the WebKit2 lib.
2010-08-07 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Eric Seidel.
[Qt] Build WebKit2 into a static lib
- WebKit2.pri: Added. Defined addWebKit2Lib function that defines how to link against the static lib.
- WebKit2.pro: Build specification for the WebKit2 framework.
- WebProcess.pro: Copied from WebKit2/WebKit2.pro. Build specification for the WebProcess binary.
- 2:32 AM Changeset in webkit [64903] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Update DRT expectation.
- 2:28 AM Changeset in webkit [64902] by
-
- 3 edits in trunk/LayoutTests
2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Remove workarounds in two dynamic-updates scripts, that now work without it.
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js:
- svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js:
- 2:25 AM Changeset in webkit [64901] by
-
- 3 edits4 adds in trunk
2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Daniel Bates.
Pattern fill with image not rendered after reload
https://bugs.webkit.org/show_bug.cgi?id=41596
Fixed by a one-liner. Instead of just invalidating it's own resources, images also have to update
resources in the ancestor chain, if imageChanged() has been called (for example, a slow loading image)
Test: http/tests/misc/slow-loading-image-in-pattern.html
- rendering/RenderSVGImage.cpp: (WebCore::RenderSVGImage::imageChanged):
2010-08-07 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Daniel Bates.
Pattern fill with image not rendered after reload
https://bugs.webkit.org/show_bug.cgi?id=41596
Added test verifying that resources are properly updated, if an image child element has changed.
- http/tests/misc/slow-loading-image-in-pattern.html: Added.
- platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.checksum: Added.
- platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.png: Added.
- platform/mac/http/tests/misc/slow-loading-image-in-pattern-expected.txt: Added.
- 2:17 AM Changeset in webkit [64900] by
-
- 2 edits in trunk/LayoutTests
2010-08-07 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium-win/fast/parser/nofoo-tags-inside-paragraph-expected.txt: Rebaseline for r64890.
- 12:13 AM Changeset in webkit [64899] by
-
- 1 edit4 deletes in trunk/LayoutTests
2010-08-07 Alex Nicolaou <anicolao@chromium.org>
Reviewed by Nikolas Zimmermann.
Remove obsolete baselines for win-xp and win-vista, all windows platforms are the same for this test
https://bugs.webkit.org/show_bug.cgi?id=43669
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
- platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
- platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum: Removed.
- platform/chromium-win-xp/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
Aug 6, 2010:
- 11:27 PM Changeset in webkit [64898] by
-
- 22 edits5 adds in trunk/WebCore
2010-08-06 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Generalize SVGPathParser to allow more than just strings as input source
https://bugs.webkit.org/show_bug.cgi?id=43618
Generalize SVGPathParser, by allowing different parsing sources than just strings.
For now only a SVGPathStringSource is available, parsing from bytestreams follows soon.
Each client that wants to parse strings, like Path or SVGPathSegList objects, only
needs to use the new central SVGPathParserFactory, which glues consumer and sources together.
Moved the SVGPathSegType enum from SVGPathSeg class in WebCore namespace, for
easier access throughout the SVG code.
Doesn't affect any tests.
- Android.mk:
- CMakeLists.txt
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateElement.cpp: (WebCore::SVGAnimateElement::calculateFromAndToValues):
- svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
- svg/SVGGlyphElement.cpp: (WebCore::parsePathData):
- svg/SVGPathBuilder.cpp: (WebCore::SVGPathBuilder::SVGPathBuilder): (WebCore::SVGPathBuilder::moveTo): (WebCore::SVGPathBuilder::lineTo): (WebCore::SVGPathBuilder::curveToCubic): (WebCore::SVGPathBuilder::closePath):
- svg/SVGPathBuilder.h: (WebCore::SVGPathBuilder::setCurrentPath): (WebCore::SVGPathBuilder::arcTo):
- svg/SVGPathConsumer.h:
- svg/SVGPathElement.cpp: (WebCore::SVGPathElement::parseMappedAttribute):
- svg/SVGPathParser.cpp: (WebCore::SVGPathParser::SVGPathParser): (WebCore::SVGPathParser::parseClosePathSegment): (WebCore::SVGPathParser::parseMoveToSegment): (WebCore::SVGPathParser::parseLineToSegment): (WebCore::SVGPathParser::parseLineToHorizontalSegment): (WebCore::SVGPathParser::parseLineToVerticalSegment): (WebCore::SVGPathParser::parseCurveToCubicSegment): (WebCore::SVGPathParser::parseCurveToCubicSmoothSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSegment): (WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment): (WebCore::SVGPathParser::parseArcToSegment): (WebCore::SVGPathParser::parsePathDataFromSource): (WebCore::SVGPathParser::decomposeArcToCubic):
- svg/SVGPathParser.h: (WebCore::SVGPathParser::setCurrentConsumer):
- svg/SVGPathParserFactory.cpp: Added. (WebCore::globalSVGPathBuilder): (WebCore::globalSVGPathSegListBuilder): (WebCore::globalSVGPathParser): (WebCore::SVGPathParserFactory::self): (WebCore::SVGPathParserFactory::SVGPathParserFactory): (WebCore::SVGPathParserFactory::~SVGPathParserFactory): (WebCore::SVGPathParserFactory::buildPathFromString): (WebCore::SVGPathParserFactory::buildSVGPathSegListFromString):
- svg/SVGPathParserFactory.h: Added.
- svg/SVGPathSeg.h: (WebCore::): (WebCore::SVGPathSeg::~SVGPathSeg): (WebCore::SVGPathSeg::): (WebCore::SVGPathSeg::pathSegType): (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString): (WebCore::SVGPathSeg::associatedAttributeName): (WebCore::SVGPathSeg::SVGPathSeg): (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord): (WebCore::SVGPathSegSingleCoord::setX): (WebCore::SVGPathSegSingleCoord::x): (WebCore::SVGPathSegSingleCoord::setY): (WebCore::SVGPathSegSingleCoord::y): (WebCore::SVGPathSegSingleCoord::toString):
- svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::getPathSegAtLength): (WebCore::SVGPathSegList::toPathData): (WebCore::SVGPathSegList::createAnimated):
- svg/SVGPathSegListBuilder.cpp: (WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder): (WebCore::SVGPathSegListBuilder::moveTo): (WebCore::SVGPathSegListBuilder::lineTo): (WebCore::SVGPathSegListBuilder::curveToCubic): (WebCore::SVGPathSegListBuilder::curveToCubicSmooth): (WebCore::SVGPathSegListBuilder::curveToQuadratic): (WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth): (WebCore::SVGPathSegListBuilder::arcTo):
- svg/SVGPathSegListBuilder.h: (WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
- svg/SVGPathSource.h: Added. (WebCore::SVGPathSource::~SVGPathSource): (WebCore::SVGPathSource::SVGPathSource):
- svg/SVGPathStringSource.cpp: Added. (WebCore::SVGPathStringSource::SVGPathStringSource): (WebCore::SVGPathStringSource::~SVGPathStringSource): (WebCore::SVGPathStringSource::endOfStream): (WebCore::SVGPathStringSource::parseFloat): (WebCore::SVGPathStringSource::parseFlag): (WebCore::SVGPathStringSource::skipSpaces): (WebCore::SVGPathStringSource::parseSVGSegmentType): (WebCore::SVGPathStringSource::hasRemainingCoordinatesInCurrentCommand):
- svg/SVGPathStringSource.h: Added. (WebCore::SVGPathStringSource::create):
- 11:20 PM Changeset in webkit [64897] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing files from last commit - per Alex request.
- platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
- platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.
- 10:03 PM Changeset in webkit [64896] by
-
- 5 edits in trunk/LayoutTests
2010-08-06 Alex Nicolaou <anicolao@chromium.org>
Reviewed by Darin Adler.
recent colorspace changes have fixed svg/custom/grayscale-gradient-mask.svg
https://bugs.webkit.org/show_bug.cgi?id=43104
New baselines for windows and linux for two tests affected by the bug fix
for https://bugs.webkit.org/show_bug.cgi?id=42228 where I failed to rebaseline
them properly at that time.
- platform/chromium-linux/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.checksum:
- platform/chromium-win/svg/custom/grayscale-gradient-mask-expected.png:
- platform/chromium-win/svg/custom/mask-colorspace-expected.checksum: Added.
- platform/chromium-win/svg/custom/mask-colorspace-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 9:27 PM Changeset in webkit [64895] by
-
- 6 edits in trunk/LayoutTests
2010-08-06 Alex Nicolaou <anicolao@chromium.org>
Reviewed by Dirk Schulze.
can't see anything wrong with the output for circle-in-mask-with-shadow.svg
https://bugs.webkit.org/show_bug.cgi?id=43106
This test has been affected by recent colorspace changes but the diffs are
so slight as to be very difficult to detect. I'm reasonably confident
these new baselines are OK.
- platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.checksum:
- platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.checksum:
- platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
- platform/chromium/test_expectations.txt:
- 9:11 PM Changeset in webkit [64894] by
-
- 6 edits in trunk/LayoutTests
2010-08-06 Alex Nicolaou <anicolao@chromium.org>
Reviewed by Darin Adler.
rebaseline masking-intro-01-f.svg - diffs are in the antialiasing
https://bugs.webkit.org/show_bug.cgi?id=43107
After some investigation, the antialiasing diffs were
definitely verified to be due to the colorspace change
made for https://bugs.webkit.org/show_bug.cgi?id=42228
and I'm reasonably confident that these rebaselined
outputs are good.
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/chromium-linux/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.checksum:
- platform/chromium-win/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
- platform/chromium/test_expectations.txt:
- 8:37 PM Changeset in webkit [64893] by
-
- 2 edits in trunk/WebCore
2010-08-06 Robert Hogan <robert@webkit.org>
Reviewed by Adam Barth.
Define setPrivateBrowsingEnabled()
https://bugs.webkit.org/show_bug.cgi?id=42283
Define the scope of 'private browsing' in WebKit
See also https://bugs.webkit.org/show_bug.cgi?id=41801
- page/Settings.h:
- 8:30 PM Changeset in webkit [64892] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Ojan Vafai.
dump-as-markup should work in Firefox
https://bugs.webkit.org/show_bug.cgi?id=43606
Apparently Firefox lacks this API.
- resources/dump-as-markup.js: (Markup._getMarkupForTextNode): (Markup._getSelectionMarker):
- 8:09 PM Changeset in webkit [64891] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Dimitri Glazkov <Dimitri Glazkov>
[Chromium/DRT] One more tweak to the expectation overrides to pacify the bot.
- platform/chromium/drt_expectations.txt: Removed duplicate expectations.
- 6:56 PM Changeset in webkit [64890] by
-
- 5 edits in trunk
2010-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
https://bugs.webkit.org/show_bug.cgi?id=43605
Show test progression. We missed this regression when analyzing the
expectation diffs because the DOM was correct and was a progression.
- fast/dom/no-elements-expected.txt:
- platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
2010-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
REGRESSION (r64712): YouTube video pages have contents of <noembed> elements overlapping the video description
https://bugs.webkit.org/show_bug.cgi?id=43605
The old parser used to drop <noembed> on the floor. We're supposed to
add it to the DOM, but we don't want to create a renderer for it.
- html/HTMLElement.cpp: (WebCore::HTMLElement::rendererIsNeeded):
- 6:30 PM Changeset in webkit [64889] by
-
- 3 edits in trunk/WebCore
2010-08-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Fix style violations in Document
https://bugs.webkit.org/show_bug.cgi?id=43657
No new tests because no new functionality.
- dom/Document.cpp: (WebCore::acceptsEditingFocus): (WebCore::Document::Document): (WebCore::Document::importNode): (WebCore::Document::adoptNode): (WebCore::Document::getElementById): (WebCore::Document::readyState): (WebCore::Document::createTreeWalker): (WebCore::Document::shouldScheduleLayout): (WebCore::Document::nextFocusableNode): (WebCore::Document::previousFocusableNode): (WebCore::Document::nodeAbsIndex): (WebCore::Document::nodeWithAbsIndex): (WebCore::Document::childTypeAllowed): (WebCore::Document::canReplaceChild): (WebCore::Document::recalcStyleSelector): (WebCore::Document::setFocusedNode): (WebCore::Document::attachNodeIterator): (WebCore::Document::detachNodeIterator): (WebCore::Document::parseQualifiedName): (WebCore::Document::getImageMap): (WebCore::Document::setInPageCache): (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::shiftMarkers): (WebCore::Document::setMarkersActive): (WebCore::Document::parentDocument): (WebCore::Document::topDocument): (WebCore::FormElementKeyHash::hash): (WebCore::Document::initSecurityContext):
- dom/Document.h: (WebCore::Document::incDOMTreeVersion): (WebCore::Document::domTreeVersion):
- 5:34 PM Changeset in webkit [64888] by
-
- 15 edits3 adds in trunk
WebKitTestRunner needs to be able to set the font smoothing type
https://bugs.webkit.org/show_bug.cgi?id=43406
Reviewed by Adam Roben.
WebKit2:
- Shared/FontSmoothingLevel.h: Added.
(WebKit::):
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
Initialize fontSmoothingLevel.
(WebKit::WebPreferencesStore::swap):
Copy fontSmoothingLevel.
- Shared/WebPreferencesStore.h:
(WebKit::WebPreferencesStore::encode):
Encode fontSmoothingLevel.
(WebKit::WebPreferencesStore::decode):
Decode it.
- UIProcess/API/C/WKPreferencesPrivate.cpp: Added.
(WKPreferencesSetFontSmoothingLevel):
Get the font smoothing level from the WKFontSmoothingLevel, and call
WebPreferences::setFontSmoothingLevel().
(WKPreferencesGetFontSmoothingLevel):
Get the font smoothing level from WebPreferences, and translate it to a
WKFontSmoothingLevel.
- UIProcess/API/C/WKPreferencesPrivate.h: Added.
Declare the font smoothing levels, and declare functions to get and set
the level.
- UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setFontSmoothingLevel):
Set fontSmoothingLevel and call update().
(WebKit::WebPreferences::fontSmoothingLevel):
Return the level.
- UIProcess/WebPreferences.h:
Declare getter and setter for fontSmoothingLevel.
- WebKit2.xcodeproj/project.pbxproj:
Add new files to project.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::preferencesDidChange):
Call platformPreferencesDidChange().
- WebProcess/WebPage/WebPage.h:
Declare platformPreferencesDidChange().
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.
- WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
Stubbed.
- WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformPreferencesDidChange):
On CG platforms, call wkSetFontSmoothingLevel(). This matches the code
in old WebKit's WebPreferences. Set the font rendering mode to either
normal (CG) or alternative (GDI) based on the font smoothing level. This
matches what was done in old WebKit's WebView.
- win/WebKit2.vcproj:
Add FontSmoothingLevel.h and WKPreferencesPrivate.{h,cpp} to project.
- win/WebKit2Generated.make:
Copy WKPreferencesPrivate.h.
WebKitTools:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
Set the font smoothing level to
kWKFontSmoothingLevelNoSubpixelAntiAliasing to match DRT.
- 5:07 PM Changeset in webkit [64887] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Dimitri Glazkov <Dimitri Glazkov>
[Chromium/DRT] Adjust expectations after my unexpectedly awful search-and-replace performance.
- platform/chromium/drt_expectations.txt: Un-bungled test names.
- 4:47 PM Changeset in webkit [64886] by
-
- 2 edits in trunk/WebCore
2010-08-06 Eric Carlson <eric.carlson@apple.com>
Unreviewed, release Qt build fix.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent): Guard call to toRenderVideo() with #if ENABLE(VIDEO).
- 4:43 PM Changeset in webkit [64885] by
-
- 1 edit in tags/Safari-534.5/WebCore/WebCore.vcproj/WebCore.vcproj
Windows build fix. Temporarily turn off link-time code generation.
- 4:35 PM Changeset in webkit [64884] by
-
- 15 edits2 adds in trunk
2010-08-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTML5 "video" tag with poster frame defined "flashes" right before movie displays
https://bugs.webkit.org/show_bug.cgi?id=37591
<rdar://problem/5650561>
If a video element has a poster frame, display it until the playback is requested or the movie's
time is changed.
Test: compositing/video/video-poster.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_displayMode. (WebCore::HTMLMediaElement::prepareForLoad): Set m_displayMode to Unknown. (WebCore::HTMLMediaElement::loadResource): Call updateDisplayState to let it set configure the poster, if necessary. (WebCore::HTMLMediaElement::noneSupported): updatePosterImage -> updateDisplayState. (WebCore::HTMLMediaElement::setNetworkState): Ditto. (WebCore::HTMLMediaElement::setReadyState): Ditto. (WebCore::HTMLMediaElement::finishSeek): Set display mode to Video so a video frame will be displayed if a poster is currently visible. (WebCore::HTMLMediaElement::mediaPlayerRepaint): updatePosterImage -> updateDisplayState. (WebCore::HTMLMediaElement::updatePlayState): Set display mode to Video.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::displayMode): New. (WebCore::HTMLMediaElement::setDisplayMode): Ditto. (WebCore::HTMLMediaElement::updateDisplayState): Ditto.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): Remove m_shouldDisplayPosterImage. (WebCore::HTMLVideoElement::attach): Call shouldDisplayPosterImage instead of checking m_shouldDisplayPosterImage directly. (WebCore::HTMLVideoElement::detach): Ditto. (WebCore::HTMLVideoElement::parseMappedAttribute): Set m_displayMode to Unknown before calling updateDisplayState so shouldDisplayPosterImage() will return the correct result. Remove the PLUGIN_PROXY_FOR_VIDEO code, it is now in updateDisplayState. (WebCore::HTMLVideoElement::setDisplayMode): Renamed from updatePosterImage and rework logic so we tell the media engine it is OK to display video frames when there is no poster, or once the media engine has something to display and the movie has started or seeked. (WebCore::HTMLVideoElement::updateDisplayState): New, manage display mode based on poster attribute.
- html/HTMLVideoElement.h: (WebCore::HTMLVideoElement::shouldDisplayPosterImage):
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::prepareForRendering): New, call media engine's prepareForRendering.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::prepareForRendering):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Initialize m_isAllowedToRender. (WebCore::MediaPlayerPrivate::setUpVideoRendering): (WebCore::MediaPlayerPrivate::isReadyForVideoSetup): Renamed from isReadyForRendering. (WebCore::MediaPlayerPrivate::prepareForRendering): New, set m_isAllowedToRender and inform the client that render tree should be updated so we correctly switch from showing the poster, which often doens't use a layer, to showing video frames, which do. (WebCore::MediaPlayerPrivate::updateStates): Don't call setUpVideoRendering until isReadyForVideoSetup() returns true. (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering): isReadyForRendering -> isReadyForVideoSetup
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::containsPaintedContent): Only consider video when displaying video frames so a poster won't force compositing mode.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForVideo): Ditto.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::shouldDisplayVideo): New, return true when not displaying a poster.
- rendering/RenderVideo.h:
2010-08-06 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
HTML5 "video" tag with poster frame defined "flashes" right before movie displays
https://bugs.webkit.org/show_bug.cgi?id=37591
<rdar://problem/5650561>
If a video element has a poster frame, display it until the playback is requested or the movie's
time is changed. Test this by ensuring that an element with a poster doesn't have layers while
and element with one does.
- compositing/video/video-poster-expected.txt: Added.
- compositing/video/video-poster.html: Added.
- 4:35 PM Changeset in webkit [64883] by
-
- 5 edits in trunk
Versioning.
- 4:30 PM Changeset in webkit [64882] by
-
- 1 copy in tags/Safari-534.5
New tag.
- 4:29 PM Changeset in webkit [64881] by
-
- 9 edits in trunk/WebCore
2010-08-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Accelerated 2d canvases should get compositing layers
https://bugs.webkit.org/show_bug.cgi?id=43362
Allows for 2d canvas rendering contexts to use a GraphicsContext3D for
accelerated rendering. The rendering context holds the GraphicsContext3D
alive and exposes it to the compositor. The 3d context itself is passed
down through the GraphicsContext to use for actual rendering:
https://bug-43362-attachments.webkit.org/attachment.cgi?id=63557
This approach will let us simultaneously prototype accelerated techniques
for canvas 2d and revise the design of canvas elements without destabilizing
all ports.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::getContext): (WebCore::HTMLCanvasElement::willDraw): (WebCore::HTMLCanvasElement::makeRenderingResultsAvailable):
- html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::paintRenderingResultsToCanvas):
- html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): (WebCore::CanvasRenderingContext2D::isAccelerated): (WebCore::CanvasRenderingContext2D::reset): (WebCore::CanvasRenderingContext2D::willDraw): (WebCore::CanvasRenderingContext2D::paintRenderingResultsToCanvas):
- html/canvas/CanvasRenderingContext2D.h: (WebCore::CanvasRenderingContext2D::graphicsContext3D):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
- html/canvas/WebGLRenderingContext.h:
- platform/graphics/GraphicsContext.h:
- platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::syncSoftwareCanvas):
- 4:23 PM Changeset in webkit [64880] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Dimitri Glazkov <Dimitri Glazkov>
[Chromium/DRT] Update expectation overrides for Windows.
- platform/chromium/drt_expectations.txt: Added a bunch of failing tests.
- 4:15 PM Changeset in webkit [64879] by
-
- 6 edits in trunk/WebKit2
Build fixes.
- Platform/win/SharedMemoryWin.cpp:
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
- Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
- Shared/qt/UpdateChunk.h:
- Shared/win/UpdateChunk.cpp:
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
- Shared/win/UpdateChunk.h:
- 4:07 PM Changeset in webkit [64878] by
-
- 2 edits in trunk/WebKitTools
Fix a missed variable rename.
Unreviewed.
- Scripts/old-run-webkit-tests:
- 4:04 PM Changeset in webkit [64877] by
-
- 36 edits in trunk/WebKit2
Change all ArgumentEncoder and ArgumentDecoder references to pointers
https://bugs.webkit.org/show_bug.cgi?id=43651
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentCoder.h:
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/Arguments.h:
- Platform/CoreIPC/Attachment.cpp:
- Platform/CoreIPC/Attachment.h:
- Platform/CoreIPC/mac/MachPort.h:
- Platform/SharedMemory.h:
- Platform/mac/SharedMemoryMac.cpp:
- Shared/DrawingAreaBase.cpp:
- Shared/DrawingAreaBase.h:
- Shared/WebEvent.h:
- Shared/WebNavigationDataStore.h:
- Shared/WebPreferencesStore.h:
- Shared/mac/UpdateChunk.cpp:
- Shared/mac/UpdateChunk.h:
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
- UIProcess/DrawingAreaProxy.h:
- UIProcess/LayerBackedDrawingAreaProxy.cpp:
- UIProcess/LayerBackedDrawingAreaProxy.h:
- UIProcess/WebContext.cpp:
- UIProcess/WebContext.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/LayerBackedDrawingArea.cpp:
- WebProcess/WebPage/LayerBackedDrawingArea.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
- 3:59 PM Changeset in webkit [64876] by
-
- 4 edits in trunk
mac-wk2/Skipped should be used on Windows when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=43494
Reviewed by Adam Roben.
WebKitTools:
- Scripts/old-run-webkit-tests:
If the platform is win-wk2, also read the mac-wk2 skipped list.
LayoutTests:
- platform/win-wk2/Skipped:
Remove the tests copied from the mac-wk2 skipped list.
- 3:39 PM Changeset in webkit [64875] by
-
- 4 edits in trunk/WebKit2
Don't try to allocate a vector unless we know the buffer can contain it
https://bugs.webkit.org/show_bug.cgi?id=43647
Reviewed by Sam Weinig.
- Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::):
Check that the argument decoder buffer actually can hold all the vector elements.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Align the current position to the given alignment, add the size and check if the position is
past the end of the buffer.
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughtToContain):
Get the size and alignment and call the other bufferIsLargeEnoughtToContain overload.
- 3:20 PM Changeset in webkit [64874] by
-
- 12 edits in trunk/WebCore
2010-08-06 Eric Seidel <eric@webkit.org>
Reviewed by Chris Fleizach.
Make AX Code use more specific RenderObject subclass types
https://bugs.webkit.org/show_bug.cgi?id=43632
No functional change, thus no tests.
- accessibility/AXObjectCache.cpp:
(WebCore::nodeHasRole):
- Make this take a String instead of AtomicString, to avoid thrashing the atomic string hash. It would be better to take a const char* here, except one caller passes nullAtom.
(WebCore::createFromRenderer):
- Split this out from getOrCreate to make it simpler.
- No longer needs to deal with setting a "result" pointer and can instead just return.
- I've also made this function use RenderBoxModelObject* where appropriate.
(WebCore::AXObjectCache::getOrCreate):
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
- Fix style.
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::AccessibilityMenuList):
- Use a more specific type.
(WebCore::AccessibilityMenuList::renderer):
- accessibility/AccessibilityMenuList.h: (WebCore::AccessibilityMenuList::create):
- accessibility/AccessibilityMenuListPopup.cpp:
- Need RenderMenuList.h since renderer() is a RenderMenuList*
- accessibility/AccessibilityObject.cpp: (WebCore::renderListItemContainerForNode):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::renderBoxModelObject):
- New helper function, similar to Node::renderBoxModelObject()
(WebCore::isInlineWithContinuation):
(WebCore::AccessibilityRenderObject::isNativeImage):
(WebCore::AccessibilityRenderObject::isAttachment):
(WebCore::AccessibilityRenderObject::isMultiSelectable):
(WebCore::AccessibilityRenderObject::isReadOnly):
(WebCore::AccessibilityRenderObject::isFieldset):
(WebCore::AccessibilityRenderObject::actionElement):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::widget):
(WebCore::AccessibilityRenderObject::visiblePositionForPoint):
(WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::renderObjectIsObservable):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addChildren):
(WebCore::msaaRoleForRenderer):
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.cpp: (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
- accessibility/AccessibilityTable.h:
- Remove unneeded "using namespace std".
- 3:07 PM Changeset in webkit [64873] by
-
- 12 edits2 adds in trunk/WebCore
2010-08-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Factor an AsyncScriptRunner out of Document
https://bugs.webkit.org/show_bug.cgi?id=43633
This copies the existing implementation exactly. In the future
this will use PendingScript which handles ref counting without
the need for those manual ref()/deref()s. This is also currently
a trivial class, but a little more logic will be added to it to
support <script async>.
No new tests because no new functionality.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/AsyncScriptRunner.cpp: Added. (WebCore::AsyncScriptRunner::AsyncScriptRunner): (WebCore::AsyncScriptRunner::~AsyncScriptRunner): (WebCore::AsyncScriptRunner::executeScriptSoon): (WebCore::AsyncScriptRunner::suspend): (WebCore::AsyncScriptRunner::resume): (WebCore::AsyncScriptRunner::timerFired):
- dom/AsyncScriptRunner.h: Added. (WebCore::AsyncScriptRunner::create): (WebCore::AsyncScriptRunner::hasPendingScripts):
- dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
- dom/Document.h: (WebCore::Document::asyncScriptRunner):
- dom/ScriptElement.cpp: (WebCore::ScriptElementData::notifyFinished):
- page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
- 2:58 PM Changeset in webkit [64872] by
-
- 9 edits in trunk/WebCore
2010-08-06 James Robinson <jamesr@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Implement GLES2Canvas/Texture in terms of GraphicsContext3D instead of direct OpenGL calls
https://bugs.webkit.org/show_bug.cgi?id=43608
This converts all OpenGL calls in GLES2(Canvas|Texture) to calls on the corresponding GraphicsContext3D
API, due to feedback on https://bugs.webkit.org/show_bug.cgi?id=43362. Nearly all the changes are
applying the regex s/gl([A-Z])/m_context->%1</ and removing unnecessary makeCurrent() calls.
Other changes hilighted below.
- platform/graphics/chromium/GLES2Canvas.cpp:
(WebCore::affineTo3x3):
(WebCore::GLES2Canvas::GLES2Canvas):
(WebCore::GLES2Canvas::~GLES2Canvas):
(WebCore::GLES2Canvas::clearRect):
(WebCore::GLES2Canvas::fillRect):
(WebCore::GLES2Canvas::drawTexturedRect):
(WebCore::GLES2Canvas::applyCompositeOperator):
(WebCore::GLES2Canvas::getQuadVertices):
(WebCore::GLES2Canvas::getQuadIndices):
- use new typed XXArray classes for buffer uploads
(WebCore::loadShader):
(WebCore::GLES2Canvas::getSimpleProgram):
(WebCore::GLES2Canvas::getTexProgram):
(WebCore::GLES2Canvas::createTexture):
(WebCore::GLES2Canvas::checkGLError):
- platform/graphics/chromium/GLES2Canvas.h: (WebCore::GLES2Canvas::context):
- platform/graphics/chromium/GLES2Texture.cpp: (WebCore::GLES2Texture::GLES2Texture): (WebCore::GLES2Texture::~GLES2Texture): (WebCore::GLES2Texture::create): (WebCore::convertFormat): (WebCore::GLES2Texture::load): (WebCore::GLES2Texture::bind):
- platform/graphics/chromium/GLES2Texture.h:
- platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::fillRect):
- add a missing restore() call to the H/W path
- platform/graphics/skia/ImageSkia.cpp: (WebCore::drawBitmapGLES2):
- platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::setGraphicsContext3D):
(WebCore::PlatformContextSkia::uploadSoftwareToHardware):
- avoid applying CTM to uploads
(WebCore::PlatformContextSkia::readbackHardwareToSoftware):
- platform/graphics/skia/PlatformContextSkia.h:
- 2:52 PM Changeset in webkit [64871] by
-
- 9 edits in trunk/WebKit2
Detect invalid CoreIPC messages and call didReceiveInvalidMessage
https://bugs.webkit.org/show_bug.cgi?id=43643
<rdar://problem/7891069>
Reviewed by Adam Roben.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::alignBufferPosition):
If we can't correctly align the buffer position, mark the decoder as invalid.
- Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::isInvalid):
Check if the argument decoder is valid.
(CoreIPC::ArgumentDecoder::markInvalid):
Mark the argument decoder as invalid, by setting its buffer position past its end position.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchMessages):
Check if m_client is null before dispatching messages. If an argument decoder was marked invalid, call
Connection::Client::didReceiveInvalidMessage.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::Message::releaseArguments):
Rename destroy to releaseArguments and make it return a PassOwnPtr.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::~WebProcessProxy):
Call releaseArguments instead of destroy.
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
Kill the web process and invalidate its connection.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveInvalidMessage):
Don't do anything, if the UI process is sending invalid messages there's not much we can do.
- WebProcess/WebProcess.h:
- 2:49 PM Changeset in webkit [64870] by
-
- 12 edits2 moves in trunk
2010-08-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Composited canvas should be treated the same by the compositor and not be WebGL specific
https://bugs.webkit.org/show_bug.cgi?id=43589
Initializes the platformLayer as a CanvasLayerChromium, not a WebGLLayerChromium.
The layer itself isn't WebGL-specific.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformLayer): (WebCore::GraphicsContext3D::platformLayer):
2010-08-06 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Composited canvas should be treated the same by the compositor and not be WebGL specific
https://bugs.webkit.org/show_bug.cgi?id=43589
This treats all GraphicsContext3D-backed layers the same instead of special casing WebGL.
The cross-platform change is to rename GraphicsLayer::setContentsToWebGL() to
GraphicsLayer::setContentsToCanvas() and to rename all implementations.
This patch also renames the chromium class used for accelerating these layers.
Cross platform changes:
- WebCore.gypi:
- platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::setContentsToCanvas):
Rename the function on the base class. GraphicsLayerCA and GraphicsLayerChromium implement this.
- rendering/RenderLayerBacking.cpp: (WebCore::isAcceleratedCanvas):
Helper function to see if a renderer is associated with an accelerated compositing layer.
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::containsPaintedContent):
(WebCore::RenderLayerBacking::rendererContentChanged):
Chromium specific changes:
- platform/graphics/chromium/CanvasLayerChromium.cpp: Added. (WebCore::CanvasLayerChromium::create): (WebCore::CanvasLayerChromium::CanvasLayerChromium): (WebCore::CanvasLayerChromium::textureId): (WebCore::CanvasLayerChromium::updateTextureContents): (WebCore::CanvasLayerChromium::setContext):
- platform/graphics/chromium/CanvasLayerChromium.h: Added. (WebCore::CanvasLayerChromium::drawsContent): (WebCore::CanvasLayerChromium::ownsTexture): (WebCore::CanvasLayerChromium::shaderProgramId): (WebCore::CanvasLayerChromium::setShaderProgramId):
- platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::setContentsNeedsDisplay): (WebCore::GraphicsLayerChromium::setContentsToCanvas):
- platform/graphics/chromium/GraphicsLayerChromium.h: (WebCore::GraphicsLayerChromium::):
- platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawLayer): (WebCore::LayerRendererChromium::initializeSharedGLObjects):
- platform/graphics/chromium/LayerRendererChromium.h: (WebCore::LayerRendererChromium::):
- platform/graphics/chromium/WebGLLayerChromium.cpp: Removed.
- platform/graphics/chromium/WebGLLayerChromium.h: Removed. Mac specific changes:
- platform/graphics/mac/GraphicsLayerCA.h: (WebCore::GraphicsLayerCA::):
- platform/graphics/mac/GraphicsLayerCA.mm: (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): (WebCore::GraphicsLayerCA::updateContentsCanvasLayer): (WebCore::GraphicsLayerCA::setContentsToCanvas):
- 2:45 PM Changeset in webkit [64869] by
-
- 3 edits in trunk/WebCore
2010-08-06 Patrick Gansterer <paroga@paroga.com>
Reviewed by Eric Seidel.
Add PluginView::bindingInstance() to PluginViewNone
https://bugs.webkit.org/show_bug.cgi?id=42936
- bindings/js/ScriptControllerEfl.cpp: (WebCore::ScriptController::createScriptInstanceForWidget): Removed workaround.
- plugins/PluginViewNone.cpp: Added property svn:eol-style. (WebCore::PluginView::bindingInstance): Added missing method and use it on WinCE.
- 2:22 PM Changeset in webkit [64868] by
-
- 2 edits in trunk/WebKit/mac
2010-08-06 Yongjun Zhang <yongjun_zhang@apple.com>
Reviewed by Eric Seidel.
add "const" to WebChromeClient::webView().
https://bugs.webkit.org/show_bug.cgi?id=43631
Change WebChromeClient::webView() to be const because ChromeClient::didReceiveViewportArguments
is const method now, and calling webView() inside port-specific didReceiveViewportArguments
implementation fails compiling if webView() is not const.
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
- 1:40 PM Changeset in webkit [64867] by
-
- 9 edits in trunk/WebKit2
Add CoreIPC::MessageReceiver class
https://bugs.webkit.org/show_bug.cgi?id=43637
Reviewed by Adam Roben.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::MessageReceiver::~MessageReceiver):
Add MessageReceiver class and make Client inherit from it.
(CoreIPC::Connection::MessageReceiver::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
- UIProcess/ChunkedUpdateDrawingAreaProxy.h:
Remove ChunkedUpdateDrawingAreaProxy::didReceiveSyncMessage.
- Shared/DrawingAreaBase.h:
Include "Connection.h" instead.
- UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::didReceiveSyncMessage):
Change didReceiveSyncMessage from being a pure virtual member function and make it
assert by default instead.
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
Remove didReceiveSyncMessage.
- 1:20 PM Changeset in webkit [64866] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-06 Rafael Antognolli <antognolli@profusion.mobi>
[EFL] Build fix.
- CMakeLists.txt: add runtime/CGHandle.cpp.
- 12:59 PM Changeset in webkit [64865] by
-
- 4 edits in trunk
2010-08-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Use new "package" name also for the directory where the inspector
support files are installed.
- GNUmakefile.am:
WebKit/gtk
2010-08-06 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Use the new paths, and also fix the path for localizedStrings.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend): (WebKit::InspectorFrontendClient::localizedStringsURL):
- 12:27 PM Changeset in webkit [64864] by
-
- 2 edits in trunk/WebCore
Fix chromium build break.
- inspector/InspectorDebuggerAgent.h:
- 12:21 PM Changeset in webkit [64863] by
-
- 2 edits in trunk/WebCore
2010-08-06 Dirk Schulze <krit@webkit.org>
Not reviewed. Sort XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 11:54 AM Changeset in webkit [64862] by
-
- 8 edits2 adds in trunk/WebKit2
Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
Unreviewed.
Patch by Jessie Berlin <jberlin@apple.com> on 2010-08-06
- UIProcess/PageClient.h:
- UIProcess/VisitedLinkProvider.h:
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebHistoryClient.h:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPolicyClient.h:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.h:
- UIProcess/win/WebView.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/Plugins/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.h:
- 11:49 AM Changeset in webkit [64861] by
-
- 285 edits in trunk
2010-08-06 Jessie Berlin <jberlin@apple.com>
Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
Unreviewed.
- 11:21 AM Changeset in webkit [64860] by
-
- 9 edits4 adds in trunk/LayoutTests
Update chromium test results.
- platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.checksum: Added.
- platform/chromium-linux/svg/custom/path-zero-strokewidth-expected.png: Added.
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
- platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
- platform/chromium-win/svg/custom/path-zero-strokewidth-expected.checksum: Added.
- platform/chromium-win/svg/custom/path-zero-strokewidth-expected.png: Added.
- platform/chromium/test_expectations.txt:
- 11:03 AM Changeset in webkit [64859] by
-
- 6 edits in trunk
2010-08-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
WebGLBuffer::associateBufferData(ArrayBufferView* array) copies incorrect data for sliced views
https://bugs.webkit.org/show_bug.cgi?id=42124
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::associateBufferDataImpl): Helper function that's called by all associateBufferData(). (WebCore::WebGLBuffer::associateBufferData): Call associateBufferDataImpl(). (WebCore::WebGLBuffer::associateBufferSubDataImpl): Helper function that's called by all associateBufferSubData(). (WebCore::WebGLBuffer::associateBufferSubData): Call associateBufferSubDataImpl().
- html/canvas/WebGLBuffer.h: Declare helper functions.
2010-08-04 Zhenyao Mo <zmo@google.com>
Reviewed by Dimitri Glazkov.
WebGLBuffer::associateBufferData(ArrayBufferView* array) copies incorrect data for sliced views
https://bugs.webkit.org/show_bug.cgi?id=42124
- fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Adding test case for bufferData and bufferSubData with ArrayBufferView input.
- fast/canvas/webgl/draw-elements-out-of-bounds.html: Ditto.
- 10:58 AM Changeset in webkit [64858] by
-
- 3 edits in trunk/WebCore
2010-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
noembed should respect whether plugins are enabled
https://bugs.webkit.org/show_bug.cgi?id=43611
This instruction isn't in the HTML5 spec, but it seems like the right
thing to do. I suspect this is because the spec doesn't understand
that plugins can be disabled.
I'm not sure how we can test this in DumpRenderTree, but I'm open to
suggestions.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::adjustedLexerState): (WebCore::HTMLTreeBuilder::processStartTagForInBody): (WebCore::HTMLTreeBuilder::processStartTagForInHead): (WebCore::HTMLTreeBuilder::scriptEnabled): (WebCore::HTMLTreeBuilder::pluginsEnabled):
- html/HTMLTreeBuilder.h:
- 10:35 AM Changeset in webkit [64857] by
-
- 10 edits2 adds in trunk/WebCore
2010-08-06 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Adam Barth.
Factor out PendingScript and protect its members
https://bugs.webkit.org/show_bug.cgi?id=43391
This will be shared by AsyncScriptRunner.
No new tests because no new functionality.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/PendingScript.cpp: Added. (WebCore::PendingScript::~PendingScript): (WebCore::PendingScript::element): (WebCore::PendingScript::releaseElementAndClear): (WebCore::PendingScript::setCachedScript): (WebCore::PendingScript::cachedScript):
- dom/PendingScript.h: Added. (WebCore::PendingScript::PendingScript): (WebCore::PendingScript::startingLineNumber): (WebCore::PendingScript::watchingForLoad): (WebCore::PendingScript::setWatchingForLoad): (WebCore::PendingScript::hasElement): (WebCore::PendingScript::adoptElement): (WebCore::PendingScript::notifyFinished):
- html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): (WebCore::HTMLScriptRunner::haveParsingBlockingScript): (WebCore::HTMLScriptRunner::requestScript):
- html/HTMLScriptRunner.h:
- 9:51 AM Changeset in webkit [64856] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-06 Jessie Berlin <jberlin@apple.com>
Windows Build Fix (continued). Unreviewed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 9:43 AM Changeset in webkit [64855] by
-
- 2 edits in trunk/WebCore
2010-08-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Darin Adler.
Change permission to access methods in XMLDocumentParser.h
https://bugs.webkit.org/show_bug.cgi?id=43180
Change permission to access wellFormed(), lineNumber() and columnNumber()
in XMLDocumentParser.h. Because, the methods are used by WML.
- dom/XMLDocumentParser.h: (WebCore::XMLDocumentParser::wellFormed): Change accebility permission.
- 9:09 AM Changeset in webkit [64854] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-06 Jessie Berlin <jberlin@apple.com>
Windows Build Fix. Unreviewed.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add GCHandle.h and GCHandle.cpp.
- 9:02 AM Changeset in webkit [64853] by
-
- 2 edits in trunk
2010-08-06 ryuan choi <ryuan.choi@samsung.com>
Reviewed by Antonio Gomes.
[EFL] Regression (64763) build fix for efl.
https://bugs.webkit.org/show_bug.cgi?id=43597
change ENABLE_BLOB_SLICE to ENABLE_BLOB for fixing build break
- cmake/OptionsEfl.cmake:
- 8:59 AM Changeset in webkit [64852] by
-
- 5 edits4 adds in trunk
2010-08-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Support for image drags
https://bugs.webkit.org/show_bug.cgi?id=40788
Unskip and add baselines for tests that are now passing with image drag support.
- platform/gtk/Skipped:
- platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
- platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
- platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt: Added.
- platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt: Added.
2010-08-06 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Support for image drags
https://bugs.webkit.org/show_bug.cgi?id=40788
Add image drag-and-drop support for WebKit GTK+.
- platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::setDragImage): Filled this stub. (WebCore::ClipboardGtk::setDragImageElement): Filled this stub. (WebCore::ClipboardGtk::createDragImage): Filled this stub. (WebCore::ClipboardGtk::declareAndWriteDragImage): Write the image URL, markup, and image itself to the data object member.
- platform/gtk/ClipboardGtk.h: Brought method declarations into line with the parent class.
- 8:30 AM Changeset in webkit [64851] by
-
- 3 edits in trunk/WebKit/chromium
2010-08-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium: disable device motion by default.
- public/WebRuntimeFeatures.h:
- src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableDeviceMotion): (WebKit::WebRuntimeFeatures::isDeviceMotionEnabled): (WebKit::WebRuntimeFeatures::enableDeviceOrientation):
- 7:59 AM Changeset in webkit [64850] by
-
- 3 edits in trunk/LayoutTests
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline win specific getComputedStyle* results, after r64832.
- platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 7:55 AM Changeset in webkit [64849] by
-
- 10 edits2 adds in trunk/JavaScriptCore
2010-08-06 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Geoffrey Garen.
WeakGCPtr's should instead of directly pointing to the GC'd object
should be directed to an array of pointers that can be updated for
movable objects.
- Android.mk:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/Collector.cpp: (JSC::Heap::destroy): (JSC::Heap::allocateBlock): (JSC::Heap::freeBlock): (JSC::Heap::updateWeakGCHandles): (JSC::WeakGCHandlePool::update): (JSC::Heap::addWeakGCHandle): (JSC::Heap::markRoots):
- runtime/Collector.h: (JSC::Heap::weakGCHandlePool):
- runtime/GCHandle.cpp: Added. (JSC::WeakGCHandle::pool): (JSC::WeakGCHandlePool::WeakGCHandlePool): (JSC::WeakGCHandlePool::allocate): (JSC::WeakGCHandlePool::free): (JSC::WeakGCHandlePool::operator new):
- runtime/GCHandle.h: Added. (JSC::WeakGCHandle::isValidPtr): (JSC::WeakGCHandle::isPtr): (JSC::WeakGCHandle::isNext): (JSC::WeakGCHandle::invalidate): (JSC::WeakGCHandle::get): (JSC::WeakGCHandle::set): (JSC::WeakGCHandle::getNextInFreeList): (JSC::WeakGCHandle::setNextInFreeList): (JSC::WeakGCHandlePool::isFull):
- runtime/WeakGCPtr.h: (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::~WeakGCPtr): (JSC::WeakGCPtr::get): (JSC::WeakGCPtr::clear): (JSC::WeakGCPtr::assign): (JSC::get):
- 7:44 AM Changeset in webkit [64848] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Rebaseline gtk specific getComputedStyle-basic.html result, after r64832.
- platform/gtk/svg/css/getComputedStyle-basic-expected.txt:
- 7:16 AM Changeset in webkit [64847] by
-
- 1 copy in releases/WebKitGTK/webkit-1.3.3
Way late tagging of 1.3.3.
- 7:00 AM Changeset in webkit [64846] by
-
- 14 edits2 adds in trunk/WebCore
2010-08-06 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract debugger implementation into InspectorDebuggerAgent
https://bugs.webkit.org/show_bug.cgi?id=42340
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::enableDebuggerFromFrontend): (WebCore::InspectorController::disableDebugger): (WebCore::InspectorController::resume): (WebCore::InspectorController::loadBreakpoints): (WebCore::InspectorController::saveBreakpoints):
- inspector/InspectorController.h: (WebCore::InspectorController::debuggerAgent):
- inspector/InspectorDebuggerAgent.cpp: Added. (WebCore::md5Base16): (WebCore::formatBreakpointId): (WebCore::InspectorDebuggerAgent::create): (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent): (WebCore::InspectorDebuggerAgent::isDebuggerAlwaysEnabled): (WebCore::InspectorDebuggerAgent::activateBreakpoints): (WebCore::InspectorDebuggerAgent::deactivateBreakpoints): (WebCore::InspectorDebuggerAgent::setBreakpoint): (WebCore::InspectorDebuggerAgent::removeBreakpoint): (WebCore::InspectorDebuggerAgent::editScriptSource): (WebCore::InspectorDebuggerAgent::getScriptSource): (WebCore::InspectorDebuggerAgent::pause): (WebCore::InspectorDebuggerAgent::resume): (WebCore::InspectorDebuggerAgent::stepOverStatement): (WebCore::InspectorDebuggerAgent::stepIntoStatement): (WebCore::InspectorDebuggerAgent::stepOutOfFunction): (WebCore::InspectorDebuggerAgent::setPauseOnExceptionsState): (WebCore::InspectorDebuggerAgent::clearForPageNavigation): (WebCore::InspectorDebuggerAgent::currentCallFrames): (WebCore::InspectorDebuggerAgent::loadBreakpoints): (WebCore::InspectorDebuggerAgent::saveBreakpoints): (WebCore::InspectorDebuggerAgent::didParseSource): (WebCore::InspectorDebuggerAgent::failedToParseSource): (WebCore::InspectorDebuggerAgent::didPause): (WebCore::InspectorDebuggerAgent::didContinue): (WebCore::InspectorDebuggerAgent::remoteFrontend):
- inspector/InspectorDebuggerAgent.h: Added.
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
- 6:38 AM Changeset in webkit [64845] by
-
- 35 edits22 adds in trunk
2010-08-06 Dean Jackson <dino@apple.com>
Reviewed by Simon Fraser and Steve Block.
https://bugs.webkit.org/show_bug.cgi?id=42865
Implement DeviceMotionEvent
Implement the DeviceMotionEvent interface as defined
in http://dev.w3.org/geo/api/spec-source-orientation.html
This is currently an empty implementation, in that there is
no motion client connected - the platform implementations
will need to do that.
Tests: fast/dom/DeviceMotion/create-event.html
fast/dom/DeviceMotion/optional-event-properties.html
fast/dom/DeviceMotion/window-property.html
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.jscbindings.mk:
- Android.mk:
- Android.v8bindings.mk:
- CMakeLists.txt:
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- Add new files for DeviceMotionEvent build support
- bindings/generic/RuntimeEnabledFeatures.cpp:
- bindings/generic/RuntimeEnabledFeatures.h:
- new runtime flags for device motion
- bindings/js/JSDeviceMotionEventCustom.cpp: Added.
- bindings/v8/custom/V8DeviceMotionEventCustom.cpp: Added.
- Custom JS binding to translate property access through to the DeviceMotionData object that the Event holds
- bindings/js/JSEventCustom.cpp:
- Include the custom code for DeviceMotionEvent
- dom/DeviceMotionClient.h: Added.
- Pure virtual client for DeviceMotion access
- dom/DeviceMotionController.cpp: Added.
- dom/DeviceMotionController.h: Added.
- Controller class that manages event dispatch
- dom/DeviceMotionData.cpp: Added.
- dom/DeviceMotionData.h: Added.
- Representation of the data that comes from a device motion client that is then used within the event.
- dom/DeviceMotionEvent.cpp: Added.
- dom/DeviceMotionEvent.h: Added.
- dom/DeviceMotionEvent.idl: Added.
- The actual event implementation
- dom/Document.cpp:
(WebCore::Document::createEvent):
- Update createEvent to allow "devicemotion" events
- dom/Event.cpp:
- dom/Event.h:
- isDeviceMotionEvent virtual method
- dom/EventNames.h:
- new "devicemotion" event type
- page/DOMWindow.cpp: (WebCore::DOMWindow::addEventListener):
- page/DOMWindow.h:
- page/DOMWindow.idl:
- allow creation of "devicemotion" events and pass registration through to the Page's deviceMotionController object
- page/Page.cpp:
- page/Page.h:
- new PageClient for deviceMotionController
Layout Tests:
- fast/dom/Window/window-properties-device-orientation-expected.txt:
- fast/dom/Window/window-properties-device-orientation.html:
- fast/dom/Window/window-properties.html:
Add some tests for the DeviceMotionEvent interface.
- fast/dom/DeviceMotion/create-event-expected.txt: Added.
- fast/dom/DeviceMotion/create-event.html: Added.
- fast/dom/DeviceMotion/optional-event-properties-expected.txt: Added.
- fast/dom/DeviceMotion/optional-event-properties.html: Added.
- fast/dom/DeviceMotion/script-tests/TEMPLATE.html: Added.
- fast/dom/DeviceMotion/script-tests/create-event.js: Added.
- fast/dom/DeviceMotion/script-tests/optional-event-properties.js: Added.
- fast/dom/DeviceMotion/script-tests/window-property.js: Added.
- fast/dom/DeviceMotion/window-property-expected.txt: Added.
- fast/dom/DeviceMotion/window-property.html: Added.
Make sure these are skipped on Mac, Win, GTK and QT.
- platform/gtk/Skipped:
- platform/mac/Skipped:
- platform/qt/Skipped:
- platform/win/Skipped:
- 6:29 AM Changeset in webkit [64844] by
-
- 5 edits in trunk
2010-08-06 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI.
https://bugs.webkit.org/show_bug.cgi?id=43450
- inspector/front-end/ApplicationCacheItemsView.js: (WebInspector.ApplicationCacheItemsView): (WebInspector.ApplicationCacheItemsView.prototype.get statusBarItems): (WebInspector.ApplicationCacheItemsView.prototype.updateNetworkState):
- inspector/front-end/Settings.js:
2010-08-06 Kavita Kanetkar <kkanetkar@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: Remove "Online/Offline" icon for Chrome's appcache devtools UI.
https://bugs.webkit.org/show_bug.cgi?id=43450
- src/js/DevTools.js: (WebInspector.loaded):
- 6:22 AM Changeset in webkit [64843] by
-
- 8 edits in trunk/WebKitTools
2010-08-06 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Should revoke scheduled tasks
https://bugs.webkit.org/show_bug.cgi?id=43560
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::reset): Calls RevokeAll().
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::reset): Calls RevokeAll().
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- DumpRenderTree/chromium/EventSender.cpp: (EventSender::reset): Calls RevokeAll().
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::reset): Calls RevokeAll().
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::resetTestController): Calls DRTDevToolsAgent::reset() and DRTDevToolsClient::reset().
- 6:07 AM Changeset in webkit [64842] by
-
- 2 edits in trunk/JavaScriptCore
[Qt] Fix warnings about difference in symbol visiblity on Mac OS X
Reviewed by Antonio Gomes.
- jsc.pro:
- 6:07 AM Changeset in webkit [64841] by
-
- 2 edits in trunk/WebKitTools
[Qt] Fix the DRT build on Mac OS X
Reviewed by Antonio Gomes.
- DumpRenderTree/qt/DumpRenderTree.pro:
- 5:59 AM Changeset in webkit [64840] by
-
- 34 edits4 adds in trunk
2010-08-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rolling out 64835, 64836 and 64839.
- 5:25 AM Changeset in webkit [64839] by
-
- 2 edits in trunk/WebCore
Unreviewed, fix the "GTK Linux 64-bit Debug" bot.
CodeGeneratorGObject.pm doesn't know yet how to auto-generate
callbacks, so we should not auto-generate functions that take
callbacks as parameters. This shouldn't break anything, because
all these functions were marked as Custom? until now, and this
code generator skipped those functions anyway.
- bindings/scripts/CodeGeneratorGObject.pm:
- 5:13 AM Changeset in webkit [64838] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
<noscript> is not allowed inside <p>
https://bugs.webkit.org/show_bug.cgi?id=43440
Add a test that we now we parse this example correctly.
- html5lib/resources/webkit02.dat:
- 5:04 AM Changeset in webkit [64837] by
-
- 3 edits in trunk/LayoutTests
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed, forgot to land these new results in my last commit.
SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 5:00 AM Changeset in webkit [64836] by
-
- 2 edits in trunk/WebCore
Unreviewed, "Qt Linux Realese minimal" build fix.
- bindings/scripts/CodeGeneratorJS.pm:
- 4:47 AM Changeset in webkit [64835] by
-
- 33 edits4 deletes in trunk
WebCore: Auto-generate all HTML5 DB bindings.
https://bugs.webkit.org/show_bug.cgi?id=43382
Reviewed by Adam Barth.
- Android.jscbindings.mk: Remove {JS|V8}Database{Sync}Custom.cpp
and the custom implementations of openDatabas{Sync}().
- Android.v8bindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowCustom.cpp:
- bindings/js/JSDatabaseCustom.cpp: Removed.
- bindings/js/JSDatabaseSyncCustom.cpp: Removed.
- bindings/js/JSWorkerContextCustom.cpp:
- bindings/v8/custom/V8DOMWindowCustom.cpp:
- bindings/v8/custom/V8DatabaseCustom.cpp: Removed.
- bindings/v8/custom/V8DatabaseSyncCustom.cpp: Removed.
- bindings/v8/custom/V8WorkerContextCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm: Change the code generators
to check that a value was passed for each non-optional argument,
and that the value can be converted to the argument type.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp:
(WebCore::JSTestCallback::~JSTestCallback):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback):
(WebCore::TestObjInternal::intMethodWithArgsCallback):
(WebCore::TestObjInternal::objMethodWithArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsCallback):
(WebCore::TestObjInternal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjInternal::serializedValueCallback):
(WebCore::TestObjInternal::idbKeyCallback):
(WebCore::TestObjInternal::customArgsAndExceptionCallback):
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback):
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback):
(WebCore::TestObjInternal::methodWithOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback):
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback):
(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
(WebCore::TestObjInternal::overloadedMethod1Callback):
(WebCore::TestObjInternal::overloadedMethod2Callback):
(WebCore::TestObjInternal::overloadedMethod3Callback):
(WebCore::TestObjInternal::overloadedMethod4Callback):
(WebCore::):
(WebCore::ConfigureV8TestObjTemplate):
- bindings/v8/V8Binding.h:
(WebCore::String):
(WebCore::AtomicString):
- page/DOMWindow.idl: Minor changes required by the auto-generated
bindings.
- storage/Database.cpp:
(WebCore::Database::transaction):
(WebCore::Database::readTransaction):
(WebCore::Database::runTransaction):
- storage/Database.h:
- storage/Database.idl:
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::transaction):
(WebCore::DatabaseSync::readTransaction):
(WebCore::DatabaseSync::runTransaction):
- storage/DatabaseSync.h:
- storage/DatabaseSync.idl:
- workers/WorkerContext.idl:
LayoutTests: Cosmetic changes to two tests.
https://bugs.webkit.org/show_bug.cgi?id=43382
Reviewed by Adam Barth.
- fast/workers/storage/open-database-inputs-sync-expected.txt:
- fast/workers/storage/resources/open-database-inputs-sync.js:
- storage/null-callbacks.html:
- 4:43 AM Changeset in webkit [64834] by
-
- 2 edits in trunk/WebCore
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Sort XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 4:41 AM Changeset in webkit [64833] by
-
- 2 edits in trunk/LayoutTests
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Skip another hyphens* test to turn Leopard green again.
fast/text/hyphen* tests have different results on Leopard
https://bugs.webkit.org/show_bug.cgi?id=43296
- platform/mac-leopard/Skipped:
- 4:30 AM Changeset in webkit [64832] by
-
- 2 edits in trunk/WebCore
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Fix warning, breaking win build.
- svg/SVGLength.cpp: (WebCore::SVGLength::toCSSPrimitiveValue):
- 4:23 AM Changeset in webkit [64831] by
-
- 2 edits in trunk/WebCore
Fix crashing Leopard and Gtk bots.
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Don't register ISO8859-16, because older versions of ICU don't support ISO-8859-16, causing crashes when we try to register an alias. Also, we don't need it, because Firefox doesn't support this particular alias (it supports ISO8859-1 to ISO8859-15, but only supports the main name for ISO-8859-16).
- 4:21 AM Changeset in webkit [64830] by
-
- 25 edits4 adds in trunk
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387
Stop storing refcounted CSSValue/CSSValueList objects in SVGRenderStyle, replacing them with SVGLength types.
Allows us to directly specify default values for stroke-dashoffset/width in the SVGRenderStyle, fixing a problem
with stroke-width animations when resetting to the original stored baseVal, exposed in svg/W3C-1.1/animate-elem-40-t.svg
Originally discovered by Fady Samuel.
Test: svg/custom/path-zero-strokewidth.svg
- css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::strokeDashArrayToCSSValueList): New helper function converting from Vector<SVGLength> to CSSValueList. (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue): Convert SVGLength values to CSSPrimitiveValues.
- css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty): Convert CSSPrimitiveValues to SVGLength objects, for SVGRenderStyle storage.
- rendering/RenderPath.cpp: (WebCore::RenderPath::calculateMarkerBoundsIfNeeded): Just grab strokeWidth SVGLength value from SVGRenderSTyle, no need to call cssPrimitiveToLength anymore.
- rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::strokeBoundingBox): Ditto.
- rendering/SVGCharacterLayoutInfo.cpp: (WebCore::calculateBaselineShift): Ditto (for baseline-shift).
- rendering/SVGInlineTextBox.cpp: (WebCore::SVGInlineTextBox::buildLayoutInformation): Ditto (for kerning).
- rendering/SVGRenderSupport.cpp: (WebCore::SVGRenderSupport::applyStrokeStyleToContext): Ditto (for stroke-width/stroke-dashoffset/stroke-dasharray).
- rendering/SVGRenderSupport.h:
- rendering/SVGRenderTreeAsText.cpp: (WebCore::writeStyle): Ditto.
- rendering/SVGTextLayoutUtilities.cpp: (WebCore::calculateCSSKerning): Ditto.
- rendering/SVGTextLayoutUtilities.h:
- rendering/style/SVGRenderStyle.cpp: Remove no longer needed cssPrimitiveToLength function.
- rendering/style/SVGRenderStyle.h: Stop storing RefPtr<CSSValue> / RefPtr<CSSValueList> but use SVGLength/Vector<SVGLength>. (WebCore::SVGRenderStyle::initialStrokeDashArray): Allows us to specify correct default values, instead of null pointers. (WebCore::SVGRenderStyle::initialBaselineShiftValue): Specify 0px default value. (WebCore::SVGRenderStyle::initialKerning): Ditto. (WebCore::SVGRenderStyle::initialStrokeDashOffset): Ditto. (WebCore::SVGRenderStyle::initialStrokeWidth): Specify 1px default value. (WebCore::SVGRenderStyle::setStrokeDashArray): Takes a Vector<SVGLength> now, not a PassRefPtr<CSSValueList>. (WebCore::SVGRenderStyle::setStrokeWidth): Takes a SVGLength now, not a PassRefPtr<CSSValue>. (WebCore::SVGRenderStyle::setStrokeDashOffset): Ditto. (WebCore::SVGRenderStyle::setKerning): Ditto. (WebCore::SVGRenderStyle::setStopColor): Pass Color as const-reference. (WebCore::SVGRenderStyle::setFloodColor): Ditto. (WebCore::SVGRenderStyle::setLightingColor): Ditto. (WebCore::SVGRenderStyle::setBaselineShiftValue): Takes a SVGLength now, not a PassRefPtr<CSSValue>. (WebCore::SVGRenderStyle::setShadow): Reformat, had wrong style. (WebCore::SVGRenderStyle::setClipperResource): Pass String as const-reference. (WebCore::SVGRenderStyle::setFilterResource): Ditto. (WebCore::SVGRenderStyle::setMaskerResource): Ditto. (WebCore::SVGRenderStyle::setMarkerStartResource): Ditto. (WebCore::SVGRenderStyle::setMarkerMidResource): Ditto. (WebCore::SVGRenderStyle::setMarkerEndResource): Ditto. (WebCore::SVGRenderStyle::strokeDashArray): Return Vector<SVGLength>. (WebCore::SVGRenderStyle::strokeWidth): Return SVGLength. (WebCore::SVGRenderStyle::strokeDashOffset): Ditto. (WebCore::SVGRenderStyle::kerning): Ditto. (WebCore::SVGRenderStyle::baselineShiftValue): Ditto.
- rendering/style/SVGRenderStyleDefs.cpp: (WebCore::StyleStrokeData::StyleStrokeData): Changed initialization order, to group stroke properties.
- rendering/style/SVGRenderStyleDefs.h: Store SVGLength values instead of reference counted CSS objects.
- svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): Add copy constructor. (WebCore::SVGLength::operator==): Add comparision operator. (WebCore::SVGLength::operator!=): Ditto. (WebCore::SVGLength::fromCSSPrimitiveValue): New static helper function to convert from a CSSPrimitiveValue. (WebCore::SVGLength::toCSSPrimitiveValue): New static helper function to convert to a CSSPrimitiveValue.
- svg/SVGLength.h: Reindent.
2010-08-06 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
SVG - stroke-width:0 bug with stroke other than "none"
https://bugs.webkit.org/show_bug.cgi?id=42387
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.checksum: Updated result, as fill="freeze" and stroke-width now works as expected.
- platform/mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png: Ditto.
- platform/mac/fast/css/getComputedStyle/computed-style-expected.txt: kerning reports 0, stroke-dashoffset 0, stroke-width 1 instead of empty values.
- platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Ditto.
- platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Updated result, as fill="freeze" and stroke-width now works as expected.
- platform/mac/svg/custom/path-zero-strokewidth-expected.checksum: Added.
- platform/mac/svg/custom/path-zero-strokewidth-expected.png: Added.
- platform/mac/svg/custom/path-zero-strokewidth-expected.txt: Added.
- svg/css/getComputedStyle-basic-expected.txt: An empty stroke-dasharray reports "none", as defined in the spec now.
- svg/custom/path-zero-strokewidth.svg: Added.
- 4:15 AM Changeset in webkit [64829] by
-
- 11 edits3 moves1 add3 deletes in trunk
2010-08-06 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=43427
After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.
PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
to WebKit/qt/WebCoreSupport as well.
All classes that previously inherited from QtAbstractWebPopup now inherit from
QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
instance of class QWebSelectMethod instead of QtAbstractWebPopup.
- WebCore.pro:
- platform/qt/PopupMenuQt.cpp: Removed.
- platform/qt/PopupMenuQt.h: Removed.
- platform/qt/QtAbstractWebPopup.cpp: Removed.
- platform/qt/QtAbstractWebPopup.h: Removed.
- platform/qt/SearchPopupMenuQt.cpp: Removed.
- platform/qt/SearchPopupMenuQt.h: Removed.
2010-08-06 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Move Qt's popup menu implementation from WebCore to WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=43427
After PopupMenu changes in bug 42592 class QtAbstractWebPopup became unecessary and
there is no need to keep any Qt specific code for popup menus in WebCore/platform/qt.
PopupMenuQt has been moved from WebCore/platform/qt to WebKit/qt/WebCoreSupport and
assumed the responsibilities of QtAbstractWebPopup. SearchPopupMenuQt has been moved
to WebKit/qt/WebCoreSupport as well.
All classes that previously inherited from QtAbstractWebPopup now inherit from
QWebSelectMethod and QtPlatformPlugin's method createSelectInputMethod now returns an
instance of class QWebSelectMethod instead of QtAbstractWebPopup.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createSelectPopup): (WebCore::ChromeClientQt::createPopupMenu): (WebCore::ChromeClientQt::createSearchPopupMenu):
- WebCoreSupport/ChromeClientQt.h:
- WebCoreSupport/PopupMenuQt.cpp: Added. (SelectData::SelectData): (SelectData::itemText): (SelectData::itemToolTip): (SelectData::itemIsEnabled): (SelectData::itemCount): (SelectData::itemIsSelected): (SelectData::multiple): (SelectData::itemType): (WebCore::PopupMenuQt::PopupMenuQt): (WebCore::PopupMenuQt::~PopupMenuQt): (WebCore::PopupMenuQt::disconnectClient): (WebCore::PopupMenuQt::show): (WebCore::PopupMenuQt::didHide): (WebCore::PopupMenuQt::hide): (WebCore::PopupMenuQt::updateFromElement): (WebCore::PopupMenuQt::selectItem):
- WebCoreSupport/PopupMenuQt.h: Added.
- WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopupCombo::hidePopup): (WebCore::QtFallbackWebPopup::QtFallbackWebPopup): (WebCore::QtFallbackWebPopup::show): (WebCore::QtFallbackWebPopup::populate): (WebCore::QtFallbackWebPopup::activeChanged): (WebCore::QtFallbackWebPopup::pageClient):
- WebCoreSupport/QtFallbackWebPopup.h: (WebCore::QtFallbackWebPopup::setGeometry): (WebCore::QtFallbackWebPopup::geometry): (WebCore::QtFallbackWebPopup::setFont): (WebCore::QtFallbackWebPopup::font):
- WebCoreSupport/QtMaemoWebPopup.cpp: (WebCore::Maemo5Popup::populateList): (WebCore::QtMaemoWebPopup::QtMaemoWebPopup): (WebCore::QtMaemoWebPopup::createSingleSelectionPopup): (WebCore::QtMaemoWebPopup::createMultipleSelectionPopup): (WebCore::QtMaemoWebPopup::createPopup): (WebCore::QtMaemoWebPopup::show): (WebCore::QtMaemoWebPopup::popupClosed): (WebCore::QtMaemoWebPopup::itemClicked): (WebCore::Maemo5SingleSelectionPopup::Maemo5SingleSelectionPopup): (WebCore::Maemo5MultipleSelectionPopup::Maemo5MultipleSelectionPopup):
- WebCoreSupport/QtMaemoWebPopup.h: (WebCore::Maemo5Popup::Maemo5Popup):
- WebCoreSupport/QtPlatformPlugin.cpp: (WebCore::QtPlatformPlugin::createSelectInputMethod):
- WebCoreSupport/QtPlatformPlugin.h:
- WebCoreSupport/SearchPopupMenuQt.cpp: Added. (WebCore::SearchPopupMenuQt::SearchPopupMenuQt): (WebCore::SearchPopupMenuQt::popupMenu): (WebCore::SearchPopupMenuQt::saveRecentSearches): (WebCore::SearchPopupMenuQt::loadRecentSearches): (WebCore::SearchPopupMenuQt::enabled):
- WebCoreSupport/SearchPopupMenuQt.h: Added.
- 3:37 AM Changeset in webkit [64828] by
-
- 38 edits13 copies3 adds in trunk
2010-08-05 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Initial bindings and plumbing for IDBCursor.
https://bugs.webkit.org/show_bug.cgi?id=41888
Test: storage/indexeddb/idb-opencursor.html
- storage/indexeddb/open-cursor-expected.txt: Added.
- storage/indexeddb/open-cursor.html: Added.
- storage/indexeddb/script-tests/open-cursor.js: Added. (cursorSuccess): (openCursor): (populateObjectStore): (createObjectStoreSuccess): (openSuccess): (test):
2010-08-05 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Initial bindings and plumbing for IDBCursor.
https://bugs.webkit.org/show_bug.cgi?id=41888
Test: storage/indexeddb/idb-opencursor.html
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- storage/IDBAny.cpp: (WebCore::IDBAny::idbCursor): (WebCore::IDBAny::set):
- storage/IDBAny.h: (WebCore::IDBAny::):
- storage/IDBCallbacks.h:
- storage/IDBCursor.cpp: Added. (WebCore::IDBCursor::IDBCursor): (WebCore::IDBCursor::~IDBCursor): (WebCore::IDBCursor::direction): (WebCore::IDBCursor::key): (WebCore::IDBCursor::value): (WebCore::IDBCursor::update): (WebCore::IDBCursor::continueFunction): (WebCore::IDBCursor::remove):
- storage/IDBCursor.h: Added. (WebCore::IDBCursor::): (WebCore::IDBCursor::create):
- storage/IDBCursor.idl: Added.
- storage/IDBCursorBackendImpl.cpp: Added. (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::direction): (WebCore::IDBCursorBackendImpl::key): (WebCore::IDBCursorBackendImpl::value): (WebCore::IDBCursorBackendImpl::update): (WebCore::IDBCursorBackendImpl::continueFunction): (WebCore::IDBCursorBackendImpl::remove):
- storage/IDBCursorBackendImpl.h: Added. (WebCore::IDBCursorBackendImpl::create):
- storage/IDBCursorBackendInterface.h: Added. (WebCore::IDBCursorBackendInterface::~IDBCursorBackendInterface):
- storage/IDBObjectStore.cpp: (WebCore::IDBObjectStore::openCursor):
- storage/IDBObjectStore.h:
- storage/IDBObjectStore.idl:
- storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::openCursor):
- storage/IDBObjectStoreBackendImpl.h:
- storage/IDBObjectStoreBackendInterface.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess): (WebCore::IDBRequest::timerFired):
- storage/IDBRequest.h:
2010-08-05 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Initial bindings and plumbing for IDBCursor.
https://bugs.webkit.org/show_bug.cgi?id=41888
Test: storage/indexeddb/idb-opencursor.html
- WebKit.gyp:
- public/WebIDBCallbacks.h: (WebKit::WebIDBCallbacks::onSuccess):
- public/WebIDBCursor.h: Added. (WebKit::WebIDBCursor::~WebIDBCursor): (WebKit::WebIDBCursor::direction): (WebKit::WebIDBCursor::key): (WebKit::WebIDBCursor::value): (WebKit::WebIDBCursor::update): (WebKit::WebIDBCursor::continueFunction): (WebKit::WebIDBCursor::remove):
- public/WebIDBKeyRange.h: Added. (WebKit::WebIDBKeyRange::~WebIDBKeyRange): (WebKit::WebIDBKeyRange::WebIDBKeyRange):
- public/WebIDBObjectStore.h: (WebKit::WebIDBObjectStore::openCursor):
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBCursorBackendProxy.cpp: Added. (WebCore::IDBCursorBackendProxy::create): (WebCore::IDBCursorBackendProxy::IDBCursorBackendProxy): (WebCore::IDBCursorBackendProxy::~IDBCursorBackendProxy): (WebCore::IDBCursorBackendProxy::direction): (WebCore::IDBCursorBackendProxy::key): (WebCore::IDBCursorBackendProxy::value): (WebCore::IDBCursorBackendProxy::update): (WebCore::IDBCursorBackendProxy::continueFunction): (WebCore::IDBCursorBackendProxy::remove):
- src/IDBCursorBackendProxy.h: Added.
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::openCursor):
- src/IDBObjectStoreProxy.h:
- src/WebIDBCallbacksImpl.cpp: (WebCore::WebIDBCallbacksImpl::onSuccess):
- src/WebIDBCallbacksImpl.h:
- src/WebIDBCursorImpl.cpp: Added. (WebKit::WebIDBCursorImpl::WebIDBCursorImpl): (WebKit::WebIDBCursorImpl::~WebIDBCursorImpl): (WebKit::WebIDBCursorImpl::direction): (WebKit::WebIDBCursorImpl::key): (WebKit::WebIDBCursorImpl::value): (WebKit::WebIDBCursorImpl::update): (WebKit::WebIDBCursorImpl::continueFunction): (WebKit::WebIDBCursorImpl::remove):
- src/WebIDBCursorImpl.h: Added.
- src/WebIDBKeyRange.cpp: Added. (WebKit::WebIDBKeyRange::WebIDBKeyRange): (WebKit::WebIDBKeyRange::assign): (WebKit::WebIDBKeyRange::reset): (WebKit::WebIDBKeyRange::left): (WebKit::WebIDBKeyRange::right): (WebKit::WebIDBKeyRange::flags):
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::openCursor):
- src/WebIDBObjectStoreImpl.h:
- 3:33 AM Changeset in webkit [64827] by
-
- 3 edits in trunk/JavaScriptCore
Refactor identifier parsing in lexer
https://bugs.webkit.org/show_bug.cgi?id=41845
Reviewed by Darin Adler.
The code is refactored to avoid gotos. The new code
has the same performance as the old one.
SunSpider --parse-only: no change (from 34.0ms to 33.6ms)
SunSpider: no change (from 523.2ms to 523.5ms)
- parser/Lexer.cpp:
(JSC::Lexer::parseIdent):
(JSC::Lexer::lex):
- parser/Lexer.h:
- 3:16 AM Changeset in webkit [64826] by
-
- 2 edits in trunk/WebCore
2010-08-06 Andrei Popescu <andreip@google.com>
Unreviewed, release build fix.
Leopard relase build is broken due to absolute path to JSIDBTransaction.cpp file present in XCode project file.
https://bugs.webkit.org/show_bug.cgi?id=43616
- WebCore.xcodeproj/project.pbxproj:
- 3:00 AM Changeset in webkit [64825] by
-
- 3 edits in trunk/WebKit/qt
2010-08-06 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Add support for the Android viewport meta tag extensions.
http://webkit.org/b/43567
- Api/qwebpage.h:
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::didReceiveViewportArguments):
- 2:42 AM Changeset in webkit [64824] by
-
- 26 edits2 copies2 adds in trunk
2010-08-05 Andrei Popescu <andreip@dhcp-172-16-14-12.lon.corp.google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] IndexedDB is missing the Transaction interface.
https://bugs.webkit.org/show_bug.cgi?id=42970
Add IDBTransaction boilerplate.
No new tests, not functional yet.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/EventNames.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::transaction):
- storage/IDBDatabase.h:
- storage/IDBDatabase.idl:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::transaction):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::IDBRequest): (WebCore::IDBRequest::canSuspend): (WebCore::IDBRequest::timerFired): (WebCore::IDBRequest::onEventCommon):
- storage/IDBRequest.h:
- storage/IDBTransaction.cpp: Added. (WebCore::IDBTransaction::IDBTransaction): (WebCore::IDBTransaction::~IDBTransaction): (WebCore::IDBTransaction::mode): (WebCore::IDBTransaction::db): (WebCore::IDBTransaction::objectStore): (WebCore::IDBTransaction::abort): (WebCore::IDBTransaction::scriptExecutionContext): (WebCore::IDBTransaction::canSuspend): (WebCore::IDBTransaction::eventTargetData): (WebCore::IDBTransaction::ensureEventTargetData):
- storage/IDBTransaction.h: Added. (WebCore::IDBTransaction::create): (WebCore::IDBTransaction::): (WebCore::IDBTransaction::toIDBTransaction): (WebCore::IDBTransaction::refEventTarget): (WebCore::IDBTransaction::derefEventTarget):
- storage/IDBTransaction.idl: Added.
- storage/IDBTransactionBackendInterface.h: Added. (WebCore::IDBTransactionBackendInterface::~IDBTransactionBackendInterface):
2010-08-05 Andrei Popescu <andreip@dhcp-172-16-14-12.lon.corp.google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] IndexedDB is missing the Transaction interface.
https://bugs.webkit.org/show_bug.cgi?id=42970
Add IDBTransaction boilerplate.
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::transaction):
- src/IDBDatabaseProxy.h:
- 1:45 AM Changeset in webkit [64823] by
-
- 2 edits in trunk/WebCore
2010-08-06 Rafael Antognolli <antognolli@profusion.mobi>
Unreviewed build fix.
[EFL] Regression (64735) build fix for efl.
https://bugs.webkit.org/show_bug.cgi?id=43564
Removing bindings/js/ScriptArray.cpp from the WebCore_SOURCES.
No new features, so no new tests.
- CMakeLists.txt:
- 1:42 AM Changeset in webkit [64822] by
-
- 2 edits in trunk/WebKitTools
2010-08-06 Jochen Eisinger <jochen@chromium.org>
Reviewed by Pavel Feldman.
Rietvield's upload.py moved to a different location.
https://bugs.webkit.org/show_bug.cgi?id=43613
- Scripts/webkitpy/thirdparty/init.py:
- 1:15 AM Changeset in webkit [64821] by
-
- 10 edits1 copy1 add in trunk/LayoutTests
2010-08-06 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium test expectations rebaseline.
- platform/chromium-linux/fast/text/stripNullFromText-expected.checksum:
- platform/chromium-linux/fast/text/stripNullFromText-expected.png: Added.
- platform/chromium-linux/fast/text/stripNullFromText-expected.txt:
- platform/chromium-linux/websocket/tests/bad-sub-protocol-control-chars-expected.txt: Added.
- platform/chromium-mac/fast/text/stripNullFromText-expected.checksum:
- platform/chromium-mac/fast/text/stripNullFromText-expected.png:
- platform/chromium-mac/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
- platform/chromium-win/fast/text/stripNullFromText-expected.checksum:
- platform/chromium-win/fast/text/stripNullFromText-expected.png:
- platform/chromium-win/fast/text/stripNullFromText-expected.txt:
- platform/chromium-win/websocket/tests/bad-sub-protocol-control-chars-expected.txt:
- 12:47 AM MathML 3 testsuite results edited by
- (diff)
Aug 5, 2010:
- 11:50 PM Changeset in webkit [64820] by
-
- 5 edits in trunk
Fix http/tests/webarchive/test-css-url-encoding-shift-jis.html
For some reason, I didn't see the failure locally, but bots complain.
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Register "shift-jis" (with dash instead of underscore). At least Firefox supports it.
- 10:57 PM Changeset in webkit [64819] by
-
- 3 edits2 adds in trunk
2010-08-05 Ben Murdoch <benm@google.com>
Reviewed by Simon Fraser.
Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible
https://bugs.webkit.org/show_bug.cgi?id=38050
- fast/css/visibility-collapse-form-buttons-expected.txt: Added.
- fast/css/visibility-collapse-form-buttons.html: Added.
2010-08-05 Ben Murdoch <benm@google.com>
Reviewed by Simon Fraser.
Form button input elements lacking text in some cases after switching from
visibility:collapse to visibility:visible
https://bugs.webkit.org/show_bug.cgi?id=38050
A relayout is required after toggling visibility from collapse to another value.
Test: fast/css/visibility-collapse-form-buttons.html
- rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): If we're toggling from visibility:collapse to another
visibility value (or vice versa) then we need to trigger a relayout.
- 10:50 PM Changeset in webkit [64818] by
-
- 4 edits in trunk/JavaScriptCore
The ARM JIT does not support JSValue32_64 with RVCT
https://bugs.webkit.org/show_bug.cgi?id=43411
Reviewed by Gavin Barraclough.
JSValue32_64 is enabled for RVCT by default.
- create_jit_stubs:
- jit/JITStubs.cpp:
(JSC::ctiTrampoline):
(JSC::ctiVMThrowTrampoline):
(JSC::ctiOpThrowNotCaught):
- wtf/Platform.h:
- 10:36 PM Changeset in webkit [64817] by
-
- 9 edits3 adds in trunk
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=43554
Way too many encoding aliases are treated as valid
<rdar://problem/7863399> Garbage characters displayed in some yesky.com pages.
<rdar://problem/7859068> Garbage characters displayed for most text at ceping.zhaopin.com
Test: http/tests/misc/bad-charset-alias.html
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForCSSCharset): Fix encoding name length computation. Previously, a trailing quote was ignored by TextEncodingRegistry.
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Added dashes to alias names that didn't have them. Added aliases prompted by regression tests.
- platform/text/TextCodecLatin1.cpp: (WebCore::TextCodecLatin1::registerEncodingNames): Don't register 8859-1, other browsers do not support this encoding name.
- platform/text/TextEncoding.cpp: (WebCore::Latin1Encoding): "Latin-1" is not a real encoding name, it's not known to Firefox or IE.
- platform/text/TextEncodingRegistry.cpp: (WebCore::TextEncodingNameHash::equal): Changed to no longer ignore non-alphanumeric characters. There is a good chance that we'll be missing support for some necessary alias names, but other browsers don't ignore any characters when matching names. (WebCore::TextEncodingNameHash::hash): Ditto. (WebCore::checkExistingName): Re-formatted a line. (WebCore::isUndesiredAlias): Added a filter to reject "8859_1" and any names containing commas. (WebCore::addToTextEncodingNameMap): Used it. (WebCore::atomicCanonicalTextEncodingName): Changed to no longer ignore non-alphanumeric characters.
- 10:08 PM Changeset in webkit [64816] by
-
- 2 edits in trunk/WebCore
2010-08-05 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] Temporary files should not be created in the current directory
https://bugs.webkit.org/show_bug.cgi?id=43562
Don't create temporary files in the current directory, use QDir::tempPath()
instead, as suggested by the QTemporaryFile documentation.
- platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile):
- 9:50 PM Changeset in webkit [64815] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
2010-08-05 W. James MacLean <wjmaclean@chromium.org>
Reviewed by Nikolas Zimmermann.
SVG - numeric overflow for very large elements
https://bugs.webkit.org/show_bug.cgi?id=25645
Rebaselining results for gtk/win platforms.
Skip pattern-excessive-malloc.svg on GTK for now.
- platform/gtk/svg/custom/pattern-excessive-malloc-expected.txt: Removed.
- platform/gtk/Skipped: Modified.
- platform/win/svg/custom/massive-coordinates-expected.txt: Added.
- 9:11 PM Changeset in webkit [64814] by
-
- 2 edits in trunk/WebCore
2010-08-05 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Make STIX font the default one to render MathML
https://bugs.webkit.org/show_bug.cgi?id=41961
- css/mathml.css: (math):
- 8:47 PM Changeset in webkit [64813] by
-
- 2 edits in trunk/WebCore
2010-08-05 Cosmin Truta <ctruta@chromium.org>
Reviewed by Eric Seidel.
Apply a stylistic fix to the patch 62640.
https://bug-41175-attachments.webkit.org/attachment.cgi?id=62640
https://bugs.webkit.org/show_bug.cgi?id=41175
- WebCore/platform/graphics/skia/ImageBufferSkia.cpp: (getImageData):
- 7:57 PM WebKit Team edited by
- (diff)
- 7:51 PM Changeset in webkit [64812] by
-
- 2 edits in trunk/WebCore
2010-08-05 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
Make SearchPopupMenuWin more portable
https://bugs.webkit.org/show_bug.cgi?id=43527
Add #if PLATFORM(CF) around CoreFoundation code.
- platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenuWin::enabled): (WebCore::SearchPopupMenuWin::saveRecentSearches): (WebCore::SearchPopupMenuWin::loadRecentSearches):
- 7:17 PM Changeset in webkit [64811] by
-
- 2 edits in trunk/WebKit/win
2010-08-05 Jessie Berlin <jberlin@apple.com>
Reviewed by Jon Honeycutt.
Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
https://bugs.webkit.org/show_bug.cgi?id=43593
- WebView.cpp: (WebView::backingStore): If m_backingStoreBitmap is NULL, return E_FAIL.
- 6:54 PM Changeset in webkit [64810] by
-
- 3 edits1 delete in trunk/WebCore
2010-08-05 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r63653.
http://trac.webkit.org/changeset/63653
https://bugs.webkit.org/show_bug.cgi?id=43592
regressed multiple background-images (Requested by smfr on
#webkit).
- manual-tests/css3-background-layer-count.html: Removed.
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::fillUnsetProperties): (WebCore::FillLayer::cullEmptyLayers):
- rendering/style/RenderStyle.h: (WebCore::InheritedFlags::adjustBackgroundLayers): (WebCore::InheritedFlags::adjustMaskLayers):
- 6:38 PM Changeset in webkit [64809] by
-
- 2 edits in trunk/WebCore
Fix some leaks seen on the buildbot.
Reviewed by Jon Honeycutt.
- platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::paintToCanvas): Adopt the newly-created CoreGraphics objects rather than sharing ownership
and over-incrementing their reference count. Also cleaned up the bizarre wrapping used for function arguments while I was
touching this code.
- 6:23 PM Changeset in webkit [64808] by
-
- 4 edits3 adds29 deletes in trunk/LayoutTests
2010-08-05 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Tony Chang.
dumpAsMarkup conversion: deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
https://bugs.webkit.org/show_bug.cgi?id=43580
Converted deleting/delete-4038408-fix.html, deleting/delete-br-011.html, and execCommand/format-block-from-range-selection.html
to a dumpAsMarkup test because all the tests were testing the correctness of the resultant DOM tree.
In addition, removed editing delegates from execCommand/format-block-from-range-selection.html because it's not relevant to the test.
- editing/deleting/delete-4038408-fix-expected.txt: Added.
- editing/deleting/delete-4038408-fix.html: Converted.
- editing/deleting/delete-br-011-expected.txt: Added.
- editing/deleting/delete-br-011.html: Converted.
- editing/execCommand/format-block-from-range-selection-expected.txt: Added.
- editing/execCommand/format-block-from-range-selection.html: Converted.
- platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-4038408-fix-expected.png: Removed.
- platform/chromium-linux/editing/deleting/delete-br-011-expected.checksum: Removed.
- platform/chromium-linux/editing/deleting/delete-br-011-expected.png: Removed.
- platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
- platform/chromium-linux/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
- platform/chromium-win/editing/deleting/delete-4038408-fix-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-4038408-fix-expected.txt: Removed.
- platform/chromium-win/editing/deleting/delete-br-011-expected.checksum: Removed.
- platform/chromium-win/editing/deleting/delete-br-011-expected.png: Removed.
- platform/chromium-win/editing/deleting/delete-br-011-expected.txt: Removed.
- platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
- platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
- platform/chromium-win/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
- platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
- platform/mac-leopard/editing/deleting/delete-4038408-fix-expected.png: Removed.
- platform/mac/editing/deleting/delete-4038408-fix-expected.checksum: Removed.
- platform/mac/editing/deleting/delete-4038408-fix-expected.png: Removed.
- platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Removed.
- platform/mac/editing/deleting/delete-br-011-expected.checksum: Removed.
- platform/mac/editing/deleting/delete-br-011-expected.png: Removed.
- platform/mac/editing/deleting/delete-br-011-expected.txt: Removed.
- platform/mac/editing/execCommand/format-block-from-range-selection-expected.checksum: Removed.
- platform/mac/editing/execCommand/format-block-from-range-selection-expected.png: Removed.
- platform/mac/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
- platform/qt/editing/deleting/delete-4038408-fix-expected.txt: Removed.
- platform/qt/editing/deleting/delete-br-011-expected.txt: Removed.
- platform/qt/editing/execCommand/format-block-from-range-selection-expected.txt: Removed.
- 6:09 PM Changeset in webkit [64807] by
-
- 2 edits in trunk/WebCore
2010-08-05 James Robinson <jamesr@chromium.org>
Rubber stamped by Eric Seidel.
[SVG] SVGPathSeg.cpp needs an #if ENABLE(SVG) guard
https://bugs.webkit.org/show_bug.cgi?id=43599
Matches the rest of the .cpp files in this directory.
- svg/SVGPathSeg.cpp:
- 5:56 PM Changeset in webkit [64806] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Adam Barth <abarth@webkit.org>
Update Qt result showing that we strip nulls in this case.
- platform/qt/fast/text/stripNullFromText-expected.txt:
- 5:46 PM Changeset in webkit [64805] by
-
- 4 edits2 adds in trunk
2010-08-05 Erik Arvidsson <arv@chromium.org>
Reviewed by Kent Tamura.
Calling setCustomValidity should trigger a layout
https://bugs.webkit.org/show_bug.cgi?id=43582
- fast/forms/setCustomValidity-expected.txt: Added.
- fast/forms/setCustomValidity.html: Added.
2010-08-05 Erik Arvidsson <arv@chromium.org>
Reviewed by Kent Tamura.
Calling setCustomValidity should trigger a layout
https://bugs.webkit.org/show_bug.cgi?id=43582
Test: fast/forms/setCustomValidity.html
- html/ValidityState.cpp: (WebCore::ValidityState::setCustomErrorMessage): Call setNeedsValidityCheck to tell the system that the validity might have changed.
- html/ValidityState.h:
- 5:41 PM Changeset in webkit [64804] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-05 Chao-ying Fu <fu@mips.com>
Reviewed by Darin Adler.
Define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER for MIPS
https://bugs.webkit.org/show_bug.cgi?id=43514
MIPS needs to define WTF_USE_ARENA_ALLOC_ALIGNMENT_INTEGER, so that
RenderArena::allocate() can return 8-byte aligned memory to avoid
exceptions on sdc1/ldc1.
- wtf/Platform.h:
- 5:31 PM Changeset in webkit [64803] by
-
- 12 edits in trunk
Add ability to get a JSValueRef for a node handle and a world
https://bugs.webkit.org/show_bug.cgi?id=43591
Reviewed by Anders Carlsson.
WebCore:
- WebCore.exp.in: Add exports.
WebKit2:
- Add API to get a JSValueRef for a world, node and frame (the frame is currently necessary to pick the right globalObject for the node wrapper).
- Add API to a JSGlobalContextRef for a world and a frame.
- WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameGetJavaScriptContextForWorld):
(WKBundleFrameGetJavaScriptWrapperForNodeForWorld):
- WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::coreNode):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:
(WebKit::InjectedBundleScriptWorld::coreWorld):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::jsContext):
(WebKit::WebFrame::jsContextForWorld):
(WebKit::WebFrame::jsWrapperForWorld):
- WebProcess/WebPage/WebFrame.h:
- 5:24 PM Changeset in webkit [64802] by
-
- 2 edits in trunk/WebKit/mac
2010-08-05 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Remove Invalid Asserts for Application Cache Quotas
https://bugs.webkit.org/show_bug.cgi?id=43585
Removed Invalid ASSERTs that would always happen for quotas
that were not noQuota().
- WebView/WebPreferences.mm: (-[WebPreferences applicationCacheTotalQuota]): (-[WebPreferences applicationCacheDefaultOriginQuota]):
- 5:20 PM Changeset in webkit [64801] by
-
- 286 edits in trunk
Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
Rubber stamped by Sam Weinig
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/Forward.h:
WebCore:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.h:
- accessibility/AccessibilityARIAGrid.h:
- accessibility/AccessibilityListBoxOption.h:
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.h:
- accessibility/AccessibilityTable.h:
- bindings/cpp/WebDOMCString.h:
- bindings/cpp/WebDOMString.h:
- bindings/gobject/ConvertToUTF8String.h:
- bindings/js/DOMWrapperWorld.h:
- bindings/js/JSDOMBinding.h:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSMessagePortCustom.h:
- bindings/js/JavaScriptCallFrame.h:
- bindings/js/ScriptController.h:
- bindings/js/ScriptProfile.h:
- bindings/js/ScriptSourceProvider.h:
- bindings/js/ScriptString.h:
- bindings/js/WorkerScriptController.h:
- bindings/objc/DOMImplementationFront.h:
- bindings/v8/ScheduledAction.h:
- bindings/v8/ScriptController.h:
- bindings/v8/V8DOMWindowShell.h:
- bindings/v8/V8Proxy.h:
- bindings/v8/V8Utilities.h:
- bindings/v8/custom/V8CustomXPathNSResolver.h:
- bridge/c/c_utility.h:
- css/CSSFontSelector.h:
- css/CSSHelper.h:
- css/CSSOMUtils.h:
- css/CSSPrimitiveValue.h:
- css/MediaList.h:
- css/StyleBase.h:
- css/StyleSheetList.h:
- css/WebKitCSSKeyframesRule.h:
- dom/CheckedRadioButtons.h:
- dom/DOMImplementation.h:
- dom/DocumentMarker.h:
- dom/DynamicNodeList.h:
- dom/EventTarget.h:
- dom/MessagePort.h:
- dom/MessagePortChannel.h:
- dom/NameNodeList.h:
- dom/Node.h:
- dom/NodeList.h:
- dom/OptionGroupElement.h:
- dom/ScriptExecutionContext.h:
- dom/SelectElement.h:
- dom/ViewportArguments.h:
- dom/make_names.pl:
- editing/HTMLInterchange.h:
- editing/htmlediting.h:
- editing/markup.h:
- html/CollectionCache.h:
- html/DOMFormData.h:
- html/DataGridColumnList.h:
- html/DateComponents.h:
- html/FileStream.h:
- html/FileStreamProxy.h:
- html/FormDataList.h:
(WebCore::FormDataList::appendData):
- html/HTMLCollection.h:
- html/HTMLElementStack.h:
- html/HTMLFormattingElementList.h:
- html/HTMLParserQuirks.h:
- html/HTMLQuoteElement.h:
- html/HTMLScriptRunnerHost.h:
- html/StepRange.h:
- html/canvas/CanvasGradient.h:
- html/canvas/CanvasNumberArray.h:
- html/canvas/CanvasPattern.h:
- inspector/InjectedScript.h:
- inspector/InspectorCSSStore.h:
- inspector/InspectorClient.h:
- inspector/InspectorFrontendClient.h:
- inspector/InspectorValues.h:
- inspector/ScriptDebugListener.h:
- loader/CachedResourceClient.h:
- loader/CrossOriginAccessControl.h:
- loader/DocumentThreadableLoader.h:
- loader/FrameLoaderClient.h:
- loader/RedirectScheduler.h:
- loader/SubframeLoader.h:
- loader/appcache/DOMApplicationCache.h:
- loader/archive/ArchiveFactory.h:
- loader/icon/IconDatabaseClient.h:
- notifications/NotificationPresenter.h:
- page/Chrome.h:
- page/ChromeClient.h:
- page/Console.h:
- page/ContextMenuClient.h:
- page/DOMSelection.h:
- page/EditorClient.h:
- page/EventHandler.h:
- page/FrameView.h:
- page/GeolocationPositionCache.h:
- page/History.h:
- page/Location.h:
- page/Navigator.h:
- page/NavigatorBase.h:
- page/PluginHalterClient.h:
- page/PrintContext.h:
- page/SpeechInput.h:
- page/SpeechInputListener.h:
- page/animation/AnimationController.h:
- platform/CookieJar.h:
- platform/CrossThreadCopier.h:
- platform/DragImage.h:
- platform/FileSystem.h:
- platform/Language.h:
- platform/Length.h:
- platform/LinkHash.h:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.h:
- platform/Logging.h:
- platform/Pasteboard.h:
- platform/PopupMenuClient.h:
- platform/SearchPopupMenu.h:
- platform/Widget.h:
- platform/cf/BinaryPropertyList.h:
- platform/chromium/ChromiumBridge.h:
- platform/chromium/ClipboardUtilitiesChromium.h:
- platform/cocoa/KeyEventCocoa.h:
- platform/graphics/Color.h:
- platform/graphics/FontCache.h:
- platform/graphics/FontData.h:
- platform/graphics/FontSelector.h:
- platform/graphics/GraphicsTypes.h:
- platform/graphics/Icon.h:
- platform/graphics/ImageBuffer.h:
- platform/graphics/ImageSource.h:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
- platform/graphics/Path.h:
- platform/graphics/StringTruncator.h:
- platform/graphics/cairo/FontCustomPlatformData.h:
- platform/graphics/cairo/FontPlatformData.h:
- platform/graphics/cg/FontPlatformData.h:
- platform/graphics/cg/ImageSourceCG.h:
- platform/graphics/chromium/FontCustomPlatformData.h:
- platform/graphics/chromium/FontPlatformDataChromiumWin.h:
- platform/graphics/chromium/FontPlatformDataLinux.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/haiku/FontCustomPlatformData.h:
- platform/graphics/mac/FontCustomPlatformData.h:
- platform/graphics/mac/FontPlatformData.h:
- platform/graphics/qt/FontCustomPlatformData.h:
- platform/graphics/qt/FontPlatformData.h:
- platform/graphics/win/FontCustomPlatformData.h:
- platform/graphics/win/FontCustomPlatformDataCairo.h:
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.h:
- platform/graphics/wince/FontPlatformData.h:
- platform/graphics/wince/MediaPlayerPrivateWince.h:
- platform/graphics/wince/MediaPlayerProxy.h:
- platform/graphics/wx/FontCustomPlatformData.h:
- platform/graphics/wx/FontPlatformData.h:
- platform/mac/PasteboardHelper.h:
- platform/network/DNS.h:
- platform/network/FormData.h:
- platform/network/FormDataBuilder.h:
- platform/network/HTTPParsers.h:
- platform/text/Hyphenation.h:
- platform/text/LineEnding.h:
- platform/text/TextCodec.h:
- platform/text/TextEncoding.h:
- platform/text/TextStream.h:
- platform/win/BString.h:
- platform/win/ClipboardUtilitiesWin.h:
- platform/win/WCDataObject.h:
- platform/win/WebCoreTextRenderer.h:
- plugins/DOMMimeType.h:
- plugins/DOMMimeTypeArray.h:
- plugins/DOMPlugin.h:
- plugins/DOMPluginArray.h:
- rendering/CounterNode.h:
- rendering/HitTestResult.h:
- rendering/RenderObjectChildList.h:
- rendering/RenderText.h:
- rendering/RenderTreeAsText.h:
- rendering/TextControlInnerElements.h:
- rendering/style/ContentData.h:
- rendering/style/RenderStyle.h:
- storage/DatabaseAuthorizer.h:
- storage/DatabaseTrackerClient.h:
- storage/SQLTransaction.h:
- storage/SQLTransactionSync.h:
- storage/Storage.h:
- storage/chromium/DatabaseObserver.h:
- svg/SVGAnimatedTemplate.h:
- svg/SVGDocumentExtensions.h:
- svg/SVGGlyphElement.h:
- svg/SVGHKernElement.h:
- svg/SVGNumberList.h:
- svg/SVGPointList.h:
- svg/SVGPreserveAspectRatio.h:
- svg/SVGStylable.h:
- svg/SVGTests.h:
- svg/SVGTransformList.h:
- svg/SVGTransformable.h:
- svg/SVGVKernElement.h:
- websockets/ThreadableWebSocketChannel.h:
- websockets/ThreadableWebSocketChannelClientWrapper.h:
- websockets/WebSocket.h:
- websockets/WebSocketChannel.h:
- websockets/WebSocketHandshakeResponse.h:
- wml/WMLErrorHandling.h:
- wml/WMLPageState.h:
- wml/WMLVariables.h:
- workers/DefaultSharedWorkerRepository.h:
- workers/SharedWorkerRepository.h:
- workers/Worker.h:
- workers/WorkerContextProxy.h:
- workers/WorkerLoaderProxy.h:
- workers/WorkerLocation.h:
- workers/WorkerMessagingProxy.h:
- workers/WorkerReportingProxy.h:
- workers/WorkerThread.h:
- xml/DOMParser.h:
- xml/XMLHttpRequestUpload.h:
- xml/XPathEvaluator.h:
- xml/XPathExpression.h:
- xml/XPathNSResolver.h:
- xml/XPathResult.h:
- xml/XPathUtil.h:
WebKit:
- WebKit.xcodeproj/project.pbxproj:
WebKit/chromium:
- public/WebCString.h:
- public/WebString.h:
- src/DOMUtilitiesPrivate.h:
- src/DebuggerAgentImpl.h:
- src/DebuggerAgentManager.h:
- src/WebDevToolsAgentImpl.h:
- src/WebDevToolsFrontendImpl.h:
- src/WebPageSerializerImpl.h:
WebKit/efl:
- WebCoreSupport/InspectorClientEfl.h:
WebKit/gtk:
- WebCoreSupport/InspectorClientGtk.h:
WebKit/haiku:
- WebCoreSupport/FrameLoaderClientHaiku.h:
- WebCoreSupport/InspectorClientHaiku.h:
WebKit/mac:
- Plugins/Hosted/NetscapePluginInstanceProxy.h:
- Plugins/WebBaseNetscapePluginView.h:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebIconDatabaseClient.h:
- WebCoreSupport/WebPluginHalterClient.h:
- WebView/WebViewInternal.h:
WebKit/qt:
- WebCoreSupport/FrameLoaderClientQt.h:
- WebCoreSupport/InspectorClientQt.h:
WebKit/win:
- COMVariantSetter.h:
- MarshallingHelpers.h:
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebPluginHalterClient.h:
- WebHistory.h:
WebKit/wx:
- WebKitSupport/FrameLoaderClientWx.h:
- WebKitSupport/InspectorClientWx.h:
WebKit2:
- UIProcess/PageClient.h:
- UIProcess/VisitedLinkProvider.h:
- UIProcess/WebContextInjectedBundleClient.h:
- UIProcess/WebFrameProxy.h:
- UIProcess/WebHistoryClient.h:
- UIProcess/WebLoaderClient.h:
- UIProcess/WebPolicyClient.h:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebUIClient.h:
- UIProcess/win/WebView.h:
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/Plugins/NPRuntimeObjectMap.h:
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
- WebProcess/Plugins/PluginController.h:
- WebProcess/WebPage/WebFrame.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.h:
- 5:13 PM Changeset in webkit [64800] by
-
- 2 edits in trunk/JavaScriptCore
Fixed leak seen on buildbot.
Reviewed by Mark Rowe.
- runtime/GCActivityCallbackCF.cpp:
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()): Make out timer a RetainPtr,
since anything less would be uncivilized.
- 5:12 PM Changeset in webkit [64799] by
-
- 9 edits4 adds in trunk
2010-08-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
U+0000 is turned to U+FFFD (replacement character)
https://bugs.webkit.org/show_bug.cgi?id=42112
Update test results to show null stripping. These changes are mostly
going back to the old results we had before we added the FFFD
replacement.
- fast/dom/stripNullFromTextNodes-expected.txt:
- fast/tokenizer/null-in-text-expected.txt: Added.
- fast/tokenizer/null-in-text.html: Added.
- fast/tokenizer/null-xss-expected.txt: Added.
- fast/tokenizer/null-xss.html: Added.
- The main risk with stripping null characters is that they'll be used in XSS attacks. This test shows that we don't strip null characters from tag names.
- platform/mac/fast/text/stripNullFromText-expected.txt:
- svg/dom/fuzz-path-parser-expected.txt:
- svg/dom/rgb-color-parser-expected.txt:
2010-08-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
U+0000 is turned to U+FFFD (replacement character)
https://bugs.webkit.org/show_bug.cgi?id=42112
This patch introduces an intentional parsing difference from the HTML5
parsing specificiation. The spec requires us to convert NULL
characters to U+FFFD, but doing so causes compatibility issues with a
number of sites, including US Bank.
In this patch, we strip the null characters instead in certain cases.
Firefox has made a corresponding change. After gathering compatability
data, we hope to convince the HTML WG to adopt this change.
Tests: fast/tokenizer/null-in-text.html
fast/tokenizer/null-xss.html
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): (WebCore::HTMLTokenizer::reset):
- html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::setSkipLeadingNewLineForListing): (WebCore::HTMLTokenizer::forceNullCharacterReplacement): (WebCore::HTMLTokenizer::setForceNullCharacterReplacement): (WebCore::HTMLTokenizer::shouldSkipNullCharacters): (WebCore::HTMLTokenizer::InputStreamPreprocessor::InputStreamPreprocessor): (WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::passTokenToLegacyParser): (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::processStartTagForInBody):
- 5:08 PM Changeset in webkit [64798] by
-
- 11 edits in trunk
JavaScriptCore: Rename iOS-related OS and PLATFORM macros.
https://bugs.webkit.org/show_bug.cgi?id=43493
Reviewed by David Kilzer.
Rename WTF_OS_IPHONE_OS to WTF_OS_IOS, WTF_PLATFORM_IPHONE to
WTF_PLATFORM_IOS, and WTF_PLATFORM_IPHONE_SIMULATOR to
WTF_PLATFORM_IOS_SIMULATOR.
- jit/ExecutableAllocator.h:
- jit/JITStubs.cpp:
- profiler/ProfilerServer.mm:
(-[ProfilerServer init]):
- wtf/FastMalloc.cpp:
(WTF::TCMallocStats::):
- wtf/Platform.h:
- wtf/unicode/icu/CollatorICU.cpp:
(WTF::Collator::userDefault):
WebCore: Rename iOS-related OS and PLATFORM macros.
https://bugs.webkit.org/show_bug.cgi?id=43493
Reviewed by David Kilzer.
Rename WTF_OS_IPHONE_OS to WTF_OS_IOS, WTF_PLATFORM_IPHONE to
WTF_PLATFORM_IOS, and WTF_PLATFORM_IPHONE_SIMULATOR to
WTF_PLATFORM_IOS_SIMULATOR.
- platform/cocoa/KeyEventCocoa.mm:
- platform/iphone/KeyEventIPhone.mm:
- platform/network/Credential.h:
- 5:00 PM Changeset in webkit [64797] by
-
- 13 edits in trunk
Use the visited link provider for visited links
https://bugs.webkit.org/show_bug.cgi?id=43583
Reviewed by Sam Weinig.
WebCore:
Export Page::visitedStateChanged and Page::allvisitedStateChanged.
- WebCore.exp.in:
WebKit2:
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Remove AddVisitedLink.
- Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:
(WebProcessProxyMessage::):
Remove PopulateVisitedLinks and add AddVisitedLink.
- UIProcess/WebContext.cpp:
(WebKit::WebContext::sharedProcessContext):
Initialize the main run loop before creating the context.
(WebKit::WebContext::sharedThreadContext):
Ditto.
(WebKit::WebContext::create):
Ditto.
(WebKit::WebContext::WebContext):
Initialize the visited link provider.
(WebKit::WebContext::processDidFinishLaunching):
Ask the visited link provider to populate visited links.
(WebKit::WebContext::addVisitedLink):
Ask the visited link provider to add the visited link.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addVisitedLink):
Call WebContext::addVisitedLink.
(WebKit::WebProcessProxy::didReceiveMessage):
Handle AddVisitedLink.
(WebKit::WebProcessProxy::didFinishLaunching):
Call WebContext::processdidFinishLaunching.
- UIProcess/WebProcessProxy.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::populateVisitedLinks):
Don't send the WebProcessProxyMessage::PopulateVisitedLinks message.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::isLinkVisited):
Call WebProcess::isLinkVisited.
(WebKit::WebPlatformStrategies::addVisitedLink):
Call WebProcess::addVisitedLink.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::setVisitedLinkTable):
Create a shared memory object and tell the visited link table about it.
(WebKit::WebProcess::visitedLinkStateChanged):
Go through the link hashes and call Page::visitedStateChanged.
(WebKit::WebProcess::allVisitedLinkStateChanged):
Call Page::allVisitedStateChanged.
(WebKit::WebProcess::isLinkVisited):
Call VisitedLinkTable::isLinkVisited.
(WebKit::WebProcess::addVisitedLink):
Inform the UI process about the added link.
(WebKit::WebProcess::didReceiveMessage):
Handle new messages.
- 4:52 PM Changeset in webkit [64796] by
-
- 7 edits in trunk/LayoutTests
2010-08-05 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
js-test-pre.js's escapeHTML should escape null characters so we can see them
https://bugs.webkit.org/show_bug.cgi?id=43579
- fast/canvas/canvas-getContext-invalid-expected.txt:
- fast/js/null-char-in-string-expected.txt:
- fast/js/resources/js-test-pre.js: (escapeHTML):
- fast/js/switch-behaviour-expected.txt:
- storage/domstorage/complex-values-expected.txt:
- websocket/tests/bad-sub-protocol-control-chars-expected.txt:
- 4:22 PM Changeset in webkit [64795] by
-
- 2 edits in trunk/WebKit2
Windows build fix.
Add missing include path.
- win/WebKit2Common.vsprops:
- 4:11 PM Changeset in webkit [64794] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-05 Brett Wilson <brettw@chromium.org>
Reviewed by Nate Chapin.
Make the webkit unit tests depend on test_support_base
https://bugs.webkit.org/show_bug.cgi?id=43584
- WebKit.gyp:
- 3:55 PM CommitterTips edited by
- (diff)
- 3:55 PM Changeset in webkit [64793] by
-
- 22 edits1 add in trunk/WebCore
2010-08-05 Eric Seidel <eric@webkit.org>
Reviewed by Nikolas Zimmermann.
Touching SVGNames should only rebuild hundreds of files, not thousands
https://bugs.webkit.org/show_bug.cgi?id=43308
Remove SVGNames.h include from several core SVG header files
which do not need to include it.
One of them, SVGPathSeg.h, required creation of an SVGPathSeg.cpp.
A bunch of SVGPathSeg* could remove PlatformString.h includes if
we moved their toString() methods into the .cpp files.
I re-indented on header to stop check-webkit-style from complaining.
I removed a couple mode lines I saw, since my understanding from
previous webkit-dev threads is that we plan to remove those all.
No functional change, thus no tests.
- Android.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- svg/SVGAllInOne.cpp:
- svg/SVGAngle.h:
- svg/SVGPathSeg.cpp: Added. (WebCore::SVGPathSeg::~SVGPathSeg): (WebCore::SVGPathSeg::pathSegType): (WebCore::SVGPathSeg::pathSegTypeAsLetter): (WebCore::SVGPathSeg::toString): (WebCore::SVGPathSeg::associatedAttributeName): (WebCore::SVGPathSegSingleCoord::toString):
- svg/SVGPathSeg.h: (WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
- svg/SVGPathSegArc.cpp: (WebCore::SVGPathSegArc::toString):
- svg/SVGPathSegArc.h: (WebCore::SVGPathSegArc::SVGPathSegArc):
- svg/SVGPathSegClosePath.h: (WebCore::SVGPathSegClosePath::create): (WebCore::SVGPathSegClosePath::pathSegType): (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter): (WebCore::SVGPathSegClosePath::toString):
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticSmooth.h:
- svg/SVGPathSegLineto.h:
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegMoveto.h:
- svg/SVGTransform.h:
- 3:38 PM Changeset in webkit [64792] by
-
- 2 edits in trunk/WebKit2
Export WKError.h
Rubberstamped by Sam Weinig.
- WebKit2.xcodeproj/project.pbxproj:
- 3:29 PM Changeset in webkit [64791] by
-
- 2 edits in trunk/WebKit2
Windows build fix.
Correct vcproj nesting.
- win/WebKit2.vcproj:
- 3:22 PM Changeset in webkit [64790] by
-
- 11 edits in trunk/JavaScriptCore
2010-08-05 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Darin Adler.
Currently, the global object is being embedded in the JavaScriptCore
bytecode, however since the global object is the same for all opcodes
in a code block, we can have the global object just be a member of the
associated code block.
Additionally, I added an assert inside of emitOpcode that verifies
that the last generated opcode was of the correct length.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::derefStructures): (JSC::CodeBlock::markAggregate):
- bytecode/CodeBlock.h: (JSC::CodeBlock::globalObject): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::FunctionCodeBlock::FunctionCodeBlock):
- bytecode/Opcode.h: (JSC::opcodeLength):
- bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::BytecodeGenerator): (JSC::BytecodeGenerator::emitOpcode):
Added an assert to check that the last generated opcode is the
correct length.
(JSC::BytecodeGenerator::rewindBinaryOp):
Changed the last opcode to op_end since the length will no longer
be correct.
(JSC::BytecodeGenerator::rewindUnaryOp):
Changed the last opcode to op_end since the length will no longer
be correct.
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetScopedVar):
(JSC::BytecodeGenerator::emitPutScopedVar):
(JSC::BytecodeGenerator::emitResolveWithBase):
- bytecompiler/BytecodeGenerator.h:
- interpreter/Interpreter.cpp: (JSC::Interpreter::resolveGlobal): (JSC::Interpreter::resolveGlobalDynamic): (JSC::Interpreter::privateExecute):
- jit/JITOpcodes.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global): (JSC::JIT::emit_op_resolve_global_dynamic): (JSC::JIT::emitSlow_op_resolve_global_dynamic):
- jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_get_global_var): (JSC::JIT::emit_op_put_global_var): (JSC::JIT::emit_op_resolve_global): (JSC::JIT::emitSlow_op_resolve_global):
- jit/JITStubs.cpp: (JSC::cti_op_resolve_global):
- runtime/Executable.cpp: (JSC::FunctionExecutable::compileForCallInternal): (JSC::FunctionExecutable::compileForConstructInternal): (JSC::FunctionExecutable::reparseExceptionInfo):
- 2:49 PM Changeset in webkit [64789] by
-
- 2 edits in trunk/WebCore
2010-08-05 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 2:32 PM Changeset in webkit [64788] by
-
- 8 edits4 adds in trunk/WebKit2
Add script world API for injected bundles
https://bugs.webkit.org/show_bug.cgi?id=43577
Reviewed by Gavin Barraclough.
- Shared/APIObject.h:
(WebKit::APIObject::):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(WebKit::):
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp: Added.
(WKBundleScriptWorldGetTypeID):
(WKBundleScriptWorldCreateWorld):
(WKBundleScriptWorldNormalWorld):
(WKBundleScriptWorldRetain):
(WKBundleScriptWorldRelease):
- WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.h: Added.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp: Added.
(WebKit::allWorlds):
(WebKit::InjectedBundleScriptWorld::create):
(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):
(WebKit::InjectedBundleScriptWorld::InjectedBundleScriptWorld):
(WebKit::InjectedBundleScriptWorld::~InjectedBundleScriptWorld):
- WebProcess/InjectedBundle/InjectedBundleScriptWorld.h: Added.
(WebKit::InjectedBundleScriptWorld::type):
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 2:28 PM Changeset in webkit [64787] by
-
- 5 edits1 copy1 add in trunk/WebKitTools
2010-05-23 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
QueueStatusServer needs better queue-status pages
https://bugs.webkit.org/show_bug.cgi?id=39562
The primary goal of this patch is to display queue
positions somewhere on the site so that it's easier
for commit-queue users to know when their pach will
be landed. I also tried to improve the root page
to be more useful than the previous wall of status text.
- QueueStatusServer/handlers/recentstatus.py:
- QueueStatusServer/main.py:
- QueueStatusServer/model/queues.py:
- QueueStatusServer/templates/recentstatus.html:
- 2:24 PM Changeset in webkit [64786] by
-
- 5 edits in trunk/WebKitTools
2010-08-05 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
Add option to generate/upload incremental json results to test result server.
Also refactor the json results generator unittest code to test
incremental and aggregated json results.
- Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
- Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
- 2:10 PM Changeset in webkit [64785] by
-
- 2 edits in trunk/WebCore
2010-08-05 Adam Barth <abarth@webkit.org>
Actually make HTMLEntityNames.json valid JSON.
- html/HTMLEntityNames.json:
- 2:10 PM Changeset in webkit [64784] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for chromium.
https://bugs.webkit.org/show_bug.cgi?id=43574
- platform/chromium/test_expectations.txt:
- 1:59 PM Changeset in webkit [64783] by
-
- 2 edits in trunk/WebCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=43516 REGRESSION:
Huge number of memory leaks after enabling MathML
-and corresponding-
<rdar://problem/8274123>
Reviewed by Kenneth Rohde Christiansen.
Destroy the old children in
RenderMathMLOperator::updateFromElement() instead of just removing
them since just removing them will cause them to leak.
- mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
- 1:57 PM Changeset in webkit [64782] by
-
- 6 edits in trunk/JavaScriptCore
Bug 43185 - Switch RegisterFile over to use PageAllocation
Reviewed by Sam Weinig.
Remove platform-specific memory allocation code.
- interpreter/RegisterFile.cpp:
(JSC::RegisterFile::~RegisterFile):
(JSC::RegisterFile::releaseExcessCapacity):
- interpreter/RegisterFile.h:
(JSC::RegisterFile::RegisterFile):
(JSC::RegisterFile::grow):
(JSC::RegisterFile::checkAllocatedOkay):
- wtf/PageAllocation.cpp:
(WTF::PageAllocation::lastError):
- wtf/PageAllocation.h:
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::isPageAligned):
(WTF::PageAllocation::isPowerOfTwo):
- wtf/PageReservation.h:
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):
- 1:40 PM Changeset in webkit [64781] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Martin Robinson <mrobinson@igalia.com>
[GTK] Some sputnik tests fail
https://bugs.webkit.org/show_bug.cgi?id=43568
- platform/gtk/Skipped: Skip some more failing Sputnik tests.
- 1:32 PM Changeset in webkit [64780] by
-
- 6 edits3 adds in trunk
2010-08-05 Tony Chang <tony@chromium.org>
Reviewed by David Hyatt.
Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
https://bugs.webkit.org/show_bug.cgi?id=42724
- scrollbars/hidden-iframe-scrollbar-crash2.html: Added.
- scrollbars/resources/hidden-iframe-scrollbar-crash2.html: Added.
2010-08-05 Tony Chang <tony@chromium.org>
Reviewed by David Hyatt.
Fix a crash when a hidden iframe with a custom scrollbar finishes loading an image.
https://bugs.webkit.org/show_bug.cgi?id=42724
Test: scrollbars/hidden-iframe-scrollbar-crash2.html
- page/FrameView.cpp: (WebCore::FrameView::createScrollbar):
- rendering/RenderScrollbar.cpp: (WebCore::RenderScrollbar::createCustomScrollbar): Pass in Frame (WebCore::RenderScrollbar::RenderScrollbar): Pass in Frame (WebCore::RenderScrollbar::owningRenderer): Use the frame to get the RenderBox (WebCore::RenderScrollbar::getScrollbarPseudoStyle): (WebCore::RenderScrollbar::updateScrollbarParts): (WebCore::RenderScrollbar::updateScrollbarPart):
- rendering/RenderScrollbar.h:
- rendering/RenderScrollbarPart.cpp: (WebCore::RenderScrollbarPart::computeScrollbarWidth): null check (WebCore::RenderScrollbarPart::computeScrollbarHeight): null check
- 1:27 PM Changeset in webkit [64779] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed build fix for Chromium.
WebInspector: inspector/debugger-breakpoints-not-activated-on-reload.html
was regressed. I'll fix it tomorrow.
https://bugs.webkit.org/show_bug.cgi?id=43574
- platform/chromium/test_expectations.txt:
- 1:19 PM Changeset in webkit [64778] by
-
- 8 edits5 adds in trunk/WebKit2
Reviewed Anders Carlsson.
Add DOM Node wrapper class for injected bundle
https://bugs.webkit.org/show_bug.cgi?id=43524
- This class should not expose any DOM APIs, but just be a handle that can be used to get a JS wrapper for the node in a specific world.
- Shared/APIObject.h:
(WebKit::APIObject::):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
(WebKit::):
- WebProcess/InjectedBundle/API/c/WKBundleBase.h:
- WebProcess/InjectedBundle/API/c/WKBundleNode.h:
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp: Added.
(WKBundleNodeHandleGetTypeID):
(WKBundleNodeHandleRetain):
(WKBundleNodeHandleRelease):
- WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.h: Added.
- WebProcess/InjectedBundle/DOM: Added.
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added.
(WebKit::domHandleCache):
(WebKit::getDOMHandle):
(WebKit::setDOMHandle):
(WebKit::removeDOMHandle):
(WebKit::InjectedBundleNodeHandle::getOrCreate):
(WebKit::InjectedBundleNodeHandle::create):
(WebKit::InjectedBundleNodeHandle::InjectedBundleNodeHandle):
(WebKit::InjectedBundleNodeHandle::~InjectedBundleNodeHandle):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Added.
(WebKit::InjectedBundleNodeHandle::type):
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- 1:01 PM Changeset in webkit [64777] by
-
- 3 edits in trunk/WebCore
2010-08-05 Yong Li <yoli@rim.com>
Reviewed by Adam Treat.
Fix the problem that down-sampling code doesn't work
for some GIF's. GIF reader can call setSize() multiple times.
We should clear the scaling maps before adding new entries.
Also add a fast path to check if the size has changed since last time.
- platform/image-decoders/ImageDecoder.cpp: (WebCore::ImageDecoder::prepareScaleDataIfNecessary):
- platform/image-decoders/gif/GIFImageDecoder.cpp: (WebCore::GIFImageDecoder::setSize):
- 12:58 PM Changeset in webkit [64776] by
-
- 2 edits in trunk/WebKit2
Build fix.
- Platform/mac/SharedMemoryMac.cpp:
- 12:54 PM Changeset in webkit [64775] by
-
- 5 edits1 copy1 add in trunk/WebKit2
Add VisitedLinkProvider class
https://bugs.webkit.org/show_bug.cgi?id=43570
Reviewed by Sam Weinig.
- Shared/CoreIPCSupport/WebProcessMessageKinds.h:
(WebProcessMessage::):
Add SetVisitedLinkTable, VisitedLinkStateChanged and AllVisitedLinkStateChanged.
- UIProcess/VisitedLinkProvider.cpp: Added.
(WebKit::VisitedLinkProvider::VisitedLinkProvider):
Initialize table.
(WebKit::VisitedLinkProvider::populateVisitedLinksIfNeeded):
Ask the context to populate visited links.
(WebKit::VisitedLinkProvider::addVisitedLink):
Add the link hash to the set of pending visited links and start the timer.
(WebKit::nextPowerOf2):
Add helper function.
(WebKit::tableSizeForKeyCount):
Given a key count, returns a table size. The table size is always a power of two, and
is chosen so that the table is always at least half empty.
(WebKit::VisitedLinkProvider::pendingVisitedLinksTimerFired):
First, check if we need to resize the hash table and allocate new shared memory for it if that is the case.
Then, go through the pending link hash vector and insert all the elements in the table. Finally, notify the web
process about visited links whose state have changed.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveMessage):
Add case statements.
- win/WebKit2.vcproj:
- WebKit2.xcodeproj/project.pbxproj:
Add VisitedLinkProvider.cpp and VisitedLinkProvider.h.
- 12:44 PM Changeset in webkit [64774] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Martin Robinson <mrobinson@igalia.com>
[GTK] Some sputnik tests fail
https://bugs.webkit.org/show_bug.cgi?id=43568
- platform/gtk/Skipped: Adding some more sputnik failures from the debug bot.
- 12:33 PM Changeset in webkit [64773] by
-
- 3 edits3 adds in trunk
2010-08-05 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Fixed https://bugs.webkit.org/show_bug.cgi?id=43401 where array
content aren't properly initialized as part of unshift.
- runtime/JSArray.cpp: (JSC::JSArray::unshiftCount):
2010-08-05 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
New regression tests added as part of unshift fix for bug described
inhttps://bugs.webkit.org/show_bug.cgi?id=43401.
- fast/js/script-tests/unshift-multi.js: Added.
- fast/js/unshift-multi-expected.txt: Added.
- fast/js/unshift-multi.html: Added.
- 12:24 PM Changeset in webkit [64772] by
-
- 1 edit in branches/audio/WebCore/audio/JavaScriptAudioNode.cpp
fixes for buffer size in JavaScriptAudioNode
- keep buffer size within reasonable min/max range
- fix initialization error
- 12:24 PM Changeset in webkit [64771] by
-
- 1 edit in branches/audio/WebCore/audio/AudioContext.cpp
Fix AudioContext initialization to avoid unpredictable pauses
- 12:17 PM Changeset in webkit [64770] by
-
- 18 edits in trunk/WebCore
2010-08-05 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: In the current implementation of inspector agents we're calling
did methods manually. That is error prone and is bad from protocol point of view.
It would be better to call did methods automatically from the corresponding methods
of InspectorBackendDispatcher and report the results. As far as our protocol is
statefull this trick will keep it in the consistent state.
https://bugs.webkit.org/show_bug.cgi?id=43489
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getProfilerLogLines): (WebCore::InspectorBackend::setInjectedScriptSource): (WebCore::InspectorBackend::dispatchOnInjectedScript): (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::releaseWrapperObjectGroup): (WebCore::InspectorBackend::getDatabaseTableNames):
- inspector/InspectorBackend.h:
- inspector/InspectorCSSStore.cpp: (WebCore::InspectorCSSStore::inspectorStyleSheet):
- inspector/InspectorCSSStore.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::editScriptSource): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::setBreakpoint): (WebCore::InspectorController::getResourceContent):
- inspector/InspectorController.h: (WebCore::InspectorController::inspectorClient):
- inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::getChildNodes): (WebCore::InspectorDOMAgent::setAttribute): (WebCore::InspectorDOMAgent::removeAttribute): (WebCore::InspectorDOMAgent::removeNode): (WebCore::InspectorDOMAgent::changeTagName): (WebCore::InspectorDOMAgent::getOuterHTML): (WebCore::InspectorDOMAgent::setOuterHTML): (WebCore::InspectorDOMAgent::setTextNodeValue): (WebCore::InspectorDOMAgent::getEventListenersForNode): (WebCore::InspectorDOMAgent::getStyles): (WebCore::InspectorDOMAgent::getAllStyles): (WebCore::InspectorDOMAgent::getStyleSheet): (WebCore::InspectorDOMAgent::getRuleRanges): (WebCore::InspectorDOMAgent::getInlineStyle): (WebCore::InspectorDOMAgent::getComputedStyle): (WebCore::InspectorDOMAgent::applyStyleText): (WebCore::InspectorDOMAgent::setStyleText): (WebCore::InspectorDOMAgent::setStyleProperty): (WebCore::InspectorDOMAgent::toggleStyleEnabled): (WebCore::InspectorDOMAgent::setRuleSelector): (WebCore::InspectorDOMAgent::addRule): (WebCore::InspectorDOMAgent::buildObjectForRule): (WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
- inspector/InspectorDOMAgent.h:
- inspector/InspectorValues.cpp: (WebCore::InspectorValue::asNumber): (WebCore::InspectorBasicValue::asNumber):
- inspector/InspectorValues.h:
- inspector/front-end/Callback.js: (WebInspector.Callback.prototype.processCallback): (WebInspector.Callback.prototype.removeCallbackEntry):
- inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.reset):
- inspector/front-end/inspector.js: (WebInspector.reportProtocolError):
- 12:11 PM Changeset in webkit [64769] by
-
- 2 edits6 adds in trunk/LayoutTests
2010-08-05 Martin Robinson <mrobinson@igalia.com>
[GTK] Some sputnik tests fail
https://bugs.webkit.org/show_bug.cgi?id=43568
Unskip the majority of the Sputnik tests. Most of them are passing
and a few just needed GTK+ baselines showing that they pass.
- platform/gtk/Skipped: Skip remaining failures.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A3.2-expected.txt.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T1-expected.txt.
- platform/gtk/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt: Copied from LayoutTests/platform/win/fast/js/sputnik/Unicode/Unicode_510/S7.6_A5.3_T2-expected.txt.
- 11:58 AM Changeset in webkit [64768] by
-
- 3 edits2 adds in trunk/WebKit2
Add VisitedLinkTable class
https://bugs.webkit.org/show_bug.cgi?id=43566
Reviewed by Sam Weinig.
- Shared/VisitedLinkTable.cpp: Added.
(WebKit::VisitedLinkTable::VisitedLinkTable):
(WebKit::VisitedLinkTable::~VisitedLinkTable):
Add out of line constructors so we won't have to include SharedMemory.h in the
VisitedLinkTable.h header.
(WebKit::isPowerOf2):
Add helper function.
(WebKit::VisitedLinkTable::setSharedMemory):
Set the new shared memory and update the table size and hash.
(WebKit::doubleHash):
Add helper function from the WTF HashTable.
(WebKit::VisitedLinkTable::addLinkHash):
Add a link hash to the table.
(WebKit::VisitedLinkTable::isLinkVisited):
See if there is an entry for the given link hash.
- Shared/VisitedLinkTable.h: Added.
(WebKit::VisitedLinkTable::sharedMemory):
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add VisitedLinkTable.cpp and VisitedLinkTable.h
- 11:33 AM Changeset in webkit [64767] by
-
- 28 edits in trunk
2010-08-04 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Style cleanups in WebGL
https://bugs.webkit.org/show_bug.cgi?id=38761
Cleaned up all style violations in WebGL-related files reported by
check-webkit-style. No logic or other changes. Built WebKit and
Chromium and ran WebGL layout tests.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas):
- src/WebGraphicsContext3DDefaultImpl.cpp:
- src/WebGraphicsContext3DDefaultImpl.h:
2010-08-04 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Style cleanups in WebGL
https://bugs.webkit.org/show_bug.cgi?id=38761
Cleaned up all style violations in WebGL-related files reported by
check-webkit-style. No logic or other changes. Built WebKit and
Chromium and ran WebGL layout tests.
- html/canvas/ArrayBuffer.cpp: (WebCore::ArrayBuffer::ArrayBuffer): (WebCore::ArrayBuffer::data): (WebCore::ArrayBuffer::byteLength): (WebCore::ArrayBuffer::~ArrayBuffer): (WebCore::ArrayBuffer::tryAllocate):
- html/canvas/ArrayBufferView.cpp: (WebCore::ArrayBufferView::setImpl):
- html/canvas/ArrayBufferView.h:
- html/canvas/TypedArrayBase.h:
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::deleteObjectImpl): (WebCore::WebGLBuffer::associateBufferData):
- html/canvas/WebGLBuffer.h: (WebCore::WebGLBuffer::~WebGLBuffer): (WebCore::WebGLBuffer::elementArrayBuffer): (WebCore::WebGLBuffer::getTarget): (WebCore::WebGLBuffer::isBuffer):
- html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::deleteObjectImpl):
- html/canvas/WebGLFramebuffer.h: (WebCore::WebGLFramebuffer::~WebGLFramebuffer): (WebCore::WebGLFramebuffer::isDepthAttached): (WebCore::WebGLFramebuffer::isStencilAttached): (WebCore::WebGLFramebuffer::isDepthStencilAttached): (WebCore::WebGLFramebuffer::isFramebuffer):
- html/canvas/WebGLGetInfo.cpp:
- html/canvas/WebGLGetInfo.h:
- html/canvas/WebGLObject.cpp: (WebCore::WebGLObject::deleteObject):
- html/canvas/WebGLObject.h: (WebCore::WebGLObject::object): (WebCore::WebGLObject::detachContext): (WebCore::WebGLObject::context): (WebCore::WebGLObject::isBuffer): (WebCore::WebGLObject::isFramebuffer): (WebCore::WebGLObject::isProgram): (WebCore::WebGLObject::isRenderbuffer): (WebCore::WebGLObject::isShader): (WebCore::WebGLObject::isTexture):
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::deleteObjectImpl):
- html/canvas/WebGLProgram.h: (WebCore::WebGLProgram::~WebGLProgram): (WebCore::WebGLProgram::isLinkFailureFlagSet): (WebCore::WebGLProgram::setLinkFailureFlag): (WebCore::WebGLProgram::isProgram):
- html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::deleteObjectImpl):
- html/canvas/WebGLRenderbuffer.h: (WebCore::WebGLRenderbuffer::~WebGLRenderbuffer): (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::getInternalFormat): (WebCore::WebGLRenderbuffer::isInitialized): (WebCore::WebGLRenderbuffer::setInitialized): (WebCore::WebGLRenderbuffer::isRenderbuffer):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::beginPaint): (WebCore::WebGLRenderingContext::blendEquation): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getBufferParameter): (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): (WebCore::WebGLRenderingContext::vertexAttribPointer):
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::is3d): (WebCore::WebGLRenderingContext::isAccelerated): (WebCore::WebGLRenderingContext::graphicsContext3D): (WebCore::WebGLRenderingContext::cleanupAfterGraphicsCall): (WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState): (WebCore::WebGLRenderingContext::VertexAttribState::initValue):
- html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::deleteObjectImpl):
- html/canvas/WebGLShader.h: (WebCore::WebGLShader::~WebGLShader): (WebCore::WebGLShader::getType): (WebCore::WebGLShader::isShader):
- html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::deleteObjectImpl):
- html/canvas/WebGLTexture.h: (WebCore::WebGLTexture::~WebGLTexture): (WebCore::WebGLTexture::isCubeMapRWrapModeInitialized): (WebCore::WebGLTexture::setCubeMapRWrapModeInitialized): (WebCore::WebGLTexture::isTexture): (WebCore::WebGLTexture::LevelInfo::LevelInfo): (WebCore::WebGLTexture::LevelInfo::setInfo):
- platform/graphics/GraphicsContext3D.h: (WebCore::GraphicsContext3D::): (WebCore::GraphicsContext3D::Attributes::Attributes): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::platformLayer):
- 11:19 AM Changeset in webkit [64766] by
-
- 19 edits in trunk/LayoutTests
Update test results caused by r64763.
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/Window/window-properties.html:
- fast/dom/constructed-objects-prototypes-expected.txt:
- fast/dom/script-tests/constructed-objects-prototypes.js:
(constructorPropertiesOnWindow):
- platform/gtk/Skipped:
- platform/gtk/fast/dom/Window/window-properties-expected.txt:
- platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/gtk/fast/dom/prototype-inheritance-expected.txt:
- platform/gtk/fast/js/global-constructors-expected.txt:
- platform/qt/Skipped:
- platform/qt/fast/dom/Window/window-properties-expected.txt:
- platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/qt/fast/dom/prototype-inheritance-expected.txt:
- platform/qt/fast/js/global-constructors-expected.txt:
- platform/win/Skipped:
- platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
- platform/win/fast/dom/prototype-inheritance-expected.txt:
- platform/win/fast/js/global-constructors-expected.txt:
- 11:12 AM WebKitGTK edited by
- Small language cleanup (diff)
- 11:03 AM Changeset in webkit [64765] by
-
- 3 edits3 adds in trunk/WebKit2
Add shared memory abstraction
https://bugs.webkit.org/show_bug.cgi?id=43535
<rdar://problem/8275295>
Reviewed by Adam Roben.
- Platform/SharedMemory.h: Added.
(WebKit::SharedMemory::):
(WebKit::SharedMemory::size):
Return the size, in bytes, of the shared memory object.
(WebKit::SharedMemory::data):
Return a pointer to the shared memory object.
- Platform/mac/SharedMemoryMac.cpp: Added.
(WebKit::SharedMemory::Handle):
A shared memory handle, which can be passed in a CoreIPC Connection.
(WebKit::SharedMemory::create):
Allocate the shared memory.
(WebKit::SharedMemory::~SharedMemory):
Deallocate the shared memory.
(WebKit::SharedMemory::createHandle):
Create a mach port and pass it to the handle.
(WebKit::SharedMemory::systemPageSize):
Return the system page size, in bytes.
- Platform/win/SharedMemoryWin.cpp: Added.
Add stubbed out version.
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
Add files.
- 10:50 AM Changeset in webkit [64764] by
-
- 3 edits in trunk/WebCore
2010-08-05 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Simon Hausmann.
Make the viewport meta tag parser support the Android
target-densitydpi extension.
http://webkit.org/b/43492
http://developer.android.com/reference/android/webkit/WebView.html
Section 'Building web pages to support different screen densities'
- dom/ViewportArguments.cpp: (WebCore::setViewportFeature): (WebCore::viewportErrorMessageTemplate):
- dom/ViewportArguments.h: (WebCore::): (WebCore::ViewportArguments::ViewportArguments): (WebCore::ViewportArguments::hasCustomArgument):
- 10:42 AM Changeset in webkit [64763] by
-
- 49 edits in trunk
Unify blob related feature defines to ENABLE(BLOB).
https://bugs.webkit.org/show_bug.cgi?id=43081
Reviewed by David Levin.
.:
- cmakeconfig.h.cmake:
- configure.ac:
- Configurations/FeatureDefines.xcconfig:
WebCore:
- Configurations/FeatureDefines.xcconfig:
- GNUmakefile.am:
- WebCore.pri:
- bindings/js/JSEventTarget.cpp:
(WebCore::toJS):
- bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
- dom/EventTarget.cpp:
- dom/EventTarget.h:
- dom/ExceptionCode.h:
(WebCore::):
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::~ScriptExecutionContext):
- dom/ScriptExecutionContext.h:
- html/Blob.cpp:
- html/Blob.h:
- html/Blob.idl:
- html/FileError.h:
- html/FileError.idl:
- html/FileReader.cpp:
- html/FileReader.h:
- html/FileReader.idl:
- html/FileStream.cpp:
(WebCore::FileStream::openForRead):
- html/FileStream.h:
- html/FileStreamClient.h:
- html/FileStreamProxy.cpp:
- html/FileStreamProxy.h:
- html/FileThread.cpp:
- html/FileThread.h:
- page/DOMWindow.idl:
- platform/BlobItem.cpp:
(WebCore::getFileSnapshotModificationTime):
(WebCore::DataBlobItem::slice):
(WebCore::FileBlobItem::slice):
- platform/BlobItem.h:
- platform/network/FormData.cpp:
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendItem):
(WebCore::FormData::appendKeyValuePairItems):
- platform/network/FormData.h:
(WebCore::operator==):
- platform/network/mac/FormDataStreamMac.mm:
(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
(WebCore::formRead):
(WebCore::setHTTPBody):
WebKit/chromium:
- features.gypi:
- src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):
(WebKit::WebHTTPBody::appendFileRange):
WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
WebKit2:
- Configurations/FeatureDefines.xcconfig:
WebKitLibraries:
- win/tools/vsprops/FeatureDefines.vsprops:
- win/tools/vsprops/FeatureDefinesCairo.vsprops:
WebKitTools:
- Scripts/build-webkit:
- 10:25 AM Changeset in webkit [64762] by
-
- 2 edits in trunk/LayoutTests
Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 10:14 AM Changeset in webkit [64761] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-05 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Rubber-stamped by Xan Lopez.
Remove GHashTable left-overs. GHashTable is ref-counted, and is
correctly supported by GRefPtr.
- wtf/gobject/GOwnPtr.h:
- 10:06 AM Changeset in webkit [64760] by
-
- 2 edits in trunk
2010-08-05 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
Move files that are generated by the configure script to
DISTCLEANFILES, where they should be. This fixes building after a
make clean.
- GNUmakefile.am:
- 10:06 AM Changeset in webkit [64759] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-05 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed.
Typo fix that makes distcheck happy.
- GNUmakefile.am:
- 9:57 AM Changeset in webkit [64758] by
-
- 2 edits in trunk/WebCore
2010-08-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
When trying to wrap a Node we know is an Element fallback to a
simple Element wrapper in the worst case, not to Node.
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::createWrapper):
- 9:52 AM Changeset in webkit [64757] by
-
- 17 edits13 adds in trunk/LayoutTests
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Updated test expectations for speech input in the chromium port
https://bugs.webkit.org/show_bug.cgi?id=43563
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png: Added.
- platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png: Added.
- platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png: Added.
- platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png: Added.
- platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 9:30 AM Changeset in webkit [64756] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-05 Nico Weber <thakis@chromium.org>
Reviewed by Jeremy Orlow.
Remove useless const on return-by-value (fixes a clang warning)
https://bugs.webkit.org/show_bug.cgi?id=43491
- src/WebInputEventConversion.cpp: (WebKit::toPlatformKeyboardEventType):
- 9:23 AM Debugging With Visual Studio edited by
- (diff)
- 9:10 AM Debugging With Visual Studio edited by
- (diff)
- 9:07 AM Debugging With Visual Studio edited by
- (diff)
- 9:00 AM Debugging With Visual Studio created by
- 8:58 AM Changeset in webkit [64755] by
-
- 2 edits in trunk/WebKit2
2010-08-05 Balazs Kelemen <kb@inf.u-szeged.hu>
Rubber-stamped by Kenneth Rohde Christiansen.
[Qt] Remove redundant include paths from WebKit2.pro.
- WebKit2.pro:
- 8:55 AM Changeset in webkit [64754] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Jeremy Orlow <jorlow@chromium.org>
Don't skip speech tests.
- platform/chromium/test_expectations.txt:
- 8:43 AM WikiStart edited by
- (diff)
- 8:33 AM Changeset in webkit [64753] by
-
- 8 edits in trunk
2010-08-05 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Add test for basic values of the MathML mathvariant attribute
https://bugs.webkit.org/show_bug.cgi?id=43481
- mathml/presentation/attributes.xhtml:
- platform/mac/mathml/presentation/attributes-expected.checksum:
- platform/mac/mathml/presentation/attributes-expected.png:
- platform/mac/mathml/presentation/attributes-expected.txt:
2010-08-05 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Implement basic values of MathML mathvariant attribute
https://bugs.webkit.org/show_bug.cgi?id=43481
Test: mathml/presentation/attributes.xhtml
- css/mathml.css: (math[mathvariant="normal"], mstyle[mathvariant="normal"], mo[mathvariant="normal"], mn[mathvariant="normal"], mi[mathvariant="normal"], mtext[mathvariant="normal"], mspace[mathvariant="normal"], ms[mathvariant="normal"]): (math[mathvariant="bold"], mstyle[mathvariant="bold"], mo[mathvariant="bold"], mn[mathvariant="bold"], mi[mathvariant="bold"], mtext[mathvariant="bold"], mspace[mathvariant="bold"], ms[mathvariant="bold"]): (math[mathvariant="italic"], mstyle[mathvariant="italic"], mo[mathvariant="italic"], mn[mathvariant="italic"], mi[mathvariant="italic"], mtext[mathvariant="italic"], mspace[mathvariant="italic"], ms[mathvariant="italic"]): (math[mathvariant="bold-italic"], mstyle[mathvariant="bold-italic"], mo[mathvariant="bold-italic"], mn[mathvariant="bold-italic"], mi[mathvariant="bold-italic"], mtext[mathvariant="bold-italic"], mspace[mathvariant="bold-italic"], ms[mathvariant="bold-italic"]):
- mathml/mathattrs.in:
- 8:29 AM Changeset in webkit [64752] by
-
- 3 edits in trunk/WebKit/gtk
2010-08-05 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Use correct path for Inspector data files in GTK+3.x builds
https://bugs.webkit.org/show_bug.cgi?id=43445
Use the right data path for inspector files when building with
GTK+ 3.x.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
- 8:16 AM Changeset in webkit [64751] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 7:48 AM Changeset in webkit [64750] by
-
- 1 edit2 adds in trunk/LayoutTests
2010-08-05 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Add missing pixel test results for svg/in-html test.
- platform/mac/svg/in-html/circle-expected.checksum: Added.
- platform/mac/svg/in-html/circle-expected.png: Added.
- 7:40 AM Changeset in webkit [64749] by
-
- 17 edits7 adds in trunk
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add speech input controller mock in WebKit and a layout test.
https://bugs.webkit.org/show_bug.cgi?id=43477
- fast/speech/input-text-speechbutton-expected.txt: Added.
- fast/speech/input-text-speechbutton.html: Added.
- fast/speech/script-tests/input-text-speechbutton.js: Added. (onChange): (run):
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add speech input controller mock in WebKit and a layout test.
https://bugs.webkit.org/show_bug.cgi?id=43477
- WebKit.gyp:
- public/WebSpeechInputControllerMock.h: Added WebKit speech input controller mock interface.
- src/WebSpeechInputControllerMockImpl.cpp: Added implementation of the above mock. (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording): (WebKit::WebSpeechInputControllerMock::create):
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Add speech input controller mock in WebKit and a layout test.
https://bugs.webkit.org/show_bug.cgi?id=43477
Added LayoutTestController::setMockSpeechInputResultCallback method.
- DumpRenderTree/LayoutTestController.cpp: (setMockSpeechInputResultCallback): Wrapper invoking the member function. (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::setMockSpeechInputResult): Sets the mock result. (LayoutTestController::speechInputController): Creates the mock controller.
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::speechInputController): Creates the mock controller.
- DumpRenderTree/chromium/WebViewHost.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setMockSpeechInputResult): dummy method.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setMockSpeechInputResult): dummy method.
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setMockSpeechInputResult): dummy method.
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: dummy method. (LayoutTestController::setMockSpeechInputResult):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: dummy method. (LayoutTestController::setMockSpeechInputResult):
- 7:39 AM Changeset in webkit [64748] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Skip new debugger test on Qt.
- platform/qt/Skipped:
- 7:32 AM Changeset in webkit [64747] by
-
- 3 edits2 adds in trunk
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspected page crashes when there is a cyclic reference in Object prototype
https://bugs.webkit.org/show_bug.cgi?id=43558
Test: inspector/debugger-cyclic-ref.html
- bindings/v8/ScriptValue.cpp: (WebCore::v8ToInspectorValue):
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspected page crashes when there is a cyclic reference in Object prototype
https://bugs.webkit.org/show_bug.cgi?id=43558
- inspector/debugger-cyclic-ref-expected.txt: Added.
- inspector/debugger-cyclic-ref.html: Added.
- 7:28 AM Changeset in webkit [64746] by
-
- 10 edits3 moves14 adds4 deletes in trunk
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Fix rendering of speech button and enable layout tests
https://bugs.webkit.org/show_bug.cgi?id=43425
Added layout and pixel test expecations for speech button on chromium-linux and chromium-mac.
Also enabled the relevant layout tests on these platforms.
Non chromium ports don't have the feature flag enabled and the code does not get compiled in yet,
so there are no test expectations for those ports.
- fast/speech/input-appearance-numberandspeech-expected.txt: Removed.
- fast/speech/input-appearance-numberandspeech.html:
- fast/speech/input-appearance-searchandspeech-expected.txt: Removed.
- fast/speech/input-appearance-searchandspeech.html:
- fast/speech/input-appearance-speechbutton-expected.txt: Removed.
- fast/speech/input-appearance-speechbutton.html:
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png: Added.
- platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png: Added.
- platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt: Added.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.checksum: Added.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png: Added.
- platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt: Added.
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.checksum: Added.
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png: Added.
- platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.txt: Added.
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.checksum: Added.
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png: Added.
- platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- platform/mac/fast/forms/input-appearance-numberandspeech-expected.checksum: Removed.
- platform/mac/fast/forms/input-appearance-numberandspeech-expected.png: Removed.
- platform/mac/fast/forms/input-appearance-speechbutton-expected.checksum: Removed.
- platform/mac/fast/forms/input-appearance-speechbutton-expected.png: Removed.
2010-08-05 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Fix rendering of speech button and enable layout tests
https://bugs.webkit.org/show_bug.cgi?id=43425
Rewrote the speech button rendering code to match how the spin buttons (for input type=number)
are implemented as the previous implementation did not work well on many platforms.
- rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine): (WebCore::RenderTextControlSingleLine::layout): (WebCore::RenderTextControlSingleLine::nodeAtPoint): (WebCore::RenderTextControlSingleLine::styleDidChange): (WebCore::RenderTextControlSingleLine::hasControlClip): (WebCore::RenderTextControlSingleLine::adjustControlHeightBasedOnLineHeight): (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded): (WebCore::RenderTextControlSingleLine::createInnerTextStyle): (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle): (WebCore::RenderTextControlSingleLine::clientPaddingRight):
- rendering/RenderTextControlSingleLine.h:
- rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::create):
- rendering/TextControlInnerElements.h:
- 7:23 AM Changeset in webkit [64745] by
-
- 7 edits in trunk
2010-08-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Re-enabling inspector/extension* tests following a fix in InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=43344
- platform/gtk/Skipped:
- platform/qt/Skipped:
2010-08-05 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Separated WebInspector extension API injection logic from other scripts that inspector injects.
Enabled injection of the API scripts even if inspector is disabled for inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=43344
- inspector/InspectorController.cpp: (WebCore::InspectorController::inspectedWindowScriptObjectCleared): (WebCore::InspectorController::setInspectorExtensionAPI):
- inspector/InspectorController.h:
- inspector/InspectorFrontendHost.cpp: (WebCore::InspectorFrontendHost::setExtensionAPI):
- 7:16 AM QtScript edited by
- (diff)
- 7:02 AM Changeset in webkit [64744] by
-
- 11 edits in trunk
Get WebKitTestRunner loading TestNetscapePlugin on Windows
Fixes <http://webkit.org/b/43513> WebKitTestRunner on Windows fails to
load TestNetscapePlugin
Reviewed by Jon Honeycutt.
WebKit2:
Teach WebKit2 how to load the TestNetscapePlugin
- Platform/Module.cpp:
(WebKit::Module::Module): Initialize m_module on Windows.
- Platform/Module.h: Added m_module on Windows.
- Platform/win/ModuleWin.cpp:
(WebKit::Module::load): Implemented using ::LoadLibraryExW.
(WebKit::Module::unload): Implemented using ::FreeLibrary.
(WebKit::Module::platformFunctionPointer): Implemented using
::GetProcAddress.
- Platform/win/RunLoopWin.cpp:
(RunLoop::TimerBase::timerFired): Kill the native timer before calling
the fired callback. This makes all our timers non-repeating, but
that's all we need currently.
(RunLoop::TimerBase::start): Added an assertion to help us figure out
when we need to implement repeating timers. Also fixed a typo.
- UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::pluginsDirectories): Added a FIXME.
(WebKit::PathWalker::PathWalker):
(WebKit::PathWalker::~PathWalker):
(WebKit::PathWalker::isValid):
(WebKit::PathWalker::data):
(WebKit::PathWalker::step):
Added. This class wraps the ::FindFirstFile/::FindNextFile APIs.
(WebKit::PluginInfoStore::pluginPathsInDirectory): Implemented by
porting logic from
WebCore::PluginDatabase::getPluginPathsInDirectories.
(WebKit::getVersionInfo): Copied from PluginDatabaseWin.cpp.
(WebKit::PluginInfoStore::getPluginInfo): Implemented by porting logic
from WebCore::PluginPackage::fetchInfo.
(WebKit::PluginInfoStore::shouldUsePlugin): Changed to always return
true for now. Added a FIXME about implementing this for real.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createPlugin):
Removed PLATFORM(MAC) guards around plugin code.
- win/WebKit2.vcproj: Let VS sort the file.
WebKitTools:
Fix the path to TestNetscapePlugin's directory on Windows
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
TestNetscapePlugin is in a TestNetscapePlugin[_Debug] directory that's
next to WebKitTestRunner.exe. Previously we were passing the directory
that contains WebKitTestRunner.exe. Also fixed some leaks.
- 6:41 AM Changeset in webkit [64743] by
-
- 6 edits in trunk/WebKitTools
2010-08-05 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
check-webkit-style returns non-zero when patch is entirely minus lines.
https://bugs.webkit.org/show_bug.cgi?id=38169
- Scripts/check-webkit-style: Check whether a patch contains modified files that are entirely minus lines.
- Scripts/webkitpy/style/filereader.py: Add a variable that holds number of files that contain only deleted lines.
- Scripts/webkitpy/style/patchreader.py: Count up modified files that contain only deleted lines.
- 6:30 AM Changeset in webkit [64742] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: [REGRESSION] Frame navigation is not handled in devtools.
- src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::detach): (WebKit::WebDevToolsAgentImpl::frontendLoaded): (WebKit::WebDevToolsAgentImpl::setRuntimeFeatureEnabled):
- 6:27 AM Changeset in webkit [64741] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. More chromium test rebaselines.
- platform/chromium/test_expectations.txt:
- 6:19 AM Changeset in webkit [64740] by
-
- 3 edits2 adds in trunk
2010-08-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos.
https://bugs.webkit.org/show_bug.cgi?id=43469
<noscript> is working wrong in some cases when xhtmlmp is enabled.
- fast/xhtmlmp/noscript-basic-expected.txt: Added.
- fast/xhtmlmp/noscript-basic.xhtml: Added.
2010-08-05 Charles Wei <charles.wei@torchmobile.com.cn>
Reviewed by George Staikos.
<noscript> is working the other way around in some cases with xhtmlmp enabled
https://bugs.webkit.org/show_bug.cgi?id=43469
Test: fast/xhtmlmp/noscript-basic.xhtml
- dom/Document.cpp: (WebCore::Document::Document):
- 6:05 AM QtWebKitWeeklyBuilds edited by
- (diff)
- 5:58 AM Changeset in webkit [64739] by
-
- 3 edits in trunk/WebKit2
Use toCopiedRef for making WK objects
https://bugs.webkit.org/show_bug.cgi?id=43552
Reviewed by Kenneth Rohde Christiansen.
- UIProcess/API/cpp/qt/WKStringQt.cpp:
(WKStringCreateWithQString):
- UIProcess/API/cpp/qt/WKURLQt.cpp:
(WKURLCreateWithQUrl):
- 5:50 AM Changeset in webkit [64738] by
-
- 2 edits in trunk/WebCore
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Win compilation.
- bindings/js/JSBindingsAllInOne.cpp:
- 5:44 AM QtWebKitBackportingFixes edited by
- (diff)
- 5:40 AM Changeset in webkit [64737] by
-
- 6 edits in trunk
[Qt] Clean up the input method handling
https://bugs.webkit.org/show_bug.cgi?id=43545
Reviewed by Tor Arne Vestbø.
WebCore:
Changed input method hint interface to be more efficient by setting
all hints in one shot, like in QWidget.
- platform/qt/QWebPageClient.h:
WebKit/qt:
Replace the way of individually setting input method hints by
many calls to QWidget::setInputMethodHints with one single call.
This is more efficient by requiring less updates in the input
method hint.
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::setInputMethodHints):
(WebCore::PageClientQGraphicsWidget::setInputMethodHints):
- WebCoreSupport/PageClientQt.h:
- 5:37 AM Changeset in webkit [64736] by
-
- 2 edits10 adds1 delete in trunk/LayoutTests
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. More chromium test rebaselines.
- platform/chromium-linux/svg/in-html/circle-expected.checksum: Added.
- platform/chromium-linux/svg/in-html/circle-expected.png: Added.
- platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
- platform/chromium-mac/svg/in-html/circle-expected.checksum: Added.
- platform/chromium-mac/svg/in-html/circle-expected.png: Added.
- platform/chromium-win/svg/in-html/circle-expected.checksum: Added.
- platform/chromium-win/svg/in-html/circle-expected.png: Added.
- platform/chromium-win/svg/in-html/circle-expected.txt: Added.
- platform/chromium/test_expectations.txt:
- 5:36 AM Changeset in webkit [64735] by
-
- 17 edits4 deletes in trunk/WebCore
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove mutator methods from ScriptObject and remove ScriptArray.
We shouldn't modify JS objects from InspectorController, InspectorValues
should be used instead.
https://bugs.webkit.org/show_bug.cgi?id=43546
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptArray.cpp: Removed.
- bindings/js/ScriptArray.h: Removed.
- bindings/js/ScriptCallStack.h:
- bindings/js/ScriptObject.cpp:
- bindings/js/ScriptObject.h:
- bindings/v8/ScriptArray.cpp: Removed.
- bindings/v8/ScriptArray.h: Removed.
- bindings/v8/ScriptCallStack.h:
- bindings/v8/ScriptObject.cpp:
- bindings/v8/ScriptObject.h:
- 4:54 AM Changeset in webkit [64734] by
-
- 3 edits in trunk/WebCore
2010-08-05 Ned Holbrook <nholbrook@apple.com>
Reviewed by Darin Adler.
~5% complex layout performance improvement.
https://bugs.webkit.org/show_bug.cgi?id=43436
- platform/graphics/mac/ComplexTextController.h:
- platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use Vector rather than CFMutableData. (WebCore::ComplexTextController::ComplexTextRun::createTextRunFromFontDataCoreText): Ditto. (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Avoid typesetter allocation unless using typesetter options.
- 4:34 AM Changeset in webkit [64733] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-05 John Gregg <johnnyg@google.com>
Reviewed by Darin Fisher.
[chromium] WebFileChooserParams should have default constructor
https://bugs.webkit.org/show_bug.cgi?id=43435
- public/WebFileChooserParams.h: (WebKit::WebFileChooserParams::WebFileChooserParams):
- 4:24 AM MathML 3 testsuite results edited by
- (diff)
- 4:19 AM Changeset in webkit [64732] by
-
- 2 edits in trunk/WebCore
2010-08-05 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
targetReferenceFromResource() in SVGResources.cpp is missing an ENABLE(FILTERS) guard
https://bugs.webkit.org/show_bug.cgi?id=43550
Also updates an existing ENABLE(FILTERS) guard to avoid a compiler
warning 'case FilterResourceType not handled in switch' when FILTERS
is not enabled.
No new tests, build fix only.
- rendering/SVGResources.cpp: (WebCore::targetReferenceFromResource): (WebCore::SVGResources::resourceDestroyed):
- 4:15 AM Changeset in webkit [64731] by
-
- 5 edits in trunk
2010-08-05 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Added logic to use glMapTexSubImage2D to write video layer to GPU
texture. Also fixes CPU usage problem from previous patch.
https://bugs.webkit.org/show_bug.cgi?id=43101
No change in user-visible functionality (since it isn't turned on),
so no new tests.
- platform/graphics/chromium/VideoLayerChromium.cpp: (WebCore::VideoLayerChromium::VideoLayerChromium): (WebCore::VideoLayerChromium::updateTextureContents): (WebCore::VideoLayerChromium::createTextureRect): (WebCore::VideoLayerChromium::updateTextureRect): (WebCore::VideoLayerChromium::updateCompleted):
- platform/graphics/chromium/VideoLayerChromium.h:
2010-08-05 Victoria Kirst <vrk@google.com>
Reviewed by David Levin.
Added a repaint request so that VideoLayerChromium does not have
a flickering problem when playing video.
https://bugs.webkit.org/show_bug.cgi?id=43101
- src/WebMediaPlayerClientImpl.cpp: (WebKit::WebMediaPlayerClientImpl::repaint):
- 3:55 AM Changeset in webkit [64730] by
-
- 26 edits3 adds in trunk/LayoutTests
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium expectations update.
- 3:00 AM Changeset in webkit [64729] by
-
- 14 edits in trunk
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
DevTools: get rid of delayed command dispatching on front-end side.
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendFrontendLoaded):
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::frontendLoaded):
- src/WebDevToolsAgentImpl.h:
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): (WebKit::WebDevToolsFrontendImpl::frontendLoaded):
- src/WebDevToolsFrontendImpl.h:
- src/js/DevTools.js: (WebInspector.doLoadedDone):
- src/js/Tests.js: (.uiTests.runTest):
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
DevTools: get rid of delayed command dispatching on front-end side.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::detach): (DRTDevToolsAgent::frontendLoaded):
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::~DRTDevToolsClient): (DRTDevToolsClient::sendFrontendLoaded):
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- 2:56 AM Changeset in webkit [64728] by
-
- 141 edits39 adds in trunk/LayoutTests
2010-08-05 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Rebaselined a bunch of chromium layout tests after the parser switch.
- 2:25 AM QtWebKitBackportingFixes edited by
- (diff)
- 2:25 AM Changeset in webkit [64727] by
-
- 1 edit in trunk/WebKit/qt/tests/qwebview/tst_qwebview.cpp
Remove stray debug output
- 2:25 AM Changeset in webkit [64726] by
-
- 2 edits in trunk/WebCore
2010-08-05 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
Allow custom memory allocation control for ClipperData struct
https://bugs.webkit.org/show_bug.cgi?id=43337
Inherits the following class from FastAllocBase because it is
instantiated by 'new':
class name - instantiated at: WebCore/'location'
RenderLayerBacking - rendering/RenderSVGResourceClipper.cpp:165
- rendering/RenderSVGResourceClipper.h:
- 2:19 AM Changeset in webkit [64725] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Input mode states are not reset after entering a password field
https://bugs.webkit.org/show_bug.cgi?id=43530
Patch by David Leong <david.leong@nokia.com> on 2010-08-05
Reviewed by Simon Hausmann.
Input mode hints are not reset if clicking on password <input> elements then
clicking on <textarea> elements
- WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
- tests/qwebview/resources/input_types.html:
- tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes):
- 2:06 AM Changeset in webkit [64724] by
-
- 2 edits in trunk/WebCore
2010-08-05 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Simon Hausmann.
Allow custom memory allocation control for DoctypeData class
https://bugs.webkit.org/show_bug.cgi?id=43343
Inherits the following class from Noncopyable because it is
instantiated by 'new' and no need to be copyable:
class name - instantiated at: WebCore/'location'
DoctypeData - html/HTMLToken.h:113
- html/HTMLToken.h:
- 1:45 AM Changeset in webkit [64723] by
-
- 2 edits in trunk/WebCore
2010-08-05 François Sausset <François Sausset>
Reviewed by Darin Adler.
Small style adjustments for MathML merror element.
https://bugs.webkit.org/show_bug.cgi?id=43432
- css/mathml.css: (merror):
- 1:31 AM Changeset in webkit [64722] by
-
- 12 edits in trunk/WebCore
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: forbid InspectorController to create script objects directly in the frontend
https://bugs.webkit.org/show_bug.cgi?id=43541
Cookie and AppCache data are now serialized into InspectorValues instead of
ScriptObjects. These were last usages of InspectorFrontend::newScript{Object,Array}
so we can remove them now and use only InspectorValues to pass data to the inspector
frontend.
- inspector/Inspector.idl:
- inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent): (WebCore::InspectorApplicationCacheAgent::getApplicationCaches): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCache): (WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources): (WebCore::InspectorApplicationCacheAgent::buildObjectForApplicationCacheResource):
- inspector/InspectorApplicationCacheAgent.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend): (WebCore::InspectorController::getCookies): (WebCore::InspectorController::buildArrayForCookies): (WebCore::InspectorController::buildObjectForCookie):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp: (WebCore::InspectorFrontend::setRecordingProfile):
- inspector/InspectorFrontend.h:
- 12:55 AM Changeset in webkit [64721] by
-
- 2 edits in trunk/WebCore
2010-08-05 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Xan Lopez.
[GTK] Extra check needed at AccessibilityObject::visiblePositionRangeForRange
https://bugs.webkit.org/show_bug.cgi?id=43418
Ensure the renderer is a RenderText before calling toRenderText()
Also, simplified code a bit to avoid so many nested if's in that
part of the code, while keeping the same logic.
- accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::visiblePositionRangeForRange):
- 12:36 AM Changeset in webkit [64720] by
-
- 2 edits in trunk/WebCore
2010-08-05 Kwang Yul Seo <skyul@company100.net>
Reviewed by Kent Tamura.
[BREWMP] Define htonl, htons, ntohl and ntohs
https://bugs.webkit.org/show_bug.cgi?id=43397
In BREWMP, AEEStdLib.h provides macros for byte order conversion: HTONL, HTONS, NTOHL and NTOHS.
Use these macros to define htonl, htons, ntohl and ntohs used by WOFFFileFormat.cpp.
- platform/graphics/WOFFFileFormat.cpp:
- 12:11 AM Changeset in webkit [64719] by
-
- 2 edits in trunk/LayoutTests
2010-08-05 Adam Barth <abarth@webkit.org>
residual-style-hang times out on Gtk
https://bugs.webkit.org/show_bug.cgi?id=43540
Skip fast/parser/residual-style-hang.html on Gtk. Hopefully someone
with access to a Gtk machine can help us understand why this is
hanging. There's (a little) more information in the bug page.
- platform/gtk/Skipped:
- 12:11 AM Changeset in webkit [64718] by
-
- 3 edits in trunk/WebKitTools
2010-08-04 Kenichi Ishibashi <bashi@google.com>
Reviewed by Shinichiro Hamaji.
Fixes check-webkit-style false positive on "new uint32_t."
https://bugs.webkit.org/show_bug.cgi?id=43077
- Scripts/webkitpy/style/checkers/cpp.py:
- Scripts/webkitpy/style/checkers/cpp_unittest.py:
- 12:01 AM Changeset in webkit [64717] by
-
- 1 edit4 adds in trunk/LayoutTests
2010-08-05 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Add a test for SVG-in-HTML
https://bugs.webkit.org/show_bug.cgi?id=43539
Just a basic test that we can render SVG in HTML.
- platform/mac/svg/in-html/circle-expected.txt: Added.
- svg/in-html/circle.html: Added.
Aug 4, 2010:
- 11:44 PM Changeset in webkit [64716] by
-
- 10 edits80 adds in trunk
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
Reviewed by Nikolas Zimmermann.
WebCore:
Implementing svgAttributeChanged for SVGFESpotLightElement object.
Furthermore, invalidateFilter has been moved to SVGFilterElement, and
it is a static function now.
Tests: svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr.html
svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop.html
svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop.html
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged):
(WebCore::SVGFELightElement::childrenChanged):
- svg/SVGFELightElement.h:
- svg/SVGFEOffsetElement.cpp:
(WebCore::SVGFEOffsetElement::svgAttributeChanged):
- svg/SVGFESpecularLightingElement.cpp:
- svg/SVGFilterElement.h:
(WebCore::SVGFilterElement::invalidateFilter):
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
- svg/SVGFilterPrimitiveStandardAttributes.h:
LayoutTests:
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.png: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.checksum: Added.
- platform/mac/svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.png: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-limitingConeAngle-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtX-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtY-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-pointsAtZ-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-specularExponent-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-x-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-y-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-dom-z-attr.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtX-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtY-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-pointsAtZ-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-specularExponent-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-x-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-y-prop.html: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop-expected.txt: Added.
- svg/dynamic-updates/SVGFESpotLightElement-svgdom-z-prop.html: Added.
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-limitingConeAngle-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtX-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtY-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-pointsAtZ-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-specularExponent-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-x-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-y-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-dom-z-attr.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-limitingConeAngle-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtX-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtY-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-pointsAtZ-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-specularExponent-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-x-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-y-prop.js: Added.
(executeTest):
- svg/dynamic-updates/script-tests/SVGFESpotLightElement-svgdom-z-prop.js: Added.
(executeTest):
- 11:38 PM Changeset in webkit [64715] by
-
- 2 edits in trunk/LayoutTests
2010-08-04 Adam Barth <abarth@webkit.org>
Enable HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42804
Update expected results for Leopard.
- platform/mac-leopard/fast/forms/file-input-disabled-expected.txt:
- 11:15 PM Changeset in webkit [64714] by
-
- 7 edits in trunk/LayoutTests
2010-08-04 Adam Barth <abarth@webkit.org>
Enable HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42804
Update expected results for Qt. These results look correct vis-a-vis
the Mac changes.
- platform/qt/fast/block/float/4145535Crash-expected.txt:
- platform/qt/fast/dom/isindex-001-expected.txt:
- platform/qt/fast/forms/isindex-placeholder-expected.txt:
- platform/qt/fast/forms/text-style-color-expected.txt:
- platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/qt/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- 11:00 PM Changeset in webkit [64713] by
-
- 7 edits in trunk/WebCore
2010-08-05 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: serialize DOM storage items to InspectorValues
https://bugs.webkit.org/show_bug.cgi?id=43486
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didUseDOMStorage): (WebCore::InspectorController::selectDOMStorage): (WebCore::InspectorController::getDOMStorageEntries): (WebCore::InspectorController::setDOMStorageItem): (WebCore::InspectorController::removeDOMStorageItem):
- inspector/InspectorDOMStorageResource.cpp: (WebCore::InspectorDOMStorageResource::bind):
- inspector/InspectorDOMStorageResource.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- 10:57 PM Changeset in webkit [64712] by
-
- 90 edits in trunk
2010-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Enable HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42804
Lots of crazy changes. As far as we can tell, these
are all progressions/match minefield. For a more in-depth,
per-test breakdown see the spreadsheet:
http://spreadsheets.google.com/ccc?key=0AlC4tS7Ao1fIdEo0SFdLaVpiclBHMVNQcHlTenV5TEE
- dom/html/level2/html/HTMLIsIndexElement01-expected.txt: Expected, <isindex> now gets converted into a <form><input> tree.
- dom/html/level2/html/HTMLIsIndexElement02-expected.txt:
- dom/html/level2/html/HTMLIsIndexElement03-expected.txt:
- editing/execCommand/indent-div-inside-list-expected.txt:
- fast/dom/HTMLLabelElement/label-control-expected.txt:
- fast/dom/attribute-case-sensitivity-expected.txt:
- fast/dom/no-elements-expected.txt:
- fast/events/tabindex-focus-blur-all-expected.txt:
- fast/forms/datalist-nonoption-child-expected.txt:
- fast/lists/ol-nested-items-expected.txt:
- fast/parser/remove-current-node-parent-expected.txt:
- fast/parser/residual-style-dom-expected.txt:
- fast/parser/residual-style-hang-expected.txt:
- html5lib/runner-expected.txt: massive progression
- html5lib/webkit-resumer-expected.txt: massive progression.
- http/tests/misc/isindex-formdata-expected.txt:
- http/tests/misc/isindex-with-no-form-base-href-expected.txt:
- http/tests/xmlhttprequest/close-window-expected.txt:
- platform/mac/editing/selection/designmode-no-caret-expected.txt:
- platform/mac/fast/block/float/4145535Crash-expected.txt:
- platform/mac/fast/block/float/float-in-float-painting-expected.txt:
- platform/mac/fast/dom/isindex-001-expected.txt:
- platform/mac/fast/dom/isindex-002-expected.txt:
- platform/mac/fast/events/focusingUnloadedFrame-expected.txt:
- platform/mac/fast/forms/file-input-disabled-expected.txt:
- platform/mac/fast/forms/form-added-to-table-expected.txt:
- platform/mac/fast/forms/form-element-geometry-expected.txt:
- platform/mac/fast/forms/form-in-malformed-markup-expected.txt:
- platform/mac/fast/forms/formmove3-expected.txt:
- platform/mac/fast/forms/isindex-placeholder-expected.txt:
- platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
- platform/mac/fast/forms/text-style-color-expected.txt:
- platform/mac/fast/invalid/004-expected.txt:
- platform/mac/fast/invalid/005-expected.txt:
- platform/mac/fast/invalid/007-expected.txt:
- platform/mac/fast/invalid/012-expected.txt:
- platform/mac/fast/invalid/017-expected.txt:
- platform/mac/fast/invalid/018-expected.txt:
- platform/mac/fast/invalid/019-expected.txt:
- platform/mac/fast/invalid/missing-address-end-tag-expected.txt:
- platform/mac/fast/invalid/missing-font-end-tag-expected.txt:
- platform/mac/fast/invalid/residual-style-expected.txt:
- platform/mac/fast/invalid/table-inside-stray-table-content-expected.txt:
- platform/mac/fast/invalid/table-residual-style-crash-expected.txt:
- platform/mac/fast/parser/nofoo-tags-inside-paragraph-expected.txt:
- platform/mac/fast/parser/remove-block-in-residual-style-expected.txt:
- platform/mac/fast/parser/title-error-test-expected.txt:
- platform/mac/fast/table/fixed-table-non-cell-in-row-expected.txt:
- platform/mac/fast/table/giantCellspacing-expected.txt:
- platform/mac/fast/table/inline-form-assert-expected.txt:
- platform/mac/fast/table/insert-cell-before-form-expected.txt:
- platform/mac/fast/table/insert-row-before-form-expected.txt:
- platform/mac/fast/text/large-text-composed-char-expected.txt:
- platform/mac/fonts/cursive-expected.txt:
- platform/mac/fonts/fantasy-expected.txt:
- platform/mac/fonts/monospace-expected.txt:
- platform/mac/fonts/sans-serif-expected.txt:
- platform/mac/fonts/serif-expected.txt:
- platform/mac/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
- platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
- platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug137388-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2267-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2516-expected.txt:
- platform/mac/tables/mozilla/bugs/bug2757-expected.txt:
- platform/mac/tables/mozilla/bugs/bug278385-expected.txt:
- platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
- platform/mac/tables/mozilla/bugs/bug32447-expected.txt:
- platform/mac/tables/mozilla/bugs/bug34538-expected.txt:
- platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
- platform/mac/tables/mozilla/bugs/bug48028-1-expected.txt:
- platform/mac/tables/mozilla/bugs/bug48028-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug53690-2-expected.txt:
- platform/mac/tables/mozilla/bugs/bug56563-expected.txt:
- platform/mac/tables/mozilla/bugs/bug78162-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
- platform/mac/tables/mozilla/bugs/bug96343-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
- platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
- platform/mac/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
- webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
- webarchive/test-frameset-expected.webarchive:
2010-08-04 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Enable HTML5 tree builder
https://bugs.webkit.org/show_bug.cgi?id=42804
Months of work into a single line code change.
Geez. Should have thought of this sooner.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
- 10:51 PM Changeset in webkit [64711] by
-
- 3 edits3 adds in trunk
Spin-button behavior improvement for out-of-range values
https://bugs.webkit.org/show_bug.cgi?id=43463
Reviewed by Darin Adler.
WebCore:
If the current value is smaller than the minimum value, the up
button should change the value to the minimum value. If the
current value is larger than the maximum value, the down button
should change the value to the maximum value.
Test: fast/forms/input-number-outofrange.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer):
LayoutTests:
- fast/forms/input-number-outofrange-expected.txt: Added.
- fast/forms/input-number-outofrange.html: Added.
- fast/forms/script-tests/input-number-outofrange.js: Added.
- 10:20 PM Changeset in webkit [64710] by
-
- 4 edits in trunk/WebKitTools
2010-08-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove base/linked_ptr.h dependency
https://bugs.webkit.org/show_bug.cgi?id=43472
Replace linked_ptr<TestNavigationEntry> with RefPtr<TestNavigationEntry>.
We need to use RefPtr<> because m_pendingEntry points an object in
m_entries or not in m_entries.
- DumpRenderTree/chromium/TestNavigationController.cpp: (TestNavigationEntry::create): Added. (TestNavigationController::activeEntry): (TestNavigationController::didNavigateToEntry): (TestNavigationController::discardPendingEntry): (TestNavigationController::insertEntry): (TestNavigationController::navigateToPendingEntry):
- DumpRenderTree/chromium/TestNavigationController.h:
- DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::loadURLForFrame): Use TestNavigationEntry::create(). (WebViewHost::updateURL): Use RefPtr<>. (WebViewHost::updateSessionHistory): Remove unnecessary static_cast<>.
- 10:19 PM Changeset in webkit [64709] by
-
- 2 edits in trunk/WebKitTools
2010-08-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Fix a problem that "archived test results" step doesn't work on Chromium buildbots
https://bugs.webkit.org/show_bug.cgi?id=43333
- BuildSlaveSupport/test-result-archive:
- Make layoutTestResultsDir local and pass it to archiveTestResults()
- Adjust layoutTestResultsDir for Chromium
- 10:17 PM Changeset in webkit [64708] by
-
- 2 edits in trunk/WebKitTools
2010-08-04 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
NRWT: websocket_server startup detection failure
https://bugs.webkit.org/show_bug.cgi?id=43466
- Scripts/webkitpy/layout_tests/port/websocket_server.py: Increase timeout value: 5 second -> 10 second
- 9:55 PM Changeset in webkit [64707] by
-
- 2 edits in trunk/LayoutTests
2010-08-04 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
- platform/chromium/drt_expectations.txt: Add flaky tests on DRT/Chromium/Mac
- 9:52 PM Changeset in webkit [64706] by
-
- 4 edits3 adds in trunk
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=43461
Invalid NaN parsing
Reviewed by Oliver Hunt and Beth Dakin.
- wtf/dtoa.cpp: Turn off the dtoa feature that allows you to specify a
non-standard NaN representation, since our NaN encoding assumes that all
true NaNs have the standard bit pattern.
- API/JSValueRef.cpp:
(JSValueMakeNumber): Don't allow an API client to accidentally specify
a non-standard NaN either.
LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=43461
Crash parsing certain values for NaN
Reviewed by Oliver Hunt and Beth Dakin.
- fast/js/parse-nan.html: Added.
- fast/js/script-tests/parse-nan.js: Added.
- 8:27 PM Changeset in webkit [64705] by
-
- 2 edits in trunk/WebCore
2010-08-04 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Daniel Bates.
Remove superfluous non-negative checks in HitTestResult:padding{Width|Height}
https://bugs.webkit.org/show_bug.cgi?id=43534
As pointed out by Steve Block in https://bugs.webkit.org/show_bug.cgi?id=40197#c54 ,
the non-negative checks present in both paddingWidth and paddingHeight methods of
HitTestResults class are superflous, after we changed the rect based hit testing logic
of invalid padding from IntSize(-1, -1) to IntSize(0, 0). Patch addresses this issue.
No new tests needed.
- rendering/HitTestResult.h: (WebCore::HitTestResult::paddingWidth): (WebCore::HitTestResult::paddingHeight):
- 7:22 PM Changeset in webkit [64704] by
-
- 6 edits25 deletes in trunk
2010-08-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64674.
http://trac.webkit.org/changeset/64674
https://bugs.webkit.org/show_bug.cgi?id=43532
Doesn't work with HTML5 tree builder (Requested by tonyg-cr on
#webkit).
- fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Removed.
- fast/dom/HTMLScriptElement/defer-double-defer-write.html: Removed.
- fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Removed.
- fast/dom/HTMLScriptElement/defer-double-write.html: Removed.
- fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Removed.
- fast/dom/HTMLScriptElement/defer-inline-script.html: Removed.
- fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Removed.
- fast/dom/HTMLScriptElement/defer-onbeforeload.html: Removed.
- fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Removed.
- fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Removed.
- fast/dom/HTMLScriptElement/resources/defer.js: Removed.
- fast/dom/HTMLScriptElement/resources/external.js: Removed.
- fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Removed.
- http/tests/misc/resources/defer-script.js: Removed.
- http/tests/misc/resources/external-script.js: Removed.
- http/tests/misc/resources/script-debug-body-background.js: Removed.
- http/tests/misc/resources/script-write-slow-stylesheet.js: Removed.
- http/tests/misc/resources/slow-defer-script.cgi: Removed.
- http/tests/misc/resources/slow-stylesheet.cgi: Removed.
- http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Removed.
- http/tests/misc/script-defer-after-slow-stylesheet.html: Removed.
- http/tests/misc/script-defer-expected.txt: Removed.
- http/tests/misc/script-defer-write-slow-stylesheet-expected.txt: Removed.
- http/tests/misc/script-defer-write-slow-stylesheet.html: Removed.
- http/tests/misc/script-defer.html: Removed.
2010-08-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64674.
http://trac.webkit.org/changeset/64674
https://bugs.webkit.org/show_bug.cgi?id=43532
Doesn't work with HTML5 tree builder (Requested by tonyg-cr on
#webkit).
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed):
- html/HTMLDocumentParser.h:
- html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::runScript):
- html/HTMLScriptRunner.h:
- 6:19 PM Changeset in webkit [64703] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix part II.
- wtf/PageReservation.h:
(WTF::PageReservation::systemReserve):
- 6:10 PM Changeset in webkit [64702] by
-
- 3 edits2 adds in trunk
2010-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
fast/parser/residual-style-hang.html hangs
https://bugs.webkit.org/show_bug.cgi?id=42950
Add a dump-as-markup test that shows what DOM we actually create in
this case.
Note: these results are for the existing parser.
- fast/parser/residual-style-dom-expected.txt: Added.
- fast/parser/residual-style-dom.html: Added.
2010-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
fast/parser/residual-style-hang.html hangs
https://bugs.webkit.org/show_bug.cgi?id=42950
We need to cap the iteration of the adoption agency algorithm to
prevent this hang. The legacy tree builder does this as well.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
- 6:02 PM Changeset in webkit [64701] by
-
- 2 edits in trunk/LayoutTests
Unreviewed fix for chromium test expectations.
- platform/chromium/test_expectations.txt: Removed incorrectly formatted line.
- 5:53 PM Changeset in webkit [64700] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- wtf/PageReservation.h:
(WTF::PageReservation::systemReserve):
- 5:36 PM Changeset in webkit [64699] by
-
- 4 edits in trunk
2010-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pick up spec change w.r.t. figcaption and summary
https://bugs.webkit.org/show_bug.cgi?id=43075
- html5lib/runner-expected-html5.txt:
2010-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pick up spec change w.r.t. figcaption and summary
https://bugs.webkit.org/show_bug.cgi?id=43075
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processEndTagForInBody):
- 5:34 PM Changeset in webkit [64698] by
-
- 4 edits in trunk
2010-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pick up spec change w.r.t. replacement character and <frameset>
https://bugs.webkit.org/show_bug.cgi?id=43073
- html5lib/runner-expected-html5.txt:
2010-08-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pick up spec change w.r.t. replacement character and <frameset>
https://bugs.webkit.org/show_bug.cgi?id=43073
Apparently this fixes parsing for some home router configuration pages.
- html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::processCharacterBuffer):
- 5:31 PM Changeset in webkit [64697] by
-
- 2 edits in trunk/LayoutTests
Unreviewed change to Chromium test expectations to mark hyphenate-locale.html as failing.
- platform/chromium/test_expectations.txt: mark hyphenate-locate.html as failing.
- 5:21 PM Changeset in webkit [64696] by
-
- 4 edits in trunk/JavaScriptCore
Build fix - add new header to !Mac projects.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- 5:18 PM Changeset in webkit [64695] by
-
- 13 edits1 copy2 adds in trunk
JavaScriptCore: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
Reviewed by Sam Weinig.
The PageAllocation class has a number of issues:
- Changes in bug #43269 accidentally switched SYMBIAN over to use malloc/free to allocate blocks of memory for the GC heap, instead of allocating RChunks. Revert this change in behaviour.
- In order for PageAllocation to work correctly on WinCE we should be decommitting memory before deallocating. In order to simplify understanding the expected state at deallocate, split behaviour out into PageAllocation and PageReservation classes. Require that all memory be decommitted before calling deallocate on a PageReservation, add asserts to enforce this.
- add many missing asserts.
- inline more functions.
- remove ability to create sub-PageAllocations from an existing PageAllocations object - this presented an interface that would allow sub regions to be deallocated, which would not have provided expected behaviour.
- remove writable/executable arguments to commit, this value can be cached at the point the memory is reserved.
- remove writable/executable arguments to allocateAligned, protection other than RW is not supported.
- add missing checks for overflow & failed allocation to mmap path through allocateAligned.
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::intializePageSize):
- jit/ExecutableAllocator.h:
(JSC::ExecutablePool::Allocation::Allocation):
(JSC::ExecutablePool::Allocation::base):
(JSC::ExecutablePool::Allocation::size):
(JSC::ExecutablePool::Allocation::operator!):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::reuse):
(JSC::FixedVMPoolAllocator::coalesceFreeSpace):
(JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
(JSC::FixedVMPoolAllocator::alloc):
(JSC::FixedVMPoolAllocator::free):
(JSC::FixedVMPoolAllocator::allocInternal):
- runtime/AlignedMemoryAllocator.h:
(JSC::::allocate):
(JSC::::AlignedMemoryAllocator):
- runtime/Collector.cpp:
(JSC::Heap::allocateBlock):
- runtime/Collector.h:
- wtf/PageAllocation.cpp:
- wtf/PageAllocation.h:
(WTF::PageAllocation::operator!):
(WTF::PageAllocation::allocate):
(WTF::PageAllocation::allocateAt):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::deallocate):
(WTF::PageAllocation::pageSize):
(WTF::PageAllocation::systemAllocate):
(WTF::PageAllocation::systemAllocateAt):
(WTF::PageAllocation::systemAllocateAligned):
(WTF::PageAllocation::systemDeallocate):
(WTF::PageAllocation::systemPageSize):
- wtf/PageReservation.h: Copied from JavaScriptCore/wtf/PageAllocation.h.
(WTF::PageReservation::PageReservation):
(WTF::PageReservation::commit):
(WTF::PageReservation::decommit):
(WTF::PageReservation::reserve):
(WTF::PageReservation::reserveAt):
(WTF::PageReservation::deallocate):
(WTF::PageReservation::systemCommit):
(WTF::PageReservation::systemDecommit):
(WTF::PageReservation::systemReserve):
(WTF::PageReservation::systemReserveAt):
- wtf/Platform.h:
JavaScriptGlue: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
(add forwarding headers)
Reviewed by Sam Weinig.
- ForwardingHeaders/wtf/Bitmap.h: Added.
- ForwardingHeaders/wtf/PageReservation.h: Added.
WebCore: Bug 43515 - Fix small design issues with PageAllocation, split out PageReservation.
(add forwarding headers)
Reviewed by Sam Weinig.
- ForwardingHeaders/wtf/Bitmap.h: Added.
- ForwardingHeaders/wtf/PageReservation.h: Added.
- 5:13 PM Changeset in webkit [64694] by
-
- 3 edits in trunk/WebKitTools
2010-08-04 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] [QtTestBrowser] Remove unneeded QAction class members
https://bugs.webkit.org/show_bug.cgi?id=43518
LauncherWindow class has two totally unneeded class members: m_flopAnimated and
m_flipYAnimated. Also, in initializeView method there are some dead code block
trying to connect them at the wrong time, when they have not been instanciated.
This patch:
- removes the two cited class members in favor of local variables in createChrome method;
- removes the dead code block.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::initializeView): (LauncherWindow::createChrome):
- QtTestBrowser/launcherwindow.h:
- 5:12 PM Changeset in webkit [64693] by
-
- 20 edits3 copies in branches/audio/WebCore
Implement more carefully thought out JavaScriptAudioNode for direct JavaScript audio processing
- works with a simple test case (amplitude modulation effect), but not heavily tested
- can be routed together with other AudioNode objects for hybrid processing
- the API still needs a little more work, but it's coming along
- still may need V8 bindings work for Chrome
- 5:12 PM Changeset in webkit [64692] by
-
- 3 edits3 moves in branches/audio/WebCore
Change name of JavascriptAudioSourceNode to JavaScriptAudioNode
- 5:12 PM Changeset in webkit [64691] by
-
- 1 edit in trunk/WebKitTools/QtTestBrowser/launcherwindow.cpp
2010-08-04 Antonio Gomes <tonikitoo@webkit.org>
Unreviewed missing bit of r64673
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- 5:12 PM Changeset in webkit [64690] by
-
- 20 edits in branches/audio/WebCore/audio
General random cleanup in audio branch
- 5:12 PM Changeset in webkit [64689] by
-
- 10 edits in branches/audio/WebCore/audio
Add create() methods for all the AudioNode objects
- 5:06 PM Changeset in webkit [64688] by
-
- 11 edits3 adds in trunk/WebKit2
2010-08-04 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Change callback APIs to include an Error object in one callback, instead of having a second callback for failure.
https://bugs.webkit.org/show_bug.cgi?id=43522
This includes adding a WKErrorRef object which - for now - either exists or doesn't.
In the future, it may contain useful information about the error.
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- win/WebKit2Generated.make:
- Shared/APIObject.h: (WebKit::APIObject::):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
- Shared/WebError.h: Added. (WebKit::WebError::create): (WebKit::WebError::WebError): (WebKit::WebError::type):
- UIProcess/API/C/WKError.cpp: Added. (WKErrorGetTypeID):
- UIProcess/API/C/WKError.h: Added.
- UIProcess/API/C/WKPage.cpp: (WKPageRunJavaScriptInMainFrame): (callRunJavaScriptBlockAndRelease): (WKPageRunJavaScriptInMainFrame_b): (WKPageRenderTreeExternalRepresentation): (callRenderTreeExternalRepresentationBlockAndDispose): (WKPageRenderTreeExternalRepresentation_b):
- UIProcess/API/C/WKPage.h:
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/GenericCallback.h: (WebKit::GenericCallback::create): (WebKit::GenericCallback::performCallbackWithReturnValue): (WebKit::GenericCallback::invalidate): (WebKit::GenericCallback::GenericCallback):
- 4:50 PM Changeset in webkit [64687] by
-
- 8 edits3 adds in trunk/WebKitTools
2010-08-04 Victor Wang <victorw@chromium.org>
Reviewed by Ojan Vafai.
-. Add result.json incremental merging functionality to test results app engine.
-. blobstore is not suitable for AE data merging and there is no API to
programatically edit existing blob or write a new one yet, so replace blobstore
with datastore. If file is oversize (>1000*1000 bytes), store file data in
multiple datastore entries.
-. Fix styles.
Test: jsonresults_unittest to test merging logics.
- TestResultServer/handlers/dashboardhandler.py:
- TestResultServer/handlers/menu.py:
- TestResultServer/handlers/testfilehandler.py:
- TestResultServer/main.py:
- TestResultServer/model/dashboardfile.py:
- TestResultServer/model/datastorefile.py: Added.
- TestResultServer/model/jsonresults.py: Added.
- TestResultServer/model/jsonresults_unittest.py: Added.
- TestResultServer/model/testfile.py:
- TestResultServer/templates/uploadform.html:
- 4:13 PM Changeset in webkit [64686] by
-
- 2 edits in trunk/WebCore
2010-08-04 Zhenyao Mo <zmo@google.com>
Reviewed by Adam Barth.
getAttachedShaders takes wrong parameter type in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=43517
- html/canvas/WebGLRenderingContext.idl: Fix the wrong parameter type in getAttachedShaders().
- 3:48 PM Changeset in webkit [64685] by
-
- 23 edits2 moves in trunk/WebCore
2010-08-04 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Rename CanvasObject to WebGLObject
https://bugs.webkit.org/show_bug.cgi?id=31564
Renamed CanvasObject to WebGLObject using do-webcore-rename script.
Because it seems the new convention is to not check in the changes
made to this script, only checking in its effects. No new tests;
built and ran WebGL in Safari and Chromium to test.
- Android.mk:
- WebCore.gypi:
- WebCore.pro:
- WebCore.xcodeproj/project.pbxproj:
- html/canvas/CanvasObject.cpp: Removed.
- html/canvas/CanvasObject.h: Removed.
- html/canvas/CanvasRenderingContext.h:
- html/canvas/WebGLBuffer.cpp: (WebCore::WebGLBuffer::WebGLBuffer):
- html/canvas/WebGLBuffer.h:
- html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::WebGLFramebuffer): (WebCore::WebGLFramebuffer::setAttachment): (WebCore::WebGLFramebuffer::onAttachedObjectChange): (WebCore::WebGLFramebuffer::isUninitialized): (WebCore::WebGLFramebuffer::setInitialized):
- html/canvas/WebGLFramebuffer.h:
- html/canvas/WebGLObject.cpp: Copied from WebCore/html/canvas/CanvasObject.cpp. (WebCore::WebGLObject::WebGLObject): (WebCore::WebGLObject::~WebGLObject): (WebCore::WebGLObject::setObject): (WebCore::WebGLObject::deleteObject):
- html/canvas/WebGLObject.h: Copied from WebCore/html/canvas/CanvasObject.h.
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::WebGLProgram):
- html/canvas/WebGLProgram.h:
- html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::WebGLRenderbuffer):
- html/canvas/WebGLRenderbuffer.h:
- html/canvas/WebGLRenderingContext.cpp: (WebCore::objectOrZero): (WebCore::WebGLRenderingContext::validateWebGLObject): (WebCore::WebGLRenderingContext::removeObject): (WebCore::WebGLRenderingContext::addObject): (WebCore::WebGLRenderingContext::detachAndRemoveAllObjects): (WebCore::WebGLRenderingContext::findTexture): (WebCore::WebGLRenderingContext::findRenderbuffer): (WebCore::WebGLRenderingContext::findBuffer): (WebCore::WebGLRenderingContext::findShader):
- html/canvas/WebGLRenderingContext.h:
- html/canvas/WebGLShader.cpp: (WebCore::WebGLShader::WebGLShader):
- html/canvas/WebGLShader.h:
- html/canvas/WebGLTexture.cpp: (WebCore::WebGLTexture::WebGLTexture):
- html/canvas/WebGLTexture.h:
- html/canvas/WebGLUniformLocation.h:
- platform/graphics/mac/GraphicsContext3DMac.mm:
- platform/graphics/qt/GraphicsContext3DQt.cpp:
- 3:21 PM Changeset in webkit [64684] by
-
- 15 edits in trunk
2010-08-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64655.
http://trac.webkit.org/changeset/64655
https://bugs.webkit.org/show_bug.cgi?id=43496
JavaScriptCore references patch seems to have caused
regressions in QT and GTK builds (Requested by nlawrence on
#webkit).
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
- runtime/Collector.cpp: (JSC::Heap::markConservatively):
- runtime/JSCell.h: (JSC::JSValue::asCell): (JSC::MarkStack::append):
- runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
- runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object):
- runtime/JSObject.h: (JSC::JSObject::prototype):
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
- runtime/JSValue.h: (JSC::JSValue::): (JSC::JSValue::JSValue): (JSC::JSValue::asCell):
- runtime/MarkStack.h:
- runtime/NativeErrorConstructor.cpp:
- runtime/NativeErrorConstructor.h:
- runtime/Structure.h: (JSC::Structure::storedPrototype):
2010-08-04 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64655.
http://trac.webkit.org/changeset/64655
https://bugs.webkit.org/show_bug.cgi?id=43496
JavaScriptCore references patch seems to have caused
regressions in QT and GTK builds (Requested by nlawrence on
#webkit).
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):
- 2:38 PM Changeset in webkit [64683] by
-
- 2 edits in trunk/WebCore
Build fix.
- platform/text/mac/HyphenationMac.mm:
(WebCore::lastHyphenLocation):
- 2:34 PM Changeset in webkit [64682] by
-
- 2 edits in trunk/WebCore
Release build fix.
- platform/text/mac/HyphenationMac.mm:
(WebCore::lastHyphenLocation):
- 2:32 PM Changeset in webkit [64681] by
-
- 2 edits in trunk/WebCore
Don't leak FontDescription objects inside MathML.
Reviewed by Sam Weinig.
- mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement): Don't unnecessarily allocate the FontDescription on the heap.
(WebCore::RenderMathMLOperator::createStackableStyle): Ditto.
- 2:28 PM Changeset in webkit [64680] by
-
- 2 edits in trunk/WebCore
2010-08-04 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add ANGLE dependency for Chromium WebCore build
https://bugs.webkit.org/show_bug.cgi?id=43508
No new tests. Built modified version of patch from bug 42405 in
Chromium to test.
- WebCore.gyp/WebCore.gyp:
- 2:26 PM Changeset in webkit [64679] by
-
- 3 edits in trunk/WebKit/qt
2010-08-04 Pierre Rossi <pierre.rossi@nokia.com>
Reviewed by Antonio Gomes.
[Qt] QWebFrame::setContent() does not respect charset provided in the mimeType
https://bugs.webkit.org/show_bug.cgi?id=43125
- Api/qwebframe.cpp: (QWebFrame::setContent):
- tests/qwebframe/tst_qwebframe.cpp:
- 2:24 PM Changeset in webkit [64678] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- win/WebKit2Generated.make:
- 2:22 PM Changeset in webkit [64677] by
-
- 22 edits5 adds in trunk
WebCore: Allow the language for hyphenation to be specified
https://bugs.webkit.org/show_bug.cgi?id=43467
Test: fast/text/hyphenate-locale.html
Added a -webkit-hyphenate-locale property whose value can be either auto or a locale identifier
string. The initial value is auto and the property is inherited. When the value is a locale
identifier, hyphenation should follow the rules for the specified locale.
- WebCore.xcodeproj/project.pbxproj: Added AtomicStringKeyedMRUCache.h.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle -webkit-hyphenate-locale.
Updated for the renaming of RenderStyle::hyphenateCharacter() to hyphenationString().
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue): Parse -webkit-hyphenate-locale.
- css/CSSPropertyNames.in: Added -webkit-hyphenate-locale.
- css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Apply the -webkit-hyphenate-locale property to the
RenderStyle. Updated for the renaming of RenderStyle::hyphenateCharacter() to hyphenationString().
- platform/text/AtomicStringKeyedMRUCache.h: Added.
(WebCore::AtomicStringKeyedMRUCache::get):
- platform/text/Hyphenation.cpp:
(WebCore::canHyphenate): Added an implementation that returns false.
(WebCore::lastHyphenLocation): Now asserts that it is not called, because it is an error to call
this function if canHyphenate() returned false.
- platform/text/Hyphenation.h:
Added canHyphenate(). Returns true if hyphenation is possible for the given locale identifier.
- platform/text/android/HyphenationAndroid.cpp:
(WebCore::canHyphenate): Added an implementation that returns true and a FIXME.
(WebCore::lastHyphenLocation): Added unused localeIdentifier parameter.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef> >::createValueForNullKey): Returns
the CFLocaleRef for the current search locale.
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef> >::createValueForKey): Returns a
CFLocaleRef for the locale identifier.
(WebCore::canHyphenate): Added. Returns true.
(WebCore::lastHyphenLocation): Added localeIdentifier parameter, used to pass a CFLocaleRef to
the hyphenation function.
- platform/text/mac/HyphenationMac.mm:
(WebCore::AtomicStringKeyedMRUCache<bool>::createValueForNullKey): Returns whether the current
search locale is english.
(WebCore::AtomicStringKeyedMRUCache<bool>::createValueForKey): Returns whether the locale identifier
string identifies locale with the English language.
(WebCore::canHyphenate): Added. Returns true if the locale language is English.
(WebCore::lastHyphenLocation): Added localeIdentifier parameter and an assertion that its language
is English.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::tryHyphenating): Added a locale identifier parameter, which is passed down to
lastHyphenLocation(). Added 1 to the value passed for the beforeIndex parameter to lastHyphenLocation(),
because the latter only returns values smaller than that index. The Mac implementation could
return a value equal to beforeIndex, but that is fixed in the WebKitSystemInterface part of this patch.
(WebCore::RenderBlock::findNextLineBreak): Only set canHyphenate to true if hyphenation is possible
for the specified hyphenation locale. Pass the hyphenation locale to tryHyphenating().
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff): Compare hyphenation locales.
(WebCore::RenderStyle::hyphenString): Updated for the renaming of hyphenateCharacter() to
hyphenationString().
- rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::hyphenationString): Renamed hyphenateCharacter() to this.
(WebCore::InheritedFlags::hyphenationLocale): Added this accessor.
(WebCore::InheritedFlags::setHyphenationString): Renamed setHyphenateCharacter() to this.
(WebCore::InheritedFlags::setHyphenationLocale): Added this accessor.
(WebCore::InheritedFlags::initialHyphenationString): Renamed initialHyphenateCharacter() to this.
(WebCore::InheritedFlags::initialHyphenateLocale): Added. Returns the null atom, which represents a
value of auto.
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData): Copy the hyphenation locale. Updated for
rename.
(WebCore::StyleRareInheritedData::operator==): Compare the hyphenation locales. Updated for rename.
- rendering/style/StyleRareInheritedData.h:
WebKitLibraries: WebKitSystemInterface part of: Allow the language for hyphenation to be specified
https://bugs.webkit.org/show_bug.cgi?id=43467
Reviewed by Darin Adler.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceSnowLeopard.a:
- libWebKitSystemInterfaceTiger.a:
LayoutTests: Allow the language for hyphenation to be specified
https://bugs.webkit.org/show_bug.cgi?id=43467
Reviewed by Simon Fraser.
- fast/text/hyphenate-locale.html: Added.
- platform/mac/fast/text/hyphenate-locale-expected.checksum: Added.
- platform/mac/fast/text/hyphenate-locale-expected.png: Added.
- platform/mac/fast/text/hyphenate-locale-expected.txt: Added.
- 2:02 PM Changeset in webkit [64676] by
-
- 2 edits in trunk/LayoutTests
2010-08-04 Dimitri Glazkov <Dimitri Glazkov>
Updating Windows DRT expectations after DRT's successful run.
- platform/chromium/drt_expectations.txt: Added failure expectations.
- 2:00 PM Changeset in webkit [64675] by
-
- 2 edits in trunk/WebKit2
Build fix, rubber-stamped by Brady Eidson.
- WebKit2.xcodeproj/project.pbxproj:
Made WKData.h a public header.
- 1:39 PM Changeset in webkit [64674] by
-
- 6 edits25 adds in trunk
2010-08-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
LayoutTests for <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
- fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-double-defer-write.html: Added. Tests for tricky ordering and reentrancy by doing a double write of defered scripts.
- fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Copied from LayoutTests/fast/tokenizer/write-before-load-expected.txt.
- fast/dom/HTMLScriptElement/defer-double-write.html: Added. Tests for tricky ordering and reentrancy by doing a double write of inline scripts.
- fast/dom/HTMLScriptElement/defer-inline-script-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-inline-script.html: Added. Tests that the defer attribute is ignored on inline script blocks.
- fast/dom/HTMLScriptElement/defer-onbeforeload-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-onbeforeload.html: Added. Tests that onbeforeload fires immediately when a deferred script is encounted. Also tests that it can be cancelled.
- fast/dom/HTMLScriptElement/defer-script-invalid-url-expected.txt: Added.
- fast/dom/HTMLScriptElement/defer-script-invalid-url.html: Added. Tests that invalid URLs are ignored and subsequent scripts are still executed.
- fast/dom/HTMLScriptElement/resources/defer.js: Added.
- fast/dom/HTMLScriptElement/resources/external.js: Added.
- fast/dom/HTMLScriptElement/resources/shouldnotexecute.js: Added.
- http/tests/misc/resources/defer-script.js: Added.
- http/tests/misc/resources/external-script.js: Added.
- http/tests/misc/resources/script-debug-body-background.js: Added.
- http/tests/misc/resources/script-write-slow-stylesheet.js: Added.
- http/tests/misc/resources/slow-defer-script.cgi: Added.
- http/tests/misc/resources/slow-stylesheet.cgi: Added.
- http/tests/misc/script-defer-after-slow-stylesheet-expected.txt: Added.
- http/tests/misc/script-defer-after-slow-stylesheet.html: Added. Tests stylesheet blocking behavior.
- http/tests/misc/script-defer-expected.txt: Added.
- http/tests/misc/script-defer-write-slow-stylesheet-expected.txt: Added.
- http/tests/misc/script-defer-write-slow-stylesheet.html: Added. Tests stylesheet blocking behavior with a slow stylesheet.
- http/tests/misc/script-defer.html: Added. Tests basic functionality and ordering.
2010-08-04 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Eric Seidel.
Support <script defer> as specified by HTML5
https://bugs.webkit.org/show_bug.cgi?id=40934
Tests: fast/dom/HTMLScriptElement/defer-double-defer-write.html
fast/dom/HTMLScriptElement/defer-double-write.html
fast/dom/HTMLScriptElement/defer-inline-script.html
fast/dom/HTMLScriptElement/defer-onbeforeload.html
fast/dom/HTMLScriptElement/defer-script-invalid-url.html
http/tests/misc/script-defer-after-slow-stylesheet.html
http/tests/misc/script-defer-write-slow-stylesheet.html
http/tests/misc/script-defer.html
- html/HTMLDocumentParser.cpp: (WebCore::HTMLDocumentParser::attemptToEnd): (WebCore::HTMLDocumentParser::endIfDelayed): (WebCore::HTMLDocumentParser::executeScriptsWaitingForParsingAndEnd):
- html/HTMLDocumentParser.h:
- html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::executeScriptsWaitingForParsing): (WebCore::HTMLScriptRunner::requestScript): (WebCore::HTMLScriptRunner::requestParsingBlockingScript): (WebCore::HTMLScriptRunner::requestDeferredScript): (WebCore::HTMLScriptRunner::runScript):
- html/HTMLScriptRunner.h: (WebCore::HTMLScriptRunner::PendingScript::PendingScript): (WebCore::HTMLScriptRunner::PendingScript::operator=):
- 1:31 PM Changeset in webkit [64673] by
-
- 4 edits in trunk/WebKitTools
2010-08-04 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Simon Hausmann and Kenneth Christiansen.
[Qt] [QtTestBrowser] Clean up static and global menu state controls
https://bugs.webkit.org/show_bug.cgi?id=43448
After LauncherWindow class was refactored out of from main.cpp, all global variables that
were hanging in main.cpp became temporarily public static class members of newly added
LauncherWindow class. This design was not properly handling the initial purpose of the
global variables: newly created launcher windows should inherit the settings of the originating
one.
In order to properly fix the problem, this patch introduces a WindowOptions class, as a POD. It
comprises all data needed to handling the goal described above.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::LauncherWindow): The class now receives an optional WindowOptions pointer object
holding all user settings configured in the menus and command line.
It also receices an optional QGraphicsScene points in case we are doing
a "Clone Window".
(LauncherWindow::init): Removed the usesGraphics parameter because the class member m_userData holds its
value.
(LauncherWindow::initializeView): Ditto.
(LauncherWindow::createChrome): Changed all references to gXXX to m_userData.XXX
(LauncherWindow::applyPrefs): Removed the "LauncherWindow* source" parameter. All data needed to properly
apply the preferences is provided by m_userData.
(LauncherWindow::toggleAcceleratedCompositing): Change gXXX by m_userData.XXX
(LauncherWindow::toggleResizesToContents): Ditto.
(LauncherWindow::toggleWebGL): Ditto.
(LauncherWindow::toggleFrameFlattening): Ditto.
(LauncherWindow::toggleQGLWidgetViewport): Ditto.
(LauncherWindow::changeViewportUpdateMode): Ditto.
(LauncherWindow::showFPS): Ditto.
(LauncherWindow::newWindow): Changed to pass the userData.
(LauncherWindow::cloneWindow): Ditto.
- QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
- QtTestBrowser/main.cpp: (requiresGraphicsView): (LauncherApplication::handleUserOptions): (main):
- 1:26 PM Changeset in webkit [64672] by
-
- 7 edits in trunk
[wx] Build fix for gcc not importing all symbols from convenience libraries.
Works on 10.6 only for Mac until the build system is reworked.
- 1:18 PM Changeset in webkit [64671] by
-
- 2 edits in trunk/WebKitTools
2010-08-04 Markus Goetz <Markus.Goetz@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Change wording in QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=43241
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::createChrome):
- 1:17 PM Changeset in webkit [64670] by
-
- 2 edits in trunk/WebCore
[wx] Build fix. Enclose PlatformStrategy methods in USE(PLATFORM_STRATEGIES).
- 12:57 PM Changeset in webkit [64669] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_SetValue): Removed unreachable code.
- 12:56 PM Changeset in webkit [64668] by
-
- 5 edits4 adds in trunk
2010-08-04 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Regression test: overflow: auto; on a math element was a cause of crash.
https://bugs.webkit.org/show_bug.cgi?id=42894
- mathml/presentation/style.xhtml: Added.
- platform/mac/mathml/presentation/style-expected.checksum: Added.
- platform/mac/mathml/presentation/style-expected.png: Added.
- platform/mac/mathml/presentation/style-expected.txt: Added.
2010-08-04 François Sausset <François Sausset>
Reviewed by Kenneth Rohde Christiansen.
Remove unnecessary calls to setStyle() in MathML code that made RenderLayer crash.
https://bugs.webkit.org/show_bug.cgi?id=42894
Test: mathml/presentation/style.xhtml
- mathml/MathMLInlineContainerElement.cpp: (WebCore::MathMLInlineContainerElement::createRenderer):
- mathml/MathMLMathElement.cpp: (WebCore::MathMLMathElement::createRenderer):
- mathml/MathMLTextElement.cpp: (WebCore::MathMLTextElement::createRenderer):
- 12:49 PM Changeset in webkit [64667] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_SetValue): Added some case statements that are compiled
on Windows to avoid a warning about having default but not cases.
- 12:36 PM Changeset in webkit [64666] by
-
- 2 edits in trunk/WebKit2
Windows build fix
- win/WebKit2.vcproj: Added NetscapeBrowserFuncs.
- 12:31 PM Changeset in webkit [64665] by
-
- 9 edits in trunk/ANGLE
2010-08-04 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Update ANGLE to r352
https://bugs.webkit.org/show_bug.cgi?id=43500
Updated ANGLE to r352 (July 26, 2010). Built WebKit to test.
- include/GLSLANG/ShaderLang.h:
- src/compiler/Initialize.cpp: (BuiltInFunctionsCommon): (BuiltInFunctionsVertex): (BuiltInFunctionsFragment): (StandardUniforms): (DefaultPrecisionVertex): (DefaultPrecisionFragment): (BuiltInConstants): (TBuiltIns::initialize): (IdentifyBuiltIns):
- src/compiler/Initialize.h: (TBuiltIns::getBuiltInStrings):
- src/compiler/OutputGLSL.cpp: (TOutputGLSL::visitSelection):
- src/compiler/ShHandle.h: (TCompiler::getLanguage): (TCompiler::getSpec): (TCompiler::getSymbolTable): (TCompiler::getInfoSink):
- src/compiler/ShaderLang.cpp: (InitializeSymbolTable): (GenerateBuiltInSymbolTable): (ShInitialize): (ShConstructCompiler): (ShFinalize): (ShCompile):
- src/compiler/SymbolTable.h: (TSymbolTable::atBuiltInLevel): (TSymbolTable::atGlobalLevel): (TSymbolTable::push): (TSymbolTable::getGlobalLevel): (TSymbolTable::currentLevel):
- src/libGLESv2/Shader.cpp: (gl::Shader::Shader): (gl::Shader::compileToHLSL):
- 12:29 PM Changeset in webkit [64664] by
-
- 2 edits1 delete in trunk/WebKit2
Windows build fix
The functions in NetscapePluginModuleWin.cpp have been moved to
NetscapePluginModule.cpp.
- WebProcess/Plugins/Netscape/win/NetscapePluginModuleWin.cpp: Removed.
- win/WebKit2.vcproj: Removed NetscapePluginModuleWin.
- 12:09 PM Changeset in webkit [64663] by
-
- 5 edits3 copies1 move1 add in trunk/WebKit2
Move bundle-loading code from NetscapePluginModule to a new Module class
This allows more NetscapePluginModule code to be cross-platform.
Fixes <http://webkit.org/b/43497> NetscapePluginModule::try/unload
should be cross-platform
Reviewed by Anders Carlsson.
- Platform/Module.cpp: Added.
(WebKit::Module::Module): Store our path.
(WebKit::Module::~Module): Unload our native module.
- Platform/Module.h: Added.
(WebKit::Module::leakBundle): Does what it says.
(WebKit::Module::functionPointer): Returns a pointer to the named
function, with the right type.
- Platform/mac/ModuleMac.mm: Added.
(WebKit::Module::load): Code was moved here from
NetscapePluginModule::tryLoad.
(WebKit::Module::unload): Just clears our bundle.
(WebKit::Module::platformFunctionPointer): Code was moved here from
NetscapePluginModuleMac.cpp.
- Platform/qt/ModuleQt.cpp: Added.
(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):
- Platform/win/ModuleWin.cpp: Added.
(WebKit::Module::load):
(WebKit::Module::unload):
(WebKit::Module::platformFunctionPointer):
Just stubbed out these functions.
- WebKit2.xcodeproj/project.pbxproj: Added Module.
- WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
(WebKit::NetscapePluginModule::tryLoad):
(WebKit::NetscapePluginModule::unload):
Moved here from NetscapePluginModuleMac.cpp. Now uses the
cross-platform m_module member.
- WebProcess/Plugins/Netscape/NetscapePluginModule.h: Replaced
m_bundle with m_module.
- WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp: Removed.
- win/WebKit2.vcproj: Added Module.
- 11:55 AM Changeset in webkit [64662] by
-
- 10 edits3 adds in trunk/WebKit2
2010-08-04 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Lay the groundwork for saving/restoring page session state to WK2
https://bugs.webkit.org/show_bug.cgi?id=43495
- WebKit2.xcodeproj/project.pbxproj:
- win/WebKit2.vcproj:
- Shared/APIObject.h: (WebKit::APIObject::):
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKBase.h:
Arbitrary byte buffer:
- Shared/WebData.h: Added. (WebKit::WebData::create): (WebKit::WebData::bytes): (WebKit::WebData::size): (WebKit::WebData::WebData): (WebKit::WebData::type):
API facing object to act as a byte buffer:
- UIProcess/API/C/WKData.cpp: Added. (WKDataGetTypeID): (WKDataCreate): (WKDataGetBytes): (WKDataGetSize): (WKDataRetain): (WKDataRelease):
- UIProcess/API/C/WKData.h: Added.
API for saving/restoring state:
- UIProcess/API/C/WKPage.cpp: (WKPageCopySessionState): (WKPageRestoreFromSessionState):
- UIProcess/API/C/WKPage.h:
These will be filled in later:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::sessionState): (WebKit::WebPageProxy::restoreFromSessionState):
- UIProcess/WebPageProxy.h:
- 11:44 AM Changeset in webkit [64661] by
-
- 2 edits in trunk/WebKit2
Set correct default minimumFontSize.
Reviewed by Anders Carlsson.
- Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
- 11:39 AM Changeset in webkit [64660] by
-
- 2 edits in trunk/WebCore
2010-08-03 Kenneth Russell <kbr@google.com>
Reviewed by Nate Chapin.
Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API
https://bugs.webkit.org/show_bug.cgi?id=43221
Added a helper function to extract the contents of WebGL objects
to reduce duplicated code and fix a couple of potential crashes
introduced in the previous refactoring.
No new tests; ran existing WebGL tests.
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::handleNPOTTextures): (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation):
- 11:29 AM Changeset in webkit [64659] by
-
- 4 edits1 add in trunk
2010-08-04 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Jeremy Orlow.
[Gtk] Make sure DRT return the right AXTitle for controls
https://bugs.webkit.org/show_bug.cgi?id=39997
Added expected results file to the GTK port and removed the new
test from the Skipped file.
- platform/gtk/Skipped:
- platform/gtk/accessibility/aria-checkbox-text-expected.txt: Copied from LayoutTests/platform/mac/accessibility/aria-checkbox-text-expected.txt.
2010-08-04 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Jeremy Orlow.
[Gtk] Make sure DRT return the right AXTitle for controls
https://bugs.webkit.org/show_bug.cgi?id=39997
Fallback to the text under the given element as its name in case
it's a control element and has no associated label for it.
- accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: (webkit_accessible_get_name):
- 11:14 AM Changeset in webkit [64658] by
-
- 2 edits in trunk/JavaScriptCore
Enable JSVALUE64 for CPU(PPC64).
Basic browsing seems to work.
Rubber stamped by Sam Weinig.
- wtf/Platform.h:
- 11:08 AM Changeset in webkit [64657] by
-
- 2 edits in trunk
2010-08-04 Siddharth Mathur <siddharth.mathur@nokia.com>
Reviewed by Laszlo Gombos.
[Qt][Symbian] Variable max heap size between target/emulator
https://bugs.webkit.org/show_bug.cgi?id=41480
- WebKit.pri: Symbian-only code block for EPOCHEAPSIZE configuration
- 10:48 AM Changeset in webkit [64656] by
-
- 9 edits in trunk
2010-08-02 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Port Chromium's accelerated compositing to Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=43398
- public/WebGLES2Context.h:
- Added resizeOnscreenContent, needed on Mac OS X to report window size changes.
- src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
- Send resize notification to the WebGLES2Context.
(WebKit::WebViewImpl::updateRootLayerContents):
- Ported to Core Graphics.
(WebKit::WebViewImpl::gles2Context):
- Added initial size notification upon context creation.
2010-08-02 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Port Chromium's accelerated compositing to Mac OS X
https://bugs.webkit.org/show_bug.cgi?id=43398
No new tests. Tested manually with CSS 3D and WebGL tests.
- platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::clearBorderColor):
(WebCore::clearLayerBackgroundColor):
- Fixed compilation problems with gcc.
- platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::updateTextureContents):
- Added Core Graphics port.
- platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
- Fixed compilation problems with gcc related to initialization order of members.
(WebCore::LayerChromium::updateTextureContents):
(WebCore::LayerChromium::updateTextureRect):
- Ported to Core Graphics, adjusting for lower-left coordinate system origin.
- platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
- Fixed compilation problems with gcc related to initialization order of members.
(WebCore::LayerRendererChromium::setRootLayerCanvasSize):
- Ported to Core Graphics.
(WebCore::LayerRendererChromium::drawLayers):
- Added more debug-only error calls during drawing phase. Adjusted scrolling and incremental updating code for Core Graphics' lower-left coordinate system origin.
(WebCore::LayerRendererChromium::initializeSharedGLObjects):
- Removed color channel swizzling in Core Graphics port. Fixed preexisting bug in initialization check of m_rootLayerTextureId.
- platform/graphics/chromium/LayerRendererChromium.h:
- Added needed data members for Core Graphics port.
- 10:18 AM Changeset in webkit [64655] by
-
- 15 edits in trunk
2010-08-04 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Darin Adler.
Refactoring MarkStack::append to take a reference. This is in
preparation for movable objects when we will need to update pointers.
http://bugs.webkit.org/show_bug.cgi?id=41177
Unless otherwise noted, all changes are to either return by reference
or pass a reference to MarkStack::append.
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::markAggregate):
- runtime/Collector.cpp: (JSC::Heap::markConservatively):
Added a temporary variable to prevent marking from changing an
unknown value on the stack
- runtime/JSCell.h: (JSC::JSValue::asCell): (JSC::MarkStack::append): (JSC::MarkStack::appendInternal):
- runtime/JSGlobalObject.cpp: (JSC::markIfNeeded):
- runtime/JSONObject.cpp: (JSC::Stringifier::Holder::object):
- runtime/JSObject.h: (JSC::JSObject::prototype):
- runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::markChildren):
- runtime/JSValue.h: (JSC::JSValue::JSValue): (JSC::JSValue::asCell):
- runtime/MarkStack.h:
- runtime/NativeErrorConstructor.cpp: (JSC::NativeErrorConstructor::createStructure):
Changed the structure flags to include a custom markChildren.
(JSC::NativeErrorConstructor::markChildren):
Update the prototype of the stored structure.
- runtime/NativeErrorConstructor.h:
Added structure flags.
- runtime/Structure.h: (JSC::Structure::storedPrototype):
2010-08-04 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Darin Adler.
Removed unneeded marking. We need to remove this marking in order to have
MarkStack::append take references for updating movable objects.
- JSValueWrapper.cpp: (JSValueWrapper::JSObjectMark):
- 10:12 AM Changeset in webkit [64654] by
-
- 2 edits in trunk/WebKitTools
2010-08-04 Aaron Boodman <aa@chromium.org>
Reviewed by Eric Seidel.
prepare-ChangeLog fails mysteriously if curl doesn't support ssl
https://bugs.webkit.org/show_bug.cgi?id=43460
- Scripts/prepare-ChangeLog:
- 8:26 AM Changeset in webkit [64653] by
-
- 12 edits in trunk/WebCore
2010-08-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use InspectorValue to push dispatch results from the injected script
https://bugs.webkit.org/show_bug.cgi?id=43483
- bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::reportDidDispatchOnInjectedScript):
- bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::reportDidDispatchOnInjectedScriptCallback):
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::dispatch):
- inspector/InjectedScript.h:
- inspector/InjectedScriptHost.cpp: (WebCore::InjectedScriptHost::reportDidDispatchOnInjectedScript): (WebCore::InjectedScriptHost::remoteFrontend):
- inspector/InjectedScriptHost.h:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::dispatchOnInjectedScript):
- inspector/InspectorController.cpp: (WebCore::InspectorController::didContinue):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- 8:10 AM Changeset in webkit [64652] by
-
- 2 edits in trunk/LayoutTests
2010-08-04 Abhishek Arya <inferno@chromium.org>
Unreviewed. QT expectation fix.
- platform/qt/fast/notifications/notifications-document-close-crash-expected.txt:
- 7:45 AM Changeset in webkit [64651] by
-
- 4 edits2 adds in trunk
2010-08-04 Abhishek Arya <inferno@chromium.org>
Unreviewed. Put missing equivalent js bindings check.
Forgot putting js bindings check in http://trac.webkit.org/changeset/64647. This fixes the qt crash.
- bindings/js/JSDesktopNotificationsCustom.cpp: (WebCore::JSNotificationCenter::requestPermission):
2010-08-04 Abhishek Arya <inferno@chromium.org>
Unreviewed.
Add qt specific layout test results for my commit http://trac.webkit.org/changeset/64647.
Fix timeout in my layout test since it was generating too many events in qt.
- fast/notifications/notifications-document-close-crash.html:
- platform/qt/fast/notifications: Added.
- platform/qt/fast/notifications/notifications-document-close-crash-expected.txt: Added.
- 7:43 AM Changeset in webkit [64650] by
-
- 10 edits in trunk/WebCore
2010-08-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: serialize database resources to InspectorValues
https://bugs.webkit.org/show_bug.cgi?id=43482
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::getDatabaseTableNames):
- inspector/InspectorController.cpp: (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::selectDatabase): (WebCore::InspectorController::didOpenDatabase):
- inspector/InspectorController.h:
- inspector/InspectorDatabaseResource.cpp: (WebCore::InspectorDatabaseResource::create): (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::bind):
- inspector/InspectorDatabaseResource.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- storage/Database.cpp: (WebCore::Database::openDatabase):
- 7:19 AM Changeset in webkit [64649] by
-
- 4 edits in trunk/JavaScriptCore
2010-08-03 Nathan Lawrence <nlawrence@apple.com>
Reviewed by Oliver Hunt.
Tightened up some get_by_id_chain* code generation
https://bugs.webkit.org/show_bug.cgi?id=40935
This is in the style of
https://bugs.webkit.org/show_bug.cgi?id=30539, and changed code to
call accessor functions when it was not necessary to directly access
the private variables.
- jit/JIT.h:
- jit/JITPropertyAccess.cpp: (JSC::JIT::compileGetDirectOffset): (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp: (JSC::JIT::testPrototype): (JSC::JIT::privateCompilePutByIdTransition): (JSC::JIT::privateCompileGetByIdChainList): (JSC::JIT::privateCompileGetByIdChain):
- 6:56 AM Changeset in webkit [64648] by
-
- 2 edits in trunk/LayoutTests
2010-08-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium expectations update.
- platform/chromium/test_expectations.txt:
- 6:25 AM Changeset in webkit [64647] by
-
- 4 edits2 adds in trunk
2010-08-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Null the script execution context when disconnecting frame in notifications.
Make sure that script execution context is valid in notification requestPermission.
https://bugs.webkit.org/show_bug.cgi?id=43295
Tests: fast/notifications/notifications-document-close-crash.html
- bindings/v8/custom/V8NotificationCenterCustom.cpp: (WebCore::V8NotificationCenter::requestPermissionCallback):
- notifications/NotificationCenter.cpp: (WebCore::NotificationCenter::disconnectFrame):
2010-08-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Alexey Proskuryakov.
Tests that requesting notification permission on a closed document does
not result in crash.
https://bugs.webkit.org/show_bug.cgi?id=43295
- fast/notifications/notifications-document-close-crash-expected.txt: Added.
- fast/notifications/notifications-document-close-crash.html: Added.
- 6:13 AM Changeset in webkit [64646] by
-
- 4 edits in trunk/WebKit/chromium
2010-08-04 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
DevTools: get rid of delayed command dispatching on front-end side.
- public/WebDevToolsAgent.h:
- src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::frontendLoaded):
- src/WebDevToolsAgentImpl.h:
- 6:00 AM Changeset in webkit [64645] by
-
- 10 edits2 adds2 deletes in trunk
Turn on PLATFORM_STRATEGIES on Windows
Fixes <http://webkit.org/b/43431>.
Reviewed by Anders Carlsson.
- wtf/Platform.h:
WebCore:
- WebCore.vcproj/WebCore.vcproj: Added LocalizedStrings.cpp,
PlatformStrategies.h, LocalizationStrategy.h, PluginStrategy.h, and
VisitedLinkStrategy.h. Removed PluginDataWin.cpp
- platform/LocalizedStrings.cpp: Wrapped Mac-only functions in
PLATFORM(MAC) guards.
(WebCore::uploadFileText):
(WebCore::allFilesText):
Added these Windows-only functions.
- plugins/win/PluginDataWin.cpp: Removed.
WebKit/win:
- WebCoreLocalizedStrings.cpp: Removed.
- WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac
equivalent.
(WebPlatformStrategies::initialize): Creates the singleton instance.
(WebPlatformStrategies::WebPlatformStrategies): Registers the
singleton instance as the PlatformStrategies instance for WebCore.
(WebPlatformStrategies::createPluginStrategy):
(WebPlatformStrategies::createLocalizationStrategy):
(WebPlatformStrategies::createVisitedLinkStrategy):
Return ourselves as the strategy.
(WebPlatformStrategies::refreshPlugins):
(WebPlatformStrategies::getPluginInfo):
Moved code here from WebCore's PluginDataWin.cpp file.
(WebPlatformStrategies::searchableIndexIntroduction):
(WebPlatformStrategies::submitButtonDefaultLabel):
(WebPlatformStrategies::inputElementAltText):
(WebPlatformStrategies::resetButtonDefaultLabel):
(WebPlatformStrategies::fileButtonChooseFileLabel):
(WebPlatformStrategies::fileButtonNoFileSelectedLabel):
(WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopy):
(WebPlatformStrategies::contextMenuItemTagGoBack):
(WebPlatformStrategies::contextMenuItemTagGoForward):
(WebPlatformStrategies::contextMenuItemTagStop):
(WebPlatformStrategies::contextMenuItemTagReload):
(WebPlatformStrategies::contextMenuItemTagCut):
(WebPlatformStrategies::contextMenuItemTagPaste):
(WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
(WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
(WebPlatformStrategies::contextMenuItemTagLearnSpelling):
(WebPlatformStrategies::contextMenuItemTagSearchWeb):
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
(WebPlatformStrategies::contextMenuItemTagOpenLink):
(WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
(WebPlatformStrategies::contextMenuItemTagSpellingMenu):
(WebPlatformStrategies::contextMenuItemTagCheckSpelling):
(WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
(WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
(WebPlatformStrategies::contextMenuItemTagFontMenu):
(WebPlatformStrategies::contextMenuItemTagBold):
(WebPlatformStrategies::contextMenuItemTagItalic):
(WebPlatformStrategies::contextMenuItemTagUnderline):
(WebPlatformStrategies::contextMenuItemTagOutline):
(WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagDefaultDirection):
(WebPlatformStrategies::contextMenuItemTagLeftToRight):
(WebPlatformStrategies::contextMenuItemTagRightToLeft):
(WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
(WebPlatformStrategies::contextMenuItemTagInspectElement):
(WebPlatformStrategies::searchMenuNoRecentSearchesText):
(WebPlatformStrategies::searchMenuRecentSearchesText):
(WebPlatformStrategies::searchMenuClearRecentSearchesText):
(WebPlatformStrategies::AXWebAreaText):
(WebPlatformStrategies::AXLinkText):
(WebPlatformStrategies::AXListMarkerText):
(WebPlatformStrategies::AXImageMapText):
(WebPlatformStrategies::AXHeadingText):
(WebPlatformStrategies::AXDefinitionListTermText):
(WebPlatformStrategies::AXDefinitionListDefinitionText):
(WebPlatformStrategies::AXButtonActionVerb):
(WebPlatformStrategies::AXRadioButtonActionVerb):
(WebPlatformStrategies::AXTextFieldActionVerb):
(WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXLinkActionVerb):
(WebPlatformStrategies::AXMenuListActionVerb):
(WebPlatformStrategies::AXMenuListPopupActionVerb):
(WebPlatformStrategies::unknownFileSizeText):
(WebPlatformStrategies::uploadFileText):
(WebPlatformStrategies::allFilesText):
(WebPlatformStrategies::missingPluginText):
(WebPlatformStrategies::crashedPluginText):
(WebPlatformStrategies::imageTitle):
(WebPlatformStrategies::multipleFileUploadText):
(WebPlatformStrategies::mediaElementLoadingStateText):
(WebPlatformStrategies::mediaElementLiveBroadcastStateText):
(WebPlatformStrategies::localizedMediaControlElementString):
(WebPlatformStrategies::localizedMediaControlElementHelpText):
(WebPlatformStrategies::localizedMediaTimeDescription):
(WebPlatformStrategies::validationMessageValueMissingText):
(WebPlatformStrategies::validationMessageTypeMismatchText):
(WebPlatformStrategies::validationMessagePatternMismatchText):
(WebPlatformStrategies::validationMessageTooLongText):
(WebPlatformStrategies::validationMessageRangeUnderflowText):
(WebPlatformStrategies::validationMessageRangeOverflowText):
(WebPlatformStrategies::validationMessageStepMismatchText):
Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
it up).
(WebPlatformStrategies::isLinkVisited):
(WebPlatformStrategies::addVisitedLink):
Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.
- WebCoreSupport/WebPlatformStrategies.h: Added.
- WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added
WebPlatformStrategies.
- WebView.cpp:
(WebView::initWithFrame): Initialize WebPlatformStrategies.
WebKit2:
- win/WebKit2.vcproj: Added WebPlatformStrategies. Also let VS reorder
this file as it saw fit.
- 5:41 AM Changeset in webkit [64644] by
-
- 2 edits in trunk/LayoutTests
2010-08-04 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 5:38 AM Changeset in webkit [64643] by
-
- 3 edits2 adds in trunk
2010-08-03 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[DRT] Assertion failed when drag and move a draggable element.
https://bugs.webkit.org/show_bug.cgi?id=41695
- fast/events/dragging-mouse-moves-expected.txt: Added.
- fast/events/dragging-mouse-moves.html: Added.
2010-08-03 MORITA Hajime <morrita@google.com>
Reviewed by Tony Chang.
[DRT] Assertion failed when drag and move a draggable element.
https://bugs.webkit.org/show_bug.cgi?id=41695
mouseMoveToX() did call [WebHTMLView mouseDragged] even if dragging started.
But Cocoa doesn't call mouseDragged() until dragging is done.
Other part of DumpRenderTree also assumes Cocoa behavior and an assertion
on UIDelegate failed when mouseDragged() is called during dragging.
This change eliminated the mouseDragged() call when dragging begins,
which is implicated by draggingInfo instance.
- DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController mouseMoveToX:Y:]):
Test: fast/events/dragging-mouse-moves.html
- 5:36 AM QtWebKit edited by
- (diff)
- 5:22 AM Changeset in webkit [64642] by
-
- 17 edits1 add in trunk/WebCore
2010-08-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: serialize CPU profiles to InspectorValues instead of
using JS wrappers.
https://bugs.webkit.org/show_bug.cgi?id=43475
- Android.jscbindings.mk:
- CMakeLists.txt:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptProfile.h:
- bindings/js/ScriptProfiler.cpp: (WebCore::ScriptProfiler::stop):
- bindings/scripts/CodeGeneratorJS.pm:
- bindings/v8/ScriptProfile.cpp: (WebCore::buildInspectorObjectFor): (WebCore::ScriptProfile::buildInspectorObjectForHead):
- bindings/v8/ScriptProfile.h:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::addProfile): (WebCore::InspectorController::addProfileFinishedMessageToConsole): (WebCore::InspectorController::getProfileHeaders): (WebCore::InspectorController::getProfile): (WebCore::InspectorController::createProfileHeader):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- 4:42 AM Changeset in webkit [64641] by
-
- 2 edits in trunk/WebCore
2010-08-04 Andreas Kling <andreas.kling@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Use a QImage for the stroke applier scratch context
This avoids leaking a server-side resource on some graphics systems.
- platform/graphics/qt/PathQt.cpp: (WebCore::scratchContext):
- 4:39 AM Changeset in webkit [64640] by
-
- 2 edits in trunk/LayoutTests
Unreviewed build fix.
Add new Geolocation delayed permission tests to Qt skipped list
https://bugs.webkit.org/show_bug.cgi?id=43478
- platform/qt/Skipped:
- 4:13 AM Changeset in webkit [64639] by
-
- 12 edits6 adds in trunk
Adds Geolocation LayoutTests for the case where permission is not granted or denied immediately
https://bugs.webkit.org/show_bug.cgi?id=40002
Reviewed by Alexey Proskuryakov.
WebKitTools:
The code in LayoutTestController::setGeolocationPermission() was moved to
setGeolocationPermissionCommon() to allow each port to provide its own
implementation of setGeolocationPermission().
For the Mac port, setGeolocationPermission() notifies the UIDelegate of the
new permission, so it can call back to WebCore if permission requests are in
progress and are waiting for a response. A minor fix to the Mac
MockGeolocationProvider was also required to make sure that the mock provider
calls back to WebCore when it is first started.
For other ports, LayoutTestController::setGeolocationPermission() is not
implemented.
- DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::setGeolocationPermissionCommon):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setGeolocationPermission):
- DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setGeolocationPermission):
- DumpRenderTree/mac/MockGeolocationProvider.mm:
(-[MockGeolocationProvider registerWebView:]):
- DumpRenderTree/mac/UIDelegate.h:
- DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
(-[UIDelegate setGeolocationPermission:]):
(-[UIDelegate dealloc]):
- DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setGeolocationPermission):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setGeolocationPermission):
LayoutTests:
- fast/dom/Geolocation/delayed-permission-allowed-expected.txt: Added.
- fast/dom/Geolocation/delayed-permission-allowed.html: Added.
- fast/dom/Geolocation/delayed-permission-denied-expected.txt: Added.
- fast/dom/Geolocation/delayed-permission-denied.html: Added.
- fast/dom/Geolocation/script-tests/delayed-permission-allowed.js: Added.
- fast/dom/Geolocation/script-tests/delayed-permission-denied.js: Added.
- platform/gtk/Skipped: Added new tests to GTK skipped lists
- 2:30 AM Changeset in webkit [64638] by
-
- 2 edits in trunk/WebCore
HTML5 parser may cause onload not to fire
https://bugs.webkit.org/show_bug.cgi?id=43423
Reviewed by Darin Adler.
If a complex page causes the HTML parser to yield,
then when parsing continues again and eventually
finishes, we are missing a call to endIfDelayed(). This
results in onload never being called.
Not for lack of trying, but it seems almost
impossible to write a reliable test for this bug,
due to the highly timing-dependent nature of the
bug. The link above contains further discussion and
attempts at writing a test.
- html/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
Add a call to endIfDelayed() after pumping the tokenizer
post the parser yielding to ensure that the parsing step
is completed properly and the onload event fires.
- 1:57 AM Changeset in webkit [64637] by
-
- 2 edits in trunk/WebCore
2010-08-04 Dirk Schulze <krit@webkit.org>
Unreviewed sort of XCode project file.
- WebCore.xcodeproj/project.pbxproj:
- 1:16 AM Changeset in webkit [64636] by
-
- 2 edits in trunk
Build fix.
Fix the contents of the forwarding headers too.
- 1:06 AM Changeset in webkit [64635] by
-
- 2 moves in trunk
Build fix.
It's really useful if the forwarding headers match the name of the file that they're forwarding to.
Amazingly enough, if the name doesn't match then the file cannot be found! Who'd have thunk it?!
- 12:32 AM Changeset in webkit [64634] by
-
- 2 edits1 add in trunk/WebCore
2010-08-03 Darin Adler <Darin Adler>
Reviewed by Dan Bernstein.
System color changes are not applied properly
https://bugs.webkit.org/show_bug.cgi?id=43468
- manual-tests/system-color-change.html: Added.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::platformColorsDidChange): Added a call to Page::setNeedsReapplyStyles, so all frames of all pages will recompute in case they use system colors. It's rare for these colors to change, so OK to do a little extra style computation.
- 12:30 AM Changeset in webkit [64633] by
-
- 2 edits in trunk/WebCore
2010-08-04 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Revert changed license in SVGFEOffsetElement.h, thanks Gabor for noticing.
- svg/SVGFEOffsetElement.h:
- 12:12 AM Changeset in webkit [64632] by
-
- 2 edits in trunk/JavaScriptCore
Enable JSValue32_64 for GCC on ARM by default
https://bugs.webkit.org/show_bug.cgi?id=43410
Reviewed by Geoffrey Garen.
- wtf/Platform.h:
Aug 3, 2010:
- 11:52 PM Changeset in webkit [64631] by
-
- 7 edits in trunk
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42939
WebEditorClient::didBeginEditing is never called in WebKit2
- page/FocusController.cpp: (WebCore::FocusController::setFocused): Focusing a page without a focused frame makes little sense, so WebKit used to focus a frame first when its view became first responder. For viewless frames, WebKit cannot know what to focus. The assumption here is that in all cases with null m_focusedFrame, it's the main frame that needs to be focused.
- 10:57 PM Changeset in webkit [64630] by
-
- 1 edit in trunk/ChangeLog
2010-08-03 Eric Seidel <eric@webkit.org>
Unreviewed. Test commit for commit-queue@webkit.org.
- 10:09 PM Changeset in webkit [64629] by
-
- 2 edits in trunk/WebKit/gtk
2010-08-03 Daniel Bates <dbates@rim.com>
Fix misspelled word 'teh' in the description of the XSS Auditor setting.
- webkit/webkitwebsettings.cpp: (webkit_web_settings_class_init):
- 10:07 PM Changeset in webkit [64628] by
-
- 3 edits in trunk/WebKit2
2010-08-03 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Close the WebProcess
- Platform/CoreIPC/qt/ConnectionQt.cpp: (CoreIPC::Connection::open): Registered connectionDidClose to be called when the client disconnected.
- Platform/qt/RunLoopQt.cpp: (RunLoop::stop): Implemented by calling QCoreApplication::exit.
- 9:37 PM Changeset in webkit [64627] by
-
- 2 edits in trunk/JavaScriptCore
Speculative windows build fix.
- wtf/Bitmap.h:
- 9:25 PM Changeset in webkit [64626] by
-
- 5 edits2 adds in trunk
Build fix following r64624.
- JavaScriptCore.xcodeproj/project.pbxproj:
- wtf/PageAllocation.h:
JavaScriptGlue:
- ForwardingHeaders/wtf/BitMap.h: Added.
WebCore:
- ForwardingHeaders/wtf/BitMap.h: Added.
- 8:58 PM Changeset in webkit [64625] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations fixup for origin-quota.html.
- platform/chromium/test_expectations.txt:
- 8:27 PM Changeset in webkit [64624] by
-
- 10 edits2 adds1 delete in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=43269
Patch by Nathan Lawrence <nlawrence@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.
Added new allocateAligned methods to PageAllocation. In order to
prevent a regress in performance, the function needs to be inlined.
Additionally, I ported the symbian block allocator to use
PageAllocation and added a new WTF::Bitmap class to support this.
- GNUmakefile.am:
- JavaScriptCore.gypi:
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/AlignedMemoryAllocator.h: Added.
(JSC::AlignedMemory::deallocate):
(JSC::AlignedMemory::base):
(JSC::AlignedMemory::AlignedMemory):
(JSC::AlignedMemoryAllocator::destroy):
(JSC::AlignedMemoryAllocator::allocate):
(JSC::AlignedMemoryAllocator::AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::~AlignedMemoryAllocator):
(JSC::AlignedMemoryAllocator::free):
- runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::destroy):
(JSC::Heap::allocateBlock):
(JSC::Heap::freeBlock):
(JSC::Heap::freeBlocks):
(JSC::Heap::allocate):
(JSC::Heap::shrinkBlocks):
(JSC::Heap::markConservatively):
(JSC::Heap::clearMarkBits):
(JSC::Heap::markedCells):
- runtime/Collector.h:
(JSC::CollectorHeap::collectorBlock):
- runtime/CollectorHeapIterator.h:
(JSC::CollectorHeapIterator::operator*):
(JSC::LiveObjectIterator::operator++):
(JSC::DeadObjectIterator::operator++):
- wtf/Bitmap.h: Added.
(WTF::Bitmap::get):
(WTF::Bitmap::set):
(WTF::Bitmap::clear):
(WTF::Bitmap::clearAll):
(WTF::Bitmap::advanceToNextFreeBit):
(WTF::Bitmap::count):
(WTF::Bitmap::isEmpty):
(WTF::Bitmap::isFull):
- wtf/PageAllocation.h:
(WTF::PageAllocation::operator UnspecifiedBoolType):
(WTF::PageAllocation::allocateAligned):
(WTF::PageAllocation::reserveAligned):
- wtf/Platform.h:
- wtf/symbian: Removed.
- wtf/symbian/BlockAllocatorSymbian.cpp: Removed.
- wtf/symbian/BlockAllocatorSymbian.h: Removed.
- 8:16 PM Changeset in webkit [64623] by
-
- 2 edits in trunk/LayoutTests
Unreviewed chromium test expectations fixup to fix canary bot redness.
- platform/chromium/test_expectations.txt:
- 8:07 PM Changeset in webkit [64622] by
-
- 2 edits in trunk/LayoutTests
2010-08-03 Kent Tamura <tkent@chromium.org>
Rubber-stamped by Eric Seidel.
Add an explanation comment to drt_expectations.txt.
- platform/chromium/drt_expectations.txt:
- 8:06 PM Changeset in webkit [64621] by
-
- 3 edits in trunk/WebKit/qt
2010-08-03 Noam Rosenthal <noam.rosenthal@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Edits to bridge documentation
https://bugs.webkit.org/show_bug.cgi?id=43012
- docs/qtwebkit-bridge.qdoc:
- docs/webkitsnippets/qtwebkit_bridge_snippets.cpp: (wrapInFunction):
- 8:05 PM Changeset in webkit [64620] by
-
- 2 edits in trunk/JavaScriptCore
Fix for https://bugs.webkit.org/show_bug.cgi?id=43314. The prior code
was using the wrong "length" value to move array contents when adding
space to the beginning of an array for an unshift() or similar
operation. Instead of using m_vectorLength, the length of the
allocated JSValue array, the code was using m_length, the declared
length of the array. These two values do not need to match.
Patch by Michael Saboff <msaboff@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSArray.cpp:
(JSC::JSArray::increaseVectorPrefixLength):
- 7:54 PM Changeset in webkit [64619] by
-
- 2 edits in trunk/JavaScriptCore
Fix following https://bugs.webkit.org/show_bug.cgi?id=43089
(accidentally inverted a compiler version check).
Patch by Chao-ying Fu <fu@mips.com> on 2010-08-03
Reviewed by Gavin Barraclough.
- jit/ExecutableAllocator.h:
(JSC::ExecutableAllocator::cacheFlush):
- 7:32 PM Changeset in webkit [64618] by
-
- 2 edits in trunk/JavaScriptCore
2010-08-03 Patrick Gansterer <paroga@paroga.com>
Reviewed by Gavin Barraclough.
Implement DEFINE_STUB_FUNCTION for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=34953
- jit/JITStubs.cpp: (JSC::): (JSC::DEFINE_STUB_FUNCTION):
- 7:29 PM Changeset in webkit [64617] by
-
- 5 edits in trunk/LayoutTests
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Skipping tests for a new feature not implemented on some platforms.
Follow-up bugs have been filed and are listed below.
- platform/chromium/test_expectations.txt: https://bugs.webkit.org/show_bug.cgi?id=43459
- platform/gtk/Skipped: https://bugs.webkit.org/show_bug.cgi?id=43456
- platform/qt/Skipped: https://bugs.webkit.org/show_bug.cgi?id=43455
- platform/win/Skipped: https://bugs.webkit.org/show_bug.cgi?id=43458
- 7:07 PM Changeset in webkit [64616] by
-
- 3 edits3 adds in trunk
<input type=number> UI: Support wheel events
https://bugs.webkit.org/show_bug.cgi?id=42441
Reviewed by Ojan Vafai.
WebCore:
Test: fast/forms/input-number-wheel.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
Call stepUpFromRenderer() for wheelDeltaY.
LayoutTests:
- fast/forms/input-number-wheel-expected.txt: Added.
- fast/forms/input-number-wheel.html: Added.
- fast/forms/script-tests/input-number-wheel.js: Added.
- 6:53 PM Changeset in webkit [64615] by
-
- 6 edits in trunk/WebKitTools
2010-08-03 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Implement --testshell-startup-dialog
https://bugs.webkit.org/show_bug.cgi?id=40616
- DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Check --testshell-startup-dialog, and call openStartUpDialog() if it is specfied.
- DumpRenderTree/chromium/TestShell.h: Declare openStartUpDialog().
- DumpRenderTree/chromium/TestShellGtk.cpp: (openStartupDialog):
- DumpRenderTree/chromium/TestShellMac.mm: (openStartupDialog):
- DumpRenderTree/chromium/TestShellWin.cpp: (openStartupDialog):
- 6:51 PM Changeset in webkit [64614] by
-
- 2 edits in trunk/WebKitTools
2010-08-03 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Remove dependency of base/md5.h
https://bugs.webkit.org/show_bug.cgi?id=43403
- DumpRenderTree/chromium/TestShell.cpp: (TestShell::dumpImage): Use wtf/MD5.h
- 6:50 PM Changeset in webkit [64613] by
-
- 19 edits8 adds in trunk
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
LayoutTests:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 6 - LayoutTest and Cleanup
- http/tests/appcache/origin-quota-expected.txt: Added.
- http/tests/appcache/origin-quota.html: Added.
- http/tests/appcache/resources/quota-origin-iframe-1.html: Added.
- http/tests/appcache/resources/quota-origin-iframe-1.manifest: Added.
- http/tests/appcache/resources/quota-origin-iframe-2.html: Added.
- http/tests/appcache/resources/quota-origin-iframe-2.manifest: Added.
- http/tests/appcache/resources/quota-origin-iframe-3.html: Added.
- http/tests/appcache/resources/quota-origin-iframe-3.manifest: Added.
WebCore:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 6 - LayoutTest and Cleanup
Test: http/tests/appcache/origin-quota.html
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::scheduleReachedOriginQuotaCallback): made synchronous, as asynchronously the cache group was deleted too soon.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin): all storing operations should force the database to be created if needed.
WebKit/mac:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Part 6 - LayoutTest and Cleanup
- WebCoreSupport/WebApplicationCache.h:
- WebCoreSupport/WebApplicationCache.mm: (+[WebApplicationCache setMaximumSize:]): refactor out deleting the application caches. (+[WebApplicationCache deleteAllApplicationCaches]): delete application caches.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
WebKitTools:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Part 6 - LayoutTest and Cleanup
Allow tests to delete application caches and set application cache
origin quotas, so they can be tested.
- DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (dumpApplicationCacheDelegateCallbacksCallback): JavaScript callback, delegates to the controller. (clearAllApplicationCachesCallback): should delete all application caches. (setApplicationCacheOriginQuotaCallback): should set the origin quota for the localhost tests. (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h: (LayoutTestController::dumpApplicationCacheDelegateCallbacks): accessor to see if application cache callbacks should be output. (LayoutTestController::setDumpApplicationCacheDelegateCallbacks): enable or disable debug output when the application cache quota is reached.
Mac implementation.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::clearAllApplicationCaches): delete application caches. (LayoutTestController::setApplicationCacheOriginQuota): set the quota for localhost.
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): style fix. (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:]): reset the quota.
Stub implementations for other platforms.
- DumpRenderTree/chromium/LayoutTestController.cpp: (LayoutTestController::LayoutTestController): (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
- DumpRenderTree/chromium/LayoutTestController.h:
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
- DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
- DumpRenderTree/qt/LayoutTestControllerQt.h:
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
- DumpRenderTree/wx/LayoutTestControllerWx.cpp: (LayoutTestController::clearAllApplicationCaches): (LayoutTestController::setApplicationCacheOriginQuota):
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
- 6:50 PM Changeset in webkit [64612] by
-
- 9 edits4 moves1 add in trunk
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
WebKit:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
- WebKit.xcodeproj/project.pbxproj: Add new Quota Managers, remove old SecurityOrigin subclasses.
WebKit/mac:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
Per-Origin quotas exist for Databases and Application Caches. Clients
given a WebSecurityOrigin have the ability to set the quota for any
per-origin quota type. This puts quota management into an interface
and WebSecurityOrigin allows access to quota managers for the
different types of quotas.
This also deprecates the old methods on WebSecurityOrigin. They are
left in for now to prevent breaking older clients.
The WebQuotaManager interface allows querying and modifying a
per-origin quota. This is implemented for both Databases and
Application Caches.
- Misc/WebQuotaManager.h: Added. Interface for quota management (usage, quota, setQuota).
- Storage/WebDatabaseQuotaManager.h: Added.
- Storage/WebDatabaseQuotaManager.mm: Added. (-[WebDatabaseQuotaManager origin]): (-[WebDatabaseQuotaManager usage]): (-[WebDatabaseQuotaManager quota]): (-[WebDatabaseQuotaManager setQuota:]):
- Storage/WebDatabaseSecurityOrigin.h: Removed.
- Storage/WebDatabaseSecurityOrigin.mm: Removed.
- WebCoreSupport/WebApplicationCacheQuotaManager.h: Added.
- WebCoreSupport/WebApplicationCacheQuotaManager.mm: Added. (-[WebApplicationCacheQuotaManager origin]): (-[WebApplicationCacheQuotaManager usage]): (-[WebApplicationCacheQuotaManager quota]): (-[WebApplicationCacheQuotaManager setQuota:]):
- WebCoreSupport/WebSecurityOriginPrivate.h: Added a category to access managers. Deprecated old methods.
Remove the WebSecurityOrigin sub-classes. Managers are better.
- WebCoreSupport/WebApplicationCacheSecurityOrigin.h: Removed.
- WebCoreSupport/WebApplicationCacheSecurityOrigin.mm: Removed.
Create the managers lazily. Change old style calls to make use
of the managers.
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::exceededDatabaseQuota): (WebChromeClient::reachedApplicationCacheOriginQuota):
- WebCoreSupport/WebSecurityOrigin.mm: (-[WebSecurityOrigin applicationCacheQuotaManager]): (-[WebSecurityOrigin databaseQuotaManager]): (-[WebSecurityOrigin dealloc]): release the managers if they exist.
WebKitTools:
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
Part 5 - Refactor Quota Management in WebSecurityOrigin into Managers
Change old style calls to make use of the managers.
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::setDatabaseQuota):
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
- 6:29 PM Changeset in webkit [64611] by
-
- 2 edits in trunk/LayoutTests
2010-08-03 Eric Seidel <eric@webkit.org>
Unreviewed. Skipping test which fails on some Leopard installs.
http/tests/media/video-seekable-stall.html fails on the Leopard Commit Queue Machine
https://bugs.webkit.org/show_bug.cgi?id=35271
Skip this failing test as the most expedient solution.
- platform/mac-leopard/Skipped:
- 6:19 PM Changeset in webkit [64610] by
-
- 3 edits in trunk/WebCore
2010-08-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
extractAndNegateTextDecorationStyle and maxRangeOffset in ApplyStyleCommand.cpp should be deleted
https://bugs.webkit.org/show_bug.cgi?id=43437
Removed extractAndNegateTextDecorationStyle because we never push down text decorations added by CSS rules
as discussed on the bug 27809. Also removed pushDownTextDecorationStyleAtBoundaries because it only existed
to encapsulate the complexity of calling pushDownTextDecorationStyleAroundNode first with forceNegate = false
(calling pushDownTextDecorationStyleAroundNode) and again with forceNegate = true (calling extractAndNegateTextDecorationStyle)
after updating layout but neither the layout update nor the second call to pushDownTextDecorationStyleAroundNode
is needed after the removal of extractAndNegateTextDecorationStyle.
Also replaced maxRangeOffset by lastOffsetForEditing as FIXME (added by r48235) indicated.
No new tests added since this is a clean up.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): No longer takes forceNegate as an argument. (WebCore::ApplyStyleCommand::removeInlineStyle): Calls pushDownTextDecorationStyleAroundNode directly.
- editing/ApplyStyleCommand.h:
- 6:09 PM Changeset in webkit [64609] by
-
- 2 edits in trunk/WebCore
2010-08-03 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Extract a function that serializes nodes from the range version of createMarkup
https://bugs.webkit.org/show_bug.cgi?id=43405
Extracted serializeNodes that serializes nodes from createMarkup.
No new tests added since this is a clean up.
- editing/markup.cpp: (WebCore::serializeNodes): Added. (WebCore::createMarkup): Calls serializeNodes.
- 5:15 PM Changeset in webkit [64608] by
-
- 24 edits in trunk/JavaScriptCore
Bug 43390 - Do not CRASH if we run out of room for jit code.
Reviewed by Oliver Hunt.
Change the ExecutableAllocator implementations not to crash, and to return 0 if memory cannot be allocated.
The assemblers should pass this through without trying to use it in executableCopy.
Change the LinkBuffer to handle this, and to provide an allocationSuccessful() method to test for this.
Change the JIT to throw an exception if allocation fails.
Make JIT optimizations fail gracefully if memory cannot be allocated (use non-optimized path).
Change YARR JIT to fallback to PCRE
- assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::executableCopy):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::executableCopy):
- assembler/LinkBuffer.h:
(JSC::LinkBuffer::allocationSuccessful):
- assembler/MIPSAssembler.h:
(JSC::MIPSAssembler::executableCopy):
- assembler/X86Assembler.h:
(JSC::X86Assembler::executableCopy):
- bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
- jit/ExecutableAllocator.cpp:
(JSC::ExecutablePool::systemAlloc):
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::allocInternal):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- jit/JIT.h:
(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):
(JSC::JIT::compilePatchGetArrayLength):
- jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
(JSC::JIT::privateCompileCTINativeCall):
- jit/JITPropertyAccess.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompilePatchGetArrayLength):
(JSC::JIT::privateCompileGetByIdProto):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
(JSC::JIT::privateCompileGetByIdChain):
- jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):
(JSC::setupPolymorphicProtoList):
- jit/JITStubs.h:
- jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
- runtime/ExceptionHelpers.cpp:
(JSC::createOutOfMemoryError):
- runtime/ExceptionHelpers.h:
- runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
- yarr/RegexJIT.cpp:
(JSC::Yarr::RegexGenerator::compile):
- 4:44 PM Changeset in webkit [64607] by
-
- 2 edits in trunk/WebCore
Fix the build by adding the needed MathML source files to WebCore's vcproj.
Also, Visual Studio did some drive-by resorting of the vcproj, the added
MathML files are the only important change.
- WebCore.vcproj/WebCore.vcproj:
- 4:36 PM Changeset in webkit [64606] by
-
- 2 edits in trunk/WebKitTools
Add a new Leopard build slave to run the release tests.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:26 PM Changeset in webkit [64605] by
-
- 2 edits in trunk/WebCore
2010-08-03 Joseph Pecoraro <Joseph Pecoraro>
Reviewed by Nate Chapin.
Web Inspector: Missing ApplicationCache InspectorBackend Stub
https://bugs.webkit.org/show_bug.cgi?id=43265
Registered "getApplicationCaches".
- inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
- 4:09 PM Changeset in webkit [64604] by
-
- 2 edits in trunk/WebCore
Fix the Windows build by adding WebCore/mathml to the list of paths to look for header
files.
- WebCore.vcproj/WebCoreCommon.vsprops:
- 3:56 PM Changeset in webkit [64603] by
-
- 9 edits in trunk
WebKitTestRunner needs to activate the Mac font ascent hack
https://bugs.webkit.org/show_bug.cgi?id=43404
Reviewed by Darin Adler.
WebKit2:
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleActivateMacFontAscentHack):
Get the InjectedBundle, and calls its activateMacFontAscentHack().
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
Declare WKBundleActivateMacFontAscentHack().
- WebProcess/InjectedBundle/InjectedBundle.h:
Declare activateMacFontAscentHack().
- WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack):
Stubbed.
- WebProcess/InjectedBundle/qt/InjectedBundleQt.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack):
Stubbed.
- WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::activateMacFontAscentHack):
Activate the ascent hack.
WebKitTools:
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::initialize):
Call WKBundleActivateMacFontAscentHack().
- 3:55 PM Changeset in webkit [64602] by
-
- 5 edits in trunk/JavaScriptCore
Fixed a crash seen on the GTK 64bit buildbot.
Reviewed by Oliver Hunt.
When JSArray is allocated for the vptr stealing hack, it's not allocated
in the heap, so the JSArray constructor can't safely call Heap::heap().
Since this was subtle enough to confuse smart people, I've changed JSArray
to have an explicit vptr stealing constructor.
- JavaScriptCore.xcodeproj/project.pbxproj:
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
- runtime/JSArray.h:
(JSC::JSArray::):
- runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):
- 3:55 PM Changeset in webkit [64601] by
-
- 2 edits in trunk/WebKitTools
WebKitTestRunner needs to support loading custom fonts (via the
WEBKIT_TESTFONTS environment variable)
https://bugs.webkit.org/show_bug.cgi?id=42782
Reviewed by Adam Roben.
- WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
(WTR::fontsPath):
Copied from DRT code. Removed the fallback to DumpRenderTree.resources/,
as this directory doesn't appear to be created anymore.
(WTR::activateFonts):
Loop through the fonts, and call AddFontResourceExW() for each.
- 3:54 PM Changeset in webkit [64600] by
-
- 2 edits in trunk/WebCore
Fix the i386 build with a static_cast hammer.
- mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::layout):
- 3:50 PM Changeset in webkit [64599] by
-
- 2 edits in trunk/WebKit2
2010-08-03 Simon Fraser <Simon Fraser>
Fix typo in typo fix.
- Shared/DrawingAreaBase.h: (WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo): (WebKit::DrawingAreaBase::DrawingAreaBase):
- 3:49 PM Changeset in webkit [64598] by
-
- 1 edit5 deletes in trunk/ANGLE
Remove some unnecessary files from the ANGLE tree.
Rubber-stamped by Adele Peterson.
- src/compiler/tools/COPYING.bison: Removed.
- src/compiler/tools/COPYING.flex: Removed.
- src/compiler/tools/README: Removed.
- src/compiler/tools/bison.hairy: Removed.
- src/compiler/tools/bison.simple: Removed.
- 3:49 PM Changeset in webkit [64597] by
-
- 2 edits4 adds in trunk/ANGLE
Clean up the ANGLE Xcode project.
Rubber-stamped by Adele Peterson.
Main changes include:
- Adding a Production configuration.
- Modifying the library name from libangle.a to libANGLE.a.
- Installing the headers in a subdirectory of /usr/local/include to avoid polluting the top-level directory.
- Generating derived sources in to the built products directory so they're saved along with the symroot.
- Switching to using .xcconfig files for maximum cleanliness.
- ANGLE.xcodeproj/project.pbxproj:
- Configurations/ANGLE.xcconfig: Added.
- Configurations/Base.xcconfig: Added.
- Configurations/DebugRelease.xcconfig: Added.
- 3:42 PM Changeset in webkit [64596] by
-
- 5 edits in trunk/WebCore
Speculative build fix for Leopard.
- mathml/RenderMathMLOperator.cpp:
- mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):
- mathml/RenderMathMLSquareRoot.cpp:
(WebCore::RenderMathMLSquareRoot::paint):
- mathml/RenderMathMLSubSup.cpp:
- 3:33 PM Changeset in webkit [64595] by
-
- 2 edits in trunk/WebKit2
2010-08-03 Simon Fraser <Simon Fraser>
Fix typo in previous commit.
- Shared/DrawingAreaBase.h: (WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo): (WebKit::DrawingAreaBase::DrawingAreaBase):
- 3:30 PM Changeset in webkit [64594] by
-
- 21 edits2 copies in trunk
2010-08-03 Simon Fraser <Simon Fraser>
Reviewed by Anders Carlsson.
Compositing iframe layout test crashes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42860
Fix assertion caused by a DrawingArea handling a message that was targetted at an older DrawingArea
that it has replaced.
This was done by assigning a unique ID to each DrawingAreaProxy that gets created, and passing
this ID, along with the type, to the WebProcess via an encoded DrawingAreaInfo. Each message
also includes this ID. Messages with an ID that doesn't match that of the current DrawingArea are ignored.
Refactored some common code and data into a DrawingAreaBase class which is shared, and adding
encode/decode of DrawingAreaInfo.
- Shared/DrawingAreaBase.cpp: Added. (WebKit::DrawingAreaBase::encode): (WebKit::DrawingAreaBase::decode):
- Shared/DrawingAreaBase.h: Added. (WebKit::DrawingAreaBase::): (WebKit::DrawingAreaBase::~DrawingAreaBase): (WebKit::DrawingAreaBase::type): (WebKit::DrawingAreaBase::id): (WebKit::DrawingAreaBase::DrawingAreaInfo::DrawingAreaInfo): (WebKit::DrawingAreaBase::DrawingAreaBase): (CoreIPC::):
- UIProcess/ChunkedUpdateDrawingAreaProxy.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::setSize): (WebKit::ChunkedUpdateDrawingAreaProxy::setPageIsVisible): (WebKit::ChunkedUpdateDrawingAreaProxy::update):
- UIProcess/DrawingAreaProxy.cpp: (WebKit::DrawingAreaProxy::DrawingAreaProxy): (WebKit::DrawingAreaProxy::nextDrawingAreaID):
- UIProcess/DrawingAreaProxy.h:
- UIProcess/LayerBackedDrawingAreaProxy.cpp: (WebKit::LayerBackedDrawingAreaProxy::setSize): (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible): (WebKit::LayerBackedDrawingAreaProxy::update):
- UIProcess/LayerBackedDrawingAreaProxy.h:
- UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveSyncMessage):
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::createWindow):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp: (WebKit::ChunkedUpdateDrawingArea::ChunkedUpdateDrawingArea): (WebKit::ChunkedUpdateDrawingArea::didReceiveMessage):
- WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create): (WebKit::DrawingArea::DrawingArea):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/LayerBackedDrawingArea.cpp: (WebKit::LayerBackedDrawingArea::LayerBackedDrawingArea): (WebKit::LayerBackedDrawingArea::didReceiveMessage):
- WebProcess/WebPage/LayerBackedDrawingArea.h:
- WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::create): (WebKit::WebPage::WebPage): (WebKit::WebPage::changeAcceleratedCompositingMode):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::createWebPage): (WebKit::WebProcess::didReceiveMessage):
- WebProcess/WebProcess.h:
- win/WebKit2.vcproj:
- 3:29 PM Changeset in webkit [64593] by
-
- 2 edits in trunk/WebKitLibraries
Enable MathML on Windows.
Reviewed by Alice Liu.
- win/tools/vsprops/FeatureDefines.vsprops:
- 3:11 PM Changeset in webkit [64592] by
-
- 2 edits in trunk/WebCore
Speculative build fix.
- css/mathml.css:
(mi):
(math[mathsize="small"], mstyle[mathsize="small"], mo[mathsize="small"], mn[mathsize="small"], mi[mathsize="small"], mtext[mathsize="small"], mspace[mathsize="small"], ms[mathsize="small"]):
(math[mathsize="normal"], mstyle[mathsize="normal"], mo[mathsize="normal"], mn[mathsize="normal"], mi[mathsize="normal"], mtext[mathsize="normal"], mspace[mathsize="normal"], ms[mathsize="normal"]):
(math[mathsize="big"], mstyle[mathsize="big"], mo[mathsize="big"], mn[mathsize="big"], mi[mathsize="big"], mtext[mathsize="big"], mspace[mathsize="big"], ms[mathsize="big"]):
- 3:04 PM Changeset in webkit [64591] by
-
- 4 edits in trunk
2010-08-03 Alex Milowski <alex@milowski.com>
Reviewed by Beth Dakin.
Changed the ENABLE_MATHML value to enable MathML by default.
- Configurations/FeatureDefines.xcconfig:
2010-08-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=43444
PLATFORM(CF) is false on Windows in JavaScriptCore
Moved some PLATFORM(WIN) #defines down into JavaScriptCore.
- config.h: Moved WTF_PLATFORM_CF 1 and WTF_USE_PTHREADS 0 to wtf/Platform.h. Removed #undef WTF_USE_WININET because wtf/Platform.h no longer #defines it.
- 2:57 PM Changeset in webkit [64590] by
-
- 2 edits in trunk/LayoutTests
2010-08-03 Dimitri Glazkov <Dimitri Glazkov>
Removed duplicate expectations from the DRT overrides.
- platform/chromium/drt_expectations.txt: Removed special-key-events-in-input-text.html.
- 2:40 PM Writing DumpAsMarkup Tests edited by
- Updated "Dump Multiple Times" to match the recent changes (diff)
- 2:35 PM Changeset in webkit [64589] by
-
- 11 edits in trunk
JavaScriptCore: Changed the ENABLE_MATHML value to enable MathML by default.
Patch by Alex Milowski <alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.
- Configurations/FeatureDefines.xcconfig:
WebCore: Changed the ENABLE_MATHML value to enable MathML by default.
Patch by Alex Milowski <alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.
- Configurations/FeatureDefines.xcconfig:
WebKit/mac: Changed the ENABLE_MATHML value to enable MathML by default.
Patch by Alex Milowski <alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.
- Configurations/FeatureDefines.xcconfig:
WebKit2: Changed the ENABLE_MATHML value to enable MathML by default.
Patch by Alex Milowski <alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.
- Configurations/FeatureDefines.xcconfig:
WebKitTools: Changed the default for MathML support so that is is enabled by default.
Patch by Alex Milowski <alex@milowski.com> on 2010-08-03
Reviewed by Beth Dakin.
- Scripts/build-webkit:
- 2:34 PM Writing DumpAsMarkup Tests edited by
- Updated "Output Subtree" to match the recent changes (diff)
- 2:29 PM Writing DumpAsMarkup Tests edited by
- Updated "How to Use" to match the recent changes (diff)
- 2:29 PM Changeset in webkit [64588] by
-
- 4 edits in trunk/JavaScriptCore
Change to keep returned pointer from malloc family functions to
quiet memory leak detect. The pointer is saved in the new m_allocBase
member of the ArrayStorage structure. This fixes the issue found in
https://bugs.webkit.org/show_bug.cgi?id=43229.
Patch by Michael Saboff <msaboff@apple.com> on 2010-08-03
Reviewed by Gavin Barraclough.
As part of this change, we use m_allocBase when reallocating and
freeing the memory associated with ArrayStorage.
- runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::~JSArray):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::increaseVectorPrefixLength):
- runtime/JSArray.h:
- 2:01 PM Changeset in webkit [64587] by
-
- 3 edits in trunk/JavaScriptCore
Try to fix Windows build: Don't use GCActivityCallbackCF on Windows, since
PLATFORM(CF) is not defined on Windows.
We'll need to enable the GC activity callback some other way, but this
change should get the build back to normal.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- runtime/GCActivityCallbackCF.cpp: Make it easier to detect this error
in the future with an explicit error message.
- 1:42 PM Changeset in webkit [64586] by
-
- 2 edits in trunk/JavaScriptCore
Try to fix Windows build: update .def file.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
- 1:34 PM Changeset in webkit [64585] by
-
- 12 edits3 adds in trunk/JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=41318
GC should reclaim garbage even when new objects are not being allocated rapidly
Patch by Nathan Lawrence <nlawrence@apple.com> on 2010-08-03
Reviewed by Oliver Hunt.
Added a callback in JavaScriptCore that gets triggered after an
allocation causes the heap to reset. This is useful for adding a
timer that will trigger garbage collection after the "last" allocation.
Also needed was to add lock and unlock methods to JSLock that needed
only a JSGlobalData object versus an ExecState object.
- CMakeLists.txt:
- GNUmakefile.am:
- JavaScriptCore.exp:
- JavaScriptCore.gypi:
- JavaScriptCore.pro:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_by_val):
- runtime/Collector.cpp:
(JSC::Heap::Heap):
(JSC::Heap::reset):
(JSC::Heap::setActivityCallback):
- runtime/Collector.h:
- runtime/GCActivityCallback.cpp: Added.
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()):
- runtime/GCActivityCallback.h: Added.
(JSC::GCActivityCallback::~GCActivityCallback):
(JSC::GCActivityCallback::operator()):
(JSC::GCActivityCallback::GCActivityCallback):
(JSC::DefaultGCActivityCallback::create):
- runtime/GCActivityCallbackCF.cpp: Added.
(JSC::DefaultGCActivityCallbackPlatformData::trigger):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::~DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::operator()):
- runtime/JSLock.cpp:
(JSC::JSLock::JSLock):
- runtime/JSLock.h:
- 1:23 PM Changeset in webkit [64584] by
-
- 10 edits in trunk/WebCore
2010-07-30 Stephen White <senorblanco@chromium.org>
Reviewed by Ojan Vafai.
Move PlatformContextSkia and NativeImageSkia into the WebCore namespace.
https://bugs.webkit.org/show_bug.cgi?id=43272
One wrinkle is that PlatformContext and NativeImagePtr are
typedef'ed outside outside the WebCore namespace block, so the
PlatformContextSkia and NativeImageSkia have to be forward-declared
explicitly within that namespace. Another solution might be to move
those declarations into the WebCore namespace block below, but that
would affect platforms other than Skia, so I leave it to the reviewer
to decide.
Test: if it compiles, you're happy.
- platform/graphics/GraphicsContext.h:
- platform/graphics/Image.h:
- platform/graphics/ImageSource.h:
- platform/graphics/skia/NativeImageSkia.cpp: (WebCore::NativeImageSkia::hasResizedBitmap): (WebCore::NativeImageSkia::shouldCacheResampling):
- platform/graphics/skia/NativeImageSkia.h:
- platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::State::State): (WebCore::PlatformContextSkia::beginLayerClippedToImage): (WebCore::PlatformContextSkia::drawRect): (WebCore::PlatformContextSkia::setupPaintForStroking): (WebCore::PlatformContextSkia::getStrokeStyle): (WebCore::PlatformContextSkia::setStrokeStyle): (WebCore::PlatformContextSkia::setTextDrawingMode): (WebCore::PlatformContextSkia::interpolationQuality): (WebCore::PlatformContextSkia::setInterpolationQuality): (WebCore::PlatformContextSkia::getImageResamplingHint): (WebCore::PlatformContextSkia::setImageResamplingHint): (WebCore::PlatformContextSkia::clearImageResamplingHint): (WebCore::PlatformContextSkia::applyClipFromImage): (WebCore::PlatformContextSkia::setGLES2Context): (WebCore::PlatformContextSkia::prepareForSoftwareDraw): (WebCore::PlatformContextSkia::prepareForHardwareDraw): (WebCore::PlatformContextSkia::syncSoftwareCanvas): (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
- platform/graphics/skia/PlatformContextSkia.h: (WebCore::PlatformContextSkia::gpuCanvas):
- platform/graphics/skia/SkiaFontWin.cpp: (WebCore::windowsCanHandleDrawTextShadow): (WebCore::paintSkiaText):
- platform/graphics/skia/SkiaFontWin.h:
- 1:04 PM Changeset in webkit [64583] by
-
- 2 edits1 move in trunk/WebCore
Rename LocalizedStringsMac.mm to LocalizedStrings.cpp
LocalizedStringsMac.mm should be usable by other ports
https://bugs.webkit.org/show_bug.cgi?id=43441
Reviewed by Anders Carlsson.
- WebCore.xcodeproj/project.pbxproj: Updated the file's name and path.
- platform/LocalizedStrings.cpp: Renamed from
WebCore/platform/mac/LocalizedStringsMac.mm. Changed #imports to
- 12:47 PM Changeset in webkit [64582] by
-
- 10 edits in trunk
2010-08-03 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API
https://bugs.webkit.org/show_bug.cgi?id=43221
Implements functions in term of Platform3DObjects instead of WebGL types.
- src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::shaderSource):
2010-08-03 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
Move WebGL-specific code out of GraphicsContext3D so that G3D can be used as a generic accelerated drawing API
https://bugs.webkit.org/show_bug.cgi?id=43221
Changes the GraphicsContext3D API to use Platform3DObjects instead of WebGLFoo* types like WebGLTexture.
WebGLRenderingContext still uses WebGLFoo types and converts to Platform3DObjects internally. Other
consumers of the GraphicsContext3D can use the Platform3DObject APIs directly without any ties to WebGL.
The majority of this change is purely mechanical. The less obvious changes are:
- move all null checking on WebGLFoo types to WebGLRenderingContext, instead of mixing them between WebGLRenderingContext and the various port-specific implementations of GraphicsContext3D
- add a GraphicsContext3D getter to CanvasRenderingContext. This is needed for the readback path on Chromium/mac. It may be possible to remove this, but I would prefer to do that in a follow-up patch to minimize churn.
- move some texture cube map logic that existed only in the Chromium port of GC3D to WebGLRenderingContext behind #if PLATFORM(CHROMIUM). I think this logic should either exist for all ports or exist for none, but again I would rather change the behavior in a different patch from this one.
- html/canvas/CanvasRenderingContext.h: (WebCore::CanvasRenderingContext::graphicsContext3D):
- html/canvas/WebGLProgram.cpp: (WebCore::WebGLProgram::cacheActiveAttribLocations):
- html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): (WebCore::WebGLRenderingContext::bindAttribLocation): (WebCore::WebGLRenderingContext::bindBuffer): (WebCore::WebGLRenderingContext::bindFramebuffer): (WebCore::WebGLRenderingContext::bindRenderbuffer): (WebCore::WebGLRenderingContext::bindTexture): (WebCore::WebGLRenderingContext::compileShader): (WebCore::WebGLRenderingContext::detachShader): (WebCore::WebGLRenderingContext::framebufferRenderbuffer): (WebCore::WebGLRenderingContext::framebufferTexture2D): (WebCore::WebGLRenderingContext::getActiveAttrib): (WebCore::WebGLRenderingContext::getActiveUniform): (WebCore::WebGLRenderingContext::getAttachedShaders): (WebCore::WebGLRenderingContext::getAttribLocation): (WebCore::WebGLRenderingContext::getProgramParameter): (WebCore::WebGLRenderingContext::getProgramInfoLog): (WebCore::WebGLRenderingContext::getShaderParameter): (WebCore::WebGLRenderingContext::getShaderInfoLog): (WebCore::WebGLRenderingContext::getShaderSource): (WebCore::WebGLRenderingContext::getUniform): (WebCore::WebGLRenderingContext::getUniformLocation): (WebCore::WebGLRenderingContext::isBuffer): (WebCore::WebGLRenderingContext::isFramebuffer): (WebCore::WebGLRenderingContext::isProgram): (WebCore::WebGLRenderingContext::isRenderbuffer): (WebCore::WebGLRenderingContext::isShader): (WebCore::WebGLRenderingContext::isTexture): (WebCore::WebGLRenderingContext::linkProgram): (WebCore::WebGLRenderingContext::shaderSource): (WebCore::WebGLRenderingContext::useProgram): (WebCore::WebGLRenderingContext::validateProgram): (WebCore::WebGLRenderingContext::handleNPOTTextures): (WebCore::WebGLRenderingContext::createFallbackBlackTextures1x1): (WebCore::WebGLRenderingContext::initVertexAttrib0): (WebCore::WebGLRenderingContext::simulateVertexAttrib0): (WebCore::WebGLRenderingContext::restoreStatesAfterVertexAttrib0Simulation):
- html/canvas/WebGLRenderingContext.h: (WebCore::WebGLRenderingContext::graphicsContext3D):
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/mac/GraphicsContext3DMac.mm: (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttachedShaders): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation):
- platform/graphics/qt/GraphicsContext3DQt.cpp: (WebCore::GraphicsContext3D::beginPaint): (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): (WebCore::GraphicsContext3D::attachShader): (WebCore::GraphicsContext3D::bindAttribLocation): (WebCore::GraphicsContext3D::bindBuffer): (WebCore::GraphicsContext3D::bindFramebuffer): (WebCore::GraphicsContext3D::bindRenderbuffer): (WebCore::GraphicsContext3D::bindTexture): (WebCore::GraphicsContext3D::compileShader): (WebCore::GraphicsContext3D::detachShader): (WebCore::GraphicsContext3D::framebufferRenderbuffer): (WebCore::GraphicsContext3D::framebufferTexture2D): (WebCore::GraphicsContext3D::getActiveAttrib): (WebCore::GraphicsContext3D::getActiveUniform): (WebCore::GraphicsContext3D::getAttribLocation): (WebCore::GraphicsContext3D::isBuffer): (WebCore::GraphicsContext3D::isFramebuffer): (WebCore::GraphicsContext3D::isProgram): (WebCore::GraphicsContext3D::isRenderbuffer): (WebCore::GraphicsContext3D::isShader): (WebCore::GraphicsContext3D::isTexture): (WebCore::GraphicsContext3D::linkProgram): (WebCore::GraphicsContext3D::shaderSource): (WebCore::GraphicsContext3D::useProgram): (WebCore::GraphicsContext3D::validateProgram): (WebCore::GraphicsContext3D::getProgramiv): (WebCore::GraphicsContext3D::getProgramInfoLog): (WebCore::GraphicsContext3D::getShaderiv): (WebCore::GraphicsContext3D::getShaderInfoLog): (WebCore::GraphicsContext3D::getShaderSource): (WebCore::GraphicsContext3D::getUniformfv): (WebCore::GraphicsContext3D::getUniformiv): (WebCore::GraphicsContext3D::getUniformLocation):
- 12:45 PM Changeset in webkit [64581] by
-
- 2 edits in trunk/LayoutTests
- platform/mac-snowleopard/Skipped: Added bug number.
- 12:41 PM Changeset in webkit [64580] by
-
- 10 edits1 add in trunk
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Fix DOM event dispatch
https://bugs.webkit.org/show_bug.cgi?id=40847
Add new files to the build.
- GNUmakefile.am:
WebCore:
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Fix DOM event dispatch
https://bugs.webkit.org/show_bug.cgi?id=40847
Bind UI and Mouse events and add ad-hoc kit method for WebCore
Events.
- GNUmakefile.am:
- bindings/gobject/WebKitDOMBinding.cpp: (WebKit::kit):
- bindings/gobject/WebKitDOMBinding.h:
- bindings/gobject/WebKitDOMEventTarget.cpp: (WebKit::core):
- bindings/gobject/WebKitDOMEventTargetPrivate.h: Added.
- bindings/scripts/CodeGeneratorGObject.pm:
WebKit/gtk:
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
[GTK] Fix DOM event dispatch
https://bugs.webkit.org/show_bug.cgi?id=40847
Test DOM event dispatch.
- tests/testdomdomwindow.c: (load_event_callback): (test_dom_domview_signals): (clicked_cb): (load_status_callback): (test_dom_domview_dispatch_event): (main):
- 12:39 PM Changeset in webkit [64579] by
-
- 480 edits in trunk/WebCore
2010-08-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Eric Seidel.
Cleanup all of svg/ code
https://bugs.webkit.org/show_bug.cgi?id=43311
Unify the license header in all files in svg/, to use the same template as most WebCore files use.
Unified email adress style, etc. all generated with a perl script attached to bug 43311.
- svg/...: Updated header template in all files, in the svg/ subdirectory.
- 12:31 PM Changeset in webkit [64578] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-03 Dimitri Glazkov <Dimitri Glazkov>
Unreviewed, build fix.
Roll chromium to 54723 to unbreak the builds.
- DEPS:
- 12:20 PM Changeset in webkit [64577] by
-
- 37 edits1 copy4 moves1 delete in trunk
2010-08-03 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] IDBObjectStoreRequest should be called IDBObjectStore
https://bugs.webkit.org/show_bug.cgi?id=43420
Renaming IDBObjectStoreRequest to IDBObjectStore.
No new tests needed, just refactoring.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- storage/IDBAny.cpp: (WebCore::IDBAny::idbObjectStore): (WebCore::IDBAny::set):
- storage/IDBAny.h: (WebCore::IDBAny::):
- storage/IDBCallbacks.h:
- storage/IDBDatabase.cpp: (WebCore::IDBDatabase::objectStore):
- storage/IDBDatabase.h:
- storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore):
- storage/IDBDatabaseBackendImpl.h:
- storage/IDBDatabaseBackendInterface.h:
- storage/IDBObjectStore.cpp: Added. (WebCore::IDBObjectStore::IDBObjectStore): (WebCore::IDBObjectStore::name): (WebCore::IDBObjectStore::keyPath): (WebCore::IDBObjectStore::indexNames): (WebCore::IDBObjectStore::get): (WebCore::IDBObjectStore::add): (WebCore::IDBObjectStore::put): (WebCore::IDBObjectStore::remove): (WebCore::IDBObjectStore::createIndex): (WebCore::IDBObjectStore::index): (WebCore::IDBObjectStore::removeIndex):
- storage/IDBObjectStore.h: (WebCore::IDBObjectStore::create): (WebCore::IDBObjectStore::~IDBObjectStore):
- storage/IDBObjectStore.idl: Added.
- storage/IDBObjectStoreBackendImpl.cpp: Added. (WebCore::IDBObjectStoreBackendImpl::~IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::indexNames): (WebCore::IDBObjectStoreBackendImpl::get): (WebCore::IDBObjectStoreBackendImpl::put): (WebCore::IDBObjectStoreBackendImpl::remove): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::index): (WebCore::IDBObjectStoreBackendImpl::removeIndex):
- storage/IDBObjectStoreBackendImpl.h: Added. (WebCore::IDBObjectStoreBackendImpl::create): (WebCore::IDBObjectStoreBackendImpl::name): (WebCore::IDBObjectStoreBackendImpl::keyPath):
- storage/IDBObjectStoreBackendInterface.h: Added. (WebCore::IDBObjectStoreBackendInterface::~IDBObjectStoreBackendInterface):
- storage/IDBObjectStoreImpl.cpp: Removed.
- storage/IDBObjectStoreImpl.h: Removed.
- storage/IDBObjectStoreRequest.cpp: Removed.
- storage/IDBObjectStoreRequest.h: Removed.
- storage/IDBObjectStoreRequest.idl: Removed.
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
- storage/IDBRequest.h:
2010-08-03 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
[IndexedDB] IDBObjectStoreRequest should be called IDBObjectStore
https://bugs.webkit.org/show_bug.cgi?id=43420
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::objectStore):
- src/IDBDatabaseProxy.h:
- src/IDBObjectStoreProxy.cpp: (WebCore::IDBObjectStoreProxy::create):
- src/IDBObjectStoreProxy.h:
- src/WebIDBObjectStoreImpl.cpp: (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl):
- src/WebIDBObjectStoreImpl.h:
- 12:18 PM Changeset in webkit [64576] by
-
- 5 edits1 add in trunk/WebKitTools
Roll r64566 back in this time with all the overloads in place..
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldInsertNode):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/StringFunctions.h:
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 12:17 PM Changeset in webkit [64575] by
-
- 2 edits in trunk/LayoutTests
- platform/mac-snowleopard/Skipped: Skip remove-property test that Anders added while
working on WebKit2. Unknown why it's failing on SnowLeopard at this time. We could have
added SnowLeopard-specific results instead, but for now we decided skipping was easier.
Reviewed by Anders Carlsson.
- 12:11 PM Changeset in webkit [64574] by
-
- 5 edits1 delete in trunk/WebKitTools
Rollout r64566. It broke all the WebKit2 tests.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<):
(WTR::InjectedBundlePage::shouldInsertNode):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/StringFunctions.h: Removed.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::createWKURL):
(WTR::WKStringToUTF8):
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 11:56 AM Changeset in webkit [64573] by
-
- 4 edits in trunk
2010-08-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ojan Vafai.
[GTK] Incorrect keyIdentifier for print screen key events
https://bugs.webkit.org/show_bug.cgi?id=43422
Unskip a test which is now passing.
- platform/gtk/Skipped:
2010-08-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Ojan Vafai.
[GTK] Incorrect keyIdentifier for print screen key events
https://bugs.webkit.org/show_bug.cgi?id=43422
Produce the correct keyIdentifier for GDK_Print (print screen).
- platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
- 11:44 AM Changeset in webkit [64572] by
-
- 2 edits in trunk/WebCore
2010-08-03 Anton Muhin <antonm@chromium.org>
Reviewed by David Levin.
[v8] Get current memory usage and make it available on stack before crashing due to out of memory
https://bugs.webkit.org/show_bug.cgi?id=43426
That should allow us to diagnose the cases when the process just ran out of memory
and hence V8 failed to allocate more OS pages.
- bindings/v8/V8DOMWindowShell.cpp: (WebCore::reportFatalErrorInV8):
- 11:28 AM Changeset in webkit [64571] by
-
- 2 edits in trunk/WebKit/gtk/po
2010-08-03 Jorge González <aloriel@gmail.com>
Reviewed by Gustavo Noronha.
Spanish translation update.
- es.po: Updated.
- 11:18 AM Changeset in webkit [64570] by
-
- 5 edits7 adds in trunk
2010-08-03 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
Implement HTML5 slider theme (using the scrollbar theme as base).
https://bugs.webkit.org/show_bug.cgi?id=43430
- DefaultTheme/default.edc: Include slider.edc.
- DefaultTheme/widget/slider/slider.edc: Added.
- DefaultTheme/widget/slider/slider_h.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png.
- DefaultTheme/widget/slider/slider_hilight.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_hilight.png.
- DefaultTheme/widget/slider/slider_knob_h.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png.
- DefaultTheme/widget/slider/slider_knob_v.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png.
- DefaultTheme/widget/slider/slider_v.png: Copied from WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png.
2010-08-03 Leandro Pereira <leandro@profusion.mobi>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Implement HTML5 slider theme (using the scrollbar theme as base).
https://bugs.webkit.org/show_bug.cgi?id=43430
EFL port does not yet support automated tests.
- platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::paintThemePart): (WebCore::RenderThemeEfl::edjeGroupFromFormType): Add Edje groups for both vertical and horizontal sliders. (WebCore::supportsFocus): Add sliders as focusable elements. (WebCore::RenderThemeEfl::paintSliderTrack): Implement. (WebCore::RenderThemeEfl::adjustSliderTrackStyle): Implement. (WebCore::RenderThemeEfl::adjustSliderThumbStyle): Use adjustSliderTrackStyle() implementation. (WebCore::RenderThemeEfl::paintSliderThumb): Use paintSliderTrack() implementation().
- platform/efl/RenderThemeEfl.h: Add SliderVertical and
- SliderHorizontal. (WebCore::): Added prototypes for adjustSlider*/paintSlider*.
- 11:12 AM Changeset in webkit [64569] by
-
- 5 edits in trunk/WebKit2
2010-08-03 Simon Fraser <Simon Fraser>
Reviewed by Sam Weinig.
Compositing iframe layout test crashes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42860
Part one of the fix: make DrawingArea ref-counted, so that the object
can survide a swap in drawing areas inside the run loop observer callback.
- WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
- WebProcess/WebPage/DrawingArea.h:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/LayerBackedDrawingAreaMac.mm: (WebKit::LayerBackedDrawingArea::platformClear): (WebKit::LayerBackedDrawingArea::updateLayoutRunLoopObserverCallback): (WebKit::LayerBackedDrawingArea::updateLayoutRunLoopObserverFired):
- 11:10 AM Changeset in webkit [64568] by
-
- 3 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Fix crash during HitTest call.
https://bugs.webkit.org/show_bug.cgi?id=43372
- 11:08 AM Changeset in webkit [64567] by
-
- 3 edits in trunk/WebKit/gtk
2010-08-03 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Xan Lopez.
[GTK] Does not paint the node highlight used by the inspector
https://bugs.webkit.org/show_bug.cgi?id=43429
Implement highlighting the nodes when using the inspector.
- WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::highlight): (WebKit::InspectorClient::hideHighlight):
- webkit/webkitwebview.cpp: (webkit_web_view_expose_event):
- 11:02 AM Changeset in webkit [64566] by
-
- 5 edits1 add in trunk/WebKitTools
WTR: Move all the utility functions for working with strings to a shared header.
https://bugs.webkit.org/show_bug.cgi?id=43386
Reviewed by Anders Carlsson.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::shouldInsertNode):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
- WebKitTestRunner/StringFunctions.h: Added.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::resetPreferencesToConsistentValues):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- 10:54 AM Changeset in webkit [64565] by
-
- 2 edits in trunk/WebCore
2010-08-03 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: incorrect absolute protocol-less URLs in tooltips of links in the ElementsTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=43246
- inspector/front-end/inspector.js: (WebInspector.completeURL):
- 10:39 AM Changeset in webkit [64564] by
-
- 2 edits in trunk/WebKit2
Frequent ASSERT_NOT_REACHED in Connection::processIncomingMessage when running regression tests
https://bugs.webkit.org/show_bug.cgi?id=42926
<rdar://problem/8237329>
Reviewed by Adam Roben.
Remove this assert, it's bogus. It would fire when a reply came in on the connection queue before
waitForReply was called on the client thread, but that case is already covered.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::processIncomingMessage):
- 10:17 AM Changeset in webkit [64563] by
-
- 6 edits in trunk
Compile out two Mac-only localized strings on non-Mac platforms
Fixes <http://webkit.org/b/43433> copyImageUnknownFileLabel and
AXARIAContentGroupText should only be compiled on Mac
Reviewed by Anders Carlsson.
WebCore:
- platform/LocalizationStrategy.h:
- platform/LocalizedStrings.h:
Wrapped copyImageUnknownFileLabel and AXARIAContentGroupText in
PLATFORM(MAC).
WebKit2:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Wrapped copyImageUnknownFileLabel and AXARIAContentGroupText in
PLATFORM(MAC).
- 10:13 AM Changeset in webkit [64562] by
-
- 2 edits in trunk/WebCore
[wx] Build fix, don't build some DOM bindings we don't use.
- 10:02 AM Changeset in webkit [64561] by
-
- 2 edits in trunk/WebCore
2010-08-03 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Remove a memory leak from CusorGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=43424
- platform/gtk/CursorGtk.cpp: (WebCore::createNamedCursor): (WebCore::createCustomCursor): (WebCore::Cursor::ensurePlatformCursor):
- platform/gtk/KeyEventGtk.cpp: (WebCore::keyIdentifierForGdkKeyCode):
- 9:26 AM Changeset in webkit [64560] by
-
- 149 adds in trunk/ANGLE
2010-08-02 Paul Sawaya <psawaya@apple.com>
Reviewed by Adele Peterson.
Add ANGLE library to WebKit. From the repository (http://angleproject.googlecode.com) as of July 22.
https://bugs.webkit.org/show_bug.cgi?id=42789
- 9:01 AM AGC created by
- 8:47 AM Changeset in webkit [64559] by
-
- 2 edits in trunk/WebKit/efl
2010-08-03 ryuan choi <ryuan.choi@samsung.com>
Reviewed by Darin Adler.
[EFL] REGRESSION(64425) need to fix build break
https://bugs.webkit.org/show_bug.cgi?id=43322
just add include path missed after r64425
- CMakeListsEfl.txt:
- 8:33 AM Changeset in webkit [64558] by
-
- 3 edits in trunk/WebCore
2010-08-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: speculative chromium tests fix.
- inspector/front-end/ExtensionServer.js:
- inspector/front-end/inspector.js: (WebInspector.loaded):
- 8:26 AM Changeset in webkit [64557] by
-
- 4 edits in trunk/WebKit/qt
[Qt] Platform plugin interface for Haptics
https://bugs.webkit.org/show_bug.cgi?id=43143
Patch by Kim Grönholm <kim.1.gronholm@nokia.com> on 2010-08-03
Reviewed by Simon Hausmann.
Platform plugin interface for playing haptic feedback
- Api/qwebkitplatformplugin.h:
(QWebHapticFeedbackPlayer::):
(QWebKitPlatformPlugin::):
- examples/platformplugin/WebPlugin.h:
(WebPlugin::createHapticFeedbackPlayer):
- examples/platformplugin/qwebkitplatformplugin.h:
(QWebHapticFeedbackPlayer::):
(QWebKitPlatformPlugin::):
- 8:14 AM Changeset in webkit [64556] by
-
- 4 edits in trunk/WebKitTools
2010-08-02 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Kenneth Christiansen.
[Qt] QtTestBrowser not setting preferredContentsSize for resizesToContents
https://bugs.webkit.org/show_bug.cgi?id=43168
QGraphicsWebView resizesToContents property has to work together with QWebPage's
setPreferredContentsSize as stated by the docs. Patch addresses that for QtTestBrowser.
- QtTestBrowser/launcherwindow.cpp: (LauncherWindow::applyPrefs):
- QtTestBrowser/webview.h: (WebViewGraphicsBased::setCustomLayoutSize): Setter helper. (WebViewGraphicsBased::customLayoutSize): Getter helper.
- QtTestBrowser/webview.cpp: (WebViewGraphicsBased::resizeEvent): (WebViewGraphicsBased::setResizesToContents): Properly handle scene, webview and viewport sizes
needed when toggle resizesToContents on/off.
- 8:07 AM Changeset in webkit [64555] by
-
- 3 edits in trunk/LayoutTests
2010-08-03 Martin Robinson <mrobinson@igalia.com>
[GTK] Incorrect keyIdentifier for print screen key events
https://bugs.webkit.org/show_bug.cgi?id=43422
Skip this test on GTK+ until this bug can be fixed. Correct the
baseline, so that the Mac bots pass the test.
- fast/events/special-key-events-in-input-text-expected.txt:
- platform/gtk/Skipped:
- 7:53 AM Changeset in webkit [64554] by
-
- 2 edits in trunk/WebKit/chromium
2010-08-03 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Chromium interactive UI tests.
- src/js/Tests.js: (.TestSuite.prototype.testResourceHeaders):
- 6:44 AM Changeset in webkit [64553] by
-
- 2 edits in trunk/WebCore
2010-08-03 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Antonio Gomes.
Fix warning in WebCore/rendering/RenderBoxModelObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=43412
- rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::clipBorderSidePolygon): Remove useless assignment.
- 6:38 AM Changeset in webkit [64552] by
-
- 5 edits in trunk
WebCore:
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Make string parameters be 'const char*' instead of just 'char*'.
- bindings/scripts/CodeGeneratorGObject.pm:
WebKit/gtk:
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Update unit tests now that string parameters are 'const char*'.
- tests/testdomdocument.c: (test_dom_document_title): (test_dom_document_get_elements_by_tag_name): (test_dom_document_get_elements_by_class_name): (test_dom_document_get_element_by_id):
- tests/testdomnode.c: (test_dom_node_insertion):
- 6:37 AM Changeset in webkit [64551] by
-
- 2 edits in trunk/WebCore
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Get rid of extra spaces in the type strings.
- bindings/scripts/CodeGeneratorGObject.pm:
- 6:33 AM Changeset in webkit [64550] by
-
- 2 edits in trunk
2010-08-03 Xan Lopez <xlopez@igalia.com>
Reviewed by Gustavo Noronha.
Silence JSCore gir "creation".
- GNUmakefile.am:
- 6:24 AM Changeset in webkit [64549] by
-
- 2 edits in trunk/WebKitTools
2010-08-03 Jochen Eisinger <jochen@chromium.org>
Unreviewed. Adding myself as committer.
- Scripts/webkitpy/common/config/committers.py:
- 6:22 AM Changeset in webkit [64548] by
-
- 2 edits in trunk/WebCore
2010-08-03 Csaba Osztrogonác <Csaba Osztrogonác>
Reviewed by Adam Roben.
Fix warning in WebCore/plugins/win/PluginMessageThrottlerWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=43413
- plugins/win/PluginMessageThrottlerWin.cpp: (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Modify initialization order.
- 6:07 AM Changeset in webkit [64547] by
-
- 8 edits in trunk/WebCore
2010-08-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: use InspectorValue to push resource data to the frontend
https://bugs.webkit.org/show_bug.cgi?id=43414
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::disconnectFrontend): destroy remote frontend object along with the old inspector frontend (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::didLoadResourceFromMemoryCache): (WebCore::InspectorController::identifierForInitialRequest): (WebCore::InspectorController::mainResourceFiredDOMContentEvent): (WebCore::InspectorController::mainResourceFiredLoadEvent): (WebCore::InspectorController::willSendRequest): (WebCore::InspectorController::didReceiveResponse): (WebCore::InspectorController::didReceiveContentLength): (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest): (WebCore::InspectorController::scriptImported):
- inspector/InspectorFrontend.cpp:
- inspector/InspectorFrontend.h:
- inspector/InspectorResource.cpp: (WebCore::buildHeadersObject): (WebCore::buildObjectForTiming): (WebCore::InspectorResource::updateScriptObject):
- inspector/InspectorResource.h:
- inspector/front-end/inspector.js: (WebInspector.updateResource):
- 5:50 AM Changeset in webkit [64546] by
-
- 480 edits in trunk/WebCore
2010-08-03 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64539.
http://trac.webkit.org/changeset/64539
https://bugs.webkit.org/show_bug.cgi?id=43409
Accidently changed licenses in some files (Requested by
WildFox on #webkit).
- svg/ColorDistance.cpp:
- svg/ColorDistance.h:
- svg/ElementTimeControl.h:
- svg/ElementTimeControl.idl:
- svg/GradientAttributes.h:
- svg/LinearGradientAttributes.h:
- svg/PatternAttributes.h:
- svg/RadialGradientAttributes.h:
- svg/SVGAElement.cpp:
- svg/SVGAElement.h:
- svg/SVGAElement.idl:
- svg/SVGAllInOne.cpp:
- svg/SVGAltGlyphElement.cpp:
- svg/SVGAltGlyphElement.h:
- svg/SVGAltGlyphElement.idl:
- svg/SVGAngle.cpp:
- svg/SVGAngle.h:
- svg/SVGAngle.idl:
- svg/SVGAnimateColorElement.cpp:
- svg/SVGAnimateColorElement.h:
- svg/SVGAnimateColorElement.idl:
- svg/SVGAnimateElement.cpp:
- svg/SVGAnimateElement.h:
- svg/SVGAnimateElement.idl:
- svg/SVGAnimateMotionElement.cpp:
- svg/SVGAnimateMotionElement.h:
- svg/SVGAnimateTransformElement.cpp:
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimateTransformElement.idl:
- svg/SVGAnimatedAngle.idl:
- svg/SVGAnimatedBoolean.idl:
- svg/SVGAnimatedEnumeration.idl:
- svg/SVGAnimatedInteger.idl:
- svg/SVGAnimatedLength.idl:
- svg/SVGAnimatedLengthList.idl:
- svg/SVGAnimatedNumber.idl:
- svg/SVGAnimatedNumberList.idl:
- svg/SVGAnimatedPathData.cpp:
- svg/SVGAnimatedPathData.h:
- svg/SVGAnimatedPathData.idl:
- svg/SVGAnimatedPoints.cpp:
- svg/SVGAnimatedPoints.h:
- svg/SVGAnimatedPoints.idl:
- svg/SVGAnimatedPreserveAspectRatio.idl:
- svg/SVGAnimatedProperty.h:
- svg/SVGAnimatedPropertySynchronizer.h:
- svg/SVGAnimatedPropertyTraits.h:
- svg/SVGAnimatedRect.idl:
- svg/SVGAnimatedString.idl:
- svg/SVGAnimatedTemplate.h:
- svg/SVGAnimatedTransformList.idl:
- svg/SVGAnimationElement.cpp:
- svg/SVGAnimationElement.h:
- svg/SVGAnimationElement.idl:
- svg/SVGCircleElement.cpp:
- svg/SVGCircleElement.h:
- svg/SVGCircleElement.idl:
- svg/SVGClipPathElement.cpp:
- svg/SVGClipPathElement.h:
- svg/SVGClipPathElement.idl:
- svg/SVGColor.cpp:
- svg/SVGColor.h:
- svg/SVGColor.idl:
- svg/SVGComponentTransferFunctionElement.cpp:
- svg/SVGComponentTransferFunctionElement.h:
- svg/SVGComponentTransferFunctionElement.idl:
- svg/SVGCursorElement.cpp:
- svg/SVGCursorElement.h:
- svg/SVGCursorElement.idl:
- svg/SVGDefsElement.cpp:
- svg/SVGDefsElement.h:
- svg/SVGDefsElement.idl:
- svg/SVGDescElement.cpp:
- svg/SVGDescElement.h:
- svg/SVGDescElement.idl:
- svg/SVGDocument.cpp:
- svg/SVGDocument.h:
- svg/SVGDocument.idl:
- svg/SVGDocumentExtensions.cpp:
- svg/SVGDocumentExtensions.h:
- svg/SVGElement.cpp:
- svg/SVGElement.h:
- svg/SVGElement.idl:
- svg/SVGElementInstance.cpp:
- svg/SVGElementInstance.h:
- svg/SVGElementInstance.idl:
- svg/SVGElementInstanceList.cpp:
- svg/SVGElementInstanceList.h:
- svg/SVGElementInstanceList.idl:
- svg/SVGElementRareData.h:
- svg/SVGEllipseElement.cpp:
- svg/SVGEllipseElement.h:
- svg/SVGEllipseElement.idl:
- svg/SVGException.h:
- svg/SVGExternalResourcesRequired.cpp:
- svg/SVGExternalResourcesRequired.h:
- svg/SVGExternalResourcesRequired.idl:
- svg/SVGFEBlendElement.cpp:
- svg/SVGFEBlendElement.h:
- svg/SVGFEBlendElement.idl:
- svg/SVGFEColorMatrixElement.cpp:
- svg/SVGFEColorMatrixElement.h:
- svg/SVGFEColorMatrixElement.idl:
- svg/SVGFEComponentTransferElement.cpp:
- svg/SVGFEComponentTransferElement.h:
- svg/SVGFEComponentTransferElement.idl:
- svg/SVGFECompositeElement.cpp:
- svg/SVGFECompositeElement.h:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEConvolveMatrixElement.cpp:
- svg/SVGFEConvolveMatrixElement.h:
- svg/SVGFEConvolveMatrixElement.idl:
- svg/SVGFEDiffuseLightingElement.cpp:
- svg/SVGFEDiffuseLightingElement.h:
- svg/SVGFEDiffuseLightingElement.idl:
- svg/SVGFEDisplacementMapElement.cpp:
- svg/SVGFEDisplacementMapElement.h:
- svg/SVGFEDisplacementMapElement.idl:
- svg/SVGFEDistantLightElement.cpp:
- svg/SVGFEDistantLightElement.h:
- svg/SVGFEDistantLightElement.idl:
- svg/SVGFEFloodElement.cpp:
- svg/SVGFEFloodElement.h:
- svg/SVGFEFloodElement.idl:
- svg/SVGFEFuncAElement.cpp:
- svg/SVGFEFuncAElement.h:
- svg/SVGFEFuncAElement.idl:
- svg/SVGFEFuncBElement.cpp:
- svg/SVGFEFuncBElement.h:
- svg/SVGFEFuncBElement.idl:
- svg/SVGFEFuncGElement.cpp:
- svg/SVGFEFuncGElement.h:
- svg/SVGFEFuncGElement.idl:
- svg/SVGFEFuncRElement.cpp:
- svg/SVGFEFuncRElement.h:
- svg/SVGFEFuncRElement.idl:
- svg/SVGFEGaussianBlurElement.cpp:
- svg/SVGFEGaussianBlurElement.h:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEImageElement.cpp:
- svg/SVGFEImageElement.h:
- svg/SVGFEImageElement.idl:
- svg/SVGFELightElement.cpp:
- svg/SVGFELightElement.h:
- svg/SVGFEMergeElement.cpp:
- svg/SVGFEMergeElement.h:
- svg/SVGFEMergeElement.idl:
- svg/SVGFEMergeNodeElement.cpp:
- svg/SVGFEMergeNodeElement.h:
- svg/SVGFEMergeNodeElement.idl:
- svg/SVGFEMorphologyElement.cpp:
- svg/SVGFEMorphologyElement.h:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFEOffsetElement.cpp:
- svg/SVGFEOffsetElement.h:
- svg/SVGFEOffsetElement.idl:
- svg/SVGFEPointLightElement.cpp:
- svg/SVGFEPointLightElement.h:
- svg/SVGFEPointLightElement.idl:
- svg/SVGFESpecularLightingElement.cpp:
- svg/SVGFESpecularLightingElement.h:
- svg/SVGFESpecularLightingElement.idl:
- svg/SVGFESpotLightElement.cpp:
- svg/SVGFESpotLightElement.h:
- svg/SVGFESpotLightElement.idl:
- svg/SVGFETileElement.cpp:
- svg/SVGFETileElement.h:
- svg/SVGFETileElement.idl:
- svg/SVGFETurbulenceElement.cpp:
- svg/SVGFETurbulenceElement.h:
- svg/SVGFETurbulenceElement.idl:
- svg/SVGFilterElement.cpp:
- svg/SVGFilterElement.h:
- svg/SVGFilterElement.idl:
- svg/SVGFilterPrimitiveStandardAttributes.cpp:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/SVGFilterPrimitiveStandardAttributes.idl:
- svg/SVGFitToViewBox.cpp:
- svg/SVGFitToViewBox.h:
- svg/SVGFitToViewBox.idl:
- svg/SVGFont.cpp:
- svg/SVGFontData.cpp:
- svg/SVGFontData.h:
- svg/SVGFontElement.cpp:
- svg/SVGFontElement.h:
- svg/SVGFontElement.idl:
- svg/SVGFontFaceElement.cpp:
- svg/SVGFontFaceElement.h:
- svg/SVGFontFaceElement.idl:
- svg/SVGFontFaceFormatElement.cpp:
- svg/SVGFontFaceFormatElement.h:
- svg/SVGFontFaceFormatElement.idl:
- svg/SVGFontFaceNameElement.cpp:
- svg/SVGFontFaceNameElement.h:
- svg/SVGFontFaceNameElement.idl:
- svg/SVGFontFaceSrcElement.cpp:
- svg/SVGFontFaceSrcElement.h:
- svg/SVGFontFaceSrcElement.idl:
- svg/SVGFontFaceUriElement.cpp:
- svg/SVGFontFaceUriElement.h:
- svg/SVGFontFaceUriElement.idl:
- svg/SVGForeignObjectElement.cpp:
- svg/SVGForeignObjectElement.h:
- svg/SVGForeignObjectElement.idl:
- svg/SVGGElement.cpp:
- svg/SVGGElement.h:
- svg/SVGGElement.idl:
- svg/SVGGlyphElement.cpp:
- svg/SVGGlyphElement.h:
- svg/SVGGlyphElement.idl:
- svg/SVGGlyphMap.h:
- svg/SVGGradientElement.cpp:
- svg/SVGGradientElement.h:
- svg/SVGGradientElement.idl:
- svg/SVGHKernElement.cpp:
- svg/SVGHKernElement.h:
- svg/SVGHKernElement.idl:
- svg/SVGImageElement.cpp:
- svg/SVGImageElement.h:
- svg/SVGImageElement.idl:
- svg/SVGImageLoader.cpp:
- svg/SVGImageLoader.h:
- svg/SVGLangSpace.cpp:
- svg/SVGLangSpace.h:
- svg/SVGLangSpace.idl:
- svg/SVGLength.cpp:
- svg/SVGLength.h:
- svg/SVGLength.idl:
- svg/SVGLengthList.cpp:
- svg/SVGLengthList.h:
- svg/SVGLengthList.idl:
- svg/SVGLineElement.cpp:
- svg/SVGLineElement.h:
- svg/SVGLineElement.idl:
- svg/SVGLinearGradientElement.cpp:
- svg/SVGLinearGradientElement.h:
- svg/SVGLinearGradientElement.idl:
- svg/SVGList.h:
- svg/SVGListTraits.h:
- svg/SVGLocatable.cpp:
- svg/SVGLocatable.h:
- svg/SVGLocatable.idl:
- svg/SVGMPathElement.cpp:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.cpp:
- svg/SVGMarkerElement.h:
- svg/SVGMarkerElement.idl:
- svg/SVGMaskElement.cpp:
- svg/SVGMaskElement.h:
- svg/SVGMaskElement.idl:
- svg/SVGMatrix.idl:
- svg/SVGMetadataElement.cpp:
- svg/SVGMetadataElement.h:
- svg/SVGMetadataElement.idl:
- svg/SVGMissingGlyphElement.cpp:
- svg/SVGMissingGlyphElement.h:
- svg/SVGMissingGlyphElement.idl:
- svg/SVGNumber.idl:
- svg/SVGNumberList.cpp:
- svg/SVGNumberList.h:
- svg/SVGNumberList.idl:
- svg/SVGPaint.cpp:
- svg/SVGPaint.h:
- svg/SVGPaint.idl:
- svg/SVGParserUtilities.cpp:
- svg/SVGParserUtilities.h:
- svg/SVGPathBuilder.cpp:
- svg/SVGPathBuilder.h:
- svg/SVGPathConsumer.h:
- svg/SVGPathElement.cpp:
- svg/SVGPathElement.h:
- svg/SVGPathElement.idl:
- svg/SVGPathParser.cpp:
- svg/SVGPathParser.h:
- svg/SVGPathSeg.h:
- svg/SVGPathSeg.idl:
- svg/SVGPathSegArc.cpp:
- svg/SVGPathSegArc.h:
- svg/SVGPathSegArcAbs.idl:
- svg/SVGPathSegArcRel.idl:
- svg/SVGPathSegClosePath.cpp:
- svg/SVGPathSegClosePath.h:
- svg/SVGPathSegClosePath.idl:
- svg/SVGPathSegCurvetoCubic.cpp:
- svg/SVGPathSegCurvetoCubic.h:
- svg/SVGPathSegCurvetoCubicAbs.idl:
- svg/SVGPathSegCurvetoCubicRel.idl:
- svg/SVGPathSegCurvetoCubicSmooth.cpp:
- svg/SVGPathSegCurvetoCubicSmooth.h:
- svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
- svg/SVGPathSegCurvetoCubicSmoothRel.idl:
- svg/SVGPathSegCurvetoQuadratic.cpp:
- svg/SVGPathSegCurvetoQuadratic.h:
- svg/SVGPathSegCurvetoQuadraticAbs.idl:
- svg/SVGPathSegCurvetoQuadraticRel.idl:
- svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
- svg/SVGPathSegCurvetoQuadraticSmooth.h:
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
- svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
- svg/SVGPathSegLineto.cpp:
- svg/SVGPathSegLineto.h:
- svg/SVGPathSegLinetoAbs.idl:
- svg/SVGPathSegLinetoHorizontal.cpp:
- svg/SVGPathSegLinetoHorizontal.h:
- svg/SVGPathSegLinetoHorizontalAbs.idl:
- svg/SVGPathSegLinetoHorizontalRel.idl:
- svg/SVGPathSegLinetoRel.idl:
- svg/SVGPathSegLinetoVertical.cpp:
- svg/SVGPathSegLinetoVertical.h:
- svg/SVGPathSegLinetoVerticalAbs.idl:
- svg/SVGPathSegLinetoVerticalRel.idl:
- svg/SVGPathSegList.cpp:
- svg/SVGPathSegList.h:
- svg/SVGPathSegList.idl:
- svg/SVGPathSegListBuilder.cpp:
- svg/SVGPathSegListBuilder.h:
- svg/SVGPathSegMoveto.cpp:
- svg/SVGPathSegMoveto.h:
- svg/SVGPathSegMovetoAbs.idl:
- svg/SVGPathSegMovetoRel.idl:
- svg/SVGPatternElement.cpp:
- svg/SVGPatternElement.h:
- svg/SVGPatternElement.idl:
- svg/SVGPoint.idl:
- svg/SVGPointList.cpp:
- svg/SVGPointList.h:
- svg/SVGPointList.idl:
- svg/SVGPolyElement.cpp:
- svg/SVGPolyElement.h:
- svg/SVGPolygonElement.cpp:
- svg/SVGPolygonElement.h:
- svg/SVGPolygonElement.idl:
- svg/SVGPolylineElement.cpp:
- svg/SVGPolylineElement.h:
- svg/SVGPolylineElement.idl:
- svg/SVGPreserveAspectRatio.cpp:
- svg/SVGPreserveAspectRatio.h:
- svg/SVGPreserveAspectRatio.idl:
- svg/SVGRadialGradientElement.cpp:
- svg/SVGRadialGradientElement.h:
- svg/SVGRadialGradientElement.idl:
- svg/SVGRect.idl:
- svg/SVGRectElement.cpp:
- svg/SVGRectElement.h:
- svg/SVGRectElement.idl:
- svg/SVGRenderingIntent.h:
- svg/SVGRenderingIntent.idl:
- svg/SVGSVGElement.cpp:
- svg/SVGSVGElement.h:
- svg/SVGSVGElement.idl:
- svg/SVGScriptElement.cpp:
- svg/SVGScriptElement.h:
- svg/SVGScriptElement.idl:
- svg/SVGSetElement.cpp:
- svg/SVGSetElement.h:
- svg/SVGSetElement.idl:
- svg/SVGStopElement.cpp:
- svg/SVGStopElement.h:
- svg/SVGStopElement.idl:
- svg/SVGStringList.cpp:
- svg/SVGStringList.h:
- svg/SVGStringList.idl:
- svg/SVGStylable.cpp:
- svg/SVGStylable.h:
- svg/SVGStylable.idl:
- svg/SVGStyleElement.cpp:
- svg/SVGStyleElement.h:
- svg/SVGStyleElement.idl:
- svg/SVGStyledElement.cpp:
- svg/SVGStyledElement.h:
- svg/SVGStyledLocatableElement.cpp:
- svg/SVGStyledLocatableElement.h:
- svg/SVGStyledTransformableElement.cpp:
- svg/SVGStyledTransformableElement.h:
- svg/SVGSwitchElement.cpp:
- svg/SVGSwitchElement.h:
- svg/SVGSwitchElement.idl:
- svg/SVGSymbolElement.cpp:
- svg/SVGSymbolElement.h:
- svg/SVGSymbolElement.idl:
- svg/SVGTRefElement.cpp:
- svg/SVGTRefElement.h:
- svg/SVGTRefElement.idl:
- svg/SVGTSpanElement.cpp:
- svg/SVGTSpanElement.h:
- svg/SVGTSpanElement.idl:
- svg/SVGTests.cpp:
- svg/SVGTests.h:
- svg/SVGTests.idl:
- svg/SVGTextContentElement.cpp:
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTextElement.cpp:
- svg/SVGTextElement.h:
- svg/SVGTextElement.idl:
- svg/SVGTextPathElement.cpp:
- svg/SVGTextPathElement.h:
- svg/SVGTextPathElement.idl:
- svg/SVGTextPositioningElement.cpp:
- svg/SVGTextPositioningElement.h:
- svg/SVGTextPositioningElement.idl:
- svg/SVGTitleElement.cpp:
- svg/SVGTitleElement.h:
- svg/SVGTitleElement.idl:
- svg/SVGTransform.cpp:
- svg/SVGTransform.h:
- svg/SVGTransform.idl:
- svg/SVGTransformDistance.cpp:
- svg/SVGTransformDistance.h:
- svg/SVGTransformList.cpp:
- svg/SVGTransformList.h:
- svg/SVGTransformList.idl:
- svg/SVGTransformable.cpp:
- svg/SVGTransformable.h:
- svg/SVGTransformable.idl:
- svg/SVGURIReference.cpp:
- svg/SVGURIReference.h:
- svg/SVGURIReference.idl:
- svg/SVGUnitTypes.h:
- svg/SVGUnitTypes.idl:
- svg/SVGUseElement.cpp:
- svg/SVGUseElement.h:
- svg/SVGUseElement.idl:
- svg/SVGVKernElement.cpp:
- svg/SVGVKernElement.h:
- svg/SVGVKernElement.idl:
- svg/SVGViewElement.cpp:
- svg/SVGViewElement.h:
- svg/SVGViewElement.idl:
- svg/SVGViewSpec.cpp:
- svg/SVGViewSpec.h:
- svg/SVGViewSpec.idl:
- svg/SVGZoomAndPan.cpp:
- svg/SVGZoomAndPan.h:
- svg/SVGZoomAndPan.idl:
- svg/SVGZoomEvent.cpp:
- svg/SVGZoomEvent.h:
- svg/SVGZoomEvent.idl:
- svg/animation/SMILTime.cpp:
- svg/animation/SMILTime.h:
- svg/animation/SMILTimeContainer.cpp:
- svg/animation/SMILTimeContainer.h:
- svg/animation/SVGSMILElement.cpp:
- svg/animation/SVGSMILElement.h:
- svg/graphics/SVGImage.cpp:
- svg/graphics/SVGImage.h:
- svg/graphics/filters/SVGDistantLightSource.h:
- svg/graphics/filters/SVGFEConvolveMatrix.cpp:
- svg/graphics/filters/SVGFEConvolveMatrix.h:
- svg/graphics/filters/SVGFEDiffuseLighting.cpp:
- svg/graphics/filters/SVGFEDiffuseLighting.h:
- svg/graphics/filters/SVGFEDisplacementMap.cpp:
- svg/graphics/filters/SVGFEDisplacementMap.h:
- svg/graphics/filters/SVGFEFlood.cpp:
- svg/graphics/filters/SVGFEFlood.h:
- svg/graphics/filters/SVGFEImage.cpp:
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFELighting.cpp:
- svg/graphics/filters/SVGFELighting.h:
- svg/graphics/filters/SVGFEMerge.cpp:
- svg/graphics/filters/SVGFEMerge.h:
- svg/graphics/filters/SVGFEMorphology.cpp:
- svg/graphics/filters/SVGFEMorphology.h:
- svg/graphics/filters/SVGFEOffset.cpp:
- svg/graphics/filters/SVGFEOffset.h:
- svg/graphics/filters/SVGFESpecularLighting.cpp:
- svg/graphics/filters/SVGFESpecularLighting.h:
- svg/graphics/filters/SVGFETile.cpp:
- svg/graphics/filters/SVGFETile.h:
- svg/graphics/filters/SVGFETurbulence.cpp:
- svg/graphics/filters/SVGFETurbulence.h:
- svg/graphics/filters/SVGFilter.cpp:
- svg/graphics/filters/SVGFilter.h:
- svg/graphics/filters/SVGFilterBuilder.cpp:
- svg/graphics/filters/SVGFilterBuilder.h:
- svg/graphics/filters/SVGLightSource.cpp:
- svg/graphics/filters/SVGLightSource.h:
- svg/graphics/filters/SVGPointLightSource.h:
- svg/graphics/filters/SVGSpotLightSource.h:
- 5:36 AM Changeset in webkit [64545] by
-
- 2 edits in trunk/WebKit2
2010-08-03 Balazs Kelemen <kb@inf.u-szeged.hu>
[Qt] Unreviewed typo fix in the WebKit2/DerivedSources.pro project file.
Use QMAKE_MKDIR as the command for directory creation.
- DerivedSources.pro:
- 4:59 AM WebKit Team edited by
- (diff)
- 4:08 AM Changeset in webkit [64544] by
-
- 2 edits in trunk/WebCore
2010-08-03 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
[IndexedDB] Chromium build is broken due to typo in WebCore.gypi:3501
https://bugs.webkit.org/show_bug.cgi?id=43408
Add missing ' in WebCore.gypi:3501.
- WebCore.gypi:
- 3:43 AM Changeset in webkit [64543] by
-
- 30 edits1 copy4 moves1 delete in trunk
2010-07-30 Andrei Popescu <andreip@dhcp-172-16-14-12.lon.corp.google.com>
Reviewed by Jeremy Orlow.
Rename IDBDatabaseRequest to IDBDatabase
https://bugs.webkit.org/show_bug.cgi?id=43250
No new tests, just refactoring.
- Android.derived.jscbindings.mk:
- Android.derived.v8bindings.mk:
- Android.mk:
- CMakeLists.txt:
- DerivedSources.cpp:
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pri:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCore.vcproj~: Added.
- WebCore.xcodeproj/project.pbxproj:
- WebCore.xcodeproj/project.pbxproj~: Added.
- bindings/js/JSIDBAnyCustom.cpp: (WebCore::toJS):
- bindings/v8/custom/V8IDBAnyCustom.cpp: (WebCore::toV8):
- storage/IDBAny.cpp: (WebCore::IDBAny::idbDatabase): (WebCore::IDBAny::set):
- storage/IDBAny.h: (WebCore::IDBAny::):
- storage/IDBCallbacks.h:
- storage/IDBDatabase.cpp: Added. (WebCore::IDBDatabase::IDBDatabase): (WebCore::IDBDatabase::~IDBDatabase): (WebCore::IDBDatabase::createObjectStore): (WebCore::IDBDatabase::objectStore): (WebCore::IDBDatabase::removeObjectStore):
- storage/IDBDatabase.h: (WebCore::IDBDatabase::create): (WebCore::IDBDatabase::name): (WebCore::IDBDatabase::description): (WebCore::IDBDatabase::version): (WebCore::IDBDatabase::objectStores):
- storage/IDBDatabase.idl: Added.
- storage/IDBDatabaseBackendImpl.cpp: Added. (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::objectStores): (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::objectStore): (WebCore::IDBDatabaseBackendImpl::removeObjectStore):
- storage/IDBDatabaseBackendImpl.h: Added. (WebCore::IDBDatabaseBackendImpl::create): (WebCore::IDBDatabaseBackendImpl::name): (WebCore::IDBDatabaseBackendImpl::description): (WebCore::IDBDatabaseBackendImpl::version):
- storage/IDBDatabaseBackendInterface.h: Added. (WebCore::IDBDatabaseBackendInterface::~IDBDatabaseBackendInterface):
- storage/IDBDatabaseImpl.cpp: Removed.
- storage/IDBDatabaseImpl.h: Removed.
- storage/IDBDatabaseRequest.cpp: Removed.
- storage/IDBDatabaseRequest.h: Removed.
- storage/IDBDatabaseRequest.idl: Removed.
- storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open):
- storage/IDBFactoryBackendImpl.h:
- storage/IDBRequest.cpp: (WebCore::IDBRequest::onSuccess):
- storage/IDBRequest.h:
2010-07-30 Andrei Popescu <andreip@dhcp-172-16-14-12.lon.corp.google.com>
Reviewed by Jeremy Orlow.
Rename IDBDatabaseRequest to IDBDatabase
https://bugs.webkit.org/show_bug.cgi?id=43250
- src/IDBCallbacksProxy.cpp: (WebCore::IDBCallbacksProxy::onSuccess):
- src/IDBCallbacksProxy.h:
- src/IDBDatabaseProxy.cpp: (WebCore::IDBDatabaseProxy::create):
- src/IDBDatabaseProxy.h:
- src/WebIDBDatabaseImpl.cpp: (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl): (WebKit::WebIDBDatabaseImpl::name): (WebKit::WebIDBDatabaseImpl::description): (WebKit::WebIDBDatabaseImpl::version): (WebKit::WebIDBDatabaseImpl::objectStores): (WebKit::WebIDBDatabaseImpl::createObjectStore): (WebKit::WebIDBDatabaseImpl::objectStore): (WebKit::WebIDBDatabaseImpl::removeObjectStore):
- src/WebIDBDatabaseImpl.h:
- 3:12 AM Changeset in webkit [64542] by
-
- 2 edits in trunk/WebCore
2010-08-03 Satish Sampath <satish@chromium.org>
Reviewed by Kent Tamura.
Initiate speech input requests on click event
https://bugs.webkit.org/show_bug.cgi?id=43352
- rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
- 2:54 AM Changeset in webkit [64541] by
-
- 2 edits in trunk/LayoutTests
2010-08-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Chromium test expectations update.
- platform/chromium/test_expectations.txt:
- 2:33 AM Changeset in webkit [64540] by
-
- 11 edits in trunk/WebCore
2010-08-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger code should serialize call frames to InspectorObjects instead of SerializedScriptValues.
https://bugs.webkit.org/show_bug.cgi?id=43339
No new tests. Refactoring.
- inspector/InjectedScript.cpp: (WebCore::InjectedScript::callFrames):
- inspector/InjectedScript.h:
- inspector/Inspector.idl:
- inspector/InspectorController.cpp: (WebCore::InspectorController::editScriptSource): (WebCore::InspectorController::getScriptSource): (WebCore::InspectorController::currentCallFrames): (WebCore::InspectorController::didPause):
- inspector/InspectorController.h:
- inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
- 2:21 AM Changeset in webkit [64539] by
-
- 480 edits in trunk/WebCore
2010-08-03 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Cleanup all of svg/ code
https://bugs.webkit.org/show_bug.cgi?id=43311
Unify the license header in all files in svg/, to use the same template as most WebCore files use.
Unified email adress style, etc. all generated with a perl script attached to bug 43311.i
- svg/...: Updated header template in all files, in the svg/ subdirectory.
- 2:11 AM Changeset in webkit [64538] by
-
- 2 edits in trunk/LayoutTests
2010-08-03 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Upstreaming test_expectations.
- platform/chromium/test_expectations.txt:
- 2:04 AM Changeset in webkit [64537] by
-
- 40 edits11 adds in trunk
WebCore: Turn all callbacks into ActiveDOMObjects and create callbacks in the correct context.
https://bugs.webkit.org/show_bug.cgi?id=40112
Reviewed by Adam Barth.
Test: http/tests/storage/callbacks-are-called-in-correct-context.html
- CMakeLists.txt: Added new files.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.gypi:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/generic/ActiveDOMCallback.cpp: Added. The base class
for all callbacks, that behaves like an ActiveDOMObject.
(WebCore::DestroyOnContextThreadTask::create):
(WebCore::DestroyOnContextThreadTask::performTask):
(WebCore::DestroyOnContextThreadTask::DestroyOnContextThreadTask):
(WebCore::ActiveDOMObjectCallbackImpl::ActiveDOMObjectCallbackImpl):
(WebCore::ActiveDOMObjectCallbackImpl::contextDestroyed):
(WebCore::ActiveDOMObjectCallbackImpl::canSuspend):
(WebCore::ActiveDOMObjectCallbackImpl::suspend):
(WebCore::ActiveDOMObjectCallbackImpl::resume):
(WebCore::ActiveDOMObjectCallbackImpl::stop):
(WebCore::ActiveDOMObjectCallbackImpl::canInvokeCallback):
(WebCore::ActiveDOMObjectCallbackImpl::scriptExecutionContext):
(WebCore::ActiveDOMObjectCallbackImpl::mutex):
(WebCore::destroyOnContextThread):
(WebCore::ActiveDOMCallback::ActiveDOMCallback):
(WebCore::ActiveDOMCallback::~ActiveDOMCallback):
(WebCore::ActiveDOMCallback::canInvokeCallback):
(WebCore::ActiveDOMCallback::scriptExecutionContext):
- bindings/generic/ActiveDOMCallback.h: Added.
- bindings/js/JSCustomSQLStatementErrorCallback.cpp: Pass the
right ScriptExecutionContext to the JSC callbacks.
(WebCore::JSSQLStatementErrorCallback::handleEvent):
- bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
- bindings/scripts/CodeGeneratorJS.pm: Make all callbacks inherit
from ActiveDOMCallback, and make them use the right
ScriptExecutionContext.
- bindings/scripts/CodeGeneratorV8.pm:
- bindings/scripts/test/JS/JSTestCallback.cpp: Update the
expectations for the code generated by CodeGenerator{JS|V8}.pm.
(WebCore::JSTestCallback::JSTestCallback):
(WebCore::JSTestCallback::~JSTestCallback):
(WebCore::JSTestCallback::callbackWithClass1Param):
(WebCore::JSTestCallback::callbackWithClass2Param):
- bindings/scripts/test/JS/JSTestCallback.h:
- bindings/scripts/test/V8/V8TestCallback.cpp:
(WebCore::V8TestCallback::V8TestCallback):
(WebCore::V8TestCallback::callbackWithClass1Param):
(WebCore::V8TestCallback::callbackWithClass2Param):
- bindings/scripts/test/V8/V8TestCallback.h:
(WebCore::V8TestCallback::create):
- bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::methodWithCallbackArgCallback):
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback):
(WebCore::TestObjInternal::methodWithCallbackAndOptionalArgCallback):
- bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: Pass
the right ScriptExecutionContext to the V8 callbacks.
(WebCore::V8SQLStatementErrorCallback::handleEvent):
- bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::openDatabaseCallback):
- bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
(WebCore::createTransaction):
- bindings/v8/custom/V8SQLTransactionCustom.cpp:
(WebCore::V8SQLTransaction::executeSqlCallback):
- bindings/v8/custom/V8WorkerContextCustom.cpp:
(WebCore::V8WorkerContext::openDatabaseCallback):
(WebCore::V8WorkerContext::openDatabaseSyncCallback):
- dom/ActiveDOMObject.cpp: Simplify the code.
(WebCore::ActiveDOMObject::ActiveDOMObject):
(WebCore::ActiveDOMObject::~ActiveDOMObject):
- storage/Database.cpp: CallbackClass::handleEvent() doesn't take
a ScriptExecutionContext anymore.
(WebCore::DatabaseCreationCallbackTask::performTask):
- storage/DatabaseCallback.h:
- storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::openDatabaseSync):
- storage/EntryCallback.h:
- storage/ErrorCallback.h:
- storage/FileSystemCallback.h:
- storage/MetadataCallback.h:
- storage/SQLStatement.cpp:
(WebCore::SQLStatement::performCallback):
- storage/SQLStatementCallback.h:
- storage/SQLStatementErrorCallback.h:
- storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverTransactionErrorCallback):
- storage/SQLTransactionCallback.h:
- storage/SQLTransactionErrorCallback.h:
- storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::execute):
- storage/SQLTransactionSyncCallback.h:
LayoutTests: Make sure all DB callbacks run in the correct context.
https://bugs.webkit.org/show_bug.cgi?id=40112
Reviewed by Adam Barth.
- http/tests/storage: Added.
- http/tests/storage/callbacks-are-called-in-correct-context-expected.txt: Added.
- http/tests/storage/callbacks-are-called-in-correct-context.html: Added.
- http/tests/storage/resources: Added.
- http/tests/storage/resources/callbacks-are-called-in-correct-context-first-frame.html: Added.
- http/tests/storage/resources/callbacks-are-called-in-correct-context-output-frame.html: Added.
- http/tests/storage/resources/callbacks-are-called-in-correct-context-second-frame.html: Added.
- http/tests/storage/resources/callbacks-are-called-in-correct-context-third-frame.html: Added.
- http/tests/storage/resources/callbacks-are-called-in-correct-context.cgi: Added.
- 1:57 AM Changeset in webkit [64536] by
-
- 6 edits in trunk/WebCore
2010-08-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: Trivial InspectorBackend functions were removed.
And now it is bit simpler to change Inspector API because we have
less number of abstraction layers.
https://bugs.webkit.org/show_bug.cgi?id=43402
- inspector/CodeGeneratorInspector.pm:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::clearConsoleMessages): (WebCore::InspectorBackend::releaseWrapperObjectGroup): (WebCore::InspectorBackend::inspectorFrontend): (WebCore::InspectorBackend::remoteFrontend):
- inspector/InspectorBackend.h: (WebCore::InspectorBackend::inspectorDOMAgent): (WebCore::InspectorBackend::inspectorApplicationCacheAgent):
- inspector/InspectorController.h:
- 1:32 AM Changeset in webkit [64535] by
-
- 2 edits in trunk/WebCore
Unreviewed (emergency test fix).
REGRESSION (r64518): Most regression tests fail on ASSERT(shouldTrackVisitedLinks)
on Snow Leopard.
Platforms that use strategies now use a different code path than others, and that code path
lacks necessary checks. We don't have a Snow Leopard debug buildbot.
- page/PageGroup.cpp: (WebCore::PageGroup::addVisitedLinkHash): The private version of addVisitedLink() must not be called when we're not tracking visited links.
- 12:36 AM Changeset in webkit [64534] by
-
- 35 edits10 deletes in trunk
2010-08-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: Get rid of DevTools RPC.
- bindings/js/ScriptProfiler.h: (WebCore::ScriptProfiler::getProfilerLogLines):
- bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::getProfilerLogLines):
- bindings/v8/ScriptProfiler.h:
- inspector/Inspector.idl:
- inspector/InspectorBackend.cpp: (WebCore::InspectorBackend::takeHeapSnapshot): (WebCore::InspectorBackend::getProfilerLogLines):
- inspector/InspectorBackend.h:
- inspector/InspectorController.cpp: (WebCore::InspectorController::disableProfiler):
- inspector/InspectorController.h:
- inspector/InspectorFrontend.h:
- inspector/front-end/InspectorBackendStub.js: (WebInspector.InspectorBackendStub):
2010-08-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: Get rid of DevTools RPC.
- WebKit.gyp:
- public/WebDevToolsAgent.h:
- public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::sendMessageToInspectorFrontend): (WebKit::WebDevToolsAgentClient::sendDebuggerOutput): (WebKit::WebDevToolsAgentClient::sendDispatchToAPU):
- public/WebDevToolsFrontend.h:
- public/WebDevToolsFrontendClient.h: (WebKit::WebDevToolsFrontendClient::sendMessageToBackend):
- public/WebDevToolsMessageData.h: Removed.
- public/WebDevToolsMessageTransport.h: Removed.
- src/APUAgentDelegate.h: Removed.
- src/DebuggerAgent.h: Removed.
- src/DebuggerAgentImpl.cpp: (WebKit::DebuggerAgentImpl::DebuggerAgentImpl): (WebKit::DebuggerAgentImpl::debuggerOutput):
- src/DebuggerAgentImpl.h:
- src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugDetach): (WebKit::DebuggerAgentManager::onV8DebugMessage): (WebKit::DebuggerAgentManager::executeDebuggerCommand): (WebKit::DebuggerAgentManager::sendCommandToV8): (WebKit::DebuggerAgentManager::sendContinueCommandToV8):
- src/DevToolsRPC.h: Removed.
- src/DevToolsRPCJS.h: Removed.
- src/InspectorClientImpl.cpp:
- src/InspectorFrontendClientImpl.cpp: (WebKit::InspectorFrontendClientImpl::sendMessageToBackend):
- src/ProfilerAgent.h: Removed.
- src/ProfilerAgentImpl.cpp: Removed.
- src/ProfilerAgentImpl.h: Removed.
- src/ToolsAgent.h: Removed.
- src/WebDevToolsAgentImpl.cpp: (WebKit::): (WebKit::WebDevToolsAgentImpl::WebDevToolsAgentImpl): (WebKit::WebDevToolsAgentImpl::attach): (WebKit::WebDevToolsAgentImpl::didClearWindowObject): (WebKit::WebDevToolsAgentImpl::dispatchOnInspectorBackend): (WebKit::WebDevToolsAgentImpl::jsDispatchOnClient): (WebKit::WebDevToolsAgentImpl::sendMessageToFrontend):
- src/WebDevToolsAgentImpl.h:
- src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend): (WebKit::WebDevToolsFrontendImpl::frontendLoaded): (WebKit::WebDevToolsFrontendImpl::executeScript):
- src/WebDevToolsFrontendImpl.h:
- src/js/DevTools.js: (devtools.dispatch): (devtools.ToolsAgent):
- src/js/DevToolsHostStub.js:
- src/js/ProfilerAgent.js: (devtools.ProfilerAgent):
2010-08-02 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: Get rid of DevTools RPC.
- DumpRenderTree/chromium/DRTDevToolsAgent.cpp: (DRTDevToolsAgent::sendMessageToInspectorFrontend): (DRTDevToolsAgent::call):
- DumpRenderTree/chromium/DRTDevToolsAgent.h:
- DumpRenderTree/chromium/DRTDevToolsCallArgs.h: (DRTDevToolsCallArgs::DRTDevToolsCallArgs):
- DumpRenderTree/chromium/DRTDevToolsClient.cpp: (DRTDevToolsClient::sendMessageToBackend): (DRTDevToolsClient::call):
- DumpRenderTree/chromium/DRTDevToolsClient.h:
- 12:14 AM Changeset in webkit [64533] by
-
- 2 edits in trunk/LayoutTests
2010-08-03 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update for DRT/Chromium.
- platform/chromium/drt_expectations.txt:
