Timeline



Nov 8, 2010:

11:48 PM Changeset in webkit [71610] by commit-queue@webkit.org
  • 3 edits in trunk/WebKit/chromium

2010-11-08 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Convert to and from DOMTimeStamp with converter functions
https://bugs.webkit.org/show_bug.cgi?id=49066

  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::triggeringEventTime):
11:07 PM Changeset in webkit [71609] by rniwa@webkit.org
  • 67 edits
    1 add in trunk/LayoutTests

2010-11-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Chromium rebaselines for r71465.

  • platform/chromium-linux/editing/pasteboard/4806874-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4806874-expected.png:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/input-field-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-linux/editing/selection/4397952-expected.checksum:
  • platform/chromium-linux/editing/selection/4397952-expected.png:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-linux/editing/selection/caret-before-select-expected.png:
  • platform/chromium-linux/editing/selection/click-start-of-line-expected.checksum:
  • platform/chromium-linux/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-linux/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/text/delete-hard-break-character-expected.checksum:
  • platform/chromium-linux/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium-win/editing/pasteboard/4806874-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4806874-expected.png:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
  • platform/chromium-win/editing/selection/4397952-expected.checksum:
  • platform/chromium-win/editing/selection/4397952-expected.png:
  • platform/chromium-win/editing/selection/after-line-break-expected.txt: Added.
  • platform/chromium-win/editing/selection/caret-before-select-expected.checksum:
  • platform/chromium-win/editing/selection/caret-before-select-expected.png:
  • platform/chromium-win/editing/selection/click-start-of-line-expected.checksum:
  • platform/chromium-win/editing/selection/click-start-of-line-expected.png:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
  • platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
  • platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/chromium-win/fast/text/delete-hard-break-character-expected.checksum:
  • platform/chromium-win/fast/text/delete-hard-break-character-expected.png:
  • platform/chromium/test_expectations.txt:
  • platform/mac/editing/pasteboard/4806874-expected.checksum:
  • platform/mac/editing/pasteboard/4806874-expected.png:
  • platform/mac/editing/pasteboard/4944770-1-expected.checksum:
  • platform/mac/editing/pasteboard/4944770-1-expected.png:
  • platform/mac/editing/pasteboard/input-field-1-expected.checksum:
  • platform/mac/editing/pasteboard/input-field-1-expected.png:
  • platform/mac/editing/selection/4397952-expected.checksum:
  • platform/mac/editing/selection/4397952-expected.png:
  • platform/mac/editing/selection/caret-before-select-expected.checksum:
  • platform/mac/editing/selection/caret-before-select-expected.png:
  • platform/mac/editing/selection/extend-by-word-002-expected.checksum:
  • platform/mac/editing/selection/extend-by-word-002-expected.png:
  • platform/mac/editing/selection/select-element-paragraph-boundary-expected.checksum:
  • platform/mac/editing/selection/select-element-paragraph-boundary-expected.png:
11:02 PM Changeset in webkit [71608] by commit-queue@webkit.org
  • 10 edits in trunk

2010-11-08 James Simonsen <simonjam@chromium.org>

Reviewed by Dimitri Glazkov.

[Web Timing] Split domContentLoaded into start/end
https://bugs.webkit.org/show_bug.cgi?id=48920

  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): (checkTimingWhileDeferred): (checkWebTimingOnDOMContentLoaded): Added. (checkWebTimingWhileAsync): (checkWebTimingOnLoad): (checkWebTimingAfterLoad):
  • fast/dom/webtiming-document-open-expected.txt:
  • fast/dom/webtiming-expected.txt:

2010-11-08 James Simonsen <simonjam@chromium.org>

Reviewed by Dimitri Glazkov.

[Web Timing] Split domContentLoaded into start/end
https://bugs.webkit.org/show_bug.cgi?id=48920

  • dom/Document.cpp: (WebCore::Document::finishedParsing):
  • dom/DocumentTiming.h: (WebCore::DocumentTiming::DocumentTiming):
  • page/Timing.cpp: (WebCore::Timing::domContentLoadedStart): (WebCore::Timing::domContentLoadedEnd):
  • page/Timing.h:
  • page/Timing.idl:
10:19 PM Changeset in webkit [71607] by abarth@webkit.org
  • 2 edits in trunk/BugsSite

2010-11-08 Adam Barth <abarth@webkit.org>

Update help text to match behavior change.

  • code-review.js:
10:15 PM Changeset in webkit [71606] by Nate Chapin
  • 2 edits in trunk/WebCore

2010-11-08 Nate Chapin <Nate Chapin>

Reviewed by Adam Barth.

Call ApplicationCacheHost::maybeLoadResource() in
ResourceLoader::start() instead of ResourceLoader::load().
maybeLoadResource() might mutate the ResourceRequest, and
in its current location any modifications are lost.

https://bugs.webkit.org/show_bug.cgi?id=49221

Fixes a couple of http/tests/appcache tests
failing on chromium.

  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::start):
9:23 PM Changeset in webkit [71605] by chang.shu@nokia.com
  • 4 edits in trunk

2010-11-08 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Unskip test that is passing now.
https://bugs.webkit.org/show_bug.cgi?id=49150

  • platform/gtk/Skipped:

2010-11-08 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

[GTK] Use Space to toggle arrow key handling for selection change or
spatial navigation. Put the logic in common code to pass both Qt and
GTK. Mac won't work because arrow keys trigger the popup.
https://bugs.webkit.org/show_bug.cgi?id=49150

Existing test: fast/events/spatial-navigation/snav-single-select.html

  • dom/SelectElement.cpp: (WebCore::SelectElement::menuListDefaultEventHandler):
9:05 PM Changeset in webkit [71604] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Link with target name set does not work
https://bugs.webkit.org/show_bug.cgi?id=48865

When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • WebCoreSupport/InspectorClientGtk.cpp: (WebKit::InspectorClient::openInspectorFrontend):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init):

2010-11-08 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Link with target name set does not work
https://bugs.webkit.org/show_bug.cgi?id=48865

When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
8:47 PM Changeset in webkit [71603] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-08 Jenn Braithwaite <jennb@chromium.org>

Reviewed by Pavel Feldman.

_bindResourceURL in ResourceManager.js may not add resource to map
https://bugs.webkit.org/show_bug.cgi?id=49088

No new tests. pfeldman working on better test harness and tests.

  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype._bindResourceURL):
8:14 PM Changeset in webkit [71602] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

2010-11-08 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Convert to and from DOMTimeStamp with converter functions.
This is a refactoring only, covered by existing layout tests.
https://bugs.webkit.org/show_bug.cgi?id=49066

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMTimeStamp.h: Added. (WebCore::convertSecondsToDOMTimeStamp): (WebCore::convertDOMTimeStampToSeconds):
  • dom/Event.cpp: (WebCore::Event::Event):
  • dom/Event.h:
  • page/Geolocation.cpp: (WebCore::Geolocation::haveSuitableCachedPosition):
  • platform/android/GeolocationServiceAndroid.cpp: (WebCore::GeolocationServiceAndroid::isPositionMoreTimely):

2010-11-08 John Knottenbelt <jknotten@chromium.org>

Reviewed by Steve Block.

Convert to and from DOMTimeStamp with converter functions
https://bugs.webkit.org/show_bug.cgi?id=49066

  • src/WebDataSourceImpl.cpp: (WebKit::WebDataSourceImpl::triggeringEventTime):
8:14 PM Changeset in webkit [71601] by rniwa@webkit.org
  • 238 edits in trunk/LayoutTests

2010-11-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed. Rebaselines for r71589.

  • platform/chromium-linux/editing/deleting/5156801-2-expected.checksum:
  • platform/chromium-linux/editing/deleting/5156801-2-expected.png:
  • platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-linux/editing/deleting/delete-br-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-linux/editing/deleting/delete-br-004-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-linux/editing/deleting/delete-br-005-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-linux/editing/deleting/delete-line-003-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-line-003-expected.png:
  • platform/chromium-linux/editing/deleting/delete-tab-004-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-linux/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-linux/editing/execCommand/5482023-expected.checksum:
  • platform/chromium-linux/editing/execCommand/5482023-expected.png:
  • platform/chromium-linux/editing/inserting/4960120-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/4960120-2-expected.png:
  • platform/chromium-linux/editing/inserting/5549929-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/5549929-2-expected.png:
  • platform/chromium-linux/editing/inserting/5549929-3-expected.checksum:
  • platform/chromium-linux/editing/inserting/5549929-3-expected.png:
  • platform/chromium-linux/editing/inserting/editable-inline-element-expected.checksum:
  • platform/chromium-linux/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3654864-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3786362-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-006-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-008-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-009-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-linux/editing/inserting/insert-tab-004-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-linux/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-linux/editing/inserting/line-break-expected.checksum:
  • platform/chromium-linux/editing/inserting/line-break-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • platform/chromium-linux/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-linux/editing/inserting/typing-003-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-003-expected.png:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-linux/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/4989774-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/4989774-expected.png:
  • platform/chromium-linux/editing/pasteboard/5028447-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5028447-expected.png:
  • platform/chromium-linux/editing/pasteboard/5601583-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-1-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-1-expected.png:
  • platform/chromium-linux/editing/pasteboard/merge-end-2-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/merge-end-2-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-table-003-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-table-003-expected.png:
  • platform/chromium-linux/editing/pasteboard/paste-text-010-expected.checksum:
  • platform/chromium-linux/editing/pasteboard/paste-text-010-expected.png:
  • platform/chromium-linux/editing/selection/5007143-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5007143-2-expected.png:
  • platform/chromium-linux/editing/selection/5007143-expected.checksum:
  • platform/chromium-linux/editing/selection/5007143-expected.png:
  • platform/chromium-linux/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-linux/editing/selection/5234383-2-expected.png:
  • platform/chromium-linux/editing/selection/editable-html-element-expected.checksum:
  • platform/chromium-linux/editing/selection/editable-html-element-expected.png:
  • platform/chromium-linux/editing/selection/move-3875618-fix-expected.checksum:
  • platform/chromium-linux/editing/selection/move-3875618-fix-expected.png:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-linux/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-002-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-linux/editing/selection/move-by-character-003-expected.checksum:
  • platform/chromium-linux/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-linux/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-linux/editing/selection/selection-3748164-fix-expected.checksum:
  • platform/chromium-linux/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.checksum:
  • platform/chromium-linux/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.checksum:
  • platform/chromium-linux/editing/unsupported-content/table-delete-003-expected.png:
  • platform/chromium-win/editing/deleting/5156801-2-expected.checksum:
  • platform/chromium-win/editing/deleting/5156801-2-expected.png:
  • platform/chromium-win/editing/deleting/delete-3608445-fix-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-3608445-fix-expected.png:
  • platform/chromium-win/editing/deleting/delete-br-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-br-002-expected.png:
  • platform/chromium-win/editing/deleting/delete-br-004-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-br-004-expected.png:
  • platform/chromium-win/editing/deleting/delete-br-005-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-br-005-expected.png:
  • platform/chromium-win/editing/deleting/delete-line-003-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-line-003-expected.png:
  • platform/chromium-win/editing/deleting/delete-tab-004-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-tab-004-expected.png:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.checksum:
  • platform/chromium-win/editing/deleting/delete-trailing-ws-002-expected.png:
  • platform/chromium-win/editing/execCommand/5482023-expected.checksum:
  • platform/chromium-win/editing/execCommand/5482023-expected.png:
  • platform/chromium-win/editing/inserting/4960120-2-expected.checksum:
  • platform/chromium-win/editing/inserting/4960120-2-expected.png:
  • platform/chromium-win/editing/inserting/5549929-2-expected.checksum:
  • platform/chromium-win/editing/inserting/5549929-2-expected.png:
  • platform/chromium-win/editing/inserting/5549929-3-expected.checksum:
  • platform/chromium-win/editing/inserting/5549929-3-expected.png:
  • platform/chromium-win/editing/inserting/editable-inline-element-expected.checksum:
  • platform/chromium-win/editing/inserting/editable-inline-element-expected.png:
  • platform/chromium-win/editing/inserting/insert-3654864-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3654864-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-3775316-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3775316-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3786362-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-3800346-fix-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-3800346-fix-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-001-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-005-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-006-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-006-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-007-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-008-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-008-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-009-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-009-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-001-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-002-expected.png:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-br-at-tabspan-003-expected.png:
  • platform/chromium-win/editing/inserting/insert-tab-004-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-tab-004-expected.png:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.checksum:
  • platform/chromium-win/editing/inserting/insert-text-with-newlines-expected.png:
  • platform/chromium-win/editing/inserting/line-break-expected.checksum:
  • platform/chromium-win/editing/inserting/line-break-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-1-expected.png:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • platform/chromium-win/editing/inserting/paragraph-separator-in-table-2-expected.png:
  • platform/chromium-win/editing/inserting/typing-003-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-003-expected.png:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.checksum:
  • platform/chromium-win/editing/inserting/typing-around-br-001-expected.png:
  • platform/chromium-win/editing/pasteboard/4989774-expected.checksum:
  • platform/chromium-win/editing/pasteboard/4989774-expected.png:
  • platform/chromium-win/editing/pasteboard/5028447-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5028447-expected.png:
  • platform/chromium-win/editing/pasteboard/5601583-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/5601583-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-1-expected.png:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.checksum:
  • platform/chromium-win/editing/pasteboard/merge-end-2-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-4035648-fix-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-001-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-line-endings-006-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-table-003-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-table-003-expected.png:
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.checksum:
  • platform/chromium-win/editing/pasteboard/paste-text-010-expected.png:
  • platform/chromium-win/editing/selection/5007143-2-expected.checksum:
  • platform/chromium-win/editing/selection/5007143-2-expected.png:
  • platform/chromium-win/editing/selection/5007143-expected.checksum:
  • platform/chromium-win/editing/selection/5007143-expected.png:
  • platform/chromium-win/editing/selection/5234383-2-expected.checksum:
  • platform/chromium-win/editing/selection/5234383-2-expected.png:
  • platform/chromium-win/editing/selection/editable-html-element-expected.checksum:
  • platform/chromium-win/editing/selection/editable-html-element-expected.png:
  • platform/chromium-win/editing/selection/extend-selection-expected.txt:
  • platform/chromium-win/editing/selection/move-3875618-fix-expected.checksum:
  • platform/chromium-win/editing/selection/move-3875618-fix-expected.png:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.checksum:
  • platform/chromium-win/editing/selection/move-backwords-by-word-001-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-002-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-002-expected.png:
  • platform/chromium-win/editing/selection/move-by-character-003-expected.checksum:
  • platform/chromium-win/editing/selection/move-by-character-003-expected.png:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.checksum:
  • platform/chromium-win/editing/selection/move-past-trailing-space-expected.png:
  • platform/chromium-win/editing/selection/selection-3748164-fix-expected.checksum:
  • platform/chromium-win/editing/selection/selection-3748164-fix-expected.png:
  • platform/chromium-win/editing/unsupported-content/table-delete-001-expected.checksum:
  • platform/chromium-win/editing/unsupported-content/table-delete-001-expected.png:
  • platform/chromium-win/editing/unsupported-content/table-delete-003-expected.checksum:
  • platform/chromium-win/editing/unsupported-content/table-delete-003-expected.png:
7:41 PM Changeset in webkit [71600] by kenneth@webkit.org
  • 11 edits in trunk/WebKit2

2010-11-08 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by Andreas Kling.

Send page scroll requests to the PageClient when scroll delegation is turned on
https://bugs.webkit.org/show_bug.cgi?id=49171

Implement the IPC and API required for making scroll delegation work
with WebKit2. This is only used when you have tiling enabled.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::pageDidRequestScroll):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::pageDidRequestScroll):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::pageDidRequestScroll):
  • WebProcess/WebPage/WebPage.h:
7:24 PM Changeset in webkit [71599] by mrowe@apple.com
  • 2 edits in trunk/WebKit2

<rdar://problem/8531943> Enable partial symbolication for sandbox violations in WebProcess.

Patch by Ivan Krstić <ike@apple.com> on 2010-11-08
Reviewed by Mark Rowe.

  • WebProcess/com.apple.WebProcess.sb:
7:19 PM Changeset in webkit [71598] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-11-08 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed build fix for Chromium Mac for r71590.

  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::provideStringAndAttributes):
7:04 PM Changeset in webkit [71597] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-08 John Knottenbelt <jknotten@chromium.org>

Reviewed by Kent Tamura.

WebViewHost::reset() uses placement new.
https://bugs.webkit.org/show_bug.cgi?id=49069

WebViewHost is using placement destruction / new to simulate a fresh
WebViewHost object at the same address. This is because the WebView remains
open across tests and maintains a pointer to the WebViewHost.
This change resets member variables explictly instead of the placement new dance.

  • DumpRenderTree/chromium/WebViewHost.cpp: (WebViewHost::WebViewHost): (WebViewHost::reset):
6:48 PM Changeset in webkit [71596] by commit-queue@webkit.org
  • 4 edits in trunk/WebKit2

2010-11-08 Juha Savolainen <juha.savolainen@weego.fi>

Reviewed by Andreas Kling.

[Qt] Added new methods to QWKHistory and made QWKHistoryItemPrivate to shared object.
https://bugs.webkit.org/show_bug.cgi?id=49063

Added more functionality to the QWKHistory and changed QWKHistoryItemPrivate to shared object.
This is needed because we cannot delete the QWKHistoryItemPrivate pointer in destructor of QWKHistoryItem,
there may have other history instances which share same private implementation.

  • UIProcess/API/qt/qwkhistory.cpp: (QWKHistoryItemPrivate::~QWKHistoryItemPrivate): (QWKHistoryItem::QWKHistoryItem): (QWKHistoryItem::QWKHistoryItem::operator=): (QWKHistory::currentItem): Added (QWKHistory::backItem): Added (QWKHistory::forwardItem): Added (QWKHistory::itemAt): Added (QWKHistory::backItems): Added (QWKHistory::forwardItems): Added
  • UIProcess/API/qt/qwkhistory.h:
  • UIProcess/API/qt/qwkhistory_p.h:
6:45 PM Changeset in webkit [71595] by rniwa@webkit.org
  • 6 edits
    2 adds
    21 deletes in trunk/LayoutTests

2010-11-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Kent Tamura.

dump-as-markup conversion: editing/inserting/5607069-2.html and 5607069-3.html
https://bugs.webkit.org/show_bug.cgi?id=49223

Converted editing/inserting/5607069-2.html and editing/inserting/5607069-3.html
to dump-as-markup tests. Re-enabled them on Qt, Gtk, and Chromium platforms.

  • editing/inserting/5607069-2-expected.txt: Added.
  • editing/inserting/5607069-2.html:
  • editing/inserting/5607069-3-expected.txt: Added.
  • editing/inserting/5607069-3.html:
  • platform/chromium-linux/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/5607069-2-expected.png: Removed.
  • platform/chromium-linux/editing/inserting/5607069-2-expected.txt: Removed.
  • platform/chromium-linux/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/chromium-linux/editing/inserting/5607069-3-expected.png: Removed.
  • platform/chromium-win/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/5607069-2-expected.png: Removed.
  • platform/chromium-win/editing/inserting/5607069-2-expected.txt: Removed.
  • platform/chromium-win/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/chromium-win/editing/inserting/5607069-3-expected.png: Removed.
  • platform/chromium-win/editing/inserting/5607069-3-expected.txt: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/mac-leopard/editing/inserting/5607069-2-expected.png: Removed.
  • platform/mac-leopard/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/mac-leopard/editing/inserting/5607069-3-expected.png: Removed.
  • platform/mac/editing/inserting/5607069-2-expected.checksum: Removed.
  • platform/mac/editing/inserting/5607069-2-expected.png: Removed.
  • platform/mac/editing/inserting/5607069-2-expected.txt: Removed.
  • platform/mac/editing/inserting/5607069-3-expected.checksum: Removed.
  • platform/mac/editing/inserting/5607069-3-expected.png: Removed.
  • platform/mac/editing/inserting/5607069-3-expected.txt: Removed.
  • platform/qt/Skipped:
6:32 PM Changeset in webkit [71594] by antonm@chromium.org
  • 6 edits in trunk

2010-11-08 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Get rid of automatically generated named property getter for classes with namedItem method
https://bugs.webkit.org/show_bug.cgi?id=48770

  • platform/chromium-mac/fast/dom/HTMLSelectElement/named-options-expected.txt:
  • platform/chromium-win/fast/dom/HTMLSelectElement/named-options-expected.txt:

2010-11-08 Anton Muhin <antonm@chromium.org>

Reviewed by Nate Chapin.

[v8] Get rid of automatically generated named property getter for classes with namedItem method
https://bugs.webkit.org/show_bug.cgi?id=48770

  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
6:15 PM Changeset in webkit [71593] by benjamin.poulain@nokia.com
  • 2 edits in trunk/WebKit/qt

2010-11-08 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Andreas Kling.

[Qt] build error in WebKit/qt/Api/qwebpage.cpp in Qt 4.7.0
https://bugs.webkit.org/show_bug.cgi?id=47427

Add a missing guard in order to be able to compile when
ENABLE(TOUCH_EVENTS) is not defined.

  • Api/qwebpage.cpp: (QWebPagePrivate::touchEvent):
6:08 PM Changeset in webkit [71592] by dumi@chromium.org
  • 10 edits
    46 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/editing/selection/home-end-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/chromium-linux/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png: Added.
  • platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win-xp/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win/editing/selection/home-end-expected.txt:
  • platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/chromium-win/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/chromium-win/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/chromium-win/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
  • platform/chromium-win/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/chromium-win/fast/text/international/bidi-override-expected.txt:
  • platform/chromium/test_expectations.txt:
5:54 PM Changeset in webkit [71591] by andersca@apple.com
  • 16 edits
    3 copies
    1 add in trunk/WebKit2

Add WKDownloadClient API
https://bugs.webkit.org/show_bug.cgi?id=49227

Reviewed by Dan Bernstein.

  • Shared/API/c/WKBase.h:

Add WKDownloadRef.

  • UIProcess/API/C/WKAPICast.h:

Add WKDownloadRef <-> DownloadProxy mapping.

  • UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):
Initialize the download client.

  • UIProcess/API/C/WKContext.h:

Add new WKContextDownloadClient API.

  • UIProcess/API/C/WKDownload.cpp: Added.
  • UIProcess/API/C/WKDownload.h:

Add WKDownload files.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didStart):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Call down to the the WebDownloadClient.

  • UIProcess/Downloads/DownloadProxy.messages.in:

Rename DidBegin to DidStart.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::initializeDownloadClient):
Initialize the download client.

  • UIProcess/WebContext.h:

(WebKit::WebContext::downloadClient):
Add getter.

  • UIProcess/WebDownloadClient.cpp:

(WebKit::WebDownloadClient::didStart):
(WebKit::WebDownloadClient::didCreateDestination):
(WebKit::WebDownloadClient::didFinish):
Call the relevant WKContextDownloadClient functions.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didStart):

  • WebProcess/Downloads/Download.h:
  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate downloadDidBegin:]):
Rename Download::didBegin to Download::didStart.

  • win/WebKit2.vcproj:

Add new files.

5:53 PM Changeset in webkit [71590] by commit-queue@webkit.org
  • 7 edits in trunk

2010-11-08 Ned Holbrook <nholbrook@apple.com>

Reviewed by Adam Barth.

Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
https://bugs.webkit.org/show_bug.cgi?id=48886

  • WebCore.exp.in:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp: (WebCore::provideStringAndAttributes): (WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

2010-11-08 Ned Holbrook <nholbrook@apple.com>

Reviewed by Adam Barth.

Avoid CFAttributedString creation in ComplexTextController by adopting UniChar provider SPI.
https://bugs.webkit.org/show_bug.cgi?id=48886

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface):
5:41 PM Changeset in webkit [71589] by hyatt@apple.com
  • 2 edits in trunk/WebCore

https://bugs.webkit.org/show_bug.cgi?id=49228

Reviewed by Simon Fraser.

REGRESSION: caret too short when a positive line height is specified. Now that lineTop no longer
accidentally incorporates the top leading, we need to use selectionTop/Bottom for the caret rect.

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):

5:13 PM Changeset in webkit [71588] by xji@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-08 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Rebaesline for GTK after r71566
https://bugs.webkit.org/show_bug.cgi?id=25321

  • platform/gtk/editing/selection/extend-selection-expected.txt:
5:05 PM Changeset in webkit [71587] by commit-queue@webkit.org
  • 6 edits in trunk

2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>

Reviewed by Darin Fisher.

[chromium] Adding hasUserGesture flag to the ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=37057

This flag is to be used on the browser side to indicate when a
download has been user initiated.

No new tests. This change will be tested through a browser UI test.

  • platform/network/chromium/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::hasUserGesture): (WebCore::ResourceRequest::setHasUserGesture):

2010-11-08 Pierre-Antoine LaFayette <pierre.lafayette@gmail.com>

Reviewed by Darin Fisher.

[chromium] Adding hasUserGesture flag to the ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=37057

This flag is to be used on the browser side to indicate when a
download has been user initiated.

  • public/WebURLRequest.h:
  • src/WebURLRequest.cpp: (WebKit::WebURLRequest::hasUserGesture): (WebKit::WebURLRequest::setHasUserGesture):
4:48 PM Changeset in webkit [71586] by crogers@google.com
  • 5 edits in trunk/WebCore

2010-11-08 Chris Rogers <crogers@google.com>

Reviewed by Kenneth Russell.

Remove obsolete PASSTHROUGH and MATRIXMIX panner mode
https://bugs.webkit.org/show_bug.cgi?id=49087

No new tests since audio API is not yet implemented.

  • platform/audio/Panner.cpp: (WebCore::Panner::create):
  • platform/audio/Panner.h:
  • webaudio/AudioPannerNode.h:
  • webaudio/AudioPannerNode.idl:
4:42 PM Changeset in webkit [71585] by beidson@apple.com
  • 19 edits
    2 moves in trunk/WebKit2

Part of https://bugs.webkit.org/show_bug.cgi?id=49222
Rename "WebContextMenuItem" to "WebContextMenuItemData"

Reviewed by Anders Carlsson.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:
  • Shared/WebContextMenuItem.cpp: Removed.
  • Shared/WebContextMenuItem.h: Removed.
  • Shared/WebContextMenuItemData.cpp: Copied from Shared/WebContextMenuItem.cpp.

(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::encode):
(WebKit::WebContextMenuItemData::decode):
(WebKit::kitItems):

  • Shared/WebContextMenuItemData.h: Copied from Shared/WebContextMenuItem.h.

(WebKit::WebContextMenuItemData::submenu):

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::contextMenuItemSelected):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WebMenuTarget forwardContextMenuAction:]):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):
(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.cpp:

(WebKit::WebContextMenuProxyQt::showContextMenu):

  • UIProcess/qt/WebContextMenuProxyQt.h:
  • UIProcess/win/WebContextMenuProxyWin.cpp:

(WebKit::WebContextMenuProxyWin::showContextMenu):

  • UIProcess/win/WebContextMenuProxyWin.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::itemSelected):

  • WebProcess/WebPage/WebContextMenu.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didSelectItemFromActiveContextMenu):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:23 PM Changeset in webkit [71584] by Patrick Gansterer
  • 2 edits
    1 delete in trunk/WebCore

2010-11-08 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Roben.

Merge EditorWinCE.cpp into EditorWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=49095

  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard):
  • platform/wince/EditorWinCE.cpp: Removed.
4:08 PM Changeset in webkit [71583] by andersca@apple.com
  • 3 edits in trunk/WebKit2

Find in Page: scrolling the page with the scrollbar while overlay is up dismisses the overlay
https://bugs.webkit.org/show_bug.cgi?id=49219
<rdar://problem/8569550>

Reviewed by John Sullivan and Dan Bernstein.

  • WebProcess/WebPage/FindPageOverlay.cpp:

(WebKit::FindPageOverlay::bounds):
Return the bounds of the find page overlay, excluding any scrollbars.

(WebKit::FindPageOverlay::drawRect):
Call bounds.

(WebKit::FindPageOverlay::mouseEvent):
Only dismiss the find UI if the mouse down event happens inside the overlay bounds.

3:59 PM Changeset in webkit [71582] by hyatt@apple.com
  • 6 edits in trunk

https://bugs.webkit.org/show_bug.cgi?id=49217

Reviewed by Simon Fraser.

Fix coordinate space mismatch in RenderReplaced and make sure RenderText retains its old behavior of
preferring later lines when there is overlap.

WebCore:

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):

  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

LayoutTests:

  • fast/dom/Document/CaretRangeFromPoint/replace-element-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/replace-element.html:
3:52 PM Changeset in webkit [71581] by andersca@apple.com
  • 16 edits
    1 add in trunk/WebKit2

Add the ability to send messages to DownloadProxy objects
https://bugs.webkit.org/show_bug.cgi?id=49213

Reviewed by Adam Roben.

  • DerivedSources.make:
  • DerivedSources.pro:

Add Download.messages.in.

  • Platform/CoreIPC/MessageID.h:

Add MessageClassDownloadProxy message class.

  • Platform/CoreIPC/MessageSender.h:

Include Connection.h directly since it's required.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::didBegin):
(WebKit::DownloadProxy::didCreateDestination):
(WebKit::DownloadProxy::didFinish):
Add stubs.

  • UIProcess/Downloads/DownloadProxy.messages.in: Added.
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::didReceiveMessage):
Handle DownloadProxy messages.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessage):
Hand DownloadProxy messages off to the context.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Downloads/Download.cpp:

(WebKit::Download::didBegin):
(WebKit::Download::didReceiveData):
(WebKit::Download::didCreateDestination):
(WebKit::Download::didFinish):
Send messages.

  • WebProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didCreateDestination:]):
Call Download::didCreateDestination.

  • win/WebKit2.vcproj:

Add new files.

3:36 PM Changeset in webkit [71580] by dpranke@chromium.org
  • 9 edits
    5 adds in trunk/WebKitTools

2010-11-08 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

Fix the webkit_base_dir logic in webkitpy/layout_tests/port/config.py.
It turns out that NRWT can't use the code in scm.find_checkout_root()
because the Chromium bots don't do full checkouts of the WebKit
tree; they only check out subdirectories like WebKitTools/Scripts.
Until we can figure out a better approach for this, I've
restored the base_dir-detecting code from NRWT, which works in
any directory tree, scm or no.

This also restores the files modified in r71475 and r71474.

https://bugs.webkit.org/show_bug.cgi?id=49151

  • WebKitTools/Scripts/webkitpy/layout_tests/port/config.py
  • WebKitTools/Scripts/webkitpy/layout_tests/port/config_unittest.py
3:07 PM Changeset in webkit [71579] by hyatt@apple.com
  • 1 edit in trunk/WebCore/rendering/RenderObject.h

Fix build bustage.

2:52 PM Changeset in webkit [71578] by steveblock@google.com
  • 4 edits in trunk/WebCore

2010-11-08 Steve Block <steveblock@google.com>

Reviewed by David Levin.

Building for Android generates several compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=49175

Fixes these warnings, most of which are trivial.

No new tests, fixes compile warnings only.

  • WebCorePrefix.h:
  • bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
  • platform/android/FileSystemAndroid.cpp: (WebCore::listDirectory):
2:52 PM Changeset in webkit [71577] by noam.rosenthal@nokia.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed bot fix.

Removed a test that was added without results. Will add again later.

  • compositing/layer-creation/many-layers.html: Removed.
2:48 PM Changeset in webkit [71576] by mitz@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/8119781> Crash zooming into Word document at office.live.com
https://bugs.webkit.org/show_bug.cgi?id=49203

Reviewed by Darin Adler.

WebCore:

Test: fast/css/zoom-change-triggering-layout.html

RenderBox::styleDidChange() was calling scrollLeft() and scrollTop(), whose RenderTextControlSingleLine
overrides can trigger layout.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange): Use the layer directly for updating the scroll offsets when
the zoom factor changes.

LayoutTests:

  • fast/css/zoom-change-triggering-layout-expected.txt: Added.
  • fast/css/zoom-change-triggering-layout.html: Added.
2:43 PM Changeset in webkit [71575] by Csaba Osztrogonác
  • 1 edit
    2 moves in trunk/LayoutTests

Unreviewed rolling out r71567.

r71567 was incorrect, because fast/js/navigator-mimeTypes-length.html contains relative paths to js files.

  • fast/js/navigator-mimeTypes-length-expected.txt: Copied from LayoutTests/plugins/navigator-mimeTypes-length-expected.txt.
  • fast/js/navigator-mimeTypes-length.html: Copied from LayoutTests/plugins/navigator-mimeTypes-length.html.
  • plugins/navigator-mimeTypes-length-expected.txt: Removed.
  • plugins/navigator-mimeTypes-length.html: Removed.
2:39 PM Changeset in webkit [71574] by andersca@apple.com
  • 9 edits
    2 copies
    1 add in trunk/WebKit2

Add DownloadProxy object
https://bugs.webkit.org/show_bug.cgi?id=49211

Reviewed by Adam Roben.

DownloadProxy will be the implementation of the forthcoming WKDownloadRef object.

  • Shared/APIObject.h:

Add TypeDownload.

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::generateDownloadID):
Generate a unique download ID.

(WebKit::DownloadProxy::invalidate):
Null out the web context.

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::WebContext::processDidClose):
Invalidate all downloads.

(WebKit::WebContext::createDownloadProxy):
Create a WebDownload object.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Call createDownloadProxy instead.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

  • win/WebKit2Common.vsprops:

Add new include path.

2:28 PM Changeset in webkit [71573] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-08 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

Add a test missing results to chromium-gpu test expectations.

  • platform/chromium-gpu/test_expectations.txt:
2:21 PM Changeset in webkit [71572] by hyatt@apple.com
  • 4 edits
    12 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=48587

Reviewed by Simon Fraser.

Make Ruby work with vertical text. Ruby already nearly does work. The only big issue I found was with
flipped lines writing modes. Make sure to mutate the writing-mode of the RenderRubyRun to ensure that
the ruby text is on the correct side of the ruby base.

Added fast/blockflow tests of the various writing modes.

WebCore:

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):

  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::staticCreateRubyRun):

LayoutTests:

  • fast/blockflow/japanese-ruby-horizontal-bt.html: Added.
  • fast/blockflow/japanese-ruby-vertical-lr.html: Added.
  • fast/blockflow/japanese-ruby-vertical-rl.html: Added.
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-ruby-horizontal-bt-expected.txt: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-lr-expected.txt: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-ruby-vertical-rl-expected.txt: Added.
2:19 PM Changeset in webkit [71571] by eric@webkit.org
  • 5 edits in trunk/WebKitTools

2010-11-08 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

webkit-patch failure-reason explodes if a build is missing
https://bugs.webkit.org/show_bug.cgi?id=49195

This is likely a recent regression. Adding a unit test for this case.

  • Scripts/webkitpy/common/net/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot_unittest.py:
2:18 PM Changeset in webkit [71570] by abarth@webkit.org
  • 3 edits in trunk/BugsSite

2010-11-08 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Restore normal meaning of double-click on patch review page?
https://bugs.webkit.org/show_bug.cgi?id=47641

After this patch, you need to click on the line numbers to add a
comment.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
2:10 PM Changeset in webkit [71569] by bfulgham@webkit.org
  • 3 edits in trunk/WebCore

Unreviewed build correction after @70369/@70846.

Please use PLATFORM(CG) to define CG-specific code, not
PLATFORM(CF).

  • platform/image-decoders/ImageDecoder.cpp:
  • platform/image-decoders/ImageDecoder.h:
1:52 PM Changeset in webkit [71568] by jamesr@google.com
  • 3 edits
    2 adds in trunk

2010-11-08 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Input element with inner spin button set to display:none causes crash
https://bugs.webkit.org/show_bug.cgi?id=49121

Adds a test for dispatching mouse events at an <input type="number"> with
the inner spin button set to display:none does not crash.

  • fast/forms/input-number-spinbutton-crash-expected.txt: Added.
  • fast/forms/input-number-spinbutton-crash.html: Added.

2010-11-08 James Robinson <jamesr@chromium.org>

Reviewed by Dimitri Glazkov.

Input element with inner spin button set to display:none causes crash
https://bugs.webkit.org/show_bug.cgi?id=49121

Null check the inner spin button's renderer before dereferencing it.

Test: fast/forms/input-number-spinbutton-crash.html

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::forwardEvent):
1:41 PM Changeset in webkit [71567] by tony@chromium.org
  • 1 edit
    2 moves in trunk/LayoutTests

2010-11-08 Tony Chang <tony@chromium.org>

Unreviewed. Moving a plugin test into the plugins directory.

  • plugins/navigator-mimeTypes-length-expected.txt: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length-expected.txt.
  • plugins/navigator-mimeTypes-length.html: Renamed from LayoutTests/fast/js/navigator-mimeTypes-length.html.
1:35 PM Changeset in webkit [71566] by xji@chromium.org
  • 13 edits
    4 adds in trunk

2010-11-08 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix Unicode explicit bidi control characters are removed in editing operations,
such as insert/copy/cut/paste.
https://bugs.webkit.org/show_bug.cgi?id=25321

Unicode explicit bidi control characters were excluded in BidiRun and
consequently from InlineTextBoxes due to their effect on rendering complex
text with ATSUI.
The fix is including those characters in BidiRun and remove them from
ComplexTextRun with ATSUI.

Test: editing/inserting/insert-paste-bidi-control.html

fast/text/atsui-bidi-control.html

  • platform/graphics/mac/ComplexTextControllerATSUI.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
  • platform/text/BidiResolver.h: (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel): (WebCore::::lowerExplicitEmbeddingLevel): (WebCore::::raiseExplicitEmbeddingLevel): (WebCore::::createBidiRunsForLine):

2010-11-08 Xiaomei Ji <xji@chromium.org>

Reviewed by Dan Bernstein.

Fix Unicode explicit bidi control characters are removed in editing operations,
such as insert/copy/cut/paste.
https://bugs.webkit.org/show_bug.cgi?id=25321

Unicode explicit bidi control characters were excluded in BidiRun and
consequently from InlineTextBoxes due to their effect on rendering complex
text with ATSUI.
The fix is including those characters in BidiRun and remove them from
ComplexTextRun with ATSUI.

  • editing/inserting/insert-paste-bidi-control-expected.txt: Added.
  • editing/inserting/insert-paste-bidi-control.html: Added.
  • editing/selection/extend-selection-expected.txt:
  • editing/selection/home-end-expected.txt:
  • fast/text/atsui-bidi-control-expected.txt: Added.
  • fast/text/atsui-bidi-control.html: Added.
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt:
  • platform/mac/fast/text/international/bidi-explicit-embedding-expected.txt:
  • platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
  • platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
  • platform/mac/fast/text/international/bidi-override-expected.txt:
1:21 PM Changeset in webkit [71565] by ap@apple.com
  • 3 edits in trunk/WebKit2

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49201
Crash when closing a page

Handle null frame by passing a 0 frame id (normal ones start from 1).

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::focusedFrameChanged):
  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::focusedFrameChanged):
1:20 PM Changeset in webkit [71564] by Nate Chapin
  • 2 edits in trunk/WebKit/mac

2010-11-08 Nate Chapin <Nate Chapin>

Unreviewed, build fix.

Clumsy typo in r71562.

  • Plugins/Hosted/HostedNetscapePluginStream.mm: (WebKit::HostedNetscapePluginStream::start):
1:12 PM Changeset in webkit [71563] by hyatt@apple.com
  • 11 edits
    12 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=49126

Reviewed by Dan Bernstein.

RenderBlock::positionForPoint is not writing-mode aware. Patch the function to examine lines in the correct
writing-mode direction. Patched and renamed a number of helpers used by positionForPoint.

Fixed a bug with RenderReplaced's positionForPoint. There was a coordinate space mismatch between what the
function expected (local coordinates) and what was passed in (containing block coords), which meant the function didn't even work.

Fixed a bug with the propagation of selection state on RenderReplaced to its containing block. The bit double propagated
because both the base class function and the derived class function did the propagation, and the setter function did not
do the right thing if this happened.

Patched the localSelectionRect method on RenderReplaced so that selection draws in the right place in all writing modes.

Added new tests of positionForPoint and replaced elements in fast/blockflow.

WebCore:

  • editing/visible_units.cpp:

(WebCore::previousLinePosition):
(WebCore::nextLinePosition):

  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::transpose):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::paint):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::positionForPoint):
(WebCore::RenderReplaced::localSelectionRect):
(WebCore::RenderReplaced::setSelectionState):

  • rendering/RenderReplaced.h:
  • rendering/RenderText.cpp:

(WebCore::RenderText::positionForPoint):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::closestLeafChildForLogicalLeftPosition):

  • rendering/RootInlineBox.h:

LayoutTests:

  • fast/blockflow/horizontal-bt-replaced-selection.html: Added.
  • fast/blockflow/vertical-lr-replaced-selection.html: Added.
  • fast/blockflow/vertical-rl-replaced-selection.html: Added.
  • platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
  • platform/mac/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
  • platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
  • platform/mac/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
1:01 PM Changeset in webkit [71562] by Nate Chapin
  • 28 edits
    2 adds in trunk

2010-11-08 Nate Chapin <Nate Chapin>

Reviewed by Alexey Proskuryakov.

Move connection-per-host counting and request prioritization out
of Loader and down to the ResourceLoader level.

https://bugs.webkit.org/show_bug.cgi?id=27165

Refactor only, so no new tests.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::suspendPostAttachCallbacks): (WebCore::ContainerNode::resumePostAttachCallbacks):
  • loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::loadRequest):
  • loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::loadNow):
  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::create):
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoadScheduler.cpp: Added. (WebCore::ResourceLoadScheduler::hostForURL): (WebCore::resourceLoadScheduler): Returns the single ResourceLoadScheduler instance (WebCore::ResourceLoadScheduler::ResourceLoadScheduler): (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): (WebCore::ResourceLoadScheduler::schedulePluginStreamLoad): (WebCore::ResourceLoadScheduler::addMainResourceLoad): (WebCore::ResourceLoadScheduler::scheduleLoad): (WebCore::ResourceLoadScheduler::remove): (WebCore::ResourceLoadScheduler::crossOriginRedirectReceived): (WebCore::ResourceLoadScheduler::servePendingRequests): (WebCore::ResourceLoadScheduler::suspendPendingRequests): (WebCore::ResourceLoadScheduler::resumePendingRequests): (WebCore::ResourceLoadScheduler::scheduleServePendingRequests): (WebCore::ResourceLoadScheduler::requestTimerFired): (WebCore::ResourceLoadScheduler::assertLoaderBeingCounted): (WebCore::ResourceLoadScheduler::HostInformation::assertLoaderBeingCounted): (WebCore::ResourceLoadScheduler::HostInformation::HostInformation): (WebCore::ResourceLoadScheduler::HostInformation::~HostInformation): (WebCore::ResourceLoadScheduler::HostInformation::schedule): (WebCore::ResourceLoadScheduler::HostInformation::addLoadInProgress): (WebCore::ResourceLoadScheduler::HostInformation::remove): (WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
  • loader/ResourceLoadScheduler.h: Added. (WebCore::ResourceLoadScheduler::HostInformation::name): (WebCore::ResourceLoadScheduler::HostInformation::limitRequests): (WebCore::ResourceLoadScheduler::HostInformation::requestsPending):
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources): Remove this from ResourceLoadScheduler's counting. (WebCore::ResourceLoader::load): (WebCore::ResourceLoader::start): Create the ResourceHandle, called by ResourceLoadScheduler. (WebCore::ResourceLoader::willSendRequest): Ensure ResourceLoadScheduler counts redirects

correctly.

  • loader/ResourceLoader.h: (WebCore::ResourceLoader::url):
  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading):
  • loader/loader.cpp: Move scheduling to ResourceLoadScheduler, remove Host subclass

and make Loader the SubresourceLoaderClient instead.

(WebCore::determinePriority):
(WebCore::Loader::load): Schedule the creation of the ResourceHandle, rather than

doing it immediately.

(WebCore::Loader::cancelRequests):
(WebCore::Loader::didFinishLoading):
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveResponse):
(WebCore::Loader::didReceiveData):
(WebCore::Loader::didReceiveCachedMetadata):

  • loader/loader.h:
  • page/EventSource.cpp: (WebCore::EventSource::connect): (WebCore::EventSource::endRequest):
  • plugins/PluginStream.cpp: (WebCore::PluginStream::start):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::~XMLHttpRequest): (WebCore::XMLHttpRequest::createRequest): (WebCore::XMLHttpRequest::didFail): (WebCore::XMLHttpRequest::didFinishLoading):
  • xml/XMLHttpRequest.h:
1:00 PM Changeset in webkit [71561] by leandro@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-11-08 Rafael Antognolli <antognolli@profusion.mobi>

Reviewed by Antonio Gomes.

[EFL] Change the usage of eina_iterator_next due to latest EFL changes.
https://bugs.webkit.org/show_bug.cgi?id=49082

A change on how the iterator for a tiler is used in EFL needs to be
reflected in WebKit-EFL. The iterator now receives a pointer to an
Eina_Rectangle and makes it point to its internal structure. The old
usage was to receive a reference to a pre-allocated Eina_Rectangle.

  • ewk/ewk_view_single.c: (_ewk_view_single_smart_repaints_process):
12:41 PM Changeset in webkit [71560] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Ignore the system scrollbar setting.

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues): Set the scrollbar default.

12:32 PM Changeset in webkit [71559] by andersca@apple.com
  • 9 edits in trunk

NPClass::construct and NPClass::invokeDefault never called with out-of-process plug-ins in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49198

Reviewed by Adam Roben.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::invokeDefault):
Call NPClass::invokeDefault.

(WebKit::NPObjectMessageReceiver::construct):
Call NPClass::construct

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add InvokeDefault and Construct messages.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::invokeDefault):
Send the InvokeDefault message.

(WebKit::NPObjectProxy::construct):
Send the Construct message.

(WebKit::NPObjectProxy::NP_InvokeDefault):
Call NPObjectProxy::invokeDefault.

(WebKit::NPObjectProxy::NP_Construct):
Call NPObjectProxy::construct.

LayoutTests:

Remove now passing tests.

  • platform/mac-snowleopard/Skipped:
  • platform/mac-wk2/Skipped:
12:29 PM Changeset in webkit [71558] by tony@chromium.org
  • 4 edits
    1 copy
    1 move
    2 deletes in trunk/LayoutTests

2010-11-08 Tony Chang <tony@chromium.org>

Unreviewed, updating plugin expectations.

  • platform/chromium-mac/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
  • platform/chromium-win/plugins/netscape-destroy-plugin-script-objects-expected.txt: Removed.
  • platform/mac-snowleopard/Skipped: Only failing on SL.
  • platform/mac/Skipped:
  • platform/qt/plugins/nested-plugin-objects-expected.txt: Removed.
  • plugins/nested-plugin-objects-expected.txt: Made the main version

have a console error line of 0 since it seems to be a chromium
specific difference.

12:28 PM Changeset in webkit [71557] by jberlin@webkit.org
  • 2 edits in trunk/WebKitSite

We should add a build step to comment out or remove the lines unsetting TEMP and TMP in the
.bashrc file.
https://bugs.webkit.org/show_bug.cgi?id=49189

Reviewed by Adam Roben.

  • building/tools.html:

Add a line recommending bash shell users to comment out or remove those lines, with an
explanation as to why.

12:15 PM Changeset in webkit [71556] by rniwa@webkit.org
  • 13 edits in trunk/WebCore

2010-11-08 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Remove the remaining editing-style functions from ApplyStyleCommand
https://bugs.webkit.org/show_bug.cgi?id=49155

Replaced removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt,
and removeStylesAddedByNode in ApplyStyleCommand.cpp by removeNonEditingProperties, EditingStyle::create,
prepareToApplyAt, and removeStyleAddedByNode in EditingStyle.cpp.

Also removed unnecessary header includes from various cpp files.

No tests are added since this is a cleanup.

  • editing/ApplyStyleCommand.cpp: Removed removeNonEditingProperties, editingStyleAtPosition, prepareEditingStyleToApplyAt, and removeStylesAddedByNode.
  • editing/ApplyStyleCommand.h: Ditto.
  • editing/DeleteSelectionCommand.cpp: Removed removeEnclosingAnchorStyle. (WebCore::DeleteSelectionCommand::saveTypingStyleState): Calls removeStylesAddedByNode instead.
  • editing/EditingStyle.cpp: (WebCore::copyEditingProperties): Moved and renamed ApplyStyleCommand::removeNonEditingProperties. (WebCore::editingStyleFromComputedStyle): Calls copyEditingProperties. Changed the argument to PassRefPtr as supposed to a raw pointer for convenience. (WebCore::EditingStyle::init): Calls editingStyleFromComputedStyle. (WebCore::EditingStyle::removeStyleAddedByNode): Added. (WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode): Added. (WebCore::EditingStyle::removeNonEditingProperties): Added. (WebCore::editingStyleIncludingTypingStyle): Calls copyEditingProperties.
  • editing/EditingStyle.h: Added prototypes.
  • editing/Editor.cpp: (WebCore::Editor::selectionComputedStyle): Uses EditingStyle.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::calculateStyleBeforeInsertion): Ditto. (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Ditto.
  • editing/InsertParagraphSeparatorCommand.h:
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::handleStyleSpansBeforeInsertion): Ditto. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Ditto. (WebCore::ReplaceSelectionCommand::doApply): Ditto. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: Removed removeEnclosingMailBlockquoteStyle and removeDefaultStyles. (WebCore::createMarkup): Uses EditingStyle.
12:02 PM Changeset in webkit [71555] by dumi@chromium.org
  • 1 edit
    60 adds
    2 deletes in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-mac/svg/custom/polyline-points-crash-expected.txt: Removed.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • platform/chromium-win/svg/custom/polyline-points-crash-expected.txt: Removed.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/chromium-win/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
11:58 AM Changeset in webkit [71554] by andersca@apple.com
  • 4 edits in trunk

Plug-in views should not assume that plugins are RenderEmbeddedObjects
https://bugs.webkit.org/show_bug.cgi?id=49196
<rdar://problem/8638467>

Reviewed by Dan Bernstein.

WebKit/mac:

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView pluginHostDied]):

WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginProcessCrashed):

11:47 AM Changeset in webkit [71553] by Simon Fraser
  • 9 edits
    5 adds in trunk

2010-11-08 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Media objects in nested iframes showing above everything else in TinyMCE
https://bugs.webkit.org/show_bug.cgi?id=44877

Tests: compositing/iframes/become-composited-nested-iframes.html

compositing/iframes/overlapped-nested-iframes.html

The overlap testing logic that connects compositing across iframe boundaries
needed to be educated about nestd iframes, for platforms (i.e. Mac) where iframes
are allowed to be independently composited.

Also fix a bug that could cause iframes (and possibly other elements) that share
style to fail to become composited.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Disable style sharing for elements that force synethetic style updates in order to gain RenderLayers, so they can become composited. This is tested by become-composited-nested-iframes.html, though it is very timing-dependent.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::hasCompositedContentIncludingDescendants): New method that is a "deep" version of hasCompositedContent() on platforms where that is necessary to ask.

(WebCore::FrameView::hasCompositingAncestor): New method.
(WebCore::FrameView::setIsOverlapped): If we can have independently composited iframes,
we need to force all descendant iframes to update so that compositing gets hooked up across
nested iframes.

(WebCore::FrameView::isOverlappedIncludingAncestors): New method, only called on platforms
where allowsIndependentlyCompositedIFrames() is true.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::allowsIndependentlyCompositedIFrames): Utility method that returns true if an iframe can be a compositing root.

(WebCore::RenderLayerCompositor::shouldPropagateCompositingToEnclosingIFrame): Make use of
allowsIndependentlyCompositedIFrames().

(WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): We need to notify all
descendant frames, not just children.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Add assert to ensure that we don't do style sharing for elements that play tricks with synthetic style changes.
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::paint): Run overlap testing if a frame has any composited descendants.
11:29 AM Changeset in webkit [71552] by tony@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2010-11-08 Tony Chang <tony@chromium.org>

Unreviewed, adding qt results for new test (only console line number
is different). Test failing for unknown reasons on mac-- will fix
offline.

  • platform/mac/Skipped:
  • platform/qt/plugins/nested-plugin-objects-expected.txt: Added.
11:26 AM Changeset in webkit [71551] by andersca@apple.com
  • 7 edits in trunk

NPN_Evaluate doesn't work with out-of-process plugins in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49193

Reviewed by Adam Roben.

WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::evaluate):
Send an Evaluate message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::evaluate):
Call Evaluate on the plug-in proxy.

  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginProxy.messages.in:

Add Evaluate message.

LayoutTests:

Remove now passing tests.

  • platform/mac-wk2/Skipped:
11:22 AM Changeset in webkit [71550] by caseq@chromium.org
  • 6 edits in trunk/WebCore

Unreviewed. Rolling back r71506 & r71507, broke inspector/debugger-pause-on-* tests.

11:18 AM Changeset in webkit [71549] by leandro@webkit.org
  • 2 edits in trunk/WebKit

2010-11-08 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed. Build fix after r71496.

  • CMakeLists.txt: Add WebCore/loader/cache directory to WebKit's include directories list.
11:15 AM Changeset in webkit [71548] by ap@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

  • WebCoreSupport/WebChromeClient.h: Added namespace prefix.
11:12 AM Changeset in webkit [71547] by Adam Roben
  • 3 edits in trunk/WebKitTools

Make webkitpy.common.system.executive_unittest pass when running under Win32 Python

Fixes <http://webkit.org/b/49033>.

Reviewed by Dave Levin and Eric Seidel.

  • Scripts/webkitpy/common/system/executive.py:

(Executive._run_command_with_teed_output): Pass the arguments through
encode_argument_if_needed rather than using Cygwin-specific code here.
(Executive.run_and_throw_if_fail): Use child_process_encoding to decode
the output.
(Executive.run_command): Use encode_argument_if_needed to encode the
arguments and child_process_encoding to decode the output.
(Executive._child_process_encoding): Returns the encoding that should be
used when communicating with child processes. On Windows we use mbcs,
which maps to the current code page. On all other platforms we use
UTF-8.
(Executive._should_encode_child_process_arguments): Returns True if
arguments to child processes need to be encoded. This is currently
only needed on Cygwin and Win32 Python 2.x.
(Executive._encode_argument_if_needed): Encode the argument using
child_process_encoding if we need to encode arguments to child
processes on this platform.

  • Scripts/webkitpy/common/system/executive_unittest.py:

(never_ending_command): Added. Returns arguments to run a command that
will not quit until we kill it. On Windows we use wmic, on other
platforms we use yes.
(ExecutiveTest.test_run_command_with_unicode): Changed to expect the
mbcs encoding to be used and for output from the child processes to
have been roundtripped through encode/decode on Win32 Python. When
UTF-8 is the encoding the roundtripping is undetectable, but with mbcs
it's possible that some characters will not be able to be converted
and will be replaced by question marks; the round-tripping allows us
to expect this result.

(ExecutiveTest.test_kill_process):
(ExecutiveTest.test_kill_all):
Use never_ending_command instead of invoking "yes" directly. Expect an
exit code of 1 when using Win32 Python, as that's what seems to happen.

11:05 AM Changeset in webkit [71546] by andersca@apple.com
  • 8 edits in trunk

Correctly convert NPObjectProxy to NPVariantData
https://bugs.webkit.org/show_bug.cgi?id=49190

Reviewed by John Sullivan.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.h:

(WebKit::NPObjectMessageReceiver::npObject):
Add NPObject getter.

  • Shared/Plugins/NPObjectProxy.h:

(WebKit::NPObjectProxy::npObjectID):
Add NPObjectID getter.

  • Shared/Plugins/NPRemoteObjectMap.cpp:

(WebKit::NPRemoteObjectMap::npVariantToNPVariantData):
Handle the case where the NPObject is an NPObjectProxy.

(WebKit::NPRemoteObjectMap::npVariantDataToNPVariant):
Handle NPVariantData::LocalNPObjectID.

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::makeRemoteNPObjectID):

  • Shared/Plugins/NPVariantData.h:

New function for creating an NPVariantData that contains a remote NPObject ID.

LayoutTests:

Remove now passing test.

  • platform/mac-wk2/Skipped:
11:04 AM Changeset in webkit [71545] by Adam Roben
  • 5 edits
    2 deletes in trunk

Roll out r71532

It broke the build for Cygwin 1.7 installs. Cygwin 1.7's default
.bashrc unsets %TEMP%, which broke copy-tools.cmd.

JavaScriptCore:

WebKitTools:

  • Scripts/webkitdirs.pm:
11:00 AM Changeset in webkit [71544] by Darin Adler
  • 3 edits in trunk
  • fast/images/image-map-multiple-xhtml.xhtml: Fixed this test to check that

map name lookup is case sensitive.

Rubber stamped by Alexey Proskuryakov.

10:50 AM Changeset in webkit [71543] by Darin Adler
  • 5 edits
    4 adds in trunk

2010-11-08 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Incorrect image map used when multiple maps have the same name
https://bugs.webkit.org/show_bug.cgi?id=49086

Test: fast/images/image-map-multiple.html

Factored out the code used to look up elements by id and reused it
to look up maps by name. It handles multiple elements efficiently.

  • dom/Document.cpp: (WebCore::Document::DocumentOrderedMap::clear): Added. (WebCore::Document::DocumentOrderedMap::add): Added. Has code that was formerly in addElementById. (WebCore::Document::DocumentOrderedMap::remove): Added. Has code that was formerly in removeElementById. (WebCore::Document::DocumentOrderedMap::get): Added. Has code that was formerly in getElementById. (WebCore::keyMatchesId): Added. (WebCore::Document::getElementById): Use DocumentOrderedMap::get. (WebCore::Document::addElementById): Use DocumentOrderedMap::add. (WebCore::Document::removeElementById): Use DocumentOrderedMap::remove. (WebCore::Document::addImageMap): Use DocumentOrderedMap::add. (WebCore::Document::removeImageMap): Use DocumentOrderedMap::remove. (WebCore::keyMatchesMapName): Added. (WebCore::keyMatchesLowercasedMapName): Added. (WebCore::Document::getImageMap): Use DocumentOrderedMap::get.
  • dom/Document.h: Added DocumentOrderedMap class, used inside the Document class. Changed m_imageMapsByName to be a DocumentOrderedMap. Changed m_elementsById to be a DocumentOrderedMap. Eliminated m_duplicateIds, since DocumentOrderedMap now has that internally.

2010-11-08 Darin Adler <Darin Adler>

Reviewed by Alexey Proskuryakov.

Incorrect image map used when multiple maps have the same name
https://bugs.webkit.org/show_bug.cgi?id=49086

  • fast/images/image-map-multiple-expected.txt: Added.
  • fast/images/image-map-multiple-xhtml-expected.txt: Added.
  • fast/images/image-map-multiple-xhtml.xhtml: Added.
  • fast/images/image-map-multiple.html: Added.
  • fast/images/zoomed-img-size-expected.txt: Removed property svn:executable.
10:36 AM Changeset in webkit [71542] by apavlov@chromium.org
  • 3 edits in trunk/LayoutTests

2010-11-08 Alexander Pavlov <apavlov@chromium.org>

Unreviewed, build fix from commit r71530.

  • fast/css/background-norepeat-crash-expected.txt:
  • fast/css/background-norepeat-crash.html:
10:23 AM Changeset in webkit [71541] by ap@apple.com
  • 42 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=48685
Notify UI process about focused frame

10:19 AM Changeset in webkit [71540] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

Build fix.

  • MigrateHeaders.make:
10:16 AM Changeset in webkit [71539] by andersca@apple.com
  • 4 edits in trunk

Remove use of HIGetScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=49186
<rdar://problem/8618410>

Reviewed by Adam Roben.

Scale factors can vary on a display-by-display basis and it doesn't make sense
to compute scale factor event coordinates like this.

WebCore:

  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::globalMousePosForPlugin):

WebKit/mac:

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:

(getCarbonEvent):

10:04 AM Changeset in webkit [71538] by noam.rosenthal@nokia.com
  • 14 edits
    4 adds in trunk

[Texmap] [Qt] Texture mapper initial implementation
https://bugs.webkit.org/show_bug.cgi?id=47070

Reviewed by Kenneth Rohde Christiansen.

WebCore:

Make the necessary changes in TextureMapperNode in preparation of making it possible to paint it
from a different thread.
The main problematic part was the cache, which made it so that textures can become invalid and have to
be rerendered from content during paint. This is solved here by creating a pack/unpack function for
textures, which lets a texture archive its data away from video memory, or do whatever the platform
thinks is right for freeing memory without needing to re-render again from content (which cannot be
made thread safe).

After this change, TextureMapperNode moved to its own file, and has 2 entry points: paint and syncCompositingState.
The idea is that syncCompositingState has to be called in the UI thread, paint can be called from a different
thread, and they should block each other.

The new test tests the cache code-path, to show that the pack/unpack technique works for cases where it
kicks in.

Test: compositing/layer-creation/many-layers.html

  • WebCore.pro:
  • platform/graphics/opengl/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::drawTexture):

  • platform/graphics/opengl/TextureMapperGL.h:

(WebCore::TextureMapperGL::create):

  • platform/graphics/qt/TextureMapperQt.cpp:

(WebCore::BitmapTextureQt::pack):
(WebCore::BitmapTextureQt::unpack):
(WebCore::TextureMapper::create):
(WebCore::BitmapTextureQt::BitmapTextureQt):

  • platform/graphics/qt/TextureMapperQt.h: Added.

WebKit/qt:

Reorganized the textureMapper to be a member of QWebFramePrivate, to help with making
TextureMapper thread-safe.

  • Api/qwebframe.cpp:

(QWebFramePrivate::renderCompositedLayers):

  • Api/qwebframe_p.h:
  • WebCoreSupport/PageClientQt.cpp:

(WebCore::PlatformLayerProxyQt::setTextureMapper):
(WebCore::PlatformLayerProxyQt::textureMapper):
(WebCore::PlatformLayerProxyQWidget::PlatformLayerProxyQWidget):
(WebCore::PlatformLayerProxyQGraphicsObject::PlatformLayerProxyQGraphicsObject):

LayoutTests:

Added a test that includes several composited layers, containing pixel data that's larger
than 24MB, which is the default value for TextureMapper's cache. This tests the video memory
ceiling functionality of TextureMapper, as purging that cache would kick in whe running this test.

  • compositing/layer-creation/many-layers.html: Added.
9:56 AM Changeset in webkit [71537] by tony@chromium.org
  • 4 edits
    2 moves in trunk

2010-11-08 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/nested-plugin-objects.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49094

  • plugins/nested-plugin-objects-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects-expected.txt.
  • plugins/nested-plugin-objects.html: Renamed from LayoutTests/platform/chromium/plugins/nested-plugin-objects.html.

2010-11-08 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

run platform/chromium/plugins/nested-plugin-objects.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49094

This tests that objects created by plugins are proplery cleaned up.

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (testPassTestObject): (pluginInvoke):
  • DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: (testAllocate): (testDeallocate): (testGetProperty): (testConstruct):
9:48 AM Changeset in webkit [71536] by Simon Fraser
  • 8 edits in trunk

2010-11-08 Simon Fraser <Simon Fraser>

Reviewed by Sam Weinig.

Allow applets to participate in accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=49117
<rdar://problem/8625819>

Add RenderApplet to the list of renderers that can optionally get RenderLayers,
and be composited for some reason.

Not currently testable.

  • rendering/RenderApplet.h: Outdented the class declaration.
  • rendering/RenderApplet.cpp: (WebCore::RenderApplet::requiresLayer): Return true if the underlying widget has a platform layer. (WebCore::RenderApplet::allowsAcceleratedCompositing): Check the widget to see if it has a platform layer.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::shouldBeNormalFlowOnly): Reformat, and add isApplet(). (WebCore::RenderLayer::isSelfPaintingLayer): Reformat, and add isApplet().
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Use 'renderer' local variable for efficiency. Now check for embedded objects and applets.
  • rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForPlugin): Check for embedded objects and applets.
9:30 AM Changeset in webkit [71535] by mrobinson@webkit.org
  • 2 edits in trunk/JavaScriptCore

2010-11-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

=webkitgtk-1.2.5: parallel build fails with libtool: link: cannot find the library libwebkit-1.0.la' or unhandled argument libwebkit-1.0.la'

https://bugs.webkit.org/show_bug.cgi?id=49128

r59042 introduced a C++-style comment in Platform.h, which is often
included in C source files. Change it to a C-style comment.

  • wtf/Platform.h: Fix the C++-style comment.
9:24 AM Changeset in webkit [71534] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • GNUmakefile.am: add missing files to fix distcheck.
9:17 AM Changeset in webkit [71533] by inferno@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-11-08 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Only call WebInspector_syncDispatch if it's actually a function.
https://bugs.webkit.org/show_bug.cgi?id=49180

  • src/WebDevToolsFrontendImpl.cpp: (WebKit::WebDevToolsFrontendImpl::WebDevToolsFrontendImpl): (WebKit::WebDevToolsFrontendImpl::dispatchOnInspectorFrontend):
  • src/WebDevToolsFrontendImpl.h:
9:14 AM Changeset in webkit [71532] by Adam Roben
  • 5 edits
    2 adds in trunk

Show a message and cause the build to immediately fail when any .vsprops files are copied

When $WebKitLibrariesDir is set to a non-standard location, the
.vsprops files have to be copied from WebKitLibraries/win to
$WebKitLibrariesDir. When this happens, Visual Studio doesn't pick up
changes to the .vsprops files until the next time it opens the solution
file. Before this patch, the build would soldier on with the old
.vsprops files, leading to strange build failures. Now we detect that
the .vsprops files have been updated, display a message to the user
telling them what to do, and make the build fail immediately.

Fixes <http://webkit.org/b/49181> Windows build fail mysteriously when
.vsprops files are updated

Reviewed by Steve Falkenburg.

JavaScriptCore:

Moved code to copy the tools directory to the new copy-tools.cmd
script. Moved that after the command that writes the buildfailed file
so the build will be considered a failure if copy-tools.cmd fails.
Changed to write the project name into buildfailed like all our other
projects do, so those other projects will know that the failure was due
to this project.

Added new scripts.

the tools directory to $WebKitLibrariesDir. If any files were copied,
we display a message to the user and exit with error code 1 to cause
the build to fail. In non-interactive builds, we just print the message
to the build log. In interactive builds, we show the message in an
alert.

Windows Scripting Host to display a message in an alert.

WebKitTools:

Mark Windows builds triggered from Perl as being non-interactive

This affects whether some of our scripts will show alerts vs. printing
to the build log.

  • Scripts/webkitdirs.pm:

(buildVisualStudioProject): Set WEBKIT_NONINTERACTIVE_BUILD to 1.

9:02 AM Changeset in webkit [71531] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add a sometimes-failing test to the Windows Skipped file

  • platform/win/Skipped: Added

animations/stop-animation-on-suspend.html.

8:54 AM Changeset in webkit [71530] by apavlov@chromium.org
  • 3 edits
    2 adds in trunk

2010-11-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by David Hyatt.

getPropertyValue("background") causes crash
https://bugs.webkit.org/show_bug.cgi?id=49055

  • fast/css/background-norepeat-crash-expected.txt: Added.
  • fast/css/background-norepeat-crash.html: Added.

2010-11-08 Alexander Pavlov <apavlov@chromium.org>

Reviewed by David Hyatt.

getPropertyValue("background") causes crash
https://bugs.webkit.org/show_bug.cgi?id=49055

Test: fast/css/background-norepeat-crash.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
8:48 AM Changeset in webkit [71529] by mrobinson@webkit.org
  • 2 edits in trunk/WebKit/gtk

2010-11-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Andreas Kling.

[GTK] Error page templates are not filled properly
https://bugs.webkit.org/show_bug.cgi?id=49148

Replace a call to makeString with String::format. This was mistakenly
changed to makeString in an earlier commit.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidFailLoad):
8:42 AM Changeset in webkit [71528] by mrobinson@webkit.org
  • 4 edits in trunk/WebCore

2010-11-08 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Wrapped DOM bindings GObjects do not disconnect event listeners when they die
https://bugs.webkit.org/show_bug.cgi?id=49136

When GObjects are finalized and freed, disconnect their event listeners, so that
WebCore does not try to fire signals on dead GObjects. We do this by holding a weak
reference to the GObject in the signal listener. When the weak reference notification
callback is executed, we disconnect the event listener.

No new tests; this fix is proved by prevention of crashes in soon to be
landed editing delegate signals, which are covered by the layout tests.

  • bindings/gobject/GObjectEventListener.cpp: (WebCore::GObjectEventListener::GObjectEventListener): Updated the constructor. (WebCore::GObjectEventListener::~GObjectEventListener): Disconnect the weak reference if the GObject is still alive. (WebCore::GObjectEventListener::gobjectDestroyed): When the GObject is destroyed, disconnect the appropriate event listener. (WebCore::GObjectEventListener::handleEvent): Changes to reflect use of CString instead of WebCore string.
  • bindings/gobject/GObjectEventListener.h: (WebCore::GObjectEventListener::addEventListener): Changed create to addEventListener, so that the connection and disconnection is an internal contract to the class. (WebCore::GObjectEventListener::gobjectDestroyedCallback): Added.
  • bindings/scripts/CodeGeneratorGObject.pm: Modified the code generate to use GObjectEventListener::addEventListener and no longer call addEventListener on its own.
8:27 AM Changeset in webkit [71527] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
8:26 AM Changeset in webkit [71526] by mrobinson@webkit.org
  • 3 edits in trunk/LayoutTests

2010-11-08 Martin Robinson <mrobinson@igalia.com>

Skip failing tests and rebaseline another test after r71512.

  • platform/gtk/Skipped: Update the skipped list.
  • platform/gtk/svg/custom/use-property-synchronization-crash-expected.txt:
8:25 AM Changeset in webkit [71525] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

2010-11-08 Gabor Rapcsanyi <rgabor@inf.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

[NRWT] If the http lock fails we shouldn't do any locking
https://bugs.webkit.org/show_bug.cgi?id=49164

If something goes wrong with the locking, the test should keep going.

  • Scripts/webkitpy/layout_tests/port/http_lock.py:
7:50 AM Changeset in webkit [71524] by xan@webkit.org
  • 4 edits in trunk

2010-11-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

Update version numbers for release.

  • configure.ac:

WebKit/gtk:

2010-11-08 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

  • NEWS: update for release.
7:40 AM Changeset in webkit [71523] by kbalazs@webkit.org
  • 2 edits in trunk/LayoutTests

Skip plugins tests on Qt WebKit2 since we do
not have plugin support yet.

Rubber-stamped by Csaba Osztrogonac.

  • platform/qt-wk2/Skipped:
7:30 AM Changeset in webkit [71522] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-08 Stephen White <senorblanco@chromium.org>

Unreviewed; test expectations update.

Update chromium-gpu test_expectations after canvas/philip update, and
other fixes.

  • platform/chromium-gpu/test_expectations.txt:
7:19 AM Changeset in webkit [71521] by Adam Roben
  • 2 edits in trunk/WebCore

Windows Release build fix after r71514

The build was failing due to an alignment error. Strangely, depending
on the order of SVGStaticPropertyTearOff's members, the build will
either fail in Release (as it does before this change), or Debug (as it
did before r71514), but not both.

  • svg/properties/SVGStaticPropertyTearOff.h:

(WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff): Copied
the #pragma pack trick from JSSVGPODTypeWrapper.h, which has similar
issues.

7:09 AM Changeset in webkit [71520] by Csaba Osztrogonác
  • 8 edits in trunk/LayoutTests

Unreviewed. Update expectations.

[Qt] DRT sideeffect revealed by r71518
https://bugs.webkit.org/show_bug.cgi?id=49174

The previous expected results were wrong, because they were modified by this sideeffect.
New results were generated by: WebKitTools/Scripts/run-webkit-tests --reset-results --singly TEST_NAME

  • platform/qt/http/tests/navigation/error404-basic-expected.txt:
  • platform/qt/http/tests/navigation/error404-goback-expected.txt:
  • platform/qt/http/tests/navigation/error404-subframeload-expected.txt:
  • platform/qt/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-basic-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-frames-expected.txt:
  • platform/qt/http/tests/navigation/postredirect-goback1-expected.txt:
6:48 AM Changeset in webkit [71519] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected file after r71512.

  • platform/qt/svg/custom/use-property-synchronization-crash-expected.txt: updated.
6:31 AM Changeset in webkit [71518] by Csaba Osztrogonác
  • 120 edits
    1 copy
    264 adds in trunk/LayoutTests

[Qt] Unreviewed. Update/add expectations for passing editing/deleting/* tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/Skipped:
  • platform/qt/editing/deleting/4845371-expected.checksum: Added.
  • platform/qt/editing/deleting/4845371-expected.png: Added.
  • platform/qt/editing/deleting/4845371-expected.txt:
  • platform/qt/editing/deleting/4922367-expected.checksum: Added.
  • platform/qt/editing/deleting/4922367-expected.png: Added.
  • platform/qt/editing/deleting/4922367-expected.txt:
  • platform/qt/editing/deleting/5026848-1-expected.checksum: Added.
  • platform/qt/editing/deleting/5026848-1-expected.png: Added.
  • platform/qt/editing/deleting/5026848-1-expected.txt:
  • platform/qt/editing/deleting/5026848-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5026848-2-expected.png: Added.
  • platform/qt/editing/deleting/5026848-2-expected.txt:
  • platform/qt/editing/deleting/5026848-3-expected.checksum: Added.
  • platform/qt/editing/deleting/5026848-3-expected.png: Added.
  • platform/qt/editing/deleting/5026848-3-expected.txt:
  • platform/qt/editing/deleting/5032066-expected.checksum: Added.
  • platform/qt/editing/deleting/5032066-expected.png: Added.
  • platform/qt/editing/deleting/5032066-expected.txt:
  • platform/qt/editing/deleting/5091898-expected.checksum: Added.
  • platform/qt/editing/deleting/5091898-expected.png: Added.
  • platform/qt/editing/deleting/5091898-expected.txt:
  • platform/qt/editing/deleting/5099303-expected.checksum: Added.
  • platform/qt/editing/deleting/5099303-expected.png: Added.
  • platform/qt/editing/deleting/5099303-expected.txt:
  • platform/qt/editing/deleting/5115601-expected.checksum: Added.
  • platform/qt/editing/deleting/5115601-expected.png: Added.
  • platform/qt/editing/deleting/5115601-expected.txt:
  • platform/qt/editing/deleting/5126166-expected.checksum: Added.
  • platform/qt/editing/deleting/5126166-expected.png: Added.
  • platform/qt/editing/deleting/5126166-expected.txt:
  • platform/qt/editing/deleting/5144139-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5144139-2-expected.png: Added.
  • platform/qt/editing/deleting/5144139-2-expected.txt:
  • platform/qt/editing/deleting/5156801-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5156801-2-expected.png: Added.
  • platform/qt/editing/deleting/5156801-2-expected.txt:
  • platform/qt/editing/deleting/5168598-expected.checksum: Added.
  • platform/qt/editing/deleting/5168598-expected.png: Added.
  • platform/qt/editing/deleting/5168598-expected.txt:
  • platform/qt/editing/deleting/5206311-1-expected.checksum: Added.
  • platform/qt/editing/deleting/5206311-1-expected.png: Added.
  • platform/qt/editing/deleting/5206311-1-expected.txt:
  • platform/qt/editing/deleting/5206311-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5206311-2-expected.png: Added.
  • platform/qt/editing/deleting/5206311-2-expected.txt:
  • platform/qt/editing/deleting/5272440-expected.checksum: Added.
  • platform/qt/editing/deleting/5272440-expected.png: Added.
  • platform/qt/editing/deleting/5272440-expected.txt:
  • platform/qt/editing/deleting/5369009-expected.checksum: Added.
  • platform/qt/editing/deleting/5369009-expected.png: Added.
  • platform/qt/editing/deleting/5369009-expected.txt:
  • platform/qt/editing/deleting/5390681-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5390681-2-expected.png: Added.
  • platform/qt/editing/deleting/5390681-2-expected.txt:
  • platform/qt/editing/deleting/5390681-expected.checksum: Added.
  • platform/qt/editing/deleting/5390681-expected.png: Added.
  • platform/qt/editing/deleting/5433862-2-expected.checksum: Added.
  • platform/qt/editing/deleting/5433862-2-expected.png: Added.
  • platform/qt/editing/deleting/5433862-2-expected.txt: Added.
  • platform/qt/editing/deleting/5483370-expected.checksum: Added.
  • platform/qt/editing/deleting/5483370-expected.png: Added.
  • platform/qt/editing/deleting/5483370-expected.txt: Added.
  • platform/qt/editing/deleting/delete-3608445-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3608445-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3608445-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3775172-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3775172-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3775172-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3857753-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3857753-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3857753-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3865854-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3865854-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3865854-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3928305-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3928305-fix-expected.txt:
  • platform/qt/editing/deleting/delete-3959464-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-3959464-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/qt/editing/deleting/delete-4038408-fix-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-4038408-fix-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-002-expected.txt:
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-after-span-ws-003-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.png: Added.
  • platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-contents-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-contents-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-contents-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-002-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-003-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-004-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-005-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-006-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-007-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-008-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-009-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-011-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-023-expected.txt:
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png: Added.
  • platform/qt/editing/deleting/delete-block-merge-contents-024-expected.txt:
  • platform/qt/editing/deleting/delete-br-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-001-expected.txt:
  • platform/qt/editing/deleting/delete-br-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-002-expected.txt:
  • platform/qt/editing/deleting/delete-br-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-003-expected.txt:
  • platform/qt/editing/deleting/delete-br-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-004-expected.txt:
  • platform/qt/editing/deleting/delete-br-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-005-expected.txt:
  • platform/qt/editing/deleting/delete-br-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-006-expected.txt:
  • platform/qt/editing/deleting/delete-br-008-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-008-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-008-expected.txt:
  • platform/qt/editing/deleting/delete-br-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-009-expected.txt:
  • platform/qt/editing/deleting/delete-br-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-010-expected.txt:
  • platform/qt/editing/deleting/delete-br-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-012-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-012-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-013-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-013-expected.png: Added.
  • platform/qt/editing/deleting/delete-br-013-expected.txt: Added.
  • platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-br-in-last-table-cell-expected.png: Added.
  • platform/qt/editing/deleting/delete-by-word-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-by-word-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-by-word-001-expected.txt:
  • platform/qt/editing/deleting/delete-by-word-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-by-word-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-by-word-002-expected.txt:
  • platform/qt/editing/deleting/delete-character-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-character-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-character-001-expected.txt:
  • platform/qt/editing/deleting/delete-first-list-item-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-first-list-item-expected.png: Added.
  • platform/qt/editing/deleting/delete-first-list-item-expected.txt:
  • platform/qt/editing/deleting/delete-hr-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-hr-expected.png: Added.
  • platform/qt/editing/deleting/delete-hr-expected.txt:
  • platform/qt/editing/deleting/delete-image-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-001-expected.txt:
  • platform/qt/editing/deleting/delete-image-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-002-expected.txt:
  • platform/qt/editing/deleting/delete-image-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-003-expected.txt:
  • platform/qt/editing/deleting/delete-image-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-image-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-image-004-expected.txt:
  • platform/qt/editing/deleting/delete-line-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-001-expected.txt:
  • platform/qt/editing/deleting/delete-line-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-002-expected.txt:
  • platform/qt/editing/deleting/delete-line-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-003-expected.txt:
  • platform/qt/editing/deleting/delete-line-004-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-004-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-004-expected.txt:
  • platform/qt/editing/deleting/delete-line-005-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-005-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-005-expected.txt:
  • platform/qt/editing/deleting/delete-line-006-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-006-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-006-expected.txt:
  • platform/qt/editing/deleting/delete-line-007-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-007-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-007-expected.txt:
  • platform/qt/editing/deleting/delete-line-008-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-008-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-008-expected.txt:
  • platform/qt/editing/deleting/delete-line-009-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-009-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-009-expected.txt:
  • platform/qt/editing/deleting/delete-line-010-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-010-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-010-expected.txt:
  • platform/qt/editing/deleting/delete-line-011-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-011-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-011-expected.txt:
  • platform/qt/editing/deleting/delete-line-012-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-012-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-012-expected.txt:
  • platform/qt/editing/deleting/delete-line-013-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-013-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-013-expected.txt:
  • platform/qt/editing/deleting/delete-line-014-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-014-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-014-expected.txt:
  • platform/qt/editing/deleting/delete-line-015-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-015-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-015-expected.txt:
  • platform/qt/editing/deleting/delete-line-016-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-016-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-016-expected.txt:
  • platform/qt/editing/deleting/delete-line-017-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-017-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-017-expected.txt:
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-select-all-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-select-all-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-002-expected.txt:
  • platform/qt/editing/deleting/delete-select-all-003-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-select-all-003-expected.png: Added.
  • platform/qt/editing/deleting/delete-select-all-003-expected.txt:
  • platform/qt/editing/deleting/delete-selection-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-selection-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-selection-001-expected.txt:
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.png: Added.
  • platform/qt/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-line-009-expected.txt.
  • platform/qt/editing/deleting/delete-to-select-table-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/qt/editing/deleting/delete-to-select-table-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.png: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-001-expected.txt:
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.checksum: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/qt/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/qt/editing/deleting/list-item-1-expected.checksum: Added.
  • platform/qt/editing/deleting/list-item-1-expected.png: Added.
  • platform/qt/editing/deleting/list-item-1-expected.txt:
  • platform/qt/editing/deleting/merge-different-styles-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-different-styles-expected.png: Added.
  • platform/qt/editing/deleting/merge-different-styles-expected.txt:
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.png: Added.
  • platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt:
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Added.
  • platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt:
  • platform/qt/editing/deleting/merge-no-br-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-no-br-expected.png: Added.
  • platform/qt/editing/deleting/merge-no-br-expected.txt:
  • platform/qt/editing/deleting/merge-unrendered-space-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-unrendered-space-expected.png: Added.
  • platform/qt/editing/deleting/merge-unrendered-space-expected.txt:
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.checksum: Added.
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.png: Added.
  • platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/qt/editing/deleting/move-nodes-001-expected.checksum: Added.
  • platform/qt/editing/deleting/move-nodes-001-expected.png: Added.
  • platform/qt/editing/deleting/move-nodes-001-expected.txt:
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.checksum: Added.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Added.
  • platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.checksum: Added.
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.png: Added.
  • platform/qt/editing/deleting/pruning-after-merge-2-expected.txt:
  • platform/qt/editing/deleting/smart-delete-001-expected.checksum: Added.
  • platform/qt/editing/deleting/smart-delete-001-expected.png: Added.
  • platform/qt/editing/deleting/smart-delete-001-expected.txt:
  • platform/qt/editing/deleting/table-cells-expected.checksum: Added.
  • platform/qt/editing/deleting/table-cells-expected.png: Added.
  • platform/qt/editing/deleting/table-cells-expected.txt:
  • platform/qt/editing/deleting/type-delete-after-quote-expected.checksum: Added.
  • platform/qt/editing/deleting/type-delete-after-quote-expected.png: Added.
  • platform/qt/editing/deleting/type-delete-after-quote-expected.txt: Added.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.checksum: Added.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.png: Added.
  • platform/qt/editing/deleting/whitespace-pre-1-expected.txt:
6:20 AM Changeset in webkit [71517] by Adam Roben
  • 4 edits
    6 adds in trunk/LayoutTests

Update Windows results after r71465

  • platform/win/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/win/fast/blockflow/border-vertical-lr-expected.png:
  • platform/win/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/win/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/win/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/win/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/win/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/win/fast/blockflow/japanese-rl-selection-expected.txt: Added.
6:18 AM Changeset in webkit [71516] by Adam Roben
  • 2 edits in trunk/WebKitTools

Switch back to using kCGImageAlphaPremultipliedFirst when generating pixel dumps on Windows

I changed this behavior in r71418 thinking that it was required for
getting plugins to show up in pixel dumps. But it doesn't seem to be
necessary, and was making it impossible to compare new Windows pixel
dumps with existing Windows or Mac pixel dumps (because ImageDiff won't
compare an image with alpha to an image without alpha).

Fixes <http://webkit.org/b/49172> REGRESION (r71418): Can't compare
new Windows pixel results to existing Windows or Mac results

Reviewed by Antti Koivisto.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView): Replaced kCGImageAlphaNoneSkipFirst
with kCGImageAlphaPremultipliedFirst.

6:05 AM Changeset in webkit [71515] by yurys@chromium.org
  • 30 edits
    4 copies
    6 moves
    2 deletes in trunk/WebCore

2010-11-08 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: decouple ScriptArguments from ScriptCallStack
https://bugs.webkit.org/show_bug.cgi?id=48058

ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
The factory functions that allow to create ScriptCallStack from VM-specific
objects are defined in ScriptCallStackFactory.cpp.

ScriptArguments class is used for passing arguments from JS code to the native
part.

No new tests. This refactoring is covered with existing Console tests.

  • Android.jscbindings.mk:
  • Android.v8bindings.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSConsoleCustom.cpp: (WebCore::JSConsole::profile): (WebCore::JSConsole::profileEnd):
  • bindings/js/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/js/ScriptCallStack.cpp. (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
  • bindings/js/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
  • bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::~ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get):
  • bindings/js/ScriptState.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorV8.pm:
  • bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
  • bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::TestObjInternal::customArgsAndExceptionCallback):
  • bindings/v8/ScriptCallFrame.h: Removed.
  • bindings/v8/ScriptCallStack.h: Removed.
  • bindings/v8/ScriptCallStackFactory.cpp: Renamed from WebCore/bindings/v8/ScriptCallStack.cpp. (WebCore::toScriptCallFrame): (WebCore::toScriptCallFramesVector): (WebCore::createScriptCallStack): (WebCore::createScriptArguments): (WebCore::ScriptCallStack::stackTrace):
  • bindings/v8/ScriptCallStackFactory.h: Copied from WebCore/bindings/js/ScriptCallFrame.cpp.
  • bindings/v8/ScriptController.cpp: (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
  • bindings/v8/ScriptState.h: (WebCore::ScriptStateProtectedPtr::get):
  • bindings/v8/V8ConsoleMessage.cpp: (WebCore::V8ConsoleMessage::handler): (WebCore::V8ConsoleMessage::dispatchNow):
  • bindings/v8/V8ConsoleMessage.h:
  • bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::traceCallback): (WebCore::V8Console::assertCallback): (WebCore::V8Console::profileCallback): (WebCore::V8Console::profileEndCallback):
  • dom/NodeFilter.h:
  • inspector/ConsoleMessage.cpp: (WebCore::ConsoleMessage::ConsoleMessage): (WebCore::ConsoleMessage::addToFrontend): (WebCore::ConsoleMessage::updateRepeatCountInConsole): (WebCore::ConsoleMessage::isEqual):
  • inspector/ConsoleMessage.h:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::addMessageToConsole): (WebCore::InspectorController::startGroup):
  • inspector/InspectorController.h:
  • inspector/ScriptArguments.cpp: Copied from WebCore/bindings/v8/ScriptCallFrame.cpp. (WebCore::ScriptArguments::ScriptArguments): (WebCore::ScriptArguments::~ScriptArguments): (WebCore::ScriptArguments::argumentAt): (WebCore::ScriptArguments::globalState): (WebCore::ScriptArguments::getFirstArgumentAsString): (WebCore::ScriptArguments::isEqual):
  • inspector/ScriptArguments.h: Copied from WebCore/bindings/js/ScriptCallFrame.h. (WebCore::ScriptArguments::argumentCount):
  • inspector/ScriptCallFrame.cpp: Renamed from WebCore/bindings/v8/ScriptCallFrame.cpp. (WebCore::ScriptCallFrame::ScriptCallFrame): (WebCore::ScriptCallFrame::~ScriptCallFrame): (WebCore::ScriptCallFrame::isEqual): (WebCore::ScriptCallFrame::buildInspectorObject):
  • inspector/ScriptCallFrame.h: Renamed from WebCore/bindings/js/ScriptCallFrame.h. (WebCore::ScriptCallFrame::functionName): (WebCore::ScriptCallFrame::sourceURL): (WebCore::ScriptCallFrame::lineNumber):
  • inspector/ScriptCallStack.cpp: Renamed from WebCore/bindings/js/ScriptCallFrame.cpp. (WebCore::ScriptCallStack::ScriptCallStack): (WebCore::ScriptCallStack::~ScriptCallStack): (WebCore::ScriptCallStack::at): (WebCore::ScriptCallStack::size): (WebCore::ScriptCallStack::isEqual): (WebCore::ScriptCallStack::buildInspectorObject):
  • inspector/ScriptCallStack.h: Renamed from WebCore/bindings/js/ScriptCallStack.h.
  • page/Console.cpp: (WebCore::Console::addMessage): (WebCore::Console::debug): (WebCore::Console::error): (WebCore::Console::info): (WebCore::Console::log): (WebCore::Console::dir): (WebCore::Console::dirxml): (WebCore::Console::trace): (WebCore::Console::assertCondition): (WebCore::Console::count): (WebCore::Console::markTimeline): (WebCore::Console::profile): (WebCore::Console::profileEnd): (WebCore::Console::timeEnd): (WebCore::Console::group): (WebCore::Console::groupCollapsed): (WebCore::Console::shouldCaptureFullStackTrace): (WebCore::Console::warn):
  • page/Console.h: (WebCore::Console::profiles):
  • page/Console.idl:
6:00 AM Changeset in webkit [71514] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Build fix.


Attempt to fix windows builds after r71512. Swap order of members to avoid warning C4121.

  • svg/properties/SVGStaticPropertyTearOff.h: (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):
5:49 AM Changeset in webkit [71513] by mnaganov@chromium.org
  • 2 edits in trunk/WebCore

2010-11-08 Mikhail Naganov <mnaganov@chromium.org>

Unreviewed. Fix Qt build after r71511.

  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie):
5:43 AM Changeset in webkit [71512] by Nikolas Zimmermann
  • 40 edits
    4 adds
    3 deletes in trunk

2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49067

Remove SVGAnimatedPoints interface, not reachable through bindings anyway, it was just another MI interface, that
now has been integrated into SVGPolylineElement/SVGPolygonElement, simplfying the generation and avoiding virtual
calls in SVGPolylineElement/SVGPolygonElement.

Remove the need to use manual XML <-> SVG DOM synchronization. The points/animatedPoints methods now create
SVGListPropertyTearOffs, thus using the same synchronization/expose-to-bindings concept like all other
animated properties.

Convert SVGPoint/SVGPointList to use the new SVGPropertyTearOff concept, adapted all code, as SVGPointList
is now a plain Vector<FloatPoint>. Enable StrictTypeChecking for SVGPoint.

Test: svg/dom/SVGPoint.html

  • Android.derived.v8bindings.mk: Remove SVGAnimatedPoints (and IDL generation).
  • Android.mk: Ditto.
  • CMakeLists.txt: Ditto.
  • DerivedSources.make: Ditto.
  • GNUmakefile.am: Ditto. Add SVGStaticPropertyTearOff.h to build.
  • WebCore.gypi: Ditto.
  • WebCore.order: Remove SVGAnimatedPoints symbols.
  • WebCore.pro: Remove SVGAnimatedPoints (and IDL generation). Add SVGStaticPropertyTearOff.h to build.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOMSVG.h: Remove DOMSVGAnimatedPoints include.
  • bindings/scripts/CodeGenerator.pm: Adapt code converting SVGPoint/SVGPointList to use the new SVGPropertyTearOff concepts.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • rendering/SVGRenderTreeAsText.cpp: Adapt for SVGPolyElement API change, use pointList() instead of points() (which is only used for bindings now). (WebCore::operator<<):
  • svg/SVGAllInOne.cpp: Remove SVGAnimatedPoints.cpp.
  • svg/SVGAnimateElement.cpp: Adapt for SVGPointList API change, it's not refcounted anymore. (WebCore::SVGAnimateElement::calculateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues): (WebCore::SVGAnimateElement::applyResultsToTarget):
  • svg/SVGAnimateElement.h: Ditto.
  • svg/SVGAnimatedPoints.cpp: Removed.
  • svg/SVGAnimatedPoints.h: Removed.
  • svg/SVGAnimatedPoints.idl: Removed.
  • svg/SVGParserUtilities.cpp: Adapt for SVGPointList API change, it's not refcounted anymore. (WebCore::pointsListFromSVGData):
  • svg/SVGParserUtilities.h: Ditto.
  • svg/SVGPoint.idl: Remove PODType marker, and add StrictTypeChecking for x/y attributes.
  • svg/SVGPointList.cpp: SVGPointList is now a plain Vector<FloatPoint>, rewrite. (WebCore::SVGPointList::valueAsString): (WebCore::SVGPointList::createAnimated):
  • svg/SVGPointList.h: Ditto. (WebCore::SVGPointList::SVGPointList):
  • svg/SVGPolyElement.cpp: Remove manual SVG <-> XML DOM synchronization. Now handles through the SVGAnimatedPropertyTearOff concept. (WebCore::SVGPolyElement::parseMappedAttribute): (WebCore::SVGPolyElement::svgAttributeChanged): (WebCore::SVGPolyElement::synchronizeProperty): (WebCore::SVGPolyElement::synchronizePoints): (WebCore::SVGPolyElement::points): (WebCore::SVGPolyElement::animatedPoints):
  • svg/SVGPolyElement.h: Reindented. (WebCore::SVGPolyElement::pointList): (WebCore::SVGPolyElement::isValid): (WebCore::SVGPolyElement::supportsMarkers):
  • svg/SVGPolygonElement.cpp: Adapt for SVGPointList API change. (WebCore::SVGPolygonElement::toPathData):
  • svg/SVGPolygonElement.idl: Remove SVGAnimatedPoints inheritance.
  • svg/SVGPolylineElement.cpp: Adapt for SVGPointList API change. (WebCore::SVGPolylineElement::toPathData):
  • svg/SVGPolylineElement.idl: Remove SVGAnimatedPoints inheritance.
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentTranslate): Use updateCurrentTranslate(). (WebCore::SVGSVGElement::updateCurrentTranslate): Added, only used by the bindings, after changing a value of SVGStaticPropertyTearOff object.
  • svg/SVGSVGElement.h: (WebCore::SVGSVGElement::currentTranslate): Return reference to m_translation.
  • svg/properties/SVGPropertyTearOff.h: Made constructors protected, as SVGStaticPropertyTearOff inherits from it. (WebCore::SVGPropertyTearOff::commitChange):
  • svg/properties/SVGPropertyTraits.h: Add SVGPointList handing.
  • svg/properties/SVGStaticPropertyTearOff.h: Added. Used for SVGProperty types returned by attributes, that are not associated with a SVGAnimatedProperty. (SVGSVGElement::currentTranslate). (WebCore::SVGStaticPropertyTearOff::create): (WebCore::SVGStaticPropertyTearOff::commitChange): (WebCore::SVGStaticPropertyTearOff::SVGStaticPropertyTearOff):

2010-11-08 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

Convert SVGPoint/SVGPointList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49067

  • platform/mac/svg/custom/use-property-synchronization-crash-expected.txt: Cloned <polyline> now reports parsing problems as well.
  • svg/custom/polyline-points-crash-expected.txt: Update expectation.
  • svg/custom/polyline-points-crash.html: appendItem(null) now throws, catch exception.
  • svg/dom/points-parser.html: Fix failure reporting, use correct variable name.
5:38 AM Changeset in webkit [71511] by mnaganov@chromium.org
  • 10 edits in trunk/WebCore

2010-11-08 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Adam Barth.

Web Inspector [Chromium]: Make CPU profiling to survive navigation.

https://bugs.webkit.org/show_bug.cgi?id=48843

  • inspector/Inspector.idl:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::restoreInspectorStateFromCookie): (WebCore::InspectorController::reuseFrontend): (WebCore::InspectorController::disconnectFrontend): (WebCore::InspectorController::populateScriptObjects): (WebCore::InspectorController::restoreProfiler): (WebCore::InspectorController::didCommitLoad): (WebCore::InspectorController::startUserInitiatedProfiling): (WebCore::InspectorController::stopUserInitiatedProfiling):
  • inspector/InspectorController.h: (WebCore::InspectorController::startProfiling): (WebCore::InspectorController::stopProfiling):
  • inspector/InspectorProfilerAgent.cpp: (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling): (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
  • inspector/InspectorState.h:
  • inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.hasTemporaryProfile): (WebInspector.ProfilesPanel.prototype.hasProfile):
  • inspector/front-end/inspector.js: (WebInspector.setRecordingProfile):
3:58 AM Changeset in webkit [71510] by Csaba Osztrogonác
  • 6 edits in trunk

2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed, rolling out r71466.
http://trac.webkit.org/changeset/71466
https://bugs.webkit.org/show_bug.cgi?id=48865

It broke layout tests on GTK bots.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init): (webkit_web_view_set_group_name):

2010-11-08 Csaba Osztrogonac <Csaba Osztrogonác>

Unreviewed, rolling out r71466.
http://trac.webkit.org/changeset/71466
https://bugs.webkit.org/show_bug.cgi?id=48865

It broke layout tests on GTK bots.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (createWebView):
2:50 AM Changeset in webkit [71509] by Csaba Osztrogonác
  • 2 edits in trunk/WebKitTools

Enable running of Qt API tests on BuildBot
https://bugs.webkit.org/show_bug.cgi?id=49004

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-08
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
2:43 AM Changeset in webkit [71508] by reni@webkit.org
  • 6 edits
    50 adds in trunk

WebCore: SVGFEConvolveMatrixElement doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=47660

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.

Wrap orderX and orderY into the common order property according to the w3 standard and remove them from svnattrs.in.
The patch implements the orderXIdentifier and orderYIdentifier getter functions to reach
properly the orderX and orderY components of order property from SVG DOM.

Tests: svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html

svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html
svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html

  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::orderXIdentifier):
(WebCore::SVGFEConvolveMatrixElement::orderYIdentifier):

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/svgattrs.in:

LayoutTests: SVGFEConvolveMatrixElement doesn't support dynamic invalidation, when attributes change.
https://bugs.webkit.org/show_bug.cgi?id=47660

Patch by Renata Hodovan <reni@webkit.org> on 2010-11-08
Reviewed by Nikolas Zimmermann.

This patch contains the SVG DOM dynamic update tests of feConvolveMatrix and it
fixes the DOM test of order attribute because the product of order components should be equal the
size of the kernelMatrix.

  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.checksum: Added.
  • platform/mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.png: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop-expected.txt: Added.
  • svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html: Added.
  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-dom-order-attr.js:

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-bias-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-divisor-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-in-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop.js: Added.

(SVGNumberListToString):
(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-order-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetX-prop.js: Added.

(executeTest):

  • svg/dynamic-updates/script-tests/SVGFEConvolveMatrixElement-svgdom-targetY-prop.js: Added.

(executeTest):

2:28 AM Changeset in webkit [71507] by pfeldman@chromium.org
  • 3 edits in trunk/WebCore

2010-11-08 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: follow up to inspector commit.
https://bugs.webkit.org/show_bug.cgi?id=49130

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.reset):
  • inspector/front-end/inspector.css: (.event-bar):
2:12 AM Changeset in webkit [71506] by pfeldman@chromium.org
  • 6 edits in trunk/WebCore

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add more event listener breakpoint types, add support for regular breakpoint hit state, beautify hit rendering.
https://bugs.webkit.org/show_bug.cgi?id=49130

  • English.lproj/localizedStrings.js:
  • inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype.debuggerPaused): (WebInspector.Breakpoint.jsBreakpointId): (WebInspector.Breakpoint.prototype.get id):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.EventListenerBreakpointsSidebarPane): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel):
  • inspector/front-end/inspector.css: (#elements-sidebar): (.pane > .body): (#scripts-sidebar): (li.breakpoint-hit .breakpoint-hit-marker):
1:36 AM Changeset in webkit [71505] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

Since r71493:r71496, http/tests/misc/prefetch-purpose.html start failing on Mac

  • platform/chromium/test_expectations.txt:
1:12 AM Changeset in webkit [71504] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION (r71465): editing/selection/after-line-break.html fails
https://bugs.webkit.org/show_bug.cgi?id=49127

  • platform/qt/Skipped: editing/selection/after-line-break.html skipped until fix.
12:59 AM Changeset in webkit [71503] by abarth@webkit.org
  • 8 edits in trunk/WebCore

2010-11-08 Adam Barth <abarth@webkit.org>

Reviewed by Antti Koivisto.

Rename CachedResourceLoader::m_doc to CachedResourceLoader::m_document
https://bugs.webkit.org/show_bug.cgi?id=49163

The usual convention is to use "document", not "doc" to refer to the
document.

  • css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::cachedImage):
  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::shouldAllowExternalLoad):
  • loader/cache/CachedResourceLoader.cpp: (WebCore::CachedResourceLoader::CachedResourceLoader): (WebCore::CachedResourceLoader::frame): (WebCore::CachedResourceLoader::requestImage): (WebCore::CachedResourceLoader::canRequest): (WebCore::CachedResourceLoader::requestResource): (WebCore::CachedResourceLoader::printAccessDeniedMessage): (WebCore::CachedResourceLoader::preload): (WebCore::CachedResourceLoader::checkForPendingPreloads): (WebCore::CachedResourceLoader::requestPreload):
  • loader/cache/CachedResourceLoader.h: (WebCore::CachedResourceLoader::document):
  • loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::requestResource):
  • loader/loader.cpp: (WebCore::Loader::load): (WebCore::Loader::Host::servePendingRequests): (WebCore::Loader::Host::didFinishLoading): (WebCore::Loader::Host::didFail):
  • xml/XSLTProcessorLibxslt.cpp: (WebCore::docLoaderFunc):
12:42 AM Changeset in webkit [71502] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-11-08 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add clean-review-queue command to remove closed bugs from the webkit.org/pending-review
https://bugs.webkit.org/show_bug.cgi?id=49160

Bugzilla doesn't automatically remove r? when a bug gets closed.
This script takes care of that for webkit.org.

  • Scripts/webkitpy/common/net/bugzilla.py:
  • Scripts/webkitpy/tool/commands/upload.py:

Nov 7, 2010:

11:59 PM Changeset in webkit [71501] by abarth@webkit.org
  • 3 edits in trunk/WebCore

2010-11-07 Adam Barth <abarth@webkit.org>

Unreviewed. Remove some unneeded includes.

  • loader/FrameLoader.cpp:
  • loader/PlaceholderDocument.cpp:
10:54 PM Changeset in webkit [71500] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
10:46 PM Changeset in webkit [71499] by abarth@webkit.org
  • 53 edits
    2 moves in trunk

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • public/WebCache.h:
  • src/WebCache.cpp: (WebKit::ToResourceTypeStat): (WebKit::WebCache::setCapacities): (WebKit::WebCache::clear): (WebKit::WebCache::getUsageStats): (WebKit::WebCache::getResourceTypeStats):

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • Api/qwebpage.cpp:
  • Api/qwebsettings.cpp:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • webkit/webkitwebview.cpp:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebCache.cpp: (WebCache::statistics):
  • WebFrame.cpp:
  • WebView.cpp:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebView.cpp: (wxWebView::SetCachePolicy):
  • WebView.h:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • Misc/WebCache.mm: (+[WebCache statistics]):
  • WebCoreSupport/WebDeviceOrientationClient.mm: (WebDeviceOrientationClient::setController):
  • WebView/WebView.mm:

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

So sayeth the diagram.

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSImageValue.cpp:
  • dom/ContainerNode.cpp:
  • history/PageCache.cpp:
  • inspector/InspectorCSSStore.h:
  • inspector/InspectorResourceAgent.cpp:
  • loader/FrameLoader.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/Cache.cpp: Removed.
  • loader/cache/Cache.h: Removed.
  • loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved):
  • loader/cache/CachedFont.cpp:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: (WebCore::CachedImage::destroyDecodedData):
  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:
  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedScript.cpp: (WebCore::CachedScript::destroyDecodedData):
  • loader/cache/MemoryCache.cpp: Copied from WebCore/loader/cache/Cache.cpp. (WebCore::cache): (WebCore::MemoryCache::MemoryCache): (WebCore::MemoryCache::requestResource): (WebCore::MemoryCache::requestUserCSSStyleSheet): (WebCore::MemoryCache::revalidateResource): (WebCore::MemoryCache::revalidationSucceeded): (WebCore::MemoryCache::revalidationFailed): (WebCore::MemoryCache::resourceForURL): (WebCore::MemoryCache::deadCapacity): (WebCore::MemoryCache::liveCapacity): (WebCore::MemoryCache::pruneLiveResources): (WebCore::MemoryCache::pruneDeadResources): (WebCore::MemoryCache::setCapacities): (WebCore::MemoryCache::makeResourcePurgeable): (WebCore::MemoryCache::evict): (WebCore::MemoryCache::addCachedResourceLoader): (WebCore::MemoryCache::removeCachedResourceLoader): (WebCore::MemoryCache::lruListFor): (WebCore::MemoryCache::removeFromLRUList): (WebCore::MemoryCache::insertInLRUList): (WebCore::MemoryCache::resourceAccessed): (WebCore::MemoryCache::removeFromLiveDecodedResourcesList): (WebCore::MemoryCache::insertInLiveDecodedResourcesList): (WebCore::MemoryCache::addToLiveResourcesSize): (WebCore::MemoryCache::removeFromLiveResourcesSize): (WebCore::MemoryCache::adjustSize): (WebCore::MemoryCache::TypeStatistic::addResource): (WebCore::MemoryCache::getStatistics): (WebCore::MemoryCache::setDisabled): (WebCore::MemoryCache::dumpStats): (WebCore::MemoryCache::dumpLRULists):
  • loader/cache/MemoryCache.h: Copied from WebCore/loader/cache/Cache.h. (WebCore::MemoryCache::shouldMakeResourcePurgeableOnEviction):
  • loader/loader.cpp:
  • page/EventSource.cpp:
  • page/Settings.h:
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::createRequest):

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159

  • WebProcess/WebProcess.cpp:
  • WebProcess/mac/WebProcessMac.mm:
  • WebProcess/win/WebProcessWin.cpp:
9:57 PM Changeset in webkit [71498] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

Add failures for crbug 62298, 62299, 62301

  • platform/chromium/test_expectations.txt:
9:47 PM Changeset in webkit [71497] by eric@webkit.org
  • 3 edits in trunk/WebCore

2010-11-07 Eric Seidel <eric@webkit.org>

Unreviewed. Attempt to fix the windows build.

Move the rest of the cache-related files into loader/cache
https://bugs.webkit.org/show_bug.cgi?id=49156

  • WebCore.vcproj/WebCoreCommon.vsprops:
  • WebCore.vcproj/copyForwardingHeaders.cmd:
9:30 PM Changeset in webkit [71496] by eric@webkit.org
  • 9 edits
    20 moves in trunk

2010-11-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move the rest of the cache-related files into loader/cache
https://bugs.webkit.org/show_bug.cgi?id=49156

  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/CachePolicy.h: Removed.
  • loader/CachedCSSStyleSheet.cpp: Removed.
  • loader/CachedCSSStyleSheet.h: Removed.
  • loader/CachedFont.cpp: Removed.
  • loader/CachedFont.h: Removed.
  • loader/CachedImage.cpp: Removed.
  • loader/CachedImage.h: Removed.
  • loader/CachedResource.cpp: Removed.
  • loader/CachedResource.h: Removed.
  • loader/CachedResourceClient.h: Removed.
  • loader/CachedResourceClientWalker.cpp: Removed.
  • loader/CachedResourceClientWalker.h: Removed.
  • loader/CachedResourceHandle.cpp: Removed.
  • loader/CachedResourceHandle.h: Removed.
  • loader/CachedResourceLoader.cpp: Removed.
  • loader/CachedResourceLoader.h: Removed.
  • loader/CachedScript.cpp: Removed.
  • loader/CachedScript.h: Removed.
  • loader/CachedXSLStyleSheet.cpp: Removed.
  • loader/CachedXSLStyleSheet.h: Removed.
  • loader/cache/CachePolicy.h: Copied from WebCore/loader/CachePolicy.h.
  • loader/cache/CachedCSSStyleSheet.cpp: Copied from WebCore/loader/CachedCSSStyleSheet.cpp.
  • loader/cache/CachedCSSStyleSheet.h: Copied from WebCore/loader/CachedCSSStyleSheet.h.
  • loader/cache/CachedFont.cpp: Copied from WebCore/loader/CachedFont.cpp.
  • loader/cache/CachedFont.h: Copied from WebCore/loader/CachedFont.h.
  • loader/cache/CachedImage.cpp: Copied from WebCore/loader/CachedImage.cpp.
  • loader/cache/CachedImage.h: Copied from WebCore/loader/CachedImage.h.
  • loader/cache/CachedResource.cpp: Copied from WebCore/loader/CachedResource.cpp.
  • loader/cache/CachedResource.h: Copied from WebCore/loader/CachedResource.h.
  • loader/cache/CachedResourceClient.h: Copied from WebCore/loader/CachedResourceClient.h.
  • loader/cache/CachedResourceClientWalker.cpp: Copied from WebCore/loader/CachedResourceClientWalker.cpp.
  • loader/cache/CachedResourceClientWalker.h: Copied from WebCore/loader/CachedResourceClientWalker.h.
  • loader/cache/CachedResourceHandle.cpp: Copied from WebCore/loader/CachedResourceHandle.cpp.
  • loader/cache/CachedResourceHandle.h: Copied from WebCore/loader/CachedResourceHandle.h.
  • loader/cache/CachedResourceLoader.cpp: Copied from WebCore/loader/CachedResourceLoader.cpp.
  • loader/cache/CachedResourceLoader.h: Copied from WebCore/loader/CachedResourceLoader.h.
  • loader/cache/CachedScript.cpp: Copied from WebCore/loader/CachedScript.cpp.
  • loader/cache/CachedScript.h: Copied from WebCore/loader/CachedScript.h.
  • loader/cache/CachedXSLStyleSheet.cpp: Copied from WebCore/loader/CachedXSLStyleSheet.cpp.
  • loader/cache/CachedXSLStyleSheet.h: Copied from WebCore/loader/CachedXSLStyleSheet.h.
9:03 PM Changeset in webkit [71495] by morrita@google.com
  • 2 edits
    1 delete in trunk/LayoutTests

2010-11-07 MORITA Hajime <morrita@google.com>

Unreviewed test expectation rebaseline.

  • platform/chromium-win/fast/dom/HTMLMeterElement/meter-element-expected.txt: Removed. (It's now same as platform/win)
  • platform/chromium/test_expectations.txt:
8:44 PM Changeset in webkit [71494] by abarth@webkit.org
  • 5 edits in trunk

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename X-Purpose to Purpose
https://bugs.webkit.org/show_bug.cgi?id=47802

As requested by IETF HTTP WG. This patch is part of a larger movement
in the HTTP community to move away from X- headers. Various senior
folks at the IETF believe they're a failed experiment:

http://tools.ietf.org/html/draft-saintandre-xdash-considered-harmful

  • loader/loader.cpp: (WebCore::Loader::Host::servePendingRequests):

2010-11-07 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Rename X-Purpose to Purpose
https://bugs.webkit.org/show_bug.cgi?id=47802

Update expected results.

  • http/tests/misc/prefetch-purpose-expected.txt:
  • http/tests/misc/resources/prefetch-purpose.php:
8:32 PM Changeset in webkit [71493] by dbates@webkit.org
  • 2 edits in trunk/WebCore

2010-11-07 Daniel Bates <dbates@rim.com>

Reviewed by Adam Barth.

Assert that a non-null PassRefPtr<Document> has a non-null frame in Frame::setDocument()
https://bugs.webkit.org/show_bug.cgi?id=49152

Add an ASSERT to ensure that a non-null Document has a non-null Frame
in Frame::setDocument().

Currently, whenever Frame::setDocument() is called with a non-null
Document the Document has a non-null Frame. We should assert this
invariant.

  • page/Frame.cpp: (WebCore::Frame::setDocument):
8:09 PM Changeset in webkit [71492] by eric@webkit.org
  • 9 edits
    2 moves
    1 add in trunk/WebCore

2010-11-07 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move Cache.* into loader/cache in as a start to cleaning up loader/
https://bugs.webkit.org/show_bug.cgi?id=49153

  • Android.mk:
  • CMakeLists.txt:
  • GNUmakefile.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/cache/Cache.cpp: Renamed from WebCore/loader/Cache.cpp. (WebCore::cache): (WebCore::Cache::Cache): (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::revalidateResource): (WebCore::Cache::revalidationSucceeded): (WebCore::Cache::revalidationFailed): (WebCore::Cache::resourceForURL): (WebCore::Cache::deadCapacity): (WebCore::Cache::liveCapacity): (WebCore::Cache::pruneLiveResources): (WebCore::Cache::pruneDeadResources): (WebCore::Cache::setCapacities): (WebCore::Cache::makeResourcePurgeable): (WebCore::Cache::evict): (WebCore::Cache::addCachedResourceLoader): (WebCore::Cache::removeCachedResourceLoader): (WebCore::fastLog2): (WebCore::Cache::lruListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList): (WebCore::Cache::resourceAccessed): (WebCore::Cache::removeFromLiveDecodedResourcesList): (WebCore::Cache::insertInLiveDecodedResourcesList): (WebCore::Cache::addToLiveResourcesSize): (WebCore::Cache::removeFromLiveResourcesSize): (WebCore::Cache::adjustSize): (WebCore::Cache::TypeStatistic::addResource): (WebCore::Cache::getStatistics): (WebCore::Cache::setDisabled): (WebCore::Cache::dumpStats): (WebCore::Cache::dumpLRULists):
  • loader/cache/Cache.h: Renamed from WebCore/loader/Cache.h. (WebCore::Cache::LRUList::LRUList): (WebCore::Cache::TypeStatistic::TypeStatistic): (WebCore::Cache::loader): (WebCore::Cache::disabled): (WebCore::Cache::setPruneEnabled): (WebCore::Cache::prune): (WebCore::Cache::setDeadDecodedDataDeletionInterval): (WebCore::Cache::deadDecodedDataDeletionInterval): (WebCore::Cache::remove): (WebCore::Cache::shouldMakeResourcePurgeableOnEviction):
7:54 PM Changeset in webkit [71491] by ukai@chromium.org
  • 9 edits in trunk/WebKitTools

2010-11-07 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed, rolling out r71474.
http://trac.webkit.org/changeset/71474
https://bugs.webkit.org/show_bug.cgi?id=48280

breaks chromium webkit tests
https://bugs.webkit.org/show_bug.cgi?id=49151

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:52 PM Changeset in webkit [71490] by ukai@chromium.org
  • 1 edit
    5 deletes in trunk/WebKitTools

2010-11-07 Fumitoshi Ukai <ukai@chromium.org>

Unreviewed, rolling out r71475.
http://trac.webkit.org/changeset/71475

breaks chromium webkit tests
https://bugs.webkit.org/show_bug.cgi?id=49151

  • Scripts/webkitpy/common/newstringio.py: Removed.
  • Scripts/webkitpy/common/newstringio_unittest.py: Removed.
  • Scripts/webkitpy/common/system/executive_mock.py: Removed.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Removed.
  • Scripts/webkitpy/layout_tests/port/config_mock.py: Removed.
7:08 PM Changeset in webkit [71489] by andreas.kling@nokia.com
  • 2 edits in trunk/JavaScriptCore

2010-11-07 Sam Magnuson <smagnuson@netflix.com>

Reviewed by Andreas Kling.

[Qt] make install does not cause JavaScriptCore to be built
https://bugs.webkit.org/show_bug.cgi?id=49114

6:54 PM Changeset in webkit [71488] by andreas.kling@nokia.com
  • 5 edits in trunk

2010-11-05 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] box-shadow does not blur (is solid) when using border-radius
https://bugs.webkit.org/show_bug.cgi?id=46327

Implement blurred box-shadow when styling with border-radius.
This change is related to https://bugs.webkit.org/show_bug.cgi?id=44488

  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRoundedRect):

2010-11-05 Helder Correia <helder@sencha.com>

Reviewed by Andreas Kling.

[Qt] box-shadow does not blur (is solid) when using border-radius
https://bugs.webkit.org/show_bug.cgi?id=46327

Implement blurred box-shadow when styling with border-radius.
This change is related to https://bugs.webkit.org/show_bug.cgi?id=44488

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
6:31 PM Changeset in webkit [71487] by mdelaney@apple.com
  • 3 edits
    12 adds in trunk/LayoutTests

2010-11-07 Matthew Delaney <mdelaney@apple.com>

Reviewed by Andreas Kling.

Unskipping recently merged new philip canvas tests from SnowLeopard
https://bugs.webkit.org/show_bug.cgi?id=49147

  • platform/mac-leopard/Skipped: Moving skipped test list down to leopard.
  • platform/mac-snowleopard/canvas/philip/tests/*: All new tests' expectations.
  • platform/mac/Skipped: Unskipping tests from overall mac.
5:49 PM Changeset in webkit [71486] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-11-07 Helder Correia <helder@sencha.com>

Reviewed by Ariya Hidayat.

[Qt] Update the baseline for blur shadow test
https://bugs.webkit.org/show_bug.cgi?id=48223

Update basic-shadows test expected result with correct line segments.

  • platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
  • platform/qt/fast/box-shadow/basic-shadows-expected.png:
5:14 PM Changeset in webkit [71485] by andreas.kling@nokia.com
  • 3 edits in trunk/LayoutTests

2010-11-07 Andreas Kling <kling@webkit.org>

Unreviewed, skipping new canvas tests that are failing on Gtk+ and Qt.

Skip the following tests:

  • canvas/philip/tests/security.pattern.canvas.timing.html
  • canvas/philip/tests/security.pattern.create.html
  • canvas/philip/tests/security.pattern.cross.html
  • canvas/philip/tests/security.pattern.image.fillStyle.html
  • canvas/philip/tests/security.pattern.image.strokeStyle.html
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:38 PM Changeset in webkit [71484] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/WebCore

2010-11-07 John Reck <jreck@google.com>

Reviewed by Steve Block.

Implements navigator.language for Android
https://bugs.webkit.org/show_bug.cgi?id=49099

Android was previously hardcoding the value for WebCore::platformDefaultLanguage().
This patch removes the hardcoding and calls into the PlatformBridge to get the
correct language based off of the user's settings.

No new tests needed, this is already covered

  • Android.mk:
  • platform/android/LanguageAndroid.cpp: Added. (WebCore::platformDefaultLanguage):
  • platform/android/PlatformBridge.h:
  • platform/android/TemporaryLinkStubs.cpp:
7:25 AM Changeset in webkit [71483] by robert@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-07 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[qt] screenDepthPerComponent returns the wrong value

Return best estimate of the number of bits per color
rather than screen depth.

Add a layout test to sanity check screenDepthPerComponent.

https://bugs.webkit.org/show_bug.cgi?id=20289

  • fast/css/media-rule-screenDepthPerComponent-expected.txt: Added.
  • fast/css/media-rule-screenDepthPerComponent.html: Added.

2010-11-07 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[qt] screenDepthPerComponent returns the wrong value

Return best estimate of the number of bits per color
rather than screen depth.

Add a layout test to sanity check screenDepthPerComponent.

https://bugs.webkit.org/show_bug.cgi?id=20289

Test: fast/css/media-rule-screenDepthPerComponent.html

  • platform/qt/PlatformScreenQt.cpp: (WebCore::screenDepthPerComponent):
7:02 AM Changeset in webkit [71482] by andreas.kling@nokia.com
  • 52 edits in trunk/LayoutTests

2010-11-07 Andreas Kling <kling@webkit.org>

Unreviewed, rebaselining failures on Leopard and Snow Leopard after r71481.

  • canvas/philip/tests/2d.imageData.get.source.negative-expected.txt:
  • canvas/philip/tests/security.pattern.canvas.timing-expected.txt:
  • canvas/philip/tests/security.pattern.create-expected.txt:
  • canvas/philip/tests/security.pattern.cross-expected.txt:
  • canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
  • canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.broken-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.drawImage.null-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.front-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.cone.top-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside2-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.inside3-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.gradient.radial.outside1-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create1.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.create2.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.imageData.get.type-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.cap.closed-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.join.parallel-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.line.miter.lineedge-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.missingargs-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.path.rect.winding-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.broken-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.blur-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.x-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.enable.y-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.alpha-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.basic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.shadow.gradient.transparent.2-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.strokeRect.zero.4-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.bottom-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.hanging-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.ideographic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.middle-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.baseline.top-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.fill.maxWidth.fontface-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.end-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.nonspace-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.other-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.space-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.draw.space.collapse.start-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.basic-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.complex-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.invalid-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.size.percentage.default-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.font.parse.system-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/2d.text.measure.width.space-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt:
  • platform/mac-snowleopard/canvas/philip/tests/type.prototype-expected.txt:
5:49 AM Changeset in webkit [71481] by andreas.kling@nokia.com
  • 1568 edits
    53 adds in trunk/LayoutTests

2010-10-18 Andreas Kling <kling@webkit.org>

Reviewed by James Robinson.

Update our clone of Philip Taylor's canvas test suite
https://bugs.webkit.org/show_bug.cgi?id=47707

Source: http://dvcs.w3.org/hg/html/file/df23d00a3395/tests/submission/PhilipTaylor

  • canvas/philip/README: Added, contains link to upstream revision.
  • canvas/philip/: Synced with upstream.
  • platform/gtk/Skipped: Skipped new failing tests.
  • platform/mac/Skipped: Ditto.
  • platform/qt/Skipped: Ditto.
1:42 AM Changeset in webkit [71480] by jcivelli@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-07 Jay Civelli <jcivelli@chromium.org>

Reviewed by Kent Tamura.

Fixing a crasher with the select popup on Mac that happens when a
page removes the select node when the select changes.
https://bugs.webkit.org/show_bug.cgi?id=49108

  • src/ExternalPopupMenu.cpp: (WebKit::ExternalPopupMenu::didAcceptIndex): (WebKit::ExternalPopupMenu::didCancel):
1:24 AM Changeset in webkit [71479] by chang.shu@nokia.com
  • 9 edits in trunk

2010-11-07 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add a helper function to avoid duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=49085

  • dom/SelectElement.cpp:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable):
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultArrowEventHandler):
  • page/SpatialNavigation.cpp: (WebCore::isSpatialNavigationEnabled):
  • page/SpatialNavigation.h:

2010-11-07 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add a helper function to avoid duplicated code.
https://bugs.webkit.org/show_bug.cgi?id=49085

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent):

Nov 6, 2010:

11:43 PM Changeset in webkit [71478] by pfeldman@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Not reviewed. Chromium DevTools: disable filesystem inspection
until polished.
https://bugs.webkit.org/show_bug.cgi?id=48963

  • src/js/DevTools.js:
11:26 PM Changeset in webkit [71477] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Simon Fraser.

Web Inspector: Some image resources don't display the image when selected in the Resources panel.
https://bugs.webkit.org/show_bug.cgi?id=48935

Marked resources loaded from memory cache as finished.

  • inspector/front-end/ResourceManager.js: (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache):
11:23 PM Changeset in webkit [71476] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-06 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: XHR logging is not checked in context menu after browser restart.
https://bugs.webkit.org/show_bug.cgi?id=49133

  • inspector/InspectorState.cpp: (WebCore::InspectorState::InspectorState):
9:21 PM Changeset in webkit [71475] by dpranke@chromium.org
  • 1 edit
    5 adds in trunk/WebKitTools

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build fix.

Add files inexplicably not committed in r71474 as part of the
fix for bug 48280.

  • Scripts/webkitpy/common/newstringio.py: Added.
  • Scripts/webkitpy/common/newstringio_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive_mock.py: Added.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Added.
  • Scripts/webkitpy/layout_tests/port/config_mock.py: Added.
8:38 PM Changeset in webkit [71474] by dpranke@chromium.org
  • 9 edits in trunk/WebKitTools

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Siedel.

new-run-webkit-tests: update port/base and port/webkit to use the
new FileSystem and Config abstractions, pulling more logic out of
the base Port classes into separate, mockable objects.

Also create a MockFileSystem object, a MockConfig object, move
MockExecutive into common/system to be next to executive, and
update the config object to use a FileSystem.

https://bugs.webkit.org/show_bug.cgi?id=48280

  • Scripts/webkitpy/common/newstringio.py: Added.
  • Scripts/webkitpy/common/newstringio_unittest.py: Added.
  • Scripts/webkitpy/common/system/executive_mock.py: Added.
  • Scripts/webkitpy/common/system/filesystem_mock.py: Added.
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/config.py:
  • Scripts/webkitpy/layout_tests/port/config_mock.py:
  • Scripts/webkitpy/layout_tests/port/config_unittest.py:
  • Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
7:44 PM Changeset in webkit [71473] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Unreviewed, build breakage.

Apparently I uploaded the wrong version of the file to fix 49122
and neither Eric or I noticed - it was missing a dirname() call.
Fixing ...

https://bugs.webkit.org/show_bug.cgi?id=49122

  • Scripts/webkitpy/common/checkout/scm.py:
7:31 PM Changeset in webkit [71472] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-06 Dirk Pranke <dpranke@chromium.org>

Reviewed by Eric Seidel.

webkitpy/tool/* unittests change cwd and don't clean up properly

https://bugs.webkit.org/show_bug.cgi?id=49122

  • Scripts/webkitpy/common/checkout/scm.py:
6:23 PM Changeset in webkit [71471] by kbalazs@webkit.org
  • 2 edits in trunk/WebKit2

2010-11-06 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] WebKitTestRunner is dead
https://bugs.webkit.org/show_bug.cgi?id=49129

  • Platform/qt/SharedMemoryQt.cpp: (WebKit::SharedMemory::~SharedMemory): Avoid double deletion when deleteLater has already been called.
3:56 PM Changeset in webkit [71470] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-11-06 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed Windows build fix.

  • editing/EditingAllInOne.cpp: Added EditingStyle.cpp
2:19 PM Changeset in webkit [71469] by rniwa@webkit.org
  • 17 edits
    2 adds in trunk/WebCore

2010-11-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Bug 46335 - Add EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=46335

Added EditingStyle to WebCore/editing. This class is intended to encapsulate getPropertiesNotIn, removeNonEditingProperties,
editingStyleAtPosition, and prepareEditingStyleToApplyAt in ApplyStyleCommand.cpp once deployed everywhere.
Deployed it in typing styles.

No new tests are added since this is a refactoring in progress.

  • CMakeLists.txt: Added EditingStyle.cpp
  • GNUmakefile.am: Added EditingStyle.cpp and EditingStyle.h
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Calls editingStyleIncludingTypingStyle. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Uses EditingStyle.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::saveTypingStyleState): Ditto. (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Ditto.
  • editing/DeleteSelectionCommand.h:
  • editing/EditingStyle.cpp: Added. (WebCore::editingStyleFromComputedStyle): Added. (WebCore::EditingStyle::EditingStyle): Added. (WebCore::EditingStyle::init): Added; a clone of ApplyStyleCommand::editingStyleAtPosition. (WebCore::EditingStyle::removeTextFillAndStrokeColorsIfNeeded): Extracted from init. (WebCore::EditingStyle::replaceFontSizeByKeywordIfPossible): Extracted from init. (WebCore::EditingStyle::isEmpty): Added. (WebCore::EditingStyle::setStyle): Added. (WebCore::EditingStyle::clear): Added. (WebCore::EditingStyle::removeBlockProperties): Added. (WebCore::EditingStyle::prepareToApplyAt): Added. (WebCore::editingStyleIncludingTypingStyle): Added.
  • editing/EditingStyle.h: Added. (WebCore::EditingStyle::create): Added. (WebCore::EditingStyle::style): Added.
  • editing/RemoveFormatCommand.cpp: (WebCore::RemoveFormatCommand::doApply): Uses EditingStyle.
  • editing/SelectionController.h: (WebCore::SelectionController::typingStyle): Uses EditingStyle. (WebCore::SelectionController::clearTypingStyle): Uses EditingStyle. (WebCore::SelectionController::setTypingStyle): Uses EditingStyle.
  • rendering/style/RenderStyle.h: Added EditingStyle as a friend.
1:33 AM Changeset in webkit [71468] by Csaba Osztrogonác
  • 7 edits in trunk/LayoutTests

Unreviewed. Update Qt specific expected files after r71467.

  • platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum:
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.png:
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.txt:
  • platform/qt/fast/blockflow/background-vertical-lr-expected.checksum:
  • platform/qt/fast/blockflow/background-vertical-lr-expected.png:
  • platform/qt/fast/blockflow/background-vertical-lr-expected.txt:

Nov 5, 2010:

11:13 PM Changeset in webkit [71467] by ap@apple.com
  • 2 edits in trunk/WebKit/mac

2010-11-05 Alexey Proskuryakov <ap@apple.com>

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49100
ASSERT([self window]) fails in -[WebBaseNetscapePluginView restartTimers]

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView restartTimers]): Removed the assertion. Multiple callers provide no guarantee that the plug-in is still alive (see bug comments), and there seems to be no harm in executing this function in that case.
10:52 PM Changeset in webkit [71466] by commit-queue@webkit.org
  • 5 edits in trunk

2010-11-05 Nicolas Dufresne <nicolas.dufresne@collabora.co.uk>

Reviewed by Martin Robinson.

[GTK] Link with target name set does not work correctly
https://bugs.webkit.org/show_bug.cgi?id=48865

When a new page is created with a name (target=myFrame), the new
mainFrame could not be found because they where not stored in the
same PageGroup. As PageGroup are not exposed externally so the
simpliest solution is to use a global page group name. This also fixes
issue with visited link coloration across pages. After this change the
private function webkit_web_view_set_group_name() was no longer used
so it was removed completly.

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::closeWindowSoon):
  • webkit/webkitprivate.h:
  • webkit/webkitwebview.cpp: (webkit_web_view_init):
10:49 PM Changeset in webkit [71465] by hyatt@apple.com
  • 43 edits
    8 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=47237

Reviewed by Dan Bernstein and Simon Fraser.

Make selection work with vertical text. This patch fixes a bug in the computation of lineTop. For lines
with positive leading, lineTop was incorrectly including the top leading. Since the flipping of lines
for "lr" and "bt" writing modes involved flipping using lineTop and lineBottom, an incorrect lineTop meant
that those modes were mis-rendering. This is why the Japanese "lr" text examples have the first line smushed
too far against the border.

Fixing lineTop to no longer incorrectly include top leading has implications for editing. I ended up
rewriting positionForPoint to exactly match selection, since that seemed to be the most intuitive
behavior. I got rid of the verticalClickFudgeFactor and now just use selectionTop and selectionBottom
instead of lineTop and lineBottom. I am pretty sure the code used selectionTop in a previous incarnation
anyway and that I moved away from it when I implemented lineTop and lineBottom. The code then grew
more complicated from people trying to work with lineTop and lineBottom, but going back to selectionTop
and selectionBottom is the right behavior I think. One editing test has been updated after this change
(editing/selection/after-line-break.html), and one DOM test has been changed to not hit test past the
bottom of a line (fast/dom/Document/CaretRangeFromPoint/basic.html).

I patched selection painting of InlineTextBoxes so that the leading going up to the next line box is used
for "lr" and "bt" modes instead of the previous box. This makes sense for English text, but we may want
a different policy for Japanese text eventually (possibly just splitting the difference instead). Leaving it
this way for now, and we can collect feedback on the design.

I rewrote all of the selection gap painting code to be writing-mode aware. During the course of rewriting this
code I noticed a bug in the logicalLeftSelectionOffset and logicalRightSelectionOffset functions where there
was a coordinate space mismatch on a comparison. Fixing this improves the repaint/selection-clear.html test.

Added new tests in fast/blockflow/.

WebCore:

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionBottom):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):
(WebCore::RenderBlock::paintSelection):
(WebCore::clipOutPositionedObjects):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionOffset):
(WebCore::RenderBlock::logicalRightSelectionOffset):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::flipForWritingMode):

  • rendering/RenderBox.h:

(WebCore::RenderBox::logicalBottom):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):

  • rendering/RootInlineBox.h:

LayoutTests:

  • editing/selection/after-line-break-expected.txt:
  • fast/blockflow/japanese-lr-selection.html: Added.
  • fast/blockflow/japanese-rl-selection.html: Added.
  • fast/dom/Document/CaretRangeFromPoint/basic.html:
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/background-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/background-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/background-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/background-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-image-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/border-image-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/border-image-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-image-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/border-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.png:
  • platform/mac/fast/blockflow/box-shadow-horizontal-bt-expected.txt:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.png:
  • platform/mac/fast/blockflow/box-shadow-vertical-lr-expected.txt:
  • platform/mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-lr-selection-expected.txt: Added.
  • platform/mac/fast/blockflow/japanese-lr-text-expected.checksum:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.png:
  • platform/mac/fast/blockflow/japanese-lr-text-expected.txt:
  • platform/mac/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
  • platform/mac/fast/blockflow/japanese-rl-selection-expected.png: Added.
  • platform/mac/fast/blockflow/japanese-rl-selection-expected.txt: Added.
  • platform/mac/fast/repaint/selection-clear-expected.checksum:
  • platform/mac/fast/repaint/selection-clear-expected.png:
10:34 PM Changeset in webkit [71464] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-11-05 Simon Fraser <Simon Fraser>

Just put things back the way they were. Too many mysterious linker errors.

10:23 PM Changeset in webkit [71463] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-11-05 Simon Fraser <Simon Fraser>

Undo most of the previous commit since the compiler seems to have trouble
with an inlined operator++ in debug builds.

  • platform/DeprecatedPtrListImpl.cpp: (WebCore::DeprecatedPtrListImplIterator::operator++):
  • platform/DeprecatedPtrListImpl.h:
9:55 PM Changeset in webkit [71462] by Simon Fraser
  • 3 edits in trunk/WebCore

2010-11-05 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Inline some DeprecatedPtrListImplIterator methods for performance
https://bugs.webkit.org/show_bug.cgi?id=49124

This is a ~4% performance improvement on some Peacekeepr "Community" tests.

  • platform/DeprecatedPtrListImpl.cpp:
  • platform/DeprecatedPtrListImpl.h: (WebCore::DeprecatedListNode::DeprecatedListNode): (WebCore::DeprecatedPtrListImplIterator::current): (WebCore::DeprecatedPtrListImplIterator::operator++):
6:01 PM Changeset in webkit [71461] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale PNGs with color profiles don't decode properly on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=49110

Test that we decode gray-scale PNGs correctly. Sadly, this is a pixel
test. For ports that run pixel tests, we'll have to grab the pixels
off the bot.

  • fast/images/gray-scale-png-with-color-profile.html: Added.
  • fast/images/resources/mu.png: Added.
  • platform/mac/fast/images/gray-scale-png-with-color-profile-expected.txt: Added.

2010-11-05 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Gray-scale PNGs with color profiles don't decode properly on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=49110

Applying the color profile from this PNG was causing the image to
triple in width. This seems to be because both the PNG decoder and
CoreGraphics were trying to expand the gray-scale image to RGB. To fix
this issue, I've disabled color profile support for gray-scale PNGs.

Test: fast/images/gray-scale-png-with-color-profile.html

  • platform/image-decoders/png/PNGImageDecoder.cpp: (WebCore::PNGImageDecoder::headerAvailable):
5:42 PM Changeset in webkit [71460] by jianli@chromium.org
  • 2 edits in trunk/WebCore

2010-11-05 Jian Li <jianli@chromium.org>

Reviewed by Dmitry Titov.

Need to check if page is detached in Frame::transferChildFrameToNewDocument to avoid occasional crash
https://bugs.webkit.org/show_bug.cgi?id=49116

The fix is to add the check.

  • page/Frame.cpp: (WebCore::Frame::transferChildFrameToNewDocument):
5:14 PM Changeset in webkit [71459] by enrica@apple.com
  • 2 edits in trunk/WebCore

Pasting large amounts of plain text in a text area is very slow
https://bugs.webkit.org/show_bug.cgi?id=49040
<rdar://problem/7640912>

Reviewed by Adele Peterson.

The optimization consists in skipping the ApplyStyle command when
pasting into a text area or into an element that has -webkit-user-modify: read-write-plaintext-only.
The biggest performance hit comes from iterating through
a large number of paragraph when no style change is needed.
A further step will be to improve the paragraph iteration when it
can't be avoided.

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply): Check if the selection
is in a text form control or in an element that has -webkit-user-modify: read-write-plaintext-only
and force no style matching.

5:12 PM Changeset in webkit [71458] by cmarrin@apple.com
  • 11 edits in trunk

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

suspendAnimations/resumeAnimations not present in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49109

Got 4 tests out of the Skipped list that now pass

  • platform/mac-wk2/Skipped:

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

suspendAnimations/resumeAnimations not present in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49109

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::suspendAnimations): (WTR::LayoutTestController::resumeAnimations):
  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

suspendAnimations/resumeAnimations not present in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49109

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: (WKBundleFrameSuspendAnimations): (WKBundleFrameResumeAnimations):
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::suspendAnimations): (WebKit::WebFrame::resumeAnimations):
  • WebProcess/WebPage/WebFrame.h:
4:01 PM Changeset in webkit [71457] by dumi@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
  • platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
3:55 PM Changeset in webkit [71456] by andersca@apple.com
  • 13 edits
    2 adds in trunk/WebKit2

WebProcess won't kill itself if UIProcess goes away while WebProcess is spinning
https://bugs.webkit.org/show_bug.cgi?id=49090
<rdar://problem/7834575>

Reviewed by Darin Adler.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):
Call Client::didCloseOnConnectionWorkQueue.

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::Client::didCloseOnConnectionWorkQueue):
Add new client function. Will be called on the connection work queue when the connection is closed.

  • Platform/WorkItem.h:

(FunctionWorkItem0::FunctionWorkItem0):
(FunctionWorkItem0::execute):
(WorkItem::create):
Add a new WorkItem subclass that will invoke a C function.

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::scheduleWorkAfterDelay):
New function which will schedule the given work item to be executed in at least 'delay' seconds.

  • Platform/qt/WorkQueueQt.cpp:

(WorkQueue::scheduleWorkAfterDelay):
Add empty stub.

  • Platform/win/WorkQueueWin.cpp:

(WorkQueue::scheduleWorkAfterDelay):
Ditto.

  • PluginProcess/PluginProcess.h:

Derive from ChildProcess.

  • Shared/ChildProcess.cpp: Added.

(WebKit::ChildProcess::ChildProcess):
(WebKit::ChildProcess::~ChildProcess):
(WebKit::watchdogCallback):
Call _exit.

(WebKit::ChildProcess::didCloseOnConnectionWorkQueue):
When the connection is closed, schedule a work item to be run in 10 seconds. If the process hasn't
exited normally by then, we'll exit.

  • Shared/ChildProcess.h:

Add new ChildProcess class which is a common base class of WebProcess and PluginProcess and which contains
the watchdog timer logic.

  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebProcess.h:

Derive from ChildProcess.

  • win/WebKit2.vcproj:

Add new files.

3:47 PM Changeset in webkit [71455] by rniwa@webkit.org
  • 3 edits in trunk/WebCore

2010-11-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by David Levin.

JSCallbackData::invokeCallback triggers layout from a worker thread
https://bugs.webkit.org/show_bug.cgi?id=49096

Fixed the bug by only calling updateStyleForAllDocuments when the context is document in
JSCallbackData::invokeCallback.

No new tests are added since many of existing workers tests hit the added assertion in debug builds.

  • bindings/js/JSCallbackData.cpp: (WebCore::JSCallbackData::invokeCallback): No longer calls updateStyleForAllDocuments unconditionally.
  • dom/Document.cpp: (WebCore::Document::updateStyleIfNeeded): Added ASSERT(isMainThread()). (WebCore::Document::updateStyleForAllDocuments): Ditto. (WebCore::Document::updateLayout): Ditto.
3:47 PM Changeset in webkit [71454] by cmarrin@apple.com
  • 1 edit in trunk/LayoutTests/animations/stop-animation-on-suspend.html

Increased tolerance on test due to variability of timing on the bots

3:34 PM Changeset in webkit [71453] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] animations tests fails which uses suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=43905

  • platform/qt/Skipped:
    • animations/suspend-resume-animation-events.html added until fix.
    • animations/stop-animation-on-suspend.html added until fix.
3:00 PM Changeset in webkit [71452] by commit-queue@webkit.org
  • 6 edits in trunk

2010-11-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Querying selection start and end should be const
https://bugs.webkit.org/show_bug.cgi?id=48786

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::indexForVisiblePosition):
  • rendering/RenderTextControl.h:

2010-11-05 Ilya Sherman <isherman@chromium.org>

Reviewed by Simon Fraser.

Querying selection start and end should be const
https://bugs.webkit.org/show_bug.cgi?id=48786

  • public/WebInputElement.h:
  • src/WebInputElement.cpp: (WebKit::WebInputElement::selectionStart): (WebKit::WebInputElement::selectionEnd):
2:45 PM Changeset in webkit [71451] by cmarrin@apple.com
  • 20 edits in trunk

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • src/WebAnimationControllerImpl.cpp: (WebKit::WebAnimationControllerImpl::suspendAnimations): (WebKit::WebAnimationControllerImpl::resumeAnimations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::suspendAnimations): (DumpRenderTreeSupportQt::resumeAnimations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • webkit/webkitwebframe.cpp: (webkit_web_frame_suspend_animations): (webkit_web_frame_resume_animations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • WebFrame.cpp: (WebFrame::suspendAnimations): (WebFrame::resumeAnimations):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

  • WebView/WebFrame.mm: (-[WebFrame _suspendAnimations]): (-[WebFrame _resumeAnimations]):

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073

Changed the name of suspendAnimations/resumeAnimations to
suspendAnimationsInDocument/resumeAnimationsInDocument. These are no
longer exported, but have the same functionality as before. I then
added new suspendAnimations/resumeAnimations function which take
no params and suspend/resume on the frame owning the animation
controller and all its child frames. These are the functions that
are now exported. I then changed all the platform specific WebKit
code to use these functions.

  • WebCore.exp.in:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/animation/AnimationController.cpp: (WebCore::AnimationControllerPrivate::suspendAnimations): (WebCore::AnimationControllerPrivate::resumeAnimations):
2:41 PM Changeset in webkit [71450] by mihaip@chromium.org
  • 3 edits
    1 add in trunk/LayoutTests

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[Chromium] fast/events/stopPropagation-submit.html fails
https://bugs.webkit.org/show_bug.cgi?id=49078

The test was failing because of a difference between KURL and GURL in
how forms that have a data: URL action are handled*. Since the actual
test was testing something else (that stopPropagation does not prevent
form submissions), using a real page as the target makes the test
pass everywhere.

  • FWIW, it looks like GURL is right, per step 15 of section 4.10.22.3 (Form submission algorithm) of the HTML 5 spec, data URLs used with GET should not be mutated; filed bug 49091 about this.
  • fast/events/resources/stopPropagation-submit-target.html: Added.
  • fast/events/stopPropagation-submit.html:
  • platform/chromium/test_expectations.txt:
1:28 PM Changeset in webkit [71449] by zmo@google.com
  • 8 edits in trunk

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
https://bugs.webkit.org/show_bug.cgi?id=49020

  • src/WebGraphicsContext3DDefaultImpl.cpp: Remove DEPTH_STENCIL_ATTACHMENT emulation at this level.

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Need to simulate DEPTH_STENCIL in framebufferRenderbuffer / getFramebufferAttachmentParameter
https://bugs.webkit.org/show_bug.cgi?id=49020

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::getAttachment): Return the attached renderbuffer/texture. (WebCore::WebGLFramebuffer::isIncomplete): Add an extra parameter deciding whether we should check internal format matching the attachment point or not. (WebCore::WebGLFramebuffer::onAccess): Pass extra parameter in isIncomplete.
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::checkFramebufferStatus): Pass extra parameter in isIncomplete. (WebCore::WebGLRenderingContext::framebufferRenderbuffer): Emulate DEPTH_STENCIL_ATTACHMENT; re-attach previously conflicted buffers upon detachment. (WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter): Throw an error when conflicted attachments exist. (WebCore::WebGLRenderingContext::renderbufferStorage): Map DEPTH_STENCIL to DEPTH24_STENCIL8.
  • platform/graphics/Extensions3D.h: Add DEPTH24_STENCIL8 enum and update the documentation.
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::framebufferRenderbuffer): Remove emulation code at this level.
1:27 PM Changeset in webkit [71448] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed; test_expectations fix.

Remove three tests that are no longer flaky. Update a comment about a
test that fails due to V8 differences.

  • platform/chromium/test_expectations.txt:
1:26 PM Changeset in webkit [71447] by darin@chromium.org
  • 2 edits in trunk/WebKit/chromium

2010-11-05 Darin Fisher <darin@chromium.org>

Pull chromium@65229 to fix the build.

  • DEPS:
1:08 PM Changeset in webkit [71446] by mihaip@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectation update for fast/events/context-no-deselect.html.

Add missing chromium-linux expectations.

  • platform/chromium-linux/fast/events/context-no-deselect-expected.checksum: Added.
  • platform/chromium-linux/fast/events/context-no-deselect-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:55 PM Changeset in webkit [71445] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-05 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Keep a reference to the scrollbar in accessibility scrollbar.
https://bugs.webkit.org/show_bug.cgi?id=48896

  • accessibility/AccessibilityScrollbar.h: (WebCore::AccessibilityScrollbar::scrollbar):
12:42 PM Changeset in webkit [71444] by oliver@apple.com
  • 4 edits in trunk/JavaScriptCore

2010-11-05 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Website consistently crashing TOT in JIT::execute() on news.com.au
https://bugs.webkit.org/show_bug.cgi?id=48954

The problem here was the strict pass of this conversion was loading the
this structure into one register but doing the flags check off a different
register. This is clearly wrong. I have been unable to trigger the crash
with a reduction, but I've added an assertion to the this conversion to
attempt to make it more readily catchable in future.

  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_convert_this_strict):
  • jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_convert_this_strict):
  • jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION):
12:37 PM Changeset in webkit [71443] by tony@chromium.org
  • 3 edits in trunk/WebKitTools

2010-11-05 Tony Chang <tony@chromium.org>

Reviewed by David Levin.

cleanup style in TestNetscapePlugIn/PluginObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=49044

  • DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: (getPluginClass): (pluginGetProperty): (pluginSetProperty): (variantToIdentifier): (testCallback): (getURL): (getURLNotify): (testInvokeDefault): (testGetProperty): (testDocumentOpen): (testWindowOpen): (pluginInvoke): (handleCallback): (notifyStream):
  • DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
12:22 PM Changeset in webkit [71442] by chang.shu@nokia.com
  • 6 edits in trunk

2010-11-05 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add support for <select> element in single selection mode. We use space to
trigger arrow key handling for selection change or spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48937

  • fast/events/spatial-navigation/resources/spatial-navigation-utils.js: (doMove):
  • fast/events/spatial-navigation/snav-single-select-expected.txt:
  • fast/events/spatial-navigation/snav-single-select.html:

2010-11-05 Chang Shu <chang.shu@nokia.com>

Reviewed by Antonio Gomes.

Add support for <select> element in single selection mode. We use space to
trigger arrow key handling for selection change or spatial navigation.
https://bugs.webkit.org/show_bug.cgi?id=48937

  • dom/SelectElement.cpp: (WebCore::isSpatialNavigationEnabled): (WebCore::SelectElement::menuListDefaultEventHandler): (WebCore::SelectElement::listBoxDefaultEventHandler):
12:02 PM Changeset in webkit [71441] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-11-05 Eric Seidel <eric@webkit.org>

Reviewed by David Levin.

Add QueueStatusServer/init.py so others can run the QueueStatusServer tests
https://bugs.webkit.org/show_bug.cgi?id=49032

I wrote this file as part of bug 47847, but I forgot to commit it.
No one else noticed it missing because test-webkitpy knows how
to recover in the case where it can't import QueueStatusServer
(which generally occurs due to not having installed the AppEngine SDK).

  • QueueStatusServer/init.py: Added.
  • QueueStatusServer/model/workitems_unittest.py:
    • Remove a test which fails. This was probably landed (by me) from my other machine, which since this init.py was missing I never noticed the failure and landed this invalid test. Sadly we can't really test remove_work_item as it depends on .key() working. .key() will throw unless the object has already been saved it seems. This may be a mis-design in our remove_work_item implementation, but for now, just removing the test.
11:44 AM Changeset in webkit [71440] by darin@chromium.org
  • 3 edits in trunk/WebKit/chromium

2010-11-05 Darin Fisher <darin@chromium.org>

Reviewed by Nate Chapin.

Replace deprecated TargetIsSub{Frame,Resource} with TargetIsSub{frame,resource}.
https://bugs.webkit.org/show_bug.cgi?id=49074

  • public/WebURLRequest.h:
  • src/FrameLoaderClientImpl.cpp:
11:32 AM Changeset in webkit [71439] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update for fast/events/click-count.html; it's no longer slow since r46779 sped it up.

  • platform/chromium/test_expectations.txt:
11:25 AM Changeset in webkit [71438] by mihaip@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-05 Mihai Parparita <mihaip@chromium.org>

Unreviewed expectations update for fast/events/option-tab.html; it no longer crashes.

  • platform/chromium/test_expectations.txt:
11:24 AM Changeset in webkit [71437] by commit-queue@webkit.org
  • 4 edits in trunk

2010-11-05 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

Need to expose HistoryController::previousItem() for Chromium WebKit API.
https://bugs.webkit.org/show_bug.cgi?id=48809

  • loader/HistoryController.h:

2010-11-05 Charlie Reis <creis@chromium.org>

Reviewed by Darin Fisher.

WebFrame::previousHistoryItem() should return last committed item.
https://bugs.webkit.org/show_bug.cgi?id=48809

  • src/WebFrameImpl.cpp:
11:15 AM Changeset in webkit [71436] by Adam Roben
  • 2 edits in trunk/WebKit2

Implement PluginInfoStore::shouldUsePlugin on Windows

Fixes <http://webkit.org/b/43509> <rdar://problem/8273822> WebKit2
should refuse to load the same plugins that old-WebKit refuses to load

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::fileVersion): Helper function to construct a 64-bit file
version from two 32-bit numbers.
(WebKit::PluginInfoStore::getPluginInfo): Ported code from
WebCore::PluginPackage::fetchInfo to get the plugin's version. We now
store it in Plugin::fileVersion.

(WebKit::isOldWindowsMediaPlayerPlugin):
(WebKit::isNewWindowsMediaPlayerPlugin):
Added these helpers. The code came from
WebCore::PluginDatabase::getPluginPathsInDirectories.

(WebKit::PluginInfoStore::shouldUsePlugin): Implemented. The code was
ported from WebCore::PluginDatabase::getPluginPathsInDirectories and
WebCore::PluginPackage::isPluginBlacklisted.

11:14 AM Changeset in webkit [71435] by Adam Roben
  • 7 edits in trunk/WebKit2

Operate on m_plugins directly in PluginInfoStore::shouldUsePlugin

We'll need to operate on m_plugins if we ever want to unload an
already-loaded plugin before loading the new one.

Fixes <http://webkit.org/b/49076> loadedPlugins parameter to
PluginInfoStore::shouldUsePlugin is redundant

Reviewed by Anders Carlsson.

  • UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPlugin):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/gtk/PluginInfoStoreGtk.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):

  • UIProcess/Plugins/qt/PluginInfoStoreQt.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):

  • UIProcess/Plugins/win/PluginInfoStoreWin.cpp:

(WebKit::PluginInfoStore::shouldUsePlugin):
Removed the loadedPlugins parameter from shouldUsePlugin. The single
implementation (Mac) now uses m_plugins directly.

11:08 AM Changeset in webkit [71434] by bweinstein@apple.com
  • 4 edits in trunk

Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
https://bugs.webkit.org/show_bug.cgi?id=48751
<rdar://problem/8615536>

Reviewed by Anders Carlsson.

WebKit/win:

Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
an assert in the PluginStream destructor.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::finishedLoading):

LayoutTests:

Unskip userscripts/user-script-plugin-document.html because it is passing now.

  • platform/win/Skipped:
11:01 AM Changeset in webkit [71433] by bweinstein@apple.com
  • 4 edits
    1 add
    1 delete in trunk/LayoutTests

userscripts/user-script-*-document.html tests are flaky on Windows
https://bugs.webkit.org/show_bug.cgi?id=45980

Reviewed by Eric Carlson.

We can't use counting.mp4 as our video file to create a video document, because on Windows counting.mp4
is opened in Windows Explorer or Quicktime instead of Safari. This bug is being tracked by
<https://bugs.webkit.org/show_bug.cgi?id=25220>.

This patch switches user-script-video-document.html to use silence-loop.mov instead of counting.mp4,
which creates a video document on both Mac and Windows.

  • userscripts/resources/counting.mp4: Removed.
  • userscripts/resources/silence-loop.mov: Added.
  • userscripts/user-script-video-document-expected.txt:
  • userscripts/user-script-video-document.html:
10:58 AM Changeset in webkit [71432] by andersca@apple.com
  • 7 edits in trunk

Implement pluginElementNPObject
https://bugs.webkit.org/show_bug.cgi?id=49077

Reviewed by Adam Roben.

WebKit2:

  • PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::pluginElementNPObject):
Send the GetPluginElementNPObject message.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::getPluginElementNPObject):
Get the plug-in element NPObject and expose it to the other side of the connection.

  • WebProcess/Plugins/PluginProxy.messages.in:

Add GetPluginElementNPObject.

LayoutTests:

Remove now passing test.

  • platform/mac-snowleopard/Skipped:
10:43 AM Changeset in webkit [71431] by rniwa@webkit.org
  • 7 edits in trunk

2010-11-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Crash in ApplyStyleCommand::surroundNodeRangeWithElement
https://bugs.webkit.org/show_bug.cgi?id=48581

The crash was caused by a false assertion that we can always recover selection in
ApplyStyleCommand::removeInlineStyle. Fixed the crash by removing the assertion
and adding an early exit to the call site. Also converted raw pointers to RefPtr
in surroundNodeRangeWithElement and addInlineStyleIfNeeded.

Test (non-Mac platforms): editing/style/iframe-onload-crash.html

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): (WebCore::ApplyStyleCommand::removeInlineStyle): (WebCore::ApplyStyleCommand::surroundNodeRangeWithElement): (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
  • editing/ApplyStyleCommand.h:

2010-11-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

Re-enabled editing/style/iframe-onload-crash.html on Chromium, Qt, and Windows platforms.

  • platform/chromium/test_expectations.txt:
  • platform/qt/Skipped:
  • platform/win/Skipped:
10:38 AM Changeset in webkit [71430] by andersca@apple.com
  • 8 edits in trunk

Implement NP_RemoveProperty and NP_Enumerate
https://bugs.webkit.org/show_bug.cgi?id=49046

Reviewed by Oliver Hunt.

WebKit2:

  • Shared/Plugins/NPObjectMessageReceiver.cpp:

(WebKit::NPObjectMessageReceiver::removeProperty):
Call the removeProperty NPClass function.

(WebKit::NPObjectMessageReceiver::enumerate):
Call the enumerate NPClass function.

  • Shared/Plugins/NPObjectMessageReceiver.messages.in:

Add RemoveProperty and Enumerate messages.

  • Shared/Plugins/NPObjectProxy.cpp:

(WebKit::NPObjectProxy::removeProperty):
Send the RemoveProperty message.

(WebKit::NPObjectProxy::enumerate):
Send the Enumerate message.

(WebKit::NPObjectProxy::NP_RemoveProperty):
Call removeProperty.

(WebKit::NPObjectProxy::NP_Enumerate):
Call enumerate.

LayoutTests:

Remove now passing tests.

  • platform/mac-wk2/Skipped:
10:35 AM Changeset in webkit [71429] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-05 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium/test_expectations.txt:
10:25 AM Changeset in webkit [71428] by zmo@google.com
  • 2 edits in trunk/LayoutTests

2010-11-05 Zhenyao Mo <zmo@google.com>

Unreviewed, update webgl test expectations.

  • platform/chromium/test_expectations.txt:
10:05 AM Changeset in webkit [71427] by cmarrin@apple.com
  • 2 edits in trunk/WebKit/gtk

Fix for GTK build broken by http://trac.webkit.org/changeset/71424

10:02 AM Changeset in webkit [71426] by ap@apple.com
  • 8 edits in trunk

Reviewed by Darin Adler.

https://bugs.webkit.org/show_bug.cgi?id=49008
<rdar://problem/7906226> Frequent crashes on mail.yahoo.co.jp

WebCore:

Instance::m_runtimeObject used to be zeroed out by RuntimeObject destructor. But the
destructor may not be called immediately - GC first marks an object as dead, and only
destroys it when its cell is overwritten. So, m_runtimeObject would keep pointing to a dead
object.

Functions in JSPluginElementFunctions.cpp put the RuntimeObject on stack for later use,
but if it's already dead, it can be overwritten before use.

The solution is of course to use WeakGCPtr, which returns 0 for dead objects.

  • bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::Instance): (JSC::Bindings::Instance::~Instance): (JSC::Bindings::Instance::createRuntimeObject): (JSC::Bindings::Instance::willDestroyRuntimeObject): (JSC::Bindings::Instance::willInvalidateRuntimeObject):
  • bridge/jsc/BridgeJSC.h:
  • bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::~RuntimeObject): (JSC::Bindings::RuntimeObject::invalidate):

WebKit:

Callers of NetscapePluginInstanceProxy::waitForReply() are not prepared to be deleted during
the call, unless it returns 0. There are two reasons for NetscapePluginInstanceProxy to be
deleted during wait:

  • plugin crashed;
  • plugin was stopped (e.g. due to a DOM modification performed by another reply that came in while waiting).

We didn't recognize the latter.

  • Plugins/Hosted/NetscapePluginHostProxy.mm: (WebKit::PluginDestroyDeferrer::~PluginDestroyDeferrer):
  • Plugins/Hosted/NetscapePluginInstanceProxy.h: (WebKit::NetscapePluginInstanceProxy::waitForReply):
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::didCallPluginFunction):
9:55 AM Changeset in webkit [71425] by weinig@apple.com
  • 3 edits in trunk/WebKit2

Fix failing python tests.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
9:38 AM Changeset in webkit [71424] by cmarrin@apple.com
  • 12 edits
    3 adds in trunk

2010-11-05 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
https://bugs.webkit.org/show_bug.cgi?id=46945

Add new funtions to suspend and resume animations. The go through all subframes and suspend or resume them
recursively.

Test: animations/stop-animation-on-suspend.html

  • WebCore.exp.in:
  • page/Frame.cpp: (WebCore::Frame::suspendAnimations): (WebCore::Frame::resumeAnimations):
  • page/Frame.h:
9:18 AM Changeset in webkit [71423] by weinig@apple.com
  • 17 edits
    1 add in trunk/WebKit2

Generate the messages sent to the WebProcessProxy
https://bugs.webkit.org/show_bug.cgi?id=49062

Reviewed by Adam Roben..

  • Platform/CoreIPC/MessageID.h:

Temporarily add MessageClassWebProcessProxyLegacy while we still can't
support GetPluginProcessConnection (and deferred sync replies) in the
general mechanism.

  • Scripts/webkit2/messages.py:

Add support for WebCore::PluginData and WebKit::WebNavigationDataStore.

  • Shared/CoreIPCSupport/WebProcessProxyMessageKinds.h:

Remove now unused kinds. Rename to MessageClassWebProcessProxyLegacy.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getPluginPath):
(WebKit::WebProcessProxy::addBackForwardItem):
(WebKit::WebProcessProxy::didNavigateWithNavigationData):
(WebKit::WebProcessProxy::didPerformClientRedirect):
(WebKit::WebProcessProxy::didPerformServerRedirect):
(WebKit::WebProcessProxy::didUpdateHistoryTitle):
(WebKit::WebProcessProxy::didReceiveMessage):
(WebKit::WebProcessProxy::didReceiveSyncMessage):
(WebKit::WebProcessProxy::didDestroyFrame):

  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in: Added.

Move implementations to their own functions.

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
Change to use WebProcessProxyLegacyMessage.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory):
(WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebKit::WebFrameLoaderClient::setTitle):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::populatePluginCache):

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addVisitedLink):
(WebKit::WebProcess::removeWebFrame):
Use generated messages.

  • DerivedSources.make:
  • DerivedSources.pro:
  • WebKit2.pro:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj:

Add new files.

8:45 AM Changeset in webkit [71422] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-05 Stephen White <senorblanco@chromium.org>

Unreviewed; test_expectations fix.

Cleaning up the chromium-gpu test expectations after the switch to DRT.

  • platform/chromium-gpu/test_expectations.txt:
8:40 AM Changeset in webkit [71421] by Adam Roben
  • 3 edits
    2 adds in trunk/LayoutTests

Update expected results for two tests on Windows

  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.png:
  • platform/win/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/win/fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
7:59 AM Changeset in webkit [71420] by Csaba Osztrogonác
  • 1 edit
    57 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71382.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/table/027-vertical-expected.checksum: Added.
  • platform/qt/fast/table/027-vertical-expected.png: Added.
  • platform/qt/fast/table/027-vertical-expected.txt: Added.
  • platform/qt/fast/table/028-vertical-expected.checksum: Added.
  • platform/qt/fast/table/028-vertical-expected.png: Added.
  • platform/qt/fast/table/028-vertical-expected.txt: Added.
  • platform/qt/fast/table/035-vertical-expected.checksum: Added.
  • platform/qt/fast/table/035-vertical-expected.png: Added.
  • platform/qt/fast/table/035-vertical-expected.txt: Added.
  • platform/qt/fast/table/038-vertical-expected.checksum: Added.
  • platform/qt/fast/table/038-vertical-expected.png: Added.
  • platform/qt/fast/table/038-vertical-expected.txt: Added.
  • platform/qt/fast/table/040-vertical-expected.checksum: Added.
  • platform/qt/fast/table/040-vertical-expected.png: Added.
  • platform/qt/fast/table/040-vertical-expected.txt: Added.
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.png: Added.
  • platform/qt/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
  • platform/qt/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum: Added.
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.png: Added.
  • platform/qt/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/qt/fast/table/growCellForImageQuirk-vertical-expected.checksum: Added.
  • platform/qt/fast/table/growCellForImageQuirk-vertical-expected.png: Added.
  • platform/qt/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/qt/fast/table/height-percent-test-vertical-expected.checksum: Added.
  • platform/qt/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/qt/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/qt/fast/table/percent-widths-stretch-vertical-expected.checksum: Added.
  • platform/qt/fast/table/percent-widths-stretch-vertical-expected.png: Added.
  • platform/qt/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.png: Added.
  • platform/qt/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/qt/fast/table/table-display-types-vertical-expected.checksum: Added.
  • platform/qt/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/qt/fast/table/table-display-types-vertical-expected.txt: Added.
7:48 AM Changeset in webkit [71419] by Adam Roben
  • 2 edits in trunk/WebKitTools

Teach check-webkit-style about TestNetscapePlugIn

Fixes <http://webkit.org/b/49030> check-webkit-style is ignorant of
TestNetscapePlugIn's coding conventions

Reviewed by John Sullivan.

  • Scripts/webkitpy/style/checker.py: Lump TestNetscapePlugIn in with

WebKitAPITest and TestWebKitAPI in having different include order and
naming conventions than WebCore. Added some comments about why the
exceptions exist.

7:47 AM Changeset in webkit [71418] by Adam Roben
  • 4 edits
    8 adds in trunk

Add a test that shows that windowed plugins are able to paint

Somehow we never had a test for this before.

Fixes <http://webkit.org/b/49029> Should add a test that shows
windowed plugins can paint

Reviewed by Jon Honeycutt.

WebKitTools:

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/DrawsGradient.cpp: Added.

(DrawsGradient::DrawsGradient):
(DrawsGradient::wndProc): We handle the WM_PAINT and WM_PRINTCLIENT messages.

(DrawsGradient::onPaint):
(DrawsGradient::onPrintClient):
These both just call through to paint.

(DrawsGradient::paint): Fills our client area with some gradients.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Link

against Msimg32.lib for ::GradientFill and added DrawsGradient.

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView): Use WM_PRINT instead of
WM_PRINTCLIENT so that ::DefWindowProc will send
WM_PRINT/WM_PRINTCLIENT messages to the WebView's child windows.
Replaced kCGImageAlphaPremultipledFirst with kCGImageAlphaNoneSkipFirst
because GDI doesn't support alpha and kCGImageBitmapOrder32Little with
kCGImageBitmapOrder32Host because, who knows, maybe someday Windows
will run on a big-endian platform.

LayoutTests:

  • platform/win/platform/win/plugins/draws-gradient-expected.checksum: Added.
  • platform/win/platform/win/plugins/draws-gradient-expected.png: Added.
  • platform/win/platform/win/plugins/draws-gradient-expected.txt: Added.
  • platform/win/plugins/draws-gradient.html: Added.
7:46 AM Changeset in webkit [71417] by Adam Roben
  • 3 edits
    2 adds in trunk/WebKitTools

Extract much of NPNInvalidateRectInvalidatesWindow's code into a WindowedPluginTest base class

The base class takes care of subclassing the plugin's window so that a
custom WNDPROC is called. This will make it easier to write tests that
need to handle window messages.

Fixes <http://webkit.org/b/49028> It's hard to write a PluginTest with
a custom WNDPROC

Reviewed by Jon Honeycutt.

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:

(NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow):
(NPNInvalidateRectInvalidatesWindow::wndProc):
(NPNInvalidateRectInvalidatesWindow::testInvalidateRect):
Moved code from here to WindowedPluginTest. Changed to use window()
instead of m_window.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added WindowedPluginTest and added TestNetscapePlugIn/win to the
include path. Also reordered the include path to make a little more
sense and simplified the entry that added TestNetscapePlugIn itself to
the include path.

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp: Added.

(WindowedPluginTest::WindowedPluginTest):
(WindowedPluginTest::NPP_SetWindow):
(WindowedPluginTest::staticWndProc):

  • DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h: Added.

(WindowedPluginTest::window):
Code came from NPNInvalidateRectInvalidatesWindow.

7:46 AM Changeset in webkit [71416] by Adam Roben
  • 5 edits
    3 adds in trunk

Use a window region to clip windowed plugins

Fixes <http://webkit.org/b/49024> <rdar://problem/8487847> Windowed
plugins aren't clipped in WebKit2 on Windows

Reviewed by Jon Honeycutt.

WebKit2:

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::registerPluginView): Removed the CS_PARENTDC style. This style
makes Windows ignore the window region and always clip to the parent
window. Also pass WebKit.dll's HINSTANCE as part of the WNDCLASSW
struct so that the window class will be specific to WebKit.dll rather
than to WebKit2WebProcess.exe. This is useful for testing, but also
more pedantically correct.
(WebKit::setWindowRegion): Helper function to set a window region and
deal with ownership of the HRGN correctly.
(WebKit::NetscapePlugin::platformGeometryDidChange): Make an HRGN that
corresponds to m_clipRect and set it on the plugin's window.

WebKitTools:

Add a plugin test to show that windowed plugins are clipped correctly

  • DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp: Added.

(WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Initialize members.
(WindowRegionIsSetToClipRect::NPP_SetWindow): Check that our window
region matches the clip rect we know we should have based on
window-region-is-set-to-clip-rect.html, and check that our window class
doesn't have the CS_PARENTDC style.

  • DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:

Added WindowRegionIsSetToClipRect.

LayoutTests:

Add a test to show that windowed plugins are clipped correctly

  • platform/win/plugins/window-region-is-set-to-clip-rect-expected.txt: Added.
  • platform/win/plugins/window-region-is-set-to-clip-rect.html: Added.
7:29 AM Changeset in webkit [71415] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Crash in InspectorDOMAgent::innerParentNode.
https://bugs.webkit.org/show_bug.cgi?id=49054

  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::setOuterHTML):
7:25 AM Changeset in webkit [71414] by Csaba Osztrogonác
  • 1 edit
    72 adds in trunk/LayoutTests

Unreviewed.

[Qt] Add platform specific expected results for new passing tests.
Compared to Mac png files and Mac expected files.

  • platform/qt/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/qt/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/qt/fast/block/basic/truncation-rtl-expected.txt: Added.
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.png: Added.
  • platform/qt/fast/blockflow/background-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/blockflow/background-vertical-lr-expected.checksum: Added.
  • platform/qt/fast/blockflow/background-vertical-lr-expected.png: Added.
  • platform/qt/fast/blockflow/background-vertical-lr-expected.txt: Added.
  • platform/qt/fast/blockflow/background-vertical-rl-expected.checksum: Added.
  • platform/qt/fast/blockflow/background-vertical-rl-expected.png: Added.
  • platform/qt/fast/blockflow/background-vertical-rl-expected.txt: Added.
  • platform/qt/fast/blockflow/basic-vertical-line-expected.checksum: Added.
  • platform/qt/fast/blockflow/basic-vertical-line-expected.png: Added.
  • platform/qt/fast/blockflow/basic-vertical-line-expected.txt: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.png: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-blocked-expected.txt: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-expected.png: Added.
  • platform/qt/fast/blockflow/body-direction-propagation-expected.txt: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.png: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-blocked-expected.txt: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-expected.checksum: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-expected.png: Added.
  • platform/qt/fast/blockflow/body-writing-mode-propagation-expected.txt: Added.
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Added.
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/qt/fast/blockflow/border-radius-clipping-vertical-lr-expected.txt: Added.
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Added.
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.png: Added.
  • platform/qt/fast/blockflow/box-shadow-horizontal-bt-expected.txt: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-lr-expected.txt: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.png: Added.
  • platform/qt/fast/blockflow/box-shadow-vertical-rl-expected.txt: Added.
  • platform/qt/fast/blockflow/english-bt-text-expected.checksum: Added.
  • platform/qt/fast/blockflow/english-bt-text-expected.png: Added.
  • platform/qt/fast/blockflow/english-bt-text-expected.txt: Added.
  • platform/qt/fast/blockflow/english-lr-text-expected.checksum: Added.
  • platform/qt/fast/blockflow/english-lr-text-expected.png: Added.
  • platform/qt/fast/blockflow/english-lr-text-expected.txt: Added.
  • platform/qt/fast/blockflow/english-rl-text-expected.checksum: Added.
  • platform/qt/fast/blockflow/english-rl-text-expected.png: Added.
  • platform/qt/fast/blockflow/english-rl-text-expected.txt: Added.
  • platform/qt/fast/borders/border-radius-inline-flow-expected.checksum: Added.
  • platform/qt/fast/borders/border-radius-inline-flow-expected.png: Added.
  • platform/qt/fast/borders/border-radius-inline-flow-expected.txt: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.checksum: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
  • platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt: Added.
  • platform/qt/fast/dom/gc-10-expected.checksum: Added.
  • platform/qt/fast/dom/gc-10-expected.png: Added.
  • platform/qt/fast/dom/gc-10-expected.txt: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.checksum: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.checksum: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/qt/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.checksum: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
  • platform/qt/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/qt/svg/animations: Added.
  • platform/qt/svg/animations/repeatDur-zero-expected.checksum: Added.
  • platform/qt/svg/animations/repeatDur-zero-expected.png: Added.
  • platform/qt/svg/animations/repeatDur-zero-expected.txt: Added.
  • platform/qt/svg/custom/use-invalid-pattern-expected.checksum: Added.
  • platform/qt/svg/custom/use-invalid-pattern-expected.png: Added.
7:25 AM Changeset in webkit [71413] by pfeldman@chromium.org
  • 5 edits in trunk/WebCore

2010-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: XHR logging in console should give complete view of resource.
https://bugs.webkit.org/show_bug.cgi?id=48998

Drive-by fixes: linkify line number to scripts panel, fall back to resources;
enable multiline console entry on shift modifier as well.


7:01 AM Changeset in webkit [71412] by jorlow@chromium.org
  • 13 edits in trunk

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBTransactionBackend/Coordinator
https://bugs.webkit.org/show_bug.cgi?id=48425

Get rid of obsolete id and thus we don't need the factory method
on IDBTransactionCoordinator that creates IDBTransactionBackends.

Add an assert to IDBTransactionBackend to make sure we're not in
the coordinator and then remove the coordinators ref counting link
to the transaction.

Have the transaction backend zero out refs to the database when its
done using it.

Existing tests provide coverage for this refactoring.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::setVersion): (WebCore::IDBDatabaseBackendImpl::transaction):
  • storage/IDBTransactionBackendImpl.cpp: (WebCore::IDBTransactionBackendImpl::create): (WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::~IDBTransactionBackendImpl): (WebCore::IDBTransactionBackendImpl::abort): (WebCore::IDBTransactionBackendImpl::commit):
  • storage/IDBTransactionBackendImpl.h:
  • storage/IDBTransactionBackendInterface.h:
  • storage/IDBTransactionCoordinator.cpp: (WebCore::IDBTransactionCoordinator::didStartTransaction): (WebCore::IDBTransactionCoordinator::didFinishTransaction): (WebCore::IDBTransactionCoordinator::isActive): (WebCore::IDBTransactionCoordinator::processStartedTransactions):
  • storage/IDBTransactionCoordinator.h:

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

Clean up IDBTransactionBackend/Coordinator
https://bugs.webkit.org/show_bug.cgi?id=48425

Remove obsolete ::id() method.

  • public/WebIDBTransaction.h:
  • src/IDBTransactionBackendProxy.cpp:
  • src/IDBTransactionBackendProxy.h:
  • src/WebIDBTransactionImpl.cpp:
  • src/WebIDBTransactionImpl.h:
6:57 AM Changeset in webkit [71411] by jorlow@chromium.org
  • 5 edits in trunk/WebCore

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBFactoryBackend's reference to IDBDatabaseBackend should be weak
https://bugs.webkit.org/show_bug.cgi?id=48416

The factory's lifetime is that of the application, so without making
this weak, IDBDatabaseBackend's will never be closed until the app
terminates.

  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl): (WebCore::IDBDatabaseBackendImpl::~IDBDatabaseBackendImpl):
  • storage/IDBDatabaseBackendImpl.h: (WebCore::IDBDatabaseBackendImpl::create):
  • storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::removeIDBDatabaseBackend): (WebCore::IDBFactoryBackendImpl::removeSQLiteDatabase): (WebCore::IDBFactoryBackendImpl::open):
  • storage/IDBFactoryBackendImpl.h:
5:25 AM Changeset in webkit [71410] by alex
  • 36 edits in trunk/LayoutTests

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Unreviewed, apparently some forms tests need different results in
the bots after the removing the font hinting.

  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
  • platform/gtk/svg/in-html/circle-expected.txt:
5:03 AM Changeset in webkit [71409] by kbalazs@webkit.org
  • 4 edits
    2 adds in trunk/WebKit2

[Qt][WK2] Left over files and shared memory segments
https://bugs.webkit.org/show_bug.cgi?id=48985

Reviewed by Andreas Kling.

  • Platform/qt/SharedMemoryQt.cpp:

(WebKit::SharedMemory::create): Force deletion of the QSharedMemory
object on terminate by connecting QCoreApplication::aboutToQuit with
deleteLater. Add the object to the CrashHandler as well to release the
shared memory segment even on crash.
(WebKit::SharedMemory::~SharedMemory):

  • Shared/qt/CrashHandler.cpp: Added.

CrashHandler has a container for QObjects that we want to
destroy on crash. When we got a signal that we interpret as
a crash then it destroys those objects.
(WebKit::CrashHandler::CrashHandler):
(WebKit::CrashHandler::signalHandler):
(WebKit::CrashHandler::deleteObjects):

  • Shared/qt/CrashHandler.h: Added.

(WebKit::CrashHandler::instance):
(WebKit::CrashHandler::didDelete):
(WebKit::CrashHandler::markForDeletionOnCrash):

  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:

(WebKit::ProcessLauncherHelper::ProcessLauncherHelper):
Add the object itself to the CrashHandler to close the QLocalServer
even on crash. Without that the QLocalServer leaves over socket files on the disk.
(WebKit::ProcessLauncherHelper::~ProcessLauncherHelper):

  • WebKit2.pro:
4:53 AM Changeset in webkit [71408] by jorlow@chromium.org
  • 8 edits in trunk/WebCore

2010-10-27 Jeremy Orlow <jorlow@chromium.org>

Reviewed by Steve Block.

IDBObjectStoreBackend and IDBIndexBackend should not depend on IDBDatabaseBackend
https://bugs.webkit.org/show_bug.cgi?id=48410

Break dependency cyles between IDBDatabaseBackend and the other classes listed.
This was causing memory leaks.

  • storage/IDBCursorBackendImpl.cpp: (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl): (WebCore::IDBCursorBackendImpl::updateInternal): (WebCore::IDBCursorBackendImpl::removeInternal): (WebCore::IDBCursorBackendImpl::database):
  • storage/IDBCursorBackendImpl.h: (WebCore::IDBCursorBackendImpl::create):
  • storage/IDBDatabaseBackendImpl.cpp: (WebCore::IDBDatabaseBackendImpl::createObjectStore): (WebCore::IDBDatabaseBackendImpl::loadObjectStores):
  • storage/IDBIndexBackendImpl.cpp: (WebCore::IDBIndexBackendImpl::IDBIndexBackendImpl): (WebCore::IDBIndexBackendImpl::openCursorInternal): (WebCore::IDBIndexBackendImpl::sqliteDatabase):
  • storage/IDBIndexBackendImpl.h: (WebCore::IDBIndexBackendImpl::create): (WebCore::IDBIndexBackendImpl::storeName):
  • storage/IDBObjectStoreBackendImpl.cpp: (WebCore::IDBObjectStoreBackendImpl::IDBObjectStoreBackendImpl): (WebCore::IDBObjectStoreBackendImpl::createIndex): (WebCore::IDBObjectStoreBackendImpl::openCursorInternal): (WebCore::IDBObjectStoreBackendImpl::loadIndexes): (WebCore::IDBObjectStoreBackendImpl::sqliteDatabase):
  • storage/IDBObjectStoreBackendImpl.h: (WebCore::IDBObjectStoreBackendImpl::create):
4:44 AM Changeset in webkit [71407] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2010-11-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, skipping crashing svg test.

[GTK] svg/animations/animate-path-nested-transforms.html crashes
https://bugs.webkit.org/show_bug.cgi?id=49065

  • platform/gtk/Skipped:
4:36 AM Changeset in webkit [71406] by alex
  • 180 edits in trunk/LayoutTests

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Rebaseline the test results after removing the font hinting.

  • platform/gtk/http/tests/misc/slow-loading-mask-expected.txt:
  • platform/gtk/fast/multicol/float-multicol-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-complex-expected.txt:
  • platform/gtk/fast/multicol/float-paginate-expected.txt:
  • platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
  • platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/gtk/fast/multicol/margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/max-height-columns-block-expected.txt:
  • platform/gtk/fast/multicol/nested-columns-expected.txt:
  • platform/gtk/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/gtk/fast/multicol/positioned-split-expected.txt:
  • platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt:
  • platform/gtk/fast/multicol/shadow-breaking-expected.txt:
  • platform/gtk/fast/multicol/single-line-expected.txt:
  • platform/gtk/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/gtk/fast/multicol/table-margin-collapse-expected.txt:
  • platform/gtk/fast/multicol/table-vertical-align-expected.txt:
  • platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt:
  • platform/gtk/fast/overflow/line-clamp-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  • platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt:
  • platform/gtk/fast/repaint/block-no-inflow-children-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-child-of-transformed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-scroll-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset2-expected.txt:
  • platform/gtk/fast/repaint/layout-state-scrolloffset3-expected.txt:
  • platform/gtk/fast/repaint/selection-gap-overflow-scroll-2-expected.txt:
  • platform/gtk/fast/repaint/stacked-diacritics-expected.txt:
  • platform/gtk/fast/table/early-table-layout-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
  • platform/gtk/fast/table/fixed-table-with-small-percent-width-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-dynamic-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt:
  • platform/gtk/fast/text/backslash-to-yen-sign-expected.txt:
  • platform/gtk/fast/text/format-control-expected.txt:
  • platform/gtk/fast/text/international/bidi-mirror-he-ar-expected.txt:
  • platform/gtk/fast/text/international/bold-bengali-expected.txt:
  • platform/gtk/fast/text/international/plane2-expected.txt:
  • platform/gtk/fast/text/shadow-no-blur-expected.txt:
  • platform/gtk/fast/text/shadow-translucent-fill-expected.txt:
  • platform/gtk/fast/text/stroking-expected.txt:
  • platform/gtk/fonts/cursive-expected.txt:
  • platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
  • platform/gtk/fonts/default-expected.txt:
  • platform/gtk/fonts/fantasy-expected.txt:
  • platform/gtk/fonts/font-face-with-complex-text-expected.txt:
  • platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-bold-expected.txt:
  • platform/gtk/fonts/fontconfig-synthetic-oblique-expected.txt:
  • platform/gtk/fonts/monospace-expected.txt:
  • platform/gtk/fonts/sans-serif-expected.txt:
  • platform/gtk/fonts/serif-expected.txt:
  • platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
  • platform/gtk/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
  • platform/gtk/media/audio-controls-rendering-expected.txt:
  • platform/gtk/media/audio-no-installed-engines-expected.txt:
  • platform/gtk/media/controls-after-reload-expected.txt:
  • platform/gtk/media/controls-strict-expected.txt:
  • platform/gtk/media/video-display-toggle-expected.txt:
  • platform/gtk/media/video-empty-source-expected.txt:
  • platform/gtk/media/video-no-audio-expected.txt:
  • platform/gtk/media/video-replaces-poster-expected.txt:
  • platform/gtk/media/video-zoom-expected.txt:
  • platform/gtk/scrollbars/basic-scrollbar-expected.txt:
  • platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/gtk/scrollbars/disabled-scrollbar-expected.txt:
  • platform/gtk/scrollbars/overflow-scrollbar-combinations-expected.txt:
  • platform/gtk/scrollbars/scrollbar-buttons-expected.txt:
  • platform/gtk/scrollbars/scrollbar-orientation-expected.txt:
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
  • platform/gtk/svg/batik/text/textDecoration-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/broken-internal-references-expected.txt:
  • platform/gtk/svg/custom/bug45331-expected.txt:
  • platform/gtk/svg/custom/clone-element-with-animated-svg-properties-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt:
  • platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt:
  • platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt:
  • platform/gtk/svg/custom/mask-invalidation-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt:
  • platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt:
  • platform/gtk/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/gtk/svg/custom/recursive-gradient-expected.txt:
  • platform/gtk/svg/custom/recursive-pattern-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-content-with-resources-expected.txt:
  • platform/gtk/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/relative-sized-shadow-tree-content-expected.txt:
  • platform/gtk/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
  • platform/gtk/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/gtk/svg/custom/text-rotated-gradient-expected.txt:
  • platform/gtk/svg/custom/text-rotation-expected.txt:
  • platform/gtk/svg/custom/text-x-dy-lists-expected.txt:
  • platform/gtk/svg/custom/text-xy-updates-SVGList-expected.txt:
  • platform/gtk/svg/custom/use-font-face-crash-expected.txt:
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt:
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt:
  • platform/gtk/svg/filters/filter-width-update-expected.txt:
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt:
  • platform/gtk/svg/foreignObject/svg-document-in-html-document-expected.txt:
  • platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/gtk/svg/in-html/circle-expected.txt:
  • platform/gtk/svg/repaint/filter-repaint-expected.txt:
  • platform/gtk/svg/text/foreignObject-text-clipping-bug-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-4-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/gtk/svg/text/selection-background-color-expected.txt:
  • platform/gtk/svg/text/selection-doubleclick-expected.txt:
  • platform/gtk/svg/text/selection-styles-expected.txt:
  • platform/gtk/svg/text/selection-tripleclick-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/gtk/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-1-expected.txt:
  • platform/gtk/tables/layering/paint-test-layering-2-expected.txt:
  • platform/gtk/transforms/2d/compound-transforms-vs-containers-expected.txt:
  • platform/gtk/transforms/2d/hindi-rotated-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-fixed-container-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
  • platform/gtk/transforms/no_transform_hit_testing-expected.txt:
  • platform/gtk/transforms/svg-vs-css-expected.txt:
  • platform/gtk/transitions/move-after-transition-expected.txt:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt:
  • platform/gtk/transitions/transition-drt-api-expected.txt:
4:29 AM Changeset in webkit [71405] by alex
  • 387 edits in trunk/LayoutTests

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Rebaseline the test results after removing the font hinting.

  • platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
  • platform/gtk/editing/pasteboard/paste-xml-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/13804-expected.txt:
  • platform/gtk/editing/selection/4818145-expected.txt:
  • platform/gtk/editing/selection/4866671-expected.txt:
  • platform/gtk/editing/selection/4889598-expected.txt:
  • platform/gtk/editing/selection/4895428-2-expected.txt:
  • platform/gtk/editing/selection/4960116-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4983858-expected.txt:
  • platform/gtk/editing/selection/5007143-2-expected.txt:
  • platform/gtk/editing/selection/5007143-expected.txt:
  • platform/gtk/editing/selection/5057506-2-expected.txt:
  • platform/gtk/editing/selection/5057506-expected.txt:
  • platform/gtk/editing/selection/5076323-1-expected.txt:
  • platform/gtk/editing/selection/5076323-2-expected.txt:
  • platform/gtk/editing/selection/5076323-3-expected.txt:
  • platform/gtk/editing/selection/5081257-1-expected.txt:
  • platform/gtk/editing/selection/5081257-2-expected.txt:
  • platform/gtk/editing/selection/5099303-expected.txt:
  • platform/gtk/editing/selection/5109817-expected.txt:
  • platform/gtk/editing/selection/5131716-1-expected.txt:
  • platform/gtk/editing/selection/5131716-2-expected.txt:
  • platform/gtk/editing/selection/5131716-3-expected.txt:
  • platform/gtk/editing/selection/5131716-4-expected.txt:
  • platform/gtk/editing/selection/5232159-expected.txt:
  • platform/gtk/editing/selection/5234383-1-expected.txt:
  • platform/gtk/editing/selection/5234383-2-expected.txt:
  • platform/gtk/editing/selection/addRange-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-select-1-expected.txt:
  • platform/gtk/editing/selection/drag-text-delay-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-002-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-003-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-004-expected.txt:
  • platform/gtk/editing/selection/extend-by-character-005-expected.txt:
  • platform/gtk/editing/selection/extend-selection-expected.txt:
  • platform/gtk/editing/selection/fake-drag-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/inline-table-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-6-expected.txt:
  • platform/gtk/editing/selection/mixed-editability-7-expected.txt:
  • platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
  • platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-001-expected.txt:
  • platform/gtk/editing/selection/move-by-character-002-expected.txt:
  • platform/gtk/editing/selection/move-by-character-003-expected.txt:
  • platform/gtk/editing/selection/move-by-character-004-expected.txt:
  • platform/gtk/editing/selection/move-by-character-005-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
  • platform/gtk/editing/selection/move-by-sentence-linebreak-expected.txt:
  • platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
  • platform/gtk/editing/selection/range-between-block-and-inline-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/gtk/editing/selection/selectNode-expected.txt:
  • platform/gtk/editing/selection/selectNodeContents-expected.txt:
  • platform/gtk/editing/selection/selection-actions-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-1-expected.txt:
  • platform/gtk/editing/selection/wrapped-line-caret-2-expected.txt:
  • platform/gtk/editing/spelling/spelling-expected.txt:
  • platform/gtk/editing/style/4916887-expected.txt:
  • platform/gtk/editing/style/5017613-1-expected.txt:
  • platform/gtk/editing/style/5017613-2-expected.txt:
  • platform/gtk/editing/style/5046875-1-expected.txt:
  • platform/gtk/editing/style/5046875-2-expected.txt:
  • platform/gtk/editing/style/5084241-expected.txt:
  • platform/gtk/editing/style/5228141-expected.txt:
  • platform/gtk/editing/style/5279521-expected.txt:
  • platform/gtk/editing/style/apply-through-end-of-document-expected.txt:
  • platform/gtk/editing/style/block-style-003-expected.txt:
  • platform/gtk/editing/style/highlight-expected.txt:
  • platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
  • platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
  • platform/gtk/editing/style/typing-style-001-expected.txt:
  • platform/gtk/editing/style/typing-style-002-expected.txt:
  • platform/gtk/editing/undo/4063751-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-combined-delete-expected.txt:
  • platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-delete-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
  • platform/gtk/editing/undo/undo-forward-delete-expected.txt:
  • platform/gtk/fast/backgrounds/001-expected.txt:
  • platform/gtk/fast/backgrounds/animated-gif-as-background-expected.txt:
  • platform/gtk/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/gtk/fast/backgrounds/background-origin-root-element-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-1-expected.txt:
  • platform/gtk/fast/backgrounds/background-position-rounding-expected.txt:
  • platform/gtk/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
  • platform/gtk/fast/backgrounds/mask-composite-expected.txt:
  • platform/gtk/fast/backgrounds/opacity-on-document-element-expected.txt:
  • platform/gtk/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • platform/gtk/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/gtk/fast/backgrounds/size/backgroundSize16-expected.txt:
  • platform/gtk/fast/backgrounds/size/zero-expected.txt:
  • platform/gtk/fast/backgrounds/solid-color-context-restore-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/gtk/fast/block/positioning/absolute-positioning-no-scrollbar-expected.txt:
  • platform/gtk/fast/blockflow/fieldsets-expected.txt:
  • platform/gtk/fast/borders/block-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/border-color-inherit-expected.txt:
  • platform/gtk/fast/borders/border-fit-expected.txt:
  • platform/gtk/fast/borders/border-image-border-radius-expected.txt:
  • platform/gtk/fast/borders/border-radius-constraints-expected.txt:
  • platform/gtk/fast/borders/border-radius-huge-assert-expected.txt:
  • platform/gtk/fast/borders/border-radius-split-inline-expected.txt:
  • platform/gtk/fast/borders/borderRadiusAllStylesAllCorners-expected.txt:
  • platform/gtk/fast/borders/borderRadiusInvalidColor-expected.txt:
  • platform/gtk/fast/borders/different-color-borders-expected.txt:
  • platform/gtk/fast/borders/inline-mask-overlay-image-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-2-expected.txt:
  • platform/gtk/fast/borders/svg-as-border-image-expected.txt:
  • platform/gtk/fast/box-shadow/basic-shadows-expected.txt:
  • platform/gtk/fast/box-shadow/border-radius-big-expected.txt:
  • platform/gtk/fast/box-shadow/inset-expected.txt:
  • platform/gtk/fast/box-shadow/transform-fringing-expected.txt:
  • platform/gtk/fast/canvas/setWidthResetAfterForcedRender-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-1-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-2-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-3-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-4-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-5-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-6-expected.txt:
  • platform/gtk/fast/canvas/shadow-offset-7-expected.txt:
  • platform/gtk/fast/canvas/toDataURL-alpha-expected.txt:
  • platform/gtk/fast/css-generated-content/after-duplicated-after-split-expected.txt:
  • platform/gtk/fast/css/compare-content-style-expected.txt:
  • platform/gtk/fast/css/css3-space-in-nth-and-lang-expected.txt:
  • platform/gtk/fast/css/first-letter-first-line-hover-expected.txt:
  • platform/gtk/fast/css/first-letter-punctuation-expected.txt:
  • platform/gtk/fast/css/font-face-opentype-expected.txt:
  • platform/gtk/fast/css/inline-element-line-break-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt:
  • platform/gtk/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
  • platform/gtk/fast/css/pseudo-element-line-break-expected.txt:
  • platform/gtk/fast/css/rtl-to-viewport-expected.txt:
  • platform/gtk/fast/css/shadow-multiple-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/transformed-mask-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dynamic/window-resize-scrollbars-test-expected.txt:
  • platform/gtk/fast/dynamic/window-scrollbars-test-expected.txt:
  • platform/gtk/fast/events/event-sender-mouse-moved-expected.txt:
  • platform/gtk/fast/events/keydown-1-expected.txt:
  • platform/gtk/fast/events/mouseout-dead-node-expected.txt:
  • platform/gtk/fast/events/standalone-image-drag-to-editable-expected.txt:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/006-expected.txt:
  • platform/gtk/fast/forms/007-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label01-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label02-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label03-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label04-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label05-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label06-expected.txt:
  • platform/gtk/fast/forms/HTMLOptionElement_label07-expected.txt:
  • platform/gtk/fast/forms/basic-buttons-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/blankbuttons-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-align-expected.txt:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/gtk/fast/forms/button-default-title-expected.txt:
  • platform/gtk/fast/forms/button-generated-content-expected.txt:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/button-sizes-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/button-submit-expected.txt:
  • platform/gtk/fast/forms/button-table-styles-expected.txt:
  • platform/gtk/fast/forms/button-text-transform-expected.txt:
  • platform/gtk/fast/forms/button-white-space-expected.txt:
  • platform/gtk/fast/forms/caret-rtl-expected.txt:
  • platform/gtk/fast/forms/checkbox-radio-onchange-expected.txt:
  • platform/gtk/fast/forms/control-clip-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/encoding-test-expected.txt:
  • platform/gtk/fast/forms/fieldset-align-expected.txt:
  • platform/gtk/fast/forms/fieldset-with-float-expected.txt:
  • platform/gtk/fast/forms/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/float-before-fieldset-expected.txt:
  • platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
  • platform/gtk/fast/forms/form-added-to-table-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/form-hides-table-expected.txt:
  • platform/gtk/fast/forms/form-in-malformed-markup-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/hidden-input-file-expected.txt:
  • platform/gtk/fast/forms/hidden-listbox-expected.txt:
  • platform/gtk/fast/forms/image-border-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-align-expected.txt:
  • platform/gtk/fast/forms/input-align-image-expected.txt:
  • platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
  • platform/gtk/fast/forms/input-appearance-focus-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
  • platform/gtk/fast/forms/input-appearance-selection-expected.txt:
  • platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
  • platform/gtk/fast/forms/input-appearance-width-expected.txt:
  • platform/gtk/fast/forms/input-baseline-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-disabled-color-expected.txt:
  • platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
  • platform/gtk/fast/forms/input-first-letter-expected.txt:
  • platform/gtk/fast/forms/input-no-renderer-expected.txt:
  • platform/gtk/fast/forms/input-paste-undo-expected.txt:
  • platform/gtk/fast/forms/input-placeholder-focus-twice-expected.txt:
  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/gtk/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/gtk/fast/forms/input-readonly-empty-expected.txt:
  • platform/gtk/fast/forms/input-spaces-expected.txt:
  • platform/gtk/fast/forms/input-table-expected.txt:
  • platform/gtk/fast/forms/input-text-click-inside-expected.txt:
  • platform/gtk/fast/forms/input-text-click-outside-expected.txt:
  • platform/gtk/fast/forms/input-text-double-click-expected.txt:
  • platform/gtk/fast/forms/input-text-drag-down-expected.txt:
  • platform/gtk/fast/forms/input-text-option-delete-expected.txt:
  • platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/gtk/fast/forms/input-text-word-wrap-expected.txt:
  • platform/gtk/fast/forms/input-type-change-expected.txt:
  • platform/gtk/fast/forms/input-type-change2-expected.txt:
  • platform/gtk/fast/forms/input-type-text-min-width-expected.txt:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/isindex-placeholder-expected.txt:
  • platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/gtk/fast/forms/listbox-scrollbar-incremental-load-expected.txt:
  • platform/gtk/fast/forms/listbox-width-change-expected.txt:
  • platform/gtk/fast/forms/menulist-clip-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-option-wrap-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/minWidthPercent-expected.txt:
  • platform/gtk/fast/forms/negativeLineHeight-expected.txt:
  • platform/gtk/fast/forms/option-index-expected.txt:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/password-placeholder-text-security-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/placeholder-stripped-expected.txt:
  • platform/gtk/fast/forms/plaintext-mode-2-expected.txt:
  • platform/gtk/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/gtk/fast/forms/radio-attr-order-expected.txt:
  • platform/gtk/fast/forms/radio-nested-labels-expected.txt:
  • platform/gtk/fast/forms/radio_checked-expected.txt:
  • platform/gtk/fast/forms/radio_checked_dynamic-expected.txt:
  • platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-placeholder-value-changed-expected.txt:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-transformed-expected.txt:
  • platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
  • platform/gtk/fast/forms/search-zoomed-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-block-background-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-size-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-change-popup-to-listbox-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-display-none-style-resolve-expected.txt:
  • platform/gtk/fast/forms/select-empty-option-height-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-item-background-clip-expected.txt:
  • platform/gtk/fast/forms/select-list-box-with-height-expected.txt:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-size-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/slider-padding-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/forms/text-style-color-expected.txt:
  • platform/gtk/fast/forms/textAreaLineHeight-expected.txt:
  • platform/gtk/fast/forms/textarea-align-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-attribute-expected.txt:
  • platform/gtk/fast/forms/textarea-placeholder-set-value-expected.txt:
  • platform/gtk/fast/forms/textarea-scroll-height-expected.txt:
  • platform/gtk/fast/forms/textarea-scrollbar-expected.txt:
  • platform/gtk/fast/forms/textarea-scrolled-type-expected.txt:
  • platform/gtk/fast/forms/textarea-setinnerhtml-expected.txt:
  • platform/gtk/fast/forms/textarea-width-expected.txt:
  • platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
  • platform/gtk/fast/forms/textfield-outline-expected.txt:
  • platform/gtk/fast/forms/thumbslider-crash-expected.txt:
  • platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/contentWindow_Frame-expected.txt:
  • platform/gtk/fast/frames/contentWindow_iFrame-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-advanced-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-grid-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframe-resize-expected.txt:
  • platform/gtk/fast/frames/flattening/frameset-flattening-subframesets-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/frame-navigation-expected.txt:
  • platform/gtk/fast/frames/frame-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/frameElement-frame-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/frameset-style-recalc-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/inline-object-inside-frameset-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/gradients/radial-centered-expected.txt:
  • platform/gtk/fast/images/imagemap-focus-ring-expected.txt:
  • platform/gtk/fast/images/svg-background-partial-redraw-expected.txt:
  • platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
  • platform/gtk/fast/inline/inline-focus-ring-expected.txt:
  • platform/gtk/fast/layers/remove-only-this-layer-update-expected.txt:
  • platform/gtk/fast/lists/drag-into-marker-expected.txt:
  • platform/gtk/fast/multicol/border-padding-pagination-expected.txt:
  • platform/gtk/fast/multicol/client-rects-expected.txt:
  • platform/gtk/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/gtk/fast/multicol/column-count-with-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-expected.txt:
  • platform/gtk/fast/multicol/column-rules-stacking-expected.txt:
  • platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/gtk/fast/multicol/float-avoidance-expected.txt:
4:18 AM Changeset in webkit [71404] by alex
  • 258 edits in trunk/LayoutTests

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Rebaseline the test results after removing the font hinting.

  • platform/gtk/animations/animation-drt-api-expected.txt:
  • platform/gtk/animations/animation-drt-api-multiple-keyframes-expected.txt:
  • platform/gtk/animations/missing-values-first-keyframe-expected.txt:
  • platform/gtk/animations/missing-values-last-keyframe-expected.txt:
  • platform/gtk/animations/state-at-end-event-expected.txt:
  • platform/gtk/css1/basic/class_as_selector-expected.txt:
  • platform/gtk/css1/basic/comments-expected.txt:
  • platform/gtk/css1/basic/containment-expected.txt:
  • platform/gtk/css1/basic/contextual_selectors-expected.txt:
  • platform/gtk/css1/basic/grouping-expected.txt:
  • platform/gtk/css1/basic/id_as_selector-expected.txt:
  • platform/gtk/css1/basic/inheritance-expected.txt:
  • platform/gtk/css1/box_properties/border-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width-expected.txt:
  • platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_color-expected.txt:
  • platform/gtk/css1/box_properties/border_color_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left-expected.txt:
  • platform/gtk/css1/box_properties/border_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width-expected.txt:
  • platform/gtk/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right-expected.txt:
  • platform/gtk/css1/box_properties/border_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width-expected.txt:
  • platform/gtk/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_style-expected.txt:
  • platform/gtk/css1/box_properties/border_style_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top-expected.txt:
  • platform/gtk/css1/box_properties/border_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width-expected.txt:
  • platform/gtk/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/border_width-expected.txt:
  • platform/gtk/css1/box_properties/border_width_inline-expected.txt:
  • platform/gtk/css1/box_properties/clear-expected.txt:
  • platform/gtk/css1/box_properties/clear_float-expected.txt:
  • platform/gtk/css1/box_properties/float-expected.txt:
  • platform/gtk/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/gtk/css1/box_properties/float_margin-expected.txt:
  • platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/gtk/css1/box_properties/height-expected.txt:
  • platform/gtk/css1/box_properties/margin-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom-expected.txt:
  • platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_left-expected.txt:
  • platform/gtk/css1/box_properties/margin_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_right-expected.txt:
  • platform/gtk/css1/box_properties/margin_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/margin_top-expected.txt:
  • platform/gtk/css1/box_properties/margin_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom-expected.txt:
  • platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_left-expected.txt:
  • platform/gtk/css1/box_properties/padding_left_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_right-expected.txt:
  • platform/gtk/css1/box_properties/padding_right_inline-expected.txt:
  • platform/gtk/css1/box_properties/padding_top-expected.txt:
  • platform/gtk/css1/box_properties/padding_top_inline-expected.txt:
  • platform/gtk/css1/box_properties/width-expected.txt:
  • platform/gtk/css1/cascade/cascade_order-expected.txt:
  • platform/gtk/css1/cascade/important-expected.txt:
  • platform/gtk/css1/classification/display-expected.txt:
  • platform/gtk/css1/classification/list_style-expected.txt:
  • platform/gtk/css1/classification/list_style_image-expected.txt:
  • platform/gtk/css1/classification/list_style_position-expected.txt:
  • platform/gtk/css1/classification/list_style_type-expected.txt:
  • platform/gtk/css1/classification/white_space-expected.txt:
  • platform/gtk/css1/color_and_background/background-expected.txt:
  • platform/gtk/css1/color_and_background/background_attachment-expected.txt:
  • platform/gtk/css1/color_and_background/background_color-expected.txt:
  • platform/gtk/css1/color_and_background/background_image-expected.txt:
  • platform/gtk/css1/color_and_background/background_position-expected.txt:
  • platform/gtk/css1/color_and_background/background_repeat-expected.txt:
  • platform/gtk/css1/color_and_background/color-expected.txt:
  • platform/gtk/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/font_properties/font_family-expected.txt:
  • platform/gtk/css1/font_properties/font_size-expected.txt:
  • platform/gtk/css1/font_properties/font_style-expected.txt:
  • platform/gtk/css1/font_properties/font_variant-expected.txt:
  • platform/gtk/css1/font_properties/font_weight-expected.txt:
  • platform/gtk/css1/formatting_model/canvas-expected.txt:
  • platform/gtk/css1/formatting_model/floating_elements-expected.txt:
  • platform/gtk/css1/formatting_model/height_of_lines-expected.txt:
  • platform/gtk/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/gtk/css1/formatting_model/inline_elements-expected.txt:
  • platform/gtk/css1/formatting_model/replaced_elements-expected.txt:
  • platform/gtk/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/gtk/css1/pseudo/anchor-expected.txt:
  • platform/gtk/css1/pseudo/firstletter-expected.txt:
  • platform/gtk/css1/pseudo/firstline-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/gtk/css1/text_properties/letter_spacing-expected.txt:
  • platform/gtk/css1/text_properties/line_height-expected.txt:
  • platform/gtk/css1/text_properties/text_align-expected.txt:
  • platform/gtk/css1/text_properties/text_decoration-expected.txt:
  • platform/gtk/css1/text_properties/text_indent-expected.txt:
  • platform/gtk/css1/text_properties/text_transform-expected.txt:
  • platform/gtk/css1/text_properties/vertical_align-expected.txt:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
  • platform/gtk/css1/units/color_units-expected.txt:
  • platform/gtk/css1/units/length_units-expected.txt:
  • platform/gtk/css1/units/percentage_units-expected.txt:
  • platform/gtk/css1/units/urls-expected.txt:
  • platform/gtk/css3/css3-modsel-33-expected.txt:
  • platform/gtk/css3/css3-modsel-35-expected.txt:
  • platform/gtk/css3/css3-modsel-36-expected.txt:
  • platform/gtk/css3/css3-modsel-37-expected.txt:
  • platform/gtk/editing/deleting/4922367-expected.txt:
  • platform/gtk/editing/deleting/5026848-1-expected.txt:
  • platform/gtk/editing/deleting/5026848-2-expected.txt:
  • platform/gtk/editing/deleting/5026848-3-expected.txt:
  • platform/gtk/editing/deleting/5032066-expected.txt:
  • platform/gtk/editing/deleting/5091898-expected.txt:
  • platform/gtk/editing/deleting/5099303-expected.txt:
  • platform/gtk/editing/deleting/5115601-expected.txt:
  • platform/gtk/editing/deleting/5126166-expected.txt:
  • platform/gtk/editing/deleting/5156801-2-expected.txt:
  • platform/gtk/editing/deleting/5206311-1-expected.txt:
  • platform/gtk/editing/deleting/5206311-2-expected.txt:
  • platform/gtk/editing/deleting/5272440-expected.txt:
  • platform/gtk/editing/deleting/5300379-expected.txt:
  • platform/gtk/editing/deleting/5369009-expected.txt:
  • platform/gtk/editing/deleting/5390681-2-expected.txt:
  • platform/gtk/editing/deleting/5433862-2-expected.txt:
  • platform/gtk/editing/deleting/5483370-expected.txt:
  • platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
  • platform/gtk/editing/deleting/delete-and-undo-expected.txt:
  • platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • platform/gtk/editing/deleting/delete-br-001-expected.txt:
  • platform/gtk/editing/deleting/delete-br-002-expected.txt:
  • platform/gtk/editing/deleting/delete-br-003-expected.txt:
  • platform/gtk/editing/deleting/delete-br-004-expected.txt:
  • platform/gtk/editing/deleting/delete-br-005-expected.txt:
  • platform/gtk/editing/deleting/delete-br-006-expected.txt:
  • platform/gtk/editing/deleting/delete-br-007-expected.txt:
  • platform/gtk/editing/deleting/delete-br-010-expected.txt:
  • platform/gtk/editing/deleting/delete-br-013-expected.txt:
  • platform/gtk/editing/deleting/delete-by-word-001-expected.txt:
  • platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-002-expected.txt:
  • platform/gtk/editing/deleting/delete-line-005-expected.txt:
  • platform/gtk/editing/deleting/delete-line-006-expected.txt:
  • platform/gtk/editing/deleting/delete-line-007-expected.txt:
  • platform/gtk/editing/deleting/delete-line-008-expected.txt:
  • platform/gtk/editing/deleting/delete-line-009-expected.txt:
  • platform/gtk/editing/deleting/delete-line-010-expected.txt:
  • platform/gtk/editing/deleting/delete-line-011-expected.txt:
  • platform/gtk/editing/deleting/delete-line-012-expected.txt:
  • platform/gtk/editing/deleting/delete-line-013-expected.txt:
  • platform/gtk/editing/deleting/delete-line-014-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
  • platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
  • platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
  • platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
  • platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
  • platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
  • platform/gtk/editing/deleting/forward-delete-expected.txt:
  • platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
  • platform/gtk/editing/deleting/move-nodes-001-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-003-expected.txt:
  • platform/gtk/editing/deleting/smart-delete-004-expected.txt:
  • platform/gtk/editing/deleting/type-delete-after-quote-expected.txt:
  • platform/gtk/editing/execCommand/4580583-1-expected.txt:
  • platform/gtk/editing/execCommand/4580583-2-expected.txt:
  • platform/gtk/editing/execCommand/4747450-expected.txt:
  • platform/gtk/editing/execCommand/4916402-expected.txt:
  • platform/gtk/editing/execCommand/4916541-expected.txt:
  • platform/gtk/editing/execCommand/4924441-expected.txt:
  • platform/gtk/editing/execCommand/5080333-1-expected.txt:
  • platform/gtk/editing/execCommand/5080333-2-expected.txt:
  • platform/gtk/editing/execCommand/5136770-expected.txt:
  • platform/gtk/editing/execCommand/5138441-expected.txt:
  • platform/gtk/editing/execCommand/5142012-1-expected.txt:
  • platform/gtk/editing/execCommand/5142012-2-expected.txt:
  • platform/gtk/editing/execCommand/5190926-expected.txt:
  • platform/gtk/editing/execCommand/5481523-expected.txt:
  • platform/gtk/editing/execCommand/5482023-expected.txt:
  • platform/gtk/editing/execCommand/5569741-expected.txt:
  • platform/gtk/editing/inserting/12882-expected.txt:
  • platform/gtk/editing/inserting/4840662-expected.txt:
  • platform/gtk/editing/inserting/4875189-1-expected.txt:
  • platform/gtk/editing/inserting/4875189-2-expected.txt:
  • platform/gtk/editing/inserting/4959067-expected.txt:
  • platform/gtk/editing/inserting/4960120-2-expected.txt:
  • platform/gtk/editing/inserting/5002441-expected.txt:
  • platform/gtk/editing/inserting/5058163-1-expected.txt:
  • platform/gtk/editing/inserting/5058163-2-expected.txt:
  • platform/gtk/editing/inserting/5156401-2-expected.txt:
  • platform/gtk/editing/inserting/5418891-expected.txt:
  • platform/gtk/editing/inserting/5510537-expected.txt:
  • platform/gtk/editing/inserting/5549929-2-expected.txt:
  • platform/gtk/editing/inserting/5549929-3-expected.txt:
  • platform/gtk/editing/inserting/6703873-expected.txt:
  • platform/gtk/editing/inserting/editable-inline-element-expected.txt:
  • platform/gtk/editing/inserting/edited-whitespace-1-expected.txt:
  • platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
  • platform/gtk/editing/inserting/insert-div-009-expected.txt:
  • platform/gtk/editing/inserting/insert-div-024-expected.txt:
  • platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
  • platform/gtk/editing/inserting/redo-expected.txt:
  • platform/gtk/editing/inserting/typing-002-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-2-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-3-expected.txt:
  • platform/gtk/editing/pasteboard/4076267-expected.txt:
  • platform/gtk/editing/pasteboard/5032095-expected.txt:
  • platform/gtk/editing/pasteboard/5071074-2-expected.txt:
  • platform/gtk/editing/pasteboard/5075944-3-expected.txt:
  • platform/gtk/editing/pasteboard/5089327-expected.txt:
  • platform/gtk/editing/pasteboard/5134759-expected.txt:
  • platform/gtk/editing/pasteboard/5156401-1-expected.txt:
  • platform/gtk/editing/pasteboard/5387578-expected.txt:
  • platform/gtk/editing/pasteboard/5483567-expected.txt:
  • platform/gtk/editing/pasteboard/7955-expected.txt:
  • platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
  • platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
  • platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/gtk/editing/pasteboard/innerText-inline-table-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-1-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-2-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
  • platform/gtk/editing/pasteboard/paste-blockquote-into-blockquote-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
  • platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
4:10 AM Changeset in webkit [71403] by alex
  • 3 edits in trunk/WebKitTools

2010-11-05 Alejandro G. Castro <alex@igalia.com>

Reviewed by Martin Robinson.

[GTK] Avoid font hinting in the DRT
https://bugs.webkit.org/show_bug.cgi?id=48548

Change the settings to avoid font hinting, it was causing
different results depending on the distribution.

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (initializeGtkFontSettings):
  • DumpRenderTree/gtk/fonts/fonts.conf:
3:30 AM Changeset in webkit [71402] by pfeldman@chromium.org
  • 2 edits in trunk/WebCore

2010-11-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: inspector lags on large resources with numerous <script> tags.
https://bugs.webkit.org/show_bug.cgi?id=49060

  • inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
3:15 AM Changeset in webkit [71401] by Patrick Gansterer
  • 15 edits in trunk

2010-11-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903

  • platform/UUID.cpp: (WebCore::createCanonicalUUIDString):
  • platform/graphics/chromium/FontCacheChromiumWin.cpp: (WebCore::FontCache::getFontDataForCharacters):
  • platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getLastResortFallbackFont):
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::createIconForFiles):
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::getWebLocData):
  • platform/win/ClipboardWin.cpp: (WebCore::createGlobalHDropContent): (WebCore::createGlobalImageFileDescriptor): (WebCore::ClipboardWin::files): (WebCore::ClipboardWin::writeURL):
  • platform/win/DragDataWin.cpp: (WebCore::DragData::asFilenames):
  • platform/win/FileSystemWin.cpp: (WebCore::safeCreateFile):

2010-11-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::interpretKeyEvent):

2010-11-05 Patrick Gansterer <Patrick Gansterer>

Reviewed by David Kilzer.

Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::exceededDatabaseQuota):
  • WebKitDLL.cpp: (DllGetClassObject):
  • WebView.cpp: (WebView::mouseWheel):
2:47 AM Changeset in webkit [71400] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed.

Fix wrong test_expectation format.

  • platform/chromium/test_expectations.txt:
2:42 AM Changeset in webkit [71399] by rolandsteiner@chromium.org
  • 4 edits in trunk

2010-11-05 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dirk Schulze.

Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
https://bugs.webkit.org/show_bug.cgi?id=48979

Remove Chromium expectation entry.

  • platform/chromium/test_expectations.txt:

2010-11-05 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dirk Schulze.

Bug 48979 - [Chromium] SVGListPropertyTearOff.h: function commitChange ASSERTs on Win & Mac
https://bugs.webkit.org/show_bug.cgi?id=48979

Function removeItemValuesAndWrappers(): Move code out of 'if' statement so that
'wrappers' and 'values' stay synced.

test: svg/dom/baseVal-animVal-crash.html doesn't ASSERT

  • svg/properties/SVGListProperty.h: (WebCore::SVGListProperty::removeItemValuesAndWrappers):
2:14 AM Changeset in webkit [71398] by eric@webkit.org
  • 3 edits in trunk/WebKitTools

2010-11-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

build-webkit spams system.log by repeatedly checking for PBXProductDirectory in com.apple.Xcode
https://bugs.webkit.org/show_bug.cgi?id=49051

This is a speculative fix. The unit tests cover these methods, however
I don't know if this will fully stop the system.log spam.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
2:08 AM Changeset in webkit [71397] by ukai@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

Add failure for crbug 62025 and 62026

  • platform/chromium/test_expectations.txt:
1:29 AM Changeset in webkit [71396] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-05 John Reck <jreck@google.com>

Reviewed by Nikolas Zimmermann.

The change to SVGPropertyTearOff by CodeGeneratorV8.pm caused two build failures
for Android. One was a missing SVGPropertyTearOff.h include, the other was a
missing forward declaration of FloatRect. Seems to be the result of:
https://bugs.webkit.org/show_bug.cgi?id=48204

Bug: https://bugs.webkit.org/show_bug.cgi?id=49025

No tests needed, fixes build issue.

  • bindings/scripts/CodeGeneratorV8.pm:
1:04 AM Changeset in webkit [71395] by rwlbuis@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-05 Rob Buis <rwlbuis@gmail.com>

Reviewed by David Hyatt.

CSSRule#parentRule always null
https://bugs.webkit.org/show_bug.cgi?id=46228

Ensure MediaList child rules have the MediaList set as parent
in order to correct their parentRule correctness.

Test: fast/dom/css-mediarule-parentRule.html

  • css/CSSMediaRule.cpp: (WebCore::CSSMediaRule::CSSMediaRule):
12:58 AM Changeset in webkit [71394] by eric@webkit.org
  • 3 edits
    1 add in trunk/WebKitTools

2010-11-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add basic support for showing bot id on /queue-status/ pages
https://bugs.webkit.org/show_bug.cgi?id=49037

This support is really simple. Eventually we'll want to
show the bot id in the lock table too, but we don't have
that information stored in the server yet.

  • QueueStatusServer/handlers/queuestatus.py:
  • QueueStatusServer/handlers/queuestatus_unittest.py: Added.
  • QueueStatusServer/templates/includes/singlequeuestatus.html:

Nov 4, 2010:

10:08 PM Changeset in webkit [71393] by tonikitoo@webkit.org
  • 3 edits in trunk/WebKit/qt

2010-11-03 Antonio Gomes <tonikitoo@webkit.org>, Andre Pedralho <andre.pedralho@gmail.com>

Reviewed by Kenneth Rohde Christiansen and Antti Koivisto.

[Qt] Making effective use of nodesFromRect.
https://bugs.webkit.org/show_bug.cgi?id=44089

Patch adds a helper class (named TouchAdjuster) to improve tap actions
on mobile touch devices. TouchAdjuster makes use of the newly added rect
based hit test extension through the Document::nodesFromRect method.
Given a rectangle as input, nodesFromRect returns a z-index ordered list
of nodes whose boundaries intersect the rectangle.

Basically the TouchAdjuster class intercepts the QGraphicsSceneMouseEvent
passed to both QWebPagePrivate::mouse{Press,Release}Event methods before
they are passed down to WebCore. The goal is to infer the target click position.
For that, a rectangle is built up using the event position as a center point and
expanding it based on the values and directions set in the Platform Plugin
QWebTouchModifier::hitTestPadding.

TouchAdjuster iterates over the list of nodes returned by nodesFromRect and
picks the clickable one that has the largest intersection area with the hit
test rectangle. The target position is then the center point of this intersection
area.

In case of no clickable node intersects the hit test area, the click position
is not altered.

TouchAdjuster is *only* working for QGraphicsWebView based views.

  • Api/qwebpage.cpp: (QWebPagePrivate::mousePressEvent): (QWebPagePrivate::mouseReleaseEvent): (QWebPagePrivate::adjustPointForClicking): (QWebPagePrivate::TouchAdjuster::TouchAdjuster): (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch): (isClickableElement): (hasMouseListener): (isValidFrameOwner): (nodeToElement):
  • Api/qwebpage_p.h:
9:58 PM Changeset in webkit [71392] by morrita@google.com
  • 4 edits
    3 adds
    4 deletes in trunk/LayoutTests

2010-11-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Expectation of /editing/spelling/spelling-textarea.html is confusing
https://bugs.webkit.org/show_bug.cgi?id=48818

  • Turned spelling-contenteditable.html and spelling-textarea.html into single script-test named spelling-hasspellingmarker.html, which uses shouldBe() family for the assertion. The original tests misused testPassed() for printing.
  • Added a test for <input>, which possibly goes different path from editing <textarea> and @contentEditable.
  • Added a "false" case test to catch the error that results true for anything.
  • editing/spelling/script-tests/spelling-hasspellingmarker.js: Added.
  • editing/spelling/spelling-contenteditable-expected.txt: Removed.
  • editing/spelling/spelling-contenteditable.html: Removed.
  • editing/spelling/spelling-hasspellingmarker-expected.txt: Added.
  • editing/spelling/spelling-hasspellingmarker.html: Added.
  • editing/spelling/spelling-textarea-expected.txt: Removed.
  • editing/spelling/spelling-textarea.html: Removed.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
9:47 PM Changeset in webkit [71391] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-04 usaini <usaini08@gmail.com>

Reviewed by Antonio Gomes.

WebWindowFeatures has a faulty constructor for WebCore::WindowFeatures
https://bugs.webkit.org/show_bug.cgi?id=48035

  • public/WebWindowFeatures.h: (WebKit::WebWindowFeatures::WebWindowFeatures): updated the constructor that takes in a WebCore::WindowFeature and had it copy all the variables over properly so that after calling the constructor WebWindowFeatures is always in a valid state. Before, the x,y,width,height booleans may be true, but the corresponding int values would not be updated.
9:41 PM Changeset in webkit [71390] by tonikitoo@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-04 Antonio Gomes <agomes@rim.com>

Rubber-stamped by Martin Robinson.

[Gtk] fast/events/spatial-navigation/snav-iframe-flattening-simple.html fails
https://bugs.webkit.org/show_bug.cgi?id=47587

Frame flattening support was added to GTK+ by r69919 in bug 38650. Tests passes now.

  • platform/gtk/Skipped:
9:33 PM Changeset in webkit [71389] by xan@webkit.org
  • 2 edits in trunk/WebCore

2010-11-04 Xan Lopez <xlopez@igalia.com>

Fix the GTK+ build.

  • GNUmakefile.am:
9:31 PM Changeset in webkit [71388] by tonikitoo@webkit.org
  • 7 edits
    4 adds in trunk

2010-10-20 Chang Shu <chang.shu@nokia.com>, Antonio Gomes <tonikitoo@webkit.org>

Reviewed by Simon Fraser.

Spatial Navigation: add support to <input type=text> and <textarea>
https://bugs.webkit.org/show_bug.cgi?id=37153

Before this patch, the focus cannot move away from input box once it is in. This patch allows focus
move to neighbor nodes when the caret reaches the edge of the texts. This patch does not support yet
cases where the focused <input> has a JS handler for the arrow keys.

WebCore:

Tests: fast/events/spatial-navigation/snav-input.html
fast/events/spatial-navigation/snav-textarea.html

  • editing/EditorCommand.cpp: (WebCore::executeMoveDown): (WebCore::executeMoveLeft): (WebCore::executeMoveRight): (WebCore::executeMoveUp):
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify):

WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp: WebCore::EditorClientQt::handleKeyboardEvent):

LayoutTests:

  • fast/events/spatial-navigation/snav-input-expected.txt: Added.
  • fast/events/spatial-navigation/snav-input.html: Added.
  • fast/events/spatial-navigation/snav-textarea-expected.txt: Added.
  • fast/events/spatial-navigation/snav-textarea.html: Added.
9:07 PM Changeset in webkit [71387] by mrobinson@webkit.org
  • 2 edits in trunk/LayoutTests

2010-11-04 Martin Robinson <mrobinson@igalia.com>

Skip two new tests. One of which is only failing on the
bots and the other which uses the meter element, which is
currently unsupported on GTK+.

  • platform/gtk/Skipped: Skip two more tests.
8:58 PM Changeset in webkit [71386] by mitz@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • editing/Editor.cpp:

(WebCore::Editor::dismissCorrectionPanel):

8:48 PM Changeset in webkit [71385] by mitz@apple.com
  • 19 edits
    6 adds in trunk

reversion bubble in WebViews
https://bugs.webkit.org/show_bug.cgi?id=47630
<rdar://problem/8530960>

Patch by Jia Pu <jpu@apple.com> on 2010-11-04
Reviewed by Dan Bernstein.

WebCore:

Added manual test:
manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html
manual-tests/autocorrection/delete-to-dismiss-reversion.html
manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html
manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html
manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html

We can only manully test this feature for two reasons:

  1. On Mac OS X, the result of spell checking is partly determined by past user usage. We can't realiably generating test cases until we can disable user custom data during spell checking.
  2. To exerciese this feature, we need a minimum of 0.3 second delay using WebCore timer.

This patch is to add reversion to correction panel. It consists of following major code changes:

  1. Collected all autocorrection related member variables in Editor into a CorrectionPanelInfo class to improve readability.
  2. Changed signature of Editor::startCorrectionPanelTimer() to allow caller to specify the type of correction panel--regular correction or reversion.
  3. Made necessary changes to adopt reversion API in AppKit.
  4. Use SUPPORT_CORRECTION_PANEL macro to improve readability.
  • GNUmakefile.am: Added CorrectionPanelInfo.h.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj:
  • editing/CorrectionPanelInfo.h: Added.
  • editing/Editor.cpp:

(WebCore::Editor::respondToChangedSelection): Start correction panel timer for reversion when

the new selection is a caret selection at end of a previously corrected word.

(WebCore::Editor::appliedEditing): Stop timer at the beginning of the method instead of at the end.
(WebCore::Editor::~Editor): Adopted new method dismissCorrectionPanel().
(WebCore::Editor::markMisspellingsAfterTypingToPosition): Adopted new method applyCorrectionPanelInfo().
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Code change for new m_correctionPanelInfo

member variable.

(WebCore::Editor::correctionPanelTimerFired): Change to handle reversion panel type.
(WebCore::Editor::handleRejectedCorrection): Ditto.
(WebCore::Editor::startCorrectionPanelTimer): Changed signature to allow passing in panel type.
(WebCore::Editor::stopCorrectionPanelTimer): Adopted macro SUPPORT_CORRECTION_PANEL.
(WebCore::Editor::handleCancelOperation): Ditto.
(WebCore::Editor::isShowingCorrectionPanel): Ditto.
(WebCore::Editor::dismissCorrectionPanel): Update m_correctionPanelInfo when correction panel

is dismissed.

(WebCore::Editor::applyCorrectionPanelInfo): Factored out code that applies autocorrection.
(WebCore::Editor::changeSelectionAfterCommand): Adopt macro SUPPORT_CORRECTION_PANEL.

  • editing/Editor.h: Adopted CorrectionPanelInfo and add new member methods.
  • editing/EditorCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL

(WebCore::createCommandMap):

  • editing/TypingCommand.cpp: Adopted macro SUPPORT_CORRECTION_PANEL and new signature of startCorrectionPanelTimer().

(WebCore::TypingCommand::markMisspellingsAfterTyping):

  • loader/EmptyClients.h:

(WebCore::EmptyEditorClient::showCorrectionPanel): Adopted new signature of base class method.
(WebCore::EmptyEditorClient::dismissCorrectionPanel): Ditto.

  • manual-tests/autocorrection/continue-typing-to-dismiss-reversion.html: Added.
  • manual-tests/autocorrection/delete-to-dismiss-reversion.html: Added.
  • manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html: Added.
  • manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html: Added.
  • manual-tests/autocorrection/type-whitespace-to-dismiss-reversion.html: Added.
  • page/EditorClient.h: Changed signature of showCorrectionPanel() and dismissCorrectionPanel().
  • platform/graphics/mac/GraphicsContextMac.mm: Added comment to improve readability.

(WebCore::GraphicsContext::drawLineForTextChecking):

WebKit/mac:

This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

  • WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
  • WebCoreSupport/WebEditorClient.mm: Adopted new signature of base class method. And code change to use new reversion API in AppKit.

(WebEditorClient::WebEditorClient):
(WebEditorClient::~WebEditorClient):
(WebEditorClient::respondToChangedSelection):
(WebEditorClient::showCorrectionPanel):
(WebEditorClient::dismissCorrectionPanel):
(WebEditorClient::isShowingCorrectionPanel):

WebKit2:

This patch is to add reversion to correction panel. Please see WebCore/ChangeLog for detail.

  • WebProcess/WebCoreSupport/WebEditorClient.h: Adopted new signature of base class method.
  • WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: Ditto.

(WebKit::WebEditorClient::showCorrectionPanel):
(WebKit::WebEditorClient::dismissCorrectionPanel):

8:39 PM Changeset in webkit [71384] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated test result from previous commit, as I removed tabs from the test before committing
but forgot to update the result.

  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
7:51 PM Changeset in webkit [71383] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2010-11-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

Create a filesystem wrapper that we can use to enforce
particular conventions and use for mocking and dependency
injection down the line.

https://bugs.webkit.org/show_bug.cgi?id=48144

  • Scripts/webkitpy/common/system/filesystem.py: Added.
  • Scripts/webkitpy/common/system/filesystem_unittest.py: Added.
7:43 PM Changeset in webkit [71382] by mitz@apple.com
  • 9 edits
    20 copies
    60 adds in trunk

WebCore: Made table layout and painting work with all writing modes. Hit-testing, repainting, tables
where some elements have their own layers, and cells whose writing mode differs from the
table’s are not supported yet.

Reviewed by Dave Hyatt.

Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Tests: fast/table/027-vertical.html

fast/table/028-vertical.html
fast/table/035-vertical.html
fast/table/038-vertical.html
fast/table/040-vertical.html
fast/table/auto-with-percent-height-vertical.html
fast/table/border-collapsing/001-vertical.html
fast/table/border-collapsing/002-vertical.html
fast/table/border-collapsing/003-vertical.html
fast/table/border-collapsing/004-vertical.html
fast/table/border-collapsing/border-collapsing-head-foot-vertical.html
fast/table/border-collapsing/equal-precedence-resolution-vertical.html
fast/table/border-collapsing/rtl-border-collapsing-vertical.html
fast/table/colspanMinWidth-vertical.html
fast/table/fixed-with-auto-with-colspan-vertical.html
fast/table/growCellForImageQuirk-vertical.html
fast/table/height-percent-test-vertical.html
fast/table/percent-widths-stretch-vertical.html
fast/table/rowspan-paint-order-vertical.html
fast/table/table-display-types-vertical.html

  • css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::adjustRenderStyle): Changed to allow all writing modes for tables,
make row groups, rows, column groups and columns inherit the table’s writing mode. For now,
make cells do this too.

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::parseMappedAttribute): Map align=center using logical properties.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::RenderTable): Initialize m_borderStart and m_borderEnd.
(WebCore::RenderTable::styleDidChange): Changed the rule for when to use auto layout to look
at the logical width instead of the width.
(WebCore::RenderTable::computeLogicalWidth): Uses logical widths and works with perpendicular
containing blocks.
(WebCore::RenderTable::layout): Use logical lengths.
(WebCore::RenderTable::setCellLogicalWidths): Renamed setCellWidths() to this and updated for
the renaming of RenderTableSection::setCellWidths().
(WebCore::RenderTable::paintObject): Account for flipped modes.
(WebCore::RenderTable::subtractCaptionRect): Added this helper method the considers writing modes.
(WebCore::RenderTable::paintBoxDecorations): Adopted subtractCaptionRect().
(WebCore::RenderTable::paintMask): Ditto.
(WebCore::RenderTable::computePreferredLogicalWidths): Updated for the renaming of
recalcHorizontalBorders().
(WebCore::RenderTable::calcBorderStart): Renamed calcBorderLeft() to this and changed it to use
borderStart(). Splits odd number of pixels based on the physical side.
(WebCore::RenderTable::calcBorderEnd): Similar.
(WebCore::RenderTable::recalcBordersInRowDirection): Renamed recalcHorizontalBorders() to this
and updated for other renames.
(WebCore::RenderTable::borderBefore): Replaced borderTop() with this.
(WebCore::RenderTable::borderAfter): Similar.
(WebCore::RenderTable::outerBorderBefore): Similar.
(WebCore::RenderTable::outerBorderAfter): Similar.
(WebCore::RenderTable::outerBorderStart): Similar.
(WebCore::RenderTable::outerBorderEnd): Similar.
(WebCore::RenderTable::firstLineBoxBaseline): Changed to use logical heights.
(WebCore::RenderTable::overflowClipRect): Account for writing modes.

  • rendering/RenderTable.h:

(WebCore::RenderTable::borderStart):
(WebCore::RenderTable::borderEnd):
(WebCore::RenderTable::borderLeft):
(WebCore::RenderTable::borderRight):
(WebCore::RenderTable::borderTop):
(WebCore::RenderTable::borderBottom):
(WebCore::RenderTable::outerBorderLeft):
(WebCore::RenderTable::outerBorderRight):
(WebCore::RenderTable::outerBorderTop):
(WebCore::RenderTable::outerBorderBottom):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection): Changed to match its name.

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleWillChange): Changed to detect changes to logical height.

  • rendering/RenderTableSection.cpp:

(WebCore::setRowLogicalHeightToRowStyleLogicalHeightIfNotRelative): Renamed and changed to use
logical heights.
(WebCore::RenderTableSection::RenderTableSection): Updated initializers for new member variables.
(WebCore::RenderTableSection::addChild): Updated for rename.
(WebCore::RenderTableSection::ensureRows): Ditto.
(WebCore::RenderTableSection::addCell): Ditto. Also use logical heights.
(WebCore::RenderTableSection::setCellLogicalWidths): Renamed setCellWidths() to this, changed
to use logical widths.
(WebCore::RenderTableSection::calcRowLogicalHeight): Added “logical” to the name. Updated with
logical heights.
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::calcOuterBorderBefore):
(WebCore::RenderTableSection::calcOuterBorderAfter):
(WebCore::RenderTableSection::calcOuterBorderStart):
(WebCore::RenderTableSection::calcOuterBorderEnd):
(WebCore::RenderTableSection::recalcOuterBorder):
(WebCore::RenderTableSection::firstLineBoxBaseline):
(WebCore::RenderTableSection::paintCell):
(WebCore::RenderTableSection::recalcCells):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::outerBorderBefore):
(WebCore::RenderTableSection::outerBorderAfter):
(WebCore::RenderTableSection::outerBorderStart):
(WebCore::RenderTableSection::outerBorderEnd):

LayoutTests: Make tables work with vertical text
https://bugs.webkit.org/show_bug.cgi?id=46417

Reviewed by Dave Hyatt.

  • fast/table/027-vertical.html: Copied from LayoutTests/fast/table/027.html.
  • fast/table/028-vertical.html: Copied from LayoutTests/fast/table/028.html.
  • fast/table/035-vertical.html: Copied from LayoutTests/fast/table/035.html.
  • fast/table/038-vertical.html: Copied from LayoutTests/fast/table/038.html.
  • fast/table/040-vertical.html: Copied from LayoutTests/fast/table/040.html.
  • fast/table/auto-with-percent-height-vertical.html: Copied from LayoutTests/fast/table/auto-with-percent-height.html.
  • fast/table/border-collapsing/001-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/001.html.
  • fast/table/border-collapsing/002-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/002.html.
  • fast/table/border-collapsing/003-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/003.html.
  • fast/table/border-collapsing/004-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/004.html.
  • fast/table/border-collapsing/border-collapsing-head-foot-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/border-collapsing-head-foot.html.
  • fast/table/border-collapsing/equal-precedence-resolution-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/equal-precedence-resolution.html.
  • fast/table/border-collapsing/rtl-border-collapsing-vertical.html: Copied from LayoutTests/fast/table/border-collapsing/rtl-border-collapsing.html.
  • fast/table/colspanMinWidth-vertical.html: Copied from LayoutTests/fast/table/colspanMinWidth.html.
  • fast/table/fixed-with-auto-with-colspan-vertical.html: Copied from LayoutTests/fast/table/fixed-with-auto-with-colspan.html.
  • fast/table/growCellForImageQuirk-vertical.html: Copied from LayoutTests/fast/table/growCellForImageQuirk.html.
  • fast/table/height-percent-test-vertical.html: Copied from LayoutTests/fast/table/height-percent-test.html.
  • fast/table/percent-widths-stretch-vertical.html: Copied from LayoutTests/fast/table/percent-widths-stretch.html.
  • fast/table/rowspan-paint-order-vertical.html: Copied from LayoutTests/fast/table/rowspan-paint-order.html.
  • fast/table/table-display-types-vertical.html: Copied from LayoutTests/fast/table/table-display-types.html.
  • platform/mac/fast/table/027-vertical-expected.checksum: Added.
  • platform/mac/fast/table/027-vertical-expected.png: Added.
  • platform/mac/fast/table/027-vertical-expected.txt: Added.
  • platform/mac/fast/table/028-vertical-expected.checksum: Added.
  • platform/mac/fast/table/028-vertical-expected.png: Added.
  • platform/mac/fast/table/028-vertical-expected.txt: Added.
  • platform/mac/fast/table/035-vertical-expected.checksum: Added.
  • platform/mac/fast/table/035-vertical-expected.png: Added.
  • platform/mac/fast/table/035-vertical-expected.txt: Added.
  • platform/mac/fast/table/038-vertical-expected.checksum: Added.
  • platform/mac/fast/table/038-vertical-expected.png: Added.
  • platform/mac/fast/table/038-vertical-expected.txt: Added.
  • platform/mac/fast/table/040-vertical-expected.checksum: Added.
  • platform/mac/fast/table/040-vertical-expected.png: Added.
  • platform/mac/fast/table/040-vertical-expected.txt: Added.
  • platform/mac/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
  • platform/mac/fast/table/auto-with-percent-height-vertical-expected.png: Added.
  • platform/mac/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/001-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/001-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/002-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/003-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt: Added.
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
  • platform/mac/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt: Added.
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.checksum: Added.
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.png: Added.
  • platform/mac/fast/table/fixed-with-auto-with-colspan-vertical-expected.txt: Added.
  • platform/mac/fast/table/growCellForImageQuirk-vertical-expected.checksum: Added.
  • platform/mac/fast/table/growCellForImageQuirk-vertical-expected.png: Added.
  • platform/mac/fast/table/growCellForImageQuirk-vertical-expected.txt: Added.
  • platform/mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
  • platform/mac/fast/table/height-percent-test-vertical-expected.png: Added.
  • platform/mac/fast/table/height-percent-test-vertical-expected.txt: Added.
  • platform/mac/fast/table/percent-widths-stretch-vertical-expected.checksum: Added.
  • platform/mac/fast/table/percent-widths-stretch-vertical-expected.png: Added.
  • platform/mac/fast/table/percent-widths-stretch-vertical-expected.txt: Added.
  • platform/mac/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
  • platform/mac/fast/table/rowspan-paint-order-vertical-expected.png: Added.
  • platform/mac/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
  • platform/mac/fast/table/table-display-types-vertical-expected.checksum: Added.
  • platform/mac/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/mac/fast/table/table-display-types-vertical-expected.txt: Added.
7:29 PM Changeset in webkit [71381] by inferno@chromium.org
  • 2 edits
    4 copies in branches/chromium/552

Merge 71377

BUG=60013

7:10 PM Changeset in webkit [71380] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

run_webkit_tests_unittest fails under Python 2.5
https://bugs.webkit.org/show_bug.cgi?id=49043

Switch from itertools.chain.from_iterable (which was added in 2.6)
to using itertools.chain directly.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
6:57 PM Changeset in webkit [71379] by tkent@chromium.org
  • 2 edits in trunk/WebCore

2010-11-04 Kent Tamura <tkent@chromium.org>

Unreviewed, trivial test fix.

Fix GTK build for http://trac.webkit.org/changeset/71373 .

  • GNUmakefile.am: Add HTMLOutputElement.{cpp,h}
6:26 PM Changeset in webkit [71378] by mihaip@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-04 Mihai Parparita <mihaip@chromium.org>

Unreviewed fix to webkit-patch rebaseline-server so that it runs under
Python 2.5 (it needs an import to use the with statement).

  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
6:23 PM Changeset in webkit [71377] by morrita@google.com
  • 4 edits
    4 adds in trunk

2010-11-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Stale reference to RenderObject held as FrameView layoutRoot
https://bugs.webkit.org/show_bug.cgi?id=48019

  • fast/dom/HTMLMeterElement/meter-element-with-child-crash-expected.txt: Added.
  • fast/dom/HTMLMeterElement/meter-element-with-child-crash.html: Added.
  • fast/dom/HTMLProgressElement/progress-element-with-child-crash-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-element-with-child-crash.html: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:

2010-11-04 MORITA Hajime <morrita@google.com>

Reviewed by Kent Tamura.

Stale reference to RenderObject held as FrameView layoutRoot
https://bugs.webkit.org/show_bug.cgi?id=48019

<progress> and <meter> shouldn't have children of its RenderObject,
which caused unexpected result.
This change suppresses child creation to prevent it.

Tests: fast/dom/HTMLMeterElement/meter-element-with-child-crash.html

fast/dom/HTMLProgressElement/progress-element-with-child-crash.html

  • rendering/RenderIndicator.h: (WebCore::RenderIndicator::canHaveChildren):
6:18 PM Changeset in webkit [71376] by mrobinson@webkit.org
  • 4 edits
    1 add in trunk/LayoutTests

2010-11-04 Martin Robinson <mrobinson@igalia.com>

Unskip some passing tests and update some baselines.

  • platform/gtk/Skipped: Update skipped list.
  • platform/gtk/http/tests/misc/slow-loading-mask-expected.txt: Added.
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
6:16 PM Changeset in webkit [71375] by xan@webkit.org
  • 16 edits in trunk/JavaScriptCore

2010-11-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Adam Barth.

Use leakRef instead of releaseRef
https://bugs.webkit.org/show_bug.cgi?id=48974

Use leakRef instead of the deprecated releaseRef. This was renamed
some time ago because 'releaseRef' is too close to 'release',
which does something completely different.

6:05 PM Changeset in webkit [71374] by dpranke@chromium.org
  • 1 edit
    2 adds in trunk/WebKitTools

2010-11-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

new-run-webkit-tests: split out webkit-specific configuration stuff into a new module

The current NRWT code has webkit-specific configuration code (like
_script_path, default configuration, etc.) mixed in with
layout-test-specific stuff in port/base. The configuration code
should be split out into a separate module for easier mocking,
testing, and isolation.

https://bugs.webkit.org/show_bug.cgi?id=48264

  • Scripts/webkitpy/layout_tests/port/config.py: Added.
  • Scripts/webkitpy/layout_tests/port/config_unittest.py: Added.
5:57 PM Changeset in webkit [71373] by commit-queue@webkit.org
  • 40 edits
    1 copy
    20 adds in trunk

2010-11-04 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5][Forms] Support for <output> element
https://bugs.webkit.org/show_bug.cgi?id=29363

Adds tests for the DOMSettableTokenList and the output element.

  • fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt: Added.
  • fast/dom/HTMLOutputElement/dom-settable-token-list.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-reset-event-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-reset-event.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-validity-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-validity.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-value-expected.txt: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement-value.html: Added.
  • fast/dom/HTMLOutputElement/htmloutputelement.html: Added.
  • fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js: Added. (createElement):
  • fast/dom/HTMLOutputElement/script-tests/htmloutputelement-reset-event.js: Added.
  • fast/dom/HTMLOutputElement/script-tests/htmloutputelement-validity.js: Added.
  • fast/dom/HTMLOutputElement/script-tests/htmloutputelement-value.js: Added.
  • fast/dom/Window/window-properties-expected.txt: Updated expectation.
  • fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • fast/dom/prototype-inheritance-2-expected.txt: Updated expectation.
  • fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • fast/js/global-constructors-expected.txt: Updated expectation.
  • platform/chromium/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/gtk/fast/dom/Window/window-properties-expected.txt: Updated expectation.
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/gtk/fast/js/global-constructors-expected.txt: Updated expectation.
  • platform/qt/fast/dom/Window/window-properties-expected.txt: Updated expectation.
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • platform/qt/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/qt/fast/js/global-constructors-expected.txt: Updated expectation.
  • platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Updated expectation.
  • platform/win/fast/dom/prototype-inheritance-2-expected.txt: Updated expectation.
  • platform/win/fast/dom/prototype-inheritance-expected.txt: Updated expectation.
  • platform/win/fast/js/global-constructors-expected.txt: Updated expectation.

2010-11-04 Kenichi Ishibashi <bashi@google.com>

Reviewed by Kent Tamura.

[HTML5][Forms] Support for <output> element
https://bugs.webkit.org/show_bug.cgi?id=29363

Support for <output> element.

Tests: fast/dom/HTMLOutputElement/dom-settable-token-list.html

fast/dom/HTMLOutputElement/htmloutputelement-reset-event.html
fast/dom/HTMLOutputElement/htmloutputelement-validity.html
fast/dom/HTMLOutputElement/htmloutputelement-value.html
fast/dom/HTMLOutputElement/htmloutputelement.html

  • Android.derived.jscbindings.mk: Added JSHTMLOutputElement.h.
  • Android.derived.v8bindings.mk: Added V8HTMLOutputElement.h.
  • Android.jscbindings.mk: Added JSHTMLOutputElementCustom.cpp.
  • Android.mk: Added HTMLOutputElement.cpp.
  • Android.v8bindings.mk: Added V8HTMLOutputElementCustom.cpp.
  • CMakeLists.txt: Added HTMLOutputElement.{idl,cpp} and JSHTMLOutputElementCustom.cpp.
  • DerivedSources.cpp: Added JSHTMLOutputElement.cpp.
  • DerivedSources.make: Added HTMLOutputElement entry.
  • GNUmakefile.am: Added JSHTMLOutputElement.{cpp,h}
  • WebCore.gypi: Added HTMLOutputElement.{idl,cpp,h}, JSHTMLOutputElementCustom.cpp and V8HTMLOutputElementCustom.cpp
  • WebCore.pri: Added HTMLOutputElement.idl.
  • WebCore.pro: Added V8HTMLOutputElementCustom.cpp, JSHTMLOutputElementCustom.cpp and HTMLOutputElement.cpp.
  • WebCore.vcproj/WebCore.vcproj: Added entries for JSHTMLOutputElement.{cpp,h} and JSHTMLOutputElementCustom.cpp.
  • WebCore.xcodeproj/project.pbxproj: Added entries for JSHTMLOutputElementCustom.cpp, HTMLOutputElement.{cpp,h,idl}, JSHTMLOutputElement.{cpp,h}
  • bindings/js/JSBindingsAllInOne.cpp: Added JSHTMLOutputElementCustom.cpp.
  • bindings/js/JSHTMLOutputElementCustom.cpp: Added. (WebCore::JSHTMLOutputElement::htmlFor): (WebCore::JSHTMLOutputElement::setHtmlFor):
  • bindings/v8/custom/V8DOMSettableTokenListCustom.cpp: Modified. (WebCore::V8DOMSettableTokenList::indexedPropertyGetter): Returns null if the index is out of range.
  • bindings/v8/custom/V8HTMLOutputElementCustom.cpp: Added. (WebCore::V8HTMLOutputElement::htmlForAccessorGetter): (WebCore::V8HTMLOutputElement::htmlForAccessorSetter):
  • css/html.css: Added a default style of output element. (output):
  • html/DOMSettableTokenList.cpp: Fix bugs. (WebCore::DOMSettableTokenList::item): Returns null string if the index is out of range. (WebCore::DOMSettableTokenList::addInternal): Added check m_tokens.isNull(). (WebCore::DOMSettableTokenList::setValue): Set the value case sensitive.
  • html/HTMLOutputElement.cpp: Added. (WebCore::HTMLOutputElement::HTMLOutputElement): (WebCore::HTMLOutputElement::create): (WebCore::HTMLOutputElement::formControlType): (WebCore::HTMLOutputElement::parseMappedAttribute): (WebCore::HTMLOutputElement::htmlFor): (WebCore::HTMLOutputElement::setFor): (WebCore::HTMLOutputElement::setForm): (WebCore::HTMLOutputElement::childrenChanged): (WebCore::HTMLOutputElement::reset): (WebCore::HTMLOutputElement::value): (WebCore::HTMLOutputElement::setValue): (WebCore::HTMLOutputElement::defaultValue): (WebCore::HTMLOutputElement::setDefaultValue): (WebCore::HTMLOutputElement::setTextContentInternal):
  • html/HTMLOutputElement.h: Added. (WebCore::HTMLOutputElement::isEnumeratable): (WebCore::HTMLOutputElement::willValidate):
  • html/HTMLOutputElement.idl: Added.
  • html/HTMLTagNames.in: Added "output".
  • page/DOMWindow.idl: Added an attribute for HTMLOutputElement.
5:55 PM Changeset in webkit [71372] by zmo@google.com
  • 13 edits in trunk

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
https://bugs.webkit.org/show_bug.cgi?id=48938

  • src/WebGraphicsContext3DDefaultImpl.cpp: (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
https://bugs.webkit.org/show_bug.cgi?id=48938

  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): (WebCore::WebGLRenderingContext::getParameter): (WebCore::WebGLRenderingContext::readPixels):
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContext.idl:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp: (WebCore::GraphicsContext3D::getIntegerv):

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

Remove IMPLEMENTATION_COLOR_READ_FORMAT and TYPE
https://bugs.webkit.org/show_bug.cgi?id=48938

  • fast/canvas/webgl/read-pixels-pack-alignment-expected.txt:
  • fast/canvas/webgl/read-pixels-pack-alignment.html:
  • fast/canvas/webgl/webgl-specific-expected.txt:
  • fast/canvas/webgl/webgl-specific.html: Test two enums are undefined in WebGL.
5:52 PM Changeset in webkit [71371] by zmo@google.com
  • 8 edits in trunk

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

TypedArray should throw exception if length not a multiple of element size
https://bugs.webkit.org/show_bug.cgi?id=45487

  • bindings/js/JSArrayBufferViewHelper.h: (WebCore::constructArrayBufferView):
  • bindings/v8/custom/V8ArrayBufferViewCustom.h: (WebCore::constructWebGLArray):

2010-11-04 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

TypedArray should throw exception if length not a multiple of element size
https://bugs.webkit.org/show_bug.cgi?id=45487

  • fast/canvas/webgl/array-unit-tests-expected.txt:
  • fast/canvas/webgl/array-unit-tests.html: Test against the non-multiplication exception behavior.
  • fast/canvas/webgl/gl-enum-tests-expected.txt:
  • fast/canvas/webgl/gl-enum-tests.html: Fix the ArrayBuffer size so it won't throw an error with this patch.
5:33 PM Changeset in webkit [71370] by kbr@google.com
  • 6 edits in trunk

2010-11-04 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

[chromium] Mac: WebGL: all textured content is blue
https://bugs.webkit.org/show_bug.cgi?id=49021

Added support for 8-bit, little-endian CGImages. The previous
image decode path used the default byte order, which is apparently
big-endian.

Tested with various WebGL content and layout tests in Chromium.
Ran layout tests in WebKit and tested various WebGL content in
Safari. Was not able to run layout tests with Chromium port of
DumpRenderTree due to build failures currently in the tree.

  • platform/graphics/GraphicsContext3D.cpp: (WebCore::doPacking):
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/cg/GraphicsContext3DCG.cpp: (WebCore::getSourceDataFormat): (WebCore::GraphicsContext3D::getImageData):

2010-11-04 Kenneth Russell <kbr@google.com>

Reviewed by Adam Barth.

[chromium] Mac: WebGL: all textured content is blue
https://bugs.webkit.org/show_bug.cgi?id=49021

Updated expectations for WebGL layout tests which were affected by
the image decoder change
https://bugs.webkit.org/show_bug.cgi?id=47974 .

  • platform/chromium/test_expectations.txt:
5:28 PM Changeset in webkit [71369] by mihaip@chromium.org
  • 2 edits
    6 adds in trunk/WebKitTools

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

Rebaseline server: initial framework
https://bugs.webkit.org/show_bug.cgi?id=48892

Adds the basic framework for the rebaseline server (details at
http://webkit.org/b/47761). Includes the rebaseline-server webkit-patch
command, which starts an HTTP server that can serve static files or
invoke handler methods on a class.

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html: Added.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css: Added.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js: Added.
  • Scripts/webkitpy/tool/commands/rebaselineserver.py: Added.
5:08 PM Changeset in webkit [71368] by mihaip@chromium.org
  • 4 edits
    5 copies in branches/chromium/552

Merge 71170 - 2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

Add a reduced version of the page that was originally reported at
http://crbug.com/59554.

  • http/tests/history/back-during-onload-triggered-by-back-expected.txt: Added.
  • http/tests/history/back-during-onload-triggered-by-back.html: Added.
  • http/tests/history/resources/back-during-onload-container.html: Added.
  • http/tests/history/resources/back-during-onload-hung-page.php: Added.
  • http/tests/history/resources/back-during-onload-middle.html: Added.

2010-11-02 Mihai Parparita <mihaip@chromium.org>

Reviewed by Adam Barth.

[Chromium] Crash when encountering history.back() call during Page::goToItem execution
https://bugs.webkit.org/show_bug.cgi?id=48477

For the Chromium port, BackForwardList::itemAtIndex synthesizes a
HistoryItem and saves a pointer to it in m_pendingItem. During
Page::goToItem we call FrameLoader::stopAllLoaders, which can trigger
onload handlers (if a subframe was not considered committed by the frame
loader). If one of those handlers calls calls history.back() or another
operation that ends up in NavigationScheduler::scheduleHistoryNavigation,
we would call BackForwardList::itemAtIndex, which means that we would
lose the m_pendingItem RefPtr that pointed to the item being navigated
to, causing its ref count to go to 0*, and thus for the HistoryItem to
be deleted before we were done navigating to it.

This is fixed in two ways:

  • Add a protector RefPtr in Page::goToItem to make sure that the item is still around for when we pass it to HistoryController:goToItem.
  • Change NavigationScheduler::scheduleHistoryNavigation to not use BackForwardList::itemAtIndex and instead look at the forward/backListCount() (since it doesn't actually care about the returned HistoryItem).

Test: http/tests/history/back-during-onload-triggered-by-back.html

  • loader/NavigationScheduler.cpp: (WebCore::NavigationScheduler::scheduleHistoryNavigation):
  • page/Page.cpp: (WebCore::Page::goToItem):

TBR=mihaip@chromium.org

4:57 PM Changeset in webkit [71367] by zmo@google.com
  • 9 edits in trunk

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

renderbufferStorage(DEPTH_STENCIL) shouldn't generate an error
https://bugs.webkit.org/show_bug.cgi?id=48891

  • html/canvas/WebGLFramebuffer.cpp: (WebCore::WebGLFramebuffer::isIncomplete): Considering the case where DEPTH_STENCIL is not supported.
  • html/canvas/WebGLRenderbuffer.cpp: (WebCore::WebGLRenderbuffer::WebGLRenderbuffer): Init added members.
  • html/canvas/WebGLRenderbuffer.h: Add members and accessor functions. (WebCore::WebGLRenderbuffer::setInternalFormat): (WebCore::WebGLRenderbuffer::setSize): (WebCore::WebGLRenderbuffer::getWidth): (WebCore::WebGLRenderbuffer::getHeight): (WebCore::WebGLRenderbuffer::setIsValid): (WebCore::WebGLRenderbuffer::isValid):
  • html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::initializeNewContext): Check if packed_depth_stencil extension exists. (WebCore::WebGLRenderingContext::getRenderbufferParameter): Simulate the case for DEPTH_STENCIL where packed_depth_stencil is not supported. (WebCore::WebGLRenderingContext::renderbufferStorage): Bypass the call if packed_depth_stencil is not supported.
  • html/canvas/WebGLRenderingContext.h:

2010-11-03 Zhenyao Mo <zmo@google.com>

Reviewed by Kenneth Russell.

renderbufferStorage(DEPTH_STENCIL) shouldn't generate an error
https://bugs.webkit.org/show_bug.cgi?id=48891

  • fast/canvas/webgl/framebuffer-object-attachment-expected.txt:
  • fast/canvas/webgl/framebuffer-object-attachment.html: Add the test cases for DEPTH_STENCIL renderbuffer.
4:34 PM Changeset in webkit [71366] by commit-queue@webkit.org
  • 10 edits in trunk

2010-11-04 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Adam Barth.

Web Inspector: Enable files ystem UI for chromium
https://bugs.webkit.org/show_bug.cgi?id=48963

  • inspector/Inspector.idl:
  • inspector/InspectorFileSystemAgent.cpp: (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync):
  • inspector/InspectorFileSystemAgent.h:
  • inspector/front-end/FileSystemView.js: (WebInspector.FileSystemView): (WebInspector.FileSystemView.prototype.setFileSystemDisabled): (WebInspector.FileSystemView.prototype._createTextAndButton): (WebInspector.FileSystemView.prototype.refreshFileSystem):
  • inspector/front-end/StoragePanel.js: (WebInspector.StoragePanel.prototype.setFileSystemDisabled):
  • inspector/front-end/inspector.js: (WebInspector.didGetFileSystemDisabled): (WebInspector.reset):

2010-11-04 Kavita Kanetkar <kkanetkar@chromium.org>

Reviewed by Adam Barth.

Web Inspector: Enable files ystem UI for chromium
https://bugs.webkit.org/show_bug.cgi?id=48963

  • src/js/DevTools.js:
4:32 PM Changeset in webkit [71365] by dpranke@chromium.org
  • 2 edits in trunk/WebKitTools

2010-11-04 Dirk Pranke <dpranke@chromium.org>

Reviewed by James Robinson.

new-run-webkit-tests wasn't using DRT by default for
--platform chromium-gpu

The default value was set to False instead of None, which meant
that the platform specific logic wasn't firing to change the
value to True (b/c we were afraid we'd be overriding the user
preference).

https://bugs.webkit.org/show_bug.cgi?id=49038

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:31 PM Changeset in webkit [71364] by bweinstein@apple.com
  • 2 edits in trunk/LayoutTests

Part of https://bugs.webkit.org/show_bug.cgi?id=45980
userscripts/user-script-*-document.html tests are flaky on Windows

Rubber-stamped by Jon Honeycutt.

Unskip userscripts/user-script-audio-document.html on Windows, because it appears to be passing
and not flaky.

  • platform/win/Skipped:
4:24 PM Changeset in webkit [71363] by tony@chromium.org
  • 3 edits
    2 moves in trunk

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

make platform/chromium/plugins/multiple-plugins.html pass on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49026

Move the test from the chromium directory to the top level LayoutTests/plugins directory.

  • plugins/multiple-plugins-expected.txt: Renamed from LayoutTests/platform/chromium/plugins/multiple-plugins-expected.txt.
  • plugins/multiple-plugins.html: Renamed from LayoutTests/platform/chromium/plugins/multiple-plugins.html.

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

make platform/chromium/plugins/multiple-plugins.html pass on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49026

Have the testObject.bar property return the string "bar". This lets
us run and pass platform/chromium/plugins/multiple-plugins.html on all
platforms.

  • DumpRenderTree/TestNetscapePlugIn/TestObject.cpp: (testGetProperty):
3:45 PM Changeset in webkit [71362] by dumi@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium/test_expectations.txt:
3:40 PM Changeset in webkit [71361] by gyuyoung.kim@samsung.com
  • 2 edits in trunk

2010-11-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Adam Barth.

[EFL] Enable HTML5 Video
https://bugs.webkit.org/show_bug.cgi?id=48972

Enable HTML 5 Video option for WebKit EFL.

  • cmake/OptionsEfl.cmake:
3:38 PM Changeset in webkit [71360] by commit-queue@webkit.org
  • 2 edits in trunk/WebKit/efl

2010-11-04 Ryuan Choi <ryuan.choi@samsung.com>

Reviewed by Adam Barth.

[EFL] Reflect latest EFL changes related to stride.
https://bugs.webkit.org/show_bug.cgi?id=48971

Remove adjustment code to compare stride of cairo_image_surfece and evas_object_image, as following changes of latest EFL.

  • ewk/ewk_util.cpp: (ewk_util_image_from_cairo_surface_add):
3:21 PM Changeset in webkit [71359] by mihaip@chromium.org
  • 4 edits in trunk/WebKitTools

2010-11-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Tony Chang.

NRWT doesn't have good test coverage for --run-chunk, --batch-size, --run-part, etc.
https://bugs.webkit.org/show_bug.cgi?id=48878

Add get_tests_run so that it's easy to see which tests get run (and with
what batching) for a given flag combination. Flesh out the various
test cases that have FIXMEs.

Also fixes an off-by-one error (batch sizes were one larger than
expected) and makes --run-part also have wraparound behavior, like
--run-chunk.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2:51 PM Changeset in webkit [71358] by dumi@chromium.org
  • 11 edits
    6 adds in trunk/LayoutTests

Unreviewed, updating Chromium expectations.

  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.checksum:
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-linux/transforms/2d/transform-borderbox-expected.txt: Added.
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.checksum:
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium-linux/transforms/2d/transform-origin-borderbox-expected.txt: Added.
  • platform/chromium-mac/transforms/2d/transform-borderbox-expected.checksum: Added.
  • platform/chromium-mac/transforms/2d/transform-borderbox-expected.png: Added.
  • platform/chromium-mac/transforms/2d/transform-origin-borderbox-expected.checksum: Added.
  • platform/chromium-mac/transforms/2d/transform-origin-borderbox-expected.png: Added.
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.checksum:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.png:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.checksum:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.png:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
2:35 PM Changeset in webkit [71357] by tony@chromium.org
  • 3 edits
    1 delete in trunk/LayoutTests

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

handle plugins without mimetypes in fast/js/navigator-mimeTypes-length.html
https://bugs.webkit.org/show_bug.cgi?id=49015

This test was added in r15573 to verify that navigator.mimeTypes.length
returns the number of mimeTypes provided by plugins. However, it assumes
that there are more mimeTypes handled than plugins installed. It's
possible for a plugin to handle no mime types, so this invariant isn't
true. This often works on Win/Mac because they have a plugin that handles
multimedia files (like QuickTime), but on Linux, often there are no plugins
installed other than the test plugin (which handles 1 mime type).

Instead, add up the mime types from each plugin and verify that it
matches navigator.mimeTypes.length.

  • fast/js/navigator-mimeTypes-length-expected.txt:
  • fast/js/script-tests/navigator-mimeTypes-length.js:
  • platform/google-chrome-linux32/fast/js/navigator-mimeTypes-length-expected.txt: Removed.
2:19 PM Changeset in webkit [71356] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitSite

2010-11-04 Orlando Leite <orlleite@gmail.com>

Reviewed by Adam Barth.

Add Java for Mac OS X Developer Package to Installing Developer Tools web page

  • building/tools.html:
2:01 PM Changeset in webkit [71355] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2010-11-04 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

make plugins/update-widgets-crash.html resilient to multiple calls to NPP_SetWindow
https://bugs.webkit.org/show_bug.cgi?id=49013

When using the upstream TestNetscapePlugIn, on Chromium Linux, this
test passes, but setWindowCalled() is called twice before the test
is finished. This causes an exception to be thrown that 'victim'
doesn't have a parent node (since we already removed it during the
earlier call).

On different platforms, NPP_SetWindow is called a different number
of times.

  • plugins/update-widgets-crash.html:
1:41 PM Changeset in webkit [71354] by robert@webkit.org
  • 6 edits in trunk

2010-11-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Adler.

Stale reference to JSDOMWindow in ScriptController::m_cacheableBindingObject

Unskip fast/dom/nodesFromRect-basic.html on Qt.

https://bugs.webkit.org/show_bug.cgi?id=48758

  • platform/qt/Skipped:

2010-11-04 Robert Hogan <robert@webkit.org>

Reviewed by Darin Adler.

Stale reference to JSDOMWindow in ScriptController::m_cacheableBindingObject

After bug 37725 we need to update the globalObject() (i.e. JSDOMWindow)
associated with the m_cacheablebindingRootObject every time we clear the
frame and load a new page. This allows the runtime objects
(e.g. LayoutTestController etc.) to persist between navigations as
before but also ensures that when qt_runtime, or any other bridge,
looks at the root->globalObject() of a cacheable binding object
it gets the DOMWindow of the current page rather than the DOMWindow
that was in place when m_cacheableBindingRootObject was created.

Fixes fast/dom/nodesFromRect-basic.html on Qt.

https://bugs.webkit.org/show_bug.cgi?id=48758

  • bindings/js/ScriptController.cpp: (WebCore::ScriptController::clearWindowShell):
  • bridge/runtime_root.cpp: (JSC::Bindings::RootObject::updateGlobalObject):
  • bridge/runtime_root.h:
1:04 PM Changeset in webkit [71353] by mthole@apple.com
  • 4 edits in trunk/WebKit

Title for images should use localized numerals
https://bugs.webkit.org/show_bug.cgi?id=49017

Reviewed by Dan Bernstein.

WebKit:

  • English.lproj/Localizable.strings: Updated.

WebKit/mac:

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::imageTitle): Use localized numerals on Snow Leopard or newer.

12:41 PM Changeset in webkit [71352] by andreas.kling@nokia.com
  • 13 edits in trunk

2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Hyatt.

Delegate scrolling via a separate method
https://bugs.webkit.org/show_bug.cgi?id=48988

Implement delegatedScrollRequested and make it emit the
scrollRequested signal for Qt.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::delegatedScrollRequested):
  • WebCoreSupport/ChromeClientQt.h:

2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Hyatt.

Delegate scrolling via a separate method
https://bugs.webkit.org/show_bug.cgi?id=48988

Add a delegatedScrollRequested method to HostWindow for delegating
scrolling to the view. This is only used in conjunction with tiling,
and is ifdef'ed.

  • page/Chrome.cpp: (WebCore::Chrome::delegatedScrollRequested):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:
  • platform/ScrollView.cpp: (WebCore::ScrollView::setScrollPosition):

2010-11-04 Kenneth Rohde Christiansen <kenneth@webkit.org>

Reviewed by David Hyatt.

Delegate scrolling via a separate method
https://bugs.webkit.org/show_bug.cgi?id=48988

Add delegatedScrollRequested method to WebChromeClient,
which is only used in conjunging with tiling, and thus ifdef'ed.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::delegatedScrollRequested):
  • WebProcess/WebCoreSupport/WebChromeClient.h:
12:09 PM Changeset in webkit [71351] by pfeldman@chromium.org
  • 9 edits in trunk/WebCore

2010-11-04 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Timothy Hatcher.

Web Inspector: Need better way of switching back to the Timeline view of the Network tab.
https://bugs.webkit.org/show_bug.cgi?id=48995

  • Moved close button to the left, preceding tab headers;
  • Auto-adjusting summary bar width when switching to the preview mode
  • Auto-scrolling network log if it was scrolled to bottom.
  • inspector/front-end/DataGrid.js: (WebInspector.DataGrid): (WebInspector.DataGrid.prototype.isScrolledToLastRow): (WebInspector.DataGrid.prototype.scrollToLastRow):
  • inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel): (WebInspector.NetworkPanel.prototype.updateSidebarWidth): (WebInspector.NetworkPanel.prototype._positionSummaryBar): (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._toggleGridMode):
  • inspector/front-end/inspector.css: (.tabbed-pane-header li):
  • inspector/front-end/networkPanel.css: (.network-summary-bar): (#network-close-button): (#network-views.small #network-close-button): (#network-views .resource-view .tabbed-pane-header): (#network-views.small .resource-view .tabbed-pane-header):
12:00 PM Changeset in webkit [71350] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add a timing-out test to the Windows Skipped file

  • platform/win/Skipped:
11:46 AM Changeset in webkit [71349] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

Not reviewed. Build fix.

https://bugs.webkit.org/show_bug.cgi?id=48795

Skipping 4 media tests that trigger a hang in DRT.

  • platform/chromium/test_expectations.txt:
11:35 AM Changeset in webkit [71348] by arv@chromium.org
  • 35 edits
    2 adds in trunk

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Dimitri Glazkov.

Support box-sizing without the vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=36713

Based on patch by Peter Beverloo <peter@lvp-media.com>

Update the tests to use box-sizing instead of -webkit-box-sizing.

  • fast/borders/borderRadiusDashed05.html:
  • fast/css/box-sizing-backwards-compat-prefix-expected.txt: Added.
  • fast/css/box-sizing-backwards-compat-prefix.html: Added. This tests that both box-sizing and -webkit-box-sizing works.
  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-expected.txt:
  • platform/chromium-mac/fast/css/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/computed-style-expected.txt:
  • platform/chromium-win/fast/css/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
  • platform/chromium-win/transforms/2d/transform-borderbox-expected.txt:
  • platform/chromium-win/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-borderbox-expected.txt:
  • platform/gtk/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/mac/transforms/2d/transform-borderbox-expected.checksum:
  • platform/mac/transforms/2d/transform-borderbox-expected.txt:
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.checksum:
  • platform/mac/transforms/2d/transform-origin-borderbox-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
  • transforms/2d/transform-borderbox.html:
  • transforms/2d/transform-origin-borderbox.html:

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Dimitri Glazkov.

Support box-sizing without the vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=36713

Based on patch by Peter Beverloo <peter@lvp-media.com>

Test: fast/css/box-sizing-backwards-compat-prefix.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::cssPropertyID): This handles -webkit-box-sizing and maps it to box-sizing.
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/quirks.css: Change -webkit-box-sizing to box-sizing. (input:not([type=image]), textarea):
  • css/view-source.css: Ditto. (.webkit-line-gutter-backdrop, .webkit-line-number):
  • css/wml.css: Ditto. (do): (select):

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Dimitri Glazkov.

Support box-sizing without the vendor prefix
https://bugs.webkit.org/show_bug.cgi?id=36713

Based on patch by Peter Beverloo <peter@lvp-media.com>

  • iExploder/htdocs/cssproperties.in: Change -webkit-box-sizing to box-sizing.
11:29 AM Changeset in webkit [71347] by enrica@apple.com
  • 15 edits in trunk/WebKit2

Need a way to test in WebKit2 whether a form field contains marked text
<rdar://problem/8555293>
https://bugs.webkit.org/show_bug.cgi?id=48969

Reviewed by Alexey Proskuryakov.

Added a selection changed notification from the Web process to the UI process.
The message being sent contains information about the current selection.
Event though for this specific bug the only information required is the marked text,
I've added other selection information that will be needed to support IME.
All the stubbed methods are required methods by the NSTextInput protocol.

  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::selectionChanged): Added.

  • UIProcess/API/mac/WKView.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:pageNamespaceRef:]): Added initialization of new members.
(-[WKView _selectionChanged:isEditable:isPassword:hasMarkedText:]): Stores the values from
the selection changed message.
(-[WKView selectedRange]): Added stub.
(-[WKView hasMarkedText]): Implemented.
(-[WKView unmarkText]): Added stub.
(-[WKView validAttributesForMarkedText]): Added stub.
(-[WKView setMarkedText:selectedRange:]): Added stub.
(-[WKView markedRange]): Added stub.
(-[WKView attributedSubstringFromRange:]): Added stub.
(-[WKView conversationIdentifier]): Added stub.
(-[WKView characterIndexForPoint:]): Added stub.
(-[WKView firstRectForCharacterRange:]): Added stub.

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/qwkpage.cpp:

(QWKPagePrivate::selectionChanged): Added.

  • UIProcess/API/qt/qwkpage_p.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSelectionChange): New message handler.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebView.cpp:

(WebKit::WebView::selectionChanged): Added.

  • UIProcess/win/WebView.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::respondToChangedSelection): Added implementation.

11:02 AM Changeset in webkit [71346] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-04 John Reck <jreck@google.com>

Reviewed by Steve Block.

Fix a linker failure when building for Android
https://bugs.webkit.org/show_bug.cgi?id=48964

The Android stub for setCookieStoragePrivateBrowsingEnabled(bool) wasn't in the WebCore namespace, which caused
a linker failure when building for Android. Moved the stub to the WebCore namespace. This was caused by
http://trac.webkit.org/changeset/70400

No new tests, build fix only

  • platform/android/TemporaryLinkStubs.cpp:
11:01 AM WebKitGtkLayoutTests edited by Philippe Normand
(diff)
10:31 AM Changeset in webkit [71345] by eric@webkit.org
  • 3 edits
    2 adds in trunk

2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

The contract for all String/AtomicString methods seems to be that it's
safe to call them, even when the String is null (impl() returns 0).
This contract was broken by r49798 (unintentionally) when optimizing
for dromeo.
This patch adds a null check to AtomicString::lower() fixing this
crash and preventing future confusion.

  • wtf/text/AtomicString.cpp: (WTF::AtomicString::lower):

2010-11-04 Eric Seidel <eric@webkit.org>

Reviewed by Gavin Barraclough.

REGRESSION(49798): Crash in HTMLObjectElement::parseMappedAttribute
https://bugs.webkit.org/show_bug.cgi?id=48789

  • fast/dom/HTMLObjectElement/set-type-to-null-crash-expected.txt: Added.
  • fast/dom/HTMLObjectElement/set-type-to-null-crash.html: Added.
10:25 AM Changeset in webkit [71344] by andreas.kling@nokia.com
  • 5 edits in trunk/WebKit2

2010-11-04 Balazs Kelemen <kbalazs@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Cleanup UpdateChunk and MappedMemoryPool
https://bugs.webkit.org/show_bug.cgi?id=48994

  • Platform/qt/MappedMemoryPool.cpp: (WebKit::MappedMemoryPool::mapMemory): Removed argument with default value that was always used with the default value. (WebKit::MappedMemoryPool::mapFile): Ditto and add some asserts.
  • Platform/qt/MappedMemoryPool.h: Encapsulating MappedMemory and remove the unused MappedMemoryPool::searchForMappedMemory method. (WebKit::MappedMemory::mappedFile): (WebKit::MappedMemory::markFree): (WebKit::MappedMemory::data): (WebKit::MappedMemory::MappedMemory): (WebKit::MappedMemory::markUsed): (WebKit::MappedMemory::mapSize): (WebKit::MappedMemory::isFree): (WebKit::MappedMemoryPool::instance):
  • Shared/qt/UpdateChunk.cpp: Removed the unused data method besides other cleanups. (WebKit::UpdateChunk::UpdateChunk): (WebKit::UpdateChunk::encode): (WebKit::UpdateChunk::decode): (WebKit::UpdateChunk::createImage):
  • Shared/qt/UpdateChunk.h:
10:17 AM Changeset in webkit [71343] by andreas.kling@nokia.com
  • 3 edits
    2 adds in trunk/WebKit2

2010-11-04 Andreas Kling <kling@webkit.org>

Reviewed by Tor Arne Vestbø.

[Qt] Add a stub WebContextMenuProxy

This is the Qt equivalent of r71333.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::createContextMenuProxy):
  • UIProcess/qt/WebContextMenuProxyQt.cpp: Added. (WebKit::WebContextMenuProxyQt::WebContextMenuProxyQt): (WebKit::WebContextMenuProxyQt::create): (WebKit::WebContextMenuProxyQt::showContextMenu): (WebKit::WebContextMenuProxyQt::hideContextMenu):
  • UIProcess/qt/WebContextMenuProxyQt.h: Added.
  • WebKit2.pro:
10:16 AM Changeset in webkit [71342] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Unreviewed rollout r71340, because it broke Chromium Windows bot.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9:51 AM WebKit Team edited by reni@webkit.org
(diff)
9:44 AM Changeset in webkit [71341] by Joseph Pecoraro
  • 2 edits in trunk/WebCore

2010-11-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Andreas Kling.

Request.h getters can be made const
https://bugs.webkit.org/show_bug.cgi?id=49003

Added the const qualifier to some getters that don't mutate the object.

  • loader/Request.h: (WebCore::Request::cachedResource): (WebCore::Request::cachedResourceLoader): (WebCore::Request::isIncremental): (WebCore::Request::isMultipart):
9:44 AM Changeset in webkit [71340] by Csaba Osztrogonác
  • 3 edits in trunk/WebKitTools

Make http locking default in NRWT.
https://bugs.webkit.org/show_bug.cgi?id=48053

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-04
Reviewed by Ojan Vafai.

  • Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
9:38 AM Changeset in webkit [71339] by bweinstein@apple.com
  • 14 edits in trunk

User scripts shouldn't be injected in a frame's empty initial document.
https://bugs.webkit.org/show_bug.cgi?id=48970
<rdar://problem/8618164>
<rdar://problem/8082122>

Reviewed by Brady Eidson.

WebCore:

When a frame loads, it first creates an empty initial document, then navigates to the correct URL. Our
current policy with user scripts is to inject them into both the initial empty document, and then inject
them again.

This causes developers to think their scripts have been injected twice into all iframes, and there is a timing
issue between WebKit1 and WebKit2 that causes start scripts to be injected into the initial empty document
of the main frame when a new tab or window is created.

The fix for this is to not inject user scripts when the frame is creating its initial empty document before loading
the correct source.

  • page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

LayoutTests:

Update userscripts tests to reflect the fact that start scripts are not injected
in the initial load of about:blank in an iframe anymore.

This patch also makes the tests more verbose, and the results clearer to understand
by printing out the URLs of the documents that ran the content scripts.

  • userscripts/script-not-run-for-fragments-expected.txt:
  • userscripts/script-not-run-for-fragments.html:
  • userscripts/script-run-at-start-expected.txt:
  • userscripts/user-script-audio-document-expected.txt:
  • userscripts/user-script-audio-document.html:
  • userscripts/user-script-image-document-expected.txt:
  • userscripts/user-script-image-document.html:
  • userscripts/user-script-plugin-document-expected.txt:
  • userscripts/user-script-plugin-document.html:
  • userscripts/user-script-video-document-expected.txt:
  • userscripts/user-script-video-document.html:
9:08 AM Changeset in webkit [71338] by Csaba Osztrogonác
  • 4 edits in trunk/WebKitTools

[NRWT] Clear invalid http locks on Windows platform as well
https://bugs.webkit.org/show_bug.cgi?id=48515

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-04
Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/executive.py:
  • Scripts/webkitpy/common/system/executive_unittest.py:
  • Scripts/webkitpy/layout_tests/port/http_lock.py:
8:47 AM Changeset in webkit [71337] by andreas.kling@nokia.com
  • 5 edits in trunk/WebCore

2010-11-04 Andreas Kling <kling@webkit.org>

Reviewed by Nikolas Zimmermann.

GraphicsContext: Don't do full save/restore when painting with low quality scaling
https://bugs.webkit.org/show_bug.cgi?id=48738

Stash the imageInterpolationQuality() in a local and reset it after painting.

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::drawImage): (WebCore::GraphicsContext::drawTiledImage): (WebCore::GraphicsContext::drawImageBuffer):
  • platform/graphics/haiku/GraphicsContextHaiku.cpp: (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::imageInterpolationQuality):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::imageInterpolationQuality):
8:24 AM Changeset in webkit [71336] by Adam Roben
  • 2 edits
    5 adds in trunk/WebKitTools

Reduce our dependence on coreutils when running Python tests

This patch introduces versions of the standard echo and cat utilities
implemented in Python. They are probably missing features of their
coreutils equivalents, but they can do what's necessary for our Python
tests. This is useful on Windows, where these utilities typically
aren't available.

Fixes <http://webkit.org/b/48883> executive_unittest relies on echo
and cat utilities from coreutils, which are not present on Windows

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/executive_unittest.py: Changed to use

our Python-based echo and cat.

  • Scripts/webkitpy/common/system/fileutils.py: Added.

(make_stdout_binary): On Windows, puts sys.stdout into binary mode so
that \n won't be translated into \r\n. I couldn't think of a good way
to test this directly without touching the filesystem, but it is tested
indirectly by echo_unittest.

  • Scripts/webkitpy/test/cat.py: Added.

(command_arguments): Returns a list for invoking cat with the given arguments.
(main): Acts like a simplified version of the coreutils cat utility.

  • Scripts/webkitpy/test/cat_unittest.py: Added.

(CatTest.assert_cat): Runs cat with the given input and ensures the
output matches the input.
(CatTest.test_basic): Performs a simple test of cat.
(CatTest.test_no_newline): Tests what happens when the input string
doesn't have a trailing newline.
(CatTest.test_unicode): Tests passing a unicode string to cat.
(CatTest.test_as_command): Tests running cat as a separate command.

  • Scripts/webkitpy/test/echo.py: Added.

(command_arguments): Returns a list for invoking echo with the given arguments.
(main): Acts like a simplified version of the coreutils echo utility.

  • Scripts/webkitpy/test/echo_unittest.py: Added.

(EchoTest.test_basic): Performs a simple test of echo.
(EchoTest.test_no_newline): Tests passing -n to echo to suppress the
trailing newline.
(EchoTest.test_unicode): Tests passing unicode and non-unicode strings
to echo.
(EchoTest.test_argument_order): Tests what happens when -n is not the
first argument.
(EchoTest.test_empty_arguments): Tests what happens when you pass [] to
echo.main.
(EchoTest.test_no_arguments): Tests what happens when you call
echo.main with no arguments.
(EchoTest.test_as_command): Tests running echo as a separate command.

8:04 AM WebKit Team edited by reni@webkit.org
(diff)
8:00 AM Changeset in webkit [71335] by reni@webkit.org
  • 2 edits in trunk/WebKitTools

Unreviewed: Add myself to the list of Committers.

  • Scripts/webkitpy/common/config/committers.py:
7:51 AM Changeset in webkit [71334] by Adam Roben
  • 2 edits in trunk/LayoutTests

Add more failing tests to the Windows Skipped file

  • platform/win/Skipped:
7:31 AM Changeset in webkit [71333] by Adam Roben
  • 3 edits
    2 adds in trunk/WebKit2

Add a do-nothing WebContextMenuProxy implementation on Windows

Fixes <http://webkit.org/b/48992> REGRESSION (r71041): Crash in
WebPageProxy::showContextMenu when right-clicking in WebKit2 on
Windows

Reviewed by Dan Bernstein.

  • UIProcess/win/WebContextMenuProxyWin.cpp: Added.

(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin):
(WebKit::WebContextMenuProxyWin::create):
(WebKit::WebContextMenuProxyWin::showContextMenu):
(WebKit::WebContextMenuProxyWin::hideContextMenu):

  • UIProcess/win/WebContextMenuProxyWin.h: Added.

Just stubbed-out this class.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::createContextMenuProxy): Create a new
WebContextMenuProxyWin and return it. Returning 0 results in a crash.

  • win/WebKit2.vcproj: Added WebContextMenuProxyWin.
6:45 AM Changeset in webkit [71332] by andreas.kling@nokia.com
  • 3 edits in trunk/WebKitTools

2010-11-04 Andreas Kling <kling@webkit.org>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Hook into QWebPage::scrollRequested for resizes-to-contents mode

In RTC mode the QGraphicsWebView item is the size of the contents,
scrolling works a bit differently (we need to react to scrollRequested.)

Normally QGraphicsView will replay the last mouse event when scrolling,
so to prevent WebKit from getting confused by this we temporarily make
the QGraphicsView non-interactive.

  • QtTestBrowser/webview.cpp: (WebViewGraphicsBased::setPage): (WebViewGraphicsBased::scrollRequested):
  • QtTestBrowser/webview.h:
6:34 AM Changeset in webkit [71331] by vestbo@webkit.org
  • 2 edits in trunk/WebKitTools

Use OS(MAC_OS_X) rather than PLATFORM(MAC) in TestControllerQt

Reviewed by Andreas Kling.

PLATFORM(MAC) is not defined for the Qt port, as it refers to
the Mac-port, not the Mac OS X operating system.

  • WebKitTestRunner/qt/TestControllerQt.cpp:

(WTR::isExistingLibrary):

6:24 AM Changeset in webkit [71330] by vestbo@webkit.org
  • 2 edits in trunk/WebKit2

[Qt] Build Webkit2 both in debug and release on Mac

Reviewed by Andreas Kling..

On Mac OS X we build QtWebKit in both debug and release, so
we need to also build the webkit2 library in both configs.

  • WebKit2.pro:
6:06 AM Changeset in webkit [71329] by Nikolas Zimmermann
  • 12 edits
    2 adds
    1 delete in trunk/WebCore

2010-11-04 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Andreas Kling.

Refactor SVGStringListPropertyTearOff/SVGListPropertyTearOff to use a common base class
https://bugs.webkit.org/show_bug.cgi?id=48990

Introduce SVGListProperty as common base class between static lists (SVGStringListPropertyTearOff) and dynamic lists (SVGListPropertyTearOff).
This is a preparation for the addition of the next static list type: SVGPointList.

  • GNUmakefile.am: Add new files to build.
  • WebCore.gypi: Ditto.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGenerator.pm: s/SVGStringListPropertyTearOff/SVGStaticListPropertyTearOff/.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: Ditto.
  • bindings/scripts/CodeGeneratorV8.pm: Ditto.
  • svg/properties/SVGAnimatedListPropertyTearOff.h: Include SVGStaticListPropertyTearOff.h here, to avoid special dependencies in CodeGenerator*.pm
  • svg/properties/SVGListProperty.h: Added.
  • svg/properties/SVGListPropertyTearOff.h: Use SVGList API implementation from SVGListProperty base class.
  • svg/properties/SVGStaticListPropertyTearOff.h: Added. Use SVGList API implementation from SVGListProperty base class.
  • svg/properties/SVGStringListPropertyTearOff.h: Removed.
5:42 AM Changeset in webkit [71328] by rniwa@webkit.org
  • 2 edits in trunk/WebCore

2010-11-04 Ryosuke Niwa <rniwa@webkit.org>

Unreviewed. Fixed WebCore.xcodeproject

  • WebCore.xcodeproj/project.pbxproj:
5:39 AM Changeset in webkit [71327] by Adam Roben
  • 2 edits in trunk/WebKit2

Remove lame puts()s from WebPageProxy

Rubber-stamped by Anders Carlsson.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):

5:34 AM Changeset in webkit [71326] by jeremy@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2010-11-04 Jeremy Moskovich <jeremy@chromium.org>

No review - new baselines.

New Linux & Windows baselines for LayoutTests/fast/block/basic/truncation-rtl.html

https://bugs.webkit.org/show_bug.cgi?id=48917

  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/chromium-linux/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.checksum: Added.
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/chromium-win/fast/block/basic/truncation-rtl-expected.txt: Added.
5:29 AM Changeset in webkit [71325] by commit-queue@webkit.org
  • 2 edits in trunk/WebKitTools

2010-11-04 Leonid Ebril <leonid.ebril@nokia.com>

Reviewed by Andreas Kling.

[Qt] Adding iphone user agent string the user agent list for QtTestBrowser
https://bugs.webkit.org/show_bug.cgi?id=48869

  • QtTestBrowser/useragentlist.txt:
5:26 AM Changeset in webkit [71324] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip fast/dom/webtiming-document-open.html on Windows

Web Timing isn't implemented yet on Windows. We could check in
platform-specific results for this test, but all other Web Timing tests
are skipped.

  • platform/win/Skipped:
4:38 AM Changeset in webkit [71323] by Adam Roben
  • 2 edits in trunk/LayoutTests

Skip editing/style/iframe-onload-crash.html on Windows

It crashes there, too.

  • platform/win/Skipped:
4:34 AM Changeset in webkit [71322] by alex
  • 2 edits in trunk/LayoutTests

2010-11-04 Alejandro G. Castro <alex@igalia.com>

Unreviewed. Added fast/dom/webtiming-document-open.html to the
Skipped file, it was added in r71313, timing is disabled also in gtk.

  • platform/gtk/Skipped:
4:33 AM Changeset in webkit [71321] by Adam Roben
  • 2 edits in trunk/WebKitTools

Always use uppercase drive names in strings returned by abspath_to_uri

Some versions of cygpath use lowercase drive letters while others use
uppercase, which makes it hard to test the output of code that uses
cygpath.

Fixes <http://webkit.org/b/48914> webkitpy.common.system.path_unittest
fails with Cygwin 1.5

Reviewed by Eric Seidel.

  • Scripts/webkitpy/common/system/path.py:

(cygpath): Updated the docstring to indicate that only absolute paths
should be passed for now (though relative paths will work fine).
(_Cygpath.convert): Upper-case the first letter of the converted Windows path.

4:17 AM Changeset in webkit [71320] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] svg/animations/animate-path-nested-transforms.html fails
https://bugs.webkit.org/show_bug.cgi?id=48987

  • platform/qt/Skipped: svg/animations/animate-path-nested-transforms.html skipped until fix.
3:13 AM Changeset in webkit [71319] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed.

[Qt] REGRESSION (r71288): editing/style/iframe-onload-crash.html crashes
https://bugs.webkit.org/show_bug.cgi?id=48967

  • platform/qt/Skipped:
    • fast/dom/webtiming-document-open.html added, because web timing is disabled. (test introduced in r71313)
    • editing/style/iframe-onload-crash.html added until fix.
3:10 AM Changeset in webkit [71318] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk/WebCore

2010-11-04 Pratik Solanki <psolanki@apple.com>

Reviewed by Darin Adler.

Should make use of purge priorities for different resource types
https://bugs.webkit.org/show_bug.cgi?id=48684

Assign purge priorities to CachedResource objects. JavaScript and CSS stylesheets are more
important than images so hint to the kernel to purge them last. We do this by repurposing
the previously unused function, PurgeableBuffer::setPurgePriority(). It now just sets the
priority field and does not have side-effects like calling makePurgeable(true).

Also, remove unusued PurgeableBuffer::create(const Vector<char>&) function and move the
purgeable memory size threshold from CachedResource to PurgeableBuffer.

  • WebCore.xcodeproj/project.pbxproj: Add new PurgePriority.h header and mark it as private header.
  • loader/CachedCSSStyleSheet.h: (WebCore::CachedCSSStyleSheet::purgePriority):
  • loader/CachedImage.h: (WebCore::CachedImage::purgePriority):
  • loader/CachedResource.cpp: (WebCore::CachedResource::makePurgeable): Set the purge priority on the PurgeableBffer. Also, move the check for purgeable size threshold to PurgeableBuffer.
  • loader/CachedResource.h: (WebCore::CachedResource::purgePriority): Added. New virtual method that lets the class specify its purge priority.
  • loader/CachedScript.h: (WebCore::CachedScript::purgePriority):
  • platform/PurgePriority.h: Added. Move the PurgePriority enum from PurgeableBuffer class to its own header file. (WebCore::):
  • platform/PurgeableBuffer.h: (WebCore::PurgeableBuffer::setPurgePriority): Update this previously unused function to just set the priority and not call makePurgeable(true).
  • platform/mac/PurgeableBufferMac.cpp: Update size threshold to 16KB which is what CachedResource was using.
2:59 AM Changeset in webkit [71317] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-04 Chris Guillory <chris.guillory@google.com>

Reviewed by Chris Fleizach.

Ignore static text children of text field controls in the accessibility tree.
https://bugs.webkit.org/show_bug.cgi?id=48944

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
2:24 AM Changeset in webkit [71316] by arv@chromium.org
  • 5 edits in trunk

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Tony Chang.

Computed style is not correct for negative values in the presence of zooming
https://bugs.webkit.org/show_bug.cgi?id=48855

Updated the test to include some negative values. I also added tests for zoom less than one which in turn
forced me to increase the values because we lose a lot of precision when zooming out.

  • fast/css/getComputedStyle/computed-style-with-zoom-expected.txt: Updated the expectations
  • fast/css/getComputedStyle/script-tests/computed-style-with-zoom.js: Updated tests.

2010-11-04 Erik Arvidsson <arv@chromium.org>

Reviewed by Tony Chang.

Computed style is not correct for negative values in the presence of zooming
https://bugs.webkit.org/show_bug.cgi?id=48855

  • rendering/style/RenderStyle.h: (WebCore::adjustForAbsoluteZoom): When the value is less than zero we need to decrement instead of increment.
2:22 AM Changeset in webkit [71315] by robert@webkit.org
  • 2 edits in trunk/WebKit/qt

2010-11-04 Robert Hogan <robert@webkit.org>

Reviewed by Andreas Kling.

[Qt] Clarify expected return values of innerXml(), outerXml()

If you put HTML in (e.g. using setHTML()) you will get HTML out,
even if you marked it up as XML.

https://bugs.webkit.org/show_bug.cgi?id=44876

  • Api/qwebelement.cpp:
1:49 AM Changeset in webkit [71314] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2010-11-04 Shane Stephens <shanestephens@google.com>

Reviewed by Tony Chang.

SVGStyledTransformableElement supplemental transforms pre-multiplied
but should be post-multiplied.
https://bugs.webkit.org/show_bug.cgi?id=48026

  • svg/animations/animate-path-nested-transforms-expected.txt: Added.
  • svg/animations/animate-path-nested-transforms.svg: Added.

2010-11-04 Shane Stephens <shanestephens@google.com>

Reviewed by Tony Chang.

SVGStyledTransformableElement supplemental transforms pre-multiplied
but should be post-multiplied.
https://bugs.webkit.org/show_bug.cgi?id=48026

Test: svg/animations/animate-path-nested-transforms.svg

  • svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::animatedLocalTransform):

Switched order of multiplication. Note that due to a bug in
AffineTransform's operator* implementation the order of arguments is
reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).

1:36 AM Changeset in webkit [71313] by commit-queue@webkit.org
  • 18 edits
    1 copy
    5 adds in trunk

2010-11-04 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Implement dom* timing marks
https://bugs.webkit.org/show_bug.cgi?id=46301

  • fast/dom/Window/window-properties-performance-expected.txt:
  • fast/dom/script-tests/webtiming-async.js: Added.
  • fast/dom/script-tests/webtiming-defer.js: Added.
  • fast/dom/script-tests/webtiming-document-open.js: Added. (testTimingWithDocumentOpen):
  • fast/dom/script-tests/webtiming-navigate-within-document.js: (checkTimingNotChanged): Added dom timing.
  • fast/dom/script-tests/webtiming.js: (checkTimingBeforeLoad): Added dom timing. (checkTimingWhileDeferred): Added. (checkWebTimingWhileAsync): Added. (checkWebTimingOnLoad): Added dom timing. (checkWebTimingAfterLoad): Added dom timing.
  • fast/dom/webtiming-document-open-expected.txt: Added.
  • fast/dom/webtiming-document-open.html: Added.
  • fast/dom/webtiming-expected.txt:
  • fast/dom/webtiming-navigate-within-document-expected.txt:
  • fast/dom/webtiming.html: Added async and defer tests.
  • platform/mac/Skipped: Skip new webtiming test.

2010-11-04 James Simonsen <simonjam@chromium.org>

Reviewed by Darin Fisher.

[Web Timing] Implement dom* timing marks
https://bugs.webkit.org/show_bug.cgi?id=46301

Test: fast/dom/webtiming-document-open.html

  • GNUmakefile.am: Added DocumentTiming.h
  • WebCore.gypi: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::setReadyState): Set DOM WebTiming marks. (WebCore::Document::finishedParsing): Set DOM WebTiming marks.
  • dom/Document.h: (WebCore::Document::timing): Added.
  • dom/DocumentTiming.h: Added. (WebCore::DocumentTiming::DocumentTiming):
  • page/Timing.cpp: Added DOM timing. (WebCore::Timing::domLoading): Ditto. (WebCore::Timing::domInteractive): Ditto. (WebCore::Timing::domContentLoaded): Ditto. (WebCore::Timing::domComplete): Ditto. (WebCore::Timing::documentTiming): Ditto.
  • page/Timing.h: Ditto.
  • page/Timing.idl: Ditto.
1:23 AM Changeset in webkit [71312] by commit-queue@webkit.org
  • 2 edits in trunk/WebCore

2010-11-04 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Implement unencodable characters handling in TextCodecGtk::encode()
https://bugs.webkit.org/show_bug.cgi?id=48902

Fixes a crash in test fast/encoding/char-encoding.html.

  • platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::encode):
12:12 AM Changeset in webkit [71311] by abarth@webkit.org
  • 4 edits in trunk

2010-11-04 Adam Barth <abarth@webkit.org>

Enabled ICCJPEG on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=48977

  • wtf/Platform.h:

2010-11-04 Adam Barth <abarth@webkit.org>

Enabled ICCJPEG on Chromium Mac
https://bugs.webkit.org/show_bug.cgi?id=48977

Add iccjpeg as a dependency.

  • WebCore.gyp/WebCore.gyp:
12:00 AM Changeset in webkit [71310] by abarth@webkit.org
  • 2 edits in trunk/WebKit/chromium

2010-11-03 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=48978

  • DEPS:
Note: See TracTimeline for information about the timeline view.