Timeline



May 5, 2011:

11:46 PM Changeset in webkit [85921] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSPropertySpeak use the correct macro.
https://bugs.webkit.org/show_bug.cgi?id=60335

No tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use correct macro for CSSPropertySpeak.
11:44 PM Changeset in webkit [85920] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed flakiness marking.

  • platform/chromium/test_expectations.txt:
11:25 PM Changeset in webkit [85919] by jam@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-05 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Make IndexedDB code use WebPermissionClient API
https://bugs.webkit.org/show_bug.cgi?id=60340

  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowIndexedDB):
  • src/IDBFactoryBackendProxy.cpp: (WebKit::IDBFactoryBackendProxy::open):
11:22 PM Changeset in webkit [85918] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Maciej Stachowiak.

<rdar://problem/9390864>
https://bugs.webkit.org/show_bug.cgi?id=60343
Crash on Recovery System when trying to load page that includes media element

Automated test not possible, tested manually.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::isAvailable): Only return true if

AVFoundation and CoreMedia are installed.

  • platform/mac/SoftLinking.h: Define SOFT_LINK_FRAMEWORK_OPTIONAL, identical to

SOFT_LINK_FRAMEWORK except that it doesn't ASSERT if the framework doesn't exist.

11:06 PM Changeset in webkit [85917] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed attempt to error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
10:38 PM Changeset in webkit [85916] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
8:44 PM Changeset in webkit [85915] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed error fix on test_expectations.txt.

  • platform/chromium/test_expectations.txt:
8:36 PM Changeset in webkit [85914] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed addding skip line for full-screen-stacking-context.html.

  • platform/chromium/test_expectations.txt:
7:29 PM Changeset in webkit [85913] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Darin Adler.

Live streams sometimes won't play with AVFoundation backend
https://bugs.webkit.org/show_bug.cgi?id=58961
rdar://problem/9284748

Tested manually because we don't have any live streams to test in DRT.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::updateStates): Don't special case seeking, assume

AVFoundation will notify us when internal states change.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h: Make m_timeObserver

a RetainPtr

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Ditto. (WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
7:18 PM Changeset in webkit [85912] by ojan@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-05 Ojan Vafai <ojan@chromium.org>

Now that win has a failing result, chromium-win needs to
have the passing result. http://trac.webkit.org/changeset/85911

  • platform/chromium/fast/harness/results-expected.txt: Added.
7:04 PM Changeset in webkit [85911] by ojan@chromium.org
  • 1 edit
    1 move
    1 add in trunk/LayoutTests

2011-05-05 Ojan Vafai <ojan@chromium.org>

Move failing result as it appears to be failing on all Apple Win platforms.

  • platform/win/fast/harness/results-expected.txt: Renamed from LayoutTests/platform/win-7sp0/fast/harness/results-expected.txt.
6:43 PM Changeset in webkit [85910] by evan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Evan Martin <evan@chromium.org>

Unreviewed, just skipping a test.

New test fast/events/backspace-nagivates-back fails on Qt
https://bugs.webkit.org/show_bug.cgi?id=60311

Skip this test until Antonoi has time to look at it.

  • platform/qt-linux/Skipped:
6:37 PM Changeset in webkit [85909] by jcivelli@chromium.org
  • 9 edits
    2 adds in trunk/Source

2011-05-05 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Added convenience methods to convert from a byte to hex ASCII digit
characters and vice-versa.
https://bugs.webkit.org/show_bug.cgi?id=59834

  • wtf/ASCIICType.h: (WTF::toASCIIHexValue): (WTF::lowerNibbleToASCIIHexDigit): (WTF::upperNibbleToASCIIHexDigit):

2011-05-05 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding quoted-printable encoding/decoding capabilities.
This is needed for MHTML support.
https://bugs.webkit.org/show_bug.cgi?id=59834

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/QuotedPrintable.cpp: Added.
  • platform/text/QuotedPrintable.h: Added.
6:00 PM Changeset in webkit [85908] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

REGRESSION (r85689): Unresponsive timer firing when closing background tabs
<rdar://problem/9385988>
https://bugs.webkit.org/show_bug.cgi?id=60325

When calling WKPageTryClose(), if the page close succeeded, the notification to stop
the responsiveness timer would be dropped because the page was closed by the time it
got to the UIProcess.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::closePage):
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in: Add parameter to closePage stipulating whether or not to stop the responsiveness timer.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::tryClose): (WebKit::WebPage::sendClose): Instead of sending a StopResponsivenessTimer message after sending the ClosePage message, add a bit to the ClosePage message.
5:52 PM Changeset in webkit [85907] by jer.noble@apple.com
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, partial rollout of r85843 and r85824. r85897 made these expected results unnecessary.

  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Removed.
  • platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Removed.
5:48 PM Changeset in webkit [85906] by mitz@apple.com
  • 1 edit in trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

Fixed typos in a comment

5:28 PM Changeset in webkit [85905] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

2011-05-05 Steve Lacey <sjl@chromium.org>

Reviewed by Ojan Vafai.

Fix generation of results html file by passing relative path to scm
methods.
Generate diff images for results html file.

https://bugs.webkit.org/show_bug.cgi?id=60086

  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  • Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
5:19 PM Changeset in webkit [85904] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Kenji Imasaki <imasaki@chromium.org>

Reviewed by Jian Li.

[Chromium] Remove non-flaky tests (BUGCR81682, BUGCR80067)
and skip one unsupported test in test expectation file (BUGCR59399).
https://bugs.webkit.org/show_bug.cgi?id=60282

The skipped test is a cliking test that is specific to Mac and we
(Chrome Video Stack team) decided not to support it.

  • platform/chromium/test_expectations.txt:
5:12 PM Changeset in webkit [85903] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Andy Estes <aestes@apple.com>

Reviewed by Eric Seidel.

Implement document.innerHTML
https://bugs.webkit.org/show_bug.cgi?id=60316

ASSERT that contextElement is non-0 when constructing a HTMLTreeBuilder
for fragment parsing. This assertion will become invalid when
document.innerHTML is implemented, which is the only case where HTML5
specifies that a fragment will not have a context element.

  • html/parser/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
5:12 PM Changeset in webkit [85902] by kevino@webkit.org
  • 5 edits in trunk

[wx] Unreviewed build fixes after recent trunk changes.

5:09 PM Changeset in webkit [85901] by mitz@apple.com
  • 11 edits in trunk

Source/WebCore: WebCore part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebCore.exp.in: Export wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes): Account for the binary-compatiblity
check in Core Animation.

  • platform/mac/WebCoreSystemInterface.h: Added wkExecutableWasLinkedOnOrBeforeSnowLeopard.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac: WebKit part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

Source/WebKit2: WebKit2 part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Initialize wkExecutableWasLinkedOnOrBeforeSnowLeopard.

WebKitLibraries: WebKitSystemInterface part of <rdar://problem/9155590> Broken animation in iAd producer

Reviewed by Simon Fraser.

  • WebKitSystemInterface.h: Added WKExecutableWasLinkedOnOrBeforeSnowLeopard().
4:56 PM Changeset in webkit [85900] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

WebKit2 (Mac): Background tabs/windows can force themselves to the front
<rdar://problem/9386346>
https://bugs.webkit.org/show_bug.cgi?id=60315

  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): It is incorrect for us to call Chrome::focus() here, which could bring a window/tab to the front. Calling focusNSView() was only necessary because in WebKit we must inform the platform widget that the focus has changed. WebKit2 Mac now matches other ports.
4:54 PM Changeset in webkit [85899] by commit-queue@webkit.org
  • 58 edits
    7 deletes in trunk/LayoutTests

2011-05-05 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Seidel.

Rebaseline various media tests after absolute positioning change. This rebaseline also
fixes outstanding minor pixel diffs.

[chromium] Rebaseline various media tests after controls absolute positioning changes
https://bugs.webkit.org/show_bug.cgi?id=60230

  • platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-linux/media/video-no-audio-expected.png:
  • platform/chromium-gpu-mac/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-mac/media/video-no-audio-expected.png:
  • platform/chromium-gpu-win/media/video-display-toggle-expected.png:
  • platform/chromium-gpu-win/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/audio-controls-rendering-expected.png:
  • platform/chromium-linux/media/media-document-audio-repaint-expected.png:
  • platform/chromium-linux/media/video-controls-rendering-expected.png:
  • platform/chromium-linux/media/video-display-toggle-expected.png:
  • platform/chromium-linux/media/video-empty-source-expected.png:
  • platform/chromium-linux/media/video-no-audio-expected.png:
  • platform/chromium-linux/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/audio-controls-rendering-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-after-reload-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-strict-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/controls-styling-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac-leopard/media/video-controls-rendering-expected.png:
  • platform/chromium-mac-leopard/media/video-display-toggle-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.png:
  • platform/chromium-mac-leopard/media/video-empty-source-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-no-audio-expected.png:
  • platform/chromium-mac-leopard/media/video-no-audio-expected.txt: Removed.
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.png:
  • platform/chromium-mac-leopard/media/video-volume-slider-expected.txt: Removed.
  • platform/chromium-mac/media/audio-controls-rendering-expected.png:
  • platform/chromium-mac/media/audio-controls-rendering-expected.txt:
  • platform/chromium-mac/media/controls-after-reload-expected.txt:
  • platform/chromium-mac/media/controls-strict-expected.txt:
  • platform/chromium-mac/media/controls-styling-expected.txt:
  • platform/chromium-mac/media/controls-without-preload-expected.txt:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.png:
  • platform/chromium-mac/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-mac/media/video-controls-rendering-expected.png:
  • platform/chromium-mac/media/video-controls-rendering-expected.txt:
  • platform/chromium-mac/media/video-display-toggle-expected.png:
  • platform/chromium-mac/media/video-display-toggle-expected.txt:
  • platform/chromium-mac/media/video-empty-source-expected.png:
  • platform/chromium-mac/media/video-empty-source-expected.txt:
  • platform/chromium-mac/media/video-no-audio-expected.png:
  • platform/chromium-mac/media/video-no-audio-expected.txt:
  • platform/chromium-mac/media/video-volume-slider-expected.png:
  • platform/chromium-mac/media/video-volume-slider-expected.txt:
  • platform/chromium-win/media/audio-controls-rendering-expected.png:
  • platform/chromium-win/media/audio-controls-rendering-expected.txt:
  • platform/chromium-win/media/controls-after-reload-expected.txt:
  • platform/chromium-win/media/controls-strict-expected.txt:
  • platform/chromium-win/media/controls-styling-expected.txt:
  • platform/chromium-win/media/controls-without-preload-expected.txt:
  • platform/chromium-win/media/media-document-audio-repaint-expected.png:
  • platform/chromium-win/media/media-document-audio-repaint-expected.txt:
  • platform/chromium-win/media/video-controls-rendering-expected.png:
  • platform/chromium-win/media/video-controls-rendering-expected.txt:
  • platform/chromium-win/media/video-display-toggle-expected.png:
  • platform/chromium-win/media/video-display-toggle-expected.txt:
  • platform/chromium-win/media/video-empty-source-expected.png:
  • platform/chromium-win/media/video-empty-source-expected.txt:
  • platform/chromium-win/media/video-no-audio-expected.png:
  • platform/chromium-win/media/video-no-audio-expected.txt:
  • platform/chromium-win/media/video-volume-slider-expected.png:
  • platform/chromium-win/media/video-volume-slider-expected.txt:
  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [85898] by aestes@apple.com
  • 2 edits in trunk/Tools

2011-05-05 Andy Estes <aestes@apple.com>

Reviewed by Daniel Bates.

update-webkit should handle Internal using a different VCS than OpenSource.
https://bugs.webkit.org/show_bug.cgi?id=60310

isGit() and isSVN() cache their results, so Internal will always be
updated using the VCS commands used for OpenSource. If Internal uses a
different VCS, this will fail. Fix this by calling isGitDirectory() and
isSVNDirectory() instead, which do not cache their results.

  • Scripts/update-webkit:
4:07 PM Changeset in webkit [85897] by jer.noble@apple.com
  • 4 edits
    3 deletes in trunk/LayoutTests

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Tony Chang.

full-screen-stacking-context-expected.txt should be under platform/mac
https://bugs.webkit.org/show_bug.cgi?id=60236

Make the text output of full screen pixel tests platform agnostic.

  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/full-screen-test.js:
  • fullscreen/full-screen-zIndex-expected.txt:
  • platform/chromium-linux/fullscreen/full-screen-zIndex-expected.txt: Removed.
  • platform/chromium-win/fullscreen/full-screen-zIndex-expected.txt: Removed.
  • platform/gtk/fullscreen/full-screen-zIndex-expected.txt: Removed.
3:42 PM Changeset in webkit [85896] by dpranke@chromium.org
  • 10 edits in trunk/Tools

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

nrwt: revamp integration tests incl. tests for servers
https://bugs.webkit.org/show_bug.cgi?id=59985

This change adds the ability to run "integration tests" that
depend on (and affect) the local environment on your machine.
These tests can be run manually by invoking python on the
test file in question and passing the '-i' flag, but are
not run automatically as part of test-webkitpy.

Integration tests are identified by being methods named as
"integration_test_*" instead of "test_*", and we use a
custom TestLoader instead of the default one provided by
unittest.

This change also adds a protected "_default_to_apache" method
to the port object so we can do the right thing when starting
and stopping web servers with less mechanism.

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  • Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  • Scripts/webkitpy/layout_tests/port/port_testcase.py:
3:39 PM Changeset in webkit [85895] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-05 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
https://bugs.webkit.org/show_bug.cgi?id=60173

  • platform/chromium/test_expectations.txt: Adding expected failures for the the switch to Ganesh

2011-05-05 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Change the --accelerated-2d-canvas flag to mean Ganesh, and stop using --enable-accelerated-drawing for that purpose
https://bugs.webkit.org/show_bug.cgi?id=60173

  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): Flipping the switch to make Skia the default for the accelerated 2d canvas
3:38 PM Changeset in webkit [85894] by tonyg@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101

  • fast/parser/close-while-stopping-expected.txt: Added.
  • fast/parser/close-while-stopping.html: Added.

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Adam Barth.

ASSERT(m_state == ParsingState) fires @ www.canalplus.fr
https://bugs.webkit.org/show_bug.cgi?id=60101

Test: fast/parser/close-while-stopping.html

3:23 PM Changeset in webkit [85893] by evan@chromium.org
  • 4 edits
    2 adds in trunk

2011-05-03 Evan Martin <evan@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731

Add a test that verifies that pressing backspace goes back on Mac
and Windows but does not go back on Linux.

  • fast/events/backspace-navigates-back-expected.txt: Added.
  • fast/events/backspace-navigates-back.html: Added.

2011-04-28 Evan Martin <evan@chromium.org>

Reviewed by Ojan Vafai.

REGRESSION: backspace should not go back on Linux
https://bugs.webkit.org/show_bug.cgi?id=59731

Add a new EditingBehavior, shouldNavigateBackOnBackspace, which is false on
Linux, and test for it in the default backspace handler.

  • editing/EditingBehavior.h: (WebCore::EditingBehavior::shouldNavigateBackOnBackspace):
  • page/EventHandler.cpp: (WebCore::EventHandler::defaultBackspaceEventHandler):
3:14 PM Changeset in webkit [85892] by hclam@chromium.org
  • 1 edit
    8 adds in trunk/LayoutTests

2011-05-05 Alpha Lam <hclam@chromium.org>

Build fix. Not reviewed.

Add test expectations.

  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • platform/chromium-linux/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • platform/chromium-win/fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
3:10 PM Changeset in webkit [85891] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-05 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Kenneth Russell.

Framebuffer object is being created twice
https://bugs.webkit.org/show_bug.cgi?id=60207

Does not create more than one opengl framebuffer

  • platform/graphics/gpu/mac/DrawingBufferMac.mm: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gpu/qt/DrawingBufferQt.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
  • platform/graphics/gtk/DrawingBufferGtk.cpp: (WebCore::DrawingBuffer::DrawingBuffer):
3:09 PM Changeset in webkit [85890] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

2011-05-05 Simon Fraser <Simon Fraser>

Reviewed by Beth Dakin.

Every RenderLayer registers itself as a ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=59650

Rather than registering every RenderLayer as a ScrollableArea
on layer creation, only register RenderLayers which are overflow-
scrollable. Use the m_scrollableAreaPage pointer to keep track
of whether we've registered to avoid excess work.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollsOverflow): (WebCore::RenderLayer::styleChanged):
  • rendering/RenderLayer.h:
3:06 PM Changeset in webkit [85889] by Adam Roben
  • 4 edits in trunk

Update pixel results for draws-gradient.html to have an alpha channel

These pixel results were generated in r71418, when DRT was changed not to use an alpha
channel for pixel results. DRT was changed back to using an alpha channel in r71516, but
these pixel results were never updated. Now that DRT ensures that the alpha channel is
filled with constant opacity, we can safely update these pixel results without negatively
affecting their appearance. (The draws-gradient plugin uses ::GradientFill, which fills the
alpha channel with 0, so the plugin would have shown up as fully transparent in the pixel
results if DRT didn't modify the alpha channel.)

Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
generated due to alpha channel weirdness

Reviewed by Sam Weinig.

LayoutTests:

  • platform/win/platform/win/plugins/draws-gradient-expected.png: Regenerated. Looks the same

as before, but with an alpha channel.

Tools:

Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows

DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
alpha channel will even get filled with zeros (like when ::GradientFill is used). To
safeguard against this, we fill the alpha channel with constant full opacity after the
WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
results need an alpha channel, too.)

  • DumpRenderTree/win/PixelDumpSupportWin.cpp:

(makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
constant full opacity.
(createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
in a CGContext or cairo_surface.

3:05 PM Changeset in webkit [85888] by Adam Roben
  • 6 edits in trunk/Tools

Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner

Passing true tells the test harness to dump pixels even though we're not dumping a render
tree.

Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
WebKitTestRunner doesn't result in pixel results being generated

Reviewed by Sam Weinig.

  • WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels

argument to dumpAsText.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Updated for dumpAsText change.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
  • WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows

developers.

3:04 PM Changeset in webkit [85887] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] [WK2] Add method to disable plugins under WK2
https://bugs.webkit.org/show_bug.cgi?id=57796

  • config.h: Allow PLUGIN_ARCHITECTURE_UNSUPPORTED to be defined on build command line
2:59 PM Changeset in webkit [85886] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-05 Jer Noble <jer.noble@apple.com>

Reviewed by Steve Falkenburg.

Workaround iTunes' incorrect registry entry for .m4a extensions.
https://bugs.webkit.org/show_bug.cgi?id=60229

No new tests, as a test already exits for .m4a support (LayoutTests/media/audio-mpeg4-supported.html).
The test failed to catch this regression because the build bots haven't installed iTunes.

Add a hard-coded MIME type mapping for 'm4a' -> 'audio/x-m4a'.

  • platform/win/MIMETypeRegistryWin.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
2:57 PM Changeset in webkit [85885] by inferno@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-05 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Minor rebaselines for gtk after my r85876.

  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/gtk/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
2:49 PM Changeset in webkit [85884] by tony@chromium.org
  • 1 edit
    10 deletes in trunk/LayoutTests

2011-05-05 Tony Chang <tony@chromium.org>

Remove google-chrome-linux results. We're switching the official
builders from hardy to lucid and want to clear the old hardy based
results.

  • platform/google-chrome-linux32/css1: Removed.
  • platform/google-chrome-linux32/css2.1: Removed.
  • platform/google-chrome-linux32/editing: Removed.
  • platform/google-chrome-linux32/fast: Removed.
  • platform/google-chrome-linux32/plugins: Removed.
  • platform/google-chrome-linux32/svg: Removed.
  • platform/google-chrome-linux32/tables: Removed.
  • platform/google-chrome-linux32/transforms: Removed.
  • platform/google-chrome-linux64/fast: Removed.
  • platform/google-chrome-linux64/svg: Removed.
2:49 PM Changeset in webkit [85883] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

2:42 PM Changeset in webkit [85882] by inferno@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-05 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Minor rebaselines for qt after my r85876.

  • platform/qt/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • platform/qt/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
2:42 PM Changeset in webkit [85881] by Lucas Forschler
  • 1 copy in tags/Safari-534.34

New tag.

2:41 PM Changeset in webkit [85880] by dpranke@chromium.org
  • 6 edits in trunk

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

Modify the chromium expectations so that you no longer need to
specify both the operating system and the version. I.e., you
don't need "MAC LEOPARD", just "LEOPARD".

  • platform/chromium/test_expectations.txt:

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: merge os, version fields in test config
https://bugs.webkit.org/show_bug.cgi?id=60004

This change removes the 'o/s' field from the TestConfiguration
object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
the expectations file to macros that expand to the version names
for each platform.

This means that you can once again put any subset of the
operating system versions on a single line, e.g.:

BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL

This change will break any existing test_expectations.txt
file that uses the "OS-VERSION" macros, which are no longer
needed. It turns out they were never needed, as just VERSION
by itself was sufficient. The test_expectations.txt file should
be updated accordingly prior to landing this change.

  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
2:26 PM Changeset in webkit [85879] by tony@chromium.org
  • 17 edits
    6 copies
    13 adds in trunk

2011-05-05 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] switch from Lucida to free fonts for Hindi and Thai
https://bugs.webkit.org/show_bug.cgi?id=60287

Rebase tests that have Thai or Hindi glyphs. We have different
results for x86_64 (lucid) and x86 (hardy) because the fonts have
changed. Since it's only a handful of tests, seems ok to have
separate baselines (also, hardy is going away real soon now).

  • platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.png: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png.
  • platform/chromium-linux-x86_64/fast/text/atsui-multiple-renderers-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/capitalize-boundaries-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/complex-text-opacity-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux-x86_64/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/danda-space-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/hindi-spacing-expected.txt: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-baht-space-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt.
  • platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.png: Added.
  • platform/chromium-linux-x86_64/fast/text/international/thai-line-breaks-expected.txt: Added.
  • platform/chromium-linux-x86_64/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt.
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.png:
  • platform/chromium-linux/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.png:
  • platform/chromium-linux/fast/text/complex-text-opacity-expected.txt:
  • platform/chromium-linux/fast/text/international/complex-joining-using-gpos-expected.txt:
  • platform/chromium-linux/fast/text/international/danda-space-expected.png:
  • platform/chromium-linux/fast/text/international/danda-space-expected.txt:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.png:
  • platform/chromium-linux/fast/text/international/hindi-spacing-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.txt:

2011-05-05 Tony Chang <tony@chromium.org>

Reviewed by Adam Barth.

[chromium] switch from Lucida to free fonts for Hindi and Thai
https://bugs.webkit.org/show_bug.cgi?id=60287

The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
packages on Lucid. There are actually multiple Thai fonts in the
package, so I just picked one.

  • DumpRenderTree/chromium/TestShellGtk.cpp: (setupFontconfig):
2:14 PM Changeset in webkit [85878] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

When an underlay surface is active, paint normal web contents in a transparency layer
https://bugs.webkit.org/show_bug.cgi?id=60296

In order for the page contents to correctly blend with the underlay, the page contents
needs to be painted in a transparency layer.

  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::drawRect):
2:13 PM Changeset in webkit [85877] by tony@chromium.org
  • 2 edits in trunk/Tools

2011-05-05 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
https://bugs.webkit.org/show_bug.cgi?id=60290

It used to be that google-chrome-32 was hardy32, google-chrome-64 was
hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
lucid64. Because of that, google-chrome-64 used to skip the
chromium-linux-x86_64 results since they were more incorrect.

Now that we're switching to lucid for google-chrome, we want
google-chrome-64 to fall back to chromium-linux-x86_64.

  • Scripts/webkitpy/layout_tests/port/google_chrome.py:
2:07 PM Changeset in webkit [85876] by inferno@chromium.org
  • 4 edits
    14 adds in trunk

2011-05-05 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

When style changes for a RenderBlock and we lose our ability to intrude into
floats in the next siblings block (e.g a position change), make sure to mark
our childs with floats for layout and iterate through our next sibling block
chain to see which ones contain the float that also exists in our floating
objects list and clear those using markAllDescendantsWithFloatsForLayout.
https://bugs.webkit.org/show_bug.cgi?id=56299

Tests: fast/block/float/float-not-removed-from-next-sibling-crash.html

fast/block/float/float-not-removed-from-next-sibling.html
fast/block/float/float-not-removed-from-next-sibling2.html
fast/block/float/float-not-removed-from-next-sibling3.html
fast/block/float/float-not-removed-from-next-sibling4.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::styleWillChange): (WebCore::RenderBlock::styleDidChange): (WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
  • rendering/RenderBlock.h:

2011-05-04 Abhishek Arya <inferno@chromium.org>

Reviewed by Dave Hyatt.

Tests that we do not crash when trying to add overflow from a float not in the
descendant list and whose renderer is already removed.
https://bugs.webkit.org/show_bug.cgi?id=56299

  • fast/block/float/float-not-removed-from-next-sibling-crash-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling-crash.html: Added.
  • fast/block/float/float-not-removed-from-next-sibling.html: Added. Black text boxes should be inside the silver float. Failing test will have float added to the text div block which will push the text downward.
  • fast/block/float/float-not-removed-from-next-sibling-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling2.html: Added. Black text boxes should be inside the silver float. Failing test will have float added to the text div block which will push the text downward.
  • fast/block/float/float-not-removed-from-next-sibling2-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling3.html: Added. Distance between the silver float and black text boxes should be less than height of silver float. Failing test will have float overflow added to the text div block which will cause large space between silver float and and black text boxes.
  • fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added.
  • fast/block/float/float-not-removed-from-next-sibling4.html: Added. Distance between the silver float and black text boxes should be less than height of silver float. Failing test will have float overflow added to the text div block which will cause large space between silver float and and black text boxes.
  • fast/block/float/float-not-removed-from-next-sibling4-expected.png: Added.
  • fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Added.
1:55 PM Changeset in webkit [85875] by dpranke@chromium.org
  • 7 edits in trunk/Tools

2011-05-05 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
https://bugs.webkit.org/show_bug.cgi?id=60002

  • Scripts/webkitpy/layout_tests/layout_package/manager.py:
  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  • Scripts/webkitpy/style/checkers/test_expectations.py:
1:31 PM Changeset in webkit [85874] by bweinstein@apple.com
  • 6 edits in trunk/Source

Source/WebCore: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Make a needed function public and export it.

  • WebCore.exp.in: Export constrainedAttaechedWindowHeight.
  • inspector/InspectorFrontendClientLocal.h: Make constrainedAttaechedWindowHeight public.

Source/WebKit2: WebKit2: Docking Web Inspector doesn't respect maximum inspector size
https://bugs.webkit.org/show_bug.cgi?id=60294
<rdar://problem/9388518>

Reviewed by Timothy Hatcher.

Before we place the inspector and the inspected views, make sure that we have constrained the height
of the docked inspector. Putting the code here covers both when the inspector is initially attached
and when a window with the docked inspector is resized.

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Constrain the height before laying out the views.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Ditto.

1:30 PM Changeset in webkit [85873] by tonyg@chromium.org
  • 6 edits in trunk

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
https://bugs.webkit.org/show_bug.cgi?id=59448

  • http/tests/misc/resources/webtiming-cross-origin-and-back2.html:
  • http/tests/misc/resources/webtiming-cross-origin-redirect.html:
  • http/tests/misc/webtiming-origins-expected.txt:

2011-05-05 Tony Gentilcore <tonyg@chromium.org>

Reviewed by Nate Chapin.

[Navigation Timing] navigationStart should always be available
https://bugs.webkit.org/show_bug.cgi?id=59448

  • page/PerformanceTiming.cpp: (WebCore::PerformanceTiming::navigationStart):
1:21 PM Changeset in webkit [85872] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

Block callbacks delivered during destruction
https://bugs.webkit.org/show_bug.cgi?id=60291
<rdar://problem/9382942>

No new tests, tested by existing tests.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::~MediaPlayerPrivateAVFoundation): Call

setIgnoreLoadStateChanges(true) to cancel all callbacks.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Return immediately if

m_ignoreLoadStateChanges is true.

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): loadStateChanged -> updateStates.

Don't call updateStates after calling loadedTimeRangesChanged, it already does it.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
1:18 PM Changeset in webkit [85871] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-05 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

commit-queue should reject patches which fail ewses
https://bugs.webkit.org/show_bug.cgi?id=47534

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1:13 PM Changeset in webkit [85870] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>

Reviewed by Simon Hausmann.

Install correct header files for webkit.

Since WebKit is no longer inside Qt, we can remove the detection for
that.

[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=57621

  • Source/sync.profile:

2011-05-05 Prasanth Ullattil <prasanth.ullattil@nokia.com>

Reviewed by Simon Hausmann.

Install correct header files for webkit.

Since WebKit is no longer inside Qt, we can remove the detection for
that.

[Qt] Install targets are not working correctly for modularized Qt and QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=57621

1:04 PM Changeset in webkit [85869] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/9354979> REGRESSION (r83070-r83126): Conversation takes 10 seconds to load and makes mail unresponsive

Reviewed by Darin Adler.

Culled inlines were triggering some pathological line box tree groveling that isn't even necessary.
Removed the ancient code (that used to be in RenderFlow), since it made no sense in the RenderBlock case
(it was running for inline blocks, which was definitely not even the intent) or in the RenderInline case
(the object being removed has no effect on any lines).

Also tweaked culledInlineFirstLineBox and culledInlineLastLineBox to avoid bailing if the first replaced object that
is encountered has a null inlineBoxWrapper(). Just a slight speed optimization to avoid an extra null check.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::destroy):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::destroy):
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):

12:21 PM Changeset in webkit [85868] by commit-queue@webkit.org
  • 4 edits in trunk/Source

2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>

Reviewed by Holger Freyther.

Fix build-webkit --minimal.
https://bugs.webkit.org/show_bug.cgi?id=60257

No new tests. This is just a build fix.

  • bindings/js/JSDOMBinding.cpp:

2011-05-05 Bharathwaaj Srinivasan <bharathwaaj.s@gmail.com>

Reviewed by Holger Freyther.

Fix build-webkit --minimal.
https://bugs.webkit.org/show_bug.cgi?id=60257

  • webkit/webkitglobals.cpp: (webkitInit):
12:05 PM Changeset in webkit [85867] by commit-queue@webkit.org
  • 11 edits in trunk

2011-05-05 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

Unskip passed tests.

  • platform/qt-wk2/Skipped:

2011-05-05 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

Added private constructors for class QGraphicsWKView and QWKPage to support
WKPageGroupRef.

  • UIProcess/API/qt/qgraphicswkview.cpp: (QGraphicsWKView::QGraphicsWKView): (QGraphicsWKView::~QGraphicsWKView): (QGraphicsWKView::init):
  • UIProcess/API/qt/qgraphicswkview.h:
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::QWKPagePrivate): (QWKPage::QWKPage): (QWKPage::~QWKPage): (QWKPage::init):
  • UIProcess/API/qt/qwkpage.h:
  • UIProcess/API/qt/qwkpage_p.h:

2011-05-05 Chang Shu <cshu@webkit.org>

Reviewed by Andreas Kling.

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

  1. Call QGraphicsWKView constructor with pageGroupRef.
  2. Disable setFontFamily calls as it breaks Qt test fonts.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::WebView::WebView): (WTR::PlatformWebView::PlatformWebView):
11:22 AM Changeset in webkit [85866] by abarth@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-05 Adam Barth <abarth@webkit.org>

Roll Chromium DEPS.

  • DEPS:
11:17 AM Changeset in webkit [85865] by eric.carlson@apple.com
  • 8 edits in trunk/Source/WebCore

2011-05-05 Eric Carlson <eric.carlson@apple.com>

Reviewed by Adam Roben.

The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/9369746>

This change implements "preload=metadata" for the AVFoundation backend.
Tested manually with manual-tests/media-elements/video-preload.html.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay. (WebCore::HTMLMediaElement::prepareForLoad): Ditto. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'auto'

because we need to have media data loaded to seek.

(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.

  • html/HTMLMediaElement.h:
  • manual-tests/media-elements/video-preload.html: Make changing urls work.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove

m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.

(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.

Move all preload logic to setPreload, call it from here.

(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to

setPreload, call it.

(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is

unlikely to be correct and isn't worth caching. Use invalidTime() function.

(WebCore::MediaPlayerPrivateAVFoundation::seeking): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::setNaturalSize): Add logging.
(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus

to AssetStatus. Always create a AVPlayerItem for live streams because they can't be inspected
without one. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.

(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache

width, height, hasVideo, etc.

(WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): Use invalidTime() function.
(WebCore::MediaPlayerPrivateAVFoundation::timeChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done

in derived classes.

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create

AVAsset and AVPlayerItem here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_videoFrameHasDrawn.

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from

videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset

if necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when

the buffer is full.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the

AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset

when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before

we have allocated the AVPlayerItem.

11:14 AM Changeset in webkit [85864] by rniwa@webkit.org
  • 88 edits
    5 moves in trunk/Source

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::selectWordAroundCaret):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::textInputType): (WebKit::WebViewImpl::caretOrSelectionBounds): (WebKit::WebViewImpl::caretOrSelectionRange): (WebKit::WebViewImpl::clearFocusedNode):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • Api/qwebframe.cpp:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • webkit/webkitwebview.cpp: (getLocationForKeyboardGeneratedContextMenu):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebView.cpp:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebDOMSelection.cpp:
  • WebDOMSelection.h:
  • WebKitSupport/EditorClientWx.cpp:
  • WebView.cpp:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebView/WebFrame.mm: (-[WebFrame _rangeByAlteringCurrentSelection:FrameSelection::direction:granularity:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLView.mm:
  • WebView/WebTextCompletionController.mm: (-[WebTextCompletionController doCompletion]):
  • WebView/WebView.mm:

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientHaiku.cpp: (WebCore::EditorClientHaiku::handleKeyboardEvent):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientWinCE.cpp: (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • WebCoreSupport/EditorClientEfl.cpp: (WebCore::EditorClientEfl::handleEditingKeyboardEvent):

2011-05-05 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.exp.in:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • accessibility/AccessibilityObject.cpp:
  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::visiblePositionRangeForLine):
  • accessibility/mac/AccessibilityObjectWrapper.mm:
  • bindings/objc/ExceptionHandlers.h:
  • css/CSSStyleSelector.cpp:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
  • dom/Document.cpp:
  • dom/InputElement.cpp:
  • editing/DeleteButtonController.cpp:
  • editing/EditCommand.cpp:
  • editing/EditingAllInOne.cpp:
  • editing/EditingStyle.cpp:
  • editing/Editor.cpp: (WebCore::Editor::canCopy): (WebCore::Editor::canDelete): (WebCore::Editor::markMisspellingsAfterTypingToWord): (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): (WebCore::Editor::changeSelectionAfterCommand): (WebCore::Editor::respondToChangedSelection):
  • editing/Editor.h:
  • editing/EditorCommand.cpp: (WebCore::executeDeleteToMark): (WebCore::executeMoveBackward): (WebCore::executeMoveBackwardAndModifySelection): (WebCore::executeMoveDown): (WebCore::executeMoveDownAndModifySelection): (WebCore::executeMoveForward): (WebCore::executeMoveForwardAndModifySelection): (WebCore::executeMoveLeft): (WebCore::executeMoveLeftAndModifySelection): (WebCore::executeMovePageDown): (WebCore::executeMovePageDownAndModifySelection): (WebCore::executeMovePageUp): (WebCore::executeMovePageUpAndModifySelection): (WebCore::executeMoveRight): (WebCore::executeMoveRightAndModifySelection): (WebCore::executeMoveToBeginningOfDocument): (WebCore::executeMoveToBeginningOfDocumentAndModifySelection): (WebCore::executeMoveToBeginningOfLine): (WebCore::executeMoveToBeginningOfLineAndModifySelection): (WebCore::executeMoveToBeginningOfParagraph): (WebCore::executeMoveToBeginningOfParagraphAndModifySelection): (WebCore::executeMoveToBeginningOfSentence): (WebCore::executeMoveToBeginningOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfDocument): (WebCore::executeMoveToEndOfDocumentAndModifySelection): (WebCore::executeMoveToEndOfSentence): (WebCore::executeMoveToEndOfSentenceAndModifySelection): (WebCore::executeMoveToEndOfLine): (WebCore::executeMoveToEndOfLineAndModifySelection): (WebCore::executeMoveToEndOfParagraph): (WebCore::executeMoveToEndOfParagraphAndModifySelection): (WebCore::executeMoveParagraphBackwardAndModifySelection): (WebCore::executeMoveParagraphForwardAndModifySelection): (WebCore::executeMoveUp): (WebCore::executeMoveUpAndModifySelection): (WebCore::executeMoveWordBackward): (WebCore::executeMoveWordBackwardAndModifySelection): (WebCore::executeMoveWordForward): (WebCore::executeMoveWordForwardAndModifySelection): (WebCore::executeMoveWordLeft): (WebCore::executeMoveWordLeftAndModifySelection): (WebCore::executeMoveWordRight): (WebCore::executeMoveWordRightAndModifySelection): (WebCore::executeMoveToLeftEndOfLine): (WebCore::executeMoveToLeftEndOfLineAndModifySelection): (WebCore::executeMoveToRightEndOfLine): (WebCore::executeMoveToRightEndOfLineAndModifySelection):
  • editing/FrameSelection.cpp: Copied from Source/WebCore/editing/SelectionController.cpp. (WebCore::FrameSelection::FrameSelection): (WebCore::FrameSelection::moveTo): (WebCore::FrameSelection::setSelection): (WebCore::FrameSelection::nodeWillBeRemoved): (WebCore::FrameSelection::respondToNodeModification): (WebCore::FrameSelection::textWillBeReplaced): (WebCore::FrameSelection::setIsDirectional): (WebCore::FrameSelection::directionOfEnclosingBlock): (WebCore::FrameSelection::willBeModified): (WebCore::FrameSelection::positionForPlatform): (WebCore::FrameSelection::startForPlatform): (WebCore::FrameSelection::endForPlatform): (WebCore::FrameSelection::modifyExtendingRight): (WebCore::FrameSelection::modifyExtendingForward): (WebCore::FrameSelection::modifyMovingRight): (WebCore::FrameSelection::modifyMovingForward): (WebCore::FrameSelection::modifyExtendingLeft): (WebCore::FrameSelection::modifyExtendingBackward): (WebCore::FrameSelection::modifyMovingLeft): (WebCore::FrameSelection::modifyMovingBackward): (WebCore::FrameSelection::modify): (WebCore::FrameSelection::xPosForVerticalArrowNavigation): (WebCore::FrameSelection::clear): (WebCore::FrameSelection::setStart): (WebCore::FrameSelection::setEnd): (WebCore::FrameSelection::setBase): (WebCore::FrameSelection::setExtent): (WebCore::FrameSelection::setCaretRectNeedsUpdate): (WebCore::FrameSelection::updateCaretRect): (WebCore::FrameSelection::caretRenderer): (WebCore::FrameSelection::localCaretRect): (WebCore::FrameSelection::absoluteBoundsForLocalRect): (WebCore::FrameSelection::absoluteCaretBounds): (WebCore::FrameSelection::caretRepaintRect): (WebCore::FrameSelection::recomputeCaretRect): (WebCore::FrameSelection::shouldRepaintCaret): (WebCore::FrameSelection::invalidateCaretRect): (WebCore::FrameSelection::paintCaret): (WebCore::FrameSelection::debugRenderer): (WebCore::FrameSelection::contains): (WebCore::FrameSelection::selectFrameElementInParentIfFullySelected): (WebCore::FrameSelection::selectAll): (WebCore::FrameSelection::setSelectedRange): (WebCore::FrameSelection::isInPasswordField): (WebCore::FrameSelection::caretRendersInsideNode): (WebCore::FrameSelection::focusedOrActiveStateChanged): (WebCore::FrameSelection::pageActivationChanged): (WebCore::FrameSelection::updateSecureKeyboardEntryIfActive): (WebCore::FrameSelection::setUseSecureKeyboardEntry): (WebCore::FrameSelection::setFocused): (WebCore::FrameSelection::isFocusedAndActive): (WebCore::FrameSelection::updateAppearance): (WebCore::FrameSelection::setCaretVisible): (WebCore::FrameSelection::clearCaretRectIfNeeded): (WebCore::FrameSelection::caretBlinkTimerFired): (WebCore::FrameSelection::notifyRendererOfSelectionChange): (WebCore::FrameSelection::setFocusedNodeIfNeeded): (WebCore::FrameSelection::paintDragCaret): (WebCore::FrameSelection::copyTypingStyle): (WebCore::FrameSelection::shouldDeleteSelection): (WebCore::FrameSelection::bounds): (WebCore::FrameSelection::getClippedVisibleTextRectangles): (WebCore::FrameSelection::currentForm): (WebCore::FrameSelection::revealSelection): (WebCore::FrameSelection::setSelectionFromNone): (WebCore::FrameSelection::shouldChangeSelection): (WebCore::FrameSelection::formatForDebugger): (WebCore::FrameSelection::showTreeForThis): (showTree):
  • editing/FrameSelection.h: Copied from Source/WebCore/editing/SelectionController.h. (WebCore::FrameSelection::typingStyle): (WebCore::FrameSelection::clearTypingStyle): (WebCore::FrameSelection::setTypingStyle): (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/ModifySelectionListLevel.cpp:
  • editing/RemoveFormatCommand.cpp:
  • editing/ReplaceSelectionCommand.cpp:
  • editing/SelectionController.cpp: Removed.
  • editing/SelectionController.h: Removed.
  • editing/SetSelectionCommand.cpp: (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply):
  • editing/SetSelectionCommand.h: (WebCore::SetSelectionCommand::create):
  • editing/SpellingCorrectionCommand.cpp: (WebCore::SpellingCorrectionCommand::doApply):
  • editing/SpellingCorrectionController.cpp: (WebCore::SpellingCorrectionController::respondToUnappliedSpellCorrection):
  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
  • editing/chromium/FrameSelectionChromium.cpp: Copied from Source/WebCore/editing/chromium/SelectionControllerChromium.cpp. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/chromium/SelectionControllerChromium.cpp: Removed.
  • editing/gtk/FrameSelectionGtk.cpp: Copied from Source/WebCore/editing/gtk/SelectionControllerGtk.cpp. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/gtk/SelectionControllerGtk.cpp: Removed.
  • editing/mac/EditorMac.mm: (WebCore::Editor::canCopyExcludingStandaloneImages):
  • editing/mac/FrameSelectionMac.mm: Copied from Source/WebCore/editing/mac/SelectionControllerMac.mm. (WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
  • editing/mac/SelectionControllerMac.mm: Removed.
  • editing/qt/EditorQt.cpp:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::populate):
  • page/DOMSelection.cpp: (WebCore::DOMSelection::type): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::deleteFromDocument): (WebCore::DOMSelection::containsNode):
  • page/DragController.cpp: (WebCore::DragController::dragIsMove):
  • page/DragController.h:
  • page/EventHandler.cpp: (WebCore::setSelectionIfNeeded): (WebCore::setNonDirectionalSelectionIfNeeded): (WebCore::EventHandler::sendContextMenuEventForKey): (WebCore::EventHandler::handleKeyboardSelectionMovement):
  • page/EventHandler.h:
  • page/FocusController.cpp: (WebCore::clearSelectionIfNeeded):
  • page/Frame.cpp: (WebCore::Frame::Frame):
  • page/Frame.h: (WebCore::Frame::selection):
  • page/Page.cpp: (WebCore::Page::Page):
  • page/Page.h: (WebCore::Page::dragCaretController):
  • page/chromium/DragControllerChromium.cpp:
  • page/chromium/EventHandlerChromium.cpp:
  • page/win/DragControllerWin.cpp:
  • page/win/EventHandlerWin.cpp:
  • rendering/HitTestResult.cpp:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::destroy): (WebCore::RenderBlock::paintCaret):
  • rendering/RenderImage.cpp:
  • rendering/RenderInline.cpp: (WebCore::RenderInline::destroy):
  • rendering/RenderLayer.cpp:
  • rendering/RenderListBox.cpp:
  • rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::removeChildNode):
  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderTreeAsText.cpp:
  • svg/SVGSVGElement.cpp:
  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::selectSubString):
11:01 AM Changeset in webkit [85863] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WinCairo] Unreviewed build fix.

  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::cachedResponseDataForURL): Stub out
implementation for cURL networking case.

10:54 AM Changeset in webkit [85862] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] unreviewed build correction.

  • platform/network/curl/ResourceRequest.h:

Stub out the new pipelined http logic for cURL.

10:49 AM Changeset in webkit [85861] by Joseph Pecoraro
  • 2 edits in trunk/Tools

2011-05-05 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Add --only-webkit option to build-webkit
https://bugs.webkit.org/show_bug.cgi?id=60245

  • Scripts/build-webkit: If --only-webkit was specified just build the WebKit project, and not its dependencies.
9:57 AM Changeset in webkit [85860] by jeffm@apple.com
  • 15 edits in trunk

2011-05-05 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add didNotHandleWheelEvent callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=60203

  • MiniBrowser/gtk/BrowserWindow.c: (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
  • MiniBrowser/mac/BrowserWindowController.m: (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
  • MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Stub out didNotHandleWheelEvent callback.
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback. (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.

2011-05-05 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add didNotHandleWheelEvent callback to WKPageUIClient
https://bugs.webkit.org/show_bug.cgi?id=60203


Remove Windows-specific WebPageProxy::wheelEventNotHandled() member function and use
didNotHandleWheelEvent callback in WKPageUIClient instead. It turns out that just
resending the wheel event to the parent window doesn't provide the client with enough context
to know that WebKit has already attempted to handle the event.

  • UIProcess/API/C/WKPage.h: Added WKPageDidNotHandleWheelEventCallback typedef and didNotHandleWheelEvent to WKPageUIClient.
  • UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::didNotHandleWheelEvent): Added, but not implemented.
  • UIProcess/API/gtk/PageClientImpl.h: Added didNotHandleWheelEvent().
  • UIProcess/API/qt/qwkpage.cpp: (QWKPage::QWKPage):Stubbed out didNotHandleWheelEvent callback.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveEvent): Call didNotHandleWheelEvent in WKPageUIClient if wheel event is not handled.
  • UIProcess/WebPageProxy.h: Removed wheelEventNotHandled().


  • UIProcess/WebUIClient.cpp: (WebKit::WebUIClient::implementsDidNotHandleWheelEvent): Added. (WebKit::WebUIClient::didNotHandleWheelEvent): Added.
  • UIProcess/WebUIClient.h: Added implementsDidNotHandleWheelEvent() and didNotHandleWheelEvent().
  • UIProcess/win/WebPageProxyWin.cpp: Removed wheelEventNotHandled().
9:40 AM Changeset in webkit [85859] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Return correct GTK version for NPNVToolkit
https://bugs.webkit.org/show_bug.cgi?id=60275

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_GetValue): Return always 2 for NPNVToolkit in GTK platform.
9:38 AM Changeset in webkit [85858] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: searching for node does not result in bringToFront call.
https://bugs.webkit.org/show_bug.cgi?id=60222

  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.updateFocusedNode):
9:07 AM Changeset in webkit [85857] by abarth@webkit.org
  • 2 edits in trunk

2011-05-05 Adam Barth <abarth@webkit.org>

Remove a couple stray mentions of WML that I missed before.

  • configure.ac:
9:01 AM Changeset in webkit [85856] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Make native events code more consistent
https://bugs.webkit.org/show_bug.cgi?id=60258

Make all other native events code follow the current keyboard
events approach: use a GOwnPtr for the native event, and use
const GdkEvent* in the API. We need to implement the copy
constructors for native events to copy the gdk events with
gdk_event_copy().

  • Shared/NativeWebMouseEvent.h: (WebKit::NativeWebMouseEvent::nativeEvent):
  • Shared/NativeWebWheelEvent.h: (WebKit::NativeWebWheelEvent::nativeEvent):
  • Shared/gtk/NativeWebKeyboardEventGtk.cpp: (WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent):
  • Shared/gtk/NativeWebMouseEventGtk.cpp: (WebKit::NativeWebMouseEvent::NativeWebMouseEvent):
  • Shared/gtk/NativeWebWheelEventGtk.cpp: (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
  • Shared/gtk/WebEventFactory.cpp: (WebKit::buttonForEvent): (WebKit::WebEventFactory::createWebMouseEvent): (WebKit::WebEventFactory::createWebWheelEvent): (WebKit::WebEventFactory::createWebKeyboardEvent):
  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseScrollEvent):
8:44 AM Changeset in webkit [85855] by alexis.menard@openbossa.org
  • 4 edits in trunk

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Make QtWebKit build when using gcc 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60265

If QtWebKit is compiled with gcc 4.6.0 and the build is not done
with c++0x support we need to deactivate warnings about compatibility.
Some WebKit types have names which conflicts with upcoming c++0x
types. If QtWebKit is built with c++0x support, WebKit has code to
fallback to the standard type rather than the WebKit implementation.
For example nullptr will be the one of the std if build options turns on
c++0x support.

  • Source/WebKit.pri:

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Make QtWebKit build when using gcc 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60265

If QtWebKit is compiled with gcc 4.6.0 or later we don't want to deactivate
the c++0x support because it works.

8:40 AM Changeset in webkit [85854] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Martin Robinson.

[GTK] Module::load() should return true when g_module_open() returns a valid pointer
https://bugs.webkit.org/show_bug.cgi?id=60261

  • Platform/gtk/ModuleGtk.cpp: (WebKit::Module::load):
8:39 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
8:20 AM Changeset in webkit [85853] by andreas.kling@nokia.com
  • 12 edits in trunk/Source/WebCore

2011-05-05 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Simon Hausmann.

[Qt] Implement the fast font path for Qt.
https://bugs.webkit.org/show_bug.cgi?id=51106

Use the new QRawFont and QGlyphs APIs in Qt 4.8 to implement the fast paths for
rendering and measurement of simple text.

Since this is still unreleased API, it's guarded by HAVE(QRAWFONT) until the new
classes are fully integrated into the Qt 4.8 release branch.

  • WebCore.pro: Add HAVE_QRAWFONT define (for Qt >= 4.8) and new files to build.
  • platform/graphics/Font.cpp: (WebCore::Font::drawText): Disable fast font path for stroked text, and when painting text with a shadow. (Qt-only) (WebCore::Font::codePath): Try to use fast font path in more cases.
  • platform/graphics/qt/FontCacheQt.cpp: (WebCore::rawFontForCharacters): Helper function, returns a suitable QRawFont to use for rendering a given string. Goes through QTextLayout to find the best font based on the original QFont query. (WebCore::FontCache::getFontDataForCharacters): Implemented using helper above.
  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate): (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::rawFont):
  • platform/graphics/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): Add a QRawFont member to FontPlatformData.
  • platform/graphics/qt/FontQt.cpp: (WebCore::fillPenForContext): (WebCore::strokePenForContext): (WebCore::drawTextCommon): Factored QPen creation out of drawTextCommon to share code between complex and simple font rendering paths. (WebCore::Font::drawGlyphs): Implemented using QPainter::drawGlyphs().
  • platform/graphics/qt/GlyphPageTreeNodeQt.cpp: (WebCore::GlyphPage::fill): Implemented using QRawFont::glyphIndexesForString().
  • platform/graphics/qt/SimpleFontDataQt.cpp: (WebCore::SimpleFontData::determinePitch): Return false when using QRawFont since we have no way of knowing the pitch. (WebCore::SimpleFontData::containsCharacters): Implemented using QRawFont::supportsCharacter(). (WebCore::SimpleFontData::platformWidthForGlyph): Implemented using QRawFont::advancesForGlyphIndexes(). (WebCore::SimpleFontData::scaledFontData): Added, based on other ports. (WebCore::SimpleFontData::smallCapsFontData): Ditto. (WebCore::SimpleFontData::emphasisMarkFontData): Ditto. (WebCore::SimpleFontData::platformBoundsForGlyph): Stub. (WebCore::SimpleFontData::platformInit): Use QRawFont APIs to retrieve font metrics. (WebCore::SimpleFontData::platformCharWidthInit): Ditto.
8:11 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
8:11 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
8:09 AM QtWebKitRelease22 edited by Ademar Reis
(diff)
7:15 AM Changeset in webkit [85852] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-05 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skip inspector/console/console-shadow-dom-access.html (crashes in debug)
https://bugs.webkit.org/show_bug.cgi?id=60266

  • platform/mac/Skipped:
7:14 AM Changeset in webkit [85851] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224

We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::addUserStyleSheet):

2011-05-05 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Andreas Kling.

[Qt] RenderThemeQt and DumpRenderTreeSupportQt should use nullptr rather than 0.
https://bugs.webkit.org/show_bug.cgi?id=60224

We should use nullptr rather than 0. nullptr will be added in the new C++ standard
but WebKit already has a nullptr class if there is no c++0x support.

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::adjustProgressBarStyle): (WebCore::RenderThemeQt::adjustSliderTrackStyle): (WebCore::RenderThemeQt::adjustSliderThumbStyle):
6:36 AM QtWebKitRelease22 edited by alexis.menard@openbossa.org
(diff)
6:35 AM QtWebKitPlatformSupport created by alexis.menard@openbossa.org
6:31 AM QtWebKitRelease22 edited by alexis.menard@openbossa.org
(diff)
6:20 AM Changeset in webkit [85850] by loislo@chromium.org
  • 14 edits
    2 moves in trunk/Source/WebCore

2011-05-05 Ilya Tikhonovsky <loislo@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger to DOMDebugger.

https://bugs.webkit.org/show_bug.cgi?id=60256
InspectorBrowserDebuggerAgent => InspectorDOMDebuggerAgent
browserDebugger => domDebugger

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/CodeGeneratorInspector.pm:
  • inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::InspectorAgent): (WebCore::InspectorAgent::inspectedPageDestroyed): (WebCore::InspectorAgent::disconnectFrontend):
  • inspector/InspectorAgent.h: (WebCore::InspectorAgent::DOMDebuggerAgent):
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/InspectorDOMDebuggerAgent.cpp: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp. (WebCore::InspectorDOMDebuggerAgent::create): (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent): (WebCore::InspectorDOMDebuggerAgent::~InspectorDOMDebuggerAgent): (WebCore::InspectorDOMDebuggerAgent::debuggerWasEnabled): (WebCore::InspectorDOMDebuggerAgent::debuggerWasDisabled): (WebCore::InspectorDOMDebuggerAgent::disable): (WebCore::InspectorDOMDebuggerAgent::clearFrontend): (WebCore::InspectorDOMDebuggerAgent::discardBindings): (WebCore::InspectorDOMDebuggerAgent::setEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeEventListenerBreakpoint): (WebCore::InspectorDOMDebuggerAgent::didInsertDOMNode): (WebCore::InspectorDOMDebuggerAgent::didRemoveDOMNode): (WebCore::InspectorDOMDebuggerAgent::setDOMBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeDOMBreakpoint): (WebCore::InspectorDOMDebuggerAgent::willInsertDOMNode): (WebCore::InspectorDOMDebuggerAgent::willRemoveDOMNode): (WebCore::InspectorDOMDebuggerAgent::willModifyDOMAttr): (WebCore::InspectorDOMDebuggerAgent::descriptionForDOMEvent): (WebCore::InspectorDOMDebuggerAgent::hasBreakpoint): (WebCore::InspectorDOMDebuggerAgent::updateSubtreeBreakpoints): (WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded): (WebCore::InspectorDOMDebuggerAgent::setXHRBreakpoint): (WebCore::InspectorDOMDebuggerAgent::removeXHRBreakpoint): (WebCore::InspectorDOMDebuggerAgent::willSendXMLHttpRequest): (WebCore::InspectorDOMDebuggerAgent::clear):
  • inspector/InspectorDOMDebuggerAgent.h: Renamed from Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h.
  • inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl): (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl): (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl): (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl): (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
  • inspector/InstrumentingAgents.h: (WebCore::InstrumentingAgents::InstrumentingAgents): (WebCore::InstrumentingAgents::inspectorDOMDebuggerAgent): (WebCore::InstrumentingAgents::setInspectorDOMDebuggerAgent):
  • inspector/WorkerInspectorController.cpp: (WebCore::WorkerInspectorController::connectFrontend):
6:06 AM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
6:05 AM QtWebKitCheckList edited by alexis.menard@openbossa.org
(diff)
5:14 AM Changeset in webkit [85849] by caseq@chromium.org
  • 2 edits
    2 adds in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: add test for shadow DOM access in the console API
https://bugs.webkit.org/show_bug.cgi?id=60192

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.findNode.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId): (initialize_ElementTest.InspectorTest.selectNode):
  • inspector/console/console-shadow-dom-access-expected.txt: Added.
  • inspector/console/console-shadow-dom-access.html: Added.
3:58 AM Changeset in webkit [85848] by Philippe Normand
  • 1 edit
    14 adds in trunk/LayoutTests

2011-05-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/editing/inserting/typing-at-end-of-line-expected.png: Added.
  • platform/gtk/editing/inserting/typing-at-end-of-line-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/gtk/fast/forms/input-placeholder-text-indent-expected.txt: Added.
3:41 AM Changeset in webkit [85847] by yurys@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: show only Console and Scripts panels in worker inspector front-end
https://bugs.webkit.org/show_bug.cgi?id=60159

  • inspector/front-end/WorkerManager.js: (WebInspector.WorkerManager.isWorkerFrontend):
  • inspector/front-end/inspector.js: show only Scripts and Console panels in the worker inspector front-end.
2:17 AM Changeset in webkit [85846] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed, marking flaky tests.

  • platform/chromium/test_expectations.txt:
1:44 AM Changeset in webkit [85845] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed, rolling out r85817.
http://trac.webkit.org/changeset/85817

It looks these lines are mis-skipped.

  • platform/chromium/test_expectations.txt:
1:36 AM Changeset in webkit [85844] by hans@chromium.org
  • 4 edits
    1 add in trunk/Source

2011-05-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Unit tests for LevelDB key coding functions
https://bugs.webkit.org/show_bug.cgi?id=59692

Fix some embarrassing bugs uncovered by unit tests.

No new functionality, but this is now covered by unit tests in the Chromium WebKit port.

  • storage/IDBLevelDBCoding.cpp: (WebCore::IDBLevelDBCoding::decodeInt): (WebCore::IDBLevelDBCoding::decodeVarInt):

2011-05-03 Hans Wennborg <hans@chromium.org>

Reviewed by Steve Block.

IndexedDB: Unit tests for LevelDB key coding functions
https://bugs.webkit.org/show_bug.cgi?id=59692

Add unit tests for the basic key coding functions used by the LevelDB back-end.

  • WebKit.gypi:
  • tests/IDBLevelDBCodingTest.cpp: Added. (IDBLevelDBCoding::TEST):
1:25 AM Changeset in webkit [85843] by Philippe Normand
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-05 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new fullscreen test.

  • platform/gtk/fullscreen/full-screen-stacking-context-expected.png: Added.
  • platform/gtk/fullscreen/full-screen-stacking-context-expected.txt: Added.
1:12 AM Changeset in webkit [85842] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed, fixed a syntax error on expectations file.

  • platform/chromium/test_expectations.txt:
12:57 AM Changeset in webkit [85841] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

2011-05-05 Carlos Garcia Campos <cgarcia@igalia.com>

Unreviewed. Fix WebKit2 GTK build after r85808.

  • Shared/NativeWebWheelEvent.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseScrollEvent):
12:25 AM Changeset in webkit [85840] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-05 MORITA Hajime <morrita@google.com>

Unreviewed expectations update for MAC GPU flakiness.

  • video-zoom-controls.html: Added IMAGE
  • media/controls-without-preload.html, media/controls-styling.html, media/controls-strict.html, media/controls-after-reload.html Added TEXT
  • platform/chromium/test_expectations.txt:
12:00 AM Changeset in webkit [85839] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-05 Young Han Lee <joybro@company100.net>

Reviewed by Csaba Osztrogonác.

[Texmap][Qt] Enable strict OwnPtr for Qt with texmap enabled.
https://bugs.webkit.org/show_bug.cgi?id=60251

No new tests. Build fix.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::GraphicsLayerTextureMapper):

May 4, 2011:

11:48 PM Changeset in webkit [85838] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed expectations update.

  • platform/chromium/test_expectations.txt:
11:41 PM Changeset in webkit [85837] by jcivelli@chromium.org
  • 7 edits
    2 adds in trunk/Source/WebCore

2011-05-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by Adam Barth.

Adding a utility class to read a SharedBuffer line by line.
https://bugs.webkit.org/show_bug.cgi?id=59946

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SharedBufferCRLFLineReader.cpp: Added.
  • platform/SharedBufferCRLFLineReader.h: Added.
11:32 PM Changeset in webkit [85836] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

r85835 skipped too much. narrowed skipped target.

  • platform/chromium/test_expectations.txt:
11:29 PM Changeset in webkit [85835] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed marking failing gpu tests:

  • controls-without-preload.html, controls-after-reload.html, controls-strict.html, controls-styling.html
  • platform/chromium/test_expectations.txt:
10:57 PM Changeset in webkit [85834] by commit-queue@webkit.org
  • 3 edits
    8 deletes in trunk

2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85788.
http://trac.webkit.org/changeset/85788
https://bugs.webkit.org/show_bug.cgi?id=60250

svg/text/text-block-child-crash.xhtml asserts (Requested by
Ossy on #webkit).

  • svg/custom/display-table-caption-foreignObject-expected.txt: Removed.
  • svg/custom/display-table-caption-foreignObject.svg: Removed.
  • svg/custom/display-table-caption-inherit-foreignObject-expected.txt: Removed.
  • svg/custom/display-table-caption-inherit-foreignObject.xhtml: Removed.
  • svg/custom/display-table-caption-inherit-text-expected.txt: Removed.
  • svg/custom/display-table-caption-inherit-text.xhtml: Removed.
  • svg/custom/display-table-caption-text-expected.txt: Removed.
  • svg/custom/display-table-caption-text.svg: Removed.

2011-05-04 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85788.
http://trac.webkit.org/changeset/85788
https://bugs.webkit.org/show_bug.cgi?id=60250

svg/text/text-block-child-crash.xhtml asserts (Requested by
Ossy on #webkit).

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
10:43 PM Changeset in webkit [85833] by morrita@google.com
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed unit test skip (startPostAndWaitOnCondition)
which fails on Windows 7. See bug 60248 for tracking.

  • tests/CCThreadTest.cpp: (WebCore::TEST):
10:04 PM Changeset in webkit [85832] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebKit/gtk

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

GTK build fix attempt after r85823

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::webView):
  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted): (WebKit::imContextPreeditChanged):
  • webkit/webkitwebview.cpp: (WebKit::kit):
9:54 PM Changeset in webkit [85831] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebKit/win

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Windows build fix attempt after r85823

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
  • WebView.cpp: (kit):
9:43 PM Changeset in webkit [85830] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Marking at r85822 was not enough. Re-marked it.

  • platform/chromium/test_expectations.txt:
9:35 PM Changeset in webkit [85829] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed flaky marking to full-screen-stacking-context.html.

  • platform/chromium/test_expectations.txt:
9:22 PM Changeset in webkit [85828] by kerz@chromium.org
  • 1 edit in branches/chromium/742/LayoutTests/platform/chromium/test_expectations.txt

getting chromium continuous branch builder tests working again

8:55 PM Changeset in webkit [85827] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Add more missing imports from scm refactor
https://bugs.webkit.org/show_bug.cgi?id=60239

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
8:07 PM Changeset in webkit [85826] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Make more member functions in EventHandler private
https://bugs.webkit.org/show_bug.cgi?id=60200

Reduced the number of public member functions in EventHandler.

  • WebCore.exp.in:
  • page/EventHandler.cpp: (WebCore::EventHandler::handleAutoscroll): (WebCore::EventHandler::autoscrollTimerFired): (WebCore::EventHandler::stopAutoscrollTimer): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult):
  • page/EventHandler.h: (WebCore::EventHandler::mouseDownMayStartSelect):
8:03 PM Changeset in webkit [85825] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

2011-05-04 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202

Adds a regression test for composited content changing from transform-style: preserve-3d to flat.

  • compositing/repaint/transform-style-change-expected.png: Added.
  • compositing/repaint/transform-style-change-expected.txt: Added.
  • compositing/repaint/transform-style-change.html: Added.

2011-05-04 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] REGRESSION(85136): Composited content vanishes when transform-style changes from preserve-3d to flat
https://bugs.webkit.org/show_bug.cgi?id=60202

In r85136 I accidentally transposed two lines in GraphicsLayerChromium when adding a null check. This switches
the order back and adds a regression test.

Test: compositing/repaint/transform-style-change.html

  • platform/graphics/chromium/GraphicsLayerChromium.cpp: (WebCore::GraphicsLayerChromium::updateLayerPreserves3D):
7:42 PM Changeset in webkit [85824] by morrita@google.com
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed expectations update.

  • platform/chromium-linux/fullscreen/full-screen-stacking-context-expected.txt: Added.
  • platform/chromium-win/fullscreen/full-screen-stacking-context-expected.txt: Added.
7:36 PM Changeset in webkit [85823] by cdn@chromium.org
  • 32 edits
    2 adds in trunk

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Tests whether a style media specifier inside an svg image will crash.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • fast/media/media-svg-crash-expected.txt: Added.
  • fast/media/media-svg-crash.html: Added.

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

Test: fast/media/media-svg-crash.html

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::webView):
  • page/ChromeClient.h:
  • page/brew/ChromeClientBrew.h: (WebCore::ChromeClientBrew::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • src/AutoFillPopupMenuClient.cpp: (WebKit::AutoFillPopupMenuClient::getWebView):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::webView):
  • src/ChromeClientImpl.h:
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3DInternal::initialize):
  • src/PlatformBridge.cpp: (WebCore::toWebWidgetClient):
  • src/StorageNamespaceProxy.cpp: (WebCore::StorageNamespace::sessionStorageNamespace):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::fromPage):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientEfl.h: (WebCore::ChromeClientEfl::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientGtk.h: (WebKit::ChromeClient::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientHaiku.h: (WebCore::ChromeClientHaiku::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):
  • WebView/WebFrame.mm: (kit):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientQt.h: (WebCore::ChromeClientQt::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/WebChromeClient.h: (WebChromeClient::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebCoreSupport/ChromeClientWinCE.h: (WebKit::ChromeClientWinCE::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebKitSupport/ChromeClientWx.h: (WebCore::ChromeClientWx::webView):

2011-05-04 Cris Neckar <cdn@chromium.org>

Reviewed by Adam Barth.

Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902

  • WebProcess/WebCoreSupport/WebChromeClient.h: (WebKit::WebChromeClient::webView):
7:32 PM Changeset in webkit [85822] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed skipping text-block-child-crash.xhtml

  • platform/chromium/test_expectations.txt:
7:24 PM Changeset in webkit [85821] by eric@webkit.org
  • 4 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot is having more exception trouble
https://bugs.webkit.org/show_bug.cgi?id=60233

A webpage-forced build was causing SB to throw an exception.
We've long had this bug, but we just didn't notice it until now.

In debugging this I found we fetch an absurd amount of data now
that we use buildbot's json (instead of xmlrpc), so I added
the filter=1 parameter to reduce it a little. That required
me to handle the case where filter=1 would strip
result=0 in some cases (it's unclear why it does that).

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
7:08 PM Changeset in webkit [85820] by ojan@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Commit failing result. It's not clear to me why this test is failing.
There's nothing platform specific about it, it doesn't depend on the
system environment and it's not failing on the chromium win7 bot.

Committing this for now to green the tree.

  • platform/win-7sp0/fast/harness/results-expected.txt: Added.
7:07 PM Changeset in webkit [85819] by xan@webkit.org
  • 2 edits in trunk

2011-05-04 Xan Lopez <xlopez@igalia.com>

Reviewed by Martin Robinson.

[GTK] Fix warnings in webkit.m4 with autoconf 2.68
https://bugs.webkit.org/show_bug.cgi?id=60189

Use AC_LANG_SOURCE when passing source code to AC_COMPILE_IFELSE
to remove warnings.

  • Source/autotools/webkit.m4: ditto.
6:16 PM Changeset in webkit [85818] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

2011-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219

  • editing/pasteboard/paste-placeholder-input-expected.txt: Added.
  • editing/pasteboard/paste-placeholder-input.html: Added.

2011-05-04 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by Darin Adler.

Unable to Paste After Deleting Text from Input due to -webkit-user-select
https://bugs.webkit.org/show_bug.cgi?id=60219

When deleting all the text inside the input a placeholder <br>
element was inserted for the selection point. However, when
pasting, the test run computes the -webkit-user-select for the
<br> element, instead of what would be the text inside the
<input> and incorrectly disallows selection and prevented
the paste.

Test: editing/pasteboard/paste-placeholder-input.html

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::insertFragmentForTestRendering): skip <br> elements above us as those are likely placeholder elements.
5:49 PM Changeset in webkit [85817] by morrita@google.com
  • 2 edits in trunk/LayoutTests

2011-05-04 MORITA Hajime <morrita@google.com>

Unreviewed marking flaky tests.

  • platform/chromium/test_expectations.txt:
5:43 PM Changeset in webkit [85816] by cdn@chromium.org
  • 2 edits in trunk/Tools

2011-05-04 Cris Neckar <cdn@chromium.org>

Unreviewed, Adding Cris Neckar as a committer

  • Scripts/webkitpy/common/config/committers.py:
5:43 PM Changeset in webkit [85815] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Windows build of WebKit GTK needs to be able to find SystemInfo.h
https://bugs.webkit.org/show_bug.cgi?id=60221

  • GNUmakefile.am: add Source/WebCore/platform/win to the paths searched for headers, since Source/WebCore/platform/win/SystemInfo.h header is needed by Source/WebKit/gtk/webkit/webkitwebsettings.cpp on Windows.
5:42 PM Changeset in webkit [85814] by vangelis@chromium.org
  • 7 edits
    5 adds in trunk

2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Adding a new layout test for perpendicular layers.
https://bugs.webkit.org/show_bug.cgi?id=59255

  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.png: Added.
  • platform/chromium-gpu-mac/platform/chromium/compositing/perpendicular-layer-sorting-expected.txt: Added.
  • platform/chromium/compositing/perpendicular-layer-sorting.html: Added.
  • platform/chromium/test_expectations.txt:

2011-05-04 Vangelis Kokkevis <vangelis@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Improve sorting of layers in hierarchies that preserve-3d
by testing for overlapping regions between layer pairs and doing a
topological sort to determine the right order.
https://bugs.webkit.org/show_bug.cgi?id=59255

Test: platform/chromium/compositing/perpendicular-layer-sorting.html

  • WebCore.gypi:
  • platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
  • platform/graphics/chromium/LayerRendererChromium.h:
  • platform/graphics/chromium/cc/CCLayerImpl.h: (WebCore::CCLayerImpl::clearRenderSurface):
  • platform/graphics/chromium/cc/CCLayerSorter.cpp: Added. (WebCore::perpProduct): (WebCore::innerProduct): (WebCore::pointInColinearEdge): (WebCore::edgeEdgeTest): (WebCore::CCLayerSorter::LayerIntersector::LayerIntersector): (WebCore::CCLayerSorter::LayerIntersector::go): (WebCore::CCLayerSorter::LayerIntersector::edgeTriangleTest): (WebCore::CCLayerSorter::LayerIntersector::triangleTriangleTest): (WebCore::CCLayerSorter::LayerIntersector::checkZDiff): (WebCore::CCLayerSorter::LayerIntersector::layerZFromProjectedPoint): (WebCore::CCLayerSorter::CCLayerSorter): (WebCore::CCLayerSorter::checkOverlap): (WebCore::CCLayerSorter::createGraphNodes): (WebCore::CCLayerSorter::createGraphEdges): (WebCore::CCLayerSorter::removeEdgeFromList): (WebCore::CCLayerSorter::sort):
  • platform/graphics/chromium/cc/CCLayerSorter.h: Added. (WebCore::CCLayerSorter::GraphNode::GraphNode): (WebCore::CCLayerSorter::GraphEdge::GraphEdge):
5:23 PM Changeset in webkit [85813] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Geoffrey Garen.

Port MachineStackMarker.cpp to Windows x64
https://bugs.webkit.org/show_bug.cgi?id=60216

  • heap/MachineStackMarker.cpp: (JSC::getPlatformThreadRegisters): the CONTEXT struct is usable also on 64-bit Windows. (JSC::otherThreadStackPointer): return the Rsp register on Windows x64.
5:09 PM Changeset in webkit [85812] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Martin Robinson.

Link libjavascriptcoregtk on Windows with winmm.dll
https://bugs.webkit.org/show_bug.cgi?id=60215

  • GNUmakefile.am:
5:07 PM Changeset in webkit [85811] by jer.noble@apple.com
  • 9 edits
    3 adds in trunk

2011-05-03 Jer Noble <jer.noble@apple.com>

Reviewed by Antti Koivisto.

Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140

  • fullscreen/full-screen-stacking-context-expected.txt: Added.
  • fullscreen/full-screen-stacking-context.html: Added.
  • platform/mac/fullscreen/full-screen-stacking-context-expected.png: Added.

2011-05-03 Jer Noble <jer.noble@apple.com>

Reviewed by Antti Koivisto.

Safari: Video at apple.com cannot play at full screen mode with layout distortion
https://bugs.webkit.org/show_bug.cgi?id=60140

Because a fullscreen element may be in a stacking context with a lower z-index than
a sibling stacking context, those higher contexts would sometimes "pop" through the
full screen renderer. To facilitate eliminating all the stacking contexts aside from
the full screen renderer, added a new pseudo-class specific to video or audio full
screen elements. Then, added a new UA rule which resets the z-index and opacities of
all elements under said pseudo-class to auto and 1 respectively. To facilitate quick
identity checking of HTMLMediaElements, added isMediaElement() virtual function to
Element and HTMLMediaElement.

Test: fullscreen/full-screen-stacking-context.html

  • css/CSSSelector.cpp: (WebCore::CSSSelector::pseudoId): Support PseudoFullScreenMediaDocument. (WebCore::nameToPseudoTypeMap): Support fullScreenMediaDocument. (WebCore::CSSSelector::extractPseudoType): Support PseudoFullScreenMediaDocument.
  • css/CSSSelector.h: Add PseudoFullScreenMediaDocument.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Support PseudoFullScreenMediaDocument.
  • css/fullscreen.css: (:root:-webkit-full-screen-document:not(:-webkit-full-screen)): Corrected these names,

which were missing the -webkit prefix.

(:root:-webkit-full-screen-media-document *:not(-webkit-full-screen)): Added.

  • dom/Element.h: (WebCore::Element::isMediaElement): Added, returns false.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::isMediaElement): Added, returns true.
  • rendering/style/RenderStyleConstants.h: Added FULL_SCREEN_MEDIA_DOCUMENT.
5:01 PM Changeset in webkit [85810] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Split findNextLineBreak into a LineBreaker class
https://bugs.webkit.org/show_bug.cgi?id=60209

Breaking findNextLineBreak into a new class inside RenderBlock. Currently it's tracking
nearly no state, but subsequent patches will move some of the local variables used throughout
the nextLineBreak function into member variables to simplify breaking off helper functions from
the bloated function.

No new tests since this is just moving code around.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.h: (WebCore::RenderBlock::LineBreaker::LineBreaker): (WebCore::RenderBlock::LineBreaker::lineWasHyphenated): Accessor. (WebCore::RenderBlock::LineBreaker::positionedObjects): Ditto. (WebCore::RenderBlock::LineBreaker::clear): Ditto.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::LineBreaker::skipTrailingWhitespace): (WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace): (WebCore::RenderBlock::LineBreaker::reset): (WebCore::RenderBlock::LineBreaker::nextLineBreak):
4:56 PM Changeset in webkit [85809] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] Hide the entire table if all failures are expected
https://bugs.webkit.org/show_bug.cgi?id=60225

If in a port that uses expected results and all failures are expected,
hide the table as well as the rows when hiding expected failures.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
4:49 PM Changeset in webkit [85808] by jeffm@apple.com
  • 7 edits in trunk/Source/WebKit2

2011-05-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Send unhandled wheel events to parent window on Windows
https://bugs.webkit.org/show_bug.cgi?id=60220

Keep track of wheel events using NativeWebWheelEvent instead of WebWheelEvent in WebPageProxy
so we can send the native event to the parent window if WebKit doesn't handle it.

  • UIProcess/API/mac/WKView.mm: Use NativeWebWheelEvent instead of WebWheelEvent.
  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::wheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::WebPageProxy): Removed initialization of obsolete m_processingWheelEvent member variable. (WebKit::coalesceWheelEvents): Use NativeWebWheelEvent instead of WebWheelEvent and add a note that this won't work if we ever enable MERGE_WHEEL_EVENTS. (WebKit::WebPageProxy::handleWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent, keep track of the current event in m_currentlyProcessedWheelEvent. (WebKit::WebPageProxy::didReceiveEvent): Call wheelEventNotHandled() on Windows if wheel event is not handled. (WebKit::WebPageProxy::processDidCrash): Clear out m_currentlyProcessedWheelEvent.
  • UIProcess/WebPageProxy.h: Change handleWheelEvent() to take a NativeWebWheelEvent, added wheelEventNotHandled() on Windows, remove m_processingWheelEvent, add m_currentlyProcessedWheelEvent.
  • UIProcess/win/WebPageProxyWin.cpp: (WebKit::WebPageProxy::wheelEventNotHandled): Added.


  • UIProcess/win/WebView.cpp: (WebKit::WebView::onWheelEvent): Use NativeWebWheelEvent instead of WebWheelEvent.
4:46 PM Changeset in webkit [85807] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: odd result order
https://bugs.webkit.org/show_bug.cgi?id=60193

This test uses setTimeout to check that the result property of
asynchronous requests persists into the setTimeout callback.

  • storage/indexeddb/mozilla/odd-result-order-expected.txt: Added.
  • storage/indexeddb/mozilla/odd-result-order.html: Added.
4:42 PM Changeset in webkit [85806] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Darin Adler.

Add bundle API for making a page paint as the background of another page
https://bugs.webkit.org/show_bug.cgi?id=60227

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetUnderlayPage): Call WebPage::setUnderlayPage.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::close): Null out the underlay page.

(WebKit::WebPage::layoutIfNeeded):
Layout the underlay page if necessary.

(WebKit::WebPage::drawRect):
Draw the underlay page.

4:36 PM Changeset in webkit [85805] by hclam@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-04 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations.

  • platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium/test_expectations.txt:
4:34 PM Changeset in webkit [85804] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

2011-05-04 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Added error check for _ewk_init_body result.
https://bugs.webkit.org/show_bug.cgi?id=60149

The ewk_init function should be failed when _ewk_init_body function
return false.

  • ewk/ewk_main.cpp: (ewk_init):
4:26 PM Changeset in webkit [85803] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462

  • WebProcess.pro: Add Symbian OS capabilities to web process executable. Also enable data paging flag and prevent application's icon from showing up in the application grid.

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Laszlo Gombos.

[Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
https://bugs.webkit.org/show_bug.cgi?id=59462

  • MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.
4:22 PM Changeset in webkit [85802] by eric@webkit.org
  • 8 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

The testing EWS bots should upload layout-test-results.zip to bugs after failures
https://bugs.webkit.org/show_bug.cgi?id=60223

This required sharing a bit of code between the commit-queue
(which already knew how to do this) and the new EWS testing bots.

In the process I also cleaned up EWS testing a little and
removed some dead code from the commit-queue.

  • Scripts/webkitpy/common/config/committervalidator.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
4:08 PM Changeset in webkit [85801] by Nate Chapin
  • 3 edits in branches/chromium/742/Source/WebKit/chromium

2011-05-04 Nate Chapin <Nate Chapin>

Reviewed by Mihai Parparita.

Ensure we don't overwrite user-specified scroll positions
on same document HistoryItem navigations.
https://bugs.webkit.org/show_bug.cgi?id=59877

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
3:55 PM Changeset in webkit [85800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Fridrich Strba <fridrich.strba@bluewin.ch>

Reviewed by Adam Barth.

Add COMPILER(MINGW) to the compilers using the Microsoft C Runtime's vsnprintf.
The vsnprintf is part of Microsoft C runtime used also by MinGW (GCC) toolchain.
https://bugs.webkit.org/show_bug.cgi?id=58579

  • dom/XMLDocumentParserLibxml2.cpp: (WebCore::XMLDocumentParser::error):
3:54 PM Changeset in webkit [85799] by alexis.menard@openbossa.org
  • 8 edits in trunk/Source

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just unused.

  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::inputMethods):

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.

  • dom/Node.cpp: (WebCore::Node::removeEventListener):
  • platform/DateComponents.cpp: (WebCore::DateComponents::parseTime):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::convertToLayerCoords):
  • storage/StorageMap.cpp: (WebCore::StorageMap::importItem):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildShadowTree): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
3:50 PM Changeset in webkit [85798] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] put flaky tests into their own table
https://bugs.webkit.org/show_bug.cgi?id=60214

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:
3:45 PM Changeset in webkit [85797] by koz@chromium.org
  • 6 edits in trunk/Tools

2011-05-04 James Kozianski <koz@chromium.org>

Reviewed by Eric Seidel.

Add method to make a Port able to retrieve TestOutputSets from its builders.
https://bugs.webkit.org/show_bug.cgi?id=58211

This will be used in the new rebaseline script - TestOutputs are
potential new baselines.

  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/factory.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
3:44 PM Changeset in webkit [85796] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] fix apply options on page load
https://bugs.webkit.org/show_bug.cgi?id=60217

This broke when we started storing options in localstorage.
Also fixes regressions exposed by fixing this.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
3:32 PM Changeset in webkit [85795] by Adam Roben
  • 13 edits in trunk/Source/WebKit2

Clip and reposition windowed plugins when the UI process paints

This ensures that their geometry updates in sync with the rest of the page.

Most of this patch is just plumbing the scheduleWindowedPluginGeometryUpdate and
scheduleChildWindowGeometryUpdate calls through from NetscapePlugin all the way over to
WebView. I've tried to call out the other parts below.

Fixes <http://webkit.org/b/60210> <rdar://problem/8483441> REGRESSION (WebKit2): Windowed
plugins don't scroll at the same speed as the rest of the page

Reviewed by Darin Adler and Anders Carlsson.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::scheduleChildWindowGeometryUpdate):
Added plumbing.

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::onPaintEvent): Update child windows before painting so that they will stay
in sync with the rest of the page.
(WebKit::WebView::scheduleChildWindowGeometryUpdate): Add this update information to the
set of geometries to update on the next paint.
(WebKit::setWindowRegion): Moved this helper function here from NetscapePluginWin.cpp.
(WebKit::WebView::updateChildWindowGeometries): Update the size, position, and clip rects of
all the child windows with scheduled geometry updates.

  • UIProcess/win/WebView.h: Added new members to track and update child window geometries.
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPostInitialize): Don't show the window immediately. Let the
UI process take care of it.
(WebKit::NetscapePlugin::platformGeometryDidChange): Don't update the window's position or
clip rect. Let the UI process take care of it.

  • WebProcess/Plugins/PluginController.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::scheduleWindowedPluginGeometryUpdate):

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/win/WebPageWin.cpp:

(WebKit::WebPage::scheduleChildWindowGeometryUpdate):
Added plumbing.

3:20 PM Changeset in webkit [85794] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

WKView on Windows has no equivalent of Mac's -[WKView setDraws[Transparent]Background:]
https://bugs.webkit.org/show_bug.cgi?id=52009
<rdar://problem/8829746>

Add and implement WKViewSetDrawsTransparentBackground on windows.

  • UIProcess/API/C/win/WKView.cpp: (WKViewSetDrawsTransparentBackground): (WKViewDrawsTransparentBackground): Call through to the WebPageProxy object.
  • UIProcess/API/C/win/WKView.h:
  • UIProcess/win/WebView.cpp: (WebKit::drawPageBackground): Don't fill the rect with white if WebPageProxy::drawsBackground() or WebPageProxy::drawsTransparentBackground() returns false. Because of limitations in Win32, both drawsBackground and drawsTransparentBackground are pretty much equivalent.

(WebKit::WebView::paint):
Pass the WebPageProxy object to drawPageBackground.

3:08 PM Changeset in webkit [85793] by mrobinson@webkit.org
  • 2 edits in trunk

2011-05-04 Martin Robinson <mrobinson@igalia.com>

Fix the WebKitGTK+ build.

  • configure.ac: Added option parsing code for loading touch icons.
3:02 PM Changeset in webkit [85792] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Ojan Vafai.

sheriff-bot can't parse results.html
https://bugs.webkit.org/show_bug.cgi?id=60196

The problem was that the NRWT bots are currently core
and so sheriff-bot was trying to diagnose failures on
them. It was trying to parse their results.html file
and BeautifulSoup was throwing an exception.

It seems our version of BeautifulSoup was quite old
and unable to handle <script> tags correctly.
This moves us to 3.2 which doesn't seem to have this bug.

  • Scripts/webkitpy/thirdparty/BeautifulSoup.py:
2:52 PM Changeset in webkit [85791] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Unreviewed warning fix.

The variable is just used in the ASSERT macro. Let's use ASSERT_UNUSED to avoid
a warning in Release build.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::lastChildConsideringContinuation):
2:46 PM Changeset in webkit [85790] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-04 Dimitri Glazkov <Dimitri Glazkov>

Sort xcodeproj files.

The WebCore.xcodeproj got out of sorts again.

  • WebCore.xcodeproj/project.pbxproj: Ran sort-XCode-project-file.
2:42 PM Changeset in webkit [85789] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Adam Barth.

Warning fix.

  • bindings/js/DOMObjectHashTableMap.h: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
2:32 PM Changeset in webkit [85788] by rwlbuis@webkit.org
  • 3 edits
    8 adds in trunk

2011-05-04 Rob Buis <rbuis@rim.com>

Reviewed by Darin Adler.

NULL deref when SVG elements have table styles
https://bugs.webkit.org/show_bug.cgi?id=45561

Restrict computed CSS values for SVG display property to block, inline or none.

Tests: svg/custom/display-table-caption-foreignObject.svg

svg/custom/display-table-caption-inherit-foreignObject.xhtml
svg/custom/display-table-caption-inherit-text.xhtml
svg/custom/display-table-caption-text.svg

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
2:32 PM Changeset in webkit [85787] by Nate Chapin
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-04 Nate Chapin <Nate Chapin>

Reviewed by Mihai Parparita.

Ensure we don't overwrite user-specified scroll positions
on same document HistoryItem navigations.
https://bugs.webkit.org/show_bug.cgi?id=59877

  • src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::loadHistoryItem): (WebKit::WebFrameImpl::currentHistoryItem): (WebKit::WebFrameImpl::WebFrameImpl):
  • src/WebFrameImpl.h:
2:12 PM Changeset in webkit [85786] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Make the EWS test logging less verbose
https://bugs.webkit.org/show_bug.cgi?id=60201

This should help us generate less than a hundred MB of logs per hour.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/common/config/ports_unittest.py:
2:02 PM Changeset in webkit [85785] by commit-queue@webkit.org
  • 55 edits
    2 adds in trunk

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

  • Configurations/FeatureDefines.xcconfig:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Parsed and populated apple-touch-icon url to FrameLoaderClient.
Changed favicon to be a type of icon.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp: (WebCore::Document::iconURL): (WebCore::Document::setIconURL):
  • dom/Document.h:
  • dom/IconURL.cpp: Added. (WebCore::toIconIndex):
  • dom/IconURL.h: Added. (WebCore::IconURL::IconURL):
  • features.pri:
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::tokenizeRelAttribute): (WebCore::HTMLLinkElement::process): (WebCore::HTMLLinkElement::addSubresourceAttributeURLs):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::RelAttribute::RelAttribute): (WebCore::HTMLLinkElement::isEnabledViaScript):
  • html/parser/HTMLPreloadScanner.cpp: (WebCore::HTMLNames::PreloadTask::relAttributeIsStyleSheet):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::iconURL): (WebCore::DocumentLoader::setIconURL):
  • loader/DocumentLoader.h:
  • loader/EmptyClients.h: (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::iconURL): (WebCore::FrameLoader::iconURLs): (WebCore::FrameLoader::fillIconURL): (WebCore::FrameLoader::getDefaultIconURL): (WebCore::FrameLoader::setIconURL): (WebCore::FrameLoader::didChangeIcons):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respected the change of FrameLoaderClient.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
  • src/FrameLoaderClientImpl.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient

  • WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientEfl.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientGtk.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidChangeIcons):

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientQt.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidChangeIcons):
  • WebCoreSupport/WebFrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebCoreSupport/FrameLoaderClientWinCE.cpp: (WebKit::FrameLoaderClientWinCE::dispatchDidChangeIcons):
  • WebCoreSupport/FrameLoaderClientWinCE.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respect the interface change in FrameLoaderClient.

  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidChangeIcons):
  • WebKitSupport/FrameLoaderClientWx.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Respected the change of FrameLoaderClient.
Added WebIconURL and WebIconType responding the new IconURL and IconType.
Supported to get the multiple icon urls.

  • Configurations/FeatureDefines.xcconfig:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchDidChangeIcons):
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

2011-05-04 Tao Bai <michaelbai@chromium.org>

Reviewed by David Kilzer.

Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143

Disable touch icon by default.

  • Scripts/build-webkit:
1:40 PM Changeset in webkit [85784] by luiz@webkit.org
  • 4 edits in trunk/LayoutTests

Unreviewed build fix.

Skipping test http/tests/navigation/response204.html for Mac, Win and GTK.

  • platform/gtk/Skipped:
  • platform/mac/Skipped:
  • platform/win/Skipped:
1:33 PM Changeset in webkit [85783] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

2011-05-04 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Can't save a link from "Save Linked File to Download" popup menu
https://bugs.webkit.org/show_bug.cgi?id=60190
<rdar://problem/9367927>

Make sure that suggestedFilenameForResourceWithURL and resourceDataForFrame both look
in the cache if the resource can't be found in the current web page. This matches WebKit1.

  • WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::suggestedFilenameForResourceWithURL): Call WebPage::cachedSuggestedFilenameForURL if we can't find a resource in the page.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::resourceDataForFrame): Move code out from getResourceDataFromFrame.

(WebKit::WebPage::getResourceDataFromFrame):
Call resourceDataForFrame first and then cachedResponseDataForURL.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/gtk/WebPageGtk.cpp: (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL): Add stubs.
  • WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::cachedResponseForURL): Add helper function.

(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.

  • WebProcess/WebPage/qt/WebPageQt.cpp: (WebKit::WebPage::platformHasLocalDataForURL): (WebKit::WebPage::cachedResponseMIMETypeForURL): (WebKit::WebPage::platformCanHandleRequest): (WebKit::WebPage::cachedSuggestedFilenameForURL): (WebKit::WebPage::cachedResponseDataForURL): Add stubs.


  • WebProcess/WebPage/win/WebPageWin.cpp: (WebKit::cachedResponseForURL): Add helper function.

(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
Call helper function.

1:26 PM Changeset in webkit [85782] by imasaki@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Update bug numbers in media related test cases.
https://bugs.webkit.org/show_bug.cgi?id=60078

Reviewed by David Levin.

  • platform/chromium/test_expectations.txt:
1:17 PM Changeset in webkit [85781] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-04 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Crash in PlatformCALayer ::replaceSublayer when layer has not superlayer
https://bugs.webkit.org/show_bug.cgi?id=60191

Skip replaceSublayer when there is no superlayer rather than asserting.
This is probably not a problem and happens when restructuring the layer
tree. Avoiding this crash will allow us to get more testing.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
1:08 PM Changeset in webkit [85780] by Simon Fraser
  • 4 edits
    2 adds in trunk

2011-05-04 Simon Fraser <Simon Fraser>

Reviewed by Anders Carlsson.

WebKit2 flashes if entering and exiting compositing rapidly
https://bugs.webkit.org/show_bug.cgi?id=60198

If a page enters then immediately leaves compositing mode, the
DrawingAreaImpl would send a message to the UI process that it
had entered compositing even after all the layers had been torn
down. Fix this by never sending the 'enter' message if we're
waiting for the 'exit' timer to fire.

Also fix an assertion in the UI process caused by sending mismatched
'enter' and 'leave' messages by keeping track of which messages
we've sent.

  • WebProcess/WebPage/DrawingAreaImpl.cpp: (WebKit::DrawingAreaImpl::DrawingAreaImpl): (WebKit::DrawingAreaImpl::layerHostDidFlushLayers): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModeSoon):
  • WebProcess/WebPage/DrawingAreaImpl.h: (WebKit::DrawingAreaImpl::exitAcceleratedCompositingModePending):
12:37 PM Changeset in webkit [85779] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Windows DRT needs an implementation of shadowRoot
https://bugs.webkit.org/show_bug.cgi?id=59081

Add another test for the shadow dom to the Windows Skipped list to get the bots green.

  • platform/win/Skipped:
12:26 PM Changeset in webkit [85778] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] Don't show actual failure type column for ports that don't use expectations files
https://bugs.webkit.org/show_bug.cgi?id=60199

For the most part, the links shown tell you what type of failure it is.
The only case where we lose some information here is for a test that
failed one run, but passed or had a different failure on retry.i
We should probably put those tests in their own table anyways.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
12:20 PM Changeset in webkit [85777] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

2011-05-04 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Add gpu acceleration flags to DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=60168
Adding support for command line flags
enable-accelerated-2d-canvas an
enable-accelerated-drawing in DumpRenderTree.

  • DumpRenderTree/chromium/DumpRenderTree.cpp: (main):
  • DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): (TestShell::resetWebSettings):
  • DumpRenderTree/chromium/TestShell.h: (TestShell::setLegacyAccelerated2dCanvasEnabled): (TestShell::setAcceleratedDrawingEnabled):
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::reset): (WebPreferences::applyTo):
  • DumpRenderTree/chromium/WebPreferences.h:
12:19 PM Changeset in webkit [85776] by Ademar Reis
  • 2 edits in trunk/Tools

2011-05-04 Ademar de Souza Reis Jr. <Ademar Reis>

Reviewed by Csaba Osztrogonác.

[Qt] run-qtwebkit-tests misses exec bit
https://bugs.webkit.org/show_bug.cgi?id=60188

Also removing an unecessary import (mostly to let this bugfix goes
through the system, as this is just a chmod).

  • Scripts/run-qtwebkit-tests:
12:07 PM Changeset in webkit [85775] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Skipped inspector/elements/shadow-dom.html on win.
https://bugs.webkit.org/show_bug.cgi?id=60195

  • platform/win/Skipped:
12:04 PM Changeset in webkit [85774] by luiz@webkit.org
  • 4 edits
    4 adds in trunk

[Qt] Qt WebKit updates view on HTTP 204 response
https://bugs.webkit.org/show_bug.cgi?id=42529

Reviewed by Kenneth Rohde Christiansen.

Source/WebKit/qt:

Ignoring http responses which have status code equal to 204 (No Content)
or 205 (Reset Content).

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForResponse):

LayoutTests:

Responses which have status code equal to 204 should be ignored.

  • http/tests/navigation/response204-expected.txt: Added.
  • http/tests/navigation/response204.html: Added.
  • http/tests/navigation/resources/response204.pl: Added.
12:01 PM Changeset in webkit [85773] by mrobinson@webkit.org
  • 5 edits in trunk/Source/WebCore

2011-05-04 Martin Robinson <mrobinson@igalia.com>

Reviewed by Gustavo Noronha Silva.

Fix the GTK+ 2.x build for Windows. Instead of making getStockIcon a RenderTheme
method, just use extern declarations to avoid having to declare it in the header.
This will prevent having to include glib.h in RenderThemeGtk.h, which is included
in many C++ files.

No new tests. This is just a build fix.

  • platform/gtk/RenderThemeGtk.cpp: Update getStockIcon calls to say getStockIconForWidgetType. (WebCore::RenderThemeGtk::paintSearchFieldResultsDecoration): (WebCore::RenderThemeGtk::paintSearchFieldCancelButton): (WebCore::RenderThemeGtk::paintCapsLockIndicator): (WebCore::RenderThemeGtk::paintMediaButton):
  • platform/gtk/RenderThemeGtk.h: Removed getStockIcon declaration. Make gtkContainer() and gtkEntry() public because they are now accessed externally from getStockIcon().
  • platform/gtk/RenderThemeGtk2.cpp: Update getStockIcon calls. (WebCore::getStockIconForWidgetType):
  • platform/gtk/RenderThemeGtk3.cpp: Ditto. (WebCore::getStockIconForWidgetType):
12:00 PM Changeset in webkit [85772] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Source/WebKit/qt

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Benjamin Poulain.

[Qt] Fix signals emitted in FakeReply used in autotests
https://bugs.webkit.org/show_bug.cgi?id=60049

The signals emitted for each case of FakeReply were swapped (error case
emitting metaDataChanged() and redirect case emitting error()). Emitting
readyRead() is not necessary.

  • tests/qwebframe/tst_qwebframe.cpp: (FakeReply::FakeReply): Choose the different continue function for each case of FakeReply. This removes the need of the if-statement in timeout() and let us replace timeout() with two simpler functions.

(FakeReply::continueRedirect):
(FakeReply::continueError):
Continuation cases, emitting the minimal set of signals needed for each case.

11:56 AM Changeset in webkit [85771] by ggaren@apple.com
  • 3 edits
    2 adds in trunk

<rdar://problem/9366557> Various crashes due to bad DFG codegen at canalplus.fr

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes): Removed a stray line of
code that accidentally survived the conversion to a switch statement,
causing a lot of important code not to run most of the time.

Since this is not a trivial finger-picking mistake, I will not call it a
typo.

LayoutTests:

  • fast/js/trivial-functions-expected.txt: Added.
  • fast/js/trivial-functions.html: Added.
11:55 AM Changeset in webkit [85770] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022

  • storage/indexeddb/mozilla/open-database-null-name-expected.txt: Added.
  • storage/indexeddb/mozilla/open-database-null-name.html: Added.

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

IndexedDB open (database) should fail if name is null
https://bugs.webkit.org/show_bug.cgi?id=60022

Test: storage/indexeddb/mozilla/open-database-null-name.html

Combination problem: Bug in IDL didn't pass null values to .cpp layer,
then .cpp layer didn't check for null value anyway.

  • storage/IDBFactory.cpp: (WebCore::IDBFactory::open): check for null name
  • storage/IDBFactory.idl: pass null name as null
11:50 AM Changeset in webkit [85769] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Improve styling on the toolbar. Make the background opaque.

  • fast/harness/results.html:
11:49 AM Changeset in webkit [85768] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Fix import of ircproxy module to actually import the module. I don't
really understand how this code could have worked before.

  • Scripts/webkitpy/common/host.py:
11:39 AM Changeset in webkit [85767] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-04 Jer Noble <jer.noble@apple.com>

Reviewed by Darin Adler.

Entering full screen fails >= second time on Vimeo.com.
https://bugs.webkit.org/show_bug.cgi?id=60143

Force the RenderFullScreen's layer backing to be recreated when setAnimating() is called.
Previously, the RenderLayerCompositor would fail to reparent the RenderFullScreen's layer
at the end of an animation, if it determined that the RenderFullScreen would still require
a layer even when not animating.

  • rendering/RenderFullScreen.cpp: (RenderFullScreen::setAnimating): Clear the renderer's layer.
11:24 AM Changeset in webkit [85766] by hclam@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations for Linux.

  • platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
  • platform/chromium-linux/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
11:22 AM Changeset in webkit [85765] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

  • inspector/elements/shadow-dom-expected.txt:
  • inspector/elements/shadow-dom.html:
11:03 AM Changeset in webkit [85764] by jeffm@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix typo in svn property in r85756.

  • Shared/mac/NativeWebWheelEventMac.mm: Added property svn:eol-style. Removed property snv:eol-style.
11:02 AM Changeset in webkit [85763] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Andreas Kling.

[Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=60172

  • MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser (BrowserWindow::BrowserWindow):
11:00 AM Changeset in webkit [85762] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Part 2 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE

Reviewed by Adam Barth.

  • Configurations/Base.xcconfig:

(GCC_TREAT_WARNINGS_AS_ERRORS): Set to YES.

11:00 AM Changeset in webkit [85761] by ddkilzer@apple.com
  • 5 edits in trunk/Source/ThirdParty/ANGLE

Part 1 of 2: <http://webkit.org/b/56337> Enable -Werror on ANGLE

Merge ANGLE upstream commits r572, r573, r574, r575.

This unblocks enabling -Werror on ANGLE. Since all changes are
in the upstream repository, they may be safely overwritten
during the next ANGLE update.

  • src/compiler/ConstantUnion.h:

(ConstantUnion::operator==): Added a default case.

  • src/compiler/Intermediate.cpp:

(TIntermBinary::promote): Added parentheses.

  • src/compiler/ParseHelper.cpp:

(TParseContext::precisionErrorCheck): Added a default case.

  • src/compiler/PoolAlloc.cpp:

(TAllocation::checkGuardBlock): Changed '%u' to '%lu' for size_t
variable. Put for loop inside #ifdef GUARD_BLOCKS/#endif macros
to fix tautological-compare warning.
(TAllocation::checkAllocList): Added newline to end of file.

10:50 AM Changeset in webkit [85760] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

2011-05-04 Simon Fraser <Simon Fraser>

Reviewed by Darin Adler.

Avoid allocating a new image buffer in ~CanvasRenderingContext2D()
https://bugs.webkit.org/show_bug.cgi?id=59849

When attempting to unwind the graphics state stack in the
CanvasRenderingContext2D destructor, don't allow HTMLCanvasElement
to create a new ImageBuffer.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::existingDrawingContext):
  • html/HTMLCanvasElement.h:
  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::~CanvasRenderingContext2D):
10:47 AM Changeset in webkit [85759] by jcivelli@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

2011-05-04 Jay Civelli <jcivelli@chromium.org>

Reviewed by Ojan Vafai.

Send the char events to the select popup if one is showing to fix
a bug were pressing a letter would not select the matching option.
https://bugs.webkit.org/show_bug.cgi?id=47769

  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::keyEvent): (WebKit::WebViewImpl::charEvent):
  • src/WebViewImpl.h:
10:46 AM Changeset in webkit [85758] by caseq@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Another shot at fixing flakiness under win (also renamed a couple of obsolete things).

  • inspector/elements/shadow-dom-expected.txt:
  • inspector/elements/shadow-dom.html:
10:37 AM Changeset in webkit [85757] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-04 Ojan Vafai <ojan@chromium.org>

Reviewed by Eric Seidel.

[results.html] bucket crashes/timeouts into their own test lists
https://bugs.webkit.org/show_bug.cgi?id=60181

Also, don't show the "expected to fail but passed" table for ports
that don't use an expectation file.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
10:29 AM Changeset in webkit [85756] by jeffm@apple.com
  • 5 edits
    5 adds in trunk/Source/WebKit2

2011-05-04 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Add NativeWebWheelEvent class
https://bugs.webkit.org/show_bug.cgi?id=60182


This will be needed soon when we start notifying the UI process that a mouse wheel event wasn't handled by WebKit.

  • GNUmakefile.am: Added NativeWebWheelEventGtk.cpp and NativeWebWheelEvent.h.
  • Shared/NativeWebWheelEvent.h: Added. (WebKit::NativeWebWheelEvent::nativeEvent): Added.
  • Shared/gtk/NativeWebWheelEventGtk.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
  • Shared/mac/NativeWebWheelEventMac.mm: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
  • Shared/qt/NativeWebWheelEventQt.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent): Added.
  • Shared/win/NativeWebWheelEventWin.cpp: Added. (WebKit::NativeWebWheelEvent::NativeWebWheelEvent):Added.
  • WebKit2.pro: Added NativeWebWheelEventQt.cpp and NativeWebWheelEvent.h.
  • WebKit2.xcodeproj/project.pbxproj: Added NativeWebWheelEventMac.mm and NativeWebWheelEvent.h.
  • win/WebKit2.vcproj: Added NativeWebWheelEventWin.cpp and NativeWebWheelEvent.h.
9:59 AM Changeset in webkit [85755] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>

Reviewed by Anders Carlsson.

ArgumentDecoder should use aligned memory for its internal copy of data
https://bugs.webkit.org/show_bug.cgi?id=59960

Since we check for memory alignment when unpacking primitive types from the buffer,
insure alignment of the base address.
As uint64_t is the largest type we use in Argument encoder/decoder, use 8 byte alignment.

  • Platform/CoreIPC/ArgumentDecoder.cpp: (CoreIPC::ArgumentDecoder::~ArgumentDecoder): free m_alignedBase (CoreIPC::roundUpToAlignment): move this up in the source file (CoreIPC::ArgumentDecoder::initialize): m_buffer is now guaranteed sizeof(uint64_t) aligned
  • Platform/CoreIPC/ArgumentDecoder.h: add m_alignedBase member which needs to be freed in d'tor
9:58 AM Changeset in webkit [85754] by Adam Roben
  • 6 edits
    2 adds in trunk/Source/WebKit2

Make ShareableBitmap::makeCGImageCopy use a copy-on-write copy on Windows when possible

Fixes <http://webkit.org/b/57269> <rdar://problem/9198788> REGRESSION (r82151): Every WKView
paint now makes an extra copy of the painted bits

Reviewed by Anders Carlsson.

  • Platform/SharedMemory.h:
  • Platform/win/SharedMemoryWin.cpp:

(WebKit::SharedMemory::createCopyOnWriteCopy):
Added this new function. Creates a copy-on-write copy of the first |size| bytes of the
original SharedMemory.

  • Shared/ShareableBitmap.h: Added createCGImage helper function.
  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::makeCGImageCopy): Don't compile this version of this function on
Windows; we'll provide our own implementation since CGBitmapContextCreateImage isn't smart
enough to make a copy-on-write copy on Windows.
(WebKit::ShareableBitmap::makeCGImage): Moved some code from here...
(WebKit::ShareableBitmap::createCGImage): ...to this new function.

  • Shared/cg/win/ShareableBitmapCGWin.cpp: Added.

(WebKit::derefSharedMemory): This function is called when the CGDataProvider is finalized.
All we have to do is deref the SharedMemory that was backing the CGDataProvider.
(WebKit::ShareableBitmap::makeCGImageCopy): Create a copy-on-write copy of the image data
when possible. We use the copy-on-write copy to back this ShareableBitmap from here on out,
and use the original SharedMemory to back the CGImage. This should prevent future
modifications to the ShareableBitmap from affecting the CGImage. If we can't make a
copy-on-write copy, we fall back to just copying the data normally.

  • win/WebKit2.vcproj: Added ShareableBitmapCGWin.cpp.
9:53 AM Changeset in webkit [85753] by Adam Roben
  • 2 edits in trunk/Source/WebKit2

Let transparent windowless plugins draw into a graphics context with an alpha channel

Fixes <http://webkit.org/b/57647> <rdar://problem/9168462> Flash plugins with
wmode=transparent have black (instead of transparent) background in WebKit2 on Windows

I had trouble writing a test case for this, so I split that task out into
<http://webkit.org/b/60169>.

Reviewed by Sam Weinig.

  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:

(WebKit::NetscapePlugin::platformPaint): Give the graphics context an alpha channel if this
is a transparent windowless plugin.

9:28 AM Changeset in webkit [85752] by caseq@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Unreviewed. Attempt to resolve flakiness on windows.

  • inspector/elements/shadow-dom.html:
8:07 AM Changeset in webkit [85751] by caseq@chromium.org
  • 12 edits
    2 adds in trunk

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160

Test: inspector/elements/shadow-dom.html

  • dom/Element.cpp: (WebCore::Element::ensureShadowRoot): (WebCore::Element::removeShadowRoot):
  • inspector/Inspector.json:
  • inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::pushChildNodesToFrontend): (WebCore::InspectorDOMAgent::buildObjectForNode): (WebCore::InspectorDOMAgent::didInsertDOMNode): (WebCore::InspectorDOMAgent::didRemoveDOMNode): (WebCore::InspectorDOMAgent::isContainerNode):
  • inspector/InspectorDOMAgent.h:
  • inspector/front-end/DOMAgent.js: (WebInspector.DOMNode): (WebInspector.DOMNode.prototype.inShadowTree): (WebInspector.DOMNode.prototype._setShadowRootPayload): (WebInspector.DOMNode.prototype._renumber): (WebInspector.DOMAgent.prototype._bindNodes): (WebInspector.DOMAgent.prototype.querySelectorAll): (WebInspector.DOMAgent.prototype._shadowRootUpdated): (WebInspector.DOMDispatcher.prototype.searchResults): (WebInspector.DOMDispatcher.prototype.shadowRootUpdated):
  • inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel): (WebInspector.ElementsPanel.prototype._nodeUpdated): (WebInspector.ElementsPanel.prototype._attributesUpdated): (WebInspector.ElementsPanel.prototype._nodeRemoved): (WebInspector.ElementsPanel.prototype.updateModifiedNodes): (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
  • inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeElement): (WebInspector.ElementsTreeElement.prototype._updateChildren.updateChildrenOfNode): (WebInspector.ElementsTreeElement.prototype._updateChildren): ():
  • inspector/front-end/inspector.css: (#elements-content .dom-shadow-root): (.outline-disclosure li .webkit-html-tag.shadow):
  • inspector/front-end/utilities.js:

2011-05-04 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: expose shadow DOM in the Elements panel
https://bugs.webkit.org/show_bug.cgi?id=60160

  • http/tests/inspector/elements-test.js: (initialize_ElementTest.InspectorTest.nodeWithId.processChildren): (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested): (initialize_ElementTest.InspectorTest.nodeWithId):
  • inspector/elements/shadow-dom-expected.txt: Added.
  • inspector/elements/shadow-dom.html: Added.
7:55 AM Changeset in webkit [85750] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Websites/bugs.webkit.org

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

REGRESSION (r85657): webkitpy.common.prettypatch_unittest.PrettyPatchTest.test_pretty_diff_encodings failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=60164

Use Array#length to get the number of elements in an array. Array#count
was added in Ruby 1.8.7, but Leopard have Ruby 1.8.6.

  • PrettyPatch/PrettyPatch.rb:
7:31 AM Changeset in webkit [85749] by Adam Roben
  • 3 edits in trunk/Source/JavaScriptCore

Another attempted build fix

  • wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added a return statement. And made a tweak based on a suggestion from Anders Carlsson.

7:25 AM Changeset in webkit [85748] by Adam Roben
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix Leopard, Qt, and probably others

  • wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Try to get the compiler not to instantiate these function templates unnecessarily.

7:25 AM Changeset in webkit [85747] by Ademar Reis
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Unreviewed: Adding myself to the committers' list.

7:11 AM Changeset in webkit [85746] by Adam Roben
  • 8 edits in trunk/Source

Disallow equality comparisons between [Pass]OwnPtrs

If you have two OwnPtrs that are equal, you've already lost. (Unless you're doing something
really sneaky, in which case you should stop!)

Fixes <http://webkit.org/b/60053> Testing OwnPtrs for equality should cause a compiler error

Reviewed by Anders Carlsson and Antti Koivisto.

Source/JavaScriptCore:

  • wtf/OwnPtr.h:

(WTF::OwnPtr::operator==):
(WTF::OwnPtr::operator!=):

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::operator==):
(WTF::PassOwnPtr::operator!=):
Added private equality operators that fail to compile when used. (When not used, the
compiler will skip over them because they are function templates.)

Source/WebCore:

Remove an unnecessary OwnPtr equality check in XSLT code

  • dom/Document.cpp:

(WebCore::Document::setTransformSource): No need to check for equality. If the pointers are
equal, we're screwed anyway. (And the caller always passes in a newly-allocated object, so
we're safe.)

Source/WebKit2:

Remove WebPageProxy::setDrawingArea

It is unused. It also does a useless equality comparison between OwnPtrs; if they are equal,
we've already lost.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:

Removed setDrawingArea.

(WebKit::WebPageProxy::drawingArea):
(WebKit::WebPageProxy::backForwardList):
Made these functions const while I was at it.

6:57 AM Changeset in webkit [85745] by commit-queue@webkit.org
  • 11 edits
    5 adds in trunk/Source/WebCore

2011-05-04 Leandro Gracia Gil <leandrogracia@chromium.org>

Reviewed by Tony Gentilcore.

Media Stream API: add the skeleton of the frame and page controllers and the embedder client.
https://bugs.webkit.org/show_bug.cgi?id=56922

Add the basic outlines of the page controller, the per-frame controller and the embedder
client interface for the Media Stream API. Provide methods to handle the situations
where a frame is detached from the page or transferred between pages.

Tests for the Media Stream API will be provided by the bug 56587.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame): (WebCore::Frame::pageDestroyed): (WebCore::Frame::transferChildFrameToNewDocument):
  • page/Frame.h: (WebCore::Frame::mediaStreamFrameController):
  • page/MediaStreamClient.h: Added. (WebCore::MediaStreamClient::~MediaStreamClient):
  • page/MediaStreamController.cpp: Added. (WebCore::MediaStreamController::Request::Request): (WebCore::MediaStreamController::Request::localId): (WebCore::MediaStreamController::Request::frameController): (WebCore::MediaStreamController::MediaStreamController): (WebCore::MediaStreamController::~MediaStreamController): (WebCore::MediaStreamController::unregisterFrameController): (WebCore::MediaStreamController::registerRequest):
  • page/MediaStreamController.h: Added.
  • page/MediaStreamFrameController.cpp: Added. (WebCore::MediaStreamFrameController::Request::Request): (WebCore::MediaStreamFrameController::Request::~Request): (WebCore::MediaStreamFrameController::Request::scriptExecutionContext): (WebCore::MediaStreamFrameController::Request::isGenerateStreamRequest): (WebCore::MediaStreamFrameController::Request::isRecordedDataRequest): (WebCore::MediaStreamFrameController::RequestMap::abort): (WebCore::MediaStreamFrameController::RequestMap::abortAll): (WebCore::MediaStreamFrameController::MediaStreamFrameController): (WebCore::MediaStreamFrameController::~MediaStreamFrameController): (WebCore::MediaStreamFrameController::securityOrigin): (WebCore::MediaStreamFrameController::scriptExecutionContext): (WebCore::MediaStreamFrameController::pageController): (WebCore::MediaStreamFrameController::enterDetachedState): (WebCore::MediaStreamFrameController::disconnectPage): (WebCore::MediaStreamFrameController::disconnectFrame): (WebCore::MediaStreamFrameController::transferToNewPage):
  • page/MediaStreamFrameController.h: Added.
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::PageClients::PageClients):
  • page/Page.h: (WebCore::Page::mediaStreamController):
6:48 AM Changeset in webkit [85744] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Alexander Pavlov <apavlov@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: Double-click in a read-only style rule results in a non-editable blank property
https://bugs.webkit.org/show_bug.cgi?id=60150

  • inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertiesSection.prototype._handleEmptySpaceDoubleClick):
6:46 AM Changeset in webkit [85743] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Fix crashes in QMetaObject::metacall
https://bugs.webkit.org/show_bug.cgi?id=53912

  • platform/qt/Skipped: Unskip http/tests/websocket/tests.
6:36 AM Changeset in webkit [85742] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Dominic Battre <battre@chromium.org>

Reviewed by Tony Gentilcore.

Fix missing header in case SVG is disabled
https://bugs.webkit.org/show_bug.cgi?id=60153

  • dom/EventDispatcher.cpp:
6:26 AM WebKit Team edited by Ademar Reis
(diff)
6:25 AM Changeset in webkit [85741] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-04 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Initialize viewport argument in ewk_view.cpp
https://bugs.webkit.org/show_bug.cgi?id=60147

viewport computation logic can't be worked correctly because viewport argument
isn't initialized. So, we need to initialize viewport argument.

  • ewk/ewk_view.cpp: (_ewk_view_priv_new):
6:18 AM Changeset in webkit [85740] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-04 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip fast/dom/Geolocation/argument-types.html crashing
on GTK.

[GTK] fast/dom/Geolocation/argument-types.html flaky crash on 32-bits Debug
https://bugs.webkit.org/show_bug.cgi?id=60158

  • platform/gtk/Skipped:
6:14 AM Changeset in webkit [85739] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-04 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: readyState
https://bugs.webkit.org/show_bug.cgi?id=60069

Checks the value of the request.readyState property during and
after opening a database, setting the version, creating a datastore,
adding a record, and retrieving a record.

  • storage/indexeddb/mozilla/readyState-expected.txt: Added.
  • storage/indexeddb/mozilla/readyState.html: Added.
6:06 AM Changeset in webkit [85738] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Rename CSSStyleApplyProperty::propertyValue and setPropertyValue.
https://bugs.webkit.org/show_bug.cgi?id=60006

No new tests as no functionality added. Simple rename only.

  • css/CSSStyleApplyProperty.cpp: Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
  • css/CSSStyleApplyProperty.h: Rename propertyValue propertyHandler and setPropertyValue setPropertyHandler.
6:03 AM Changeset in webkit [85737] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Cleanup conditionals in findNextLineBreak
https://bugs.webkit.org/show_bug.cgi?id=60117

Simplified conditional statements in findNextLineBreak.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
5:44 AM Changeset in webkit [85736] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Eric Seidel.

Make CSSStyleSelector::applyProperty() CSSPropertyWebkitHyphens case use appropriate macro.
https://bugs.webkit.org/show_bug.cgi?id=60114

No new tests as no functionality changes.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro to remove code duplication.
5:39 AM Changeset in webkit [85735] by mihaip@chromium.org
  • 11 edits in trunk/Tools

2011-05-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

[NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
https://bugs.webkit.org/show_bug.cgi?id=60088

Makes --new-baseline put new baselines into the first entry in the
baseline search path, including any additional directories passed in via
--additional-platform-directory.

Simplifies baseline_path() by making it return the first entry in the
baseline search path instead of requiring each port to have an
implementation (should not result in any behavior change).

  • Scripts/webkitpy/layout_tests/port/base.py:
  • Scripts/webkitpy/layout_tests/port/base_unittest.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py:
  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  • Scripts/webkitpy/layout_tests/port/chromium_win.py:
  • Scripts/webkitpy/layout_tests/port/mac.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/port/webkit.py:
5:24 AM Changeset in webkit [85734] by caio.oliveira@openbossa.org
  • 4 edits in trunk/Source/WebCore

2011-05-04 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

[Qt] Fix QNetworkReplyWrapper to not depend on QNetworkReply::isFinished() method
https://bugs.webkit.org/show_bug.cgi?id=59070

Applications using our API and our autotests subclass QNetworkReply as part of providing a
custom QNetworkAccessManager. But there's an API limitation in Qt 4.7, that makes
QNetworkReply::isFinished() always be false for these custom replies. This was fixed in Qt
4.8, see http://bugreports.qt.nokia.com/browse/QTBUG-11737.

The consequence is that QtWebKit cannot rely on this function. So now QNetworkReplyWrapper
watches for the finished() signal and set a dynamic property "_q_isFinished" on the reply
indicating that it is finished. When there's no finished signal (synchronous) we set the
dynamic property once we get the reply.

This fixes tst_QWebFrame::requestedUrl(), that was breaking because sniffer was not
emitting its own finished() signal, causing QWebFrame::loadFinished() to not be emitted.

  • platform/network/qt/QNetworkReplyHandler.cpp: (WebCore::QNetworkReplyWrapper::QNetworkReplyWrapper): Connect the finished signal to the new setFinished() slot.

(WebCore::QNetworkReplyWrapper::synchronousLoad):
Since we don't get the finished signal for synchronous loads, set the dynamic property
before processing it.

(WebCore::QNetworkReplyWrapper::resetConnections):
Do not reset the connection to setFinished().

(WebCore::QNetworkReplyWrapper::setFinished):
Set the dynamic property in the reply.

(WebCore::QNetworkReplyWrapper::emitMetaDataChanged):
(WebCore::QNetworkReplyHandler::start):
Change to use wrapper's isFinished() instead of asking the reply directly.

  • platform/network/qt/QNetworkReplyHandler.h: (WebCore::QNetworkReplyWrapper::isFinished): Checks the dynamic property of the reply.
  • platform/network/qt/QtMIMETypeSniffer.cpp: (QtMIMETypeSniffer::sniff): Use the dynamic property to check if the reply is finished.
4:58 AM Changeset in webkit [85733] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-04 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r85669.

  • platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt:
4:51 AM Changeset in webkit [85732] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
https://bugs.webkit.org/show_bug.cgi?id=60080

No functional change, just moving code.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::createLineBoxesFromBidiRuns): (WebCore::RenderBlock::layoutRunsAndFloats):
4:42 AM Changeset in webkit [85731] by andreas.kling@nokia.com
  • 2 edits in trunk/Source/WebCore

2011-05-04 Andreas Kling <andreas.kling@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Remove unused function FontPlatformData::pixelSize()
https://bugs.webkit.org/show_bug.cgi?id=60156

  • platform/graphics/qt/FontPlatformData.h: (WebCore::FontPlatformData::pixelSize): Removed.
4:35 AM Changeset in webkit [85730] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Luke Macpherson <macpherson@chromium.org>

Reviewed by Darin Adler.

Remove redundant conversion from auto table layout to auto table layout in CSSStyleSelector::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=60011

No new tests added as no functionality changed.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove reundant check for auto table layout.
4:34 AM Changeset in webkit [85729] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Gavin Barraclough.

JITArithmetic.cpp produces a warning on a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=60060

Just properly use what we already have converted.

  • jit/JITArithmetic.cpp: (JSC::JIT::emitSlow_op_add): (JSC::JIT::emitSlow_op_mul):
4:08 AM Changeset in webkit [85728] by mihaip@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-04 Mihai Parparita <mihaip@chromium.org>

Reviewed by Darin Adler.

Remove double-free checks for bug 56124
https://bugs.webkit.org/show_bug.cgi?id=60037

Antti's speculative fix for bug 56124 (r84151) appears to have worked,
these CRASH() calls are not triggering anymore.

  • css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector):
  • css/CSSSelectorList.cpp: (WebCore::CSSSelectorList::deleteSelectors):
3:44 AM Changeset in webkit [85727] by abarth@webkit.org
  • 12 edits in trunk/Tools

2011-05-04 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Fix circular dependency in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=60075

These functions don't belong in bugzilla.py. They only exist there
because they are old. Really, these functions shouldn't be free
functions at all, but that's a patch for another day.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
  • Scripts/webkitpy/common/checkout/checkout.py:
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/bugzilla/init.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  • Scripts/webkitpy/style/checkers/changelog.py:
  • Scripts/webkitpy/tool/bot/irc_command.py:
  • Scripts/webkitpy/tool/bot/sheriff.py:
  • Scripts/webkitpy/tool/commands/upload.py:
2:41 AM Changeset in webkit [85726] by satish@chromium.org
  • 6 edits in trunk

2011-05-04 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742

  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium/test_expectations.txt:

2011-05-04 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Layout the speech input button to the left of outer spin button properly.
https://bugs.webkit.org/show_bug.cgi?id=59742

  • rendering/RenderTextControlSingleLine.cpp: (WebCore::RenderTextControlSingleLine::layout):
1:33 AM Changeset in webkit [85725] by alexis.menard@openbossa.org
  • 4 edits in trunk/Source/JavaScriptCore

2011-05-04 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Geoffrey Garen.

JITPropertyAccess produces a unused but set variable warning in gcc 4.6.0.
https://bugs.webkit.org/show_bug.cgi?id=60050

This patch fix a compilation warning. The new warning scenario -Wunused-but-set-variable
in gcc 4.6.0 is included in -Wall and therefore stops the compilation when warnings are treated
as errors. The patch introduces a new macro ASSERT_JIT_OFFSET_UNUSED and ASSERT_WITH_MESSAGE_UNUSED
which copy the idea of ASSERT_UNUSED.

  • jit/JIT.h:
  • jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_method_check): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id):
  • wtf/Assertions.h: (assertWithMessageUnused):
12:03 AM Changeset in webkit [85724] by yurys@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-04 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Build fix.

  • bindings/js/JSInjectedScriptHostCustom.cpp: fix includes declaration
12:00 AM Changeset in webkit [85723] by psolanki@apple.com
  • 2 edits in trunk/Tools

https://bugs.webkit.org/show_bug.cgi?id=60141 Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit

Reviewed by Dan Bernstein.

  • Scripts/build-webkit:

May 3, 2011:

11:45 PM Changeset in webkit [85722] by yurys@chromium.org
  • 6 edits
    2 adds in trunk

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't inspect element in an iframe when element originates from non-frame document
https://bugs.webkit.org/show_bug.cgi?id=60031

  • inspector/elements/elements-inspect-iframe-from-different-domain-expected.txt: Added.
  • inspector/elements/elements-inspect-iframe-from-different-domain.html: Added.

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: can't inspect element in an iframe when element originates from non-frame document
https://bugs.webkit.org/show_bug.cgi?id=60031

Inspected object type evaluation has moved into native bindings. This way it doesn't
depend on the current JS context.

Test: inspector/elements/elements-inspect-iframe-from-different-domain.html

  • bindings/js/JSInjectedScriptHostCustom.cpp: (WebCore::JSInjectedScriptHost::isHTMLAllCollection): this method helps distinguish real undefined values from HTMLAllCollection (WebCore::JSInjectedScriptHost::type): method that returns presice type of the passed value
  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp: (WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback): (WebCore::V8InjectedScriptHost::typeCallback):
  • inspector/InjectedScriptHost.idl:
  • inspector/InjectedScriptSource.js: (.):
11:36 PM Changeset in webkit [85721] by psolanki@apple.com
  • 8 edits in trunk/Source

Part of WebCore should use CFNetwork-based loader on Mac
https://bugs.webkit.org/show_bug.cgi?id=51836

Reviewed by Antti Koivisto.

Source/WebCore:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one. Clean
up some warnings and #if USE(CFNETWORK) around code.

  • platform/mac/CookieJar.mm:
  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::privateBrowsingCookieStorage):
(WebCore::currentCookieStorage):
(WebCore::setCurrentCookieStorage):
(WebCore::setCookieStoragePrivateBrowsingEnabled):
(WebCore::notifyCookiesChangedOnMainThread):
(WebCore::notifyCookiesChanged):

  • platform/network/cf/CookieStorageCFNet.h:
  • platform/network/mac/CookieStorageMac.mm:

Source/WebKit2:

Merge the conflicting definitions of WebCore::privateBrowsingCookieStorage() into one.

  • WebProcess/Cookies/cf/WebCookieManagerCFNet.cpp:

(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):

11:25 PM Changeset in webkit [85720] by commit-queue@webkit.org
  • 9 edits in trunk/Source

2011-05-03 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Make accelerated 2d canvas enabled by default with skia
https://bugs.webkit.org/show_bug.cgi?id=59929

No new tests. Covered by existing layout tests

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): Initialized for accelerated canvas if either the accelerated2dCanvas or the legacyAccelerated2dCanvas flags are enabled
  • page/Page.cpp: (WebCore::Page::sharedGraphicsContext3D): This is where the code goes to implement the functionality for the legacy vs current acceleration paths for the 2D canvas. Currently, this is a no-op, and always select the legacy path. This is temporary until we are ready to sort the GPU layout tests (rebasline vs. bug)
  • page/Settings.cpp: Added new flage for legacyAccelerated2dCanvas (WebCore::Settings::Settings): (WebCore::Settings::setLegacyAccelerated2dCanvasEnabled):
  • page/Settings.h: (WebCore::Settings::legacyAccelerated2dCanvasEnabled):

2011-05-03 Justin Novosad <junov@chromium.org>

Reviewed by Kenneth Russell.

[Chromium] Make accelerated 2d canvas enabled by default with skia
https://bugs.webkit.org/show_bug.cgi?id=59929
Added new flag for enabling the legacy accelerated 2d canvas
The flag is not yet functional with this change.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::setLegacyAccelerated2dCanvasEnabled):
  • src/WebSettingsImpl.h:
11:21 PM Changeset in webkit [85719] by jer.noble@apple.com
  • 7 edits in trunk

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798

  • wtf/Platform.h: Set ENABLE_FULLSCREEN_API on win.

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798

  • WebCore.vcproj/WebCore.vcproj: Add missing full screen related

files to the project.

2011-04-29 Jer Noble <jer.noble@apple.com>

Reviewed by Eric Seidel.

Implement FULLSCREEN_API on Windows, Part 4: Enable it
https://bugs.webkit.org/show_bug.cgi?id=59798

  • win/tools/vsprops/FeatureDefines.vsprops: Set ENABLE_FULLSCREEN_API to true.
11:08 PM Changeset in webkit [85718] by alexis.menard@openbossa.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-03 Alexis Menard <alexis.menard@openbossa.org>

Reviewed by Eric Seidel.

Unused but set variable warning in MacroAssemberX86_64
https://bugs.webkit.org/show_bug.cgi?id=59482

  • assembler/MacroAssemblerX86_64.h: (JSC::MacroAssemblerX86_64::call): (JSC::MacroAssemblerX86_64::tailRecursiveCall): (JSC::MacroAssemblerX86_64::makeTailRecursiveCall):
10:46 PM Changeset in webkit [85717] by hclam@chromium.org
  • 6 edits in trunk/Source/WebKit/chromium

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

More 0 to nullptr.

  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::pluginLoadObserver):
  • src/GraphicsContext3DChromium.cpp: (WebCore::GraphicsContext3D::~GraphicsContext3D):
  • src/WebAudioBus.cpp: (WebKit::WebAudioBus::release):
  • src/WebBlobData.cpp: (WebKit::WebBlobData::reset):
  • src/WebViewImpl.cpp: (WebKit::WebView::addUserScript): (WebKit::WebView::addUserStyleSheet):
10:30 PM Changeset in webkit [85716] by hclam@chromium.org
  • 11 edits in trunk/Source/WebCore

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

More places from 0 to nullptr.

  • bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::precompileScript):
  • platform/graphics/chromium/LayerTilerChromium.cpp: (WebCore::LayerTilerChromium::create):
  • platform/graphics/gpu/BicubicShader.cpp: (WebCore::BicubicShader::create):
  • platform/graphics/gpu/ConvolutionShader.cpp: (WebCore::ConvolutionShader::create):
  • platform/graphics/gpu/LoopBlinnSolidFillShader.cpp: (WebCore::LoopBlinnSolidFillShader::create):
  • platform/graphics/gpu/SolidFillShader.cpp: (WebCore::SolidFillShader::create):
  • platform/graphics/gpu/TexShader.cpp: (WebCore::TexShader::create):
  • platform/graphics/skia/PlatformContextSkia.cpp: (WebCore::PlatformContextSkia::~PlatformContextSkia):
  • platform/leveldb/LevelDBDatabase.cpp: (WebCore::LevelDBDatabase::createIterator):
  • platform/text/LocalizedNumberICU.cpp: (WebCore::createFormatterForCurrentLocale):
10:07 PM Changeset in webkit [85715] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Updated expected results after updating this test in r85676.

  • platform/mac/fast/text/ligature-subdivision-expected.txt:
9:59 PM Changeset in webkit [85714] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Quick suppresion for layout test failures.

  • platform/chromium/test_expectations.txt:
9:52 PM Changeset in webkit [85713] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Using nullptr instead of 0. This makes visual studio happy.

  • storage/IDBTransactionBackendInterface.h:
8:54 PM Changeset in webkit [85712] by dpranke@chromium.org
  • 3 edits
    5 adds
    1 delete in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage and new baselines.

  • platform/chromium-linux/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-mac-leopard/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-mac-leopard/fast/multicol/client-rects-expected.png: Added.
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png: Removed.
  • platform/chromium-win/fast/borders/bidi-012-expected.png: Added.
  • platform/chromium-win/fast/borders/bidi-012-expected.txt: Added.
  • platform/chromium/test_expectations.txt:
  • platform/mac/fast/block/float/float-overhangs-root-expected.png:
8:36 PM Changeset in webkit [85711] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Add template parameter to ApplyPropertyColor to improve clarity by removing constructor parameter side effects.
https://bugs.webkit.org/show_bug.cgi?id=59774

No new tests required as on new functionality.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyColor::applyValue): Added template parameter "inheritColorFromParent = false". (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Use template parameter where appropriate.
8:15 PM Changeset in webkit [85710] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Reviewed by Xan Lopez.

[CMAKE] Remove C++0x compat mode warnings for GCC >= 4.6.0
https://bugs.webkit.org/show_bug.cgi?id=60041

Hardcode -Wno-c++0x-compat for the default compiler (if version >=
4.6.0) until our codebase is ready. This is the same as done for
autotools.

  • Source/cmake/WebKitHelpers.cmake: ditto.
8:13 PM Changeset in webkit [85709] by dpranke@chromium.org
  • 11 edits
    1 add
    2 deletes in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage and new baselines.

  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/chromium-linux/fast/forms/basic-selects-expected.png:
  • platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-mac-leopard/fast/box-shadow/inset-expected.png: Added.
  • platform/chromium-mac-leopard/fast/forms/basic-selects-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-expected.png: Removed.
  • platform/chromium-mac/fast/forms/basic-selects-expected.png: Removed.
  • platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/forms/basic-selects-expected.png:
  • platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
  • platform/chromium/test_expectations.txt:
8:07 PM Changeset in webkit [85708] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, rolling out r85624.
http://trac.webkit.org/changeset/85624

The same command is used also for make_names.pl, which breaks
the build.

  • Source/cmake/OptionsCommon.cmake: ditto.
7:48 PM Changeset in webkit [85707] by dpranke@chromium.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations change and new baselines.

  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-leopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium/test_expectations.txt:
7:34 PM Changeset in webkit [85706] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage.

  • platform/chromium/test_expectations.txt:
7:20 PM Changeset in webkit [85705] by mitz@apple.com
  • 4 edits in trunk/Source/WebCore

<rdar://problem/9313186> Make the fix for <rdar://problem/9190108> more robust.

Reviewed by Darin Adler.

Added a pointer from FloatingObject to its originating line, if there is one, and made sure to
dirty the line when the float is removed, instead of relying on the float always intersecting
its originating line.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::clearFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::FloatingObject::FloatingObject):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::appendFloatingObjectToLastLine):
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::determineStartPosition):

7:14 PM Changeset in webkit [85704] by dpranke@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage.

  • platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
7:08 PM Changeset in webkit [85703] by jam@chromium.org
  • 8 edits in trunk/Source/WebKit/chromium

2011-05-03 John Abd-El-Malek <jam@chromium.org>

Reviewed by James Robinson.

[chromium] Go through WebPermissionClient for local storage access. Also cleanup left over code from previous WebPermissionClient change.
https://bugs.webkit.org/show_bug.cgi?id=60066

  • public/WebFrameClient.h:
  • public/WebPermissionClient.h: (WebKit::WebPermissionClient::allowLocalStorage):
  • src/DatabaseObserver.cpp: (WebCore::DatabaseObserver::canEstablishDatabase):
  • src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowScriptExtension): (WebKit::FrameLoaderClientImpl::allowJavaScript): (WebKit::FrameLoaderClientImpl::allowPlugins): (WebKit::FrameLoaderClientImpl::allowImages): (WebKit::FrameLoaderClientImpl::didNotAllowScript): (WebKit::FrameLoaderClientImpl::didNotAllowPlugins):
  • src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::setItem):
6:59 PM Changeset in webkit [85702] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triage.

  • platform/chromium/test_expectations.txt:
6:36 PM Changeset in webkit [85701] by dpranke@chromium.org
  • 2 edits
    4 deletes in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, remove obsolete baselines.

  • platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
  • platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
  • platform/chromium/test_expectations.txt:
6:32 PM Changeset in webkit [85700] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

2011-05-03 Oliver Hunt <oliver@apple.com>

Reviewed by Geoffrey Garen.

Make malloc validation useful
https://bugs.webkit.org/show_bug.cgi?id=57502

Reland this patch (rolled out in 82905) without
turning it on by default.

  • JavaScriptCore.exp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • wtf/FastMalloc.cpp: (WTF::tryFastMalloc): (WTF::fastMalloc): (WTF::tryFastCalloc): (WTF::fastCalloc): (WTF::fastFree): (WTF::tryFastRealloc): (WTF::fastRealloc): (WTF::fastMallocSize): (WTF::TCMalloc_PageHeap::isScavengerSuspended): (WTF::TCMalloc_PageHeap::scheduleScavenger): (WTF::TCMalloc_PageHeap::suspendScavenger): (WTF::TCMalloc_PageHeap::signalScavenger): (WTF::TCMallocStats::malloc): (WTF::TCMallocStats::free): (WTF::TCMallocStats::fastCalloc): (WTF::TCMallocStats::tryFastCalloc): (WTF::TCMallocStats::calloc): (WTF::TCMallocStats::fastRealloc): (WTF::TCMallocStats::tryFastRealloc): (WTF::TCMallocStats::realloc): (WTF::TCMallocStats::fastMallocSize):
  • wtf/FastMalloc.h: (WTF::Internal::fastMallocValidationHeader): (WTF::Internal::fastMallocValidationSuffix): (WTF::Internal::fastMallocMatchValidationType): (WTF::Internal::setFastMallocMatchValidationType): (WTF::fastMallocMatchValidateFree): (WTF::fastMallocValidate):
6:28 PM Changeset in webkit [85699] by jer.noble@apple.com
  • 15 edits
    1 copy
    1 move
    1 add
    1 delete in trunk/Source

2011-05-02 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845

Move WebFullScreenController into WebCore to facilitate code sharing between WebKit
and WebKit2. WebFullScreenController now uses a Client class to request work on its
behalf by WebKit and WebKit2. MediaPlayerPrivateFullscreenWindow now only creates a
CALayerHost once a root layer is set, as the CALayerHost was causing child window drawing
problems, and because a CALayerHost is overkill if the window is only drawing black to
its client area.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp: (WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow): Do not create

m_layerHost in the constructor.

(WebCore::MediaPlayerPrivateFullscreenWindow::createWindow): NULL check m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Lazily instantiate m_layerHost.
(WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): NULL check m_layerHost; if a root layer is

not present, fill the window with black in WM_PAINT.

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  • platform/graphics/win/FullScreenController.cpp: Renamed from Source/WebKit/win/WebFullScreenController.cpp.
  • platform/graphics/win/FullScreenController.h: Renamed from Source/WebKit/win/WebFullScreenController.h.
  • platform/graphics/win/FullScreenControllerClient.h: Split out from FullScreenController.h (WebCore::FullScreenControllerClient::~FullScreenControllerClient):

2011-05-02 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845

Implementation of WebFullScreenController has been moved into WebCore, and
required virutal functions of WebFullScreenControllerClient have been added to
WebView. These functions are mostly simple accessors of existing ivars, but
m_fullScreenElement and its accessors have also been added to WebView.

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::enterFullScreenForElement):
  • WebFullScreenController.cpp: Removed.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::setFullScreenElement): Added accessor. (WebVIew::fullScreenElement): Ditto. (WebView::fullScreenClientWindow): Ditto. (WebView::fullScreenClientParentWindow): Ditto. (WebView::fullScreenClientSetParentWindow): Ditto. (WebView::fullScreenClientWillEnterFullScreen): Pass through to Document. (WebView::fullScreenClientDidEnterFullScreen): Ditto. (WebView::fullScreenClientWillExitFullScreen): Ditto. (WebView::fullScreenClientDidExitFullScreen): Ditto.
  • WebView.h:

2011-05-02 Jer Noble <jer.noble@apple.com>

Reviewed by Adam Roben.

Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845

Implement a similar full screen mode to WebKit; Re-use the same
full screen window class used in WebKit in the new WebFullScreenController.
No animations (yet), so many of the stubs remain unimplemented.

  • UIProcess/win/WebView.cpp: (WebKit::WebView::onKeyEvent): Handle VK_ESCAPE and cancel full screen

mode if caught.

(WebKit::WebView::fullScreenController): Lazily instantiate m_fullScreenController.
(WebKit::WebView::fullScreenClientWindow): Added accessor.
(WebKit::WebView::fullScreenClientParentWindow): Ditto.
(WebKit::WebView::fullScreenClientSetParentWindow): Ditto.
(WebKit::WebView::fullScreenClientWillEnterFullScreen): Pass through to WebFullScreenManagerProxy.
(WebKit::WebView::fullScreenClientDidEnterFullScreen): Ditto.
(WebKit::WebView::fullScreenClientWillExitFullScreen): Ditto.
(WebKit::WebView::fullScreenClientDidExitFullScreen): Ditto.

  • UIProcess/win/WebView.h:
  • UIProcess/win/WebFullScreenManagerProxyWin.cpp: (WebKit::WebFullScreenManagerProxy::enterFullScreen): Pass through to

WebFullScreenController.

(WebKit::WebFullScreenManagerProxy::exitFullScreen): Ditto.

  • UIProcess/win/WebView.cpp: (WebKit::WebView::WebView): (WebKit::WebView::onKeyEvent): Handle the escape key and exit

full screen mode when detected.

(WebKit::WebView::fullScreenWindowController): Added.

  • UIProcess/win/WebView.h:
  • WebProcess/FullScreen/win/WebFullScreenManagerWin.cpp: (WebKit::WebFullScreenManagerWin::~WebFullScreenManagerWin): (WebKit::WebFullScreenManagerWin::setRootFullScreenLayer): Host the root

full screen layer if it gets detached.

  • WebProcess/FullScreen/win/WebFullScreenManagerWin.h:
  • win/WebKit2.vcproj:
6:14 PM Changeset in webkit [85698] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, expectations triaging.

  • platform/chromium/test_expectations.txt:
5:38 PM Changeset in webkit [85697] by beidson@apple.com
  • 7 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=60087 and <rdar://problem/9373182>
WK2 Icon Database should provide access to all image representations in the icon.

Reviewed by Sam Weinig.

../WebCore:

Add an accessor for CG platforms to get a CFArrayRef of all the CGImageRefs represented:

  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:

(WebCore::Image::getCGImageArray):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::BitmapImage::getCGImageArray):

../WebKit2:

Expose a CFArrayRef of CGImageRefs as API for CG platforms:

  • UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryCopyCGImageArrayForURL):

  • UIProcess/API/C/cg/WKIconDatabaseCG.h:
5:38 PM Changeset in webkit [85696] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

5:38 PM Changeset in webkit [85695] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

findNextLineBreak splits InlineIterator into 3 pieces
https://bugs.webkit.org/show_bug.cgi?id=60082

Avoid splitting InlineIterator into 3 variables with inter-dependencies.

  • rendering/InlineIterator.h: (WebCore::InlineIterator::fastIncrementInTextNode): Added. (WebCore::InlineIterator::previousInSameNode): Added.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::findNextLineBreak):
5:36 PM Changeset in webkit [85694] by Lucas Forschler
  • 1 copy in tags/Safari-534.33

New tag.

5:31 PM Changeset in webkit [85693] by dino@apple.com
  • 3 edits
    3 adds in trunk

2011-05-03 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062

CompositeAnimation was replacing any existing
transition as a new one was created. However, it wasn't
clearing the lists in AnimationControllerPrivate that
signal when a hardware animation starts. Rather than
simple removing the existing transition, we now tell
AnimationControllerPrivate that is has gone.

Test: transitions/3d/interrupted-transition.html

  • page/animation/CompositeAnimation.cpp: (WebCore::CompositeAnimation::updateTransitions):

2011-05-03 Dean Jackson <dino@apple.com>

Reviewed by Simon Fraser.

Interrupted transitions are not correctly removed
https://bugs.webkit.org/show_bug.cgi?id=60062

  • transitions/3d/interrupted-transition-expected.txt: Added.
  • transitions/3d/interrupted-transition.html: Added.
5:23 PM Changeset in webkit [85692] by mihaip@chromium.org
  • 2 edits in trunk/Tools

2011-05-03 Mihai Parparita <mihaip@chromium.org>

Reviewed by Ojan Vafai.

Update rebaseline queue server to handle hierarchical test results
https://bugs.webkit.org/show_bug.cgi?id=60063

Update test result parsing done by the rebaseline queue server to handle
the hierarchical test result output that is generated as of r85254.

  • RebaselineQueueServer/templates/builder-queue-edit.html:
4:59 PM Changeset in webkit [85691] by bweinstein@apple.com
  • 3 edits in trunk/Source/WebKit/win

REGRESSION(r84990): Nightly builds don't launch on Windows
https://bugs.webkit.org/show_bug.cgi?id=60081
<rdar://problem/9358635>

Reviewed by Steve Falkenburg.

Fix nightlies on Window by moving the layered window functions to the bottom
of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.

  • Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
  • Interfaces/WebKit.idl: Touch to force a rebuild.
4:51 PM Changeset in webkit [85690] by hclam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adding rebaseline for recent changes for mac.

  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
4:46 PM Changeset in webkit [85689] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-03 Sam Weinig <sam@webkit.org>

Reviewed by Dan Bernstein.

WebKit2 should treat API calls that start/stop loads as user gestures for responsiveness timer
https://bugs.webkit.org/show_bug.cgi?id=60083

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::reattachToWebProcessWithItem): (WebKit::WebPageProxy::tryClose): (WebKit::WebPageProxy::loadURL): (WebKit::WebPageProxy::loadURLRequest): (WebKit::WebPageProxy::loadHTMLString): (WebKit::WebPageProxy::loadAlternateHTMLString): (WebKit::WebPageProxy::loadPlainTextString): (WebKit::WebPageProxy::stopLoading): (WebKit::WebPageProxy::reload): (WebKit::WebPageProxy::goForward): (WebKit::WebPageProxy::goBack): (WebKit::WebPageProxy::goToBackForwardItem): Start responsiveness timer for load start/stop and close.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::SendStopResponsivenessTimer::SendStopResponsivenessTimer): (WebKit::SendStopResponsivenessTimer::~SendStopResponsivenessTimer): Add simple RAII class to ensure the StopResponsivenessTimer is called.

(WebKit::WebPage::tryClose):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadData):
(WebKit::WebPage::stopLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
Sends a message back to the UIProcess to indicate the WebProcess
is still responsive.

4:45 PM Changeset in webkit [85688] by hclam@chromium.org
  • 1 edit
    5 adds in trunk/LayoutTests

2011-05-03 Enrica Casucci <enrica@apple.com>

Reviewed by Ryosuke Niwa.

Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

  • editing/selection/undo-crash-expected.txt: Added.
  • editing/selection/undo-crash.html: Added.
4:40 PM Changeset in webkit [85687] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Crash in SpellingCorrectionController::respondToChangedSelection.
https://bugs.webkit.org/show_bug.cgi?id=60071
<rdar://problem/9358190>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Creating a Visible position could trigger a layout and there is no
guarantee that the selection is still valid after that.

Tests: editing/selection/undo-crash.html

  • editing/SpellingCorrectionController.cpp:

(WebCore::SpellingCorrectionController::respondToChangedSelection):

LayoutTests:

  • editing/selection/undo-crash-expected.txt: Added.
  • editing/selection/undo-crash.html: Added.
4:35 PM Changeset in webkit [85686] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Incorrect line number dumping
https://bugs.webkit.org/show_bug.cgi?id=60074

[Qt][WK2] editing/pasteboard/do-not-copy-body-color.html fails
https://bugs.webkit.org/show_bug.cgi?id=60076

  • platform/qt-wk2/Skipped: Add a couple of failing tests.
4:28 PM Changeset in webkit [85685] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Refactor computeInlineDirectionPositionsForLine into smaller functions
https://bugs.webkit.org/show_bug.cgi?id=60072

Split three functions off from computeInlineDirectionPositionsForLine
to improve its readability.

No new tests since this is just moving code around.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::setMarginsForRubyRun): (WebCore::setLogicalWidthForTextRun): (WebCore::computeExpansionForJustifiedText): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
4:25 PM Changeset in webkit [85684] by ddkilzer@apple.com
  • 6 edits in trunk/Source

<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking

Reviewed by Antti Koivisto.

Source/WebCore:

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Set the
priority on the request if HTTP pipelining is enabled.
(WebCore::ResourceRequest::doUpdateResourceRequest): Read the
priority from the request if HTTP pipelining is enabled.
(readBooleanPreference): Enable code when compiling with
USE(CFNETWORK).
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Ditto.
Comment out setting the minimum fast lane priority on Windows
since it's not currently available.

Source/WebKit/win:

  • Interfaces/IWebViewPrivate.idl:

(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.

  • WebView.cpp:

(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.

  • WebView.h:

(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.

4:20 PM Changeset in webkit [85683] by tony@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Tony Chang <tony@chromium.org>

Add a bug number for a recent regression to test_expectations.txt.

  • platform/chromium/test_expectations.txt:
4:18 PM Changeset in webkit [85682] by hclam@chromium.org
  • 2 edits
    10 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations.

  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.txt:
4:14 PM Changeset in webkit [85681] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-03 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

<rdar://problem/9278296> Flicker zooming on Google Maps satellite view with accelerated compositing turned on

Conditionalize compositing tiled layer size-constraining logic to older
OSes.

  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::constrainedSize):
4:08 PM Changeset in webkit [85680] by rolandsteiner@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-03 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Allow access keys to be used in shadow DOM
https://bugs.webkit.org/show_bug.cgi?id=59979

Move access key methods and members back to Document from TreeScope.
Also traverse into shadow trees when building the access key map.

No new tests. (refactoring)

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::getElementByAccessKey): (WebCore::Document::buildAccessKeyMap): (WebCore::Document::invalidateAccessKeyMap):
  • dom/Document.h:
  • dom/TreeScope.cpp: (WebCore::TreeScope::TreeScope): (WebCore::TreeScope::destroyTreeScopeData):
  • dom/TreeScope.h:
4:03 PM Changeset in webkit [85679] by kerz@chromium.org
  • 1 edit in branches/chromium/742/LayoutTests/platform/chromium/test_expectations.txt

fixing chrome continuous webkit tests after bad test-expectations merge

4:00 PM Changeset in webkit [85678] by hclam@chromium.org
  • 1 edit
    11 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Build fix. Not reviewed.

Add test expectations for new tests.

  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/chromium-linux/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/chromium-linux/fast/forms/input-readonly-autoscroll-expected.txt: Added.
3:33 PM Changeset in webkit [85677] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/8891395> -[DOMRange textRects] returns incorrect results for vertical or flipped text
https://bugs.webkit.org/show_bug.cgi?id=60067

Reviewed by Darin Adler.

No test because this code path is only used by the Objective-C API, which is not testable from DumpRenderTree.

  • rendering/RenderText.cpp:

(WebCore::RenderText::absoluteRectsForRange): Use width/height instead of logicalWidth/logicalHeight here,
and perform the local-to-absolute mapping on the rects rather than their origin, in order to get the right
results for flipped writing modes.

3:30 PM Changeset in webkit [85676] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Account for font metric differences exposed by r85411.
Fixes <rdar://problem/9377892> REGRESSION (r85403-r85475): platform/mac/fast/text/ligature-subdivision.html failing

Rubber-stamped by Darin Adler.

  • platform/mac/fast/text/script-tests/ligature-subdivision.js:
3:29 PM Changeset in webkit [85675] by tony@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Tony Chang <tony@chromium.org>

Update results for fast/harness/results.html. We shouldn't be
ignoring these failures :(

  • fast/harness/results-expected.txt:
  • platform/chromium/test_expectations.txt:
3:25 PM Changeset in webkit [85674] by tony@chromium.org
  • 25 edits in trunk/LayoutTests

2011-05-03 Tony Chang <tony@chromium.org>

Update chromium linux test results after r85013. The vertical
positioning of the glyphs have improved.

  • platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/atsui-spacing-features-expected.png:
  • platform/chromium-linux/fast/text/international/hebrew-vowels-expected.png:
  • platform/chromium-linux/fast/text/international/thai-baht-space-expected.png:
  • platform/chromium-linux/fast/text/international/thai-line-breaks-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
  • platform/chromium-linux/svg/W3C-I18N/text-anchor-no-markup-expected.png:
  • platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
3:22 PM Changeset in webkit [85673] by antonm@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Anton Muhin <antonm@chromium.org>

Reviewed by Yury Semikhatsky.

[v8] remove an ASSERT from grouping logic
https://bugs.webkit.org/show_bug.cgi?id=60024

This ASSERT was exploratory. Alas, right now I am aware of no easy way to
repro it. Removing for now for greener bots.

No new tests, only an ASSERT removal.

  • bindings/v8/V8GCController.cpp: (WebCore::calculateGroupId):
3:20 PM Changeset in webkit [85672] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-03 Eric Seidel <eric@webkit.org>

Reviewed by Adam Roben.

webkit-patch post-commits HEAD.. throws an exception
https://bugs.webkit.org/show_bug.cgi?id=60027

  • Scripts/webkitpy/common/checkout/scm/git.py:
3:16 PM Changeset in webkit [85671] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION(r85648) Skip data-transfer-items.html test because data-transfer-items is not a Qt default build option
https://bugs.webkit.org/show_bug.cgi?id=60068

Patch by Igor Oliveira <igor.oliveira@openbossa.org> on 2011-05-03
Reviewed by Csaba Osztrogonác.

Skip data-transfer-items.html test because data-transfer-items
is not a Qt default build option

  • platform/qt/Skipped:
3:16 PM Changeset in webkit [85670] by luiz@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Fixing ChangeLog.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

3:14 PM Changeset in webkit [85669] by rniwa@webkit.org
  • 5 edits
    16 adds in trunk

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit allows selection that crosses the shadow boundary of a readonly input element
https://bugs.webkit.org/show_bug.cgi?id=60000

Added pixel tests to ensure WebKit doesn't create a selection that spans across
the shadow DOM boundary of a readonly input element. Also rebaselined a test that
previously exhibited this behavior.

  • editing/selection/resources/select-across-readonly-input.js: Added. (moveMouseToMiddleOfElement):
  • editing/selection/select-across-readonly-input-1.html: Added.
  • editing/selection/select-across-readonly-input-2.html: Added.
  • editing/selection/select-across-readonly-input-3.html: Added.
  • editing/selection/select-across-readonly-input-4.html: Added.
  • editing/selection/select-across-readonly-input-5.html: Added.
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Darin Adler.

WebKit allows selection that crosses the shadow boundary of a readonly input element
https://bugs.webkit.org/show_bug.cgi?id=60000

The bug was caused by VisibleSelection's not validating shadow DOM boundaries.
Fixed the bug by adding an extra adjustment, adjustSelectionToAvoidCrossingShadowBoundaries,
in its validation process.

Tests: editing/selection/select-across-readonly-input-1.html

editing/selection/select-across-readonly-input-2.html
editing/selection/select-across-readonly-input-3.html
editing/selection/select-across-readonly-input-4.html
editing/selection/select-across-readonly-input-5.html

  • editing/VisibleSelection.cpp: (WebCore::VisibleSelection::validate): Calls adjustSelectionToAvoidCrossingShadowBoundaries. (WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Added.
  • editing/VisibleSelection.h:
3:11 PM Changeset in webkit [85668] by eric@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Eric Seidel <eric@webkit.org>

Reviewed by Ryosuke Niwa.

Split out layoutRunsAndFloats from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=60052

No new tests, just moving code here. There should be
no change in behavior.

  • rendering/RenderBlock.h:
  • rendering/RenderBlockLineLayout.cpp: (WebCore::RenderBlock::layoutRunsAndFloats): (WebCore::RenderBlock::layoutInlineChildren):
3:05 PM Changeset in webkit [85667] by luiz@webkit.org
  • 2 edits in trunk/Tools

[Qt] Layout tests may timeout if loadFinished receives false
https://bugs.webkit.org/show_bug.cgi?id=60064

Reviewed by NOBODY Kenneth Rohde Christiansen.

When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
a response is ignored, like it should be for 204 responses. It is a problem for creating
tests for 204 responses for example.

This change has been tested and it causes no regressions in layout tests.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp:

(LayoutTestController::maybeDump):

3:05 PM Changeset in webkit [85666] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Add expectation to suppress new failure.

  • platform/chromium/test_expectations.txt:
2:51 PM Changeset in webkit [85665] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Unreviewed, rolling out r85659.
http://trac.webkit.org/changeset/85659
https://bugs.webkit.org/show_bug.cgi?id=59977

restarting isn't working correctly

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:47 PM Changeset in webkit [85664] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
https://bugs.webkit.org/show_bug.cgi?id=59638

  • platform/qt-wk2/Skipped: Add failing tests until fix.
2:40 PM Changeset in webkit [85663] by hclam@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965

Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

  • fast/canvas/canvas-resize-after-paint-expected.txt: Added.
  • fast/canvas/canvas-resize-after-paint.html: Added.
2:33 PM Changeset in webkit [85662] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9250444> Enter key doesn't work in a web text field (but Return key does)

Reviewed by Sam Weinig.

No test at this time because the WebKit2 eventSender doesn't use this code path.

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebKeyboardEvent): Copied the code to special-case certain
keys from the corresponding Mac WebKit1 code path.

2:21 PM Changeset in webkit [85661] by jamesr@google.com
  • 5 edits
    2 adds in trunk

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965

Adds a test with a canvas rendered once with normal width/height dimensions then resized to very large dimensions.

  • fast/canvas/canvas-resize-after-paint-expected.txt: Added.
  • fast/canvas/canvas-resize-after-paint.html: Added.

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Resizing a 2d canvas to huge dimensions after compositing crashes with accelerated 2d canvas option enabled
https://bugs.webkit.org/show_bug.cgi?id=59965

Fixes a few bugs leading to a crash if a canvas already being composited was resized to huge dimensions.

Test: fast/canvas/canvas-resize-after-paint.html

  • html/canvas/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::reset):

Mark the canvas's layer as needing a synthetic style recalculation when creating or destroying the backing
DrawingBuffer so that we exit compositing mode properly if we can't handle the canvas dimensions.

  • platform/graphics/chromium/Canvas2DLayerChromium.cpp: (WebCore::Canvas2DLayerChromium::setLayerRenderer):

Add a null check for m_drawingBuffer

  • platform/graphics/gpu/DrawingBuffer.cpp: (WebCore::DrawingBuffer::clear):

Avoid clearing the m_context pointer in reset() - we destroy the DrawingBuffer whenever reset() fails, so
this is unnecessary.

2:21 PM Changeset in webkit [85660] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-03 Tony Chang <tony@chromium.org>

Unreviewed, rolling the version of chromium to r83922.

  • DEPS:
2:18 PM Changeset in webkit [85659] by dpranke@chromium.org
  • 5 edits in trunk/Tools

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Ojan Vafai.

new-run-webkit-tests: fix http server startup/shutdown

Previous versions of the code had three problems that made startup
and shutdown flaky. The first is that it would throw exceptions
if it couldn't delete stale log files, which was overly
paranoid. The second is that some of the exceptions weren't
defined properly. The third, and most important, is that it was
using urllib to check if ports were available, which was leaving
sockets in a half-closed state, and keeping ports from being
reused. By switching to raw sockets, we are able to now reliably
restart.

This change also switches the code to using Executives to stop
processes, which will let us delete a bunch of code in the
port/* implementations and fix a weird layering problem in a
subsequent patch.

https://bugs.webkit.org/show_bug.cgi?id=59977

  • Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server.py:
  • Scripts/webkitpy/layout_tests/port/http_server_base.py:
  • Scripts/webkitpy/layout_tests/port/websocket_server.py:
2:14 PM Changeset in webkit [85658] by dpranke@chromium.org
  • 2 edits in trunk/Tools

2011-05-03 Dirk Pranke <dpranke@chromium.org>

Reviewed by Adam Barth.

fix failing printing_unittest on win32
https://bugs.webkit.org/show_bug.cgi?id=59963

  • Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1:57 PM Changeset in webkit [85657] by caio.oliveira@openbossa.org
  • 2 edits
    1 add in trunk/Websites/bugs.webkit.org

2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Adam Roben.

Add tests to PrettyPatch
https://bugs.webkit.org/show_bug.cgi?id=57298

Verify that 'prettify' parse the right number of files and parts
(add/remove/shared) by checking a set of patches available in
bugs.webkit.org.

  • PrettyPatch/PrettyPatch.rb: exported a couple a globals with statistics information for our test script.
  • PrettyPatch/PrettyPatch_test.rb: Added.
1:55 PM Changeset in webkit [85656] by Adam Roben
  • 2 edits in trunk/Source/WebKit/win

Add some missing virtual keywords on derived-class destructors

Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".

  • WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and

WebInspectorFrontendClient destructors explicitly virtual.

1:54 PM Changeset in webkit [85655] by jeffm@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-03 Jeff Miller <jeffm@apple.com>

Reviewed by Darin Adler.

Unreachable URL is lost when canceling load of a new page
https://bugs.webkit.org/show_bug.cgi?id=60057
<rdar://problem/9049135>


When setting the unreachable URL in the WebFrameProxy, keep track of any previous unreachable URL
so we can restore it if the page load fails.

  • UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::didFailProvisionalLoad): Restore m_unreachableURL to previous value. (WebKit::WebFrameProxy::setUnreachableURL): Keep track of previous unreachable URL in m_lastUnreachableURL.
  • UIProcess/WebFrameProxy.h: Moved setUnreachableURL() implementation to .cpp file, added m_lastUnreachableURL.
1:51 PM Changeset in webkit [85654] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

store results.html options in localstorage
https://bugs.webkit.org/show_bug.cgi?id=60048

This makes options persistent per-domain. It's not perfect,
but it should make it possible to have preferences for how
people would like the results.html page to render.

  • fast/harness/resources/results-test.js:
  • fast/harness/results.html:
1:51 PM Changeset in webkit [85653] by Adam Roben
  • 20 edits in trunk

Fix most strict PassOwnPtr violations on Windows

Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled

Reviewed by Anders Carlsson.

Source/WebCore:

  • loader/EmptyClients.h:
  • platform/GeolocationService.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/mock/GeolocationServiceMock.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeSafari.cpp:

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now

that this type is put into a PassOwnPtr. (Previously, only
WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)

  • FullscreenVideoController.cpp:
  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebInspectorClient.cpp:
  • WebHistory.cpp:
  • WebHistoryItem.cpp:
  • WebView.cpp:

Source/WebKit2:

  • Platform/CoreIPC/win/ConnectionWin.cpp:

(CoreIPC::Connection::writeEventHandler): Use nullptr.

Tools:

  • WebKitAPITest/Test.h: Use adoptPtr.
1:49 PM Changeset in webkit [85652] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

Extract LineInfo class
https://bugs.webkit.org/show_bug.cgi?id=60044

Created a LineInfo class in RenderBlockLineLayout.cpp that brings together the relevant
layout information about a line. This simplifies function signatures and clears up initialization.

No new tests as this is refactoring.

  • rendering/RenderBlock.h: Updated internal layout function signatures to use LineInfo.
  • rendering/RenderBlockLineLayout.cpp: (WebCore::LineInfo::LineInfo): (WebCore::LineInfo::isFirstLine): (WebCore::LineInfo::isLastLine): (WebCore::LineInfo::isEmpty): (WebCore::LineInfo::previousLineBrokeCleanly): (WebCore::LineInfo::setFirstLine): (WebCore::LineInfo::setLastLine): (WebCore::LineInfo::setEmpty): (WebCore::LineInfo::setPreviousLineBrokeCleanly): (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeInlineDirectionPositionsForLine): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::skipNonBreakingSpace): (WebCore::shouldCollapseWhiteSpace): (WebCore::requiresLineBox): Moved from RenderBlock.h and made it locally scoped to RenderBlockLineLayout.cpp (WebCore::RenderBlock::generatesLineBoxesForInlineChild): (WebCore::RenderBlock::skipTrailingWhitespace): (WebCore::RenderBlock::skipLeadingWhitespace): (WebCore::RenderBlock::findNextLineBreak):
1:39 PM Changeset in webkit [85651] by leandro@webkit.org
  • 4 edits in trunk

2011-05-03 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

Force linking with zlib so that uncompress() exists.

  • Source/cmake/OptionsEfl.cmake: Find zlib.

2011-05-03 Leandro Pereira <leandro@profusion.mobi>

[EFL] Unreviewed build fix for NETWORK_BACKEND=curl.

Force linking with zlib so that uncompress() exists.

  • CMakeListsEfl.txt: Append zlib libraries.
1:35 PM Changeset in webkit [85650] by rolandsteiner@chromium.org
  • 5 edits in trunk/Source/WebCore

2011-05-03 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Update node list cache count on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59983

Change code to call add/removeNodeListCache() and hasNodeListCaches() on the proper tree scope.
Move updating of the node list cache count from setDocument() to setTreeScopeRecursively().
Make setDocument() and setDocumentRecursively() private.

No new tests. (refactoring)

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::~Node): (WebCore::Node::setDocument): (WebCore::Node::setTreeScopeRecursively): (WebCore::Node::childNodes): (WebCore::Node::registerDynamicNodeList): (WebCore::Node::unregisterDynamicNodeList): (WebCore::Node::notifyLocalNodeListsAttributeChanged): (WebCore::Node::notifyLocalNodeListsChildrenChanged): (WebCore::Node::getElementsByTagName): (WebCore::Node::getElementsByTagNameNS): (WebCore::Node::getElementsByName): (WebCore::Node::getElementsByClassName):
  • dom/Node.h:
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::labels):
1:33 PM Changeset in webkit [85649] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Bundle trailingSpaceObject and trailingPositionedBoxes in findNextLineBreak as a class
https://bugs.webkit.org/show_bug.cgi?id=60046

Extracted TrailingObjects that encapsulates trailingSpaceObject and trailingPositionedBoxes.

  • rendering/RenderBlockLineLayout.cpp: (WebCore::TrailingObjects::TrailingObjects): (WebCore::TrailingObjects::setTrailingWhitespace): (WebCore::TrailingObjects::clear): (WebCore::TrailingObjects::appendBoxIfNeeded): (WebCore::TrailingObjects::addMidpoints): (WebCore::RenderBlock::findNextLineBreak):
1:29 PM Changeset in webkit [85648] by commit-queue@webkit.org
  • 9 edits
    2 copies
    3 adds in trunk

2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Implement initial support to DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58448

Remove data-transfer-items.html from Qt skipped tests and create an expected
result file for data-transfer-items.html test. The need to create a expected result
file is because the test presuppose that the type of the first element in
DataTransferItems list is a html but when Qt selects a data, it first copies a text
and then it copies the html, so for Qt expected test file the first element is a
text and the second one is a html.

  • platform/qt/Skipped:
  • platform/qt/editing/pasteboard/data-transfer-items-expected.txt: Added.

2011-05-03 Igor Oliveira <igor.oliveira@openbossa.org>

Reviewed by Eric Seidel.

[Qt] Implement initial support to DataTransferItems
https://bugs.webkit.org/show_bug.cgi?id=58448

Implement initial support to DataTransferItems. DataTransferItems are used to
hold data for drag and drop operations. DataTransferItems hold a list of
DataTransferItem objects each of which holds an item being dragged.

  • WebCore.pro:
  • dom/DataTransferItems.idl:
  • editing/qt/EditorQt.cpp: (WebCore::Editor::newGeneralClipboard):
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/chromium/DataTransferItemsChromium.h:
  • platform/qt/ClipboardQt.cpp: (WebCore::Clipboard::create): (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::items):
  • platform/qt/ClipboardQt.h: (WebCore::ClipboardQt::create):
  • platform/qt/DataTransferItemQt.cpp: Added. (WebCore::DataTransferItem::create): (WebCore::DataTransferItemQt::createFromPasteboard): (WebCore::DataTransferItemQt::create): (WebCore::DataTransferItemQt::DataTransferItemQt): (WebCore::DataTransferItemQt::getAsString): (WebCore::DataTransferItemQt::getAsFile):
  • platform/qt/DataTransferItemQt.h: Added.
  • platform/qt/DataTransferItemsQt.cpp: Copied from Source/WebCore/editing/qt/EditorQt.cpp. (WebCore::DataTransferItemsQt::create): (WebCore::DataTransferItemsQt::DataTransferItemsQt): (WebCore::DataTransferItemsQt::addPasteboardItem):
  • platform/qt/DataTransferItemsQt.h: Copied from Source/WebCore/editing/qt/EditorQt.cpp.
1:22 PM Changeset in webkit [85647] by caio.oliveira@openbossa.org
  • 2 edits in trunk/Tools

2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>

Reviewed by Andreas Kling.

Add myself to the committers list.

  • Scripts/webkitpy/common/config/committers.py:
1:16 PM Changeset in webkit [85646] by hclam@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

new baseline for SVG test.

  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Added.
1:11 PM Changeset in webkit [85645] by hclam@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

New baseline for GPU layout tests.

  • platform/chromium-gpu-mac/animations/3d/matrix-transform-type-animation-expected.png: Added.
  • platform/chromium-gpu-mac/animations/3d/state-at-end-event-transform-expected.png: Added.
1:08 PM Changeset in webkit [85644] by commit-queue@webkit.org
  • 17 edits in trunk/Source

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

No new tests, refactoring only.

  • dom/Element.cpp: (WebCore::Element::copyNonAttributeProperties): (WebCore::Element::insertedIntoDocument): (WebCore::Element::removedFromDocument): (WebCore::Element::insertedIntoTree): (WebCore::Element::removedFromTree): (WebCore::Element::attach): (WebCore::Element::detach): (WebCore::Element::recalcStyle): (WebCore::Element::shadowRoot): (WebCore::Element::ensureShadowRoot): (WebCore::Element::childrenChanged):
  • dom/Node.cpp: (WebCore::Node::setTreeScopeRecursively): (WebCore::shadowRoot): (WebCore::Node::setDocumentRecursively): (WebCore::NodeRendererFactory::findVisualParent): Updated all the call sites for shadowRoot and ensureShadowRoot in the 2 previous classes.
  • dom/Element.h: Updated 2 methods' signature to return a ShadowRoot*.
  • dom/ShadowRoot.h: Removed toShadowRoot as it is not used anymore.
  • html/HTMLDetailsElement.cpp:
  • html/HTMLSummaryElement.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

  • src/WebElement.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

  • DOM/WebDOMOperations.mm: Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::shadowRoot): Added #include for ShadowRoot.h.

2011-05-03 Julien Chaffraix <jchaffraix@codeaurora.org>

Reviewed by Dimitri Glazkov.

Element:shadowRoot & Element::ensureShadowRoot should return ShadowRoot*
https://bugs.webkit.org/show_bug.cgi?id=58703

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Added #include for ShadowRoot.h.
1:07 PM Changeset in webkit [85643] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

2011-05-03 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement mediaSliderTrack
https://bugs.webkit.org/show_bug.cgi?id=59998

Implement paintMediaSliderTrack.

  • platform/efl/RenderThemeEfl.cpp: (WebCore::RenderThemeEfl::RenderThemeEfl): (WebCore::RenderThemeEfl::paintMediaSliderTrack):
  • platform/efl/RenderThemeEfl.h:
1:03 PM Changeset in webkit [85642] by mnaganov@chromium.org
  • 4 edits in trunk/Source/WebCore

2011-05-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Fix slowness of Summary view nodes expansion in detailed heap profiles.
https://bugs.webkit.org/show_bug.cgi?id=60023

  • inspector/front-end/DetailedHeapshotGridNodes.js: (WebInspector.HeapSnapshotConstructorNode): (WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
  • inspector/front-end/HeapSnapshot.js: (WebInspector.HeapSnapshot.prototype.dispose): (WebInspector.HeapSnapshot.prototype.aggregates): (WebInspector.HeapSnapshot.prototype._buildAggregates): (WebInspector.HeapSnapshot.prototype._sortAggregateIndexes): (WebInspector.HeapSnapshot.prototype.createNodesProviderForClass): (WebInspector.HeapSnapshotFilteredOrderedIterator): (WebInspector.HeapSnapshotNodesProvider):
  • inspector/front-end/HeapSnapshotProxy.js: (WebInspector.HeapSnapshotProxy.prototype.aggregates): (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForClass):
12:52 PM Changeset in webkit [85641] by mnaganov@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-03 Mikhail Naganov <mnaganov@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: [Chromium] Hint user that to display retaining paths, an object entry must be clicked.
https://bugs.webkit.org/show_bug.cgi?id=60029

  • English.lproj/localizedStrings.js:
  • inspector/front-end/DetailedHeapshotView.js: (WebInspector.HeapSnapshotRetainingPathsList.prototype.reset): (WebInspector.DetailedHeapshotView.prototype._mouseClickInContainmentGrid):
12:51 PM Changeset in webkit [85640] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/qt

2011-05-03 Keith Kyzivat <keith.kyzivat@nokia.com>

Reviewed by Andreas Kling.

[Qt] QtDeclarative Webview element has a fixed white background
https://bugs.webkit.org/show_bug.cgi?id=40918

QProperty REVISION feature is not present in certain Qt Trunk clones.
These builds report their version as 4.8.0, and therefore break on the
prior #if QT_VERSION >= 0x040704. The proper fix is to check based on
the existance of Q_REVISION.

  • declarative/plugin.cpp: (WebKitQmlPlugin::registerTypes):
  • declarative/qdeclarativewebview.cpp:
  • declarative/qdeclarativewebview_p.h:
12:50 PM Changeset in webkit [85639] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, skipping test timing out in the GTK 64-bit bot.

  • platform/gtk/Skipped: Skipped media/video-volume-slider.html.
12:47 PM Changeset in webkit [85638] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

improve styling of options menu in results.html file

  • fast/harness/results.html:
12:42 PM Changeset in webkit [85637] by hclam@chromium.org
  • 2 edits
    3 adds in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

New baseline and add test expectation to suppress failure.

  • platform/chromium-gpu-win/animations/3d/replace-filling-transform-expected.png: Added.
  • platform/chromium/test_expectations.txt:
12:34 PM Changeset in webkit [85636] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

Don't include the test itself in expanded test results
https://bugs.webkit.org/show_bug.cgi?id=60051

When loading from local disk, we can't force it to render as
plain text, which causes the page to actually run. Also,
the extra clutter of another iframe is probably not worth it.

If we decide we want this later, we can add it back in as a
preference that's off by default.

  • fast/harness/results.html:
12:31 PM Changeset in webkit [85635] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectation for a slow test to avoid flakiness.

  • platform/chromium/test_expectations.txt:
12:25 PM Changeset in webkit [85634] by ojan@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Fix test that broke after adding CSS animations.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
12:19 PM Changeset in webkit [85633] by ojan@chromium.org
  • 4 edits in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adding test expectations for some SVG tests on Windows.

  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
12:17 PM Changeset in webkit [85632] by hclam@chromium.org
  • 4 edits
    5 adds
    1 delete in trunk/LayoutTests

2011-05-03 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adding test expectations for some SVG tests on Windows.

  • platform/chromium-win-vista/svg/text/text-fonts-01-t-expected.png: Removed.
  • platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win-xp/svg/text/text-intro-05-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.png: Added.
  • platform/chromium-win/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/chromium-win/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-win/svg/text/text-intro-05-t-expected.txt:
  • platform/chromium/test_expectations.txt:
12:11 PM Changeset in webkit [85631] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-03 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursor update updates indexes
https://bugs.webkit.org/show_bug.cgi?id=59995

This test creates an object store, adds both a unique and a non-unique index,
adds a record, opens a cursor, changes the record, and verifies that both
indexes correctly updated to reflect the modified record.

  • storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt: Added.
  • storage/indexeddb/mozilla/cursor-update-updates-indexes.html: Added.
11:45 AM Changeset in webkit [85630] by jamesr@google.com
  • 2 edits in trunk/LayoutTests

2011-05-03 James Robinson <jamesr@chromium.org>

Remove stale expectations for animations/3d in chromium test_expectations.txt

  • platform/chromium/test_expectations.txt:
11:45 AM Changeset in webkit [85629] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=60045
Scrollbar thumb sometimes leaves artifacts in the track after scrolling
-and corresponding-
<rdar://problem/9015376>

Reviewed by Dan Bernstein.

When we're using WK_SCROLLBAR_PAINTER, the AppleScrollBarVariant default should
always be ignored.

  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::updateArrowPlacement):

11:43 AM Changeset in webkit [85628] by jamesr@google.com
  • 4 edits in trunk

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Layout test animations/3d/replace-filling-transform.html failing
https://bugs.webkit.org/show_bug.cgi?id=59839

Ignore animations/3d when run in CPU mode as these are compositor tests.

  • platform/chromium/test_expectations.txt:

2011-05-03 James Robinson <jamesr@chromium.org>

Reviewed by Kenneth Russell.

[chromium] Layout test animations/3d/replace-filling-transform.html failing
https://bugs.webkit.org/show_bug.cgi?id=59839

Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.

  • Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
11:42 AM Changeset in webkit [85627] by Dimitri Glazkov
  • 3 edits
    2 copies in branches/chromium/696

Merge 84270 - 2011-04-19 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
https://bugs.webkit.org/show_bug.cgi?id=58419

Added new test for cross-iframe focus changes on plugin clicks.

  • plugins/mouse-click-iframe-to-plugin-expected.txt: Added.
  • plugins/mouse-click-iframe-to-plugin.html: Added.

2011-04-19 Stuart Morgan <stuartmorgan@chromium.org>

Reviewed by Tony Chang.

[chromium] Clicking on plugin for first time blocks focus shift
https://bugs.webkit.org/show_bug.cgi?id=58419

Switched to using FocusController when moving focus to a plugin
so that cross-frame focus changes are handled correctly.

  • src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleMouseEvent):

TBR=commit-queue@webkit.org

11:18 AM Changeset in webkit [85626] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

make pixel zooming in results.html file less jarring
https://bugs.webkit.org/show_bug.cgi?id=60038

-Hide zoomed images when you mouse out of the document or
mouseover an iframe.
-Handle the case where the zoomed images overlap the actual images.

  • fast/harness/results.html:
11:15 AM Changeset in webkit [85625] by demarchi@webkit.org
  • 2 edits in trunk/Tools

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

Unreviewed, rolling out r85471.
http://trac.webkit.org/changeset/85471
https://bugs.webkit.org/show_bug.cgi?id=59922

The rule of thumb in EFL is that you init in all the places
you use it. So, if in your application you call ecore_evas_*
functions, you have to call ecore_evas_init() first.

  • EWebLauncher/main.c: always call *_init() functions when you use that namespace. (quit): (main):
11:10 AM Changeset in webkit [85624] by demarchi@webkit.org
  • 2 edits in trunk

2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>

[CMAKE] Unreviewed build fix for gcc >= 4.6

Same fix as done in r84123. CMake explicitly pass the arguments to
make_names.pl, so let's make them the same.

  • Source/cmake/OptionsCommon.cmake: ditto.
11:00 AM Changeset in webkit [85623] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=60040
<rdar://problem/9261591>

Reviewed by Dan Bernstein.

Links broken at iplanwebsites.com. Make sure that culledInlineAbsoluteQuads still does
a translation of a 0,0 point to absolute coordinates so that the top left position is
accurate.

Source/WebCore:

Added fast/inline/skipped-whitespace-client-rect.html

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::culledInlineAbsoluteQuads):

LayoutTests:

Added fast/inline/skipped-whitespace-client-rect.html

  • fast/inline/skipped-whitespace-client-rect-expected.txt: Added.
  • fast/inline/skipped-whitespace-client-rect.html: Added.
10:43 AM Changeset in webkit [85622] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

More quarantine related sandbox denial when downloading files
<rdar://problem/9362626>

Reviewed by Anders Carlsson.

  • WebProcess/com.apple.WebProcess.sb:
10:34 AM Changeset in webkit [85621] by alexis.menard@openbossa.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-03 Xan Lopez <xlopez@igalia.com>

Reviewed by Anders Carlsson.

Compile error with GCC 4.6.0, tries to assign unsigned& to bitfield
https://bugs.webkit.org/show_bug.cgi?id=59261

Use unary '+' to force proper type detection in template arguments
with GCC 4.6.0. See bug report for more details.

  • runtime/Structure.cpp: (JSC::StructureTransitionTable::remove): Use '+' to force precise type detection. (JSC::StructureTransitionTable::add): ditto.
  • runtime/Structure.h: (JSC::StructureTransitionTable::keyForWeakGCMapFinalizer): ditto.
10:27 AM Changeset in webkit [85620] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium build.

  • page/Settings.cpp:
10:20 AM Changeset in webkit [85619] by rolandsteiner@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-02 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 59974 - Update image map on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59974

No new tests. (reefactoring)

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute): (WebCore::HTMLMapElement::insertedIntoDocument): (WebCore::HTMLMapElement::removedFromDocument):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageMap):
10:18 AM Changeset in webkit [85618] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium build.

  • loader/HistoryController.cpp:
10:17 AM Changeset in webkit [85617] by rolandsteiner@chromium.org
  • 25 edits in trunk/Source/WebCore

2011-05-02 Roland Steiner <rolandsteiner@chromium.org>

Reviewed by Dimitri Glazkov.

Bug 59966 - Update ID hash on the containing TreeScope rather than the Document
https://bugs.webkit.org/show_bug.cgi?id=59966

No new tests. (refactoring)

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::elementsFromAttribute): (WebCore::AccessibilityRenderObject::activeDescendant):
  • accessibility/AccessibilityRenderObject.h: (WebCore::AccessibilityRenderObject::isAccessibilityRenderObject):
  • css/CSSCursorImageValue.cpp: (WebCore::resourceReferencedByCursorElement): (WebCore::CSSCursorImageValue::~CSSCursorImageValue): (WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed): (WebCore::CSSCursorImageValue::cachedImage):
  • dom/DynamicNodeList.cpp: (WebCore::DynamicNodeList::itemWithName):
  • dom/Element.h: (WebCore::Element::updateId):
  • dom/Node.cpp: (WebCore::Node::querySelector):
  • html/FormAssociatedElement.cpp: (WebCore::FormAssociatedElement::insertedIntoTree): (WebCore::FormAssociatedElement::resetFormOwner):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dataList):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::control):
  • rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::layoutPath):
  • svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
  • svg/SVGAltGlyphElement.cpp: (WebCore::SVGAltGlyphElement::glyphElement):
  • svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::requestImageResource): (WebCore::SVGFEImageElement::build):
  • svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes):
  • svg/SVGMPathElement.cpp: (WebCore::SVGMPathElement::pathElement):
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternAttributes):
  • svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getElementById):
  • svg/SVGTRefElement.cpp: (WebCore::SVGTRefElement::updateReferencedText):
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::insertedIntoDocument):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::buildPendingResource): (WebCore::SVGUseElement::hasCycleUseReferencing): (WebCore::SVGUseElement::expandUseElementsInShadowTree):
  • svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::viewTarget):
  • svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::eventBaseFor): (WebCore::SVGSMILElement::connectConditions): (WebCore::SVGSMILElement::targetElement):
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunId::evaluate):
10:14 AM Changeset in webkit [85616] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix chromium build.

  • css/StyleMedia.cpp:
10:11 AM Changeset in webkit [85615] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Prune #includes from FrameView.h (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=59957

Reviewed by Anders Carlsson.

  • page/FrameView.h:

Prune #includes.

  • accessibility/chromium/AXObjectCacheChromium.cpp:
  • page/win/FrameCGWin.cpp:
  • platform/Scrollbar.cpp:

Add not necessary #includes.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:

Add now necessary forward declaration.

9:45 AM Changeset in webkit [85614] by ojan@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Ojan Vafai <ojan@chromium.org>

Fix test accidentally modified in http://trac.webkit.org/changeset/85610.

  • fullscreen/full-screen-zIndex.html:
9:42 AM Changeset in webkit [85613] by Dimitri Glazkov
  • 5 edits in branches/chromium/742

Merge 84587 - 2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053

  • fast/events/shadow-boundary-crossing-expected.txt: Updated expected results.
  • fast/events/shadow-boundary-crossing.html: Added new sub-test.

2011-04-21 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Adele Peterson.

REGRESSION (r83386): Typing in WSJ.com search field doesn't clear placeholder text
https://bugs.webkit.org/show_bug.cgi?id=59053

Turns out, the relatedTarget of an event could be also an ancestor of an event,
not just its parent. Duh.

  • dom/EventDispatcher.cpp: (WebCore::EventDispatcher::adjustToShadowBoundaries): Changed to use shadowHost

explicitly.

TBR=Dimitri Glazkov
Review URL: http://codereview.chromium.org/6914018

9:39 AM Changeset in webkit [85612] by ojan@chromium.org
  • 3 edits in trunk/Tools

2011-05-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

remove no longer used method
https://bugs.webkit.org/show_bug.cgi?id=59981

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
9:33 AM Changeset in webkit [85611] by ddkilzer@apple.com
  • 3 edits in trunk/WebKitLibraries

Part 1 of 2: <http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
<rdar://problem/8924448>

Reviewed by Adam Roben.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:

(wkGetHTTPPipeliningPriority): Added declaration.
(wkSetHTTPPipeliningMaximumPriority): Added declaration.
(wkSetHTTPPipeliningPriority): Added declaration.

  • win/lib/WebKitSystemInterface.lib: Updated.
9:30 AM Changeset in webkit [85610] by ojan@chromium.org
  • 7 edits in trunk

2011-05-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

add image toggling behavior from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59978

Add a checkbox to switch between image toggling (default)
and just showing results for expected/actual images.

  • fast/harness/resources/results-test.js:
  • fast/harness/results-expected.txt:
  • fast/harness/results.html:

2011-05-02 Ojan Vafai <ojan@chromium.org>

Reviewed by Tony Chang.

add image toggling behavior from old-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59978

Output -diffs.html files. This matches old-run-webkit-tests.
In theory, we could use data urls in the results.html file, but
data urls don't currently have access to local files.

  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
9:25 AM Changeset in webkit [85609] by tony@chromium.org
  • 7 edits in trunk/Tools

2011-05-02 Tony Chang <tony@chromium.org>

Reviewed by Ojan Vafai.

[nrwt] remove some obsolete references to .checksum files
https://bugs.webkit.org/show_bug.cgi?id=59971

  • Scripts/webkitpy/layout_tests/layout_package/printing.py:
  • Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  • Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  • Scripts/webkitpy/layout_tests/port/test.py:
  • Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
9:22 AM Changeset in webkit [85608] by satish@chromium.org
  • 7 edits
    1 delete in trunk/LayoutTests

2011-05-03 Satish Sampath <satish@chromium.org>

Unreviewed, update test expectations for chromium.

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.txt: Removed.
9:21 AM Changeset in webkit [85607] by adamk@chromium.org
  • 4 edits in trunk

2011-05-02 Adam Klein <adamk@chromium.org>

Reviewed by Tony Chang.

Roll chromium DEPS to r83722, add new crypto directory to DEPS
https://bugs.webkit.org/show_bug.cgi?id=59992

  • .gitignore: Ignore new chromium/crypto directory.

2011-05-02 Adam Klein <adamk@chromium.org>

Reviewed by Tony Chang.

Roll chromium DEPS to r83722, add new crypto directory to DEPS
https://bugs.webkit.org/show_bug.cgi?id=59992

  • DEPS:
9:18 AM Changeset in webkit [85606] by caseq@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Andrey Kosyakov <caseq@chromium.org>

Reviewed by Dimitri Glazkov.

[Chromium] toV8(Node*) will enter infinite recursion when called with a node of type SHADOW_ROOT_NODE
https://bugs.webkit.org/show_bug.cgi?id=60026

Return a wrapper for Node in toV8(Node*) when called with a node of type
SHADOW_ROOT_NODE instead of entering infinite recursion.

  • bindings/v8/custom/V8NodeCustom.cpp: (WebCore::toV8Slow):
8:41 AM Changeset in webkit [85605] by jberlin@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Revert r85550 and r85575.

Rubber-stamped by Adam Roben.

Variables cannot be exported via the .def file. Instead, they should be annotated with
JS_EXPORTDATA.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):

  • runtime/Structure.h:

(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

8:14 AM April 2011 Meeting edited by vestbo@webkit.org
(diff)
8:05 AM Changeset in webkit [85604] by satish@chromium.org
  • 12 edits in trunk/LayoutTests

2011-05-03 Satish Sampath <satish@chromium.org>

Reviewed by Tony Gentilcore.

Rebaseline speech input layout test expectations for chromium.
https://bugs.webkit.org/show_bug.cgi?id=59742

  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-searchandspeech-expected.txt:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-linux/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-searchandspeech-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.png:
  • platform/chromium-mac/fast/speech/input-appearance-speechbutton-expected.txt:
  • platform/chromium/test_expectations.txt:
6:54 AM Changeset in webkit [85603] by Adam Roben
  • 43 edits in trunk

Allow implicit conversion from nullptr_t to PassOwnPtr

This makes it a lot easier to write code that just wants a null PassOwnPtr, especially in
strict PassOwnPtr mode.

Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
doesn't work, but should

Reviewed by Adam Barth.

Source/JavaScriptCore:

  • wtf/PassOwnPtr.h:

(WTF::PassOwnPtr::PassOwnPtr): Added a non-explicit constructor that takes a nullptr_t.

  • wtf/MessageQueue.h:

(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):
Use the new implicit conversion.

Source/WebCore:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • bindings/js/ScheduledAction.cpp:
  • css/CSSStyleSelector.cpp:
  • css/MediaList.cpp:
  • css/MediaQueryMatcher.cpp:
  • css/SVGCSSStyleSelector.cpp:
  • dom/MessagePort.cpp:
  • html/InputType.cpp:
  • html/canvas/WebGLRenderingContext.cpp:
  • inspector/InspectorStyleSheet.cpp:
  • page/ContextMenuController.cpp:
  • page/Page.cpp:
  • platform/PlatformGestureRecognizer.cpp:
  • platform/PurgeableBuffer.h:
  • platform/graphics/ImageBuffer.h:
  • platform/leveldb/LevelDBDatabase.cpp:
  • platform/mac/PurgeableBufferMac.cpp:
  • platform/text/RegularExpression.cpp:
  • rendering/RenderTheme.cpp:
  • rendering/RenderThemeMac.mm:
  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp:
  • rendering/style/ShadowData.cpp:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/svg/RenderSVGResourcePattern.cpp:

Source/WebKit/chromium:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • src/WebMediaPlayerClientImpl.cpp:

Source/WebKit/mac:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • History/WebHistory.mm:
  • Plugins/WebNetscapePluginEventHandler.mm:
  • WebView/WebView.mm:

Source/WebKit2:

Take advantage of implicit conversion from nullptr_t to PassOwnPtr

  • Platform/CoreIPC/Connection.cpp:
  • UIProcess/qt/WebContextMenuProxyQt.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/WebPage/DrawingArea.cpp:

Tools:

Take advantage of implicit nullptr_t -> PassOwnPtr conversion

  • DumpRenderTree/chromium/CppBoundClass.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
6:37 AM Changeset in webkit [85602] by apavlov@chromium.org
  • 2 edits in branches/chromium/742/Source/WebCore/inspector/front-end

Merge 85415 - 2011-05-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: address stack frame scriptName -> url rename in timeline panel.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

TBR=pfeldman@chromium.org
Review URL: http://codereview.chromium.org/6914017

6:25 AM Changeset in webkit [85601] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: fix inspector status bar image glyph reference in network panel.

  • inspector/front-end/networkPanel.css: (.network-larger-resources-status-bar-item .glyph):
6:11 AM Changeset in webkit [85600] by yurys@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Unreviewed. Provide Chromium test expectaions for new test.

  • platform/chromium/inspector/console/console-log-document-proto-expected.txt: Added.
6:10 AM Changeset in webkit [85599] by pfeldman@chromium.org
  • 3 edits in trunk/LayoutTests

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: rebaseline inspector test.

  • inspector/storage-panel-dom-storage-expected.txt:
  • inspector/storage-panel-dom-storage.html:
6:02 AM Changeset in webkit [85598] by rgabor@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Add failing tests to ARM specific Skipped list

Rubber-stamped by Csaba Osztrogonác.

  • platform/qt-arm/Skipped:
5:56 AM Changeset in webkit [85597] by pfeldman@chromium.org
  • 7 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: rename BrowserDebugger agent to DOMDebugger.
https://bugs.webkit.org/show_bug.cgi?id=60019

  • inspector/CodeGeneratorInspector.pm:
  • inspector/Inspector.json:
  • inspector/InspectorController.cpp: (WebCore::InspectorController::connectFrontend):
  • inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.XHRBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._removeBreakpoint): (WebInspector.XHRBreakpointsSidebarPane.prototype._checkboxClicked): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._setBreakpoint): (WebInspector.EventListenerBreakpointsSidebarPane.prototype._removeBreakpoint):
  • inspector/generate-inspector-idl:
5:48 AM Changeset in webkit [85596] by yurys@chromium.org
  • 5 edits
    2 adds in trunk

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove special logic for type of document.proto
https://bugs.webkit.org/show_bug.cgi?id=60014

  • inspector/console/console-log-document-proto-expected.txt: Added.
  • inspector/console/console-log-document-proto.html: Added.
  • inspector/console/console-log-toString-object-expected.txt:
  • inspector/console/console-log-toString-object.html:

2011-05-03 Yury Semikhatsky <yurys@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: remove special logic for type of document.proto
https://bugs.webkit.org/show_bug.cgi?id=60014

Test: inspector/console/console-log-document-proto.html

  • inspector/InjectedScriptSource.js: removed unnecessary check nodeType === undefined
2:53 AM Changeset in webkit [85595] by Carlos Garcia Campos
  • 5 edits in trunk

2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Eric Seidel.

[GTK] Build webkit1 even when webkit2 is enabled
https://bugs.webkit.org/show_bug.cgi?id=59695

  • GNUmakefile.am:
  • configure.ac:

2011-05-03 Carlos Garcia Campos <cgarcia@igalia.com>

Reviewed by Eric Seidel.

[GTK] Build webkit1 even when webkit2 is enabled
https://bugs.webkit.org/show_bug.cgi?id=59695

  • GNUmakefile.am:
2:30 AM Changeset in webkit [85594] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-03 Philippe Normand <pnormand@igalia.com>

Unreviewed, unskip now passing test.

[GTK] media/video-controls-transformed.html fails
https://bugs.webkit.org/show_bug.cgi?id=50706

  • platform/gtk/Skipped:
2:17 AM Changeset in webkit [85593] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: fixed typo in inspector style.

  • inspector/front-end/inspector.css: (.status-bar-item > .glyph):
2:13 AM Changeset in webkit [85592] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-03 Pavel Feldman <pfeldman@google.com>

Not reviewed: re-applied r85589.

  • src/js/DevTools.js: (.WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
2:01 AM Changeset in webkit [85591] by pfeldman@chromium.org
  • 4 edits in trunk/Source

2011-05-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: revision history storage is too slow.
https://bugs.webkit.org/show_bug.cgi?id=59939

It turns out that iterating localStorage keys is very
expensive (results in slow inspector start), refactor revision
history in order not to rely upon that operation.

1:55 AM Changeset in webkit [85590] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

2011-05-03 Mario Sanchez Prada <msanchez@igalia.com>

Unreviewed, needed rebaseline after revision r85499.

  • platform/gtk/fast/replaced/table-percent-height-expected.txt:
1:00 AM Changeset in webkit [85589] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-03 Pavel Feldman <pfeldman@google.com>

Reviewed by Yury Semikhatsky.

Web Inspector: [remote debugging] use document.title to set window name.
https://bugs.webkit.org/show_bug.cgi?id=60012

  • src/js/DevTools.js: (WebInspector.InspectorFrontendHostStub.prototype.inspectedURLChanged):
12:54 AM Changeset in webkit [85588] by pfeldman@chromium.org
  • 6 edits
    2 adds
    8 deletes in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: combine toolbar icon images.
https://bugs.webkit.org/show_bug.cgi?id=59931

  • WebCore.gypi:
  • inspector/front-end/Images/auditsIcon.png: Removed.
  • inspector/front-end/Images/consoleIcon.png: Removed.
  • inspector/front-end/Images/elementsIcon.png: Removed.
  • inspector/front-end/Images/networkIcon.png: Removed.
  • inspector/front-end/Images/profilesIcon.png: Removed.
  • inspector/front-end/Images/resourcesIcon.png: Removed.
  • inspector/front-end/Images/scriptsIcon.png: Removed.
  • inspector/front-end/Images/timelineIcon.png: Removed.
  • inspector/front-end/Images/toolbarIcons.png: Added.
  • inspector/front-end/Images/toolbarIconsSmall.png: Added.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.toolbar-icon): (#toolbar-dropdown .toolbar-icon): (.toolbar-item:active .toolbar-icon): (#toolbar-dropdown .toolbar-item:active .toolbar-icon): (.toolbar-item.elements .toolbar-icon): (.toolbar-item.resources .toolbar-icon): (#toolbar-dropdown .toolbar-item.resources .toolbar-icon): (.toolbar-item.network .toolbar-icon): (#toolbar-dropdown .toolbar-item.network .toolbar-icon): (.toolbar-item.scripts .toolbar-icon): (#toolbar-dropdown .toolbar-item.scripts .toolbar-icon): (.toolbar-item.timeline .toolbar-icon): (#toolbar-dropdown .toolbar-item.timeline .toolbar-icon): (.toolbar-item.profiles .toolbar-icon): (#toolbar-dropdown .toolbar-item.profiles .toolbar-icon): (.toolbar-item.audits .toolbar-icon): (#toolbar-dropdown .toolbar-item.audits .toolbar-icon): (.toolbar-item.console .toolbar-icon): (#toolbar-dropdown .toolbar-item.console .toolbar-icon): (.status-bar-item > .glyph):
12:52 AM Changeset in webkit [85587] by pfeldman@chromium.org
  • 5 edits
    1 add
    21 deletes in trunk/Source/WebCore

2011-05-03 Pavel Feldman <pfeldman@chromium.org>

Reviewed by Yury Semikhatsky.

Web Inspector: combine status bar button glyphs.
https://bugs.webkit.org/show_bug.cgi?id=59885

  • WebCore.gypi:
  • inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Removed.
  • inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Removed.
  • inspector/front-end/Images/clearConsoleButtonGlyph.png: Removed.
  • inspector/front-end/Images/consoleButtonGlyph.png: Removed.
  • inspector/front-end/Images/dockButtonGlyph.png: Removed.
  • inspector/front-end/Images/enableOutlineButtonGlyph.png: Removed.
  • inspector/front-end/Images/enableSolidButtonGlyph.png: Removed.
  • inspector/front-end/Images/excludeButtonGlyph.png: Removed.
  • inspector/front-end/Images/focusButtonGlyph.png: Removed.
  • inspector/front-end/Images/garbageCollectButtonGlyph.png: Removed.
  • inspector/front-end/Images/gearButtonGlyph.png: Removed.
  • inspector/front-end/Images/helpButtonGlyph.png: Removed.
  • inspector/front-end/Images/largerResourcesButtonGlyph.png: Removed.
  • inspector/front-end/Images/nodeSearchButtonGlyph.png: Removed.
  • inspector/front-end/Images/pauseOnExceptionButtonGlyph.png: Removed.
  • inspector/front-end/Images/percentButtonGlyph.png: Removed.
  • inspector/front-end/Images/prettyPrintButtonGlyph.png: Removed.
  • inspector/front-end/Images/recordButtonGlyph.png: Removed.
  • inspector/front-end/Images/recordToggledButtonGlyph.png: Removed.
  • inspector/front-end/Images/reloadButtonGlyph.png: Removed.
  • inspector/front-end/Images/statusBarButtonGlyphs.png: Added.
  • inspector/front-end/Images/undockButtonGlyph.png: Removed.
  • inspector/front-end/WebKit.qrc:
  • inspector/front-end/inspector.css: (.status-bar-item > .glyph): (#dock-status-bar-item .glyph): (body.detached #dock-status-bar-item .glyph): (#console-status-bar-item .glyph): (.clear-status-bar-item .glyph): (button.enable-toggle-status-bar-item .glyph): (button.enable-toggle-status-bar-item.toggled-on .glyph): (.scripts-pause-on-exceptions-status-bar-item .glyph): (.scripts-toggle-pretty-print-status-bar-item .glyph): (.toggle-breakpoints .glyph): (.toggle-breakpoints.toggled-on .glyph): (.resources-larger-resources-status-bar-item .glyph): (.timeline-filter-status-bar-item .glyph): (.garbage-collect-status-bar-item .glyph): (.record-profile-status-bar-item .glyph): (.record-profile-status-bar-item.toggled-on .glyph): (.heap-snapshot-status-bar-item .glyph): (.node-search-status-bar-item .glyph): (.percent-time-status-bar-item .glyph): (.focus-profile-node-status-bar-item .glyph): (.exclude-profile-node-status-bar-item .glyph): (.reset-profile-status-bar-item .glyph): (.delete-storage-status-bar-item .glyph): (.refresh-storage-status-bar-item .glyph):
  • inspector/front-end/inspector.js:

May 2, 2011:

11:04 PM Changeset in webkit [85586] by Simon Fraser
  • 3 edits
    2 adds in trunk

2011-05-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Possible crash when removing elements with reflections
https://bugs.webkit.org/show_bug.cgi?id=60009

RenderLayer's destructor deleted its z-order list Vector pointers
before removing the reflection layer. However, the reflection cleanup
code could call back into the RenderLayer to dirty z-order lists,
so move reflection cleanup to before z-order vector deletion.

The test crashes when run manually a few times with MallocScribble enabled,
but I was not able to create a test that crashed reliably.

Test: fast/reflections/remove-reflection-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
10:07 PM Changeset in webkit [85585] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

2011-05-02 Ian Henderson <ianh@apple.com>

Reviewed by Dan Bernstein.

CSS !important not respected by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=60007

  • fast/css/important-js-override-expected.txt: Added.
  • fast/css/important-js-override.html: Added.

2011-05-02 Ian Henderson <ianh@apple.com>

Reviewed by Dan Bernstein.

CSS !important not respected by JavaScript
https://bugs.webkit.org/show_bug.cgi?id=60007

The addParsedProperty and addParsedProperties methods were subtly
different. The former did not check for !important before setting the
given property.

Change addParsedProperties to call addParsedProperty and move the
relevant code. The one other caller of this method, in
editing/markup.cpp, probably wanted this behavior anyway.

Test: fast/css/important-js-override.html

  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::addParsedProperty):
10:02 PM Changeset in webkit [85584] by yael.aharon@nokia.com
  • 2 edits in trunk/Source/WebKit2

2011-05-02 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Andreas Kling.

[Qt] White screen displays when using MiniBrowser with DrawingAreaImpl
https://bugs.webkit.org/show_bug.cgi?id=60003

When using DrawingAreaImpl, we need to properly pass the viewSize to the WebPage.
Otherwise, the dirty rect will always be empty and we will not draw.

  • UIProcess/API/qt/qwkpage.cpp: (QWKPagePrivate::viewSize):
9:45 PM Changeset in webkit [85583] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] Compiler warning in Tools/MiniBrowser/main.c
https://bugs.webkit.org/show_bug.cgi?id=59986

Remove a compiler warning.

  • MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers from complaining.
9:03 PM Changeset in webkit [85582] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
9:03 PM Changeset in webkit [85581] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

2011-05-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>

Unreviewed. Style error fix.

  • WebCoreSupport/ChromeClientEfl.cpp:
8:57 PM Changeset in webkit [85580] by hclam@chromium.org
  • 1 edit
    28 adds in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

New baselines for SVG tests for Chromium Leopard build.

  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-mac-leopard/svg/filters/feLighting-crash-expected.png: Added.
  • platform/chromium-mac-leopard/tables/mozilla_expected_failures/other/test4-expected.png: Added.
8:54 PM Changeset in webkit [85579] by Dimitri Glazkov
  • 1 edit
    2 deletes in trunk/LayoutTests

2011-05-02 Dimitri Glazkov <Dimitri Glazkov>

Unreviewed, rolling out r85578.
http://trac.webkit.org/changeset/85578
https://bugs.webkit.org/show_bug.cgi?id=59976

The test needs more lovin'. Voluntary rollout.

  • media/video-document-click-expected.txt: Removed.
  • media/video-document-click.html: Removed.
7:28 PM Changeset in webkit [85578] by Dimitri Glazkov
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Darin Adler.

Add layout tests for clicking in media documents.
https://bugs.webkit.org/show_bug.cgi?id=59976

  • media/video-document-click-expected.txt: Added.
  • media/video-document-click.html: Added.
7:22 PM Changeset in webkit [85577] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-02 Ben Wells <benwells@chromium.org>

Reviewed by Simon Fraser.

Cleanup variable usage in RenderObject.cpp paintOutline()
https://bugs.webkit.org/show_bug.cgi?id=59911

No new tests for this, there should be no change in behaviour.

  • rendering/RenderObject.cpp: (WebCore::RenderObject::paintOutline):
7:03 PM Changeset in webkit [85576] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix crash that was introduced in r85515.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::dispatchSyncMessage):
If didReceiveSyncMessage returns ManualReply, the client took ownership of the reply
encoder so we must leak it to avoid a double-free.

7:00 PM Changeset in webkit [85575] by jberlin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Remove an assertion that Windows was hitting on launch.

Rubber-stamped by Oliver Hunt.

  • runtime/Structure.cpp:

(JSC::Structure::materializePropertyMap):

  • runtime/Structure.h:

(JSC::Structure::typeInfo):
(JSC::Structure::previousID):
(JSC::Structure::propertyStorageCapacity):
(JSC::Structure::propertyStorageSize):
(JSC::Structure::get):
(JSC::Structure::materializePropertyMapIfNecessary):

6:51 PM Changeset in webkit [85574] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: adding and removing values
https://bugs.webkit.org/show_bug.cgi?id=59953

  • storage/indexeddb/mozilla/object-store-remove-values-expected.txt: Added.
  • storage/indexeddb/mozilla/object-store-remove-values.html: Added.
6:48 PM Changeset in webkit [85573] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

The web process locks up when the plug-in process crashes
https://bugs.webkit.org/show_bug.cgi?id=59999
<rdar://problem/8889303>

Add a hash map from plug-in paths to CoreIPC connections to PluginProcessConnectionManager.
Add PluginProcessConnectionManager::pluginProcessCrashed and make it look up the corresponding
CoreIPC connection and call postConnectionDidCloseOnConnectionWorkQueue on it.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
  • Platform/CoreIPC/Connection.h:
  • WebProcess/Plugins/PluginProcessConnectionManager.cpp: (WebKit::PluginProcessConnectionManager::getPluginProcessConnection): (WebKit::PluginProcessConnectionManager::removePluginProcessConnection): (WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::pluginProcessCrashed):
6:46 PM Changeset in webkit [85572] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-02 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by James Robinson.

REGRESSION(r84672): showTree doesn't work for input/textarea elements
https://bugs.webkit.org/show_bug.cgi?id=60001

When shadow is null, try retrieving the inner element of a render text control.

  • dom/Node.cpp: (WebCore::traverseTreeAndMark):
6:34 PM Changeset in webkit [85571] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Try to fix Windows build.

  • Scripts/webkit2/messages.py:
  • Scripts/webkit2/messages_unittest.py:
6:19 PM Changeset in webkit [85570] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Oliver Hunt.

Dispatch the PluginProcessCrashed on the connection work queue
https://bugs.webkit.org/show_bug.cgi?id=59996

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initialize): Add the web process as a queue client.

(WebKit::WebProcess::terminate):
Remove the web process as a queue client.

(WebKit::WebProcess::willProcessMessageOnClientRunLoop):
Try calling willProcessWebProcessMessageOnClientRunLoop.

  • WebProcess/WebProcess.messages.in: Add the DispatchOnConnectionQueue attribute to PluginProcessCrashed.
6:12 PM Changeset in webkit [85569] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Send a PluginProcessCrashed message to all web processes when a plug-in crashes
https://bugs.webkit.org/show_bug.cgi?id=59994

  • UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::didClose): Iterate over all contexts and send PluginProcessCrashed to all web processes in each context.

(WebKit::PluginProcessProxy::didFinishLaunching):
Call setShouldCloseConnectionOnMachExceptions on the CoreIPC connection.

  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::pluginProcessCrashed): Add empty stub.
  • WebProcess/WebProcess.messages.in: Add message.
6:04 PM Changeset in webkit [85568] by mrowe@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

<rdar://problem/9371948> JavaScriptCore should build with GCC 4.2

Reviewed by Geoff Garen.

  • Configurations/CompilerVersion.xcconfig:
6:02 PM Changeset in webkit [85567] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Simon Fraser.

Plug-in not completely repainted after a crash
https://bugs.webkit.org/show_bug.cgi?id=59991

Call Widget::invalidate().

  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::pluginProcessCrashed):
5:53 PM Changeset in webkit [85566] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Dan Bernstein.

Make PluginProcessConnectionManager a member of WebProcess
https://bugs.webkit.org/show_bug.cgi?id=59989

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:
  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::initialize):
  • WebProcess/WebProcess.h: (WebKit::WebProcess::pluginProcessConnectionManager):
5:43 PM Changeset in webkit [85565] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Expectation for new test.

  • platform/chromium/test_expectations.txt:
5:36 PM Changeset in webkit [85564] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/9371289> WebKit2 can persist an invalid current back/forward item index when URLs are filtered from back/forward list

Reviewed by Brady Eidson.

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): We need to update the current index to account for filtered items
for all items before the current item in the array.

5:28 PM Changeset in webkit [85563] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Chromium test expectations.

  • platform/chromium/test_expectations.txt:
5:26 PM Changeset in webkit [85562] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/742

Merge 85335
BUG=80255
Review URL: http://codereview.chromium.org/6913012

5:24 PM Changeset in webkit [85561] by barraclough@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 build fix.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):

5:20 PM Changeset in webkit [85560] by Joseph Pecoraro
  • 3 edits
    3 adds in trunk

2011-05-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Respect fixed text-indent on ::-webkit-input-placeholder
https://bugs.webkit.org/show_bug.cgi?id=59825

Placeholder text does not appear in the render tree
dumps, so this is a pixel test for the position of
the placeholder affected by text-indent.

  • fast/forms/input-placeholder-text-indent.html: Added.
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.png: Added.
  • platform/mac/fast/forms/input-placeholder-text-indent-expected.txt: Added.

2011-05-02 Joseph Pecoraro <Joseph Pecoraro>

Reviewed by David Kilzer.

Respect fixed text-indent on ::-webkit-input-placeholder
https://bugs.webkit.org/show_bug.cgi?id=59825

Test: fast/forms/input-placeholder-text-indent.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::paintPlaceholder): indent by a fixed text-indent size specified on the placeholder style.
5:17 PM Changeset in webkit [85559] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 84085
BUG=79595

5:14 PM Changeset in webkit [85558] by cevans@google.com
  • 4 edits
    16 copies in branches/chromium/742

Merge 85355
BUG=79075
Review URL: http://codereview.chromium.org/6913011

5:12 PM Changeset in webkit [85557] by cevans@google.com
  • 4 edits
    16 copies in branches/chromium/696

Merge 85355
BUG=79075

5:10 PM Changeset in webkit [85556] by ericu@chromium.org
  • 6 edits in trunk

2011-05-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by Eric Seidel.

Some FileWriter progress events should be queued
https://bugs.webkit.org/show_bug.cgi?id=50846

  • fileapi/FileWriter.cpp:
  • fileapi/FileWriter.h: Create a new asynchronous Task [FileWriterCompletionEventTask] that will set readyState to DONE and fire off the right events.

2011-05-02 Eric Uhrhane <ericu@chromium.org>

Reviewed by Eric Seidel.

Some FileWriter progress events should be queued
https://bugs.webkit.org/show_bug.cgi?id=50846

  • fast/filesystem/resources/file-writer-events.js: (onWrite): Expect readyState at onwrite to be DONE now, not WRITING.
  • fast/filesystem/resources/file-writer-utils.js: Switch to using onwrite, now that it works.
4:57 PM Changeset in webkit [85555] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 84300
BUG=79055

4:51 PM Changeset in webkit [85554] by cevans@google.com
  • 1 edit
    4 copies in branches/chromium/696

Merge 83690
BUG=78948

4:51 PM Changeset in webkit [85553] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: cursor mutation in object store
https://bugs.webkit.org/show_bug.cgi?id=59933

This is a test case *adapted* from a test in Mozilla's IndexedDB
test suite. The original test checked cursor mutation while iterating
an index cursor (tracked as bug 59822). This test checks whether the
cursor mutation is successfully recognized while iterating a straight
objectstore cursor. Specifically, it deletes a record that's already
been iterated, then adds a record to the objectstore during iteration,
then checks that no records were skipped and that the added record is
eventually found during iteration.

  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt: Added.
  • storage/indexeddb/mozilla/cursor-mutation-objectstore-only.html: Added.
4:44 PM Changeset in webkit [85552] by rniwa@webkit.org
  • 4 edits in branches/chromium/742

Merge 84919 - 2011-04-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111

Added a test to move left and right within Arabic numerals and Arabic letters.

We still fail to set the position offset properly when we moving to the left from before B
to before A in "ABC123" (logical order) in a LTR block where ABC and 123 are Arabic letters
and numerals respectively. This bug is to be fixed in the followup bugs.

  • editing/selection/move-left-right-expected.txt:
  • editing/selection/move-left-right.html:

2011-04-26 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Dan Bernstein.

[RTL] Arabic/AB - after typing a date, cursors doesn't go back
https://bugs.webkit.org/show_bug.cgi?id=49111

Even when the offset corresponds to a position visually left of the box
and there aren't any inline boxes on the left, the previous/next position
may still correspond to some position in the same line.

The bug was caused by our ignoring such cases. Fixed the bug by comparing
previous/next position's inline box to the current box. If they match,
then we stay on the same position because moving to the left visually at
the left edge should not result in a position on the same line.

Also fixed a bug that WebKit uses offsets that are not extrema when moved to
the left edge or to the right edge, and a bug that WebKit could not move to
the left from 123 CBA abc to 123 CBA abc (there is no offset between 3 and C).

Test cases are added to editing/selection/move-left-right.html

  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::leftVisuallyDistinctCandidate): (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):

Review URL: http://codereview.chromium.org/6911017

4:43 PM Changeset in webkit [85551] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-02 Jia Pu <jpu@apple.com>

Reviewed by Alexey Proskuryakov.

[Mac] Need to truncate the string sent to "Look Up … " menu item, if it's too long.
https://bugs.webkit.org/show_bug.cgi?id=59836
<rdar://problem/9275983>

  • platform/DefaultLocalizationStrategy.cpp: (WebCore::truncatedStringForLookupMenuItem): (WebCore::DefaultLocalizationStrategy::contextMenuItemTagLookUpInDictionary):
4:42 PM Changeset in webkit [85550] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Windows build fix.

4:41 PM Changeset in webkit [85549] by beidson@apple.com
  • 6 edits in trunk/Source

<rdar://problem/9340945> and https://bugs.webkit.org/show_bug.cgi?id=59973
In Aperture, a WebView might be dealloc'ed before it finishes loading.

Reviewed by Anders Carlsson.

../WebCore:

  • WebCore.exp.in:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsAperture): Perform a com.apple.Aperture bundle check.

  • platform/RuntimeApplicationChecks.h:

../WebKit/mac:

  • WebView/WebView.mm:

(needsSelfRetainWhileLoadingQuirk):
(-[WebView _didStartProvisionalLoadForFrame:]): If we need the quirk, retain self.
(-[WebView _didFinishLoadForFrame:]): If we need the quirk, release self on a delay.
(-[WebView _didFailLoadWithError:forFrame:]): Ditto.
(-[WebView _didFailProvisionalLoadWithError:forFrame:]): Ditto.

4:40 PM Changeset in webkit [85548] by abarth@webkit.org
  • 1 edit
    1 add in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add runtests_unittest.py
https://bugs.webkit.org/show_bug.cgi?id=59955

I forgot to add this file in a previous patch.

  • Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
4:38 PM Changeset in webkit [85547] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/742

Merge 84422
BUG=78327
Review URL: http://codereview.chromium.org/6909014

4:36 PM Changeset in webkit [85546] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/696

Merge 84422
BUG=78327

4:28 PM Changeset in webkit [85545] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Update Qt specific expected result after r85499.

  • platform/qt/fast/replaced/table-percent-height-expected.png:
  • platform/qt/fast/replaced/table-percent-height-expected.txt:
4:25 PM Changeset in webkit [85544] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/742

Merge 85406
BUG=67923
Review URL: http://codereview.chromium.org/6907011

4:23 PM Changeset in webkit [85543] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/696

Merge 85406
BUG=67923

4:22 PM Changeset in webkit [85542] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectation for new test.

  • platform/chromium/test_expectations.txt:
4:19 PM Changeset in webkit [85541] by msaboff@apple.com
  • 5 edits in trunk

2011-05-02 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

crash in JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=58922

New tests to check for proper clearing and chaining of backtrack
data labels.

  • fast/regex/parentheses-expected.txt:
  • fast/regex/script-tests/parentheses.js:

2011-05-02 Michael Saboff <msaboff@apple.com>

Reviewed by Geoffrey Garen.

crash in JSC::RegExp::match
https://bugs.webkit.org/show_bug.cgi?id=58922

Cleared chained backtrack data label when linking label even if that
label doesn't chain itself. This is needed so that subsequent
backtrack data labels point to the next outer paren and not within
the current paren.

  • yarr/YarrJIT.cpp: (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
4:18 PM Changeset in webkit [85540] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

2011-05-02 Simon Fraser <Simon Fraser>

Reviewed by Dan Bernstein.

Avoid wasted cycles updating paths when popping the context stack
https://bugs.webkit.org/show_bug.cgi?id=59967

CanvasRenderingContext2D has to map the current path through
transforms whenever the context stack is popped, which creates
a lot of platform path objects. Avoid extra work here when the
path is empty, or when the transform is identity.

  • platform/graphics/cg/PathCG.cpp: (WebCore::Path::transform):
4:13 PM Changeset in webkit [85539] by enne@google.com
  • 8 edits in trunk/LayoutTests

2011-05-02 Adrienne Walker <enne@google.com>

[chromium] Unreviewed, rebaseline small scrollbar image differences after r85527
https://bugs.webkit.org/show_bug.cgi?id=58907

This could be tickling the same bug that is showing up in bug 58587.

  • platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
  • platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
  • platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
4:12 PM Changeset in webkit [85538] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
4:05 PM Changeset in webkit [85537] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Change the testing EWS to log failures explicitly to avoid an infinite loop.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4:04 PM Changeset in webkit [85536] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Fix Chromium test expectations.

  • platform/chromium/test_expectations.txt:
3:46 PM Changeset in webkit [85535] by enrica@apple.com
  • 3 edits
    2 adds in trunk

Text does not split on white space when typing to the edge of window.
https://bugs.webkit.org/show_bug.cgi?id=59968
<rdar://problem/9112683>

Reviewed by Dan Bernstein.

Source/WebCore:

Test: editing/inserting/typing-at-end-of-line.html

This is a regression introduced when we converted the line box tree to
floating point in r78846. In findNextLineBreak, there was still one place where
the character width was treated as int and truncated and we were inconsistent
in the way we treated a character that did not fit entirely in the line.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

  • editing/inserting/typing-at-end-of-line.html: Added.
  • platform/mac/editing/inserting/typing-at-end-of-line-expected.txt: Added.
3:40 PM Changeset in webkit [85534] by hclam@chromium.org
  • 2 edits
    1 add in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Test expectations for Chromium Mac port.

  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png: Added.
  • platform/chromium/test_expectations.txt:
3:38 PM Changeset in webkit [85533] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Tiny bit of heap cleanup.

Reviewed by Oliver Hunt.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::contains): Tightened up an assertion and a comment.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::globalData):
(JSC::MarkedSpace::highWaterMark):
(JSC::MarkedSpace::setHighWaterMark): Moved inlines out of the class
definition, for better clarity.

3:37 PM Changeset in webkit [85532] by tony@chromium.org
  • 1 edit
    4 deletes in trunk/LayoutTests

2011-05-02 Tony Chang <tony@chromium.org>

Remove unused files.

  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.checksum: Removed. This file differs from

the value in the png file, but I assume that the png is correct (more recently generated).

  • platform/mac/fast/table/dynamic-caption-add-before-child-expected.checksum: Removed.
  • platform/mac/fast/table/dynamic-caption-add-remove-before-child-expected.checksum: Removed.
  • platform/mac/fast/table/multiple-captions-display-expected.checksum: Removed.
3:30 PM Changeset in webkit [85531] by enne@google.com
  • 2 edits in trunk/Tools

2011-05-02 Adrienne Walker <enne@google.com>

Unreviewed, fix misspelled contributor name.

  • Scripts/webkitpy/common/config/committers.py:
3:28 PM Changeset in webkit [85530] by cevans@google.com
  • 1 edit
    7 copies
    5 deletes in branches/chromium/742

Merge 85436
BUG=75696
Review URL: http://codereview.chromium.org/6911011

3:23 PM Changeset in webkit [85529] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

Update Qt specific expected result after r85499.

  • platform/qt/fast/replaced/table-percent-height-expected.png:
  • platform/qt/fast/replaced/table-percent-height-expected.txt:
3:20 PM Changeset in webkit [85528] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

2011-05-02 Chang Shu <cshu@webkit.org>

Reviewed by Martin Robinson.

[GTK][Qt] fast/events/keydown-1.html fails
https://bugs.webkit.org/show_bug.cgi?id=59586

Replace mac-specific keys with cross-platform keys to make the test
pass on GTK and Qt platforms.

  • fast/events/keydown-1.html:
  • platform/gtk/Skipped:
  • platform/qt/Skipped:
3:13 PM Changeset in webkit [85527] by enne@google.com
  • 5 edits
    4 adds in trunk

2011-04-27 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

Add test for multiple invalidations of the same size.
https://bugs.webkit.org/show_bug.cgi?id=58907

This tests a bug in Chromium where canvas state was not being properly
reset between draw calls and a cached canvas of the same size was
being used to paint into that retained incorrect state.

  • compositing/repaint/same-size-invalidation-expected.txt: Added.
  • compositing/repaint/same-size-invalidation.html: Added.
  • platform/chromium-gpu/compositing/repaint/same-size-invalidation-expected.png: Added.

2011-04-19 Adrienne Walker <enne@google.com>

Reviewed by James Robinson.

[chromium] Don't unnecessarily resize skia/cg canvases when painting in compositor
https://bugs.webkit.org/show_bug.cgi?id=58907

Additionally, move the context save/restore logic to a place where it
will reset the translation added in LayerTilerChromium.

Test: compositing/repaint/same-size-invalidation.html

  • platform/graphics/chromium/ContentLayerChromium.cpp: (WebCore::ContentLayerPainter::paint):
  • platform/graphics/chromium/PlatformCanvas.cpp: (WebCore::PlatformCanvas::resize): (WebCore::PlatformCanvas::Painter::Painter): (WebCore::PlatformCanvas::Painter::~Painter):
  • platform/graphics/chromium/PlatformCanvas.h:
3:04 PM Changeset in webkit [85526] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Enable strict OwnPtr for Qt
https://bugs.webkit.org/show_bug.cgi?id=59667

Unreviewed buildfix after r85343.

  • platform/graphics/qt/GraphicsContext3DQt.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

2:55 PM Changeset in webkit [85525] by hclam@chromium.org
  • 21 edits
    41 adds
    1 delete in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Add test expectations for SVG changes.

  • platform/chromium-mac-leopard/editing/selection/3690703-2-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690703-expected.png:
  • platform/chromium-mac-leopard/editing/selection/3690719-expected.png:
  • platform/chromium-mac-leopard/editing/selection/4975120-expected.png:
  • platform/chromium-mac-leopard/editing/selection/extend-selection-bidi-expected.png:
  • platform/chromium-mac-leopard/editing/style/5046875-1-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-focus-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-appearance-readonly-expected.png:
  • platform/chromium-mac-leopard/fast/forms/input-double-click-selection-gap-bug-expected.png:
  • platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac-leopard/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-mac-leopard/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-intro-05-t-expected.png:
  • platform/chromium-mac/editing/selection/3690703-2-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690703-expected.png: Added.
  • platform/chromium-mac/editing/selection/3690719-expected.png: Added.
  • platform/chromium-mac/editing/selection/4975120-expected.png: Added.
  • platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
  • platform/chromium-mac/editing/style/5046875-1-expected.png: Added.
  • platform/chromium-mac/fast/borders/svg-as-border-image-2-expected.png: Removed.
  • platform/chromium-mac/fast/borders/svg-as-border-image-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-focus-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png: Added.
  • platform/chromium-mac/fast/forms/input-double-click-selection-gap-bug-expected.png: Added.
  • platform/chromium-mac/fast/repaint/japanese-rl-selection-repaint-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
  • platform/chromium-mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png: Added.
  • platform/chromium-mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png: Added.
  • platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png: Added.
  • platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-in-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularConstant-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-specularExponent-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-dom-suraceScale-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-inherit-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-lighting-color-css-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-in-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularConstant-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-specularExponent-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFESpecularLightingElement-svgdom-suraceScale-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png: Added.
  • platform/chromium-mac/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png: Added.
  • platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
  • platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
  • platform/chromium/test_expectations.txt:
2:43 PM Changeset in webkit [85524] by abarth@webkit.org
  • 6 edits in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

cr-linux-ews should run tests
https://bugs.webkit.org/show_bug.cgi?id=59272

This patch turns on testing for the cr-linux-ews. Yay!

  • Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
2:36 PM Changeset in webkit [85523] by oliver@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

2011-05-02 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Correct marking of interpreter data in mixed mode builds
https://bugs.webkit.org/show_bug.cgi?id=59962

We had a few places in mixed mode builds where we would not
track data used by the interpreter for marking. This patch
corrects the problem and adds a number of assertions to catch
live Structures being collected.

  • JavaScriptCore.exp:
  • assembler/ARMv7Assembler.h: (JSC::ARMv7Assembler::ARMInstructionFormatter::debugOffset):
  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump):
  • bytecode/CodeBlock.h: (JSC::CodeBlock::addPropertyAccessInstruction): (JSC::CodeBlock::addGlobalResolveInstruction): (JSC::CodeBlock::addStructureStubInfo): (JSC::CodeBlock::addGlobalResolveInfo):
  • bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitResolve): (JSC::BytecodeGenerator::emitResolveWithBase): (JSC::BytecodeGenerator::emitGetById): (JSC::BytecodeGenerator::emitPutById): (JSC::BytecodeGenerator::emitDirectPutById):
  • runtime/Structure.cpp: (JSC::Structure::materializePropertyMap):
  • runtime/Structure.h: (JSC::Structure::typeInfo): (JSC::Structure::previousID): (JSC::Structure::propertyStorageCapacity): (JSC::Structure::propertyStorageSize): (JSC::Structure::get): (JSC::Structure::materializePropertyMapIfNecessary):
2:18 PM Changeset in webkit [85522] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Add test expectations to accomodate new tests.

  • platform/chromium/test_expectations.txt:
2:13 PM Changeset in webkit [85521] by xan@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-02 Xan Lopez <xlopez@igalia.com>

Reviewed by Alexey Proskuryakov.

Use native NullPtr when using GCC 4.6.0 and C++0x
https://bugs.webkit.org/show_bug.cgi?id=59252

GCC 4.6.0 has nullptr support, use it when possible.

  • wtf/NullPtr.cpp: include config.h to pull in Platform.h before NullPtr.h, since we need the GCC_VERSION_AT_LEAST definition.
  • wtf/NullPtr.h: check for GCC >= 4.6.0 and C++0x in order to use native nullptr.
2:05 PM Changeset in webkit [85520] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Adjust test expectations.

  • platform/chromium/test_expectations.txt:
2:04 PM Changeset in webkit [85519] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Handle DispatchOnConnectionQueue for asynchronous messages
https://bugs.webkit.org/show_bug.cgi?id=59959

If any asynchronous messages have the DispatchOnConnectionQueue attribute,
create a new willProcess{Receiver}MessageOnClientRunLoop.

  • Scripts/webkit2/messages.py:
  • Fix a regex bug where we would only parse attributes on synchronous messages.
  • Collect messages with the dispatch_on_connection_queue flag set. We only handle asynchronous messages currently; sync message support will be added when/if the need arises.
  • Scripts/webkit2/messages_unittest.py: Update test.
2:04 PM Changeset in webkit [85518] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85483.
http://trac.webkit.org/changeset/85483
https://bugs.webkit.org/show_bug.cgi?id=59958

Causes media test failures. (Requested by eric_carlson on
#webkit).

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::prepareForLoad): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::updatePlayState):
  • html/HTMLMediaElement.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): (WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): (WebCore::MediaPlayerPrivateAVFoundation::load): (WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): (WebCore::MediaPlayerPrivateAVFoundation::paint): (WebCore::MediaPlayerPrivateAVFoundation::duration): (WebCore::MediaPlayerPrivateAVFoundation::seeking): (WebCore::MediaPlayerPrivateAVFoundation::updateStates): (WebCore::MediaPlayerPrivateAVFoundation::hasAvailableVideoFrame): (WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): (WebCore::MediaPlayerPrivateAVFoundation::loadedTimeRangesChanged): (WebCore::MediaPlayerPrivateAVFoundation::timeChanged): (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): (WebCore::MediaPlayerPrivateAVFoundation::repaint): (WebCore::MediaPlayerPrivateAVFoundation::setPreload):
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): (WebCore::MediaPlayerPrivateAVFoundationObjC::videoLayerIsReadyToDisplay): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForURL): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerForCacheResource): (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): (WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): (WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): (WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): (WebCore::MediaPlayerPrivateAVFoundationObjC::paint): (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): (WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
1:49 PM Changeset in webkit [85517] by hclam@chromium.org
  • 6 edits
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: inline autoincrement key added on put
https://bugs.webkit.org/show_bug.cgi?id=59936

  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.
1:45 PM Changeset in webkit [85516] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Martin Robinson <mrobinson@igalia.com>

Incorporate a review comment that I mistakenly omitted from my last commit.

  • DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
1:37 PM Changeset in webkit [85515] by abarth@webkit.org
  • 18 edits in trunk/Source

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924

  • css/CSSGrammar.y:
  • platform/graphics/mac/SimpleFontDataMac.mm:
    • Memory management for the font cache is somewhat... complext. This will require some careful thought to sort out.

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924

  • History/WebHistory.mm: (-[WebHistory _visitedURL:withTitle:method:wasFailure:increaseVisitCount:]):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedFrame):
  • WebView/WebView.mm: (-[WebView _injectMailQuirksScript]): (-[WebView _injectOutlookQuirksScript]): (toStringVector):

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

PLATFORM(MAC) should (almost!) build with strict PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59924

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::sendSyncMessage): (CoreIPC::Connection::waitForSyncReply): (CoreIPC::Connection::dispatchSyncMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::Message::releaseArguments):
    • The memory management for this class is very strange. I wrote a large comment. Hopefully a kind soul will come by and fix it.
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp: (WebKit::NetscapePluginModule::unload):
  • UIProcess/API/mac/WKView.mm: (-[WKView _setFindIndicator:fadeOut:]):
  • WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm: (WebKit::WebFullScreenManagerMac::setRootFullScreenLayer):
  • WebProcess/InjectedBundle/InjectedBundle.cpp: (WebKit::toStringVector):
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp: (WebKit::NetscapePluginStream::stop):
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: (WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
  • WebProcess/WebPage/DrawingArea.cpp: (WebKit::DrawingArea::create):
1:32 PM Changeset in webkit [85514] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

2011-05-02 Mark Pilgrim <pilgrim@chromium.org>

Reviewed by Tony Chang.

Port Mozilla's IndexedDB tests: inline autoincrement key added on put
https://bugs.webkit.org/show_bug.cgi?id=59936

  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt: Added.
  • storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put.html: Added.
1:28 PM Changeset in webkit [85513] by kerz@chromium.org
  • 5 edits in branches/chromium/742

Merge 85264 - 2011-04-28 Mike Reed <reed@google.com>

Reviewed by Eric Seidel.

fix shadw behavior for both CSS and Canvas
https://bugs.webkit.org/show_bug.cgi?id=59700

  • platform/chromium/test_expectations.txt:

2011-04-28 Mike Reed <reed@google.com>

Reviewed by Eric Seidel.

fix shadw behavior for both CSS and Canvas -- skia only
https://bugs.webkit.org/show_bug.cgi?id=59700

Test:
canvas/philip/tests/2d.shadow.alpha.3.html
canvas/philip/tests/2d.shadow.alpha.4.html
canvas/philip/tests/2d.shadow.alpha.5.html
fast/canvas/canvas-fillPath-alpha-shadow.html
fast/canvas/canvas-strokePath-alpha-shadow.html
fast/canvas/canvas-strokeRect-alpha-shadow.html
fast/css/text-input-with-webkit-border-radius.html
fast/repaint/shadow-multiple-horizontal.html
fast/repaint/shadow-multiple-strict-horizontal.html
fast/repaint/shadow-multiple-strict-vertical.html
fast/repaint/shadow-multiple-vertical.html
fast/canvas/canvas-getImageData.html

  • platform/graphics/chromium/FontChromiumWin.cpp: (WebCore::Font::drawGlyphs):
  • platform/graphics/skia/GraphicsContextSkia.cpp: (WebCore::GraphicsContext::setPlatformShadow):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6913001

1:23 PM Changeset in webkit [85512] by leviw@chromium.org
  • 13 edits in trunk/Source/WebCore

2011-05-02 Levi Weintraub <leviw@chromium.org>

Reviewed by Eric Seidel.

showLineTree/showLineTreeForThis would make working with the line box tree easier
https://bugs.webkit.org/show_bug.cgi?id=59662

Adding a showLineTree/showLineTreeForThis method to help visualize and debug
the line tree. Also adding a missing showRenderTreeForThis method to RenderObject.

No new tests since this is a debugging feature only and not compiled in release.

  • rendering/InlineBox.cpp: (WebCore::InlineBox::showLineTreeForThis): (WebCore::InlineBox::showLineTreeAndMark): (WebCore::InlineBox::showBox): (showLineTree):
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::showLineTreeAndMark):
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::showBox):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::showLineTreeAndMark):
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::showRenderTreeForThis): (WebCore::RenderObject::showLineTreeForThis): (showTree): (showLineTree):
  • rendering/RenderObject.h:
1:20 PM Changeset in webkit [85511] by hclam@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewd. Build fix.

Adjust test expectations to make build bots happy.

  • platform/chromium/test_expectations.txt:
1:19 PM Changeset in webkit [85510] by Dimitri Glazkov
  • 2 edits in trunk/Source/WebCore

2011-05-02 Dimitri Glazkov <Dimitri Glazkov>

Reviewed by Eric Carlson.

REGRESSIONS (r71934): In standalone media documents, (double-)clicking the media element doesn’t play/pause
https://bugs.webkit.org/show_bug.cgi?id=59917

Since default event handlers are not retargeted, we should always attempt ancestor
traversal to find out whether the event.

  • html/MediaDocument.cpp: (WebCore::ancestorVideoElement): Added ancestor-traversing helper. (WebCore::MediaDocument::defaultEventHandler): Changed to use ancestorVideoElement.
1:02 PM Changeset in webkit [85509] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

EWS should report the list of unexpected failures
https://bugs.webkit.org/show_bug.cgi?id=59923

We cache the results of the first layout test results run on the task
so the EWS can grab them later. Another option is to include them in
the exception that's thrown, but this approach seemed slightly more
aesthetic.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  • Scripts/webkitpy/tool/bot/patchanalysistask.py:
12:55 PM Changeset in webkit [85508] by cmarrin@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Chris Marrin <cmarrin@apple.com>

Reviewed by Simon Fraser.

Pages with accelerated compositing do not redraw unless scrolled
https://bugs.webkit.org/show_bug.cgi?id=59851

Added a setNeedDisplay on the non-composited content layer after
the size is changed so it paints the full size of the layer. Called
only for the areas newly exposed, if any.

  • WebProcess/WebPage/ca/LayerTreeHostCA.cpp: (WebKit::LayerTreeHostCA::sizeDidChange):
12:50 PM Changeset in webkit [85507] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Attempt to fix the Leopard build.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerATSUI.cpp:
  • platform/mac/WebCoreSystemInterface.h:
12:49 PM Changeset in webkit [85506] by hclam@chromium.org
  • 108 edits
    1 copy
    14 adds
    1 delete in trunk/LayoutTests

2011-05-02 Alpha Lam <hclam@chromium.org>

Not reviewed. Build fix.

Rebaseline SVG layout tests for chromium port.

  • platform/chromium-linux-x86_64/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/editing/style/block-style-003-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-linux/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-linux/editing/style/table-selection-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-linux/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-linux/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-linux/svg/text/text-align-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-02-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-04-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-05-b-expected.png:
  • platform/chromium-linux/svg/text/text-align-06-b-expected.png:
  • platform/chromium-linux/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-linux/svg/text/text-path-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-03-b-expected.png:
  • platform/chromium-linux/svg/text/text-text-05-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-06-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-07-t-expected.png:
  • platform/chromium-linux/svg/text/text-text-08-b-expected.png:
  • platform/chromium-linux/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-linux/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-linux/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-linux/svg/text/textPathBoundsBug-expected.png:
  • platform/chromium-mac-leopard/editing/style/table-selection-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac-leopard/svg/text/text-tspan-01-b-expected.png: Removed.
  • platform/chromium-mac/editing/style/block-style-003-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-005-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-006-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-010-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-011-expected.png: Added.
  • platform/chromium-mac/editing/style/create-block-for-style-012-expected.png: Added.
  • platform/chromium-mac/editing/style/table-selection-expected.png: Copied from LayoutTests/platform/chromium-mac/svg/text/textPathBoundsBug-expected.png.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-1-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-3-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-4-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-1-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-2-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-3-expected.png: Added.
  • platform/chromium-mac/svg/text/select-textLength-spacing-stretch-4-expected.png: Added.
  • platform/chromium-mac/svg/text/text-align-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-02-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-03-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-04-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-05-b-expected.png:
  • platform/chromium-mac/svg/text/text-align-06-b-expected.png:
  • platform/chromium-mac/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-mac/svg/text/text-path-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-03-b-expected.png:
  • platform/chromium-mac/svg/text/text-text-05-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-06-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-07-t-expected.png:
  • platform/chromium-mac/svg/text/text-text-08-b-expected.png:
  • platform/chromium-mac/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-mac/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-mac/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-mac/svg/text/textPathBoundsBug-expected.png:
  • platform/chromium-win/editing/style/block-style-003-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-005-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-006-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-010-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-011-expected.png:
  • platform/chromium-win/editing/style/create-block-for-style-012-expected.png:
  • platform/chromium-win/editing/style/table-selection-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-1-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-2-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-3-expected.png:
  • platform/chromium-win/svg/text/select-textLength-spacing-stretch-4-expected.png:
  • platform/chromium-win/svg/text/text-align-01-b-expected.png:
  • platform/chromium-win/svg/text/text-align-02-b-expected.png:
  • platform/chromium-win/svg/text/text-align-03-b-expected.png:
  • platform/chromium-win/svg/text/text-align-04-b-expected.png:
  • platform/chromium-win/svg/text/text-align-05-b-expected.png:
  • platform/chromium-win/svg/text/text-align-06-b-expected.png:
  • platform/chromium-win/svg/text/text-altglyph-01-b-expected.png:
  • platform/chromium-win/svg/text/text-deco-01-b-expected.png:
  • platform/chromium-win/svg/text/text-fonts-02-t-expected.png:
  • platform/chromium-win/svg/text/text-path-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-01-b-expected.png:
  • platform/chromium-win/svg/text/text-text-03-b-expected.png:
  • platform/chromium-win/svg/text/text-text-05-t-expected.png:
  • platform/chromium-win/svg/text/text-text-06-t-expected.png:
  • platform/chromium-win/svg/text/text-text-07-t-expected.png:
  • platform/chromium-win/svg/text/text-text-08-b-expected.png:
  • platform/chromium-win/svg/text/text-tref-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-01-b-expected.png:
  • platform/chromium-win/svg/text/text-tselect-02-f-expected.png:
  • platform/chromium-win/svg/text/text-tspan-01-b-expected.png:
  • platform/chromium-win/svg/text/text-ws-01-t-expected.png:
  • platform/chromium-win/svg/text/text-ws-02-t-expected.png:
  • platform/chromium-win/svg/text/textPathBoundsBug-expected.png:
12:43 PM Changeset in webkit [85505] by tony@chromium.org
  • 2 edits
    2 adds
    1 delete in trunk

2011-05-02 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

convert manual-tests/bugzilla-6821.html to a layout test
https://bugs.webkit.org/show_bug.cgi?id=59404

  • fast/css/hover-update-expected.txt: Added.
  • fast/css/hover-update.html: Added.

2011-05-02 Tony Chang <tony@chromium.org>

Reviewed by Kent Tamura.

convert manual-tests/bugzilla-6821.html to a layout test
https://bugs.webkit.org/show_bug.cgi?id=59404

Test: fast/css/hover-update.html

  • manual-tests/bugzilla-6821.html: Removed.
12:42 PM Changeset in webkit [85504] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add base case for a test-running EWS
https://bugs.webkit.org/show_bug.cgi?id=59920

Later I will subclass this to run the Chromium Linux EWS.

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
12:41 PM Changeset in webkit [85503] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

2011-05-02 Anders Carlsson <andersca@apple.com>

Reviewed by Adam Roben.

Need a way to handle CoreIPC messages on the connection work queue
https://bugs.webkit.org/show_bug.cgi?id=59954

Add a Connection::QueueClient abstract class. This class has a single pure virtual
member function, willProcessMessageOnClientRunLoop which should return true if the message
should be forwarded to the next Connection::QueueClient in the list or Connection::Client's
run loop for processing and false otherwise. Users of Connection can use addQueueClient to
add clients and all messages will be dispatched to the queue clients first.

  • Platform/CoreIPC/Connection.cpp: (CoreIPC::Connection::addQueueClient): (CoreIPC::Connection::removeQueueClient): (CoreIPC::Connection::processIncomingMessage):
  • Platform/CoreIPC/Connection.h: (CoreIPC::Connection::QueueClient::~QueueClient):
12:24 PM Changeset in webkit [85502] by jeffm@apple.com
  • 10 edits in trunk/Source/WebKit2

2011-05-02 Jeff Miller <jeffm@apple.com>

Reviewed by Adam Roben.

WebKit2 thinks the web process is unresponsive when a plugin displays a context menu
https://bugs.webkit.org/show_bug.cgi?id=59124
<rdar://problem/9318600>


This is the Windows version of <https://bugs.webkit.org/show_bug.cgi?id=58943>.

Since we have no control over how long a plugin will take to handle an event, we need
to tell the UI process to stop its responsive timer when we're about to send an event
to the plugin. The downside of doing this is that if the plugin does become unresponsive,
the user won't know this immediately until they click on the web page again. At that point,
if the web process is unresponsive because of a hung plugin, the responsiveness timer will fire.


We're only doing this on Windows currently when running plugins in the web process (Anders fixed
bug 58943 in a different way when running plugins in a separate plugin process on the Mac).

  • PluginProcess/PluginControllerProxy.cpp: (WebKit::PluginControllerProxy::willSendEventToPlugin): Added, not used when running plugins in a separate process.
  • PluginProcess/PluginControllerProxy.h: Added willSendEventToPlugin().
  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::stopResponsivenessTimer): Added.
  • UIProcess/WebPageProxy.h: Added stopResponsivenessTimer().
  • UIProcess/WebPageProxy.messages.in: Added StopResponsivenessTimer message.
  • WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: (WebKit::NetscapePlugin::platformPaint): Tell our controller when we're about to send an event to the plugin. (WebKit::NetscapePlugin::platformHandleMouseEvent): Ditto. (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Ditto. (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Ditto.
  • WebProcess/Plugins/PluginController.h: Added willSendEventToPlugin().
  • WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::willSendEventToPlugin): Added, tell the UI process to stop its responsiveness timer.
  • WebProcess/Plugins/PluginView.h: Added willSendEventToPlugin().
12:11 PM Changeset in webkit [85501] by weinig@apple.com
  • 16 edits in trunk/Source/WebCore

2011-05-02 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune ApplicationServices.h out of the headers
https://bugs.webkit.org/show_bug.cgi?id=59952

More forward declares are better.

  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/mac/ComplexTextControllerCoreText.cpp:
  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/WebCoreNSStringExtras.h:
  • platform/mac/WebCoreSystemInterface.h:
12:09 PM Changeset in webkit [85500] by inferno@chromium.org
  • 2 edits in trunk/LayoutTests

2011-05-02 Abhishek Arya <inferno@chromium.org>

Unreviewed.

Remove passing tests after rebaselines from r85365.

  • platform/chromium/test_expectations.txt:
11:50 AM Changeset in webkit [85499] by mitz@apple.com
  • 5 edits in trunk

<rdar://problem/7972529> Images with percentage based height/max-height are missing when they are inside blocks inside tables
https://bugs.webkit.org/show_bug.cgi?id=58006

Reviewed by Simon Fraser.

Source/WebCore:

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing): Expanded the scope of the fix for
<http://webkit.org/b/15359> from r29039 to cover not just the case of a auto-or-percent-height
table cell as the immediate containing block, but any case where all containing block ancestors
up to and including a table cell are auto-or-percent height.

LayoutTests:

  • fast/replaced/table-percent-height-expected.txt: Updated.
  • fast/replaced/table-percent-height.html: Added a test case with a replaced object nested in an

auto-height block inside a table cell.

11:38 AM Changeset in webkit [85498] by andersca@apple.com
  • 3 edits in trunk/Tools

Build fix.

  • WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
11:30 AM Changeset in webkit [85497] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=59950
Clean up AssemblerBuffer to use a Vector internally.

Reviewed by Oliver Hunt.

AssemblerBuffer handles reallocing a byte array itself - stop that.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::labelAtOffset):
(JSC::AssemblerBuffer::AssemblerBuffer):
(JSC::AssemblerBuffer::~AssemblerBuffer):
(JSC::AssemblerBuffer::isAvailable):
(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::isAligned):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::putIntegralUnchecked):
(JSC::AssemblerBuffer::putByteUnchecked):
(JSC::AssemblerBuffer::putByte):
(JSC::AssemblerBuffer::putShortUnchecked):
(JSC::AssemblerBuffer::putShort):
(JSC::AssemblerBuffer::putIntUnchecked):
(JSC::AssemblerBuffer::putInt):
(JSC::AssemblerBuffer::putInt64Unchecked):
(JSC::AssemblerBuffer::putInt64):
(JSC::AssemblerBuffer::codeSize):
(JSC::AssemblerBuffer::label):
(JSC::AssemblerBuffer::executableCopy):
(JSC::AssemblerBuffer::rewindToLabel):
(JSC::AssemblerBuffer::debugOffset):
(JSC::AssemblerBuffer::append):
(JSC::AssemblerBuffer::grow):

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::linkCall):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):

11:20 AM Changeset in webkit [85496] by jeffm@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Avoid potential buffer overflow in WTFLog() and WTFLogVerbose()
https://bugs.webkit.org/show_bug.cgi?id=59949

Reviewed by Alexy Proskuryakov.

  • wtf/Assertions.cpp: Check for 0 or empty format string in WTFLog() and WTFLogVerbose().
11:14 AM Changeset in webkit [85495] by dbates@webkit.org
  • 2 edits
    1 move
    1 add in trunk

2011-05-02 Daniel Bates <dbates@webkit.org>

Reviewed by Sam Weinig.

Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
https://bugs.webkit.org/show_bug.cgi?id=59379

Make onblur-remove.html a DRT test. As of 04/25/2011 this test fails. See bug #59379
for more details.

  • fast/events/onblur-remove-expected.txt: Added; expected failure results.
  • fast/events/onblur-remove.html: Copied from Source/WebCore/manual-tests/onblur-remove.html.

2011-05-02 Daniel Bates <dbates@webkit.org>

Reviewed by Sam Weinig.

Convert manual test onblur-remove.html to a DRT test; onblur-remove.html fails
https://bugs.webkit.org/show_bug.cgi?id=59379

Move manual test onblur-remove.html to LayoutTests/fast/events.

Test: fast/events/onblur-remove.html

  • manual-tests/onblur-remove.html: Removed.
11:09 AM Changeset in webkit [85494] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/chromium/742

MERGE 85090 - 2011-04-27 Enrica Casucci <enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

2011-04-27 Enrica Casucci <enrica@apple.com>

Reviewed by Darin Adler.

REGRESSION (r84311): Copy should preserve background color if specified in the body only if the entire content is selected.
https://bugs.webkit.org/show_bug.cgi?id=59251
<rdar://problem/9327044>

  • editing/pasteboard/do-not-copy-body-color-expected.txt: Added.
  • editing/pasteboard/do-not-copy-body-color.html: Added.

http://crbug.com/80498

11:04 AM Changeset in webkit [85493] by sfalken@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-29 Steve Falkenburg <sfalken@apple.com>

Reviewed by Maciej Stachowiak.

Plug-in failed to initialize message should be called when Java fails to initialize
https://bugs.webkit.org/show_bug.cgi?id=59856


To match the WebKit1 behavior, WebKit2 should dispatch the plug-in failed
to initialize message when we can't instantiate the Java plug-in.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
10:55 AM Changeset in webkit [85492] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Source/WebCore

2011-05-02 Sailesh Agrawal <sail@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium Mac: Add scrollbar overlay drawing functions
https://bugs.webkit.org/show_bug.cgi?id=59741

These functions are simply copied from WebCoreSystemInterface. These will be used to implement overlay scrollbars for Chromium Mac.

No new tests, since this code is only enabled on future versions of Mac OS X.

  • WebCore.gypi:
  • platform/chromium/ScrollbarOverlayUtilitiesMac.h: Added.
  • platform/chromium/ScrollbarOverlayUtilitiesMac.mm: Added. (LookUpNSScrollerImpClass): (LookUpNSScrollerImpPairClass): (ScrollbarControlSizeToNSControlSize): (wkScrollbarPainterUsesOverlayScrollers): (wkScrollbarPainterIsHorizontal): (wkScrollbarPainterKnobAlpha): (wkScrollbarPainterSetOverlayState): (wkScrollbarPainterPaint): (wkScrollbarMinimumThumbLength): (wkScrollbarPainterSetDelegate): (wkScrollbarPainterTrackAlpha): (wkMakeScrollbarPainter): (wkScrollbarThickness): (wkScrollbarMinimumTotalLengthNeededForThumb): (wkVerticalScrollbarPainterForController): (wkHorizontalScrollbarPainterForController): (wkMakeScrollbarReplacementPainter): (wkSetPainterForPainterController): (wkSetScrollbarPainterControllerStyle): (wkScrollbarPainterKnobRect): (wkSetScrollbarPainterKnobAlpha): (wkSetScrollbarPainterTrackAlpha): (wkSetScrollbarPainterKnobStyle): (wkMakeScrollbarPainterController): (wkContentAreaScrolled): (wkContentAreaWillPaint): (wkMouseEnteredContentArea): (wkMouseExitedContentArea): (wkMouseMovedInContentArea): (wkWillStartLiveResize): (wkContentAreaResized): (wkWillEndLiveResize): (wkContentAreaDidShow): (wkContentAreaDidHide): (wkDidBeginScrollGesture): (wkDidEndScrollGesture): (wkScrollbarPainterForceFlashScrollers): (IsScrollbarOverlayAPIAvailable):
10:55 AM Changeset in webkit [85491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

2011-05-02 Alok Priyadarshi <alokp@chromium.org>

Reviewed by Dimitri Glazkov.

Chromium windows build is broken due to r85395
https://bugs.webkit.org/show_bug.cgi?id=59945

Include SecurityOrigin.h in IDBFactoryBackendProxy.cpp

  • src/IDBFactoryBackendProxy.cpp:
10:54 AM Changeset in webkit [85490] by thakis@chromium.org
  • 2 edits in trunk/Tools

2011-05-02 Nico Weber <thakis@chromium.org>

Reviewed by Mihai Parparita.

Add --no-webkit2 to the output of "build-webkit -h"
https://bugs.webkit.org/show_bug.cgi?id=59942

  • Scripts/build-webkit:
10:53 AM Changeset in webkit [85489] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-02 Luke Macpherson <macpherson@chromium.org>

Reviewed by Dimitri Glazkov.

Implement Length based CSS properties in CSSStyleApplyProperty
https://bugs.webkit.org/show_bug.cgi?id=59314

No new tests as no functionality changed.

  • css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyLength::ApplyPropertyLength): Added this class to handle all length types. Property specific behavior is handled through set of boolean parameters. (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty): Added calls to set up entries for the newly added length properties.
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Remove property implementations mow implemented in CSSStyleApplyProperty.
  • css/CSSStyleSelector.h: (WebCore::CSSStyleSelector::rootElementStyle): Expose m_rootElementStyle via getter.
10:52 AM Changeset in webkit [85488] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

2011-05-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by Eric Seidel.

HTMLMediaElement should not seek to time 0 when readyState reaches HAVE_METADATA
https://bugs.webkit.org/show_bug.cgi?id=59828

No new tests required, no functional change because seeking to time zero before playback
begins has no effect.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::setReadyState): Don't seek to time 0 when readyState reaches

HAVE_METADATA.

10:43 AM Changeset in webkit [85487] by mrobinson@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Xan Lopez.

[GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
https://bugs.webkit.org/show_bug.cgi?id=59943

Disable the Ubuntu overlay scrollbar while testing, by injecting the
LIBOVERLAY_SCROLLBAR=0 environment variable.

  • Scripts/old-run-webkit-tests:
10:42 AM Changeset in webkit [85486] by kerz@chromium.org
  • 4 edits in branches/chromium/742

Merge 85290 - 2011-04-28 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732

  • platform/chromium/test_expectations.txt: Add expectations for affected tests.

2011-04-28 Steve Lacey <sjl@chromium.org>

Reviewed by Eric Carlson.

Change chromium media controls to use absolute positioning until bug 59644 is fixed.
https://bugs.webkit.org/show_bug.cgi?id=59732

  • css/mediaControlsChromium.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/6880352

10:39 AM Changeset in webkit [85485] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix extra whitespace in license in FocusDirection.h.

Reviewed by Gavin Barraclough.

  • page/FocusDirection.h:
10:35 AM Changeset in webkit [85484] by weinig@apple.com
  • 25 edits in trunk/Source

2011-05-02 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907

  • Plugins/WebBaseNetscapePluginView.mm:
  • WebView/WebFrame.mm: Add now missing SecurityOrigin.h #includes.

2011-05-02 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907

  • page/DOMWindow.cpp: (WebCore::DOMWindow::setSecurityOrigin):
  • page/DOMWindow.h: Remove #includes of SecurityOrigin and MessagePort by forward declaring and moving the SecurityOrigin setter to the .cpp file. Also adds EventTarget #include that was getting added by MessagePort.h.
  • bindings/js/JSCustomVoidCallback.cpp:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSHistoryCustom.cpp:
  • bindings/js/ScriptController.h:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLMediaElement.cpp:
  • html/parser/XSSFilter.cpp:
  • inspector/InspectorDOMStorageResource.cpp:
  • loader/MainResourceLoader.cpp:
  • page/DragController.cpp:
  • page/EventSource.cpp:
  • page/Location.cpp:
  • websockets/WebSocket.cpp:
  • xml/XSLTProcessorLibxslt.cpp: Add now missing SecurityOrigin.h #includes.

2011-05-02 Sam Weinig <sam@webkit.org>

Reviewed by Adam Barth.

Prune some #includes from DOMWindow.h
https://bugs.webkit.org/show_bug.cgi?id=59907

  • WebProcess/WebPage/WebFrame.cpp: Add now missing SecurityOrigin.h #include.
10:21 AM Changeset in webkit [85483] by eric.carlson@apple.com
  • 7 edits in trunk/Source/WebCore

2011-05-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by Brady Eidson.

The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>

Tested manually with manual-tests/media-elements/video-preload.html.

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_havePreparedToPlay. (WebCore::HTMLMediaElement::prepareForLoad): Ditto. (WebCore::HTMLMediaElement::prepareToPlay): New, tell player to prepare to play. (WebCore::HTMLMediaElement::seek): Call prepareToPlay when preload is less than 'metadata'

because we need to have media data loaded to seek.

(WebCore::HTMLMediaElement::updatePlayState): Call prepareToPlay.

  • html/HTMLMediaElement.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Remove

m_videoFrameHasDrawn and m_delayingLoad as they are no longer used.

(WebCore::MediaPlayerPrivateAVFoundation::resumeLoad): Removed.
(WebCore::MediaPlayerPrivateAVFoundation::load): Don't initialize m_videoFrameHasDrawn.

Move all preload logic to setPreload, call it from here.

(WebCore::MediaPlayerPrivateAVFoundation::prepareToPlay): Move all preload logic to

setPreload, call it.

(WebCore::MediaPlayerPrivateAVFoundation::duration): Don't cache duration = 0, it is

unlikely to be correct and isn't worth caching.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Update for name change AVAssetStatus

to AssetStatus. Create the AVPlayer once we know an asset is playable but preload is
'metadata'. Set networkState to 'idle' when the playback buffer is full because that is
a signal that AVFoundation won't do any more IO. Set readyState to 'HAVE_CURRENT_DATA'
when the first frame is available.

(WebCore::MediaPlayerPrivateAVFoundation::metadataLoaded): Call tracksChanged so we cache

width, height, hasVideo, etc.

(WebCore::MediaPlayerPrivateAVFoundation::repaint): Don't set m_videoFrameHasDrawn, it is done

in derived classes.

(WebCore::MediaPlayerPrivateAVFoundation::setPreload): Centralize all logic about when to create

AVAsset and AVPlayerItem here.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): Initialize

m_videoFrameHasDrawn.

(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAvailableVideoFrame): New, renamed from

videoLayerIsReadyToDisplay. Return true if we have a layer with frames available or
if we have painted a frame to the context.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): New, create the AVAsset

if necessary.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForCacheResource): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Restructure logic.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): New, create AVPlayerItem.
(WebCore::MediaPlayerPrivateAVFoundationObjC::beginLoadingMetadata): Correct logging.
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus): Return "buffer full" when

the buffer is full.

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration): Get the duration from the

AVAsset when we haven't allocated the AVPlayerItem yet so that we can return duration
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::assetStatus): Update for name change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::paint): Set m_videoFrameHasDrawn.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Get attributes from AVAsset

when when we haven't allocated the AVPlayerItem yet so that we can report attributes
when we only have metadata.

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged): Guard against being called before

we have allocated the AVPlayerItem.

9:52 AM Changeset in webkit [85482] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Alexey Proskuryakov.

StringImpl::endsWith has some insane code
https://bugs.webkit.org/show_bug.cgi?id=59900

  • wtf/text/StringImpl.cpp: (WTF::StringImpl::endsWith):
    • m_data shadows a member variable of the same name.
9:23 AM Changeset in webkit [85481] by mrobinson@webkit.org
  • 4 edits in trunk

2011-05-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] editing/selection/select-out-of-editable.html failing after r83967
https://bugs.webkit.org/show_bug.cgi?id=58667

  • platform/gtk/Skipped: Unskip a test which is now passing.

2011-05-02 Martin Robinson <mrobinson@igalia.com>

Reviewed by Eric Seidel.

[GTK] editing/selection/select-out-of-editable.html failing after r83967
https://bugs.webkit.org/show_bug.cgi?id=58667

Do not trigger mouse down events when the EventSender knows that a mouse button is
already down. These type of situations can confuse Xvfb and cause dragging failures.

  • DumpRenderTree/gtk/EventSender.cpp: (mouseDownCallback): Do not trigger another mouse button down event if the mouse button is already down. This can interfere with drags in Xvfb.
9:19 AM WebKitGtkLayoutTests edited by mrobinson@webkit.org
Made the package list more readable and remove DejaVu fonts. (diff)
9:13 AM Changeset in webkit [85480] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

2011-05-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Martin Robinson.

[GTK] gdk_drawable_get_size() shouldn't be used with GTK+ >= 2.24
https://bugs.webkit.org/show_bug.cgi?id=59932

Use gdk_window_get_width() and gdk_window_get_height() if
available, instead of the deprecated gdk_drawable_get_size().

No new tests, build fix only.

  • platform/gtk/WidgetRenderingContext.cpp: (WebCore::WidgetRenderingContext::WidgetRenderingContext):
9:09 AM Changeset in webkit [85479] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r83928 or before): Some tests failing assertions in MarkStack::internalAppend
/ MarkStack::drain.
https://bugs.webkit.org/show_bug.cgi?id=58657

Add inspector/styles/styles-cancel-editing.html to the Windows XP Skipped list because it
has been crashing under MarkStack::drain on the Windows XP bots.

  • platform/win-xp/Skipped:
9:04 AM Changeset in webkit [85478] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

2011-05-02 Eric Carlson <eric.carlson@apple.com>

Reviewed by Brady Eidson.

The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>

Test manually with manual-tests/media-elements/video-preload.html.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivateQTKit::commonMovieAttributes): Add new "limit read-ahead"

attribute when preload is not "auto".

(WebCore::MediaPlayerPrivateQTKit::resumeLoad): Remove m_delayingLoad, we don't need it.
(WebCore::MediaPlayerPrivateQTKit::load): Correct comment.
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay): Call setPreload('auto').
(WebCore::MediaPlayerPrivateQTKit::setPreload): Set new attribue if we already have

a QTMovie.

8:59 AM Changeset in webkit [85477] by Csaba Osztrogonác
  • 3 edits in trunk/LayoutTests

[Qt] Update an exptected file after r85474.

  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
  • platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
8:55 AM Changeset in webkit [85476] by eric.carlson@apple.com
  • 1 edit
    1 add in trunk/Source/WebCore

2011-04-30 Eric Carlson <eric.carlson@apple.com>

Reviewed by Brady Eidson.

The preload attribute of the video tag is not completely implemented
https://bugs.webkit.org/show_bug.cgi?id=43673
<rdar://problem/7508322>

Manual test manual-tests/media-elements/video-preload.html added.

  • manual-tests/media-elements/video-preload.html: Added. New manual test for media element

'preload' attribute because it is not possible to detect if a media engine supports
"preload=metadata" in a way that lets us have per-platform layout test results.

7:29 AM Changeset in webkit [85475] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <pnormand@igalia.com>

Reviewed by Eric Carlson.

[GTK] Media tests relying on video-paint-test.js are still flaky
https://bugs.webkit.org/show_bug.cgi?id=59934

Dump the render tree after the video completed the seek. This is
to avoid flake happening in the control slider not always being at
beginning of the timeline.

  • media/video-paint-test.js: (init.document.addEventListener.): (init):
7:27 AM Changeset in webkit [85474] by commit-queue@webkit.org
  • 4 edits in trunk

2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

DRT sideeffect revealed by r71268
https://bugs.webkit.org/show_bug.cgi?id=48958

  • platform/qt/Skipped: Unskip svg/custom/text-zoom.xhtml

2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>

Reviewed by Csaba Osztrogonác.

DRT sideeffect revealed by r71268.
https://bugs.webkit.org/show_bug.cgi?id=48958

Reset QWebSettings::ZoomTextOnly attribute before all tests.

Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
PageZoomFactor too. It should be done before resetsettings()
to guarantee resetting QWebSettings::ZoomTextOnly correctly.

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings): (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
7:24 AM Changeset in webkit [85473] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, skip flaky test on GTK.

  • platform/gtk/Skipped: Skip tables/mozilla_expected_failures/bugs/bug85016.html
5:13 AM Changeset in webkit [85472] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Tools

2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r85469.
http://trac.webkit.org/changeset/85469
https://bugs.webkit.org/show_bug.cgi?id=59928

Broke webkitpy-tests on Windows 7, GTK and Qt. (Requested by
bbandix on #webkit).

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
4:03 AM Changeset in webkit [85471] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-02 Tomasz Morawski <t.morawski@samsung.com>

Reviewed by Kenneth Rohde Christiansen.

Cleanup EFL initialization/shutdown in the EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=59922

Removed ecore_evas_init and edje_init form main function due to they
are also called in the ewk_init. Moved ewk_shutdown to quit function.

  • EWebLauncher/main.c: (quit): (main):
3:54 AM Changeset in webkit [85470] by Philippe Normand
  • 2 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, re-enable websocket tests on GTK. they moved over to a
real http server and most of the flakiness went away.

  • platform/gtk/Skipped:
3:51 AM Changeset in webkit [85469] by abarth@webkit.org
  • 3 edits
    1 add in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add base case for a test-running EWS
https://bugs.webkit.org/show_bug.cgi?id=59920

Later I will subclass this to run the Chromium Linux EWS.

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3:02 AM Changeset in webkit [85468] by Philippe Normand
  • 1 edit
    46 adds in trunk/LayoutTests

2011-05-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK baselines for new tests.

  • platform/gtk/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/gtk/fast/backgrounds/gradient-background-leakage-expected.txt: Added.
  • platform/gtk/fast/block/float/float-overhangs-root-expected.png: Added.
  • platform/gtk/fast/block/float/float-overhangs-root-expected.txt: Added.
  • platform/gtk/fast/block/float/overhanging-tall-block-expected.png: Added.
  • platform/gtk/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.png: Added.
  • platform/gtk/fast/block/positioning/rtl-fixed-positioning-expected.txt: Added.
  • platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.png: Added.
  • platform/gtk/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt: Added.
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Added.
  • platform/gtk/fast/box-shadow/single-pixel-shadow-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png: Added.
  • platform/gtk/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt: Added.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.png: Added.
  • platform/gtk/fast/forms/date-input-visible-strings-expected.txt: Added.
  • platform/gtk/fast/html/details-add-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-add-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-add-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-add-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-add-summary-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-add-summary-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-add-summary-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-add-summary-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-remove-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-remove-child-2-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-summary-child-1-expected.png: Added.
  • platform/gtk/fast/html/details-remove-summary-child-1-expected.txt: Added.
  • platform/gtk/fast/html/details-remove-summary-child-2-expected.png: Added.
  • platform/gtk/fast/html/details-remove-summary-child-2-expected.txt: Added.
  • platform/gtk/fast/table/auto-100-percent-width-expected.png: Added.
  • platform/gtk/fast/table/auto-100-percent-width-expected.txt: Added.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.png: Added.
  • platform/gtk/fast/table/dynamic-caption-add-before-child-expected.txt: Added.
  • platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.png: Added.
  • platform/gtk/fast/table/dynamic-caption-add-remove-before-child-expected.txt: Added.
  • platform/gtk/fast/table/multiple-captions-display-expected.png: Added.
  • platform/gtk/fast/table/multiple-captions-display-expected.txt: Added.
  • platform/gtk/fast/text/selection-rect-rounding-expected.png: Added.
  • platform/gtk/fast/text/selection-rect-rounding-expected.txt: Added.
  • platform/gtk/svg/filters/feDropShadow-expected.png: Added.
  • platform/gtk/svg/filters/feDropShadow-expected.txt: Added.
2:37 AM Changeset in webkit [85467] by loki@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Buildfix for ARM after r85448

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::loadBranchTarget):

2:09 AM Changeset in webkit [85466] by Philippe Normand
  • 3 edits in trunk/LayoutTests

2011-05-02 Philippe Normand <pnormand@igalia.com>

Unreviewed, GTK rebaseline after r85355.

  • platform/gtk/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/other/test4-expected.txt:
1:11 AM Changeset in webkit [85465] by abarth@webkit.org
  • 5 edits in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Add the ability to skip python and perl unit tests on EC2
https://bugs.webkit.org/show_bug.cgi?id=59918

  • Scripts/webkitpy/common/config/ports.py:
    • This is slightly ugly, but it's useful...
  • Scripts/webkitpy/common/config/ports_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:
  • Scripts/webkitpy/tool/steps/runtests.py:
12:56 AM Changeset in webkit [85464] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch --non-interactive is incompatible with new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=59919

new-run-webkit-tests doesn't support --wait-for-httpd (because it
always waits for HTTPD, as I understand things). It turns out we're
not really using this flag for anything, so we should just remove it.

  • Scripts/webkitpy/tool/steps/runtests.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
12:53 AM Changeset in webkit [85463] by eric@webkit.org
  • 5 edits in trunk/Tools

2011-05-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

The bots should learn from expected failures without having to retry
https://bugs.webkit.org/show_bug.cgi?id=59279

Rather than re-trying the whole patch, we can just check whether we now
expect the failures we see with the patch applied, saving a lot of time.

This patch also teaches the CommitQueue how to reject patches even
when the tree is red using the new unexpected_failures() method on
ExpectedFailures.

Finally in testing we found a bug in ExpectedFailures where it would
"trust" results which had many many failures, due to using an
equal sign instead of a less-than sign.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py
  • Scripts/webkitpy/tool/bot/expectedfailures.py
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py
  • Scripts/webkitpy/tool/bot/patchanalysistask.py
12:17 AM Changeset in webkit [85462] by abarth@webkit.org
  • 4 edits in trunk/Tools

2011-05-02 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

workspace.py fails to import ScriptError
https://bugs.webkit.org/show_bug.cgi?id=59915

If the workspace fails to create a zip, webkitpy crashes instead of
handling the error as expected.

  • Scripts/webkitpy/common/system/workspace.py:
  • Scripts/webkitpy/common/system/workspace_unittest.py:
  • Scripts/webkitpy/tool/mocktool.py:

May 1, 2011:

11:29 PM Changeset in webkit [85461] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Adam Barth <abarth@webkit.org>

Remove unadvertantly added file.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11:18 PM Changeset in webkit [85460] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

expectedfailures.py should report the unexpected failures when asked
https://bugs.webkit.org/show_bug.cgi?id=59916

This information is useful when the EWS runs tests.

  • Scripts/webkitpy/tool/bot/expectedfailures.py:
  • Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
11:14 PM Changeset in webkit [85459] by abarth@webkit.org
  • 3 edits in trunk/Tools

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

JSONTestResult needs to handle multiple results
https://bugs.webkit.org/show_bug.cgi?id=59269

This case occurs when a test is flaky because NRWT will run the test
twice and report both results as "actual."

  • Scripts/webkitpy/common/net/resultsjsonparser.py:
  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
10:59 PM Changeset in webkit [85458] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 Abhishek Arya <inferno@chromium.org>

Reviewed by Eric Carlson.

Regression(r74787): Media document mouse click and double-click
events should be checked on target node only and not its descendants.
https://bugs.webkit.org/show_bug.cgi?id=59886

  • html/MediaDocument.cpp: (WebCore::MediaDocument::defaultEventHandler):
10:44 PM Changeset in webkit [85457] by bweinstein@apple.com
  • 7 edits in trunk/Source/WebKit2

WebKit2: Crash closing tab with docked Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59914
<rdar://problem/9359672>

Reviewed by Dan Bernstein.

When a tab is closed with a docked inspector, invalidate called platformClose, which
didn't do the tear down that is needed, but is called when we close the web inspector explcitly.
One part of tear down we weren't doing is removing ourselves as a WindowMessageBrodcaster listener
on the inspected web view, and this can cause crashes.

This patch also renames platformClose to platformDidClose, to be clearer about when the function
is called.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::invalidate): Call didClose instead of platformClose.
(WebKit::WebInspectorProxy::didClose): Call platformDidClose instead of platformClose.

  • UIProcess/WebInspectorProxy.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformDidClose): Renamed from platformClose.

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformDidClose): Ditto.

  • UIProcess/gtk/WebInspectorGtk.cpp:

(WebKit::WebInspectorProxy::platformDidClose): Ditto.

  • UIProcess/qt/WebInspectorProxyQt.cpp:

(WebKit::WebInspectorProxy::platformDidClose): Ditto.

10:21 PM Changeset in webkit [85456] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Strict-mode only reserved words not reserved
https://bugs.webkit.org/show_bug.cgi?id=55342

Fix line number tracking when we rollback the lexer.

  • parser/JSParser.cpp: (JSC::JSParser::parseSourceElements):
9:51 PM Changeset in webkit [85455] by oliver@apple.com
  • 4 edits in trunk

2011-05-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295

Update for correct results

  • fast/js/mozilla/strict/11.1.5-expected.txt:

2011-05-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

ES5 Strict mode does not allow getter and setter for same propId
https://bugs.webkit.org/show_bug.cgi?id=57295

Simplify and correct the logic for strict mode object literals.

  • parser/JSParser.cpp: (JSC::JSParser::parseStrictObjectLiteral):
7:57 PM Changeset in webkit [85454] by oliver@apple.com
  • 6 edits in trunk

2011-05-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289

Add test case for correct behaviour, and update mozilla test results to reflect
the correct result.

  • fast/js/basic-strict-mode-expected.txt:
  • fast/js/mozilla/strict/assign-to-callee-name-expected.txt:
  • fast/js/script-tests/basic-strict-mode.js:

2011-05-01 Oliver Hunt <oliver@apple.com>

Reviewed by Gavin Barraclough.

Assigning to function identifier under strict should throw
https://bugs.webkit.org/show_bug.cgi?id=59289

Add logic to StaticScopeObject to ensure we don't silently consume
writes to constant properties.

  • runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::put):
6:55 PM Changeset in webkit [85453] by abarth@webkit.org
  • 3 edits
    4 adds in trunk

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899

Test two host wildcard cases.

  • http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html: Added.

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Polish CSP host and port matching
https://bugs.webkit.org/show_bug.cgi?id=59899

Finish last two details of host and port matching. I don't think the
default port handling is testable with our current testing
infrastructure.

Tests: http/tests/security/contentSecurityPolicy/image-full-host-wildcard-allowed.html

http/tests/security/contentSecurityPolicy/image-host-wildcard-allowed.html

  • page/ContentSecurityPolicy.cpp: (WebCore::CSPSource::hostMatches): (WebCore::CSPSource::portMatches):
6:46 PM Changeset in webkit [85452] by abarth@webkit.org
  • 7 edits
    2 moves in trunk/Tools

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

Move checkout/api.py to checkout/checkout.py
https://bugs.webkit.org/show_bug.cgi?id=59906

This is more consistent with Python style.

  • Scripts/webkitpy/common/checkout/init.py:
  • Scripts/webkitpy/common/checkout/scm_unittest.py:
  • Scripts/webkitpy/common/host.py:
  • Scripts/webkitpy/tool/main.py:
6:44 PM Changeset in webkit [85451] by abarth@webkit.org
  • 4 edits
    6 adds in trunk

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641

Test that default-src controls some scripting policy and that
script-src, if present, overrides default-src. In principle, we could
test the interaction of default-src with every other directive, but
that seems like overkill.

  • http/tests/security/contentSecurityPolicy/default-src-inline-allowed-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html: Added.
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html: Added.
  • http/tests/security/contentSecurityPolicy/script-src-overrides-default-src-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html: Added.

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

CSP default-src is missing
https://bugs.webkit.org/show_bug.cgi?id=58641

Add support for default-src. The default-src provides a default policy
for every directive that sends in "-src". If the more-specific
directive is present, it takes precedence. I also took this
opportunity to refactor the internals of ContentSecurityPolicy a bit to
reduce duplicate code.

Tests: http/tests/security/contentSecurityPolicy/default-src-inline-allowed.html

http/tests/security/contentSecurityPolicy/default-src-inline-blocked.html
http/tests/security/contentSecurityPolicy/script-src-overrides-default-src.html

  • page/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::didReceiveHeader): (WebCore::ContentSecurityPolicy::checkEval): (WebCore::ContentSecurityPolicy::operativeDirective): (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation): (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation): (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation): (WebCore::ContentSecurityPolicy::allowJavaScriptURLs): (WebCore::ContentSecurityPolicy::allowInlineEventHandlers): (WebCore::ContentSecurityPolicy::allowInlineScript): (WebCore::ContentSecurityPolicy::allowInlineStyle): (WebCore::ContentSecurityPolicy::allowEval): (WebCore::ContentSecurityPolicy::allowScriptFromSource): (WebCore::ContentSecurityPolicy::allowObjectFromSource): (WebCore::ContentSecurityPolicy::allowChildFrameFromSource): (WebCore::ContentSecurityPolicy::allowImageFromSource): (WebCore::ContentSecurityPolicy::allowStyleFromSource): (WebCore::ContentSecurityPolicy::allowFontFromSource): (WebCore::ContentSecurityPolicy::allowMediaFromSource): (WebCore::ContentSecurityPolicy::addDirective):
  • page/ContentSecurityPolicy.h:
6:34 PM Changeset in webkit [85450] by eric@webkit.org
  • 3 edits in trunk/Tools

2011-05-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

scm.py should be split into many pieces
https://bugs.webkit.org/show_bug.cgi?id=59908

Forgot an AuthenticationError import.

  • Scripts/webkitpy/common/checkout/scm/git.py:
  • Scripts/webkitpy/common/checkout/scm/svn.py:
6:27 PM Changeset in webkit [85449] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk/Tools

2011-05-01 Arno Renevier <arno@renevier.net>

Reviewed by Eric Seidel.

wrong exception raised in Lighttpd start method
https://bugs.webkit.org/show_bug.cgi?id=59283

raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted

  • Scripts/webkitpy/layout_tests/port/http_server.py:
6:04 PM Changeset in webkit [85448] by barraclough@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=59903
Use AssemblerLabel throughout Assembler classes, AssemblerBuffer

Reviewed by Sam Weinig.

Creating a lable() into the AssemblerBuffer should return an AssemblerLabel,
not an unsigned int.

  • assembler/ARMAssembler.cpp:

(JSC::ARMAssembler::executableCopy):

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::loadBranchTarget):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::ARMInstructionFormatter::label):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::label):

  • assembler/AssemblerBufferWithConstantPool.h:
  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::relocateJumps):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::loadConstant):
(JSC::SH4Assembler::loadConstantUnReusable):
(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::oneShortOp):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::label):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::label):

6:03 PM Changeset in webkit [85447] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Arno Renevier <arno@renevier.net>

Reviewed by Eric Seidel.

wrong exception raised in Lighttpd start method
https://bugs.webkit.org/show_bug.cgi?id=59283

raise standard Exception instead of non existent
google.httpd_utils.HttpdNotStarted

  • Scripts/webkitpy/layout_tests/port/http_server.py:
5:58 PM Changeset in webkit [85446] by eric@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Make most scm.py tests pass in preparation for splitting them up
https://bugs.webkit.org/show_bug.cgi?id=59904

There is one remaining failure:
webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch
which identifies a difference between the SVN and Git versions of the
SCM api. I'm not going to bother fixing that until we split out all
the tests.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
5:33 PM Changeset in webkit [85445] by abarth@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by David Levin.

Enable strict mode for OwnPtr and PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=59428

  • wtf/OwnPtr.h:
5:19 PM Changeset in webkit [85444] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix windows build.

  • WebFrame.cpp:
5:15 PM Changeset in webkit [85443] by Patrick Gansterer
  • 2 edits in trunk/Tools

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85440.

  • DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::UIDelegate): Removed accidental added adoptPtr.
4:56 PM Changeset in webkit [85442] by weinig@apple.com
  • 20 edits in trunk/Source

2011-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895

Start getting rid of unnecessary #includes and forward declares.

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:

2011-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895

Start getting rid of unnecessary #includes and forward declares.

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/ScheduledAction.cpp:
  • bindings/js/ScriptController.cpp:
  • bindings/js/ScriptController.h:
  • bindings/js/ScriptDebugServer.cpp:
  • editing/Editor.h:
  • inspector/InspectorClient.cpp:
  • loader/FrameLoader.h:
  • loader/NavigationScheduler.h:
  • page/Console.cpp:
  • xml/XMLTreeViewer.cpp:
  • xml/XMLTreeViewer.h:

2011-05-01 Sam Weinig <sam@webkit.org>

Reviewed by Anders Carlsson.

Prune some unnecessary #includes
https://bugs.webkit.org/show_bug.cgi?id=59895

Start getting rid of unnecessary #includes and forward declares.

  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/WebPage/WebPage.cpp:
4:53 PM Changeset in webkit [85441] by Patrick Gansterer
  • 3 edits in trunk/Tools

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: Added missing header.
  • DumpRenderTree/win/UIDelegate.cpp: Ditto.
4:44 PM Changeset in webkit [85440] by Patrick Gansterer
  • 5 edits in trunk

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • WebView.cpp: (WebView::paint):

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: (FrameLoadDelegate::FrameLoadDelegate):
  • DumpRenderTree/win/UIDelegate.cpp: (DRTUndoManager::DRTUndoManager): (UIDelegate::UIDelegate): (UIDelegate::resetUndoManager):
4:29 PM Changeset in webkit [85439] by Patrick Gansterer
  • 5 edits in trunk/Source/WebKit2

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::startDragDrop):
  • UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp: (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore): (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
  • WebProcess/WebCoreSupport/win/WebDragClientWin.cpp: (WebKit::WebDragClient::startDrag):
  • WebProcess/WebPage/win/ChunkedUpdateDrawingAreaWin.cpp: (WebKit::ChunkedUpdateDrawingArea::paintIntoUpdateChunk):
4:09 PM Changeset in webkit [85438] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::createLayerForMovie):
3:53 PM Changeset in webkit [85437] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext): Added missing header.
3:45 PM Changeset in webkit [85436] by jschuh@chromium.org
  • 3 edits
    5 moves
    2 adds in trunk

2011-05-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840

  • fast/loader/stateobjects/pushstate-in-data-url-denied-expected.txt: Added.
  • fast/loader/stateobjects/pushstate-in-data-url-denied.html: Added.
  • fast/loader/stateobjects/replacestate-base-illegal-expected.txt: Removed.
  • fast/loader/stateobjects/replacestate-base-illegal.html: Removed.
  • fast/loader/stateobjects/replacestate-base-legal-expected.txt: Removed.
  • fast/loader/stateobjects/replacestate-base-legal.html: Removed.
  • fast/loader/stateobjects/resources/replacestate-base-pass.html: Removed.
  • http/tests/navigation/replacestate-base-illegal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal-expected.txt.
  • http/tests/navigation/replacestate-base-illegal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-illegal.html.
  • http/tests/navigation/replacestate-base-legal-expected.txt: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal-expected.txt.
  • http/tests/navigation/replacestate-base-legal.html: Copied from LayoutTests/fast/loader/stateobjects/replacestate-base-legal.html.
  • http/tests/navigation/resources/replacestate-base-pass.html: Copied from LayoutTests/fast/loader/stateobjects/resources/replacestate-base-pass.html.

2011-05-01 Justin Schuh <jschuh@chromium.org>

Reviewed by Adam Barth.

History::stateObjectAdded should check origin via SecurityOrigin::canRequest
https://bugs.webkit.org/show_bug.cgi?id=59840

Tests: fast/loader/stateobjects/pushstate-in-data-url-denied.html

http/tests/navigation/replacestate-base-illegal.html
http/tests/navigation/replacestate-base-legal.html

  • page/History.cpp: (WebCore::History::stateObjectAdded):
3:42 PM Changeset in webkit [85435] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

[WIN] Unreviewed buildfix after r85434.

  • platform/graphics/win/QTMovieVisualContext.cpp: (QTMovieVisualContext::QTMovieVisualContext):
3:30 PM Changeset in webkit [85434] by Patrick Gansterer
  • 2 edits in trunk/Source/JavaScriptCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Enable strict OwnPtr for PLATFORM(WIN)
https://bugs.webkit.org/show_bug.cgi?id=59881

  • wtf/OwnPtr.h:
3:28 PM Changeset in webkit [85433] by Patrick Gansterer
  • 7 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

[WINCE] Fix OwnPtr strict issues
https://bugs.webkit.org/show_bug.cgi?id=59898

  • page/wince/FrameWinCE.cpp: (WebCore::imageFromSelection):
  • platform/graphics/wince/FontPlatformData.cpp: (WebCore::FixedSizeFontData::create): (WebCore::FontPlatformPrivateData::FontPlatformData::hfont): (WebCore::FontPlatformPrivateData::FontPlatformData::getScaledFontHandle): (WebCore::FontPlatformPrivateData::FontPlatformData::discardFontHandle):
  • platform/graphics/wince/GraphicsContextWinCE.cpp: (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::drawRoundCorner): (WebCore::GraphicsContext::drawText):
  • platform/graphics/wince/ImageBufferWinCE.cpp: (WebCore::ImageBuffer::ImageBuffer):
  • platform/graphics/wince/ImageWinCE.cpp: (WebCore::BitmapImage::getHBITMAPOfSize):
  • platform/graphics/wince/SharedBitmap.cpp: (WebCore::SharedBitmap::SharedBitmap):
3:20 PM Changeset in webkit [85432] by barraclough@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

https://bugs.webkit.org/show_bug.cgi?id=59896
Remove JmpSrc/JmpDst types.

Reviewed by Sam Weinig.

The JmpSrc/JmpDst classes predate the MacroAssembler interface. Having these
object be per-assembler in unhelpful, causes unnecessary code duplication,
and prevents the AssemblerBuffer from providing a richer type for labels.
The limited semantic meaning that they did convey is undermined by the manner
in which their meanings have been overloaded (use of JmpSrc for Call, JmpDst
for data labels).

Jumps on ARMv7 have had additional information added to the object via the
ARMv7 JmpSrc. This data should probably be in the instruction stream. This
patch does not fix the problem, and moves the data (ifdefed) to
AbstractMacroAssembler::Jump (which is effectively where it was before!).
This at least closes the hole such that no further data may be added to JmpSrc,
but this is unfortunate, and should be cleaned up.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::align):
(JSC::ARMAssembler::loadBranchTarget):
(JSC::ARMAssembler::jmp):
(JSC::ARMAssembler::linkPointer):
(JSC::ARMAssembler::linkJump):
(JSC::ARMAssembler::linkCall):
(JSC::ARMAssembler::getRelocatedAddress):
(JSC::ARMAssembler::getDifferenceBetweenLabels):
(JSC::ARMAssembler::getCallReturnOffset):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::b):
(JSC::ARMv7Assembler::blx):
(JSC::ARMv7Assembler::bx):
(JSC::ARMv7Assembler::label):
(JSC::ARMv7Assembler::align):
(JSC::ARMv7Assembler::getRelocatedAddress):
(JSC::ARMv7Assembler::getDifferenceBetweenLabels):
(JSC::ARMv7Assembler::getCallReturnOffset):
(JSC::ARMv7Assembler::linkJump):
(JSC::ARMv7Assembler::linkCall):
(JSC::ARMv7Assembler::linkPointer):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::Label::isSet):
(JSC::AbstractMacroAssembler::Call::Call):
(JSC::AbstractMacroAssembler::Jump::Jump):
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
(JSC::AbstractMacroAssembler::linkPointer):
(JSC::AbstractMacroAssembler::getLinkerAddress):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerLabel::AssemblerLabel):
(JSC::AssemblerLabel::isSet):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::patch):

  • assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::label):
(JSC::MIPSAssembler::align):
(JSC::MIPSAssembler::getRelocatedAddress):
(JSC::MIPSAssembler::getDifferenceBetweenLabels):
(JSC::MIPSAssembler::getCallReturnOffset):
(JSC::MIPSAssembler::linkJump):
(JSC::MIPSAssembler::linkCall):
(JSC::MIPSAssembler::linkPointer):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchDouble):
(JSC::MacroAssemblerARMv7::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARMv7::jump):
(JSC::MacroAssemblerARMv7::nearCall):
(JSC::MacroAssemblerARMv7::call):
(JSC::MacroAssemblerARMv7::ret):
(JSC::MacroAssemblerARMv7::tailRecursiveCall):
(JSC::MacroAssemblerARMv7::makeBranch):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::nearCall):
(JSC::MacroAssemblerMIPS::call):
(JSC::MacroAssemblerMIPS::tailRecursiveCall):
(JSC::MacroAssemblerMIPS::branchTrue):
(JSC::MacroAssemblerMIPS::branchFalse):
(JSC::MacroAssemblerMIPS::branchEqual):
(JSC::MacroAssemblerMIPS::branchNotEqual):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::call):
(JSC::SH4Assembler::jmp):
(JSC::SH4Assembler::jne):
(JSC::SH4Assembler::je):
(JSC::SH4Assembler::label):
(JSC::SH4Assembler::align):
(JSC::SH4Assembler::linkJump):
(JSC::SH4Assembler::linkCall):
(JSC::SH4Assembler::linkPointer):
(JSC::SH4Assembler::getCallReturnOffset):
(JSC::SH4Assembler::getRelocatedAddress):
(JSC::SH4Assembler::getDifferenceBetweenLabels):
(JSC::SH4Assembler::patchPointer):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::call):
(JSC::X86Assembler::jmp):
(JSC::X86Assembler::jmp_r):
(JSC::X86Assembler::jne):
(JSC::X86Assembler::jnz):
(JSC::X86Assembler::je):
(JSC::X86Assembler::jz):
(JSC::X86Assembler::jl):
(JSC::X86Assembler::jb):
(JSC::X86Assembler::jle):
(JSC::X86Assembler::jbe):
(JSC::X86Assembler::jge):
(JSC::X86Assembler::jg):
(JSC::X86Assembler::ja):
(JSC::X86Assembler::jae):
(JSC::X86Assembler::jo):
(JSC::X86Assembler::jp):
(JSC::X86Assembler::js):
(JSC::X86Assembler::jCC):
(JSC::X86Assembler::label):
(JSC::X86Assembler::labelFor):
(JSC::X86Assembler::align):
(JSC::X86Assembler::linkJump):
(JSC::X86Assembler::linkCall):
(JSC::X86Assembler::linkPointer):
(JSC::X86Assembler::getCallReturnOffset):
(JSC::X86Assembler::getRelocatedAddress):
(JSC::X86Assembler::getDifferenceBetweenLabels):
(JSC::X86Assembler::rewindToLabel):
(JSC::X86Assembler::X86InstructionFormatter::immediateRel32):
(JSC::X86Assembler::X86InstructionFormatter::rewindToLabel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITInlineMethods.h:

(JSC::JIT::atJumpTarget):
(JSC::JIT::emitGetVirtualRegister):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_jmp):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_jsr):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_jmp_scopes):

2:15 PM Changeset in webkit [85431] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Can't open document from skydrive.com in Microsoft Word
https://bugs.webkit.org/show_bug.cgi?id=59891
<rdar://problem/9354285>

Add the AllowHalfBakedQuickDrawSupport quirk for the SharePoint plug-in.

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm: (WebKit::NetscapePluginModule::determineQuirks):
1:47 PM Changeset in webkit [85430] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Sam Weinig.

Don't try to create a backing store for a 0x0 plug-in
https://bugs.webkit.org/show_bug.cgi?id=59887

  • WebProcess/Plugins/PluginProxy.cpp: (WebKit::PluginProxy::geometryDidChange):
1:26 PM Changeset in webkit [85429] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

2011-05-01 Chao-ying Fu <fu@mips.com>

Reviewed by Eric Seidel.

Fix MIPS build due to the split of "Condition" enum
https://bugs.webkit.org/show_bug.cgi?id=59407

  • assembler/MIPSAssembler.h: (JSC::MIPSAssembler::debugOffset):
  • assembler/MacroAssemblerMIPS.h: (JSC::MacroAssemblerMIPS::branch32): (JSC::MacroAssemblerMIPS::compare32):
12:46 PM Changeset in webkit [85428] by rniwa@webkit.org
  • 6 edits in trunk/Source

2011-05-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837

Removed EventHandler::sendContextMenuEvent(NSEvent*) and EventHandler::eventMayStartDrag(NSEvent*)

  • WebCore.exp.in:
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

2011-05-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Get rid of versions of sendContextMenuEvent and eventMayStartDrag that takes NSEvent
https://bugs.webkit.org/show_bug.cgi?id=59837

Call sendContextMenuEvent and eventMayStartDrag with PlatformMouseEvent instead of NSEvent.

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]):
12:20 PM Changeset in webkit [85427] by eric@webkit.org
  • 2 edits
    2 moves
    2 adds in trunk/Tools

2011-05-01 Eric Seidel <eric@webkit.org>

Reviewed by Adam Barth.

Move scm.py into its own module in preparation for splitting it up
https://bugs.webkit.org/show_bug.cgi?id=59884

  • Scripts/webkitpy/common/checkout/scm/init.py: Added.
  • Scripts/webkitpy/common/checkout/scm/scm.py: Moved.
  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Moved.
  • Scripts/webkitpy/test/main.py:
12:15 PM Changeset in webkit [85426] by commit-queue@webkit.org
  • 2 edits in trunk

2011-05-01 ojab <ojab@ojab.ru>

Reviewed by Eric Seidel.

--disable-video-track if --disable-video
https://bugs.webkit.org/show_bug.cgi?id=59605

  • configure.ac:
12:10 PM Changeset in webkit [85425] by rniwa@webkit.org
  • 6 edits in trunk/Source

2011-05-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835

Moved currentKeyboardEvent.

  • WebCore.exp.in:
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm:

2011-05-01 Ryosuke Niwa <rniwa@webkit.org>

Reviewed by Eric Seidel.

Move currentKeyboardEvent from EventHandlerMac.mm to WebHTMLView.mm
https://bugs.webkit.org/show_bug.cgi?id=59835

Moved currentKeyboardEvent.

  • WebView/WebHTMLView.mm: (currentKeyboardEvent): (-[WebHTMLView becomeFirstResponder]):
11:58 AM Changeset in webkit [85424] by abarth@webkit.org
  • 2 edits in trunk/Tools

2011-05-01 Adam Barth <abarth@webkit.org>

Reviewed by Eric Seidel.

webkit-patch fails when not run from root
https://bugs.webkit.org/show_bug.cgi?id=59882

We need to set the CWD when running svn so that svn interprets file
paths relative to the root of the working copy.

  • Scripts/webkitpy/common/checkout/scm.py:
11:42 AM Changeset in webkit [85423] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 ojab <ojab@ojab.ru>

Reviewed by Eric Seidel.

Fix build with --disable-video --enable-fullscreen-api
https://bugs.webkit.org/show_bug.cgi?id=59698

  • rendering/RenderTheme.h: (WebCore::RenderTheme::extraFullScreenStyleSheet):
11:35 AM Changeset in webkit [85422] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

2011-05-01 Jeff Timanus <twiz@chromium.org>

Reviewed by Eric Seidel.

Add solid-color checking to BitmapImage::checkForSolidColour in the skia port.
https://bugs.webkit.org/show_bug.cgi?id=59041

Test:css2.1/t140201-c533-bgimage-00-a.html

  • platform/graphics/Image.cpp: (WebCore::Image::drawTiled): Removal of macro exclusion of assert for Skia path.
  • platform/graphics/skia/ImageSkia.cpp: (WebCore::BitmapImage::checkForSolidColor):
11:02 AM Changeset in webkit [85421] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Anders Carlsson <andersca@apple.com>

Reviewed by Kevin Decker.

Sandbox violation by WebProcess for DownloadAssessment.plist
https://bugs.webkit.org/show_bug.cgi?id=59879
<rdar://problem/9326041>

  • WebProcess/com.apple.WebProcess.sb: Allow reading ~/Library/Preferences/com.apple.DownloadAssessment.plist
10:47 AM Changeset in webkit [85420] by Patrick Gansterer
  • 13 edits in trunk/Source

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp: (WebCore::getDirtyRects):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: (WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
  • platform/graphics/win/WKCAImageQueue.cpp: (WebCore::WKCAImageQueue::WKCAImageQueue):
  • platform/win/CursorWin.cpp: (WebCore::createSharedCursor):
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Adam Barth.

Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878

  • FullscreenVideoController.cpp: (FullscreenVideoController::FullscreenVideoController): (FullscreenVideoController::createHUDWindow):
  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::highlight):
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag):
  • WebNodeHighlight.cpp: (WebNodeHighlight::update):
  • WebNotificationCenter.cpp: (WebNotificationCenter::WebNotificationCenter):
  • WebView.cpp: (WebView::close): (WebView::paint): (WebView::handleMouseEvent): (WebView::registerEmbeddedViewMIMEType):
10:43 AM Changeset in webkit [85419] by Patrick Gansterer
  • 5 edits in trunk/Source/WebCore

2011-05-01 Patrick Gansterer <Patrick Gansterer>

Reviewed by Eric Seidel.

Use PassOwnPtr as return value of GraphicsContext::createWindowsBitmap
https://bugs.webkit.org/show_bug.cgi?id=59876

Also pass the size "as reference" instead of "as value".

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/win/FontCGWin.cpp: (WebCore::drawGDIGlyphs):
  • platform/graphics/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap):
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::paint):
10:30 AM Changeset in webkit [85418] by eae@chromium.org
  • 3 edits
    2 adds in trunk

2011-05-01 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111

Add test to verify that getComputedStyle returns length properties with a unit.

  • fast/css/getComputedStyle/getComputedStyle-length-unit-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-length-unit.html: Added.

2011-05-01 Emil A Eklund <eae@chromium.org>

Reviewed by Eric Seidel.

getComputedStyle() returns unitless values for some properties that require units
https://bugs.webkit.org/show_bug.cgi?id=55111

Change getComputedStyle to return value with unit for -webkit-column-width, -webkit-column-gap and -webkit-perspective

Test: fast/css/getComputedStyle/getComputedStyle-length-unit.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
10:25 AM Changeset in webkit [85417] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 Young Han Lee <joybro@company100.net>

Reviewed by Eric Seidel.

Change TEXMAP_OPENGL_ES2 to TEXMAP_OPENGL_ES_2
https://bugs.webkit.org/show_bug.cgi?id=59608

TEXMAP_OPENGL_ES2 is a wrong name. TEXMAP_OPENGL_ES_2 is already defined in TextureMapper.h

No new functionality, no new tests.

  • platform/graphics/opengl/TextureMapperGL.cpp: (WebCore::TextureMapperGL::TextureMapperGL):
10:08 AM Changeset in webkit [85416] by yael.aharon@nokia.com
  • 3 edits
    2 adds in trunk

2011-05-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943

  • fast/css/nth-child-n-expected.txt: Added.
  • fast/css/nth-child-n.html: Added.

2011-05-01 Yael Aharon <yael.aharon@nokia.com>

Reviewed by Eric Seidel.

CSS3 nth-child(n) selector fails
https://bugs.webkit.org/show_bug.cgi?id=56943

Regression from r75158.
"n" is a valid parameter to nth() and should be allowed.

Test: fast/css/nth-child-n.html

  • css/CSSParser.cpp: (WebCore::isValidNthToken):
9:09 AM Changeset in webkit [85415] by pfeldman@chromium.org
  • 3 edits in trunk/Source/WebCore

2011-05-01 Pavel Feldman <pfeldman@chromium.org>

Not reviewed: address stack frame scriptName -> url rename in timeline panel.

  • inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails): (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):
9:07 AM Changeset in webkit [85414] by Chris Fleizach
  • 2 edits in trunk/Source/WebCore

2011-05-01 Chris Fleizach <Chris Fleizach>

Reviewed by Maciej Stachowiak.

Crash in AccessibilityRenderObject while viewing PDFs in iframes
https://bugs.webkit.org/show_bug.cgi?id=59629

Could not reproduce this crash, but it's quite clear how it could happen.

  • accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityHitTest):
7:38 AM Changeset in webkit [85413] by Nikolas Zimmermann
  • 14 edits
    6 adds in trunk

2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072

Add testcase that used to leak, the leaks bot will assure they won't in future.

  • svg/custom/pending-resource-leak-2-expected.txt: Added.
  • svg/custom/pending-resource-leak-2.svg: Added.
  • svg/custom/pending-resource-leak-3-expected.txt: Added.
  • svg/custom/pending-resource-leak-3.svg: Added.
  • svg/custom/pending-resource-leak-expected.txt: Added.
  • svg/custom/pending-resource-leak.svg: Added.

2011-05-01 Nikolas Zimmermann <nzimmermann@rim.com>

Reviewed by Dirk Schulze.

LEAK: SVGElement leaks when detaching it in a pending resource state
https://bugs.webkit.org/show_bug.cgi?id=59072

Make the pending resources set non-refcounted again. We made it refcounted a while ago
to fix a security bug, as we had dangling pointers in the set in SVGDocumentExtensions.
Fix the underlying problem, by removing all pending resources referencing to a particular
SVGElement, upon its destruction or upon removing it from the document.

Example: <rect fill="url(#foo)" id="rect">
When we try to render the rect, the foo paint server can't be found and thus "foo" will be
added to the pending resource set, with "rect" as client. When "foo" appears, it would remove
itself from the pending resource set, and a ref count to the "rect" would be released.
If "foo" never appears, SVGDocumentExtensions still holds a ref to the <rect>, thus keeping
it and the associated document alive.

Tests: svg/custom/pending-resource-leak-2.svg

svg/custom/pending-resource-leak-3.svg
svg/custom/pending-resource-leak.svg

These tests cover several scenarios where we used to leak. Should fix several SVG*Element leaks on the bots.
I manually tested reloading above testcases dozens of times, before the leak count was incremented by 2 nodes on every reload, that's gone now.

  • rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource):
  • rendering/svg/RenderSVGShadowTreeRootContainer.cpp: (WebCore::RenderSVGShadowTreeRootContainer::updateFromElement):
  • rendering/svg/SVGResources.cpp: (WebCore::registerPendingResource):
  • svg/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::addPendingResource): (WebCore::SVGDocumentExtensions::hasPendingResources): (WebCore::SVGDocumentExtensions::removeElementFromPendingResources): (WebCore::SVGDocumentExtensions::removePendingResource):
  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp:
  • svg/SVGElement.h:
  • svg/SVGElementRareData.h: (WebCore::SVGElementRareData::SVGElementRareData): (WebCore::SVGElementRareData::hasPendingResources): (WebCore::SVGElementRareData::setHasPendingResources):
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::~SVGStyledElement): (WebCore::SVGStyledElement::insertedIntoDocument): (WebCore::SVGStyledElement::removedFromDocument): (WebCore::SVGStyledElement::hasPendingResources): (WebCore::SVGStyledElement::setHasPendingResources):
  • svg/SVGStyledElement.h: (WebCore::SVGStyledElement::needsPendingResourceHandling): (WebCore::SVGStyledElement::buildPendingResource):
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::SVGUseElement): (WebCore::SVGUseElement::insertedIntoDocument): (WebCore::SVGUseElement::svgAttributeChanged): (WebCore::SVGUseElement::buildPendingResource):
  • svg/SVGUseElement.h:
7:12 AM Changeset in webkit [85412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

2011-05-01 Rafael Brandao <rafael.lobo@openbossa.org>

Reviewed by Csaba Osztrogonác.

[Qt] build-webkit warning Inspector.idl is missing
https://bugs.webkit.org/show_bug.cgi?id=59047

Added variable_out to pipe output from one compiler to another,
and then forced the output to be added to the sources.

  • CodeGenerators.pri:
2:19 AM Changeset in webkit [85411] by mitz@apple.com
  • 5 edits
    3 adds in trunk

<rdar://problem/9155067> REGRESSION (float-based line boxes): Gaps and overlaps in selection highlight
https://bugs.webkit.org/show_bug.cgi?id=56658

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/text/selection-rect-rounding.html

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::selectionRectForSimpleText): Account for non-integral anchor point coordinates.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::selectionRectForComplexText): Ditto.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionRect): Floor the horizontal sides of the clip rect.
(WebCore::InlineTextBox::paintSelection): Pass the logical left location to Font::selectionRectForText(),
since it affects rounding.

LayoutTests:

  • fast/text/selection-rect-rounding.html: Added.
  • platform/mac/fast/text/selection-rect-rounding-expected.png: Added.
  • platform/mac/fast/text/selection-rect-rounding-expected.txt: Added.
1:09 AM Changeset in webkit [85410] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Ivan Krstić <ike@apple.com>

Reviewed by Maciej Stachowiak.

Remove unnecessary keychain and CoreAudio debris from WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=59873

These rules have been obsoleted by <rdar://problem/9301520> and
<rdar://problem/9181468>.

  • WebProcess/com.apple.WebProcess.sb:
12:45 AM Changeset in webkit [85409] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Ivan Krstić <ike@apple.com>

Reviewed by Maciej Stachowiak.

Simplify WebProcess sandbox with homedir-relative path filters.
https://bugs.webkit.org/show_bug.cgi?id=59872

  • WebProcess/com.apple.WebProcess.sb:
12:28 AM Changeset in webkit [85408] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-05-01 Ivan Krstić <ike@apple.com>

Reviewed by Maciej Stachowiak.

On-demand VPN support for sandboxed WebProcess.
<rdar://problem/8994181>

  • WebProcess/com.apple.WebProcess.sb:
12:10 AM Changeset in webkit [85407] by ike@apple.com
  • 2 edits in trunk/Source/WebKit2

2011-04-30 Ivan Krstić <ike@apple.com>

Reviewed by Sam Weinig.

Reindent WebProcess sandbox to standard scheme style
https://bugs.webkit.org/show_bug.cgi?id=59870

  • WebProcess/com.apple.WebProcess.sb:
Note: See TracTimeline for information about the timeline view.