Context Navigation

← Previous Period
Next Period →

Timeline

Oct 16, 2011:

11:32 PM Changeset in webkit [97589] by abarth@webkit.org

4 edits in trunk/Source

Always disable ENABLE(ON_FIRST_TEXTAREA_FOCUS_SELECT_ALL) and delete associated code
https://bugs.webkit.org/show_bug.cgi?id=70216

Reviewed by Eric Seidel.

Source/JavaScriptCore:

wtf/Platform.h:

Source/WebCore:

No port enables this feature. It was added for the previous Android
port (and should have been an editing behavior in any case).

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::updateFocusAppearance):

11:29 PM Changeset in webkit [97588] by wjmaclean@chromium.org

3 edits
1 add in trunk/LayoutTests

[chromium] Rebaseline layout test zoom-animator-scale-test2.html for win, mac
https://bugs.webkit.org/show_bug.cgi?id=69624

Reviewed by Kent Tamura.

Also modifies timeout in zoom-animator-scale-test2.html to try and reduce flake, generate
win baselines.

platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
platform/chromium/compositing/zoom-animator-scale-test2.html:
platform/chromium/test_expectations.txt:

11:05 PM Changeset in webkit [97587] by rniwa@webkit.org

8 edits
2 adds in trunk

Expose rangeFromLocationAndLength and locationAndLengthFromRange via internals object
https://bugs.webkit.org/show_bug.cgi?id=68330

Reviewed by Hajime Morita.

Source/WebCore:

Add rangeFromLocationAndLength, locationFromRange, and lengthFromRange to window.internals.

Test: editing/text-iterator/range-to-from-location-and-length.html

WebCore.exp.in:
testing/Internals.cpp:

(WebCore::Internals::scrollElementToRect):
(WebCore::Internals::rangeFromLocationAndLength):
(WebCore::Internals::locationFromRange):
(WebCore::Internals::lengthFromRange):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

Add a basic test that uses internals.rangeFromLocationAndLength, internals.locationFromRange,
and internals.lengthFromRange.

editing/text-iterator/range-to-from-location-and-length-expected.txt: Added.
editing/text-iterator/range-to-from-location-and-length.html: Added.

11:02 PM Changeset in webkit [97586] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Generate MessageChannel constructor by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70214

Reviewed by Adam Barth.

This patch generates an MessageChannel constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires special logic.

Tests: fast/dom/global-constructors.html

fast/events/message-port.html
fast/events/message-port-no-wrapper.html
fast/dom/Window/window-postmessage-args.html

bindings/js/JSMessageChannelCustom.cpp: Removed the MessageChannel constructor.
dom/MessageChannel.idl: Generates the MessageChannel constructor for JSC.

10:44 PM Changeset in webkit [97585] by rniwa@webkit.org

4 edits in trunk/Source/WebCore

[Mac] fontForSelection and styleForSelectionStart should be moved to EditorMac
https://bugs.webkit.org/show_bug.cgi?id=70114

Reviewed by Hajime Morita.

Moved fontForSelection and styleForSelectionStart from Editor to EditorMac
and made styleForSelectionStart static local.

editing/Editor.cpp:
editing/Editor.h:
editing/mac/EditorMac.mm:

(WebCore::styleForSelectionStart):
(WebCore::Editor::fontForSelection):
(WebCore::Editor::fontAttributesForSelectionStart):

10:06 PM Changeset in webkit [97584] by haraken@chromium.org

8 edits
1 delete in trunk/Source/WebCore

Generate EventSource constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70212

Reviewed by Adam Barth.

Removed JSEventSourceCustom.cpp.

Tests: fast/dom/global-constructors.html

fast/eventsource/eventsource-constructor.html
fast/eventsource/eventsource-attribute-listeners.html

GNUmakefile.list.am: Removed JSEventSourceCustom.cpp.
UseJSC.cmake: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/JSBindingsAllInOne.cpp: Ditto.
bindings/js/JSEventSourceCustom.cpp: Removed this file.
page/EventSource.idl: Removed 'JSCustomConstructor' IDL.

9:27 PM Changeset in webkit [97583] by commit-queue@webkit.org

11 edits
1 delete in trunk/Source/WebCore

Inline CSSPrimitiveValue::isQuirkValue() as non-virtual function
https://bugs.webkit.org/show_bug.cgi?id=64865

Patch by David Barr <davidbarr@chromium.org> on 2011-10-16
Reviewed by Darin Adler.

Based on profiling and patch from:
Tamas Czene <Czene.Tamas@stud.u-szeged.hu>

This is expected to produce a small performance progression.
Additional memory overhead is avoided by using spare bits.
CSSQuirkPrimitiveValue is removed as it becomes just a factory.

GNUmakefile.list.am:
WebCore.gypi:
WebCore.order:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
css/CSSParser.cpp:

(WebCore::CSSParser::parseValidPrimitive):

css/CSSParserValues.cpp:

(WebCore::CSSParserValue::createCSSValue):

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::createAllowingMarginQuirk):
Moved from CSSQuirkPrimitiveValue::create.
(WebCore::CSSPrimitiveValue::isQuirkValue):

css/CSSQuirkPrimitiveValue.h: Removed.
css/SVGCSSParser.cpp:

(WebCore::CSSParser::parseSVGValue):

9:03 PM Changeset in webkit [97582] by tkent@chromium.org

16 edits
72 moves
252 adds
123 deletes in trunk/LayoutTests

Update test exepctations.

Add baseline files for new tests
Update for Skia focus ring change
Update for Mac spelling underline change
Optimize test results for them

css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt.
css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt.
editing/deleting/delete-3959464-fix-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-3959464-fix-expected.txt.
editing/deleting/delete-block-contents-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-block-contents-003-expected.txt.
editing/deleting/delete-trailing-ws-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt.
editing/deleting/delete-ws-fixup-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt.
editing/inserting/insert-br-004-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-004-expected.txt.
editing/inserting/insert-br-005-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-005-expected.txt.
editing/inserting/insert-br-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-br-007-expected.txt.
editing/inserting/insert-div-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-007-expected.txt.
editing/inserting/insert-div-012-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-012-expected.txt.
editing/inserting/insert-div-013-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-013-expected.txt.
editing/inserting/insert-div-014-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-014-expected.txt.
editing/inserting/insert-div-015-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-015-expected.txt.
editing/inserting/insert-div-016-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-016-expected.txt.
editing/inserting/insert-div-017-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-017-expected.txt.
editing/inserting/insert-div-018-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-018-expected.txt.
editing/inserting/insert-div-019-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-019-expected.txt.
editing/inserting/insert-div-020-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-020-expected.txt.
editing/inserting/insert-div-022-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-022-expected.txt.
editing/inserting/insert-div-025-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-025-expected.txt.
editing/inserting/insert-div-027-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-div-027-expected.txt.
editing/inserting/insert-tab-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-tab-002-expected.txt.
editing/inserting/insert-tab-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/insert-tab-003-expected.txt.
editing/inserting/return-key-with-selection-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-001-expected.txt.
editing/inserting/return-key-with-selection-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-002-expected.txt.
editing/inserting/return-key-with-selection-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/return-key-with-selection-003-expected.txt.
editing/inserting/typing-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/typing-002-expected.txt.
editing/inserting/typing-around-br-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/inserting/typing-around-br-001-expected.txt.
editing/pasteboard/paste-text-013-expected.txt: Removed.
editing/pasteboard/paste-text-019-expected.txt: Renamed from LayoutTests/platform/gtk/editing/pasteboard/paste-text-019-expected.txt.
editing/selection/extend-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/extend-by-word-001-expected.txt.
editing/selection/move-backwords-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt.
editing/selection/move-by-character-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-character-001-expected.txt.
editing/selection/move-by-line-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-line-001-expected.txt.
editing/selection/move-by-word-001-expected.txt: Renamed from LayoutTests/platform/gtk/editing/selection/move-by-word-001-expected.txt.
editing/style/block-styles-007-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/block-styles-007-expected.txt.
editing/style/create-block-for-style-002-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-002-expected.txt.
editing/style/create-block-for-style-003-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-003-expected.txt.
editing/style/create-block-for-style-004-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-004-expected.txt.
editing/style/create-block-for-style-006-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-006-expected.txt.
editing/style/create-block-for-style-008-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-008-expected.txt.
editing/style/create-block-for-style-009-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-009-expected.txt.
editing/style/create-block-for-style-011-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-011-expected.txt.
editing/style/create-block-for-style-012-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-012-expected.txt.
editing/style/create-block-for-style-013-expected.txt: Renamed from LayoutTests/platform/gtk/editing/style/create-block-for-style-013-expected.txt.
platform/chromium-cg-mac-leopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/height-width-table-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-3928305-fix-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-3959464-fix-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-and-undo-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-block-contents-003-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-tab-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-tab-003-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-to-select-table-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png:
platform/chromium-cg-mac-leopard/editing/execCommand/5569741-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png:
platform/chromium-cg-mac-leopard/editing/inserting/5418891-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/editing-empty-divs-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-br-004-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-br-005-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-br-007-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-007-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-012-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-013-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-014-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-015-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-016-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-017-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-018-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-019-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-020-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-022-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-025-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-div-027-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-paragraph-02-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-paragraph-03-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-tab-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-tab-003-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-01-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-02-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/paragraph-separator-03-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/typing-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/inserting/typing-around-br-001-expected.png:
platform/chromium-cg-mac-leopard/editing/pasteboard/4242293-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/pasteboard/8145-2-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/pasteboard/cut-text-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-1-expected.png:
platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-2-expected.png:
platform/chromium-cg-mac-leopard/editing/pasteboard/merge-after-delete-expected.png:
platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-013-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-014-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/pasteboard/paste-text-019-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/13804-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/5234383-1-expected.png:
platform/chromium-cg-mac-leopard/editing/selection/5234383-2-expected.png:
platform/chromium-cg-mac-leopard/editing/selection/extend-by-word-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/move-by-character-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/move-by-line-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/move-by-word-001-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
platform/chromium-cg-mac-leopard/editing/selection/unrendered-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/spelling/inline_spelling_markers-expected.png:
platform/chromium-cg-mac-leopard/editing/spelling/spelling-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/5046875-2-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/block-styles-007-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-002-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-003-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-004-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-006-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-008-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-009-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-011-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-012-expected.png: Added.
platform/chromium-cg-mac-leopard/editing/style/create-block-for-style-013-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-3928305-fix-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/execCommand/5569741-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/5418891-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-007-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-012-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-013-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-014-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-015-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-016-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-017-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-018-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-019-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-020-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-022-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-div-027-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/4242293-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/8145-2-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-013-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-014-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/13804-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/5234383-1-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/5234383-2-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/spelling/spelling-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/5046875-2-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-002-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-003-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-004-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-006-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-008-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-009-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/style/create-block-for-style-013-expected.png: Added.
platform/chromium-cg-mac/editing/deleting/delete-tab-003-expected.png: Removed.
platform/chromium-cg-mac/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
platform/chromium-cg-mac/editing/deleting/delete-ws-fixup-002-expected.png: Removed.
platform/chromium-cg-mac/editing/inserting/insert-tab-003-expected.png: Removed.
platform/chromium-cg-mac/editing/inserting/typing-around-br-001-expected.png: Removed.
platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-1-expected.png: Removed.
platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-2-expected.png: Removed.
platform/chromium-cg-mac/editing/pasteboard/merge-after-delete-expected.png: Removed.
platform/chromium-cg-mac/editing/selection/5234383-1-expected.png: Removed.
platform/chromium-cg-mac/editing/selection/5234383-2-expected.png: Removed.
platform/chromium-cg-mac/editing/selection/select-from-textfield-outwards-expected.png: Removed.
platform/chromium-cg-mac/editing/spelling/inline_spelling_markers-expected.png: Removed.
platform/chromium-cg-mac/editing/style/create-block-for-style-006-expected.png: Removed.
platform/chromium-cg-mac/editing/style/create-block-for-style-011-expected.png: Removed.
platform/chromium-cg-mac/editing/style/create-block-for-style-012-expected.png: Removed.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Removed.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Removed.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
platform/chromium-mac-leopard/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/height-width-table-001-expected.png: Added.
platform/chromium-mac-leopard/editing/deleting/delete-3928305-fix-expected.png: Added.
platform/chromium-mac-leopard/editing/deleting/delete-to-select-table-expected.png: Added.
platform/chromium-mac-leopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
platform/chromium-mac-leopard/editing/execCommand/5569741-expected.png: Added.
platform/chromium-mac-leopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
platform/chromium-mac-leopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/5418891-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/editing-empty-divs-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/insert-paragraph-02-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/insert-paragraph-03-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/paragraph-separator-01-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/paragraph-separator-02-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/paragraph-separator-03-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/4242293-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/8145-2-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/merge-after-delete-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
platform/chromium-mac-leopard/editing/pasteboard/paste-text-013-expected.png: Added.
platform/chromium-mac-leopard/editing/pasteboard/paste-text-014-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/13804-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/5234383-1-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/5234383-2-expected.png: Added.
platform/chromium-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
platform/chromium-mac-leopard/editing/spelling/inline_spelling_markers-expected.png: Added.
platform/chromium-mac-leopard/editing/spelling/spelling-expected.png: Added.
platform/chromium-mac-leopard/editing/style/5046875-2-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-3928305-fix-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/deleting/delete-3928305-fix-expected.png.
platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png: Added.
platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png: Added.
platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-007-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-007-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-012-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-012-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-013-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-014-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-014-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-015-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-015-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-016-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-016-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-017-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-017-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-018-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-018-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-019-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-019-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-020-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-020-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-022-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-022-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-div-027-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/inserting/insert-div-027-expected.png.
platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png: Added.
platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-013-expected.png.
platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-014-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/pasteboard/paste-text-014-expected.png.
platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/13804-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png: Added.
platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png: Added.
platform/chromium-mac-snowleopard/editing/spelling/inline_spelling_markers-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/spelling/inline_spelling_markers-expected.png.
platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png: Added.
platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png: Added.
platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png: Added.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-002-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-002-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-003-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-003-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-004-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-004-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-006-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-006-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-008-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-008-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-009-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-009-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-011-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-011-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-012-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-012-expected.png.
platform/chromium-mac-snowleopard/editing/style/create-block-for-style-013-expected.png: Renamed from LayoutTests/platform/chromium-mac/editing/style/create-block-for-style-013-expected.png.
platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-and-undo-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-tab-002-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-tab-003-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png: Removed.
platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png: Removed.
platform/chromium-mac/editing/execCommand/5569741-expected.png: Removed.
platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png: Removed.
platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png: Removed.
platform/chromium-mac/editing/inserting/5418891-expected.png: Removed.
platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-br-004-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-br-005-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-br-007-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-div-025-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-tab-002-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-tab-003-expected.png: Removed.
platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png: Removed.
platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png: Removed.
platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png: Removed.
platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png: Removed.
platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png: Removed.
platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png: Removed.
platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png: Removed.
platform/chromium-mac/editing/inserting/typing-002-expected.png: Removed.
platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/4242293-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/8145-2-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png: Removed.
platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png: Removed.
platform/chromium-mac/editing/selection/13804-expected.png: Removed.
platform/chromium-mac/editing/selection/5234383-1-expected.png: Removed.
platform/chromium-mac/editing/selection/5234383-2-expected.png: Removed.
platform/chromium-mac/editing/selection/extend-by-word-001-expected.png: Removed.
platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png: Removed.
platform/chromium-mac/editing/selection/move-by-character-001-expected.png: Removed.
platform/chromium-mac/editing/selection/move-by-line-001-expected.png: Removed.
platform/chromium-mac/editing/selection/move-by-word-001-expected.png: Removed.
platform/chromium-mac/editing/selection/select-from-textfield-outwards-expected.png: Removed.
platform/chromium-mac/editing/selection/unrendered-002-expected.png: Removed.
platform/chromium-mac/editing/spelling/spelling-expected.png: Removed.
platform/chromium-mac/editing/style/5046875-2-expected.png: Removed.
platform/chromium-mac/editing/style/block-styles-007-expected.png: Removed.
platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
platform/chromium-win/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
platform/chromium-win/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/height-width-inline-table-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt.
platform/chromium-win/css2.1/20110323/height-width-table-001-expected.png: Added.
platform/chromium-win/css2.1/20110323/height-width-table-001-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt.
platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
platform/chromium/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added.
platform/chromium/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added.
platform/chromium/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
platform/chromium/css2.1/20110323/height-width-table-001-expected.png: Added.
platform/chromium/test_expectations.txt:
platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
platform/mac/editing/deleting/delete-block-contents-003-expected.txt: Removed.
platform/mac/editing/deleting/delete-trailing-ws-002-expected.txt: Removed.
platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
platform/mac/editing/inserting/insert-br-004-expected.txt: Removed.
platform/mac/editing/inserting/insert-br-005-expected.txt: Removed.
platform/mac/editing/inserting/insert-br-007-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-007-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-012-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-013-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-014-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-015-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-016-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-017-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-018-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-019-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-020-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-022-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-025-expected.txt: Removed.
platform/mac/editing/inserting/insert-div-027-expected.txt: Removed.
platform/mac/editing/inserting/insert-tab-002-expected.txt: Removed.
platform/mac/editing/inserting/insert-tab-003-expected.txt: Removed.
platform/mac/editing/inserting/return-key-with-selection-001-expected.txt: Removed.
platform/mac/editing/inserting/return-key-with-selection-002-expected.txt: Removed.
platform/mac/editing/inserting/return-key-with-selection-003-expected.txt: Removed.
platform/mac/editing/inserting/typing-002-expected.txt: Removed.
platform/mac/editing/inserting/typing-around-br-001-expected.txt: Removed.
platform/mac/editing/pasteboard/paste-text-019-expected.txt: Removed.
platform/mac/editing/selection/extend-by-word-001-expected.txt: Removed.
platform/mac/editing/selection/move-backwords-by-word-001-expected.txt: Removed.
platform/mac/editing/selection/move-by-character-001-expected.txt: Removed.
platform/mac/editing/selection/move-by-line-001-expected.txt: Removed.
platform/mac/editing/selection/move-by-word-001-expected.txt: Removed.
platform/mac/editing/style/block-styles-007-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-002-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-003-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-004-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-006-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-008-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-009-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-011-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-012-expected.txt: Removed.
platform/mac/editing/style/create-block-for-style-013-expected.txt: Removed.
platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Removed.
platform/qt/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Removed.
platform/win/editing/inserting/insert-div-013-expected.txt: Removed.
platform/win/editing/inserting/insert-div-015-expected.txt: Removed.
platform/win/editing/inserting/insert-div-019-expected.txt: Removed.
platform/win/editing/inserting/insert-paragraph-03-expected.txt: Removed.
platform/win/editing/selection/move-by-word-001-expected.txt: Removed.
platform/win/editing/style/create-block-for-style-008-expected.txt: Removed.

8:13 PM Changeset in webkit [97581] by haraken@chromium.org

6 edits in trunk/Source/WebCore

Generate XMLHttpRequest constructor for JSC by [Constructor] IDL
https://bugs.webkit.org/show_bug.cgi?id=70208

Reviewed by Adam Barth.

This patch generates an XMLHttpRequest constructor for JSC by [Constructor] IDL,
but V8 is still using a custom constructor since the V8 constructor requires a special logic.

Tests: fast/dom/global-constructors.html

fast/dom/XMLHttpRequest-constants.html
fast/dom/xmlhttprequest-constructor-in-detached-document.html
http/tests/security/cookies/xmlhttprequest.html

bindings/js/JSXMLHttpRequestCustom.cpp: Removed an XMLHttpRequest custom constructor.
bindings/scripts/CodeGeneratorV8.pm: Currently, CodeGeneratorV8.pm generates constructor code whenever [Constructor] is specified, even if [V8CustomConstructor] is specified. This is wrong. This patch fixes the condition where the constructor code is generated.
bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-binding-tests result.
xml/XMLHttpRequest.h: Added a necessary header.
xml/XMLHttpRequest.idl: V8 is still using a custom constructor.

7:02 PM Changeset in webkit [97580] by haraken@chromium.org

3 edits in trunk/Source/WebCore

Generate XSLTProcessor constructor for JSC by [Constructor] IDL.
https://bugs.webkit.org/show_bug.cgi?id=70206

Reviewed by Adam Barth.

Tests: fast/xsl/xslt-processor.html

fast/xsl/default-html.html
fast/dom/global-constructors.html

bindings/js/JSXSLTProcessorCustom.cpp: Removed a custom constructor.
xml/XSLTProcessor.idl: Removed 'JSCustomConstructor'.

6:11 PM Changeset in webkit [97579] by noel.gordon@gmail.com

2 edits in trunk/Source/JavaScriptCore

[chromium] Remove PageAllocatorSymbian.h, OSAllocatorSymbian.cpp, gtk/ThreadingGtk.cpp from gyp project files
https://bugs.webkit.org/show_bug.cgi?id=70205

Reviewed by James Robinson.

wtf/PageAllocatorSymbian.h and wtf/OSAllocatorSymbian.cpp were removed in r97557.
wtf/gtk/ThreadingGtk.cpp was removed in r97269.

JavaScriptCore.gypi:

4:30 PM Changeset in webkit [97578] by haraken@chromium.org

10 edits in trunk/Source/WebCore

Support [Constructor] IDL for JSC.
https://bugs.webkit.org/show_bug.cgi?id=70101

Reviewed by Adam Barth.

The spec for [Constructor] IDL is here: http://www.w3.org/TR/WebIDL/#Constructor
This patch introduced [Constructor] IDL for JSC. This patch also added
[ConstructorRaisesException] for JSC. If [ConstructorRaisesException] is specified,
a placeholder for ExceptionCode is passed to XXX::create(), like XXX::create(..., ec).

Notes:

We do not yet support constructor overloading.
We do not yet support [Optional] without CallWithDefaultValue for constructor arguments.

Tests: Source/WebCore/bindings/scripts/test/TestInterface.idl

Source/WebCore/bindings/scripts/test/TestObj.idl

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader): Generates constructor declaration code to a header file, if a given DOM object has constructor.
(GenerateImplementation): Uses GenerateArgumentsCountCheck() and GenerateParametersCheck().
(GenerateArgumentsCountCheck): Splits out of GenerateImplementation() for reuse.
(GenerateParametersCheck): Splits out of GenerateImplementation() for reuse.
(GenerateConstructorDefinition): Generates constructor definition code.

bindings/scripts/test/JS/JSTestInterface.cpp: Updated the run-binding-tests results.

(WebCore::JSTestInterfaceConstructor::constructJSTestInterface):

bindings/scripts/test/JS/JSTestInterface.h: Ditto.

(WebCore::JSTestInterfaceConstructor::create):
(WebCore::JSTestInterfaceConstructor::createStructure):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.

(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h: Ditto.

(WebCore::JSTestMediaQueryListListenerConstructor::create):
(WebCore::JSTestMediaQueryListListenerConstructor::createStructure):

bindings/scripts/test/JS/JSTestObj.cpp: Ditto.

(WebCore::jsTestObjPrototypeFunctionVoidMethod):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionIntMethod):
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethod):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgs):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionSerializedValue):
(WebCore::jsTestObjPrototypeFunctionIdbKey):
(WebCore::jsTestObjPrototypeFunctionOptionsObject):
(WebCore::jsTestObjPrototypeFunctionMethodWithException):
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException):
(WebCore::jsTestObjPrototypeFunctionAddEventListener):
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrame):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture):
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContext):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg):
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackAndOptionalArg):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod1):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod2):
(WebCore::jsTestObjPrototypeFunctionConditionalMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5):
(WebCore::jsTestObjPrototypeFunctionClassMethod):
(WebCore::jsTestObjPrototypeFunctionClassMethodWithOptional):

bindings/scripts/test/JS/JSTestObj.h: Ditto.

(WebCore::JSTestObjConstructor::create):
(WebCore::JSTestObjConstructor::createStructure):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: Ditto.
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h: Ditto.

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::createStructure):

2:37 PM Changeset in webkit [97577] by Csaba Osztrogonác

2 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed weekend gardening.

platform/qt/fast/dom/Window/window-properties-expected.txt:
platform/qt/fast/files/url-required-arguments-expected.txt: Added.

12:19 PM Changeset in webkit [97576] by dslomov@google.com

10 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70186
Pass MessagePortArray to JSC's SerializedScriptValue::serialize/deserialize.

Reviewed by Oliver Hunt.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::handlePostMessage):
(WebCore::JSDOMWindow::postMessage):
(WebCore::JSDOMWindow::webkitPostMessage):

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::pushState):
(WebCore::JSHistory::replaceState):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):
(WebCore::handleInitMessageEvent):
(WebCore::JSMessageEvent::initMessageEvent):
(WebCore::JSMessageEvent::webkitInitMessageEvent):

bindings/js/JSMessagePortCustom.h:

(WebCore::handlePostMessage):

bindings/js/JSPopStateEventCustom.cpp:

(WebCore::JSPopStateEvent::state):

bindings/js/ScriptValue.cpp:

(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::deserialize):

bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

bindings/js/SerializedScriptValue.h:

8:55 AM Changeset in webkit [97575] by mitz@apple.com

3 edits
3 adds in trunk

REGRESSION (r96620): Float-avoiding block positioned incorrectly in right-to-left block
https://bugs.webkit.org/show_bug.cgi?id=70197

Reviewed by Dave Kilzer.

Source/WebCore:

Test: fast/block/float/avoidance-rtl.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Changed
logicalLeftOffsetForContent() to startOffsetForContent() to get the right value in the
right-to-left case.

LayoutTests:

fast/block/float/avoidance-rtl-expected.png: Added.
fast/block/float/avoidance-rtl-expected.txt: Added.
fast/block/float/avoidance-rtl.html: Added.

3:28 AM Changeset in webkit [97574] by abarth@webkit.org

113 edits in trunk

Always enable ENABLE(DOM_STORAGE)
https://bugs.webkit.org/show_bug.cgi?id=70189

Reviewed by Eric Seidel.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:
configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we are reducing the complexity of WebKit by
removing unnecessary configuration options. DOMStorage is not a core
part of the web platform. It should always be enabled.

CMakeLists.txt:
Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
GNUmakefile.list.am:
UseJSC.cmake:
WebCore.exp.in:
WebCore.pro:
bindings/js/JSEventCustom.cpp:
bindings/js/JSInjectedScriptHostCustom.cpp:
bindings/js/JSStorageCustom.cpp:
bindings/v8/custom/V8EventCustom.cpp:

(WebCore::toV8):

bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::storageIdCallback):

bindings/v8/custom/V8StorageCustom.cpp:
dom/Document.cpp:

(WebCore::Document::createEvent):

dom/Event.cpp:

(WebCore::Event::isStorageEvent):

dom/Event.h:
dom/Node.cpp:
features.pri:
inspector/InjectedScriptHost.cpp:

(WebCore::InjectedScriptHost::InjectedScriptHost):
(WebCore::InjectedScriptHost::disconnect):
(WebCore::InjectedScriptHost::storageIdImpl):

inspector/InjectedScriptHost.h:

(WebCore::InjectedScriptHost::init):

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::restoreInspectorStateFromCookie):

inspector/InspectorController.h:
inspector/InspectorDOMStorageAgent.cpp:
inspector/InspectorDOMStorageResource.cpp:
inspector/InspectorDOMStorageResource.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):

inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didUseDOMStorage):

inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::InstrumentingAgents):

inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):

inspector/generate-inspector-idl:
page/Chrome.cpp:
page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::clear):
(WebCore::DOMWindow::localStorage):

page/DOMWindow.h:
page/DOMWindow.idl:
page/Navigator.cpp:

(WebCore::Navigator::getStorageUpdates):

page/Navigator.h:
page/Navigator.idl:
page/Page.cpp:
page/Page.h:
page/PageGroup.cpp:

(WebCore::PageGroup::closeLocalStorage):

page/PageGroup.h:
page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setSessionStorageQuota):

page/Settings.h:

(WebCore::Settings::sessionStorageQuota):

storage/LocalStorageTask.cpp:
storage/LocalStorageTask.h:
storage/LocalStorageThread.cpp:
storage/LocalStorageThread.h:
storage/Storage.cpp:
storage/Storage.h:
storage/Storage.idl:
storage/StorageArea.h:
storage/StorageAreaImpl.cpp:
storage/StorageAreaImpl.h:
storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::scheduleSync):

storage/StorageAreaSync.h:
storage/StorageEvent.cpp:
storage/StorageEvent.h:
storage/StorageEvent.idl:
storage/StorageEventDispatcher.cpp:
storage/StorageEventDispatcher.h:
storage/StorageMap.cpp:
storage/StorageMap.h:
storage/StorageNamespace.cpp:
storage/StorageNamespace.h:
storage/StorageNamespaceImpl.cpp:
storage/StorageNamespaceImpl.h:
storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

storage/StorageSyncManager.h:
storage/StorageTracker.cpp:
storage/StorageTracker.h:

Source/WebKit/chromium:

features.gypi:
src/StorageAreaProxy.cpp:
src/StorageAreaProxy.h:
src/StorageEventDispatcherChromium.cpp:
src/StorageEventDispatcherImpl.cpp:
src/StorageEventDispatcherImpl.h:
src/StorageNamespaceProxy.cpp:
src/StorageNamespaceProxy.h:
src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableLocalStorage):
(WebKit::WebRuntimeFeatures::isLocalStorageEnabled):
(WebKit::WebRuntimeFeatures::enableSessionStorage):
(WebKit::WebRuntimeFeatures::isSessionStorageEnabled):

src/WebStorageAreaImpl.cpp:
src/WebStorageAreaImpl.h:
src/WebStorageEventDispatcherImpl.cpp:
src/WebStorageEventDispatcherImpl.h:
src/WebStorageNamespaceImpl.cpp:
src/WebStorageNamespaceImpl.h:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:
Storage/WebStorageManager.mm:
Storage/WebStorageManagerInternal.h:
Storage/WebStorageTrackerClient.h:
Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::dispatchDidModifyOrigin):

WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Tools:

Scripts/build-webkit:
waf/build/settings.py:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

fast/events/event-creation.html:

Oct 15, 2011:

10:59 PM Changeset in webkit [97573] by abarth@webkit.org

9 edits in trunk/Source

Rename ENABLE(SKIA_TEXT) to USE(SKIA_TEXT)
https://bugs.webkit.org/show_bug.cgi?id=70191

Reviewed by Daniel Bates.

Source/WebCore:

SKIA_TEXT is not a WebKit feature. It's a macro that determines
whether we use a feature of the underly library (Skia).

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawComplexText):

platform/graphics/chromium/UniscribeHelper.cpp:

(WebCore::UniscribeHelper::draw):

platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

platform/graphics/skia/PlatformContextSkia.h:
platform/graphics/skia/SkiaFontWin.cpp:
platform/graphics/skia/SkiaFontWin.h:

Source/WebKit/chromium:

features.gypi:

10:00 PM Changeset in webkit [97572] by eric.carlson@apple.com

6 edits in trunk/Source/WebCore

2011-10-15 Eric Carlson <eric.carlson@apple.com>

Make VIDEO_TRACK compile with warnings as errors enabled
https://bugs.webkit.org/show_bug.cgi?id=70188

Reviewed by Filip Pizlo.

No new tests, no functionality changed.

html/TextTrackCueList.h: Fix an include.
html/track/CueParser.cpp: (WebCore::CueParser::supportsType): Remove unused param.
html/track/CueParser.h: (WebCore::CueParserClient::~CueParserClient): Add virtual destructor.
html/track/CueParserPrivate.h: (WebCore::CueParserPrivateClient::~CueParserPrivateClient): Ditto.
loader/CueLoader.h: (WebCore::CueLoaderClient::~CueLoaderClient): Ditto. (WebCore::CueLoader::~CueLoader): Ditto.

9:35 PM Changeset in webkit [97571] by abarth@webkit.org

58 edits in trunk

Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
https://bugs.webkit.org/show_bug.cgi?id=70194

Reviewed by Daniel Bates.

Source/WebCore:

TILED_BACKING_STORE isn't a web platform feature. It's an
implementation strategy for WebKit that's used by some ports
and not by others.

features.pri:
loader/EmptyClients.h:
page/Chrome.cpp:
page/Chrome.h:
page/ChromeClient.h:
page/Frame.cpp:

(WebCore::Frame::Frame):
(WebCore::Frame::setView):

page/Frame.h:
page/FrameView.cpp:

(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::doDeferredRepaints):

page/Settings.cpp:

(WebCore::Settings::setTiledBackingStoreEnabled):

platform/HostWindow.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollPosition):

platform/graphics/Tile.h:
platform/graphics/TiledBackingStore.cpp:
platform/graphics/TiledBackingStore.h:
platform/graphics/TiledBackingStoreBackend.h:
platform/graphics/TiledBackingStoreClient.h:
platform/graphics/qt/GraphicsLayerQt.cpp:

(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::~GraphicsLayerQtImpl):
(WebCore::GraphicsLayerQtImpl::recache):
(WebCore::GraphicsLayerQtImpl::paint):

platform/graphics/qt/TileQt.cpp:
platform/graphics/qt/TileQt.h:
platform/graphics/texmap/TextureMapperNode.cpp:

(WebCore::TextureMapperNode::computeTiles):
(WebCore::TextureMapperNode::renderContent):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::syncCompositingStateSelf):

platform/graphics/texmap/TextureMapperNode.h:

(WebCore::TextureMapperNode::State::State):

Source/WebKit/qt:

Api/qgraphicswebview.cpp:

(QGraphicsWebViewPrivate::_q_scaleChanged):
(QGraphicsWebView::QGraphicsWebView):
(QGraphicsWebView::paint):
(QGraphicsWebView::isTiledBackingStoreFrozen):
(QGraphicsWebView::setTiledBackingStoreFrozen):

Api/qwebframe.cpp:
Api/qwebframe_p.h:
Api/qwebpage.cpp:

(QWebPagePrivate::dynamicPropertyChangeEvent):

Api/qwebsettings.cpp:

(QWebSettingsPrivate::apply):

WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::invalidateWindow):

WebCoreSupport/ChromeClientQt.h:
WebCoreSupport/PageClientQt.cpp:

(WebCore::PageClientQGraphicsWidget::createOrDeleteOverlay):

WebCoreSupport/PageClientQt.h:
tests/qgraphicswebview/tst_qgraphicswebview.cpp:

Source/WebKit2:

Shared/DrawingAreaInfo.h:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxy.messages.in:
UIProcess/PageClient.h:
UIProcess/TiledDrawingAreaProxy.cpp:
UIProcess/TiledDrawingAreaProxy.h:
UIProcess/WebPageProxy.cpp:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::contentsSizeChanged):

WebProcess/WebCoreSupport/WebChromeClient.h:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::create):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingArea.messages.in:
WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
WebProcess/WebPage/TiledBackingStoreRemoteTile.h:
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

Tools:

Scripts/build-webkit:

9:19 PM Changeset in webkit [97570] by abarth@webkit.org

2 edits in trunk/Source/WebKit/chromium

Remove unused ENABLE(SKIA_GPU)
https://bugs.webkit.org/show_bug.cgi?id=70192

Reviewed by Daniel Bates.

There do not appear to be any references to this macro.

features.gypi:

8:33 PM Changeset in webkit [97569] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Remove the last remnant of WBXML
https://bugs.webkit.org/show_bug.cgi?id=70187

Reviewed by Daniel Bates.

The bulk of the WBXML code was removed in 2009, but we missed one block.

platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::initMIMETypeEntensionMap):

5:54 PM Changeset in webkit [97568] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

The s390 and s390x architectures both use 64-bit double type
that conforms to the IEEE-754 standard.

https://bugs.webkit.org/show_bug.cgi?id=69940

Patch by Dan Horák <dan@danny.cz> on 2011-10-15
Reviewed by Gavin Barraclough.

wtf/dtoa/utils.h:

5:18 PM Changeset in webkit [97567] by ojan@chromium.org

2 edits in trunk/Tools

run-webkit-tests should accept --child-processes
https://bugs.webkit.org/show_bug.cgi?id=69713

Reviewed by Adam Barth.

Only set --child-processes=1 if --child-processes it not
passed on the commandline.

Scripts/run-webkit-tests:

4:46 PM Changeset in webkit [97566] by arv@chromium.org

1055 edits in trunk/LayoutTests

JS Test Harness: Make console and description elements optional in the HTML
https://bugs.webkit.org/show_bug.cgi?id=69881

Reviewed by Darin Adler.

This makes the description element and the console element in the HTML files
optional and these gets created as needed by the call to description() and debug().

This removes the description and console elements from a lots of files in LayoutTests/fast/

fast/js/resources/js-test-pre.js:

3:47 PM Changeset in webkit [97565] by Darin Adler

3 edits in trunk/Source/WebCore

REGRESSION(r97533): fast/forms/select-script-onchange.html failed after
https://bugs.webkit.org/show_bug.cgi?id=70173

Reviewed by Ryosuke Niwa.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setValue): Removed unneeded boolean argument
[true for deselect].
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Added explicit
boolean arguments for all calls to setSelectedIndex to restore pre-r97533
behavior.
(WebCore::HTMLSelectElement::typeAheadFind): Ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Ditto.

html/HTMLSelectElement.h:

Removed default of true for userDrivenChange. Each caller should pass it
explicitly. Longer term we should use an enum instead of a boolean or find
some other way of avoiding the argument.
(WebCore::HTMLSelectElement::setSelectedIndex):
Pass false for userDrivenChange as the old code did pre-r97533.

2:44 PM Changeset in webkit [97564] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks
https://bugs.webkit.org/show_bug.cgi?id=70157

Reviewed by Geoff Garen.

Added FunctionExecutable::produceCodeBlockFor() and rewired compileForCallInternal()
and compileForConstructInternal() to use this method. This required more cleanly
exposing some of CodeBlock's tiering functionality and moving the CompilationKind
enum to Executable.h, as this was the easiest way to make it available to the
declarations/definitions of CodeBlock, FunctionExecutable, and BytecodeGenerator.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::copyDataFrom):
(JSC::CodeBlock::copyDataFromAlternative):

bytecode/CodeBlock.h:

(JSC::CodeBlock::setAlternative):

bytecompiler/BytecodeGenerator.h:
runtime/Executable.cpp:

(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

runtime/Executable.h:

(JSC::FunctionExecutable::codeBlockFor):

12:35 PM Changeset in webkit [97563] by scheib@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Populate WebMouseEvent movementX/Y on Mac
https://bugs.webkit.org/show_bug.cgi?id=70167

Reviewed by Adam Barth.

src/mac/WebInputEventFactory.mm:

(WebKit::setWebEventLocationFromEventInView):

12:34 PM Changeset in webkit [97562] by dbates@webkit.org

3 edits
1 delete in trunk/Tools

Extract common gdb code into its own function; Remove script gdb-safari
https://bugs.webkit.org/show_bug.cgi?id=68499

Reviewed by David Kilzer.

Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
runSafari}() and in the script gdb-safari to launch gdb to debug an application.
We should extract the common parts into a function that can be shared by all callers
so as to remove duplicate code.

As a side effect of removing duplicate code we can remove the script gdb-safari since
its code has been incorporated into webkitdirs::debugSafari() which is called by the
script debug-safari.

Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
Scripts/gdb-safari: Removed.
Scripts/webkitdirs.pm:

(execMacWebKitAppForDebugging): Added; Extracted common debugging code from
debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
script gdb-safari to here.
(debugSafari): Added.
(runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
runSafari() always returns 1 on Windows and the script run-safari exits using this
value as its exit status. Hence, the script run-safari always exits with a nonzero
exit status (i.e. abnormal termination) on Windows. Instead, we should return the
exit status of the WebKit launcher application.
(debugMiniBrowser): Modified to call debugMacWebKitApp().
(debugWebKitTestRunner): Ditto.

12:14 PM Changeset in webkit [97561] by robert@webkit.org

3 edits
1 add in trunk/Tools

[webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
https://bugs.webkit.org/show_bug.cgi?id=70056

Reviewed by Adam Barth.

The preferred file-order for patches is LayoutTests at the end and
ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use
it when creating patches for review and landing.

Scripts/webkitpy/common/checkout/scm/git.py:
Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
Scripts/webkitpy/common/config/orderfile: Added.

9:17 AM Changeset in webkit [97560] by commit-queue@webkit.org

25 edits
5 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r97559.
http://trac.webkit.org/changeset/97559
https://bugs.webkit.org/show_bug.cgi?id=70176

Broke build on Mac (Requested by noamr_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-15

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::~LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

UIProcess/DrawingAreaProxy.cpp:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Removed.
UIProcess/LayerTreeHostProxy.messages.in: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Removed.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::deletedLayerIDs):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::didSynchronize):
(WebCore::WebGraphicsLayer::layerInfo):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::needsDisplayRect):
(WebCore::WebGraphicsLayer::takeLayersToDelete):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::divideIntoTiles):
(WebCore::collectCompositingInfoForThisLayer):
(WebCore::collectCompositingInfoRecursively):
(WebCore::WebGraphicsLayer::sendLayersToUIProcess):

WebProcess/WebCoreSupport/WebGraphicsLayer.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/LayerTreeHost.messages.in: Removed.
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.

9:01 AM Changeset in webkit [97559] by noam.rosenthal@nokia.com

25 edits
5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

Make the tiled "non-composited" content and the composited layers go through the same
code path on WebKit2. Instead of having a "drawing area" that handles the non-composited
content and a seperate layer tree, we put everything in a layer tree, with the non-
composited content being a layer in the tree.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Layer-tree synchronization is done by passing WebKit2 messages between a LayerTreeHost
on the WebProcess and a LayerTreeHostProxy on the UI process. Every layer in the tree has
its own tiled backing store, and uses the LayerTreeHost communication channel to pass
content up to the UI process. The UI process will later creates its own GraphicsLayer tree,
based on TextureMapper, which can be painted directly with OpenGL.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::viewportVisibleRect):
(WebKit::DrawingAreaProxy::isBackingStoreReady):
(WebKit::DrawingAreaProxy::paintToCurrentGLContext):
(WebKit::DrawingAreaProxy::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxy::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxy::createTileForLayer):
(WebKit::DrawingAreaProxy::updateTileForLayer):
(WebKit::DrawingAreaProxy::removeTileForLayer):
(WebKit::DrawingAreaProxy::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxy::page):

UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeHostProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRectAndScale):
(WebKit::DrawingAreaProxyImpl::setVisibleContentRectTrajectoryVector):
(WebKit::DrawingAreaProxyImpl::paintToCurrentGLContext):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Added.

(WebKit::LayerTreeHostProxy::layerByID):
(WebKit::LayerTreeHostProxy::rootLayer):
(WebKit::LayerTreeHostProxy::notifyAnimationStarted):
(WebKit::LayerTreeHostProxy::notifySyncRequired):
(WebKit::LayerTreeHostProxy::showDebugBorders):
(WebKit::LayerTreeHostProxy::showRepaintCounter):
(WebKit::LayerTreeHostProxy::paintContents):

UIProcess/LayerTreeHostProxy.messages.in: Added.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setVisibleContentRect):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateTileBuffersRecursively):
(WebCore::WebGraphicsLayer::layerTreeTileClient):
(WebCore::WebGraphicsLayer::updateContentBuffers):

WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setVisibleContentRectAndScale):
(WebKit::LayerTreeHost::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHost::setVisibleContentRectForLayer):
(WebKit::LayerTreeHost::renderNextFrame):

WebProcess/WebPage/LayerTreeHost.messages.in: Added.
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

(WebKit::LayerTreeHostQt::create):
(WebKit::LayerTreeHostQt::~LayerTreeHostQt):
(WebKit::LayerTreeHostQt::LayerTreeHostQt):
(WebKit::LayerTreeHostQt::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeHostQt::scheduleLayerFlush):
(WebKit::LayerTreeHostQt::cancelPendingLayerFlush):
(WebKit::LayerTreeHostQt::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeHostQt::setRootCompositingLayer):
(WebKit::LayerTreeHostQt::invalidate):
(WebKit::LayerTreeHostQt::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostQt::scrollNonCompositedContents):
(WebKit::LayerTreeHostQt::forceRepaint):
(WebKit::LayerTreeHostQt::sizeDidChange):
(WebKit::LayerTreeHostQt::didInstallPageOverlay):
(WebKit::LayerTreeHostQt::didUninstallPageOverlay):
(WebKit::LayerTreeHostQt::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostQt::flushPendingLayerChanges):
(WebKit::LayerTreeHostQt::didSyncCompositingStateForLayer):
(WebKit::LayerTreeHostQt::didDeleteLayer):
(WebKit::LayerTreeHostQt::performScheduledLayerFlush):
(WebKit::LayerTreeHostQt::layerFlushTimerFired):
(WebKit::LayerTreeHostQt::createPageOverlayLayer):
(WebKit::LayerTreeHostQt::destroyPageOverlayLayer):
(WebKit::LayerTreeHostQt::adoptImageBackingStore):
(WebKit::LayerTreeHostQt::releaseImageBackingStore):
(WebKit::LayerTreeHostQt::notifyAnimationStarted):
(WebKit::LayerTreeHostQt::notifySyncRequired):
(WebKit::LayerTreeHostQt::paintContents):
(WebKit::LayerTreeHostQt::showDebugBorders):
(WebKit::LayerTreeHostQt::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeHostQt::createTile):
(WebKit::LayerTreeHostQt::updateTile):
(WebKit::LayerTreeHostQt::removeTile):
(WebKit::LayerTreeHostQt::setVisibleContentRectForLayer):
(WebKit::LayerTreeHostQt::setVisibleContentRectAndScale):
(WebKit::LayerTreeHostQt::setVisibleContentRectTrajectoryVector):
(WebKit::LayerTreeHostQt::renderNextFrame):
(WebKit::LayerTreeHostQt::layerTreeTileUpdatesAllowed):

8:15 AM Changeset in webkit [97558] by robert@webkit.org

1 edit
1 add in trunk/LayoutTests

Missed mac result from r97555

Unreviewed.

platform/mac/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.

6:25 AM Changeset in webkit [97557] by Laszlo Gombos

75 edits
4 deletes in trunk

[Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
https://bugs.webkit.org/show_bug.cgi?id=69920
Patch by Laszlo Gombos <Laszlo Gombos> on 2011-10-15
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit.pri:
Source/WebKit.pro:

DumpRenderTree/qt/DumpRenderTree.pro:
DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::DumpRenderTree::open):
DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
QtTestBrowser/QtTestBrowser.pro:
QtTestBrowser/launcherwindow.cpp: (LauncherWindow::screenshot): (LauncherWindow::showFPS): (LauncherWindow::updateFPS):
QtTestBrowser/launcherwindow.h: (WindowOptions::WindowOptions):
QtTestBrowser/mainwindow.cpp: (MainWindow::buildUI):
Scripts/webkitpy/style/checker.py: Remove rules for the WebKit/qt/symbian/platformplugin directory.
Scripts/webkitpy/style/checker_unittest.py:
Tools.pro:
WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: (WTR::LayoutTestController::platformInitialize):
WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::isExistingLibrary):
WebKitTestRunner/qt/WebKitTestRunner.pro:

benchmarks/qscriptengine/qscriptengine.pro:

JavaScriptCore.pri:
JavaScriptCore.pro:
heap/MarkStack.h: (JSC::::shrinkAllocation):
jit/ExecutableAllocator.cpp:
jit/ExecutableAllocator.h: (JSC::ExecutableAllocator::cacheFlush):
jit/JITStubs.cpp:
jsc.pro:
runtime/ArrayPrototype.cpp: (JSC::arrayProtoFuncToString):
runtime/DatePrototype.cpp: (JSC::formatLocaleDate):
runtime/StringPrototype.cpp: (JSC::stringProtoFuncLastIndexOf):
runtime/TimeoutChecker.cpp: (JSC::getCPUTime):
wtf/Assertions.cpp:
wtf/Assertions.h:
wtf/Atomics.h:
wtf/MathExtras.h:
wtf/OSAllocator.h: (WTF::OSAllocator::decommitAndRelease):
wtf/OSAllocatorSymbian.cpp: Removed.
wtf/OSRandomSource.cpp: (WTF::cryptographicallyRandomValuesFromOS):
wtf/PageAllocation.h:
wtf/PageAllocatorSymbian.h: Removed.
wtf/PageBlock.cpp:
wtf/Platform.h:
wtf/StackBounds.cpp:
wtf/wtf.pri:

Api/qgraphicswebview.cpp: (QGraphicsWebView::setPage):
Api/qwebpage.cpp: (QWebPage::userAgentForUrl):
Api/qwebview.cpp: (QWebView::QWebView):
QtWebKit.pro:
WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::setInputMethodState):
WebCoreSupport/QtFallbackWebPopup.cpp: (WebCore::QtFallbackWebPopup::populate):
declarative/declarative.pro:
declarative/qdeclarativewebview.cpp: (QDeclarativeWebView::setPage):
symbian: Removed.
symbian/backup_registration.xml: Removed.
symbian/bwins: Removed.
symbian/bwins/QtWebKitu.def: Removed.
symbian/eabi: Removed.
symbian/eabi/QtWebKitu.def: Removed.
symbian/platformplugin: Removed.
symbian/platformplugin/HTML5VideoPlugin.cpp: Removed.
symbian/platformplugin/HTML5VideoPlugin.h: Removed.
symbian/platformplugin/HTML5VideoWidget.cpp: Removed.
symbian/platformplugin/HTML5VideoWidget.h: Removed.
symbian/platformplugin/OverlayWidget.cpp: Removed.
symbian/platformplugin/OverlayWidget.h: Removed.
symbian/platformplugin/PlayerButton.cpp: Removed.
symbian/platformplugin/PlayerButton.h: Removed.
symbian/platformplugin/PlayerLabel.cpp: Removed.
symbian/platformplugin/PlayerLabel.h: Removed.
symbian/platformplugin/WebPlugin.cpp: Removed.
symbian/platformplugin/WebPlugin.h: Removed.
symbian/platformplugin/images: Removed.
symbian/platformplugin/images/button_cannotplay.png: Removed.
symbian/platformplugin/images/button_close.png: Removed.
symbian/platformplugin/images/button_pause.png: Removed.
symbian/platformplugin/images/button_play.png: Removed.
symbian/platformplugin/images/button_sound_off.png: Removed.
symbian/platformplugin/images/button_sound_on.png: Removed.
symbian/platformplugin/images/loading_buffering_1.png: Removed.
symbian/platformplugin/images/loading_buffering_2.png: Removed.
symbian/platformplugin/images/loading_buffering_3.png: Removed.
symbian/platformplugin/images/loading_buffering_4.png: Removed.
symbian/platformplugin/platformplugin.pro: Removed.
symbian/platformplugin/platformplugin.qrc: Removed.
symbian/platformplugin/qss: Removed.
symbian/platformplugin/qss/OverlayWidget.qss: Removed.
symbian/platformplugin/qwebkitplatformplugin.h: Removed.
tests/qgraphicswebview/tst_qgraphicswebview.cpp: (tst_QGraphicsWebView::focusInputTypes):
tests/qwebframe/qwebframe.pro:
tests/qwebframe/tst_qwebframe.cpp:
tests/qwebview/tst_qwebview.cpp: (tst_QWebView::focusInputTypes):
tests/tests.pri:

WebCore.gypi:
WebCore.pri:
WebCore.pro:
bindings/v8/V8GCController.cpp: (WebCore::V8GCController::checkMemoryUsage):
config.h:
css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::operator int):
features.pri:
page/NavigatorBase.cpp:
platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
platform/network/qt/ResourceRequestQt.cpp: (WebCore::initializeMaximumHTTPConnectionCountPerHost):
platform/text/qt/TextCodecQt.cpp: (WebCore::TextCodecQt::decode):
plugins/PluginDatabase.cpp:
plugins/PluginPackage.cpp: (WebCore::PluginPackage::unload):
plugins/PluginPackage.h: (WebCore::PluginPackage::version):
plugins/PluginView.cpp: (WebCore::PluginView::setFrameRect):
plugins/PluginView.h:
plugins/npapi.h:
plugins/symbian: Removed.
plugins/symbian/PluginContainerSymbian.cpp: Removed.
plugins/symbian/PluginContainerSymbian.h: Removed.
plugins/symbian/PluginDatabaseSymbian.cpp: Removed.
plugins/symbian/PluginPackageSymbian.cpp: Removed.
plugins/symbian/PluginViewSymbian.cpp: Removed.
plugins/symbian/npinterface.h: Removed.

6:00 AM Changeset in webkit [97556] by robert@webkit.org

1 edit
17 adds in trunk/LayoutTests

Platform-specific results for r97555

Unreviewed.

platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/gtk/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/gtk/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
platform/gtk/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/gtk/css2.1/20110323/height-width-table-001-expected.txt: Added.
platform/mac/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/mac/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/mac/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/mac/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/mac/css2.1/20110323/height-width-table-001-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/qt/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
platform/qt/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/qt/css2.1/20110323/height-width-table-001-expected.txt: Added.

4:32 AM Changeset in webkit [97555] by robert@webkit.org

3 edits
33 copies
6 moves
31 adds
8 deletes in trunk

CSS 2.1 failure: height-width-table-001.htm
https://bugs.webkit.org/show_bug.cgi?id=69709

Reviewed by Simon Fraser.

Source/WebCore:

CSS 2.1 expects CSS table elements to treat fixed height/width as
excluding table borders, but HTML table elements to treat fixed height/width as
including them.

See http://lists.w3.org/Archives/Public/www-style/2011Jan/0178.html

http://lists.w3.org/Archives/Public/public-css-testsuite/2011Oct/0005.html

It looks like some clarification is pending in the specs, but the new behaviour
lets WebKit pass the following tests in the suite CSS and also match FF:

height-width-table-001.htm
height-width-inline-table-001.htm
abspos-containing-block-initial-004d.htm

rendering/RenderTable.cpp:

(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::layout):

LayoutTests:

css2.1/20110323/abspos-containing-block-initial-001-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-001.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004-ref-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004-ref-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004a-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004a-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004a.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004b-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004b-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004b.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004c-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004c-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004c.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004d-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004d-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004d.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004d.htm.1: Added.
css2.1/20110323/abspos-containing-block-initial-004e-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004e-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004e.htm: Added.
css2.1/20110323/abspos-containing-block-initial-004f-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-004f-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-004f.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005-ref-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005-ref-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005a-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005a-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005a.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005b-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005b-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005b.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005c-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005c-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005c.htm: Added.
css2.1/20110323/abspos-containing-block-initial-005d-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-005d-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-005d.htm: Added.
css2.1/20110323/abspos-containing-block-initial-007-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-007.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009-ref-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009-ref-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009-ref.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009a-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009a-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009a.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009b-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009b-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009b.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009e-expected.png: Added
css2.1/20110323/abspos-containing-block-initial-009e-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009e.htm: Added.
css2.1/20110323/abspos-containing-block-initial-009f-expected.png: Added.
css2.1/20110323/abspos-containing-block-initial-009f-expected.txt: Added.
css2.1/20110323/abspos-containing-block-initial-009f.htm: Added.
css2.1/20110323/height-width-inline-table-001.htm: Added.
css2.1/20110323/height-width-table-001.htm: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.png: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-001-ref-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Added
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.png: Added
platform/chromium-linux/css2.1/20110323/abspos-containing-block-initial-007-ref-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/height-width-inline-table-001-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.png: Added.
platform/chromium-linux/css2.1/20110323/height-width-table-001-expected.txt: Added.
platform/gtk/fast/backgrounds/table-root-expected.txt: Removed.
platform/mac/fast/backgrounds/positioned-root-expected.png: Removed.
platform/mac/fast/backgrounds/table-root-expected.png: Removed.
platform/mac/fast/backgrounds/table-root-expected.txt: Removed.
platform/qt/fast/backgrounds/positioned-root-expected.png: Removed.
platform/qt/fast/backgrounds/positioned-root-expected.txt: Removed.
platform/qt/fast/backgrounds/table-root-expected.png: Removed.
platform/qt/fast/backgrounds/table-root-expected.txt: Removed.

2:37 AM Changeset in webkit [97554] by commit-queue@webkit.org

25 edits
5 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r97549.
http://trac.webkit.org/changeset/97549
https://bugs.webkit.org/show_bug.cgi?id=70174

It broke the SL build (Requested by Ossy_weekend on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-15

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

UIProcess/DrawingAreaProxy.cpp:
UIProcess/DrawingAreaProxy.h:
UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Removed.
UIProcess/LayerTreeHostProxy.messages.in: Removed.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Removed.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

WebProcess/WebCoreSupport/WebGraphicsLayer.h:
WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:
WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:
WebProcess/WebPage/LayerTreeHost.messages.in: Removed.
WebProcess/WebPage/TiledDrawingArea.cpp:
WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:
WebProcess/WebPage/qt/LayerTreeHostQt.h: Removed.

1:28 AM Changeset in webkit [97553] by abarth@webkit.org

2 edits in trunk/Tools

Fix typo in webkitpy help
https://bugs.webkit.org/show_bug.cgi?id=70169

Reviewed by Eric Seidel.

Scripts/webkitpy/tool/commands/upload.py:

12:59 AM Changeset in webkit [97552] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Trivial fix for a missing change in r97512
https://bugs.webkit.org/show_bug.cgi?id=70166

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-15
Reviewed by Gavin Barraclough.

dfg/DFGJITCompiler32_64.cpp:

(JSC::DFG::JITCompiler::link):

12:59 AM Changeset in webkit [97551] by Darin Adler

10 edits in trunk/Source/WebCore

Make toHTMLElement fail to compile if you try to use it on an HTMLElement*
https://bugs.webkit.org/show_bug.cgi?id=70164

Reviewed by Adam Barth.

Refactoring covered by existing tests.

bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter): Removed unneeded casts and
some unneeded local variables as well. Changed the name of the local variable
for the HTMLFrameElement to frameElement to avoid confusion with the Frame.

dom/Document.cpp:

(WebCore::Document::openSearchDescriptionURL): Removed unneeded HTMLElement
check; we can call hasTagName directly on a Node and that takes care of
checking both that it's an HTMLElement and checking the tag name.

dom/MicroDataItemList.cpp:

(WebCore::MicroDataItemList::nodeMatches): Use toHTMLElement instead of
a cast. Also changed hasAttribute calls to fastHasAttribute and getAttribute
calls to fastGetAttribute since these are neither style attributes nor SVG
animatables.

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): Use toHTMLElement.
(WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Ditto.

editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::show): Removed unneeded toHTMLElement call.

html/HTMLElement.cpp:

(WebCore::HTMLElement::setOuterHTML): Use toHTMLElement.

html/HTMLElement.h: Added toHTMLElement overload to catch calls when the

pointer is already HTMLElement* or a pointer to a class derived from it.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems): Use toHTMLElement.

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Use toHTMLElement.

12:44 AM Changeset in webkit [97550] by commit-queue@webkit.org

10 edits
3 copies
1 add in trunk/Source

Add WebAcceleratedContentLayer backed by a texture to support accelerated content hosting
https://bugs.webkit.org/show_bug.cgi?id=70084

Patch by Antoine Labour <piman@chromium.org> on 2011-10-15
Reviewed by James Robinson.

Source/WebCore:

Covered by existing compositing/ tests

platform/graphics/chromium/LayerChromium.h:
platform/graphics/chromium/LayerRendererChromium.cpp:

(WebCore::LayerRendererChromium::pluginLayerProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):

platform/graphics/chromium/LayerRendererChromium.h:
platform/graphics/chromium/PluginLayerChromium.cpp:

(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::setTextureId):
(WebCore::PluginLayerChromium::setFlipped):
(WebCore::PluginLayerChromium::pushPropertiesTo):

platform/graphics/chromium/PluginLayerChromium.h:

(WebCore::PluginLayerChromium::flipped):

platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:

(WebCore::CCPluginLayerImpl::CCPluginLayerImpl):
(WebCore::CCPluginLayerImpl::draw):

platform/graphics/chromium/cc/CCPluginLayerImpl.h:

(WebCore::CCPluginLayerImpl::setFlipped):

Source/WebKit/chromium:

WebKit.gyp:
public/WebExternalTextureLayer.h: Added.

(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::~WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):

src/WebExternalTextureLayer.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebKit::WebExternalTextureLayer::create):
(WebKit::WebExternalTextureLayer::setTextureId):
(WebKit::WebExternalTextureLayer::textureId):
(WebKit::WebExternalTextureLayer::setFlipped):
(WebKit::WebExternalTextureLayer::flipped):
(WebKit::WebExternalTextureLayer::WebExternalTextureLayer):
(WebKit::WebExternalTextureLayer::operator=):
(WebKit::WebExternalTextureLayer::operator PassRefPtr<WebExternalTextureLayerImpl>):

src/WebExternalTextureLayerImpl.cpp: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

(WebKit::WebExternalTextureLayerImpl::create):
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::~WebExternalTextureLayerImpl):
(WebKit::WebExternalTextureLayerImpl::drawsContent):
(WebKit::WebExternalTextureLayerImpl::paintContents):
(WebKit::WebExternalTextureLayerImpl::notifySyncRequired):

src/WebExternalTextureLayerImpl.h: Copied from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.

12:32 AM Changeset in webkit [97549] by noam.rosenthal@nokia.com

25 edits
5 adds in trunk/Source/WebKit2

[Qt][WK2] Synchronize tiling with accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=69151

Reviewed by Simon Hausmann.

This allows fixing several issues with websites that have large content areas that are
composited or overlap with composited layers.

Several optimizations are available for the non-composited layer as well, e.g. specifying
a trajectory and updating the visible rect together with the content scale.

This code is currently disabled, a separate patch will enable it and glue it to
QTouchWebPage.

DerivedSources.pro:
Platform/CoreIPC/MessageID.h:
Scripts/webkit2/messages.py:
Shared/LayerTreeContext.h:
Shared/WebLayerTreeInfo.cpp:

(WebKit::WebLayerInfo::encode):
(WebKit::WebLayerInfo::decode):

Shared/WebLayerTreeInfo.h:
Shared/qt/LayerTreeContextQt.cpp:

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::updateWebView):
(WebKit::DrawingAreaProxy::contentsRect):

UIProcess/DrawingAreaProxy.h:

UIProcess/DrawingAreaProxyImpl.cpp:

UIProcess/DrawingAreaProxyImpl.h:
UIProcess/LayerTreeHostProxy.h: Added.

UIProcess/LayerTreeHostProxy.messages.in: Added.
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveMessage):

UIProcess/qt/LayerTreeHostProxyQt.cpp: Added.
WebKit2.pro:
WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:

WebProcess/WebCoreSupport/WebGraphicsLayer.h:

(WebCore::WebGraphicsLayer::setLayerTreeTileClient):

WebProcess/WebPage/DrawingArea.h:
WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/DrawingAreaImpl.h:
WebProcess/WebPage/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::create):

WebProcess/WebPage/LayerTreeHost.h:

WebProcess/WebPage/LayerTreeHost.messages.in: Added.
WebProcess/WebPage/TiledDrawingArea.cpp:

(WebKit::TiledDrawingArea::didReceiveLayerTreeHostMessage):

WebProcess/WebPage/TiledDrawingArea.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceiveMessage):

WebProcess/WebPage/qt/LayerTreeHostQt.cpp:

12:28 AM Changeset in webkit [97548] by tony@chromium.org

2 edits in trunk/Tools

fix another typo in treemap.html
https://bugs.webkit.org/show_bug.cgi?id=70149

Reviewed by Ojan Vafai.

Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.

TestResultServer/static-dashboards/treemap.html:

12:19 AM Changeset in webkit [97547] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

IndexedDB: some string keys not properly stored and retrieved
https://bugs.webkit.org/show_bug.cgi?id=62348

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-15
Reviewed by Tony Chang.

Just adding Mark Pilgrim's test case from bug; this was fixed at some
point, presumably when we moved to LevelDB.

storage/indexeddb/odd-strings-expected.txt: Added.
storage/indexeddb/odd-strings.html: Added.

12:16 AM Changeset in webkit [97546] by Michael Nordman

4 edits in trunk/Source

[Chromium] Some WebSQLDatabase in worker bug fixes.
https://bugs.webkit.org/show_bug.cgi?id=70071

Test for a NULL webView WebWorkerClientImpl.
Avoid altering Database instance lifetimes during WorkerThread::stop().

Source/WebCore:

Existing tests coverage applies.

Reviewed by David Levin.

storage/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::interruptAllDatabasesForContext):

Source/WebKit/chromium:

Reviewed by David Levin.

src/WebWorkerClientImpl.cpp:

(WebKit::WebWorkerClientImpl::allowFileSystem):
(WebKit::WebWorkerClientImpl::allowDatabase):

12:08 AM Changeset in webkit [97545] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[FileSystem API] File readonly attributes test
https://bugs.webkit.org/show_bug.cgi?id=69687

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-15
Reviewed by Adam Barth.

fast/filesystem/simple-readonly-file-object-expected.txt: Added.
fast/filesystem/simple-readonly-file-object.html: Added.

12:03 AM Changeset in webkit [97544] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[File API] URL methods required arguments
https://bugs.webkit.org/show_bug.cgi?id=69692

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-15
Reviewed by Adam Barth.

fast/files/url-required-arguments-expected.txt: Added.
fast/files/url-required-arguments.html: Added.

12:02 AM Changeset in webkit [97543] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

[File API] Test how FileReader substitutes illegal UTF-8 characters
https://bugs.webkit.org/show_bug.cgi?id=69691

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

fast/files/file-reader-fffd-expected.txt: Added.
fast/files/file-reader-fffd.html: Added.

Oct 14, 2011:

11:52 PM Changeset in webkit [97542] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

[FileSystem API] readonly attributes test
https://bugs.webkit.org/show_bug.cgi?id=69655

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

fast/filesystem/resources/simple-readonly.js: Added.

(setReadonlyProperty):
(errorCallback):
(getFileCallback):
(successCallback):

fast/filesystem/simple-readonly-expected.txt: Added.
fast/filesystem/simple-readonly.html: Added.

11:51 PM Changeset in webkit [97541] by commit-queue@webkit.org

1 edit
3 adds in trunk/LayoutTests

[FileSystem API] restricted Unicode characters in names
https://bugs.webkit.org/show_bug.cgi?id=69657

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

fast/filesystem/op-restricted-unicode-expected.txt: Added.
fast/filesystem/op-restricted-unicode.html: Added.
fast/filesystem/resources/op-restricted-unicode.js: Added.

(testCases.name.precondition.tests):
(testCases):

11:26 PM Changeset in webkit [97540] by abarth@webkit.org

2 edits in trunk/Source/WebCore

Update expected results.

bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjInternal::serializedValueCallback):

10:45 PM Changeset in webkit [97539] by rniwa@webkit.org

3 edits in trunk/Source/WebCore

GTK build fix after r97533.

accessibility/gtk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(optionFromSelection):
(webkit_accessible_selection_get_selection_count):

9:37 PM Changeset in webkit [97538] by ddkilzer@apple.com

4 edits in trunk/Source

<http://webkit.org/b/70158> Fix clang compiler warnings

Reviewed by Darin Adler.

Source/WebCore:

dom/ViewportArguments.cpp:

(WebCore::computeViewportAttributes): Use std::max<float>()
instead of std::max().

Source/WebKit/mac:

The following two methods in WebDelegateImplementationCaching.h
are ambiguous in WebChromeClient::runJavaScriptPrompt() because
the compiler can't decide how to convert the WTF::String
defaultText argument:

id CallUIDelegate(WebView *, SEL, id, id);
id CallUIDelegate(WebView *, SEL, id, BOOL);

The fix is to perform the conversion explicitly.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::runJavaScriptPrompt): Extract a defaultString
variable to convert the WTF::String to an NSString*, then
use defaultString in place of defaultText.

7:00 PM Changeset in webkit [97537] by mhahnenberg@apple.com

102 edits in trunk/Source

Rename getOwnPropertySlot to getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=69810

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertySlotVirtual):
(JSC::::getOwnPropertySlot):
(JSC::::getOwnPropertyDescriptor):
(JSC::::staticFunctionGetter):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::getOwnPropertySlotVirtual):
(JSC::DebuggerActivation::getOwnPropertySlot):

debugger/DebuggerActivation.h:
runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlotVirtual):
(JSC::Arguments::getOwnPropertySlot):

runtime/Arguments.h:
runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getOwnPropertySlotVirtual):
(JSC::ArrayConstructor::getOwnPropertySlot):

runtime/ArrayConstructor.h:
runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::getOwnPropertySlotVirtual):

runtime/ArrayPrototype.h:
runtime/BooleanPrototype.cpp:

(JSC::BooleanPrototype::getOwnPropertySlotVirtual):

runtime/BooleanPrototype.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::getOwnPropertySlotVirtual):

runtime/DateConstructor.h:
runtime/DatePrototype.cpp:

(JSC::DatePrototype::getOwnPropertySlotVirtual):

runtime/DatePrototype.h:
runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::getOwnPropertySlotVirtual):

runtime/ErrorPrototype.h:
runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnPropertySlotVirtual):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlotVirtual):
(JSC::JSArray::getOwnPropertySlot):

runtime/JSArray.h:
runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::getOwnPropertySlotVirtual):

runtime/JSBoundFunction.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::getOwnPropertySlotVirtual):

runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::getOwnPropertySlotVirtual):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlotVirtual):
(JSC::JSFunction::getOwnPropertyDescriptor):
(JSC::JSFunction::getOwnPropertyNames):
(JSC::JSFunction::put):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::getOwnPropertySlotVirtual):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::hasOwnPropertyForWrite):

runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::getOwnPropertySlotVirtual):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Stringifier::Holder::appendNextProperty):
(JSC::JSONObject::getOwnPropertySlotVirtual):
(JSC::Walker::walk):

runtime/JSONObject.h:
runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSObject::getOwnPropertySlot):
(JSC::JSObject::hasOwnProperty):

runtime/JSObject.h:

(JSC::JSObject::getOwnPropertySlotVirtual):
(JSC::JSCell::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):
(JSC::JSValue::get):

runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::getOwnPropertySlotVirtual):

runtime/JSStaticScopeObject.h:
runtime/JSString.cpp:

(JSC::JSString::getOwnPropertySlotVirtual):
(JSC::JSString::getOwnPropertySlot):

runtime/JSString.h:
runtime/Lookup.h:

(JSC::getStaticPropertySlot):
(JSC::getStaticFunctionSlot):
(JSC::getStaticValueSlot):

runtime/MathObject.cpp:

(JSC::MathObject::getOwnPropertySlotVirtual):

runtime/MathObject.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlotVirtual):

runtime/NumberConstructor.h:
runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::getOwnPropertySlotVirtual):

runtime/NumberPrototype.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getOwnPropertySlotVirtual):

runtime/ObjectConstructor.h:
runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::getOwnPropertySlotVirtual):

runtime/ObjectPrototype.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getOwnPropertySlotVirtual):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::getOwnPropertySlotVirtual):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlotVirtual):

runtime/RegExpObject.h:
runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::getOwnPropertySlotVirtual):

runtime/RegExpPrototype.h:
runtime/StringConstructor.cpp:

(JSC::StringConstructor::getOwnPropertySlotVirtual):

runtime/StringConstructor.h:
runtime/StringObject.cpp:

(JSC::StringObject::getOwnPropertySlotVirtual):

runtime/StringObject.h:
runtime/StringPrototype.cpp:

(JSC::StringPrototype::getOwnPropertySlotVirtual):

runtime/StringPrototype.h:

Source/JavaScriptGlue:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

UserObjectImp.cpp:

(UserObjectImp::getOwnPropertySlotVirtual):

UserObjectImp.h:

Source/WebCore:

No new tests.

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

WebCore.exp.in:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotVirtual):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::DialogHandler::returnValue):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::getOwnPropertySlotVirtual):
(WebCore::JSDOMWindowShell::getOwnPropertySlot):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSWorkerContextCustom.cpp:

(WebCore::JSWorkerContext::getOwnPropertySlotDelegate):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::getSparseIndex):
(WebCore::CloneSerializer::getProperty):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestInterface::getOwnPropertySlotVirtual):
(WebCore::JSTestInterface::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestInterface.h:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListenerConstructor::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListenerPrototype::getOwnPropertySlot):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlotVirtual):
(WebCore::JSTestMediaQueryListListener::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestObjConstructor::getOwnPropertySlot):
(WebCore::JSTestObjPrototype::getOwnPropertySlotVirtual):
(WebCore::JSTestObjPrototype::getOwnPropertySlot):
(WebCore::JSTestObj::getOwnPropertySlotVirtual):
(WebCore::JSTestObj::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestObj.h:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlotVirtual):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getOwnPropertySlot):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlotVirtual):
(WebCore::JSTestSerializedScriptValueInterface::getOwnPropertySlot):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlotVirtual):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::getOwnPropertySlot):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlotVirtual):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlotVirtual):

bridge/qt/qt_runtime.h:
bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertySlotVirtual):

bridge/runtime_array.h:
bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlotVirtual):

bridge/runtime_method.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getOwnPropertySlotVirtual):

bridge/runtime_object.h:

Source/WebKit2:

Renamed the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual
in preparation for when we add the static getOwnPropertySlot to the MethodTable
in ClassInfo.

Also added a few static getOwnPropertySlot functions where they had been overlooked
before (especially in CodeGeneratorJS.pm).

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertySlotVirtual):

WebProcess/Plugins/Netscape/JSNPObject.h:

6:25 PM Changeset in webkit [97536] by barraclough@apple.com

65 edits in trunk

Most built-in properties are not deletable
https://bugs.webkit.org/show_bug.cgi?id=61014

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Our static hash tables don't allow for deleting properties.
This is the cause of a bunch of expected failures in LayoutTests/sputnik.

This fixes the problem by reifying all static functions immediately prior
to the first deletion. Reification is tracked by a flag on the structure,
so properties will no longer 'bounce-back' on later access.

Theoretically there could probably also be an issue with custom accessor
properties, but we probably do not really require any of these to be
Configurable anyway. I'll follow up with a separate patch to address this.

runtime/ClassInfo.h:

(JSC::ClassInfo::hasStaticProperties):

detects static property tables.

runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

call reifyStaticFunctions before deletion.

(JSC::JSObject::reifyStaticFunctions):

If the class has static functions, set them up now.

runtime/JSObject.h:

(JSC::JSObject::staticFunctionsReified):

returns true if static functions have been reified, and as such should no longer be added.

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

If static functions have been reified do not add.

runtime/Lookup.h:

(JSC::HashTable::ConstIterator::ConstIterator):
(JSC::HashTable::ConstIterator::operator->):
(JSC::HashTable::ConstIterator::operator*):
(JSC::HashTable::ConstIterator::operator!=):
(JSC::HashTable::ConstIterator::operator++):
(JSC::HashTable::ConstIterator::skipInvalidKeys):
(JSC::HashTable::begin):
(JSC::HashTable::end):
(JSC::getStaticPropertySlot):
(JSC::getStaticPropertyDescriptor):
(JSC::getStaticFunctionSlot):
(JSC::getStaticFunctionDescriptor):

setUpStaticFunctionSlot may not add, returns a bool.

(JSC::lookupPut):

remove redundant branch.

runtime/Structure.cpp:

(JSC::Structure::Structure):

initialize new flag in constructors.

runtime/Structure.h:

(JSC::Structure::staticFunctionsReified):
(JSC::Structure::setStaticFunctionsReified):

added flag

LayoutTests:

Mostly checking in passing results, added a couple of extra test cases to fast/js/delete-syntax.

fast/js/delete-syntax-expected.txt:
fast/js/script-tests/delete-syntax.js:
ietestcenter/Javascript/11.4.1-4.a-10-expected.txt:
sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/S15.4.4_A1.1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4.1_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.5_String/15.5.4/S15.5.4_A3-expected.txt:
sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.2/S15.6.2.1_A4-expected.txt:
sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.3/15.6.3.1_Boolean.prototype/S15.6.3.1_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.6_Boolean/15.6.4/S15.6.4_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.2/S15.7.2.1_A4-expected.txt:
sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.3/15.7.3.1_Number.prototype/S15.7.3.1_A2_T1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.7_Number/15.7.4/S15.7.4_A1-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.2_Date.parse/S15.9.4.2_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.4/15.9.4.3_Date.UTC/S15.9.4.3_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.10_Date.prototype.getFullYear/S15.9.5.10_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.11_Date.prototype.getUTCFullYear/S15.9.5.11_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.12_Date.prototype.getMonth/S15.9.5.12_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.13_Date.prototype.getUTCMonth/S15.9.5.13_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.14_Date.prototype.getDate/S15.9.5.14_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.15_Date.prototype.getUTCDate/S15.9.5.15_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.16_Date.prototype.getDay/S15.9.5.16_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.17_Date.prototype.getUTCDay/S15.9.5.17_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.18_Date.prototype.getHours/S15.9.5.18_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.19_Date.prototype.getUTCHours/S15.9.5.19_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.20_Date.prototype.getMinutes/S15.9.5.20_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.21_Date.prototype.getUTCMinutes/S15.9.5.21_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.22_Date.prototype.getSeconds/S15.9.5.22_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.23_Date.prototype.getUTCSeconds/S15.9.5.23_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.24_Date.prototype.getMilliseconds/S15.9.5.24_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.25_Date.prototype.getUTCMilliseconds/S15.9.5.25_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.26_Date.prototype.getTimezoneOffset/S15.9.5.26_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.27_Date.prototype.setTime/S15.9.5.27_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.28_Date.prototype.setMilliseconds/S15.9.5.28_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.29_Date.prototype.setUTCMilliseconds/S15.9.5.29_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.2_Date.prototype.toString/S15.9.5.2_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.30_Date.prototype.setSeconds/S15.9.5.30_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.31_Date.prototype.setUTCSeconds/S15.9.5.31_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.32_Date.prototype.setMinutes/S15.9.5.32_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.33_Date.prototype.setUTCMinutes/S15.9.5.33_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.34_Date.prototype.setHours/S15.9.5.34_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.35_Date.prototype.setUTCHours/S15.9.5.35_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.36_Date.prototype.setDate/S15.9.5.36_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.37_Date.prototype.setUTCDate/S15.9.5.37_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.38_Date.prototype.setMonth/S15.9.5.38_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.39_Date.prototype.setUTCMonth/S15.9.5.39_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.3_Date.prototype.toDateString/S15.9.5.3_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.40_Date.prototype.setFullYear/S15.9.5.40_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.41_Date.prototype.setUTCFullYear/S15.9.5.41_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.42_Date.prototype.toUTCString/S15.9.5.42_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.4_Date.prototype.toTimeString/S15.9.5.4_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.5_Date.prototype.toLocaleString/S15.9.5.5_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.6_Date.prototype.toLocaleDateString/S15.9.5.6_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.7_Date.prototype.toLocaleTimeString/S15.9.5.7_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.8_Date.prototype.valueOf/S15.9.5.8_A1_T2-expected.txt:
sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.5/15.9.5.9_Date.prototype.getTime/S15.9.5.9_A1_T2-expected.txt:

5:53 PM Changeset in webkit [97535] by Darin Adler

2 edits in trunk/Source/WebKit/chromium

Try to fix Chromium build.

tests/PopupMenuTest.cpp:

(WebKit::TestPopupMenuClient::valueChanged):
Use toHTMLSelectElement instead of toSelectElement.

5:48 PM Changeset in webkit [97534] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Windows build fix attempt after r97533.

html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

5:30 PM Changeset in webkit [97533] by Darin Adler

16 edits in trunk/Source/WebCore

Follow up the recent HTMLSelectElement improvements with a little bit more
https://bugs.webkit.org/show_bug.cgi?id=70139

Reviewed by Ryosuke Niwa.

Refactoring, covered by existing tests.

Mostly, this adds a toHTMLSelectElement and uses it wherever possible.

accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute): Use toHTMLSelectElement.
(WebCore::AccessibilityListBox::addChildren): Ditto. Also removed unneeded toHTMLElement.

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren): Ditto.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMultiSelectable): Ditto.
(WebCore::AccessibilityRenderObject::stringValue): Removed checks on the type of the
underlying node, since other code already assumes that a menu list renderer is only
created for a select element. Streamlined the code a bit and removed some unneeded
local variables.

bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::indexSetter): Use toHTMLSelectElement.

bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove): Ditto.
(WebCore::JSHTMLSelectElement::indexSetter): Ditto.

editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll): Ditto.

html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect): Ditto.

html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions): Ditto.
(WebCore::HTMLOptGroupElement::ownerSelectElement): Ditto.

html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::selected): Changed code to call renamed
updateListItemSelectedStates rather than the confusing old name
recalcListItemsIfNeeded.
(WebCore::HTMLOptionElement::childrenChanged): Changed to call
optionElementChildrenChanged rather than calling childrenChanged,
because the children of the select element did not change!
(WebCore::HTMLOptionElement::ownerSelectElement): Use toHTMLSelectElement.

html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::remove): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::selectedIndex): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::setSelectedIndex): Use toHTMLSelectElement.
(WebCore::HTMLOptionsCollection::setLength): Use toHTMLSelectElement.

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setSelectedIndexByUser): Call setSelectedIndex
without the now-unneeded internal suffix.
(WebCore::HTMLSelectElement::parseMappedAttribute): When the code says that
we should "determine selectedness of the items", call updateListItemSelectedStates
rather than the confusingly named recalcListItemsIfNeeded.
(WebCore::HTMLSelectElement::updateListItemSelectedStates): Renamed
recalcListItemsIfNeeded to this, since that's what this function is for.
(WebCore::HTMLSelectElement::optionElementChildrenChanged): Added. Does
the same work as childrenChanged, although it does not call up to the
base class childrenChanged function. Later we might find we can remove
some of the work here, for example it's not clear we should call the
accessibility childrenChanged function.
(WebCore::HTMLSelectElement::nextValidIndex): Changed this to a member function
and made it get the list items itself rather than requiring they be passed in.
(WebCore::HTMLSelectElement::nextSelectableListIndex): Updated for change to
nextValidIndex.
(WebCore::HTMLSelectElement::previousSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::firstSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::lastSelectableListIndex): Ditto.
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway): Ditto.
(WebCore::HTMLSelectElement::listItems): Removed unneeded const_cast, since
recalcListItems is now a const member function. Call recalcListItems by that
name instead of recalcListItemsInternal.
(WebCore::HTMLSelectElement::recalcListItems): Renamed from recalcListItemsInternal
and made this a const member function. The data members that this needs to modify
are now mutable.
(WebCore::HTMLSelectElement::setSelectedIndex): Renamed from setSelectedIndexInternal.
Changed call to updateValidity to instead call setNeedsValidityCheck, since both
do the same thing.
(WebCore::HTMLSelectElement::parseMultipleAttribute): Ditto.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Updated for change to
nextValidIndex, removed unneeded comparison with zero that's already handled by
casting to an unsigned type, and use setSelectedIndex instead of using
setSelectedIndexInternal since they are both the same thing.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Removed another unneeded
comparision with zero that's handled by casting to an unsigned type.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Use size_t instead of unsigned
for a vector index.
(WebCore::HTMLSelectElement::typeAheadFind): Use setSelectedIndex instead of
setSelectedIndexInternal.
(WebCore::HTMLSelectElement::insertedIntoTree): Removed unneeded explicit boolean
when calling a function that already has a default value of true.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): Use setSelectedIndex
instead of setSelectedIndexInternal.

html/HTMLSelectElement.h: Made childrenChanged private. Added

optionElementChildrenChanged. Renamed recalcListItemsIfNeeded to the clearer
updateListItemSelectedStates. Removed unused listBoxSelectItem. Removed
updateValidity after changing all callers to instead call setNeedsValidityCheck.
Made canSelectAll and selectAll non-virtual. Removed recalcListItemsInternal
since it's the same thing as recalcListItems now. Renamed setSelectedIndexInternal
to setSelectedIndex since it's the same function, just with a few arguments we
don't want to allow outside callers to pass. Changed nextValidIndex into a
non-static member function. Made m_listItems and m_shouldRecalcListItems mutable.
Added a toHTMLSelectElement function, modeled on the toElement function.

html/ValidityState.cpp:

(WebCore::ValidityState::valueMissing): Use toHTMLSelectElement.

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement): Ditto.
(WebCore::RenderListBox::scrollToRevealSelection): Ditto.
(WebCore::RenderListBox::size): Ditto.
(WebCore::RenderListBox::numItems): Ditto.
(WebCore::RenderListBox::addFocusRingRects): Ditto.
(WebCore::RenderListBox::paintItemForeground): Ditto.
(WebCore::RenderListBox::paintItemBackground): Ditto.
(WebCore::RenderListBox::panScroll): Ditto.
(WebCore::RenderListBox::autoscroll): Ditto.
(WebCore::RenderListBox::stopAutoscroll): Ditto.
(WebCore::RenderListBox::valueChanged): Ditto.
(WebCore::RenderListBox::nodeAtPoint): Ditto.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth): Ditto.
(WebCore::RenderMenuList::updateFromElement): Ditto.
(WebCore::RenderMenuList::setTextFromOption): Ditto.
(WebCore::RenderMenuList::showPopup): Ditto.
(WebCore::RenderMenuList::valueChanged): Ditto.
(WebCore::RenderMenuList::listBoxSelectItem): Ditto.
(WebCore::RenderMenuList::multiple): Ditto.
(WebCore::RenderMenuList::didSetSelectedIndex): Ditto.
(WebCore::RenderMenuList::didUpdateActiveOption): Ditto.
(WebCore::RenderMenuList::itemText): Ditto.
(WebCore::RenderMenuList::itemAccessibilityText): Ditto.
(WebCore::RenderMenuList::itemToolTip): Ditto.
(WebCore::RenderMenuList::itemIsEnabled): Ditto. Also use the
disabled function instead of the virtual isEnabledFormControl
function to check if the optgroup is enabled.
(WebCore::RenderMenuList::itemStyle): Ditto.
(WebCore::RenderMenuList::itemBackgroundColor): Ditto.
(WebCore::RenderMenuList::listSize): Ditto.
(WebCore::RenderMenuList::selectedIndex): Ditto.
(WebCore::RenderMenuList::itemIsSeparator): Ditto.
(WebCore::RenderMenuList::itemIsLabel): Ditto.
(WebCore::RenderMenuList::itemIsSelected): Ditto.
(WebCore::RenderMenuList::setTextFromItem): Ditto.

5:04 PM Changeset in webkit [97532] by mhahnenberg@apple.com

84 edits in trunk

Rename virtual put to putVirtual
https://bugs.webkit.org/show_bug.cgi?id=69851

Reviewed by Darin Adler.

Renamed virtual versions of put to putVirtual in prepration for
adding the static put to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same
name.

Source/autotools/symbols.filter:

Source/JavaScriptCore:

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::putVirtual):

API/JSObjectRef.cpp:

(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::putVirtual):
(JSC::DebuggerActivation::put):

debugger/DebuggerActivation.h:
dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):

interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

jsc.cpp:

(GlobalObject::finishCreation):

runtime/Arguments.cpp:

(JSC::Arguments::putVirtual):

runtime/Arguments.h:
runtime/ArrayPrototype.cpp:

(JSC::putProperty):
(JSC::arrayProtoFuncConcat):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSort):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncFilter):
(JSC::arrayProtoFuncMap):

runtime/JSActivation.cpp:

(JSC::JSActivation::putVirtual):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::putVirtual):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::push):
(JSC::JSArray::shiftCount):
(JSC::JSArray::unshiftCount):

runtime/JSArray.h:
runtime/JSByteArray.cpp:

(JSC::JSByteArray::putVirtual):

runtime/JSByteArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::putVirtual):
(JSC::JSCell::put):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::putVirtual):

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::putVirtual):
(JSC::JSGlobalObject::putWithAttributes):

runtime/JSGlobalObject.h:
runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::putVirtual):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::putVirtual):
(JSC::JSObject::put):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:

(JSC::JSValue::put):

runtime/JSStaticScopeObject.cpp:

(JSC::JSStaticScopeObject::putVirtual):

runtime/JSStaticScopeObject.h:
runtime/Lookup.h:

(JSC::lookupPut):

runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::putVirtual):

runtime/ObjectPrototype.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpMatchesArray::fillArrayInstance):
(JSC::RegExpConstructor::putVirtual):

runtime/RegExpConstructor.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::putVirtual):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::putVirtual):

runtime/RegExpObject.h:
runtime/StringObject.cpp:

(JSC::StringObject::putVirtual):

runtime/StringObject.h:
runtime/StringPrototype.cpp:

(JSC::stringProtoFuncSplit):

Source/JavaScriptGlue:

JSValueWrapper.cpp:

(JSValueWrapper::JSObjectSetProperty):

UserObjectImp.cpp:

(UserObjectImp::putVirtual):

UserObjectImp.h:

Source/WebCore:

No new tests.

WebCore.exp.in:
bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::putVirtual):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::putVirtual):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

bindings/js/JSPluginElementFunctions.cpp:

(WebCore::runtimeObjectCustomPut):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::putProperty):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::putVirtual):

bindings/scripts/test/JS/JSTestObj.h:
bridge/NP_jsobject.cpp:

(_NPN_SetProperty):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::setMember):
(JavaJSObject::setSlot):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::putVirtual):

bridge/qt/qt_instance.cpp:

(JSC::Bindings::QtInstance::put):

bridge/qt/qt_runtime.cpp:

(JSC::Bindings::convertQVariantToValue):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::putVirtual):

bridge/runtime_array.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::putVirtual):

bridge/runtime_object.h:
bridge/testqtbindings.cpp:

(main):

Source/WebKit/efl:

ewk/ewk_view.cpp:

(ewk_view_js_object_add):

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::setProperty):

Source/WebKit/qt:

Api/qwebframe.cpp:

(QWebFrame::addToJavaScriptWindowObject):

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::putVirtual):
(WebKit::JSNPObject::put):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):

4:42 PM Changeset in webkit [97531] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r97519.
http://trac.webkit.org/changeset/97519
https://bugs.webkit.org/show_bug.cgi?id=70156

Broke 79+ tests on bots (Requested by dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

4:13 PM Changeset in webkit [97530] by levin@chromium.org

4 edits in trunk/Tools

watchlist: Add a validation check for the email names in the list.
https://bugs.webkit.org/show_bug.cgi?id=70154

Reviewed by Adam Barth.

If an email is listed which doesn't have a bugzilla log in, then any emails
added to the bug along with that email will fail to happen, so try to prevent this
from happening by validating that emails added to the watchlist are known to be
contributors.

Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.

4:04 PM Changeset in webkit [97529] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Windows rebaseline after r97522.

platform/win/fast/harness/results-expected.txt:

3:56 PM Changeset in webkit [97528] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97522.

platform/chromium/fast/harness/results-expected.txt: Tweakaged.

3:52 PM Changeset in webkit [97527] by Beth Dakin

1 edit
2 adds
2 deletes in trunk/LayoutTests

These tests results should really be in the mac-specific directory. They were
added earlier today with https://bugs.webkit.org/show_bug.cgi?id=68641

Rubber-stamped by Andy Estes and Jon Honeycutt.

fast/css/clip-text-in-scaled-div-expected.png: Removed.
fast/css/clip-text-in-scaled-div-expected.txt: Removed.
platform/mac/fast/css/clip-text-in-scaled-div-expected.png: Added.
platform/mac/fast/css/clip-text-in-scaled-div-expected.txt: Added.

3:51 PM Changeset in webkit [97526] by Dimitri Glazkov

1 edit
1 delete in trunk/LayoutTests

[Chromium] Remove the duplicelious expectation.

platform/chromium/fast/css/getComputedStyle/computed-style-border-image-expected.txt: Removed.

3:49 PM Changeset in webkit [97525] by robert@webkit.org

5 edits
2 adds in trunk

Replaced elements squeezed when width is specified as percentage inside a table with Auto layout
https://bugs.webkit.org/show_bug.cgi?id=29447

If inserting a 'replaced' element (e.g. image, plugin) in a table cell that is not descendant from
a block with fixed layout then do not squeeze the element, let it use its intrinsic width and height.

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/replaced/table-percent-width.html

rendering/RenderBox.cpp:

(WebCore::shouldExpandToIntrinsicDimension):
(WebCore::RenderBox::containingBlockReplacedLogicalWidthForContent):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

rendering/RenderBox.h:

LayoutTests:

fast/replaced/table-percent-width-expected.txt: Added.
fast/replaced/table-percent-width.html: Added.
platform/chromium-win/fast/replaced/table-percent-height-expected.txt: Rebaselined

3:45 PM Changeset in webkit [97524] by Simon Fraser

2 edits in trunk/LayoutTests

Fix the bad expected result that I added earlier.

fast/css/getComputedStyle/computed-style-border-image-expected.txt:

3:42 PM Changeset in webkit [97523] by abarth@webkit.org

2 edits in trunk/Tools

Hide status bubbles from queues which are very far behind
https://bugs.webkit.org/show_bug.cgi?id=70133

Reviewed by Eric Seidel.

The mac-ews is so far behind that we shouldn't show its status bubble.
The status bubble just makes contributors sad.

QueueStatusServer/handlers/statusbubble.py:

3:40 PM Changeset in webkit [97522] by rniwa@webkit.org

4 edits in trunk/LayoutTests

nrwt's results.html should show crashed tests before flaky tests
https://bugs.webkit.org/show_bug.cgi?id=66041

Reviewed by Ojan Vafai.

Fixed the over by changing the order in which we aggregate results.

fast/harness/resources/results-test.js: Added a test.
fast/harness/results-expected.txt:
fast/harness/results.html:

3:37 PM Changeset in webkit [97521] by Dimitri Glazkov

3 edits in trunk/Tools

Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=70143

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.

3:35 PM Changeset in webkit [97520] by Dimitri Glazkov

2 edits
2 adds in trunk/LayoutTests

[Chromium] Update expectations after r97502.

platform/chromium/fast/css/getComputedStyle/computed-style-border-image-expected.txt: Added.
platform/chromium/test_expectations.txt:

3:24 PM Changeset in webkit [97519] by caryclark@google.com

2 edits in trunk/Source/WebCore

[Chromium Skia on Mac] Improve focus ring
https://bugs.webkit.org/show_bug.cgi?id=70124

Reviewed by Eric Seidel.

The focus ring code formerly outset the bounds of
the component rectangles by fractional amounts. Because
the rectangles are SkIRect (integer based), the fractional
outset had no effect.

The equivalent code in GraphicsContextMac.mm computes
the curve radius and rectangle outset with integers, so
the use of floats in Skia's case, besides not working,
is unnecessary.

The Skia code also failed to take the offset into account.
In LayoutTests, the focus rings either have an offset of
0 or 2. The CoreGraphics code increases the ring's rectangles
by the offset, then passes the result to wkDrawFocusRing.

I did not find any documentation about how wkDrawFocusRing
further inflates the focus ring, but empirically I determined
that adding 2 to the offset generated rings with identical
outer diameters.

With these adjustments, the layout tests generate focus rings
in the Skia on Mac case that match the coverage of the
Chromium CG-based platform, in particular, matching:

editing/inserting/editable-inline-element.html
editing/selection/3690703-2.html

platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::getFocusRingOutset):
(WebCore::GraphicsContext::drawFocusRing):

3:17 PM Changeset in webkit [97518] by commit-queue@webkit.org

5 edits in trunk

[Qt] Enable fullscreen api on Qt
https://bugs.webkit.org/show_bug.cgi?id=70131

Source/WebCore:

As a result, we have 3 passed tests.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-14
Reviewed by Noam Rosenthal.

features.pri:

LayoutTests:

As a result, we have 3 passed tests.
fullscreen/full-screen-api.html
fullscreen/full-screen-iframe-not-allowed.html
fullscreen/full-screen-remove-ancestor-during-transition.html

Patch by Chang Shu <cshu@webkit.org> on 2011-10-14
Reviewed by Noam Rosenthal.

platform/qt-wk2/Skipped:
platform/qt/Skipped:

3:13 PM Changeset in webkit [97517] by Beth Dakin

2 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70148
Should switch to CoreUI version of CorrectionDot, GrammarDot, and SpellingDot
-and corresponding-
<rdar://problem/10208281>

Reviewed by Anders Carlsson.

Use NS*Dot whenever it's available, and fallback to *Dot only when it is not.

platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::createPatternColor):
(WebCore::GraphicsContext::drawLineForTextChecking):

3:13 PM Changeset in webkit [97516] by dslomov@google.com

13 edits in trunk/Source

https://bugs.webkit.org/show_bug.cgi?id=70120
[Chromium] Pass MessagePortArray to SerializedScriptValue::serialize/deserialize.
This patch augments SerializedScriptValue with MessagePortArray* parameter to implement MessagePort
transfer within the message in the future.

Reviewed by David Levin.

Source/WebCore:

bindings/scripts/CodeGeneratorV8.pm:

(GenerateParametersCheck):

bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

bindings/v8/SerializedScriptValue.h:
bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):

bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):

bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::pushStateCallback):
(WebCore::V8History::replaceStateCallback):

bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

bindings/v8/custom/V8MessagePortCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):

bindings/v8/custom/V8WorkerCustom.cpp:

(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):

workers/Worker.idl:

Source/WebKit/chromium:

src/WebSerializedScriptValue.cpp:

(WebKit::WebSerializedScriptValue::serialize):

3:11 PM Changeset in webkit [97515] by levin@chromium.org

4 edits in trunk/Tools

watchlist: If the style check fails, then the watchlist will not be run.
https://bugs.webkit.org/show_bug.cgi?id=69484

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/queues.py: Run the watch list even

if the style part fails and don't allow watch list failures turn the
bot run red.

Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.

3:11 PM Changeset in webkit [97514] by jeffm@apple.com

8 edits in trunk/Source

../WebCore: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

Add infrastructure to convert from any frame view's coordinate system to the
root view's coordinate system.

Reviewed by Simon Fraser.

No new tests (yet), this is covered by <https://bugs.webkit.org/show_bug.cgi?id=70136>.

WebCore.exp.in: Exported WebCore::ScrollView::contentsToRootView(), used by InjectedBundleHitTestResult.cpp.

platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents): Added (both point and rect versions).
(WebCore::ScrollView::contentsToRootView): Ditto.

platform/ScrollView.h: Added member functions to convert to/from root view coordinates.

platform/Widget.cpp:

(WebCore::Widget::convertFromRootView): Added (both point and rect versions).
(WebCore::Widget::convertToRootView): Ditto.

platform/Widget.h: Added member functions to convert to/from root view coordinates.

../WebKit2: InjectedBundleHitTestResult::imageRect() should return rect in WKView coordinates
https://bugs.webkit.org/show_bug.cgi?id=69963

WebKit2 clients only have knowledge of the WKView's coordinate system, they have no way to
convert from subframe view coordinates , so any rect that we expose through WK2 APIs should
be in WKView coordinates.

Reviewed by Simon Fraser.

WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::imageRect): Use WebCore::FrameView::contentsToRootView() to convert the image rect to WKView coordinates.

3:03 PM Changeset in webkit [97513] by Dimitri Glazkov

2 edits
1 add in trunk/LayoutTests

[Chromium] Update expectations after r97487.

platform/chromium-cg-mac-snowleopard/fast/css/clip-text-in-scaled-div-expected.png: Added.
platform/chromium/test_expectations.txt:

3:01 PM Changeset in webkit [97512] by fpizlo@apple.com

17 edits
1 add in trunk/Source/JavaScriptCore

Reflective Arguments retrieval should be hardened for the
possibility of inlining
https://bugs.webkit.org/show_bug.cgi?id=70068

Reviewed by Oliver Hunt.

CodeBlock can now track, as part of its RareData, the virtual inline
stack at callsites. CallFrame walking can now rematerialize "inline"
CallFrames by combining the meta-data in CodeBlock with the information
already in the JS stack. Arguments can now safely retrieve the
arguments from inline CallFrames.

The DFG already had the notion of a "CodeOrigin" in preparation for
inlining. This notion will now be saved into the CodeBlock, if the DFG
had done inlining. So, CodeOrigin has been moved to bytecode/ and has
been changed to behave more like a struct since that is how it's
meant to be used.

GNUmakefile.list.am:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/CodeBlock.h:

(JSC::CodeBlock::inlineCallFrames):
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::codeOriginForReturn):

bytecode/CodeOrigin.h: Added.

(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):
(JSC::getCallReturnOffsetForCodeOrigin):

dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):

dfg/DFGNode.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

interpreter/CallFrame.cpp:

(JSC::CallFrame::isInlineCallFrame):
(JSC::CallFrame::trueCallerFrame):

interpreter/CallFrame.h:

(JSC::ExecState::inlineCallFrame):
(JSC::ExecState::setInlineCallFrame):
(JSC::ExecState::isInlineCallFrame):
(JSC::ExecState::trueCallerFrame):

interpreter/Interpreter.cpp:

(JSC::Interpreter::findFunctionCallFrame):

interpreter/Register.h:

(JSC::Register::operator=):
(JSC::Register::inlineCallFrame):

runtime/Arguments.h:

(JSC::Arguments::getArgumentsData):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):

runtime/Executable.h:

(JSC::FunctionExecutable::parameterCount):

3:00 PM Changeset in webkit [97511] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

CSSParser: Remove StyleBase usage.
https://bugs.webkit.org/show_bug.cgi?id=70150

Reviewed by Darin Adler.

Split CSSParser::m_parsedStyleObjects into two vectors of
CSSRules and MediaLists.

css/CSSParser.cpp:

(WebCore::CSSParser::createMediaList):
(WebCore::CSSParser::createCharsetRule):
(WebCore::CSSParser::createImportRule):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createKeyframesRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframeRule):

css/CSSParser.h:

2:58 PM Changeset in webkit [97510] by imasaki@chromium.org

2 edits in trunk/LayoutTests

[Chromium] unskipping full screen layout tests. We will do rebaselines later.
https://bugs.webkit.org/show_bug.cgi?id=70144

Reviewed by David Levin.

platform/chromium/test_expectations.txt:

2:50 PM Changeset in webkit [97509] by abarth@webkit.org

18 edits in trunk

canvas getImageData should explain why it throws SECURITY_ERR
https://bugs.webkit.org/show_bug.cgi?id=70088

Reviewed by Darin Adler.

Source/WebCore:

Log as message to the console when getImageData fails because the
canvas is tainted.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

LayoutTests:

Update test results to show the new error message.

http/tests/canvas/philip/tests/security.drawImage.canvas-expected.txt:
http/tests/canvas/philip/tests/security.drawImage.image-expected.txt:
http/tests/canvas/philip/tests/security.pattern.canvas.fillStyle-expected.txt:
http/tests/canvas/philip/tests/security.pattern.canvas.strokeStyle-expected.txt:
http/tests/canvas/philip/tests/security.pattern.cross-expected.txt:
http/tests/canvas/philip/tests/security.pattern.image.fillStyle-expected.txt:
http/tests/canvas/philip/tests/security.pattern.image.strokeStyle-expected.txt:
http/tests/security/canvas-remote-read-data-url-svg-image-expected.txt:
http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt:
http/tests/security/canvas-remote-read-remote-image-blocked-no-crossorigin-expected.txt:
http/tests/security/canvas-remote-read-remote-image-blocked-then-allowed-expected.txt:
http/tests/security/canvas-remote-read-remote-image-expected.txt:
http/tests/security/canvas-remote-read-remote-image-redirect-expected.txt:
http/tests/security/canvas-remote-read-svg-image-expected.txt:

2:33 PM Changeset in webkit [97508] by andreas.kling@nokia.com

4 edits in trunk/Source/WebCore

Inspector: Remove StyleBase usage.
https://bugs.webkit.org/show_bug.cgi?id=70138

Reviewed by Antti Koivisto.

Be fully specific about whether we're operating on a CSSRule or
a CSSStyleSheet.

No behavior change expected, this merely is a cleanup.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::parentStyleSheet):
(WebCore::InspectorCSSAgent::asCSSStyleRule):

inspector/InspectorCSSAgent.h:
inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):

2:25 PM Changeset in webkit [97507] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97502.

platform/chromium/test_expectations.txt: Updated expectations.

2:18 PM Changeset in webkit [97506] by mhahnenberg@apple.com

58 edits in trunk/Source

Rename virtual deleteProperty to deletePropertyVirtual
https://bugs.webkit.org/show_bug.cgi?id=69884

Reviewed by Darin Adler.

Source/JavaScriptCore:

Renamed virtual versions of deleteProperty to deletePropertyVirtual in prepration for
adding the static deleteProperty to the MethodTable in ClassInfo since the
compiler gets mad if the virtual and static versions have the same name.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::deletePropertyVirtual):
(JSC::::deleteProperty):

API/JSObjectRef.cpp:

(JSObjectDeleteProperty):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
debugger/DebuggerActivation.cpp:

(JSC::DebuggerActivation::deletePropertyVirtual):
(JSC::DebuggerActivation::deleteProperty):

debugger/DebuggerActivation.h:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/Arguments.cpp:

(JSC::Arguments::deletePropertyVirtual):

runtime/Arguments.h:
runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):

runtime/JSActivation.cpp:

(JSC::JSActivation::deletePropertyVirtual):

runtime/JSActivation.h:
runtime/JSArray.cpp:

(JSC::JSArray::deletePropertyVirtual):
(JSC::JSArray::deleteProperty):

runtime/JSArray.h:
runtime/JSCell.cpp:

(JSC::JSCell::deletePropertyVirtual):
(JSC::JSCell::deleteProperty):

runtime/JSCell.h:
runtime/JSFunction.cpp:

(JSC::JSFunction::deletePropertyVirtual):

runtime/JSFunction.h:
runtime/JSNotAnObject.cpp:

(JSC::JSNotAnObject::deletePropertyVirtual):

runtime/JSNotAnObject.h:
runtime/JSONObject.cpp:

(JSC::Walker::walk):

runtime/JSObject.cpp:

(JSC::JSObject::deletePropertyVirtual):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::defineOwnProperty):

runtime/JSObject.h:
runtime/JSVariableObject.cpp:

(JSC::JSVariableObject::deletePropertyVirtual):

runtime/JSVariableObject.h:
runtime/RegExpMatchesArray.h:

(JSC::RegExpMatchesArray::deletePropertyVirtual):

runtime/StrictEvalActivation.cpp:

(JSC::StrictEvalActivation::deletePropertyVirtual):

runtime/StrictEvalActivation.h:
runtime/StringObject.cpp:

(JSC::StringObject::deletePropertyVirtual):

runtime/StringObject.h:

Source/WebCore:

No new tests.

WebCore.exp.in:
bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::deletePropertyVirtual):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::deletePropertyVirtual):

bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::deletePropertyVirtual):

bindings/js/JSDOMWindowShell.h:
bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::deletePropertyVirtual):

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::deletePropertyVirtual):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deletePropertyVirtual):

bindings/js/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::remove):

bindings/objc/WebScriptObject.mm:

(-[WebScriptObject removeWebScriptKey:]):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

bridge/NP_jsobject.cpp:

(_NPN_RemoveProperty):

bridge/jni/jni_jsobject.mm:

(JavaJSObject::removeMember):

bridge/objc/objc_runtime.h:
bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::deletePropertyVirtual):

bridge/runtime_array.cpp:

(JSC::RuntimeArray::deletePropertyVirtual):

bridge/runtime_array.h:
bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::deletePropertyVirtual):

bridge/runtime_object.h:

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::removeProperty):

Source/WebKit2:

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::deletePropertyVirtual):
(WebKit::JSNPObject::deleteProperty):

WebProcess/Plugins/Netscape/JSNPObject.h:
WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::removeProperty):

2:17 PM Changeset in webkit [97505] by inferno@chromium.org

2 edits in branches/chromium/874/Source/WebCore/bindings/v8

Merge 97429
BUG=98582
Review URL: http://codereview.chromium.org/8293008

2:12 PM Changeset in webkit [97504] by Dimitri Glazkov

8 edits in trunk/Tools

Plumb style-checker filter up to command options and make land-cowboy use it.
https://bugs.webkit.org/show_bug.cgi?id=70119

Reviewed by Adam Barth.

Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.

1:58 PM Changeset in webkit [97503] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add documentation for WebKitPluginError and WebKitPolicyError.
https://bugs.webkit.org/show_bug.cgi?id=70016

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

UIProcess/API/gtk/WebKitError.h:

1:57 PM Changeset in webkit [97502] by Simon Fraser

4 edits
2 adds in trunk

Web Inspector: WebProcess crashes hard when inspecting elements with border-images applied
https://bugs.webkit.org/show_bug.cgi?id=70105

Source/WebCore:

Reviewed by Dave Hyatt.

Fix three different crashes related to getting computed style for border-image.
In both valueForNinePieceImageSlice() and valueForNinePieceImageQuad(),
assign 'right' to 'left' because we've computed a value for 'right' already.
Otherwise this would leave 'right' as null, causing later crashes in cssText().

In mapNinePieceImage(), borderImage->imageValue() can be null for a border-image
shorthand that is missing the image value.

Test: fast/css/getComputedStyle/computed-style-border-image.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForNinePieceImageSlice):
(WebCore::valueForNinePieceImageQuad):

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::mapNinePieceImage):

LayoutTests:

Reviewed by Dave Hyatt.

Computed style test for border-image.

fast/css/getComputedStyle/computed-style-border-image-expected.txt: Added.
fast/css/getComputedStyle/computed-style-border-image.html: Added.

1:53 PM Changeset in webkit [97501] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

DEPS:

1:33 PM Changeset in webkit [97500] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[WebKit2][gtk] Skip TestWebKitSettings test.
https://bugs.webkit.org/show_bug.cgi?id=70129

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

Skip running TestWebKitSettings test till a bug
https://bugs.webkit.org/show_bug.cgi?id=70127 gets fixed.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Skip TestWebKitSettings test.

1:16 PM Changeset in webkit [97499] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Mac build fix after r97497.

editing/markup.cpp:

(WebCore::isNonTableCellHTMLBlockElement):

1:02 PM Changeset in webkit [97498] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/efl

[EFL] Bump class version after r97421.
https://bugs.webkit.org/show_bug.cgi?id=70102

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Joseph Pecoraro.

r97421 changed the signature of the run_open_panel virtual method in
Ewk_Smart_Class, so we need to bump the class version.

ewk/ewk_view.h:

12:55 PM Changeset in webkit [97497] by dcheng@chromium.org

11 edits in trunk/Source

Context-aware HTML paste for Chromium
https://bugs.webkit.org/show_bug.cgi?id=62112

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add createFragmentFromMarkupWithContext which understands enough about DOM structure to
retain necessary elements to preserve structure and appearance when extracting a subset of
a DOM tree.

Covered by existing layout tests.

editing/MarkupAccumulator.h:
editing/markup.cpp:

(WebCore::isNonTableCellHTMLBlockElement):
(WebCore::isHTMLBlockElement):
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::ancestorToRetainStructureAndAppearance):
(WebCore::ancestorToRetainStructureAndAppearanceWithNoRenderer):
(WebCore::findNodesSurroundingContext):
(WebCore::trimFragment):
(WebCore::createFragmentFromMarkupWithContext):

editing/markup.h:
platform/chromium/ChromiumDataObject.cpp:

(WebCore::ChromiumDataObject::getData):

platform/chromium/DataTransferItemChromium.cpp:

(WebCore::DataTransferItemChromium::getAsString):

platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::documentFragment):

platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

Add WebKit side for plumbing to receive context for HTML paste.

public/WebClipboard.h:

(WebKit::WebClipboard::readHTML):

src/PlatformSupport.cpp:

(WebCore::PlatformSupport::clipboardReadHTML):

12:52 PM Changeset in webkit [97496] by weinig@apple.com

2 edits in trunk/Tools

Remove the Leopard slaves.

Reviewed by Adam Roben.

BuildSlaveSupport/build.webkit.org-config/config.json:

12:49 PM Changeset in webkit [97495] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[chromium skia] Add media/video-playing-and-pause.html to test expectations pending rebaseline
https://bugs.webkit.org/show_bug.cgi?id=70125

Patch by Brian Salomon <bsalomon@google.com> on 2011-10-14
Reviewed by Stephen White.

platform/chromium/test_expectations.txt:

12:48 PM Changeset in webkit [97494] by chang.shu@nokia.com

4 edits in trunk/LayoutTests

2011-10-14 Chang Shu <cshu@webkit.org>

[WK2] Unreviewed gardening.

Some fullscreen tests are passing now on mac WK2 after EventSender support.

platform/gtk-wk2/Skipped:
platform/win-wk2/Skipped:
platform/wk2/Skipped:

12:47 PM Changeset in webkit [97493] by commit-queue@webkit.org

10 edits in trunk

[Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
https://bugs.webkit.org/show_bug.cgi?id=70028

Patch by Peter Beverloo <peter@chromium.org> on 2011-10-14
Reviewed by Adam Barth.

Source/JavaScriptCore:

JavaScriptCore.gyp/JavaScriptCore.gyp:

Source/WebCore:

WebCore.gyp/WebCore.gyp:

Source/WebKit/chromium:

WebKit.gyp:
gyp_webkit:

Tools:

Scripts/update-webkit-chromium:
Scripts/webkitdirs.pm:

(buildChromiumMakefile):
(buildChromium):

12:45 PM Changeset in webkit [97492] by bfulgham@webkit.org

2 edits in trunk/LayoutTests

[WinCairo] Unreviewed Skipped change to get bot green again.

platform/wincairo/Skipped: Skipped all animations, since tests do

not exactly match Windows results on Apple test output.

12:31 PM Changeset in webkit [97491] by Nate Chapin

6 edits in trunk/Source/WebCore

Check CachedResourceClient types with ASSERTs rather
than if statements.
https://bugs.webkit.org/show_bug.cgi?id=70113

Reviewed by Adam Barth.

No new tests, no functionality change.

loader/cache/CachedCSSStyleSheet.cpp:
loader/cache/CachedFont.cpp:
loader/cache/CachedImage.cpp:
loader/cache/CachedResourceClientWalker.h:
loader/cache/CachedXSLStyleSheet.cpp:

12:18 PM Changeset in webkit [97490] by mitz@apple.com

5 edits in trunk/WebKitLibraries

REGRESSION (Safari 5.1 - 5.1.1): CSS nesw-resize cursor shows up as a sw-resize cursor
https://bugs.webkit.org/show_bug.cgi?id=70081

Reviewed by Anders Carlsson.

WebKitSystemInterface.h: Unrelated change, perhaps needed for bug 68478.
libWebKitSystemInterfaceLeopard.a:
libWebKitSystemInterfaceLion.a:
libWebKitSystemInterfaceSnowLeopard.a:

11:54 AM Changeset in webkit [97489] by andreas.kling@nokia.com

3 edits in trunk/Source/WebCore

Don't assert that CSSRules are CSSRules.

Rubber-stamped by Antti Koivisto.

css/CSSRule.h:

(WebCore::CSSRule::isRule):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insert):

11:48 AM Changeset in webkit [97488] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations after r97481.

platform/chromium/test_expectations.txt: Updated.

11:45 AM Changeset in webkit [97487] by Beth Dakin

2 edits in trunk/Source/WebCore

Attempted Leopard build fix.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

11:41 AM Changeset in webkit [97486] by rniwa@webkit.org

2 edits in trunk/Source/WebKit/chromium

Chromium Mac build fix after r97478.

src/mac/WebSubstringUtil.mm:

(WebKit::WebSubstringUtil::attributedSubstringInRange):

11:36 AM Changeset in webkit [97485] by andreas.kling@nokia.com

15 edits in trunk/Source/WebCore

CSSStyleSheet should only ever contain CSSRules.
https://bugs.webkit.org/show_bug.cgi?id=70116

Reviewed by Antti Koivisto.

Move child management from the StyleSheet class down into
CSSStyleSheet and XSLStyleSheet. XSLStyleSheet continues to
manage StyleBase objects, while CSSStyleSheet now only contains
CSSRule.

This is enforced at both compile time and runtime with explicit
types and assertions.

css/CSSRule.h:

(WebCore::CSSRule::isRule):

Promoted to a public method so we can use it in assertions.

css/CSSRuleList.h:

(WebCore::CSSRuleList::create):
(WebCore::CSSRuleList::styleSheet):

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::CSSRuleList):

bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

Change backing to a CSSStyleSheet instead of a StyleSheet.

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::item):

Remove redundant assertions.

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::isLoading):
(WebCore::CSSStyleSheet::addSubresourceStyleURLs):

css/CSSStyleSelector.cpp:

(WebCore::RuleSet::addRulesFromSheet):

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::collectStyleSheets):

page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

Use more specific CSSRule* since that's what we get from
CSSStyleSheet::item() now.

css/StyleSheet.cpp:

(WebCore::StyleSheet::~StyleSheet):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::~CSSStyleSheet):

xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

xml/XSLStyleSheetQt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):

Orphaning logic from ~StyleSheet() moved to subclass dtors.

css/StyleSheet.h:
css/CSSStyleSheet.h:

(WebCore::CSSStyleSheet::length):
(WebCore::CSSStyleSheet::item):

css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::append):
(WebCore::CSSStyleSheet::insert):
(WebCore::CSSStyleSheet::remove):

Moved from StyleSheet and changed to only accept CSSRules.

css/StyleSheet.h:
xml/XSLStyleSheet.h:

(WebCore::XSLStyleSheet::length):
(WebCore::XSLStyleSheet::item):
(WebCore::XSLStyleSheet::append):
(WebCore::XSLStyleSheet::insert):
(WebCore::XSLStyleSheet::remove):

Moved from StyleSheet though still uses StyleBase.

11:34 AM Changeset in webkit [97484] by leandro@webkit.org

3 edits in trunk/Tools

Unreviewed; add missing #includes.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
DumpRenderTree/efl/EventSender.cpp:

11:27 AM Changeset in webkit [97483] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r97375.
http://trac.webkit.org/changeset/97375
https://bugs.webkit.org/show_bug.cgi?id=70115

It breaks loading of webpages in QtWebKit2 (Requested by jeez_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-14

UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForNavigationAction):

UIProcess/qt/ClientImpl.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

11:26 AM Changeset in webkit [97482] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Include dom/ExceptionCode.h instead of Filesystem APIs headers
to fix compile error when ENABLE_WORKERS=1 and ENABLE_FILE_SYSTEM=0
https://bugs.webkit.org/show_bug.cgi?id=70036

Patch by Yuji Sanachan <sanachan.y@gmail.com> on 2011-10-14
Reviewed by Darin Adler.

workers/WorkerContext.cpp:

(WebCore::WorkerContext::importScript):

11:14 AM Changeset in webkit [97481] by Beth Dakin

5 edits
3 adds in trunk

Text drawn via -webkit-background-clip:text should be non-blurry with all scaling
techniques
https://bugs.webkit.org/show_bug.cgi?id=68641

Source/WebCore:

Patch by Darin Adler <Darin Adler> on 2011-10-14
Reviewed by Simon Fraser. Committed by Beth Dakin.

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer): Allocate a buffer based on the
scale
factor of the context.

platform/graphics/GraphicsContext.h: Added createCompatibleBuffer.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Use
createCompatibleBuffer.

LayoutTests:

Reviewed by Simon Fraser.

fast/css/clip-text-in-scaled-div-expected.png: Added.
fast/css/clip-text-in-scaled-div-expected.txt: Added.
fast/css/clip-text-in-scaled-div.html: Added.

11:00 AM Changeset in webkit [97480] by rniwa@webkit.org

10 edits in trunk/Source/WebCore

Move selectionStartStyle and selectionHasStyle to EditingStyle
https://bugs.webkit.org/show_bug.cgi?id=69882

Reviewed by Enrica Casucci.

Moved selectionHasStyle and selectionStartStyle from Editor to EditingStyle.
Also moved much of code in Editor::selectionStartCSSPropertyValue to method of EditingStyle.

In addition, moved Range::editingStartPosition to htmlediting where it belongs
and renamed it to adjustedSelectionStartForStyleComputation.

dom/Range.cpp:
dom/Range.h:
editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle): Extracted from selectionHasStyle.
(WebCore::EditingStyle::legacyFontSize): Extracted from selectionStartCSSPropertyValue.
(WebCore::EditingStyle::styleAtSelectionStart): Moved from Editor::selectionStartStyle.

editing/EditingStyle.h:
editing/Editor.cpp:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::selectionStartHasStyle):
(WebCore::Editor::selectionHasStyle):
(WebCore::Editor::selectionStartCSSPropertyValue):

editing/Editor.h:
editing/EditorCommand.cpp:

(WebCore::executeToggleStyleInList):

editing/htmlediting.cpp:

(WebCore::adjustedSelectionStartForStyleComputation): Moved from Range::editingStartPosition.

editing/htmlediting.h:

10:57 AM Changeset in webkit [97479] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Redundant comparison in AccessibilityObject.cpp updateAXLineStartForVisiblePosition
https://bugs.webkit.org/show_bug.cgi?id=70074

Reviewed by Chris Fleizach.

Removed redundant code.

accessibility/AccessibilityObject.cpp:

(WebCore::updateAXLineStartForVisiblePosition):

10:54 AM Changeset in webkit [97478] by rniwa@webkit.org

18 edits in trunk/Source

Make the interface of locationAndLengthFromRange and rangeFromLocationAndLength consistent
https://bugs.webkit.org/show_bug.cgi?id=69964

Reviewed by Enrica Casucci.

Source/WebCore:

Extracted the logic to determine the scope element as FrameSelection::rootEditableElementOrDocumentElement
and deployed it in WebKit layer. Made locationAndLengthFromRange take a scope element and renamed it to
getLocationAndLengthFromRange.

WebCore.exp.in:
editing/FrameSelection.cpp:

(WebCore::FrameSelection::rootEditableElementOrDocumentElement):

editing/FrameSelection.h:
editing/TextIterator.cpp:

(WebCore::TextIterator::getLocationAndLengthFromRange):

editing/TextIterator.h:

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::firstRectForCharacterRange):
(WebKit::WebFrameImpl::characterIndexForPoint):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::compositionRange):
(WebKit::WebViewImpl::getSelectionOffsetsAndTextInEditableContent):
(WebKit::WebViewImpl::caretOrSelectionRange):

src/mac/WebSubstringUtil.mm:

(WebKit::WebSubstringUtil::attributedSubstringInRange):

Source/WebKit/gtk:

WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::firstRectForCharacterRange):

Source/WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame _convertToNSRange:]):
(-[WebFrame _convertToDOMRange:]):

Source/WebKit/qt:

WebCoreSupport/DumpRenderTreeSupportQt.cpp:

(DumpRenderTreeSupportQt::firstRectForCharacterRange):

Source/WebKit2:

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::getMarkedRange):
(WebKit::WebPage::getSelectedRange):
(WebKit::WebPage::characterIndexForPoint):
(WebKit::convertToRange):

10:23 AM Changeset in webkit [97477] by commit-queue@webkit.org

3 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Performance fix for ResolveGlobal
https://bugs.webkit.org/show_bug.cgi?id=70096

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-14
Reviewed by Gavin Barraclough.

Structure check of global object should be a pointer comparison
instead of a tag and payload pair comparison. This fix improves
SunSpider by 7% on Linux 32, with bitops-bitwise-and improved by 4.75X.
Also two trivial fixes for successful 32-bit build are included.

dfg/DFGSpeculativeJIT.cpp:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:15 AM Changeset in webkit [97476] by jchaffraix@webkit.org

4 edits in trunk/Source/WebKit/win

Remove layerX / layerY from the Windows API
https://bugs.webkit.org/show_bug.cgi?id=70051

Reviewed by Darin Adler.

Renamed layerX to unused1 and layerY to unused2 to keep the
binary compatibility.

DOMEventsClasses.cpp:

(DOMUIEvent::unused1):
(DOMUIEvent::unused2):

DOMEventsClasses.h:

(DOMKeyboardEvent::unused1):
(DOMKeyboardEvent::unused2):
(DOMMouseEvent::unused1):
(DOMMouseEvent::unused2):
(DOMWheelEvent::unused1):
(DOMWheelEvent::unused2):

Interfaces/DOMEvents.idl:

10:12 AM Changeset in webkit [97475] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
https://bugs.webkit.org/show_bug.cgi?id=69770

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Antonio Gomes.

We were just appending the given URL to the absolute URI of the main
frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
instead of "file:///foo/bar/theother/url.html".

This should make fast/dom/navigation-type-navigate.html behave
better (it still fails, but later).

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::queueLoad):

10:04 AM Changeset in webkit [97474] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[GTK] r97438: Inconsistent use of flattening vs flattering in function names/comments
https://bugs.webkit.org/show_bug.cgi?id=70092

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-14
Reviewed by Martin Robinson.

Fixes the miss-spelling of 'PROP_ENABLE_FRAME_FLATTENING' as 'PROP_ENABLE_FRAME_FLATTERING'
introduced with change set r97438.

UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Property name correction.
(webKitSettingsGetProperty): Property name correction.
(webkit_settings_class_init): Property name correction.

UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Spelling correction.

9:49 AM Changeset in webkit [97473] by Csaba Osztrogonác

2 edits
1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt/Skipped:
- Skip a failing test.
- Typo fix after r97471.
platform/qt/http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added after r97388.

9:21 AM Changeset in webkit [97472] by rniwa@webkit.org

3 edits in trunk/LayoutTests

Skip MicroData tests on Mac and WinCairo as well.

platform/mac/Skipped:
platform/wincairo/Skipped:

9:13 AM Changeset in webkit [97471] by rniwa@webkit.org

33 edits
23 adds in trunk

Microdata: Basic implementation of document.getItems() method.
https://bugs.webkit.org/show_bug.cgi?id=68610

Patch by Arko Saha <arko@motorola.com> on 2011-10-13
Reviewed by Ryosuke Niwa.

Added ENABLE(MICRODATA) feature flag.

configure.ac:

Source/WebCore:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

Tests: fast/dom/MicroData/001.html

fast/dom/MicroData/002.html
fast/dom/MicroData/003.html
fast/dom/MicroData/004.html
fast/dom/MicroData/005.html
fast/dom/MicroData/006.html
fast/dom/MicroData/007.html
fast/dom/MicroData/008.html
fast/dom/MicroData/009.html

CMakeLists.txt:
DerivedSources.make:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
dom/Document.cpp:

(WebCore::Document::getItems): Returns NodeList of the element in the Document that
create items, that are not part of other items, and that are of one of the types
given in the argument. If no tokens specified/undefined in the argument, then
return a NodeList containing all top level microdata items.
(WebCore::Document::removeCachedMicroDataItemList): Remove Microdata item node list
from cache.

dom/Document.h:
dom/Document.idl: Added getItems() microdata DOM API.
dom/MicroDataItemList.cpp: Added.

(WebCore::MicroDataItemList::MicroDataItemList):
(WebCore::MicroDataItemList::~MicroDataItemList):
(WebCore::MicroDataItemList::nodeMatches):

dom/MicroDataItemList.h: Added.

(WebCore::MicroDataItemList::create):

dom/Node.cpp:

(WebCore::Node::itemTypeAttributeChanged): It is responsible to invalidate the Microdata
item node cache when itemType attribute changes.
(WebCore::NodeListsNodeData::invalidateCachesThatDependOnAttributes):
(WebCore::NodeListsNodeData::invalidateMicrodataItemListCaches): Invalidate Microdata item
list cache.
(WebCore::NodeListsNodeData::isEmpty):

dom/Node.h:
dom/NodeRareData.h:
features.pri:
html/HTMLAttributeNames.in: Added itemid, itemprop, itemscope, itemtype attributes.
html/HTMLElement.cpp:

(WebCore::HTMLElement::parseMappedAttribute): Handle itemtype attribute change.

html/HTMLElement.idl: Added itemid, itemprop, itemscope, itemtypes microdata attributes.

Source/WebKit/chromium:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

features.gypi:

Tools:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

Scripts/build-webkit:

WebKitLibraries:

Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Added test-cases for document.getItems() method.
Spec: http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
Skipping test-cases for now as Microdata DOM API is not yet enabled.

fast/dom/MicroData: Added.
fast/dom/MicroData/001-expected.txt: Added.
fast/dom/MicroData/001.html: Added.
fast/dom/MicroData/002-expected.txt: Added.
fast/dom/MicroData/002.html: Added.
fast/dom/MicroData/003-expected.txt: Added.
fast/dom/MicroData/003.html: Added.
fast/dom/MicroData/004-expected.txt: Added.
fast/dom/MicroData/004.html: Added.
fast/dom/MicroData/005-expected.txt: Added.
fast/dom/MicroData/005.html: Added.
fast/dom/MicroData/006-expected.txt: Added.
fast/dom/MicroData/006.html: Added.
fast/dom/MicroData/007-expected.txt: Added.
fast/dom/MicroData/007.html: Added.
fast/dom/MicroData/008-expected.txt: Added.
fast/dom/MicroData/008.html: Added.
fast/dom/MicroData/009-expected.txt: Added.
fast/dom/MicroData/009.html: Added.
fast/dom/MicroData/resources: Added.
fast/dom/MicroData/resources/microdata-common.js: Added.

(createElem):
(runTest):

platform/win/Skipped:

8:50 AM Changeset in webkit [97470] by Csaba Osztrogonác

2 edits in trunk/Tools

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Roll-back second part of r97252. :)

Scripts/webkitpy/layout_tests/port/qt.py:

8:45 AM BuildingQt5OnHarmattan edited by abecsi@webkit.org

(diff)

8:36 AM Changeset in webkit [97469] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
https://bugs.webkit.org/show_bug.cgi?id=70106

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Antonio Gomes.

OwnFastMallocPtr was being used as a smart pointer that automatically called
free() on the strings returned by the EFL or by ewk.

However, when WTF is built in release mode, it uses its own memory management
code instead of using the system malloc(), free() and friends. This means bad
things will happen when one uses WTF's free() on memory allocated with system
malloc() by the EFL or ewk.

The easiest way to solve this is to call free() ourselves.

DumpRenderTree/efl/DumpRenderTree.cpp:

(dumpFramesAsText):
(getFinalTestURL):

8:32 AM Changeset in webkit [97468] by andreas.kling@nokia.com

5 edits in trunk/Source/WebCore

Stricter management of WebKitCSSKeyframeRules.
https://bugs.webkit.org/show_bug.cgi?id=70109

Reviewed by Antti Koivisto.

Covered by existing tests.

css/CSSParser.h:
css/CSSParser.cpp:

(WebCore::CSSParser::parseKeyframeRule):

Return a WebKitCSSKeyframeRule instead of a CSSRule.

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::deleteRule):

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::deleteRule):

Moved style sheet orphaning logic for @-webkit-keyframe
from CSSRuleList into WebKitCSSKeyframesRule::deleteRule()
since that's the only caller operating on those rules.

css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::~WebKitCSSKeyframesRule):
(WebCore::WebKitCSSKeyframesRule::length):
(WebCore::WebKitCSSKeyframesRule::item):
(WebCore::WebKitCSSKeyframesRule::insertRule):

Change isKeyframeRule() checks to assertions since we know
our rules are always WebKitCSSKeyframeRules. Also tidied up.

8:10 AM Changeset in webkit [97467] by andreas.kling@nokia.com

1 edit
2 deletes in trunk/Source/WebCore

Unreviewed, actually remove StyleList.* after r97640.

css/StyleList.cpp: Removed.
css/StyleList.h: Removed.

8:04 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

7:57 AM Changeset in webkit [97466] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[Qt] enable qmltests for qt5
https://bugs.webkit.org/show_bug.cgi?id=70037

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-10-14
Reviewed by Chang Shu.

Qml tests seem to be disabled for some reason. This patch enables the tests by including qmltests to SUBDIRS.

UIProcess/API/qt/tests/tests.pro:

7:49 AM Changeset in webkit [97465] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
https://bugs.webkit.org/show_bug.cgi?id=66134

Unreviewed build fix after r97462.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2011-10-14

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

7:43 AM Changeset in webkit [97464] by commit-queue@webkit.org

14 edits
2 adds in trunk

[EFL] Add DumpRenderTreeSupportEfl
https://bugs.webkit.org/show_bug.cgi?id=68458

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-14
Reviewed by Kenneth Rohde Christiansen.

Source/cmake/eflsymbols.filter: Export DumpRenderTreeSupportEfl

symbols so that DumpRenderTree can link to them.

Source/WebKit/efl:

This class is similar to their counterparts present in the Qt and GTK+
ports, and it is responsible for providing an interface to certain
WebCore methods needed by DumpRenderTree.

CMakeListsEfl.txt: Conditionally add the svg directories to the

include path.

WebCoreSupport/DumpRenderTreeSupportEfl.cpp: Added.

(DumpRenderTreeSupportEfl::DumpRenderTreeSupportEfl):
(DumpRenderTreeSupportEfl::~DumpRenderTreeSupportEfl):
(DumpRenderTreeSupportEfl::activeAnimationsCount):
(DumpRenderTreeSupportEfl::clearFrameName):
(DumpRenderTreeSupportEfl::clearOpener):
(DumpRenderTreeSupportEfl::counterValueByElementId):
(DumpRenderTreeSupportEfl::frameChildren):
(DumpRenderTreeSupportEfl::frameParent):
(DumpRenderTreeSupportEfl::layoutFrame):
(DumpRenderTreeSupportEfl::numberOfPages):
(DumpRenderTreeSupportEfl::numberOfPagesForElementId):
(DumpRenderTreeSupportEfl::pauseAnimation):
(DumpRenderTreeSupportEfl::pauseSVGAnimation):
(DumpRenderTreeSupportEfl::pauseTransition):
(DumpRenderTreeSupportEfl::pendingUnloadEventCount):
(DumpRenderTreeSupportEfl::renderTreeDump):
(DumpRenderTreeSupportEfl::responseMimeType):
(DumpRenderTreeSupportEfl::resumeAnimations):
(DumpRenderTreeSupportEfl::selectionRectangle):
(DumpRenderTreeSupportEfl::suitableDRTFrameName):
(DumpRenderTreeSupportEfl::suspendAnimations):
(DumpRenderTreeSupportEfl::findString):
(DumpRenderTreeSupportEfl::garbageCollectorCollect):
(DumpRenderTreeSupportEfl::garbageCollectorCollectOnAlternateThread):
(DumpRenderTreeSupportEfl::javaScriptObjectsCount):
(DumpRenderTreeSupportEfl::workerThreadCount):
(DumpRenderTreeSupportEfl::childHistoryItems):
(DumpRenderTreeSupportEfl::historyItemTarget):
(DumpRenderTreeSupportEfl::isTargetItem):
(DumpRenderTreeSupportEfl::setMockScrollbarsEnabled):

WebCoreSupport/DumpRenderTreeSupportEfl.h: Added.
ewk/ewk_frame.cpp:

(EWKPrivate::coreFrame): Export the WebCore::Frame* related to an
ewk_frame.

ewk/ewk_history.cpp: Remove functions which have been moved to

DumpRenderTreeSupportEfl.
(_ewk_history_item_list_get): _ewk_history_item_new ->
ewk_history_item_new_from_core.
(ewk_history_history_item_back_get): Ditto.
(ewk_history_history_item_current_get): Ditto.
(ewk_history_history_item_forward_get): Ditto.
(ewk_history_history_item_nth_get): Ditto.
(ewk_history_item_new): Ditto.
(ewk_history_item_new_from_core): Rename from _ewk_history_item_new.
(EWKPrivate::coreHistoryItem): Export the WebCore::HistoryItem*
related to an Ewk_History_Item.

ewk/ewk_private.h: Create the EWKPrivate namespace, remove functions

which have been moved to DumpRenderTreeSupportEfl.

ewk/ewk_util.cpp: Remove functions which have been moved to

DumpRenderTreeSupportEfl.

ewk/ewk_view.cpp:

(EWKPrivate::corePage): Export the WebCore::Page* related to an
ewk_view.

Tools:

Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.

DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
(DumpRenderTreeChrome::onWindowObjectCleared):
(DumpRenderTreeChrome::onDocumentLoadFinished):

DumpRenderTree/efl/GCControllerEfl.cpp:

(GCController::collect):
(GCController::collectOnAlternateThread):
(GCController::getJSObjectCount):

DumpRenderTree/efl/LayoutTestControllerEfl.cpp:

(LayoutTestController::counterValueForElementById):
(LayoutTestController::pageNumberForElementById):
(LayoutTestController::numberOfPages):
(LayoutTestController::workerThreadCount):
(LayoutTestController::findString):
(LayoutTestController::pauseAnimationAtTimeOnElementWithId):
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
(LayoutTestController::sampleSVGAnimationForElementAtTime):
(LayoutTestController::numberOfActiveAnimations):
(LayoutTestController::suspendAnimations):
(LayoutTestController::resumeAnimations):

DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView):

7:17 AM Changeset in webkit [97463] by Csaba Osztrogonác

2 edits in trunk/Tools

[Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.

Unreviewed.

Scripts/run-webkit-tests:

(useNewRunWebKitTests):

7:09 AM Changeset in webkit [97462] by kenneth@webkit.org

4 edits in trunk/Source/WebKit2

Do not cache m_resizesToContentsLayoutSize on WebKit2's WebPage
https://bugs.webkit.org/show_bug.cgi?id=66134

Reviewed by Simon Hausmann.

Do the resize to contents on the web process side.

Based on patch by Zalan Bujtas.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSize):
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
(WebKit::WebPage::resizeToContentsIfNeeded):

WebProcess/WebPage/WebPage.h:

7:05 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt version on Windows bots (diff)

6:55 AM Changeset in webkit [97461] by Csaba Osztrogonác

3 edits in trunk/Tools

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Roll-back r97252 with unit test fix.

Reviewed by Csaba Osztrogonác.

Scripts/webkitpy/layout_tests/port/qt.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:

5:48 AM Changeset in webkit [97460] by andreas.kling@nokia.com

12 edits in trunk/Source/WebCore

Merge StyleList into StyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70100

Reviewed by Antti "printf" Koivisto.

Merge all functionality from StyleList into StyleSheet,
since StyleSheet was the only subclass of StyleList anyway.

Also removed FIXME's about throwing exceptions in CSSRuleList
since they were incorrect. The call sites already handle the
relevant cases.

CMakeLists.txt:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSRuleListCustom.cpp:

(WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):

css/CSSRuleList.cpp:

(WebCore::CSSRuleList::CSSRuleList):
(WebCore::CSSRuleList::length):
(WebCore::CSSRuleList::item):
(WebCore::CSSRuleList::deleteRule):
(WebCore::CSSRuleList::append):
(WebCore::CSSRuleList::insertRule):

css/CSSRuleList.h:

(WebCore::CSSRuleList::create):
(WebCore::CSSRuleList::styleSheet):

css/StyleList.cpp: Removed.
css/StyleList.h: Removed.
css/StyleSheet.cpp:

(WebCore::StyleSheet::StyleSheet):
(WebCore::StyleSheet::append):
(WebCore::StyleSheet::insert):
(WebCore::StyleSheet::remove):

css/StyleSheet.h:

(WebCore::StyleSheet::length):
(WebCore::StyleSheet::item):

5:31 AM BuildingQt5OnHarmattan edited by lars.knudsen@nokia.com

(diff)

4:40 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt5 on the WK2 bot (diff)

4:30 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:00 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:00 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

3:23 AM Changeset in webkit [97459] by abarth@webkit.org

6 edits in trunk/LayoutTests

tables/mozilla/bugs/bug53690-1.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67745

Reviewed by Eric Seidel.

Previously, this script had just errored out. This patch removes the
script, making the results more sane.

platform/chromium-win/tables/mozilla/bugs/bug53690-1-expected.txt:
platform/gtk/tables/mozilla/bugs/bug53690-1-expected.txt:
platform/mac/tables/mozilla/bugs/bug53690-1-expected.txt:
platform/qt/tables/mozilla/bugs/bug53690-1-expected.txt:
tables/mozilla/bugs/bug53690-1.html:

3:17 AM BuildingQt5OnHarmattan edited by zeno.albisser@nokia.com

(diff)

3:15 AM Changeset in webkit [97458] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] Build is broken with new ld
https://bugs.webkit.org/show_bug.cgi?id=70097

Reviewed by Philippe Normand.

UIProcess/API/gtk/tests/GNUmakefile.am:

3:14 AM Changeset in webkit [97457] by Simon Hausmann

5 edits in trunk/Source/WebKit2

[Qt][WK2] Fix build after QSGItem API changes
https://bugs.webkit.org/show_bug.cgi?id=69926

Reviewed by Kenneth Rohde Christiansen.

Commit c825865cdd88445aa1db94cdf0da89426919acdb in qtdeclarative changed the
signatures of the Drag & Drop event handlers in QSGItem. The SG specific events
were replaced with the plain QDrag* events, which are now used for widgets as well
as the Qt scene graph.

This patch adapts the desktop webview as well as the page proxy to handle these
kind of events.

UIProcess/API/qt/qdesktopwebview.cpp:

(QDesktopWebView::dragMoveEvent):
(QDesktopWebView::dragEnterEvent):
(QDesktopWebView::dragLeaveEvent):
(QDesktopWebView::dropEvent):

UIProcess/API/qt/qdesktopwebview.h:
UIProcess/qt/qdesktopwebpageproxy.cpp:

(QDesktopWebPageProxy::handleEvent):
(QDesktopWebPageProxy::handleDragEnterEvent):
(QDesktopWebPageProxy::handleDragLeaveEvent):
(QDesktopWebPageProxy::handleDragMoveEvent):
(QDesktopWebPageProxy::handleDropEvent):

UIProcess/qt/qdesktopwebpageproxy.h:

3:09 AM BuildingGtk edited by nayankk@motorola.com

(diff)

3:04 AM BuildingQt5OnHarmattan edited by kenneth@webkit.org

(diff)

3:02 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

2:55 AM Changeset in webkit [97456] by abarth@webkit.org

2 edits
1 move
3 deletes in trunk/LayoutTests

tables/mozilla/bugs/bug9024.html has never worked
https://bugs.webkit.org/show_bug.cgi?id=67744

Reviewed by Eric Seidel.

Previously, this script had just errored out. This patch removes the
scripts, which lets us share the same baseline across all the ports.

platform/chromium-win/tables/mozilla/bugs/bug9024-expected.txt: Removed.
platform/gtk/tables/mozilla/bugs/bug9024-expected.txt: Removed.
platform/mac/tables/mozilla/bugs/bug9024-expected.txt: Removed.
platform/qt/tables/mozilla/bugs/bug9024-expected.txt: Removed.
tables/mozilla/bugs/bug9024-expected.txt: Added.
tables/mozilla/bugs/bug9024.html:

2:42 AM Changeset in webkit [97455] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update.
https://bugs.webkit.org/show_bug.cgi?id=70013

platform/chromium/test_expectations.txt:

Add more canvas crashes.

2:28 AM Changeset in webkit [97454] by mihnea@adobe.com

81 edits in trunk

[CSS Regions] Change -webkit-flow to -webkit-flow-into
https://bugs.webkit.org/show_bug.cgi?id=70014

Reviewed by David Hyatt.

-webkit-flow is renamed to -webkit-flow-into
-webkit-flow-into takes <ident> instead of strings

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::validFlowName):
(WebCore::CSSParser::parseFlowThread):

css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/regions/bottom-overflow-out-of-first-region.html:
fast/regions/content-flowed-into-regions-no-scroll.html:
fast/regions/float-pushed-width-change.html:
fast/regions/floats-basic-in-variable-width-regions.html:
fast/regions/flow-anonymous-children.html:
fast/regions/flow-content-basic-vertical-rl.html:
fast/regions/flow-content-basic-vertical.html:
fast/regions/flow-content-basic.html:
fast/regions/flows-dependency-dynamic-remove.html:
fast/regions/flows-dependency-same-flow.html:
fast/regions/hit-test-float.html:
fast/regions/multiple-directionality-changes-in-variable-width-regions.html:
fast/regions/no-split-line-box.html:
fast/regions/outline-sides-in-region.html:
fast/regions/overflow-in-uniform-regions-dynamic.html:
fast/regions/overflow-in-uniform-regions.html:
fast/regions/overflow-in-variable-width-regions.html:
fast/regions/overflow-moving-below-floats-in-variable-width-regions.html:
fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html:
fast/regions/overflow-rtl-in-variable-width-regions.html:
fast/regions/overflow-size-change-in-variable-width-regions.html:
fast/regions/overflow-size-change-with-stacking-context-rtl.html:
fast/regions/overflow-size-change-with-stacking-context.html:
fast/regions/percentage-margins-mixed-ltr-dominant-regions.html:
fast/regions/percentage-margins-mixed-rtl-dominant-regions.html:
fast/regions/percentage-margins-rtl-variable-width-regions.html:
fast/regions/percentage-margins-variable-width-regions.html:
fast/regions/position-writing-modes-in-variable-width-regions.html:
fast/regions/positioned-objects-block-static-in-regions.html:
fast/regions/positioned-objects-block-static-in-rtl-regions.html:
fast/regions/positioned-objects-block-static-spanning-regions-rtl.html:
fast/regions/positioned-objects-block-static-spanning-regions.html:
fast/regions/positioned-objects-in-regions.html:
fast/regions/positioned-objects-in-rtl-regions.html:
fast/regions/positioned-objects-inline-static-in-regions.html:
fast/regions/positioned-objects-inline-static-in-rtl-regions.html:
fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html:
fast/regions/positioned-objects-inline-static-spanning-regions.html:
fast/regions/positioned-objects-perpendicular-flows-in-regions.html:
fast/regions/positioned-objects-spanning-regions.html:
fast/regions/region-overflow-auto-overflow-hidden.html:
fast/regions/region-overflow-auto-overflow-visible.html:
fast/regions/region-overflow-break.html:
fast/regions/resources/region-style.css:

(.flowArticle):

fast/regions/script-tests/webkit-flow-parsing.js:

(test):
(testComputedStyle):
(testNotInherited):

fast/regions/text-region-breaks.html:
fast/regions/text-region-split-after-resize.html:
fast/regions/text-region-split-horizontal-bt.html:
fast/regions/text-region-split-small-pagination.html:
fast/regions/text-region-split-vertical-rl.html:
fast/regions/text-region-split-vertical.html:
fast/regions/text-region-split.html:
fast/regions/top-overflow-out-of-second-region.html:
fast/regions/webkit-flow-double-pagination-float-push.html:
fast/regions/webkit-flow-float-pushed-to-last-region.html:
fast/regions/webkit-flow-float-unable-to-push.html:
fast/regions/webkit-flow-floats-inside-regions-bounds.html:
fast/regions/webkit-flow-inlines-dynamic.html:
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html:
fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
fast/regions/webkit-flow-parsing-expected.txt:
fast/regions/webkit-flow-renderer-layer.html:
fast/regions/webkit-flow-renderer-nested.html:
fast/regions/webkit-flow-renderer.html:
fast/repaint/japanese-rl-selection-repaint-in-regions.html:
fast/repaint/line-flow-with-floats-in-regions.html:
fast/repaint/overflow-flipped-writing-mode-block-in-regions.html:
fast/repaint/region-painting-via-layout.html:
platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

2:15 AM Changeset in webkit [97453] by hans@chromium.org

17 edits
2 deletes in trunk/Source

IndexedDB: Remove SQLite backing store
https://bugs.webkit.org/show_bug.cgi?id=69620

Reviewed by Darin Fisher.

Remove the SQLite backing store implementation; it is not used anymore.
Also remove the maximumSize parameter, it is not used either.

Source/WebCore:

No new functionality, so no new tests.

GNUmakefile.list.am:
WebCore.gypi:
storage/IDBBackingStore.h:
storage/IDBFactory.cpp:

(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::open):

storage/IDBFactoryBackendImpl.cpp:

(WebCore::computeFileIdentifier):
(WebCore::computeUniqueIdentifier):
(WebCore::IDBFactoryBackendImpl::getDatabaseNames):
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::openBackingStore):

storage/IDBFactoryBackendImpl.h:
storage/IDBFactoryBackendInterface.h:
storage/IDBLevelDBBackingStore.cpp:

(WebCore::IDBLevelDBBackingStore::open):

storage/IDBLevelDBBackingStore.h:
storage/IDBSQLiteBackingStore.cpp: Removed.
storage/IDBSQLiteBackingStore.h: Removed.

Source/WebKit/chromium:

public/WebIDBFactory.h:

(WebKit::WebIDBFactory::getDatabaseNames):
(WebKit::WebIDBFactory::open):

src/AssertMatchingEnums.cpp:
src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::getDatabaseNames):
(WebKit::IDBFactoryBackendProxy::open):

src/IDBFactoryBackendProxy.h:
src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::getDatabaseNames):
(WebKit::WebIDBFactoryImpl::open):

src/WebIDBFactoryImpl.h:

2:06 AM Changeset in webkit [97452] by Nikolas Zimmermann

2 edits in trunk/Source/WebCore

2011-10-14 Nikolas Zimmermann <nzimmermann@rim.com>

Not reviewed. Fix mac builds. r97448 broke them.

WebCore.xcodeproj/project.pbxproj: Set ImageBySizeCache.h role to private.

1:36 AM Changeset in webkit [97451] by jschuh@chromium.org

6 edits in trunk/Source

Clear WebMediaPlayerClientImpl back pointer on destruction
https://bugs.webkit.org/show_bug.cgi?id=69973

Reviewed by James Robinson.

Clear the backpointer and remove the unused m_currentFrame

Source/WebCore:

platform/graphics/chromium/VideoLayerChromium.cpp:

(WebCore::VideoLayerChromium::VideoLayerChromium):
(WebCore::VideoLayerChromium::cleanupResources):
(WebCore::VideoLayerChromium::updateCompositorResources):
(WebCore::VideoLayerChromium::releaseProvider):

platform/graphics/chromium/VideoLayerChromium.h:

Source/WebKit/chromium:

src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):
(WebKit::WebMediaPlayerClientImpl::load):
(WebKit::WebMediaPlayerClientImpl::getCurrentFrame):
(WebKit::WebMediaPlayerClientImpl::putCurrentFrame):

src/WebMediaPlayerClientImpl.h:

1:34 AM Changeset in webkit [97450] by hans@chromium.org

6 edits in trunk

IndexedDB: Make IDBCursor.value() return an IDBAny object
https://bugs.webkit.org/show_bug.cgi?id=70024

Reviewed by Tony Chang.

Source/WebCore:

This is to work around the fact that the V8 bindings mechanism does
eager deserialization of SerializedScriptValue attributes. This means
that the value is fetched from the back-end only once, when the
IDBCursor is first wrapped. When the cursor's value changes, this is
not reflected.

We work around this by making IDBCursor.value() return the
SerializedScriptValue wrapped in an IDBAny object.

storage/IDBCursor.cpp:

(WebCore::IDBCursor::value):

storage/IDBCursor.h:
storage/IDBCursorWithValue.idl:

LayoutTests:

Update test expectations since more of this test now passes.

storage/indexeddb/cursor-inconsistency-expected.txt:

1:12 AM Changeset in webkit [97449] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Fix compilation when the JS Debugger is disabled.
https://bugs.webkit.org/show_bug.cgi?id=70007

Patch by Rémi Duraffort <remi.duraffort@st.com> on 2011-10-14
Reviewed by Antti Koivisto.

inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):

inspector/InspectorRuntimeAgent.cpp:
inspector/InspectorRuntimeAgent.h:
inspector/WorkerInspectorController.cpp:
inspector/WorkerInspectorController.h:
workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):

1:11 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

1:08 AM Changeset in webkit [97448] by Nikolas Zimmermann

59 edits
2 copies in trunk/Source/WebCore

2011-10-13 Nikolas Zimmermann <nzimmermann@rim.com>

Prepare SVGImage intrinsic size negotiation: Introduce an IntSize <-> SVGImage cache in CachedImage
https://bugs.webkit.org/show_bug.cgi?id=69416

Reviewed by Antti Koivisto.

Refactor ImageBySizeCache out of CSSImageGeneratorValue as CachedImage wants to use the same type of cache for its purposes.
When introducing the SVGImage intrinsic size negotiation the container size of an SVGImage is dependant on the place where
it gets embedded (eg width/height attributes of host documents <img> force a certain size).

Currently CachedImage only contains a single RefPtr<Image>, which it constructs out of the decoded data.
Multiple RenderObjects share the same CachedImages, when embedding eg. a SVG document in a <html:img> or using it in a background-image for a <div>.
Consider the case where two RenderObjects use the same CachedImage, each with a different container size (200x100 vs 100x200) and the embedded
document contains a viewBox and some arbitary preserveAspectRatio settings. To honour these we have to relayout the document with the desired
size (percentual unit resolving etc, all depend on the RenderSVGRoots size).

With the current design this is hard to realize, w/o requring to relayout the embedded document for each embedder that uses an SVGImage.
This patch introduces a cache right within CachedImage, which manages a map of images to certain sizes, by utilizing the new ImageBySizeCache.

CachedImage::imageForRenderer() takes a RenderObject* parameter, which it uses to look up the last set image container size for a renderer.
Using that size it queries the cache whether it already has an SVGImage for that size, if not it gets created, by creating a whole
new instance of SVGImage, filling it with the already decoded data, and passing on a fixed image container size, which overrides the
size that RenderSVGRoot reports, when computeReplacedLogicalWidth/Height is called and thus laying out the document at the desired size.
This image is then put in the cache for further reusability.

Likewise CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter and stores that in the cache with an associated container size.
It requires to touch several files which use CachedImage throughout WebCore/WebKit/WebKit2.

The actual cache is not yet turned on yet, so this is not a functional change so far, as it needs some other changes to SVGImage,
which will come with the master patch in bug 47156.

No new tests yet, as the new cache isn't turned on yet.

CMakeLists.txt: Add rendering/ImageBySizeCache.* to build.
GNUmakefile.list.am: Ditto.
WebCore.gypi: Ditto.
WebCore.pro: Ditto.
WebCore.vcproj/WebCore.vcproj: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.
accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use new CachedImage::imageSizeForRenderer(RenderObject*) method.
bindings/objc/DOM.mm: Ditto (for CachedImage::image()). (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
bridge/qt/qt_pixmapruntime.cpp: (JSC::Bindings::QtPixmapInstance::variantFromObject): Ditto (for CachedImage::image()).
css/CSSCanvasValue.cpp: s/m_clients/clients()/, which now live in the ImageBySizeCache instead of CSSImageGeneratorValue. (WebCore::CSSCanvasValue::canvasChanged): (WebCore::CSSCanvasValue::canvasResized): (WebCore::CSSCanvasValue::image):
css/CSSGradientValue.cpp: Ditto. (WebCore::CSSGradientValue::image):
css/CSSImageGeneratorValue.cpp: Move the sizes/clients/images cache into a new ImageBySizeCache class, to make it usable for CachedImage as well. (WebCore::CSSImageGeneratorValue::addClient): Adapt to move. (WebCore::CSSImageGeneratorValue::removeClient): Ditto. (WebCore::CSSImageGeneratorValue::getImage): Ditto. (WebCore::CSSImageGeneratorValue::putImage): Ditto.
css/CSSImageGeneratorValue.h: (WebCore::CSSImageGeneratorValue::clients): Forwarded to the ImageBySizeCache.
editing/DeleteButtonController.cpp: (WebCore::isDeletableElement): CachedImage::canRender() now takes a RenderObject* parameter.
html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::width): Use new CachedImage::imageSizeForRenderer(RenderObject*) method. (WebCore::HTMLImageElement::height): Ditto. (WebCore::HTMLImageElement::naturalWidth): Ditto. (WebCore::HTMLImageElement::naturalHeight): Ditto.
html/ImageDocument.cpp: (WebCore::ImageDocumentParser::finish): Ditto. (WebCore::ImageDocument::scale): Ditto. (WebCore::ImageDocument::resizeImageToFit): Ditto. (WebCore::ImageDocument::imageUpdated): Ditto. (WebCore::ImageDocument::restoreImageSize): Ditto. (WebCore::ImageDocument::imageFitsInWindow): Ditto.
html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin): Use new CachedImage::imageForRenderer(RenderObject*) method.
html/canvas/CanvasRenderingContext2D.cpp: (WebCore::isOriginClean): Ditto. (WebCore::size): Ditto (for CachedImage::imageSizeForRenderer()). (WebCore::CanvasRenderingContext2D::drawImage): Ditto. (WebCore::CanvasRenderingContext2D::createPattern): Ditto.
html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::texImage2D): Ditto. (WebCore::WebGLRenderingContext::texSubImage2D): Ditto.
loader/cache/CachedImage.cpp: Add currently _disabled_ cache for SVGImages. The intrinsic size negotiation will need to use multiple SVGImages for each requested size (equal to the size of the embedding place for the image) - make it possible to cache these SVGImages, and maintain a cache for them. The hash code is a 1:1 refactoring from the already present code in CSSImageGeneratorValue, now named 'ImageBySizeCache'. (WebCore::CachedImage::lookupImageForSize): Looks up an Image from the cache for a given IntSize. Currently turned off. (WebCore::CachedImage::lookupImageForRenderer): Looks up an Image from the cache for a given renderer. Currently turned off. (WebCore::CachedImage::lookupOrCreateImageForRenderer): Looks up an Image from the cache or creates a new SVGImage for a given size and caches it, if possible. Currently turned off. All following changes share this: Don't operate on m_image directly, instead always look up one from the cache for a given size or renderer - if that's not present fallback to m_image. When an SVGImage is first created by CachedImage::createImage() and stored in m_image, the cache remains empty.

If eg. <img width="30" height="70" src="foo.svg"> is used which implies a container size of 30x70 a new SVGImage is created with the additional information of a 30x70 container size
which is immediately passed to the SVGImage after its creation. This SVGImage is put in the ImageBySizeCache associated with a container size of 30x70.
We now have two SVGImage objects present, one living in CachedImage::m_image, created by createImage() during data decoding, and one living in the ImageBySizeCache
created by lookupOrCreateImageForRenderer() associated with the 30x70 container. The first SVGImage::size() will return a value as defined in the referenced foo.svg,
whereas the SVGImage::size() call of the new SVGImage living in the cache reports 30x70 and renders according to that.

Whenever any method of CachedImage is called with a RenderObject* or IntSize, we can't just operate on m_image anymore but instead have to lookup the right
images for a certain renderer/size from the cache and operate on these. When calling eg. CachedImage::image() with a null renderer, m_image is returned.
When passing with a valid renderer only cache lookups are done if the m_image is actually a SVGImage, otherwhise lookupImageForSize/Renderer will just return the m_image.
There is no logical change induced for non-SVGImage derived images.

CachedImage::image() of course needs a RenderObject* parameter now, to identify which of the images from the cache to use, if the underlying image is a SVGImage.
Luckily these information are already present in StyleCachedImage/StyleImage & friends and only need to be added for some additional methods.
(WebCore::CachedImage::image): FIXME
(WebCore::CachedImage::imageForRenderer): Call lookupOrCreateImageForRenderer() instead of returning m_image, if it's not null. Its a no-op for non SVGImage derived objects.
(WebCore::CachedImage::setContainerSizeForRenderer): For non-SVGImages, just pass on the size to the m_image. For SVGImages, associate the passed in renderer with the IntSize in the cache.

This does NOT create the SVGImage yet, this is delayed until imageForRenderer() is called for a given renderer that wants this size.

(WebCore::CachedImage::imageSize): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
(WebCore::CachedImage::imageRect): Ditto.
(WebCore::CachedImage::clear): Force clearing the m_svgImageCache.
(WebCore::CachedImage::data): Call m_image->size() instead of imageSize(), to avoid having to pass a null renderer to imageSize() as here no renderer is available yet.
(WebCore::CachedImage::destroyDecodedData): Don't destroy decoded data for SVG images, as m_data needs to be accessable at any time to construct a cloned SVGImage.

In future we don't need this anymore if we make sure multiple SVGImages share the same trees, but that's for a follow-up patch.

(WebCore::CachedImage::decodedSizeChanged): Don't operate on m_image, ask lookupImageForRenderer() with the incoming renderer.
(WebCore::CachedImage::didDraw): Ditto.
(WebCore::CachedImage::shouldPauseAnimation): Ditto.
(WebCore::CachedImage::animationAdvanced): Ditto.
(WebCore::CachedImage::changedInRect): Ditto. (eg. when leaving out this change animated SVG images wouldn't update anymore, as the animation didn't happen on m_image!)

loader/cache/CachedImage.h: imageForRenderer/canRender/setContainerSizeForRenderer/imageSizeForRenderer now all take a RenderObject* parameter to identifiy the current user of the image. (WebCore::CachedImage::canRender): Pass on the incoming renderer to imageSizeForRenderer().
page/DragController.cpp: (WebCore::getImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
page/EventHandler.cpp: (WebCore::EventHandler::selectCursor): Ditto.
page/PageSerializer.cpp: (WebCore::PageSerializer::serializeFrame): Ditto. (WebCore::PageSerializer::addImageToResources): Ditto. (WebCore::PageSerializer::retrieveResourcesForCSSDeclaration): Ditto.
page/PageSerializer.h:
platform/chromium/ClipboardChromium.cpp: (WebCore::writeImageToDataObject): Ditto.
platform/chromium/PasteboardChromium.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/graphics/Image.h: (WebCore::Image::isSVGImage): Add boolean helper to identify SVGImages, just like isBitmapImage().
platform/gtk/ClipboardGtk.cpp: (WebCore::ClipboardGtk::declareAndWriteDragImage): Use new CachedImage::imageForRenderer(RenderObject*) method.
platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/mac/HTMLConverter.mm: (fileWrapperForElement): Ditto.
platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Ditto.
platform/qt/ClipboardQt.cpp: (WebCore::ClipboardQt::declareAndWriteDragImage): Ditto.
platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/win/ClipboardWin.cpp: (WebCore::writeImageToDataObject): Ditto.
platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage): Ditto.
platform/wince/PasteboardWinCE.cpp: (WebCore::Pasteboard::writeImage): Ditto.
rendering/HitTestResult.cpp: (WebCore::HitTestResult::image): Ditto.
rendering/ImageBySizeCache.cpp: Copied from WebCore/css/CSSImageGeneratorValue.cpp, to preserve history for the original cache code. (WebCore::ImageBySizeCache::ImageBySizeCache): Straight copy from CSSImageGeneratorValue, renamed to ImageBySizeCache, removing all but the cache relevant code. (WebCore::ImageBySizeCache::addClient): Ditto. (WebCore::ImageBySizeCache::removeClient): Ditto. (WebCore::ImageBySizeCache::getImage): Ditto. (WebCore::ImageBySizeCache::putImage): Ditto. (WebCore::ImageBySizeCache::clear): New function, that clears the cache, introduced for the needs of CachedImage. (WebCore::ImageBySizeCache::imageForSize): New function to query an Image* for a given IntSize, introduced for the needs of CachedImage. (WebCore::ImageBySizeCache::sizeForClient): New function to query an IntSize for a given renderer.
rendering/ImageBySizeCache.h: Copied from WebCore/css/CSSImageGeneratorValue.h. (WebCore::ImageBySizeCache::clients):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintFillLayer): CachedImage::canRender() now takes a RenderObject* parameter. (WebCore::InlineFlowBox::paintBoxDecorations): Ditto. (WebCore::InlineFlowBox::paintMask): Ditto.
rendering/RenderBox.cpp: (WebCore::RenderBox::paintMaskImages): Ditto. (WebCore::RenderBox::repaintLayerRectsForImage): Ditto.
rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintFillLayerExtended): Ditto. (WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto (for CachedImage::setContainerSizeForRenderer()). (WebCore::RenderBoxModelObject::paintNinePieceImage): Ditto.
rendering/RenderImage.cpp: (WebCore::RenderImage::imageSizeForError): Use new CachedImage::imageForRenderer(RenderObject*) method. (WebCore::RenderImage::setImageSizeForAltText): Ditto. (WebCore::RenderImage::computeReplacedLogicalWidth): FIXME
rendering/RenderImageResource.cpp: (WebCore::RenderImageResource::setContainerSizeForRenderer): Pass on m_renderer to CachedImage::setContainerSizeForRenderer().
rendering/RenderImageResource.h: Remove constness from setContainerSizeForRenderer. (WebCore::RenderImageResource::image): Pass on m_renderer to CachedImage::image(). (WebCore::RenderImageResource::imageSize): Pass on m_renderer to CachedImage::imageSizeForRenderer().
rendering/RenderImageResourceStyleImage.h: (WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer): Remove constness, pass on m_renderer to StyleImage::setContainerSizeForRenderer().
rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::isDirectlyCompositedImage): Use new CachedImage::imageForRenderer(RenderObject*) method. (WebCore::RenderLayerBacking::updateImageContents): Ditto.
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::computePreferredLogicalWidths): CachedImage::setContainerSizeForRenderer() now takes a RenderObject* parameter.
rendering/RenderObject.cpp: (WebCore::mustRepaintFillLayers): CachedImage::canRender() now takes a RenderObject* parameter. (WebCore::RenderObject::borderImageIsLoadedAndCanBeRendered): Ditto.
rendering/style/StyleCachedImage.cpp: (WebCore::StyleCachedImage::canRender): Pass on incoming renderer to CachedImage::canRender(). (WebCore::StyleCachedImage::imageSize): Pass on incoming renderer to CachedImage::imageSizeForRenderer(). (WebCore::StyleCachedImage::setContainerSizeForRenderer): Pass on incoming renderer to CachedImage::setContainerSizeForRenderer(). (WebCore::StyleCachedImage::addClient): Remove unneeded return statment in void method. (WebCore::StyleCachedImage::removeClient): Ditto. (WebCore::StyleCachedImage::image): Pass on incoming renderer to CachedImage::image().
rendering/style/StyleCachedImage.h: Add RenderObject* parameter to canRender()/setContainerSizeForRenderer(). image() already has one, that was unused so far.
rendering/style/StyleGeneratedImage.cpp: Inlined setContainerSizeForRenderer.
rendering/style/StyleGeneratedImage.h: (WebCore::StyleGeneratedImage::setContainerSizeForRenderer): Add RenderObject* parameter.
rendering/style/StyleImage.h: (WebCore::StyleImage::canRender): Ditto.
rendering/style/StylePendingImage.h: (WebCore::StylePendingImage::setContainerSizeForRenderer): Ditto.
svg/SVGFEImageElement.cpp: (WebCore::SVGFEImageElement::build): Use new CachedImage::imageForRenderer(RenderObject*) method.
svg/graphics/SVGImage.cpp: Cleanup file, the include hack seems not needed anymore. (WebCore::SVGImage::setContainerSize): s/LayoutSize/IntSize/ to match the code in platform/.
svg/graphics/SVGImage.h: Ditto. (WebCore::SVGImage::isSVGImage): Return true.

1:04 AM Changeset in webkit [97447] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Make it possible for plugins to get current fullscreen element.
WebCore::Document already has webkitCurrentFullScreenElement().
Add a wrapper for it in WebKit::WebDocument.
https://bugs.webkit.org/show_bug.cgi?id=70076

Patch by Polina Sokolova <polina@chromium.org> on 2011-10-14
Reviewed by Darin Fisher.

public/WebDocument.h:
src/WebDocument.cpp:

(WebKit::WebDocument::securityOrigin):
(WebKit::WebDocument::isHTMLDocument):
(WebKit::WebDocument::isPluginDocument):
(WebKit::WebDocument::fullScreenElement):

12:07 AM Changeset in webkit [97446] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Speculation failures in ValueToInt32 are causing a 2x slow-down
in Kraken/stanford-crypto-pbkdf2
https://bugs.webkit.org/show_bug.cgi?id=70089

Reviewed by Gavin Barraclough.

If we can't truncate to Int32 using machine code, then don't fail
speculation. Just call JSC::toInt32.

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::callOperation):

dfg/DFGOperations.h:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:01 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt version on the bots (diff)

Oct 13, 2011:

11:57 PM Changeset in webkit [97445] by bashi@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Uninitialized read in WebCore::*Font* / HB_GSUB_Select_Feature
https://bugs.webkit.org/show_bug.cgi?id=70087

Reviewed by Kent Tamura.

Initialize local variables in ComplexTextControllerLinux::setupfontFeatures.

No new tests because there is no behavior change. Manually tested with valgrind.

platform/graphics/chromium/ComplexTextControllerLinux.cpp:

(WebCore::setupFontFeatures):

11:24 PM Changeset in webkit [97444] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit/chromium

Expose layer debug borders to WebLayer
https://bugs.webkit.org/show_bug.cgi?id=70079

Patch by Antoine Labour <piman@chromium.org> on 2011-10-13
Reviewed by Darin Fisher.

public/WebLayer.h:
src/WebLayer.cpp:

(WebKit::WebLayer::setDebugBorderColor):
(WebKit::WebLayer::setDebugBorderWidth):

11:14 PM Changeset in webkit [97443] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

[Qt][Win] Unreviewed buildfix after r97433.

platform/MemoryPressureHandler.h: Add a missing include.

10:21 PM Changeset in webkit [97442] by scherkus@chromium.org

2 edits in trunk/LayoutTests

2011-10-13 Andrew Scherkus <scherkus@chromium.org>

Unreviewed, updating Chromium expectations for http/tests/media/video-play-stall.html.

platform/chromium/test_expectations.txt:

10:12 PM Changeset in webkit [97441] by abarth@webkit.org

4 edits in trunk

Spelling error in v8WebSocket::constructorCallback error
https://bugs.webkit.org/show_bug.cgi?id=63943

Reviewed by Kent Tamura.

Source/WebCore:

Fix typo.

bindings/v8/custom/V8WebSocketCustom.cpp:

(WebCore::V8WebSocket::constructorCallback):

LayoutTests:

platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:

10:08 PM Changeset in webkit [97440] by abarth@webkit.org

1 edit
1 add in trunk/LayoutTests

Add missing result. Yes, it's supposed to be blank.

http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.png: Added.

8:32 PM Changeset in webkit [97439] by tkent@chromium.org

2 edits
20 adds in trunk/LayoutTests

[Chromium] Update test expectation.

Mark some tests flaky on Windows GPU
Update Leopard-specific images.

platform/chromium-cg-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
platform/chromium-cg-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
platform/chromium/test_expectations.txt:

8:18 PM Changeset in webkit [97438] by Martin Robinson

4 edits
3 adds in trunk/Source/WebKit2

[GTK][WEBKIT2] Add WebKitSettings GTK+ API.
https://bugs.webkit.org/show_bug.cgi?id=68371

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-13
Reviewed by Martin Robinson.

WebKitSettings GTK+ object is created and first set of
API's are written to get or set the properties of WebKitSettings.

GNUmakefile.am: Added new files for compilation.
UIProcess/API/gtk/WebKitSettings.cpp: Added.

(_WebKitSettingsPrivate::_WebKitSettingsPrivate): Constructor.
(webKitSettingsSetProperty): Set property function.
(webKitSettingsGetProperty): Get property function.
(webKitSettingsFinalize): Class finalize function.
(webkit_settings_class_init): Class init function.
(webkit_settings_init): Instance init function.
(webkit_settings_new): Creates WebKitSettings GObject.
(webkit_settings_get_enable_javascript): Function to get 'enable-javascript' property.
(webkit_settings_set_enable_javascript): Function to set 'enable-javascript' property.
(webkit_settings_get_auto_load_images): Get the 'auto-load-images' property.
(webkit_settings_set_auto_load_images): Set the 'auto-load-images' property.
(webkit_settings_get_load_icons_ignoring_image_load_setting): Function to get
'load-icons-ignoring-image-load-setting' property.
(webkit_settings_set_load_icons_ignoring_image_load_setting): Function to set
'load-icons-ignoring-image-load-setting' property.
(webkit_settings_get_enable_offline_web_application_cache): Function to get
'enable-offline-web-application-cache' property.
(webkit_settings_set_enable_offline_web_application_cache): Function to set
'enable-offline-web-application-cache' property.
(webkit_settings_get_enable_html5_local_storage): Get the property 'enable-html5-local-storage'.
(webkit_settings_set_enable_html5_local_storage): Set the property 'enable-html5-local-storage'.
(webkit_settings_get_enable_html5_database): Get the property 'enable-html5-database'.
(webkit_settings_set_enable_html5_database): Set the property 'enable-html5-database'.
(webkit_settings_get_enable_xss_auditor): Get property 'enable-xss-editor'.
(webkit_settings_set_enable_xss_auditor): Set property 'enable-xss-editor'.
(webkit_settings_get_enable_frame_flattening): Get the property 'enable-frame-flattening'.
(webkit_settings_set_enable_frame_flattening): Set the property 'enable-frame-flattening'.
(webkit_settings_get_enable_plugins): Get the property 'enable-plugins'.
(webkit_settings_set_enable_plugins): Set the property 'enable-plugins'.
(webkit_settings_get_enable_java): Function to get 'enable-java' property.
(webkit_settings_set_enable_java): Function to set 'enable-java' property.
(webkit_settings_get_javascript_can_open_windows_automatically): Get the property
'javascript-can-open-windows-automatically'.
(webkit_settings_set_javascript_can_open_windows_automatically): Set the property
'javascript-can-open-windows-automatically'.
(webkit_settings_get_enable_hyperlink_auditing): Get 'enable-hyperlink-auditing' property.
(webkit_settings_set_enable_hyperlink_auditing): Set 'enable-hyperlink-auditing' property.

UIProcess/API/gtk/WebKitSettings.h: Added. Public API's.
UIProcess/API/gtk/tests/GNUmakefile.am: Added new test.
UIProcess/API/gtk/tests/TestWebKitSettings.cpp: Added.

(testWebKitSettings): Add WebKitSetting unit test.
(beforeAll): Pre-test function.
(afterAll): Post-test function.

UIProcess/API/gtk/webkit2.h: Add WebKitSettings.h to exposed API list.

8:11 PM Changeset in webkit [97437] by ojan@chromium.org

2 edits in trunk/Tools

Make filter-build-webkit exit 1 if the build fails.
https://bugs.webkit.org/show_bug.cgi?id=70080

Reviewed by Eric Seidel.

This only works if you redirect stderr to stdout, but it at least makes it possible.
This is useful if you want to run a followup command (e.g. run-webkit-tests) but
only if the build succeeds.

Scripts/filter-build-webkit:

7:22 PM Changeset in webkit [97436] by mhahnenberg@apple.com

53 edits in trunk/Source

Rename virtual getConstructData to getConstructDataVirtual
https://bugs.webkit.org/show_bug.cgi?id=69872

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

API/JSCallbackConstructor.cpp:

(JSC::JSCallbackConstructor::getConstructDataVirtual):

API/JSCallbackConstructor.h:
API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:

(JSC::::getConstructDataVirtual):

API/JSObjectRef.cpp:

(JSObjectIsConstructor):
(JSObjectCallAsConstructor):

JavaScriptCore.exp:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
dfg/DFGOperations.cpp:
jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

runtime/ArrayConstructor.cpp:

(JSC::ArrayConstructor::getConstructDataVirtual):

runtime/ArrayConstructor.h:
runtime/BooleanConstructor.cpp:

(JSC::BooleanConstructor::getConstructDataVirtual):

runtime/BooleanConstructor.h:
runtime/DateConstructor.cpp:

(JSC::DateConstructor::getConstructDataVirtual):

runtime/DateConstructor.h:
runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::getConstructDataVirtual):

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::getConstructDataVirtual):

runtime/ErrorConstructor.h:
runtime/FunctionConstructor.cpp:

(JSC::FunctionConstructor::getConstructDataVirtual):

runtime/FunctionConstructor.h:
runtime/JSCell.cpp:

(JSC::JSCell::getConstructDataVirtual):

runtime/JSCell.h:

(JSC::getConstructData):

runtime/JSFunction.cpp:

(JSC::JSFunction::getConstructDataVirtual):

runtime/JSFunction.h:
runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::getConstructDataVirtual):

runtime/NativeErrorConstructor.h:
runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getConstructDataVirtual):

runtime/NumberConstructor.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::getConstructDataVirtual):

runtime/ObjectConstructor.h:
runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::getConstructDataVirtual):

runtime/RegExpConstructor.h:
runtime/StringConstructor.cpp:

(JSC::StringConstructor::getConstructDataVirtual):

runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

WebCore.exp.in:
bindings/js/JSAudioConstructor.cpp:

(WebCore::JSAudioConstructor::getConstructDataVirtual):

bindings/js/JSAudioConstructor.h:
bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::getConstructDataVirtual):

bindings/js/JSImageConstructor.h:
bindings/js/JSOptionConstructor.cpp:

(WebCore::JSOptionConstructor::getConstructDataVirtual):

bindings/js/JSOptionConstructor.h:
bindings/js/ScriptFunctionCall.cpp:

(WebCore::ScriptFunctionCall::construct):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::getConstructDataVirtual):

bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::getConstructDataVirtual):

bridge/runtime_object.h:

Source/WebKit/mac:

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::construct):

Source/WebKit2:

Renamed virtual getConstructData functions to getConstructDataVirtual to
avoid conflicts when we add static getConstructData to the MethodTable.

WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getConstructDataVirtual):

WebProcess/Plugins/Netscape/JSNPObject.h:

6:40 PM Changeset in webkit [97435] by abarth@webkit.org

3 edits in trunk/Websites/bugs.webkit.org

Would be nice if the review-tool offered to show the corresponding header
https://bugs.webkit.org/show_bug.cgi?id=63963

Reviewed by Ojan Vafai.

This is a first cut at adding links to the header file in the review
tool. If folks like this feature, we can cover more cases in the
future.

code-review.js:

6:22 PM Changeset in webkit [97434] by Simon Fraser

4 edits in trunk/Source/WebCore

Remove #include of <QuartzCore/QuartzCore.h> in a widely-used header.

Reviewed by Sam Weinig.

platform/PlatformScreen.h: Typedef PlatformDisplayID to a uint32_t.
platform/graphics/DisplayRefreshMonitor.h: Typedef CVDisplayLinkRef as

an opaque type to avoid bringing in QuartzCore.h, and move displayLinkCallback
to the .cpp file since it uses Core Video types.

platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::displayLinkCallback): Make this a local static function, that
calls a member fuction on the object.
(WebCore::DisplayRefreshMonitor::requestRefreshCallback):
(WebCore::DisplayRefreshMonitor::displayLinkFired):

6:16 PM Changeset in webkit [97433] by msaboff@apple.com

4 edits in trunk/Source/WebCore

REGRESSION: High frequency memory warnings cause Safari to hog the CPU doing useless garbage collection
https://bugs.webkit.org/show_bug.cgi?id=69774

Throttle the processing of memory pressure events to no more often than once every 5 seconds.

Reviewed by Geoffrey Garen.

No new tests.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::MemoryPressureHandler):

platform/MemoryPressureHandler.h:
platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::respondToMemoryPressure):

6:01 PM Changeset in webkit [97432] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Rubber stamped Stephanie Lewis.

DFG_ENABLE() macro was always returning false.

dfg/DFGNode.h:

5:57 PM Changeset in webkit [97431] by haraken@chromium.org

5 edits in trunk

Implement an OverflowEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70017

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/overflow-event-constructor.html

bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.

platform/chromium/test_expectations.txt:

5:42 PM Changeset in webkit [97430] by weinig@apple.com

2 edits in trunk/Source/WebKit2

Another SnowLeopard build fix.

WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::cachedImage):
(WebKit::WebDragClient::declareAndWriteDragImage):
(-[WKPasteboardOwner initWithImage:WebCore::]):

5:37 PM Changeset in webkit [97429] by inferno@chromium.org

3 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=70064

The NPObjectWrapper class used by V8 bindings in Chromium to wrap the window
script object was allocating an instance of itself in the NPAllocate
implementation and returning this pointer. It should be returning a pointer
to the wrapped NPObject structure (NPProxyObject). The member function
getUnderlyingNPObject should return 0 if we fail to find the underlying NPObject
for the call. It was incorrectly returning a pointer to the same NPObject in
this case which could cause recursion.

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2011-10-13
Reviewed by Nate Chapin.

No new tests as there is no change in functionality.

bindings/v8/NPObjectWrapper.cpp:

(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):

bindings/v8/NPObjectWrapper.h:

5:35 PM Changeset in webkit [97428] by weinig@apple.com

3 edits in trunk/Source/WebKit2

Fix SnowLeopard build.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setCursor):

WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

5:29 PM Changeset in webkit [97427] by Dimitri Glazkov

2 edits in trunk/Tools

land-cowboy should at least check style.
https://bugs.webkit.org/show_bug.cgi?id=70073

Reviewed by Adam Barth.

Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.

5:17 PM Changeset in webkit [97426] by simonjam@chromium.org

2 edits in trunk/Source/WebCore

Ensure font loaded before calling Skia to drawPosText in Chrome sandbox
https://bugs.webkit.org/show_bug.cgi?id=69370

Patch by Arthur Hsu <arthurhsu@chromium.org> on 2011-10-13
Reviewed by James Robinson.

platform/graphics/chromium/FontChromiumWin.cpp:

(WebCore::Font::drawGlyphs):

4:51 PM Changeset in webkit [97425] by jchaffraix@webkit.org

3 edits in trunk/Source/WebKit/chromium

Remove layerX / layerY from the Chromium API
https://bugs.webkit.org/show_bug.cgi?id=70052

Reviewed by Darin Fisher.

public/WebDOMMouseEvent.h:
src/WebDOMMouseEvent.cpp:

Just remove the 2 properties without considering the ABI stability.

4:45 PM Changeset in webkit [97424] by haraken@chromium.org

7 edits in trunk/Source/WebCore

Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
https://bugs.webkit.org/show_bug.cgi?id=69801

As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.

Reviewed by Adam Barth.

No new tests, since no change in behavior.

bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.

(GenerateConstructorCallback):

bindings/scripts/test/TestInterface.idl: Ditto.
fileapi/FileReader.idl: Ditto.
p2p/PeerConnection.idl: Ditto.
page/EventSource.idl: Ditto.
workers/Worker.idl: Ditto.

4:39 PM Changeset in webkit [97423] by haraken@chromium.org

4 edits in trunk/Source/WebCore

Constructor should not be called if the object is being constructed inside WebCore
https://bugs.webkit.org/show_bug.cgi?id=70015

Reviewed by Adam Barth.

Summary: A DOM object can be created from the JS context and from the WebCore context.
Constructor should be called if the object is created from the JS context,
but should not be called if the object is created from the WebCore context.

Details:

Expected behavior when the object is created from the JS context (e.g. "new Event()"):

(1) V8XXXX::constructorCallback() is called.
(2) V8XXXX::constructorCallback() calls XXXX::create().
(3) XXXX::create() creates a C++ object.
(4) V8XXXX::constructorCallback() calls toV8() for the C++ object.
(5) toV8() wraps the C++ object and returns the wrapped JS object.

Actual behavior when the object is created from the JS context (e.g. "new Event()"):

As described above (1) - (5). That's fine!!

Expected behavior when the object is created from the WebCore context.

(e.g. "window.addEventListener("load", function (event) { ... });". In this case,
the Event object is created inside the WebCore context):
(1) WebCore calls XXXX::create().
(2) XXXX::create() creates a C++ object.
(3) WebCore calls toV8() for the C++ object.
(4) toV8() wraps the C++ object and returns the wrapped JS object.

Actual behavior when the object is created from the WebCore context.

(e.g. "window.addEventListener("load", function (event) { ... });"):
(1) WebCore calls XXXX::create().
(2) XXXX::create() creates a C++ object.
(3) WebCore calls toV8() for the C++ object.
(4) toV8() can call XXXX::constructorCallback(). (Whether or not toV8() calls
XXXX::constructorCallback() depends on the implementation of toV8().)
(5) V8XXXX::constructorCallback() calls XXXX::create().
(6) XXXX::create() creates another C++ object.
(7) V8XXXX::constructorCallback() calls toV8() for the C++ object.
(8) toV8() wraps the C++ object and returns the wrapped JS object.

This actual behavior definitely causes the following problems:

Problem1: The object returned to JS is not the object created in (2)

but the object created in (6). However, I do not yet know a test case that causes
some visible bug because of this problem.

Problem2: In (4), XXXX::constructorCallback() can be called with no argument.

If XXXX::constructorCallback() expects at least one argument, XXXX::constructorCallback()
throws TypeError, resulting in crash. For example, Event caused this problem
when I implemented constructor for Event. Based on the discussion with Dominicc,
we solved this problem by adding the following two lines of code to Event::constructorCallback()
(See here: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp&exact_package=chromium&q=allowallocation&type=cs):

XXXX::constructorCallback(...) {

...;
if (AllowAllocation::current())

return args.Holder();

...;

}

This if check means "XXXX::constructorCallback() returns immediately if it is called
from the WebCore context".

With these observations, we think that all constructorCallback() should have the above
if check. This patch adds the if check to CodeGeneratorV8.pm. After this patch is landed,
I would like to add the if check to all existing custom V8 constructors.

No new tests, since we could not find a test case that causes some visible bug without the if check.

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback): Generates a constructor so that it returns immediately without doing anything if the constructor is called from the WebCore context.

bindings/scripts/test/V8/V8TestInterface.cpp: Updated the result.

(WebCore::V8TestInterface::constructorCallback):

bindings/scripts/test/V8/V8TestObj.cpp: Ditto.

(WebCore::V8TestObj::constructorCallback):

4:38 PM Changeset in webkit [97422] by ap@apple.com

2 edits in trunk/Source/WebKit2

[Mac] PDF Documents at epo.org look very blurry
https://bugs.webkit.org/show_bug.cgi?id=70072

Reviewed by Dan Bernstein.

WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::paintContent): Ensure integral coordinates. <rdar://problem/10283382> tracks lifting this limitation.

4:37 PM Changeset in webkit [97421] by commit-queue@webkit.org

5 edits in trunk/Source/WebKit/efl

[EFL]: Move from FileChooserSettings deprecatedAcceptType to acceptMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=70002

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-10-13
Reviewed by Joseph Pecoraro.

Adapt to the changes introduced in r97336 and r97338 by using a vector
of strings instead of a single string in runOpenPanel().

WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::runOpenPanel):

ewk/ewk_private.h:
ewk/ewk_view.cpp:

(ewk_view_run_open_panel): Change signature; accept a Vector<String>
instead of a char*. Build an Eina_List to pass for child classes.

ewk/ewk_view.h:

4:22 PM Changeset in webkit [97420] by tony@chromium.org

2 edits in trunk/Tools

fix regex in layout test times dashboard
https://bugs.webkit.org/show_bug.cgi?id=70059

This fixes the treemapfocus query param.

Reviewed by Ojan Vafai.

TestResultServer/static-dashboards/treemap.html:

4:16 PM Changeset in webkit [97419] by haraken@chromium.org

5 edits in trunk

Implement a BeforeLoadEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69980

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/before-load-event-constructor.html

bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.

platform/chromium/test_expectations.txt:

4:14 PM Changeset in webkit [97418] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Add a colon to make expectation valid.

platform/chromium/test_expectations.txt: Jeez.

4:08 PM Changeset in webkit [97417] by commit-queue@webkit.org

6 edits
6 adds in trunk

make IDBFactory.open wait for pending setVersion transactions to complete
https://bugs.webkit.org/show_bug.cgi?id=69307

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-13
Reviewed by Tony Chang.

Source/WebCore:

Added a queue of pending open calls, similar to the queue of pending
setVersion calls. Ensure pending calls are processed in the correct
order when transactions complete.

Tests: storage/indexeddb/open-close-version.html

storage/indexeddb/two-version-changes.html
storage/indexeddb/version-change-exclusive.html

storage/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::callbacks):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::setVersion):
(WebCore::IDBDatabaseBackendImpl::transactionStarted):
(WebCore::IDBDatabaseBackendImpl::transactionFinished):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):

storage/IDBDatabaseBackendImpl.h:
storage/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

storage/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::start):
(WebCore::IDBTransactionBackendImpl::commit):

LayoutTests:

Some tests marked FAIL due to crbug.com/100123

storage/indexeddb/open-close-version-expected.txt: Added.
storage/indexeddb/open-close-version.html: Added.
storage/indexeddb/two-version-changes-expected.txt: Added.
storage/indexeddb/two-version-changes.html: Added.
storage/indexeddb/version-change-exclusive-expected.txt: Added.
storage/indexeddb/version-change-exclusive.html: Added.

3:54 PM Changeset in webkit [97416] by Dimitri Glazkov

2 edits in trunk/LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=70069
REGRESSION (r63637): [Chromium] http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php reports as MISSING results.

platform/chromium/test_expectations.txt: Added expectations.

3:51 PM Changeset in webkit [97415] by thakis@chromium.org

2 edits in trunk/Source/WebKit/chromium

[chromium] Automatically pull clang on update-webkit --chromium on mac
https://bugs.webkit.org/show_bug.cgi?id=70058

Reviewed by Adam Barth.

DEPS:

3:39 PM Changeset in webkit [97414] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Tweaking moar expectations.

platform/chromium/test_expectations.txt: Tweakage.

3:34 PM Changeset in webkit [97413] by cmarrin@apple.com

2 edits in trunk/Source/WebCore

Leopard build fix

3:30 PM Changeset in webkit [97412] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Speculative build fix for !DFG builds.

jit/JIT.cpp:

(JSC::JIT::privateCompile):

3:25 PM Changeset in webkit [97411] by ap@apple.com

3 edits in trunk/Source/WebKit2

[Mac] Wheel event handler counter is incorrect with PDF views
https://bugs.webkit.org/show_bug.cgi?id=70062

Reviewed by Dan Bernstein.

WebProcess/Plugins/PDF/BuiltInPDFView.h:
WebProcess/Plugins/PDF/BuiltInPDFView.cpp: (WebKit::BuiltInPDFView::didAddVerticalScrollbar): Added forgotten override for vertical case. (WebKit::BuiltInPDFView::willRemoveVerticalScrollbar): Ditto. (WebKit::BuiltInPDFView::createScrollbar): Notify self, do not make a shortcut to ScrollAnimator. (WebKit::BuiltInPDFView::destroyScrollbar): Ditto. (WebKit::BuiltInPDFView::destroy): Actually destroy the scrollbars.

3:23 PM Changeset in webkit [97410] by oliver@apple.com

8 edits in trunk/Source/JavaScriptCore

Fix performance of ValueToInt32 node when predicting double
https://bugs.webkit.org/show_bug.cgi?id=70063

Reviewed by Filip Pizlo.

Currently we fail to inline double to int conversion when
performing a ValueToInt32 operation on a value we predict
to be a double.

dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

Apply correct filter for the double prediction path

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativeValueToInt32):

Support double parameters even when value has been spilled.

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueToInt32):

Moved old valueToInt32 code to this function, and added
path for double prediction

dfg/DFGSpeculativeJIT.h:
dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

Made the two implementations of ValueToInt32 call a single
shared compileValueToInt32 function.

3:11 PM Changeset in webkit [97409] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/qt

[Qt] GeolocationClient cleanups
https://bugs.webkit.org/show_bug.cgi?id=69737

Patch by Adenilson Cavalcanti <adenilson.silva@openbossa.org> on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.

Qt5 has a location module, so no need to use an external
library like Qt Mobility. This patch will allow the GeolocationClientQt
to compile with both Qt5 and Qt4.

QtWebKit.pro:
WebCoreSupport/GeolocationClientQt.cpp:

(WebCore::GeolocationClientQt::positionUpdated):

WebCoreSupport/GeolocationClientQt.h:

3:11 PM Changeset in webkit [97408] by barraclough@apple.com

21 edits in trunk/Source/JavaScriptCore

Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911

Patch by Chris Marrin <cmarrin@apple.com> on 2011-10-13
Reviewed by Simon Fraser.

Add REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for implementations
that use the DisplayRefreshMonitor logic.

wtf/Platform.h:

3:09 PM Changeset in webkit [97407] by Beth Dakin

30 edits
17 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=70050
DRT and WRT should have HiDPI testing capabilities

Reviewed by Darin Adler.

Source/WebKit/mac:

New method _backingScaleFactor matches SPI of a similar name that I added
recently to WKPage in WebKit2. Equivalent functionality is needed for
DumpRenderTree's HiDPI support.

WebView/WebView.mm:

(-[WebView _backingScaleFactor]):

WebView/WebViewPrivate.h:

Tools:

New layoutTestController function setBackingScaleFactor takes a double for a scale
factor and a callback function to call once the backing scale factor has
successfully been set for the view.

DumpRenderTree/LayoutTestController.cpp:

(setBackingScaleFactorCallback):
(LayoutTestController::staticFunctions):

On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other
platforms do nothing.

DumpRenderTree/LayoutTestController.h:
DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setBackingScaleFactor):

DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setBackingScaleFactor):

DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setBackingScaleFactor):

Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a
value of 0, which resets to the system default.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

When generating the pixel dump, create a Bitmap of the appropriate size based on
the backing scale factor. If it is a HiDPI view, paint into the context using
displayRectIgnoringOpacity.

DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createBitmapContextFromWebView):

And now the same stuff for WK2. Again, new layoutTestController function
setBackingScaleFactor takes a double for a scale factor and a callback function.

WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:

(WTR::LayoutTestController::setBackingScaleFactor):
(WTR::LayoutTestController::callSetBackingScaleFactorCallback):

WebKitTestRunner/InjectedBundle/LayoutTestController.h:

The InjectedBundle sends a message to the UI process to set the backing scale
factor. It also processes a message the UI process will send back once it
completes this task, and at that time, the InjectedBundle calls the callback.

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::postSetBackingScaleFactor):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor
with a value of 0, which resets to the system default.

WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

Upon receiving the SetBackingScaleFactor message, call
WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message
back to InjectedBundle to say it has been done.

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a
window's scale factor so we have to avoid that.

WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

LayoutTests:

New HiDPI tests and results. These should be skipped on all non-Lion platforms.

fast/hidpi: Added.
fast/hidpi/broken-image-icon-hidpi.html: Added.
fast/hidpi/broken-image-with-size-hidpi.html: Added.
fast/hidpi/clip-text-in-hidpi.html: Added.
fast/hidpi/resize-corner-hidpi.html: Added.
fast/hidpi/video-controls-in-hidpi.html: Added.
platform/gtk-wk2/Skipped:
platform/gtk/Skipped:
platform/mac-leopard/Skipped:
platform/mac-snowleopard/Skipped:
platform/mac/fast/hidpi: Added.
platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.png: Added.
platform/mac/fast/hidpi/broken-image-icon-hidpi-expected.txt: Added.
platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.png: Added.
platform/mac/fast/hidpi/broken-image-with-size-hidpi-expected.txt: Added.
platform/mac/fast/hidpi/clip-text-in-hidpi-expected.png: Added.
platform/mac/fast/hidpi/clip-text-in-hidpi-expected.txt: Added.
platform/mac/fast/hidpi/resize-corner-hidpi-expected.png: Added.
platform/mac/fast/hidpi/resize-corner-hidpi-expected.txt: Added.
platform/mac/fast/hidpi/video-controls-in-hidpi-expected.png: Added.
platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt: Added.
platform/qt-mac/Skipped:
platform/qt-wk2/Skipped:
platform/qt/Skipped:
platform/win-wk2/Skipped:
platform/win/Skipped:
platform/wincairo/Skipped:

3:01 PM Changeset in webkit [97406] by Dimitri Glazkov

3 edits
2 moves
13 adds
1 delete in trunk/LayoutTests

Update expectations after gdi->skia switch.

platform/chromium-cg-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/svg/batik/text/textFeatures-expected.png.
platform/chromium-mac-leopard/svg/batik/text/textFeatures-expected.png: Added.
platform/chromium-mac-leopard/svg/css/text-shadow-multiple-expected.png: Added.
platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png: Added.
platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/chromium-mac/svg/css/text-shadow-multiple-expected.png.
platform/chromium-mac/svg/batik/text/textFeatures-expected.png: Removed.
platform/chromium-win-xp/svg/css/text-shadow-multiple-expected.png: Added.
platform/chromium-win/svg/batik/text/textFeatures-expected.png:
platform/chromium-win/svg/css/text-shadow-multiple-expected.png:

2:59 PM Changeset in webkit [97405] by cmarrin@apple.com

22 edits
6 adds in trunk

Sync requestAnimationFrame callback to CVDisplayLink on Mac
https://bugs.webkit.org/show_bug.cgi?id=68911

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Add REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR for implementations
that use the DisplayRefreshMonitor logic.

wtf/Platform.h:

Source/WebCore:

Test: fast/animation/request-animation-frame-iframe.html

Implement CVDisplayLink which checks to see if any scheduleAnimation requests
have come in. If so, remember the timestamp and do a callOnMainThread to fire
the callbacks. A DisplayRefreshMonitorManager is a singleton which has a list
of DisplayRefreshMonitors, one for each display. Each monitor has one or more
DisplayRefreshMonitorClients, which is a abstract virtual class implemented
by ScriptAnimationController. When an animation is scheduled, the
displayRefreshFired method is called on the client, which in turn calls the
requestAnimationFrame callbacks.

DisplayRefreshMonitor and therefore the CVDisplayLink it owns is discarded
when it no longer has any clients. This minimizes the number of concurrent
CVDisplayLink threads.

WebCore.exp.in:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::windowScreenDidChange):
(WebCore::Document::webkitRequestAnimationFrame):

dom/Document.h:
dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::windowScreenDidChange):
(WebCore::ScriptedAnimationController::scheduleAnimation):

dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::displayRefreshFired):

page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::windowScreenDidChange):

page/Page.h:

(WebCore::Page::displayID):

platform/PlatformScreen.h:
platform/graphics/DisplayRefreshMonitor.cpp: Added.

(WebCore::DisplayRefreshMonitorClient::DisplayRefreshMonitorClient):
(WebCore::DisplayRefreshMonitorClient::~DisplayRefreshMonitorClient):
(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::refreshDisplayOnMainThread):
(WebCore::DisplayRefreshMonitorManager::sharedManager):
(WebCore::DisplayRefreshMonitorManager::findMonitor):
(WebCore::DisplayRefreshMonitorManager::registerClient):
(WebCore::DisplayRefreshMonitorManager::unregisterClient):
(WebCore::DisplayRefreshMonitorManager::scheduleAnimation):
(WebCore::DisplayRefreshMonitorManager::windowScreenDidChange):

platform/graphics/DisplayRefreshMonitor.h: Added.

(WebCore::DisplayRefreshMonitorClient::scheduleAnimation):
(WebCore::DisplayRefreshMonitor::hasClients):
(WebCore::DisplayRefreshMonitor::addClient):
(WebCore::DisplayRefreshMonitor::removeClient):
(WebCore::DisplayRefreshMonitor::displayID):
(WebCore::DisplayRefreshMonitorManager::DisplayRefreshMonitorManager):

platform/graphics/mac/DisplayRefreshMonitorMac.cpp: Added.

(WebCore::DisplayRefreshMonitor::displayLinkCallback):
(WebCore::DisplayRefreshMonitor::~DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::scheduleAnimation):

Source/WebKit/mac:

Add windowDidChangeScreen function which listens for the window changing
screens and passes the new displayID along to WebCore::Page. It also sends
one on windowWillOrderOnScreen, so the Page has a fresh displayID after it's
created.

WebView/WebView.mm:

(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _windowDidChangeScreen:]):
(-[WebView _windowWillOrderOnScreen:]):

Source/WebKit2:

Add windowDidChangeScreen function which listens for the window changing
screens and passes the new displayID along to WebCore::Page. It also sends
one on windowDidBecomeKey, so the Page has a fresh displayID after it's
created. Event is generated in the UIProcess and then sent over to the
WebProcess, which actually sends it to WebCore::Page.

UIProcess/API/mac/WKView.mm:

(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView _windowDidChangeScreen:]):
(-[WKView _windowDidBecomeKey:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::windowScreenDidChange):

UIProcess/WebPageProxy.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowScreenDidChange):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

Test to make sure requestAnimationFrame events fire inside iframe

fast/animation/request-animation-frame-iframe-expected.txt: Added.
fast/animation/request-animation-frame-iframe.html: Added.
fast/animation/script-tests/request-animation-frame-subframe.html: Added.

2:52 PM Changeset in webkit [97404] by inferno@chromium.org

2 edits in trunk/Source/WebCore

Unreviewed. Qt compile fix.

css/CSSFontFaceSource.cpp: include Document.h.

2:40 PM Changeset in webkit [97403] by inferno@chromium.org

8 edits
2 copies in branches/chromium/874

Merge 97402 - Source/WebCore: Register custom fonts at their creation time, rather than at retirement time.

BUG=100059
Review URL: http://codereview.chromium.org/8273018

2:37 PM Changeset in webkit [97402] by inferno@chromium.org

10 edits
2 adds in trunk

Source/WebCore: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929

Reviewed by Dan Bernstein.

Test: fast/text/custom-font-data-crash2.html

css/CSSFontFace.cpp:
css/CSSFontFace.h: remove function added in r94508,

which is no longer needed. We now register custom fonts
at creation time.

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSFontFaceSource::getFontData): register custom
font to document's m_customFonts.

css/CSSFontSelector.cpp:
css/CSSFontSelector.h: remove function added in r94508,

which is no longer needed. We now register custom fonts
at creation time.

css/CSSSegmentedFontFace.cpp:

(WebCore::CSSSegmentedFontFace::pruneTable): no longer need
to delete/retire font data here, it will be handled in ~Document.
(WebCore::CSSSegmentedFontFace::getFontData): register custom
font to document's m_customFonts.

dom/Document.cpp: Change function names to registerCustomFont

, deleteCustomFonts and local to m_customFont.
(WebCore::Document::~Document):
(WebCore::Document::recalcStyle): yanking out the comment. We
no longer keep retired custom fonts. We clear all custom fonts
on Document destruction.
(WebCore::Document::registerCustomFont):
(WebCore::Document::deleteCustomFonts):

dom/Document.h:

LayoutTests: Register custom fonts at their creation time,
rather than at retirement time.
https://bugs.webkit.org/show_bug.cgi?id=68929

Reviewed by Dan Bernstein.

fast/text/custom-font-data-crash2-expected.txt: Added.
fast/text/custom-font-data-crash2.html: Added.

2:28 PM Changeset in webkit [97401] by Simon Fraser

1 edit
2 adds in trunk/LayoutTests

Add results to keep the bots quiet.

fast/images/color-jpeg-with-color-profile-expected.png: Added.
fast/images/color-jpeg-with-color-profile-expected.txt: Added.

2:25 PM Changeset in webkit [97400] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Tweak flakiness expectation.

platform/chromium/test_expectations.txt: Tweaked.

2:20 PM Changeset in webkit [97399] by jesus@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
https://bugs.webkit.org/show_bug.cgi?id=70053

Reviewed by Kenneth Rohde Christiansen.

Now we will be aligned with WKError.h and WebError.h by using the shared
and pre-defined enum for error codes and WebError::webkitErrorDomain().

WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:

(WebKit::blockedError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):

2:16 PM Changeset in webkit [97398] by jesus@webkit.org

2 edits in trunk/Source/WebKit2

[Qt][WK2] WebViews are emitting loadFailed for "private" error codes
https://bugs.webkit.org/show_bug.cgi?id=70047

Reviewed by Kenneth Rohde Christiansen.

Both QDesktopWebView and QTouchWebView are emitting loadFailed for private errors
like the ones defined in Source/WebKit2/WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp.

We now filter these by not emitting this signal for FrameLoadInterruptedByPolicyChange,
PlugInWillHandleLoad and Cancellation, following previous decisions from WebKit 1.

UIProcess/qt/ClientImpl.cpp:

(dispatchLoadFailed):

2:11 PM Changeset in webkit [97397] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Add GPU crashes that cropped up.

platform/chromium/test_expectations.txt: Added.

2:05 PM Changeset in webkit [97396] by Dimitri Glazkov

2 edits in trunk/LayoutTests

Remove expectations of failure after r97149.

platform/chromium/test_expectations.txt: Yipee.

1:58 PM Changeset in webkit [97395] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Crash in DeleteSelectionCommand::handleGeneralDelete
https://bugs.webkit.org/show_bug.cgi?id=70045

Reviewed by Darin Adler.

Exit early when m_upstreamStart is null.

No new tests because we don't have a reduction.

editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

1:54 PM Changeset in webkit [97394] by Dimitri Glazkov

2 edits
3 moves
9 adds in trunk/LayoutTests

[Chromium] Update expectations after r97378.

1:51 PM Changeset in webkit [97393] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

terminateSpeculativeExecution for fillSpeculateDouble with DataFormatCell

Rubber stamped by Filip Pizlo

This is breaking fast/canvas/canvas-composite-alpha.html on 32_64 DFG JIT.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):

1:48 PM Changeset in webkit [97392] by Dimitri Glazkov

2 edits
61 adds in trunk/LayoutTests

[Chromium] Update expectations after r97369.

platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
platform/chromium-linux/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
platform/chromium-win/fast/repaint/region-painting-via-layout-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
platform/chromium-win/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
platform/chromium/fast/repaint/region-painting-via-layout-expected.png: Added.
platform/chromium/test_expectations.txt: Removed failure expectations.

1:37 PM Changeset in webkit [97391] by hyatt@apple.com

3 edits
3 adds in trunk

https://bugs.webkit.org/show_bug.cgi?id=70049

[CSS Regions] Add a test of a float being pushed down because it can't fit
next to another float and make sure it re-evaluates its position when it changes
regions as a result of the push.

Reviewed by Sam Weinig.

Source/WebCore:

Added new test in fast/regions.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat):

LayoutTests:

fast/regions/float-pushed-width-change.html: Added.
platform/mac/fast/regions/float-pushed-width-change-expected.png: Added.
platform/mac/fast/regions/float-pushed-width-change-expected.txt: Added.

1:22 PM Changeset in webkit [97390] by robert@webkit.org

1 edit
9 adds in trunk/LayoutTests

Platform-specific results for r97378

Unreviewed, new platform-specific results.

platform/gtk/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
platform/gtk/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
platform/gtk/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.
platform/qt/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
platform/qt/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
platform/qt/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.

1:18 PM Changeset in webkit [97389] by commit-queue@webkit.org

2 edits
10 adds in trunk/LayoutTests

Rebaseline for webkit bug 69503
https://bugs.webkit.org/show_bug.cgi?id=69818

Patch by Ben Wells <benwells@chromium.org> on 2011-10-13
Reviewed by Tony Chang.

platform/chromium-cg-mac-leopard/fast/css/text-transform-select-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
platform/chromium-linux/fast/css/text-transform-select-expected.txt: Added.
platform/chromium-mac-leopard/fast/css/text-transform-select-expected.png: Added.
platform/chromium-mac-snowleopard/fast/css/text-transform-select-expected.png: Added.
platform/chromium-win/fast/css/text-transform-select-expected.png: Added.
platform/chromium-win/fast/css/text-transform-select-expected.txt: Added.
platform/chromium/fast/css/text-transform-select-expected.txt: Added.
platform/chromium/test_expectations.txt:

1:03 PM Changeset in webkit [97388] by abarth@webkit.org

6 edits
2 copies
2 adds in trunk

Move XSTL to script-src in Content-Security-Policy
https://bugs.webkit.org/show_bug.cgi?id=63637

Reviewed by Eric Seidel.

Source/WebCore:

The spec was unclear about how to treat XSLT. My reading was that they
should fall under style-src, but further discussion on the mailing list
settled on using script-src because an XSLT can inject arbitrary DOM
and script into a page, which is more risky than including style.

Tests: http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php

http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

http/tests/security/contentSecurityPolicy/xsl-allowed.php:
http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
http/tests/security/contentSecurityPolicy/xsl-blocked.php:
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1-expected.txt: Added.
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-1.php: Added.
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2-expected.txt: Added.
http/tests/security/contentSecurityPolicy/xsl-unaffected-by-style-src-2.php: Added.

12:47 PM Changeset in webkit [97387] by commit-queue@webkit.org

3 edits in trunk/Source

[Qt] QtWebKit build error for Mac 32bit
https://bugs.webkit.org/show_bug.cgi?id=69914

In WebCore.pro and QtWebKit.pro we define NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES
when compiling with ENABLE_VIDEO and with WTF_USE_QTKIT.
But this is meant to be defined in NSGeometry.h under certain preconditions.
Without setting NS_BUILD_32_LIKE_64 none of these preconditions is
met and therefore NSGeometry.h will create several conflicting type definitions.

With this patch we create consistent definitions again.
Due to the order of include files we cannot remove
NSGEOMETRY_TYPES_SAME_AS_CGGEOMETRY_TYPES from WebCore.pro.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-13
Reviewed by Andreas Kling.

WebCore.pro:

12:37 PM Changeset in webkit [97386] by commit-queue@webkit.org

3 edits in trunk

Revert border radius clips (r95239) for Chromium due to performance issues. Update test expectations to skip border radius clip layout tests.
https://bugs.webkit.org/show_bug.cgi?id=69844

Patch by Tom Hudson <tomhudson@google.com> on 2011-10-13
Reviewed by Simon Fraser.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect): Only process border radius clips #if !PLATFORM(CHROMIUM)

12:36 PM Changeset in webkit [97385] by commit-queue@webkit.org

7 edits in trunk/Source/WebKit2

Implement TextChecker for WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=68548

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-10-13
Reviewed by Anders Carlsson.

Added implementation for all functions in TextCheckerGtk.cpp removing earlier stubbed implementations.
Moved couple of API earlier specific to win port to common section and added stubbed implementation
of the same for remaining ports of Qt, Efl and Mac.

GNUmakefile.am: Added TextChecker implementation files.
UIProcess/TextChecker.h: Moved spellCheckingEnabled and grammarCheckingEnabled API outside of win port.
UIProcess/efl/TextCheckerEfl.cpp: Stubbed implementation of API which was moved outside win port.
UIProcess/gtk/TextCheckerGtk.cpp: Implementation of all TextChecker API.

(WebKit::TextChecker::state):
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):

UIProcess/mac/TextCheckerMac.mm: Implementation of API which was moved outside win port.
UIProcess/qt/TextCheckerQt.cpp: Stubbed implementation of API which was moved outside win port.

12:30 PM Changeset in webkit [97384] by Simon Fraser

9 edits in trunk/LayoutTests

Rebase some editing/spelling results for Lion.

platform/mac/editing/spelling/autocorrection-at-beginning-of-word-1-expected.txt:
platform/mac/editing/spelling/autocorrection-at-beginning-of-word-2-expected.txt:
platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:

12:29 PM Changeset in webkit [97383] by hyatt@apple.com

1 edit in trunk/LayoutTests/platform/mac/fast/repaint/region-painting-via-layout-expected.txt

Fix layout test result on Lion to account for content-order removal patch.

12:24 PM Changeset in webkit [97382] by noel.gordon@gmail.com

1 edit
2 adds in trunk/LayoutTests

Add regression test: canvas.toDataURL("image/jpeg") should not crash
https://bugs.webkit.org/show_bug.cgi?id=69991

Reviewed by Kenneth Russell.

fast/canvas/canvas-toDataURL-jpeg-crash-expected.txt: Added.
fast/canvas/canvas-toDataURL-jpeg-crash.html: Added.

12:24 PM Changeset in webkit [97381] by mhahnenberg@apple.com

13 edits in trunk/Source

De-virtualized JSCell::toNumber
https://bugs.webkit.org/show_bug.cgi?id=69858

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Removed JSCallbackObject::toNumber because its no longer necessary since
JSObject::toNumber now suffices since we implicitly add valueOf to an object's
prototype whenever a convertToType callback is provided.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

De-virtualized JSCell::toNumber, JSObject::toNumber, and JSString::toNumber.

runtime/JSCell.cpp:

(JSC::JSCell::toNumber):

runtime/JSCell.h:
runtime/JSObject.h:
runtime/JSString.h:

Removed JSNotAnObject::toNumber because its result doesn't matter and it implements
defaultValue, therefore JSObject::toNumber can cover its case.

runtime/JSNotAnObject.cpp:
runtime/JSNotAnObject.h:

Source/JavaScriptGlue:

Removed UserObjectImp::toNumber because it's no longer necessary since
JSObject::toNumber can cover this case.

UserObjectImp.cpp:
UserObjectImp.h:

12:07 PM Changeset in webkit [97380] by jchaffraix@webkit.org

12 edits in trunk

Deprecate event.layerX and event.layerY in WebKit
https://bugs.webkit.org/show_bug.cgi?id=69951

Reviewed by Darin Adler.

Source/WebCore:

layerX and layerY were concepts of the old Netscape code that stayed
in WebKit for a long time without changes. Now the code is completely
wrong and Mozilla has expressed some interest in removing it from their
API too.

This is a first step in the removal as layerX and layerY are exposed
in some APIs. Chromium and Win are fine with removing the property
directly, but ObjC needs to deprecate them first.

bindings/objc/PublicDOMInterfaces.h: Mark the API as deprecated.

dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::layerX):
(WebCore::MouseRelatedEvent::layerY):

dom/UIEvent.cpp:

(WebCore::UIEvent::layerX):
(WebCore::UIEvent::layerY):
Added a call to warnDeprecatedLayerXYUsage in the previous functions.

(WebCore::UIEvent::warnDeprecatedLayerXYUsage): Print a warning in the
console about the removal of event.layerX and event.layerY in the near future.

dom/UIEvent.h: Added warnDeprecatedLayerXYUsage.

LayoutTests:

fast/dom/Window/window-xy-properties-expected.txt:
fast/events/init-events-expected.txt:
fast/events/mouse-relative-position-expected.txt:
fast/events/mouseclick-target-and-positioning-expected.txt:
fast/events/simulated-click-coords-expected.txt:
jquery/events-expected.txt:

Updated those tests with the console messages to keep our existing
coverage until we remove the 2 properties.

12:06 PM Changeset in webkit [97379] by jknotten@chromium.org

7 edits in trunk

[Chromium] Allow building without speech input enabled.
https://bugs.webkit.org/show_bug.cgi?id=69867

Reviewed by Darin Fisher.

Source/WebKit/chromium:

src/AssertMatchingEnums.cpp:
src/WebSpeechInputControllerMockImpl.cpp:

(WebKit::WebSpeechInputControllerMock::create):

src/WebSpeechInputControllerMockImpl.h:
src/WebSpeechInputResult.cpp:

Tools:

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::addMockSpeechInputResult):

12:04 PM Changeset in webkit [97378] by robert@webkit.org

4 edits
11 adds in trunk

CSS 2.1 failure: inline-replaced-height-008.htm
https://bugs.webkit.org/show_bug.cgi?id=69273

Reviewed by Simon Fraser.

Source/WebCore:

Test: css2.1/20110323/inline-block-replaced-height-008.html

Per http://www.w3.org/TR/CSS21/visudet.html#inline-replaced-height, if 'height' has computed value of
'auto', the replaced element has an intrinsic ratio and its used width is known or resolved, then
the used value of 'height' is determined by the equation (used width) / (intrinsic ratio).

rendering/RenderImage.cpp:

(WebCore::RenderImage::computeReplacedLogicalHeight):

rendering/RenderReplaced.h:

LayoutTests:

css2.1/20110323/floating-replaced-height-008.htm: Added.
css2.1/20110323/inline-block-replaced-height-008.htm: Added.
css2.1/20110323/inline-replaced-height-008.htm: Added.
css2.1/20110323/support/60x60-green.png: Added
platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.png: Added.
platform/chromium-linux/css2.1/20110323/floating-replaced-height-008-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.png: Added.
platform/chromium-linux/css2.1/20110323/inline-block-replaced-height-008-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.png: Added.
platform/chromium-linux/css2.1/20110323/inline-replaced-height-008-expected.txt: Added.

12:02 PM Changeset in webkit [97377] by adamk@chromium.org

2 edits in trunk/LayoutTests

Unreviewed, skip MutationObserver tests on wincairo.
These tests are not yet enabled on any platform.

platform/wincairo/Skipped:

11:51 AM Changeset in webkit [97376] by scherkus@chromium.org

2 edits in trunk/LayoutTests

Add stallFor URL parameter for http/tests/media/video-play-stall.html test.
https://bugs.webkit.org/show_bug.cgi?id=69974

Without the call to sleep(), the test server will issue a TCP
connection close earlier than the 3 second wait time required to issue
a stalled event.

Reviewed by Eric Carlson.

http/tests/media/video-play-stall.html:

11:44 AM Changeset in webkit [97375] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

[Qt][WK2] Implement decidePolicyForResponse in our PolicyClient
https://bugs.webkit.org/show_bug.cgi?id=69832

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-10-13
Reviewed by Kenneth Rohde Christiansen.

We implement decidePolicyForResponse in our PolicyClient in order to
decide whether a given ResourceResponse should be downloaded or loaded.

UIProcess/qt/ClientImpl.cpp:

(qt_wk_decidePolicyForResponse):

UIProcess/qt/ClientImpl.h:
UIProcess/qt/QtWebPageProxy.cpp:

(QtWebPageProxy::init):

11:31 AM Changeset in webkit [97374] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Mac test expectation update for the bug 69999.

platform/mac/test_expectations.txt:

11:28 AM Changeset in webkit [97373] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Update expectations while waiting on results from bots.

platform/chromium/test_expectations.txt: Updated.

11:02 AM Changeset in webkit [97372] by commit-queue@webkit.org

20 edits in trunk

Unreviewed, rolling out r97362.
http://trac.webkit.org/changeset/97362
https://bugs.webkit.org/show_bug.cgi?id=70039

Relies on V8 APIs that have been reverted upstream. (Requested
by dglazkov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-13

Source/WebCore:

English.lproj/localizedStrings.js:
bindings/js/ScriptProfiler.cpp:
bindings/js/ScriptProfiler.h:
bindings/v8/ScriptProfiler.cpp:
bindings/v8/ScriptProfiler.h:
inspector/Inspector.json:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):

inspector/InspectorProfilerAgent.h:
inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.hoverMessage):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showStringContentPopover):

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

inspector/front-end/HeapSnapshotProxy.js:
inspector/front-end/RemoteObject.js:
inspector/front-end/heapProfiler.css:

LayoutTests:

inspector/profiler/heap-snapshot-expected.txt:
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest):

inspector/profiler/heap-snapshot.html:

10:00 AM Changeset in webkit [97371] by commit-queue@webkit.org

5 edits in trunk/Source/JavaScriptCore

Use realloc() to expand/shrink StringBuilder buffer
https://bugs.webkit.org/show_bug.cgi?id=69913

Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-10-13
Reviewed by Darin Adler.

wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reserveCapacity):
(WTF::StringBuilder::reallocateBuffer):
(WTF::StringBuilder::appendUninitialized):
(WTF::StringBuilder::shrinkToFit):

wtf/text/StringBuilder.h:
wtf/text/StringImpl.cpp:

(WTF::StringImpl::reallocate): Added to allow StringBuilder to reallocate the buffer.

wtf/text/StringImpl.h:

9:55 AM Changeset in webkit [97370] by hyatt@apple.com

5 edits
3 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69932

Layout repainting messed up for objects in regions. There were two bugs here.
The first is that the regionOverflowRect needs to at least be the size of the
region's rect. When you're in the middle of layout, you haven't computed the
overflow rect for the flow thread yet (the flow thread's height could even be 0),
and so you just need to enforce a minimum size. Also removed the region-overflow:break
clipping behavior, since it was established that was wrong.

The second bug is that when you tell a region to repaint, you need to disable layout state,
since applying layout deltas from the flow thread makes no sense. The region is in a totally
different place in the render tree, so the current flow thread layout state can't be used
to determine your coordinate offset.

Reviewed by Dan Bernstein.

Added fast/repaint test.

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::repaintRectangleInRegions):

rendering/RenderRegion.cpp:

(WebCore::RenderRegion::regionOverflowRect):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69932

Layout repainting messed up for objects in regions. Add a repaint test to
illustrate the issue.

Reviewed by Dan Bernstein.

fast/repaint/region-painting-via-layout.html: Added.
platform/mac/fast/regions/region-overflow-break-expected.png:
platform/mac/fast/repaint/region-painting-via-layout-expected.png: Added.
platform/mac/fast/repaint/region-painting-via-layout-expected.txt: Added.

9:33 AM Changeset in webkit [97369] by reni@webkit.org

8 edits
56 adds in trunk

FEComponentTransfer element doesn't support dynamic invalidation
https://bugs.webkit.org/show_bug.cgi?id=69747

Source/WebCore:

The dynamic changes are captured by the svgAttributeChange() function, and
invalidate the filter primitive if necessary.
invalidateFilterPrimitiveParent() is a new free function in
SVGFilterPrimitiveStanardAttributes what makes the invalidation possible
by objects not inherited from SVGFilterPrimitiveStanardAttributes too.
This solution was used in SVGFEMergeNodeElement::svgAttributeChanged()
previously and now it can use this new function too.

Reviewed by Nikolas Zimmermann.

Tests: svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html

svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html
svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html
svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html
svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html
svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html
svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html

svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::svgAttributeChanged):

svg/SVGComponentTransferFunctionElement.h:
svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

svg/SVGFEMergeNodeElement.cpp:

(WebCore::SVGFEMergeNodeElement::svgAttributeChanged):

svg/SVGFilterPrimitiveStandardAttributes.cpp:

(WebCore::invalidateFilterPrimitiveParent):

svg/SVGFilterPrimitiveStandardAttributes.h:

LayoutTests:

Adding new tests for feComponentTransfer dynamic changes.

Reviewed by Nikolas Zimmermann.

platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
platform/mac/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-amplitude-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-exponent-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-intercept-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-offset-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-slope-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-tableValues-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-dom-type-attr.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-amplitude-prop.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-exponent-prop.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-intercept-prop.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-offset-prop.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-slope-prop.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop.html: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.txt: Added.
svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop.html: Added.
svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-amplitude-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-exponent-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-intercept-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-offset-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-slope-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-tableValues-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-dom-type-attr.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-amplitude-prop.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-exponent-prop.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-intercept-prop.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-offset-prop.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-slope-prop.js: Added.

(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-tableValues-prop.js: Added.

(SVGNumberListToString):
(executeTest):

svg/dynamic-updates/script-tests/SVGFEComponentTransferElement-svgdom-type-prop.js: Added.

(executeTest):

9:12 AM Changeset in webkit [97368] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit/chromium

[chromium] Add a selectionBounds() method to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=69028

Patch by Peng Huang <shawn.p.huang@gmail.com> on 2011-10-13
Reviewed by Darin Fisher.

public/WebWidget.h:

(WebKit::WebWidget::selectionBounds):

src/WebViewImpl.cpp:

(WebKit::WebViewImpl::selectionRange):
(WebKit::WebViewImpl::selectionBounds):

src/WebViewImpl.h:

8:57 AM Changeset in webkit [97367] by commit-queue@webkit.org

3 edits
2 adds in trunk

REGRESSION (r95381): Standalone video can be focused and draws a focus ring.
https://bugs.webkit.org/show_bug.cgi?id=69097

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-10-13
Reviewed by Eric Carlson.

Source/WebCore:

We don't want to focus a media element in a standalone document.

Test: fast/events/media-focus-in-standalone-media-document.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::supportsFocus): return false if media element is in a standalone media document.

LayoutTests:

New test to check that media element in a standalone document are not focussed.

fast/events/media-focus-in-standalone-media-document-expected.txt: Added.
fast/events/media-focus-in-standalone-media-document.html: Added.

8:28 AM Changeset in webkit [97366] by Carlos Garcia Campos

3 edits
2 adds in trunk/Source/WebKit2

[GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
https://bugs.webkit.org/show_bug.cgi?id=70010

Reviewed by Martin Robinson.

With this class tests using a soup server only need to implement
the soup server callback.

UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to compilation.
UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp: Use WebKitTestServer.

(testLoadingStatus):
(testLoadingError):
(testLoadAlternateContent):
(testWebViewReload):
(testLoadProgress):
(beforeAll):
(afterAll):

UIProcess/API/gtk/tests/WebKitTestServer.cpp: Added.

(WebKitTestServer::WebKitTestServer):
(WebKitTestServer::~WebKitTestServer):
(WebKitTestServer::run): Run the soup server and adds the given
soup server callback to handle requests.
(WebKitTestServer::getURIForPath): Returns the server absolute URI
for the given relative path.

UIProcess/API/gtk/tests/WebKitTestServer.h: Added.

(WebKitTestServer::baseURI):

7:31 AM Changeset in webkit [97365] by leandro@webkit.org

3 edits in trunk/Source/WebKit/efl

Unreviewed; revert some changes introduced in r97329 which are
unrelated to the patch and reverted other patches themselves.

ewk/ewk_frame.cpp:

(_ewk_frame_smart_del): Remove warning again.
(ewk_frame_contents_size_get): Check for Frame and FrameView again.

ewk/ewk_view.cpp:

(_ewk_view_priv_new): Revert back default font size change.

6:58 AM Changeset in webkit [97364] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WebKit2][gtk] Fix warnings while generating WebKit2-GTK+ documentation.
https://bugs.webkit.org/show_bug.cgi?id=69928

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-13
Reviewed by Philippe Normand.

Patch fixes the warnings reported by gtk-doc while generating
WebKit2-GTK+ documentation.

UIProcess/API/gtk/WebKitWebContext.h: Correct the documentation comment.
UIProcess/API/gtk/WebKitWebView.cpp: Parameter name correction.

5:56 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:46 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:13 AM Changeset in webkit [97363] by sergio@webkit.org

2 edits in trunk/LayoutTests

Unreviewed, rebaselined GTK SVG test result.

platform/gtk/svg/hixie/cascade/002-expected.txt:

4:08 AM Changeset in webkit [97362] by mnaganov@chromium.org

20 edits in trunk

Web Inspector: [Chromium] Add an ability to look up and explore an object from a heap profile.
https://bugs.webkit.org/show_bug.cgi?id=61179

This is exteremely helpful when dealing with DOM wrappers, as
their properties are mostly implemented with getters and thus not
stored in heap snapshots.

Reviewed by Pavel Feldman.

English.lproj/localizedStrings.js:
bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

bindings/js/ScriptProfiler.h:
bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::objectByHeapObjectId):

bindings/v8/ScriptProfiler.h:
inspector/Inspector.json:
inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::create):
(WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
(WebCore::InspectorProfilerAgent::getObjectByHeapObjectId):

inspector/InspectorProfilerAgent.h:
inspector/front-end/DetailedHeapshotGridNodes.js:

(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

inspector/front-end/DetailedHeapshotView.js:

(WebInspector.DetailedHeapshotView.prototype._showObjectPopover):

inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotNode.prototype.get canBeQueried):
(WebInspector.HeapSnapshotNode.prototype.get flags):
(WebInspector.HeapSnapshotNode.prototype.get isDOMWindow):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype._flagsOfNode):
(WebInspector.HeapSnapshot.prototype._calculateFlags):
(WebInspector.HeapSnapshot.prototype.updateStaticData):
(WebInspector.HeapSnapshotNodesProvider.prototype._serialize):

inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.get nodeFlags):

inspector/front-end/RemoteObject.js:

(WebInspector.RemoteObject.fromError):

inspector/front-end/heapProfiler.css:

(.detailed-heapshot-view tr:not(.selected) td.object-column span.highlight):

inspector/profiler/heap-snapshot-expected.txt:
inspector/profiler/heap-snapshot-test.js:

(initialize_HeapSnapshotTest.InspectorTest.createHeapSnapshotMockWithDOM):
(initialize_HeapSnapshotTest):

inspector/profiler/heap-snapshot.html:

4:01 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

3:59 AM Changeset in webkit [97361] by tkent@chromium.org

2 edits
1 move in trunk/LayoutTests

[Chromium] Fix test expectations.

platform/chromium-gpu-linux/media/video-playing-and-pause-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/media/video-playing-and-pause.png.
platform/chromium/test_expectations.txt:

3:17 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

3:16 AM Changeset in webkit [97360] by abarth@webkit.org

3 edits
2 adds in trunk

script-src * should allow all URLs
https://bugs.webkit.org/show_bug.cgi?id=70011

Reviewed by Eric Seidel.

Source/WebCore:

This patch gets us slightly ahead of the spec. Technically, script-src
means "any host" and inherits the current scheme. However, that's not
what developers expect and it's even contradicted by examples in the
spec itself. After this patch, * matches all URLs.

Test: http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html

page/ContentSecurityPolicy.cpp:

(WebCore::CSPSourceList::CSPSourceList):
(WebCore::CSPSourceList::matches):
(WebCore::CSPSourceList::parseSource):
(WebCore::CSPSourceList::addSourceStar):

LayoutTests:

Test that using * in script-src matches URLs with other schemes.

http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme-expected.txt: Added.
http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html: Added.

3:12 AM Changeset in webkit [97359] by tkent@chromium.org

4 edits
7 moves
29 adds
7 deletes in trunk/LayoutTests

[Chromium] Update test expectation.

fast/borders/border-radius-different-width-001-expected.txt: Renamed from LayoutTests/platform/gtk/fast/borders/border-radius-different-width-001-expected.txt.
fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Renamed from LayoutTests/platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt.
platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
platform/chromium-cg-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
platform/chromium-cg-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png: Added.
platform/chromium-cg-mac/fast/borders/border-radius-different-width-001-expected.png: Removed.
platform/chromium-cg-mac/fast/borders/mixed-border-styles-radius-expected.png: Removed.
platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
platform/chromium-mac-leopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-079-expected.png: Added.
platform/chromium-mac-snowleopard/css2.1/20110323/border-conflict-style-088-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/border-radius-complex-inner-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/border-radius-different-width-001-expected.png: Added.
platform/chromium-mac-snowleopard/fast/borders/mixed-border-styles-radius-expected.png: Added.
platform/chromium-mac/fast/borders/border-radius-different-width-001-expected.png: Removed.
platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png: Removed.
platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.png: Added.
platform/chromium-win/css2.1/20110323/border-conflict-style-079-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.txt.
platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.png: Added.
platform/chromium-win/css2.1/20110323/border-conflict-style-088-expected.txt: Renamed from LayoutTests/platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.txt.
platform/chromium-win/fast/borders/border-radius-complex-inner-expected.png: Added.
platform/chromium-win/fast/borders/border-radius-different-width-001-expected.png:
platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
platform/chromium-win/fast/css/outline-narrowLine-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/css/outline-narrowLine-expected.png.
platform/chromium-win/fast/css/outline-narrowLine-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/css/outline-narrowLine-expected.txt.
platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
platform/chromium-win/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt.
platform/chromium/fast/css/outline-narrowLine-expected.png: Added.
platform/chromium/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
platform/chromium/test_expectations.txt:
platform/mac/fast/borders/border-radius-different-width-001-expected.txt: Removed.
platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.
platform/qt/fast/borders/border-radius-different-width-001-expected.txt: Removed.

3:06 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

3:06 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

2:50 AM Changeset in webkit [97358] by tkent@chromium.org

1 edit
1 add in trunk/LayoutTests

[Chromium] Update test expectation.

platform/chromium-gpu-linux/media/video-playing-and-pause.png: Added.

2:30 AM Changeset in webkit [97357] by tkent@chromium.org

2 edits in trunk/LayoutTests

Update expectation of xss-DENIED-contentWindow-eval.html for r97353

http/tests/security/xss-DENIED-contentWindow-eval-expected.txt:

2:13 AM Changeset in webkit [97356] by haraken@chromium.org

11 edits
2 adds in trunk

Implement an OverflowEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69907

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the OverflowEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initOverflowEvent(), the constructor IDL should be as follows.

[Constructor(DOMString type, optional OverflowEventInit eventInitDict)]
interface OverflowEvent : Event {

...;

}

dictionary OverflowEventInit : EventInit {

unsigned short orient;
boolean horizontalOverflow;
boolean verticalOverflow;

}

Note: In initOverflowEvent(), we cannot specify |bubbles| and |cancelable|.
I do not know why, but we can find a comment in fast/events/script-tests/init-events.js
that says "initOverflowEvent has an interface that has a design that's
inconsistent with the init functions from other events".
On the other hand, the above constructor enables to specify |bubbles| and |cancelable|,
which is consistent with other constructors.

Test: fast/events/constructors/overflow-event-constructor.html

bindings/generic/EventConstructors.h: Added a definition for the OverflowEvent constructor.
bindings/js/JSEventConstructors.cpp: Added #includes for OverflowEvent.
dom/OverflowEvent.cpp:

(WebCore::OverflowEventInit::OverflowEventInit):
(WebCore::OverflowEvent::OverflowEvent):
(WebCore::OverflowEvent::initOverflowEvent):

dom/OverflowEvent.h: Added a definition for OverflowEventInit.

(WebCore::OverflowEvent::create):
(WebCore::OverflowEvent::orient):
(WebCore::OverflowEvent::horizontalOverflow):
(WebCore::OverflowEvent::verticalOverflow):

dom/OverflowEvent.idl: Makes OverflowEvent constructible.

LayoutTests:

overflow-event-constructor.html checks the behavior of the OverflowEvent constructor.

fast/dom/constructed-objects-prototypes-expected.txt: Added inner.OverflowEvent().
fast/dom/dom-constructors-expected.txt: Updated the test result.
fast/dom/dom-constructors.html: Removed OverflowEvent from test cases, since now OverflowEvent has a constructor.
fast/events/constructors/overflow-event-constructor-expected.txt: Added.
fast/events/constructors/overflow-event-constructor.html: Added.
platform/chromium/test_expectations.txt: Skipped overflow-event-constructor.html, since V8 does not yet have the OverflowEvent constructor.

2:13 AM Changeset in webkit [97355] by inferno@chromium.org

2 edits
2 copies in branches/chromium/874

Merge 97353 - DOMWindow subobjects can be re-created after navigation

BUG=96047
Review URL: http://codereview.chromium.org/8256010

2:08 AM Changeset in webkit [97354] by tkent@chromium.org

14 edits in trunk/Source

Cleanup of HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69908

Reviewed by Darin Adler.

Source/WebCore:

Change the m_listItems type: Vector<Element*> -> Vector<HTMLElement*>
Rename a member: m_recalcListItems -> m_shouldRecalcListItems
Fold checkListItems() into listItems()
Style fixes

No new tests, just a cleanup.

accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::addChildren):

accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::listBoxOptionIndex):

accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):

accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:

(optionFromSelection):
(webkit_accessible_selection_get_selection_count):

dom/OptionElement.cpp:

(WebCore::OptionElement::optionIndex):

html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::parseMappedAttribute):
(WebCore::HTMLSelectElement::recalcListItemsIfNeeded):
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::firstSelectableListIndex):
(WebCore::HTMLSelectElement::nextSelectableListIndexPageAway):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::listItems):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsInternal):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState): Use StringBuilder.
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
Optimize the code by iterating in the reverse order.
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
(WebCore::toSelectElement):

html/HTMLSelectElement.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
(WebCore::RenderListBox::nodeAtPoint):

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setTextFromOption):
(WebCore::RenderMenuList::itemText):
(WebCore::RenderMenuList::itemAccessibilityText):
(WebCore::RenderMenuList::itemToolTip):
(WebCore::RenderMenuList::itemIsEnabled):
(WebCore::RenderMenuList::itemStyle):
(WebCore::RenderMenuList::itemBackgroundColor):
(WebCore::RenderMenuList::itemIsSeparator):
(WebCore::RenderMenuList::itemIsLabel):
(WebCore::RenderMenuList::itemIsSelected):

Source/WebKit/chromium:

Change the HTMLSelectElement::listItems() return type:

Vector<Element*> -> Vector<HTMLElement*>

src/WebSearchableFormData.cpp:

(HTMLNames::IsSelectInDefaultState):

src/WebSelectElement.cpp:

(WebKit::WebSelectElement::listItems):

2:03 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

2:01 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

1:55 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

1:53 AM Changeset in webkit [97353] by abarth@webkit.org

4 edits
2 adds in trunk

DOMWindow subobjects can be re-created after navigation
https://bugs.webkit.org/show_bug.cgi?id=68849

Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html

page/DOMWindow.cpp:

(WebCore::DOMWindow::~DOMWindow):

Add ASSERTs to show that we're not recreating these objects.
Add a call to clear() as defense in depth in case we have any of these objects hanging around.

(WebCore::DOMWindow::clear):

Clear out a couple of objects that weren't getting cleared. These are actually not likely to cause problems, but clearing them out is the safe thing to do.

(WebCore::DOMWindow::isActive):

Add a concept of whether the DOMWindow is "active" in its frame. We had this concept in a couple places already, but centralizing it into a helper function make it easier to use and talk about.

(WebCore::DOMWindow::orientation):

Whitespace nit.

(WebCore::DOMWindow::screen):
(WebCore::DOMWindow::history):
(WebCore::DOMWindow::crypto):
(WebCore::DOMWindow::locationbar):
(WebCore::DOMWindow::menubar):
(WebCore::DOMWindow::personalbar):
(WebCore::DOMWindow::scrollbars):
(WebCore::DOMWindow::statusbar):
(WebCore::DOMWindow::toolbar):
(WebCore::DOMWindow::console):
(WebCore::DOMWindow::applicationCache):
(WebCore::DOMWindow::navigator):
(WebCore::DOMWindow::performance):
(WebCore::DOMWindow::location):
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::webkitIndexedDB):
(WebCore::DOMWindow::getSelection):
(WebCore::DOMWindow::styleMedia):
(WebCore::DOMWindow::webkitURL):
(WebCore::DOMWindow::webkitStorageInfo):

Avoid creating these objects when we're not active. That can only lead to sadness.

(WebCore::DOMWindow::webkitRequestFileSystem):
(WebCore::DOMWindow::webkitResolveLocalFileSystemURL):
(WebCore::DOMWindow::openDatabase):
(WebCore::DOMWindow::postMessage):

While not techincally creating subobjects, these functions also seem unwise when the DOMWindow is inactive.

(WebCore::DOMWindow::find):
(WebCore::DOMWindow::length):
(WebCore::DOMWindow::getMatchedCSSRules):

These functions operate on the active Document. When we're not active, that's not us!

(WebCore::DOMWindow::document):

Update to use the new concept of being active rather than having this function roll its own implementation.

(WebCore::DOMWindow::webkitConvertPointFromNodeToPage):
(WebCore::DOMWindow::webkitConvertPointFromPageToNode):
(WebCore::DOMWindow::scrollBy):
(WebCore::DOMWindow::scrollTo):

These functions also look unwise to run when inactive because they're reading information from the active document.
I added a RefPtr for node because the call to updateLayoutIgnorePendingStylesheets() seems likely to be able to run script somehow.

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::dispatchLoadEvent):
(WebCore::DOMWindow::dispatchEvent):

I don't think these functions worked when inactive anyway, but explicitly blocking them seems wise.

(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::isInsecureScriptAccess):
(WebCore::DOMWindow::open):
(WebCore::DOMWindow::showModalDialog):

These already have checks for being active, but it can't hurt to be explicit at the top of the function.

page/DOMWindow.h:

LayoutTests:

http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow-expected.txt: Added.
http/tests/security/xss-DENIED-getSelection-from-inactive-domwindow.html: Added.

12:50 AM Changeset in webkit [97352] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Fix errors in test_expectations.txt.

platform/chromium/test_expectations.txt:

Remove duplicated entries for MAC DEBUG.

12:34 AM Changeset in webkit [97351] by tkent@chromium.org

17 edits in trunk

REGRESSION(r89915): <input type=email multiple> don't show the default value
https://bugs.webkit.org/show_bug.cgi?id=69895

Reviewed by Hajime Morita.

Source/WebCore:

m_valueIfDirty became unexpectedly empty because
EmailInputType::sanitizeValue() returned an empty string for a
null input string.

To solve this issue, HTMLInputElement::sanitizeValue() checks
nullness, and remove the null check of sanitizeValue() of
InputType subclasses.
Also, we make InputType::sanitizeValue() const.

html/ColorInputType.cpp:

(WebCore::ColorInputType::sanitizeValue):

Make this const.
Remove null check.
html/ColorInputType.h: Make sanitizeValue() const.
html/EmailInputType.cpp:

(WebCore::EmailInputType::sanitizeValue): Make this const.

html/EmailInputType.h: Make sanitizeValue() const.
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::sanitizeValue):
(WebCore::HTMLInputElement::updateValueIfNeeded):

html/InputType.cpp:

(WebCore::InputType::sanitizeValue):
Returns a null string if the input string is null, and
don't call InputType::sanitizeValue() in this case.

html/InputType.h: Make sanitizeValue() const.
html/NumberInputType.cpp:

(WebCore::NumberInputType::sanitizeValue): Make this const.

html/NumberInputType.h: Make sanitizeValue() const.
html/RangeInputType.cpp:

(WebCore::RangeInputType::sanitizeValue):

Make this const.
Remove null check.
html/RangeInputType.h: Make sanitizeValue() const.
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::sanitizeValue): Make this const.

html/TextFieldInputType.h: Make sanitizeValue() const.

LayoutTests:

fast/forms/input-value-sanitization-expected.txt:
fast/forms/input-value-sanitization.html:

12:32 AM Changeset in webkit [97350] by tkent@chromium.org

2 edits in trunk/Tools

[Chromium] A DRT fix for r97348.

DumpRenderTree/chromium/LayoutTestController.cpp:

(LayoutTestController::overridePreference):
Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
print an error message.

12:07 AM Changeset in webkit [97349] by Csaba Osztrogonác

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

Web Inspector: REGRESSION(r97267): It made 3 tests fail on the Qt bot
https://bugs.webkit.org/show_bug.cgi?id=70005

platform/qt/Skipped: Skip failing tests.

Oct 12, 2011:

11:52 PM Changeset in webkit [97348] by Philippe Normand

8 edits in trunk/LayoutTests

Tests don't override the WebKitWebAudioEnabled runtime preference
https://bugs.webkit.org/show_bug.cgi?id=69830

Rubber-stamped by Eric Carlson.

Override WebKitWebAudioEnabled in the WebAudio tests so the audio
context can be created even for the WebKit ports not enabling the
runtime WebAudio preference by default.

webaudio/biquadfilternode-basic.html:
webaudio/delaynode-scheduling.html:
webaudio/delaynode.html:
webaudio/mediaelementaudiosourcenode-gc.html:
webaudio/mediaelementaudiosourcenode.html:
webaudio/realtimeanalyser-fft-sizing.html:
webaudio/resources/audio-testing.js:

11:14 PM Changeset in webkit [97347] by tkent@chromium.org

2 edits
1 move
21 adds
1 delete in trunk/LayoutTests

[Chromium] Test expectation udpate.

Add baseline files for ruby-base-merge-block-children.html, and
color-jpeg-with-color-profile.html only for Mac.

fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Renamed from LayoutTests/platform/gtk/fast/ruby/ruby-base-merge-block-children-crash-expected.txt.
platform/chromium-cg-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
platform/chromium-cg-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-cg-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
platform/chromium-cg-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-linux-x86/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-linux/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-linux/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
platform/chromium-mac-leopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
platform/chromium-mac-snowleopard/fast/images/color-jpeg-with-color-profile-expected.png: Added.
platform/chromium-win-vista/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-win-xp/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.txt: Added.
platform/chromium-win/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
platform/chromium/fast/ruby/ruby-base-merge-block-children-crash-expected.png: Added.
platform/chromium/test_expectations.txt:
platform/qt/fast/ruby/ruby-base-merge-block-children-crash-expected.txt: Removed.

10:40 PM Changeset in webkit [97346] by tkent@chromium.org

1 edit
14 adds in trunk/LayoutTests

[Chromium] Test expectation update.
Add baseline files for media/video-playing-and-pause.html.

platform/chromium-cg-mac-leopard/media/video-playing-and-pause-expected.png: Added.
platform/chromium-cg-mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
platform/chromium-gpu-cg-mac/media/video-playing-and-pause-expected.png: Added.
platform/chromium-gpu-mac/media/video-playing-and-pause-expected.png: Added.
platform/chromium-gpu-win/media/video-playing-and-pause-expected.png: Added.
platform/chromium-linux/media/video-playing-and-pause-expected.png: Added.
platform/chromium-mac-leopard/media/video-playing-and-pause-expected.png: Added.
platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png: Added.
platform/chromium-win/media/video-playing-and-pause-expected.png: Added.
platform/chromium-win/media/video-playing-and-pause-expected.txt: Added.
platform/chromium/media/video-playing-and-pause-expected.txt: Added.

10:33 PM Changeset in webkit [97345] by Simon Fraser

2 edits in trunk/LayoutTests

Skip some more tests for WK2.

platform/wk2/Skipped:

10:17 PM Changeset in webkit [97344] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Mac test expectation update. The failure is tracked by the bug 69999.

platform/mac/test_expectations.txt:

10:14 PM Changeset in webkit [97343] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

platform/chromium/test_expectations.txt:

plugins/refcount-leaks.html is flaky.

10:01 PM Changeset in webkit [97342] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

If an Arguments object is being used to copy the arguments, then
make this explicit
https://bugs.webkit.org/show_bug.cgi?id=69995

Reviewed by Sam Weinig.

interpreter/Interpreter.cpp:

(JSC::Interpreter::retrieveArguments):

runtime/Arguments.h:

(JSC::Arguments::createAndCopyRegisters):
(JSC::Arguments::finishCreationButDontCopyRegisters):
(JSC::Arguments::finishCreation):
(JSC::Arguments::finishCreationAndCopyRegisters):

9:09 PM Changeset in webkit [97341] by rniwa@webkit.org

3 edits in trunk/Tools

Update kill-old-processes logic.
https://bugs.webkit.org/show_bug.cgi?id=63651

Patch by Lucas Forschler <Lucas Forschler> on 2011-10-12
Reviewed by Ryosuke Niwa.

Remove unused mac platform specific folder.
Update master.config to use new kill-old-processes.

BuildSlaveSupport/build.webkit.org-config/master.cfg:
BuildSlaveSupport/kill-old-processes:
BuildSlaveSupport/mac: Removed.

8:59 PM Changeset in webkit [97340] by Simon Fraser

8 edits in trunk/LayoutTests

Rebaseline Mac region results after r97308.

platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt:
platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt:
platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt:

8:18 PM Changeset in webkit [97339] by rniwa@webkit.org

3 edits in trunk/Tools

[NRWT] New tests without expected files are reported as flakey tests
https://bugs.webkit.org/show_bug.cgi?id=67268

Reviewed by Dirk Pranke.

The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
for missing results in retry_summary.

Fixed the bug by treating missing results separately.

Scripts/webkitpy/layout_tests/controllers/manager.py:
Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

7:51 PM Changeset in webkit [97338] by Joseph Pecoraro

7 edits in trunk/Source

<http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 3 - Add acceptMIMETypes, a parsed list of MIME types, to FileChooserSettings for WebKit ports

Reviewed by David Kilzer.

Source/WebCore:

No new tests. No new functionality in WebCore, just
exposing more information to the WebKit port.

html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):
Set the MIME type list on the FileChooser settings.

html/HTMLInputElement.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::acceptMIMETypes):
Accessor for a parsed list of MIME types from the accept attribute.

platform/FileChooser.h:

Add a slot for a MIME type list on the chooser settings.

Source/WebKit2:

Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):

7:51 PM Changeset in webkit [97337] by Joseph Pecoraro

12 edits in trunk/Source/WebKit2

<http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 2 - Switch a WebKit2 mirror struct of WebCore::FileChooserSettings to just use FileChooserSettings

Reviewed by Anders Carlsson.

The WebOpenPanelParameters::Data struct was a mirror of
the already existing WebCore::FileChooserSettings struct.
So eliminate the excess struct and generate default
WebCore coders for the WebCore::FileChooserSettings struct.

Scripts/webkit2/messages.py:

Switch to the new type. FileChooserSetting's header needs
to be special cased to FileChooser.h.

Shared/WebCoreArgumentCoders.h:
Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::::decode):
Encode and decode all, non-deprecated, values. So we
ignore deprecatedAcceptTypes. A follow-up patch will add it.

Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::create):
(WebKit::WebOpenPanelParameters::WebOpenPanelParameters):
Switch to the new type.

Shared/WebOpenPanelParameters.h:

(WebKit::WebOpenPanelParameters::allowMultipleFiles):
(WebKit::WebOpenPanelParameters::selectedFileNames):
FileChooserSettings had different property names.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runOpenPanel):
Generate the WebOpenPanelParameters object here, before
passing into the WebUIClient. This seems to be the convention
to not have WebCore types in WebUIClient.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::runOpenPanel):

UIProcess/WebUIClient.h:
WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runOpenPanel):
Switch to the new type.

7:50 PM Changeset in webkit [97336] by Joseph Pecoraro

9 edits in trunk/Source

<http://webkit.org/b/69598> Pass Parsed Accept Attribute MIME Types to WebKit Clients

Part 1 - Deprecate String version of acceptTypes

Reviewed by Kent Tamura.

Source/WebCore:

Deprecate the old String version of getting the "accept"
mime type values. Instead we will change to include a
list of MIME types.

html/FileInputType.cpp:

(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::receiveDropForDirectoryUpload):

platform/FileChooser.h:

Source/WebKit/chromium:

Chromium uses the deprecated accept string. Switching to
the new approach will require coordination with their port.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

Source/WebKit/efl:

EFL uses the deprecated accept string. They can switch
to an Eina_List if they want to update their API.

src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::runOpenPanel):

Source/WebKit2:

Switch to deprecated for now, but the next patches will
remove the deprecated version from the WebKit2 path.

WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runOpenPanel):

7:43 PM Changeset in webkit [97335] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update

platform/chromium/test_expectations.txt:

More slow tests for Mac Debug.

7:20 PM Changeset in webkit [97334] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

DFG CFA does not filter structures aggressively enough.
https://bugs.webkit.org/show_bug.cgi?id=69989

Reviewed by Oliver Hunt.

dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::checkConsistency):

7:04 PM Changeset in webkit [97333] by abarth@webkit.org

45 edits
11 deletes in trunk

Remove ENABLE(XHTMLMP) and associated code
https://bugs.webkit.org/show_bug.cgi?id=69729

Reviewed by David Levin.

Source/cmake/OptionsEfl.cmake:
Source/cmake/OptionsWinCE.cmake:
Source/cmakeconfig.h.cmake:
configure.ac:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

As discussed on webkit-dev, we are removing this feature as part of our
cleanup of unmaintained code in WebKit.

Configurations/FeatureDefines.xcconfig:
GNUmakefile.am:
GNUmakefile.list.am:
WebCore.gypi:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

dom/Document.cpp:

(WebCore::Document::Document):

dom/Document.h:

(WebCore::Document::isMediaDocument):

dom/Node.cpp:
dom/make_names.pl:

(usesDefaultJSWrapper):

features.pri:
html/HTMLElement.cpp:

(WebCore::HTMLElement::rendererIsNeeded):

html/HTMLElementsAllInOne.cpp:
html/HTMLNoScriptElement.cpp: Removed.
html/HTMLNoScriptElement.h: Removed.
html/HTMLTagNames.in:
html/HTMLViewSourceDocument.cpp:

(WebCore::HTMLViewSourceDocument::createParser):

loader/FrameLoader.cpp:
platform/wince/MIMETypeRegistryWinCE.cpp:

(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

xml/parser/XMLDocumentParser.h:

(WebCore::XMLDocumentParser::isXHTMLDocument):

xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::endDocument):
(WebCore::XMLDocumentParser::internalSubset):
(WebCore::getEntityHandler):
(WebCore::externalSubsetHandler):

xml/parser/XMLDocumentParserQt.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser):
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::parseStartElement):
(WebCore::XMLDocumentParser::parseEndElement):
(WebCore::XMLDocumentParser::endDocument):
(WebCore::XMLDocumentParser::parseDtd):

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Tools:

Scripts/build-webkit:
Scripts/old-run-webkit-tests:
Scripts/webkitperl/features.pm:
Scripts/webkitpy/layout_tests/port/webkit.py:
Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

WebKitLibraries:

win/tools/vsprops/FeatureDefines.vsprops:
win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

These tests are not needed anymore (and they are currently not run).

fast/xhtmlmp: Removed.
fast/xhtmlmp/check-doctype-declaration.xhtml: Removed.
fast/xhtmlmp/check-rootelement.xhtml: Removed.
fast/xhtmlmp/noscript-basic-expected.txt: Removed.
fast/xhtmlmp/noscript-basic.xhtml: Removed.
fast/xhtmlmp/noscript-in-multiscripts.xhtml: Removed.
fast/xhtmlmp/noscript-nested.xhtml: Removed.
fast/xhtmlmp/noscript.xhtml: Removed.

6:50 PM Changeset in webkit [97332] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Fix CCThreadTest.startPostAndWaitOnCondition
https://bugs.webkit.org/show_bug.cgi?id=69967

Patch by Antoine Labour <piman@chromium.org> on 2011-10-12
Reviewed by Darin Fisher.

tests/CCThreadTest.cpp:

(WebKit::TEST):

6:44 PM Changeset in webkit [97331] by barraclough@apple.com

7 edits in trunk/Source/JavaScriptCore

MacroAssemblerX86 8-bit register ops unsafe on CPU(X86)
https://bugs.webkit.org/show_bug.cgi?id=69978

Reviewed by Filip Pizlo.

Certain ops are unsafe if the register passed is esp..edi (will instead test/set the ).

compare32/test8/test32 Call setCC, which sets an 8-bit register - we can fix this by adding
a couple of xchg instructions.

branchTest8 with a register argument is also affected. In all cases this is currently used
this is testing a value that is correct to 32 or more bits, so we can simply switch these
to branchTest32 & remove the corresponding branchTest8 (this is desirable anyway, since the
32-bit form is cheaper to implement on platforms that don't have an 8-bit compare instruction).

This fixes the remaining fast/js failures with the DFG JIT 32_64.

assembler/MacroAssemblerARMv7.h
- removed branchTest8.
assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::set32):

added set32 helper that is 'h' register safe.
removed branchTest8.

dfg/DFGJITCodeGenerator32_64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

switch uses of branchTest8 to branchTest32.

dfg/DFGJITCodeGenerator64.cpp:

(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeBranch):
(JSC::DFG::JITCodeGenerator::nonSpeculativePeepholeStrictEq):

switch uses of branchTest8 to branchTest32.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

switch uses of branchTest8 to branchTest32.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitBranch):

switch uses of branchTest8 to branchTest32.

6:33 PM Changeset in webkit [97330] by rniwa@webkit.org

2 edits in trunk/Tools

Kill old run-webkit-tests processes in kill-process on Mac
https://bugs.webkit.org/show_bug.cgi?id=69976

Reviewed by Dirk Pranke.

Add a system call to remove all python processes running run-webkit-tests.

BuildSlaveSupport/kill-old-processes:
BuildSlaveSupport/mac: Removed.

6:23 PM Changeset in webkit [97329] by gyuyoung.kim@samsung.com

19 edits in trunk/Source/WebKit/efl

[EFL] Change efl style parameter variables with WebKit coding Style
https://bugs.webkit.org/show_bug.cgi?id=69073

Reviewed by Antonio Gomes.

This is a third step in order to be more compliant with WebKit coding style.
We have used one-letter| two-letter parameter according to efl style. However, it's more difficult
for other reviewers to review EFL patches. So, this patch changes efl style parameters
with meaningful one.

Majors changes are listed below,

Use ewkFrame instead of o parameter in ewk_frame.cpp.
Use ewkView instead of o parameter in ewk_view.cpp.
Use menu and item instead of o parameter in ewk_contextmenu.cpp.
Use ewkTile instead of o parameter in ewk_tile_xxx.cpp.
Use tile parameter name instead of t parameter in ewk_tile_xxx.cpp.
Use smartData instead of sd parameter for Ewk_XXXX_Smart_Data struct.
Use width, height instead of w, h parameter.
Use xxxEvent instead of ev parameter for event. (e.g. downEvent, upEvent, wheelEvent)
Use scrollX, scrollY, scrollWidth, scrollHeight, centerX, centerY, deltaX, deltaY instead of sx, xy, sw,

sh, cx, cy, dx, dy.

Use tileUnusedCache instead of tuc parameter in tiled backing store.
Use red, green, blue and alpha instead of r,g,b,a.
Remove "_" from parameter variable.
Run demarchi's coding style script for ewk_tile_xxx.cpp files.
Remove *void* parameter in ewk_tile_xxx.cpp's internal functions.

ewk/ewk_auth_soup.cpp:
ewk/ewk_contextmenu.cpp:
ewk/ewk_cookies.cpp:
ewk/ewk_frame.cpp:
ewk/ewk_history.cpp:
ewk/ewk_js.cpp:
ewk/ewk_protocol_handler_soup.cpp:
ewk/ewk_settings.cpp:
ewk/ewk_tiled_backing_store.cpp:
ewk/ewk_tiled_backing_store.h:
ewk/ewk_tiled_matrix.cpp:
ewk/ewk_tiled_matrix.h:
ewk/ewk_tiled_model.cpp:
ewk/ewk_tiled_model.h:
ewk/ewk_view.cpp:
ewk/ewk_view_single.cpp:
ewk/ewk_view_tiled.cpp:
ewk/ewk_window_features.cpp:

6:07 PM Changeset in webkit [97328] by tkent@chromium.org

2 edits in trunk/LayoutTests

[Chromium] Test expectation update.

platform/chromium/test_expectations.txt:

Try marking SLOW for Mac Debug timeouts.

5:57 PM Changeset in webkit [97327] by Simon Fraser

3 edits in trunk/Tools

Many WK2 snapshots are blank
https://bugs.webkit.org/show_bug.cgi?id=69953

Reviewed by Beth Dakin.

Two fixes:

negating a size_t in CGContextTranslateCTM() fails, because

size_t is unsigned. Fix by casing to CGFloat before negation.

Turn on window autodisplay, so that compositing tests snapshot correctly.

Autodisplay is necessary to kick off Core Animation rendering.

WebKitTestRunner/cg/TestInvocationCG.cpp:

(WTR::createCGContextFromImage):

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):

5:50 PM Changeset in webkit [97326] by haraken@chromium.org

5 edits in trunk

Implement a WebKitTransitionEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=69911

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/webkit-transition-event-constructor.html

bindings/v8/custom/V8EventConstructors.cpp: Added a WebKitTransitionEvent constructor.
dom/WebKitTransitionEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled webkit-transition-event-constructor.html, since now V8 has the WebKitTransitionEvent constructor.

platform/chromium/test_expectations.txt:

5:37 PM Changeset in webkit [97325] by ojan@chromium.org

2 edits
1 add
2 deletes in trunk/LayoutTests

make fast/writing-mode/margins.html a reftest to avoid cross-platform differences
https://bugs.webkit.org/show_bug.cgi?id=69977

Reviewed by Tony Chang.

fast/writing-mode/margins-expected.html: Added.
fast/writing-mode/margins-expected.png: Removed.
fast/writing-mode/margins-expected.txt: Removed.
fast/writing-mode/margins.html:

5:35 PM Changeset in webkit [97324] by haraken@chromium.org

8 edits
2 adds in trunk

Implement a BeforeLoadEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=69893

Reviewed by Adam Barth.

Source/WebCore:

There is no spec for the BeforeLoadEvent constructor
since it is WebKit-specific. However, judging from the current
IDL of initBeforeLoadEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional BeforeLoadEventInit eventInitDict)]
interface BeforeLoadEvent : Event {

...;

}

dictionary BeforeLoadEventInit : EventInit {

DOMString url;

}

Test: fast/events/constructors/before-load-event-constructor.html

bindings/generic/EventConstructors.h: Added a definition for the BeforeLoadEvent constructor.
bindings/js/JSEventConstructors.cpp: Added #includes for BeforeLoadEvent.
dom/BeforeLoadEvent.h: Added a definition for BeforeLoadEventInit.

(WebCore::BeforeLoadEventInit::BeforeLoadEventInit):
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::initBeforeLoadEvent):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):

dom/BeforeLoadEvent.idl: Makes BeforeLoadEvent constructible.

LayoutTests:

before-load-event-constructor.html checks the behavior of the BeforeLoadEvent constructor.

fast/dom/constructed-objects-prototypes-expected.txt: Added inner.BeforeLoadEvent().
fast/events/constructors/before-load-event-constructor-expected.txt: Added.
fast/events/constructors/before-load-event-constructor.html: Added.
platform/chromium/test_expectations.txt: Skipped before-load-event-constructor.html, since V8 does not yet have the BeforeLoadEvent constructor.

5:34 PM Changeset in webkit [97323] by tkent@chromium.org

2 edits in trunk/WebKitLibraries

C4481 warning should be disabled for OVERRIDE and FINAL.
https://bugs.webkit.org/show_bug.cgi?id=69904

Reviewed by Adam Roben.

win/tools/vsprops/common.vsprops: Disable C4481.

5:21 PM Changeset in webkit [97322] by abarth@webkit.org

7 edits in trunk/Tools

commit-queue doesn't have a friendly error message when the reviewer line is messed up
https://bugs.webkit.org/show_bug.cgi?id=69979

Reviewed by Eric Seidel.

Rather than combining the ChangeLog validation with a more complicated
command, this patch has the commit-queue run it as a separate command,
which will give us more control over the error message.

Scripts/webkitpy/tool/bot/commitqueuetask.py:
Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
Scripts/webkitpy/tool/commands/download.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:
Scripts/webkitpy/tool/steps/validatechangelogs.py:
Scripts/webkitpy/tool/steps/validatereviewer.py:

5:14 PM Changeset in webkit [97321] by eric@webkit.org

2 edits in trunk/Tools

Layout tests asserting in LayoutTestController::pathToLocalResource()
https://bugs.webkit.org/show_bug.cgi?id=69898

Reviewed by Simon Fraser.

old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.

Scripts/old-run-webkit-tests:

(openDumpTool):

5:13 PM Changeset in webkit [97320] by abarth@webkit.org

3 edits in trunk/Tools

The commit-queue doesn't tell me which tests my patch broke
https://bugs.webkit.org/show_bug.cgi?id=69975

Reviewed by Eric Seidel.

We now print the list of newly failing tests, like we do for the EWS.

Scripts/webkitpy/tool/commands/queues.py:
Scripts/webkitpy/tool/commands/queues_unittest.py:

4:59 PM Changeset in webkit [97319] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[skia] Implement Path.currentPoint for skia
https://bugs.webkit.org/show_bug.cgi?id=69817

Replace FIXME with implementation.

Patch by Ben Wells <benwells@chromium.org> on 2011-10-12
Reviewed by Kenneth Russell.

platform/graphics/skia/PathSkia.cpp:

(WebCore::Path::currentPoint):

4:44 PM Changeset in webkit [97318] by commit-queue@webkit.org

7 edits
3 adds in trunk

Incorrect rendering with one-sided thick border and border-radius
https://bugs.webkit.org/show_bug.cgi?id=38787

Patch by Ben Wells <benwells@chromium.org> on 2011-10-12
Reviewed by Simon Fraser.

Source/WebCore:

Incorrect rendering resulted when the inner border could not be properly represented as a rounded
rectangle. When this happens, and the inner border is clipped out, the clipping code clips out the
enclosing rectangle instead.

This change addresses this by clipping in a different way in this case only. The inside is clipped
out one side at a time with a rounded rect created by adjusting the unrenderable inner border
rounded rectangle. The side polygon which is clipped to is also increased in this case to include
the inside of the border so that no areas are missing.

Test: fast/borders/border-radius-complex-inner.html

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::calculateSideRectIncludingInner):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::clipBorderSideForComplexInnerPath):

rendering/RenderBoxModelObject.h:

LayoutTests:

fast/borders/border-radius-complex-inner.html: Added.
platform/chromium-linux/fast/borders/border-radius-complex-inner-expected.png: Added.
platform/chromium-linux/fast/borders/border-radius-different-width-001-expected.png:
platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
platform/chromium/test_expectations.txt:
platform/mac/fast/borders/border-radius-complex-inner-expected.txt: Added.

4:14 PM Changeset in webkit [97317] by aboxhall@chromium.org

2 edits in trunk/Tools

Added myself as a committer.

Scripts/webkitpy/common/config/committers.py:

4:02 PM Changeset in webkit [97316] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-12

DEPS:

3:57 PM Changeset in webkit [97315] by dmazzoni@google.com

2 edits in trunk/LayoutTests

Skip accessibility/menu-list-sends-change-notification.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=69970

Reviewed by Simon Fraser.

platform/mac/Skipped:

3:51 PM Changeset in webkit [97314] by macpherson@chromium.org

6 edits in trunk/Source/WebCore

Clean up CSSPropertyTextDecoration implementation and ETextDecoration usage.
https://bugs.webkit.org/show_bug.cgi?id=67625

Reviewed by Eric Seidel.

No new tests - no functionality changed.

The implementation of CSSPropertyTextDecoration is simlified because
1) CSSValueListIterator produces a valid iterator when no results available.
2) CSSParser only allows CSSValueNone or a list of appropriate idents.
3) CSSParser will treat a zero-length list as invalid at parse time.

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator ETextDecoration):
Implement cast from CSSPrimitiveValue to ETextDecoration.

css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

rendering/style/RenderStyle.h:

Use ETextDecoration enum instead of int throughout.
(WebCore::InheritedFlags::textDecorationsInEffect):
(WebCore::InheritedFlags::textDecoration):
(WebCore::InheritedFlags::addToTextDecorationsInEffect):
(WebCore::InheritedFlags::setTextDecorationsInEffect):
(WebCore::InheritedFlags::setTextDecoration):

rendering/style/RenderStyleConstants.h:

Introduce constant for number of bits required to represent enum.
(WebCore::operator|):
Implement | operator for bitfield enum.
(WebCore::operator|=):
Implement |= operator for bitfield enum.

rendering/style/StyleVisualData.h:

Use ETextDecoration instead of int.

3:49 PM Changeset in webkit [97313] by tony@chromium.org

4 edits
6 adds in trunk

Implement -webkit-flex-align for cross axis alignment in flex-flow: row
https://bugs.webkit.org/show_bug.cgi?id=69808

Reviewed by David Hyatt.

Source/WebCore:

Tests: css3/flexbox/flex-align-percent-height.html

css3/flexbox/flex-align-vertical-writing-mode.html
css3/flexbox/flex-align.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::isFlowAwareLogicalHeightAuto):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareBorderAndPaddingLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareMarginLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::availableLogicalHeightForChild):
(WebCore::RenderFlexibleBox::marginBoxAscent):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
(WebCore::RenderFlexibleBox::adjustLocationLogicalTopForChild):
(WebCore::RenderFlexibleBox::alignChildrenBlockDirection):

rendering/RenderFlexibleBox.h:

LayoutTests:

css3/flexbox/flex-align-expected.txt: Added.
css3/flexbox/flex-align-percent-height-expected.txt: Added.
css3/flexbox/flex-align-percent-height.html: Added.
css3/flexbox/flex-align-vertical-writing-mode-expected.txt: Added.
css3/flexbox/flex-align-vertical-writing-mode.html: Added.
css3/flexbox/flex-align.html: Added.

3:47 PM Changeset in webkit [97312] by ojan@chromium.org

1 edit
1 add in trunk/LayoutTests

Expected result accidentally left out of http://trac.webkit.org/changeset/97222/.

fast/writing-mode/margins-expected.png: Added.

3:44 PM Changeset in webkit [97311] by abarth@webkit.org

2 edits in trunk/Tools

_run_tests is a confusing variable name in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=69971

Reviewed by Eric Seidel.

Eric and I thought this was a function.

Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

3:30 PM Changeset in webkit [97310] by dmazzoni@google.com

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Changed the order of my email addresses so that it autocompletes the correct one.

3:20 PM Changeset in webkit [97309] by tony@chromium.org

3 edits in trunk/Tools

Fix test-webkitpy after r97307 and r97293.

Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms is None during tests so add back the check.
Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The output directory is now build/Debug.

3:14 PM Changeset in webkit [97308] by mihnea@adobe.com

74 edits
12 deletes in trunk

[CSS Regions]Remove -webkit-content-order property
https://bugs.webkit.org/show_bug.cgi?id=69848

Reviewed by Tony Chang.

-webkit-content-order property is removed from latest CSS Regions spec.

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

css/CSSPropertyNames.in:
css/CSSStyleSelector.cpp:

(WebCore::CSSStyleSelector::applyProperty):

dom/Node.cpp:

(WebCore::Node::diff):

rendering/RenderFlowThread.cpp:

(WebCore::compareRenderRegions):

rendering/RenderTreeAsText.cpp:

(WebCore::writeRenderFlowThreads):

rendering/style/RenderStyle.h:
rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/regions/content-flowed-into-regions-with-dyn-index-expected.txt: Removed.
fast/regions/content-flowed-into-regions-with-dyn-index.html: Removed.
fast/regions/content-flowed-into-regions-with-index-dom-expected.txt: Removed.
fast/regions/content-flowed-into-regions-with-index-dom.html: Removed.
fast/regions/content-flowed-into-regions-with-index-expected.txt: Removed.
fast/regions/content-flowed-into-regions-with-index.html: Removed.
fast/regions/script-tests/webkit-content-order-parsing.js: Removed.
fast/regions/webkit-content-order-parsing-expected.txt: Removed.
fast/regions/webkit-content-order-parsing.html: Removed.
platform/chromium-cg-mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/gtk/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
platform/gtk/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt:
platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Removed.
platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Removed.
platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Removed.
platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/flow-content-basic-expected.txt:
platform/mac/fast/regions/flow-content-basic-vertical-expected.txt:
platform/mac/fast/regions/flow-content-basic-vertical-rl-expected.txt:
platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt:
platform/mac/fast/regions/flows-dependency-same-flow-expected.txt:
platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/outline-sides-in-region-expected.txt:
platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt:
platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt:
platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt:
platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
platform/mac/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt:
platform/mac/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt:
platform/mac/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt:
platform/mac/fast/regions/percentage-margins-variable-width-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-in-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-in-rtl-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-perpendicular-flows-in-regions-expected.txt:
platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt:
platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt:
platform/mac/fast/regions/region-overflow-break-expected.txt:
platform/mac/fast/regions/render-region-renderer-expected.txt:
platform/mac/fast/regions/text-region-split-small-pagination-expected.txt:
platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt:
platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt:
platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt:
platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt:
platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt:
platform/mac/fast/regions/webkit-flow-renderer-expected.txt:
platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt:
platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt:
platform/mac/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
platform/mac/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
platform/qt/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
platform/qt/fast/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt:
platform/win/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt:
svg/css/getComputedStyle-basic-expected.txt:

3:07 PM Changeset in webkit [97307] by tony@chromium.org

2 edits in trunk/Tools

[chromium] remove old build dirs on chromium-win
https://bugs.webkit.org/show_bug.cgi?id=69961

Reviewed by Adam Barth.

Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now always in build and never in chrome or webkit.

2:50 PM Changeset in webkit [97306] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] More timeouts after V8 roll.

platform/chromium/test_expectations.txt: Updated.

2:37 PM Changeset in webkit [97305] by commit-queue@webkit.org

14 edits
1 delete in trunk/Source/WebCore

Update PeerConnection to use WebCore platform interfaces
https://bugs.webkit.org/show_bug.cgi?id=68462

Patch by Adam Bergkvist <adam.bergkvist@ericsson.com> on 2011-10-12
Reviewed by Adam Barth.

Currently not testable.

WebCore.gypi:
WebCore.pro:
bindings/js/JSPeerConnectionCustom.cpp:

(WebCore::JSPeerConnectionConstructor::constructJSPeerConnection):

bindings/v8/custom/V8PeerConnectionCustom.cpp: Removed.
dom/MediaStreamList.cpp:

(WebCore::MediaStreamList::item):
(WebCore::MediaStreamList::append):
(WebCore::MediaStreamList::remove):
(WebCore::MediaStreamList::contains):

dom/MediaStreamList.h:
p2p/PeerConnection.cpp:

(WebCore::PeerConnection::create):
(WebCore::PeerConnection::PeerConnection):
(WebCore::PeerConnection::processSignalingMessage):
(WebCore::PeerConnection::readyState):
(WebCore::PeerConnection::send):
(WebCore::PeerConnection::addStream):
(WebCore::PeerConnection::removeStream):
(WebCore::PeerConnection::localStreams):
(WebCore::PeerConnection::remoteStreams):
(WebCore::PeerConnection::close):
(WebCore::PeerConnection::iceProcessingCompleted):
(WebCore::PeerConnection::sdpGenerated):
(WebCore::PeerConnection::dataStreamMessageReceived):
(WebCore::PeerConnection::remoteStreamAdded):
(WebCore::PeerConnection::remoteStreamRemoved):
(WebCore::PeerConnection::scriptExecutionContext):
(WebCore::PeerConnection::stop):
(WebCore::PeerConnection::scheduleInitialNegotiation):
(WebCore::PeerConnection::initialNegotiationTimerFired):
(WebCore::PeerConnection::ensureStreamChangeScheduled):
(WebCore::PeerConnection::streamChangeTimerFired):
(WebCore::PeerConnection::scheduleReadyStateChange):
(WebCore::PeerConnection::readyStateChangeTimerFired):
(WebCore::PeerConnection::changeReadyState):

p2p/PeerConnection.h:

(WebCore::PeerConnection::refEventTarget):
(WebCore::PeerConnection::derefEventTarget):

p2p/PeerConnection.idl:
page/MediaStreamClient.h:
page/MediaStreamController.cpp:

(WebCore::MediaStreamController::MediaStreamController):

page/MediaStreamController.h:
page/MediaStreamFrameController.cpp:
page/MediaStreamFrameController.h:

2:34 PM Changeset in webkit [97304] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Hang beneath PluginProcessProxy::createPropertyListFile() when using a thin build
https://bugs.webkit.org/show_bug.cgi?id=69960

Reviewed by Adam Roben.

UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::createPropertyListFile): Check for any non-zero return value
from posix_spawn() rather than for a negative return value. The old, incorrect check, caused
this function to hang in waitpid() after failing to spawn a plug-in process for a 32-bit plug-in
when WebKit2 was built for 64-bit only.

2:25 PM Changeset in webkit [97303] by Chris Fleizach

4 edits in trunk/Source/WebCore

AX: CrashTracer: [USER] 296 crashes in WebProcess at com.apple.WebCore: WebCore::AccessibilityScrollbar::document const + 29
https://bugs.webkit.org/show_bug.cgi?id=69936

AX Scrollbars have a weak pointer to their parent. They need to become AccessibilityMockObjects, so that they can
participate in the detachFromParent() methods that happens when those parents go away.
Could not reproduce the crash, but the backtrace is unequivocal.

Reviewed by Darin Adler.

accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::removeChildScrollbar):

accessibility/AccessibilityScrollbar.cpp:

(WebCore::AccessibilityScrollbar::AccessibilityScrollbar):

accessibility/AccessibilityScrollbar.h:

(WebCore::AccessibilityScrollbar::scrollbar):
(WebCore::AccessibilityScrollbar::isAccessibilityScrollbar):

2:21 PM Changeset in webkit [97302] by Dimitri Glazkov

4 edits in trunk/Tools

garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
https://bugs.webkit.org/show_bug.cgi?id=69954

Also renamed the action and associated event name to address an FIXME.

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.

2:10 PM Changeset in webkit [97301] by thakis@chromium.org

6 edits in trunk/Source/WebKit/chromium

[chromium] Add a setSelectionToRange() method to WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=69846

Also add a method to WebRange to create a range given a frame and an
interval.

This will be used to implement the "replacement range" feature of OS X
IMEs, see http://codereview.chromium.org/8227018 (the change to
render_widget.cc).
The renderer will set the selection to the replacement range before
calling confirmComposition(). This matches how WK2 does this, see
Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm,
WebPage::setComposition(). The function convertToRange() was taken
from there, too.

Reviewed by Darin Fisher.

public/WebFrame.h:

(WebKit::WebFrame::setSelectionToRange):

src/WebFrameImpl.cpp:

(WebKit::WebViewImpl::setSelectionToRange):

src/WebFrameImpl.h:

(WebKit::WebViewImpl::setSelectionToRange):

src/WebRange.cpp:

(WebRange::fromGlobalRange):

src/WebRange.h:

(WebRange::fromGlobalRange):

2:08 PM Changeset in webkit [97300] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark http/tests/media/video-play-stall.html as flaky TIMEOUT.

platform/chromium/test_expectations.txt: Marked.

2:01 PM Changeset in webkit [97299] by robert@webkit.org

1 edit
6 adds in trunk/LayoutTests

Platform-specific results for r97278

Unreviewed, adding results.

platform/gtk/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
platform/gtk/css2.1/20110323/border-conflict-style-088-expected.txt: Added.
platform/mac/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
platform/mac/css2.1/20110323/border-conflict-style-088-expected.txt: Added.
platform/qt/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
platform/qt/css2.1/20110323/border-conflict-style-088-expected.txt: Added.

1:59 PM Changeset in webkit [97298] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Widen expectation of flakiness according to bots.

platform/chromium/test_expectations.txt: Widened.

1:51 PM Changeset in webkit [97297] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

Selection is not collapsed in some WK2 editing tests
https://bugs.webkit.org/show_bug.cgi?id=69889

Skip tests for known reason.

Unreviewed.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-12

platform/mac-wk2/Skipped:
platform/qt-wk2/Skipped:

1:49 PM Changeset in webkit [97296] by barraclough@apple.com

2 edits in trunk/Source/JavaScriptCore

Errrk, revert accidental commit!

wtf/Platform.h:

1:47 PM Changeset in webkit [97295] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

Unreviewed, re-land changes from #69890, #69903.

These were reverted due to bug #69897, but #69903 fixed this problem.

dfg/DFGJITCodeGenerator.h:

(JSC::DFG::JITCodeGenerator::silentFillGPR):

1:28 PM Changeset in webkit [97294] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

ValueProfile::computeUpdatedPrediction doesn't merge statistics correctly
https://bugs.webkit.org/show_bug.cgi?id=69906

Reviewed by Gavin Barraclough.

It turns out that the simplest fix is to switch computeUpdatedPredictions()
to using predictionFromValue() combined with mergePrediction(). Doing so
allowed me to kill off weakBuckets and visitWeakReferences(). Hence this
not only fixes a performance bug but kills off a lot of code that I never
liked to begin with.

This appears to be a 1% win on V8.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):

bytecode/CodeBlock.h:
bytecode/PredictedType.cpp:

(JSC::predictionFromValue):

bytecode/ValueProfile.cpp:

(JSC::ValueProfile::computeStatistics):
(JSC::ValueProfile::computeUpdatedPrediction):

bytecode/ValueProfile.h:

(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::dump):

1:24 PM Changeset in webkit [97293] by tony@chromium.org

2 edits in trunk/Tools

stop spamming 'stopping test driver timed out, killing it' when running rwt
https://bugs.webkit.org/show_bug.cgi?id=69938

Reviewed by Adam Barth.

In http://trac.webkit.org/changeset/95875 , we made the timeout for
stopping the driver based on time_out_ms, but we based it on the wrong
default times.

Scripts/webkitpy/layout_tests/port/chromium.py:

1:23 PM Changeset in webkit [97292] by mhahnenberg@apple.com

15 edits in trunk/Source

De-virtualize JSCell::toString
https://bugs.webkit.org/show_bug.cgi?id=69677

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Removed toString from JSCallbackObject, since it is no
longer necessary since we now implicitly add toString and valueOf
functions to object prototypes when a convertToType callback
is provided, which is now the standard way to override toString
and valueOf in the JSC C API.

API/JSCallbackObject.h:
API/JSCallbackObjectFunctions.h:
JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

Removed toString from InterruptedExecutionError and
TerminatedExecutionError and replaced it with defaultValue,
which JSObject::toString calls. We'll probably have to de-virtualize
defaultValue eventually, but we'll cross that bridge when we
come to it.

runtime/ExceptionHelpers.cpp:

(JSC::InterruptedExecutionError::defaultValue):
(JSC::TerminatedExecutionError::defaultValue):

runtime/ExceptionHelpers.h:

Removed toString from JSNotAnObject, since its return value doesn't
actually matter and JSObject::toString can cover it.

runtime/JSNotAnObject.cpp:
runtime/JSNotAnObject.h:

De-virtualized JSCell::toString, JSObject::toString and JSString::toString.
Added handling of all cases for JSCell to JSCell::toString.

runtime/JSObject.h:
runtime/JSString.h:
runtime/JSCell.cpp:

(JSC::JSCell::toString):

runtime/JSCell.h:

Source/JavaScriptGlue:

Removed UserObjectImp::toString because it's no longer necessary since
clients can provide their own toString callback which will in turn be
called by JSObject::toString.

UserObjectImp.cpp:
UserObjectImp.h:

12:51 PM Changeset in webkit [97291] by oliver@apple.com

2 edits in trunk/Source/JavaScriptCore

Global stringStructure caches its prototype chain, abandoning a web page
https://bugs.webkit.org/show_bug.cgi?id=69952

Reviewed by Filip Pizlo.

When visiting a structure, we don't keep the prototype chain
alive if we're not the structure for an object type.

runtime/Structure.cpp:

(JSC::Structure::visitChildren):

12:47 PM Changeset in webkit [97290] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] More timeouts after V8 roll.

platform/chromium/test_expectations.txt: Updated.

12:45 PM Changeset in webkit [97289] by hyatt@apple.com

5 edits in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=69950

REGRESSION: Printing broken because of the isWritingModeRoot addition for unsplittable
paginated content. Make sure not to include the RenderView when checking for writing mode
roots. We only care about children that differ from their parents.

Reviewed by Dimitri Glazkov.

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustForUnsplittableChild):

rendering/RenderBox.cpp:

(WebCore::RenderBox::isUnsplittableForPagination):

rendering/RenderBox.h:

12:41 PM Changeset in webkit [97288] by caryclark@google.com

750 edits
2 adds in trunk/LayoutTests

Update baseline images affected by subpixel test positioning in
https://bugs.webkit.org/show_bug.cgi?id=69354 .

Unreviewed rebaselining for Skia.

platform/chromium-mac/css1/box_properties/clear_float-expected.png:
platform/chromium-mac/css1/box_properties/float_elements_in_series-expected.png:
platform/chromium-mac/css1/box_properties/float_on_text_elements-expected.png:
platform/chromium-mac/css1/text_properties/text_align-expected.png:
platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
platform/chromium-mac/css2.1/t0905-c5525-fltmult-00-d-g-expected.png:
platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png:
platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png:
platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png:
platform/chromium-mac/css2.1/t1202-counters-04-b-expected.png:
platform/chromium-mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
platform/chromium-mac/css3/unicode-bidi-isolate-aharon-expected.png:
platform/chromium-mac/css3/unicode-bidi-isolate-basic-expected.png:
platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
platform/chromium-mac/editing/selection/4975120-expected.png:
platform/chromium-mac/editing/selection/5240265-expected.png:
platform/chromium-mac/editing/selection/extend-inside-transforms-backward-expected.png:
platform/chromium-mac/editing/selection/extend-inside-transforms-forward-expected.png:
platform/chromium-mac/editing/selection/select-across-readonly-input-1-expected.png:
platform/chromium-mac/editing/selection/select-across-readonly-input-2-expected.png:
platform/chromium-mac/editing/selection/select-across-readonly-input-3-expected.png:
platform/chromium-mac/editing/selection/select-across-readonly-input-4-expected.png:
platform/chromium-mac/editing/selection/select-across-readonly-input-5-expected.png:
platform/chromium-mac/editing/selection/transformed-selection-rects-expected.png:
platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
platform/chromium-mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
platform/chromium-mac/editing/style/block-style-001-expected.png:
platform/chromium-mac/editing/style/block-style-002-expected.png:
platform/chromium-mac/editing/style/block-style-003-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-002-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-005-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-006-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-008-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-010-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-011-expected.png:
platform/chromium-mac/editing/style/create-block-for-style-012-expected.png:
platform/chromium-mac/editing/style/table-selection-expected.png:
platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
platform/chromium-mac/fast/block/basic/016-expected.png:
platform/chromium-mac/fast/block/float/016-expected.png:
platform/chromium-mac/fast/block/float/float-avoidance-expected.png:
platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
platform/chromium-mac/fast/block/positioning/051-expected.png:
platform/chromium-mac/fast/block/positioning/inline-block-relposition-expected.png:
platform/chromium-mac/fast/borders/bidi-012-expected.png:
platform/chromium-mac/fast/borders/border-antialiasing-expected.png:
platform/chromium-mac/fast/borders/rtl-border-04-expected.png:
platform/chromium-mac/fast/borders/rtl-border-05-expected.png:
platform/chromium-mac/fast/box-shadow/no-blur-multiple-offsets-expected.png:
platform/chromium-mac/fast/canvas/canvas-text-alignment-expected.png:
platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png:
platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png:
platform/chromium-mac/fast/css-generated-content/011-expected.png:
platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png:
platform/chromium-mac/fast/css/continuationCrash-expected.png:
platform/chromium-mac/fast/css/create_element_align-expected.png:
platform/chromium-mac/fast/css/css2-system-fonts-expected.png:
platform/chromium-mac/fast/css/font-face-locally-installed-expected.png:
platform/chromium-mac/fast/css/input-search-padding-expected.png:
platform/chromium-mac/fast/css/line-height-expected.png:
platform/chromium-mac/fast/css/margin-top-bottom-dynamic-expected.png:
platform/chromium-mac/fast/css/pseudo-cache-stale-expected.png:
platform/chromium-mac/fast/css/rtl-ordering-expected.png:
platform/chromium-mac/fast/css/table-text-align-strict-expected.png:
platform/chromium-mac/fast/css/text-input-with-webkit-border-radius-expected.png:
platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
platform/chromium-mac/fast/css/text-overflow-ellipsis-expected.png:
platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
platform/chromium-mac/fast/css/text-security-expected.png:
platform/chromium-mac/fast/dom/34176-expected.png:
platform/chromium-mac/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
platform/chromium-mac/fast/dom/HTMLTableElement/colSpan-expected.png:
platform/chromium-mac/fast/dom/HTMLTableElement/createCaption-expected.png:
platform/chromium-mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
platform/chromium-mac/fast/dynamic/008-expected.png:
platform/chromium-mac/fast/forms/003-expected.png:
platform/chromium-mac/fast/forms/004-expected.png:
platform/chromium-mac/fast/forms/005-expected.png:
platform/chromium-mac/fast/forms/HTMLOptionElement_label01-expected.png:
platform/chromium-mac/fast/forms/HTMLOptionElement_label02-expected.png:
platform/chromium-mac/fast/forms/HTMLOptionElement_label03-expected.png:
platform/chromium-mac/fast/forms/HTMLOptionElement_label04-expected.png:
platform/chromium-mac/fast/forms/HTMLOptionElement_label05-expected.png:
platform/chromium-mac/fast/forms/basic-buttons-expected.png:
platform/chromium-mac/fast/forms/basic-selects-expected.png:
platform/chromium-mac/fast/forms/basic-textareas-expected.png:
platform/chromium-mac/fast/forms/basic-textareas-quirks-expected.png:
platform/chromium-mac/fast/forms/blankbuttons-expected.png:
platform/chromium-mac/fast/forms/box-shadow-override-expected.png:
platform/chromium-mac/fast/forms/button-align-expected.png:
platform/chromium-mac/fast/forms/button-cannot-be-nested-expected.png:
platform/chromium-mac/fast/forms/button-default-title-expected.png:
platform/chromium-mac/fast/forms/button-generated-content-expected.png:
platform/chromium-mac/fast/forms/button-positioned-expected.png:
platform/chromium-mac/fast/forms/button-sizes-expected.png:
platform/chromium-mac/fast/forms/button-style-color-expected.png:
platform/chromium-mac/fast/forms/button-table-styles-expected.png:
platform/chromium-mac/fast/forms/button-text-transform-expected.png:
platform/chromium-mac/fast/forms/button-white-space-expected.png:
platform/chromium-mac/fast/forms/control-clip-expected.png:
platform/chromium-mac/fast/forms/control-clip-overflow-expected.png:
platform/chromium-mac/fast/forms/control-restrict-line-height-expected.png:
platform/chromium-mac/fast/forms/disabled-select-change-index-expected.png:
platform/chromium-mac/fast/forms/file/file-input-direction-expected.png:
platform/chromium-mac/fast/forms/file/input-file-re-render-expected.png:
platform/chromium-mac/fast/forms/floating-textfield-relayout-expected.png:
platform/chromium-mac/fast/forms/formmove3-expected.png:
platform/chromium-mac/fast/forms/input-align-expected.png:
platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.png:
platform/chromium-mac/fast/forms/input-appearance-default-bkcolor-expected.png:
platform/chromium-mac/fast/forms/input-appearance-disabled-expected.png:
platform/chromium-mac/fast/forms/input-appearance-height-expected.png:
platform/chromium-mac/fast/forms/input-appearance-preventDefault-expected.png:
platform/chromium-mac/fast/forms/input-appearance-readonly-expected.png:
platform/chromium-mac/fast/forms/input-appearance-spinbutton-layer-expected.png:
platform/chromium-mac/fast/forms/input-appearance-visibility-expected.png:
platform/chromium-mac/fast/forms/input-appearance-width-expected.png:
platform/chromium-mac/fast/forms/input-button-sizes-expected.png:
platform/chromium-mac/fast/forms/input-field-text-truncated-expected.png:
platform/chromium-mac/fast/forms/input-first-letter-expected.png:
platform/chromium-mac/fast/forms/input-placeholder-text-indent-expected.png:
platform/chromium-mac/fast/forms/input-readonly-autoscroll-expected.png:
platform/chromium-mac/fast/forms/input-readonly-dimmed-expected.png:
platform/chromium-mac/fast/forms/input-spaces-expected.png:
platform/chromium-mac/fast/forms/input-table-expected.png:
platform/chromium-mac/fast/forms/input-text-word-wrap-expected.png:
platform/chromium-mac/fast/forms/input-type-text-min-width-expected.png:
platform/chromium-mac/fast/forms/isindex-placeholder-expected.png:
platform/chromium-mac/fast/forms/listbox-bidi-align-expected.png:
platform/chromium-mac/fast/forms/listbox-scrollbar-incremental-load-expected.png:
platform/chromium-mac/fast/forms/listbox-width-change-expected.png:
platform/chromium-mac/fast/forms/menulist-clip-expected.png:
platform/chromium-mac/fast/forms/menulist-deselect-update-expected.png:
platform/chromium-mac/fast/forms/menulist-no-overflow-expected.png:
platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png:
platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
platform/chromium-mac/fast/forms/menulist-width-change-expected.png:
platform/chromium-mac/fast/forms/minWidthPercent-expected.png:
platform/chromium-mac/fast/forms/option-script-expected.png:
platform/chromium-mac/fast/forms/option-strip-whitespace-expected.png:
platform/chromium-mac/fast/forms/option-text-clip-expected.png:
platform/chromium-mac/fast/forms/password-placeholder-expected.png:
platform/chromium-mac/fast/forms/password-placeholder-text-security-expected.png:
platform/chromium-mac/fast/forms/placeholder-position-expected.png:
platform/chromium-mac/fast/forms/placeholder-pseudo-style-expected.png:
platform/chromium-mac/fast/forms/placeholder-set-attribute-expected.png:
platform/chromium-mac/fast/forms/placeholder-set-value-expected.png:
platform/chromium-mac/fast/forms/placeholder-stripped-expected.png:
platform/chromium-mac/fast/forms/search-cancel-button-style-sharing-expected.png:
platform/chromium-mac/fast/forms/search-display-none-cancel-button-expected.png:
platform/chromium-mac/fast/forms/search-placeholder-value-changed-expected.png:
platform/chromium-mac/fast/forms/search-rtl-expected.png:
platform/chromium-mac/fast/forms/search-styled-expected.png:
platform/chromium-mac/fast/forms/search-vertical-alignment-expected.png:
platform/chromium-mac/fast/forms/searchfield-heights-expected.png:
platform/chromium-mac/fast/forms/select-align-expected.png:
platform/chromium-mac/fast/forms/select-baseline-expected.png:
platform/chromium-mac/fast/forms/select-block-background-expected.png:
platform/chromium-mac/fast/forms/select-change-listbox-size-expected.png:
platform/chromium-mac/fast/forms/select-change-listbox-to-popup-expected.png:
platform/chromium-mac/fast/forms/select-change-popup-to-listbox-expected.png:
platform/chromium-mac/fast/forms/select-dirty-parent-pref-widths-expected.png:
platform/chromium-mac/fast/forms/select-disabled-appearance-expected.png:
platform/chromium-mac/fast/forms/select-initial-position-expected.png:
platform/chromium-mac/fast/forms/select-item-background-clip-expected.png:
platform/chromium-mac/fast/forms/select-list-box-with-height-expected.png:
platform/chromium-mac/fast/forms/select-selected-expected.png:
platform/chromium-mac/fast/forms/select-size-expected.png:
platform/chromium-mac/fast/forms/select-visual-hebrew-expected.png:
platform/chromium-mac/fast/forms/select-writing-direction-natural-expected.png:
platform/chromium-mac/fast/forms/stuff-on-my-optgroup-expected.png:
platform/chromium-mac/fast/forms/targeted-frame-submission-expected.png:
platform/chromium-mac/fast/forms/text-style-color-expected.png:
platform/chromium-mac/fast/forms/textarea-align-expected.png:
platform/chromium-mac/fast/forms/textarea-placeholder-pseudo-style-expected.png:
platform/chromium-mac/fast/forms/textarea-placeholder-set-attribute-expected.png:
platform/chromium-mac/fast/forms/textarea-placeholder-set-value-expected.png:
platform/chromium-mac/fast/forms/textarea-placeholder-wrapping-expected.png:
platform/chromium-mac/fast/forms/textarea-scroll-height-expected.png:
platform/chromium-mac/fast/forms/textarea-setinnerhtml-expected.png:
platform/chromium-mac/fast/forms/visual-hebrew-text-field-expected.png:
platform/chromium-mac/fast/html/details-replace-summary-child-expected.png:
platform/chromium-mac/fast/html/details-replace-text-expected.png:
platform/chromium-mac/fast/html/details-writing-mode-expected.png:
platform/chromium-mac/fast/html/keygen-expected.png:
platform/chromium-mac/fast/inline-block/003-expected.png:
platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png:
platform/chromium-mac/fast/inline/inline-box-background-expected.png:
platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png:
platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png:
platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png:
platform/chromium-mac/fast/lists/003-vertical-expected.png:
platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png:
platform/chromium-mac/fast/multicol/float-avoidance-expected.png:
platform/chromium-mac/fast/multicol/overflow-across-columns-expected.png:
platform/chromium-mac/fast/multicol/overflow-across-columns-percent-height-expected.png:
platform/chromium-mac/fast/multicol/overflow-unsplittable-expected.png:
platform/chromium-mac/fast/multicol/positive-leading-expected.png:
platform/chromium-mac/fast/overflow/infiniteRecursion-expected.png:
platform/chromium-mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
platform/chromium-mac/fast/overflow/scrollRevealButton-expected.png:
platform/chromium-mac/fast/parser/document-write-option-expected.png:
platform/chromium-mac/fast/parser/entity-comment-in-textarea-expected.png:
platform/chromium-mac/fast/parser/open-comment-in-textarea-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
platform/chromium-mac/fast/repaint/line-flow-with-floats-in-regions-expected.png:
platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png:
platform/chromium-mac/fast/replaced/width100percent-button-expected.png:
platform/chromium-mac/fast/replaced/width100percent-menulist-expected.png:
platform/chromium-mac/fast/replaced/width100percent-searchfield-expected.png:
platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png:
platform/chromium-mac/fast/ruby/nested-ruby-expected.png:
platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png:
platform/chromium-mac/fast/ruby/ruby-empty-rt-expected.png:
platform/chromium-mac/fast/ruby/ruby-inline-table-expected.png:
platform/chromium-mac/fast/ruby/ruby-length-expected.png:
platform/chromium-mac/fast/ruby/ruby-run-break-expected.png:
platform/chromium-mac/fast/ruby/ruby-runs-expected.png:
platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png:
platform/chromium-mac/fast/ruby/ruby-simple-expected.png:
platform/chromium-mac/fast/ruby/ruby-simple-rp-expected.png:
platform/chromium-mac/fast/ruby/ruby-text-before-after-content-expected.png:
platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png:
platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png:
platform/chromium-mac/fast/selectors/064-expected.png:
platform/chromium-mac/fast/table/011-expected.png:
platform/chromium-mac/fast/table/append-cells2-expected.png:
platform/chromium-mac/fast/table/border-collapsing/004-expected.png:
platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png:
platform/chromium-mac/fast/table/border-collapsing/rtl-border-collapsing-expected.png:
platform/chromium-mac/fast/table/colgroup-preceded-by-caption-expected.png:
platform/chromium-mac/fast/table/colgroup-spanning-groups-rules-expected.png:
platform/chromium-mac/fast/table/dynamic-caption-add-before-child-expected.png:
platform/chromium-mac/fast/table/dynamic-caption-add-remove-before-child-expected.png:
platform/chromium-mac/fast/table/frame-and-rules-expected.png:
platform/chromium-mac/fast/table/multiple-captions-display-expected.png:
platform/chromium-mac/fast/table/percent-heights-expected.png:
platform/chromium-mac/fast/table/remove-td-display-none-expected.png:
platform/chromium-mac/fast/table/rowindex-expected.png:
platform/chromium-mac/fast/table/rowspan-paint-order-vertical-expected.png:
platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png:
platform/chromium-mac/fast/table/text-field-baseline-expected.png:
platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.png:
platform/chromium-mac/fast/text/atsui-spacing-features-expected.png:
platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png:
platform/chromium-mac/fast/text/basic/002-expected.png:
platform/chromium-mac/fast/text/basic/015-expected.png:
platform/chromium-mac/fast/text/basic/generic-family-reset-expected.png:
platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
platform/chromium-mac/fast/text/break-word-expected.png:
platform/chromium-mac/fast/text/capitalize-boundaries-expected.png:
platform/chromium-mac/fast/text/cg-vs-atsui-expected.png:
platform/chromium-mac/fast/text/drawBidiText-expected.png:
platform/chromium-mac/fast/text/emphasis-expected.png:
platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png:
platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png:
platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png:
platform/chromium-mac/fast/text/international/bidi-explicit-embedding-expected.png:
platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
platform/chromium-mac/fast/text/international/bidi-innertext-expected.png:
platform/chromium-mac/fast/text/international/bidi-layout-across-linebreak-expected.png:
platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png:
platform/chromium-mac/fast/text/international/bidi-listbox-expected.png:
platform/chromium-mac/fast/text/international/bidi-menulist-expected.png:
platform/chromium-mac/fast/text/international/bidi-override-expected.png:
platform/chromium-mac/fast/text/international/hebrew-vowels-expected.png:
platform/chromium-mac/fast/text/international/hindi-spacing-expected.png:
platform/chromium-mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-expected.png:
platform/chromium-mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
platform/chromium-mac/fast/text/justified-selection-at-edge-expected.png:
platform/chromium-mac/fast/text/justify-ideograph-simple-expected.png:
platform/chromium-mac/fast/text/justify-ideograph-vertical-expected.png:
platform/chromium-mac/fast/text/line-breaks-expected.png:
platform/chromium-mac/fast/text/shadow-no-blur-expected.png:
platform/chromium-mac/fast/text/trailing-white-space-2-expected.png:
platform/chromium-mac/fast/text/trailing-white-space-expected.png:
platform/chromium-mac/fast/text/updateNewFont-expected.png:
platform/chromium-mac/fast/text/word-break-run-rounding-expected.png:
platform/chromium-mac/fast/transforms/transform-on-inline-expected.png:
platform/chromium-mac/fast/transforms/transform-table-row-expected.png:
platform/chromium-mac/fast/transforms/transformed-document-element-expected.png:
platform/chromium-mac/fast/writing-mode/vertical-baseline-alignment-expected.png:
platform/chromium-mac/fast/writing-mode/vertical-font-fallback-expected.png:
platform/chromium-mac/fonts/sans-serif-expected.png:
platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png:
platform/chromium-mac/media/audio-repaint-expected.png:
platform/chromium-mac/plugins/mouse-click-plugin-clears-selection-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-anchor-no-markup-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.png:
platform/chromium-mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-ltr-expected.png:
platform/chromium-mac/svg/W3C-I18N/tspan-direction-rtl-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/struct-frag-02-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-align-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-align-02-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-align-05-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-align-06-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-text-07-t-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.png:
platform/chromium-mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.png:
platform/chromium-mac/svg/as-background-image/animated-svg-as-background-expected.png:
platform/chromium-mac/svg/as-background-image/svg-as-background-4-expected.png:
platform/chromium-mac/svg/as-background-image/svg-as-background-5-expected.png:
platform/chromium-mac/svg/batik/filters/feTile-expected.png:
platform/chromium-mac/svg/batik/masking/maskRegions-expected.png:
platform/chromium-mac/svg/batik/paints/gradientLimit-expected.png:
platform/chromium-mac/svg/batik/paints/patternPreserveAspectRatioA-expected.png:
platform/chromium-mac/svg/batik/paints/patternRegionA-expected.png:
platform/chromium-mac/svg/batik/text/textAnchor-expected.png:
platform/chromium-mac/svg/batik/text/textAnchor2-expected.png:
platform/chromium-mac/svg/batik/text/textAnchor3-expected.png:
platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
platform/chromium-mac/svg/batik/text/textDecoration2-expected.png:
platform/chromium-mac/svg/batik/text/textEffect2-expected.png:
platform/chromium-mac/svg/batik/text/textGlyphOrientationHorizontal-expected.png:
platform/chromium-mac/svg/batik/text/textLayout-expected.png:
platform/chromium-mac/svg/batik/text/textLayout2-expected.png:
platform/chromium-mac/svg/batik/text/textLength-expected.png:
platform/chromium-mac/svg/batik/text/textOnPath-expected.png:
platform/chromium-mac/svg/batik/text/textOnPath2-expected.png:
platform/chromium-mac/svg/batik/text/textOnPath3-expected.png:
platform/chromium-mac/svg/batik/text/textOnPathSpaces-expected.png:
platform/chromium-mac/svg/batik/text/textPCDATA-expected.png:
platform/chromium-mac/svg/batik/text/textPosition-expected.png:
platform/chromium-mac/svg/batik/text/textProperties-expected.png:
platform/chromium-mac/svg/batik/text/textProperties2-expected.png:
platform/chromium-mac/svg/batik/text/textStyles-expected.png:
platform/chromium-mac/svg/batik/text/verticalText-expected.png:
platform/chromium-mac/svg/batik/text/verticalTextOnPath-expected.png:
platform/chromium-mac/svg/batik/text/xmlSpace-expected.png:
platform/chromium-mac/svg/carto.net/button-expected.png:
platform/chromium-mac/svg/carto.net/colourpicker-expected.png:
platform/chromium-mac/svg/carto.net/combobox-expected.png:
platform/chromium-mac/svg/carto.net/scrollbar-expected.png:
platform/chromium-mac/svg/carto.net/selectionlist-expected.png:
platform/chromium-mac/svg/carto.net/slider-expected.png:
platform/chromium-mac/svg/carto.net/textbox-expected.png:
platform/chromium-mac/svg/carto.net/window-expected.png:
platform/chromium-mac/svg/clip-path/clip-path-pixelation-expected.png:
platform/chromium-mac/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png:
platform/chromium-mac/svg/custom/gradient-with-1d-boundingbox-expected.png:
platform/chromium-mac/svg/custom/inline-svg-in-xhtml-expected.png:
platform/chromium-mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
platform/chromium-mac/svg/custom/js-late-clipPath-creation-expected.png:
platform/chromium-mac/svg/custom/js-late-gradient-creation-expected.png:
platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
platform/chromium-mac/svg/custom/js-late-pattern-creation-expected.png:
platform/chromium-mac/svg/custom/linking-a-03-b-all-expected.png:
platform/chromium-mac/svg/custom/linking-a-03-b-transform-expected.png:
platform/chromium-mac/svg/custom/linking-a-03-b-viewBox-transform-expected.png:
platform/chromium-mac/svg/custom/linking-uri-01-b-expected.png:
platform/chromium-mac/svg/custom/marker-default-width-height-expected.png:
platform/chromium-mac/svg/custom/mouse-move-on-svg-container-expected.png:
platform/chromium-mac/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
platform/chromium-mac/svg/custom/path-textPath-simulation-expected.png:
platform/chromium-mac/svg/custom/pattern-incorrect-tiling-expected.png:
platform/chromium-mac/svg/custom/preserve-aspect-ratio-syntax-expected.png:
platform/chromium-mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
platform/chromium-mac/svg/custom/stroke-width-large-expected.png:
platform/chromium-mac/svg/custom/stroked-pattern-expected.png:
platform/chromium-mac/svg/custom/struct-use-09-b-expected.png:
platform/chromium-mac/svg/custom/svg-fonts-without-missing-glyph-expected.png:
platform/chromium-mac/svg/custom/text-dom-01-f-expected.png:
platform/chromium-mac/svg/custom/text-linking-expected.png:
platform/chromium-mac/svg/custom/text-rotated-gradient-expected.png:
platform/chromium-mac/svg/custom/text-rotation-expected.png:
platform/chromium-mac/svg/custom/text-tref-03-b-change-href-dom-expected.png:
platform/chromium-mac/svg/custom/text-tref-03-b-change-href-expected.png:
platform/chromium-mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.png:
platform/chromium-mac/svg/custom/text-tref-03-b-tref-removal-expected.png:
platform/chromium-mac/svg/custom/text-x-dy-lists-expected.png:
platform/chromium-mac/svg/custom/tref-own-content-removal-expected.png:
platform/chromium-mac/svg/custom/tref-update-expected.png:
platform/chromium-mac/svg/custom/use-detach-expected.png:
platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-1-expected.png:
platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-2-expected.png:
platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-3-expected.png:
platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-4-expected.png:
platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-5-expected.png:
platform/chromium-mac/svg/custom/use-on-disallowed-foreign-object-6-expected.png:
platform/chromium-mac/svg/custom/use-on-non-svg-namespaced-element-expected.png:
platform/chromium-mac/svg/custom/use-referencing-nonexisting-symbol-expected.png:
platform/chromium-mac/svg/custom/viewbox-syntax-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png: Added.
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGTextElement-dom-rotate-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGTextElement-dom-textLength-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGTextElement-svgdom-textLength-prop-expected.png:
platform/chromium-mac/svg/hixie/mixed/003-expected.png:
platform/chromium-mac/svg/hixie/mixed/008-expected.png:
platform/chromium-mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.png:
platform/chromium-mac/svg/hixie/viewbox/preserveAspectRatio/002-expected.png:
platform/chromium-mac/svg/text/bidi-reorder-value-lists-expected.png:
platform/chromium-mac/svg/text/bidi-text-anchor-direction-expected.png:
platform/chromium-mac/svg/text/bidi-text-query-expected.png:
platform/chromium-mac/svg/text/bidi-tspans-expected.png:
platform/chromium-mac/svg/text/font-size-below-point-five-2-expected.png:
platform/chromium-mac/svg/text/scaled-font-expected.png:
platform/chromium-mac/svg/text/scaling-font-with-geometric-precision-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-1-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-2-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-3-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-squeeze-4-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-stretch-1-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-stretch-2-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-stretch-3-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacing-stretch-4-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
platform/chromium-mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
platform/chromium-mac/svg/text/small-fonts-2-expected.png: Added.
platform/chromium-mac/svg/text/small-fonts-3-expected.png:
platform/chromium-mac/svg/text/small-fonts-expected.png:
platform/chromium-mac/svg/text/small-fonts-in-html5-expected.png:
platform/chromium-mac/svg/text/text-align-01-b-expected.png:
platform/chromium-mac/svg/text/text-align-02-b-expected.png:
platform/chromium-mac/svg/text/text-align-03-b-expected.png:
platform/chromium-mac/svg/text/text-align-04-b-expected.png:
platform/chromium-mac/svg/text/text-align-05-b-expected.png:
platform/chromium-mac/svg/text/text-align-06-b-expected.png:
platform/chromium-mac/svg/text/text-deco-01-b-expected.png:
platform/chromium-mac/svg/text/text-fonts-01-t-expected.png:
platform/chromium-mac/svg/text/text-fonts-02-t-expected.png:
platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
platform/chromium-mac/svg/text/text-path-01-b-expected.png:
platform/chromium-mac/svg/text/text-path-middle-align-expected.png:
platform/chromium-mac/svg/text/text-text-01-b-expected.png:
platform/chromium-mac/svg/text/text-text-03-b-expected.png:
platform/chromium-mac/svg/text/text-text-07-t-expected.png:
platform/chromium-mac/svg/text/text-text-08-b-expected.png:
platform/chromium-mac/svg/text/text-tref-01-b-expected.png:
platform/chromium-mac/svg/text/text-tselect-01-b-expected.png:
platform/chromium-mac/svg/text/text-tselect-02-f-expected.png:
platform/chromium-mac/svg/text/text-tspan-01-b-expected.png:
platform/chromium-mac/svg/text/text-ws-01-t-expected.png:
platform/chromium-mac/svg/text/text-ws-02-t-expected.png:
platform/chromium-mac/svg/wicd/rightsizing-grid-expected.png:
platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-foreignObject-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-hixie-mixed-009-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-mask-with-percentages-expected.png:
platform/chromium-mac/svg/zoom/text/zoom-foreignObject-expected.png:
platform/chromium-mac/svg/zoom/text/zoom-hixie-mixed-008-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug10633-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug11384q-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug11384s-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1163-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug126742-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1302-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug131020-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug131020_iframe-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug138725-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1802-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1802s-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug18359-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug18664-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug194024-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug26178-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug27038-3-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug28928-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug29326-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug2962-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug30559-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug30692-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug3260-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug33855-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug3454-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug39209-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug3977-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug4382-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug43854-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug43854-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug4429-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug44505-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug46368-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug46368-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug48028-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug50695-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug51037-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug51727-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug52505-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug52506-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug5838-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug59354-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug60749-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug60804-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug60807-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug6304-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug647-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug67915-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug68912-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug69382-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug7112-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug7112-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug72359-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug7342-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug81934-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug8381-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug88035-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug88035-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug88524-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug8950-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug96334-expected.png:
platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
platform/chromium-mac/tables/mozilla/core/captions-expected.png:
platform/chromium-mac/tables/mozilla/core/margins-expected.png:
platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_position-table-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
platform/chromium-mac/tables/mozilla/marvin/body_col-expected.png:
platform/chromium-mac/tables/mozilla/marvin/body_tfoot-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_align_left-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_align_right-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_span-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_width_pct-expected.png:
platform/chromium-mac/tables/mozilla/marvin/colgroup_width_px-expected.png:
platform/chromium-mac/tables/mozilla/marvin/table_row_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/table_rules_none-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tables_caption_align_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tables_td_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tables_th_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tables_th_height-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tables_th_width-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tbody_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/tfoot_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_middle-expected.png:
platform/chromium-mac/tables/mozilla/marvin/th_valign_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_caption_align_top-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_caption_class-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_caption_id-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_caption_style-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_table-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_tbody_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_colspan-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_width-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_thead_align_center-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
platform/chromium-mac/tables/mozilla/other/body_col-expected.png:
platform/chromium-mac/tables/mozilla/other/test3-expected.png:
platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-11-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-12-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-4-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-7-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug3166-8-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/core/captions3-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/other/test4-expected.png:

12:28 PM Changeset in webkit [97287] by abarth@webkit.org

9 edits in trunk/Source/WebCore

Moving ScriptExecutionContext to the front of the argument list for
IDL constructors that use ConstructorWith=ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=69799

Patch by Anna Cavender <annacc@chromium.org> on 2011-10-12
Reviewed by Adam Barth.

Tests:

http/tests/eventsource/* (for EventSource)
fast/filesystem/* (for Worker)

bindings/js/JSEventSourceCustom.cpp:

(WebCore::JSEventSourceConstructor::constructJSEventSource):

bindings/js/JSWorkerCustom.cpp:

(WebCore::JSWorkerConstructor::constructJSWorker):

bindings/scripts/CodeGeneratorV8.pm:

(GenerateConstructorCallback):

bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::constructorCallback):

page/EventSource.cpp:

(WebCore::EventSource::create):

page/EventSource.h:
workers/Worker.cpp:

(WebCore::Worker::create):

workers/Worker.h:

12:28 PM Changeset in webkit [97286] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

DFG JIT 32_64 - Fix ArrayPop
https://bugs.webkit.org/show_bug.cgi?id=69918

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-12
Reviewed by Filip Pizlo.

The storageLengthGPR is polluted by EmptyValueTag and later used to
index the array, which results in abnormal behaviors in execution.
This fix makes 32_64 DFG pass v8-deltablue and kraken
crypto-sha256-iterative on Linux ia32.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::store32):

assembler/X86Assembler.h:

(JSC::X86Assembler::movl_i32m):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

12:23 PM Changeset in webkit [97285] by Simon Fraser

2 edits in trunk/Tools

3D transforms are flattened in WebKit2 snapshots
https://bugs.webkit.org/show_bug.cgi?id=68276

Reviewed by Adam Roben.

Fix WKImage leak noticed by Adam.

WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::windowSnapshotImage):

12:13 PM Changeset in webkit [97284] by rniwa@webkit.org

2 edits
7 adds in trunk/LayoutTests

Chromium rebaseline after r85535. The test only works in Mac because it tests sub pixel layout and
depends on the specific font metrics used in Mac port.

platform/chromium-cg-mac-leopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
platform/chromium-cg-mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
platform/chromium-linux/editing/inserting/typing-at-end-of-line-expected.png: Added.
platform/chromium-mac-leopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
platform/chromium-mac-snowleopard/editing/inserting/typing-at-end-of-line-expected.png: Added.
platform/chromium-win/editing/inserting/typing-at-end-of-line-expected.png: Added.
platform/chromium-win/editing/inserting/typing-at-end-of-line-expected.txt: Added.
platform/chromium/test_expectations.txt:

11:58 AM Changeset in webkit [97283] by jer.noble@apple.com

2 edits in trunk/LayoutTests

Lion: media tests with invalid URLs failing
https://bugs.webkit.org/show_bug.cgi?id=69947

Unreviewed.

Add failing tests to the Skipped list.

platform/mac-lion/Skipped:

11:51 AM Changeset in webkit [97282] by hyatt@apple.com

15 edits
21 adds in trunk

Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=69896

[CSS Regions] Make positioned blocks work with variable width regions.

Make positioned objects able to position and size independently in each region. This involves
lifting the restriction in renderBoxRegionInfo for positioned objects and passing in region
information to computeLogicalWidthForPositioned so that it can compute answers for a given
region.

In order to make mixed writing modes work with positioned objects, this patch also takes some
baby steps towards fixing differing writing modes in paginated environments.

Reviewed by Sam Weinig.

Added many new tests in fast/regions.

rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):
Disable pagination whenever differing writing modes are encountered. The block effectively becomes
unsplittable (as though it was an image).

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layoutBlock):
Remove a FIXME that looks incorrect now.

(WebCore::RenderBlock::adjustPositionedBlock):
Patch static inline position caching to call a new method that unshifts the position to put it back
in the overall block's space rather than having it be per-region.

(WebCore::RenderBlock::layoutPositionedObjects):
Make sure to attempt to set a logicalTop for positioned objects before they lay out so that they
have a chance of paginating correctly the first time around. If for some reason the top estimate proves
to be incorrect, we lay out again. Technically this bug exists for multi-column and printing as well, but
for now just fixing it for regions.

(WebCore::RenderBlock::adjustForUnsplittableChild):
Add writing mode roots to the set of objects we consider to be unsplittable.

(WebCore::RenderBlock::setStaticInlinePositionForChild):
New helper function that handles shifting the inline static position back into the overall block's space
rather than leaving it in a translated region-specific space.

rendering/RenderBlock.h:

(WebCore::RenderBlock::startOffsetForContent):
New helper function for computing the start offset when no regions are involved.

rendering/RenderBlockLineLayout.cpp:

(WebCore::setStaticPositions):
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
Patched to call the new helper function, setStaticInlinePositionForChild.

rendering/RenderBox.cpp:

(WebCore::RenderBox::positionLineBox):
Patched to call the new helper function, setStaticInlinePositionForChild.

(WebCore::RenderBox::computeLogicalWidthInRegion):
Pass region information into the positioning logical width computation function.

(WebCore::RenderBox::renderBoxRegionInfo):
Remove the positioning restriction and properly compute shifting and left/right offsets for positioned
objects.

(WebCore::RenderBox::computeLogicalHeight):
Add code for perpendicular flows that just positions the object within the first region it is encountered
in. Since the object is unsplittable, this will work out. Should the object be so tall that it can't fit
in any region, then the resulting rendering will potentially be terrible, but the expectation is that authors should
avoid having perpendicular flows break across pages.

(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
Patched to handle regions when they are passed in. Also makes sure that the pagination direction axis computation uses
the flow thread's first region when the flow thread is the positioned object's containing block.

(WebCore::computeInlineStaticDistance):
Patched to examine regions and to modify the static distance computation accordingly so that it is per-region.

(WebCore::RenderBox::computePositionedLogicalWidth):
Pass along the region information when computing the positioned logical width.

(WebCore::computeLogicalLeftPositionedOffset):
Handle the adjustment of the logical left offset for differing writing modes (in this case when the writing mode
is flipped relative to us).

(WebCore::RenderBox::computePositionedLogicalHeight):
Deal with perpendicular writing modes and make sure the object is placed properly using the first region it
occurs in.

(WebCore::computeLogicalTopPositionedOffset):
Remove code that is no longer needed.

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
Patched to pass in 0 instead of a region since replaced elements aren't handled yet.

rendering/RenderBox.h:

Changing the computePositionedLogicalWidth method to take region information.

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
Didn't bother fixing deprecated flexible box, and the new flexbox still can't handle positioned objects. When it does,
it will use the new method. Put in some FIXMEs to help the flexbox coders see the issue when they port the code over
to the new flexbox.

rendering/RenderLayer.h:

(WebCore::RenderLayer::staticInlinePosition):
(WebCore::RenderLayer::staticBlockPosition):
(WebCore::RenderLayer::setStaticInlinePosition):
(WebCore::RenderLayer::setStaticBlockPosition):
Patched to take LayoutUnits instead of ints.

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=69896

[CSS Regions] Make positioned blocks work with variable width regions.

Reviewed by Sam Weinig.

fast/regions/overflow-size-change-with-stacking-context-rtl.html: Added.
fast/regions/position-writing-modes-in-variable-width-regions.html: Added.
fast/regions/positioned-objects-block-static-spanning-regions-rtl.html: Added.
fast/regions/positioned-objects-block-static-spanning-regions.html: Added.
fast/regions/positioned-objects-inline-static-spanning-regions-rtl.html: Added.
fast/regions/positioned-objects-inline-static-spanning-regions.html: Added.
fast/regions/positioned-objects-spanning-regions.html: Added.
platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.txt:
platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Added.
platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Added.
platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.png: Added.
platform/mac/fast/regions/position-writing-modes-in-variable-width-regions-expected.txt: Added.
platform/mac/fast/regions/positioned-objects-block-static-in-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-block-static-in-rtl-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.png: Added.
platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-expected.txt: Added.
platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.png: Added.
platform/mac/fast/regions/positioned-objects-block-static-spanning-regions-rtl-expected.txt: Added.
platform/mac/fast/regions/positioned-objects-inline-static-in-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-inline-static-in-rtl-regions-expected.txt:
platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.png: Added.
platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-expected.txt: Added.
platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.png: Added.
platform/mac/fast/regions/positioned-objects-inline-static-spanning-regions-rtl-expected.txt: Added.
platform/mac/fast/regions/positioned-objects-spanning-regions-expected.png: Added.
platform/mac/fast/regions/positioned-objects-spanning-regions-expected.txt: Added.

11:46 AM Changeset in webkit [97281] by Dimitri Glazkov

5 edits in trunk/Tools

garden-o-matic should color-code test failure types.
https://bugs.webkit.org/show_bug.cgi?id=69945

Reviewed by Adam Barth.

BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.

11:45 AM Changeset in webkit [97280] by Nate Chapin

5 edits in trunk/Source/WebCore

Remove logging to determine how null v8::Contexts are happening,
and check the return value of V8DOMWindowShell::initContextIfNeeded()
before using the context it initialized.
https://bugs.webkit.org/show_bug.cgi?id=68099

Reviewed by Adam Barth.

No new tests, the only symptom is a crash without a known repro.

bindings/v8/ScriptController.cpp:
bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initContextIfNeeded): Return true

if a context already existed.

(WebCore::V8DOMWindowShell::namedItemAdded): Remove logging.

bindings/v8/V8Proxy.cpp:

11:30 AM Changeset in webkit [97279] by abarth@webkit.org

3 edits in trunk/Tools

webkitpy tests are failing on Mac bots
https://bugs.webkit.org/show_bug.cgi?id=69929

Reviewed by Simon Fraser.

Admit that Lion exists.

Scripts/webkitpy/layout_tests/port/chromium.py:
Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

11:28 AM Changeset in webkit [97278] by robert@webkit.org

4 edits
6 adds in trunk

CSS 2.1 failure: border-conflict-style-079
https://bugs.webkit.org/show_bug.cgi?id=69551

Reviewed by Antonio Gomes.

Source/WebCore:

css/CSSValueKeywords.in: ridge and outset were the wrong way round
rendering/style/RenderStyleConstants.h: ditto

LayoutTests:

css2.1/20110323/border-conflict-style-079.htm: Added.
css2.1/20110323/border-conflict-style-088.htm: Added.
platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.png: Added.
platform/chromium-linux/css2.1/20110323/border-conflict-style-079-expected.txt: Added.
platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.png: Added.
platform/chromium-linux/css2.1/20110323/border-conflict-style-088-expected.txt: Added.

11:27 AM Changeset in webkit [97277] by Simon Fraser

2 edits in trunk/Tools

Improve output of run-api-tests to make time-outs more obvious
https://bugs.webkit.org/show_bug.cgi?id=69788

Reviewed by Adam Roben.

List the tests that failed and timed out at the bottom of the output,
if run with --verbose.

Scripts/run-api-tests:

(runAllTests):
(runTest):

11:11 AM Changeset in webkit [97276] by abarth@webkit.org

3 edits in trunk/Tools

Unreviewed, rolling out r97252.
http://trac.webkit.org/changeset/97252
https://bugs.webkit.org/show_bug.cgi?id=69944

Broke test-webkpy (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-12

Scripts/webkitpy/layout_tests/port/qt.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:

10:56 AM Changeset in webkit [97275] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Fix expectation ambiguities.

platform/chromium/test_expectations.txt: Fixed.

10:45 AM Changeset in webkit [97274] by jianli@chromium.org

13 edits in trunk

Support passing optional filename when FormData.append() is used to
append a blob
https://bugs.webkit.org/show_bug.cgi?id=69885

Reviewed by David Levin.

Source/WebCore:

Covered by existing test with new test case added:
http/tests/local/formdata/send-form-data-with-sliced-file.html

bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append):

bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::appendCallback):

html/DOMFormData.cpp:

(WebCore::DOMFormData::append):

html/DOMFormData.h:
html/DOMFormData.idl:
html/FormDataList.cpp:

(WebCore::FormDataList::appendBlob):

html/FormDataList.h:

(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::filename):
(WebCore::FormDataList::appendBlob):

platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems):

LayoutTests:

http/tests/local/formdata/resources/send-form-data-common.js:

(dumpResponse):
(sendFormData):
(testSendingFormData):

http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:

(runTest):

http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt:

10:41 AM Changeset in webkit [97273] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Mark implicit-submission test as slow for all Debug builds.

platform/chromium/test_expectations.txt: Marked so.

10:32 AM Changeset in webkit [97272] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Fix ambiguous expectations.

platform/chromium/test_expectations.txt: Fixed.

10:27 AM Changeset in webkit [97271] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] More TIMEOUTs and TIMEOUT flakes due to V8 roll.

platform/chromium/test_expectations.txt: Added expectations of TIMEOUT.

10:05 AM Changeset in webkit [97270] by abarth@webkit.org

6 edits in trunk/Source

ScriptController::executeIfJavaScriptURL gets confused by synchronous frame loads
https://bugs.webkit.org/show_bug.cgi?id=69777

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-12
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html

bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::executeIfJavaScriptURL):

loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):
(WebCore::DocumentWriter::begin):

loader/DocumentWriter.h:

Source/WebKit/chromium:

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::loadJavaScriptURL):

9:55 AM Changeset in webkit [97269] by kov@webkit.org

8 edits
1 delete in trunk

Fix build with GLib 2.31
https://bugs.webkit.org/show_bug.cgi?id=69840

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2011-10-12
Reviewed by Martin Robinson.

configure.ac: add check for pthread rwlock support.

Source/JavaScriptCore:

GNUmakefile.list.am: removed ThreadingGtk.cpp.
wtf/ThreadingPrimitives.h: remove GTK+-specific definitions.
wtf/gobject/GOwnPtr.cpp: remove GCond and GMutex specializations.
wtf/gobject/GOwnPtr.h: ditto.
wtf/gobject/GTypedefs.h: remove GCond and GMutex forward declarations.
wtf/gtk/ThreadingGtk.cpp: Removed.

9:48 AM Changeset in webkit [97268] by Dimitri Glazkov

2 edits in trunk/LayoutTests

[Chromium] Add a bunch of TIMEOUTs due to V8 roll.

platform/chromium/test_expectations.txt: Added expectations of TIMEOUT.

9:24 AM Changeset in webkit [97267] by vsevik@chromium.org

14 edits
2 adds in trunk/Source/WebCore

Web Inspector: Searching in multiple scripts in the scripts tab
https://bugs.webkit.org/show_bug.cgi?id=38807

Reviewed by Pavel Feldman.

Added support for advanced search capabilities in inspector by means
of showing the new SearchView in Drawer. Advanced search is activated
with Ctrl+Shift+F (Cmd+Shift+F) shortcut.

English.lproj/localizedStrings.js:
WebCore.gypi:
WebCore.vcproj/WebCore.vcproj:
inspector/compile-front-end.sh:
inspector/front-end/AdvancedSearchController.js: Added.
inspector/front-end/DebuggerPresentationModel.js:

(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):

inspector/front-end/ScriptsPanel.js:
inspector/front-end/ScriptsSearchScope.js: Added.
inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode.prototype.searchInContent):

inspector/front-end/WebKit.qrc:
inspector/front-end/externs.js:

(WebInspector.showViewInDrawer):

inspector/front-end/inspector.css:

(.search-view):
(.search-view .search-panel):
(.search-view .search-results):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:first-child):
(#search-results-pane-file-based .search-result .search-result-file-name):
(#search-results-pane-file-based .search-result .search-result-matches-count):
(#search-results-pane-file-based .search-match):
(#search-results-pane-file-based .search-match .webkit-line-number.search-match-line-number):
(#search-results-pane-file-based .search-match:not(:hover) .webkit-line-number.search-match-line-number):
(#search-results-pane-file-based .search-match:hover):
(#search-results-pane-file-based .search-match .highlighted-match):
(#search-results-pane-file-based a):
(#search-results-pane-file-based .search-match .search-match-content):

inspector/front-end/inspector.html:
inspector/front-end/inspector.js:

(WebInspector.documentKeyDown):

inspector/front-end/utilities.js:

():

9:19 AM QtWebKitBuildBots edited by Csaba Osztrogonác

(diff)

9:07 AM Changeset in webkit [97266] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: testPauseWhenLoadingDevTools is broken
https://bugs.webkit.org/show_bug.cgi?id=69934

Reviewed by Pavel Feldman.

src/js/Tests.js:

8:54 AM Changeset in webkit [97265] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt] Assertion fail in CSSPrimitiveValue ctor
https://bugs.webkit.org/show_bug.cgi?id=69933

Unreviewed gardening.

platform/qt/Skipped:

8:29 AM Changeset in webkit [97264] by vsevik@chromium.org

5 edits in trunk/Source/WebCore

Web Inspector: Fix Drawer to make it possible to show views other than Console.
https://bugs.webkit.org/show_bug.cgi?id=69831

Reviewed by Pavel Feldman.

Animation type extracted to distinguish between slow and normal
animation and immediate show/hide.
Implemented correct console toggle button behavior on showing views
other than console in Drawer.
View shown in Drawer is now shown in drawer-contents div with common
styles moved there.
Removed unused "_safelyRemoveChildren" method from Drawer.

inspector/front-end/ConsolePanel.js:

(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):

inspector/front-end/Drawer.js:

(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._animationDuration):

inspector/front-end/inspector.css:

(body.drawer-visible #drawer-contents):

inspector/front-end/inspector.js:

(WebInspector._toggleConsoleButtonClicked):
(WebInspector._escPressed):
(WebInspector.showViewInDrawer):
(WebInspector.documentKeyDown):

8:27 AM Changeset in webkit [97263] by commit-queue@webkit.org

3 edits
3 moves in trunk/Source/WebKit2

[Qt][WK2] Move qweberror* out of API/qt
https://bugs.webkit.org/show_bug.cgi?id=69875

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-10-12
Reviewed by Andreas Kling.

Moving QWebError outside API/qt in order to keep our API folder (layer) aligned.

UIProcess/qt/qweberror.cpp: Renamed from Source/WebKit2/UIProcess/API/qt/qweberror.cpp.

(QWebError::QWebError):
(QWebErrorPrivate::createQWebError):
(QWebErrorPrivate::QWebErrorPrivate):
(QWebErrorPrivate::~QWebErrorPrivate):
(QWebError::type):
(QWebError::errorCode):
(QWebError::url):

UIProcess/qt/qweberror.h: Renamed from Source/WebKit2/UIProcess/API/qt/qweberror.h.

(QWebError::errorCodeAsHttpStatusCode):
(QWebError::errorCodeAsNetworkError):

UIProcess/qt/qweberror_p.h: Renamed from Source/WebKit2/UIProcess/API/qt/qweberror_p.h.
WebKit2.pro:
WebKit2API.pri:

7:58 AM Changeset in webkit [97262] by commit-queue@webkit.org

3 edits in trunk/Source/WebKit2

[WebKit2][gtk] Add few more API's to gtk-doc section file.
https://bugs.webkit.org/show_bug.cgi?id=69921

Patch by Nayan Kumar K <nayankk@motorola.com> on 2011-10-12
Reviewed by Gustavo Noronha Silva.

Generate documentation for existing WebKit2-GTK+ API's,
which are not yet the part of gtk-doc documentation.

UIProcess/API/gtk/docs/GNUmakefile.am: List ignore files.
UIProcess/API/gtk/docs/webkit2gtk-sections.txt: API's addition.

7:56 AM Changeset in webkit [97261] by caryclark@google.com

383 edits
70 deletes in trunk/LayoutTests

Roll back image baseline changes from
http://trac.webkit.org/changeset/96814 -- they were generated on a
headless Mac, and thus used the wrong color profile.

Unreviewed rebaselining.

platform/chromium-mac/css1/basic/comments-expected.png:
platform/chromium-mac/css1/basic/containment-expected.png:
platform/chromium-mac/css1/basic/id_as_selector-expected.png:
platform/chromium-mac/css1/basic/inheritance-expected.png:
platform/chromium-mac/css1/box_properties/border-expected.png:
platform/chromium-mac/css1/box_properties/border_bottom-expected.png:
platform/chromium-mac/css1/box_properties/border_bottom_width-expected.png:
platform/chromium-mac/css1/box_properties/border_left-expected.png:
platform/chromium-mac/css1/box_properties/border_left_width-expected.png:
platform/chromium-mac/css1/box_properties/border_right_inline-expected.png:
platform/chromium-mac/css1/box_properties/border_right_width-expected.png:
platform/chromium-mac/css1/box_properties/border_style-expected.png:
platform/chromium-mac/css1/box_properties/border_top-expected.png:
platform/chromium-mac/css1/box_properties/border_top_width-expected.png:
platform/chromium-mac/css1/box_properties/border_width-expected.png:
platform/chromium-mac/css1/box_properties/clear-expected.png:
platform/chromium-mac/css1/box_properties/float_margin-expected.png:
platform/chromium-mac/css1/box_properties/height-expected.png:
platform/chromium-mac/css1/box_properties/margin-expected.png:
platform/chromium-mac/css1/box_properties/margin_bottom-expected.png:
platform/chromium-mac/css1/box_properties/margin_inline-expected.png:
platform/chromium-mac/css1/box_properties/margin_left-expected.png:
platform/chromium-mac/css1/box_properties/margin_right-expected.png:
platform/chromium-mac/css1/box_properties/margin_top-expected.png:
platform/chromium-mac/css1/box_properties/padding-expected.png:
platform/chromium-mac/css1/box_properties/padding_bottom-expected.png:
platform/chromium-mac/css1/box_properties/padding_inline-expected.png:
platform/chromium-mac/css1/box_properties/padding_left-expected.png:
platform/chromium-mac/css1/box_properties/padding_right-expected.png:
platform/chromium-mac/css1/box_properties/padding_top-expected.png:
platform/chromium-mac/css1/box_properties/width-expected.png:
platform/chromium-mac/css1/cascade/cascade_order-expected.png:
platform/chromium-mac/css1/classification/display-expected.png:
platform/chromium-mac/css1/classification/list_style_type-expected.png:
platform/chromium-mac/css1/classification/white_space-expected.png:
platform/chromium-mac/css1/color_and_background/background-expected.png:
platform/chromium-mac/css1/color_and_background/background_attachment-expected.png:
platform/chromium-mac/css1/color_and_background/background_position-expected.png:
platform/chromium-mac/css1/color_and_background/background_repeat-expected.png:
platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png:
platform/chromium-mac/css1/font_properties/font_size-expected.png:
platform/chromium-mac/css1/font_properties/font_weight-expected.png:
platform/chromium-mac/css1/formatting_model/floating_elements-expected.png:
platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png:
platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png:
platform/chromium-mac/css1/formatting_model/inline_elements-expected.png:
platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png:
platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png:
platform/chromium-mac/css1/pseudo/anchor-expected.png:
platform/chromium-mac/css1/pseudo/firstletter-expected.png:
platform/chromium-mac/css1/pseudo/firstline-expected.png:
platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png:
platform/chromium-mac/css1/text_properties/letter_spacing-expected.png:
platform/chromium-mac/css1/text_properties/line_height-expected.png:
platform/chromium-mac/css1/text_properties/text_decoration-expected.png:
platform/chromium-mac/css1/text_properties/text_indent-expected.png:
platform/chromium-mac/css1/text_properties/vertical_align-expected.png:
platform/chromium-mac/css1/text_properties/word_spacing-expected.png:
platform/chromium-mac/css1/units/color_units-expected.png:
platform/chromium-mac/css1/units/length_units-expected.png:
platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Removed.
platform/chromium-mac/css2.1/20110323/abspos-non-replaced-width-margin-000-ref-expected.png: Removed.
platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Removed.
platform/chromium-mac/css2.1/20110323/abspos-replaced-width-margin-000-ref-expected.png: Removed.
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-002-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-004-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-006-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-008-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-010-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-012-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-014-expected.png:
platform/chromium-mac/css2.1/20110323/block-non-replaced-height-016-expected.png:
platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png:
platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png:
platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png:
platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Removed.
platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Removed.
platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png:
platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Removed.
platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Removed.
platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png:
platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png:
platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png:
platform/chromium-mac/editing/inserting/insert-div-023-expected.png:
platform/chromium-mac/editing/selection/focus_editable_html-expected.png:
platform/chromium-mac/editing/selection/select-all-003-expected.png:
platform/chromium-mac/editing/selection/select-all-004-expected.png:
platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png:
platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png:
platform/chromium-mac/fast/backgrounds/size/backgroundSize15-expected.png:
platform/chromium-mac/fast/block/basic/fieldset-stretch-to-legend-expected.png:
platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png:
platform/chromium-mac/fast/block/float/008-expected.png: Removed.
platform/chromium-mac/fast/block/float/013-expected.png:
platform/chromium-mac/fast/block/float/019-expected.png: Removed.
platform/chromium-mac/fast/block/float/021-expected.png:
platform/chromium-mac/fast/block/float/025-expected.png:
platform/chromium-mac/fast/block/float/026-expected.png:
platform/chromium-mac/fast/block/float/027-expected.png:
platform/chromium-mac/fast/block/float/028-expected.png:
platform/chromium-mac/fast/block/float/032-expected.png: Removed.
platform/chromium-mac/fast/block/float/035-expected.png: Removed.
platform/chromium-mac/fast/block/float/avoidance-percent-width-strict-expected.png: Removed.
platform/chromium-mac/fast/block/float/br-with-clear-2-expected.png: Removed.
platform/chromium-mac/fast/block/float/float-not-removed-from-next-sibling4-expected.png:
platform/chromium-mac/fast/block/float/nested-clearance-expected.png: Removed.
platform/chromium-mac/fast/block/float/relative-painted-twice-expected.png:
platform/chromium-mac/fast/block/lineboxcontain/parsing-invalid-expected.png:
platform/chromium-mac/fast/block/margin-collapse/104-expected.png:
platform/chromium-mac/fast/block/margin-collapse/empty-clear-blocks-expected.png:
platform/chromium-mac/fast/block/positioning/047-expected.png:
platform/chromium-mac/fast/block/positioning/055-expected.png:
platform/chromium-mac/fast/block/positioning/auto/007-expected.png:
platform/chromium-mac/fast/block/positioning/auto/vertical-lr/007-expected.png:
platform/chromium-mac/fast/block/positioning/auto/vertical-rl/007-expected.png:
platform/chromium-mac/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Removed.
platform/chromium-mac/fast/block/positioning/negative-rel-position-expected.png: Removed.
platform/chromium-mac/fast/block/positioning/relative-overflow-block-expected.png: Removed.
platform/chromium-mac/fast/block/positioning/relative-overflow-replaced-expected.png:
platform/chromium-mac/fast/block/positioning/relative-overflow-replaced-float-expected.png:
platform/chromium-mac/fast/block/positioning/vertical-lr/002-expected.png: Removed.
platform/chromium-mac/fast/block/positioning/vertical-rl/002-expected.png: Removed.
platform/chromium-mac/fast/body-propagation/overflow/002-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/002-xhtml-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/003-declarative-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/003-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/003-xhtml-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/004-declarative-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/004-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/004-xhtml-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/006-declarative-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/006-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/006-xhtml-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/007-declarative-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/007-expected.png:
platform/chromium-mac/fast/body-propagation/overflow/007-xhtml-expected.png:
platform/chromium-mac/fast/borders/border-image-massive-scale-expected.png:
platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png:
platform/chromium-mac/fast/borders/border-image-scale-transform-expected.png:
platform/chromium-mac/fast/borders/border-image-scaled-expected.png:
platform/chromium-mac/fast/borders/inline-mask-overlay-image-expected.png:
platform/chromium-mac/fast/borders/rtl-border-01-expected.png:
platform/chromium-mac/fast/borders/rtl-border-02-expected.png:
platform/chromium-mac/fast/borders/rtl-border-03-expected.png:
platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
platform/chromium-mac/fast/box-sizing/box-sizing-expected.png: Removed.
platform/chromium-mac/fast/canvas/canvas-bg-expected.png:
platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
platform/chromium-mac/fast/clip/014-expected.png:
platform/chromium-mac/fast/css-generated-content/014-expected.png:
platform/chromium-mac/fast/css/005-expected.png:
platform/chromium-mac/fast/css/MarqueeLayoutTest-expected.png:
platform/chromium-mac/fast/css/bidi-override-in-anonymous-block-expected.png:
platform/chromium-mac/fast/css/border-height-expected.png: Removed.
platform/chromium-mac/fast/css/color-correction-backgrounds-and-text-expected.png:
platform/chromium-mac/fast/css/color-correction-on-background-image-expected.png:
platform/chromium-mac/fast/css/empty-pseudo-class-expected.png:
platform/chromium-mac/fast/css/first-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/first-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/hsl-color-expected.png:
platform/chromium-mac/fast/css/last-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/last-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/line-height-overflow-expected.png: Removed.
platform/chromium-mac/fast/css/nested-floating-relative-position-percentages-expected.png: Removed.
platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
platform/chromium-mac/fast/css/only-child-pseudo-class-expected.png:
platform/chromium-mac/fast/css/only-of-type-pseudo-class-expected.png:
platform/chromium-mac/fast/css/percentage-non-integer-expected.png:
platform/chromium-mac/fast/css/positioned-overflow-scroll-expected.png: Removed.
platform/chromium-mac/fast/css/word-space-extra-expected.png:
platform/chromium-mac/fast/dom/clone-node-dynamic-style-expected.png:
platform/chromium-mac/fast/dom/scroll-reveal-top-overflow-expected.png: Removed.
platform/chromium-mac/fast/dynamic/anchor-lock-expected.png: Removed.
platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
platform/chromium-mac/fast/encoding/utf-16-big-endian-expected.png:
platform/chromium-mac/fast/encoding/utf-16-little-endian-expected.png:
platform/chromium-mac/fast/events/pointer-events-2-expected.png:
platform/chromium-mac/fast/events/standalone-image-drag-to-editable-expected.png:
platform/chromium-mac/fast/flexbox/009-expected.png:
platform/chromium-mac/fast/flexbox/016-expected.png:
platform/chromium-mac/fast/flexbox/flex-hang-expected.png: Removed.
platform/chromium-mac/fast/forms/fieldset-align-expected.png:
platform/chromium-mac/fast/forms/form-hides-table-expected.png:
platform/chromium-mac/fast/forms/textAreaLineHeight-expected.png:
platform/chromium-mac/fast/frames/frame-scrolling-attribute-expected.png: Removed.
platform/chromium-mac/fast/frames/iframe-scrolling-attribute-expected.png:
platform/chromium-mac/fast/gradients/background-clipped-expected.png:
platform/chromium-mac/fast/gradients/css3-color-stop-units-expected.png:
platform/chromium-mac/fast/html/details-position-expected.png:
platform/chromium-mac/fast/images/gif-large-checkerboard-expected.png: Removed.
platform/chromium-mac/fast/inline-block/tricky-baseline-expected.png:
platform/chromium-mac/fast/inline/inline-borders-with-bidi-override-expected.png:
platform/chromium-mac/fast/inline/inline-continuation-borders-expected.png:
platform/chromium-mac/fast/inline/long-wrapped-line-expected.png: Removed.
platform/chromium-mac/fast/invalid/residual-style-expected.png:
platform/chromium-mac/fast/layers/overflow-scroll-auto-switch-expected.png: Removed.
platform/chromium-mac/fast/layers/scroll-rect-to-visible-expected.png:
platform/chromium-mac/fast/lists/001-expected.png:
platform/chromium-mac/fast/lists/001-vertical-expected.png:
platform/chromium-mac/fast/lists/008-expected.png:
platform/chromium-mac/fast/lists/008-vertical-expected.png:
platform/chromium-mac/fast/lists/li-br-expected.png: Removed.
platform/chromium-mac/fast/lists/ol-start-parsing-expected.png:
platform/chromium-mac/fast/lists/olstart-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-02-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-03-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-04-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-05-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-06-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-07-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png:
platform/chromium-mac/fast/media/mq-relative-constraints-09-expected.png:
platform/chromium-mac/fast/media/mq-width-absolute-01-expected.png:
platform/chromium-mac/fast/media/mq-width-absolute-02-expected.png:
platform/chromium-mac/fast/media/mq-width-absolute-03-expected.png:
platform/chromium-mac/fast/media/mq-width-absolute-04-expected.png:
platform/chromium-mac/fast/multicol/client-rects-expected.png:
platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Removed.
platform/chromium-mac/fast/multicol/column-rules-stacking-expected.png:
platform/chromium-mac/fast/multicol/columns-shorthand-parsing-expected.png: Removed.
platform/chromium-mac/fast/multicol/float-multicol-expected.png:
platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Removed.
platform/chromium-mac/fast/multicol/float-paginate-expected.png: Removed.
platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
platform/chromium-mac/fast/multicol/layers-split-across-columns-expected.png:
platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.png: Removed.
platform/chromium-mac/fast/multicol/positioned-with-constrained-height-expected.png: Removed.
platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png:
platform/chromium-mac/fast/multicol/span/anonymous-style-inheritance-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
platform/chromium-mac/fast/multicol/span/span-margin-collapsing-expected.png:
platform/chromium-mac/fast/multicol/table-vertical-align-expected.png:
platform/chromium-mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.png:
platform/chromium-mac/fast/multicol/vertical-lr/float-multicol-expected.png:
platform/chromium-mac/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-lr/float-paginate-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-lr/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.png:
platform/chromium-mac/fast/multicol/vertical-rl/float-multicol-expected.png:
platform/chromium-mac/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-rl/float-paginate-expected.png: Removed.
platform/chromium-mac/fast/multicol/vertical-rl/nested-columns-expected.png:
platform/chromium-mac/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Removed.
platform/chromium-mac/fast/overflow/002-expected.png:
platform/chromium-mac/fast/overflow/003-expected.png:
platform/chromium-mac/fast/overflow/005-expected.png: Removed.
platform/chromium-mac/fast/overflow/007-expected.png:
platform/chromium-mac/fast/overflow/008-expected.png:
platform/chromium-mac/fast/overflow/childFocusRingClip-expected.png:
platform/chromium-mac/fast/overflow/clip-rects-fixed-ancestor-expected.png:
platform/chromium-mac/fast/overflow/float-in-relpositioned-expected.png:
platform/chromium-mac/fast/overflow/hit-test-overflow-controls-expected.png:
platform/chromium-mac/fast/overflow/image-selection-highlight-expected.png:
platform/chromium-mac/fast/overflow/overflow-auto-position-absolute-expected.png:
platform/chromium-mac/fast/overflow/overflow-auto-table-expected.png:
platform/chromium-mac/fast/overflow/overflow-rtl-expected.png:
platform/chromium-mac/fast/overflow/overflow-rtl-vertical-expected.png:
platform/chromium-mac/fast/overflow/overflow-stacking-expected.png:
platform/chromium-mac/fast/overflow/overflow-text-hit-testing-expected.png:
platform/chromium-mac/fast/overflow/overflow-update-transform-expected.png:
platform/chromium-mac/fast/overflow/overflow-with-local-background-attachment-expected.png:
platform/chromium-mac/fast/overflow/position-fixed-transform-clipping-expected.png:
platform/chromium-mac/fast/overflow/scrollbar-position-update-expected.png:
platform/chromium-mac/fast/overflow/table-overflow-float-expected.png:
platform/chromium-mac/fast/overflow/unreachable-overflow-rtl-bug-expected.png: Removed.
platform/chromium-mac/fast/repaint/block-selection-gap-stale-cache-2-expected.png:
platform/chromium-mac/fast/repaint/fixed-expected.png:
platform/chromium-mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png:
platform/chromium-mac/fast/repaint/fixed-tranformed-expected.png:
platform/chromium-mac/fast/repaint/moving-shadow-on-container-expected.png:
platform/chromium-mac/fast/repaint/overflow-scroll-body-appear-expected.png:
platform/chromium-mac/fast/repaint/repaint-during-scroll-expected.png:
platform/chromium-mac/fast/repaint/select-option-background-color-expected.png:
platform/chromium-mac/fast/repaint/selection-gap-overflow-scroll-2-expected.png:
platform/chromium-mac/fast/replaced/005-expected.png:
platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
platform/chromium-mac/fast/selectors/166-expected.png:
platform/chromium-mac/fast/table/023-expected.png: Removed.
platform/chromium-mac/fast/table/027-vertical-expected.png:
platform/chromium-mac/fast/table/028-vertical-expected.png: Removed.
platform/chromium-mac/fast/table/034-expected.png:
platform/chromium-mac/fast/table/038-vertical-expected.png:
platform/chromium-mac/fast/table/040-expected.png:
platform/chromium-mac/fast/table/040-vertical-expected.png:
platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png:
platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png:
platform/chromium-mac/fast/table/edge-offsets-expected.png:
platform/chromium-mac/fast/table/empty-cells-expected.png:
platform/chromium-mac/fast/table/height-percent-test-expected.png: Removed.
platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Removed.
platform/chromium-mac/fast/table/overflowHidden-expected.png:
platform/chromium-mac/fast/table/prepend-in-anonymous-table-expected.png:
platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Removed.
platform/chromium-mac/fast/table/wide-colspan-expected.png: Removed.
platform/chromium-mac/fast/table/wide-column-expected.png: Removed.
platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png:
platform/chromium-mac/fast/text/international/vertical-text-glyph-test-expected.png:
platform/chromium-mac/fast/text/large-text-composed-char-expected.png:
platform/chromium-mac/fast/text/softHyphen-expected.png: Removed.
platform/chromium-mac/fast/text/text-letter-spacing-expected.png:
platform/chromium-mac/fast/text/wbr-expected.png:
platform/chromium-mac/fast/text/whitespace/024-expected.png:
platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png:
platform/chromium-mac/fast/text/word-break-expected.png:
platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
platform/chromium-mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
platform/chromium-mac/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
platform/chromium-mac/fast/writing-mode/fallback-orientation-expected.png:
platform/chromium-mac/fast/writing-mode/fieldsets-expected.png:
platform/chromium-mac/fast/writing-mode/text-orientation-basic-expected.png:
platform/chromium-mac/fonts/cursive-expected.png:
platform/chromium-mac/fonts/default-expected.png:
platform/chromium-mac/fonts/fantasy-expected.png:
platform/chromium-mac/fonts/serif-expected.png:
platform/chromium-mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
platform/chromium-mac/media/video-controls-rendering-expected.png:
platform/chromium-mac/media/video-zoom-expected.png:
platform/chromium-mac/scrollbars/listbox-scrollbar-combinations-expected.png:
platform/chromium-mac/scrollbars/overflow-scrollbar-combinations-expected.png:
platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png:
platform/chromium-mac/svg/css/stars-with-shadow-expected.png:
platform/chromium-mac/svg/custom/altglyph-expected.png:
platform/chromium-mac/svg/custom/external-paintserver-reference-expected.png: Removed.
platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
platform/chromium-mac/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
platform/chromium-mac/svg/custom/invisible-text-after-scrolling-expected.png:
platform/chromium-mac/svg/custom/junk-data-expected.png:
platform/chromium-mac/svg/custom/linking-base-external-reference-expected.png: Removed.
platform/chromium-mac/svg/custom/missing-xlink-expected.png:
platform/chromium-mac/svg/custom/object-sizing-no-width-height-expected.png:
platform/chromium-mac/svg/custom/text-xy-updates-SVGList-expected.png: Removed.
platform/chromium-mac/svg/custom/use-font-face-crash-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png:
platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png:
platform/chromium-mac/svg/dom/SVGNumberList-basics-expected.png:
platform/chromium-mac/svg/dom/SVGPathSegList-appendItem-expected.png:
platform/chromium-mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png:
platform/chromium-mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png:
platform/chromium-mac/svg/dom/SVGPathSegList-removeItem-expected.png:
platform/chromium-mac/svg/dom/SVGPathSegList-replaceItem-expected.png:
platform/chromium-mac/svg/dom/SVGPointList-basics-expected.png:
platform/chromium-mac/svg/dom/SVGStringList-basics-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
platform/chromium-mac/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
platform/chromium-mac/svg/in-html/circle-expected.png:
platform/chromium-mac/svg/overflow: Removed.
platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
platform/chromium-mac/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Removed.
platform/chromium-mac/svg/text/kerning-expected.png:
platform/chromium-mac/svg/text/multichar-glyph-expected.png:
platform/chromium-mac/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
platform/chromium-mac/svg/zoom/page/relative-sized-document-scrollbars-expected.png:
platform/chromium-mac/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
platform/chromium-mac/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug101674-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug10269-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug10296-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug1055-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug113235-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug113235-3-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug11944-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug120364-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug137388-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug149275-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug22019-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug23151-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug2479-1-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug2479-4-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug29314-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug2947-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug32205-2-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug38916-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug43039-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug46480-1-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug46480-2-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug56405-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug5797-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug5835-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug625-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug650-expected.png: Removed.
platform/chromium-mac/tables/mozilla/bugs/bug73321-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug92143-expected.png:
platform/chromium-mac/tables/mozilla/bugs/bug96343-expected.png:
platform/chromium-mac/tables/mozilla/core/cell_heights-expected.png:
platform/chromium-mac/tables/mozilla/core/col_widths_auto_fix-expected.png:
platform/chromium-mac/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
platform/chromium-mac/tables/mozilla/core/nested1-expected.png:
platform/chromium-mac/tables/mozilla/core/one_row-expected.png:
platform/chromium-mac/tables/mozilla/marvin/backgr_index-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_td_height-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_td_nowrap-expected.png: Removed.
platform/chromium-mac/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_height-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_th_nowrap-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
platform/chromium-mac/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
platform/chromium-mac/tables/mozilla/other/nestedTables-expected.png:
platform/chromium-mac/tables/mozilla/other/test6-expected.png:
platform/chromium-mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.png:
platform/chromium-mac/tables/mozilla/other/wa_table_tr_align-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug101759-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug220653-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Removed.
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/core/backgrounds-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/core/col_span2-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/core/columns-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/core/conflicts-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/core/standards1-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
platform/chromium-mac/tables/mozilla_expected_failures/other/empty_cells-expected.png:
platform/chromium-mac/transforms/2d/transform-fixed-container-expected.png:

7:56 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

7:22 AM Changeset in webkit [97260] by yurys@chromium.org

2 edits in trunk/Source/WebCore

[v8] Use V8DOMWrapper::isWrapperOfType for determining global object type
https://bugs.webkit.org/show_bug.cgi?id=69923

Get rid of globalObjectPrototypeIsDOMWindow, use V8DOMWrapper::isWrapperOfType instead.

Reviewed by Pavel Feldman.

bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateV8Object):
(WebCore::V8DOMWrapper::getEventListener):

6:58 AM Changeset in webkit [97259] by kbalazs@webkit.org

2 edits in trunk/LayoutTests

[Qt][ARMv5] inspector/elements/edit-dom-actions.html and ~/elements-delete-inline-style.html times out
https://bugs.webkit.org/show_bug.cgi?id=69925

Unreviewed gardening.

platform/qt-arm/Skipped:

6:48 AM Changeset in webkit [97258] by yurys@chromium.org

2 edits in trunk/Source/WebCore

[Chromium] Web Inspector: assertion failure when evaluating expression in worker inspector console
https://bugs.webkit.org/show_bug.cgi?id=69922

Check that the global object is a DOMWindow wrapper befor casting it to V8DOMWindow.

Reviewed by Pavel Feldman.

bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::domWindow):

6:31 AM Changeset in webkit [97257] by caryclark@google.com

2 edits in trunk/Source/WebKit/chromium

[Chromium] Prevent fallback fonts from purging while measuring
https://bugs.webkit.org/show_bug.cgi?id=69855

Reviewed by Eric Seidel.

When Chrome computes the page width, an international page
may bring in a fallback font. FontCache::getCachedFontData
expects the font cache to be locked, so the measure path
needs to include an instance of FontCachePurgePreventer.

Adding FontCachePurgePreventer suppresses a debug-time assert
when running PageCycler over international tests.

src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::contentsPreferredWidth):

6:23 AM Changeset in webkit [97256] by podivilov@chromium.org

2 edits in trunk/Source/WebKit/chromium

2011-10-12 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, CCThreadTest.startPostAndWaitOnCondition is flaky on linux.

tests/CCThreadTest.cpp: (WebKit::TEST):

5:50 AM Changeset in webkit [97255] by hans@chromium.org

3 edits in branches/chromium/874/Source/WebCore/storage

Merge 96007 - IndexedDB: Null key path gets stored as empty string key path
https://bugs.webkit.org/show_bug.cgi?id=68726

Patch by Joshua Bell <jsbell@chromium.org> on 2011-09-26
Reviewed by Tony Chang.

Store additional flag to indicate if object store key path
is null vs. empty. Added additional runtime tests for integrity
of object store metadata.

storage/IDBLevelDBBackingStore.cpp:

(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBLevelDBBackingStore::getObjectStores):
(WebCore::IDBLevelDBBackingStore::createObjectStore):

storage/IDBLevelDBCoding.cpp:

TBR=commit-queue@webkit.org
Review URL: http://codereview.chromium.org/8242009

5:39 AM Changeset in webkit [97254] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-12

DEPS:

4:45 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

4:42 AM Changeset in webkit [97253] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing tests on WK2.

platform/qt-wk2/Skipped:

4:27 AM Changeset in webkit [97252] by Csaba Osztrogonác

4 edits
4 adds in trunk

new-run-webkit-tests does not support qt-4.8 results
https://bugs.webkit.org/show_bug.cgi?id=64071

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-10-12
Reviewed by Csaba Osztrogonác.

Tools:

Scripts/webkitpy/layout_tests/port/qt.py:
Scripts/webkitpy/layout_tests/port/qt_unittest.py:

LayoutTests:

platform/qt-4.7/Skipped: Added.
platform/qt-5.0/Skipped: Added.

2:58 AM Changeset in webkit [97251] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2011-10-12 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark fast/css/text-transform-select.html as IMAGE+TEXT on win.

platform/chromium/test_expectations.txt:

2:51 AM Changeset in webkit [97250] by podivilov@chromium.org

2 edits in trunk/LayoutTests

2011-10-12 Pavel Podivilov <podivilov@chromium.org>

Unreviewed, mark four js tests as failing after v8 roll.

platform/chromium/test_expectations.txt:

2:41 AM Changeset in webkit [97249] by yutak@chromium.org

2 edits in trunk/Source/WebCore

WebSocket: Update WebSocket protocol to hybi-17
https://bugs.webkit.org/show_bug.cgi?id=69910

Reviewed by Kent Tamura.

Essential changes between hybi-10 and hybi-17 are:

Sec-WebSocket-Origin header has been renamed to "Origin".
Sec-WebSocket-Version header value has been bumped to 13.

No new tests are necessary. pywebsocket has already been updated to the latest version
which understands the new protocol. Tests under http/tests/websocket/ should keep
passing.

websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

2:20 AM Changeset in webkit [97248] by Antti Koivisto

6 edits in trunk/Source/WebCore

Resolve regular and visited link style in a single pass
https://bugs.webkit.org/show_bug.cgi?id=69838

Reviewed by Darin Adler

We can simplify and speed up selector matching by removing the recursive matching done
to generate the style for the :visited pseudo selector. Both regular and visited link style
can be generated in a single pass through the style selector.

Make SelectorChecker::checkSelector to return both :visited and :link matches for all links.
For each selector statically determine and cache the link states it may match.
When applying the matched style declarations, apply them to the right RenderStyle (regular, visited, or both).

Statically determining which link state will be matched works since we only support :visited matching
based on the current element state (not ancestors or siblings).

A later patch will eliminate the separate RenderStyle for visited style completely and include the
few allowed properties to the regular RenderStyle.

css/CSSStyleSelector.cpp:

(WebCore::RuleData::linkMatchType):
(WebCore::RuleSet::linkPseudoClassRules):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::CSSStyleSelector::updateFont):
(WebCore::CSSStyleSelector::checkSelector):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addRule):
(WebCore::RuleSet::collectFeatures):
(WebCore::RuleSet::shrinkToFit):
(WebCore::CSSStyleSelector::applyDeclaration):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::CSSStyleSelector::applyProperty):
(WebCore::CSSStyleSelector::getColorFromPrimitiveValue):

css/CSSStyleSelector.h:

(WebCore::CSSStyleSelector::MatchedStyleDeclaration::MatchedStyleDeclaration):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker):
(WebCore::SelectorChecker::checkSelector):
(WebCore::SelectorChecker::fastCheckRightmostSelector):
(WebCore::SelectorChecker::fastCheckSelector):
(WebCore::SelectorChecker::checkOneSelector):
(WebCore::SelectorChecker::commonPseudoClassSelectorMatches):
(WebCore::SelectorChecker::determineLinkMatchType):

css/SelectorChecker.h:
rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::addCachedPseudoStyle):

2:14 AM Changeset in webkit [97247] by tkent@chromium.org

6 edits
6 adds
1 delete in trunk/LayoutTests

[Chromium] Update test expectations.

Update fast/forms/input-disabled-color.html, and remove an entry
for fast/forms/file/input-file-label.html.

platform/chromium-cg-mac-leopard/fast/forms/input-disabled-color-expected.png:
platform/chromium-cg-mac-snowleopard/fast/forms/input-disabled-color-expected.png: Added.
platform/chromium-linux/fast/forms/input-disabled-color-expected.png:
platform/chromium-mac-leopard/fast/forms/input-disabled-color-expected.png: Added.
platform/chromium-mac-snowleopard/fast/forms/input-disabled-color-expected.png: Added.
platform/chromium-mac/fast/forms/input-disabled-color-expected.png: Removed.
platform/chromium-win/fast/forms/input-disabled-color-expected.png:
platform/chromium-win/fast/forms/input-disabled-color-expected.txt:
platform/chromium/test_expectations.txt:

2:13 AM Changeset in webkit [97246] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: add test for pause in shared worker initialization
https://bugs.webkit.org/show_bug.cgi?id=69915

Add WebKit part of interactive ui test for pause in worker initialization.

Reviewed by Pavel Feldman.

src/js/Tests.js:

(.TestSuite.prototype.testPauseInSharedWorkerInitialization):

2:07 AM Changeset in webkit [97245] by yurys@chromium.org

2 edits in trunk/Source/WebKit/chromium

[Chromium] Web Inspector: repair interactive tests for debugger pause
https://bugs.webkit.org/show_bug.cgi?id=69912

Listen to DebuggerModel event instead of overriding private methods on it.

Reviewed by Pavel Feldman.

src/js/Tests.js:

(.TestSuite.prototype._waitForScriptPause):

2:07 AM Changeset in webkit [97244] by tkent@chromium.org

5 edits in trunk

REGRESSION(r94836): An assertion fails in HTMLFormControlElement::isValidFormControlElement
when HTMLInputElement::setValue() is called while the element is focused.
https://bugs.webkit.org/show_bug.cgi?id=69909

Reviewed by Ryosuke Niwa.

Source/WebCore:

setNeedsValidityCheck() should be called after the value update
and before any style recalculation. r94836 moved
setSelectionRange() call, and it recalculates the element style.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setValue): Move setNeedsValidityCheck() to setValueInternal().
(WebCore::HTMLInputElement::setValueInternal): Move setNeedsValidityCheck() from setValue().

LayoutTests:

fast/forms/input-live-pseudo-selectors-expected.txt:
fast/forms/resources/input-live-pseudo-selectors.js: Add a testcase for the bug.

1:58 AM QtWebKitBuildBots edited by Csaba Osztrogonác

Update Qt on 4.8.x trunk bot (diff)

1:39 AM Changeset in webkit [97243] by rgabor@webkit.org

2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

platform/qt-mac/Skipped: Skip new failing tests.

1:32 AM Changeset in webkit [97242] by mihnea@adobe.com

1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add myself to committers.

1:12 AM Changeset in webkit [97241] by rgabor@webkit.org

1 edit
4 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Add platform specific expected result for new tests.

platform/qt/fast/writing-mode/margins-expected.png: Added.
platform/qt/fast/writing-mode/margins-expected.txt: Added.
platform/qt/plugins/iframe-plugin-bgcolor-expected.png: Added.
platform/qt/plugins/iframe-plugin-bgcolor-expected.txt: Added.

1:01 AM Changeset in webkit [97240] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Layout tests crashing in DFG JIT code
https://bugs.webkit.org/show_bug.cgi?id=69897

Reviewed by Gavin Barraclough.

Abstract value filtration didn't take into account cases where a structure
set filter, combined with predicted type knowledge, could lead to a stronger
filter for the structure abstract value.

This bug would have been benign in release builds; it would have just meant
that the analysis was less precise and some optimization opportunities would
be missed. I have an ASSERT that is meant to catch such cases, and it was
triggering sporadically in one of the LayoutTests.

dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::filter):

12:50 AM BuildingQt5OnHarmattan edited by Simon Hausmann

(diff)

12:33 AM Changeset in webkit [97239] by tkent@chromium.org

3 edits in trunk/Source/WebCore

Build fixes for r97238.
https://bugs.webkit.org/show_bug.cgi?id=69828

GNUmakefile.list.am: Remove SelectElement.{cpp,h}.
dom/DOMAllInOne.cpp: Remove SelectElement.cpp.

12:14 AM Changeset in webkit [97238] by tkent@chromium.org

9 edits
2 deletes in trunk/Source/WebCore

Move the content of SelectElementData into HTMLSelectElement, and remove SelectElement.{cpp,h}
https://bugs.webkit.org/show_bug.cgi?id=69828

Reviewed by Darin Adler.

Move all of the data members of SelectElementData to

HTMLSelectElement, and their accessor functions are not needed
anymore.

Move SelectElementData::useMenuList() to HTMLSelectElement.

No new tests, just a refactoring.

CMakeLists.txt: Remove SelectElement.cpp.
WebCore.gypi: Remove SelectElement.{cpp,h}.
WebCore.pro: ditto.
WebCore.vcproj/WebCore.vcproj: ditto.
WebCore.xcodeproj/project.pbxproj: ditto.
dom/OptionElement.cpp: Remove a reference to SelectElement.h.
dom/SelectElement.cpp: Removed.
dom/SelectElement.h: Removed.
html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::HTMLSelectElement):
Initializes the moved data members.
(WebCore::HTMLSelectElement::formControlType):
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
(WebCore::HTMLSelectElement::activeSelectionStartListIndex):
(WebCore::HTMLSelectElement::activeSelectionEndListIndex):
(WebCore::HTMLSelectElement::parseMappedAttribute):
(WebCore::HTMLSelectElement::canSelectAll):
(WebCore::HTMLSelectElement::createRenderer):
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::menuListOnChange):
(WebCore::HTMLSelectElement::scrollToSelection):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::setRecalcListItems):
(WebCore::HTMLSelectElement::recalcListItemsInternal):
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
(WebCore::HTMLSelectElement::dispatchFocusEvent):
(WebCore::HTMLSelectElement::dispatchBlurEvent):
(WebCore::HTMLSelectElement::parseMultipleAttribute):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::typeAheadFind):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):

html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::size):
(WebCore::HTMLSelectElement::multiple):
(WebCore::HTMLSelectElement::usesMenuList):

12:09 AM Changeset in webkit [97237] by rniwa@webkit.org

2 edits in trunk/Source/WebCore

Chromium Mac build fix after r97227.

platform/chromium/ScrollbarThemeChromiumMac.mm:

(+[ScrollbarPrefsObserver appearancePrefsChanged:]):

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed