Timeline



Apr 13, 2013:

9:13 PM Changeset in webkit [148380] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix three crashes seen on the bots after "Make Frame's ScriptController an OwnPtr and remove the #include"

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
Check that the frame is not null (as it can be in cases like http/tests/xmlhttprequest/detaching-frame-2.html).
We used to be getting lucky, in that shouldBypassMainWorldContentSecurityPolicy(), the function that is ultimately
called, only operates on global state. Now that we need to actually dereference the Frame to get the ScriptController,
we see this crash.

9:06 PM Changeset in webkit [148379] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix attempt for webkitbot. Unicodify everything.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Whois.execute):

8:55 PM Changeset in webkit [148378] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Selection direction is not preserved when applying styles
https://bugs.webkit.org/show_bug.cgi?id=110979

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

The patch is based on the one submitted by Shezan Baig.

If the starting selection was directional and its base was not first,
switch newStart and newEnd when setting the ending direction. Otherwise,
leave the order unchanged.

Test: editing/style/preserve-selection-direction.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::updateStartEnd):

LayoutTests:

Add a test, based on the work by Shezan Baig

  • editing/style/preserve-selection-direction-expected.txt: Added.
  • editing/style/preserve-selection-direction.html: Added.
8:02 PM Changeset in webkit [148377] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Added svn:ignore for inspector/CodeGeneratorInspectorStrings.pyc

  • inspector: Added property svn:ignore.
7:12 PM Changeset in webkit [148376] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Add ObjC API for setting initialization data for the WKWebProcessPlugIn
https://bugs.webkit.org/show_bug.cgi?id=103846

Reviewed by Darin Adler.

  • UIProcess/API/mac/WKProcessGroup.h:

Adds a new optional processGroupWillCreateConnectionToWebProcessPlugIn: method for the WKProcessGroupDelegate protocol,
which allows the user to pass (via an autoreleased return value) initialization data to the web process plugin.

  • UIProcess/API/mac/WKProcessGroup.mm:

(getInjectedBundleInitializationUserData):
(setUpInectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):
(-[WKProcessGroup dealloc]):
Use the existing WKContextInjectedBundleClient infrastructure to pass the initialization data to the bundle
via the new ObjCObjectGraph APIObject.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:

Adds webProcessPlugIn:initializeWithObject: to the WKWebProcessPlugIn protocol, replacing webProcessPlugInInitialize:.

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):
Pass the initialization data to the web process plugin.

7:00 PM Changeset in webkit [148375] by ddkilzer@apple.com
  • 2 edits in branches/safari-536.30-branch/Source/JavaScriptCore

Attempt to fix Windows build after r148370

Try to fix the following build failure:

4>JSStringJoiner.cpp
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2653: 'CheckedState' : is not a class or namespace name
4>..\..\runtime\JSStringJoiner.cpp(112) : error C2065: 'DidOverflow' : undeclared identifier
4>..\..\runtime\JSStringJoiner.cpp(112) : warning C4805: '==' : unsafe mix of type 'bool' and type unknown-type in operation

  • runtime/JSStringJoiner.h: Include <wtf/CheckedArithmetic.h>.
6:27 PM Changeset in webkit [148374] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Attempt Build Fix.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
5:54 PM Changeset in webkit [148373] by weinig@apple.com
  • 88 edits in trunk/Source

Make Frame's ScriptController an OwnPtr and remove the #include
https://bugs.webkit.org/show_bug.cgi?id=114105

Reviewed by Dean Jackson.

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:
  • bindings/generic/BindingSecurity.cpp:
  • bindings/js/JSEventListener.cpp:
  • bindings/js/JSLazyEventListener.cpp:
  • bindings/js/PageScriptDebugServer.cpp:
  • bindings/js/ScriptEventListener.cpp:
  • bindings/js/ScriptState.cpp:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMAbstractView.mm:
  • bindings/objc/DOMInternal.mm:
  • dom/DocumentStyleSheetCollection.cpp:
  • dom/EventTarget.cpp:
  • dom/ScriptElement.cpp:
  • history/CachedFrame.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInImageElement.cpp:
  • html/parser/HTMLParserOptions.cpp:
  • inspector/InspectorAgent.cpp:
  • inspector/InspectorController.cpp:
  • inspector/InspectorFrontendClientLocal.cpp:
  • inspector/InspectorFrontendHost.cpp:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorOverlay.cpp:
  • inspector/InspectorPageAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • loader/DocumentWriter.cpp:
  • loader/NavigationScheduler.cpp:
  • loader/SubframeLoader.cpp:
  • loader/cache/CachedResourceLoader.cpp:
  • page/DOMWindow.cpp:
  • page/EventSource.cpp:
  • page/Frame.cpp:
  • page/Frame.h:
  • page/Navigator.cpp:
  • page/Page.cpp:
  • page/PageGroup.cpp:
  • xml/XMLHttpRequest.cpp:
  • xml/XMLTreeViewer.cpp:

Source/WebKit/mac:

  • Plugins/Hosted/HostedNetscapePluginStream.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebGeolocationClient.mm:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebView/WebFrame.mm:

Source/WebKit2:

  • Shared/WebHitTestResult.cpp:
  • Shared/WebHitTestResult.h:
  • UIProcess/Plugins/PlugInAutoStartProvider.cpp:
  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.h:
  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
  • WebProcess/Plugins/Netscape/NPJSObject.cpp:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PluginView.cpp:
  • WebProcess/Storage/StorageAreaImpl.cpp:
  • WebProcess/Storage/StorageAreaMap.cpp:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebPage.cpp:
5:46 PM Changeset in webkit [148372] by rniwa@webkit.org
  • 5 edits in trunk/Tools

webkitbot should provide full name, email address, and IRC nicknames on whois
https://bugs.webkit.org/show_bug.cgi?id=114494

Reviewed by Benjamin Poulain.

A response like the one below is useless. Improve it:
webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?

We now report full name, email address, committer/reviewer status, and IRC nickname.

Also teach webkitbot how to respond to ping.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(PingPong): Moved
(PingPong.execute):
(Whois._full_record_and_nick): Renamed and rewritten.
(Whois.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois): Updated test cases as needed.

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help): Added ping.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot): Teached WKR how to respond to hi.

5:28 PM Changeset in webkit [148371] by rniwa@webkit.org
  • 5 edits in trunk/Websites/bugs.webkit.org

Delete bubbles from webkit-commit-queue.appspot.com now that we've completed the transition
https://bugs.webkit.org/show_bug.cgi?id=114476

Reviewed by Gyuyoung Kim.

  • code-review.js:
  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
4:15 PM Changeset in webkit [148370] by ddkilzer@apple.com
  • 7 edits in branches/safari-536.30-branch

Merge 145580, 145587, 145594, r145595, r145647, 145759. Part 2/2 for <rdar://problem/13438603>.

4:15 PM Changeset in webkit [148369] by ddkilzer@apple.com
  • 2 edits
    1 add in branches/safari-536.30-branch/Source/WTF

Merge r141499, r141950, r141965. Part 1/2 for <rdar://problem/13438603>.

Add Source/WTF/wtf/EnumClass.h

3:28 PM Changeset in webkit [148368] by andersca@apple.com
  • 14 edits
    1 add in trunk

Add form delegate method that's invoked right before sending a submit event to a form element
https://bugs.webkit.org/show_bug.cgi?id=114575

Reviewed by Dan Bernstein.

Source/WebCore:

  • WebCore.exp.in:

Export a symbol.

  • WebCore.xcodeproj/project.pbxproj:

Make DOMHTMLFormElementInternal.h a private header.

Source/WebKit/mac:

  • MigrateHeaders.make:

Copy DOMHTMLFormElementInternal.h over to WebKit.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(makeFormFieldValuesDictionary):
New helper function that returns the values of a form in dictionary form.

(WebFrameLoaderClient::dispatchWillSendSubmitEvent):
Call the right delegate method.

(WebFrameLoaderClient::dispatchWillSubmitForm):
Use the helper function.

  • WebView/WebDelegateImplementationCaching.h:
  • WebView/WebDelegateImplementationCaching.mm:

(CallFormDelegate):
Add another overload.

  • WebView/WebFormDelegate.h:
  • WebView/WebFormDelegate.m:

(-[WebFormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
Add a default implementation.

Tools:

Add a test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.

(-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
(TestWebKitAPI):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/mac/PlatformUtilitiesMac.mm:

(TestWebKitAPI::Util::toSTD):
Don't crash when a null NSString is passed to toSTD.

3:01 PM Changeset in webkit [148367] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Whitespace between nowrap elements ignored after collapsed trailing space in a text run
https://bugs.webkit.org/show_bug.cgi?id=17705

Reviewed by Ryosuke Niwa.

Source/WebCore:

Bug 93448 and r138654 fixed the treatment of line-breaks between nowrap elements. This augments
that fix by recognizing that we have a potential break not only in situations where the next character is a
space and the current character is not, but also where the next character is a space and the current character
*is* a space *and* we are ignoring spaces. This is so because any spaces we have ignored up to this point
after the actual word end will get collapsed away even if we don't end up taking the line break.

In a nutshell, if we allow whitespace collapsing 'word ' and 'word' are equivalent when before a whitespace
character, so treat the first as well as the second as a potential linebreak.

Test: fast/text/whitespace/inline-whitespace-wrapping-5.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/inline-whitespace-wrapping-5-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-5.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-6-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-6.html: Added.
2:49 PM Changeset in webkit [148366] by Lucas Forschler
  • 4 edits
    3 copies in branches/safari-536.30-branch

Merged r136845. <rdar://problem/13334927>

2:11 PM QtWebKit edited by V字龍
Add QupZilla Web Browser which also uses QtWebKit (diff)
1:03 PM Changeset in webkit [148365] by akling@apple.com
  • 19 edits in trunk/Source

Rename/tweak some StylePropertySet/CSSStyleDeclaration copying functions.
<http://webkit.org/b/114569>

Reviewed by Anders Carlsson.

  • StylePropertySet::copy() -> mutableCopy()

This function now returns a MutableStylePropertySet, and this is also reflected in the name.

  • CSSStyleDeclaration::copy() -> copyProperties()

Renamed to reflect that it's the properties being copied, not the CSSStyleDeclaration.
They also now return MutableStylePropertySets.

  • StylePropertySet::copyPropertiesInSet()
  • CSSStyleDeclaration::copyPropertiesInSet()

These functions now return MutableStylePropertySets.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::copyProperties):
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):

  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::copyProperties):

  • css/PropertySetCSSStyleDeclaration.h:
  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::mutableCopy):
(WebCore::StylePropertySet::copyPropertiesInSet):

  • css/StylePropertySet.h:

(StylePropertySet):

  • css/StyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRulePage::StyleRulePage):
(WebCore::StyleRulePage::mutableProperties):
(WebCore::StyleRuleFontFace::StyleRuleFontFace):
(WebCore::StyleRuleFontFace::mutableProperties):
(WebCore::StyleRuleViewport::StyleRuleViewport):
(WebCore::StyleRuleViewport::mutableProperties):
(WebCore::StyleRuleFilter::StyleRuleFilter):
(WebCore::StyleRuleFilter::mutableProperties):

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::addViewportRule):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::mutableProperties):

  • dom/Element.cpp:

(WebCore::UniqueElementData::UniqueElementData):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::ensureMutableInlineStyle):

  • editing/ApplyStyleCommand.cpp:

(WebCore::copyStyleOrCreateEmpty):

  • editing/EditingStyle.cpp:

(WebCore::copyEditingProperties):
(WebCore::editingStyleFromComputedStyle):
(WebCore::EditingStyle::EditingStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::copy):
(WebCore::EditingStyle::mergeStyle):
(WebCore::getPropertiesNotIn):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::copyTypingStyle):

11:19 AM Changeset in webkit [148364] by Lucas Forschler
  • 8 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r147512. <rdar://problem/13380323>

11:00 AM Changeset in webkit [148363] by krit@webkit.org
  • 11 edits
    2 moves in trunk/Source/WebCore

Rename StyleBuilder to DeprecatedStyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=114532

Reviewed by Benjamin Poulain.

The StyleBuilder code is hard to read and maintain. People should
not add new properties to this class. To make this clear, this
patch renames the class to DeprecatedStyleBuilder.

Pure refactoring, no change in functionality.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/DeprecatedStyleBuilder.cpp: Renamed from Source/WebCore/css/StyleBuilder.cpp.
  • css/DeprecatedStyleBuilder.h: Renamed from Source/WebCore/css/StyleBuilder.h.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(StyleResolver):

  • rendering/style/RenderStyle.h:
10:56 AM Changeset in webkit [148362] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Python test fix attempt after r148360.

  • Scripts/webkitpy/tool/multicommandtool_unittest.py:

(test_command_help):

10:53 AM Changeset in webkit [148361] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Update Mac WebKit2 test expectations for flaky and failing tests.

  • platform/mac-wk2/TestExpectations:
10:39 AM Changeset in webkit [148360] by rniwa@webkit.org
  • 19 edits in trunk/Tools

Merge AbstractDeclarativeCommand into Command as a comment suggests
https://bugs.webkit.org/show_bug.cgi?id=114559

Reviewed by Antti Koivisto.

Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
We need to merge a lot more classes to make webkitpy hackable.

  • Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:

(AbstractLocalServerCommand):
(AbstractLocalServerCommand.init):

  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand):
(AbstractSequencedCommand.init):

  • Scripts/webkitpy/tool/commands/adduserstogroups.py:

(AddUsersToGroups):

  • Scripts/webkitpy/tool/commands/analyzechangelog.py:

(AnalyzeChangeLog):
(AnalyzeChangeLog.init):

  • Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
  • Scripts/webkitpy/tool/commands/bugfortest.py:

(BugForTest):

  • Scripts/webkitpy/tool/commands/bugsearch.py:

(BugSearch):

  • Scripts/webkitpy/tool/commands/chromechannels.py:

(ChromeChannels):
(init):

  • Scripts/webkitpy/tool/commands/download.py:

(AbstractPatchProcessingCommand):

  • Scripts/webkitpy/tool/commands/findusers.py:

(FindUsers):

  • Scripts/webkitpy/tool/commands/openbugs.py:

(OpenBugs):

  • Scripts/webkitpy/tool/commands/queries.py:

(BugsToCommit):
(PatchesInCommitQueue):
(PatchesToCommitQueue):
(PatchesToCommitQueue.init):
(PatchesToReview):
(PatchesToReview.init):
(PatchesToReview.execute):
(WhatBroke):
(ResultsFor):
(FailureReason):
(FindFlakyTests):
(TreeStatus):
(CrashLog):
(PrintExpectations):
(PrintExpectations.init):
(PrintBaselines):
(PrintBaselines.init):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.init):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractRebaseliningCommand):

  • Scripts/webkitpy/tool/commands/suggestnominations.py:

(SuggestNominations):
(SuggestNominations.init):

  • Scripts/webkitpy/tool/commands/upload.py:

(CommitMessageForCurrentDiff):
(CommitMessageForCurrentDiff.init):
(CleanPendingCommit):
(CleanReviewQueue):
(AssignToCommitter):
(PostCommits):
(PostCommits.init):
(MarkBugFixed):
(MarkBugFixed.init):
(CreateBug):
(CreateBug.init):

  • Scripts/webkitpy/tool/multicommandtool.py:

(Command):
(Command.init):
(Command.main):
(HelpCommand):
(HelpCommand.init):

  • Scripts/webkitpy/tool/multicommandtool_unittest.py:

(TrivialCommand):
(TrivialCommand.init):
(LikesToRetry):
(LikesToRetry.init):
(CommandTest.test_name_with_arguments):
(CommandTest.test_required_arguments):
(test_command_help):

9:43 AM Changeset in webkit [148359] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Remove unused method CSSStyleDeclaration::makeMutable().
<http://webkit.org/b/114567>

Reviewed by Anders Carlsson.

  • css/CSSComputedStyleDeclaration.cpp:
  • css/CSSComputedStyleDeclaration.h:

(CSSComputedStyleDeclaration):

  • css/CSSStyleDeclaration.h:

(CSSStyleDeclaration):

  • css/PropertySetCSSStyleDeclaration.cpp:
  • css/PropertySetCSSStyleDeclaration.h:
9:38 AM Changeset in webkit [148358] by Antoine Quint
  • 3 edits
    2 adds in trunk

Width of last of consecutive tabs may be incorrect with "white-space: pre-wrap"
https://bugs.webkit.org/show_bug.cgi?id=114562

Reviewed by Dan Bernstein.

Source/WebCore:

When we measure the last word of a RenderText, make sure we use the correct x
position taking into account the current accumulated word measurements up to
this character. This is of particular importance in the case of tabs where the
measured width would differ based on the x position.

Test: fast/text/tab-last-word-in-renderer-pre-wrap.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests:

  • fast/text/tab-last-word-in-renderer-pre-wrap-expected.html: Added.
  • fast/text/tab-last-word-in-renderer-pre-wrap.html: Added.
9:07 AM Changeset in webkit [148357] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] ImageBufferCairo.cpp fails to compile after 148247, 148264.
https://bugs.webkit.org/show_bug.cgi?id=114540

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-13
Reviewed by Brent Fulgham.

  • platform/graphics/cairo/ImageBufferCairo.cpp:
7:09 AM Changeset in webkit [148356] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add missing export macro to SymbolTableEntry::freeFatEntrySlow()

  • runtime/SymbolTable.h:

(SymbolTableEntry):

5:04 AM Changeset in webkit [148355] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
https://bugs.webkit.org/show_bug.cgi?id=114048

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-13
Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Wrapped view-mode media related code into #if ENABLE(VIEW_MODE_CSS_MEDIA)

  • WebCoreSupport/AssertMatchingEnums.cpp:
  • ewk/ewk_view.cpp:

(ewk_view_mode_set):

Tools:

Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::setViewModeMediaFeature):

2:47 AM Changeset in webkit [148354] by rniwa@webkit.org
  • 2 edits
    2 deletes in trunk/Tools

Merge watchlistloader into host since it's an unnecessary indirection
https://bugs.webkit.org/show_bug.cgi?id=114555

Reviewed by Antti Koivisto.

We don't need a class to load a file.

  • Scripts/webkitpy/common/host.py:

(Host.watch_list):

  • Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
  • Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
1:16 AM Changeset in webkit [148353] by rniwa@webkit.org
  • 4 edits in trunk/Tools

Rename JSONResultsGeneratorBase to JSONResultsGenerator
https://bugs.webkit.org/show_bug.cgi?id=114553

Reviewed by Philippe Normand.

Renamed now that we've got rid of the old JSONResultsGenerator in r148352.

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

(JSONGeneratorTest._test_json_generation):
(JSONGeneratorTest._verify_json_results):

1:02 AM Changeset in webkit [148352] by rniwa@webkit.org
  • 8 edits in trunk/Tools

Remove more Chromium specific code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114552

Reviewed by Philippe Normand.

  • Scripts/webkitpy/common/host.py:

(Host.checkout):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase):
(JSONResultsGeneratorBase.init):
(JSONResultsGeneratorBase._is_results_all_of_type):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port):
(Port.expected_filename):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old):
(CommitQueue.did_pass_testing_ews):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(RebaselineTest._results_url):
(Rebaseline._builder_with_name):

  • Scripts/webkitpy/tool/mocktool.py:

(MockTool.irc):

12:56 AM Changeset in webkit [148351] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r148311.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(resizeWebKitWebViewBaseFromAllocation): Passing IntSize() as the scroll offset
argument to the DrawingAreaProxy::setSize method.

12:53 AM Changeset in webkit [148350] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Fix release build.

  • dfg/DFGOSRExitCompilerCommon.cpp:
  • ftl/FTLExitValue.cpp:
  • ftl/FTLOSRExitCompiler.cpp:
12:40 AM Changeset in webkit [148349] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

Fix flakiness dashboard unit test failures
https://bugs.webkit.org/show_bug.cgi?id=114518

Reviewed by Ryosuke Niwa.

Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
test cases to simulate loading the builders list from the webkit.org build master, replacing
the Chromium builders and platforms that are used in tests with builders and platforms for the
Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
functionality of the dashboard.

This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
code and hopefully general simplification of the dashboard codebase coming in near future.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(resetGlobals):
(test):

  • TestResultServer/static-dashboards/loader_unittests.js:
12:38 AM Changeset in webkit [148348] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r148305.

  • GNUmakefile.list.am: Adding the TrackListBase build targets to the build.
12:38 AM Changeset in webkit [148347] by fpizlo@apple.com
  • 35 edits
    26 adds in branches/dfgFourthTier/Source

fourthTier: FTL should have OSR exit
https://bugs.webkit.org/show_bug.cgi?id=113623

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This implements OSR exit, and hilariously, it actually works. The idea is to have
LLVM call a no-return function on the off-ramp, passing it everything we know about
bytecode state that isn't already flushed to the call frame. Our own JIT takes care
of the rest.

We can now run all of SunSpider, V8, and Kraken with the FTL enabled.

The details are described in FTLOSRExit.h.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • assembler/AbstractMacroAssembler.h:

(Address):
(JSC::AbstractMacroAssembler::Address::withOffset):

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::offsetOf):
(LinkBuffer):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::~RepatchBuffer):
(RepatchBuffer):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/Operands.h:

(Operands):
(JSC):
(JSC::::dump):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::initialize):

  • dfg/DFGGPRInfo.h:

(DFG):
(GPRInfo):

  • dfg/DFGMinifiedNode.h:

(JSC::DFG::belongsInMinifiedGraph):

  • dfg/DFGNodeType.h:

(JSC::DFG::needsOSRBackwardRewiring):
(DFG):
(JSC::DFG::needsOSRForwardRewiring):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(DFG):
(JSC::DFG::OSRExit::convertToForward):

  • dfg/DFGOSRExit.h:

(OSRExit):

  • dfg/DFGOSRExitBase.cpp: Added.

(DFG):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):
(JSC::DFG::OSRExitBase::doSearchForForwardConversion):

  • dfg/DFGOSRExitBase.h: Added.

(DFG):
(JSC::DFG::OSRExitBase::OSRExitBase):
(OSRExitBase):
(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGOSRExitCompilerCommon.h:

(DFG):

  • dfg/DFGOSRExitPreparation.cpp: Added.

(DFG):
(JSC::DFG::prepareCodeOriginForOSRExit):

  • dfg/DFGOSRExitPreparation.h: Added.

(DFG):

  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArgumentTypes):

  • dfg/DFGValueSource.h:

(JSC::DFG::ValueSource::forSpeculation):

  • dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::reconstruct):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::functionType):
(FTL):
(JSC::FTL::typeOf):
(JSC::FTL::appendBasicBlock):
(JSC::FTL::insertBasicBlock):
(JSC::FTL::buildCall):
(JSC::FTL::setTailCall):

  • ftl/FTLCArgumentGetter.cpp: Added.

(FTL):
(JSC::FTL::CArgumentGetter::loadNextAndBox):

  • ftl/FTLCArgumentGetter.h: Added.

(FTL):
(JSC::FTL::isArgumentRegister):
(CArgumentGetter):
(JSC::FTL::CArgumentGetter::CArgumentGetter):
(JSC::FTL::CArgumentGetter::loadNext8):
(JSC::FTL::CArgumentGetter::loadNext32):
(JSC::FTL::CArgumentGetter::loadNext64):
(JSC::FTL::CArgumentGetter::loadNextPtr):
(JSC::FTL::CArgumentGetter::loadNextDouble):
(JSC::FTL::CArgumentGetter::nextAddress):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLExitArgument.cpp: Added.

(FTL):
(JSC::FTL::ExitArgument::dump):

  • ftl/FTLExitArgument.h: Added.

(FTL):
(ExitArgumentRepresentation):
(ExitArgument):
(JSC::FTL::ExitArgument::ExitArgument):
(JSC::FTL::ExitArgument::operator!):
(JSC::FTL::ExitArgument::format):
(JSC::FTL::ExitArgument::argument):
(JSC::FTL::ExitArgument::withFormat):
(JSC::FTL::ExitArgument::representation):

  • ftl/FTLExitArgumentForOperand.cpp: Added.

(FTL):
(JSC::FTL::ExitArgumentForOperand::dump):

  • ftl/FTLExitArgumentForOperand.h: Added.

(FTL):
(ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::ExitArgumentForOperand):
(JSC::FTL::ExitArgumentForOperand::operator!):
(JSC::FTL::ExitArgumentForOperand::exitArgument):
(JSC::FTL::ExitArgumentForOperand::operand):
(JSC::FTL::lesserArgumentIndex):

  • ftl/FTLExitArgumentList.h: Added.

(FTL):

  • ftl/FTLExitThunkGenerator.cpp: Added.

(FTL):
(JSC::FTL::ExitThunkGenerator::ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::~ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::emitThunk):

  • ftl/FTLExitThunkGenerator.h: Added.

(FTL):
(ExitThunkGenerator):
(JSC::FTL::ExitThunkGenerator::didThings):

  • ftl/FTLExitValue.cpp: Added.

(FTL):
(JSC::FTL::ExitValue::dump):

  • ftl/FTLExitValue.h: Added.

(FTL):
(ExitValue):
(JSC::FTL::ExitValue::ExitValue):
(JSC::FTL::ExitValue::operator!):
(JSC::FTL::ExitValue::dead):
(JSC::FTL::ExitValue::inJSStack):
(JSC::FTL::ExitValue::inJSStackAsInt32):
(JSC::FTL::ExitValue::inJSStackAsDouble):
(JSC::FTL::ExitValue::constant):
(JSC::FTL::ExitValue::exitArgument):
(JSC::FTL::ExitValue::kind):
(JSC::FTL::ExitValue::isDead):
(JSC::FTL::ExitValue::isInJSStackSomehow):
(JSC::FTL::ExitValue::isConstant):
(JSC::FTL::ExitValue::isArgument):

  • ftl/FTLFormattedValue.h:

(FTL):
(JSC::FTL::noValue):
(JSC::FTL::int32Value):
(JSC::FTL::uInt32Value):
(JSC::FTL::booleanValue):
(JSC::FTL::jsValueValue):
(JSC::FTL::doubleValue):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::initializeExitThunks):
(FTL):
(JSC::FTL::JITCode::exitThunks):

  • ftl/FTLJITCode.h:

(JITCode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(FTL):
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::transferAndCheckArguments):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileMovHint):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileMovHintAndCheck):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::speculateBackward):
(JSC::FTL::LowerDFGToLLVM::speculateForward):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::backwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::forwardTypeCheck):
(JSC::FTL::LowerDFGToLLVM::typeCheck):
(JSC::FTL::LowerDFGToLLVM::appendTypeCheck):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::speculateObject):
(JSC::FTL::LowerDFGToLLVM::isLive):
(JSC::FTL::LowerDFGToLLVM::use):
(JSC::FTL::LowerDFGToLLVM::initializeOSRExitStateForBlock):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):
(JSC::FTL::LowerDFGToLLVM::addExitArgument):
(JSC::FTL::LowerDFGToLLVM::linkOSRExitsAndCompleteInitializationBlocks):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):

  • ftl/FTLOSRExit.cpp: Added.

(FTL):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::convertToForward):

  • ftl/FTLOSRExit.h: Added.

(FTL):
(OSRExit):

  • ftl/FTLOSRExitCompilationInfo.h: Added.

(FTL):
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
(OSRExitCompilationInfo):

  • ftl/FTLOSRExitCompiler.cpp: Added.

(FTL):
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):

  • ftl/FTLOSRExitCompiler.h: Added.

(FTL):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::intToPtr):
(JSC::FTL::Output::load):
(JSC::FTL::Output::store):
(Output):
(JSC::FTL::Output::call):
(JSC::FTL::Output::convertToTailCall):
(FTL):

  • ftl/FTLState.h:

(State):

  • ftl/FTLThunks.cpp: Added.

(FTL):
(JSC::FTL::osrExitGenerationThunkGenerator):

  • ftl/FTLThunks.h: Added.

(JSC):
(FTL):

  • ftl/FTLValueFormat.cpp: Added.

(WTF):
(WTF::printInternal):

  • ftl/FTLValueFormat.h: Added.

(FTL):
(WTF):

  • ftl/FTLValueSource.cpp: Added.

(FTL):
(JSC::FTL::ValueSource::dump):

  • ftl/FTLValueSource.h: Added.

(FTL):
(ValueSource):
(JSC::FTL::ValueSource::ValueSource):
(JSC::FTL::ValueSource::kind):
(JSC::FTL::ValueSource::operator!):
(JSC::FTL::ValueSource::node):

Source/WTF:

Reviewed by Oliver Hunt.

Finally make toCString() somewhat variadic.

  • wtf/StringPrintStream.h:

(WTF):
(WTF::toCString):

Apr 12, 2013:

9:39 PM Changeset in webkit [148346] by rniwa@webkit.org
  • 2 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r148284. <rdar://problem/13335003>

9:23 PM Changeset in webkit [148345] by rniwa@webkit.org
  • 3 edits in branches/safari-536.30-branch/Source/WebCore

Merged 140893. <rdar://problem/13334946>

9:18 PM Changeset in webkit [148344] by rniwa@webkit.org
  • 5 edits in branches/safari-536.30-branch/Source/WebCore

Merged r141315. <rdar://problem/13334946>

9:15 PM Changeset in webkit [148343] by rniwa@webkit.org
  • 4 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140886. <rdar://problem/13334946>

8:52 PM Changeset in webkit [148342] by rniwa@webkit.org
  • 8 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140892. <rdar://problem/13334946>

8:15 PM Changeset in webkit [148341] by rniwa@webkit.org
  • 4 edits in branches/safari-536.30-branch/Source/WebCore

Merged r140891. <rdar://problem/13334946>

8:09 PM Changeset in webkit [148340] by rniwa@webkit.org
  • 9 edits
    2 copies in branches/safari-536.30-branch

Merged r140748. <rdar://problem/13334946>

7:38 PM Changeset in webkit [148339] by rniwa@webkit.org
  • 2 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r141445. <rdar://problem/13266396>

7:32 PM Changeset in webkit [148338] by rniwa@webkit.org
  • 2 edits in branches/safari-536.30-branch/Source/WebKit2

Merged r141445. <rdar://problem/13335003>

7:08 PM Changeset in webkit [148337] by Lucas Forschler
  • 1 edit
    2 copies in branches/safari-536.30-branch/LayoutTests

Merged r136596. <rdar://problem/13334868>

7:02 PM Changeset in webkit [148336] by Lucas Forschler
  • 2 edits
    6 copies in branches/safari-536.30-branch/LayoutTests

Merged r133701. <rdar://problem/13334976>

7:00 PM Changeset in webkit [148335] by Lucas Forschler
  • 2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r129814. <rdar://problem/13334978>

6:52 PM Changeset in webkit [148334] by Lucas Forschler
  • 5 edits in branches/safari-536.30-branch/LayoutTests

Merged r128747. <rdar://problem/13266379>

6:47 PM Changeset in webkit [148333] by Lucas Forschler
  • 3 edits in branches/safari-536.30-branch/LayoutTests

Merged r123167. <rdar://problem/13266379>

6:44 PM Changeset in webkit [148332] by roger_fong@apple.com
  • 3 edits in branches/safari-536.30-branch/Source/WebCore

Merged r143565, <rdar://problem/13334867>

6:37 PM Changeset in webkit [148331] by barraclough@apple.com
  • 7 edits in trunk/Source/WebKit2

Add private interface to WKView to asynchronously update the drawing area size
https://bugs.webkit.org/show_bug.cgi?id=114549

Reviewed by Simon Fraser.

This will allow a client using the WKView to resize the contents without blocking waiting for the web process to repaint.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _setDrawingAreaSize:]):

  • if the new size of teh drawing area does not match the frame size, position it according to the contentAnchor.

(-[WKView updateLayer]):

  • Don't let a subsequent frame size change block on a prior async resize.

(-[WKView forceAsyncDrawingAreaSizeUpdate:]):

  • resize the drawing area asynchronously, even if frame size udpates are disabled.

(-[WKView waitForAsyncDrawingAreaSizeUpdate]):

  • wait for asynchronous updates to complete.
  • UIProcess/API/mac/WKViewPrivate.h:
    • declare new methods.
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit):

  • UIProcess/DrawingAreaProxy.h:

(DrawingAreaProxy):
(WebKit::DrawingAreaProxy::waitForPossibleGeometryUpdate):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForPossibleGeometryUpdate):

  • pass timeout for waitForPossibleGeometryUpdate as a parameter.
6:25 PM Changeset in webkit [148330] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

32-bit build fix.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):

6:09 PM Changeset in webkit [148329] by jpfau@apple.com
  • 8 edits in trunk

Query directly for cache partition names
https://bugs.webkit.org/show_bug.cgi?id=114538

Reviewed by David Kilzer.

Source/WebKit2:

Call back into WebKitSystemInterface to ask it for the cache
partition names instead of trying to figure them out.

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::getCacheOrigins):
(WebKit):
(WebKit::WebResourceCacheManager::returnCacheOrigins):

  • WebProcess/ResourceCache/WebResourceCacheManager.h:

(WebResourceCacheManager):

  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit):
(WebKit::WebResourceCacheManager::cfURLCacheHostNamesWithCallback):

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
6:02 PM Changeset in webkit [148328] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS

Reviewed by Chris Fleizach.

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare

-_accessibilityPath from the WebAccessibilityObjectWrapper
class.
(_CGPathEnumerationIteration): Remove unused CGPoint* variable.

5:55 PM Changeset in webkit [148327] by timothy_horton@apple.com
  • 5 edits
    2 adds in branches/safari-536.30-branch

Merge r132856. <rdar://problem/13334380>

5:49 PM Changeset in webkit [148326] by timothy_horton@apple.com
  • 4 edits
    2 adds in branches/safari-536.30-branch

Merge r131488. <rdar://problem/13334380>

5:46 PM Changeset in webkit [148325] by rniwa@webkit.org
  • 3 edits
    2 copies in branches/safari-536.30-branch

Merged r130717. <rdar://problem/13334846>

5:37 PM Changeset in webkit [148324] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix - too soon!

  • UIProcess/API/mac/WKViewPrivate.h:
5:33 PM Changeset in webkit [148323] by roger_fong@apple.com
  • 5 edits in trunk/Source/WebCore

Update AVFoundationCF code following http://trac.webkit.org/changeset/148291.
https://bugs.webkit.org/show_bug.cgi?id=114548.

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:

(MediaPlayerPrivateAVFoundationCF):

5:15 PM Changeset in webkit [148322] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix - too soon!

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):

5:15 PM Changeset in webkit [148321] by rniwa@webkit.org
  • 2 edits in branches/safari-536.30-branch/Source/WebCore

Merged r136619. <rdar://problem/13335066>

5:09 PM Changeset in webkit [148320] by rniwa@webkit.org
  • 5 edits in branches/safari-536.30-branch

Merged r117463. <rdar://problem/13335066>

5:03 PM Changeset in webkit [148319] by Lucas Forschler
  • 2 edits
    2 deletes in branches/safari-536.30-branch/LayoutTests

Merged r138692. <rdar://problem/13334855>

4:58 PM Changeset in webkit [148318] by Lucas Forschler
  • 1 edit
    4 copies
    3 adds
    1 delete in branches/safari-536.30-branch/LayoutTests

Merged r138686. <rdar://problem/13334855>

4:55 PM Changeset in webkit [148317] by jpfau@apple.com
  • 2 edits in trunk/Tools

Unreviewed, remove an old email address for myself.

  • Scripts/webkitpy/common/config/committers.py:
4:47 PM Changeset in webkit [148316] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Demystify some code in RenderLayer::updateScrollableAreaSet()
https://bugs.webkit.org/show_bug.cgi?id=114543

Reviewed by Tim Horton.

Clean up some code that called functions with important side effects
inside a ternary operator, and clean up the #ifdefs.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollableAreaSet):

4:46 PM Changeset in webkit [148315] by Lucas Forschler
  • 7 edits
    15 copies
    2 deletes in branches/safari-536.30-branch

Merged r138654. <rdar://problem/13334855>

4:43 PM Changeset in webkit [148314] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Block freeing thread should call Region::destroy instead of delete
https://bugs.webkit.org/show_bug.cgi?id=114544

Reviewed by Oliver Hunt.

Since Region doesn't have a virtual destructor, calling delete will not properly clean up all of
the state of the Region. We should call destroy() instead.

  • heap/BlockAllocator.cpp:

(JSC::BlockAllocator::releaseFreeRegions):
(JSC::BlockAllocator::blockFreeingThreadMain):

4:42 PM Changeset in webkit [148313] by fpizlo@apple.com
  • 3 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: switch to using MCJIT and disable frame pointer elimination
https://bugs.webkit.org/show_bug.cgi?id=114542

Reviewed by Oliver Hunt and Michael Saboff.

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • runtime/InitializeThreading.cpp:

(JSC::initializeThreadingOnce):

4:29 PM Changeset in webkit [148312] by benjamin@webkit.org
  • 11 edits
    1 add in trunk

[WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
https://bugs.webkit.org/show_bug.cgi?id=110743

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-04-12
Reviewed by Benjamin Poulain.

Source/WebKit2:

A call to loadURL() just after terminating WebProcess will fail thanks to
WebPageProxy being in an undefined state since it is in the middle of its own
cleanup after process termination.

To properly fix this, not only WebPageProxy cleanup should be made
at WebProcess termination request, but also WebProcessProxy needs
to only return to its caller after terminating the process and
closing connections. Otherwise, WebPageProxy can even be able to
detect that WebProcess is no longer running, but a call to respawn
the process will fail.

To fix these issues, this patch moves the cleanup code to a shared private function
that is used for both the cases i.e. user termination and real crash. WebProcess
shutdown is done using a new method that ensures that all cleanup was done before
returning.

A last change introduced in this patch is that for user requested termination,
clients are no longer notified of a crash (since it is not a crash).

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::terminateProcess):
(WebKit::WebPageProxy::processDidCrash):
(WebKit):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::userRequestedTerminate):
(WebKit):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

Tools:

Adding a new test file to check if loading a page just after WebProcess
has crashed (or was terminated) works. The test executes the
following steps (Load, Crash, Load), thus stressing WebProcess
reattach and process termination code path.

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:

(TestWebKitAPI::setPageLoaderClient):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.

(TestWebKitAPI):
(WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
(TestWebKitAPI::WebKit2CrashLoader::loadUrl):
(TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
(TestWebKitAPI::didFinishLoad):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
4:18 PM Changeset in webkit [148311] by barraclough@apple.com
  • 15 edits in trunk/Source/WebKit2

Add contentAnchor to WKView
http://bugs.webkit.org/show_bug.cgi?id=114469

Currently if you call setFrameSize: while frame size updates are disabled, or if the geometry
update times out, then the previously rendered page content will be rendered anchored to the
top left corner of the frame.

This is appropriate if the frame is being resized from the bottom right corner. In order to
achieve a more desirable appearance if the frame is being resized from another corner we
should allow the corner at which the content anchors to be specified.

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm:

(-[WKView setFrameSize:]):

  • If the content anchor has been set, then updating the frame size moves the origin within the layer.

(-[WKView _setDrawingAreaSize:]):

  • Instruct the drawing area to paint at the correct position within the layer.

(-[WKView _setAcceleratedCompositingModeRootLayer:]):

  • If the root layer is cleared this implicitly resets any origin position we had set within it.

(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):

  • initialize new data members.

(-[WKView setContentAnchor:]):
(-[WKView contentAnchor]):

  • Accessor implementation for @property contentAnchor.
  • UIProcess/API/mac/WKViewPrivate.h:

(NS_ENUM):

  • Added WKContentAnchor enum type, and @property contentAnchor.
  • UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):

  • Don't suppress geometry updates where the layer poistion has changed.
  • UIProcess/DrawingAreaProxy.h:

(DrawingAreaProxy):

  • Added m_layerPosition, layerPosition argument to setSize
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:

(TiledCoreAnimationDrawingAreaProxy):

  • Added m_lastSentLayerPosition
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):

  • Don't suppress geometry updates where the layer poistion has changed.

(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):

  • Pass layer position in UpdateGeometry message.
  • WebProcess/WebPage/DrawingArea.h:

(WebKit::DrawingArea::updateGeometry):

  • Added layerPosition argument to updateGeometry
  • WebProcess/WebPage/DrawingArea.messages.in:
    • Added layerPosition argument to updateGeometry
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • Added layerPosition argument to updateGeometry
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):

  • Added layerPosition argument to updateGeometry
4:11 PM Changeset in webkit [148310] by ap@apple.com
  • 3 edits
    3 adds in trunk

<rdar://problem/13277362> REGRESSION (r141981): Crash when closing a Google Docs document
https://bugs.webkit.org/show_bug.cgi?id=114541

Reviewed by Brady Eidson.

Test: http/tests/ssl/ping-with-unsafe-redirect.html

  • loader/FrameNetworkingContext.h: (WebCore::FrameNetworkingContext::shouldClearReferrerOnHTTPSToHTTPRedirect): Added a null check. All NetworkingContext functions except for this one had it already.
4:07 PM Changeset in webkit [148309] by Lucas Forschler
  • 1 edit in branches/safari-536.30-branch/LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pl

Update from testRunner to layoutTestController

4:07 PM Changeset in webkit [148308] by Lucas Forschler
  • 2 edits in branches/safari-536.30-branch/LayoutTests

Update from testRunner to layoutTestController

3:50 PM Changeset in webkit [148307] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed. Don't forget to skip the test in WebKit2 for now.

  • platform/mac-wk2/TestExpectations:
3:46 PM Changeset in webkit [148306] by rniwa@webkit.org
  • 10 edits
    2 adds in trunk

[Mac] REGRESSION: Auto substitution strips new lines
https://bugs.webkit.org/show_bug.cgi?id=114537

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by SpellingCorrectionCommand's use of InsertTextCommand. This command can't insert
new lines and there's even an assertion for it. Use TypingCommand::insertText instead.

Since TypingCommand::insertText calls appliedEditing on its own, we need to avoid calling that again in
CompositeEditCommand::apply after SpellingCorrectionCommand::doApply. Replaced the check in apply to use
callsAppliedEditingInDoApply instead of isTypingCommand, and added callsAppliedEditingInDoApply to both
TypingCommand and SpellingCorrectionCommand to return true (it returns false by default).

Test: platform/mac/editing/spelling/autocorrection-with-multi-line-text.html

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::apply): Use TypingCommand::insertText instead of InsertTextCommand
(WebCore::CompositeEditCommand::callsAppliedEditingInDoApply): Added. Returns false.

  • editing/CompositeEditCommand.h:

(CompositeEditCommand):

  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::doApply):
(WebCore::SpellingCorrectionCommand::callsAppliedEditingInDoApply): Added. Returns true.

  • editing/SpellingCorrectionCommand.h:

(SpellingCorrectionCommand):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::callsAppliedEditingInDoApply): Added. Returns true.

  • editing/TypingCommand.h:

(TypingCommand):

Tools:

Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

Added a regression test. Unfortunately, we can't setup text substituion in DumpRenderTree
so use NSSpellChecker to exercise the relevant code path.

  • platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-with-multi-line-text.html: Added.
3:04 PM Changeset in webkit [148305] by commit-queue@webkit.org
  • 16 edits
    1 copy
    1 add in trunk/Source/WebCore

Refactor TextTrack and TextTrackList to make it easier to add audio and video tracks
https://bugs.webkit.org/show_bug.cgi?id=114330

Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-12
Reviewed by Jer Noble.

No new tests because this doesn't add new functionality.

  • CMakeLists.txt: Only compile text track files if ENABLE(VIDEO_TRACK), and add TrackListBase
  • Target.pri: Add TrackListBase
  • WebCore.vcproj/WebCore.vcproj: Correct InbandTextTrackPrivate.h's location and add TrackListBase
  • WebCore.xcodeproj/project.pbxproj: Add TrackListBase
  • html/HTMLMediaElement.cpp: Renamed "track" functions to "textTrack"

(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTextTrack): Renamed.
(WebCore::HTMLMediaElement::addTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeTextTrack): Renamed.
(WebCore::HTMLMediaElement::removeAllInbandTracks): Use renamed functions.
(WebCore::HTMLMediaElement::didAddTextTrack): Renamed.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Renamed.

  • html/HTMLMediaElement.h:

Renamed "track" functions to "textTrack" and only forward-declare TextTrackList if ENABLE(VIDEO_TRACK)

  • html/HTMLTrackElement.cpp: Renamed "track" functions to "textTrack"

(WebCore::HTMLTrackElement::insertedInto):
(WebCore::HTMLTrackElement::removedFrom):

  • html/track/TextTrack.cpp:

Move media element, label, language and kind into TrackBase and move EventTarget functions into TextTrack.
(WebCore::TextTrack::TextTrack): Added.
(WebCore::TextTrack::interfaceName): Added.
(WebCore::TextTrack::scriptExecutionContext): Added.
(WebCore::TextTrack::eventTargetData): Added.
(WebCore::TextTrack::ensureEventTargetData): Added.
(WebCore::TextTrack::isValidKind): Added to support TrackBase::setKind()
(WebCore::TextTrack::setKind): Override to support textTrackKindChanged()
(WebCore::TextTrack::isRendered): Use kind(), label() and language() instead of m_kind, etc.
(WebCore::TextTrack::platformTextTrack): Ditto.
(WebCore::TextTrack::isMainProgramContent): Ditto.

  • html/track/TextTrack.h:

Same as TextTrack.cpp, plus added defaultKindKeyword() so TrackBase::setKind() will work and added
toTextTrack().

  • html/track/TextTrackList.cpp:

Move functionality into TrackListBase, add toTextTrack() casts, use
TrackBase where necesssary and use owner() instead of m_owner.

Moved EventTarget functions into TrackListBase.
(TextTrackList::TextTrackList):
(TextTrackList::getTrackIndexRelativeToRenderedTracks):
(TextTrackList::item):
(TextTrackList::invalidateTrackIndexesAfterTrack):
(TextTrackList::append):
(TextTrackList::remove):
(TextTrackList::contains):

  • html/track/TextTrackList.h:

Move EventTarget, RefCounted and m_inbandTracks into TrackListBase.
Override length(), contains() and remove().

  • html/track/TrackBase.cpp: Remove EventTarget functions.

(WebCore::TrackBase::TrackBase):
Remove EventTarget, add label and language
(WebCore::TrackBase::setKind): Added

  • html/track/TrackBase.h:

Don't extend EventTarget (AudioTrack and VideoTrack aren't). Handle
kind, label, language and media element.
(WebCore::TrackBase::setMediaElement): Added.
(WebCore::TrackBase::mediaElement): Added.
(WebCore::TrackBase::kind): Added.
(WebCore::TrackBase::label): Added.
(WebCore::TrackBase::setLabel): Added.
(WebCore::TrackBase::language): Added.
(WebCore::TrackBase::setLanguage): Added.

  • html/track/TrackListBase.cpp:

Added. Handles functionality common to TextTrackList, AudioTrackList and
VideoTrackList.
(TrackListBase::TrackListBase): Added.
(TrackListBase::~TrackListBase): Added.
(TrackListBase::length): Added.
(TrackListBase::remove): Added.
(TrackListBase::contains): Added.
(TrackListBase::scheduleAddTrackEvent): Added.
(TrackListBase::scheduleRemoveTrackEvent): Added.
(TrackListBase::scheduleChangeEvent): Added.
(TrackListBase::asyncEventTimerFired): Added.

  • html/track/TrackListBase.h:

Copied from Source/WebCore/html/track/TextTrackList.h. Handles
functionality common to TextTrackList, AudioTrackList and VideoTrackList.
(WebCore::TrackListBase::scriptExecutionContext): Added.
(WebCore::TrackListBase::clearOwner): Added.
(WebCore::TrackListBase::owner): Added.
(WebCore::TrackListBase::isFiringEventListeners): Added.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::addTextTrack): Renamed (was addTrack)
(WebCore::MediaPlayer::removeTextTrack): Renamed (was removeTrack)

  • platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayerClient::mediaPlayerDidAddTextTrack): Renamed (was mediaPlayerDidAddTrack)
(WebCore::MediaPlayerClient::mediaPlayerDidRemoveTextTrack): Renamed (was mediaPlayerDidRemoveTrack)

2:54 PM Changeset in webkit [148304] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r148296 and r148297.
http://trac.webkit.org/changeset/148296
http://trac.webkit.org/changeset/148297
https://bugs.webkit.org/show_bug.cgi?id=114536

Needs more thought (Requested by ap on #webkit).

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
2:39 PM Changeset in webkit [148303] by oliver@apple.com
  • 18 edits in trunk/Source/WebCore

make the codegenerator actually emit polymorphism check in the "no vtable" path
https://bugs.webkit.org/show_bug.cgi?id=114533

Reviewed by David Kilzer.

Make the "no vtable" check correct so that we actually plant a polymorphism
check. Update a few interfaces to have the correct validation attributes.

  • Modules/webdatabase/SQLTransaction.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJS):

  • bindings/scripts/test/TestInterface.idl:
  • html/track/TextTrackCue.idl:
  • svg/SVGAnimatedAngle.idl:
  • svg/SVGAnimatedBoolean.idl:
  • svg/SVGAnimatedEnumeration.idl:
  • svg/SVGAnimatedInteger.idl:
  • svg/SVGAnimatedLength.idl:
  • svg/SVGAnimatedLengthList.idl:
  • svg/SVGAnimatedNumber.idl:
  • svg/SVGAnimatedNumberList.idl:
  • svg/SVGAnimatedPreserveAspectRatio.idl:
  • svg/SVGAnimatedRect.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGAnimatedTransformList.idl:
1:44 PM Changeset in webkit [148302] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable selecting text in single line input field without selection point being actually on the targeted text vertically
https://bugs.webkit.org/show_bug.cgi?id=114515

Patch by Yongxin Dai <yodai@rim.com> on 2013-04-12
Reviewed by Rob Buis.

PR #317924.
Internally reviewed by Mike Fenton.

It was still hard to select text in URL bar with an inverted selection handle.
We improve the issue by replacing the Y coordinate of selection point with Y
coordinate of start caret for single line input filed. Thus, the Y coordinate
is always valid regardless of the actual location of the selection handle.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::startCaretViewportRect):
(WebKit):
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

  • WebKitSupport/SelectionHandler.h:

(SelectionHandler):

1:28 PM Changeset in webkit [148301] by oliver@apple.com
  • 14 edits in trunk/Source/WebCore

Make CodeGeneratorJS plant comments to explain failures in the binding validation
https://bugs.webkit.org/show_bug.cgi?id=114528

Reviewed by Sam Weinig.

No change in behaviour, just make the generated bindings include comments
to aid diagnosing issues that may be non-obvious.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJS):

1:17 PM Changeset in webkit [148300] by timothy_horton@apple.com
  • 8 edits in trunk/Source

REGRESSION (r138858): GIFs don't start playing when they come out of background tabs
https://bugs.webkit.org/show_bug.cgi?id=108864
<rdar://problem/13140489>

Reviewed by Antti Koivisto.

Don't repaint the world when animations resume; instead, FrameView
will cause all animated images to repaint. This line also had no effect for
TiledCoreAnimationDrawingArea, which does not implement setNeedsDisplay.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::resumeActiveDOMObjectsAndAnimations):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::resumeAnimatingImagesForLoader): Added.
Iterate through all of the loader's cached resources. If they are bitmap images
which claim to be animatable, notify the image's observers that the animation advanced
by one frame. In reality, the image is still on the same frame, but will now be repainted,
restarting the animation loop.

  • loader/cache/CachedImage.h:
  • page/FrameView.cpp:

(WebCore::FrameView::setIsInWindow):
When the FrameView is brought into a window, repaint all animated images.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::canAnimate): Added.
Return whether or not the image should animate (claims to animate, has not already
finished its animation, and has an ImageObserver) *and* has more than one frame.

  • platform/graphics/BitmapImage.h:

(BitmapImage): Add canAnimate.

1:10 PM Changeset in webkit [148299] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Re-enable WinEWS tests.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

12:35 PM Changeset in webkit [148298] by mrobinson@webkit.org
  • 13 edits in trunk/Source/WebCore

r148197 broke the GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=114525

Reviewed by Anders Carlsson.

Re-add the ENABLE(SCROLLING_THREAD) guards to scrolling thread files
and extend them with USE(COORDINATED_GRAPHICS). This code is unused
by other configurations currently.

  • page/scrolling/ScrollingStateFixedNode.cpp: Re-add guards.
  • page/scrolling/ScrollingStateFixedNode.h: Ditto.
  • page/scrolling/ScrollingStateNode.cpp: Ditto.
  • page/scrolling/ScrollingStateNode.h: Ditto.
  • page/scrolling/ScrollingStateScrollingNode.cpp: Ditto.
  • page/scrolling/ScrollingStateScrollingNode.h: Ditto.
  • page/scrolling/ScrollingStateStickyNode.cpp: Ditto.
  • page/scrolling/ScrollingStateStickyNode.h: Ditto.
  • page/scrolling/ScrollingStateTree.cpp: Ditto.
  • page/scrolling/ScrollingStateTree.h: Ditto.
  • page/scrolling/mac/ScrollingStateNodeMac.mm: Ditto.
  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm: Ditto.
12:28 PM Changeset in webkit [148297] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13334446> [Mac] Tweak sandbox profile.

Apply a post-landing review comment.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
12:14 PM Changeset in webkit [148296] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13334446> [Mac] Tweak sandbox profile.

Reviewed by Jessie Berlin.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
12:09 PM Changeset in webkit [148295] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

(AVFoundation) WebKit fails to detect live stream.
https://bugs.webkit.org/show_bug.cgi?id=114474

Reviewed by Eric Carlson.

Remove a workaround (added by r88944) for an error in an Apple.com javascript
media controller. The error has been fixed, and the workaround is causing problems
with other media streams.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):

11:57 AM Changeset in webkit [148294] by Carlos Garcia Campos
  • 15 edits
    6 adds
    4 deletes in trunk

[GTK] Split GtkAuthenticationDialog in two widgets
https://bugs.webkit.org/show_bug.cgi?id=103644

Reviewed by Xan Lopez.

Source/WebCore:

The current GtkAuthenticationDialog implements both the common
logic and widgets to implement a real GtkDialog and a widget to be
embedded in any container. WebKit1 uses a GtkDialog while WebKit2
embeds the dialog in the WebView. This patch splits the code to
leave in Platform only the code that is actually common, leaving
the widget implementation to the WebKit layer, using a dialog in
WebKit1 and embedding auth widget in the WebView in WebKit2.

  • GNUmakefile.list.am: Add new files to compilation.
  • platform/gtk/GtkAuthenticationDialog.cpp: Removed.
  • platform/gtk/GtkAuthenticationDialog.h: Removed.
  • platform/gtk/WebKitAuthenticationWidget.cpp: Added.

(_WebKitAuthenticationWidgetPrivate):
(packTwoColumnLayoutInBox):
(createLabel):
(createEntry):
(webkitAuthenticationWidgetInitialize):
(webkitAuthenticationWidgetFinalize):
(webkit_authentication_widget_init):
(webkit_authentication_widget_class_init):
(webkitAuthenticationWidgetNew):
(webkitAuthenticationWidgetCreateCredential):
(webkitAuthenticationWidgetGetChallenge):

  • platform/gtk/WebKitAuthenticationWidget.h: Added.

(_WebKitAuthenticationWidget):
(_WebKitAuthenticationWidgetClass):

Source/WebKit/gtk:

  • GNUmakefile.am: Add new files to compilation.
  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
Use helper createAuthenticationDialog() to create and show the
auth dialog.

  • webkit/webkitauthenticationdialog.cpp: Added.

(authenticationDialogResponseCallback):
(createAuthenticationDialog):

  • webkit/webkitauthenticationdialog.h: Added.
  • webkit/webkitsoupauthdialog.cpp:

(sessionAuthenticate): Ditto.

Source/WebKit2:

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.cpp: Removed.
  • UIProcess/API/gtk/WebKit2GtkAuthenticationDialog.h: Removed.
  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp: Added.

(webkitAuthenticationDialogAuthenticate): Use the
AuthenticationChallengeProxy to authenticate and destroy the dialog.
(okButtonClicked): Call webkitAuthenticationDialogAuthenticate()
with the credential.
(cancelButtonClicked): Call
webkitAuthenticationDialogAuthenticate() with a NULL credential to
continue without credential.
(webkitAuthenticationDialogInitialize): Build the UI.
(webkitAuthenticationDialogDraw): Draw a background.
(webkitAuthenticationDialogMap): Grab default button.
(webkitAuthenticationDialogConstructed): Create a GtkStyleContext
with the GtkWindow path to draw the widget background like a real
dialog.
(webkit_authentication_dialog_class_init):
(webkitAuthenticationDialogNew): Create a new
WebKitAuthenticationDialog widget.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.h: Added.
  • UIProcess/API/gtk/WebKitLoaderClient.cpp:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewHandleAuthenticationChallenge): Create a
WebKitAuthenticationDialog widget and pass add it to the
container.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Updated to use the widget directly.
(webkitWebViewChildIsInternalWidget): Ditto.
(webkitWebViewBaseAddAuthenticationDialog): Ditto.
(webkitWebViewBaseCancelAuthenticationDialog): Ditto.
(webkitWebViewBaseContainerRemove): Ditto.
(webkitWebViewBaseContainerForall): Ditto.
(resizeWebKitWebViewBaseFromAllocation): Ditto.
(webkitWebViewBaseFocus): Ditto.
(webkitWebViewBaseDestroy): Destroy the auth widget is present.
(webkit_web_view_base_class_init): Add implementation for
GtkWidgetClass::destroy.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

Tools:

  • gtk/generate-gtkdoc:

(get_webkit2_options): Do not generate api docs for
WebKitAuthenticationDialog which is private in WebKit2.
(get_webkit1_options): Do not generate api docs for
webkitauthenticationdialog which is private in WebKit1.

11:45 AM Changeset in webkit [148293] by mrobinson@webkit.org
  • 2 edits in trunk

[GTK] Lower the pango dependency
https://bugs.webkit.org/show_bug.cgi?id=114520

Reviewed by Carlos Garcia Campos.

  • Source/autotools/Versions.m4: Only depend on Pango 1.30.0 instead of

Pango 1.32.0. 1.32.0 isn't strictly necessary and the version of GTK+ that
we depend on (3.6.0) depends on 1.30.0.

11:43 AM Changeset in webkit [148292] by rniwa@webkit.org
  • 2 edits in trunk/Tools

WebKit Queues should capitalize K in Wk2
https://bugs.webkit.org/show_bug.cgi?id=114524

Reviewed by Philippe Normand.

  • QueueStatusServer/model/queues.py:

(Queue.display_name):

11:39 AM Changeset in webkit [148291] by jer.noble@apple.com
  • 9 edits in trunk/Source/WebCore

Add support for MediaPlayer::minTimeSeekable()
https://bugs.webkit.org/show_bug.cgi?id=114484

Reviewed by Eric Carlson.

Plumb a new minTimeSeekable() method through MediaPlayer and
MediaPlayerPrivate and use this new method in the existing
HTMLMediaElement::minTimeSeekable() method.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::minTimeSeekable): Pass to MediaPlayer.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::NullMediaPlayerPrivate::minTimeSeekable): Return 0.
(WebCore::MediaPlayer::minTimeSeekable): Pass to MediaPlayerPrivate.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::seekable): Define in terms of

minTimeSeekable()

(WebCore::MediaPlayerPrivateInterface::minTimeSeekable): Default to 0.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

Initialize new m_cachedMinTimeSeekable ivar.

(WebCore::MediaPlayerPrivateAVFoundation::maxTimeSeekableDouble):

Renamed from maxTimeSeekable().

(WebCore::MediaPlayerPrivateAVFoundation::minTimeSeekable): Added.

Cache value of platformMinTimeSeekable().

(WebCore::MediaPlayerPrivateAVFoundation::seekableTimeRangesChanged):

Reset m_cachedMinTimeSeekable.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): float -> double.
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):

Added. Retrieve the lowest value from -[m_playerItem seekableTimeRanges].

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):

float -> double.

11:36 AM Changeset in webkit [148290] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

All tests crash on Windows
https://bugs.webkit.org/show_bug.cgi?id=114522

Reviewed by Ryosuke Niwa.

In the MSVC++ ABI, a member function pointer will have a different size depending on whether the
class it belongs to is defined or not. Because of this, when passing member function pointers as parameters
it's important to ensure that the class is known by both the caller and the callee.

  • WebFrame.cpp:

Include PolicyChecker.h

11:06 AM Changeset in webkit [148289] by rniwa@webkit.org
  • 20 edits
    2 adds
    60 deletes in trunk

Unreviewed, rolling out r147942, r148026, and r148092.
http://trac.webkit.org/changeset/147942
http://trac.webkit.org/changeset/148026
http://trac.webkit.org/changeset/148092
https://bugs.webkit.org/show_bug.cgi?id=114521

"r147942 is buggy. Rollback all the patches depending on it."
(Requested by abucur on #webkit).

Source/WebCore:

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):
(WebCore):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore):

  • dom/Document.h:

(Document):

  • dom/Node.cpp:
  • dom/Node.h:

(Node):

  • dom/NodeTraversal.cpp:
  • dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):

  • dom/Range.cpp:

(WebCore::boundaryNodeChildrenWillBeRemoved):
(WebCore):
(WebCore::Range::nodeChildrenWillBeRemoved):

  • dom/Range.h:
  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

  • rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

  • rendering/RenderListItem.cpp:

(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

  • fast/dom/MutationObserver/added-out-of-order-expected.txt:
  • fast/dom/MutationObserver/added-out-of-order.html:
  • fast/dom/Range/range-remove-children-event-expected.txt: Removed.
  • fast/dom/Range/range-remove-children-event.html: Removed.
  • fast/dom/containerNode-expected.txt: Added.
  • fast/dom/containerNode.html: Added.
  • fast/dom/shadow/shadow-and-list-elements-expected.html:
  • fast/events/mutation-during-innerHTML-expected.txt: Removed.
  • fast/events/mutation-during-innerHTML.html: Removed.
  • fast/lists/positioned-count-crash-expected.txt:
  • fast/regions/counters/extract-list-items-001-expected.html: Removed.
  • fast/regions/counters/extract-list-items-001.html: Removed.
  • fast/regions/counters/extract-list-items-002-expected.html: Removed.
  • fast/regions/counters/extract-list-items-002.html: Removed.
  • fast/regions/counters/extract-list-items-003-expected.html: Removed.
  • fast/regions/counters/extract-list-items-003.html: Removed.
  • fast/regions/counters/extract-list-items-004-expected.html: Removed.
  • fast/regions/counters/extract-list-items-004.html: Removed.
  • fast/regions/counters/extract-list-items-005-expected.html: Removed.
  • fast/regions/counters/extract-list-items-005.html: Removed.
  • fast/regions/counters/extract-list-items-006-expected.html: Removed.
  • fast/regions/counters/extract-list-items-006.html: Removed.
  • fast/regions/counters/extract-list-items-007-expected.html: Removed.
  • fast/regions/counters/extract-list-items-007.html: Removed.
  • fast/regions/counters/extract-list-items-008-expected.html: Removed.
  • fast/regions/counters/extract-list-items-008.html: Removed.
  • fast/regions/counters/extract-list-items-009-expected.html: Removed.
  • fast/regions/counters/extract-list-items-009.html: Removed.
  • fast/regions/counters/extract-list-items-010-expected.html: Removed.
  • fast/regions/counters/extract-list-items-010.html: Removed.
  • fast/regions/counters/extract-list-items-011-expected.html: Removed.
  • fast/regions/counters/extract-list-items-011.html: Removed.
  • fast/regions/counters/extract-list-items-012-expected.html: Removed.
  • fast/regions/counters/extract-list-items-012.html: Removed.
  • fast/regions/counters/extract-list-items-013-expected.html: Removed.
  • fast/regions/counters/extract-list-items-013.html: Removed.
  • fast/regions/counters/extract-list-items-014-expected.html: Removed.
  • fast/regions/counters/extract-list-items-014.html: Removed.
  • fast/regions/counters/extract-list-items-015-expected.html: Removed.
  • fast/regions/counters/extract-list-items-015.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-expected.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs.html: Removed.
  • fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Removed.
  • fast/regions/counters/extract-numbered-spans-display-only-some.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-001.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-002.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-003.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Removed.
  • fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Removed.
  • fast/regions/counters/extract-unordered-lists-in-regions.html: Removed.
10:58 AM Changeset in webkit [148288] by jer.noble@apple.com
  • 13 edits
    2 adds in trunk

TimeRanges::nearest() returns incorrect results.
https://bugs.webkit.org/show_bug.cgi?id=114483

Reviewed by Eric Carlson.

.:

Add symbols needed by WebCoreTestSupport to exports list.

  • Source/autotools/symbols.filter:

Source/WebCore:

Test: media/timeranges-nearest.html

TimeRanges::nearest() has had an incorrect algorithm since its
addition, which has gone unnoticed because no media engine supports
seekable ranges with greater than one entry, and no media engine
seekable ranges with startTime values > 0.

Fix the algorithm used to walk a TimeRanges object; return the closest
time, not the smallest delta between range and target time.

  • html/TimeRanges.cpp:

(TimeRanges::nearest):

Add some internal functions to allow us to write LayoutTests for
TimeRanges objects:

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::createTimeRanges):
(WebCore::Internals::closestTimeToTimeRanges):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

Add symbols needed by WebCoreTestSupport to the exports list.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Add symbols needed by WebCoreTestSupport to the exports list.

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

  • media/timeranges-nearest-expected.txt: Added.
  • media/timeranges-nearest.html: Added.
10:40 AM Changeset in webkit [148287] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Remove bogus change

10:24 AM Changeset in webkit [148286] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit2

[GTK] Web Process crash when the UI process finishes too early
https://bugs.webkit.org/show_bug.cgi?id=112729

Reviewed by Anders Carlsson.

The problem is when creating the GSocket in the WorkQeue for the
socket descriptor. GLib considers a programmer error to create a
GSocket providing an invalid socket and finishes the process with
g_error(). We are actually providing a valid socket when creating
the GSocket, but it can be invalidated by the worker thread while
the GSocket is being created. This is because
registerEventSourceHandler is called from the main thread and
unregisterEventSourceHandler can be called from the worker
thread. We are currently registering two event handlers, one to
read data from the socket and another one to close the CoreIPC
connection when the socket connection is broken. Every event
source registered uses its own GSocket (even if the file
descriptor is actually the same), so that when the UI process
finishes too early, the first event handler can be executed in the
worker thread, closing the socket descriptor, while the main
thread is creating the GSocket for the second one.
We don't really need to use a separate event handler to monitor
the connection, because GSocket always notifies when condition is
G_IO_HUP and G_IO_ERR even if they haven't been explicitly set in
g_socket_create_source(). We can register socket event sources
differently, providing also a function to be called when the
connection is closed, using a single socket and the same even source.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::open): Register a single socket event
handler providing also a function to be called when the connection
is closed.

  • Platform/WorkQueue.h:

(WorkQueue):

  • Platform/gtk/WorkQueueGtk.cpp: The EventSource class has been

split, moving everyting specific to socket event source to a
derived class SocketEventSource.
(WorkQueue::EventSource::EventSource):
(WorkQueue::EventSource::performWork):
(WorkQueue::EventSource::performWorkOnce):
(WorkQueue::EventSource::performWorkOnTermination):
(WorkQueue::EventSource::deleteEventSource):
(WorkQueue::EventSource):
(WorkQueue::SocketEventSource):
(WorkQueue::SocketEventSource::SocketEventSource):
(WorkQueue::SocketEventSource::cancel):
(WorkQueue::SocketEventSource::didClose):
(WorkQueue::SocketEventSource::checkCondition):
(WorkQueue::SocketEventSource::eventCallback):
(WorkQueue::registerSocketEventHandler):
(WorkQueue::unregisterSocketEventHandler):
(WorkQueue::dispatchOnSource):

10:23 AM Changeset in webkit [148285] by eric.carlson@apple.com
  • 23 edits
    2 adds in trunk

Support "forced" subtitles
https://bugs.webkit.org/show_bug.cgi?id=114460

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-forced-subtitles.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::configureTextTrackGroup): Enable a forced track if nothing else is enabled.
(WebCore::HTMLMediaElement::configureTextTracks): Include forced tracks with captions+subtitles.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Deal with kind=forced.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::forcedKeyword): New keyword.
(WebCore::TextTrack::isValidKindKeyword): Include forced.
(WebCore::TextTrack::platformTextTrack): Ditto.

  • html/track/TextTrack.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::primaryAudioTrackLanguageOverride): New override to support testing.

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Support forced tracks.

  • platform/graphics/InbandTextTrackPrivate.h:
  • platform/graphics/PlatformTextTrack.h: Add Forced, minor cleanup.
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCue): Drive-by enhancement: log cue position.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind): Support forced.
(WebCore::InbandTextTrackPrivateAVFObjC::label): Drive-by cleanup.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Don't filter out forced tracks.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Log the language returned.

  • testing/Internals.cpp:

(WebCore::Internals::setPrimaryAudioTrackLanguageOverride): New.
(WebCore::Internals::setCaptionDisplayMode): New.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/content/CC+Subtitles.m4v: Added.
  • media/track/track-forced-subtitles-in-band-expected.txt: Added.
  • media/track/track-forced-subtitles-in-band.html: Added.
  • media/trackmenu-test.js:
  • platform/efl/TestExpectations: Skip new test.
  • platform/gtk/TestExpectations: Ditto.
  • platform/mac/TestExpectations: Ditto.
  • platform/qt/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
10:06 AM Changeset in webkit [148284] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

<rdar://problem/13126204> [Mac] Tweak sandbox profile.

Reviewed by Anders Carlsson.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
9:54 AM Changeset in webkit [148283] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

[Mac] Some ligatures are applied across different fronts
https://bugs.webkit.org/show_bug.cgi?id=113604

Reviewed by Darin Adler.

The bug was caused by applyFontTransforms applying ligatures without updating the font data in the glyph buffer.

Suppose we have characters AB and A uses font X and B uses font Y. Further suppose that we have ligatures for AB
in Y. The problem was that WithIterator::advanceInternal calls applyFontTransforms on AB to apply this ligature
even though A and B use different fonts. Since X doesn't contain the same ligature for A to be paired with that
of B in X, we get a blank A.

Fixed the bug by resetting lastGlyphCount after calling applyFontTransforms. This ensures that we don't call
applyFontTransforms across different fonts.

No new tests since this requires a variant of Osaka font that doesn't come with OS X.

The bug 114482 tracks the effort to add a test for this bug fix. I've already asked someone to create a custom
font for us so that we can test this bug fix but that's going to a while.

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

9:52 AM Changeset in webkit [148282] by rniwa@webkit.org
  • 26 edits
    6 deletes in trunk

[Mac] Enable spellchecking tests added in r141471
https://bugs.webkit.org/show_bug.cgi?id=108525

Reviewed by Darin Adler.

Source/WebCore:

Made automatic quote substitution, dash substitution, text replacement, and spelling correction
togglable via internals object. These functions are no-op when text replacement is not used.

This allows us to disable automatic spelling correction in spellcheck tests.

Enabled several tests added in r141471.

  • WebCore.exp.in:
  • testing/Internals.cpp:

(WebCore::Internals::setContinuousSpellCheckingEnabled): Don't null check editor() since it's not
null whenever frame() is not null.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Added.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Added.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Added.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Added.

  • testing/Internals.h:
  • testing/Internals.idl:

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(resetDefaultsToConsistentValues):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Updated the tests not to assume spelling correction suggestions were listed in a context menu since
only Chromium port did this.

  • editing/spelling/resources/util.js:

(initSpellTest): Disable automatic text replacements.

  • editing/spelling/spelling-with-underscore-selection-expected.txt: Removed.
  • editing/spelling/spelling-with-underscore-selection.html: Removed.

This test erroneously assumed a specific word breaking behavior that doesn't include the underscore
when selecting a word especially since Chromium was the only port that was running these tests.

  • editing/spelling/spelling-double-clicked-word-with-underscores-expected.txt: Removed.
  • editing/spelling/spelling-double-clicked-word-with-underscores.html: Removed.

Ditto.

  • editing/spelling/spelling-should-select-single-word-expected.txt: Removed.
  • editing/spelling/spelling-should-select-single-word.html: Removed.

Removed since this test doesn't do anything useful without the assertion for the context menu.

  • editing/spelling/spelling-double-clicked-word-expected.txt:
  • editing/spelling/spelling-double-clicked-word.html:
  • editing/spelling/spelling-exactly-selected-word-expected.txt:
  • editing/spelling/spelling-exactly-selected-word.html:
  • editing/spelling/spelling-with-punctuation-selection-expected.txt:
  • editing/spelling/spelling-with-punctuation-selection.html:
  • editing/spelling/spelling-with-whitespace-selection-expected.txt:
  • editing/spelling/spelling-with-whitespace-selection.html:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
9:33 AM Changeset in webkit [148281] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[GTK][WK2] Add document-loaded signal to WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=110614

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Carlos Garcia Campos.

Add a new signal document-loaded to WebKitWebPage that will be emitted
when the DOM document has been loaded for the main frame.

  • UIProcess/API/gtk/tests/TestWebExtensions.cpp:

(documentLoadedCallback):
(testDocumentLoadedSignal):
(beforeAll): Add test for document-loaded signal.

  • UIProcess/API/gtk/tests/WebExtensionTest.cpp:

(documentLoadedCallback):
(pageCreatedCallback):
(methodCallCallback): Add new D-Bus signal DocumentLoaded in order to
test document-loaded signal.

  • WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:

(webkit_web_page_class_init):
(webkitWebPageCreate): Add document-loaded signal and emit it when
didFinishDocumentLoadForFrame is called.

9:19 AM Changeset in webkit [148280] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

[Qt][Win] r148257 broke the build
https://bugs.webkit.org/show_bug.cgi?id=114512

Build fix.

  • wtf/Platform.h:
9:07 AM Changeset in webkit [148279] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Webkit fails to build webkit2gtk-tests-resources.gresource.
https://bugs.webkit.org/show_bug.cgi?id=114485

Patch by Hanyee Kim <choco@company100.net> on 2013-04-12
Reviewed by Martin Robinson.

Generating webkit2gtk-tests-resources.gresource can be failed due to
the non-existing target directory.
We need to make target directory before generating it.

  • UIProcess/API/gtk/tests/GNUmakefile.am:
8:13 AM Changeset in webkit [148278] by akling@apple.com
  • 8 edits in trunk/Source/WebKit2

REGRESSION(r145869): Right-click on SWF contents displays the context menu at the wrong place.
<http://webkit.org/b/113836>
<rdar://problem/13587624>

Reviewed by Anders "Wesley Crusher" Carlsson.

Mac plugins expect flipped-Y screen coordinates, while DOM APIs speak in unflipped coordinates,
and we were mixing them up in the window frame caching optimization.

Solve this by having the UIProcess send both flipped and unflipped window frames to the WebProcess.
The flipped frame is passed on to plugins, and the unflipped frame is used for window.screenX/Y etc.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _updateWindowAndViewFrames]):

No need to retrieve the window frame here as WebPageProxy::windowAndViewFramesChanged() will
always override it anyway.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::windowAndViewFramesChanged):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::windowRect):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::windowAndViewFramesChanged):

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::windowFrameInUnflippedScreenCoordinates):

  • WebProcess/WebPage/WebPage.messages.in:
7:05 AM Changeset in webkit [148277] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash running layout tests
https://bugs.webkit.org/show_bug.cgi?id=114503

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.

Hit an assertion in ~GuardedPointerBase when DRT is
deleted. DumpRenderTree class derives from
BlackBerry::Platform::LayoutTestClient that derives from
BlackBerry::Platform::GuardedPointerBase, so the DRT pointer
should no be released with delete but with
BlackBerry::Platform::deleteGuardedObject().

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):

6:50 AM Changeset in webkit [148276] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

[GTK] Enable WebKit2 building on GTK EWSs
https://bugs.webkit.org/show_bug.cgi?id=114500

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-12
Reviewed by Philippe Normand.

Add configuration in order to be able to setup GTK EWSs building
WebKit2. A new queue gtk-wk2-ews is added.

  • QueueStatusServer/config/queues.py:
  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(GtkWK2Port):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port.run_webkit_tests_command):

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_gtk_port):
(DeprecatedPortTest):
(DeprecatedPortTest.test_gtk_wk2_port):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(GtkWK2EWS):

6:22 AM Changeset in webkit [148275] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-12
Reviewed by Rob Buis.

These are the changes for AsyncFileSystemBlackBerry.

This patch contains contributions from many members of the
BlackBerry WebKit team.

  • platform/blackberry/AsyncFileSystemBlackBerry.cpp:

(WebCore::AsyncFileSystem::isAvailable):
(WebCore):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystemBlackBerry::openFileSystem):
(WebCore::AsyncFileSystem::deleteFileSystem):
(WebCore::AsyncFileSystemBlackBerry::AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::~AsyncFileSystemBlackBerry):
(WebCore::AsyncFileSystemBlackBerry::move):
(WebCore::AsyncFileSystemBlackBerry::copy):
(WebCore::AsyncFileSystemBlackBerry::remove):
(WebCore::AsyncFileSystemBlackBerry::removeRecursively):
(WebCore::AsyncFileSystemBlackBerry::readMetadata):
(WebCore::AsyncFileSystemBlackBerry::createFile):
(WebCore::AsyncFileSystemBlackBerry::createDirectory):
(WebCore::AsyncFileSystemBlackBerry::fileExists):
(WebCore::AsyncFileSystemBlackBerry::directoryExists):
(WebCore::AsyncFileSystemBlackBerry::readDirectory):
(WebCore::AsyncFileSystemBlackBerry::createWriter):
(WebCore::AsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):
(WebCore::AsyncFileSystemBlackBerry::fileSystemURLToPath):

  • platform/blackberry/AsyncFileSystemBlackBerry.h:

(WTF):
(WTF::BlackBerry::Platform::WebFileSystem):
(WebCore::AsyncFileSystemBlackBerry::create):
(AsyncFileSystemBlackBerry):

6:10 AM Changeset in webkit [148274] by mikhail.pozdnyakov@intel.com
  • 11 edits
    4 copies in trunk/Source/WebKit2

[WK2][EFL] WebView: Add callbacks to the WKViewClient to handle page viewport update
https://bugs.webkit.org/show_bug.cgi?id=110463

Reviewed by Anders Carlsson.

  • UIProcess/efl/ViewClientEfl.h:

(ViewClientEfl):

  • UIProcess/efl/WebView.cpp:

(WebKit::WebView::didChangeViewportProperties):

  • UIProcess/efl/WebViewClient.cpp:

(WebKit::WebViewClient::didChangeViewportAttributes):
(WebKit):

  • UIProcess/efl/WebViewClient.h:

Added didChangeViewportAttributes callback to the WKViewClient to
handle page viewport updates.

  • CMakeLists.txt:
  • Shared/API/c/WKBase.h:
  • Shared/APIObject.h:
  • UIProcess/API/C/WKAPICast.h:

(WebKit):

  • UIProcess/API/C/WKViewportAttributes.cpp: Added.

(WKViewportAttributesGetTypeID):

  • UIProcess/API/C/WKViewportAttributes.h: Added.
  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/WebViewportAttributes.cpp: Added.

(WebKit):
(WebKit::WebViewportAttributes::WebViewportAttributes):
(WebKit::WebViewportAttributes::~WebViewportAttributes):

  • UIProcess/WebViewportAttributes.h: Added.

(WebKit):
(WebViewportAttributes):
(WebKit::WebViewportAttributes::create):
(WebKit::WebViewportAttributes::originalAttributes):
(WebKit::WebViewportAttributes::type):

Added WKViewportAttributesRef - WK2 C API object that is wrapping
WebCore::ViewportAttributes structure and is passed in didChangeViewportAttributes
WKViewClient callback.

  • UIProcess/efl/ViewClientEfl.cpp:

(WebKit::ViewClientEfl::didChangeViewportAttributes):
(WebKit):

Added implementaion of didChangeViewportAttributes WKViewClient
callback so that existing EFL WK2 funtionality is kept.

3:54 AM Changeset in webkit [148273] by jocelyn.turcotte@digia.com
  • 2 edits in trunk/Source/WebCore

Apply our MSVC 2012 optimizer bug workaround to all minor releases
https://bugs.webkit.org/show_bug.cgi?id=114436

Reviewed by Alexey Proskuryakov.

The bug has only been partially fixed in Update 2 but our Update 1 workaround
still avoids the crash.

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::TextEncodingNameHash::equal):

3:28 AM Changeset in webkit [148272] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

And again, with the correct case this time.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
3:22 AM Changeset in webkit [148271] by mrowe@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

Add missing #include and forward declaration.

2:03 AM Changeset in webkit [148270] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Crash running layout tests when WebPage is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114497

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-12
Reviewed by Xan Lopez.

PR 324649
Internally reviewed by Konrad Piascik and Rob Buis.

Use a bool member to keep track of whether the inspector is
enabled or not instead of relaying on the enable developer extras
setting, that can be set in other places than enableWebInspector().

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate): Initialize
m_inspectorEnabled.
(BlackBerry::WebKit::WebPage::enableWebInspector): Return early if
inspector is already enabled and set m_inspectorEnabled to true.
(BlackBerry::WebKit::WebPage::disableWebInspector): Return early
if inspector is not enabled and set m_inspectorEnabled to false.
(BlackBerry::WebKit::WebPage::isWebInspectorEnabled): Check the
current value of m_inspectorEnabled instead of the developer
extras setting.

  • Api/WebPage_p.h:

(WebPagePrivate): Add m_inspectorEnabled.

1:55 AM Changeset in webkit [148269] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed functionality fix for ports enabling the MicroData feature.

  • html/DOMSettableTokenList.idl: Add the SkipVTableValidation IDL attribute to the DOMSettableTokenList interface.

This removes crashes in the MicroData layout tests that are occurring on EFL and GTK builders, the two ports being
the only ports that enable this feature.

1:17 AM Changeset in webkit [148268] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt/TestExpectations:
  • platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r148236.
1:12 AM Changeset in webkit [148267] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] The style of visited links doesn't change in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=112175

Reviewed by Benjamin Poulain.

The problem is that visited links were not tracked by the web
process. There's a web process initial parameter to set whether
web process should track visited links or not and it's disabled by
default.

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess): Always set
shouldTrackVisitedLinks to true.

12:55 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
(diff)
12:38 AM Changeset in webkit [148266] by rniwa@webkit.org
  • 1 edit
    2 deletes in trunk/Tools

Remove Chromium scripts
https://bugs.webkit.org/show_bug.cgi?id=114492

Reviewed by Benjamin Poulain.

  • Scripts/run-chromium-webkit-unit-tests: Removed.
  • Scripts/update-webkit-chromium: Removed.
12:15 AM Changeset in webkit [148265] by ap@apple.com
  • 15 edits
    1 add in trunk/Source/WebCore

Move CachedRawResourceClient into a separate file
https://bugs.webkit.org/show_bug.cgi?id=114491

Reviewed by Mark Rowe.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:
  • loader/DocumentThreadableLoader.h:
  • loader/archive/cf/LegacyWebArchive.cpp:
  • loader/cache/CachedRawResource.cpp:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedRawResourceClient.h: Added.
  • loader/icon/IconLoader.h:
  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
12:14 AM Changeset in webkit [148264] by zandobersek@gmail.com
  • 18 edits in trunk

Unreviewed, rolling out r148262.
http://trac.webkit.org/changeset/148262
https://bugs.webkit.org/show_bug.cgi?id=114493

Cairo dep should now build, rolling r148247 back in (Requested
by zdobersek on #webkit).

Patch by Commit Queue <rniwa@webkit.org> on 2013-04-12

.:

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/PrintBuildConfiguration.m4:
  • Source/autotools/SetupWebKitFeatures.m4:

Source/WebCore:

  • platform/graphics/GraphicsContext.cpp:

(WebCore):

  • platform/graphics/ImageBuffer.cpp:

(WebCore):

  • platform/graphics/cairo/GLContext.h:

(GLContext):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::isAcceleratedContext):
(WebCore):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore):
(WebCore::createCairoGLSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::mapSurfaceToImage):
(WebCore::unmapSurfaceFromImage):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore::ImageBufferData::paintToTextureMapper):
(WebCore::ImageBuffer::platformLayer):

  • platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData):

  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):
(WebCore::GLContextEGL::cairoDevice):
(WebCore):

  • platform/graphics/egl/GLContextEGL.h:
  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):
(WebCore::GLContextGLX::cairoDevice):
(WebCore):

  • platform/graphics/glx/GLContextGLX.h:

(GLContextGLX):

Tools:

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/jhbuild.modules:

Apr 11, 2013:

11:11 PM Changeset in webkit [148263] by ap@apple.com
  • 10 edits
    1 add in trunk/Source/WebCore

Reduce includes of CachedSVGDocument.h
https://bugs.webkit.org/show_bug.cgi?id=114489

Reviewed by Jon Honeycutt.

  • loader/cache/CachedSVGDocumentReference.cpp: Added.
  • loader/cache/CachedSVGDocumentReference.h: Moved function implementations to newly added .cpp file, and removed an include of CachedSVGDocument.h.
  • css/WebKitCSSSVGDocumentValue.h: Just removed an unnecessary include.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
11:04 PM Changeset in webkit [148262] by zandobersek@gmail.com
  • 18 edits in trunk

Unreviewed, rolling out r148247.
http://trac.webkit.org/changeset/148247
https://bugs.webkit.org/show_bug.cgi?id=114490

Cairo dep fails to build on builders due to missing EGL
headers (Requested by zdobersek on #webkit).

Patch by Commit Queue <rniwa@webkit.org> on 2013-04-11

.:

  • Source/autotools/FindDependencies.m4:
  • Source/autotools/PrintBuildConfiguration.m4:
  • Source/autotools/SetupWebKitFeatures.m4:

Source/WebCore:

  • platform/graphics/GraphicsContext.cpp:

(WebCore):

  • platform/graphics/ImageBuffer.cpp:

(WebCore):

  • platform/graphics/cairo/GLContext.h:

(GLContext):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
(WebCore):

  • platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData):

  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::GLContextEGL):
(WebCore::GLContextEGL::~GLContextEGL):

  • platform/graphics/egl/GLContextEGL.h:
  • platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::GLContextGLX):
(WebCore::GLContextGLX::~GLContextGLX):

  • platform/graphics/glx/GLContextGLX.h:

(GLContextGLX):

Tools:

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject):

  • gtk/jhbuild.modules:
10:03 PM Changeset in webkit [148261] by thakis@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove debugging code that is no longer used with current mac sdks.
https://bugs.webkit.org/show_bug.cgi?id=114486

Reviewed by Dan Bernstein.

This code compared MAC_OS_X_VERSION_MAX_ALLOWED and friends to
107 and 106 instead of the correct 1070 and 1060. Instead of fixing
this, rip the code out completely: Since WebKit now only targets
current systems, the ifdef is always false anyways.

No tests, as this only removes debugging code.

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit):

9:21 PM Changeset in webkit [148260] by oliver@apple.com
  • 14 edits in trunk/Source/WebCore

Fix windows build and land new binding test results

8:42 PM Changeset in webkit [148259] by benjamin@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Merge CharacterClassTable into CharacterClass
https://bugs.webkit.org/show_bug.cgi?id=114409

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-11
Reviewed by Darin Adler.

CharacterClassTable is only a pointer and a boolean.
It is a little overkill to make a separate allocation
for that.

  • create_regex_tables:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::matchCharacterClass):

  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::charClass):

  • yarr/YarrPattern.h:

(CharacterClass):
(JSC::Yarr::CharacterClass::CharacterClass):

7:38 PM Changeset in webkit [148258] by commit-queue@webkit.org
  • 3 edits
    12 adds in trunk

Selection gaps don't repaint correctly with transforms
https://bugs.webkit.org/show_bug.cgi?id=111000

Patch by Shezan Baig <Shezan Baig> on 2013-04-11
Reviewed by Simon Fraser.

Source/WebCore:

When computing offsetFromRepaintContainer, we need to add UseTransforms
to the MapCoordinateFlags argument. Note that ApplyContainerFlip is
the default value for the flag, so this change effectively only adds
the UseTransforms flag.

Tests: fast/repaint/selection-gap-absolute-child.html

fast/repaint/selection-gap-fixed-child.html
fast/repaint/selection-gap-flipped-absolute-child.html
fast/repaint/selection-gap-flipped-fixed-child.html
fast/repaint/selection-gap-transformed-absolute-child.html
fast/repaint/selection-gap-transformed-fixed-child.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGapRectsForRepaint):

LayoutTests:

  • fast/repaint/selection-gap-absolute-child-expected.txt: Added.
  • fast/repaint/selection-gap-absolute-child.html: Added.
  • fast/repaint/selection-gap-fixed-child-expected.txt: Added.
  • fast/repaint/selection-gap-fixed-child.html: Added.
  • fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
  • fast/repaint/selection-gap-flipped-absolute-child.html: Added.
  • fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
  • fast/repaint/selection-gap-flipped-fixed-child.html: Added.
  • fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
  • fast/repaint/selection-gap-transformed-absolute-child.html: Added.
  • fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
  • fast/repaint/selection-gap-transformed-fixed-child.html: Added.
6:43 PM Changeset in webkit [148257] by oliver@apple.com
  • 21 edits in trunk/Source

Add more type validation to debug builds
https://bugs.webkit.org/show_bug.cgi?id=114478

Reviewed by Mark Hahnenberg.

Source/WebCore:

Add a bunch more type checks to the JS DOM bindings.

  • Modules/mediastream/MediaStream.idl:
  • Modules/webaudio/AudioDestinationNode.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBinding.h:

(WebCore::getExistingWrapper):
(WebCore):
(WebCore::createNewWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetNativeTypeForConversions):
(GetGnuVTableRefForInterface):
(GetGnuVTableNameForInterface):
(GetGnuMangledNameForInterface):
(GetGnuVTableOffsetForType):
(GetWinVTableRefForInterface):
(GetWinVTableNameForInterface):
(GetWinMangledNameForInterface):
(GetNamespaceForInterface):
(GetImplementationLacksVTableForInterface):
(GetSkipVTableValidationForInterface):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • dom/Clipboard.idl:
  • dom/DOMStringMap.idl:
  • dom/MutationRecord.idl:
  • dom/NodeList.idl:
  • html/DOMTokenList.idl:
  • html/track/TextTrack.idl:
  • inspector/ScriptProfileNode.idl:
  • storage/Storage.idl:
  • xml/XPathNSResolver.idl:

Source/WTF:

Add BINDING_VALIDATION flag and make RELEASE_ASSERT use UNLIKELY.

  • wtf/Assertions.h:
  • wtf/Platform.h:
5:50 PM Changeset in webkit [148256] by rniwa@webkit.org
  • 12 edits
    1 delete in trunk/Source/WebCore

Remove ResourceLoadInfo
https://bugs.webkit.org/show_bug.cgi?id=113302

Reviewed by Benjamin Poulain.

Co-authored by Christophe Dumez.

Removed ResourceLoadInfo since it had been only used by Chromium port.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorResourceAgent.cpp:

(WebCore::buildObjectForResourceResponse):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • platform/network/ResourceLoadInfo.h: Removed.
  • platform/network/ResourceResponseBase.cpp:

(WebCore):
(WebCore::ResourceResponseBase::reportMemoryUsage):

  • platform/network/ResourceResponseBase.h:

(ResourceResponseBase):

5:50 PM Changeset in webkit [148255] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove passing test expectations for ietestcenter/css3/grid/grid-items-003.htm since it started failing on
Mountain Lion WebKit2 bots after a slave reboot as well.

  • platform/mac-wk2/TestExpectations:
5:47 PM Changeset in webkit [148254] by Lucas Forschler
  • 4 edits in trunk/Source

Submission Notes.

5:39 PM Changeset in webkit [148253] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r146956): ASSERTion failure: WebKit::WebProcess::pageWillLeaveWindow
https://bugs.webkit.org/show_bug.cgi?id=114481
<rdar://problem/13534784>

Reviewed by Simon Fraser.

Inform the WebProcess of WebPages which are already in a window when created.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

5:20 PM Changeset in webkit [148252] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Another Mac Lion build fix attempt after r148197.

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:
5:08 PM Changeset in webkit [148251] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Unable to paste twice in input field when specific CSS present
https://bugs.webkit.org/show_bug.cgi?id=108675

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Ryosuke Niwa.

Source/WebCore:

When we are pre-rendering text in ReplaceSelectionCommand, we shouldn't care
whether the content is clipped by its ancestors or not. This bug was caused
by the fact the plainText() method returned an empty string because the text
was fully clipped by its ancestors. Make plainText ignore style visibility.

Test: editing/inserting/insert-text-into-text-field.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplacementFragment::ReplacementFragment):

LayoutTests:

  • editing/inserting/insert-text-into-text-field-expected.txt: Added.
  • editing/inserting/insert-text-into-text-field.html: Added.
4:55 PM Changeset in webkit [148250] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Add support for clearing storage areas
https://bugs.webkit.org/show_bug.cgi?id=114479

Reviewed by Beth Dakin.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::StorageArea):
Store the quota size so we can recreate the underlying StorageMap when clearing.

(WebKit::StorageManager::StorageArea::clear):
Create a new storage map and dispatch events.

(WebKit::StorageManager::clear):
Find the right storage area and call clear.

  • UIProcess/Storage/StorageManager.messages.in:

Add Clear message.

  • WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::clear):
Call the storage map.

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::clear):
Reset the cached values and send a clear message.

(WebKit::StorageAreaMap::resetValues):
New helper function.

(WebKit::StorageAreaMap::didClear):
New stub.

  • WebProcess/Storage/StorageAreaMap.messages.in:

Add DidClear message.

4:51 PM Changeset in webkit [148249] by bdakin@apple.com
  • 4 edits in trunk/Source/WebKit2

WebKit should set the header and footer layers' contentsScale when the device
scale factor changes
https://bugs.webkit.org/show_bug.cgi?id=114471
-and corresponding-
<rdar://problem/13621288>

Reviewed by Simon Fraser.

Update the header and footer contentsScale when the device scale factor has
changed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setDeviceScaleFactor):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::updateHeaderAndFooterLayersForDeviceScaleChange):

4:46 PM Changeset in webkit [148248] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Webkit fails to build with MinGW compiler after changeset 146468
https://bugs.webkit.org/show_bug.cgi?id=114473

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-04-11
Reviewed by Martin Robinson.

  • Source/autotools/CheckSystemAndBasicDependencies.m4: Fix typo.
4:39 PM Changeset in webkit [148247] by mrobinson@webkit.org
  • 18 edits in trunk

[GTK] Add accelerated 2D canvas support using cairo-gl
https://bugs.webkit.org/show_bug.cgi?id=104672

Reviewed by Alejandro G. Castro.

.:

Detect that we can activate accelerated canvas when CairoGL is present and
TextureMapperGL is enabled.

  • Source/autotools/FindDependencies.m4: Look for CairoGL.
  • Source/autotools/PrintBuildConfiguration.m4: Print the status of accelerated canvas activation.
  • Source/autotools/SetupWebKitFeatures.m4: Set the feature.

Source/WebCore:

No new tests. We do not yet have the ability to run tests against
accelerated content.

  • platform/graphics/GraphicsContext.cpp:

(WebCore): We don't use the stub implementation of isAcceleratedContext any longer.

  • platform/graphics/ImageBuffer.cpp:

(WebCore): Ditto for ImageBuffer::platformLayer.

  • platform/graphics/cairo/GLContext.h:

(GLContext): Added method to get a cairo_device_t from the context.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::isAcceleratedContext): Return true when we are a CairoGL surface.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::ImageBufferData): Initialize the size and the texture to 0.
(WebCore::createCairoGLSurface): Added this helper.
(WebCore::ImageBuffer::ImageBuffer): When we are in accelerated rendering mode, create
a CairoGL surface.
(WebCore::ImageBuffer::platformTransformColorSpace): Do not implement this for accelerated
contexts yet.
(WebCore::mapSurfaceToImage): Added this helper, since we don't require Cairo 1.12 yet,
which provides an builtin implementation.
(WebCore::unmapSurfaceFromImage): Ditto.
(WebCore::getImageData): Map the surface to an image surface first.
(WebCore::ImageBuffer::putByteArray): Ditto.
(WebCore::ImageBufferData::paintToTextureMapper): Connect the accelerated canvas into the
TextureMapper infrastructure.
(WebCore::ImageBuffer::platformLayer): This lets the TextureMapper at the ImageBufferData.

  • platform/graphics/cairo/ImageBufferDataCairo.h:

(ImageBufferData): Subclass TexturMapperPlatformLayer where appropriate.

  • platform/graphics/egl/GLContextEGL.cpp: Added implementation of cairoDevice.
  • platform/graphics/egl/GLContextEGL.h: Ditto.
  • platform/graphics/glx/GLContextGLX.cpp: Ditto
  • platform/graphics/glx/GLContextGLX.h: Ditto.

Tools:

Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
dependencies, don't override value of the setting determined by configure.
This will make it easier for people using build-webkit, but not the
WebKit JHBuild.

  • Scripts/webkitdirs.pm:

(buildAutotoolsProject): Add a blacklist for settings to never override.

  • gtk/jhbuild.modules: Build CairoGL.
4:31 PM Changeset in webkit [148246] by rniwa@webkit.org
  • 2 edits in trunk/Tools

build.webkit.org should link to webkit-queues instead of webkit-commit-queue
https://bugs.webkit.org/show_bug.cgi?id=114477

Reviewed by Benjamin Poulain.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4:26 PM Changeset in webkit [148245] by andersca@apple.com
  • 10 edits in trunk/Source

Implement removing storage area items
https://bugs.webkit.org/show_bug.cgi?id=114472

Reviewed by Beth Dakin.

Source/WebCore:

Export StorageMap::removeItem.

  • WebCore.exp.in:

Source/WebKit2:

  • UIProcess/Storage/StorageManager.cpp:

(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::setItem):
Rename connection to sourceConnection.

(WebKit::StorageManager::StorageArea::removeItem):
Remove the item from the map and dispatch events if needed.

(WebKit::StorageManager::removeItem):
Find the right storage area, remove the item and send back a DidRemoveItem message.

  • UIProcess/Storage/StorageManager.messages.in:

Add RemoveItem message.

  • WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::removeItem):
Call StorageAreaMap::removeItem.

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::removeItem):
Send a RemoveItem message to the storage manager.

(WebKit::StorageAreaMap::didRemoveItem):
Add empty stub.

  • WebProcess/Storage/StorageAreaMap.messages.in:

Add DidRemoveItem message.

4:25 PM Changeset in webkit [148244] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

TextTrackList's .onremovetrack is missing from IDL
https://bugs.webkit.org/show_bug.cgi?id=103421

Patch by Brendan Long <b.long@cablelabs.com> on 2013-04-11
Reviewed by Eric Carlson.

Source/WebCore:

Fixed test media/track/opera/interfaces/TextTrackList/onremovetrack.html

  • html/track/TextTrackList.cpp:

(TextTrackList::remove):
(TextTrackList::scheduleRemoveTrackEvent):

  • html/track/TextTrackList.h:

(TextTrackList):

  • html/track/TextTrackList.idl:

LayoutTests:

  • media/track/opera/interfaces/TextTrackList/onremovetrack-expected.txt: Added.
4:24 PM WebKit Team edited by silviapf@chromium.org
added my irc handles and new employer (diff)
4:20 PM Changeset in webkit [148243] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Leaks builder should not be triggered upon new commits
https://bugs.webkit.org/show_bug.cgi?id=114475

Reviewed by Jessie Berlin.

Don't trigger them on new checkins wait for Mountaion Lion (Build), which already triggers
the leak builder when builds are done.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
4:18 PM WebKitGTK/2.0.x edited by mrobinson@webkit.org
(diff)
4:09 PM Changeset in webkit [148242] by commit-queue@webkit.org
  • 1 edit
    18 adds in trunk/Source/WebCore

[BlackBerry] Upstream the filesystem code
https://bugs.webkit.org/show_bug.cgi?id=114437

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-11
Reviewed by Rob Buis.

This patch contains contributions from many members of the
BlackBerry WebKit team.

  • platform/blackberry/AsyncFileWriterBlackBerry.cpp: Added.

(WebCore):
(WebCore::AsyncFileWriterBlackBerry::write):

  • platform/blackberry/AsyncFileWriterBlackBerry.h: Added.

(WTF):
(WTF::BlackBerry::Platform::WebFileWriter):
(WebCore):

  • platform/blackberry/DOMFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::DOMFileSystemBase::createFileSystemURL):
(WebCore::DOMFileSystemBase::crackFileSystemURL):
(WebCore::DOMFileSystemBase::supportsToURL):
(WebCore::DOMFileSystemBase::isValidType):

  • platform/blackberry/LocalFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::fileSystemTypeString):
(WebCore::openFileSystem):
(WebCore::LocalFileSystem::deleteFileSystem):
(WebCore::LocalFileSystem::readFileSystem):
(WebCore::LocalFileSystem::requestFileSystem):

  • platform/blackberry/PlatformAsyncFileSystemCallbacks.cpp: Added.

(WebCore):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::getFileMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateSnapshotFileAndReadMetadata):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::PlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::PlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::PlatformAsyncFileSystemCallbacks::deleteMe):

  • platform/blackberry/PlatformAsyncFileSystemCallbacks.h: Added.

(WebCore):

  • platform/blackberry/PlatformBlob.cpp: Added.

(WebCore):
(WebCore::PlatformBlob::nextDataItem):

  • platform/blackberry/PlatformBlob.h: Added.

(WebCore):

  • platform/blackberry/PlatformFileWriterClient.cpp: Added.

(WebCore):
(WebCore::PlatformFileWriterClient::notifyWrite):
(WebCore::PlatformFileWriterClient::notifyTruncate):
(WebCore::PlatformFileWriterClient::notifyFail):

  • platform/blackberry/PlatformFileWriterClient.h: Added.

(WebCore):
(WTF):
(WTF::WebCore::PlatformFileWriterClient):

  • platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp: Added.

(WebCore):
(WebCore::WorkerAsyncFileSystemBlackBerry::WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::~WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystem):
(WebCore::WorkerAsyncFileSystemBlackBerry::move):
(WebCore::WorkerAsyncFileSystemBlackBerry::copy):
(WebCore::WorkerAsyncFileSystemBlackBerry::remove):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursively):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadata):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFile):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExists):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectory):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriter):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadata):

  • platform/blackberry/WorkerAsyncFileSystemBlackBerry.h: Added.

(WebCore):
(WorkerAsyncFileSystemBlackBerry):
(WebCore::WorkerAsyncFileSystemBlackBerry::create):

  • platform/blackberry/WorkerAsyncFileWriterBlackBerry.cpp: Added.

(WebCore):
(WebCore::WorkerAsyncFileWriterBlackBerry::writeOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncateOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::abortOnMainThread):
(WebCore::WorkerAsyncFileWriterBlackBerry::write):
(WebCore::WorkerAsyncFileWriterBlackBerry::truncate):
(WebCore::WorkerAsyncFileWriterBlackBerry::abort):
(WebCore::WorkerAsyncFileWriterBlackBerry::waitForOperationToComplete):
(WebCore::WorkerAsyncFileWriterBlackBerry::platformWriterClient):

  • platform/blackberry/WorkerAsyncFileWriterBlackBerry.h: Added.

(WebCore):

  • platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.cpp: Added.

(WebCore):
(WebCore::performTaskOnMainThread):
(WebCore::postTaskToMainThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyStop):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceed):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFail):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadata):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectory):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileSystem):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::createAsyncFileWriter):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::deleteMe):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::postTaskToWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyOpenFileSystemOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifySucceedOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadMetadataOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyReadDirectoryEntryOnWorkerThread):
(WebCore::WorkerPlatformAsyncFileSystemCallbacks::notifyCreateFileWriterOnWorkerThread):

  • platform/blackberry/WorkerPlatformAsyncFileSystemCallbacks.h: Added.

(WebCore):

  • platform/blackberry/WorkerPlatformFileWriterClient.cpp: Added.

(WebCore):
(WebCore::WorkerPlatformFileWriterClient::notifyWriteOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyFailOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncateOnWorkerThread):
(WebCore::WorkerPlatformFileWriterClient::notifyWrite):
(WebCore::WorkerPlatformFileWriterClient::notifyTruncate):
(WebCore::WorkerPlatformFileWriterClient::notifyFail):
(WebCore::WorkerPlatformFileWriterClient::postTaskToWorkerThreadIfNeeded):

  • platform/blackberry/WorkerPlatformFileWriterClient.h: Added.

(WebCore):
(WTF):
(WTF::WebCore::WorkerPlatformFileWriterClient):

4:04 PM Changeset in webkit [148241] by roger_fong@apple.com
  • 3 edits in trunk/WebKitLibraries

Build fix.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib/WebKitSystemInterface.lib:
3:56 PM Changeset in webkit [148240] by ap@apple.com
  • 4 edits in trunk/WebKitLibraries

<rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
https://bugs.webkit.org/show_bug.cgi?id=114464

Update WebKitSystemInterface.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
3:17 PM Changeset in webkit [148239] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Mac Lion build fix attempt after r148197.

  • page/scrolling/mac/ScrollingStateNodeMac.mm:
2:50 PM Changeset in webkit [148238] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

InjectedBundleNodeHandle::imageForRect doesn't respect device scale factor or highlighting option
https://bugs.webkit.org/show_bug.cgi?id=114466
<rdar://problem/13508513>

Reviewed by Simon Fraser.

Respect the device scale factor when creating the snapshot image.
Clear the snapshot image before drawing into it.
Respect SnapshotOptionsExcludeSelectionHighlighting.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

2:42 PM Changeset in webkit [148237] by ap@apple.com
  • 4 edits in trunk/Source/WebCore

<rdar://problem/10416316> [Mac] WebSocket doesn't work with authenticating proxies
https://bugs.webkit.org/show_bug.cgi?id=114464

Reviewed by Brady Eidson.

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm: Updated for new wkCopyCONNECTProxyResponse signature.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: (WebCore::SocketStreamHandle::executePACFileURL): Fixed a typo in a comment. (WebCore::SocketStreamHandle::addCONNECTCredentials): Don't crash even if the rest of the fix didn't work (which would be the case on some OS versions). (WebCore::SocketStreamHandle::readStreamCallback): Replaced most breaks with returns, because breaks were confusing in such a huge switch. Changed null proxyResponse to not be treated as authentication success, because it's not. Merged two parts of WaitingForConnect state handling for clarity. (WebCore::SocketStreamHandle::writeStreamCallback): Don't blindly assume that we can start WebSocket handshake after kCFStreamEventCanAcceptBytes. Perhaps it's nothing but a failed CONNECT, and a read callback still needs to send authentication. Without this, establishing connections was flaky. Added a check for Closed state, matching read callback.
2:41 PM Changeset in webkit [148236] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

MutationRecord is not exposed
https://bugs.webkit.org/show_bug.cgi?id=114288

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2013-04-11
Reviewed by Darin Adler.

Source/WebCore:

Expose MutationRecord on DOMWindow. This patch is copied from a patch
by Adam Klein. https://codereview.chromium.org/13861028

Test: fast/dom/MutationObserver/mutation-record-constructor.html

  • page/DOMWindow.idl:

LayoutTests:

This test is copied from a patch by Adam Klein.
https://codereview.chromium.org/13861028
The test expectation of "typeof MutationRecord" is changed from
"function" to "object". (See bug 114457)

  • fast/dom/MutationObserver/mutation-record-constructor-expected.txt: Added.
  • fast/dom/MutationObserver/mutation-record-constructor.html: Added.
2:28 PM Changeset in webkit [148235] by Lucas Forschler
  • 3 edits
    2 copies in branches/safari-536.30-branch

Merged r136554. <rdar://problem/13334986>

2:01 PM Changeset in webkit [148234] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Cannot scroll to footer on a page with overflow:hidden on the body
https://bugs.webkit.org/show_bug.cgi?id=114462
-and corresponding-
<rdar://problem/13530042>

Reviewed by Simon Fraser.

Add a new scenario in which we want to overrideHidden -- whenever we are the
mainFrame and there is a header or footer.

  • page/FrameView.cpp:

(WebCore::FrameView::applyOverflowToViewport):

2:01 PM WebKitGTK/2.0.x edited by kalevlember@gmail.com
Added r148230 as proposed merge (diff)
1:57 PM WebKitGTK/2.0.x edited by kalevlember@gmail.com
Added r147963 as proposed merge (diff)
1:53 PM Changeset in webkit [148233] by rniwa@webkit.org
  • 12 edits in trunk/Source

Unreviewed, rolling out r148034, r148052, r148097, and
r148194.
http://trac.webkit.org/changeset/148034
http://trac.webkit.org/changeset/148052
http://trac.webkit.org/changeset/148097
http://trac.webkit.org/changeset/148194
https://bugs.webkit.org/show_bug.cgi?id=114463

broke mutiresolution favicons, among other things (Requested
by thorton on #webkit).

Source/WebCore:

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconDataForIconURL):

  • loader/icon/IconDatabase.h:

(IconDatabase):

  • loader/icon/IconDatabaseBase.h:
  • loader/icon/IconRecord.cpp:
  • loader/icon/IconRecord.h:

(IconRecord):

Source/WebKit2:

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setIconDataForIconURL):

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):

  • UIProcess/WebIconDatabase.messages.in:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::destroy):

1:51 PM Changeset in webkit [148232] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GTK][AC] Implement GraphicsLayerClutter::moveOrCopyAnimations
https://bugs.webkit.org/show_bug.cgi?id=114019

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-11
Reviewed by Gustavo Noronha Silva.

Fill moveOrCopyAnimations that is based on Mac port implementation.

Tests: animations/3d/change-transform-in-end-event.html

animations/3d/transform-origin-vs-functions.html
compositing/animation/state-at-end-event-transform-layer.html

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::moveOrCopyLayerAnimation):
(WebCore):
(WebCore::GraphicsLayerClutter::moveOrCopyAnimations):

  • platform/graphics/clutter/GraphicsLayerClutter.h:
1:34 PM Changeset in webkit [148231] by andersca@apple.com
  • 4 edits in trunk/Source

Implement StorageManager::getValues
https://bugs.webkit.org/show_bug.cgi?id=114461

Reviewed by Beth Dakin.

Source/WebCore:

Expose the item hash map.

  • storage/StorageMap.h:

(WebCore::StorageMap::items):

Source/WebKit2:

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::items):
(WebKit::StorageManager::getValues):
Return the items from the right storage area.

1:22 PM Changeset in webkit [148230] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Windows build failure after r136056
https://bugs.webkit.org/show_bug.cgi?id=114121

Patch by Kalev Lember <kalevlember@gmail.com> on 2013-04-11
Reviewed by Martin Robinson.

  • TestWebKitAPI/config.h: Make sure defines are correct for other

Windows ports than apple-win.

1:14 PM Changeset in webkit [148229] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Clean up related storage areas when a connection is destroyed
https://bugs.webkit.org/show_bug.cgi?id=114459

Reviewed by Beth Dakin.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillCloseConnection):
Dispatch invalidateConnectionInternal on the work queue.

(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
Rename m_storageAreas to m_storageAreasByConnection.

(WebKit::StorageManager::invalidateConnectionInternal):
Go over all known storage areas and remove this connection as a listener.

(WebKit::StorageManager::findStorageArea):
Rename m_storageAreas to m_storageAreasByConnection.

  • UIProcess/Storage/StorageManager.h:

Rename m_storageAreas to m_storageAreasByConnection.

1:08 PM Changeset in webkit [148228] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Use the platform list of languages with fonts instead of hardcoding
https://bugs.webkit.org/show_bug.cgi?id=114452

Patch by Eli Fidler <efidler@blackberry.com> on 2013-04-11
Reviewed by Rob Buis.

BlackBerry PR 325244
Internally reviewed by Jeff Rogers

No functional change, but platform font changes won't need a WebKit change
going forward.

  • page/blackberry/SettingsBlackBerry.cpp:

(WebCore::Settings::initializeDefaultFontFamilies):

1:05 PM Changeset in webkit [148227] by krit@webkit.org
  • 8 edits
    6 adds in trunk

[CSS Shaders] Parse parameters descriptor
https://bugs.webkit.org/show_bug.cgi?id=114455

Reviewed by Dean Jackson.

Source/WebCore:

Add support for the 'parameters' descriptor in the filter at-rule to support
parameterization of CSS Shaders.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-parameters

Tests: css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp: Added 'parameters' property and fail parsing if not inside

of an @filter rule.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleParameters): New helper function to verify

values.

(WebCore):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Added new property name 'parameters'.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Tests for the 'parameters' descriptor on @filter rule.

  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-invalid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-parameters-property-valid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-invalid.js: Added.

(testInvalidParametersProperty):

  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-parameters-property-valid.js: Added.

(testParametersProperty):

1:01 PM Changeset in webkit [148226] by fpizlo@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

Get rid of the 10ms delay between test executions
https://bugs.webkit.org/show_bug.cgi?id=114458
<rdar://problem/13631112>

Reviewed by Darin Adler and Geoffrey Garen.

More details on this in the bug. Long story short, I don't know why the 10ms delay is
there, and it appears to be the root of some noisyness and unreliability in the results.
Removing it makes results more consistent, which is a good thing.

  • resources/driver-TEMPLATE.html:
12:56 PM Changeset in webkit [148225] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Initial scale changes depending on the order of page navigations
https://bugs.webkit.org/show_bug.cgi?id=114448

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 323941
During page transitions, absoluteVisibleOverflowSize() and contentsSize()
in fixedLayoutSize() were based on the old page when we just started or
committed provisinal load. In that case, fixedLayoutSize() is very old
page dependent and can cause inconsistent behaviors. For example, if
the old page contents width is 4000, we will get DEFAULT_MAX_LAYOUT_WIDTH 1024
as the new page's fixedLayoutSize; however, we will get 768 if we
navigate to the new page directly.
To fix that, return default layout size if the page doesn't have
virtual viewport and m_loadState is Provisional.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize):

12:37 PM Changeset in webkit [148224] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Default Implementation of toString for NPObject shouldn't return NPClass & NPObject address as String
https://bugs.webkit.org/show_bug.cgi?id=114450

Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::stringValue):

12:17 PM Changeset in webkit [148223] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (142152): ensure we skip past out-of-flow objects when detecting whitespace to ignore after leading empty inlines
https://bugs.webkit.org/show_bug.cgi?id=114311

Reviewed by Emil A Eklund.

Source/WebCore:

When we hit an empty inline in line layout and try to detect whether it has any whitespace after it that we ought to ignore, then
we need to skip past out-of-flow and floating objects when looking for that whitespace. Failure to do so will result in us
adding the width from the first space we encounter to our line width and over-estimating the real width of the line.

We're hitting this bug now because we have broadened the category of empty inlines that get lineboxes so we go into line layout
and have to deal with them and their subsequent whitespace there. Previously this sort of whitespace would have been simply
consumed by |skipLeadingWhitespace|.

Test: fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldSkipWhitespaceAfterStartObject):

LayoutTests:

  • fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline-expected.txt: Added.
  • fast/inline/out-of-flow-objects-and-whitespace-after-empty-inline.html: Added.
12:14 PM Changeset in webkit [148222] by ojan@chromium.org
  • 2 edits in trunk/Tools

Remove myself from watchlists.

  • Scripts/webkitpy/common/config/watchlist:
11:56 AM Changeset in webkit [148221] by rniwa@webkit.org
  • 18 edits in trunk

Autocorrected text doesn't have a marker of type autocorrected
https://bugs.webkit.org/show_bug.cgi?id=114337

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by markAndReplaceFor's text replacement errornously assuming that there are
no other text checking result starting at the same offset. That resulted in us adjusting location
offsets of the subsequent results pointing at the replaced text, hit an assertion, and blow up.

Fixed the bug by skipping all remaining results for the replaced text since they're no longer
applicable.

Tests: Existing autocorection tests have been updated to assert new behavior.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Updated tests to assert the existence of "autocorrected" markers.

  • platform/mac/editing/spelling/click-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word.html:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
11:54 AM Changeset in webkit [148220] by Michelangelo De Simone
  • 8 edits
    6 adds in trunk

[CSS Shaders] Parse the geometry descriptor
https://bugs.webkit.org/show_bug.cgi?id=110815

Source/WebCore:

Added initial parsing for the "geometry" descriptor, as per specification:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry
This descriptor allows to specify the mesh geometry for custom filters.

Reviewed by Dirk Schulze.

Tests: css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGeometry): New method that parses the geometry
descriptor (grid()).
(WebCore):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Added conditional "geometry" property.
  • css/CSSValueKeywords.in: Added conditional "attached" value keyword; detached

was already there.

LayoutTests:

Positive and negative parsing tests for the "geometry" descriptor as
per specification:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#geometry

Reviewed by Dirk Schulze.

  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-invalid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-geometry-property-valid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-invalid.js: Added.

(testInvalidGeometryProperty):

  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-geometry-property-valid.js: Added.

(testGeometryProperty):

11:43 AM Changeset in webkit [148219] by andersca@apple.com
  • 6 edits in trunk/Source

Make StorageAreaMap dispatch session storage events
https://bugs.webkit.org/show_bug.cgi?id=114454

Reviewed by Beth Dakin.

Source/WebCore:

Export storage symbols and headers needed by WebKit2.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::dispatchStorageEvent):
Depending on the storage area type, call dispatchSessionStorageEvent or dispatchLocalStorageEvent.

(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
Enumerate all the frames in our page and dispatch the event to the relevant ones.

(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
Add empty stub for now.

11:39 AM Changeset in webkit [148218] by zandobersek@gmail.com
  • 2 edits in trunk

Unreviewed.

  • Source/autotools/symbols.filter: Stop exporting redundant symbols.
11:27 AM Changeset in webkit [148217] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Removing expectations for a bunch of tests that are passing.
11:19 AM Changeset in webkit [148216] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix. Don't hard-code queues.webkit.org at least during the transition.

  • QueueStatusServer/templates/statusbubble.html:
10:44 AM Changeset in webkit [148215] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Implement more logic in StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114451

Reviewed by Alexey Proskuryakov.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::addListener):
(WebKit::StorageManager::StorageArea::removeListener):
These take storage map IDs.

(WebKit::StorageManager::StorageArea::setItem):
Rename storageAreaID to sourceStorageAreaID.

(WebKit::StorageManager::StorageArea::dispatchEvents):
Remove the code that would not dispatch to the source connection, there may still be storage areas interested in those events.

(WebKit::StorageManager::setItem):
This now takes the source storage area ID.

(WebKit::StorageManager::findStorageArea):
This takes a storage map ID.

  • UIProcess/Storage/StorageManager.messages.in:

SetItem now takes the source storage area ID as well.

  • WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::setItem):
Pass the source frame to StorageAreaMap::setItem.

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::StorageAreaMap::StorageAreaMap):
Send CreateStorageMap and add the object as a message receiver.

(WebKit::StorageAreaMap::~StorageAreaMap):
Send DestroyStorageMap and remove the object as a message receiver.

(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::contains):
Load values and forward calls to the storage map.

(WebKit::StorageAreaMap::setItem):
This now takes the source frame as well. Update the local storage map and send a SetItem message.

(WebKit::StorageAreaMap::loadValuesIfNeeded):
Get the values from the storage manager.

(WebKit::StorageAreaMap::dispatchStorageEvent):
This now takes the source storage area ID.

  • WebProcess/Storage/StorageAreaMap.messages.in:

DispatchStorageEvent now takes the source storage area ID.

10:18 AM Changeset in webkit [148214] by beidson@apple.com
  • 5 edits in trunk

Web/Plugin process deadlock initializing async plugins.
<rdar://problem/13525232> and https://bugs.webkit.org/show_bug.cgi?id=114217

Rubberstamped by Anders Carlsson.

Rollout r147953 and r147968 as we identified other causes for this.

Source/WebKit2:

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::createPluginAsynchronously):

  • WebProcess/Plugins/PluginProxy.messages.in:

LayoutTests:

  • platform/mac-wk2/TestExpectations:
10:02 AM Changeset in webkit [148213] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] Run toString & valueOf LayoutTests for WebKit2 also
https://bugs.webkit.org/show_bug.cgi?id=114433

Patch by Arunprasad Rajkumar <arunprasadr@nds.com> on 2013-04-11
Reviewed by Anders Carlsson.

  • platform/wk2/TestExpectations:
9:55 AM Changeset in webkit [148212] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397

Reviewed by Benjamin Poulain.

Reland the patch since Alan appears to have finished the migration.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

9:52 AM Changeset in webkit [148211] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

handleMouseMoveEvent should let hit-testing hit-test scrollbars
https://bugs.webkit.org/show_bug.cgi?id=114430

Reviewed by Antonio Gomes.

Allow hit-testing to hit-test frame scrollbars so handleMouseMoveEvent
does not have to do it itself.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseMoveEvent):

9:38 AM Changeset in webkit [148210] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=76796

Patch by Brian Holt <brian.holt@samsung.com> on 2013-04-11
Reviewed by Chris Fleizach.

Source/WebCore:

When using caret-browsing with the right and left arrows, the
behaviour of menuLists should be the same as listBoxes. This means
not default-handling the event and passing it up the stack instead.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):

Tools:

Make the Gtk window for the DRT a toplevel so that it gets the
focus from the window manager when the test starts.

  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(main):

LayoutTests:

Adding a new test to verify that it is possible to arrow out of
combo boxes when caret browsing is enabled. Updated failing tests
to reflect changed accessibility events in the DRT.

  • platform/gtk/accessibility/aria-slider-required-attributes-expected.txt: Updated.
  • platform/gtk/accessibility/caret-browsing-select-focus-expected.txt: Added.
  • platform/gtk/accessibility/caret-browsing-select-focus.html: Added.
  • platform/gtk/accessibility/combo-box-collapsed-selection-changed-expected.txt: Updated.
9:32 AM Changeset in webkit [148209] by ap@apple.com
  • 17 edits in trunk/Source

Remove some ResourceHandle.h includes
https://bugs.webkit.org/show_bug.cgi?id=114416

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightResultCache.h:

These files don't need ResourceHandle.h, just ResourceHandleTypes.h.

  • loader/TextTrackLoader.cpp:
  • loader/ThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/cache/MemoryCache.h:
  • loader/mac/ResourceLoaderMac.mm:
  • page/Settings.cpp:
  • platform/network/AuthenticationChallengeBase.cpp:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequestCFNet.cpp:
  • xml/XSLTProcessorLibxslt.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

Just straightforward removal of includes.

Source/WebKit2:

  • WebProcess/Network/NetworkProcessConnection.cpp: Added an include that is now

necessary.

9:19 AM Changeset in webkit [148208] by allan.jensen@digia.com
  • 9 edits in trunk

Use CSS4 image-rendering to determing image scaling quality
https://bugs.webkit.org/show_bug.cgi?id=113405

Reviewed by Simon Fraser.

Source/WebCore:

Implement the new CSS4 image-rendering property values.

Image scaling now uses low-quality (pixelated) scaling for
crisp-edges, pixelated and optimizeSpeed values, and always
use high quality (smooth) scaling for -webkit-smooth and
optimizeQuality. The latter can be used to disable low quality
scaling during CSS animations or live resizing.

The new values are protected with a new CSS4_IMAGES feature, but
the crisp-edge value has been introduced before to displace the
deprecated -webkit-optimize-contrast value, and optimizeSpeed
and optimizeQuality values are supported for SVG compatibility.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EImageRendering):

  • css/CSSValueKeywords.in:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::paintReplaced):

  • rendering/style/RenderStyleConstants.h:

Tools:

Introduce new flag to enable experimental support for CSS4 Images.

  • Scripts/webkitperl/FeatureList.pm:
9:19 AM Changeset in webkit [148207] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Added UNLIKELY() suggested in https://bugs.webkit.org/show_bug.cgi?id=114366
after checking in the original change.

Rubber-stamped by Jessie Berlin.

  • dfg/DFGOperations.cpp:
9:02 AM Changeset in webkit [148206] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix: use of uninitialized variable in ScrollingStateTree
https://bugs.webkit.org/show_bug.cgi?id=114443

Patch by Adenilson Cavalcanti <cavalcantii@gmail.com> on 2013-04-11
Reviewed by Anders Carlsson.

Initialize pointer to zero before use, fixes build.
No new tests, no changes on behavior.

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::attachNode):

8:55 AM Changeset in webkit [148205] by krit@webkit.org
  • 8 edits
    6 adds in trunk

[CSS Shaders] Parse mix descriptor
https://bugs.webkit.org/show_bug.cgi?id=114414

Reviewed by Antti Koivisto.

Source/WebCore:

Add support for the 'mix' descriptor in the filter at-rule to support blend modes
and composite operators in CSS Shaders.
Each pixel in the fragment shader will be blended and composited with the
backdrop by taking these values into account.

https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-mix

Tests: css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html

css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp: Added 'mix' property and fail parsing if not inside

of an @filter rule.

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleMix): New helper function to verify

values.

(WebCore):

  • css/CSSParser.h:
  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in: Added new property name 'mix'.
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Tests for the 'mix' descriptor on @filter rule.

  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-invalid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid-expected.txt: Added.
  • css3/filters/custom-with-at-rule-syntax/parsing-mix-property-valid.html: Added.
  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-invalid.js: Added.

(testInvalidMixProperty):

  • css3/filters/custom-with-at-rule-syntax/script-tests/parsing-mix-property-valid.js: Added.

(testMixProperty):

8:09 AM Changeset in webkit [148204] by abecsi@webkit.org
  • 2 edits in trunk/Source/ThirdParty/ANGLE

[Qt][Mac] Linking fails with Qt 5.1
https://bugs.webkit.org/show_bug.cgi?id=114435

Reviewed by Tor Arne Vestbø.

Qt 5.1 enables C++11 by default when using clang on Mac
and links against the libc++ standard library. As a result
building the QtWebKit shared library fails when linking
agains the ANGLE intermediate static library because libc++
misses some symbols needed by ANGLE.
Disable C++11 for the ANGLE intermediate library to fix the build.

  • ANGLE.pri:
7:51 AM Changeset in webkit [148203] by commit-queue@webkit.org
  • 5 edits in trunk

Parent box with background-size auto and gradient image does not get properly repainted when child box is resized.
https://bugs.webkit.org/show_bug.cgi?id=114424

Source/WebCore:

Patch by Zalan Bujtas <zalan@apple.com> on 2013-04-11
Reviewed by Antti Koivisto.

Initiate full repaint on fill layer, when the image is generated and the background
property defines auto size.
http://www.w3.org/TR/css3-background/#background-size
'If the image has neither an intrinsic width nor an intrinsic height, its size is determined as for 'contain'.'

Extended fast/repaint/background-shorthand-with-gradient-and-height-changes.html
to cover this case too.

  • rendering/RenderObject.cpp:

(WebCore::mustRepaintFillLayers):

LayoutTests:

Patch by Zalan Bujtas <zalan@apple.com> on 2013-04-11
Reviewed by Antti Koivisto.

  • fast/repaint/background-shorthand-with-gradient-and-height-changes-expected.txt:
  • fast/repaint/background-shorthand-with-gradient-and-height-changes.html:
7:42 AM Changeset in webkit [148202] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][AC] use a smart pointer for GList and ClutterCanvas
https://bugs.webkit.org/show_bug.cgi?id=114057

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-11
Reviewed by Gustavo Noronha Silva.

We can make simple code & prevent possible memory leak by using a proper smart pointer.
Especially if we get children by clutter_actor_get_children, we should free it after using.

No functionality changed.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorUpdateTexture):
(graphicsLayerActorRemoveAll):

7:36 AM Changeset in webkit [148201] by anilsson@rim.com
  • 3 edits in trunk/Source/WebCore

[BlackBerry][CSS Filters] Blur filter fails to recompute blur size when layer size changes
https://bugs.webkit.org/show_bug.cgi?id=114272

Reviewed by Rob Buis.

Blur appeared blocky or pixelated when surface changed size after
creating the filter actions. The initial image size was used to
determine the blur size (expressed in texture coordinate system).
Fixed by recomputing the blur size when the surface size changes, using
a new Uniform1f subclass that can use a functor to compute the uniform
value per-frame.

This fixes css3/filters/effect-blur-hw.html. This can only be verified
by manual inspection because the BlackBerry port is not currently using
pixel tests.

PR 323730

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore):
(SurfaceFunctor):
(WebCore::SurfaceFunctor::SurfaceFunctor):
(InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::InverseSurfaceWidth):
(WebCore::InverseSurfaceWidth::operator()):
(InverseSurfaceHeight):
(WebCore::InverseSurfaceHeight::InverseSurfaceHeight):
(WebCore::LayerFilterRenderer::actionsForOperations):

  • platform/graphics/blackberry/LayerFilterRenderer.h:

(Uniform1f):
(WebCore):
(Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::create):
(WebCore::Uniform1fWithFunctor::Uniform1fWithFunctor):
(WebCore::Uniform1fWithFunctor::apply):
(WebCore::Uniform1f::createWithFunctor):

7:28 AM Changeset in webkit [148200] by anilsson@rim.com
  • 4 edits in trunk/Source/WebCore

[BlackBerry] Accelerated compositing debug rectangle incorrectly drawn for layers with surfaces
https://bugs.webkit.org/show_bug.cgi?id=114275

Reviewed by Carlos Garcia Campos.

The drawDebugBorder method was updated to mirror the logic in
compositeLayersRecursive, i.e. if we're compositing a surface to the
screen, use the transformed bounds stored in the surface. The bounds
stored in the layer should only be used when drawing the layer to the
surface.

Speaking of which, also update the code to skip border drawing when
drawing a layer to a surface. Drawing the borders inside the surface
would only result in messing up the surface contents, especially when
CSS filters like blur were the reason for having a surface in the first
place - the border would be blurred and hard to discern.

Only manually testable, the debug border is disabled during layout
tests.

PR 323746

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::drawDebugBorder):

  • platform/graphics/blackberry/LayerRendererSurface.cpp:

(WebCore::LayerRendererSurface::drawRect):
(WebCore::LayerRendererSurface::transformedBounds): Added.
(WebCore):

  • platform/graphics/blackberry/LayerRendererSurface.h:

(LayerRendererSurface):

7:27 AM Changeset in webkit [148199] by anilsson@rim.com
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Compiler warning in LayerWebKitThread.cpp
https://bugs.webkit.org/show_bug.cgi?id=114277

Reviewed by Carlos Garcia Campos.

All the relevant WTF::Vector APIs use size_t, storing the position in
an int resulted in a compiler warning. Fixed by switching to size_t.

No change in behavior, no new tests.

PR 323753

  • platform/graphics/blackberry/LayerWebKitThread.cpp:

(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):

6:39 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
6:36 AM Changeset in webkit [148198] by Carlos Garcia Campos
  • 3 edits
    8 adds in releases/WebKitGTK/webkit-2.0

Merge r148182 - FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418

Source/WebCore:

Reviewed by Darin Adler.

When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade

Test: loader/go-back-cached-main-resource.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

LayoutTests:

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-11
Reviewed by Darin Adler.

  • loader/go-back-cached-main-resource-expected.txt: Added.
  • loader/go-back-cached-main-resource.html: Added.
  • loader/resources/first-page.html: Added.
  • loader/resources/other-page.html: Added.
  • platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
  • platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.
6:16 AM Changeset in webkit [148197] by mikhail.pozdnyakov@intel.com
  • 15 edits
    2 adds in trunk/Source/WebCore

[CoordinatedGraphics] Use ScrollingStateTree to handle fixed elements positioning while scrolling
https://bugs.webkit.org/show_bug.cgi?id=114353

Reviewed by Noam Rosenthal.

ScrollingCoordinatorCoordinatedGraphics should implement threaded scrolling interface and
re-use threaded scrolling approach (ScrollingStateTree and ViewportConstraints) to handle
fixed/sticky elements positioning while scrolling. The rationals are below.

Before the change ScrollingCoordinatorCoordinatedGraphics was implementing Chromium-specific
interface which is going to be removed eventually as there is no ScrollingCoordinatorChromium
existing.

Tested by existing manual tests (fixed-position.html for example.

  • CMakeLists.txt:
  • Target.pri:

Included ScrollingStateTree files.

  • page/scrolling/ScrollingStateFixedNode.cpp:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateNode.cpp:
  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateScrollingNode.cpp:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.cpp:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingStateTree.cpp:
  • page/scrolling/ScrollingStateTree.h:

Removed ENABLE(THREADED_SCROLLING) code guards.

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::~ScrollingCoordinatorCoordinatedGraphics):
(WebCore):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::attachToStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::detachFromStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::clearStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:

ScrollingCoordinatorCoordinatedGraphics is using threaded scrolling approach to handle fixed
elements positioning while scrolling.

(WebCore):
(ScrollingCoordinatorCoordinatedGraphics):

  • page/scrolling/coordinatedgraphics/ScrollingStateNodeCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingStateNode::platformScrollLayer):
(WebCore::ScrollingStateNode::setScrollPlatformLayer):
(WebCore::ScrollingStateNode::setScrollLayer):

  • page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp: Added.

(WebCore):
(WebCore::ScrollingStateScrollingNode::counterScrollingPlatformLayer):
(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):

5:49 AM Changeset in webkit [148196] by zarvai@inf.u-szeged.hu
  • 1 edit
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Remove platform specific expected after r148195.

  • platform/qt/fast/events/backspace-navigates-back-expected.txt: Removed.
4:46 AM Changeset in webkit [148195] by allan.jensen@digia.com
  • 7 edits in trunk/Source

[Qt] EventHandler should handle Space and BackSpace
https://bugs.webkit.org/show_bug.cgi?id=114428

Reviewed by Jocelyn Turcotte.

Source/WebCore:

Enable default space-handling for Qt.

  • page/EventHandler.cpp:

Source/WebKit/qt:

Remove our own handling of space and backspace.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::handleScrolling):

  • WidgetApi/qwebpage.cpp:

(QWebPagePrivate::keyPressEvent):

Source/WebKit2:

Remove our own handling of space and backspace.

  • WebProcess/WebPage/qt/WebPageQt.cpp:

(WebKit::WebPage::performDefaultBehaviorForKeyEvent):

4:37 AM Changeset in webkit [148194] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

IconDatabase: Simplify boolean logic in assertion.
https://bugs.webkit.org/show_bug.cgi?id=114425

Reviewed by Andreas Kling.

Follow-up to r148097; drop the overzealous use of !! to turn a
PassRefPtr into a boolean.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::updateIconRecord):

4:28 AM Changeset in webkit [148193] by zarvai@inf.u-szeged.hu
  • 2 edits
    4 adds in trunk/LayoutTests

[Qt] Unreviewed gardending. Greening bots.

  • platform/qt-5.0-wk1/loader/go-back-cached-main-resource-expected.txt: Rebaselining after r148182.
  • platform/qt-5.0-wk2/loader/go-back-cached-main-resource-expected.txt: Rebaselining after r148182.
  • platform/qt/TestExpectations:
4:11 AM Changeset in webkit [148192] by anilsson@rim.com
  • 14 edits in trunk/Source

[BlackBerry] LayerTexture refactoring
https://bugs.webkit.org/show_bug.cgi?id=114276

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Remove the GpuHandle and HostType typedefs from LayerTexture, they
don't make any sense now that we removed the Skia code paths. With Skia
they used to be an OpenGL texture ID and an SkBitmap respectively, but
now it's just BlackBerry::Platform::Graphics::Buffer all around.

This allows us to rename textureId() into buffer() which is more to the
point. The texture ID concept is now up for grabs and can be used to
consolidate all the various code for extracting an OpenGL texture from
a BlackBerry::Platform::Graphics::Buffer. This opportunity is seized in
LayerTexture::platformTexture(), a name which makes more sense than
textureId() for anyone familiar with the GraphicsContext3D code. We can
also leverage the Platform3DObject typedef to avoid including gl2.h.

The vertex attribute state was getting trampled when interacting with
BlackBerry::Platform::Graphics in the LayerFilterRenderer. Some
additional GL state save/restore incantations when accessing the OpenGL
texture for a LayerTexture in the new LayerTexture::platformTexture()
method fixes various CSS Filters test cases.

Since we removed the Skia integration from LayerTiler, nobody cares
about the dirty rect, tile rect or opaqueness of the tile contents. So
remove those parameters from the updateContents code path.

No change in behavior except for fixing CSS Filters tests like
css3/filters/effect-blur-hw.html. This can only be verified by manually
looking at the tests, we don't have pixel test support to catch this
kind of regression.

PR 322882

  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawSurface):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerRenderer.cpp:

(WebCore::LayerRenderer::useSurface):

  • platform/graphics/blackberry/LayerTexture.cpp:

(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::platformTexture):
(WebCore):

  • platform/graphics/blackberry/LayerTexture.h:

(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::buffer):
(LayerTexture):
(WebCore::LayerTexture::setBuffer):

  • platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):

  • platform/graphics/blackberry/LayerTile.h:

(WebCore::LayerTile::hasTexture):
(LayerTile):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):

  • platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(LayerTiler):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureCacheCompositingThread::createBuffer):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureForContents):
(WebCore::TextureCacheCompositingThread::updateContents):

  • platform/graphics/blackberry/TextureCacheCompositingThread.h:

(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

Source/WebKit/blackberry:

Adapt to the LayerTexture refactoring down in WebCore.

PR 322882

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):
(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::drawTextures):

4:04 AM WebKitGTK/2.0.x edited by Carlos Garcia Campos
(diff)
4:00 AM Changeset in webkit [148191] by Carlos Garcia Campos
  • 40 edits
    2 moves
    2 adds
    2 deletes in releases/WebKitGTK/webkit-2.0/Source

Merge r147924 - [GTK] DOM objects created wrapping a base class have incorrect GObject type
https://bugs.webkit.org/show_bug.cgi?id=113132

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Some of the DOM methods can create a concrete instance of another
object, but return a base class. GObject bindings provide custom
kit implementations for Node, Element, Event and EvenTarget, so
any concrete HTMLElement wrapped as an HTMLElement ends up
wrapping the right WebCore object but in the wrong GObject type.
This affects not only HTMLElements, but any polymorphic object
wrapped using a base class.
This patch changes the way objects are created, so that all
classes have their own kit implementation, but for polymorphic
objects the kit implementation of the base class is always
used. The kit method of polymorphic base classes use a generic
wrap method instead of the wrapFoo method like all other
classes. In the static code we provide the implementation of the
generic wrap method for every polimorphic base class, falling back
to their wrapFoo method if the concrete object can't be used to
wrap the object.
Both WebKitDOMBinding and WebKitHTMLElementWrapperFactory now provide
implementations of wrap and have been renamed to WebKitDOMPrivate
and WebKitDOMHTMLPrivate.

  • bindings/gobject/GNUmakefile.am:
  • bindings/gobject/WebKitDOMBinding.cpp: Removed.
  • bindings/gobject/WebKitDOMEventTarget.cpp:

(WebKit::kit): Moved kit implementation from WebKitDOMBinding for
consistency with all other objects that have their own kit.
(WebKit::core): Updated to match the core implementation fo all
other objects.

  • bindings/gobject/WebKitDOMEventTargetPrivate.h:

(WebCore):
(WebKit):

  • bindings/gobject/WebKitDOMHTMLPrivate.cpp: Added.

(WebKit): Use preprocessor macros to define and set the wrap
functions of all HTML elements, removing a lot of boilerplate code
and making it easier to add new wrap functions in the future.
(WebKit::wrap):

  • bindings/gobject/WebKitDOMHTMLPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.h.

(WebCore):
(WebKit):

  • bindings/gobject/WebKitDOMObject.cpp:
  • bindings/gobject/WebKitDOMPrivate.cpp: Added.

(WebKit):
(WebKit::wrap):

  • bindings/gobject/WebKitDOMPrivate.h: Renamed from Source/WebCore/bindings/gobject/WebKitDOMBinding.h.

(WebCore):
(WebKit):

  • bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Removed.
  • bindings/scripts/CodeGeneratorGObject.pm:

(IsBaseType): Helper function to check if a type is a base class.
(GetBaseClass): Helper function to get the base class for a given
parent type.
(GenerateFunction): Remove special case for EventTarget since the
kit prototype of EventTarget is in its private header like all
other objects.
(GenerateCFile): Add a kit implementation for all objects.
(IsPolymorphic): Helper function to check if the given type is the
base class of a polymorphic object.
(Generate): Include the private header of the base class for
polymorphic objects.
(WriteData): Remove the special case for WebKitDOMNode since now
all objects has a kit method.

  • bindings/scripts/test/GObject/WebKitDOMFloat64Array.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMFloat64ArrayPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObjectPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetter.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestCustomNamedGetterPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventConstructorPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTargetPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructor.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestNamedConstructorPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestNode.cpp:

(WebKit::kit):

  • bindings/scripts/test/GObject/WebKitDOMTestNodePrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructors.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsPrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

(WebKit):

  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestTypedefsPrivate.h:

(WebKit):

Source/WebKit/gtk:

Remove WebKitDOMBindindg.h include from several files because it's
been renamed and it was not actually needed.

  • WebCoreSupport/ChromeClientGtk.cpp:
  • WebCoreSupport/EditorClientGtk.cpp:
  • webkit/webkithittestresult.cpp:
3:00 AM Changeset in webkit [148190] by rniwa@webkit.org
  • 3 edits in trunk/Tools

Remove code for Chromium from wkbuild.py
https://bugs.webkit.org/show_bug.cgi?id=114423

Reviewed by Benjamin Poulain.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):

2:49 AM Changeset in webkit [148189] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] RenderThemeBlackBerry: upstream missing code
https://bugs.webkit.org/show_bug.cgi?id=114343

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-11
Reviewed by Xan Lopez.

Add implementations of sliderTickSize() and
sliderTickOffsetFromTrackCenter(), as well as a missing header.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore):
(WebCore::RenderThemeBlackBerry::sliderTickSize):
(WebCore::RenderThemeBlackBerry::sliderTickOffsetFromTrackCenter):

  • platform/blackberry/RenderThemeBlackBerry.h:

(RenderThemeBlackBerry):

2:17 AM Changeset in webkit [148188] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

HitTestRequest::AllowFrameScrollbars does not test main frame scrollbar
https://bugs.webkit.org/show_bug.cgi?id=112563

Reviewed by Antonio Gomes.

Move the frame scrollbar testing from RenderPart to RenderView, so that it is
tested by all frame and not just child frames. At the same time remove the
main frame test from the one current callsite using the option.

Tested by fast/events/touch/gesture/gesture-scrollbar.html.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleGestureEvent):

  • rendering/RenderPart.cpp:

(WebCore::RenderPart::nodeAtPoint):

  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest):

2:09 AM Changeset in webkit [148187] by Philippe Normand
  • 2 edits in trunk/Tools

Unreviewed, update my IRC nickname.

  • Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
2:00 AM Changeset in webkit [148186] by commit-queue@webkit.org
  • 19 edits in trunk

Incorrect evaluation of resolution media queries
https://bugs.webkit.org/show_bug.cgi?id=114029

Patch by Rune Lillesveen <rune@opera.com> on 2013-04-11
Reviewed by Kenneth Rohde Christiansen.

.:

Removed setResolutionOverride from exports.

  • Source/autotools/symbols.filter:

Source/WebCore:

The implementation used the physical resolution to evaluate the
resolution media features. Changed to use the actual CSS resolution,
also known as the device-pixel-ratio, instead. Unified the code for
evaluating the resolution and device-pixel-ratio media features.

No new tests, covered by existing tests.

  • WebCore.exp.in:
  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isResolution):

  • css/MediaQueryEvaluator.cpp:

(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):

  • page/Screen.cpp:
  • page/Screen.h:
  • page/Settings.cpp:

(WebCore):

  • page/Settings.h:

(Settings):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

  • testing/InternalSettings.h:

(Backup):
(InternalSettings):

  • testing/InternalSettings.idl:

Source/WebKit:

Removed setResolutionOverride from exports.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Removed setResolutionOverride from exports.

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

Modified tests to change CSS resolution instead of physical resolution.

  • fast/media/mq-resolution.html:
1:46 AM Changeset in webkit [148185] by rniwa@webkit.org
  • 15 edits
    1 delete in trunk/Tools

Remove the rest of Chromium code from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=114420

Reviewed by Benjamin Poulain.

  • Scripts/webkitpy/common/config/urls.py:

(view_revision_url):

  • Scripts/webkitpy/common/host.py:

(Host._engage_awesome_locale_hacks):
(Host.initialize_scm):
(Host):

  • Scripts/webkitpy/common/host_mock.py:

(MockHost.init):
(MockHost.checkout):

  • Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGeneratorBase._insert_generic_metadata):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._tokenize_line):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(ExpectationSyntaxTests.test_bare_name_and_bugs):
(ExpectationSyntaxTests.test_warnings):

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.skips_perf_test):
(Port.path_to_test_expectations_file):
(Port._port_flag_for_scripts):

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_function_definition):
(check_include_line):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(OrderOfIncludesTest.test_check_wtf_includes):
(WebKitStyleTest.test_webkit_export_check):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_valid_expectations):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Rollout.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois):

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help):

  • Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

(SheriffBotTest.test_command_aliases):

1:29 AM Changeset in webkit [148184] by rniwa@webkit.org
  • 2 edits in trunk/Tools

roll-chromium-deps doesn't roll DEPS
https://bugs.webkit.org/show_bug.cgi?id=114421

Reviewed by Antti Koivisto.

Roll DEPS. Rolling DEPS. Rolled DEPS.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS.execute):

1:27 AM Changeset in webkit [148183] by glenn@skynav.com
  • 3 edits in trunk/Tools

[webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
https://bugs.webkit.org/show_bug.cgi?id=114418

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/scm/scm_mock.py:

(MockSCM.add): Remove optional remove_exit_code argument.
(MockSCM.add_list): Remove optional remove_exit_code argument and return value.

  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

(_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
(_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.

1:25 AM Changeset in webkit [148182] by Carlos Garcia Campos
  • 3 edits
    8 adds in trunk

FrameLoaderClient::assignIdentifierToInitialRequest() not called for the main resource when loaded from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=112418

Source/WebCore:

Reviewed by Darin Adler.

When the main resource is loaded from the memory cache the
response is not added to the ResponseVector of the document
loader, so that when committing the provisional load the remaining
delegate messages are not called because the ResponseVector of the
document loader is empty. When the main resource is loaded from
the memory cache, there's no resource loader, and the client is
notified about the response received using
ResourceLoadNotifier::dispatchDidReceiveResponse() directly
instead of ResourceLoadNotifier::didReceiveResponse() which is the
one adding the response to the ResponseVector of the document
loader. So, the problem can be fixed by adding the response to the
ResponseVector before calling dispatchDidReceiveResponse() when
loading the main resource without a resource loade

Test: loader/go-back-cached-main-resource.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

LayoutTests:

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-04-11
Reviewed by Darin Adler.

  • loader/go-back-cached-main-resource-expected.txt: Added.
  • loader/go-back-cached-main-resource.html: Added.
  • loader/resources/first-page.html: Added.
  • loader/resources/other-page.html: Added.
  • platform/gtk-wk1/loader/go-back-cached-main-resource-expected.txt: Added.
  • platform/wk2/loader/go-back-cached-main-resource-expected.txt: Added.
12:45 AM Changeset in webkit [148181] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix roll-chromium-deps and hi.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):
(RollChromiumDEPS.execute):

12:40 AM Changeset in webkit [148180] by rniwa@webkit.org
  • 10 edits
    7 deletes in trunk/Tools

Remove webkitpy code to roll Chromium DEPS
https://bugs.webkit.org/show_bug.cgi?id=114415

Reviewed by Benjamin Poulain.

Removed the code to roll Chromium DEPS in WebKit.

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.bug_id_for_this_commit):

  • Scripts/webkitpy/common/checkout/checkout_mock.py:

(MockCheckout.commit_message_for_this_commit):

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:

(CheckoutTest.test_suggested_reviewers):

  • Scripts/webkitpy/common/checkout/deps.py: Removed.
  • Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
  • Scripts/webkitpy/tool/bot/irc_command.py:

(RollChromiumDEPS): Teach webkitbot a sense of humor.
(RollChromiumDEPS.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_create_bug):

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_revert):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.post_rollout_patch):

  • Scripts/webkitpy/tool/commands/init.py:
  • Scripts/webkitpy/tool/commands/roll.py: Removed.
  • Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
  • Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
  • Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
12:20 AM Changeset in webkit [148179] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Unreviewed Qt buildfixes after r148147, r148148 and r148154.

  • DerivedSources.pri:
  • Target.pri:
12:06 AM Changeset in webkit [148178] by Lucas Forschler
  • 1 copy in tags/Safari-537.37

New Tag.

12:03 AM Changeset in webkit [148177] by glenn@skynav.com
  • 3 edits in trunk/Tools

[webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
https://bugs.webkit.org/show_bug.cgi?id=114386

Reviewed by Benjamin Poulain.

Subversion client 1.7 uses a new locking scheme that invalidates the technique used
in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
can be implemented. Further, 1.7 changed svn add to not add intermediate directories
by default and to return exit code 1 if a file/dir had already been added.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(test_svn_lock): Skip body of test if subversion client 1.7 or later.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.

Apr 10, 2013:

11:29 PM Changeset in webkit [148176] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix, fixing the WebKit2 build.

  • GNUmakefile.list.am:
11:22 PM Changeset in webkit [148175] by ap@apple.com
  • 17 edits in trunk/Source/WebCore

Remove some includes of CachedImage.h
https://bugs.webkit.org/show_bug.cgi?id=114411

Reviewed by Dan Bernstein.

  • css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a definition of a class it holds, but default construction does not.
  • rendering/RenderImageResource.cpp:
  • rendering/RenderImageResource.h: Moved definitions of virtual functions to a .cpp file. There is no win from having them inline, and now we don't need CachedImage.h in the header.
  • bindings/js/JSNodeCustom.cpp:
  • dom/Clipboard.cpp: (WebCore::Clipboard::Clipboard):
  • platform/mac/ClipboardMac.h:
  • rendering/InlineFlowBox.cpp:
  • rendering/RenderBox.cpp:
  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderTableCol.cpp:
  • rendering/RenderTableRow.cpp:
  • rendering/RenderTableSection.cpp:
  • svg/graphics/SVGImageCache.cpp: Removed unnecessary includes.
  • platform/mac/PasteboardMac.mm:
  • rendering/RenderSnapshottedPlugIn.cpp: Added ones where they are now necessary.
11:19 PM Changeset in webkit [148174] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed.

  • GNUmakefile.am: Removing extra whitespace that's producing warnings.
11:04 PM Changeset in webkit [148173] by glenn@skynav.com
  • 4 edits in trunk/Tools

[webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
https://bugs.webkit.org/show_bug.cgi?id=114410

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.add_list): Remove optional return_exit_code argument. Remove return value.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.add): Remove optional return_exit_code argument.
(SCM.add_list): Remove optional return_exit_code argument.

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.add_list): Remove optional return_exit_code argument. Remove return value.

10:47 PM Changeset in webkit [148172] by commit-queue@webkit.org
  • 8 edits
    19 adds in trunk

Allow direct compositing of background images
https://bugs.webkit.org/show_bug.cgi?id=108203

Patch by No'am Rosenthal <noam@webkit.org> on 2013-04-10
Reviewed by Simon Fraser.

Source/WebCore:

Use setContentsToImage for background images, if the GraphicsLayer has only a background
bitmap image and nothing else. Compute the contentsRect/contentsTileRect from the box model.
Added new properties to GraphicsLayer, contentsTilePhase and contentsTileSize, which controls the "single tile rect",
which allows us to compute the pattern-space transform of a tile, thus allowing background-size
and other characteristics of background images.

This feature is explicitly disabled when there is any composition with a background color or if
there are several background images, as in that case having a single backing store has some
advantages over directly compositing in hardware.

Currently, this feature is disabled for all ports, allowing ports to implement their backend
and decide when to enable it.

Note that RenderBoxModelObject::getGeometryForBackgroundImage crops the contents rect to the
area that contains the tiles, which allows us to assume full tiling in GraphicsLayer.
In this way contentsTileSize/Phase is equivalent to GraphicsContext::drawTiledImage.

Tests: compositing/patterns/direct-pattern-compositing-add-text.html

compositing/patterns/direct-pattern-compositing-change.html
compositing/patterns/direct-pattern-compositing-contain.html
compositing/patterns/direct-pattern-compositing-cover.html
compositing/patterns/direct-pattern-compositing-load.html
compositing/patterns/direct-pattern-compositing-padding.html
compositing/patterns/direct-pattern-compositing-position.html
compositing/patterns/direct-pattern-compositing-rotation.html
compositing/patterns/direct-pattern-compositing-size.html
compositing/patterns/direct-pattern-compositing.html

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):
(WebCore::GraphicsLayer::setContentsTileSize):
(WebCore::GraphicsLayer::setContentsTilePhase):
(WebCore::GraphicsLayer::contentsTileSize):
(WebCore::GraphicsLayer::contentsTilePhase):
(WebCore::GraphicsLayer::supportsContentsTiling):

Add a contentsTileRect property that enables tile-repeat of background images.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::imageChanged):

Pass background image changes to the layer backing.

  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage):

Expose a function that performs the geometry calculations needed to determine
the tileRect for a background image. This function is also responsible
for cropping the contentsRect to fit the area that is drawn into.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents):
(WebCore::RenderLayerBacking::resetContentsRect):
(WebCore::hasBoxDecorationsOrBackgroundImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
(WebCore::canCreateTiledImage):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::backgroundRectForBox):

Allow background images to be directly composited if conditions allow (see bug description).

LayoutTests:

Added several ref-tests as preparation for supporting direct compositing of background
images.

  • compositing/patterns/direct-pattern-compositing-add-text-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-add-text.html: Added.
  • compositing/patterns/direct-pattern-compositing-change-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-change.html: Added.
  • compositing/patterns/direct-pattern-compositing-contain-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-contain.html: Added.
  • compositing/patterns/direct-pattern-compositing-cover-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-cover.html: Added.
  • compositing/patterns/direct-pattern-compositing-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-load-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-load.html: Added.
  • compositing/patterns/direct-pattern-compositing-padding-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-padding.html: Added.
  • compositing/patterns/direct-pattern-compositing-position-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-position.html: Added.
  • compositing/patterns/direct-pattern-compositing-size-expected.html: Added.
  • compositing/patterns/direct-pattern-compositing-size.html: Added.
  • compositing/patterns/direct-pattern-compositing.html: Added.
9:59 PM Changeset in webkit [148171] by eric@webkit.org
  • 2 edits in trunk/Tools

Remove myself from the watchlists, I'm getting too much bug mail. :)

  • Scripts/webkitpy/common/config/watchlist:
8:53 PM Changeset in webkit [148170] by paroga@webkit.org
  • 5 edits in trunk/Source/WebCore

Replace ENABLE_LEGACY_WEB_AUDIO preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114351

Reviewed by Ryosuke Niwa.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/OscillatorNode.idl:
8:23 PM Changeset in webkit [148169] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Build warning in didReceiveMessage() generated by messages.py
https://bugs.webkit.org/show_bug.cgi?id=112513

Reviewed by Anders Carlsson.

Legacy receiver makes -Wunused-parameter build warnings. This patch is to fix them.

  • Scripts/webkit2/messages.py:

(generate_message_handler):

8:21 PM Changeset in webkit [148168] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Replace ENABLE_DIRECTORY_UPLOAD preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114350

Reviewed by Ryosuke Niwa.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

  • fileapi/File.idl:
8:17 PM Changeset in webkit [148167] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unify JSC Parser's error and error message
https://bugs.webkit.org/show_bug.cgi?id=114363

Reviewed by Geoffrey Garen.

The parser kept the error state over two attributes:
error and errorMessage. They were changed in sync,
but had some discrepancy (for example, the error message
was always defined to something).

This patch unifies the two. There is an error if
if the error message is non-null or if the parsing finished
before the end.

This also gets rid of the allocation of the error message
when instantiating a parser.

  • parser/Parser.cpp:

(JSC::::Parser):
(JSC::::parseInner):
(JSC::::parseSourceElements):
(JSC::::parseVarDeclaration):
(JSC::::parseConstDeclaration):
(JSC::::parseForStatement):
(JSC::::parseSwitchStatement):
(JSC::::parsePrimaryExpression):

  • parser/Parser.h:

(JSC::Parser::updateErrorMessage):
(JSC::Parser::updateErrorWithNameAndMessage):
(JSC::Parser::hasError):
(Parser):

8:12 PM Changeset in webkit [148166] by thiago.santos@intel.com
  • 2 edits in trunk/Source/WTF

[WTF] Get rid of truncated thread name warnings for non-Windows platforms
https://bugs.webkit.org/show_bug.cgi?id=114266

Reviewed by Ryosuke Niwa.

Hide the annoying message from ports that are not really interested
about it.

  • wtf/Threading.cpp:

(WTF::createThread):

6:59 PM Changeset in webkit [148165] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[CMAKE] Build fix after StorageArea refactoring
https://bugs.webkit.org/show_bug.cgi?id=114398

Unreviewed build fix.

Change StorageAreaImpl.messages.in with StorageAreaMap.messages.in.
Add StorageAreaMap.cpp in CMakeLists.txt.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10

  • CMakeLists.txt:
6:36 PM Changeset in webkit [148164] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r148158.
http://trac.webkit.org/changeset/148158
https://bugs.webkit.org/show_bug.cgi?id=114405

We need to migrate status data (Requested by rniwa on
#webkit).

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

6:27 PM Changeset in webkit [148163] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup local variables in Editor::markAndReplaceFor
https://bugs.webkit.org/show_bug.cgi?id=114383

Reviewed by Enrica Casucci.

Added resultEndLocation, which is the sum of resultLocation and resultLength.

Also replaced ambiguousBoundaryOffset by useAmbiguousBoundaryOffset since the ambiguous offset is always
selectionOffset -1 to avoid the extra house keeping and obnoxious -1 check.

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

6:25 PM Changeset in webkit [148162] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Set trap is not being called for API objects
https://bugs.webkit.org/show_bug.cgi?id=114403

Reviewed by Anders Carlsson.

Intercept putByIndex on the callback object and add tests
to make sure we don't regress in future.

  • API/JSCallbackObject.h:

(JSCallbackObject):

  • API/JSCallbackObjectFunctions.h:

(JSC::::putByIndex):
(JSC):

  • API/tests/testapi.c:

(PropertyCatchalls_setProperty):

  • API/tests/testapi.js:
6:22 PM Changeset in webkit [148161] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Make StorageAreaImpl a wrapper around StorageAreaMap
https://bugs.webkit.org/show_bug.cgi?id=114404

Reviewed by Oliver Hunt.

Prepare for moving all the code that deals with local storage values to StorageAreaMap,
and make StorageAreaImpl a dumb wrapper that simply calls through to the map.

  • WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::create):
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):
(WebKit::StorageAreaImpl::storageType):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::getItem):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::contains):

  • WebProcess/Storage/StorageAreaImpl.h:

(WebKit::StorageAreaImpl::storageAreaID):

  • WebProcess/Storage/StorageAreaMap.cpp:

(WebKit::generateStorageMapID):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::storageType):
(WebKit::StorageAreaMap::length):
(WebKit::StorageAreaMap::key):
(WebKit::StorageAreaMap::item):
(WebKit::StorageAreaMap::setItem):
(WebKit::StorageAreaMap::contains):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):

  • WebProcess/Storage/StorageAreaMap.h:
  • WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

  • WebProcess/Storage/StorageNamespaceImpl.h:

(StorageNamespaceImpl):

6:03 PM Changeset in webkit [148160] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Rename StorageManager messages to refer to the StorageMap instead of the StorageArea
https://bugs.webkit.org/show_bug.cgi?id=114401

Reviewed by Ryosuke Niwa.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::setItem):

  • UIProcess/Storage/StorageManager.h:
  • UIProcess/Storage/StorageManager.messages.in:
  • WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):

5:20 PM Changeset in webkit [148159] by benjamin@webkit.org
  • 13 edits
    399 deletes in trunk

Mass remove all the empty directories

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-10
Rubberstamped by Ryosuke Niwa.

PerformanceTests:

  • Bindings/resources: Removed.

Source/JavaScriptCore:

  • qt/api: Removed.
  • qt/benchmarks/qscriptengine: Removed.
  • qt/benchmarks/qscriptvalue: Removed.
  • qt/tests/qscriptengine: Removed.
  • qt/tests/qscriptstring: Removed.
  • qt/tests/qscriptvalue: Removed.
  • qt/tests/qscriptvalueiterator: Removed.

Source/ThirdParty/ANGLE:

  • src/libGLESv2/geometry: Removed.

Source/WebCore:

  • Modules/intents: Removed.
  • Modules/protocolhandler: Removed.
  • Modules/speech/mac: Removed.
  • accessibility/efl: Removed.
  • accessibility/gtk: Removed.
  • bridge/jni/jsc: Removed.
  • editing/android: Removed.
  • editing/gtk: Removed.
  • history/android: Removed.
  • page/android: Removed.
  • platform/android: Removed.
  • platform/clutter: Removed.
  • platform/graphics/blackberry/skia: Removed.
  • platform/graphics/harfbuzz/ng: Removed.
  • platform/graphics/pango: Removed.
  • platform/image-decoders/cg: Removed.
  • platform/image-decoders/qt: Removed.
  • platform/network/android: Removed.
  • platform/network/soup/cache/webkit: Removed.
  • platform/text/android: Removed.
  • platform/text/wince: Removed.
  • platform/track: Removed.

Source/WebKit/efl:

  • DefaultTheme/widget/button: Removed.
  • DefaultTheme/widget/check: Removed.
  • DefaultTheme/widget/combo: Removed.
  • DefaultTheme/widget/entry: Removed.
  • DefaultTheme/widget/file: Removed.
  • DefaultTheme/widget/mediacontrol/fullscreenbutton: Removed.
  • DefaultTheme/widget/mediacontrol/mutebutton: Removed.
  • DefaultTheme/widget/mediacontrol/playpausebutton: Removed.
  • DefaultTheme/widget/mediacontrol/seekbackwardbutton: Removed.
  • DefaultTheme/widget/mediacontrol/seekforwardbutton: Removed.
  • DefaultTheme/widget/mediacontrol/togglecaptionsbutton: Removed.
  • DefaultTheme/widget/progressbar: Removed.
  • DefaultTheme/widget/radio: Removed.
  • DefaultTheme/widget/scrollbar: Removed.
  • DefaultTheme/widget/search/cancel: Removed.
  • DefaultTheme/widget/search/decoration: Removed.
  • DefaultTheme/widget/search/field: Removed.
  • DefaultTheme/widget/slider: Removed.
  • DefaultTheme/widget/spinner: Removed.

Source/WebKit/gtk:

  • gyp: Removed.
  • po: Removed.

Source/WebKit/mac:

  • ForwardingHeaders/wtf/unicode/icu: Removed.

Source/WebKit/qt:

  • tests/qdeclarativewebview/resources: Removed.

Source/WebKit2:

  • Platform/CoreIPC/gtk: Removed.
  • Platform/CoreIPC/qt: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32: Removed.
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.64: Removed.
  • PluginProcess/gtk: Removed.
  • Shared/API/c/win: Removed.
  • Shared/Plugins/Netscape/win: Removed.
  • Shared/cg/win: Removed.
  • Shared/win: Removed.
  • UIProcess/API/C/win: Removed.
  • UIProcess/API/gtk/webkit: Removed.
  • UIProcess/Launcher/win: Removed.
  • UIProcess/Plugins/gtk: Removed.
  • UIProcess/Plugins/win: Removed.
  • UIProcess/texmap: Removed.
  • UIProcess/win: Removed.
  • WebProcess/Authentication/mac: Removed.
  • WebProcess/Cookies/efl: Removed.
  • WebProcess/Cookies/gtk: Removed.
  • WebProcess/Downloads/cf/win: Removed.
  • WebProcess/Downloads/cfnet: Removed.
  • WebProcess/Downloads/curl: Removed.
  • WebProcess/Downloads/efl: Removed.
  • WebProcess/Downloads/gtk: Removed.
  • WebProcess/Downloads/mac: Removed.
  • WebProcess/Downloads/qt: Removed.
  • WebProcess/Downloads/soup: Removed.
  • WebProcess/FullScreen/gtk: Removed.
  • WebProcess/FullScreen/mac: Removed.
  • WebProcess/FullScreen/qt: Removed.
  • WebProcess/FullScreen/win: Removed.
  • WebProcess/InjectedBundle/API/c/win: Removed.
  • WebProcess/InjectedBundle/win: Removed.
  • WebProcess/KeyValueStorage: Removed.
  • WebProcess/Network/CustomProtocols/mac: Removed.
  • WebProcess/Plugins/Netscape/gtk: Removed.
  • WebProcess/Plugins/Netscape/win: Removed.
  • WebProcess/WebCoreSupport/win: Removed.
  • WebProcess/WebPage/LayerTreeCoordinator: Removed.
  • WebProcess/WebPage/ca/mac: Removed.
  • WebProcess/WebPage/ca/win: Removed.
  • WebProcess/WebPage/win: Removed.
  • WebProcess/win: Removed.
  • qt/Resources: Removed.

Source/WTF:

  • wtf/qt/compat: Removed.
  • wtf/unicode/glib: Removed.
  • wtf/unicode/qt4: Removed.
  • wtf/unicode/wince: Removed.

Tools:

  • BuildSlaveSupport/gtk/crashmon/log: Removed.
  • BuildSlaveSupport/gtk/xvfb/log: Removed.
  • DumpRenderTree/ForwardingHeaders/wtf: Removed.
  • DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
  • MiniBrowser/gtk/WebBundle: Removed.
  • MiniBrowser/win: Removed.
  • QtTestPlatformPlugin/mac: Removed.
  • Scripts/webkitpy/tool/bot/testdata: Removed.
  • Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
  • efl/ImageDiff: Removed.
  • iExploder/htdocs: Removed.
  • iExploder/iexploder-1.7.2/output: Removed.
  • iExploder/tools: Removed.
  • qmake/config.tests/libexecdir: Removed.
  • qmake/config.tests/libjpeg: Removed.
  • qmake/config.tests/libpng: Removed.

WebKitLibraries:

  • win/bin: Removed.
  • win/lib/WebKitSystemInterface: Removed.

LayoutTests:

  • css2.1/reference: Removed.
  • css3/flexbox/script-tests: Removed.
  • css3/viewport-relative-lengths: Removed.
  • editing/deleting/resources: Removed.
  • editing/inserting/resources: Removed.
  • editing/style/resources: Removed.
  • editing/text-iterator/resources: Removed.
  • fast/dom/CSSStyleDeclaration/resources: Removed.
  • fast/dom/EntityReference/resources: Removed.
  • fast/dom/HTMLFontElement/resources: Removed.
  • fast/dom/HTMLFormElement/resources: Removed.
  • fast/dom/HTMLSelectElement/resources: Removed.
  • fast/dom/HTMLTableElement/resources: Removed.
  • fast/dom/HTMLTableRowElement/resources: Removed.
  • fast/dom/HTMLTableSectionElement/resources: Removed.
  • fast/dom/MediaStream/script-tests: Removed.
  • fast/dom/Node/resources: Removed.
  • fast/dom/Proximity: Removed.
  • fast/dom/Selection/resources: Removed.
  • fast/dom/Text/resources: Removed.
  • fast/events/spatial-navigation/resources: Removed.
  • fast/events/transformaction: Removed.
  • fast/forms/script-tests: Removed.
  • fast/loading/resources: Removed.
  • fast/mutation: Removed.
  • fast/regex/resources: Removed.
  • fast/speech/script-tests: Removed.
  • fast/xhtmlmp: Removed.
  • http/tests/inspector/resources/compiler-source-mapping-provider: Removed.
  • http/tests/media/media-source/webm: Removed.
  • http/tests/w3c/webperf/approved/navigation-timing/html5: Removed.
  • http/tests/w3c/webperf/submission/resource-timing/html: Removed.
  • http/tests/w3c/webperf/submission/user-timing: Removed.
  • http/tests/xhtmlmp: Removed.
  • http/tests/xmlhttprequest/web-apps/recursion: Removed.
  • inspector/performance/resources: Removed.
  • inspector/protocol/resources: Removed.
  • inspector/resources: Removed.
  • media/track/captions: Removed.
  • platform/efl-wk1/dom/xhtml/level3/core: Removed.
  • platform/efl-wk1/fast/dom/DOMException: Removed.
  • platform/efl-wk1/mathml/presentation: Removed.
  • platform/efl-wk1/svg/dynamic-updates: Removed.
  • platform/efl-wk2/dom/xhtml/level3/core: Removed.
  • platform/efl-wk2/fast/block/basic: Removed.
  • platform/efl-wk2/fast/dom/DOMException: Removed.
  • platform/efl-wk2/fast/frames: Removed.
  • platform/efl-wk2/http/tests/loading: Removed.
  • platform/efl/fast/css3-text-decoration/repaint: Removed.
  • platform/efl/fast/dom/HTMLTemplateElement: Removed.
  • platform/efl/fast/files: Removed.
  • platform/efl/fast/forms/mailto: Removed.
  • platform/efl/fast/innerHTML: Removed.
  • platform/efl/fast/viewport: Removed.
  • platform/efl/inspector/editor: Removed.
  • platform/gtk/css3/calc: Removed.
  • platform/gtk/editing/pasteboard/resources: Removed.
  • platform/gtk/fast/innerHTML: Removed.
  • platform/gtk/fast/js/regress: Removed.
  • platform/gtk/fast/viewport: Removed.
  • platform/gtk/http/tests/webarchive: Removed.
  • platform/gtk/http/tests/websocket/tests: Removed.
  • platform/gtk/ietestcenter/css3/grid: Removed.
  • platform/gtk/platform/gtk/fonts: Removed.
  • platform/gtk/sputnik/Unicode/Unicode_510: Removed.
  • platform/gtk/svg/hittest: Removed.
  • platform/gtk/tables/hittesting: Removed.
  • platform/mac-future/accessibility: Removed.
  • platform/mac-lion/animations: Removed.
  • platform/mac-lion/compositing/visible-rect: Removed.
  • platform/mac-lion/css1/units: Removed.
  • platform/mac-lion/css3/selectors3: Removed.
  • platform/mac-lion/editing/execCommand: Removed.
  • platform/mac-lion/editing/inserting: Removed.
  • platform/mac-lion/editing/pasteboard: Removed.
  • platform/mac-lion/fast/block/float: Removed.
  • platform/mac-lion/fast/block/margin-collapse: Removed.
  • platform/mac-lion/fast/frames: Removed.
  • platform/mac-lion/fast/inline: Removed.
  • platform/mac-lion/fast/layers: Removed.
  • platform/mac-lion/fast/lists: Removed.
  • platform/mac-lion/fast/overflow: Removed.
  • platform/mac-lion/fast/text/basic: Removed.
  • platform/mac-lion/ietestcenter/css3: Removed.
  • platform/mac-lion/tables/mozilla: Removed.
  • platform/mac-lion/transforms: Removed.
  • platform/mac-snowleopard/css3/filters/custom: Removed.
  • platform/mac-snowleopard/fast/canvas/webgl: Removed.
  • platform/mac-snowleopard/fast/html: Removed.
  • platform/mac-snowleopard/fast/loader: Removed.
  • platform/mac-snowleopard/fast/regions: Removed.
  • platform/mac-snowleopard/http/tests/media: Removed.
  • platform/mac-snowleopard/mathml/presentation: Removed.
  • platform/mac-snowleopard/sputnik/Unicode/Unicode_510: Removed.
  • platform/mac-snowleopard/svg/batik/filters: Removed.
  • platform/mac-snowleopard/svg/batik/masking: Removed.
  • platform/mac-snowleopard/svg/batik/text: Removed.
  • platform/mac-wk2/compositing/geometry: Removed.
  • platform/mac-wk2/compositing/iframes: Removed.
  • platform/mac-wk2/css3/filters/custom: Removed.
  • platform/mac-wk2/fast/css: Removed.
  • platform/mac-wk2/fast/dynamic: Removed.
  • platform/mac-wk2/fast/harness: Removed.
  • platform/mac-wk2/fast/multicol/vertical-rl: Removed.
  • platform/mac-wk2/http/tests/appcache: Removed.
  • platform/mac-wk2/http/tests/inspector: Removed.
  • platform/mac-wk2/http/tests/misc: Removed.
  • platform/mac-wk2/mathml: Removed.
  • platform/mac-wk2/media: Removed.
  • platform/mac-wk2/platform/mac/accessibility: Removed.
  • platform/mac-wk2/tables/mozilla: Removed.
  • platform/mac/css3/calc: Removed.
  • platform/mac/css3/filters/custom: Removed.
  • platform/mac/dom/xhtml/level2/html: Removed.
  • platform/mac/fast/dom/shadow: Removed.
  • platform/mac/fast/files: Removed.
  • platform/mac/fast/forms/label: Removed.
  • platform/mac/fast/innerHTML: Removed.
  • platform/mac/fast/inspector: Removed.
  • platform/mac/http/tests/xmlhttprequest/web-apps: Removed.
  • platform/mac/inspector/console: Removed.
  • platform/mac/inspector/debugger: Removed.
  • platform/mac/inspector/extensions: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/sticky: Removed.
  • platform/mac/sputnik/Unicode/Unicode_510: Removed.
  • platform/mac/svg/animations: Removed.
  • platform/mac/tables/mozilla/images: Removed.
  • platform/mac/tiled-drawing/fixed: Removed.
  • platform/mac/tiled-drawing/fixed-background: Removed.
  • platform/mac/tiled-drawing/sticky: Removed.
  • platform/qt-5.0-wk1/compositing/backing: Removed.
  • platform/qt-5.0-wk1/compositing/filters: Removed.
  • platform/qt-5.0-wk1/compositing/images: Removed.
  • platform/qt-5.0-wk1/compositing/masks: Removed.
  • platform/qt-5.0-wk1/compositing/rtl: Removed.
  • platform/qt-5.0-wk1/compositing/tiling: Removed.
  • platform/qt-5.0-wk1/compositing/visibility: Removed.
  • platform/qt-5.0-wk1/css3/filters: Removed.
  • platform/qt-5.0-wk1/editing/inserting: Removed.
  • platform/qt-5.0-wk1/fast/dom/Window: Removed.
  • platform/qt-5.0-wk2/compositing/backing: Removed.
  • platform/qt-5.0-wk2/compositing/shadows: Removed.
  • platform/qt-5.0-wk2/css1/basic: Removed.
  • platform/qt-5.0-wk2/css1/box_properties: Removed.
  • platform/qt-5.0-wk2/fast/block/basic: Removed.
  • platform/qt-5.0-wk2/fast/block/float: Removed.
  • platform/qt-5.0-wk2/fast/block/margin-collapse: Removed.
  • platform/qt-5.0-wk2/fast/block/positioning/auto: Removed.
  • platform/qt-5.0-wk2/fast/dom/HTMLHeadElement: Removed.
  • platform/qt-5.0-wk2/fast/dom/HTMLTableElement: Removed.
  • platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement: Removed.
  • platform/qt-5.0-wk2/fast/dom/Window: Removed.
  • platform/qt-5.0-wk2/fast/dynamic: Removed.
  • platform/qt-5.0-wk2/fast/forms/datalist: Removed.
  • platform/qt-5.0-wk2/fast/forms/mailto: Removed.
  • platform/qt-5.0-wk2/fast/forms/number: Removed.
  • platform/qt-5.0-wk2/fast/frames: Removed.
  • platform/qt-5.0-wk2/fast/html: Removed.
  • platform/qt-5.0-wk2/fast/images/png-suite: Removed.
  • platform/qt-5.0-wk2/fast/inline: Removed.
  • platform/qt-5.0-wk2/fast/lists: Removed.
  • platform/qt-5.0-wk2/fast/multicol/span: Removed.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr: Removed.
  • platform/qt-5.0-wk2/fast/parser: Removed.
  • platform/qt-5.0-wk2/fast/text/international: Removed.
  • platform/qt-5.0-wk2/fullscreen/fullscreen: Removed.
  • platform/qt-5.0-wk2/http/tests/websocket/test/hybi: Removed.
  • platform/qt-5.0-wk2/platform/qt/plugins: Removed.
  • platform/qt-5.0-wk2/svg/dom: Removed.
  • platform/qt-5.0/animations: Removed.
  • platform/qt-5.0/css1/text_properties: Removed.
  • platform/qt-5.0/css2.1/20110323: Removed.
  • platform/qt-5.0/editing/deleting: Removed.
  • platform/qt-5.0/editing/inserting: Removed.
  • platform/qt-5.0/editing/pasteboard: Removed.
  • platform/qt-5.0/fast/borders: Removed.
  • platform/qt-5.0/fast/css: Removed.
  • platform/qt-5.0/fast/dom/DeviceMotion: Removed.
  • platform/qt-5.0/fast/dom/DeviceOrientation: Removed.
  • platform/qt-5.0/fast/dom/HTMLProgressElement: Removed.
  • platform/qt-5.0/fast/dom/HTMLTextAreaElement: Removed.
  • platform/qt-5.0/fast/dynamic: Removed.
  • platform/qt-5.0/fast/html: Removed.
  • platform/qt-5.0/fast/inline: Removed.
  • platform/qt-5.0/fast/js: Removed.
  • platform/qt-5.0/fast/multicol: Removed.
  • platform/qt-5.0/fast/parser: Removed.
  • platform/qt-5.0/fast/repaint: Removed.
  • platform/qt-5.0/fast/replaced: Removed.
  • platform/qt-5.0/fast/table/border-collapsing: Removed.
  • platform/qt-5.0/fast/writing-mode: Removed.
  • platform/qt-5.0/fast/xsl: Removed.
  • platform/qt-5.0/svg/as-background-image: Removed.
  • platform/qt-5.0/svg/custom: Removed.
  • platform/qt-5.0/svg/hixie/intrinsic: Removed.
  • platform/qt-5.0/svg/text: Removed.
  • platform/qt-5.0/svg/wicd: Removed.
  • platform/qt-5.0/svg/zoom/page: Removed.
  • platform/qt-5.0/tables/mozilla/bugs: Removed.
  • platform/qt-5.0/transitions: Removed.
  • platform/qt-arm/fast/block: Removed.
  • platform/qt-arm/fast/dom: Removed.
  • platform/qt-arm/transforms: Removed.
  • platform/qt-linux/fast/css: Removed.
  • platform/qt-mac/editing: Removed.
  • platform/qt-mac/fast/block/float: Removed.
  • platform/qt-mac/plugins: Removed.
  • platform/qt-win/fast/events: Removed.
  • platform/qt.5-0/fast/text/whitespace: Removed.
  • platform/qt/compositing/tiling: Removed.
  • platform/qt/fast/css/dumpAsText: Removed.
  • platform/qt/fast/encoding/dumpAsText: Removed.
  • platform/qt/fast/forms/mailto: Removed.
  • platform/qt/fast/innerHTML: Removed.
  • platform/qt/fast/inspector: Removed.
  • platform/qt/fast/js/regress: Removed.
  • platform/qt/fast/media/w3c: Removed.
  • platform/qt/http/tests/plugins: Removed.
  • platform/qt/http/tests/security/aboutBlank: Removed.
  • platform/qt/http/tests/security/cookies: Removed.
  • platform/qt/http/tests/security/mixedContent: Removed.
  • platform/qt/http/tests/security/xssAuditor: Removed.
  • platform/qt/http/tests/xmlhttprequest/workers: Removed.
  • platform/qt/inspector/console: Removed.
  • platform/qt/inspector/debugger: Removed.
  • platform/qt/inspector/extensions: Removed.
  • platform/qt/mathml/presentation: Removed.
  • platform/qt/scrollingcoordinator: Removed.
  • platform/qt/svg/hixie/error/dumpAsText: Removed.
  • platform/qt/tables/mozilla/images: Removed.
  • platform/qt/traversal: Removed.
  • platform/win-7sp0/fast/harness: Removed.
  • platform/win-wk2/css2.1: Removed.
  • platform/win-wk2/editing/deleting: Removed.
  • platform/win-wk2/editing/selection: Removed.
  • platform/win-wk2/fast/css: Removed.
  • platform/win-wk2/fast/forms: Removed.
  • platform/win-wk2/fast/repaint: Removed.
  • platform/win-wk2/fast/ruby: Removed.
  • platform/win-wk2/fast/text/international: Removed.
  • platform/win-wk2/http/tests/inspector-enabled: Removed.
  • platform/win-wk2/http/tests/security: Removed.
  • platform/win-wk2/http/tests/uri: Removed.
  • platform/win-wk2/media: Removed.
  • platform/win-wk2/platform/win/inverted-colors: Removed.
  • platform/win-wk2/platform/win/plugins: Removed.
  • platform/win-wk2/plugins/npruntime: Removed.
  • platform/win-wk2/svg/W3C-I18N: Removed.
  • platform/win-wk2/svg/W3C-SVG-1.1-SE: Removed.
  • platform/win-wk2/svg/text: Removed.
  • platform/win-wk2/svg/zoom/page: Removed.
  • platform/win/canvas/philip/tests: Removed.
  • platform/win/compositing/geometry: Removed.
  • platform/win/compositing/overflow: Removed.
  • platform/win/editing/style: Removed.
  • platform/win/editing/undo: Removed.
  • platform/win/fast/block/basic: Removed.
  • platform/win/fast/css/getComputedStyle: Removed.
  • platform/win/fast/css3-text-decoration/getComputedStyle: Removed.
  • platform/win/fast/dom/Element: Removed.
  • platform/win/fast/dom/HTMLTextAreaElement: Removed.
  • platform/win/fast/dom/Window: Removed.
  • platform/win/fast/events/resources: Removed.
  • platform/win/fast/frames/seamless: Removed.
  • platform/win/fast/layers: Removed.
  • platform/win/fast/loader: Removed.
  • platform/win/fast/overflow: Removed.
  • platform/win/fast/parser: Removed.
  • platform/win/fast/table: Removed.
  • platform/win/fast/transforms: Removed.
  • platform/win/inspector/debugger: Removed.
  • platform/win/platform/win/accessibility: Removed.
  • platform/win/tables/mozilla/bugs: Removed.
  • platform/win/tables/mozilla/other: Removed.
  • platform/win/tables/mozilla_expected_failures/bugs: Removed.
  • platform/wk2/tables/mozilla/bugs: Removed.
  • pointer-lock/resources: Removed.
  • storage/indexeddb/script-tests: Removed.
  • svg/dom/SVGStyleElement/resources: Removed.
  • webintents/resources: Removed.
5:15 PM Changeset in webkit [148158] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114397

Reviewed by Benjamin Poulain.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer):

5:10 PM Changeset in webkit [148157] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[CMAKE] Build fix after r148147, r148148
https://bugs.webkit.org/show_bug.cgi?id=114395

Unreviewed build fix.

Use StorageAreaImpl, StorageNamespaceImpl instead of StorageAreaProxy, StorageNamespaceProxy.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-04-10

  • CMakeLists.txt:
5:09 PM Changeset in webkit [148156] by rniwa@webkit.org
  • 5 edits in trunk/Websites/bugs.webkit.org

Make old EWS bubbles less opaque to disambiguate two set of bubbles.

Rubber-stamped by Benjamin Poulain.

  • code-review.js:
  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
5:04 PM Changeset in webkit [148155] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Log when the animation timer fires
https://bugs.webkit.org/show_bug.cgi?id=114393

Reviewed by Dean Jackson.

Logging to the Animations log channel when the updateAnimationTimer
fires is useful, because it indicates whether we're running
software animations.

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateAnimationTimer):

5:02 PM Changeset in webkit [148154] by andersca@apple.com
  • 5 edits
    1 move
    2 adds in trunk/Source/WebKit2

Add a stubbed out StorageAreaMap class
https://bugs.webkit.org/show_bug.cgi?id=114392

Reviewed by Andreas Kling.

The intention is that StorageAreaMap is going to take over responsibility for storing the storage values in the
web process, as well as dispatching events. A StorageAreaMap will be shared between multiple StorageAreaImpl objects,
for example if multiple frames with the same origin use local storage.

  • DerivedSources.make:
  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::~StorageAreaImpl):

  • WebProcess/Storage/StorageAreaMap.cpp: Added.

(WebKit):
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::StorageAreaMap):
(WebKit::StorageAreaMap::~StorageAreaMap):
(WebKit::StorageAreaMap::didSetItem):
(WebKit::StorageAreaMap::dispatchStorageEvent):

  • WebProcess/Storage/StorageAreaMap.h: Added.

(WebKit):
(StorageAreaMap):

  • WebProcess/Storage/StorageAreaMap.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaImpl.messages.in.
5:00 PM Changeset in webkit [148153] by rniwa@webkit.org
  • 5 edits in trunk/Websites/bugs.webkit.org

Bugzilla should show bubbles from webkit-queues.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114391

Reviewed by Benjamin Poulain.

Include iframe from webkit-queues.appspot.com as well as one for webkit-commit-queue.appspot.com.

  • code-review.js:
  • template/en/custom/attachment/edit.html.tmpl:
  • template/en/custom/attachment/list.html.tmpl:
  • template/en/custom/attachment/reviewform.html.tmpl:
4:53 PM Changeset in webkit [148152] by abarth@webkit.org
  • 2 edits in trunk/Tools

Remove abarth from watchlists
https://bugs.webkit.org/show_bug.cgi?id=114390

Reviewed by Ryosuke Niwa.

I'm trying to cut down on the amount of bugmail I get so that I'll have
more of a chance to notice a piece of bugmail directed at me.

  • Scripts/webkitpy/common/config/watchlist:
4:44 PM Changeset in webkit [148151] by rniwa@webkit.org
  • 3 edits in trunk/Tools

webkit-test-results.appspot.com loads the dashboard for Chromium by default
https://bugs.webkit.org/show_bug.cgi?id=114381

Reviewed by Benjamin Poulain.

Changed the defaults.

  • TestResultServer/static-dashboards/builders.js:
  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

4:34 PM Changeset in webkit [148150] by Lucas Forschler
  • 4 edits
    2 adds in branches/safari-536.30-branch

Merge 136250. <rdar://problem/13335010>

4:25 PM Changeset in webkit [148149] by bdakin@apple.com
  • 2 edits in trunk/Source/WebCore

Inspector highlights are offset when the WKView has a header
https://bugs.webkit.org/show_bug.cgi?id=114389
-and corresponding-
<rdar://problem/13522434>

Reviewed by Sam Weinig.

rootViewToContents() and contentsToRootView() need to factor in the
headerHeight(), much like windowToContents() and contentsToWindow() do already.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::rootViewToContents):
(WebCore::ScrollView::contentsToRootView):

4:22 PM Changeset in webkit [148148] by andersca@apple.com
  • 6 edits
    3 moves in trunk/Source/WebKit2

Rename StorageAreaProxy to StorageAreaImpl.

Rubber-stamped by Beth Dakin.

  • DerivedSources.make:
  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageArea::dispatchEvents):
(WebKit::StorageManager::setItem):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Storage/StorageAreaImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.cpp.
  • WebProcess/Storage/StorageAreaImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.h.
  • WebProcess/Storage/StorageAreaImpl.messages.in: Renamed from Source/WebKit2/WebProcess/Storage/StorageAreaProxy.messages.in.
  • WebProcess/Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::storageArea):

  • WebProcess/Storage/StorageNamespaceImpl.h:

(WebKit):
(StorageNamespaceImpl):

4:21 PM Changeset in webkit [148147] by andersca@apple.com
  • 5 edits
    2 moves in trunk/Source/WebKit2

Rename StorageNamespaceProxy to StorageNamespaceImpl.

Rubber-stamped by Beth Dakin.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::create):
(WebKit::StorageAreaProxy::StorageAreaProxy):

  • WebProcess/Storage/StorageAreaProxy.h:

(StorageAreaProxy):

  • WebProcess/Storage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.cpp.
  • WebProcess/Storage/StorageNamespaceImpl.h: Renamed from Source/WebKit2/WebProcess/Storage/StorageNamespaceProxy.h.
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::sessionStorageNamespace):

4:11 PM Changeset in webkit [148146] by rniwa@webkit.org
  • 6 edits in trunk/Tools

Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988

Reviewed by Benjamin Poulain.

Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/config/queues.py:
  • QueueStatusServer/model/queues.py:

(Queue.short_name):
(Queue.display_name):

  • QueueStatusServer/model/queues_unittest.py:

(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

  • QueueStatusServer/templates/activebots.html:
3:47 PM Changeset in webkit [148145] by simon.fraser@apple.com
  • 4 edits in trunk/Source/WebCore

Flesh out the Animations logging
https://bugs.webkit.org/show_bug.cgi?id=114388

Reviewed by Dean Jackson.

Log state changes and transition/animation creation and destruction
to the Animations log channel.

  • page/animation/AnimationBase.cpp:

(WebCore::nameForState):
(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::goIntoEndingOrLoopingState):
(WebCore::AnimationBase::freezeAtTime):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::updateKeyframeAnimations):

  • page/animation/KeyframeAnimation.h:

(WebCore::KeyframeAnimation::keyframes):
(KeyframeAnimation):

3:45 PM Changeset in webkit [148144] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

<rdar://problem/13047266> External XML entities are not loaded with modern libxml2
https://bugs.webkit.org/show_bug.cgi?id=114377

Reviewed by Darin Adler.

Covered by http/tests/security/xss-DENIED-xml-external-entity.xhtml when using
new enough libxml2.

  • xml/parser/XMLDocumentParserLibxml2.cpp: (WebCore::switchToUTF16): Added a FIXME with an idea for improvement. (WebCore::XMLParserContext::createStringParser): Apply XML_PARSE_NOENT in a non-hacky way, so that the new libxml2 check doesn't fail. (WebCore::XMLParserContext::createMemoryParser): Updated an unhelpful and incorrect comment (XML_PARSE_NODICT actually means "Do not reuse the context dictionary").
3:35 PM Changeset in webkit [148143] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[wk2] Un-pollute TCADA methods with "PageOverlayLayerMap::iterator end"
https://bugs.webkit.org/show_bug.cgi?id=114387

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::paintContents):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged):
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

3:25 PM Changeset in webkit [148142] by mhahnenberg@apple.com
  • 4 edits
    3 adds in trunk

JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235

Reviewed by Filip Pizlo.

If the object doesn't have any properties but the prototype does, we'll assume those prototype properties are
accessible in the base object's backing store, which is bad.

Source/JavaScriptCore:

  • runtime/JSObject.cpp:

(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnNonIndexPropertyNames):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::PropertyNameArray):
(JSC::PropertyNameArray::setNumCacheableSlotsForObject):
(JSC::PropertyNameArray::setBaseObject):
(PropertyNameArray):

LayoutTests:

  • fast/js/get-by-pname-only-prototype-properties-expected.txt: Added.
  • fast/js/get-by-pname-only-prototype-properties.html: Added.
  • fast/js/script-tests/get-by-pname-only-prototype-properties.js: Added.

(foo):

3:18 PM Changeset in webkit [148141] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] REGRESSION: Find highlight does not update when the view is resized
https://bugs.webkit.org/show_bug.cgi?id=114382
<rdar://problem/13599797>

Reviewed by Simon Fraser.

Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
This will have no effect if the page overlay hasn't previously asked to be painted
(as drawsContent will remain false on the layer).

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.

2:53 PM Changeset in webkit [148140] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] in-band tracks sometimes not recognized
https://bugs.webkit.org/show_bug.cgi?id=114380

Reviewed by Jer Noble.

No new tests, covered by existing in-band tests.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Don't call selectMediaOption,

availableMediaCharacteristicsWithMediaSelectionOptions is unlikely to be loaded at this time.

(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Disable automatic text track

selection.

(WebCore::assetMetadataKeyNames): Watch for the status of availableMediaCharacteristicsWithMediaSelectionOptions

to change.

2:22 PM Changeset in webkit [148139] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Exclusions] Zoom causes shape-inside to fail when shape-padding is specified
https://bugs.webkit.org/show_bug.cgi?id=113730

Reviewed by Dirk Schulze.

Source/WebCore:

Snap computed margin and polygon boundaries to the LayoutUnit grid to ensure
that they fall within the shape's LayoutUnit bounding box.

Test: fast/exclusions/shape-inside/shape-inside-polygon-zoom.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::snapVerticesToLayoutUnitGrid): Convert the FloatPoint coordinates to LayoutUnits and then back to floats.
(WebCore::computeShapePaddingBounds): Now calls snapVerticesToLayoutUnitGrid() before creating a FloatPolygon.
(WebCore::computeShapeMarginBounds): Ditto.

LayoutTests:

Verify that content lays out within a padded shape-inside polygon when the
document has been zoomed.

  • fast/exclusions/shape-inside/shape-inside-polygon-zoom-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-polygon-zoom.html: Added.
2:11 PM Changeset in webkit [148138] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

One more unreviewed buildfix after r148123.

  • platform/graphics/filters/CustomFilterMeshGenerator.h:
1:57 PM Changeset in webkit [148137] by bdakin@apple.com
  • 8 edits in trunk/Source

FindBanner matches are offset when the WKView has a header or footer
https://bugs.webkit.org/show_bug.cgi?id=114314
-and corresponding-
<rdar://problem/13522434>

Reviewed by Simon Fraser.

Source/WebCore:

There were already a few places in the code where we needed to adjust the
scrollOffset() to pretend that (0,0) is that the top of the Document rather than
the top of the header. To fix the FindBanner issues, we need to know that version
of the offset in a few more places, so I added a function on ScrollView to fetch
it called scrollOffsetRelativeToDocument().

New function subtracts out the headerHeight() to treat the top of
the document as (0,0).

  • WebCore.exp.in:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollOffsetRelativeToDocument):

Use scrollOffsetRelativeToDocument() where we were previously making this
calculation. Also re-name an inaccurately named variable where we are actually
converting FROM a document offset to a ScrollableArea offset.
(WebCore::ScrollView::windowToContents):

  • platform/ScrollView.h:

(ScrollView):

getRectToExpose needs to know about the actual visibleContentRect and the
visibleContentRect that is relative to the Document. So this
patch adds a new parameter to getRectToExpose for that purpose.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::getRectToExpose):

  • rendering/RenderLayer.h:

Source/WebKit2:

When calculating the matching rects, also adjust to the scroll offset that is
relative to the Document.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::rectsForTextMatches):

1:45 PM Changeset in webkit [148136] by cfleizach@apple.com
  • 7 edits
    2 adds in trunk

when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
https://bugs.webkit.org/show_bug.cgi?id=113906

Reviewed by Tim Horton.

Source/WebCore:

If an element does not expose any children, then it's safe to include all of its sub children when determining
the visible text.
The bug is that all elements were ignoring focusable elements (like <a>) when determining visible children text

Test: accessibility/link-inside-button-accessible-text.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):

  • accessibility/AccessibilityNodeObject.h:

(AccessibilityNodeObject):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isDescendantOfBarrenParent):
(AccessibilityObject):

LayoutTests:

The static-text-role-uses-text-under-element.html relies on similar logic to this bug.

I realized that it was verifying the wrong thing and if we had looked closely at this layout test
we would have caught this regression earlier most likely.

  • accessibility/link-inside-button-accessible-text-expected.txt: Added.
  • accessibility/link-inside-button-accessible-text.html: Added.
  • platform/mac/accessibility/static-text-role-uses-text-under-element-expected.txt:
  • platform/mac/accessibility/static-text-role-uses-text-under-element.html:
1:38 PM Changeset in webkit [148135] by cfleizach@apple.com
  • 2 edits in trunk/Source/WebCore

AX: Make sure all AX methods called from outside call prepareAccessibility
https://bugs.webkit.org/show_bug.cgi?id=113818

Reviewed by Darin Adler.

Make sure any calls that can be made from outside WebCore are protected with the
prepareAccessibility method.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityMathRootIndexObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathRadicandObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathNumeratorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathDenominatorObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathBaseObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSubscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathSuperscriptObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathUnderObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedOpenString]):
(-[WebAccessibilityObjectWrapper accessibilityMathFencedCloseString]):
(-[WebAccessibilityObjectWrapper accessibilityIsMathTopObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):

1:30 PM Changeset in webkit [148134] by paroga@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove code duplicates from MacroAssemblerARM
https://bugs.webkit.org/show_bug.cgi?id=104457

Reviewed by Oliver Hunt.

Reuse some existing methods to avoid duplicated code.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::swap):
(JSC::MacroAssemblerARM::add32):
(JSC::MacroAssemblerARM::sub32):

1:21 PM Changeset in webkit [148133] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed buildfix after r148123.

  • inspector/InspectorInstrumentation.h:

(WebCore):

1:05 PM Changeset in webkit [148132] by ojan@chromium.org
  • 10 edits in trunk/Tools

Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114370

Reviewed by Ryosuke Niwa.

Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
Unfortunately, there's no way to test this until this is committed and there is
a master restart.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  • TestResultServer/generate_builders_json.py:
  • TestResultServer/static-dashboards/dashboard_base.js:
  • TestResultServer/static-dashboards/loader.js:
1:02 PM Changeset in webkit [148131] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Clicking on the volume slider of HTML5 elements is pausing sometimes
https://bugs.webkit.org/show_bug.cgi?id=112548

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-10
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/click-volume-bar-not-pausing.html

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler):
Calling the setDefaultHandled() method on the event prevents it
from being incorrectly propagated from the volume button up to the
MediaDocument.

LayoutTests:

Added test.

  • media/click-volume-bar-not-pausing-expected.txt: Added.
  • media/click-volume-bar-not-pausing.html: Added.
1:01 PM Changeset in webkit [148130] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

DFG: Negative size for new Array() interpreted as large unsigned int
https://bugs.webkit.org/show_bug.cgi?id=114366

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Added new check in operationNewArrayWithSize() for a negative
size. If size is negative throw a "RangeError: Array size is not a
small enough positive integer" exception.

  • dfg/DFGOperations.cpp:

LayoutTests:

New test to make sure DFG generated code for new Array() with a
computed negative size throws an exception.

  • fast/js/dfg-negative-array-size-expected.txt: Added.
  • fast/js/dfg-negative-array-size.html: Added.
  • fast/js/script-tests/dfg-negative-array-size.js: Added.
12:56 PM Changeset in webkit [148129] by anilsson@rim.com
  • 17 edits
    2 moves in trunk/Source

[BlackBerry] Rename BlackBerry specific Texture class
https://bugs.webkit.org/show_bug.cgi?id=95781

Reviewed by Rob Buis.

Texture was a bit too generic and prone to name conflicts. Renamed it
to LayerTexture.

Source/WebCore:

No change in behavior, no new tests.

PR 322882

  • PlatformBlackBerry.cmake:
  • platform/graphics/blackberry/LayerCompositingThread.cpp:

(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):

  • platform/graphics/blackberry/LayerCompositingThread.h:

(LayerCompositingThread):

  • platform/graphics/blackberry/LayerCompositingThreadClient.h:

(WebCore):
(WebCore::LayerCompositingThreadClient::contentsTexture):

  • platform/graphics/blackberry/LayerFilterRenderer.cpp:

(WebCore::LayerFilterRenderer::applyActions):

  • platform/graphics/blackberry/LayerFilterRenderer.h:

(LayerFilterRenderer):

  • platform/graphics/blackberry/LayerRendererSurface.h:

(WebCore::LayerRendererSurface::texture):
(LayerRendererSurface):

  • platform/graphics/blackberry/LayerTexture.cpp: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.cpp.

(WebCore):
(WebCore::LayerTexture::LayerTexture):
(WebCore::LayerTexture::~LayerTexture):
(WebCore::LayerTexture::updateContents):
(WebCore::LayerTexture::setContentsToColor):
(WebCore::LayerTexture::protect):

  • platform/graphics/blackberry/LayerTexture.h: Renamed from Source/WebCore/platform/graphics/blackberry/Texture.h.

(WebCore):
(LayerTexture):
(WebCore::LayerTexture::create):
(WebCore::LayerTexture::textureId):
(WebCore::LayerTexture::isDirty):
(WebCore::LayerTexture::hasTexture):
(WebCore::LayerTexture::isColor):
(WebCore::LayerTexture::isOpaque):
(WebCore::LayerTexture::isProtected):
(WebCore::LayerTexture::protect):
(WebCore::LayerTexture::unprotect):
(WebCore::LayerTexture::size):
(WebCore::LayerTexture::width):
(WebCore::LayerTexture::height):
(WebCore::LayerTexture::bytesPerPixel):
(WebCore::LayerTexture::sizeInBytes):
(WebCore::LayerTexture::setTextureId):
(WebCore::LayerTexture::setSize):

  • platform/graphics/blackberry/LayerTile.cpp:

(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
(WebCore::LayerTile::setTexture):

  • platform/graphics/blackberry/LayerTile.h:

(WebCore::LayerTile::texture):
(LayerTile):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::contentsTexture):

  • platform/graphics/blackberry/LayerTiler.h:

(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):

  • platform/graphics/blackberry/TextureCacheCompositingThread.cpp:

(WebCore::TextureProtector::TextureProtector):
(TextureProtector):
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::textureResized):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::textureAccessed):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::textureForColor):
(WebCore::TextureCacheCompositingThread::updateContents):

  • platform/graphics/blackberry/TextureCacheCompositingThread.h:

(WebCore::TextureCacheCompositingThread::createTexture):
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):

Source/WebKit/blackberry:

PR 322882

  • Api/WebOverlay.cpp:

(BlackBerry::WebKit::WebOverlayLayerCompositingThreadClient::uploadTexturesIfNeeded):

  • Api/WebOverlay_p.h:

(WebOverlayLayerCompositingThreadClient):

12:38 PM Changeset in webkit [148128] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Disallow programmatic movement of the browser window while user gestures are in progress.
<http://webkit.org/b/114271>
<rdar://problem/13226530>

Reviewed by Oliver Hunt.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

12:33 PM Changeset in webkit [148127] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

WinCairo build fails to link.
https://bugs.webkit.org/show_bug.cgi?id=114358

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-10
Reviewed by Brent Fulgham.

Export the symbol WTF::MD5::checksum().

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
12:24 PM Changeset in webkit [148126] by glenn@skynav.com
  • 3 edits in trunk/Tools

[Qt] Fix regression to test-webkitpy.
https://bugs.webkit.org/show_bug.cgi?id=114368

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/port/factory.py:

(PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
(PortFactory.get): Remove obsolete chromium port related code.

  • Scripts/webkitpy/layout_tests/port/mac.py:

(MacPort.default_child_processes): Prevent type error if can't determine total memory.

12:18 PM Changeset in webkit [148125] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fixed build failure in Plugin.h: FloatPoint was not in namespace WebCore

make[1]: * Waiting for unfinished jobs....
In file included from Source/WebKit2/PluginProcess/PluginCreationParameters.h:31:0,

from Source/WebKit2/PluginProcess/PluginCreationParameters.cpp:27:

./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:58: error: 'FloatPoint' in namespace 'WebCore' does not name a type
./Source/WebKit2/WebProcess/Plugins/Plugin.h:268:77: error: ISO C++ forbids declaration of 'parameter' with no type [-fpermissive]
cc1plus: warning: unrecognized command line option "-Wno-c++11-extensions" [enabled by default]
make[1]: * [Source/WebKit2/PluginProcess/libwebkit2gtk_3_0_la-PluginCreationParameters.lo] Error 1

It now passes that make target.

https://bugs.webkit.org/show_bug.cgi?id=111862

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2013-04-10
Reviewed by Darin Adler.

  • WebProcess/Plugins/Plugin.h:

(WebCore): Added FloatPoint to the WebCore namespace

12:16 PM Changeset in webkit [148124] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
https://bugs.webkit.org/show_bug.cgi?id=114344

Reviewed by Enrica Casucci.

This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane state.
Extracted isAutomaticTextReplacementType and correctSpellcheckingPreservingTextCheckingParagraph,
and made convenience local variables const.

In particular, shouldMarkSpelling used to be assigned of false when shouldShowCorrectionPanel was true
in a middle of a function but this was removed in favor of explicitly checking this condition later
since shouldMarkSpelling was only referenced once after the assignment.

  • editing/Editor.cpp:

(WebCore::isAutomaticTextReplacementType): Extracted.

(WebCore::correctSpellcheckingPreservingTextCheckingParagraph): Extracted. Used highestAncestor
and rangeFromLocationAndLength to match the rest of the up-to-date editing code.

(WebCore::Editor::markAndReplaceFor): See above.

12:11 PM Changeset in webkit [148123] by andersca@apple.com
  • 38 edits in trunk

Remove unneeded headers from FrameLoader.h
https://bugs.webkit.org/show_bug.cgi?id=114223

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Update for WTF changes.

  • bytecode/SpeculatedType.h:
  • runtime/JSCJSValue.h:

Source/WebCore:

Remove unneeded headers from FrameLoader.h and add them back into the respective .cpp files where needed.

  • dom/Document.cpp:
  • history/CachedFrame.cpp:
  • history/PageCache.cpp:
  • inspector/InspectorResourceAgent.cpp:
  • loader/DocumentLoader.cpp:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::retryAfterFailedCacheOnlyMainResourceLoad):

  • loader/FrameLoader.h:

(WebCore):
(WebCore::FrameLoader::policyChecker):
(WebCore::FrameLoader::history):
(WebCore::FrameLoader::icon):

  • loader/MixedContentChecker.h:
  • loader/icon/IconLoader.cpp:
  • page/History.cpp:
  • page/Page.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • testing/Internals.cpp:

Source/WebKit/blackberry:

Include HistoryController.h from WebCore.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

Source/WebKit/mac:

Include HistoryController.h from WebCore.

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebView.mm:

Source/WebKit/win:

Include HistoryController.h from WebCore.

  • WebView.cpp:

Source/WebKit2:

Include HistoryController.h from WebCore.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebPage/WebPage.cpp:

Source/WTF:

  • wtf/Forward.h:

Add PrintStream.

  • wtf/HashTable.h:

Don't include DataLog.h unless DUMP_HASHTABLE_STATS_PER_TABLE is 1.

Tools:

Add back headers implicitly included by other headers.

  • WebKitTestRunner/WorkQueueManager.cpp:
12:03 PM Changeset in webkit [148122] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Minor code cleanup in AnimationBase::progress
https://bugs.webkit.org/show_bug.cgi?id=114371

Reviewed by Dean Jackson.

Convert some "return; else if" to just "return; if".

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::progress):

11:56 AM Changeset in webkit [148121] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Empty inline continuations should only get lineboxes if the padding applies to their side of the inline
https://bugs.webkit.org/show_bug.cgi?id=113896

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/inline/inline-with-empty-inline-continuations.html

Where an empty inline is split across anonymous blocks we should only give lineboxes to the 'sides' of the
inline that have borders, padding or margin.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::shouldApplyStartBorderPaddingOrMargin):
(WebCore):
(WebCore::shouldApplyEndBorderPaddingOrMargin):
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
(WebCore::alwaysRequiresLineBox):

LayoutTests:

  • fast/inline/inline-with-empty-inline-continuations-expected.txt: Added.
  • fast/inline/inline-with-empty-inline-continuations.html: Added.
11:53 AM Changeset in webkit [148120] by zoltan@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Exclusions] Increasing padding does not correctly layout child blocks
https://bugs.webkit.org/show_bug.cgi?id=112929

Reviewed by David Hyatt.

If a child block has changed dimension inside a shape and it has affected the block siblings
we need to relayout the content inside the shape.

Source/WebCore:

Test: fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout): Add condition for dimension change.
(WebCore::RenderBlock::layoutBlock): Call updateRegionsAndExclusionsAfterChildLayout with the new parameter.

  • rendering/RenderBlock.h:

(RenderBlock): Add extra parameter to updateRegionsAndExclusionsAfterChildLayout(...)

LayoutTests:

  • fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-sibling-block-dimension-change-needs-relayout.html: Added.
11:51 AM Changeset in webkit [148119] by ggaren@apple.com
  • 42 edits
    2 deletes in trunk/Source

Removed bitrotted TimeoutChecker code
https://bugs.webkit.org/show_bug.cgi?id=114336

Reviewed by Alexey Proskuryakov.

../JavaScriptCore:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

  • API/APIShims.h:

(JSC::APIEntryShim::~APIEntryShim):
(JSC::APIEntryShim::init):

  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGGPRInfo.h:
  • jit/JIT.cpp:
  • jit/JIT.h:
  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JSInterfaceJIT.h:

(JSInterfaceJIT):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::Walker::walk):

  • runtime/TimeoutChecker.cpp: Removed.
  • runtime/TimeoutChecker.h: Removed.

../WebCore:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::commonJSGlobalData):

  • bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::call):

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::executeFunctionInContext):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneBase::CloneBase):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneDeserializer::deserialize):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject evaluateWebScript:]):

../WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setTimeoutForJavaScriptExecution):

../WebKit/mac:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::evaluate):

../WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::createDocumentLoader):

../WebKit2:

This mechanism hasn't worked for a while.

MarkL is working on a new version of this feature with a distinct
implementation.

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::evaluate):

11:50 AM Changeset in webkit [148118] by paroga@webkit.org
  • 2 edits in trunk/Source/WebCore

Replace ENABLE_JAVASCRIPT_DEBUGGER preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114352

Reviewed by Timothy Hatcher.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

  • page/Console.idl:
11:48 AM Changeset in webkit [148117] by Alexandru Chiculita
  • 3 edits
    2 adds in trunk

Layers with opacity and blur filters are reported as opaque to the compositor
https://bugs.webkit.org/show_bug.cgi?id=114295

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/contents-opaque/filter.html

Some filters like opacity and blur might still trigger transparency in the layer, even though the
background is opaque. I've added the special case in RenderLayer::backgroundIsKnownToBeOpaqueInRect to check
for filters that might have transparency. Note that this special case is required only for software drawn
filters, as the transparency is going to be backed in the GraphicsLayer content. Composited filters can
figure it out in the compositor.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Added test to check for blur and opacity filters drawn in software mode which needs
to force the layer report non-opaque to the compositor.

  • compositing/contents-opaque/filter-expected.txt: Added.
  • compositing/contents-opaque/filter.html: Added.
11:37 AM Changeset in webkit [148116] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.11/Source/WebCore

Rollout r148109.

11:26 AM Changeset in webkit [148115] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

[Texmap] In certain situations nested blending with overflow:hidden displays clipped results
https://bugs.webkit.org/show_bug.cgi?id=114290

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

Always apply the clip when binding a surface, even if it hasn't changed.
Otherwise when binding a nested surface and rebinding its container surface,
the clip wouldn't apply.

Test: compositing/overlap-blending/nested-overlap-overflow.html

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::BitmapTextureGL::bind):

LayoutTests:

Added a ref-test that exposes an issue with TextureMapper overlap blending when composited.
This ref-test does not show correct results on Mac, skipped in TestExpectations and created a bug.

  • compositing/overlap-blending/nested-overlap-overflow-expected.html: Added.
  • compositing/overlap-blending/nested-overlap-overflow.html: Added.
  • platform/mac/TestExpectations: Skipped new tests and created bug.
11:17 AM Changeset in webkit [148114] by mrowe@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

I should know better than to lie in ChangeLog entries.

11:14 AM Changeset in webkit [148113] by mrowe@apple.com
  • 4 edits in trunk/Source/WebKit2

<rdar://problem/13617144> WKNavigationData needs to expose the destination of the navigation

Introduce WKNavigationDataCopyNavigationDestinationURL to access the destination of the navigation.

Reviewed by Darin Adler.

  • UIProcess/API/C/WKNavigationData.cpp:

(WKNavigationDataCopyURL): Add a note about returning the URL from the original request for sake of
backwards-compatibility.
(WKNavigationDataCopyNavigationDestinationURL): Return the URL from our underlying WebNavigationDataStore.

  • UIProcess/API/C/WKNavigationData.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory): Store the current URL in to the WebNavigationDataStore
object. WKNavigationData can retrieve the value that we were previously storing here via the originalRequest.

11:14 AM Changeset in webkit [148112] by mrowe@apple.com
  • 4 edits in trunk/Source/WebKit2

<rdar://problem/13617104> WKPageCopySessionState needs to provide more context to the filter callback

Introduce a new value type for WKPageSessionStateFilterCallback that represents the passing
of whole WKBackForwardListItemRefs to the filter callback. This allows clients to consider
more than the original URL of the item when filtering entries from the session state.

Reviewed by Darin Adler.

  • UIProcess/API/C/WKPage.cpp:

(WKPageGetSessionBackForwardListItemValueType): Return a static string representing our new value type.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation): Call the filter function with each of the
possible value types in turn, respecting the first false value, if any, that is returned.

11:07 AM Changeset in webkit [148111] by antti@apple.com
  • 4 edits in trunk/Source/WebCore

Use minimal tiles during live resize
https://bugs.webkit.org/show_bug.cgi?id=114364

Reviewed by Darin Adler.

We currently update non-visible speculative tiles during resizing. We should just drop them.

  • page/FrameView.cpp:

(WebCore::FrameView::willStartLiveResize):
(WebCore::FrameView::willEndLiveResize):

  • page/FrameView.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

Use minimal coverage in live resize state.

11:05 AM Changeset in webkit [148110] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/Tools

[GTK] Include a crash-fixing patch for the at-spi2-atk dependency
https://bugs.webkit.org/show_bug.cgi?id=114365

Reviewed by Martin Robinson.

Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
The patch addresses crashes in the tally_event_reply method. It is already committed into the
at-spi2-atk source tree and will be available with the next stable release, after which the
patch should be removed and the dependency version bumped.

  • gtk/jhbuild.modules:
  • gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
11:03 AM Changeset in webkit [148109] by Lucas Forschler
  • 2 edits in tags/Safari-537.35.11/Source/WebCore

Merged r147977. <rdar://problem/13604480>

10:55 AM Changeset in webkit [148108] by Lucas Forschler
  • 4 edits in tags/Safari-537.35.11/Source

Versioning.

10:51 AM Changeset in webkit [148107] by Lucas Forschler
  • 1 copy in tags/Safari-537.35.11

New Tag.

10:47 AM Changeset in webkit [148106] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION (r148073): WebKit Nightly r148082 crashes on launch in JSObjectSetPrivate
https://bugs.webkit.org/show_bug.cgi?id=114341

Reviewed by Alexey Proskuryakov.

Make JSObjectSetPrivate use uncheckedToJS as some clients
clear their private data during finalization for some reason.

  • API/JSObjectRef.cpp:

(JSObjectSetPrivate):

10:36 AM BuildingGtk edited by mrobinson@webkit.org
Warn that the instructions aren't really useful for building a release … (diff)
10:13 AM Changeset in webkit [148105] by commit-queue@webkit.org
  • 19 edits
    4 adds in trunk

Blob content type normalization.
https://bugs.webkit.org/show_bug.cgi?id=111380

Patch by Victor Costan <costan@gmail.com> on 2013-04-10
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Tests: http/tests/fast/files/blob-constructor.js

http/tests/fileapi/xhr-send-form-data-filename-escaping.html
http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html

  • WebCore.exp.in: exported Blob::isNormalizedContentType()
  • bindings/js/JSBlobCustom.cpp:

(WebCore::JSBlobConstructor::constructJSBlob): remove checks on Blob type, BlobBuilder will normalize it

  • fileapi/Blob.cpp:

(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::BlobType::isValid): content type validity checks in the File API spec
(WebCore::BlobType::normalize): implements the normalization rules in the File API spec
(WebCore::BlobType::isNormalized): useful for ASSERTing that a Blob type has been normalized
(WebCore): implement Blob type normalization according to the File API spec
(WebCore::Blob::Blob): normalize the Blob type in the data URL
(WebCore::Blob::slice): normalize the Blob type argument

  • fileapi/Blob.h:

(BlobType): utilities for normalizing a Blob's type according to the File API spec
(WebCore::Blob::create): assert that the deserialized Blob's type was normalized

  • fileapi/File.cpp:

(WebCore::createBlobDataForFileWithType): assert that the File's MIME type is a normalized Blob type

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::getBlob): normalize the Blob's type before building it

  • platform/network/BlobData.h:

(WebCore::BlobData::setContentType): assert that the Blob type has been normalized

  • platform/network/FormData.cpp:

(WebCore::FormData::appendKeyValuePairItems): assert that Blob's type has been normalized

  • platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addContentTypeToMultiPartHeader): assert that the Content-Type field is normalized

  • xml/XMLHttpRequest.cpp: when responseType is blob, normalize Content-Type before passing to Blob constructor

LayoutTests:

  • http/tests/fast/files/script-tests/blob-constructor.js: added/updated test cases for Blob type normalization
  • http/tests/fast/files/blob-constructor-expected.txt: added/updated test cases for Blob type normalization
  • http/tests/fileapi/xhr-send-form-data-filename-escaping-expected.txt: Added.
  • http/tests/fileapi/xhr-send-form-data-filename-escaping.html: Added.
  • http/tests/fileapi/xhr-send-form-data-mimetype-normalization-expected.txt: Added.
  • http/tests/fileapi/xhr-send-form-data-mimetype-normalization.html: Added.
  • http/tests/local/formdata/resources/send-form-data-common.js:

(dumpResponse): return the HTTP response text so it can be used in JS test code
(sendFormData): passthrough the HTTP response text returned by dumpResponse()
(testSendingFormData): passthrough the HTTP response text returned by dumpResponse()

  • http/tests/xmlhttprequest/post-blob-content-type-async-expected.txt: updated expectation for invalid Content-Type
  • http/tests/xmlhttprequest/post-blob-content-type-sync-expected.txt: updated expectation for invalid Content-Type
  • http/tests/xmlhttprequest/post-blob-content-type-tests.js: updated expectation for invalid Content-Type
10:11 AM Changeset in webkit [148104] by simon.fraser@apple.com
  • 13 edits
    8 deletes in trunk/LayoutTests

Rebaseline four tiled drawing tests affeted by r148049.

Move results from platform/mac/platform/mac-wk2/tiled-drawing to platform/mac-wk2/tiled-drawing

  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view-expected.txt:
  • platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt: Removed.
  • platform/mac/platform/mac-wk2/tiled-drawing/sticky/sticky-vertical-expected.txt: Removed.
9:50 AM Changeset in webkit [148103] by bfulgham@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Unreviewed build fix. Correct DropBox download link.

  • Scripts/update-webkit-wincairo-libs: Revise download URL to

match change in DropBox server behavior.

9:32 AM Changeset in webkit [148102] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

TileController doesn't remove tiles when the view is resized, leading to stale content
https://bugs.webkit.org/show_bug.cgi?id=114323
<rdar://problem/13520671>

Reviewed by Simon Fraser.

Ensure that tiles are removed if the view shrinks, so that they are not displayed
with stale content if the view later grows again (they will not be repainted by WebCore
while out-of-view).

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::revalidateTiles):

9:28 AM Changeset in webkit [148101] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update the localizable strings file.

Rubber-stamped by Dan Bernstein.

  • English.lproj/Localizable.strings:
9:27 AM Changeset in webkit [148100] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

Replace ENABLE_CHANNEL_MESSAGING preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114346

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

  • page/DOMWindow.idl:
  • workers/WorkerContext.idl:
9:25 AM Changeset in webkit [148099] by eric.carlson@apple.com
  • 32 edits in trunk/Source/WebCore

Update all float attributes in HTMLMediaElement to double
https://bugs.webkit.org/show_bug.cgi?id=113615

Reviewed by Geoffrey Garen
Patch by Aaron Colwell

No new tests. Primary behavior doesn't change. Just time, playbackRate, and volume precision.
All existing LayoutTests/media tests still pass.

  • WebCore.exp.in: Remove function that no longer need to be exported.
  • html/HTMLMediaElement.cpp: Change all float attributes to double.
  • html/HTMLMediaElement.h: Ditto.
  • html/HTMLMediaElement.idl: Ditto.
  • html/MediaController.cpp: Ditto.
  • html/MediaController.h: Ditto.
  • html/MediaControllerInterface.h: Ditto.
  • html/TimeRanges.cpp: Ditto.
  • html/TimeRanges.idl: Ditto.
  • html/shadow/MediaControlElementTypes.cpp: Ditto.
  • html/shadow/MediaControlElementTypes.h: Ditto.
  • html/shadow/MediaControlElements.cpp: Ditto.
  • html/shadow/MediaControlElements.h: Ditto.
  • html/shadow/MediaControls.cpp: Ditto.
  • html/shadow/MediaControlsApple.cpp: Ditto.
  • html/shadow/MediaControlsBlackBerry.cpp: Ditto.
  • html/shadow/MediaControlsBlackBerry.h: Ditto.
  • html/shadow/MediaControlsGtk.cpp: Ditto.
  • html/track/TextTrackCue.cpp: Ditto.
  • html/track/TextTrackCue.h: Ditto.
  • platform/Clock.h: Ditto.
  • platform/ClockGeneric.cpp: Ditto.
  • platform/ClockGeneric.h: Ditto.
  • platform/graphics/MediaPlayer.cpp: Ditto.
  • platform/graphics/MediaPlayer.h: Ditto.
  • platform/graphics/MediaPlayerPrivate.h: Ditto.
  • platform/mac/PlatformClockCA.cpp: Ditto.
  • platform/mac/PlatformClockCA.h: Ditto.
  • platform/mac/PlatformClockCM.h: Ditto.
  • platform/mac/PlatformClockCM.mm: Ditto.
9:16 AM Changeset in webkit [148098] by paroga@webkit.org
  • 3 edits in trunk/Source/WebCore

Replace ENABLE_MICRODATA preprocessor statements in IDL files with Conditional attribute
https://bugs.webkit.org/show_bug.cgi?id=114349

Reviewed by Geoffrey Garen.

The Conditional attribute does not need a preprocessor, which is source of much pain on native windows.

  • dom/Document.idl:
  • html/HTMLElement.idl:
9:13 AM Changeset in webkit [148097] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r148034): IconDatabase::updateIconRecord crashes with null iconData and iconBitmap.
https://bugs.webkit.org/show_bug.cgi?id=114356

Reviewed by Tim Horton.

When loading an icon fails (for example, when a non-existent URI is
passed to the loader), updateIconRecord can be called with both
iconData and iconBitmap having no data.

This used to be fine before r148034, but causes an assertion now.

No new tests, existing tests such as fast/encoding/mispositioned-meta.html
were crashing.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::updateIconRecord): Change the ASSERT() to check
for a NAND condition that only fails if both iconData and iconBitmap
are not 0.

8:44 AM Changeset in webkit [148096] by ggaren@apple.com
  • 2 edits in trunk/Tools

Removed an annoying message from svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=114332

Reviewed by Alexey Proskuryakov.

I see this message basically every time I write a patch, so it must not
be true.

  • Scripts/svn-create-patch:

(generateDiff):

8:10 AM Changeset in webkit [148095] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/qt

[Qt] Add API in QWebSettings for setting the CSS media type
https://bugs.webkit.org/show_bug.cgi?id=113853

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

  • Api/qwebsettings.cpp:

(QWebSettingsPrivate):
(QWebSettingsPrivate::apply):
(QWebSettings::setCSSMediaType):
(QWebSettings::cssMediaType):

  • Api/qwebsettings.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp:

(WebCore::FrameLoaderClientQt::overrideMediaType):

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage):
(tst_QWebPage::cssMediaTypeGlobalSetting):
(tst_QWebPage::cssMediaTypePageSetting):

7:58 AM Changeset in webkit [148094] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Texmap] Update a dirty region which is not covered with keepRect.
https://bugs.webkit.org/show_bug.cgi?id=113752

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-04-10
Reviewed by Jocelyn Turcotte.

There can be a dirty region which is not covered with keepRect.
However the dirty could be inside the tile area. In this case,
currently we ignore the dirty by intersecting with keepRect
and the dirty region will not be invalidated until the tile is
recreated. We must expand the keep rect to its intersecting tiles
to make sure that the dirty region is applied to existing tiles.

No tests needed, change is unobservable.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::invalidate):

7:36 AM Changeset in webkit [148093] by l.gombos@samsung.com
  • 4 edits in trunk/Source

Remove ENABLE_3D_PLUGIN
https://bugs.webkit.org/show_bug.cgi?id=108002

Source/WebCore:

Remove ENABLE_3D_PLUGIN, it was only used by Chromium.

Reviewed by Antti Koivisto.

No new tests, removing dead code.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadPlugin):

Source/WTF:

Reviewed by Antti Koivisto.

Remove ENABLE_3D_PLUGIN, it was only used by Chromium.

  • wtf/FeatureDefines.h:
6:47 AM Changeset in webkit [148092] by abucur@adobe.com
  • 1 edit
    57 adds in trunk/LayoutTests

[CSS Regions] Add tests for lists and counters
https://bugs.webkit.org/show_bug.cgi?id=103975

Reviewed by Antti Koivisto.

Lists and counters work correctly with regions since r148026 (http://trac.webkit.org/changeset/148026).
This patch adds W3C formatted ref tests to our battery.

  • fast/regions/counters/extract-list-items-001-expected.html: Added.
  • fast/regions/counters/extract-list-items-001.html: Added.
  • fast/regions/counters/extract-list-items-002-expected.html: Added.
  • fast/regions/counters/extract-list-items-002.html: Added.
  • fast/regions/counters/extract-list-items-003-expected.html: Added.
  • fast/regions/counters/extract-list-items-003.html: Added.
  • fast/regions/counters/extract-list-items-004-expected.html: Added.
  • fast/regions/counters/extract-list-items-004.html: Added.
  • fast/regions/counters/extract-list-items-005-expected.html: Added.
  • fast/regions/counters/extract-list-items-005.html: Added.
  • fast/regions/counters/extract-list-items-006-expected.html: Added.
  • fast/regions/counters/extract-list-items-006.html: Added.
  • fast/regions/counters/extract-list-items-007-expected.html: Added.
  • fast/regions/counters/extract-list-items-007.html: Added.
  • fast/regions/counters/extract-list-items-008-expected.html: Added.
  • fast/regions/counters/extract-list-items-008.html: Added.
  • fast/regions/counters/extract-list-items-009-expected.html: Added.
  • fast/regions/counters/extract-list-items-009.html: Added.
  • fast/regions/counters/extract-list-items-010-expected.html: Added.
  • fast/regions/counters/extract-list-items-010.html: Added.
  • fast/regions/counters/extract-list-items-011-expected.html: Added.
  • fast/regions/counters/extract-list-items-011.html: Added.
  • fast/regions/counters/extract-list-items-012-expected.html: Added.
  • fast/regions/counters/extract-list-items-012.html: Added.
  • fast/regions/counters/extract-list-items-013-expected.html: Added.
  • fast/regions/counters/extract-list-items-013.html: Added.
  • fast/regions/counters/extract-list-items-014-expected.html: Added.
  • fast/regions/counters/extract-list-items-014.html: Added.
  • fast/regions/counters/extract-list-items-015-expected.html: Added.
  • fast/regions/counters/extract-list-items-015.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs-expected.html: Added.
  • fast/regions/counters/extract-numbered-paragraphs.html: Added.
  • fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Added.
  • fast/regions/counters/extract-numbered-spans-display-only-some.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-001.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-002.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-003.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Added.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Added.
  • fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Added.
  • fast/regions/counters/extract-unordered-lists-in-regions.html: Added.
5:18 AM Changeset in webkit [148091] by zarvai@inf.u-szeged.hu
  • 10 edits in trunk/LayoutTests

[Qt][WK2] Unreviewed gardening. Rebaselining after r148049.

  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
4:48 AM Changeset in webkit [148090] by commit-queue@webkit.org
  • 6 edits
    4 adds in trunk

[Texmap] Hierarchy of layers with opacity may result in wrong blending.
https://bugs.webkit.org/show_bug.cgi?id=113732

Patch by Noam Rosenthal <noam@webkit.org> on 2013-04-10
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

This is a combination of three issues with nested intermediate surfaces:

  • glScissor inside an intermediate surface should not be mirrored.
  • The current surface should be passed to the next surface in paintOptions.
  • When clipping for the non-overlap region, the containing surface offset

should be applied.

Though the changes are separate, they cannot be tested separately as neither
fixes a testable case on its own.

Tests: compositing/overlap-blending/nested-non-overlap-clipping.html

compositing/overlap-blending/nested-overlap.html

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::ClipStack::reset):
(WebCore::TextureMapperGL::ClipStack::apply):
(WebCore::TextureMapperGL::beginPainting):
(WebCore::BitmapTextureGL::clearIfNeeded):

  • platform/graphics/texmap/TextureMapperGL.h:

(ClipStack):

Do not mirror the scissor clip when painting to an FBO.
Also a minor refactor to avoid reading the viewport values from the driver.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintUsingOverlapRegions):

Apply the offset when clipping for a non-overlap region.

(WebCore::TextureMapperLayer::paintIntoSurface):

Make sure the current surface is passed to the next one.

LayoutTests:

Added two ref-tests for nested composited overlaps.
This ref-test does not work on Mac due to a slight mismatch opacity value on CoreAnimation.
A new bug has been posted, and TestExpectations has been updated.

  • compositing/overlap-blending/nested-non-overlap-clipping-expected.html: Added.
  • compositing/overlap-blending/nested-non-overlap-clipping.html: Added.
  • compositing/overlap-blending/nested-overlap-expected.html: Added.
  • compositing/overlap-blending/nested-overlap.html: Added.
  • platform/mac/TestExpectations: Skipped new tests and created bug.
4:34 AM Changeset in webkit [148089] by antti@apple.com
  • 19 edits
    2 copies
    2 adds in trunk

Create fewer tiles when page is loading
https://bugs.webkit.org/show_bug.cgi?id=114294

Source/WebCore:

Reviewed by Anders Carlsson.

We currently create speculative tiles immediately. Page is often changing rapidly during loading and
keeping the speculative tiles up to date creates extra work.

Tests: platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html

platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

  • page/FrameView.cpp:

(WebCore::FrameView::adjustTiledBackingCoverage):
(WebCore::FrameView::setWasScrolledByUser):

User scrolling enables speculative tiling no matter what the load status.

  • page/FrameView.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):
(WebCore::RenderLayerBacking::adjustTiledBackingCoverage):

Cover only the viewport during loading.

LayoutTests:

Reviewed by Anders Carlsson.

Reduced initial tile counts and new tests for speculative tiles.

  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-speculative.html: Added.
  • platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-speculative-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/tile-coverage-speculative.html: Added.
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
  • platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
  • platform/mac/platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
3:48 AM Changeset in webkit [148088] by mario@webkit.org
  • 14 edits in trunk

[GTK] Add support for Page Visibility
https://bugs.webkit.org/show_bug.cgi?id=97324

Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-04-10
Reviewed by Sam Weinig.

.:

Page Visibility has been enabled for GTK port.
New GTK unittest has been added.

  • Source/autotools/SetupWebKitFeatures.m4:

Source/WebKit/gtk:

Implemented access to page visibility API for GTK test runner.

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::setPageVisibility):

  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

Source/WebKit2:

Added new unittest to test page visibility using GTK Widget visibility API.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewPageVisibility):
(beforeAll):

  • UIProcess/API/gtk/tests/WebViewTest.cpp:

(WebViewTest::showInWindow):

  • UIProcess/API/gtk/tests/WebViewTest.h:

Tools:

Implemented test runner API for page visibility layout tests.

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::resetPageVisibility):
(TestRunner::setPageVisibility):

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/gtk/TestExpectations:
2:47 AM Changeset in webkit [148087] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] RenderThemeBlackBerry: get rid of all the SKIA code
https://bugs.webkit.org/show_bug.cgi?id=114339

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-10
Reviewed by Carlos Garcia Campos.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaVolumeSliderThumb):

2:17 AM Changeset in webkit [148086] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
https://bugs.webkit.org/show_bug.cgi?id=114342

Reviewed by Gyuyoung Kim.

Commit 148033 only added an implementation for the Mac port, which made
other ports fail most tests since loading the injected bundle failed
with a missing symbol.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::pathDescription):

2:06 AM Changeset in webkit [148085] by zarvai@inf.u-szeged.hu
  • 9 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r148049.

  • platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt: Removed.
  • platform/qt/compositing/iframes/page-cache-layer-tree-expected.txt: Renamed from LayoutTests/platform/qt-5.0-wk1/compositing/iframes/page-cache-layer-tree-expected.txt.
  • platform/qt/fast/multicol/shadow-breaking-expected.txt:
  • platform/qt/svg/css/composite-shadow-text-expected.png:
  • platform/qt/svg/css/composite-shadow-text-expected.txt:
  • platform/qt/svg/css/group-with-shadow-expected.txt:
  • platform/qt/svg/css/path-with-shadow-expected.txt:
  • platform/qt/svg/css/shadow-and-opacity-expected.txt:
  • platform/qt/svg/css/shadow-breaking-expected.png: Added.
  • platform/qt/svg/css/text-shadow-multiple-expected.txt:
  • platform/qt/transitions/svg-text-shadow-transition-expected.txt:
12:55 AM Changeset in webkit [148084] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add spell checking option to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=114282

Patch by Artur Moryc <a.moryc@samsung.com> on 2013-04-10
Reviewed by Ryosuke Niwa.

Spell checking is enabled by adding a flag (t/text-checking)
with launching MiniBrowser.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

12:39 AM Changeset in webkit [148083] by zandobersek@gmail.com
  • 5 edits in trunk

REGRESSION (r146518): WebKit2APITests/TestInspector is failing
https://bugs.webkit.org/show_bug.cgi?id=113281

Reviewed by Darin Adler.

Source/WebKit2:

Changes to the WebInspectorProxy opening processing in r146518 caused the change in how the GTK-specific
WebInspectorProxy code operates, specifically the 'bring-to-front' signal is not emitted anymore when opening the
inspector due to the WebInspectorProxy::bringToFront method now only bringing the inspector window to front if it exists
and opening it (and thus unable to bring it to front) otherwise.

Closing of the inspector through the didClose method is now done immediately after sending the WebInspector::Close()
message to the WebProcess rather than waiting for the WebProcess to communicate back the order of closing. Due to this
the relevant code in the test cases had to be changed to not run the loop but rather just check that the closing was
successful.

(InspectorTest::InspectorTest): Remove the initialization of the now redundant m_quitOnBringToFront member variable.
(InspectorTest::bringToFront): Quit the loop without checking the removed member variable.
(InspectorTest::closed): Do not quit the loop as it is not run anymore.
(InspectorTest::showIdle): A helper method that asynchronously calls the webkit_web_inspector_show method, removing some
unnecessary complexity about under what exact circumstances to quit the loop in open-window/bring-to-front callbacks.
(InspectorTest::show): Replaces the showAndWaitUntilFinished method, adding an idle invocation of the showIdle helper
method and running the loop.
(InspectorTest::close): Formerly closeAndWaitUntilClosed, now does not run the loop anymore as there's no need for it.
(testInspectorDefault): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(CustomInspectorTest::destroyWindow): Formerly destroyWindowAndWaitUntilClosed, the closing is not asynchronous anymore
so the loop is not run.
(testInspectorManualAttachDetach): Only the window opening event is now expected upon showing the inspector for the first time.
Adjusting callsites to use InspectorTest::show and InspectorTest::close instead of
InspectorTest::showAndWaitUntilFinished and InspectorTest::showAndWaitUntilFinished.
(testInspectorCustomContainerDestroyed): Adjusting callsites to use InspectorTest::show and CustomInspectorTest::destroyWindow
instead of InspectorTest::showAndWaitUntilFinished and CustomInspectorTest::destroyWindowAndWaitUntilClosed.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::show): When showing a connected WebInspectorProxy, call the bringToFront method which will
open the inspector if it's not yet visible or bring it to the front otherwise.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.

12:38 AM Changeset in webkit [148082] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

[GTK][WK2] Implement WebInspectorProxy::platformInspectedWindowWidth
https://bugs.webkit.org/show_bug.cgi?id=113498

Patch by Zan Dobersek <zandobersek@gmail.com> on 2013-04-10
Reviewed by Martin Robinson.

The method was introduced in r147004.

  • UIProcess/API/gtk/tests/TestInspector.cpp: Specify the gMinimumAttachedInspectorWidth variable, reflecting the value

of WebInspectorProxy::minimumAttachedWidth. Use it as the width to which the inspected view should be resized in
InspectorTest::resizeViewAndAttach.

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformInspectedWindowHeight): Use the gtk_widget_get_allocated_height method to return the
widget height.
(WebKit::WebInspectorProxy::platformInspectedWindowWidth): Newly implemented, similarly uses the
gtk_widget_get_allocated_width method to return the widget width.

12:36 AM Changeset in webkit [148081] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r147719): Failures in two a11y tests on GTK
https://bugs.webkit.org/show_bug.cgi?id=114259

Reviewed by Ryosuke Niwa.

No new tests - covered by existing tests.

Partially revert r147719, restoring the possible creation of the AXObject cache
and the subsequent call to its handleFocusedUIElementChanged method. Removing this
code caused regressions in accessibility tests on the GTK port, so the comment about
the AXObject cache is adjusted accordingly.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

12:18 AM Changeset in webkit [148080] by zandobersek@gmail.com
  • 11 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r148049.

  • platform/gtk/fast/multicol/shadow-breaking-expected.txt:
  • platform/gtk/svg/css/composite-shadow-text-expected.txt:
  • platform/gtk/svg/css/group-with-shadow-expected.txt:
  • platform/gtk/svg/css/path-with-shadow-expected.txt:
  • platform/gtk/svg/css/shadow-and-opacity-expected.txt:
  • platform/gtk/svg/css/shadow-changes-expected.txt:
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt:
  • platform/gtk/svg/css/text-shadow-multiple-expected.txt:
  • platform/gtk/svg/custom/transform-with-shadow-and-gradient-expected.txt:
  • platform/gtk/transitions/svg-text-shadow-transition-expected.txt:

Apr 9, 2013:

11:59 PM Changeset in webkit [148079] by Philippe Normand
  • 3 edits
    3 adds in trunk

[GStreamer] playbin uri getter is invalid
https://bugs.webkit.org/show_bug.cgi?id=113884

Reviewed by Martin Robinson.

Source/WebCore:

When loading a new media location use the url stored as a member
variable instead of the one stored as a playbin property. The uri
property semantic changed in playbin since 0.10.36+. One should
now use current-uri but to avoid ifdefs depending on GStreamer
version we simply use the url already known as member variable.

Test: http/tests/media/video-redirect.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

New test for Quicktime reference movie redirect
support.

  • http/tests/media/resources/redirect-to-counting-captioned.mov: Added.
  • http/tests/media/video-redirect-expected.txt: Added.
  • http/tests/media/video-redirect.html: Added.
11:45 PM Changeset in webkit [148078] by Antoine Quint
  • 2 edits in trunk/Source/WebKit2

WKFrameIsDisplayingMarkupDocument should return true for Web Archives
https://bugs.webkit.org/show_bug.cgi?id=114291

Reviewed by Dean Jackson.

Also return true for the Web Archive MIME type since a Web Archive
is displaying a markup document by nature.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::isDisplayingMarkupDocument):

10:21 PM Changeset in webkit [148077] by glenn@skynav.com
  • 2 edits in trunk/Tools

Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.

Unreviewed.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_build_check):

10:12 PM Changeset in webkit [148076] by ggaren@apple.com
  • 12 edits in trunk

[JSC] Script run from an isolated world should bypass a page's CSP
https://bugs.webkit.org/show_bug.cgi?id=100815

Reviewed by Oliver Hunt.

Source/WebCore:

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::shouldBypassMainWorldContentSecurityPolicy):

  • bindings/js/ScriptController.h: Test the current caller's DOM wrapper

world to decide whether CSP should be enforced.

Like most of CSP, this is a stupid policy because it doesn't address
second-order effects like <script> parsing or event handler execution,
which might be triggered indirectly by privileged scripts. These indirect
effects are still broken. Oh well.

LayoutTests:

Enabled these tests, now that they pass.

I removed all the nonsense in these tests about setting an isolated world's
CSP and origin manually, since we have no use for those features.

  • http/tests/security/isolatedWorld/bypass-main-world-csp-expected.txt:
  • http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr-expected.txt:
  • http/tests/security/isolatedWorld/bypass-main-world-csp-for-xhr.html:
  • http/tests/security/isolatedWorld/bypass-main-world-csp.html:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
9:59 PM Changeset in webkit [148075] by glenn@skynav.com
  • 11 edits
    11 deletes in trunk/Tools

[webkitpy] Remove chromium ports.
https://bugs.webkit.org/show_bug.cgi?id=114326

Reviewed by Dirk Pranke.

As a side effect, also:

  • remove chromium builders from webkitpy.layout_tests.port.builders
  • remove chromium builders from rebaseline
  • rewrite chromium dependent tests in rebaseline_unittest
  • remove chromium platform from garden-o-matic
  • select apple platform as default platform in garden-o-matic
  • remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:

(BaselineOptimizerTest.test_move_baselines):
(BaselineOptimizerTest.test_efl):
(BaselineOptimizerTest.test_no_add_mac_future):
(BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
(BaselineOptimizerTest.test_common_directory_includes_root):
(BaselineOptimizerTest.test_complex_shadowing):
(BaselineOptimizerTest.test_virtual_ports_filtered):

  • Scripts/webkitpy/layout_tests/port/builders.py:
  • Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
  • Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
  • Scripts/webkitpy/layout_tests/port/factory.py:

(platform_options):
(PortFactory):

  • Scripts/webkitpy/layout_tests/port/factory_unittest.py:

(FactoryTest.test_qt):
(FactoryTest.test_get_from_builder_name):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_build_check):

  • Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

(TestExpectationsTestCase.test_determine_port_from_expectations_path):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(Rebaseline._builders_to_pull_from):

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(_BaseTestCase):
(_BaseTestCase.setUp):
(TestRebaselineTest.setUp):
(TestRebaselineTest.test_baseline_directory):
(test_rebaseline_updates_expectations_file):
(test_rebaseline_does_not_include_overrides):
(test_rebaseline_test):
(test_rebaseline_test_and_print_scm_changes):
(test_rebaseline_and_copy_test):
(test_rebaseline_and_copy_test_no_existing_result):
(test_rebaseline_and_copy_test_with_lion_result):
(test_rebaseline_and_copy_no_overwrite_test):
(TestRebaselineExpectations.test_rebaseline_expectations):

6:59 PM Changeset in webkit [148074] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove chromium exceptions from WebCore's gitattributes
https://bugs.webkit.org/show_bug.cgi?id=114327

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.

  • .gitattributes:
6:23 PM Changeset in webkit [148073] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318

Reviewed by Geoffrey Garen.

Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.

  • API/APICast.h:

(toJS):
(toJSForGC):
(unsafeToJS):

  • API/JSObjectRef.cpp:

(JSObjectGetPrivate):

6:11 PM Changeset in webkit [148072] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

Update Document's event listener type bitfield when adopting a Node
https://bugs.webkit.org/show_bug.cgi?id=114322

Reviewed by Darin Adler.

Source/WebCore:

Without this, moving a Node between documents can silently deactivate
an event listener, if it's one of the types that whose creation is
optimized away by Document::hasListenerType.

An alternate approach would be to simply copy the old document's
bitfield over. It's a tradeoff between making adoption fast and making
the operation of any operation depending on these event types fast.
The latter seems like the right optimization given that adoption
doesn't happen very often.

Test: fast/events/event-listener-moving-documents.html

  • dom/Node.cpp:

(WebCore::Node::didMoveToNewDocument): For each event listener type on the adopted node, update the new document's list of listener types.

LayoutTests:

  • fast/events/event-listener-moving-documents-expected.txt: Added.
  • fast/events/event-listener-moving-documents.html: Added.
5:57 PM Changeset in webkit [148071] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

Add logging channel for animations
https://bugs.webkit.org/show_bug.cgi?id=114325

Reviewed by Simon Fraser.

  • platform/Logging.cpp: Add LogAnimations.

(WebCore::getChannelFromName): Return LogAnimations for "Animations".

  • platform/Logging.h: Add LogAnimations.
  • platform/mac/LoggingMac.mm:

(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.

  • platform/win/LoggingWin.cpp:

(WebCore::initializeLoggingChannelsIfNecessary): Copy preference.

5:32 PM Changeset in webkit [148070] by dw.im@samsung.com
  • 18 edits
    9 adds in trunk

[CSS3] Parsing the property, text-justify.
https://bugs.webkit.org/show_bug.cgi?id=100058

Reviewed by Andreas Kling.

This patch implements the parsing side of the "text-justify" property specified
in CSS3 working draft, with "-webkit-" prefix, under ENABLE_CSS3_TEXT flag.
Specification link : http://www.w3.org/TR/css3-text/#text-justify

Source/WebCore:

Tests: fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html

fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextJustify):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):

  • css/StylePropertySet.cpp:

(WebCore):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData):

LayoutTests:

  • fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-expected.txt: Added.
  • fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited-expected.txt: Added.
  • fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify-inherited.html: Added.
  • fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html: Added.
  • fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify-inherited.js: Added.

(testComputedStyle):
(ownValueTest):
(inheritanceTest):

  • fast/css3-text/css3-text-justify/getComputedStyle/script-tests/getComputedStyle-text-justify.js: Added.

(testElementStyle):
(testComputedStyle):
(valueSettingTest):
(invalidValueSettingTest):

  • platform/mac/TestExpectations: ditto
  • platform/qt-4.8/TestExpectations: ditto
  • platform/qt-mac/TestExpectations: ditto
  • platform/qt/TestExpectations: ditto
5:17 PM Changeset in webkit [148069] by joone.hur@intel.com
  • 3 edits in trunk/Source/WebCore

[GTK][AC] Adding contentsLayer for image and video
https://bugs.webkit.org/show_bug.cgi?id=113912

Reviewed by Gustavo Noronha Silva.

contentsLayer is a ClutterActor, which is added to the main layer
as a child when GraphicsLayer needs to render an image or video.

No new tests, already covered by existing AC tests.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorUpdateTexture):

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
(WebCore):
(WebCore::GraphicsLayerClutter::setContentsToImage): Pass a Cairo surface to GraphicsLayer.
(WebCore::GraphicsLayerClutter::setContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::setContentsRect):
(WebCore::GraphicsLayerClutter::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerClutter::setupContentsLayer):
(WebCore::GraphicsLayerClutter::updateContentsImage): Set the Cairo surface for contentsLayer
to upload it as a texture.
(WebCore::GraphicsLayerClutter::updateContentsNeedsDisplay):
(WebCore::GraphicsLayerClutter::updateContentsRect):
(WebCore::GraphicsLayerClutter::updateSublayerList):

  • platform/graphics/clutter/GraphicsLayerClutter.h:

(WebCore::GraphicsLayerClutter::hasContentsLayer):
(GraphicsLayerClutter):
(WebCore::GraphicsLayerClutter::contentsLayer):

5:04 PM Changeset in webkit [148068] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION: Blob URLs broken with NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=114320

Reviewed by Brady Eidson.

Update BlobResourceHandle to use modern resource client calls.

  • platform/network/BlobResourceHandle.cpp: (WebCore::BlobResourceHandle::readSync): Don't call notifyReceiveData if there is no data (it's especially egregious when length is -1, signaling an error). (WebCore::BlobResourceHandle::notifyResponseOnSuccess): Use didReceiveResponseAsync when a client wants async callbacks. This is not very clean, as we don't wait for response, but should be workable for blobs. (WebCore::BlobResourceHandle::notifyResponseOnError): Ditto. (WebCore::BlobResourceHandle::notifyReceiveData): Use didReceiveBuffer (clients that only implement didReceiveData will have it automatically unwrapped).
5:03 PM Changeset in webkit [148067] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Rollout last patch as it destroyed everything

5:00 PM Changeset in webkit [148066] by simon.fraser@apple.com
  • 2 edits in trunk/LayoutTests

r148048 revealed that compositing/plugins/invalidate_rect.html was
only succeeded through chance, and cannot work as designed because
plugin painting is async on some platforms. Mark it as flakey.

  • platform/mac/TestExpectations:
4:57 PM Changeset in webkit [148065] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r123837): Full screen transition is broken at apple.com
https://bugs.webkit.org/show_bug.cgi?id=95650

Reviewed by Simon Fraser.

Cancel any outstanding animations on <video> elements as they enter full screen, so as to
not confuse the WebKit/WebKit2 full screen window animation about the starting and destination
screen rects.

  • css/fullscreen.css:

(video:-webkit-full-screen, audio:-webkit-full-screen):

4:52 PM Changeset in webkit [148064] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

hang in mediaSelectionGroupForMediaCharacteristic
https://bugs.webkit.org/show_bug.cgi?id=114054

Reviewed by Eric Carlson.

No new tests; Fixes sporadic hangs in media/ tests.

-[AVURLAsset mediaSelectionGroupForMediaCharacteristic:] can deadlock in certain situations: When AVURLAsset
posts a synchronous AVAssetResourceLoader notification to the main thread, calling -mediaSelectionGroupForMediaCharacteristic:
on the main thread requires IO to occur if the media characteristics are not yet loaded. Instead of blocking,
bail out early if the media characteristics are not yet known.

Add a new method, safeMediaSelectionGroupForLegibleMedia(), which first checks selection group availability
before calling mediaSelectionGroupForMediaCharacteristic:.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(MediaPlayerPrivateAVFoundationObjC):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::safeMediaSelectionGroupForLegibleMedia): Added.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Use new safe method.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processTextTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.

4:29 PM Changeset in webkit [148063] by cfleizach@apple.com
  • 3 edits in trunk/Source/WebCore

AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Unreviewed build fix for iOS.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityPath]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
4:28 PM Changeset in webkit [148062] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add liveness tests to JSC API entry points
https://bugs.webkit.org/show_bug.cgi?id=114318

Reviewed by Filip Pizlo.

Add simple checks for the existence of a method table on any
JSCells passed across the API. This in turn forces a structure
validity test.

  • API/APICast.h:

(toJS):
(toJSForGC):

4:22 PM Changeset in webkit [148061] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed correctness fix: use lroundf instead of lround for a float to int conversion.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

4:04 PM Changeset in webkit [148060] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Change requisite hardware checks for enabling antialiasing.
https://bugs.webkit.org/show_bug.cgi?id=114101
<rdar://problem/12342776>.

m_maySupportMultisampling should be true by default for all platforms/hardware now except older versions of AMD.

Reviewed by Dean Jackson.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):

3:55 PM Changeset in webkit [148059] by rniwa@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r148010.
http://trac.webkit.org/changeset/148010
https://bugs.webkit.org/show_bug.cgi?id=114310

Causes problems with focus rings (Requested by anttik on
#webkit).

Source/WebCore:

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyComputeLength::createHandler):
(WebCore::StyleBuilder::StyleBuilder):

LayoutTests:

  • fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Removed.
  • fast/borders/border-width-less-then-a-unit-of-pt.html: Removed.
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
3:52 PM Changeset in webkit [148058] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, another fix for the Windows build after r148050.

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::setFontSize): Use lround().

3:37 PM Changeset in webkit [148057] by simon.fraser@apple.com
  • 4 edits in trunk/LayoutTests

Rebaseline tests affected by r148049 or r148048.

  • compositing/layer-creation/rotate3d-overlap-expected.txt:
  • compositing/repaint/resize-repaint-expected.txt:
  • compositing/repaint/resize-repaint.html: Allow the test to run

outside WTR/DRT.

3:31 PM Changeset in webkit [148056] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Exclusions] Properly position multiple stacked floats with non rectangular shape outside
https://bugs.webkit.org/show_bug.cgi?id=110372

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-04-09
Reviewed by Dean Jackson.

Source/WebCore:

Stacked floats get positioned based on the bounding box of the shape,
not on the shape contours itself. This patch causes that to happen.

Test: fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeLogicalLocationForFloat): Use the

"BoundingBoxOffset" mode so that we compute offsets based on the shape
bounding boxes of previous floats, not the shape contour.

(WebCore::RenderBlock::logicalLeftOffsetForLine): Check the

ShapeOutsideFloatOffsetMode to determine if the offset should be
adjusted for the shape contour or not.

(WebCore::RenderBlock::logicalRightOffsetForLine): Ditto.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine): Add parameter for offset mode.
(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(RenderBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): If the

new float is being added on top of a previous float on the same line,
undo the offset for the previous float's shape contour so that we
position the new float based on the bounding box.

LayoutTests:

Tests demonstrating stacked floats properly working with shape-outside.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-stacked-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-stacked.html: Added.
3:02 PM Changeset in webkit [148055] by rniwa@webkit.org
  • 2 edits in trunk/Tools

newcommitbot (WKR) requires a subversion checkout
https://bugs.webkit.org/show_bug.cgi?id=114309

Reviewed by Benjamin Poulain.

Directly talk to the subversion server instead of relying on a local checkout.
This allows us to run WKR off of a git clone.

  • Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot.next_work_item):
(NewCommitBot.process_work_item):

2:35 PM Changeset in webkit [148054] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r147454): Youtube annotation links to new window broken
https://bugs.webkit.org/show_bug.cgi?id=114242
<rdar://problem/13609940>

Reviewed by Beth Dakin.

Set the current user gesture to "DefinitelyProcessingNewUserGesture" if popups are allowed.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performFrameLoadURLRequest):

2:30 PM Changeset in webkit [148053] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the Windows build after r148050.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Use lround().

2:28 PM Changeset in webkit [148052] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>

Reviewed by Simon Fraser.

Move an ASSERT that dereferenced a pointer inside the null-check for that pointer.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::setIconBitmapForIconURL):

2:25 PM Changeset in webkit [148051] by rniwa@webkit.org
  • 4 edits in trunk/Tools

webkitbot refers to sheriffbot in help
https://bugs.webkit.org/show_bug.cgi?id=114307

Reviewed by Benjamin Poulain.

Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Help):
(Help.execute):
(RollChromiumDEPS.execute):

  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_help):

  • Scripts/webkitpy/tool/bot/sheriff.py:

(Sheriff.name):

1:56 PM Changeset in webkit [148050] by eric.carlson@apple.com
  • 24 edits
    2 adds in trunk

[Mac] user caption styles not applied to correct element
https://bugs.webkit.org/show_bug.cgi?id=114230

Reviewed by Jer Noble.

Source/WebCore:

Test: media/track/track-css-user-override.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Drive by clean-up so we don't log excessively.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::MediaControlTextTrackContainerElement): Initialize

new member variables.

(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Set cue font size when it is

inserted into the tree.

(WebCore::MediaControlTextTrackContainerElement::updateTimerFired): Update the font size of

all active cues.

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Set size-relative CSS properties

after a time because this can be called during layout.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::textTrackPreferencesChanged): Call closedCaptionTracksChanged before updateSizes.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setFontSize): New, set the cue's font size.

  • html/track/TextTrackCue.h:
  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set cue properties on the cue element

instead of on the cue box to match what we do for the "cue" pseudo element.

(WebCore::TextTrackCueGeneric::setFontSize): New, set the cue's font size.

  • html/track/TextTrackCueGeneric.h:
  • html/track/TextTrackList.cpp:

(TextTrackList::remove): Drive-by cleanup, don't ASSERT when the media element is NULL.

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride): New, allow user CSS overrides

to be tested in DRT.

(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride): New, generate a user style

sheet override. Moved here from CaptionUserPreferencesMac.

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Don't ignore background color importance.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Implement even when we don't

have the media accessibility framework so this can be tested in DRT. Apply all cue properties
to the element used for the "cue" pseudo element.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::didLoadingProgress): Drive-by cleanup, remove logging

because this method is called so frequently and the logging is not especially useful.

(WebCore::MediaPlayerPrivateAVFoundation::updateStates): Only log when the ready/network

state changes because this method is called so frequently.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformLayer): Drive-by cleanup, remove logging

because this method is called so frequently and the logging is not especially useful.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Make the logging more useful.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset captions style sheet override.
(WebCore::Internals::captionsStyleSheetOverride): New, return the captions style sheet override.
(WebCore::Internals::setCaptionsStyleSheetOverride): New, override the captions style sheet override.

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/track/track-css-user-override-expected.txt: Added.
  • media/track/track-css-user-override.html: Added.
  • media/track/track-cue-container-rendering-position-expected.txt:
  • media/track/track-cue-container-rendering-position.html:
  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering.html: Font size is not applied instantly when a video element is

resized, so check after a very short delay.

1:52 PM Changeset in webkit [148049] by simon.fraser@apple.com
  • 66 edits
    2 adds in trunk

Repaint rect too small on elements with shadows
https://bugs.webkit.org/show_bug.cgi?id=114225

Source/WebCore:

Reviewed by Dain Adler.

We assumed that shadows (box-shadow, text-shadow, svg shadows)
only required inflating the repaint rect by the blur radius of
the shadow. However, this is incorrect; the shadow can extend
further, which resulted in clipped or incorrectly invalidated
shadows.

Fix by disambiguating the blur radius (which is 2x the standard
deviation of the Gaussian distribution used to generate the blur),
from the painting extent, which is how far the shadow visually
projects. Using a 1.4 multiplier of the blur radius is a good
approximation for the painting extent.

Renamed ShadowData::blur() to ShadowData::radius(), and added
ShadowData::paintingExtent(). Use the latter in all places
which relate to invalidation.

Test: fast/box-shadow/shadow-repaint.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::valueForShadow):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontAttributesForSelectionStart):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::applyBoxShadowForBackground):
(WebCore::areaCastingShadowInHole):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::operator==):
(WebCore::calculateShadowExtent):

  • rendering/style/ShadowData.h:

(WebCore::ShadowData::ShadowData):
(WebCore::ShadowData::radius):
(WebCore::ShadowData::paintingExtent):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

LayoutTests:

Reviewed by Darin Alder.

New test for invalidation with box-shadow. Update test results affected
by shadow extent.

  • compositing/geometry/foreground-layer-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • fast/box-shadow/shadow-repaint-expected.txt: Added.
  • fast/box-shadow/shadow-repaint.html: Added.
  • platform/mac/fast/multicol/shadow-breaking-expected.png:
  • platform/mac/fast/multicol/shadow-breaking-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-container-expected.txt:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/mac/fast/repaint/moving-shadow-on-path-expected.txt:
  • platform/mac/svg/css/arrow-with-shadow-expected.png:
  • platform/mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/mac/svg/css/clippath-with-shadow-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.png:
  • platform/mac/svg/css/composite-shadow-example-expected.txt:
  • platform/mac/svg/css/composite-shadow-text-expected.txt:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.png:
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
  • platform/mac/svg/css/group-with-shadow-expected.png:
  • platform/mac/svg/css/group-with-shadow-expected.txt:
  • platform/mac/svg/css/mask-with-shadow-expected.png:
  • platform/mac/svg/css/path-with-shadow-expected.png:
  • platform/mac/svg/css/path-with-shadow-expected.txt:
  • platform/mac/svg/css/shadow-and-opacity-expected.png:
  • platform/mac/svg/css/shadow-and-opacity-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.png:
  • platform/mac/svg/css/shadow-changes-expected.txt:
  • platform/mac/svg/css/shadow-with-large-radius-expected.png:
  • platform/mac/svg/css/shadow-with-negative-offset-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.png:
  • platform/mac/svg/css/stars-with-shadow-expected.txt:
  • platform/mac/svg/css/text-gradient-shadow-expected.png:
  • platform/mac/svg/css/text-gradient-shadow-expected.txt:
  • platform/mac/svg/css/text-shadow-multiple-expected.png:
  • platform/mac/svg/custom/repaint-shadow-expected.png:
  • platform/mac/svg/custom/transform-with-shadow-and-gradient-expected.txt:
  • svg/css/arrow-with-shadow-expected.txt:
  • svg/css/circle-in-mask-with-shadow-expected.txt:
  • svg/css/clippath-with-shadow-expected.txt:
  • svg/css/mask-with-shadow-expected.txt:
  • svg/css/shadow-with-large-radius-expected.txt:
  • svg/css/shadow-with-negative-offset-expected.txt:
  • svg/css/text-shadow-multiple-expected.txt:
  • svg/custom/repaint-shadow-expected.txt:
  • svg/filters/shadow-on-rect-with-filter-expected.txt:
  • svg/repaint/repaint-webkit-svg-shadow-container-expected.txt:
1:52 PM Changeset in webkit [148048] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

window.internals.repaintRectsAsText() is hard to use because it doesn't force layout
https://bugs.webkit.org/show_bug.cgi?id=114219

Reviewed by Beth Dakin.

Force layout when setTracksRepaints() is set to true, to flush out any pending
repaints from a layout that hasn't happened yet. Also force layout in
trackedRepaintRectsAsText(), so that any pending layout happpens and thus
repaints.

  • page/FrameView.cpp:

(WebCore::FrameView::setTracksRepaints):
(WebCore::FrameView::trackedRepaintRectsAsText):

1:48 PM Changeset in webkit [148047] by fpizlo@apple.com
  • 10 edits
    2 adds in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should provide utilities for common OSR exit tasks
https://bugs.webkit.org/show_bug.cgi?id=114306

Reviewed by Mark Hahnenberg.

Just abstract out some things that the FTL will want to use as well.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompiler.h:

(OSRExitCompiler):

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompilerCommon.cpp: Added.

(DFG):
(JSC::DFG::handleExitCounts):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

  • dfg/DFGOSRExitCompilerCommon.h: Added.

(DFG):

1:47 PM Changeset in webkit [148046] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Kill old processes between runs on WinEWS bots.
Temporarily disable tests to let bots catch up again.

  • EWSTools/start-queue-win.sh:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

1:42 PM Changeset in webkit [148045] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

LLInt conditional branch compilation fault on MIPS.
https://bugs.webkit.org/show_bug.cgi?id=114264

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-04-09
Reviewed by Filip Pizlo.

Fix conditional branch compilation in LLInt offlineasm.

  • offlineasm/mips.rb:
1:35 PM Changeset in webkit [148044] by cfleizach@apple.com
  • 2 edits in trunk/Source/WebCore

AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Unreviewed build fix (again).

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):

1:35 PM Changeset in webkit [148043] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

If we fail to decode a message name, pass the message length as the name
https://bugs.webkit.org/show_bug.cgi?id=114305
<rdar://problem/13605703>

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::length):

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

1:18 PM Changeset in webkit [148042] by cfleizach@apple.com
  • 2 edits in trunk/Source/WebCore

AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Unreviewed build fix.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(WebTransformCGPathToNSBezierPath):

1:06 PM Changeset in webkit [148041] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Main page is rendered at wrong large scale after back from any zooming article at read.thestar.com
https://bugs.webkit.org/show_bug.cgi?id=114296

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 308655
We were relying on the load state Committed to reset m_userPerformedManualZoom
and m_userPerformedManualScroll; however, the main resources of the
articles on read.thestar.com were preloaded and the WebPage didn't get
any load state change callbacks when going back to the main page from
the articles. Therefore, m_userPerformedManualZoom had never been reset
in this case and we picked up the wrong scale when restoring the main page.
Rset m_userPerformedManualScroll and m_userPerformedManualScroll when
we are going back or forward.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::goBackOrForward):

12:56 PM Changeset in webkit [148040] by benjamin@webkit.org
  • 2 edits in trunk/LayoutTests

Mark mouse-events-scaled-iframe.html as flaky

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09

  • platform/mac-wk2/TestExpectations:
12:55 PM Changeset in webkit [148039] by cfleizach@apple.com
  • 2 edits in trunk/Source/WebCore

AX: Bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Reviewed by Tim Horton.

Minor fix from review feedback.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):

12:48 PM Changeset in webkit [148038] by dino@apple.com
  • 7 edits in trunk/Source/WebKit2

Don't create another plugin process for restarted plugins
https://bugs.webkit.org/show_bug.cgi?id=114233

Reviewed by Geoff Garen.

A snapshotting plugin starts in a separate process from
regular plugins. This can be a little confusing to users
because they might see two plugin processes. We can set
the minimum life and timeout on the snapshotting process
to much smaller values, since the process doesn't need
to live that long. This will reduce some potential
confusion. Also, since there is another plugin process
running real plugins, it should be paged in if it needs
to restart.

There was, however, a bug in the process management. A
restarted plugin received a special PluginProcess::Type,
so that it could cross fade into the page nicely. This
caused it to start a *third* plugin process. Instead
mark a restarted flag directly on the PluginProxy and
revert back to two process types.

  • PluginProcess/PluginProcess.h: Remove TypeRestartedProcess.
  • UIProcess/Plugins/PluginProcessProxy.cpp: Add two new

timeout values for snapshotting processes.

(WebKit::PluginProcessProxy::didFinishLaunching): Chose which

of the timeout pairs to use.

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer): Don't look at the process type, instead

look at the process flag to see if we are restarted.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::create): Copy the new flag into constructor.
(WebKit::PluginProxy::PluginProxy): Remember the flag.

  • WebProcess/Plugins/PluginProxy.h: Add a new m_restartedProcess flag.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin): When we are creating the proxy, separate

the concept of snapshotting and restarting.

12:18 PM Changeset in webkit [148037] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should better abstract floating point arguments
https://bugs.webkit.org/show_bug.cgi?id=114300

Reviewed by Mark Hahnenberg.

  • dfg/DFGFPRInfo.h:

(FPRInfo):
(JSC::DFG::FPRInfo::toArgumentRegister):

12:16 PM Changeset in webkit [148036] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSObject::getOwnNonIndexPropertyNames calculates numCacheableSlots incorrectly
https://bugs.webkit.org/show_bug.cgi?id=114235

Reviewed by Geoffrey Garen.

Due to the way that numCacheableSlots is currently calculated, checking an object's prototype for enumerable
properties causes us not to cache any properties at all. We should only cache properties on the object itself
since we currently don't take advantage of any sort of name caching for properties in the prototype chain.
This fix undoes a ~2% SunSpider regression caused by http://trac.webkit.org/changeset/147570.

  • runtime/JSObject.cpp:

(JSC::JSObject::getOwnNonIndexPropertyNames):

12:10 PM Changeset in webkit [148035] by glenn@skynav.com
  • 4 edits in trunk/Tools

[webkitpy] Remove chromium deprecated port support.
https://bugs.webkit.org/show_bug.cgi?id=114228

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
(ChromiumPort): Removed.
(ChromiumAndroidPort): Removed.
(ChromiumXVFBPort): Removed.

  • Scripts/webkitpy/common/config/ports_unittest.py:

(DeprecatedPortTest.test_chromium_port): Removed.
(DeprecatedPortTest.test_chromium_android_port): Removed.
(DeprecatedPortTest.test_chromium_xvfb_port): Removed.

  • Scripts/webkitpy/tool/steps/update_unittest.py:

(UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
(UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.

12:09 PM FeatureFlags edited by benjamin@webkit.org
HTML Notifications were finally removed. (diff)
12:04 PM Changeset in webkit [148034] by timothy_horton@apple.com
  • 12 edits in trunk/Source

[wk2] IconDatabase images should be decoded in the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=112524
<rdar://problem/10133914>

Reviewed by Oliver Hunt.

In the interests of keeping decoding of data coming in from the greater Internet
in the WebProcess, move decoding of favicons from the UIProcess to the WebProcess.

  • UIProcess/WebIconDatabase.cpp:

(WebKit::WebIconDatabase::setIconBitmapForIconURL):
Receive a ShareableBitmap handle from the WebProcess instead of a DataReference.
Use the new setIconBitmapForIconURL IconDatabase method.

  • UIProcess/WebIconDatabase.h:

(WebIconDatabase):
Rename setIconDataForIconURL to setIconBitmapForIconURL.

  • UIProcess/WebIconDatabase.messages.in: Ditto.
  • WebProcess/IconDatabase/WebIconDatabaseProxy.cpp:

(WebKit::WebIconDatabaseProxy::setIconDataForIconURL):
In the WebProcess, decode the incoming icon and draw it into a ShareableBitmap.

No testable behavior change.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::updateIconRecord):
Added updateIconRecord, which factors most of setIconDataForIconURL out so it can
be shared with setIconBitmapForIconURL. This function will set either a bitmap or
raw image data for the given icon URL.

(WebCore::IconDatabase::setIconBitmapForIconURL):
Added; make a copy of the bitmap for thread-safety purposes, and call updateIconRecord.

(WebCore::IconDatabase::setIconDataForIconURL):
Factored out of what is now updateIconRecord.

  • loader/icon/IconDatabase.h:

(IconDatabase): Add setIconBitmapForIconURL and updateIconRecord.

  • loader/icon/IconDatabaseBase.h:

(WebCore::IconDatabaseBase::setIconBitmapForIconURL): Added.

  • loader/icon/IconRecord.cpp:

(WebCore::IconRecord::setImage): Set the image for an icon record directly (as opposed
to setting the image data, which causes the image to be decoded in the WebProcess).

  • loader/icon/IconRecord.h:

(IconRecord): Add setImage.

11:53 AM Changeset in webkit [148033] by cfleizach@apple.com
  • 22 edits
    4 adds in trunk

AX: The bounding paths should be made available through accessibility
https://bugs.webkit.org/show_bug.cgi?id=113817

Reviewed by David Kilzer.

Source/WebCore:

This allows bounding paths to be returned for some web elements (image map areas and SVG shapes).
This provides more accuracy when assistive technologies highlight elements.
The Mac and iOS platforms share some code to help transform paths to their screen coordinates.

Tests: platform/iphone-simulator/accessibility/element-paths.html

platform/mac/accessibility/element-paths.html

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):
(WebCore):
(WebCore::AccessibilityImageMapLink::elementPath):
(WebCore::AccessibilityImageMapLink::elementRect):

  • accessibility/AccessibilityImageMapLink.h:

(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::supportsPath):

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::elementPath):
(WebCore::AccessibilityObject::supportsPath):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::supportsPath):
(WebCore::AccessibilityRenderObject::elementPath):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityPath]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):
(-[WebAccessibilityObjectWrapper accessibilityActivationPoint]):
(-[WebAccessibilityObjectWrapper accessibilityFrame]):
(-[WebAccessibilityObjectWrapper frameForTextMarkers:]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:

(WebCore):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(PathConversionInfo):
(ConvertPathToScreenSpaceFunction):
(-[WebAccessibilityObjectWrapperBase convertPathToScreenSpace:]):
(-[WebAccessibilityObjectWrapperBase convertPointToScreenSpace:]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(WebTransformCGPathToNSBezierPath):
(-[WebAccessibilityObjectWrapper bezierPathFromPath:]):
(-[WebAccessibilityObjectWrapper path]):
(-[WebAccessibilityObjectWrapper position]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

Tools:

Add a pathDescription property for testing so that it's possible
to verify that a path is being returned correctly.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(getPathDescriptionCallback):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(_CGPathEnumerationIteration):
(AccessibilityUIElement::pathDescription):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::pathDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::pathDescription):
(WTR):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::pathDescription):
(WTR):

LayoutTests:

Add new tests for Mac and iOS to verify that path output works.
Modify existing tests to indicate that there is a new AXAttribute, AXPath.

  • platform/iphone-simulator/accessibility/element-paths-expected.txt: Added.
  • platform/iphone-simulator/accessibility/element-paths.html: Added.
  • platform/mac/accessibility/document-links-expected.txt:
  • platform/mac/accessibility/element-paths-expected.txt: Added.
  • platform/mac/accessibility/element-paths.html: Added.
  • platform/mac/accessibility/image-map2-expected.txt:
11:04 AM Changeset in webkit [148032] by benjamin@webkit.org
  • 2 edits
    2 deletes in trunk/Source

Remove the WebKit copy of GLU and the file using it
https://bugs.webkit.org/show_bug.cgi?id=114249

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-09
Reviewed by Darin Adler.

Source/ThirdParty:

  • glu/.gitignore: Removed.
  • glu/LICENSE.txt: Removed.
  • glu/README.webkit: Removed.
  • glu/glu.gyp: Removed.
  • glu/gluos.h: Removed.
  • glu/internal_glu.h: Removed.
  • glu/libtess/GNUmakefile: Removed.
  • glu/libtess/Imakefile: Removed.
  • glu/libtess/README: Removed.
  • glu/libtess/alg-outline: Removed.
  • glu/libtess/dict-list.h: Removed.
  • glu/libtess/dict.c: Removed.
  • glu/libtess/dict.h: Removed.
  • glu/libtess/geom.c: Removed.
  • glu/libtess/geom.h: Removed.
  • glu/libtess/memalloc.c: Removed.
  • glu/libtess/memalloc.h: Removed.
  • glu/libtess/mesh.c: Removed.
  • glu/libtess/mesh.h: Removed.
  • glu/libtess/normal.c: Removed.
  • glu/libtess/normal.h: Removed.
  • glu/libtess/priorityq-heap.c: Removed.
  • glu/libtess/priorityq-heap.h: Removed.
  • glu/libtess/priorityq-sort.h: Removed.
  • glu/libtess/priorityq.c: Removed.
  • glu/libtess/priorityq.h: Removed.
  • glu/libtess/render.c: Removed.
  • glu/libtess/render.h: Removed.
  • glu/libtess/sweep.c: Removed.
  • glu/libtess/sweep.h: Removed.
  • glu/libtess/tess.c: Removed.
  • glu/libtess/tess.h: Removed.
  • glu/libtess/tessmono.c: Removed.
  • glu/libtess/tessmono.h: Removed.

Source/WebCore:

  • platform/graphics/gpu/LoopBlinnPathProcessor.cpp: Removed.
10:45 AM Changeset in webkit [148031] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Throttle resize events during live window resize.
<http://webkit.org/b/114292>
<rdar://problem/13411454>

Reviewed by Geoffrey Garen.

Limit resize events to one at max every 0.2 seconds during live window resize.
This mitigates heavy CPU usage during resize on pages with complex onresize handlers.
If there's a pending resize event when the live resize ends, it fires immediately.

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEvent):

Factored out dispatch of the resize event after layout so we can call it on a timer
instead of immediately while live window resize is active.

(WebCore::FrameView::FrameView):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::delayedResizeEventTimerFired):
(WebCore::FrameView::willEndLiveResize):
(WebCore::FrameView::scheduleResizeEvent):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

Made willStartLiveResize() and willEndLiveResize() virtual so we can override
them on FrameView.

10:31 AM FeatureFlags edited by zoltan@webkit.org
(diff)
10:05 AM Changeset in webkit [148030] by Lucas Forschler
  • 4 edits in branches/safari-536.29-branch/Source

Versioning.

10:04 AM FeatureFlags edited by Bem Jones-Bey
Add info on the CSS Exclusions flag (diff)
10:03 AM Changeset in webkit [148029] by Lucas Forschler
  • 1 copy in tags/Safari-536.29.13

New Tag.

9:52 AM Changeset in webkit [148028] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add webp to supported image mime types if WEBP feature is enabled/used
https://bugs.webkit.org/show_bug.cgi?id=112819

Patch by Jeff Rogers <jrogers@rim.com> on 2013-04-09
Reviewed by Darin Adler.

Add WebP to list of supported image types in MIMETypeRegistry if enabled.

No new tests: WebP image decoding already covered by exisiting tests.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):

9:46 AM Changeset in webkit [148027] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

Whitespace in particular source code changes rendering; does not in Firefox
https://bugs.webkit.org/show_bug.cgi?id=100943

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-04-09
Reviewed by Darin Adler.

Source/WebCore:

A render inline which requires a line box is considered a possible
trailing object. So, ensureLineBoxInsideIgnoredSpaces will be called
for it, even if it is placed after a text render ending with a single
space.

Tests: fast/text/whitespace/trailing-space-before-empty-span-1.html

fast/text/whitespace/trailing-space-before-empty-span-2.html

  • rendering/RenderBlockLineLayout.cpp:

(TrailingObjects):
(WebCore::TrailingObjects::appendBoxIfNeeded):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/text/whitespace/trailing-space-before-empty-span-1-expected.html: Added.
  • fast/text/whitespace/trailing-space-before-empty-span-1.html: A test

with a span whose text ends with a single span. A following span
is empty but requires a line box (because it has some padding).
The second span should be rendered.

  • fast/text/whitespace/trailing-space-before-empty-span-2-expected.html: Added.
  • fast/text/whitespace/trailing-space-before-empty-span-2.html: Same

test as trailing-space-before-empty-span-1.html except that second
span contains whitespace only text.

9:39 AM Keeping the Tree Green edited by thiago.santos@intel.com
(diff)
9:22 AM FeatureFlags edited by mvujovic@adobe.com
Add info about CSS_SHADERS. (diff)
8:27 AM Changeset in webkit [148026] by abucur@adobe.com
  • 13 edits in trunk

Use DOM ordering for list counts
https://bugs.webkit.org/show_bug.cgi?id=110352

Reviewed by Elliott Sprehn.

Source/WebCore:

Currently the list items ordering is made by traversing the render tree. This gives bad results for:

  • list items flown inside regions because they are not rendered as descendants of their DOM list ancestors.
  • list items matched to insertion points inside a shadow tree. The insertion point may be a child of a

list so the numbering gets broken.

To implement correct DOM ordering I've taken into account the fact that pseudo-elements can have display: list-item
so they should be included when traversing the DOM tree. I've added helper methods on the NodeTraversal
namespace that should allow easily traversing the tree including the pseudo-elements (e.g. firstChildWithPseudo
for an element with pseudo-before will return the before PseudoElement). Using these helper methods I've implemented
pre-order traversal methods aware of the pseudo-elements.
An effect of this change is how the list items inside shadow tree update their counting. With the patch, if there's
no <ol> or <ul> element on the ancestor chain of a <li> element to the shadow root, the list node will be considered the
first parent of the <li> or the shadow root if there is no ancestor.
The RenderListItem class now makes use of this new method of traversal, replacing the one based on the render tree.
To simplify the CSS counters implementation, I've changed the traversal functions inside RenderCounter to also make use
of this method. The CSS counters and the list items now have the same traversal algorithm.

In later patches I'll add tests that should cover the regions and shadow DOM use cases.
Tests bug for shadow DOM: https://bugs.webkit.org/show_bug.cgi?id=113193
Tests bug for regions: https://bugs.webkit.org/show_bug.cgi?id=103975

Tests: no new tests is this patch; added the correct expectations for fast/lists/positioned-count-crash.html
and fast/dom/shadow/shadow-and-list-elements.html

  • dom/Node.cpp:

(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::pseudoAwareFirstChild):
(WebCore::Node::pseudoAwareLastChild):

  • dom/Node.h:

(Node):

  • dom/NodeTraversal.cpp:

(WebCore):
(WebCore::NodeTraversal::previousIncludingPseudo):
(NodeTraversal):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):

  • dom/NodeTraversal.h:

(ElementTraversal):
(NodeTraversal):
(WebCore::ElementTraversal::previousIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudo):
(WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
(WebCore::ElementTraversal::pseudoAwarePreviousSibling):

  • html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::attach):

  • html/HTMLOListElement.cpp:

(WebCore::HTMLOListElement::updateItemValues):
(WebCore::HTMLOListElement::recalculateItemCount):

  • rendering/RenderCounter.cpp:

(WebCore::previousInPreOrder):
(WebCore::previousSiblingOrParent):
(WebCore::parentElement):
(WebCore::nextInPreOrder):

  • rendering/RenderListItem.cpp:

(WebCore):
(WebCore::enclosingList):
(WebCore::RenderListItem::nextListItem):
(WebCore::previousListItem):
(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::explicitValueChanged):
(WebCore::previousOrNextItem):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderListItem.h:

(RenderListItem):

LayoutTests:

The fast/dom/shadow/shadow-and-list-elements-expected.html has changed because the list items
inside the shadow tree no longer see the root <ol> element.
The test fast/lists/positioned-count-crash.html has the correct rendering after changing
the list counting to be in DOM order.

  • fast/dom/shadow/shadow-and-list-elements-expected.html:
  • fast/lists/positioned-count-crash-expected.txt:
7:50 AM Changeset in webkit [148025] by rakuco@webkit.org
  • 16 edits in trunk

[EFL] Declare TEST_THEME_DIR in a single place.
https://bugs.webkit.org/show_bug.cgi?id=114285

Reviewed by Anders Carlsson.

.:

Instead of adding the `THEME_DIR' preprocessor variable in many
different CMakeList.txt files in the tree, declare it in
OptionsEfl.cmake so that we avoid needlessly duplicating code around.

While here, rename it to `TEST_THEME_DIR', which is the name used our
WebKit2 infrastructure, to better reflect the purpose of this value.

  • Source/cmake/OptionsEfl.cmake: Add the TEST_THEME_DIR preprocessor

definition.

Source/WebKit2:

  • PlatformEfl.cmake: Remove definition of `TEST_THEME_DIR', which is

now defined in OptionsEfl.cmake.

Tools:

Adapt to the renaming of THEME_DIR' to TEST_THEME_DIR'.

  • DumpRenderTree/efl/CMakeLists.txt:
  • DumpRenderTree/efl/DumpRenderTreeChrome.cpp:

(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::createInspectorView):
(DumpRenderTreeChrome::initialize):
(DumpRenderTreeChrome::onDownloadRequest):

  • EWebLauncher/CMakeLists.txt:
  • EWebLauncher/main.c:

(findThemePath):

  • EWebLauncher/url_bar.c:

(url_bar_add):

  • MiniBrowser/efl/CMakeLists.txt:
  • MiniBrowser/efl/main.c:

(window_create):

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):

7:48 AM Changeset in webkit [148024] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler: fix calls to HTMLInputElement methods
https://bugs.webkit.org/show_bug.cgi?id=114283

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-09
Reviewed by Rob Buis.

Fix calls with wrong names.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertInputType):

7:35 AM Changeset in webkit [148023] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/efl

[EFL] --minimal build fails with error: setSeamlessIFramesEnabled' is not a member of WebCore::RuntimeEnabledFeatures'
https://bugs.webkit.org/show_bug.cgi?id=113951

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-09
Reviewed by Laszlo Gombos.

Wrapped code related to iframe seamless into #if ENABLE(IFRAME_SEAMLESS)

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled):

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

7:31 AM Changeset in webkit [148022] by rafael.lobo@openbossa.org
  • 5 edits
    3 adds in trunk

[CoordinatedGraphics] serviceScriptedAnimations expects time in seconds
https://bugs.webkit.org/show_bug.cgi?id=112582

Reviewed by Andreas Kling.

Source/WebKit/qt:

We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.

  • WebCoreSupport/ChromeClientQt.cpp: Remove unnecessary conversion.

Source/WebKit2:

We've been exposing different time unit for requestAnimationFrame because
of wrong conversion before serviceScriptedAnimations function calls.
Fixed it to use seconds instead of milliseconds.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::syncDisplayState): Remove unnecessary conversion.

LayoutTests:

Add test to measure if the time interval is coherent with the unit
of DOMTimeStamp (milliseconds) by comparing it with Date.now() interval.

  • fast/animation/request-animation-frame-time-unit-expected.txt: Added.
  • fast/animation/request-animation-frame-time-unit.html: Added.
  • fast/animation/script-tests/request-animation-frame-time-unit.js: Added.
7:14 AM Changeset in webkit [148021] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Remove obsolete QtWebPageFindClient forward declaration from qquickwebview_p.h.
https://bugs.webkit.org/show_bug.cgi?id=114284

Reviewed by Andreas Kling.

The class QtWebPageFindClient was removed in r142073 when the functionality
was folded into QQuickWebViewPrivate.

  • UIProcess/API/qt/qquickwebview_p.h:

(WebKit):

7:13 AM Changeset in webkit [148020] by Bruno de Oliveira Abinader
  • 3 edits in trunk/Source/WebCore

[Texmap] TextureMapperLayer refactor for readiblity
https://bugs.webkit.org/show_bug.cgi?id=114278

Reviewed by Noam Rosenthal.

Removes non-needed return values, function parameters and changes
boolean values with enums for readibility.

No behavioral changes, thus no tests.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::sortByZOrder):
(WebCore::TextureMapperLayer::computeOverlapRegions):
(WebCore::TextureMapperLayer::paintUsingOverlapRegions):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::paintRecursive):

  • platform/graphics/texmap/TextureMapperLayer.h:

(TextureMapperLayer):

6:45 AM Changeset in webkit [148019] by commit-queue@webkit.org
  • 8 edits in trunk

[WebSocket] Ignore incoming message in CLOSING state
https://bugs.webkit.org/show_bug.cgi?id=85934

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-09
Reviewed by Kent Tamura.

Source/WebCore:

Change WebSocket implementation to suit the new WebSocket API, which
states that we should ignore messages in CLOSING state.

No new tests, updating existing tests.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::didReceiveMessage):

LayoutTests:

  • http/tests/websocket/tests/hybi/client-close-expected.txt: Rebaseline.
  • http/tests/websocket/tests/hybi/client-close.html: Change expected results.
  • http/tests/websocket/tests/hybi/client-close_wsh.py: Embed message in close frame

instead of using regular message sending call.

  • http/tests/websocket/tests/hybi/fragmented-frames.html: Call WebSocket.close()

only after receiving all messages from server.

  • http/tests/websocket/tests/hybi/unmasked-frames.html: Remove extra

WebSocket.close() call that caused regression.

6:26 AM Changeset in webkit [148018] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][AC] upversion of clutter and its dependecy
https://bugs.webkit.org/show_bug.cgi?id=114016

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-09
Reviewed by Gustavo Noronha Silva.

Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.

.:

  • Source/autotools/Versions.m4:

Tools:

  • gtk/jhbuild-optional.modules:
6:13 AM Changeset in webkit [148017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add Localized strings after r144154 and r135127
https://bugs.webkit.org/show_bug.cgi?id=114269

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09
Reviewed by Timothy Hatcher.

No new tests, no behavior change.

  • English.lproj/localizedStrings.js:
5:55 AM Changeset in webkit [148016] by rakuco@webkit.org
  • 1 delete in trunk/LayoutTests/platform/efl-wk2/tables/mozilla_expected_failures

Remove empty directories

5:53 AM Changeset in webkit [148015] by rakuco@webkit.org
  • 4 edits
    2 deletes in trunk/LayoutTests

[EFL] Move tables/mozilla_expected_failures/bugs/bug89315.html's expectations to efl/.

There is no point in keeping the rebaselined results WK2-only. While
here, actually unskip the test and provide a more accurate pixel result
(the previous one was fine, but this one passes with --tolerance=0).

  • platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Removed.
  • platform/efl-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
5:13 AM Changeset in webkit [148014] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit2

Fix GTK WebKit2 build after r148005.
https://bugs.webkit.org/show_bug.cgi?id=114270

Reviewed by Andreas Kling.

Fix GTK build break that went through the buildbot undetected.

  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkit_file_chooser_request_get_selected_files):

5:11 AM Changeset in webkit [148013] by antti@apple.com
  • 4 edits in trunk/Source/WebCore

Throttle compositing layer flushes in subframes
https://bugs.webkit.org/show_bug.cgi?id=114267

Reviewed by Andreas Kling.

Throttle compositing layer flushes in all frames, not just the main one.

This especially reduces flushes/repaints generated by ads in iframes.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):

  • page/FrameView.h:
5:00 AM Changeset in webkit [148012] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] Gardening.

Now unskip a few compositing-related tests which are not failing
anymore.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:53 AM Changeset in webkit [148011] by michael.bruning@digia.com
  • 6 edits in trunk/Source/WebKit2

[Qt][WK2] Remove direct references to WebPageProxy from QQuickWebPage.
https://bugs.webkit.org/show_bug.cgi?id=112850

Reviewed by Andreas Kling.

Removes direct references to WebPageProxy from QQuickWebPage and prepares the
class for the move to QRawWebView. The access to the device scale factor and
CoordinatedGraphicsScene is provided through QQuickWebViewPrivate, and therefore
accessors to these properties are temporarily added. Eventually, this access will
be provided through QRawWebView when the move is complete.

This also moves the pointer to QtWebPageEventHandler from QQuickWebPagePrivate
to QQuickWebViewPrivate as it is mainly used from there.

  • UIProcess/API/qt/qquickwebpage.cpp:

(QQuickWebPagePrivate::QQuickWebPagePrivate):
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):

  • UIProcess/API/qt/qquickwebpage_p.h:
  • UIProcess/API/qt/qquickwebpage_p_p.h:

(QQuickWebPagePrivate):

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewPrivate::handleMouseEvent):
(QQuickWebViewPrivate::processDidCrash):
(QQuickWebViewPrivate::coordinatedGraphicsScene):
(QQuickWebViewPrivate::deviceScaleFactor):
(QQuickWebViewPrivate::setIntrinsicDeviceScaleFactor):
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebView::keyPressEvent):
(QQuickWebView::keyReleaseEvent):
(QQuickWebView::inputMethodEvent):
(QQuickWebView::focusInEvent):
(QQuickWebView::itemChange):
(QQuickWebView::touchEvent):
(QQuickWebView::wheelEvent):
(QQuickWebView::hoverEnterEvent):
(QQuickWebView::hoverMoveEvent):
(QQuickWebView::hoverLeaveEvent):
(QQuickWebView::dragMoveEvent):
(QQuickWebView::dragEnterEvent):
(QQuickWebView::dragLeaveEvent):
(QQuickWebView::dropEvent):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(WebCore):
(WebKit):
(QQuickWebViewPrivate):

4:51 AM Changeset in webkit [148010] by commit-queue@webkit.org
  • 9 edits
    2 adds in trunk

Table border doesn't show up
https://bugs.webkit.org/show_bug.cgi?id=13709

Patch by Suchit Agrawal <a.suchit@samsung.com> on 2013-04-09
Reviewed by Antti Koivisto.

Source/WebCore:

Border issue is fixed when border width is less than 0.8pt

Border width is stored as unsigned. Border width (specified by
author) is converted into pixels and some times this pixel value
goes less than 1px. In this case, border width becomes 0px when
pixel value (double type) assigned to unsigned type.
Border width should not fall to 0px unless it is specified by
author.

Test: fast/borders/border-width-less-then-a-unit-of-pt.html

  • css/StyleBuilder.cpp:

ApplyPropetyComputeLength class is replaced with 3 classes :
ApplyPropertyComputeBorderWidth, ApplyPropertyComputeTextSpacing
and ApplyPropertyComputeTransformOriginZ.

(WebCore::ApplyPropertyComputeBorderWidth::applyValue):
(WebCore::ApplyPropertyComputeBorderWidth::createHandler):
This class handles all width properties like border, outline,
etc. These all properties stores value in integer types.
Pixel value rounded of to 1px if value less than 1px and greater
than 0px.

(WebCore):
(ApplyPropertyComputeTextSpacing):
(WebCore::ApplyPropertyComputeTextSpacing::setValue):
(WebCore::ApplyPropertyComputeTextSpacing::applyValue):
(WebCore::ApplyPropertyComputeTextSpacing::createHandler):
This class handles all spacing properties like word-spacing,
letter-spacing etc.

(ApplyPropertyComputeTransformOriginZ):
(WebCore::ApplyPropertyComputeTransformOriginZ::setValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::applyValue):
(WebCore::ApplyPropertyComputeTransformOriginZ::createHandler):
This class handles TransformOriginZ Property.

(WebCore::StyleBuilder::StyleBuilder):
ApplyProprtyComputeLength class usage changed with defined new
classes as per class definition.

LayoutTests:

This test file have border width, outline offset, outline width, border
spacing and column rule width properties test cases.

  • fast/borders/border-width-less-then-a-unit-of-pt-expected.html: Added.
  • fast/borders/border-width-less-then-a-unit-of-pt.html: Added.

Test case table/mozilla_expected_failures/bug89315.html need to do rebaseline
in efl, gtk and mac.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:

Updated the test result for table/mozilla_expected_failures/bug89315.html
Border is expected for table in test table/mozilla_expected_failures/bug89315.html

  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
  • platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
4:50 AM Changeset in webkit [148009] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt] Unskip and update inspector tests
https://bugs.webkit.org/show_bug.cgi?id=114263

Unreviewed gardening.

Removed fast/events/autoscroll.html after r147830.
Unskip inspector/timeline/timeline-animation-frame.html that is now passing.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-09

  • platform/qt/TestExpectations:
4:48 AM Changeset in webkit [148008] by michael.bruning@digia.com
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Use C API to enable Navigator Qt Object.
https://bugs.webkit.org/show_bug.cgi?id=112810

Reviewed by Andreas Kling.

Replace the direct reference to the WebPageProxy with use of
C API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::setNavigatorQtObjectEnabled):

4:42 AM Changeset in webkit [148007] by rakuco@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] More gardening.

Unskip some tests which have stopped crashing after r147759,
147933 and others.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
4:34 AM Changeset in webkit [148006] by rakuco@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Gardening. Unskip some tests that have been passing for a while.

  • platform/efl/TestExpectations:
4:13 AM Changeset in webkit [148005] by michael.bruning@digia.com
  • 7 edits in trunk/Source/WebKit2

[WK2] Add C API to copy selected files from WebOpenPanelParameters.
https://bugs.webkit.org/show_bug.cgi?id=112339

Reviewed by Andreas Kling.

Replaces the existing WebOpenPanelParameters::selectedFileNames() method
to return a copy of the selected file names and exposes it through the
C API. This is done in order to reduce the direct use of WebKit2 internal
classes. The implementation is very similar to the one in
WebOpenPanelParameters::acceptMIMETypes().

This also updates the GTK port, which is the other user of selectedFileNames.

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::selectedFileNames):
(WebKit):

  • Shared/WebOpenPanelParameters.h:

(WebOpenPanelParameters):

  • UIProcess/API/C/WKOpenPanelParameters.cpp:

(WKOpenPanelParametersCopySelectedFileNames):

  • UIProcess/API/C/WKOpenPanelParameters.h:
  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkit_file_chooser_request_get_selected_files):

  • UIProcess/qt/QtWebPageUIClient.cpp:

(WebKit::QtWebPageUIClient::runOpenPanel):

4:01 AM Changeset in webkit [148004] by paroga@webkit.org
  • 2 edits in trunk/Source/WTF

[CMake] Remove conditional source file lists in WTF
https://bugs.webkit.org/show_bug.cgi?id=114250

Reviewed by Laszlo Gombos.

Use the #ifdef in the source file instead of conditional adding
files to the list of source files. This allows us to remove the
information of enabled features from CMake in next step.

  • wtf/CMakeLists.txt:
3:44 AM Changeset in webkit [148003] by loki@webkit.org
  • 2 edits in trunk/Source/WebCore

Initialization skipped error on WinCario after r147643
https://bugs.webkit.org/show_bug.cgi?id=114258

Reviewed by Csaba Osztrogonác.

Build fix. Adding extra block statement to avoid error C2362 on WinCario

  • platform/win/DragImageCairoWin.cpp:

(WebCore::createDragImageFromImage):

3:15 AM Changeset in webkit [148002] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Adding failure expectations for two a11y tests that regressed with r147719.
3:11 AM Changeset in webkit [148001] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r147995.
http://trac.webkit.org/changeset/147995
https://bugs.webkit.org/show_bug.cgi?id=114261

Wrong gardening. (Requested by gyuyoung on #webkit).

  • platform/efl/TestExpectations:
3:03 AM Changeset in webkit [148000] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[WK2] Remove build warnings for unused parameters
https://bugs.webkit.org/show_bug.cgi?id=114234

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-04-09
Reviewed by Andreas Kling.

Fix build warnings -Wunused-parameter.

Source/WebCore:

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::openInMemory):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::CreateIndexAbortOperation::perform):
(WebCore::DeleteIndexAbortOperation::perform):
(WebCore::CreateObjectStoreAbortOperation::perform):
(WebCore::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/IDBLevelDBCoding.cpp:

(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):

  • Modules/indexeddb/IDBLevelDBCoding.h:

(WebCore::IDBLevelDBCoding::encodeIntSafely):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::canSet):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

  • platform/leveldb/LevelDBDatabase.cpp:

(WebCore::ComparatorAdapter::FindShortestSeparator):
(WebCore::ComparatorAdapter::FindShortSuccessor):

Source/WebKit2:

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::SessionStorageNamespace::cloneTo):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::requestNetworkingStatistics):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::removeItem):
(WebKit::StorageAreaProxy::clear):
(WebKit::StorageAreaProxy::dispatchSessionStorageEvent):
(WebKit::StorageAreaProxy::dispatchLocalStorageEvent):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::didUninstallPageOverlay):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didFinishLoad):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):

2:24 AM Changeset in webkit [147999] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations: Marking a bunch of CSS layout tests as flaky timeouts,

most likely due to libsoup dependency bump.

2:07 AM Changeset in webkit [147998] by thiago.santos@intel.com
  • 17 edits
    21 adds in trunk

[WK2] Drop WebProcess capabilities on Linux using seccomp filters
https://bugs.webkit.org/show_bug.cgi?id=89875

Reviewed by Maciej Stachowiak.

.:

Added the bits to EFL/CMake buildsystem to find the libseccomp
library.

  • Source/cmake/FindLibSeccomp.cmake: Added.
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/WebCore:

Make the DATA_DIR global since it is now needed for WebCore and WebKit2.
It is now used to set a sandbox policy for the EFL port.

  • PlatformEfl.cmake:

Source/WebKit2:

Introduce the foundations of the SeccompFilter-based sandbox. The
hardening of the WebProcess (and potentially PluginProcess, etc)
works by a combination of the two things:

  • Blocking syscalls that are not used, reducing the size of the attack

surface.

  • Trapping sensitive syscalls and delegating the execution of these

syscalls to a separated trusted process subject to a set of policies.

The initial implementation traps the open()-family of syscalls on WebKit
EFL's and Qt's WebProcess, but it could be easily used by any Linux port,
since the code is suppose to be Linux-compliant. The list of syscalls handled
by the broker process should definitely grow as we mature the
implementation. Other syscalls needs to be handled to get this sandbox
fully functional, like unlink(), mkdir(), etc.

The broker process should be initialized as early as possible on the
sandboxed process main() function, because it only does a fork(), which
is cheap on Linux. That also aims to minimize the resident memory footprint
of the broker process.

Opening of files for upload and saving downloads is not supported yet,
since it should be handled to the UIProcess in a similar fashion as
the Mac port does.

  • PlatformEfl.cmake:
  • Shared/linux/SeccompFilters/OpenSyscall.cpp: Added.

(WebKit):
(WebKit::OpenSyscall::createFromOpenatContext):
(WebKit::OpenSyscall::createFromCreatContext):
(WebKit::OpenSyscall::OpenSyscall):
(WebKit::OpenSyscall::setResult):
(WebKit::OpenSyscall::execute):
(WebKit::OpenSyscall::encode):
(WebKit::OpenSyscall::decode):
(WebKit::OpenSyscallResult::OpenSyscallResult):
(WebKit::OpenSyscallResult::~OpenSyscallResult):
(WebKit::OpenSyscallResult::encode):
(WebKit::OpenSyscallResult::decode):

  • Shared/linux/SeccompFilters/OpenSyscall.h: Added.

(CoreIPC):
(WebKit):
(OpenSyscall):
(WebKit::OpenSyscall::setPath):
(WebKit::OpenSyscall::setFlags):
(WebKit::OpenSyscall::setMode):
(OpenSyscallResult):
(WebKit::OpenSyscallResult::fd):
(WebKit::OpenSyscallResult::errorNumber):

  • Shared/linux/SeccompFilters/SeccompBroker.cpp: Added.

(WebKit):
(SeccompBrokerClient):
(WebKit::sendMessage):
(WebKit::receiveMessage):
(WebKit::SIGSYSHandler):
(WebKit::registerSIGSYSHandler):
(WebKit::SeccompBrokerClient::shared):
(WebKit::SeccompBrokerClient::SeccompBrokerClient):
(WebKit::SeccompBrokerClient::~SeccompBrokerClient):
(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBrokerClient::handleIfOpeningOnlineCPUCount):
(WebKit::SeccompBroker::launchProcess):
(WebKit::SeccompBroker::initialize):
(WebKit::SeccompBroker::runLoop):

  • Shared/linux/SeccompFilters/SeccompBroker.h: Added.

(WebKit):
(SeccompBroker):
(WebKit::SeccompBroker::setSyscallPolicy):
(WebKit::SeccompBroker::SeccompBroker):

  • Shared/linux/SeccompFilters/SeccompFilters.cpp: Added.

(WebKit):
(WebKit::SeccompFilters::SeccompFilters):
(WebKit::SeccompFilters::~SeccompFilters):
(WebKit::SeccompFilters::addRule):
(WebKit::SeccompFilters::initialize):

  • Shared/linux/SeccompFilters/SeccompFilters.h: Added.

(WebKit):
(SeccompFilters):
(WebKit::SeccompFilters::context):
(WebKit::SeccompFilters::platformInitialize):

  • Shared/linux/SeccompFilters/SigactionSyscall.cpp: Added.

(WebKit):
(WebKit::SigactionSyscall::createFromContext):

  • Shared/linux/SeccompFilters/SigactionSyscall.h: Added.

(WebKit):
(SigactionSyscall):

  • Shared/linux/SeccompFilters/SigprocmaskSyscall.cpp: Added.

(WebKit):
(WebKit::SigprocmaskSyscall::createFromContext):

  • Shared/linux/SeccompFilters/SigprocmaskSyscall.h: Added.

(WebKit):
(SigprocmaskSyscall):

  • Shared/linux/SeccompFilters/Syscall.cpp: Added.

(WebKit):
(WebKit::Syscall::createFromContext):
(WebKit::Syscall::createFromDecoder):
(WebKit::Syscall::Syscall):
(WebKit::SyscallResult::createFromDecoder):
(WebKit::SyscallResult::SyscallResult):

  • Shared/linux/SeccompFilters/Syscall.h: Added.

(CoreIPC):
(WebKit):
(Syscall):
(WebKit::Syscall::~Syscall):
(WebKit::Syscall::type):
(WebKit::Syscall::setContext):
(WebKit::Syscall::context):
(SyscallResult):
(WebKit::SyscallResult::~SyscallResult):
(WebKit::SyscallResult::type):

  • Shared/linux/SeccompFilters/SyscallPolicy.cpp: Added.

(WebKit):
(WebKit::removeTrailingSlash):
(WebKit::SyscallPolicy::hasPermissionForPath):
(WebKit::SyscallPolicy::addFilePermission):
(WebKit::SyscallPolicy::addDirectoryPermission):
(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

  • Shared/linux/SeccompFilters/SyscallPolicy.h: Added.

(WebKit):
(SyscallPolicy):

  • Target.pri:
  • WebKit2.pri:
  • WebProcess/efl/SeccompFiltersWebProcessEfl.cpp: Added.

(WebKit):
(WebKit::SeccompFiltersWebProcessEfl::SeccompFiltersWebProcessEfl):
(WebKit::SeccompFiltersWebProcessEfl::platformInitialize):

  • WebProcess/efl/SeccompFiltersWebProcessEfl.h: Added.

(WebKit):
(SeccompFiltersWebProcessEfl):

  • WebProcess/qt/SeccompFiltersWebProcessQt.cpp: Added.

(WebKit):
(WebKit::SeccompFiltersWebProcessQt::SeccompFiltersWebProcessQt):
(WebKit::SeccompFiltersWebProcessQt::platformInitialize):

  • WebProcess/qt/SeccompFiltersWebProcessQt.h: Added.

(WebKit):
(SeccompFiltersWebProcessQt):

  • WebProcess/qt/WebProcessQt.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Add unit tests to verify if the handling of the open, openat, creat syscall
is being done right. We check if the Read/Write/ReadAndWrite permissions
are respected, if the canonical path is being resolved and if
the permissions are falling back to the topmost parent directory with a
policy set when the directory being opened has no policy.

We also test if any attempt of blocking SIGSYS is silently ignored.
SIGSYS cannot be blocked because in it's handler is where we hook
syscalls to the broker process.

Also added libseccomp to EFL's jhbuild to make the life of developers
willing to help easier.

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.

(TestWebKitAPI):
(SeccompEnvironment):
(TestWebKitAPI::SeccompEnvironment::SetUp):
(TestWebKitAPI::SeccompEnvironment::TearDown):
(TestWebKitAPI::dummyHandler):
(TestWebKitAPI::TEST):
(TestWebKitAPI::stressTest):

  • efl/jhbuild.modules:
  • qmake/mkspecs/features/features.pri:
1:49 AM Changeset in webkit [147997] by Carlos Garcia Campos
  • 2 edits in trunk

Unreviewed. Fix GTK+ 32 bit build.

  • Source/autotools/symbols.filter: Add some symbols that are

mangled differently in 32 bits due to size_t.

1:35 AM FeatureFlags edited by dominik.rottsches@intel.com
subpixel layout update (diff)
1:33 AM FeatureFlags edited by dominik.rottsches@intel.com
(diff)
1:31 AM FeatureFlags edited by dominik.rottsches@intel.com
(diff)
1:12 AM Changeset in webkit [147996] by zandobersek@gmail.com
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/js/dom-static-property-for-in-iteration-expected.txt: Added.
  • platform/gtk/fast/js/exception-linenums-in-html-3-expected.png: Removed.
  • platform/gtk/fast/js/missing-style-end-tag-js-expected.png: Removed.
  • platform/gtk/fast/text/international/003-expected.png:
  • platform/gtk/fast/text/international/003-expected.txt:
  • platform/gtk/fast/text/international/text-combine-image-test-expected.png: Added.
  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt:
1:04 AM FeatureFlags edited by Mihai Maerean
CSS Regions (diff)
12:48 AM Changeset in webkit [147995] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, gardening.

fast/dom/shadow/selections-in-shadow.html is passed on EFL layout test now.

  • platform/efl/TestExpectations:
12:35 AM Changeset in webkit [147994] by rniwa@webkit.org
  • 22 edits in trunk

REGRESSION: Autocorrection doesn't work in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=113846

Reviewed by Alexey Proskuryakov.

Tools:

The problem was that we were replacing NSSpellCheck's dictionary with our own
in DumpRenderTree but we were not adding necessary corrections to the dictionary.

Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
and "would" respectively in DumpRenderTree.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetDefaultsToConsistentValues):

LayoutTests:

Removed failing expectations from tests that require "mesage" to be corrected to "message".

Also modified to dynamically assert the marker positions so that we may catch regressions
without pixel results (we still dump pixel results via dumpAsText(true) for sanity check).

  • platform/mac/TestExpectations:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.png:
  • platform/mac/editing/spelling/autocorrection-contraction-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/click-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/click-autocorrected-word.html:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-autocorrected-word.html:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.png:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word-expected.txt:
  • platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html:
  • platform/mac-wk2/TestExpectations:
12:30 AM Changeset in webkit [147993] by g.czajkowski@samsung.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Mark not implemented methods in TextCheckerEfl.
https://bugs.webkit.org/show_bug.cgi?id=112261

Reviewed by Anders Carlsson.

There's no need to call client's methods in TextCheckerEfl.cpp if they are not
implemented. Mark them as not implemented until we provide proper implementation.

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

12:20 AM Changeset in webkit [147992] by paroga@webkit.org
  • 4 edits in trunk

Do not set CMAKE_BUILD_TYPE if it is not defined
https://bugs.webkit.org/show_bug.cgi?id=114243

Reviewed by Geoffrey Garen.

Setting the CMAKE_BUILD_TYPE causes some problem with Visual Studio.
Adopt the current usage of the variable to better CMake style.

  • CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:
12:12 AM Changeset in webkit [147991] by benjamin@webkit.org
  • 1 edit
    4 deletes in trunk/Tools

Remove the gyp files for Tools
https://bugs.webkit.org/show_bug.cgi?id=114248

Reviewed by Ryosuke Niwa.

  • DumpRenderTree/DumpRenderTree.gyp: Removed.
  • DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
  • DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
  • DumpRenderTree/DumpRenderTree.gypi: Removed.
  • TestWebKitAPI/TestWebKitAPI.gyp: Removed.
  • TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
  • TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
  • TestWebKitAPI/TestWebKitAPI.gypi: Removed.
12:07 AM Changeset in webkit [147990] by rniwa@webkit.org
  • 1 edit
    1 delete in trunk/Source/JavaScriptCore

Remove yarr.gyp
https://bugs.webkit.org/show_bug.cgi?id=114247

Reviewed by Benjamin Poulain.

  • yarr/yarr.gyp: Removed.
Note: See TracTimeline for information about the timeline view.