Timeline



Mar 4, 2014:

11:41 PM Changeset in webkit [165099] by fpizlo@apple.com
  • 18 edits
    8 adds in trunk

DFG and FTL should specialize for and support CompareStrictEq over Misc (i.e. boolean, undefined, or null)
https://bugs.webkit.org/show_bug.cgi?id=129563

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Rolling this back in after fixing an assertion failure. speculateMisc() should have
said DFG_TYPE_CHECK instead of typeCheck.

This adds a specialization of CompareStrictEq over Misc. I noticed the need for this
when I saw that we didn't support CompareStrictEq(Untyped) in FTL but that the main
user of this was EarleyBoyer, and in that benchmark what it was really doing was
comparing undefined, null, and booleans to each other.

This also adds support for miscellaneous things that I needed to make my various test
cases work. This includes comparison over booleans and the various Throw-related node
types.

This also improves constant folding of CompareStrictEq and CompareEq.

Also found a bug where we were claiming that GetByVals on typed arrays are OutOfBounds
based on profiling, which caused some downstream badness. We don't actually support
compiling OutOfBounds GetByVals on typed arrays. The DFG would ignore the flag and just
emit a bounds check, but in the FTL path, the SSA lowering phase would assume that it
shouldn't factor out the bounds check since the access is not InBounds but then the
backend would ignore the flag and assume that the bounds check was already emitted.
This showed up on an existing test but I added a test for this explicitly to have more
certain coverage. The fix is to not mark something as OutOfBounds if the semantics are
that we'll have a bounds check anyway.

This is a 1% speed-up on Octane mostly because of raytrace, but also because of just
general progressions across the board. No speed-up yet on EarleyBoyer, since there is
still a lot more coverage work to be done there.

  • bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):
(JSC::leastUpperBoundOfStrictlyEquivalentSpeculations):
(JSC::valuesCouldBeEqual):

  • bytecode/SpeculatedType.h:

(JSC::isMiscSpeculation):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGArrayMode.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateMisc):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMisc):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileMiscStrictEq):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileMiscStrictEq):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileThrow):
(JSC::FTL::LowerDFGToLLVM::isNotMisc):
(JSC::FTL::LowerDFGToLLVM::isMisc):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMisc):

  • tests/stress/float32-array-out-of-bounds.js: Added.
  • tests/stress/weird-equality-folding-cases.js: Added.

LayoutTests:

Reviewed by Geoffrey Garen.

  • js/regress/fold-strict-eq-expected.txt: Added.
  • js/regress/fold-strict-eq.html: Added.
  • js/regress/misc-strict-eq-expected.txt: Added.
  • js/regress/misc-strict-eq.html: Added.
  • js/regress/script-tests/fold-strict-eq.js: Added.

(foo):
(test):

  • js/regress/script-tests/misc-strict-eq.js: Added.
11:25 PM Changeset in webkit [165098] by commit-queue@webkit.org
  • 18 edits
    8 deletes in trunk

Unreviewed, rolling out r165085.
http://trac.webkit.org/changeset/165085
https://bugs.webkit.org/show_bug.cgi?id=129729

Broke imported/w3c/html-templates/template-element/template-
content.html (Requested by ap on #webkit).

Source/JavaScriptCore:

  • bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):

  • bytecode/SpeculatedType.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGArrayMode.h:
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateBoolean):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::speculate):

  • tests/stress/float32-array-out-of-bounds.js: Removed.
  • tests/stress/weird-equality-folding-cases.js: Removed.

LayoutTests:

  • js/regress/fold-strict-eq-expected.txt: Removed.
  • js/regress/fold-strict-eq.html: Removed.
  • js/regress/misc-strict-eq-expected.txt: Removed.
  • js/regress/misc-strict-eq.html: Removed.
  • js/regress/script-tests/fold-strict-eq.js: Removed.
  • js/regress/script-tests/misc-strict-eq.js: Removed.
10:24 PM Changeset in webkit [165097] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Preparing to run layout tests on Wincairo.
https://bugs.webkit.org/show_bug.cgi?id=129709

Patch by Alex Christensen <achristensen@webkit.org> on 2014-03-04
Reviewed by Brent Fulgham.

  • Scripts/webkitdirs.pm:

(setPathForRunningWebKitApp):
Add GStreamer directory for WinCairo running layout tests.

  • win/DLLLauncher/DLLLauncherMain.cpp:

(modifyPath):
Added the WinCairo bin32 or bin64 directory for running WinLauncher.

9:55 PM Changeset in webkit [165096] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix the build after r165095

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-04

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _keyboardChangedWithInfo:adjustScrollView:]):

9:37 PM Changeset in webkit [165095] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Account for the keyboard when computing the unobscuredRect
https://bugs.webkit.org/show_bug.cgi?id=129660

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-04
Reviewed by Enrica Casucci.

Adjust the unobscuredRect when a docked keyboard is on screen.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateVisibleContentRectsWithStableState:]):
(-[WKWebView _keyboardChangedWithInfo:adjustScrollView:]):

9:30 PM Changeset in webkit [165094] by Alan Bujtas
  • 15 edits
    2 adds in trunk

Enable device pixel repaint rect tracking.
https://bugs.webkit.org/show_bug.cgi?id=129712

Reviewed by Simon Fraser.

Tracked repaint rects are device pixel snapped now to support hiDPI test cases.

Source/WebCore:

Test: fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking.html

  • WebCore.exp.in:
  • page/FrameView.cpp:

(WebCore::FrameView::addTrackedRepaintRect):
(WebCore::FrameView::trackedRepaintRectsAsText): Print them as LayoutUnits to get
trailing zeros cut off.

  • page/FrameView.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintViewRectangle):

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::trackedRepaintRects):

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:

(DumpRenderTreeSupportGtk::trackedRepaintRects):

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView trackedRepaintRects]): Keep existing behavior for now.

LayoutTests:

  • fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking-expected.txt: Added.
  • fast/repaint/hidpi-device-pixel-based-repaint-rect-tracking.html: Added.
8:44 PM Changeset in webkit [165093] by BJ Burg
  • 5 edits in trunk/Source

Inspector does not restore breakpoints after a page reload
https://bugs.webkit.org/show_bug.cgi?id=129655

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Fix a regression introduced by r162096 that erroneously removed
the inspector backend's mapping of files to breakpoints whenever the
global object was cleared.

The inspector's breakpoint mappings should only be cleared when the
debugger agent is disabled or destroyed. We should only clear the
debugger's breakpoint state when the global object is cleared.

To make it clearer what state is being cleared, the two cases have
been split into separate methods.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::disable):
(Inspector::InspectorDebuggerAgent::clearInspectorBreakpointState):
(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::InspectorDebuggerAgent::didClearGlobalObject):

  • inspector/agents/InspectorDebuggerAgent.h:

Source/WebInspectorUI:

Fix some console asserts that fire when breakpoints resolve.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.breakpointResolved):
This had a typo, it should be breakpoint.identifier.
(WebInspector.DebuggerManager.prototype.scriptDidParse):
Sometimes the url parameter is empty instead of null.

7:48 PM Changeset in webkit [165092] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS][WebKit2] Exclude plug-in sandbox profiles from the build
https://bugs.webkit.org/show_bug.cgi?id=129719

Reviewed by Simon Fraser.

  • Configurations/WebKit2.xcconfig:
6:54 PM Changeset in webkit [165091] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Don't clamp scrolling node offsets when the offset is changed by delegated scrolling
https://bugs.webkit.org/show_bug.cgi?id=129724

Reviewed by Sam Weinig.

Call setScrollPositionWithoutContentEdgeConstraints() from
ScrollingTree::scrollPositionChangedViaDelegatedScrolling() so that
layers are not clamped during rubber-banding.

This requires making setScrollPositionWithoutContentEdgeConstraints()
a pure virtual function on the base class.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):

  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
6:35 PM Changeset in webkit [165090] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Streamline JSValue::get().
<https://webkit.org/b/129720>

Fetch each Structure and VM only once when walking the prototype chain
in JSObject::getPropertySlot(), then pass it along to the functions
we call from there, so they don't have to re-fetch it.

Reviewed by Geoff Garen.

  • runtime/JSObject.h:

(JSC::JSObject::inlineGetOwnPropertySlot):
(JSC::JSObject::fastGetOwnPropertySlot):
(JSC::JSObject::getPropertySlot):

6:14 PM Changeset in webkit [165089] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] WKScrollView should be able to cancel touches in content view
https://bugs.webkit.org/show_bug.cgi?id=129711

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-04
Reviewed by Simon Fraser.

  • UIProcess/ios/WKScrollView.mm:

We should not override UIWebScrollView behavior regarding touch cancellation otherwise we force
other gesture recognizers to fail if delayed touches have been dispatched.

6:13 PM Changeset in webkit [165088] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Consider the entire view state on update to find if a change is stable or not
https://bugs.webkit.org/show_bug.cgi?id=129721

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-04
Reviewed by Simon Fraser.

Changes in scroll, zoom and obscuredRect can happen simultaneously. To compute if the current state
is stable or not, we should consider the complete picture from all the type of updates.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didFinishScrolling]):
(-[WKWebView scrollViewDidScroll:]):
(-[WKWebView scrollViewDidZoom:]):
(-[WKWebView scrollViewDidEndZooming:withView:atScale:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _updateVisibleContentRects]):
(-[WKWebView _setObscuredInsets:]):
(-[WKWebView _endInteractiveObscuredInsetsChange]):

5:51 PM Changeset in webkit [165087] by commit-queue@webkit.org
  • 16 edits in trunk/Source

WebVideoFullscreen, should make the hand off of the video layer explicit.
https://bugs.webkit.org/show_bug.cgi?id=128844

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-03-04
Reviewed by Simon Fraser.

Source/WebCore:

This change introduces a more explicit hand-off of the video layer.
This describes the interactions between WebVideoFullscreenInterface and WebVideoFullscreenModel
WebVideoFullscreenModel <-> WebVideoFullscreenInterface

enterFullScreen(*) ->

<- borrowVideoLayer

willLendVideoLayer ->

didLendVideoLayer ->

<- didEnterFullscreen
...
<- requestExitFullscreen

exitFullscreen ->

<- returnVideoLayer
<- didExitFullscreen

(*) enterFullScreen actually comes from WebVideoFullscreenControllerAVKit.

  • WebCore.exp.in:

Export new functions in WebVideoFullscreenInterfaceAVKit, WebVideoFullscreenModelMediaElement, etc.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

Add WebVideoFullscreenControllerChangeObserver to forward fullscreen callbacks to WebVideoFullscreenController

(WebVideoFullscreenControllerChangeObserver::setTarget):
Sets obj-c target of fullscreen change callbacks.

(-[WebVideoFullscreenController init]):
Point _changeObserver's target at self.

(-[WebVideoFullscreenController dealloc]):
Clear _changeObserver's target.

(-[WebVideoFullscreenController enterFullscreen:]):
Retain self to prevent dealloc during animation or while fullscreen.
Connect _interface to _changeObserver.

(-[WebVideoFullscreenController exitFullscreen]):
Remove use of completion move cleanup to -didExitFullscreen.

(-[WebVideoFullscreenController didEnterFullscreen]):
Nothing to see here.

(-[WebVideoFullscreenController didExitFullscreen]):
Move clean up code that was in a completion to here.

  • platform/ios/WebVideoFullscreenInterface.h:

Add delarations for more explicit hand-off of video layer.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.h:

Add WebVideoFullscreenChangeObserver to notify when fullscreen animations complete.
Add declarations for more explicit hand-off of video layer.
Add WebAVPlayerLayer now always wraps the m_videoLayer to prevent default behavior
of AVPlayerLayer.

(WebCore::WebVideoFullscreenChangeObserver::~WebVideoFullscreenChangeObserver):
Add empty virtual destructor.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

Include AVKit headers instead of declaring everything locally.
AVPlayerLayer protocol renamed to AVVideoLayer per AVKit.

(-[WebAVPlayerController dealloc]):
Don't refer to self.

(-[WebAVPlayerController playerViewController:shouldDismissWithReason:]):
Pause before requesting exit fullscreen.

(-[WebAVPlayerLayer setPlayerController:]):
This is required by AVVideoLayer, but we don't need it.

(WebVideoFullscreenInterfaceAVKit::playerController):
White space.

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenChangeObserver):
Set observer to forward fullscreen changes to.

(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
Use more explicit video layer hand-off.

(WebVideoFullscreenInterfaceAVKit::doEnterFullscreen):
Move enterFullscreen logic here.
AVPlayerViewController now takes the video layer at init time.
Always provide a video layer wrapped in a WebAVPlayerLayer.

(WebVideoFullscreenInterfaceAVKit::willLendVideoLayer):
Use more explicit video layer hand-off.

(WebVideoFullscreenInterfaceAVKit::didLendVideoLayer):
Use more explicit video layer hand-off.

(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Use more explicit video layer hand-off.

  • platform/ios/WebVideoFullscreenModel.h:

Add functions for more explicit video layer hand-off.

  • platform/ios/WebVideoFullscreenModelMediaElement.h:

Mark virtual functions as virtual.
Add changes for WebVideoFullscreenModel.

  • platform/ios/WebVideoFullscreenModelMediaElement.mm:

Use more explicit video layer hand-off.

(WebVideoFullscreenModelMediaElement::setMediaElement):
Don't push the video layer. Wait for a request for it.

(WebVideoFullscreenModelMediaElement::handleEvent):
Make sure m_videoFullscreenInterface is valid.

(WebVideoFullscreenModelMediaElement::borrowVideoLayer):
Use more explicit video layer hand-off.
Lend videoLayer in request to a request to borrow the videoLayer.
Make sure to retain the video layer before it is removed from the layer tree.

(WebVideoFullscreenModelMediaElement::returnVideoLayer):
Use more explicit video layer hand-off.

(WebVideoFullscreenModelMediaElement::requestExitFullscreen):
Don't clear the mediaElement reference until completely exited from fullscreen.

Source/WebKit2:

This change introduces a more explicit hand-off of the video layer and fullscreen transition.
This describes the interactions between WebVideoFullscreenInterface and WebVideoFullscreenModel
WebVideoFullscreenModel <-> WebVideoFullscreenInterface

enterFullScreen(*) ->

<- borrowVideoLayer

willLendVideoLayer ->

didLendVideoLayer ->

<- didEnterFullscreen
...
<- requestExitFullscreen

exitFullscreen ->

<- returnVideoLayer
<- didExitFullscreen

(*) enterFullScreen actually comes from WebVideoFullscreenControllerAVKit.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.h:

Implement WebVideoFullscreenChangeObserver.
Add support for explicit video layer hand-off.
Add m_videoView to retain the videoLayer's UIView.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.messages.in:

WillLendVideoLayerWithID replaces SetVideoLayerID

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

Adopt new methods for explicit video layer hand-off.

(WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy):
Observe fullscreen changes.

(WebKit::WebVideoFullscreenManagerProxy::didCommitLayerTree):
Pending fullscreen transition now does didLendVideoLayer instead of calling enter fullscreen.
It also removes the videoView from it's super view now that it is safe to do so.

(WebKit::WebVideoFullscreenManagerProxy::willLendVideoLayerWithID):
This replaces setVideoLayerID. It retains the UIView for the layer to keep it alive before it is unparented.

(WebKit::WebVideoFullscreenManagerProxy::requestExitFullscreen):
Adopt more explicit fullscreen transition.

(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):
Adopt more explicit fullscreen transition.

(WebKit::WebVideoFullscreenManagerProxy::didEnterFullscreen):
Adopt more explicit fullscreen transition.

(WebKit::WebVideoFullscreenManagerProxy::borrowVideoLayer):
Adopt more explicit video layer hand-off.

(WebKit::WebVideoFullscreenManagerProxy::returnVideoLayer):
Adopt more explicit video layer hand-off.

  • WebProcess/ios/WebVideoFullscreenManager.cpp:

Manage state of fullscreen transition more competently. Wait till an animation is complete to begin the next one.

(WebKit::WebVideoFullscreenManager::WebVideoFullscreenManager):
Init three new state members.

(WebKit::WebVideoFullscreenManager::enterFullscreenForNode):
Update animation state. Don't procede if animation is in progress.

(WebKit::WebVideoFullscreenManager::exitFullscreenForNode):
Update animation state. Don't procede if animation is in progress.

(WebKit::WebVideoFullscreenManager::willLendVideoLayer):
Adopt more explicit video layer hand-off.
This replaces SetVideoLayer.

(WebKit::WebVideoFullscreenManager::didLendVideoLayer):
This is a no-op as this will be sent through a RemoteLayerTreeTransaction.

(WebKit::WebVideoFullscreenManager::didEnterFullscreen):
Adopt more explicit fullscreen transition.

(WebKit::WebVideoFullscreenManager::didExitFullscreen):
Adopt more explicit fullscreen transition.

  • WebProcess/ios/WebVideoFullscreenManager.h:

Adopt more explicit fullscreen transition.

  • WebProcess/ios/WebVideoFullscreenManager.messages.in:

Adopt more explicit fullscreen/video layer transition.

5:24 PM Changeset in webkit [165086] by Simon Fraser
  • 10 edits in trunk/Source

Source/WebCore: Get position:fixed working slightly better on iOS
https://bugs.webkit.org/show_bug.cgi?id=129714

Reviewed by Benjamin Poulain.

Send the scroll position as a FloatPoint, rather than an IntPoint.

  • WebCore.exp.in:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):

  • page/scrolling/ScrollingTree.h:

Source/WebKit2: Get position:fixed working slightly better on iOS WK2
https://bugs.webkit.org/show_bug.cgi?id=129714

Reviewed by Benjamin Poulain.

Start telling the RemoteScrollingCoordinatorProxy about scroll position changes
again, so it can update fixed and sticky layers.

Send the scroll position as a FloatPoint, rather than an IntPoint.

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChangedViaDelegatedScrolling):
(WebKit::RemoteScrollingCoordinatorProxy::scrollPositionChanged):

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):
Tell the RemoteScrollingCoordinatorProxy about the scroll update.
Only update the customFixedPositionRect if we've finished scrolling or zooming.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::updateVisibleContentRects): Return a bool indicating
whether the visible rects changed.

5:03 PM Changeset in webkit [165085] by fpizlo@apple.com
  • 18 edits
    8 adds in trunk

DFG and FTL should specialize for and support CompareStrictEq over Misc (i.e. boolean, undefined, or null)
https://bugs.webkit.org/show_bug.cgi?id=129563

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

This adds a specialization of CompareStrictEq over Misc. I noticed the need for this
when I saw that we didn't support CompareStrictEq(Untyped) in FTL but that the main
user of this was EarleyBoyer, and in that benchmark what it was really doing was
comparing undefined, null, and booleans to each other.

This also adds support for miscellaneous things that I needed to make my various test
cases work. This includes comparison over booleans and the various Throw-related node
types.

This also improves constant folding of CompareStrictEq and CompareEq.

Also found a bug where we were claiming that GetByVals on typed arrays are OutOfBounds
based on profiling, which caused some downstream badness. We don't actually support
compiling OutOfBounds GetByVals on typed arrays. The DFG would ignore the flag and just
emit a bounds check, but in the FTL path, the SSA lowering phase would assume that it
shouldn't factor out the bounds check since the access is not InBounds but then the
backend would ignore the flag and assume that the bounds check was already emitted.
This showed up on an existing test but I added a test for this explicitly to have more
certain coverage. The fix is to not mark something as OutOfBounds if the semantics are
that we'll have a bounds check anyway.

This is a 1% speed-up on Octane mostly because of raytrace, but also because of just
general progressions across the board. No speed-up yet on EarleyBoyer, since there is
still a lot more coverage work to be done there.

  • bytecode/SpeculatedType.cpp:

(JSC::speculationToAbbreviatedString):
(JSC::leastUpperBoundOfStrictlyEquivalentSpeculations):
(JSC::valuesCouldBeEqual):

  • bytecode/SpeculatedType.h:

(JSC::isMiscSpeculation):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateMisc):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::SafeToExecuteEdge::operator()):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::speculateMisc):
(JSC::DFG::SpeculativeJIT::speculate):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileMiscStrictEq):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileMiscStrictEq):

  • dfg/DFGUseKind.cpp:

(WTF::printInternal):

  • dfg/DFGUseKind.h:

(JSC::DFG::typeFilterFor):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileThrow):
(JSC::FTL::LowerDFGToLLVM::isNotMisc):
(JSC::FTL::LowerDFGToLLVM::isMisc):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateMisc):

  • tests/stress/float32-array-out-of-bounds.js: Added.
  • tests/stress/weird-equality-folding-cases.js: Added.

LayoutTests:

Reviewed by Geoffrey Garen.

  • js/regress/fold-strict-eq-expected.txt: Added.
  • js/regress/fold-strict-eq.html: Added.
  • js/regress/misc-strict-eq-expected.txt: Added.
  • js/regress/misc-strict-eq.html: Added.
  • js/regress/script-tests/fold-strict-eq.js: Added.

(foo):
(test):

  • js/regress/script-tests/misc-strict-eq.js: Added.
4:33 PM Changeset in webkit [165084] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Fixed Windows build without MEDIA_CONTROLS_SCRIPT enabled.
https://bugs.webkit.org/show_bug.cgi?id=129701

Patch by Alex Christensen <achristensen@webkit.org> on 2014-03-04
Reviewed by Jer Noble.

  • WebCore.vcxproj/WebCore.vcxproj:
  • DerivedSources.cpp:

Moved UserAgentScriptsData.cpp to DerivedSources.cpp to only be built if MEDIA_CONTROLS_SCRIPT is enabled.

  • DerivedSources.make:

Only generate UserAgentScripts.cpp/h when USER_AGENT_SCRIPTS is non-empty.

  • rendering/RenderThemeWin.cpp:

Only include UserAgentScripts.h when MEDIA_CONTROLS_SCRIPT is enabled.

4:26 PM Changeset in webkit [165083] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

WKPage's pageExtendedBackgroundColor API exposed through WKView/WKWebView should support NSColor
https://bugs.webkit.org/show_bug.cgi?id=129704

Patch by Conrad Shultz <Conrad Shultz> on 2014-03-04
Reviewed by Beth Dakin.

Add NSColor-returning methods to complement the existing UIColor-returning methods.

  • UIProcess/API/Cocoa/WKViewPrivate.h:

Declare _pageExtendedBackgroundColor for non-TARGET_OS_IPHONE.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pageExtendedBackgroundColor]):
Return an NSColor created from the pageExtendedBackgroundColor.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Declare _pageExtendedBackgroundColor for non-TARGET_OS_IPHONE.

  • UIProcess/API/mac/WKView.mm:

(-[WKView _pageExtendedBackgroundColor]):
Return an NSColor created from the pageExtendedBackgroundColor.

4:07 PM Changeset in webkit [165082] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

Web Inspector: Give WebProcess private RWI entitlement
https://bugs.webkit.org/show_bug.cgi?id=129710

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-04
Reviewed by Timothy Hatcher.

  • Configurations/WebContent-iOS.entitlements:

Add entitlements to "WebProcess" when code signing.

  • Configurations/WebContentProcess.xcconfig:

Add the private RWI entitlement.

2:52 PM Changeset in webkit [165081] by enrica@apple.com
  • 7 edits in trunk/Source/WebKit2

[iOS WebKit2]: Next/Prev button in the accessory bar do not work.
https://bugs.webkit.org/show_bug.cgi?id=129690
<rdar://problem/16073569>

Reviewed by Simon Fraser.

Adding support for Next and Previous buttons in the accessory bar.
When the request is processed by the WebProcess, we identify the next
focusable node that needs to be assisted and we call focus() on the element
letting the focus changing machinery take care of updating the assisted node.
This change also add support for the Clear button, when appropriate and hooks up
the call to the WebProcess.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView accessoryTab:]):
(-[WKContentView accessoryClear]):
(-[WKContentView _updateAccessory]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::focusNextAssistedNode):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::nextFocusableElement):
(WebKit::hasFocusableElement):
(WebKit::WebPage::focusNextAssistedNode):
(WebKit::WebPage::getAssistedNodeInformation):

2:48 PM Changeset in webkit [165080] by Simon Fraser
  • 8 edits in trunk/Source

Allow iOS DumpRenderTree crashes to show application-specific information
https://bugs.webkit.org/show_bug.cgi?id=129705

Source/WebCore:

Reviewed by David Kilzer.

Make the WKSI function SetCrashReportApplicationSpecificInformation available
in iOS simulator builds.

  • WebCore.exp.in:
  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:

Source/WebKit/mac:

Reviewed by David Kilzer.

Make the WKSI function SetCrashReportApplicationSpecificInformation available
in iOS simulator builds.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

Reviewed by David Kilzer.

Make the WKSI function SetCrashReportApplicationSpecificInformation available
in iOS simulator builds.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

2:42 PM Changeset in webkit [165079] by akling@apple.com
  • 17 edits in trunk/Source

Spam static branch prediction hints on JS bindings.
<https://webkit.org/b/129703>

Source/JavaScriptCore:

Add LIKELY hint to jsDynamicCast since it's always used in a context
where we expect it to succeed and takes an error path when it doesn't.

Reviewed by Geoff Garen.

  • runtime/JSCell.h:

(JSC::jsDynamicCast):

Source/WebCore:

Add UNLIKELY hints to all !castedThis and exec->hadException() paths
in the JS bindings since they are almost always going to get skipped.

Reviewed by Geoff Garen.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(GenerateConstructorDefinition):

2:40 PM Changeset in webkit [165078] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Get to Structures more efficiently in JSCell::methodTable().
<https://webkit.org/b/129702>

In JSCell::methodTable(), get the VM once and pass that along to
structure(VM&) instead of using the heavier structure().

In JSCell::methodTable(VM&), replace calls to structure() with
calls to structure(VM&).

Reviewed by Mark Hahnenberg.

  • runtime/JSCellInlines.h:

(JSC::JSCell::methodTable):

2:40 PM Changeset in webkit [165077] by cavalcantii@gmail.com
  • 3 edits in trunk/Source/WebCore

Remove unused StdDeviation from Gaussian Blur effect
https://bugs.webkit.org/show_bug.cgi?id=129693

Reviewed by Simon Fraser.

No new tests, no change on behavior.

  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEGaussianBlur.h:
2:23 PM Changeset in webkit [165076] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Add a Document::updateStyleIfNeededForNode(Node&).
<https://webkit.org/b/129689>

Generalize the mechanism that computed style uses to avoid doing full
style updates when the node we're interested in isn't actually dirty.

Reviewed by Antti Koivisto.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • dom/Document.cpp:

(WebCore::nodeOrItsAncestorNeedsStyleRecalc):
(WebCore::Document::updateStyleIfNeededForNode):

  • dom/Document.h:
  • editing/htmlediting.cpp:

(WebCore::isEditablePosition):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultEventHandler):

2:15 PM Changeset in webkit [165075] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Listen for the XPC_ERROR_CONNECTION_INVALID event to deref
https://bugs.webkit.org/show_bug.cgi?id=129697

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-04
Reviewed by Timothy Hatcher.

  • inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::handleEvent):

1:38 PM Changeset in webkit [165074] by mhahnenberg@apple.com
  • 40 edits
    2 deletes in trunk/Source

Merge API shims and JSLock
https://bugs.webkit.org/show_bug.cgi?id=129650

Reviewed by Mark Lam.

Source/JavaScriptCore:

JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason
to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.

  • API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):
(JSC::APICallbackFunction::construct):

  • API/APIShims.h: Removed.
  • API/JSBase.cpp:

(JSEvaluateScript):
(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):
(JSSynchronousGarbageCollectForDebugging):

  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::init):
(JSC::JSCallbackObject<Parent>::getOwnPropertySlot):
(JSC::JSCallbackObject<Parent>::put):
(JSC::JSCallbackObject<Parent>::putByIndex):
(JSC::JSCallbackObject<Parent>::deleteProperty):
(JSC::JSCallbackObject<Parent>::construct):
(JSC::JSCallbackObject<Parent>::customHasInstance):
(JSC::JSCallbackObject<Parent>::call):
(JSC::JSCallbackObject<Parent>::getOwnNonIndexPropertyNames):
(JSC::JSCallbackObject<Parent>::getStaticValue):
(JSC::JSCallbackObject<Parent>::callbackGetter):

  • API/JSContext.mm:

(-[JSContext setException:]):
(-[JSContext wrapperForObjCObject:]):
(-[JSContext wrapperForJSObject:]):

  • API/JSContextRef.cpp:

(JSContextGroupRelease):
(JSContextGroupSetExecutionTimeLimit):
(JSContextGroupClearExecutionTimeLimit):
(JSGlobalContextCreateInGroup):
(JSGlobalContextRetain):
(JSGlobalContextRelease):
(JSContextGetGlobalObject):
(JSContextGetGlobalContext):
(JSGlobalContextCopyName):
(JSGlobalContextSetName):

  • API/JSManagedValue.mm:

(-[JSManagedValue value]):

  • API/JSObjectRef.cpp:

(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectMakeArray):
(JSObjectMakeDate):
(JSObjectMakeError):
(JSObjectMakeRegExp):
(JSObjectGetPrototype):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectGetPropertyAtIndex):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
(JSObjectIsFunction):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameArrayRelease):
(JSPropertyNameAccumulatorAddName):

  • API/JSScriptRef.cpp:
  • API/JSValue.mm:

(isDate):
(isArray):
(containerValueToObject):
(valueToArray):
(valueToDictionary):
(objectToValue):

  • API/JSValueRef.cpp:

(JSValueGetType):
(JSValueIsUndefined):
(JSValueIsNull):
(JSValueIsBoolean):
(JSValueIsNumber):
(JSValueIsString):
(JSValueIsObject):
(JSValueIsObjectOfClass):
(JSValueIsEqual):
(JSValueIsStrictEqual):
(JSValueIsInstanceOfConstructor):
(JSValueMakeUndefined):
(JSValueMakeNull):
(JSValueMakeBoolean):
(JSValueMakeNumber):
(JSValueMakeString):
(JSValueMakeFromJSONString):
(JSValueCreateJSONString):
(JSValueToBoolean):
(JSValueToNumber):
(JSValueToStringCopy):
(JSValueToObject):
(JSValueProtect):
(JSValueUnprotect):

  • API/JSVirtualMachine.mm:

(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):

  • API/JSWeakObjectMapRefPrivate.cpp:
  • API/JSWrapperMap.mm:

(constructorHasInstance):
(makeWrapper):
(tryUnwrapObjcObject):

  • API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):
(objCCallbackFunctionForInvocation):

  • CMakeLists.txt:
  • ForwardingHeaders/JavaScriptCore/APIShims.h: Removed.
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGWorklist.cpp:
  • heap/DelayedReleaseScope.h:

(JSC::DelayedReleaseScope::~DelayedReleaseScope):

  • heap/HeapTimer.cpp:

(JSC::HeapTimer::timerDidFire):
(JSC::HeapTimer::timerEvent):

  • heap/IncrementalSweeper.cpp:
  • inspector/InjectedScriptModule.cpp:

(Inspector::InjectedScriptModule::ensureInjected):

  • jsc.cpp:

(jscmain):

  • runtime/GCActivityCallback.cpp:

(JSC::DefaultGCActivityCallback::doWork):

  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):

  • runtime/JSLock.cpp:

(JSC::JSLock::lock):
(JSC::JSLock::didAcquireLock):
(JSC::JSLock::unlock):
(JSC::JSLock::willReleaseLock):
(JSC::JSLock::DropAllLocks::DropAllLocks):
(JSC::JSLock::DropAllLocks::~DropAllLocks):

  • runtime/JSLock.h:
  • testRegExp.cpp:

(realMain):

Source/WebCore:

No new tests.

JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason
to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.

  • bindings/js/DOMRequestState.h:

(WebCore::DOMRequestState::Scope::Scope):

  • bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve):
(WebCore::DeferredWrapper::reject):
(WebCore::DeferredWrapper::resolve<String>):
(WebCore::DeferredWrapper::resolve<bool>):
(WebCore::char>>):
(WebCore::DeferredWrapper::reject<String>):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::deserialize):

Source/WebKit/mac:

JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason
to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.

  • WebView/WebFrame.mm:

(-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):

Source/WebKit2:

JSLock is now taking on all of APIEntryShim's responsibilities since there is never a reason
to take just the JSLock. Ditto for DropAllLocks and APICallbackShim.

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::~UniqueIDBDatabaseBackingStoreSQLite):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createIndex):

1:30 PM Changeset in webkit [165073] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r164812.
http://trac.webkit.org/changeset/164812
https://bugs.webkit.org/show_bug.cgi?id=129699

it made things run slower (Requested by pizlo on #webkit).

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • jsc.cpp:

(GlobalObject::finishCreation):

  • runtime/BatchedTransitionOptimizer.h:

(JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
(JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):

1:27 PM Changeset in webkit [165072] by fpizlo@apple.com
  • 5 edits
    4 adds in trunk/Source/JavaScriptCore

GetMyArgumentByVal in FTL
https://bugs.webkit.org/show_bug.cgi?id=128850

Reviewed by Oliver Hunt.

This would have been easy if the OSR exit compiler's arity checks hadn't been wrong.
They checked arity by doing "exec->argumentCount == codeBlock->numParameters", which
caused it to think that the arity check had failed if the caller had passed more
arguments than needed. This would cause the call frame copying to sort of go into
reverse (because the amount-by-which-we-failed-arity would have opposite sign,
throwing off a bunch of math) and the stack would end up being corrupted.

The bug was revealed by two existing tests although as far as I could tell, neither
test was intending to cover this case directly. So, I added a new test.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentByVal):
(JSC::FTL::LowerDFGToLLVM::compileCheckArgumentsNotCreated):
(JSC::FTL::LowerDFGToLLVM::checkArgumentsNotCreated):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLState.h:
  • tests/stress/exit-from-ftl-when-caller-passed-extra-args-then-use-function-dot-arguments.js: Added.
  • tests/stress/ftl-get-my-argument-by-val-inlined-and-not-inlined.js: Added.
  • tests/stress/ftl-get-my-argument-by-val-inlined.js: Added.
  • tests/stress/ftl-get-my-argument-by-val.js: Added.
1:08 PM Changeset in webkit [165071] by Lucas Forschler
  • 5 edits in branches/safari-537.75-branch/Source

Versioning.

1:06 PM Changeset in webkit [165070] by Lucas Forschler
  • 1 copy in tags/Safari-537.75.6

New Tag.

12:22 PM Changeset in webkit [165069] by Beth Dakin
  • 3 edits in trunk/Source/WebCore

REGRESSION: Overlay scrollbars that have grown are sometimes askew in the track
https://bugs.webkit.org/show_bug.cgi?id=129691
-and corresponding-
<rdar://problem/15666846>

Reviewed by Simon Fraser.

This regression started happening after we adopted the setPresentationValue
ScrollbarPainter API which allows us to update the position of the scrollbar knob
from our secondary scrolling thread. The bug occurs when the scrollbar grows while
it still thinks it is in presentation-value mode. Whenever the scrollbar grows, it
should be in non-presentation value mode.

If the wheel event has ended or been cancelled, we can switch out of presentation
value mode.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::handleWheelEvent):

Sometimes we will grow the scrollbar before we have received a wheel event with
the end or cancelled phase, and so automatically switch out of presentation-value
mode whenever we start one of these animations.

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):

12:15 PM Changeset in webkit [165068] by zandobersek@gmail.com
  • 17 edits in trunk/Source/WebCore

Move Source/WebCore/html/track/ code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=129666

Reviewed by Eric Carlson.

Replace uses of OwnPtr and PassOwnPtr in code under Source/WebCore/html/track/ with std::unique_ptr.

  • html/track/AudioTrack.h:
  • html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::parseWebVTTCueData):

  • html/track/InbandWebVTTTextTrack.h:
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):
(WebCore::LoadableTextTrack::newCuesAvailable):
(WebCore::LoadableTextTrack::cueLoadingCompleted):
(WebCore::LoadableTextTrack::newRegionsAvailable):

  • html/track/LoadableTextTrack.h:
  • html/track/TextTrack.h:
  • html/track/TextTrackCue.h:
  • html/track/TextTrackRegion.h:
  • html/track/VTTCue.cpp:

(WebCore::VTTCue::createWebVTTNodeTree):
(WebCore::VTTCue::markFutureAndPastNodes):

  • html/track/VTTCue.h:
  • html/track/VideoTrack.h:
  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::WebVTTParser):

  • html/track/WebVTTParser.h:
  • html/track/WebVTTTokenizer.h:
  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::processNewCueData):

  • loader/TextTrackLoader.h:
12:12 PM Changeset in webkit [165067] by zandobersek@gmail.com
  • 8 edits in trunk

[GTK] Build the Udis86 disassembler
https://bugs.webkit.org/show_bug.cgi?id=129679

Reviewed by Michael Saboff.

.:

  • GNUmakefile.am: Add the Udis86_nosources variable.
  • Source/cmake/OptionsGTK.cmake: Enable the Udis86 disassembler.

Source/JavaScriptCore:

  • GNUmakefile.am: Generate the Udis86-related derived sources. Distribute the required files.
  • GNUmakefile.list.am: Add the Udis86 disassembler files to the build.

Source/WTF:

  • wtf/Platform.h: Also enable the Udis86 disassembler for the GTK port on Linux.
11:56 AM Changeset in webkit [165066] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix too-narrow assertion I added in r165054.

It's okay for a 1-character string to come in here. This will happen
if the VM small string optimization doesn't apply (ch > 0xFF)

  • runtime/JSString.h:

(JSC::jsStringWithWeakOwner):

11:53 AM Changeset in webkit [165065] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

Subpixel rendering: Make border-radius painting device pixel aware.
https://bugs.webkit.org/show_bug.cgi?id=129558

Reviewed by Simon Fraser.

Snap rounded rects to device pixels right before passing them to GraphicsContext.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::paint):

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paint):

11:43 AM Changeset in webkit [165064] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Crashes and assertions running iOS compositing tests
https://bugs.webkit.org/show_bug.cgi?id=129688

Reviewed by Dean Jackson.

When a layer is no longer composited, we need to unregister it
from the scrolling coordinator, and remove it from m_scrollCoordinatedLayers.

Tested by compositing tests on iOS.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):

11:31 AM Changeset in webkit [165063] by zoltan@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[CSS Shapes] Add test for adjusted lineTop position between left and right shape-outside floats
https://bugs.webkit.org/show_bug.cgi?id=128696

Reviewed by David Hyatt.

  • fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjusted-between-left-right-floats-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-linetop-adjusted-between-left-right-floats.html: Added.
11:11 AM Changeset in webkit [165062] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Update bindings test results after r165046.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_set_reflected_string_attr):
(webkit_dom_test_obj_set_reflected_url_attr):
(webkit_dom_test_obj_set_reflected_custom_url_attr):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjReflectedStringAttr):
(WebCore::setJSTestObjReflectedURLAttr):
(WebCore::setJSTestObjReflectedCustomURLAttr):

  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj setReflectedStringAttr:]):
(-[DOMTestObj setReflectedURLAttr:]):
(-[DOMTestObj setReflectedCustomURLAttr:]):

11:01 AM Changeset in webkit [165061] by BJ Burg
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Skip inspector tests that are still flaky.

Skip inspector-protocol/dom/dom-search-crash.html (tracked by https://webkit.org/b/129639).
Skip inspector/test-harness-trivially-works.html (tracked by https://webkit.org/b/129642).

10:43 AM Changeset in webkit [165060] by Martin Robinson
  • 9 edits
    2 adds
    2 deletes in trunk

[GTK] Simplify the GObject DOM bindings API break check into one step
https://bugs.webkit.org/show_bug.cgi?id=129571

Reviewed by Carlos Garcia Campos.

.:

  • Source/PlatformGTK.cmake: We don't need to run the API break check before gtkdoc generation.

Add the check to 'make check.'

Source/WebCore:

  • bindings/gobject/GNUmakefile.am: We no longer generate the webkitdom.symbols file in the

DerivedSources directory. All the logic is handled internally in the script now.

  • bindings/scripts/gobject-run-api-break-test: Removed.

Tools:

  • GNUmakefile.am: Add the API break check to 'make check.'
  • gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
  • gtk/check-gdom-symbols: Removed.
  • gtk/webkitdom.py: Added.

(header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
(get_all_webkitdom_symbol_files): Find the symbol files from the names.

10:35 AM Changeset in webkit [165059] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.20.1/Source/JavaScriptCore

Merged r165038.

10:20 AM Changeset in webkit [165058] by Martin Robinson
  • 2 edits in trunk

[GTK][CMake] ENABLE_NAVIGATOR_CONTENT_UTILS is mistakenly enabled for the CMake build
https://bugs.webkit.org/show_bug.cgi?id=129502

Reviewed by Carlos Garcia Campos.

  • Source/cmake/OptionsGTK.cmake: Disable the option for GTK+.
10:05 AM Changeset in webkit [165057] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Build fix for iOS.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::addRoundedBorderClip):
(WebCore::RenderThemeIOS::paintFileUploadIconDecorations):

9:16 AM Changeset in webkit [165056] by Brent Fulgham
  • 1 edit
    2 adds in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix after bad merge of r154146.
<rdar://problem/16223155>

Two files were ommitted from the prior commit.

  • platform/win/WebCoreBundleWin.cpp: Added.

(WebCore::createWebKitBundle):
(WebCore::webKitBundle):

  • platform/win/WebCoreBundleWin.h: Added.
9:06 AM Changeset in webkit [165055] by Alan Bujtas
  • 27 edits in trunk/Source

Subpixel rendering: Make GraphicsLayer::fillRect FloatRoundedRect based and cleanup dependencies.
https://bugs.webkit.org/show_bug.cgi?id=129557

Reviewed by Simon Fraser.

This is the preparation for snapping rounded rects to device pixel position. It enables
device pixel aware border-radius painting.

No change in functionality.

Source/WebCore:

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::paintMediaSliderThumb):

  • platform/graphics/FloatRoundedRect.cpp:

(WebCore::FloatRoundedRect::FloatRoundedRect):
(WebCore::FloatRoundedRect::isRenderable):

  • platform/graphics/FloatRoundedRect.h:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::clipRoundedRect):
(WebCore::GraphicsContext::clipOutRoundedRect):
(WebCore::GraphicsContext::fillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Path.cpp:

(WebCore::Path::addRoundedRect):

  • platform/graphics/Path.h:
  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::pixelSnappedRoundedRectForPainting):

  • platform/graphics/RoundedRect.h:
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawRectShadow):
(WebCore::ShadowBlur::drawInsetShadow):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):

  • platform/graphics/ShadowBlur.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::fillRoundedRect):

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::borderRadiiFromStyle):
(WebCore::RenderThemeGtk::paintMediaSliderTrack):
(WebCore::RenderThemeGtk::paintMediaSliderThumb):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):

  • platform/win/DragImageWin.cpp:

(WebCore::createDragImageForLink):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipRoundedInnerRect):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintBorder):
(WebCore::RenderBoxModelObject::drawBoxSideFromPath):
(WebCore::RenderBoxModelObject::clipBorderSideForComplexInnerPath):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintRadioDecorations):
(WebCore::RenderThemeIOS::paintTextFieldDecorations):
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):
(WebCore::RenderThemeIOS::paintSliderTrack):
(WebCore::RenderThemeIOS::paintProgressBar):
(WebCore::RenderThemeIOS::paintFileUploadIconDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):

  • rendering/RenderThemeSafari.cpp:

(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):

  • rendering/shapes/BoxShape.cpp:

(WebCore::BoxShape::buildDisplayPaths):

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeInset::path):

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(HUDSlider::draw):
(FullscreenVideoController::draw):

9:05 AM Changeset in webkit [165054] by akling@apple.com
  • 4 edits in trunk/Source

Micro-optimize Strings in JS bindings.
<https://webkit.org/b/129673>

Source/JavaScriptCore:

Make jsStringWithWeakOwner() take a StringImpl& instead of a String.
This avoids branches in length() and operator[].

Also call JSString::create() directly instead of jsString() and just
assert that the string length is >1. This way we don't duplicate the
optimizations for empty and single-character strings.

Reviewed by Ryosuke Niwa.

  • runtime/JSString.h:

(JSC::jsStringWithWeakOwner):

Source/WebCore:

Tweaked for new jsStringWithWeakOwner signature. This patch removes
36 bytes of code from every wrapper getter that returns a DOMString.

Reviewed by Ryosuke Niwa.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsStringWithCache):

9:02 AM Changeset in webkit [165053] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

SVGPropertyTearOffs should detachChildren before deleting its value.
<http://webkit.org/b/129618>
<rdar://problem/15661617>

Reviewed by Maciej Stachowiak.

Merged from Blink (patch by kouhei@chromium.org):
https://src.chromium.org/viewvc/blink?revision=158563&view=revision
http://crbug.com/296276

Test: svg/transforms/svg-matrix-tearoff-crash.html

NOTE: The test does not reproduce a crash on WebKit using
JavaScriptCore.

  • svg/properties/SVGPropertyTearOff.h:

(WebCore::SVGPropertyTearOff::setValue):
(WebCore::SVGPropertyTearOff::~SVGPropertyTearOff):

  • Call detachChildren() if m_value is a copy. The original Blink patch did not modify the destructor code path, although that seems obvious via code inspection.
8:32 AM Changeset in webkit [165052] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: Remove WebInspector.EventHandler in favor of WebInspector.EventListenerSet
https://bugs.webkit.org/show_bug.cgi?id=129185

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-03-04
Reviewed by Timothy Hatcher.

  • UserInterface/Base/EventHandler.js: Removed.
  • UserInterface/Main.html: Don't include EventHandler.js.
  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._dismissPopover):
(WebInspector.SourceCodeTextEditor.prototype._trackPopoverEvents):
Use EventListenerSet instead of EventHandler.

8:22 AM Changeset in webkit [165051] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[WK2] Selection remains after reload.
https://bugs.webkit.org/show_bug.cgi?id=129648
<rdar://problem/16207547>

Reviewed by Sam Weinig.

We normally clear the selection when resigninig first responder but
that doesn't get called when reloading the page or when navigating with
back/forward buttons. The correct place to do this is when we get
_didCommitLoadForMainFrame where we already stop assisting the node.
The method we call into webselectionassistant is resignedFirstResponder
which takes care of clearing the selection and removing the selection view.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _stopAssistingNode]):

8:17 AM Changeset in webkit [165050] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Incorrect repaint rect cuts off content's right edge after move.
https://bugs.webkit.org/show_bug.cgi?id=129652

Reviewed by Simon Fraser.

When repaint rect is adjusted in order to take the distance from renderer into account,
the accumulated fraction value need to be added too. This is always a positive value.

Source/WebCore:

Test: fast/borders/hidpi-border-clipping-right-after-move.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

LayoutTests:

  • fast/borders/hidpi-border-clipping-right-after-move-expected.html: Added.
  • fast/borders/hidpi-border-clipping-right-after-move.html: Added.
5:19 AM Changeset in webkit [165049] by ryuan.choi@samsung.com
  • 3 edits in trunk/Source/WebCore

Remove unused member variable of NetworkInfoController
https://bugs.webkit.org/show_bug.cgi?id=129674

Reviewed by Gyuyoung Kim.

  • Modules/networkinfo/NetworkInfoController.cpp:

(WebCore::NetworkInfoController::NetworkInfoController):
(WebCore::NetworkInfoController::create):
(WebCore::provideNetworkInfoTo):

  • Modules/networkinfo/NetworkInfoController.h: Removed m_page which is not really used.
4:36 AM Changeset in webkit [165048] by svillar@igalia.com
  • 15 edits in trunk

[CSS Grid Layout] Percentages of indefinite sizes should compute to auto
https://bugs.webkit.org/show_bug.cgi?id=128173

Reviewed by Darin Adler.

Source/WebCore:

We should treat percentages of indefinite sizes as auto as
mandated by the spec. Otherwise we would end up calculating a
percentage of -1, the value we use to represent infinite.

Added some test cases to the current tests.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridTrackSize):

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::isPercentage):

LayoutTests:

Added a grid with indefinite sizes to check that we use auto to
compute the track breadths instead of the specified percentages.

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
  • fast/css-grid-layout/grid-element-repeat-get-set.html:
  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
  • fast/css-grid-layout/resources/grid.css:

(.indefiniteSizeGrid):

3:27 AM Changeset in webkit [165047] by Dániel Bátyai
  • 5 edits
    3 adds in trunk

Implement Number.prototype.clz()
https://bugs.webkit.org/show_bug.cgi?id=129479

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Implemented Number.prototype.clz() as specified in the ES6 standard.

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncClz):

LayoutTests:

Added/updated tests to account for Number.prototype.clz().

  • js/number-clz.html: Added.
  • js/number-clz-expected.txt: Added.
  • js/Object-getOwnPropertyNames-expected.txt:
  • js/script-tests/number-clz.js: Added.
  • js/script-tests/Object-getOwnPropertyNames.js:
2:48 AM Changeset in webkit [165046] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Don't synchronize attributes in reflect setters when we don't need to
https://bugs.webkit.org/show_bug.cgi?id=129662

Reviewed by Andreas Kling.

The vast majority of attributes don't need synchronization. Avoid calling synchronizeAttribute in setters
for those content attributes generated by "Reflect" keyword in IDL.

  • bindings/scripts/CodeGenerator.pm:

(SetterExpression):

  • dom/Element.cpp:

(WebCore::Element::setAttributeWithoutSynchronization): Added.

  • dom/Element.h:
2:28 AM Changeset in webkit [165045] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

Remove Document::idAttributeName().
<https://webkit.org/b/129663>

Reviewed by Ryosuke "DYEB" Niwa.

This abstraction is not actually used and causes unnecessary indirection
in some pretty hot code paths.

Replace it with hard-coded HTMLNames::idAttr instead which is a compile
time constant pointer. We can revisit this in the future if we wish to
implement support for custom id attributes.

  • dom/Attr.cpp:

(WebCore::Attr::isId):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::willModifyAttribute):

  • dom/Element.h:

(WebCore::Element::getIdAttribute):
(WebCore::Element::getNameAttribute):
(WebCore::Element::setIdAttribute):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::parseAttribute):

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

  • html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::parseAttribute):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::isKnownAttribute):
(WebCore::SVGElement::svgAttributeChanged):

1:45 AM Changeset in webkit [165044] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r164856): Use after free in WebCore::QualifiedName::operator== / WebCore::StyledElement::attributeChanged
https://bugs.webkit.org/show_bug.cgi?id=129550

Reviewed by Andreas Kling.

Source/WebCore:

We can't store a reference to QualifiedName here because ensureUniqueElementData could delete QualifiedName inside Attribute.

Test: fast/dom/uniquing-attributes-via-setAttribute.html

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):

LayoutTests:

Added a regression test.

  • fast/dom/uniquing-attributes-via-setAttribute-expected.txt: Added.
  • fast/dom/uniquing-attributes-via-setAttribute.html: Added.
12:26 AM Changeset in webkit [165043] by commit-queue@webkit.org
  • 4 edits
    4 moves in trunk/Source

Move EvasGLContext and EvasGLSurface files into the efl common directory.
https://bugs.webkit.org/show_bug.cgi?id=129603

Patch by Hyowon Kim <hw1008.kim@samsung.com> on 2014-03-04
Reviewed by Gyuyoung Kim.

Source/WebCore:

EFL port will use EvasGLContext and EvasGLSurface files in both WK1 and WK2.

No new tests, just refactorings.

  • PlatformEfl.cmake:
  • platform/graphics/efl/EvasGLContext.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/EvasGLContext.cpp.

(WebKit::EvasGLContext::EvasGLContext):
(WebKit::EvasGLContext::~EvasGLContext):

  • platform/graphics/efl/EvasGLContext.h: Renamed from Source/WebKit2/UIProcess/API/efl/EvasGLContext.h.

(WebKit::EvasGLContext::create):
(WebKit::EvasGLContext::context):

  • platform/graphics/efl/EvasGLSurface.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/EvasGLSurface.cpp.

(WebKit::EvasGLSurface::EvasGLSurface):
(WebKit::EvasGLSurface::~EvasGLSurface):

  • platform/graphics/efl/EvasGLSurface.h: Renamed from Source/WebKit2/UIProcess/API/efl/EvasGLSurface.h.

(WebKit::EvasGLSurface::create):
(WebKit::EvasGLSurface::surface):

Source/WebKit2:

  • PlatformEfl.cmake: Update for removed files.

Mar 3, 2014:

11:36 PM Changeset in webkit [165042] by Martin Robinson
  • 4 edits in trunk/Source/WebKit/gtk

[GTK] Fix some simple gtkdoc warnings for WebKit1
https://bugs.webkit.org/show_bug.cgi?id=129659

Reviewed by Carlos Garcia Campos.

  • docs/webkitgtk-sections.txt: Make public some enum documentation that is used

in public APIs.

  • webkit/webkitwebview.cpp: Fix typos and add documentation for enums previously

marked as private.
(webkit_web_view_class_init):

  • webkit/webkitwebview.h: Ditto.
11:35 PM Changeset in webkit [165041] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

Fix the GTK+ CMake build

  • PlatformGTK.cmake: Add a missing file to the source list.
10:57 PM Changeset in webkit [165040] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Web Inspector: Avoid too early deref caused by RemoteInspectorXPCConnection::close
https://bugs.webkit.org/show_bug.cgi?id=129631

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-03-03
Reviewed by Timothy Hatcher.

Avoid deref() too early if a client calls close(). The xpc_connection_close
will cause another XPC_ERROR event to come in from the queue, deref then.
Likewise, protect multithreaded access to m_client. If a client calls
close() we want to immediately clear the pointer to prevent calls to it.

Overall the multi-threading aspects of RemoteInspectorXPCConnection are
growing too complicated for probably little benefit. We may want to
clean this up later.

  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::xpcConnectionFailed):

  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspectorXPCConnection.mm:

(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection):
(Inspector::RemoteInspectorXPCConnection::close):
(Inspector::RemoteInspectorXPCConnection::closeOnQueue):
(Inspector::RemoteInspectorXPCConnection::deserializeMessage):
(Inspector::RemoteInspectorXPCConnection::handleEvent):
(Inspector::RemoteInspectorXPCConnection::sendMessage):

10:52 PM Changeset in webkit [165039] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Match color of regex in source view with a popover
https://bugs.webkit.org/show_bug.cgi?id=129645

Patch by Jonathan Wells <jonowells@apple.com> on 2014-03-03
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:

(.console-formatted-string):
(.console-formatted-regexp):

10:38 PM Changeset in webkit [165038] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

AbstractMacroAssembler::CachedTempRegister should start out invalid
https://bugs.webkit.org/show_bug.cgi?id=129657

Reviewed by Filip Pizlo.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::AbstractMacroAssembler):

  • Invalidate all cached registers in constructor as we don't know the contents of any register at the entry to the code we are going to generate.
10:37 PM Changeset in webkit [165037] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

:active style is not cleared when its display property is set to none before mouse released.
https://bugs.webkit.org/show_bug.cgi?id=129465

Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2014-03-03
Reviewed by Antonio Gomes.

Source/WebCore:

We currently clearing the :active style when element has a renderer.
This patch makes elements clear its active style regardless of renderer.

  • dom/Document.cpp:

(WebCore::Document::updateHoverActiveState):

LayoutTests:

  • fast/css/active-display-none-expected.txt: Added.
  • fast/css/active-display-none.html: Added.
8:21 PM Changeset in webkit [165036] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

StructureOrOffset should be fastmalloced.
<https://webkit.org/b/129640>

Reviewed by Geoffrey Garen.

  • runtime/StructureIDTable.h:
8:11 PM Changeset in webkit [165035] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Use DYEBench v0.9 by default.

Rubber-stamped by Benjamin Poulain.

  • perf/DoYouEvenBench/index.html:
7:24 PM Changeset in webkit [165034] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] WebPage::updateVisibleContentRects can set the position directly instead of using programmatic scrolling
https://bugs.webkit.org/show_bug.cgi?id=129649

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-03
Reviewed by Sam Weinig.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):
Update my workaround from r165003. We should not use programmatic scrolling when the scroll position is changed
from the UI.

7:23 PM Changeset in webkit [165033] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Update UIScrollView's contentSize when a new layer tree is committed
https://bugs.webkit.org/show_bug.cgi?id=129641

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-03
Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:WebKit::]):
Previously, we relied on [UIScrollView setZoomScale:] to reset the contentSize for us.
In the cases where we would not go through [UIScrollView setZoomScale:], the UIScrollView's contentSize
did not match the actual WKContentView's area on screen.

6:22 PM Changeset in webkit [165032] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove 2 unnecessary includes from JSDOMBinding.h
<https://webkit.org/b/129619>

Reviewed by Antti Koivisto.

  • bindings/js/JSDOMBinding.h:
6:00 PM Changeset in webkit [165031] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

GraphicsContext::drawLineForText needs to be exported from WebCore.dylib for iOS builds
https://bugs.webkit.org/show_bug.cgi?id=129647

Reviewed by NOBODY (This is a build fix).

Fixing after r165025 and r165016.

No new tests as this is a build fix.

  • WebCore.exp.in:
5:53 PM Changeset in webkit [165030] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Start playback button misplaced
https://bugs.webkit.org/show_bug.cgi?id=129628

Reviewed by Simon Fraser.

On YouTube embeds, while the video is loading it is placed into the DOM with a 0x0 size.
This causes the start playback button to be visible in the upper-left corner of the embed
area. The button wasn't visible previously (in plugin mode) because the plugin clipped its
drawing to its bounds, and so the <video> shadow should do the same.

  • Modules/mediacontrols/mediaControlsiOS.css:

(::-webkit-media-controls):

5:45 PM Changeset in webkit [165029] by enrica@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix for iOS simulator.

  • WebCore.exp.in:
5:29 PM Changeset in webkit [165028] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Forward application suspend resume notifications to the web process.
https://bugs.webkit.org/show_bug.cgi?id=129356

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-03-03
Reviewed by Eric Carlson.

Source/WebCore:

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper initWithCallback:]):
Observe UIApplicationDidBecomeActiveNotification,
WebUIApplicationDidBecomeActiveNotification,
WebUIApplicationWillEnterForegroundNotification, and
WebUIApplicationWillResignActiveNotification

(-[WebMediaSessionHelper applicationDidBecomeActive:]):
Resume session.

Source/WebKit2:

Repost UIApplicationWillEnterForegroundNotification,
UIApplicationDidBecomeActiveNotification and
UIApplicationWillResignActiveNotification from UIProcess to WebProcess.
As WebUIApplicationWillEnterForegroundNotification,
WebUIApplicationDidBecomeActiveNotification, and
WebUIApplicationWillResignActiveNotification

  • UIProcess/WebPageProxy.h:

Add applicationWillEnterForeground()
applicationWillResignActive()
applicationDidBecomeActive()

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::]):
Observe notifications.

(-[WKContentView dealloc]):
Stop observing notifications.

(-[WKContentView _applicationWillResignActive:]):
Notify WebPageProxy of the event.

(-[WKContentView _applicationWillEnterForeground:]):
Notify WebPageProxy of the event.

(-[WKContentView _applicationDidBecomeActive:]):
Notify WebPageProxy of the event.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationWillEnterForeground):
Send corresponding Message to WebPage.

(WebKit::WebPageProxy::applicationWillResignActive):
Send corresponding Message to WebPage.

(WebKit::WebPageProxy::applicationDidBecomeActive):
Send corresponding Message to WebPage.

  • WebProcess/WebPage/WebPage.h:

Add applicationWillEnterForeground()
applicationWillResignActive()
applicationDidBecomeActive()

  • WebProcess/WebPage/WebPage.messages.in:

Add applicationWillEnterForeground()
applicationWillResignActive()
applicationDidBecomeActive()

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationWillResignActive):
Post corresponding NSNotification.

(WebKit::WebPage::applicationWillEnterForeground):
Post corresponding NSNotification.

(WebKit::WebPage::applicationDidBecomeActive):
Post corresponding NSNotification.

5:22 PM Changeset in webkit [165027] by commit-queue@webkit.org
  • 46 edits in trunk/Source

Unreviewed, rolling out r165013.
http://trac.webkit.org/changeset/165013
https://bugs.webkit.org/show_bug.cgi?id=129646

New code is not thread safe, asserting on a worker test
(Requested by ap on #webkit).

Source/WebCore:

  • WebCore.exp.in:
  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI):

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR):

  • loader/DocumentLoader.cpp:

(WebCore::areAllLoadersPageCacheAcceptable):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::CachedSVGDocument):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

  • loader/cache/CachedScript.h:
  • loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::CachedTextTrack):

  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):

  • loader/cache/CachedXSLStyleSheet.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationSucceeded):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::resourceForRequest):
(WebCore::MemoryCache::addImageToCache):
(WebCore::MemoryCache::removeImageFromCache):
(WebCore::MemoryCache::evict):
(WebCore::MemoryCache::removeResourcesWithOrigin):
(WebCore::MemoryCache::getOriginsWithCache):
(WebCore::MemoryCache::removeUrlFromCache):
(WebCore::MemoryCache::removeRequestFromCache):
(WebCore::MemoryCache::removeRequestFromCacheImpl):
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache):
(WebCore::MemoryCache::getStatistics):
(WebCore::MemoryCache::setDisabled):

  • loader/cache/MemoryCache.h:
  • platform/CrossThreadCopier.cpp:
  • platform/CrossThreadCopier.h:
  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::updateSnapshot):

  • testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/mac/DiskCacheMonitor.h:
  • NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::DiskCacheMonitor):

  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didCacheResource):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
5:20 PM Changeset in webkit [165026] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Better Debugger popovers for RegExp values
https://bugs.webkit.org/show_bug.cgi?id=129633

Patch by Jonathan Wells <jonowells@apple.com> on 2014-03-03
Reviewed by Timothy Hatcher.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression.populate):
(WebInspector.SourceCodeTextEditor.prototype._tokenTrackingControllerHighlightedJavaScriptExpression):
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForRegExp):

5:20 PM Changeset in webkit [165025] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS Simulator build.

  • WebCore.exp.in:
5:13 PM Changeset in webkit [165024] by Lucas Forschler
  • 5 edits in branches/safari-537.75-branch/Source

Versioning.

5:11 PM Changeset in webkit [165023] by Lucas Forschler
  • 1 copy in tags/Safari-537.75.5

New Tag.

5:00 PM Changeset in webkit [165022] by enrica@apple.com
  • 8 edits in trunk/Source/WebKit2

[iOS WebKit2]: Text fields don't zoom in when focused
https://bugs.webkit.org/show_bug.cgi?id=129632
<rdar://problem/16185230>

Reviewed by Benjamin Poulain.

When focusing the node we need to zoom and center it and possibly
scroll to make it visible.
On iPad we only scroll, without zooming.

  • Shared/AssistedNodeInformation.cpp:

(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

  • Shared/AssistedNodeInformation.h:

(WebKit::AssistedNodeInformation::AssistedNodeInformation):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _scrollToRect:withOrigin:minimumScrollDistance:]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView _startAssistingNode:]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

4:49 PM Changeset in webkit [165021] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Crash in JIT code while watching a video @ storyboard.tumblr.com
https://bugs.webkit.org/show_bug.cgi?id=129635

Reviewed by Filip Pizlo.

Clear m_set before we set bits in the TempRegisterSet(const RegisterSet& other)
construtor.

  • jit/TempRegisterSet.cpp:

(JSC::TempRegisterSet::TempRegisterSet): Clear map before setting it.

  • jit/TempRegisterSet.h:

(JSC::TempRegisterSet::TempRegisterSet): Use new clearAll() helper.
(JSC::TempRegisterSet::clearAll): New private helper.

4:45 PM Changeset in webkit [165020] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/Source/WebCore

Unreviewed build fix.
<rdar://problem/16197002>

  • WebCore.vcxproj/WebCore.vcxproj: Exclude 64-bit assembly code when building

32-bit DebugSuffix target.

4:44 PM Changeset in webkit [165019] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix ASSERT and leaks introduced in recent "Support IOS Accessibility in WK2" patch

Reviewed by Simon Fraser.

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _accessibilityRegisterUIProcessTokens]):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitializeAccessibility):

4:24 PM Changeset in webkit [165018] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/Source/JavaScriptCore

Unreviewed build fix.
<rdar://problem/16197002>

  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Exclude 64-bit assembly code when building

32-bit DebugSuffix target.

4:08 PM Changeset in webkit [165017] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Don't try to parse legacy CSS gradients -- we don't support them.

https://bugs.webkit.org/show_bug.cgi?id=129623

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/Gradient.js:

(WebInspector.Gradient.stopsWithComponents): Fix a possible exception on malformed stops.
(WebInspector.LinearGradient.linearGradientWithComponents): Return early for legacy gradients.

3:55 PM BuildBot edited by Martin Robinson
Remove references to nonexistent ports (diff)
3:49 PM Changeset in webkit [165016] by mmaxfield@apple.com
  • 7 edits
    2 adds in trunk

Space between double underlines does not scale with font size
https://bugs.webkit.org/show_bug.cgi?id=129521

Reviewed by Simon Fraser.

Source/WebCore:

This patch moves the logic about how far to draw the second underline (when text-decoration-style: double
is specified) from InlineTextBox to GraphicsContext, because GraphicsContext is the authoritative source
about how thick underlines should be. The space between the two underlines is set to the thickness of
each of the underlines.

This patch also deletes some unused code in InlineTextBox that was never getting triggered, in addition
to unifying drawLineForText with drawLinesForText. This didn't have any performance impact in my testing.

Test: fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html

  • platform/graphics/GraphicsContext.h: drawLineForText takes a boolean for if we should draw double

underlines.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLinesForText):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawLineForText):

  • rendering/InlineTextBox.cpp: Use new boolean argument

(WebCore::drawSkipInkUnderline):
(WebCore::InlineTextBox::paintDecoration):

LayoutTests:

This test renders large text with a double underline, but then barely clips off the bottom underline
using overflow: hidden. It makes sure that this is exactly the same as a single underline. If the
space between the two underlines does not scale with font size, it will appear as though there is a
single thick underline (because they will be drawn on top of each other) and will thus fail this test.

  • fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-style-double-space-scales.html: Added.
3:36 PM Changeset in webkit [165015] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Composited masks not working on iOS after r164890
https://bugs.webkit.org/show_bug.cgi?id=129630

Reviewed by Jer Noble.

Fix typo in UIView-related masks code; set the mask layer
on the view, not the maskView.

  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyProperties):

3:30 PM Changeset in webkit [165014] by Chris Fleizach
  • 19 edits
    2 copies
    4 adds in trunk

AX: Support IOS Accessibility in WK2
https://bugs.webkit.org/show_bug.cgi?id=129527

Reviewed by Sam Weinig.

Source/WebCore:

Update the iOS wrapper so that it can convert points to screen space in WebKit2.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper convertPointToScreenSpace:]):
(-[WebAccessibilityObjectWrapper convertRectToScreenSpace:]):

Source/WebKit2:

Implement enough AX hooks so that accessibility can work in WebKit2.

  • Platform/IPC/Connection.h:
  • Platform/IPC/mac/ConnectionMac.cpp:

(IPC::Connection::identifier):

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::accessibilityWebProcessTokenReceived):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _updateForScreen:]):
(-[WKContentView _setAccessibilityWebProcessToken:]):
(-[WKContentView _accessibilityRegisterUIProcessTokens]):
(-[WKContentView _didRelaunchProcess]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.h: Added.
  • WebProcess/WebPage/WKAccessibilityWebPageObjectIOS.mm: Added.

(-[WKAccessibilityWebPageObject init]):
(-[WKAccessibilityWebPageObject _accessibilityCategoryInstalled:]):
(-[WKAccessibilityWebPageObject pageScale]):
(-[WKAccessibilityWebPageObject dealloc]):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformInitializeAccessibility):
(WebKit::WebPage::accessibilityObjectForMainFramePlugin):
(WebKit::WebPage::registerUIProcessAccessibilityTokens):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.h: Copied from Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.h.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm: Copied from Source/WebKit2/WebProcess/WebPage/mac/WKAccessibilityWebPageObject.mm.

(-[WKAccessibilityWebPageObjectBase accessibilityFocusedUIElement]):

  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.h: Added.
  • WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: Added.

(-[WKAccessibilityWebPageObject accessibilityIsIgnored]):
(-[WKAccessibilityWebPageObject accessibilityAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityParameterizedAttributeNames]):
(-[WKAccessibilityWebPageObject accessibilityIsAttributeSettable:]):
(-[WKAccessibilityWebPageObject accessibilitySetValue:forAttribute:]):
(-[WKAccessibilityWebPageObject convertScreenPointToRootView:]):
(-[WKAccessibilityWebPageObject accessibilityActionNames]):
(-[WKAccessibilityWebPageObject accessibilityChildren]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:]):
(-[WKAccessibilityWebPageObject accessibilityAttributeValue:forParameter:]):
(-[WKAccessibilityWebPageObject accessibilityShouldUseUniqueId]):
(-[WKAccessibilityWebPageObject accessibilityHitTest:]):

  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeProcess):

3:07 PM Changeset in webkit [165013] by commit-queue@webkit.org
  • 46 edits in trunk/Source

Add support for sessions to MemoryCache.
https://bugs.webkit.org/show_bug.cgi?id=127794

Patch by Martin Hock <mhock@apple.com> on 2014-03-03
Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:
  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::createDeletionUI): Initialize CachedImage with sessionID.

  • html/DOMURL.cpp:

(WebCore::DOMURL::revokeObjectURL): Remove URL from MemoryCache for all sessions.

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResource): Pass sessionID to MemoryCache.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::replayXHR): Ditto.

  • loader/DocumentLoader.cpp:

(WebCore::areAllLoadersPageCacheAcceptable): Ditto.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads): Ditto.

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Initialize CachedImage with sessionID.

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Pass sessionID to MemoryCache.

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Constructor takes sessionID.

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp: Ditto.

(WebCore::CachedFont::CachedFont):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp: Ditto.

(WebCore::CachedImage::CachedImage):

  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.cpp: Ditto.

(WebCore::CachedRawResource::CachedRawResource):

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp: Ditto.

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::~CachedResource): Pass sessionID to MemoryCache.

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::sessionID):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource): Constructors take sessionID.
(WebCore::CachedResourceLoader::sessionID): Retrieve sessionID from page.
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet): Pass sessionID to MemoryCache.
(WebCore::CachedResourceLoader::requestResource): Initialize CachedCSSStyleSheet with sessionID.
(WebCore::CachedResourceLoader::revalidateResource): Initialize cached resource with sessionID.
(WebCore::CachedResourceLoader::loadResource): Pass sessionID to MemoryCache and initialize cached resource with sessionID.

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/CachedSVGDocument.cpp: Constructor takes sessionID.

(WebCore::CachedSVGDocument::CachedSVGDocument):

  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.cpp: Ditto.

(WebCore::CachedScript::CachedScript):

  • loader/cache/CachedScript.h:
  • loader/cache/CachedTextTrack.cpp: Ditto.

(WebCore::CachedTextTrack::CachedTextTrack):

  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.cpp: Ditto.

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):

  • loader/cache/CachedXSLStyleSheet.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getSessionMap): Retrieve CachedResourceMap based on sessionID.
(WebCore::MemoryCache::add): Use sessionID from CachedResource parameter.
(WebCore::MemoryCache::revalidationSucceeded): Add sessionID parameter.
(WebCore::MemoryCache::resourceForURL): Ditto.
(WebCore::MemoryCache::resourceForRequest): Ditto, also move impl into impl method.
(WebCore::MemoryCache::resourceForRequestImpl): Add CachedResourceMap parameter.
(WebCore::MemoryCache::addImageToCache): Use default sessionID.
(WebCore::MemoryCache::removeImageFromCache): Ditto.
(WebCore::MemoryCache::evict): Use sessionID from CachedResource parameter.
(WebCore::MemoryCache::removeResourcesWithOrigin): Iterate through all CachedResourceMaps.
(WebCore::MemoryCache::getOriginsWithCache): Ditto.
(WebCore::MemoryCache::removeUrlFromCache): Add sessionID parameter.
(WebCore::MemoryCache::removeRequestFromCache): Ditto.
(WebCore::MemoryCache::removeRequestFromCacheImpl): Ditto.
(WebCore::MemoryCache::removeRequestFromSessionCaches): Iterate through all CachedResourceMaps.
(WebCore::MemoryCache::crossThreadRemoveRequestFromCache): Add sessionID parameter.
(WebCore::MemoryCache::getStatistics): Iterate through all CachedResourceMaps.
(WebCore::MemoryCache::setDisabled): Ditto.

  • loader/cache/MemoryCache.h: Create another level for cache.
  • platform/CrossThreadCopier.cpp: Allow copying SessionIDs across threads.

(WebCore::SessionID>::copy):

  • platform/CrossThreadCopier.h:
  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest): Remove trailing whitespace.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::updateSnapshot): Initialize CachedImage with sessionID.

  • testing/Internals.cpp:

(WebCore::Internals::isLoadingFromMemoryCache): Pass sessionID to MemoryCache.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.h: Add sessionID() method.

(WebKit::NetworkResourceLoader::sessionID):

  • NetworkProcess/mac/DiskCacheMonitor.h: Add sessionID member.
  • NetworkProcess/mac/DiskCacheMonitor.mm:

(WebKit::DiskCacheMonitor::DiskCacheMonitor): Send sessionID to NetworkProcessConnection::DidCacheResource.

  • WebProcess/Network/NetworkProcessConnection.cpp: Add sessionID parameter to didCacheResource and pass to MemoryCache.

(WebKit::NetworkProcessConnection::didCacheResource):

  • WebProcess/Network/NetworkProcessConnection.h: Ditto.
  • WebProcess/Network/NetworkProcessConnection.messages.in: Ditto.
3:04 PM Changeset in webkit [165012] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Remove an innocuous error message and support default views for Resource and Debugger sidebars.

https://bugs.webkit.org/show_bug.cgi?id=129622

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.showDefaultContentView): Added.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showDefaultContentView): Added.
(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject): Don't log an error
if the tree element isn't a Script. We try to find any represented object, and it can fail.

2:42 PM Changeset in webkit [165011] by Simon Fraser
  • 2 edits in trunk/Tools

Add Jeremy Jones to the contributors list as a contributor.

  • Scripts/webkitpy/common/config/contributors.json:
2:34 PM Changeset in webkit [165010] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused DataView code from JSDOMBinding.h
<https://webkit.org/b/129616>

Reviewed by Antti Koivisto.

  • bindings/js/JSDOMBinding.h:
2:28 PM Changeset in webkit [165009] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[x86] Improve code generation of byte test
https://bugs.webkit.org/show_bug.cgi?id=129597

Reviewed by Geoffrey Garen.

When possible, test the 8 bit register to itself instead of comparing it
to a literal.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::test32):

2:12 PM Changeset in webkit [165008] by mark.lam@apple.com
  • 5 edits
    2 adds in trunk

Web Inspector: debugger statements do not break.
<https://webkit.org/b/129524>

Reviewed by Geoff Garen.

Source/JavaScriptCore:

Since we no longer call op_debug hooks unless there is a debugger request
made on the CodeBlock, the op_debug for the debugger statement never gets
serviced.

With this fix, we check in the CodeBlock constructor if any debugger
statements are present. If so, we set a m_hasDebuggerStatement flag that
causes the CodeBlock to show as having debugger requests. Hence,
breaking at debugger statements is now restored.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasDebuggerRequests):
(JSC::CodeBlock::clearDebuggerRequests):

LayoutTests:

  • inspector-protocol/debugger/debugger-statement-expected.txt: Added.
  • inspector-protocol/debugger/debugger-statement.html: Added.
  • inspector-protocol/debugger/resources/breakpoint.js:

(debuggerStatement):

1:52 PM Changeset in webkit [165007] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix an exception caused by trying to access the DOM before it is loaded.

https://bugs.webkit.org/show_bug.cgi?id=129617

Reviewed by Andreas Kling.

  • UserInterface/Base/Main.js:

(WebInspector.loaded): Move global event listeners from here...
(WebInspector.contentLoaded): ... to here.

1:45 PM Changeset in webkit [165006] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Allow overflow-scroll to be one-finger scrolled until we hook up UIScrollViews
https://bugs.webkit.org/show_bug.cgi?id=129621

Reviewed by Benjamin Poulain.

Temporary change to allow overflow:scroll to be scrolled in iOS WK2.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasAcceleratedTouchScrolling):

1:39 PM Changeset in webkit [165005] by mark.lam@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: m_numBreakpoints >= numBreakpoints when deleting breakpoints.
<https://webkit.org/b/129393>

Reviewed by Geoffrey Garen.

The issue manifests because the debugger will iterate all CodeBlocks in
the heap when setting / clearing breakpoints, but it is possible for a
CodeBlock to have been instantiate but is not yet registered with the
debugger. This can happen because of the following:

  1. DFG worklist compilation is still in progress, and the target codeBlock is not ready for installation in its executable yet.
  1. DFG compilation failed and we have a codeBlock that will never be installed in its executable, and the codeBlock has not been cleaned up by the GC yet.

The code for installing the codeBlock in its executable is the same code
that registers it with the debugger. Hence, these codeBlocks are not
registered with the debugger, and any pending breakpoints that would map
to that CodeBlock is as yet unset or will never be set. As such, an
attempt to remove a breakpoint in that CodeBlock will fail that assertion.

To fix this, we do the following:

  1. We'll eagerly clean up any zombie CodeBlocks due to failed DFG / FTL compilation. This is achieved by providing a DeferredCompilationCallback::compilationDidComplete() that does this clean up, and have all sub classes call it at the end of their compilationDidComplete() methods.
  1. Before the debugger or profiler iterates CodeBlocks in the heap, they will wait for all compilations to complete before proceeding. This ensures that:
    1. any zombie CodeBlocks would have been cleaned up, and won't be seen by the debugger or profiler.
    2. all CodeBlocks that the debugger and profiler needs to operate on will be "ready" for whatever needs to be done to them e.g. jettison'ing of DFG codeBlocks.
  • bytecode/DeferredCompilationCallback.cpp:

(JSC::DeferredCompilationCallback::compilationDidComplete):

  • bytecode/DeferredCompilationCallback.h:
  • Provide default implementation method to clean up zombie CodeBlocks.
  • debugger/Debugger.cpp:

(JSC::Debugger::forEachCodeBlock):

  • Utility function to iterate CodeBlocks. It ensures that all compilations are complete before proceeding.

(JSC::Debugger::setSteppingMode):
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::recompileAllJSFunctions):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::clearDebuggerRequests):

  • Use the utility iterator function.
  • debugger/Debugger.h:
  • dfg/DFGOperations.cpp:
  • Added an assert to ensure that zombie CodeBlocks will be imminently cleaned up.
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):

  • Remove unneeded code (that was not the best solution anyway) for ensuring that we don't generate new DFG codeBlocks after enabling the debugger or profiler. Now that we wait for compilations to complete before proceeding with debugger and profiler work, this scenario will never happen.
  • dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):

  • Call the super class method to clean up zombie codeBlocks.
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):

  • Call the super class method to clean up zombie codeBlocks.
  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::remove):

  • heap/CodeBlockSet.h:
  • heap/Heap.h:

(JSC::Heap::removeCodeBlock):

  • New method to remove a codeBlock from the codeBlock set.
  • jit/JITOperations.cpp:
  • Added an assert to ensure that zombie CodeBlocks will be imminently cleaned up.
  • jit/JITToDFGDeferredCompilationCallback.cpp:

(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

  • Call the super class method to clean up zombie codeBlocks.
  • runtime/VM.cpp:

(JSC::VM::waitForCompilationsToComplete):

  • Renamed from prepareToDiscardCode() to be clearer about what it does.

(JSC::VM::discardAllCode):
(JSC::VM::releaseExecutableMemory):
(JSC::VM::setEnabledProfiler):

  • Wait for compilation to complete before enabling the profiler.
  • runtime/VM.h:
1:33 PM Changeset in webkit [165004] by BJ Burg
  • 2 edits in trunk/LayoutTests

Inspector test dom/dom-search-crash.html times out in release builds
https://bugs.webkit.org/show_bug.cgi?id=129462

Reviewed by Timothy Hatcher.

This test passes now, so stop skipping it.

1:32 PM Changeset in webkit [165003] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS][WK2] Regression: ScrollView's scroll offset is never set after r164702
https://bugs.webkit.org/show_bug.cgi?id=129620

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-03
Reviewed by Simon Fraser.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

1:11 PM Changeset in webkit [165002] by Antti Koivisto
  • 7 edits
    4 adds in trunk

Find results on simple lines are not marked correctly
https://bugs.webkit.org/show_bug.cgi?id=129586

Reviewed by Andreas Kling.

Source/WebCore:

Tests: editing/text-iterator/count-mark-lineboxes.html

editing/text-iterator/count-mark-simple-lines.html


TextIterator operating on simple lines failed to take the end of the range into account.
This also causes performance issues on long documents as range traversals would miss the end
node and end up going through the entire document.

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleTextNode):

Stop when hitting the range end on simple text nodes.

(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):

Use hasRenderedText test instead of linebox-only firstTextBox.

  • testing/Internals.cpp:

(WebCore::Internals::countMatchesForText):

  • testing/Internals.h:
  • testing/Internals.idl:


Add testing interface for counting and marking matches.

LayoutTests:

  • editing/text-iterator/count-mark-lineboxes-expected.txt: Added.
  • editing/text-iterator/count-mark-lineboxes.html: Added.
  • editing/text-iterator/count-mark-simple-lines-expected.txt: Added.
  • editing/text-iterator/count-mark-simple-lines.html: Added.
12:57 PM Changeset in webkit [165001] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

SelectorQuery failing RightMostWithIdMatch are compiling their selectors for each execution
https://bugs.webkit.org/show_bug.cgi?id=129601

Reviewed by Andreas Kling.

This caused a regression after r164924 for documents in quirks mode. Since those always fail
selectorForIdLookup(), they ended up compiling the selector every time they were called.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute):

12:47 PM Changeset in webkit [165000] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

[Mac] Crash in MediaPlayer::rateChanged()
https://bugs.webkit.org/show_bug.cgi?id=129548

Reviewed by Darin Adler.

WTF::bind will automatically ref the parameters added to it. But MediaPlayerPrivate-
AVFoundation and -MediaSOurceAVFObjC are not RefCounted, so by the time the bound
function is called, the underlying objects may have been freed.

Replace or augment callOnMainThread arguments with lambdas and weakPtrs so that
if the argument has been destroyed, its methods will not be called.

Make the MediaPlayerPrivateAVFoundation::Notification function type a std::function:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification):
(WebCore::MediaPlayerPrivateAVFoundation::Notification::function):

Make createWeakPtr() public so that it can be called from non-class methods:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createWeakPtr):

Use a weakPtr to abort callOnMainThread() if the object has been destroyed:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::CMTimebaseEffectiveRateChangedCallback):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::pause):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance):

12:47 PM Changeset in webkit [164999] by jer.noble@apple.com
  • 8 edits
    2 adds in trunk

[MSE] YouTube videos fail to play
https://bugs.webkit.org/show_bug.cgi?id=129525

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-fudge-factor.html

Add a very simple playability metric to SourceBuffer. Track the number of seconds buffered
and use that metric to determine whether the MediaSource has buffered enough data to play
through.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::currentTime): Added simple accessor.
(WebCore::MediaSource::monitorSourceBuffers): Replace the functor-based iterators with lambdas.
(WebCore::MediaSource::addSourceBuffer): Drive-by fix; only add new source buffers to the

activeSourceBuffers list if those buffers are actually active.

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::SourceBuffer): Initialize new ivars.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Measure the number of seconds buffered.
(WebCore::SourceBuffer::monitorBufferingRate): Use a simple Exponential moving average to

track the buffering rate.

(WebCore::SourceBuffer::hasCurrentTime): Return true if the current time is within 1/24 s

of a buffered range.

(WebCore::SourceBuffer::hasFutureTime): Moved from MediaSource.
(WebCore::SourceBuffer::canPlayThrough): Return true if the buffering rate is > 1s per

second, or if the rate is sufficient to keep up over the remaining time.

  • Modules/mediasource/SourceBuffer.h:

LayoutTests:

  • media/media-source/media-source-addsourcebuffer.html: Updated.
  • media/media-source/media-source-addsourcebuffer-expected.txt: Updated.
  • media/media-source/media-source-fudge-factor-expected.txt: Added.
  • media/media-source/media-source-fudge-factor.html: Added.
12:24 PM Changeset in webkit [164998] by betravis@adobe.com
  • 8 edits in trunk

[CSS Shapes] Serialize circle positions
https://bugs.webkit.org/show_bug.cgi?id=129404

Reviewed by Dirk Schulze.

Source/WebCore:

Circle positions should always be present when serialized, and should
only have the 2 or 4-valued form. Keywords are converted to percentages
and simplified where possible. This patch adds some additional processing
that converts the parsed position into the serialized format, before
converting it to text. See http://dev.w3.org/csswg/css-shapes/#basic-shape-serialization.

Updated existing parsing tests.

  • css/CSSBasicShapes.cpp:

(WebCore::serializePositionOffset): Convert a position offset to a serialized string.
The offset must be a pair, as generated by buildSerializablePositionOffset.
(WebCore::buildSerializablePositionOffset): Generates a keyword + offset pair for each
position offset. The keywords may later be dropped during serialization.
(WebCore::CSSBasicShapeCircle::cssText): Use the new serialization methods.

LayoutTests:

Modify each circle test to have a correctly serialized position.

  • fast/masking/parsing-clip-path-shape-expected.html: Updated result.
  • fast/masking/parsing-clip-path-shape.html: Updated test.
  • fast/shapes/parsing/parsing-shape-inside-expected.txt: Updated results.
  • fast/shapes/parsing/parsing-shape-outside-expected.txt: Updated results.
  • fast/shapes/parsing/parsing-test-utils.js: Updated serialization results.
12:01 PM Changeset in webkit [164997] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Crash when going into video fullscreen on iOS
https://bugs.webkit.org/show_bug.cgi?id=129613

Reviewed by Dean Jackson.

We shouldn't reparent a UIView's layer without unparenting
the view first.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):

11:30 AM Changeset in webkit [164996] by Lucas Forschler
  • 2 edits in tags/Safari-538.20.1/Source/WebCore

Merged r164873.

11:18 AM AddingFiles edited by BJ Burg
details on adding code generators for win and mac (diff)
11:07 AM Changeset in webkit [164995] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Optimize StylePropertiesSet::findPropertyIndex() to improve CSS properties performance
https://bugs.webkit.org/show_bug.cgi?id=129605

Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-03-03
Reviewed by Andreas Kling.

Merged from Blink (patch by Mikhail Pozdnyakov):
https://src.chromium.org/viewvc/blink?view=revision&revision=167325

Avoid checking whether 'StylePropertiesSet' is mutable and accesing directly to its
data members to achieve performance improvements

Before the optimization applied:

mean: 3064.8337171934063 runs/s
median: 3097.5899379343855 runs/s
stdev: 66.89274074044187 runs/s
min: 2891.7479324362585 runs/s
max: 3113.288683440125 runs/s

After the optimization applied:

mean: 3343.8356114138105 runs/s
median: 3356.25682957446 runs/s
stdev: 36.297533087489036 runs/s
min: 3238.5468032264243 runs/s
max: 3368.664837531425 runs/s

Performance gain for the average value is approx. 9.1%, in the
range of the 10% - 8.2% for the min and max measured
values (Linux desktop x64).

  • css/StyleProperties.cpp:

(WebCore::ImmutableStyleProperties::findPropertyIndex):
(WebCore::MutableStyleProperties::findPropertyIndex):

  • css/StyleProperties.h:

(WebCore::toMutableStyleProperties):
(WebCore::toImmutableStyleProperties):
(WebCore::StyleProperties::findPropertyIndex):

11:02 AM Changeset in webkit [164994] by Lucas Forschler
  • 5 edits in tags/Safari-538.20.1/Source

Versioning.

11:00 AM Changeset in webkit [164993] by Lucas Forschler
  • 1 copy in tags/Safari-538.20.1

New Tag.

10:32 AM Changeset in webkit [164992] by krit@webkit.org
  • 6 edits
    6 copies
    2 moves
    3 adds
    23 deletes in trunk/LayoutTests

Transform CSS clip-path pixel tests to ref tests
https://bugs.webkit.org/show_bug.cgi?id=129607

Reviewed by Andreas Kling.

  • css3/masking/clip-path-border-box.html:
  • css3/masking/clip-path-circle-filter-expected.txt: Removed.
  • css3/masking/clip-path-circle-overflow-expected.txt: Removed.
  • css3/masking/clip-path-circle-overflow-hidden-expected.txt: Removed.
  • css3/masking/clip-path-circle-overflow-hidden.html: Removed.
  • css3/masking/clip-path-circle-relative-overflow-expected.txt: Removed.
  • css3/masking/clip-path-ellipse-expected.html: Renamed from LayoutTests/css3/masking/clip-path-circle-filter.html.
  • css3/masking/clip-path-ellipse-expected.txt: Removed.
  • css3/masking/clip-path-ellipse.html:
  • css3/masking/clip-path-filter-expected.html: Added.
  • css3/masking/clip-path-filter.html: Added.
  • css3/masking/clip-path-inset-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
  • css3/masking/clip-path-inset-expected.txt: Removed.
  • css3/masking/clip-path-overflow-expected.html: Copied from LayoutTests/css3/masking/clip-path-circle-overflow.html.
  • css3/masking/clip-path-overflow-hidden-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
  • css3/masking/clip-path-overflow-hidden.html: Renamed from LayoutTests/css3/masking/clip-path-circle-overflow.html.
  • css3/masking/clip-path-overflow.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
  • css3/masking/clip-path-polygon-evenodd-expected.html: Added.
  • css3/masking/clip-path-polygon-evenodd-expected.txt: Removed.
  • css3/masking/clip-path-polygon-evenodd.html:
  • css3/masking/clip-path-polygon-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
  • css3/masking/clip-path-polygon-expected.txt: Removed.
  • css3/masking/clip-path-polygon-nonzero-expected.html: Copied from LayoutTests/css3/masking/clip-path-ellipse.html.
  • css3/masking/clip-path-polygon-nonzero-expected.txt: Removed.
  • css3/masking/clip-path-polygon-nonzero.html:
  • css3/masking/clip-path-polygon.html:
  • platform/efl/css3/masking/clip-path-circle-overflow-expected.png: Removed.
  • platform/efl/css3/masking/clip-path-circle-overflow-hidden-expected.png: Removed.
  • platform/efl/css3/masking/clip-path-ellipse-expected.png: Removed.
  • platform/gtk/css3/masking/clip-path-circle-overflow-expected.png: Removed.
  • platform/gtk/css3/masking/clip-path-circle-overflow-hidden-expected.png: Removed.
  • platform/gtk/css3/masking/clip-path-ellipse-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-circle-overflow-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-ellipse-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-inset-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-polygon-evenodd-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-polygon-expected.png: Removed.
  • platform/mac/css3/masking/clip-path-polygon-nonzero-expected.png: Removed.
10:24 AM Changeset in webkit [164991] by BJ Burg
  • 2 edits in trunk/Source/JavaScriptCore

Another unreviewed build fix attempt for Windows after r164986.

We never told Visual Studio to copy over the web replay code generator scripts
and the generated headers for JavaScriptCore replay inputs as if they were
private headers.

10:20 AM Changeset in webkit [164990] by cavalcantii@gmail.com
  • 2 edits in trunk/Tools

Update the email.

9:46 AM Changeset in webkit [164989] by BJ Burg
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for Windows after r164986.

  • WebCore.vcxproj/build-generated-files.sh: Export WebReplayScripts

so that the build system knows how to find CodeGeneratorReplayInputs.py.

9:16 AM Changeset in webkit [164988] by abucur@adobe.com
  • 21 edits in trunk

[CSS Regions] Overset computation is incorrect in some cases
https://bugs.webkit.org/show_bug.cgi?id=129032

Reviewed by Mihnea Ovidenie.

Source/WebCore:

This patch reworks the way overset is computed for regions and named flows.

  1. Regions overflow no longer trigger an overset changed event. This is because

the overflow of a box is contained within the region range of the box. The content
edge should be considered the logical bottom position of the content inside the
flow thread.

  1. The regions events logic was moved from RenderFlowThread to RenderNamedFlowThread

and from RenderRegion to RenderNamedFlowFragment (including the regionOverset property).

  1. The overset value of the named flow is no longer stored in the named flow. It is

extracted from the overset of the last region in the chain.

  1. The regions overset is not computed every time the flow thread is laid out which

should improve performance for flows with many regions. With the patch, each region
computes the overset value during its layout when the flow thread is in the overflow
or the final layout phase.

  1. The overset changed event is dispatched only at the end of the layout of the named flows,

after all the region overset changes have been considered. This means that the overset
event can't be dispatched in the middle of the auto-height processing algorithm that
requires multiple layout passes for the flow threads.

However, the region layout update event dispatch timing was not changed, it is dispatched
every time the flow thread has a layout. This preserves the current behavior of the event.

Tests: The old tests were modified to take into account the change.

  • dom/Element.cpp:

(WebCore::Element::webkitRegionOverset):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::overset):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForRegions):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateFlowThreadsIntoMeasureContentPhase):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):

  • rendering/RenderFlowThread.h:
  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::setRegionOversetState):
(WebCore::RenderNamedFlowFragment::regionOversetState):
(WebCore::RenderNamedFlowFragment::updateOversetState):

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::computeOverflow):
(WebCore::RenderNamedFlowThread::layout):
(WebCore::RenderNamedFlowThread::dispatchNamedFlowEvents):
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEventIfNeeded):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEventIfNeeded):

  • rendering/RenderNamedFlowThread.h:

There's a new field called m_flowContentBottom that tracks the content bottom of the flow thread
after layout. This value is used to compute the overset value of the regions because it's not
affected by relative positioning or visual overflow such as shadows.

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:

LayoutTests:

Adjust the tests to cope with the overset changes.

  • fast/regions/cssom/element-region-overset-state-expected.txt:
  • fast/regions/cssom/element-region-overset-state-vertical-rl-expected.txt:
  • fast/regions/cssom/element-region-overset-state-vertical-rl.html:
  • fast/regions/cssom/element-region-overset-state.html:

This test has a new case that verifies region clamping is correctly taken into account.

  • fast/regions/cssom/webkit-named-flow-overset-expected.txt:
  • fast/regions/cssom/webkit-named-flow-overset.html:
9:06 AM Changeset in webkit [164987] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] CodeGeneratorGObject.pm remove usage of undefined variable
https://bugs.webkit.org/show_bug.cgi?id=129602

Patch by Tomas Popela <tpopela@redhat.com> on 2014-03-03
Reviewed by Martin Robinson.

Remove usage of undefined variable hdrPropIncludes in CodeGeneratorGObject.pm

  • bindings/scripts/CodeGeneratorGObject.pm:

(WriteData):

9:01 AM Changeset in webkit [164986] by BJ Burg
  • 18 edits
    11 copies
    14 adds in trunk/Source

Web Replay: upstream input storage, capture/replay machinery, and inspector domain
https://bugs.webkit.org/show_bug.cgi?id=128782

Source/JavaScriptCore:

Reviewed by Timothy Hatcher.

Alter the replay inputs code generator so that it knows when it is necessary to
to include headers for HEAVY_SCALAR types such as WTF::String and WebCore::URL.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • replay/scripts/CodeGeneratorReplayInputs.py:

(Framework.fromString):
(Frameworks): Add WTF as an allowed framework for code generation.
(Generator.generate_includes): Include headers for HEAVY_SCALAR types in the header file.
(Generator.generate_includes.declaration):
(Generator.generate_includes.or):
(Generator.generate_type_forward_declarations): Skip HEAVY_SCALAR types.

Source/WebCore:

Reviewed by Timothy Hatcher, Joseph Pecoraro, and Andreas Kling.

No new tests yet, as they rely on infrastructure tracked in https://webkit.org/b/129190.

Replayable executions are organized into ReplaySessions, which can
contain several ReplaySessionSegments that divide overall execution
at main frame navigation boundaries. NondeterministicInput subclasses
are stored in SegmentedInputStorage according to the input's InputQueue.

Capture and playback are controlled at the page granularity by the Page's
ReplayController. The controller knows how to create new segments, replay to
arbitrary positions in the ReplaySession, and track the active InputCursor.

The capturing and replaying input cursor subclasses encapsulate state for
storing new inputs and loading/dispatching saved inputs, respectively.

The ReplayAgent and associated inspector protocol domain is the friendly
public API for programmatically capturing and replaying sessions.

  • DerivedSources.make: Add replay inputs code generation target. Add the

replay domain specification to the list of inspector domains.

  • ForwardingHeaders/replay/EncodedValue.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Add many files, and export

WebReplayScripts environment variable to DerivedSources.make.

  • inspector/InspectorController.cpp: Add the replay agent.

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorInstrumentation.cpp:

Add events for segment lifecycle events, and loading/unloading of sessions
and segments, and capture/replay progress events. The replay controller
also needs to know about detached and committed frames.

(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::sessionCreatedImpl):
(WebCore::InspectorInstrumentation::sessionLoadedImpl):
(WebCore::InspectorInstrumentation::sessionModifiedImpl):
(WebCore::InspectorInstrumentation::segmentCreatedImpl):
(WebCore::InspectorInstrumentation::segmentCompletedImpl):
(WebCore::InspectorInstrumentation::segmentLoadedImpl):
(WebCore::InspectorInstrumentation::segmentUnloadedImpl):
(WebCore::InspectorInstrumentation::captureStartedImpl):
(WebCore::InspectorInstrumentation::captureStoppedImpl):
(WebCore::InspectorInstrumentation::playbackStartedImpl):
(WebCore::InspectorInstrumentation::playbackPausedImpl):
(WebCore::InspectorInstrumentation::playbackHitPositionImpl):
(WebCore::InspectorInstrumentation::replayAgentEnabled):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::replayAgentEnabled):
(WebCore::InspectorInstrumentation::sessionCreated):
(WebCore::InspectorInstrumentation::sessionLoaded):
(WebCore::InspectorInstrumentation::sessionModified):
(WebCore::InspectorInstrumentation::segmentCreated):
(WebCore::InspectorInstrumentation::segmentCompleted):
(WebCore::InspectorInstrumentation::segmentLoaded):
(WebCore::InspectorInstrumentation::segmentUnloaded):
(WebCore::InspectorInstrumentation::captureStarted):
(WebCore::InspectorInstrumentation::captureStopped):
(WebCore::InspectorInstrumentation::playbackStarted):
(WebCore::InspectorInstrumentation::playbackPaused):
(WebCore::InspectorInstrumentation::playbackHitPosition):

  • inspector/InspectorReplayAgent.cpp: Added.

(WebCore::buildInspectorObjectForPosition):
(WebCore::buildInspectorObjectForInput):
(WebCore::buildInspectorObjectForSession):
(WebCore::SerializeInputToJSONFunctor::SerializeInputToJSONFunctor):
(WebCore::SerializeInputToJSONFunctor::~SerializeInputToJSONFunctor):
(WebCore::SerializeInputToJSONFunctor::operator()):
(WebCore::SerializeInputToJSONFunctor::returnValue):
(WebCore::buildInspectorObjectForSegment):
(WebCore::InspectorReplayAgent::InspectorReplayAgent):
(WebCore::InspectorReplayAgent::~InspectorReplayAgent):
(WebCore::InspectorReplayAgent::sessionState):
(WebCore::InspectorReplayAgent::didCreateFrontendAndBackend):
(WebCore::InspectorReplayAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorReplayAgent::frameNavigated):
(WebCore::InspectorReplayAgent::frameDetached):
(WebCore::InspectorReplayAgent::sessionCreated):
(WebCore::InspectorReplayAgent::sessionModified):
(WebCore::InspectorReplayAgent::sessionLoaded):
(WebCore::InspectorReplayAgent::segmentCreated):
(WebCore::InspectorReplayAgent::segmentCompleted):
(WebCore::InspectorReplayAgent::segmentLoaded):
(WebCore::InspectorReplayAgent::segmentUnloaded):
(WebCore::InspectorReplayAgent::captureStarted):
(WebCore::InspectorReplayAgent::captureStopped):
(WebCore::InspectorReplayAgent::playbackStarted):
(WebCore::InspectorReplayAgent::playbackPaused):
(WebCore::InspectorReplayAgent::playbackHitPosition):
(WebCore::InspectorReplayAgent::startCapturing):
(WebCore::InspectorReplayAgent::stopCapturing):
(WebCore::InspectorReplayAgent::replayToPosition):
(WebCore::InspectorReplayAgent::replayToCompletion):
(WebCore::InspectorReplayAgent::pausePlayback):
(WebCore::InspectorReplayAgent::cancelPlayback):
(WebCore::InspectorReplayAgent::switchSession):
(WebCore::InspectorReplayAgent::insertSessionSegment):
(WebCore::InspectorReplayAgent::removeSessionSegment):
Provide a public API for modifying sessions. This is the backend support
for user editing of replay sessions to add/remove specific segments.

(WebCore::InspectorReplayAgent::findSession):
(WebCore::InspectorReplayAgent::findSegment):
(WebCore::InspectorReplayAgent::getAvailableSessions):
(WebCore::InspectorReplayAgent::getSerializedSession):
(WebCore::InspectorReplayAgent::getSerializedSegment):
Most of the replay protocol domain speaks in terms of sesssion and
segment identifiers. These functions return the actual data associated
with these identifiers.

  • inspector/InspectorReplayAgent.h: Added.
  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorReplayAgent): Added.
(WebCore::InstrumentingAgents::setInspectorReplayAgent): Added.

  • inspector/protocol/Replay.json: Added.
  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::replayController): Added.

  • platform/Logging.h: Add WebReplay logging channel.
  • replay/AllReplayInputs.h: Added. Simplifies importing all input definitions.
  • replay/CapturingInputCursor.cpp: Added.

(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::~CapturingInputCursor):
(WebCore::CapturingInputCursor::create):
(WebCore::CapturingInputCursor::storeInput):
(WebCore::CapturingInputCursor::loadInput):
(WebCore::CapturingInputCursor::uncheckedLoadInput):

  • replay/CapturingInputCursor.h: Added.
  • replay/EventLoopInput.h:

(WebCore::EventLoopInputBase::EventLoopInputBase):
(WebCore::EventLoopInputBase::timestamp):
(WebCore::EventLoopInputBase::setTimestamp): Support deserialization.

  • replay/EventLoopInputDispatcher.cpp: Added. This class encapsulates the timers

and measurements used to dispatch event loop inputs during replay.

(WebCore::EventLoopInputDispatcher::EventLoopInputDispatcher):
(WebCore::EventLoopInputDispatcher::run):
(WebCore::EventLoopInputDispatcher::pause):
(WebCore::EventLoopInputDispatcher::timerFired):
(WebCore::EventLoopInputDispatcher::dispatchInputSoon):
(WebCore::EventLoopInputDispatcher::dispatchInput):

  • replay/EventLoopInputDispatcher.h: Added.

(WebCore::EventLoopInputDispatcherClient::EventLoopInputDispatcherClient):
(WebCore::EventLoopInputDispatcherClient::~EventLoopInputDispatcherClient):

  • replay/FunctorInputCursor.h: Added.

(WebCore::FunctorInputCursor::~FunctorInputCursor):
(WebCore::FunctorInputCursor::forEachInputInQueue):
(WebCore::FunctorInputCursor::FunctorInputCursor):
(WebCore::FunctorInputCursor::storeInput):
(WebCore::FunctorInputCursor::loadInput):
(WebCore::FunctorInputCursor::uncheckedLoadInput):

  • replay/ReplayController.cpp: Added.

(WebCore::ReplayController::ReplayController):
(WebCore::ReplayController::switchSession):
(WebCore::ReplayController::createSegment):
(WebCore::ReplayController::completeSegment):
(WebCore::ReplayController::loadSegment):
(WebCore::ReplayController::unloadSegment):
(WebCore::ReplayController::startCapturing):
(WebCore::ReplayController::stopCapturing):
(WebCore::ReplayController::startPlayback):
(WebCore::ReplayController::pausePlayback):
(WebCore::ReplayController::cancelPlayback):
(WebCore::ReplayController::replayToPosition):
(WebCore::ReplayController::frameDetached):
(WebCore::ReplayController::frameNavigated):
(WebCore::ReplayController::loadedSession):
(WebCore::ReplayController::loadedSegment):
(WebCore::ReplayController::activeInputCursor):
(WebCore::ReplayController::dispatcher):
(WebCore::ReplayController::willDispatchInput):
(WebCore::ReplayController::didDispatchInput):
(WebCore::ReplayController::didDispatchFinalInput):

  • replay/ReplayController.h: Added.

(WebCore::ReplayPosition::ReplayPosition):
(WebCore::ReplayPosition::operator<):
(WebCore::ReplayPosition::operator==):

  • replay/ReplayInputCreationMethods.cpp: Added.

Static factory implementations for inputs belong here.
(WebCore::InitialNavigation::createFromPage):

  • replay/ReplayInputDispatchMethods.cpp: Added.

All dispatch() implementations for generated replay inputs belong here.
(WebCore::BeginSegmentSentinel::dispatch):
(WebCore::EndSegmentSentinel::dispatch):
(WebCore::InitialNavigation::dispatch):

  • replay/ReplayInputTypes.cpp:

(WebCore::ReplayInputTypes::ReplayInputTypes):

  • replay/ReplayInputTypes.h: Define strings for WebCore inputs.
  • replay/ReplaySession.cpp: Added.

(WebCore::ReplaySession::create):
(WebCore::ReplaySession::ReplaySession):
(WebCore::ReplaySession::~ReplaySession):
(WebCore::ReplaySession::appendSegment):
(WebCore::ReplaySession::insertSegment):
(WebCore::ReplaySession::removeSegment):

  • replay/ReplaySession.h: Added.

(WebCore::ReplaySession::identifier):
(WebCore::ReplaySession::timestamp):
(WebCore::ReplaySession::size):
(WebCore::ReplaySession::at):
(WebCore::ReplaySession::begin):
(WebCore::ReplaySession::end):

  • replay/ReplaySessionSegment.cpp: Added.

(WebCore::ReplaySessionSegment::create):
(WebCore::ReplaySessionSegment::ReplaySessionSegment):
(WebCore::ReplaySessionSegment::~ReplaySessionSegment):
(WebCore::ReplaySessionSegment::createCapturingCursor):
(WebCore::ReplaySessionSegment::createReplayingCursor):
(WebCore::ReplaySessionSegment::createFunctorCursor):

  • replay/ReplaySessionSegment.h: Added.

(WebCore::ReplaySessionSegment::identifier):
(WebCore::ReplaySessionSegment::timestamp):

  • replay/ReplayingInputCursor.cpp: Added.

(WebCore::ReplayingInputCursor::ReplayingInputCursor):
(WebCore::ReplayingInputCursor::~ReplayingInputCursor):
(WebCore::ReplayingInputCursor::create):
(WebCore::ReplayingInputCursor::storeInput):
(WebCore::ReplayingInputCursor::loadInput):
(WebCore::ReplayingInputCursor::uncheckedLoadInput):

  • replay/ReplayingInputCursor.h: Added.
  • replay/SegmentedInputStorage.cpp: Added.

(WebCore::queueTypeToLogPrefix):
(WebCore::jsonStringForInput):
(WebCore::offsetForInputQueue):
(WebCore::SegmentedInputStorage::SegmentedInputStorage):
(WebCore::SegmentedInputStorage::~SegmentedInputStorage):
(WebCore::SegmentedInputStorage::load):
(WebCore::SegmentedInputStorage::store):
(WebCore::SegmentedInputStorage::queueSize):

  • replay/SegmentedInputStorage.h: Added.
  • replay/SerializationMethods.cpp: Added.

Specializations of EncodingTraits for WebCore types belong here.

(JSC::EncodingTraits<NondeterministicInputBase>::encodeValue):
(JSC::EncodingTraits<NondeterministicInputBase>::decodeValue):
(JSC::EncodingTraits<SecurityOrigin>::encodeValue):
(JSC::EncodingTraits<SecurityOrigin>::decodeValue):
(JSC::EncodingTraits<URL>::encodeValue):
(JSC::EncodingTraits<URL>::decodeValue):

  • replay/SerializationMethods.h: Added.
  • replay/WebInputs.json: Added.

In this inital patch, we define BeginSegmentSentinel,
EndSegmentSentinel, and InitialNavigation inputs.

5:47 AM Changeset in webkit [164985] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.3.91

Tagging the WebKitGTK+ 2.3.91 release

4:59 AM Changeset in webkit [164984] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.3.91 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.3.91.
3:57 AM Changeset in webkit [164983] by graouts@webkit.org
  • 5 edits in trunk/Source/WebCore

Respect SVG fragment identifiers in <img> src attribute
https://bugs.webkit.org/show_bug.cgi?id=129387

Reviewed by Dirk Schulze.

Following Dirk Schulze's suggestion, we set the URL on the SVGImage itself and handle the URL's
fragment identifier at draw time in the SVGImage itself, which will provide a sounder base for
handling of fragment identifier in SVG resource URLs in CSS properties, and should also deal
with the crasher reported in http://webkit.org/b/129498 since there is a guaranteed Frame at the
time we call SVGImage::draw().

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.cpp:
  • svg/graphics/SVGImageForContainer.h:
2:32 AM Changeset in webkit [164982] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r164980 - [GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
https://bugs.webkit.org/show_bug.cgi?id=129145

Patch by Tomas Popela <tpopela@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.

While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

2:32 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
2:17 AM Changeset in webkit [164981] by lvidacs.u-szeged@partner.samsung.com
  • 4 edits in trunk/Source/WebCore

Move function calls outside loop in dom
https://bugs.webkit.org/show_bug.cgi?id=126525

Reviewed by Csaba Osztrogonác.

Store the result of length() in a local variable and use it in each iteration.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::isXMLMIMEType):

  • dom/ElementData.cpp:

(WebCore::UniqueElementData::UniqueElementData):

  • dom/EventContext.cpp:

(WebCore::TouchEventContext::checkReachability):

2:16 AM Changeset in webkit [164980] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] webkit_dom_range_compare_boundary_points fails when 0 is passed as how parameter
https://bugs.webkit.org/show_bug.cgi?id=129145

Patch by Tomas Popela <tpopela@redhat.com> on 2014-03-03
Reviewed by Carlos Garcia Campos.

While generating GObject DOM API the generator should skip non pointer
types while generating the g_return_val_if_fail macro.
This will avoid the situation when Range.START_TO_START is defined as 0,
thus the webkit_dom_range_compare_boundary_points function will fail
everytime it is called with 0 as how value.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

2:15 AM Changeset in webkit [164979] by commit-queue@webkit.org
  • 4 edits in trunk

[cmake] *Names.cpp file should be regenerated after touching StaticString.pm
https://bugs.webkit.org/show_bug.cgi?id=129031

Patch by Jozsef Berta <jberta.u-szeged@partner.samsung.com> on 2014-03-03
Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/WebKitMacros.cmake: Added a call for make_names.pm dependencies in GENERATE_FONT_NAMES and GENERATE_DOM_NAMES macros.

Source/WebCore:

  • CMakeLists.txt: Added make_names.pl dependencies: bindings/scripts/Hasher.pm and bindings/scripts/StaticString.pm
1:07 AM Changeset in webkit [164978] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Revert r159999 - "Correct broken build on efl port with --no-netscape-plugin-api"

This reverts commit r159999.

12:43 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
12:36 AM Changeset in webkit [164977] by calvaris@igalia.com
  • 4 edits in trunk/Source/WebCore

[GTK] Multimedia controls captions icon needs its own metaphor
https://bugs.webkit.org/show_bug.cgi?id=129091

Reviewed by Martin Robinson.

As we got the new icon created, we used it with a fallback to the
old icon to keep run-time compatibility.

No new tests, current ones suffice.

  • platform/gtk/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaToggleClosedCaptionsButton):
Replicated RenderThemeGtk::paintMediaButton to check for the
necessary icon first and do the fallback to the old and stock
icons.

  • platform/gtk/RenderThemeGtk2.cpp:

(WebCore::getStockIconForWidgetType): Added ASSERT for non-empty
icon name.
(WebCore::getStockSymbolicIconForWidgetType): Check for non empty
icon name before calling getStockIconForWidgetType. Fixed coding
style.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::getStockIconForWidgetType): Added ASSERT for non-empty
icon name.
(WebCore::getStockSymbolicIconForWidgetType): Check for non empty
icon name before calling getStockIconForWidgetType. Fixed coding
style.

12:24 AM Changeset in webkit [164976] by Carlos Garcia Campos
  • 4 edits
    1 add in releases/WebKitGTK/webkit-2.4

Merge r164973 - [GTK] WebKit2WebExtension GIR can't be used in vala
https://bugs.webkit.org/show_bug.cgi?id=127179

Reviewed by Martin Robinson.

Add a different pkg-config file for the web extensions API.

.:

  • configure.ac:

Source/WebKit2:

  • GNUmakefile.am:
  • webkit2gtk-web-extension.pc.in: Added.
12:22 AM Changeset in webkit [164975] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164940 - [GTK] Make impossible to build with <webkit2/webkit2.h> and <webkit2/webkit-web-extension.h> included together
https://bugs.webkit.org/show_bug.cgi?id=129549

Reviewed by Martin Robinson.

Add a compile error to prevent mixing the UI and web process APIs.

  • UIProcess/API/gtk/webkit2.h:
  • WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
12:21 AM Changeset in webkit [164974] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r164939 - [GTK] Remove the include dir of the C API from the WebKit2 pkg-config file
https://bugs.webkit.org/show_bug.cgi?id=129543

Reviewed by Martin Robinson.

We are not installing the C API headers anymore.

  • webkit2gtk.pc.in:
12:07 AM Changeset in webkit [164973] by Carlos Garcia Campos
  • 6 edits
    1 add in trunk

[GTK] WebKit2WebExtension GIR can't be used in vala
https://bugs.webkit.org/show_bug.cgi?id=127179

Reviewed by Martin Robinson.

Add a different pkg-config file for the web extensions API.

.:

  • Source/cmake/OptionsGTK.cmake:
  • configure.ac:

Source/WebKit2:

  • GNUmakefile.am:
  • PlatformGTK.cmake:
  • webkit2gtk-web-extension.pc.in: Added.

Mar 2, 2014:

11:10 PM Changeset in webkit [164972] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a fallback path for compiling the remaining attribute checkers
https://bugs.webkit.org/show_bug.cgi?id=129580

Reviewed by Darin Adler.

The remaining attribute checkers appear to be less common than the simple value match.
This patch adds them to SelectorCompiler for completeness but no attempt is made at optimizing them,
they all default to function calls.

If the assumption that those selectors are not common turn out to be incorrect, we should see
the function calls in profiles and optimize them as needed.

  • css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):
If we get anything but attribute match here, something has gone horribly wrong. Update the code
to fail if that were to happen.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
Add the missing match type to the selector fragment.

Begin, End, Contain cannot match an empty value per specification. We can test that at compile time
and fail immediately. See http://www.w3.org/TR/css3-selectors/#attribute-substrings

List has the extra requirement that a value containing a space does not match anything. It also cannot
match with an empty string. See http://www.w3.org/TR/css3-selectors/#attribute-representation

(WebCore::SelectorCompiler::attributeValueBeginsWith):
(WebCore::SelectorCompiler::attributeValueContains):
(WebCore::SelectorCompiler::attributeValueEndsWith):
(WebCore::SelectorCompiler::attributeValueMatchHyphenRule):
(WebCore::SelectorCompiler::attributeValueSpaceSeparetedListContains):
The slow fallbacks.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
A generic code generator making function call to match an attribute value.

10:01 PM Changeset in webkit [164971] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

PolymorphicPutByIdList should have a simpler construction API with basically a single entrypoint
https://bugs.webkit.org/show_bug.cgi?id=129591

Reviewed by Michael Saboff.

  • bytecode/PolymorphicPutByIdList.cpp:

(JSC::PutByIdAccess::fromStructureStubInfo): This function can figure out the slow path target for itself.
(JSC::PolymorphicPutByIdList::PolymorphicPutByIdList): This constuctor should be private, only from() should call it.
(JSC::PolymorphicPutByIdList::from):

  • bytecode/PolymorphicPutByIdList.h:

(JSC::PutByIdAccess::stubRoutine):

  • jit/Repatch.cpp:

(JSC::tryBuildPutByIdList): Don't pass the slow path target since it can be derived from the stubInfo.

9:42 PM Changeset in webkit [164970] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Debugging improvements from my gbemu investigation session
https://bugs.webkit.org/show_bug.cgi?id=129599

Reviewed by Mark Lam.

Various improvements from when I was investigating bug 129411.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor): Make the dataLog() statement print the actual multiplier.

  • jsc.cpp:

(GlobalObject::finishCreation):
(functionDescribe): Make describe() return a string rather than printing the string.
(functionDescribeArray): Like describe(), but prints details about arrays.

9:33 PM Changeset in webkit [164969] by akling@apple.com
  • 2 edits in trunk/Source/WebKit

Blind Windows build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Tweak JSDOMWindowBase::commonVM() return type to be a reference.

9:10 PM Changeset in webkit [164968] by akling@apple.com
  • 45 edits in trunk/Source

JSDOMWindow::commonVM() should return a reference.
<https://webkit.org/b/129293>

Source/JavaScriptCore:

Added a DropAllLocks constructor that takes VM& without null checks.

Reviewed by Geoff Garen.

Source/WebCore:

Since this function always returns a VM and never null, make it
return a reference instead. There are more VM getters that never
return null, but I tried to keep the patch from snowballing.

Reviewed by Geoff Garen.

8:49 PM Changeset in webkit [164967] by timothy@apple.com
  • 5 edits in trunk

Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.

Adding the ASSERT back is tracked by https://webkit.org/b/129593.

https://bugs.webkit.org/show_bug.cgi?id=129328

Reviewed by Sam Weinig.

Source/WebCore:

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::~IDBRequest):

LayoutTests:

  • TestExpectations: Remove skipped tests.
  • inspector-protocol/model/probe-manager-add-remove-actions-expected.txt: Rebaselined.
7:42 PM Changeset in webkit [164966] by BJ Burg
  • 4 edits in trunk

Web Inspector model tests load wrong inspector page under WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=129460

Reviewed by Dan Bernstein.

Tools:

Don't unconditionally open the inspector before running an inspector test.
Instead, the test should request that the inspector open when it's ready.

This change was lost during a rebase, but is the same change made to
DumpRenderTree.

  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

LayoutTests:

Stop skipping inspector/test-harness-trivially-works.html.

  • platform/wk2/TestExpectations:
7:24 PM Changeset in webkit [164965] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r164961.
http://trac.webkit.org/changeset/164961
https://bugs.webkit.org/show_bug.cgi?id=129596

Caused many assertion failures (Requested by ap on #webkit).

  • css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):

6:30 PM Changeset in webkit [164964] by Darin Adler
  • 33 edits in trunk/Source

Streamline use of TextIterator, cutting down includes and use of soon-to-be-deleted functions
https://bugs.webkit.org/show_bug.cgi?id=129592

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in: Re-sorted this file. Not sure how it got unsorted.
  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::stringForVisiblePositionRange): Call TextIterator::text
instead of TextIterator::length. Also removed unneeded special case for empty string
and exception code.
(WebCore::AccessibilityObject::lengthForVisiblePositionRange): Ditto.

  • accessibility/AccessibilityObject.h: Include TextIteratorBehavior.h instead of

TextIterator.h.

  • accessibility/AccessibilityRenderObject.cpp: Include TextIterator.h.
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm: Removed unneeded

TextIterator.h include.

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]): Call
TextIterator::text instead of TextIterator::length.

  • dom/Element.cpp: Include TextIterator.h.
  • dom/Node.cpp: Include Range.h.
  • dom/Position.cpp:

(WebCore::Position::isCandidate): Cast to RenderBlockFlow since that's what the
type check above does. Use a return statement instead of an else for better flow.
(WebCore::Position::leadingWhitespacePosition): Call
deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).
(WebCore::Position::trailingWhitespacePosition): Ditto.

  • dom/Range.cpp:

(WebCore::Range::firstNode): Added a FIXME about code that clearly does not
belong. This is something we really need to fix.

  • editing/AlternativeTextController.cpp: Include TextIterator.h.
  • editing/ApplyStyleCommand.cpp: Ditto.
  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit): Call
deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).

  • editing/Editor.h: Include TextIteratorBehavior.h instead of TextIterator.h.
  • editing/HTMLInterchange.cpp:

(WebCore::convertHTMLTextToInterchangeFormat): Call
deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).

  • editing/SpellingCorrectionCommand.cpp: Include TextIterator.h.
  • editing/TextIterator.h: Moved isCollapsibleWhitespace from here into

htmlediting.h and renamed it deprecatedIsCollapsibleWhitespace.

  • editing/TextIterator.cpp: Call

deprecatedIsCollapsibleWhitespace by its new name (newly deprecated).

  • editing/TypingCommand.cpp: Include TextIterator.h.
  • editing/VisibleUnits.cpp:

(WebCore::previousBoundary): Call TextIterator::text instead of
TextIterator::length.
(WebCore::nextBoundary): Ditto.

  • editing/htmlediting.cpp: Include TextIterator.h.
  • editing/htmlediting.h: Removed non-helpful section comments.

Added FIXME about isWhitespace. Added deprecatedIsCollapsibleWhitespace,
formerly not deprecated and in TextIterator.h.

  • editing/markup.cpp: Include TextIterator.h.
  • html/HTMLTextAreaElement.cpp: Include TextIterator.h.
  • page/ContextMenuController.cpp:

(WebCore::selectionContainsPossibleWord): Call TextIterator::text
instead of TextIterator::length and TextIterator::characterAt.

  • page/EventHandler.cpp: Sorted conditional includes alphabetically by condition.
  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]): Call TextIterator::text
instead of TextIterator::length.

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp: Added now-needed include.

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp: Added now-needed include.
  • WebProcess/WebPage/WebPage.cpp: Ditto.
6:27 PM Debugging With Xcode edited by BJ Burg
WKTR debugging tips (diff)
6:22 PM Debugging With Xcode edited by BJ Burg
(diff)
6:20 PM Debugging With LLDB or GDB edited by BJ Burg
(diff)
6:15 PM Debugging With Xcode created by BJ Burg
6:11 PM Debugging With LLDB or GDB created by BJ Burg
6:07 PM Changeset in webkit [164963] by enrica@apple.com
  • 7 edits in trunk/Source/WebKit2

[iOS WebKit2] Keyboard deadlock when accepting/dismissing autocorrection.
https://bugs.webkit.org/show_bug.cgi?id=129594
<rdar://problem/16168978>

Reviewed by Sam Weinig.

As a temporary fix, we are using a synchronous
message to accept autocorrection until we implement
a solution that processes these requests on a thread that
is not the main thread.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView applyAutocorrection:toString:withCompletionHandler:]):
(-[WKContentView requestAutocorrectionContextWithCompletionHandler:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applyAutocorrection):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applyAutocorrection):
(WebKit::WebPage::syncApplyAutocorrection):

6:05 PM WikiStart edited by BJ Burg
(diff)
6:03 PM WikiStart edited by BJ Burg
Simplify the different platform debugging page links (diff)
6:00 PM Changeset in webkit [164962] by ljaehun.lim@samsung.com
  • 3 edits in trunk/Source/WTF

[EFL] Remove m_initEfl from RunLoop.
https://bugs.webkit.org/show_bug.cgi?id=129568

Reviewed by Gyuyoung Kim.

We don't use m_initEfl except RunLoop constructor.

  • wtf/RunLoop.h:
  • wtf/efl/RunLoopEfl.cpp:

(WTF::RunLoop::RunLoop):

5:56 PM Debugging With Visual Studio edited by BJ Burg
merge WK2 instructions (diff)
5:52 PM WikiStart edited by BJ Burg
(diff)
5:52 PM Debugging With Visual Studio edited by BJ Burg
Fold in details from separate page about DumpRenderTree + VS (diff)
5:48 PM Changeset in webkit [164961] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Add a fallback path for compiling the remaining attribute checkers
https://bugs.webkit.org/show_bug.cgi?id=129580

Reviewed by Darin Adler.

The remaining attribute checkers appear to be less common than the simple value match.
This patch adds them to SelectorCompiler for completeness but no attempt is made at optimizing them,
they all default to function calls.

If the assumption that those selectors are not common turn out to be incorrect, we should see
the function calls in profiles and optimize them as needed.

  • css/SelectorChecker.cpp:

(WebCore::attributeValueMatches):
If we get anything but attribute match here, something has gone horribly wrong. Update the code
to fail if that were to happen.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
Add the missing match type to the selector fragment.

Begin, End, Contain cannot match an empty value per specification. We can test that at compile time
and fail immediately. See http://www.w3.org/TR/css3-selectors/#attribute-substrings

List has the extra requirement that a value containing a space does not match anything. It also cannot
match with an empty string. See http://www.w3.org/TR/css3-selectors/#attribute-representation

(WebCore::SelectorCompiler::attributeValueBeginsWith):
(WebCore::SelectorCompiler::attributeValueContains):
(WebCore::SelectorCompiler::attributeValueEndsWith):
(WebCore::SelectorCompiler::attributeValueMatchHyphenRule):
(WebCore::SelectorCompiler::attributeValueSpaceSeparetedListContains):
The slow fallbacks.

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
A generic code generator making function call to match an attribute value.

5:44 PM Debugging With Visual Studio edited by BJ Burg
restructure sections into wk1/wk2/test runners/misc. (diff)
5:37 PM Changeset in webkit [164960] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Fix build for case-sensitive file systems.

  • platform/UserActivity.h: Runloop -> RunLoop.
5:24 PM Changeset in webkit [164959] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

HysteresisTimer should use WebCore::Timer
https://bugs.webkit.org/show_bug.cgi?id=129587

Reviewed by Sam Weinig.

  • platform/HysteresisActivity.h:

(WebCore::HysteresisActivity::HysteresisActivity):
(WebCore::HysteresisActivity::hysteresisTimerFired):

  • RunLoop::Timer -> WebCore::Timer.
  • platform/UserActivity.h:
5:16 PM Changeset in webkit [164958] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(adjustedFontSize):

5:02 PM Changeset in webkit [164957] by Darin Adler
  • 10 edits
    1 add in trunk

Split TextIteratorBehavior into a separate header
https://bugs.webkit.org/show_bug.cgi?id=129578

Reviewed by Sam Weinig.

Source/WebCore:

This is in preparation to greatly cut down on includes of TextIterator.h.

  • GNUmakefile.list.am: Added new header.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • editing/FindOptions.h: Changed typedef to unsigned char;

there is no reason to store these in a 32-bit integer.

  • editing/TextIterator.h: Added include of TextIteratorBehavior.h

and moved comments about the meanings of flag bits to their definition.

  • editing/TextIteratorBehavior.h: Added.
  • WebCore.exp.in: Updated for type changes.

Tools:

  • Scripts/sort-export-file: Added special cases to the script so you can just paste link errors

from WebKit in and the script will add them in as unconditional exports. This makes the "add"
task easy, but the remove is still a bit of a pain.

4:30 PM Changeset in webkit [164956] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Page Cache is not enabled when using the modern WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=129585

Reviewed by Dan Bernstein.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool initWithConfiguration:]):
Default to CacheModelPrimaryWebBrowser until there is a way to configure it.

4:19 PM Changeset in webkit [164955] by enrica@apple.com
  • 17 edits
    3 adds in trunk/Source

[iOS WebKit2] Form controls handling
https://bugs.webkit.org/show_bug.cgi?id=129344
<rdar://problem/16053643>

Reviewed by Simon Fraser.

Source/WebCore:

Updates localizable strings and adds some exports.

  • English.lproj/Localizable.strings:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Adding support for select elements on iOS.
There is full support on iPad, while on iPhone it is
still limited to single select with no groups.
The change also fixes the issue of the keyboard appearing
on screen for types of elements that are implemented with
a popover or a picker.

  • Scripts/webkit2/messages.py:
  • Shared/AssistedNodeInformation.cpp:

(WebKit::WKOptionItem::encode):
(WebKit::WKOptionItem::decode):
(WebKit::AssistedNodeInformation::encode):
(WebKit::AssistedNodeInformation::decode):

  • Shared/AssistedNodeInformation.h:

(WebKit::WKOptionItem::WKOptionItem):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView inputView]):
(-[WKContentView assistedNodeSelectOptions]):
(-[WKContentView _startAssistingNode:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setAssistedNodeSelectedIndex):

  • UIProcess/ios/forms/WKFormSelectControl.h:
  • UIProcess/ios/forms/WKFormSelectControl.mm: Added.

(-[WKFormSelectControl initWithView:]):
(+[WKFormSelectControl createPeripheralWithView:]):
(-[WKFormSelectControl assistantView]):
(-[WKFormSelectControl beginEditing]):
(-[WKFormSelectControl endEditing]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm: Added.

(-[WKSelectSinglePicker initWithView:]):
(-[WKSelectSinglePicker dealloc]):
(-[WKSelectSinglePicker controlView]):
(-[WKSelectSinglePicker controlBeginEditing]):
(-[WKSelectSinglePicker controlEndEditing]):
(-[WKSelectSinglePicker numberOfComponentsInPickerView:]):
(stringByTrimmingWhitespaceAndNewlines):
(-[WKSelectSinglePicker pickerView:numberOfRowsInComponent:]):
(-[WKSelectSinglePicker pickerView:attributedTitleForRow:forComponent:]):
(-[WKSelectSinglePicker pickerView:didSelectRow:inComponent:]):

  • UIProcess/ios/forms/WKFormSelectPopover.mm: Added.

(stringWithWritingDirection):
(adjustedFontSize):
(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController viewWillAppear:]):
(-[WKSelectTableViewController numberOfSectionsInTableView:]):
(-[WKSelectTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectTableViewController populateCell:withItem:]):
(-[WKSelectTableViewController findItemIndexAt:]):
(-[WKSelectTableViewController findItemAt:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]):
(-[WKSelectTableViewController hasText]):
(-[WKSelectTableViewController insertText:]):
(-[WKSelectTableViewController deleteBackward]):
(-[WKSelectPopover initWithView:hasGroups:]):
(-[WKSelectPopover dealloc]):
(-[WKSelectPopover controlView]):
(-[WKSelectPopover controlBeginEditing]):
(-[WKSelectPopover controlEndEditing]):
(-[WKSelectPopover _userActionDismissedPopover:]):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::innerFrameQuad):
(WebKit::WebPage::getPositionInformation):
(WebKit::hasFocusableNode):
(WebKit::WebPage::getAssistedNodeInformation):
(WebKit::WebPage::elementDidFocus):

4:03 PM Changeset in webkit [164954] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock::hasDebuggerRequests() should returning a bool instead of an int.
<https://webkit.org/b/129584>

Reviewed by Darin Adler.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::hasDebuggerRequests):

3:14 PM Changeset in webkit [164953] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Clean up use of Options::enableConcurrentJIT().
<https://webkit.org/b/129582>

Reviewed by Filip Pizlo.

DFG Driver was conditionally checking Options::enableConcurrentJIT()
only if ENABLE(CONCURRENT_JIT). Otherwise, it bypasses it with a local
enableConcurrentJIT set to false.

Instead we should configure Options::enableConcurrentJIT() to be false
in Options.cpp if !ENABLE(CONCURRENT_JIT), and DFG Driver should always
check Options::enableConcurrentJIT(). This makes the code read a little
cleaner.

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

3:13 PM Changeset in webkit [164952] by benjamin@webkit.org
  • 10 edits in trunk/Source

[iOS][WK2] Pages using tiled compositing layers allocate too many tiles on zoom
https://bugs.webkit.org/show_bug.cgi?id=129471

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-03-02
Reviewed by Simon Fraser.

Source/WebCore:

A few issues with TileController were causing sublayers of the root layers
to tile incorrect surfaces on zoom.

First, the exposedRect API was not updating the sublayers. The layers go correctly
into tiling mode, but the tiles cover the full document instead of the visible area.

The other major issue was the margins being applied to the coverage size in document
coordinates. Since each margin is 512px, the total coverage size after zoom was
gigantic.

To solve this, this patch switch from the exposedRect API to the generic concept
of VisibleExtentContentRect introduced for iOS WebKit1.

  • WebCore.exp.in:
  • platform/ScrollView.h:

Define a VisibleExtentContentRect on the scrollview itself when there is no
platformWidget().
The case with inside frame is untested due to stability issues :(.
(see <rdar://problem/16199219>)

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::computeTileCoverageRect):
Remove the margin from the tile coverage.

On iOS, m_tileCoverage is always zero at the moment. Previously, the tile coverage
was artificially extended by the margins. With the margins removed, I temporarily added
a factor of 1.5.
ViewUpdateDispatcher has all the information to compute a great tile coverage, I will need
a follow up patch to fix that.

  • platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::visibleExtentContentRect):
(WebCore::ScrollView::setVisibleExtentContentRect):

Source/WebKit2:

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):
A few interesting changes here:
-Now that we do not use setExposedRect, we can pass the exposed area directly

to the drawing area since everything is now in content coordinates :)

-The scale is now converted to float before being compared to the Page's scaleFactor.

The page's scalefactor being a float, the comparison was failing most of the time.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setVisibleExtentContentRect):

2:35 PM Changeset in webkit [164951] by Darin Adler
  • 5 edits
    1 add in trunk

Sort Mac platform export files so they merge better
https://bugs.webkit.org/show_bug.cgi?id=129581

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in: Ran the new sort-export-file on this.

Source/WebKit/mac:

  • WebKit.exp: Ran the new sort-export-file on this.

Tools:

  • Scripts/sort-export-file: Added. Quickly whipped together script that sorts

Mac export files in a "canonical" order for this project.

2:26 PM Changeset in webkit [164950] by dino@apple.com
  • 5 edits
    2 adds in trunk

Add protected casting to FilterOperation classes.
https://bugs.webkit.org/show_bug.cgi?id=124062

Reviewed by Sam Weinig.

Source/WebCore:

Use the type cast macro generators to produce some toFilterOperation-style
functions, and then use them in our PlatformCA filter code.

Test: css3/filters/animation-from-initial-values-with-color-matrix.html

  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Use the toFilterOperation methods, in

some cases removing the unnecessary double cast.
(PlatformCAFilters::filterValueForOperation):
(PlatformCAFilters::colorMatrixValueForFilter):

  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicColorMatrixFilterOperation::operator==): Move this to the .cpp file so it can use the casting methods.
(WebCore::BasicComponentTransferFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::operator==): Ditto.

  • platform/graphics/filters/FilterOperation.h: Add the casting macros.

LayoutTests:

  • css3/filters/animation-from-initial-values-with-color-matrix-expected.html: Added.
  • css3/filters/animation-from-initial-values-with-color-matrix.html: Added.
2:22 PM Changeset in webkit [164949] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Fix srcset related bugs
https://bugs.webkit.org/show_bug.cgi?id=129539

Source/WebCore:

Fixed a bug reported against Blink's srcset implementation at https://code.google.com/p/chromium/issues/detail?id=347998
When both src and srcset had only 1x descriptors and the DPR was higher than 1, the src's resource was picked.

Also fixed the invalid descriptor handling, which wasn't aligned with the spec, and therefore was not as forward compatible as it should be.
Invalid descriptors caused the entire resource to be ignored, rather than just the descriptors themselves.

Patch by Yoav Weiss <yoav@yoav.ws> on 2014-03-02
Reviewed by Andreas Kling.

Tests: fast/hidpi/image-srcset-invalid-descriptor.html

fast/hidpi/image-srcset-src-selection-1x-both.html

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseDescriptors):
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

These tests make sure that:

  1. Invalid srcset descriptors are handled according to the spec. The invalid descriptors are ignored, but the resource is not.
  2. When both src and srcset have only 1x descriptors and the DPR is higher than 1, the srcset's resource is picked.

I've also fixed the invalid inputs test, which was faulty.

Patch by Yoav Weiss <yoav@yoav.ws> on 2014-03-02
Reviewed by Andreas Kling.

  • fast/hidpi/image-srcset-invalid-descriptor-expected.txt: Added.
  • fast/hidpi/image-srcset-invalid-descriptor.html: Added.
  • fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
  • fast/hidpi/image-srcset-src-selection-1x-both-expected.txt: Added.
  • fast/hidpi/image-srcset-src-selection-1x-both.html: Added.
  • fast/hidpi/resources/srcset-helper.js:

(runTest):

12:44 PM Changeset in webkit [164948] by barraclough@apple.com
  • 11 edits
    1 copy in trunk/Source/WebCore

Split UserActivity, simplify PageThrottler
https://bugs.webkit.org/show_bug.cgi?id=129551

Reviewed by Darin Adler.

The class UserActivity currently implements two things – a hysteresis mechanism, and
an abstraction of NSActivity controlled by that mechanism. PageThrottler implements
its own hysteresis mechanism, which directly controls DOM timer throttling and also
controls a couple of UserActivities, giving a total of 3 separate hysteresis mechanisms,
layered two deep.

Split UserActivity into three, with HysteresisActivity implementing an abstract hysteresis
mechanism, UserActivity::Impl controlling the NSActivity, and then UserActivity combining
these two back together. The interface to UserActivity is unchanged.

Remove PageThrottler's bespoke hysteresis, replacing it with a use of HysteresisActivity.
Replace the two UserActivities with a single UserActivity::Impl, so there are no longer
layered hysteresis mechanisms.

  • WebCore.exp.in:
    • exports changed.
  • WebCore.xcodeproj/project.pbxproj:
    • added HysteresisActivity.h.
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

  • if the page starts visible, begin activity. If it starts hidden throttle DOM timers.

(WebCore::PageThrottler::hiddenPageDOMTimerThrottlingStateChanged):

  • when the DOM timer throttling setting changes, make sure we update.

(WebCore::PageThrottler::incrementActivityCount):
(WebCore::PageThrottler::decrementActivityCount):

  • when m_activityCount changes update the hysteresis state.

(WebCore::PageThrottler::updateHysteresis):
(WebCore::PageThrottler::setViewState):

  • when IsVisuallyIdle changes update the hysteresis state.

(WebCore::PageThrottler::started):
(WebCore::PageThrottler::stopped):

  • callbacks from HysteresisActivity, these control m_activity and DOM timer throttling.
  • page/PageThrottler.h:

(WebCore::PageThrottler::didReceiveUserInput):
(WebCore::PageThrottler::pluginDidEvaluate):

  • call impulse to temporarily enable the activity.
  • platform/HysteresisActivity.h: Copied from Source/WebCore/platform/UserActivity.h.

(WebCore::HysteresisActivity::HysteresisActivity):

  • constructor takes a delegate optionally a timeout.

(WebCore::HysteresisActivity::start):

  • start activity immediately. If stopped, call started method on delegate. If in timeout period, cancel the timer.

(WebCore::HysteresisActivity::stop):

  • stop activity after hysteresis. If started, initiate timeout period.

(WebCore::HysteresisActivity::impulse):

  • ensure activity for at least the timeout period.

(WebCore::HysteresisActivity::hysteresisTimerFired):

  • delayed stop - when the timer fires call stopped on the delegate.
  • platform/UserActivity.cpp:

(WebCore::UserActivity::Impl::Impl):
(WebCore::UserActivity::Impl::beginActivity):
(WebCore::UserActivity::Impl::endActivity):

  • nop implementation.

(WebCore::UserActivity::UserActivity):

  • UserActivity maintains existing interface with hysteresis.

(WebCore::UserActivity::started):
(WebCore::UserActivity::stopped):

  • callbacks from HysteresisTimer; forward to Impl.
  • platform/UserActivity.h:
  • platform/mac/UserActivityMac.mm:

(WebCore::UserActivity::Impl::Impl):

  • UserActivity::Impl, abstraction for NSActivity without added hysteresis.

(WebCore::UserActivity::Impl::beginActivity):

  • allocate NSActivity.

(WebCore::UserActivity::Impl::endActivity):

  • release NSActivity.
12:34 PM Changeset in webkit [164947] by BJ Burg
  • 5 edits in trunk/Source/WebCore

DocumentLoader should keep maps of ResourceLoaders instead of sets
https://bugs.webkit.org/show_bug.cgi?id=129388

Reviewed by Darin Adler.

For web replay, we need to be able to pull a ResourceLoader instance by
identifier from the DocumentLoader. This is easy to do if we convert
ResourceLoaderSet to ResourceLoaderMap, keyed by the loader's identifier.

Added assertions whenever adding or removing from the map to ensure
that we don't try to add duplicates or resources with zero identifiers.

No new tests required. No functionality was added.

  • loader/DocumentLoader.cpp:

(WebCore::cancelAll):
(WebCore::setAllDefersLoading):
(WebCore::areAllLoadersPageCacheAcceptable):
(WebCore::DocumentLoader::addSubresourceLoader):
(WebCore::DocumentLoader::removeSubresourceLoader):
(WebCore::DocumentLoader::addPlugInStreamLoader):
(WebCore::DocumentLoader::removePlugInStreamLoader):
(WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):

  • loader/DocumentLoader.h:
  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::create): Only add the loader
to the document loader's map if it initialized successfully.
The old code was probably leaking resource loaders that failed to
initialize.

  • loader/mac/DocumentLoaderMac.cpp:

(WebCore::scheduleAll):
(WebCore::unscheduleAll):

11:52 AM Changeset in webkit [164946] by krit@webkit.org
  • 9 edits in trunk/LayoutTests

Reactivate SVG mask-type tests for Mac
https://bugs.webkit.org/show_bug.cgi?id=129577

Reviewed by Darin Adler.

Reduce mask-type tests to the minimum to test the feature.

  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • svg/masking/mask-type-alpha-expected.svg:
  • svg/masking/mask-type-alpha.svg:
  • svg/masking/mask-type-luminance-expected.svg:
  • svg/masking/mask-type-luminance.svg:
  • svg/masking/mask-type-not-set-expected.svg:
  • svg/masking/mask-type-not-set.svg:
11:36 AM Changeset in webkit [164945] by Darin Adler
  • 6 edits in trunk/Source

Change public text iterator API implementations to not depend on 16-bit character pointers
https://bugs.webkit.org/show_bug.cgi?id=129566

Reviewed by Anders Carlsson.

Source/WebKit/mac:

  • WebView/WebTextIterator.mm:

(-[WebTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
(-[WebTextIterator advance]): Clear out the upconverted text since we are moving on to the
next text.
(-[WebTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
(-[WebTextIterator currentTextLength]): Call TextIterator::text().length() since we will
probably be removing TextIterator::length eventually.

Source/WebKit2:

  • WebView/WebTextIterator.mm:

(-[WKDOMTextIterator initWithRange:]): Use make_unique instead of adoptPtr.
(-[WKDOMTextIterator advance]): Clear out the upconverted text since we are moving on to the
next text.
(-[WKDOMTextIterator currentTextPointer]): Upconvert if we have 8-bit text.
(-[WKDOMTextIterator currentTextLength]): Call TextIterator::text().length() since we will
probably be removing TextIterator::length eventually.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp: Removed unneded include of TextIterator.h.
  • WebProcess/WebPage/WebPage.cpp: Ditto.
10:25 AM Changeset in webkit [164944] by krit@webkit.org
  • 5 edits in trunk/LayoutTests

Remove path to non-existent SVG clip-path test from TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=129574

Reviewed by Simon Fraser.

The test was transformed to a ref test and moved to a different location.
It passes on all platforms now.

  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
  • platform/wk2/TestExpectations:
9:55 AM Changeset in webkit [164943] by commit-queue@webkit.org
  • 8 edits in trunk

Support ENABLE_ENCRYPTED_MEDIA in cmake builds
https://bugs.webkit.org/show_bug.cgi?id=129575

Patch by Dirkjan Ochtman <d.ochtman@activevideo.com> on 2014-03-02
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsEfl.cmake:

Enabled ENABLE_ENCRYPTED_MEDIA{,_V2} usage.

  • Source/cmake/OptionsGTK.cmake:

Enabled ENABLE_ENCRYPTED_MEDIA{,_V2} usage.

  • Source/cmake/WebKitFeatures.cmake:

Enabled ENABLE_ENCRYPTED_MEDIA{,_V2} usage.

  • Source/cmakeconfig.h.cmake:

Added ENABLE_ENCRYPTED_MEDIA{,_V2} flags.

Source/WebCore:

No new tests, only fixes the build.

  • CMakeLists.txt:

Add support for ENABLE_ENCRYPTED_MEDIA.

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::close):
Assign nullptr instead of 0 to OwnPtr to appease gcc-4.7.

9:19 AM Changeset in webkit [164942] by Darin Adler
  • 6 edits in trunk/Source/WTF

Cut down use of OwnPtr within WTF itself
https://bugs.webkit.org/show_bug.cgi?id=129567

Reviewed by Sam Weinig.

  • wtf/RefCounted.h: Removed OwnPtr includes.
  • wtf/StreamBuffer.h: Removed OwnPtr includes and switched to use

std::make_unique and std::unique_ptr instead.

  • wtf/Threading.cpp: Removed OwnPtr includes.
  • wtf/ThreadingPthreads.cpp: Ditto.
  • wtf/Vector.h: Ditto.
7:36 AM Changeset in webkit [164941] by thiago.lacerda@openbossa.org
  • 7 edits
    1 delete in trunk/LayoutTests

Updating some WebRTC and MediaStream LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=129442

Reviewed by Eric Carlson.

Due to changes in JavaScriptCore (in r163562), some LayoutTests in fast/mediastream needed to be updated:

  • MediaStreamTrack.html: checking hasOwnProperty in proto as well, until CustomGetter properties are moved to the prototype chain.
  • RTCIceCandidate.html and RTCSessionDescription.html: JSON.stringify are not considering properties in proto, so remove this for now.
  • fast/mediastream/MediaStreamTrack-expected.txt:
  • fast/mediastream/MediaStreamTrack.html:
  • fast/mediastream/RTCIceCandidate-expected.txt:
  • fast/mediastream/RTCIceCandidate.html:
  • fast/mediastream/RTCPeerConnection-have-local-answer.html: Removed. Other tests already test what this one was

testing

  • fast/mediastream/RTCSessionDescription-expected.txt:
  • fast/mediastream/RTCSessionDescription.html:
6:59 AM Changeset in webkit [164940] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Make impossible to build with <webkit2/webkit2.h> and <webkit2/webkit-web-extension.h> included together
https://bugs.webkit.org/show_bug.cgi?id=129549

Reviewed by Martin Robinson.

Add a compile error to prevent mixing the UI and web process APIs.

  • UIProcess/API/gtk/webkit2.h:
  • WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
6:56 AM Changeset in webkit [164939] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Remove the include dir of the C API from the WebKit2 pkg-config file
https://bugs.webkit.org/show_bug.cgi?id=129543

Reviewed by Martin Robinson.

We are not installing the C API headers anymore.

  • webkit2gtk.pc.in:

Mar 1, 2014:

9:35 PM Changeset in webkit [164938] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the Mac build.

  • UIProcess/mac/ViewGestureController.messages.in:
9:25 PM Changeset in webkit [164937] by timothy_horton@apple.com
  • 20 edits
    3 adds in trunk/Source

WebKit2 View Gestures (Smart Magnification): Support for iOS
https://bugs.webkit.org/show_bug.cgi?id=129146
<rdar://problem/16032668>

Reviewed by Benjamin Poulain.

Add support for double-tap smart magnification on iOS.

  • DerivedSources.make:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
WKContentView is no longer API, so it can know about WKWebView
and will always have one.

(-[WKWebView contentView:didCommitLayerTree:WebKit::]):
Don't replace the zoom scale if we're currently animating.

(-[WKWebView _takeViewSnapshot]):
Rename.

(-[WKWebView _zoomToPoint:WebCore::atScale:]):
(-[WKWebView _zoomToRect:WebCore::atScale:origin:WebCore::]):
(constrainContentOffset):
(-[WKWebView _scrollToRect:WebCore::origin:WebCore::minimumScrollDistance:]):
(-[WKWebView _zoomOutWithOrigin:]):
(-[WKWebView _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
Add _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:
and _zoomOutWithOrigin: as internal API, for use by SmartMagnificationController via WKContentView.
These will use some heuristics to generally center the target rect in the view
in a way that should match WebKit1 fairly closely.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:

Don't use the WKContentViewDelegate protocol for things that don't belong there.

  • UIProcess/ios/SmartMagnificationController.h: Added.
  • UIProcess/ios/SmartMagnificationController.messages.in: Added.
  • UIProcess/ios/SmartMagnificationController.mm: Added.

(WebKit::SmartMagnificationController::SmartMagnificationController):
(WebKit::SmartMagnificationController::~SmartMagnificationController):
(WebKit::SmartMagnificationController::handleSmartMagnificationGesture):
(WebKit::SmartMagnificationController::didCollectGeometryForSmartMagnificationGesture):
SmartMagnificationController sits off of WKContentView, and sends/receives
messages to the WebProcess to do the smart magnification hit-testing.

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView initWithFrame:context:WebKit::configuration:WebKit::webView:]):
As before, teach WKContentView about its owning WKWebView.

(-[WKContentView _takeViewSnapshot]):
Rename.

(-[WKContentView _zoomToRect:withOrigin:fitEntireRect:minimumScale:maximumScale:minimumScrollDistance:]):
(-[WKContentView _zoomOutWithOrigin:]):
Forward _zoomToRect:::::: and _zoomOutWithOrigin: to WKWebView.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _doubleTapRecognized:]):
(-[WKContentView _twoFingerDoubleTapRecognized:]):
Forward double tap to the SmartMagnificationController.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureController.messages.in:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
Retrieve the minimum/maximum viewport scale from the WebProcess.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector):
(WebKit::ViewGestureGeometryCollector::dispatchDidCollectGeometryForSmartMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
(WebKit::ViewGestureGeometryCollector::collectGeometryForMagnificationGesture):
Factor out code to send the geometry back to the UI process.

  • WebProcess/WebPage/ViewGestureGeometryCollector.h:
  • WebProcess/WebPage/ViewGestureGeometryCollector.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

  • WebProcess/WebPage/WebPage.h:

We should have a ViewGestureGeometryCollector on iOS too.

  • WebCore.exp.in:

Add an export.

7:58 PM Changeset in webkit [164936] by commit-queue@webkit.org
  • 5 edits
    4 deletes in trunk

Unreviewed, rolling out r164929 and r164934.
http://trac.webkit.org/changeset/164929
http://trac.webkit.org/changeset/164934
https://bugs.webkit.org/show_bug.cgi?id=129570

Caused assertions on two srcset tests (Requested by ap on
#webkit).

Source/WebCore:

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrComma):
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

  • fast/hidpi/image-srcset-invalid-descriptor-expected.txt: Removed.
  • fast/hidpi/image-srcset-invalid-descriptor.html: Removed.
  • fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
  • fast/hidpi/image-srcset-src-selection-1x-both-expected.txt: Removed.
  • fast/hidpi/image-srcset-src-selection-1x-both.html: Removed.
  • fast/hidpi/resources/srcset-helper.js:

(runTest):

7:45 PM Changeset in webkit [164935] by fpizlo@apple.com
  • 2 edits
    1 move in trunk

Source/JavaScriptCore: This shouldn't have been a layout test since it runs only under jsc. Moving it to JSC
stress tests.

  • tests/stress/generational-opaque-roots.js: Copied from LayoutTests/js/script-tests/generational-opaque-roots.js.

LayoutTests: This shouldn't be a layout test since it runs only under jsc. Moving it to JSC
stress tests.

  • js/script-tests/generational-opaque-roots.js: Removed.
4:35 PM Changeset in webkit [164934] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • html/parser/HTMLParserIdioms.cpp: Removed an unused function.
4:20 PM Changeset in webkit [164933] by ddkilzer@apple.com
  • 3 edits
    2 adds in trunk

Ensure keySplines is valid in SMIL animations
<http://webkit.org/b/129547>
<rdar://problem/15676128>

Reviewed by Darin Adler.

Merged from Blink (patch by Philip Rogers):
https://src.chromium.org/viewvc/blink?revision=156452&view=revision
http://crbug.com/276111

This patch fixes a crash in SMIL animations when keySplines are not
specified. The SMIL spec is clear on this:
http://www.w3.org/TR/2001/REC-smil-animation-20010904/#AnimFuncCalcMode
"If there are any errors in the keyTimes specification (bad values,
too many or too few values), the animation will have no effect."

This patch simply checks that keyTimes is not empty. Previously,
splinesCount was set to be m_keySplines.size() + 1 in
SVGAnimationElement.cpp; this patch changes splinesCount to be equal
to m_keySplines.size() to make the logic easier to follow and to
match other checks in SVGAnimationElement::startedActiveInterval.

Source/WebCore:

Test: svg/animations/animate-keysplines-crash.html

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::startedActiveInterval):

LayoutTests:

  • svg/animations/animate-keysplines-crash-expected.txt: Added.
  • svg/animations/animate-keysplines-crash.html: Added.
3:50 PM Changeset in webkit [164932] by benjamin@webkit.org
  • 3 edits
    2 adds in trunk

Tighten minimumRegisterRequirements()
https://bugs.webkit.org/show_bug.cgi?id=129538

Reviewed by Andreas Kling.

Source/WebCore:

Fix small things that made minimumRegisterRequirements() a little optimistic
when dealing with attributes.

Test: fast/selectors/adjacent-descendant-tail-register-requirement.html

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
Attribute Set does not do value matching, the case sensitive value matching is irrelevant
The problem is that flag is also used by minimumRegisterRequirements()
to find if one more register is needed.

Set the flag to case sensitive to avoid reserving one extra register.

(WebCore::SelectorCompiler::minimumRegisterRequirements):
Use a new backtrackingFlag to know if there is a descendant tail, thus a backtracking register
reserved.
This is better than using the backtracking action because the backtracking chain could be
an adjacent chain inside a descendant chain.

The flags are designed for that, just set one for minimumRegisterRequirements().

The 2 extra registers for the attribute count and address become limited to all attributes
except the last one. We don't keep a copy for the last matching, those registers were not needed.

(WebCore::SelectorCompiler::SelectorCodeGenerator::computeBacktrackingInformation):

LayoutTests:

  • fast/selectors/adjacent-descendant-tail-register-requirement-expected.txt: Added.
  • fast/selectors/adjacent-descendant-tail-register-requirement.html: Added.
3:31 PM Changeset in webkit [164931] by psolanki@apple.com
  • 4 edits in trunk/Source

[iOS] selectionImageForcingBlackText should return autoreleased object
https://bugs.webkit.org/show_bug.cgi?id=129437
<rdar://problem/15810384>

Reviewed by Darin Adler.

Source/WebCore:

  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]):

3:30 PM Changeset in webkit [164930] by Darin Adler
  • 2 edits in trunk/Websites/webkit.org

Some small modernizing tweaks to the coding style guide
https://bugs.webkit.org/show_bug.cgi?id=129427

Reviewed by Alexey Proskuryakov.

My intent here was originally to do the nullptr style guide update, but that was already done.
I did some other improvements. There's still quite a bit to do -- the guide is out of date in
a number of subtle ways.

  • coding/coding-style.html: Change "left side operator" example to be a more modern example

without non-WebKit-style abbreviations and such. Use auto& instead of const auto& in for loop
example, since that's normally preferred. Changed section title to say "zero" instead of "0".
Use words instead of abbreviations in code examples. Show that a modern C++ for loop is preferred
over index iteration in vector iteration example and also showed use of unsigned rather than
size_t since that is almost always what we want. Eliminated the use of PassOwnPtr in the "return
a newly created object" example. Use references instead of pointers in one example.

3:28 PM Changeset in webkit [164929] by commit-queue@webkit.org
  • 5 edits
    4 adds in trunk

Fix srcset related bugs
https://bugs.webkit.org/show_bug.cgi?id=129539

Source/WebCore:

Fixed a bug reported against Blink's srcset implementation at https://code.google.com/p/chromium/issues/detail?id=347998
When both src and srcset had only 1x descriptors and the DPR was higher than 1, the src's resource was picked.

Also fixed the invalid descriptor handling, which wasn't aligned with the spec, and therefore was not as forward compatible as it should be.
Invalid descriptors caused the entire resource to be ignored, rather than just the descriptors themselves.

Patch by Yoav Weiss <yoav@yoav.ws> on 2014-03-01
Reviewed by Andreas Kling.

Tests: fast/hidpi/image-srcset-invalid-descriptor.html

fast/hidpi/image-srcset-src-selection-1x-both.html

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseDescriptors):
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):

LayoutTests:

These tests make sure that:

  1. Invalid srcset descriptors are handled according to the spec. The invalid descriptors are ignored, but the resource is not.
  2. When both src and srcset have only 1x descriptors and the DPR is higher than 1, the srcset's resource is picked.

I've also fixed the invalid inputs test, which was faulty.

Patch by Yoav Weiss <yoav@yoav.ws> on 2014-03-01
Reviewed by Andreas Kling.

  • fast/hidpi/image-srcset-invalid-descriptor-expected.txt: Added.
  • fast/hidpi/image-srcset-invalid-descriptor.html: Added.
  • fast/hidpi/image-srcset-invalid-inputs-correct-src.html:
  • fast/hidpi/image-srcset-src-selection-1x-both-expected.txt: Added.
  • fast/hidpi/image-srcset-src-selection-1x-both.html: Added.
  • fast/hidpi/resources/srcset-helper.js:

(runTest):

3:22 PM Changeset in webkit [164928] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Improve "bad parent" and "bad child list" assertions in line boxes
https://bugs.webkit.org/show_bug.cgi?id=125656

Reviewed by Sam Weinig.

My previous fix for this problem was incomplete. This continuation of that fix addresses
the flaw in the original and adds additional lifetime checking so problems can be seen in
debug builds without a memory debugger.

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::assertNotDeleted): Added. Poor man's memory debugging helper.
(WebCore::InlineBox::~InlineBox): Refactored body into a new function named
invalidateParentChildList. Added code to update the deletion sentinel to record
that this object is deleted.
(WebCore::InlineBox::setHasBadParent): Moved here from header since this debug-only
feature does not need to be inlined. Added a call to assertNotDeleted.
(WebCore::InlineBox::invalidateParentChildList): Added. Refactored from the destructor,
this is used by RenderTextLineBoxes.

  • rendering/InlineBox.h: Added the deletion sentinel, and called it in the parent

function. Also changed the expansion/setExpansion functions to use the type name "int",
since we don't use the type name "signed" in the WebKit coding style.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::~InlineFlowBox): Call setHasBadChildList rather than doing the
setHasBadParent work on children directly, to avoid code duplication.
(WebCore::InlineFlowBox::setHasBadChildList): Moved here from header. Added code to set
"has bad parent" on all children, something we previously did only on destruction. Also
added assertNotDeleted.
(WebCore::InlineFlowBox::checkConsistency): Added call to assertNotDeleted. Also tweaked
code style and variable names a little bit.

  • rendering/InlineFlowBox.h: Moved setHasBadChildList out of the header when it's on.

The empty version for ASSERT_WITH_SECURITY_IMPLICATION_DISABLED is still in the header.

  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::invalidateParentChildLists): Call the new
InlineBox::invalidateParentChildList function instead of calling setHasBadChildList directly.
The new function checks m_hasBadParent, something we couldn't do here.

3:05 PM Changeset in webkit [164927] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSCell::fastGetOwnProperty() should get the Structure more efficiently.
<https://webkit.org/b/129560>

Now that structure() is nontrivial and we have a faster structure(VM&),
make use of that in fastGetOwnProperty() since we already have VM.

Reviewed by Sam Weinig.

  • runtime/JSCellInlines.h:

(JSC::JSCell::fastGetOwnProperty):

2:27 PM Changeset in webkit [164926] by cavalcantii@gmail.com
  • 2 edits in trunk/LayoutTests

Set css3/filter/huge-region as skipped
https://bugs.webkit.org/show_bug.cgi?id=129552

It tries to use an insanely huge kernel for a huge blur filtered
element while it is expected to *not* execute. Thanks to the changes
introduced in #123716, this test will try to be executed and may
timeout in some machines. The proper fix will follow up in #129553.

Reviewed by Dirk Schulze.

2:21 PM Changeset in webkit [164925] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Avoid going through ExecState for VM when we already have it (in some places.)
<https://webkit.org/b/129554>

Tweak some places that jump through unnecessary hoops to get the VM.
There are many more like this.

Reviewed by Sam Weinig.

  • runtime/JSObject.cpp:

(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

2:09 PM Changeset in webkit [164924] by benjamin@webkit.org
  • 7 edits
    2 adds in trunk

Optimized querySelector(All) when selector contains #id
https://bugs.webkit.org/show_bug.cgi?id=116502

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/selectors/querySelector-id-filtering.html

The idea of this patch is to perform querySelector on a subtree
rooted at the last element with #id matching. For example, if we have the selector
"#foobar div a", we start by looking for the element with ID foobar in the TreeScope
cache, and start matching the children from there.

The idea comes from Rune for
https://chromium.googlesource.com/chromium/blink/+/1cd83d3588973a02ab15d94b1b05a28620853624
but the code as diverged too much so it had to be reimplemented specifically for WebKit.

  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::CSSSelectorList):
(WebCore::CSSSelectorList::operator=):

  • css/CSSSelectorList.h:

(WebCore::CSSSelectorList::~CSSSelectorList):

  • css/StyleRule.h:

(WebCore::StyleRule::wrapperAdoptSelectorList):
(WebCore::StyleRulePage::wrapperAdoptSelectorList):

  • dom/SelectorQuery.cpp:

(WebCore::isSingleTagNameSelector):
(WebCore::isSingleClassNameSelector):
(WebCore::findIdMatchingType):
(WebCore::SelectorDataList::SelectorDataList):
(WebCore::filterRootById):
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::execute):
(WebCore::SelectorQuery::SelectorQuery):
(WebCore::SelectorQueryCache::add):

  • dom/SelectorQuery.h:

(WebCore::SelectorDataList::SelectorData::SelectorData):

LayoutTests:

  • fast/selectors/querySelector-id-filtering-expected.txt: Added.
  • fast/selectors/querySelector-id-filtering.html: Added.
11:57 AM Changeset in webkit [164923] by fpizlo@apple.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

FTL should support PhantomArguments
https://bugs.webkit.org/show_bug.cgi?id=113986

Reviewed by Oliver Hunt.

Adding PhantomArguments to the FTL mostly means wiring the recovery of the Arguments
object into the FTL's OSR exit compiler.

This isn't a speed-up yet, since there is still more to be done to fully support
all of the arguments craziness that our varargs benchmarks do.

  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): move the recovery code to DFGOSRExitCompilerCommon.cpp

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit): move the recovery code to DFGOSRExitCompilerCommon.cpp

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::ArgumentsRecoveryGenerator::ArgumentsRecoveryGenerator):
(JSC::DFG::ArgumentsRecoveryGenerator::~ArgumentsRecoveryGenerator):
(JSC::DFG::ArgumentsRecoveryGenerator::generateFor): this is the common place for the recovery code

  • dfg/DFGOSRExitCompilerCommon.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::dumpInContext):

  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::argumentsObjectThatWasNotCreated):
(JSC::FTL::ExitValue::isArgumentsObjectThatWasNotCreated):
(JSC::FTL::ExitValue::valueFormat):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePhantomArguments):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::tryToSetConstantExitArgument):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub): Call into the ArgumentsRecoveryGenerator

  • tests/stress/slightly-more-difficult-to-fold-reflective-arguments-access.js: Added.
  • tests/stress/trivially-foldable-reflective-arguments-access.js: Added.
11:42 AM Changeset in webkit [164922] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, uncomment some code. It wasn't meant to be commented in the first place.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination):

10:48 AM Changeset in webkit [164921] by timothy@apple.com
  • 4 edits in trunk/Source/WebInspectorUI

Make Start Timeline Recording in the Develop menu show the Timeline view again.

This also fixes a noticeable delay between showing the sidebar and the default Timeline
view when initially opening the Web Inspector to the Timeline.

https://bugs.webkit.org/show_bug.cgi?id=129545

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Call TimelineSidebarPanel.initialize to prime the content view.
This is needed so the view is ready in this run loop cycle, where it was delayed before.

  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setTimelineProfilingEnabled): Call TimelineSidebarPanel.showTimelineOverview.

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.initialize): Added.

10:48 AM Changeset in webkit [164920] by ap@apple.com
  • 9 edits in trunk

Node::compareDocumentPosition leaks memory structure
https://bugs.webkit.org/show_bug.cgi?id=120244

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition): Don't do it.

LayoutTests:

  • TestExpectations:
  • dom/xhtml/level3/core/nodecomparedocumentposition38-expected.txt:
  • fast/dom/compare-document-position-disconnected-nodes-expected.txt:
  • fast/dom/compare-document-position-disconnected-nodes.html:
  • fast/dom/shadow/compare-document-position-expected.txt:
  • fast/dom/shadow/compare-document-position.html:
10:46 AM Changeset in webkit [164919] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Select the Resource navigation sidebar by default when there is no cookie.

https://bugs.webkit.org/show_bug.cgi?id=129544

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

(WebInspector._restoreInspectorViewStateFromCookie):

9:51 AM Changeset in webkit [164918] by timothy@apple.com
  • 5 edits in trunk/Source/WebInspectorUI

Label JavaScript forced layouts as such in the Timeline.

https://bugs.webkit.org/show_bug.cgi?id=129546

Reviewed by David Kilzer.

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.eventRecorded.processRecord):
(WebInspector.TimelineManager.prototype.eventRecorded):

  • UserInterface/Models/LayoutTimelineRecord.js:

(WebInspector.LayoutTimelineRecord.EventType.displayName):

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):

8:26 AM Changeset in webkit [164917] by ddkilzer@apple.com
  • 8 edits
    1 move
    2 adds in trunk

Fix lifetime handling of SVGPropertyTearOffs
<http://webkit.org/b/129211>
<rdar://problem/15696025>

Reviewed by Maciej Stachowiak.

Merged from Blink (patch by Ojan Vafai):
https://src.chromium.org/viewvc/blink?revision=157801&view=revision
http://crbug.com/288771

-Replace SVGStaticPropertyWithParentTearOff with SVGMatrixTearOff
since it's only used in that one place. This means we can get rid
of the templatizing and the method pointer.
-Change SVGPropertyTearOff to keep track of it's child tearoffs
and call detachWrapper on its child tearoffs when it's destroyed
or when it's wrapper is detached.
-Have SVGPropertyTearOff hold WeakPtrs to the child tearoffs
to avoid having a cycle.

Source/WebCore:

Test: svg/transforms/svg-matrix-tearoff-crash.html

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValue):

  • svg/properties/SVGMatrixTearOff.h: Renamed from Source/WebCore/svg/properties/SVGStaticPropertyWithParentTearOff.h.

(WebCore::SVGMatrixTearOff::create):
(WebCore::SVGMatrixTearOff::commitChange):
(WebCore::SVGMatrixTearOff::SVGMatrixTearOff):

  • svg/properties/SVGPropertyTearOff.h:

(WebCore::SVGPropertyTearOff::addChild):
(WebCore::SVGPropertyTearOff::detachChildren):

LayoutTests:

  • svg/transforms/svg-matrix-tearoff-crash-expected.txt: Added.
  • svg/transforms/svg-matrix-tearoff-crash.html: Added.
1:35 AM Changeset in webkit [164916] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r164913.

  • platform/CountedUserActivity.h: Some ports don't (yet) support forwarding headers for WebCore,

so UserActivity.h should be included as non-forwarding.

1:08 AM Changeset in webkit [164915] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed follow-up to r164905 and r164912.

  • Platform/IPC/Connection.h: Only declare setShouldCloseConnectionOnMachExceptions() for the Mac port.
  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::didFinishLaunching): Only call setShouldCloseConnectionOnMachExceptions() on the Mac port.

1:01 AM Changeset in webkit [164914] by barraclough@apple.com
  • 5 edits in trunk/Source/WebCore

Change PageActivityAssertionToken to use a WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=129526

Reviewed by Sam Weinig.

PageThrottler effectively implements a bespoke weak pointer mechanism; remove this & just use WeakPtr.

  • page/PageActivityAssertionToken.cpp:

(WebCore::PageActivityAssertionToken::PageActivityAssertionToken):
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken):

  • addActivityToken->incrementActivityCount, removeActivityToken->decrementActivityCount
  • page/PageActivityAssertionToken.h:
    • removed invalidate, made m_throttler a WeakPtr
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):

  • initialize m_weakPtrFactory, m_activityCount.

(WebCore::PageThrottler::~PageThrottler):

  • removed called to invalidate.

(WebCore::PageThrottler::startThrottleHysteresisTimer):

  • m_activityTokens.size()->m_activityCount

(WebCore::PageThrottler::throttleHysteresisTimerFired):

  • m_activityTokens.size()->m_activityCount

(WebCore::PageThrottler::incrementActivityCount):

  • m_activityTokens.add->++

(WebCore::PageThrottler::decrementActivityCount):

  • m_activityTokens.remove->--
  • page/PageThrottler.h:

(WebCore::PageThrottler::weakPtr):

  • replaced HashSet with WeakPtrFactory & count.
12:49 AM Changeset in webkit [164913] by barraclough@apple.com
  • 16 edits
    1 copy in trunk/Source

Split UserActivity/CountedUserActivity
https://bugs.webkit.org/show_bug.cgi?id=129520

Reviewed by Sam Weinig.

UserActivity currently provides an interface allowing counted, nested calls to enable/disable.
In some cases it would be easier to use if it were a simpler boolean enabled/disabled interface.

Source/WebCore:

  • WebCore.exp.in:
    • beginActivity->start, endActivity->stop.
  • WebCore.xcodeproj/project.pbxproj:
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::PageThrottler):
(WebCore::PageThrottler::~PageThrottler):
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
(WebCore::PageThrottler::setIsVisuallyIdle):

  • beginActivity->increment, endActivity->decrement.
  • page/PageThrottler.h:
    • UserActivity->CountedUserActivity for m_pageActivity
  • platform/CountedUserActivity.h: Copied from Source/WebCore/platform/UserActivity.h.

(WebCore::CountedUserActivity::CountedUserActivity):
(WebCore::CountedUserActivity::increment):
(WebCore::CountedUserActivity::decrement):

  • Added, provides counted interface to UserActivity.
  • platform/UserActivity.cpp:

(WebCore::UserActivity::UserActivity):

  • m_count removed

(WebCore::UserActivity::start):
(WebCore::UserActivity::stop):

  • beginActivity->start, endActivity->stop, implentation now empty.
  • platform/UserActivity.h:
    • beginActivity->start, endActivity->stop, m_count moved to HAVE(NS_ACTIVITY)
  • platform/mac/UserActivityMac.mm:

(WebCore::UserActivity::UserActivity):

  • m_count->m_started

(WebCore::UserActivity::isValid):

  • m_count->m_started

(WebCore::UserActivity::start):
(WebCore::UserActivity::stop):

  • beginActivity->start, endActivity->stop, no longer nest

Source/WebKit2:

  • PluginProcess/PluginProcess.h:

(WebKit::PluginProcess::connectionActivity):

  • UserActivity->CountedUserActivity
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::platformInitializeProcess):

  • beginActivity->start
  • Shared/ActivityAssertion.cpp:

(WebKit::ActivityAssertion::ActivityAssertion):
(WebKit::ActivityAssertion::~ActivityAssertion):

  • beginActivity->increment, endActivity->decrement.
  • Shared/ActivityAssertion.h:
    • UserActivity->CountedUserActivity
  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::setProcessSuppressionEnabled):

  • beginActivity->start, endActivity->stop.
  • Shared/ChildProcess.h:
    • removed processSuppressionEnabled()
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • beginActivity->start, endActivity->stop.
12:35 AM Changeset in webkit [164912] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed trivial Linux buildfix after r164905.

setShouldCloseConnectionOnMachExceptions() is defined in the Mac only
Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp inside !PLATFORM(IOS)
which means PLATFORM(MAC), because nobody else uses this source file.

But ChildProcessProxy.cpp is used by Linux ports too, so we have to
use the most specific #if guard here, which is PLATFORM(MAC).

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

Feb 28, 2014:

10:13 PM Changeset in webkit [164911] by benjamin@webkit.org
  • 4 edits
    4 adds in trunk

Caller saved registers can be accidentally discarded when clearing the local stack
https://bugs.webkit.org/show_bug.cgi?id=129532

Reviewed by Andreas Kling.

Source/WebCore:

Tests: fast/selectors/tree-modifying-case-insensitive-selectors.html

fast/selectors/tree-modifying-selectors.html

StackAllocator::discard() no longer make sense now that we can use caller saved regsiter.
We should instead discard everything up to the beginning of the local stack.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

  • cssjit/StackAllocator.h:

(WebCore::StackAllocator::popAndDiscardUpTo):

LayoutTests:

  • fast/selectors/tree-modifying-case-insensitive-selectors.html: Added.
  • fast/selectors/tree-modifying-selectors.html: Added.
9:36 PM Changeset in webkit [164910] by Simon Fraser
  • 4 edits in trunk/Source/WebKit2

[iOS] Assertions and bad behavior when zooming into an iframe containing apple.com
https://bugs.webkit.org/show_bug.cgi?id=129537

Reviewed by Benjamin Poulain.

When building RemoteLayerTreeTransactions, the ordering of setting created
layers and doing the recursive tree walk was wrong, such that we failed
to noticed layers created during the recursiveBuildTransaction().

Also harden the UI-side code against Obj-C exceptions thrown when layers
are missing.

  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::applyProperties): Assert when
children are not found, and protect against Obj-C exceptions.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::LayerCreationProperties):
Initialize the members.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::buildTransaction): Do the recursive walk
before setting created and destroyed layers, since the walk can create
layers (especially when swapping into tiled layers).

9:34 PM Changeset in webkit [164909] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Fix WebKit2 build after r164890
https://bugs.webkit.org/show_bug.cgi?id=129533

Reviewed by Simon Fraser.

LayerRepresentation.h is included to WebPageProxy.h in r164890
but it is not used in non Mac or iOS port.

  • UIProcess/WebPageProxy.h:
9:31 PM Changeset in webkit [164908] by mitz@apple.com
  • 4 edits
    1 delete in trunk/Source/WebKit

[Mac] Remove MailQuirksUserScript.js
https://bugs.webkit.org/show_bug.cgi?id=129536

Reviewed by Andy Estes.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed reference to the file.

../WebKit/mac:

  • Configurations/WebKit.xcconfig: Removed from EXCLUDED_SOURCE_FILE_NAMES_iphoneos.
  • Misc/MailQuirksUserScript.js: Removed. This file has been unused since r147447.
9:14 PM Changeset in webkit [164907] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] FrameLoader has a NULL m_progressTracker when initialized with initForSynthesizedDocument()
https://bugs.webkit.org/show_bug.cgi?id=129534

Reviewed by Simon Fraser.

No new tests because TestWebKitAPI does not yet support iOS. See <http://webkit.org/b/129535>.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::initForSynthesizedDocument): Create a FrameProgressTracker.

9:05 PM Changeset in webkit [164906] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Extract _data->_thumbnailView checks into a helper function
https://bugs.webkit.org/show_bug.cgi?id=129517

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKView.mm:

(-[WKView shouldIgnoreMouseEvents]):
(-[WKView scrollWheel:]):
(-[WKView mouseMoved:]):
(-[WKView mouseDown:]):
(-[WKView mouseUp:]):
(-[WKView mouseDragged:]):

8:10 PM Changeset in webkit [164905] by psolanki@apple.com
  • 4 edits in trunk/Source/WebKit2

[iOS][WebKit2] Don't use any of the mach exception handling code on iOS
https://bugs.webkit.org/show_bug.cgi?id=129516

Reviewed by Sam Weinig.

This code is not used on iOS after my fix in r164883. We can just move it all under
!PLATFORM(IOS).

  • Platform/IPC/Connection.h:
  • Platform/IPC/mac/ConnectionMac.cpp:

(IPC::Connection::platformInvalidate):
(IPC::Connection::platformInitialize):
(IPC::Connection::open):

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

8:01 PM Changeset in webkit [164904] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSObject::findPropertyHashEntry() should take VM instead of ExecState.
<https://webkit.org/b/129529>

Callers already have VM in a local, and findPropertyHashEntry() only
uses the VM, no need to go all the way through ExecState.

Reviewed by Geoffrey Garen.

  • runtime/JSObject.cpp:

(JSC::JSObject::put):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::findPropertyHashEntry):

  • runtime/JSObject.h:
7:11 PM Changeset in webkit [164903] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERT(isMainThread()) hit under platformUserPreferredLanguages() with WebKit1 and WebKit2 in the same process
https://bugs.webkit.org/show_bug.cgi?id=129528

Reviewed by Andreas Kling.

  • platform/mac/Language.mm:

(WebCore::preferredLanguagesMutex):
(WebCore::preferredLanguages):
(+[WebLanguageChangeObserver languagePreferencesDidChange:]):
(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):
Add a mutex and do an isolated copy of the strings to allow this function to be called from multiple threads.

6:51 PM Changeset in webkit [164902] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Deadlock remotely inspecting iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=129511

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-28
Reviewed by Timothy Hatcher.

Avoid synchronous setup. Do it asynchronously, and let
the RemoteInspector singleton know later if it failed.

  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::setupFailed):

  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):

6:05 PM Changeset in webkit [164901] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Crash at ebay.com when viewing auction items at com.apple.WebCore: WebCore::GraphicsContext3D::getExtensions + 10
https://bugs.webkit.org/show_bug.cgi?id=129523

Reviewed by Simon Fraser.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getSupportedExtensions): Early return if the
context is pending policy resolution.

5:11 PM Changeset in webkit [164900] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Micro-optimize JSNodeOwner::isReachableFromOpaqueRoots().
<https://webkit.org/b/129518>

Only do image and audio element specific checks for element nodes.
Time spent in here goes from 0.8% to 0.5% on DYEB.

Reviewed by Benjamin Poulain.

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

5:07 PM Changeset in webkit [164899] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.75.4

New tag.

5:06 PM Changeset in webkit [164898] by bshafiei@apple.com
  • 5 edits in branches/safari-537.75-branch/Source

Versioning.

4:45 PM Changeset in webkit [164897] by ggaren@apple.com
  • 2 edits in trunk/Source/WebCore

JSC Assertion failure every time I start Safari (r164846)
https://bugs.webkit.org/show_bug.cgi?id=129510

Reviewed by Mark Hahnenberg.

Take the lock before allocating objects because afterward is too late.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):

4:42 PM Changeset in webkit [164896] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: ASSERT in WebCore::JSDOMWindowBase::supportsRichSourceInfo inspecting iOS
https://bugs.webkit.org/show_bug.cgi?id=129512

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-02-28
Reviewed by Simon Fraser.

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):

4:40 PM Changeset in webkit [164895] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

VisitedLinkStore should be able to invalidate link styles for associated pages
https://bugs.webkit.org/show_bug.cgi?id=129515

Reviewed by Dan Bernstein.

  • page/Page.cpp:

(WebCore::Page::Page):
Add the VisitedLinkStore if we have one.

(WebCore::Page::~Page):
Remove the VisitedLinkStore if we have one.

  • page/VisitedLinkStore.cpp:

(WebCore::VisitedLinkStore::~VisitedLinkStore):
Assert that we don't have any pages.

(WebCore::VisitedLinkStore::addPage):
Add the page to the set.

(WebCore::VisitedLinkStore::removePage):
Remove the page from the set.

(WebCore::VisitedLinkStore::invalidateStylesForAllLinks):
Traverse all the pages and invalidate the style for all links.

(WebCore::VisitedLinkStore::invalidateStylesForLink):
Traverse all the pages and invalidate the style for a given link.

  • page/VisitedLinkStore.h:

Add new members.

4:27 PM Changeset in webkit [164894] by Brent Fulgham
  • 2 edits in branches/safari-537.75-branch/WebKitLibraries

Unreviewed build fix.
<rdar://problem/16197002>

  • win/tools/vsprops/debugsuffix.props: Set OFFICIAL_BUILD=1 for DebugSuffix target, since this

is the official debug analog to the Production build target.

4:22 PM Changeset in webkit [164893] by Brent Fulgham
  • 7 edits in branches/safari-537.75-branch/Source

Unreviewed build fix.
<rdar://problem/16197002>

Source/JavaScriptCore:

slash from path names, as this was causing multiple arguments
to be concatenated together (the whitespace was getting escaped
by the slash.)

Source/WebCore:

  • WebCore.vcxproj/WebCore.proj: Remove trailing

slash from path names, as this was causing multiple arguments
to be concatenated together (the whitespace was getting escaped
by the slash.)

Source/WTF:

  • WTF.vcxproj/WTF.proj: Remove trailing

slash from path names, as this was causing multiple arguments
to be concatenated together (the whitespace was getting escaped
by the slash.)

  • WTF.vcxproj/work-around-vs-dependency-tracking-bugs.py:

Check for presence of RC_XBS in environment, and exit since
this logic is not needed for 'official' builds.

4:04 PM WebKitGTK/2.4.x edited by desrt@desrt.ca
geoclue2 is on track (diff)
3:55 PM Changeset in webkit [164892] by benjamin@webkit.org
  • 4 edits in trunk/Source

Source/WebCore: [iOS][WK2] highlight rects should never big bigger than the view
https://bugs.webkit.org/show_bug.cgi?id=129472

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-28
Reviewed by Enrica Casucci.

  • WebCore.exp.in:

Source/WebKit2: [iOS][WK2] highlight rects should never big bigger than the view
https://bugs.webkit.org/show_bug.cgi?id=129472
<rdar://problem/15673655>

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-02-28
Reviewed by Enrica Casucci.

The unobscuredRect on WebPageProxy is the "true" view rect as seen by the user.
Use that to constrain our highlight rects.

  • UIProcess/ios/WKContentViewInteraction.mm:

(highlightedQuadsFitInRect):
(-[WKContentView _didGetTapHighlightForRequest:color:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):

3:38 PM Changeset in webkit [164891] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Turn off margin tiles on iOS
https://bugs.webkit.org/show_bug.cgi?id=129509
-and corresponding-
<rdar://problem/16200383>

Reviewed by Simon Fraser.

  • page/FrameView.cpp:

(WebCore::FrameView::needsExtendedBackgroundRectForPainting):

3:36 PM Changeset in webkit [164890] by Simon Fraser
  • 18 edits
    2 copies
    1 move
    2 adds in trunk/Source/WebKit2

Make UIViews for compositing layers in the UI process on iOS
https://bugs.webkit.org/show_bug.cgi?id=129508

Reviewed by Sam Weinig.

In order to parent UIScrollViews for -webkit-overflow-scrolling:touch,
we need to use UIViews in the compositing layer hierarchy on iOS.

Make much of the code that currently uses CALayers layer-or-view
agnostic by using a typedef LayerOrView.

Fix RemoteLayerTreePropertyApplier to apply properties to UIViews
or CALayers; on iOS, we need both paths because we have to set properties
on CALayer for remotely hosted content.

Add iOS-specific implementation files for RemoteLayerTreeHost and RemoteScrollingCoordinatorProxy,
since these need to see the UIView implementation. WebVideoFullscreenManagerProxy.cpp also needs
to be come a .mm file.

  • Shared/mac/RemoteLayerTreePropertyApplier.h:
  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(-[UIView setSubviews:]):
(WebKit::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::applyProperties):

  • UIProcess/Cocoa/LayerRepresentation.h: Copied from Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.h.

(asLayer):

  • UIProcess/PageClient.h:
  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/LayerRepresentation.mm: Copied from Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.h.

(asLayer):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer):
(WebKit::PageClientImpl::acceleratedCompositingRootLayer):

  • UIProcess/ios/RemoteLayerTreeHostIOS.mm: Added.

(+[WKTransformView layerClass]):
(-[WKRemoteView initWithFrame:contextID:]):
(+[WKRemoteView layerClass]):
(WebKit::RemoteLayerTreeHost::createLayer):

  • UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm: Added.

(WebKit::layerRepresentationFromLayerOrView):
(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _setAcceleratedCompositingRootView:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm: Renamed from Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.cpp.

(WebKit::WebVideoFullscreenManagerProxy::create):
(WebKit::WebVideoFullscreenManagerProxy::WebVideoFullscreenManagerProxy):
(WebKit::WebVideoFullscreenManagerProxy::~WebVideoFullscreenManagerProxy):
(WebKit::WebVideoFullscreenManagerProxy::didCommitLayerTree):
(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerID):
(WebKit::WebVideoFullscreenManagerProxy::enterFullscreen):
(WebKit::WebVideoFullscreenManagerProxy::requestExitFullScreen):
(WebKit::WebVideoFullscreenManagerProxy::play):
(WebKit::WebVideoFullscreenManagerProxy::pause):
(WebKit::WebVideoFullscreenManagerProxy::togglePlayState):
(WebKit::WebVideoFullscreenManagerProxy::seekToTime):
(WebKit::WebVideoFullscreenManagerProxy::didExitFullscreen):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):

  • UIProcess/mac/RemoteLayerTreeHost.h:

(WebKit::RemoteLayerTreeHost::rootLayer):

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::getLayer):
(WebKit::RemoteLayerTreeHost::createLayer):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):
(WebKit::WebPageProxy::acceleratedCompositingRootLayer):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::recursiveBuildTransaction):

3:11 PM Changeset in webkit [164889] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

WebKit2.TerminateTwice test is failing.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):
Turns out this can be called even when we're in the launching state so don't try to
remove the process from the visited link provider when in that state.

3:05 PM Changeset in webkit [164888] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Subpixel rendering: Add subpixel support to border type of double, groove, ridge, inset and outset.
https://bugs.webkit.org/show_bug.cgi?id=129226

Reviewed by Simon Fraser.

This is the conversion of double, inset, outset, groove and ridge border type
painting to support device pixel precision width/height.

Regression is covered by existing tests.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):

  • rendering/RenderObject.h:
3:04 PM Changeset in webkit [164887] by Chris Fleizach
  • 2 edits in trunk/Source/WebKit2

AX: Crash in WebKit::WebPageProxy::registerWebProcessAccessibilityToken
https://bugs.webkit.org/show_bug.cgi?id=127387

Reviewed by Alexey Proskuryakov.

Speculative fix for crasher. We should check if the connection is still valid before proceeding.

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):

2:54 PM Changeset in webkit [164886] by cavalcantii@gmail.com
  • 7 edits
    4 adds in trunk

Filters should test for area instead of single dimension
https://bugs.webkit.org/show_bug.cgi?id=123716

Reviewed by Dirk Schulze.

A filtered SVG element with a sigle dimension bigger than 5000
(counting the margin/border) will fail to render. So an element
with 4000x4000 will render fine, while another with 5000x10
won't. This patch instead tests against the total element area,
which fixes such cases.

Source/WebCore:

It also fixes some layer violations where FilterEffectRenderer and
RenderSVGResourceFilter were directly accessing the maximum filter
size in FilterEffect. Since before a somewhat bigger filter would
be aborted, it required to change the maximum kernel size
for blur filter (some filters are slower to run than others for
bigger SVGs).

Tests: svg/filters/big-height-filter-expected.svg

svg/filters/big-height-filter.svg
svg/filters/big-width-filter-expected.svg
svg/filters/big-width-filter.svg

  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::maxFilterArea): New function, returns the
maximum allowed element area (currently is 4096 x 4096).
(WebCore::FilterEffect::isFilterSizeValid): Now it tests for
element area instead of a single dimension. This code is reused by
FilterEffectRenderer.

  • platform/graphics/filters/FilterEffect.h:
  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::updateBackingStoreRect): Uses the
new function in FilterEffect to test for valid sizes.
(WebCore::FilterEffectRendererHelper::beginFilterEffect): Same case.

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::fitsInMaximumImageSize): Test
for maximum area and properly changes the scale of transformed
element to fit.

LayoutTests:

The current patch fixes the rendering issue and at same time,
fixes some layer violations where FilterEffectRenderer and
RenderSVGResourceFilter were directly accessing the kMax value
in FilterEffect. Since before a somewhat bigger filter would
be aborted, it required to change the maximum kernel size
for blur filter (some filters are slower to run than others for
bigger SVGs).

  • svg/filters/big-height-filter-expected.svg: Added.
  • svg/filters/big-height-filter.svg: Added.
  • svg/filters/big-width-filter-expected.svg: Added.
  • svg/filters/big-width-filter.svg: Added.
2:54 PM Changeset in webkit [164885] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Enable breakpoints when adding a new breakpoint or enabling an existing breakpoint.

This eliminates a multi-step process for the user that can be confusing.

https://bugs.webkit.org/show_bug.cgi?id=129426

Reviewed by Joseph Pecoraro.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.set breakpointsEnabled):
(WebInspector.DebuggerManager.prototype._breakpointDisabledStateDidChange):

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsEnabledDidChange):
(WebInspector.DebuggerSidebarPanel.prototype._breakpointsToggleButtonClicked):

2:51 PM Changeset in webkit [164884] by timothy@apple.com
  • 5 edits in trunk/Source

Properly handle when Test.html is not present in Production builds.

https://bugs.webkit.org/show_bug.cgi?id=129506

Reviewed by Joseph Pecoraro.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController inspectorTestPagePath]):
(-[WebInspectorWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):

Source/WebKit2:

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::isMainOrTestInspectorPage):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::inspectorTestPageURL):

2:10 PM Changeset in webkit [164883] by psolanki@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS][WebKit2] Don't grab mach exception port on iOS
https://bugs.webkit.org/show_bug.cgi?id=129505
<rdar://problem/15972749>

Reviewed by Anders Carlsson.

Don't grab the mach exception port on iOS so we get crash logs for web process and network
process.

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):

1:43 PM Changeset in webkit [164882] by Alan Bujtas
  • 11 edits
    2 adds in trunk

Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
https://bugs.webkit.org/show_bug.cgi?id=129438

Reviewed by Simon Fraser.

'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
offscreen window. It makes testing subpixel rendering and positioning possible.

Both the offscreen window's and WebKit's scaling are set accordingly.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow): cleanup
(destroyWebViewAndOffscreenWindow): cleanup
(dumpRenderTree):
(changeWindowScaleIfNeeded):
(runTest):

  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::changeWindowScaleIfNeeded):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::changeWindowScaleIfNeeded):

  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::changeWindowScaleIfNeeded):

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::changeWindowScaleIfNeeded):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::changeWindowScaleIfNeeded):

LayoutTests:

  • fast/borders/hidpi-simple-hairline-border-painting-expected.html: Added.
  • fast/borders/hidpi-simple-hairline-border-painting.html: Added.
1:12 PM Changeset in webkit [164881] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Mac, iOS] Incorrect ordering of construction arguments for out-of-band text elements
https://bugs.webkit.org/show_bug.cgi?id=129501
<rdar://problem/16198587>

Reviewed by Eric Carlson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Correct order of arguments
to PlatformTextTrack.

1:03 PM Changeset in webkit [164880] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r164835): It broke 10 JSC stress test on 32 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=129488

Reviewed by Mark Lam.

Whoops, modify the right register.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

1:00 PM Changeset in webkit [164879] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r164832.

  • UIProcess/ios/WebProcessProxyIOS.mm:

(WebKit::WebProcessProxy::updateProcessState): Switch from removed
'isValid' to 'state() != State::Running'

12:40 PM Changeset in webkit [164878] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should be able to call sin/cos directly on platforms where the intrinsic is busted
https://bugs.webkit.org/show_bug.cgi?id=129503

Reviewed by Mark Lam.

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):
(JSC::FTL::Output::intrinsicOrOperation):

11:32 AM Changeset in webkit [164877] by andersca@apple.com
  • 6 edits in trunk

Source/WebKit2: VisitedLinkProvider should keep track of processes, not pages
https://bugs.webkit.org/show_bug.cgi?id=129497

Reviewed by Dan Bernstein.

Use a counted set of WebProcessProxy pointers instead of a set of pages.

  • UIProcess/VisitedLinkProvider.cpp:

(WebKit::VisitedLinkProvider::~VisitedLinkProvider):
Assert that m_processes is null.

(WebKit::VisitedLinkProvider::addProcess):
Add the process to the set.

(WebKit::VisitedLinkProvider::removeProcess):
Remove the process from the set.

  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
If our process is currently running, add it to the visited link provider.
Otherwise it will be added in connectionWillOpen.

(WebKit::WebPageProxy::close):
If our process is running, remove it from the visited link provider.
Otherwise it's either crashed or not yet launched and will not have been added.

(WebKit::WebPageProxy::connectionWillOpen):
Add the process to the visited link provider.

(WebKit::WebPageProxy::resetStateAfterProcessExited):
Remove the process from the visited link provider.

Tools: Remove logging.

Reviewed by Dan Bernstein.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):

11:19 AM Changeset in webkit [164876] by Bem Jones-Bey
  • 2 edits in trunk/Source/WebCore

Properly clear m_logicallyLastRun to remove use-after-free possibility
https://bugs.webkit.org/show_bug.cgi?id=129489

Reviewed by David Hyatt.

A use-after-free issue was caught in Blink because m_logicallyLastRun
is not cleared when the item it points to is deleted. Clearing it
turns the use-after-free into a segfault, and prevents any future
use-after-frees from happening.

  • platform/text/BidiRunList.h:

(WebCore::BidiRunList<Run>::deleteRuns):

11:03 AM Changeset in webkit [164875] by bshafiei@apple.com
  • 1 copy in tags/Safari-537.75.3

New tag.

11:02 AM Changeset in webkit [164874] by bshafiei@apple.com
  • 5 edits in branches/safari-537.75-branch/Source

Versioning.

10:59 AM Changeset in webkit [164873] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Disambiguate calls to [[window contentView] layer] and [... setLayer:]
https://bugs.webkit.org/show_bug.cgi?id=129491

Reviewed by Alexey Proskuryakov.

-[NSWindow contentView] returns a bare id, leading to ambiguity when calling
certain methods, including -layer and -setLayer:. Resolve the ambiguity by
explicitly casting the -contentView call to a NSView*.

  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setupVideoOverlay:]):
(-[WebVideoFullscreenController windowDidLoad]):
(-[WebVideoFullscreenController windowDidExitFullscreen]):

10:58 AM Changeset in webkit [164872] by ap@apple.com
  • 2 edits in trunk/LayoutTests

paragraphs with different directionality in textarea with unicode-bidi: plaintext are aligned the same
https://bugs.webkit.org/show_bug.cgi?id=71194

  • platform/mac/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:

Updated Mac results for Mavericks (the original patch only updated Mountain Lion results).

10:44 AM Changeset in webkit [164871] by akling@apple.com
  • 3 edits
    2 adds in trunk

MouseEvent.offsetX/Y should just return 0,0 for simulated clicks.
<https://webkit.org/b/129477>

Source/WebCore:

There's no need to compute the exact target-relative coordinates for
simulated mouse events, e.g those fired by HTMLElement.click().

The offsetX/Y properties are not supported by Firefox.

Test: fast/events/relative-offset-of-simulated-click.html

Reviewed by Alexey Proskuryakov.

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::offsetX):
(WebCore::MouseRelatedEvent::offsetY):

LayoutTests:

Add a test documenting the behavior of offsetX/Y on the simulated
mouse events that get sent by HTMLElement.click().

Reviewed by Alexey Proskuryakov.

  • fast/events/relative-offset-of-simulated-click-expected.txt: Added.
  • fast/events/relative-offset-of-simulated-click.html: Added.
10:36 AM Changeset in webkit [164870] by Brent Fulgham
  • 4 edits in branches/safari-537.75-branch

Source/WTF: Unreviewed build fix: Pass build environment to sub-processes via command line.
<rdar://problem/16197002>

  • WTF.vcxproj/build-generated-files.sh: Pass WEBKIT_LIBRARIES via argument, rather than

relying on global environment.

WebKitLibraries: Unreviewed build fix: Pass WEBKIT_LIBRARIES as argument to sub-process build steps.
<rdar://problem/16197002>

  • win/tools/vsprops/common.props: Pass WEBKIT_LIBRARIES directly to sub-processes, rather

than relying on global environment already having these values set.

10:34 AM Changeset in webkit [164869] by svillar@igalia.com
  • 7 edits
    4 adds in trunk

[CSS Grid Layout] Fix positioning grid items using named grid lines/areas
https://bugs.webkit.org/show_bug.cgi?id=129372

Reviewed by Darin Adler.

Source/WebCore:

Our code was assuming that a <custom-ident> in
-webkit-grid-{column|row}-{start|end} and
-webkit-grid-{column|row} was always a grid area name. That's
wrong because the <custom-ident> could be also a explicitly named
grid line or the an implicitly named grid line created by a grid
area definition.

The style resolution code was not correct either. This patch fixes
it so it now matches the spec, which means that:

  • first we try to match any existing grid area.
  • then if there is a named grid line with the name

<custom-ident>-{start|end} for -webkit-grid-{column|row}-{start|end}
defined before the grid area then we use it instead of the grid
area.

  • otherwise if there is a named grid line we resolve to the first such line.
  • otherwise we treat it as 'auto'.

Fixing this uncovered a bug in GridPosition, we were not using the
name of the stored grid area to check if two GridPositions were
the same.

Tests: fast/css-grid-layout/grid-item-position-changed-dynamic.html

fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html

  • css/StyleResolver.cpp:

(WebCore::gridLineDefinedBeforeGridArea): New function to check if
a given named grid line was defined before an implicit named grid
line created by a grid area definition.
(WebCore::StyleResolver::adjustNamedGridItemPosition): New
function that adjusts the position of a GridPosition parsed as a
grid area.
(WebCore::StyleResolver::adjustGridItemPosition): Use the new
function adjustNamedGridItemPosition to adjust the positions of
named grid lines.

  • css/StyleResolver.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveNamedGridLinePositionFromStyle): Use GridPosition:: namespace.
(WebCore::RenderGrid::resolveGridPositionFromStyle): Ditto.
(WebCore::RenderGrid::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition): Ditto.

  • rendering/RenderGrid.h:
  • rendering/style/GridPosition.h:

(WebCore::GridPosition::adjustGridPositionForRowEndColumnEndSide): Moved from RenderGrid.cpp.
(WebCore::GridPosition::adjustGridPositionForSide): Ditto.
(WebCore::GridPosition::operator==): Use the named grid line to check equality.

LayoutTests:

Added a new test that checks that we correctly position grid items
using named grid lines, grid areas and also with the implicit
named grid lines created by grid areas.

I'm also importing a test from Blink that checks that we can
dynamically change the position of a grid item by changing the
name of the grid lines used to position it.

  • fast/css-grid-layout/grid-item-position-changed-dynamic-expected.txt:

Merged from Blink r153913 by <jchaffraix@chromium.org>.

  • fast/css-grid-layout/grid-item-position-changed-dynamic.html: Ditto.
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution-expected.txt: Added.
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html: Added.
10:14 AM Changeset in webkit [164868] by zoltan@webkit.org
  • 4 edits in trunk/Source/WebCore

[CSS Shapes] Update line segments for ShapeInside only if the new line is wide enough
https://bugs.webkit.org/show_bug.cgi?id=129461

Reviewed by David Hyatt.

Shape-inside can make a line only narrower than the original line width, thus we don't need
to update the line/shape segments in fitBelowFloats for every single line inside shape-inside.
This patch adds a helper function, which updates the line segments, furthermore it updates the
line segments only when the content would fit without the shape.

No new tests, no behavior change.

  • rendering/line/BreakingContextInlineHeaders.h: Use new helper.

(WebCore::updateSegmentsForShapes):

  • rendering/line/LineWidth.cpp: Use new helper.

(WebCore::LineWidth::updateLineSegment): Add new helper.
(WebCore::LineWidth::fitBelowFloats):

10:12 AM Changeset in webkit [164867] by mario.prada@samsung.com
  • 7 edits in trunk

paragraphs with different directionality in textarea with unicode-bidi: plaintext are aligned the same
https://bugs.webkit.org/show_bug.cgi?id=71194

Reviewed by David Hyatt.

Merged from Blink r157263 by <igor.o@sisa.samsung.com>
<https://src.chromium.org/viewvc/blink?revision=157263&view=revision>

Source/WebCore:

In the css3-text spec (http://www.w3.org/TR/css3-text/#bidi-linebox):

The start and end edges of a line box are determined by the inline
base direction of the line box. In most cases, this is given by
its containing block's computed ‘direction’. However if its
containing block has ‘unicode-bidi: plaintext’, the inline base
direction the line box must be determined by the base direction of
the bidi paragraph to which it belongs: that is, the bidi
paragraph for which the line box holds content.

This patch just implements the behavior described above modifying
updateLogicalWidthForAlignment and setting the bidi level of the
RootInlineBox.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateLogicalWidthForAlignment):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):
(WebCore::RenderBlockFlow::createLineBoxesFromBidiRuns):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::deleteEllipsisLineBoxes):
(WebCore::RenderBlockFlow::checkLinesForTextOverflow):
(WebCore::RenderBlockFlow::startAlignedOffsetForLine):

LayoutTests:

Modified expectations for two layout tests to make them conforming to the spec.

  • fast/text/international/unicode-bidi-plaintext-expected.html:
  • platform/gtk/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
  • platform/mac-mountainlion/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.txt:
10:09 AM Changeset in webkit [164866] by jochen@chromium.org
  • 3 edits
    2 adds in trunk

Update meta-referrer behavior for invalid policies
https://bugs.webkit.org/show_bug.cgi?id=129475

Source/WebCore:

This patch aligns the behavior with the CSP 1.1 referrer directive,
where the fallback for an invalid value is the "never" policy.

Original patch from Mike West: https://src.chromium.org/viewvc/blink?view=rev&revision=165627

Reviewed by Alexey Proskuryakov.

Test: http/tests/security/referrer-policy-invalid.html

  • dom/Document.cpp:

(WebCore::Document::processReferrerPolicy):

LayoutTests:

Reviewed by Alexey Proskuryakov.

  • http/tests/security/referrer-policy-invalid-expected.txt: Added.
  • http/tests/security/referrer-policy-invalid.html: Added.
9:53 AM Changeset in webkit [164865] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
https://bugs.webkit.org/show_bug.cgi?id=129163

Reviewed by David Kilzer.

Fixes an issue where DumpRenderTree Perl Support may build with the specified
iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
bundle.

Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
which is specified either explicitly when building with MAKE(1) or implicitly by
build-{dumprendertree, webkit}. Instead we should always build Perl Support using
the OS X SDK and toolchain since the built products are only applicable to OS X.

  • DumpRenderTree/ios/PerlSupport/Makefile:
9:46 AM Changeset in webkit [164864] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix !ENABLE(GGC) builds

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::gatherJSStackRoots): Also fix one of the names of the GC phases.

9:30 AM Changeset in webkit [164863] by dbates@webkit.org
  • 3 edits
    2 adds in trunk

SubresourceLoader::didFinishLoading() should not assert when a decode error occurs
https://bugs.webkit.org/show_bug.cgi?id=127029

Reviewed by Darin Adler.

Source/WebCore:

SubresourceLoader::didFinishLoading() can be called for a resource (e.g. an image) that
failed to be decoded or, in the case of an image, whose estimated decoded size exceeds
the maximum decoded size (Settings::maximumDecodedImageSize()).

Test: fast/images/decoded-size-exceeds-max-decoded-size.html

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

LayoutTests:

Added a test to ensure that we don't cause an assertion failure when an image fails
to load because of a decode error. In particular, the estimated decoded image size
exceeds the maximum decoded image size.

  • fast/images/decoded-size-exceeds-max-decoded-size-expected.txt: Added.
  • fast/images/decoded-size-exceeds-max-decoded-size.html: Added.
8:56 AM Changeset in webkit [164862] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Clean up Heap::collect and Heap::markRoots
https://bugs.webkit.org/show_bug.cgi?id=129464

Reviewed by Geoffrey Garen.

These functions have built up a lot of cruft recently.
We should do a bit of cleanup to make them easier to grok.

  • heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::gatherStackRoots):
(JSC::Heap::gatherJSStackRoots):
(JSC::Heap::gatherScratchBufferRoots):
(JSC::Heap::clearLivenessData):
(JSC::Heap::visitSmallStrings):
(JSC::Heap::visitConservativeRoots):
(JSC::Heap::visitCompilerWorklists):
(JSC::Heap::markProtectedObjects):
(JSC::Heap::markTempSortVectors):
(JSC::Heap::markArgumentBuffers):
(JSC::Heap::visitException):
(JSC::Heap::visitStrongHandles):
(JSC::Heap::visitHandleStack):
(JSC::Heap::traceCodeBlocksAndJITStubRoutines):
(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::clearRememberedSet):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::collect):
(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::suspendCompilerThreads):
(JSC::Heap::willStartCollection):
(JSC::Heap::deleteOldCode):
(JSC::Heap::flushOldStructureIDTables):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::stopAllocation):
(JSC::Heap::reapWeakHandles):
(JSC::Heap::sweepArrayBuffers):
(JSC::Heap::snapshotMarkedSpace):
(JSC::Heap::deleteSourceProviderCaches):
(JSC::Heap::notifyIncrementalSweeper):
(JSC::Heap::rememberCurrentlyExecutingCodeBlocks):
(JSC::Heap::resetAllocators):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::resumeCompilerThreads):

  • heap/Heap.h:
8:35 AM Changeset in webkit [164861] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result) in WebCore::RenderGeometryMap::mapToContainer
https://bugs.webkit.org/show_bug.cgi?id=119626

Source/WebCore:

SVGRenderSupport::mapLocalToContainer() was trying to apply transforms
in the incorrect order. Specifically, it would attempt to apply its
localToParentTransform before its localToBorderBoxTransform. This
was causing an ASSERT to fail when the computed transforms didn't
match up to those computed by RenderGeometryMap.

Backported from Blink: https://codereview.chromium.org/143363004

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-02-28
Reviewed by Simon Fraser.

Test: svg/transforms/svg-geometry-crash.html

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::mapLocalToContainer):

LayoutTests:

Backported from Blink: https://codereview.chromium.org/143363004

Patch by Martin Hodovan <mhodovan@inf.u-szeged.hu> on 2014-02-28
Reviewed by Simon Fraser.

  • svg/transforms/svg-geometry-crash-expected.txt: Added.
  • svg/transforms/svg-geometry-crash.html: Added.
7:52 AM Changeset in webkit [164860] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk

Unreviewed, rolling out r164859.
http://trac.webkit.org/changeset/164859
https://bugs.webkit.org/show_bug.cgi?id=129483

caused WK1 crashes (DumpRenderTree) (Requested by zalan on
#webkit).

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(dumpRenderTree):
(runTest):

  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):

LayoutTests:

  • fast/borders/hidpi-simple-hairline-border-painting-expected.html: Removed.
  • fast/borders/hidpi-simple-hairline-border-painting.html: Removed.
7:24 AM Changeset in webkit [164859] by Alan Bujtas
  • 11 edits
    2 adds in trunk

Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
https://bugs.webkit.org/show_bug.cgi?id=129438

Reviewed by Simon Fraser.

'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
offscreen window. It makes testing subpixel rendering and positioning possible.

Both the offscreen window's and WebKit's scaling are set accordingly.

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow): unrelated cleanup.
(destroyWebViewAndOffscreenWindow): unrelated cleanup.
(dumpRenderTree):
(changeOffscreenWindowScaleIfNeeded):
(runTest):

  • DumpRenderTree/mac/DumpRenderTreeWindow.h:
  • DumpRenderTree/mac/DumpRenderTreeWindow.mm:

(-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::changeOffscreenWindowScaleIfNeeded):
(WTR::TestInvocation::invoke):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):

LayoutTests:

  • fast/borders/hidpi-simple-hairline-border-painting-expected.html: Added.
  • fast/borders/hidpi-simple-hairline-border-painting.html: Added.
6:34 AM Changeset in webkit [164858] by mihnea@adobe.com
  • 4 edits
    2 adds in trunk

[CSSRegions] ASSERTION FAILED: !m_regionsInvalidated in RenderFlowThread::regionAtBlockOffset
https://bugs.webkit.org/show_bug.cgi?id=129371

Source/WebCore:

Reviewed by Andrei Bucur.

regionAtBlockOffset method is meant to be used after the flow thread validated
its region chain, otherwise we cannot rely on regionAtBlockOffset to determine correctly
the target region based on the offset in flow thread coordinates.

When the video element is collected in a named flow and displayed in a region, we ensure
that the region's decorations are taken into account to properly position the video.
However, we have to do that only if the named flow regions are validated.

I changed the method cachedRegionForCompositedLayer to check only the "cached" region
for a layer and not update the layer to region mappings before returning the region.
Because method cachedRegionForCompositedLayer does not update the region - layer mappings,
the code does not call regionAtBlockOffset in situations where the region chain is not validated yet.

Test: compositing/regions/video-in-overflow-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::getLayerListForRegion): Make it a getter that relies on
cached information and refrain from updating the mappings. Make it const too.
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):

  • rendering/RenderFlowThread.h:

LayoutTests:

Reviewed Andrei Bucur.

  • compositing/regions/video-in-overflow-region-expected.txt: Added.
  • compositing/regions/video-in-overflow-region.html: Added.
2:06 AM Changeset in webkit [164857] by calvaris@igalia.com
  • 4 edits in trunk/Source/WebCore

[GTK] Finetune captions menu as per design team
https://bugs.webkit.org/show_bug.cgi?id=129432

Reviewed by Eric Carlson.

Some design fine tuning of the captions dialog was required.

No new tests, current suffice.

  • Modules/mediacontrols/mediaControlsApple.js:

Added out class.

  • Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.buildCaptionMenu): Setting out class when
menu is going to show overlap the panel right border.

  • css/mediaControlsGtk.css:

(video::-webkit-media-controls-closed-captions-container.out):
Setting all borders to 5px;
(video::-webkit-media-controls-closed-captions-container h3):
Reduced font size and increasing top padding.
(video::-webkit-media-controls-closed-captions-container ul):
Increased top padding.

Note: See TracTimeline for information about the timeline view.