Timeline
Jun 30, 2014:
- 9:16 PM Changeset in webkit [170630] by
-
- 7 edits in trunk/Source
Unreviewed, rolling out r170605.
https://bugs.webkit.org/show_bug.cgi?id=134484
The changes cause crashes on ARM64 (Requested by benjaminp on
#webkit).
Reverted changeset:
"Reduce dynamic memory allocation in css jit."
https://bugs.webkit.org/show_bug.cgi?id=134416
http://trac.webkit.org/changeset/170605
- 8:12 PM Changeset in webkit [170629] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] The long press gesture recognizers should not block the pinch gesture
https://bugs.webkit.org/show_bug.cgi?id=134477
<rdar://problem/17514936>
Reviewed by Tim Horton.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:canPreventGestureRecognizer:]):
- 7:19 PM Changeset in webkit [170628] by
-
- 8 edits21 adds in branches/ftlopt
Merge r169121 from trunk.
2014-05-19 Mark Hahnenberg <mhahnenberg@apple.com>
JSArray::shiftCountWith* could be more efficient
https://bugs.webkit.org/show_bug.cgi?id=133011
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Our current implementations of shiftCountWithAnyIndexingType and shiftCountWithArrayStorage
are scared of the presence of any holes in the array. We can mitigate this somewhat by enabling
them to correctly handle holes, thus avoiding the slowest of slow paths in most cases.
- runtime/ArrayStorage.h: (JSC::ArrayStorage::indexingHeader): (JSC::ArrayStorage::length): (JSC::ArrayStorage::hasHoles):
- runtime/IndexingHeader.h: (JSC::IndexingHeader::publicLength): (JSC::IndexingHeader::from):
- runtime/JSArray.cpp: (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::shiftCountWithAnyIndexingType): (JSC::JSArray::unshiftCountWithArrayStorage):
- runtime/JSArray.h: (JSC::JSArray::shiftCountForShift): (JSC::JSArray::shiftCountForSplice): (JSC::JSArray::shiftCount):
- runtime/Structure.cpp: (JSC::Structure::holesRequireSpecialBehavior):
- runtime/Structure.h:
LayoutTests:
Added a performance regression test which tests the contiguous shift case. We're ~85% faster
on this microbenchmark with this patch.
Also added a bunch of tests for each permutation of contiguous/array storage with no holes, holes,
and holes that require special behavior (e.g. indexed properties in the prototype chain).
- js/array-storage-splice-holes-expected.txt: Added.
- js/array-storage-splice-holes-require-special-behavior-expected.txt: Added.
- js/array-storage-splice-holes-require-special-behavior.html: Added.
- js/array-storage-splice-holes.html: Added.
- js/array-storage-splice-no-holes-expected.txt: Added.
- js/array-storage-splice-no-holes.html: Added.
- js/contiguous-splice-holes-expected.txt: Added.
- js/contiguous-splice-holes-require-special-behavior-expected.txt: Added.
- js/contiguous-splice-holes-require-special-behavior.html: Added.
- js/contiguous-splice-holes.html: Added.
- js/contiguous-splice-no-holes-expected.txt: Added.
- js/contiguous-splice-no-holes.html: Added.
- js/regress/array-splice-contiguous-expected.txt: Added.
- js/regress/array-splice-contiguous.html: Added.
- js/regress/script-tests/array-splice-contiguous.js: Added. (foo):
- js/script-tests/array-storage-splice-holes-require-special-behavior.js: Added.
- js/script-tests/array-storage-splice-holes.js: Added.
- js/script-tests/array-storage-splice-no-holes.js: Added.
- js/script-tests/contiguous-splice-holes-require-special-behavior.js: Added.
- js/script-tests/contiguous-splice-holes.js: Added.
- js/script-tests/contiguous-splice-no-holes.js: Added.
- 6:40 PM Changeset in webkit [170627] by
-
- 3 edits in trunk/Source/WebKit2
Add WebPageProxy::restoreFromState
https://bugs.webkit.org/show_bug.cgi?id=134480
Reviewed by Tim Horton.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::restoreFromState):
- UIProcess/WebPageProxy.h:
- 6:29 PM Changeset in webkit [170626] by
-
- 4 edits in trunk/Source/WebKit2
Add a function to restore a WebBackForwardList object from a BackForwardListState object
https://bugs.webkit.org/show_bug.cgi?id=134478
Reviewed by Tim Horton.
- UIProcess/WebBackForwardList.cpp:
(WebKit::generateWebBackForwardItemID):
(WebKit::WebBackForwardList::restoreFromState):
- UIProcess/WebBackForwardList.h:
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::generateWebBackForwardItemID): Deleted.
- 6:06 PM Changeset in webkit [170625] by
-
- 10 edits in trunk/Source
Change the AddBackForwardItem message to take a page state object
https://bugs.webkit.org/show_bug.cgi?id=134475
Reviewed by Andreas Kling.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::create):
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setPageState):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::addBackForwardItem):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::updateBackForwardItem):
- 5:50 PM Changeset in webkit [170624] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Add a flatter find-in-page current match indicator style
https://bugs.webkit.org/show_bug.cgi?id=134434
<rdar://problem/16225673>
Reviewed by Simon Fraser.
- UIProcess/FindIndicator.cpp:
(WebKit::findIndicatorsForTextRectsOverlap):
(WebKit::FindIndicator::frameRect):
(WebKit::flatHighlightColor):
(WebKit::flatRimShadowColor):
(WebKit::flatDropShadowColor):
(WebKit::FindIndicator::draw):
Add a flatter find indicator, with a bigger shadow.
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):
(WebKit::FindController::getFindIndicatorBitmapAndRect):
(WebKit::FindController::hideFindIndicator):
(WebKit::FindController::drawRect):
Don't paint a shadow behind the secondary matches if we're using the new style.
- 5:45 PM Changeset in webkit [170623] by
-
- 3 edits in trunk/Tools
[iOS] GSFontAddCGFont is deprecated and we use it in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=134133
Reviewed by Simon Fraser.
Replace it with CTFontManagerRegisterGraphicsFont
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontIOS):
- 5:42 PM Changeset in webkit [170622] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] Improve double-tap-to-scroll on image documents
https://bugs.webkit.org/show_bug.cgi?id=134474
<rdar://problem/17496778>
Reviewed by Enrica Casucci.
On image document, we were always rendering the center of the image as the origin, which broke
double tap to scroll.
This patch improves on this in two ways:
1) If the hit testing already got the image, only change the type to replaced (to get the right
scaling behavior for images since the type is block on iOS's image document).
2) If the hit testing is outside the image, only center the axis that is not in the image.
This way, we "fix" the component that is not valid, and keep the vali component.
This works great for viewing comics on iPad.
- WebProcess/WebPage/ViewGestureGeometryCollector.cpp:
(WebKit::ViewGestureGeometryCollector::collectGeometryForSmartMagnificationGesture):
- 5:38 PM Changeset in webkit [170621] by
-
- 2 edits in trunk/Source/WebCore
[iOS][WK2] Do not put tap highlight on images that are not in links, and on applet/embed/object
https://bugs.webkit.org/show_bug.cgi?id=134471
<rdar://problem/17513542>
Reviewed by Enrica Casucci.
UIKit has some special code to avoid tap highlight on certain type of object. This is not very flexible
since the page has no way of overriding that behavior.
This patch implement the same feature by changing the default stylesheet. The tap highlight is disabled
by default for those object, and enabled for images that are in a link.
- css/html.css:
(applet, embed, object, img):
(:-webkit-any-link img):
- 5:27 PM Changeset in webkit [170620] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (WK2): Weird selection behavior on autos.yahoo.com, en.wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=134466
<rdar://problem/16817263>
Reviewed by Benjamin Poulain.
Avoid selecting blocks across frame boundaries and skip non-selectable
blocks. If the only block we find is almost the same height as the
visible area, we should not select at all.
This patch also fixes the logic to compute the next block when
shrinking the selection. When calculating the new range after shrinking,
we should not include the block that corresponds to the current handle position.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::WebPage::contractedRangeFromHandle):
(WebKit::WebPage::updateSelectionWithTouches):
- 5:17 PM Changeset in webkit [170619] by
-
- 3 edits4 adds in trunk
All Indic text is rendered as boxes on iOS
https://bugs.webkit.org/show_bug.cgi?id=134464
Reviewed by Simon Fraser.
Source/WebCore:
I made a typo in r170207.
Test: fast/text/indic.html
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
LayoutTests:
Simply draw some indic text and test that against currently good metric values.
- fast/text/indic.html: Added
- platform/ios-sim/fast/text/indic-expected.txt: Added.
- platform/mac/fast/text/indic-expected.txt: Added.
- platform/mac/fast/text/indic-expected.png: Added.
- 5:14 PM Changeset in webkit [170618] by
-
- 2 edits in trunk/Source/WebCore
[iOS] languageSpecificFallbackFont() is not consistent
https://bugs.webkit.org/show_bug.cgi?id=134473
Reviewed by Darin Adler.
It can use "<" throughout the function as well as keeping the fallthrough behavior consistent.
No tests because there is no behavior change.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::languageSpecificFallbackFont):
- 5:11 PM Changeset in webkit [170617] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed gardening.
- WebCore.vcxproj/WebCore.vcxproj: Do not compile JSFileException
and JSFileReaderSync multiple times.
- 5:04 PM Changeset in webkit [170616] by
-
- 2 edits in trunk/Source/WebCore
Avoid copying function object in lambda function in ScrollingThread::dispatchBarrier(); actually use move semantics
https://bugs.webkit.org/show_bug.cgi?id=134470
Reviewed by Anders Carlsson.
Currently we always copy construct the captured std::function object when calling callOnMainThread()
in the lambda function created in ScrollingThread::dispatchBarrier() because captured variables are
const in a lambda expression's body by default. That is, the std::function object is captured as const.
Instead, we should mark this lambda expression as mutable so the captured std::function object is
non-const and hence we can use move semantics when passing it to callOnMainThread().
- page/scrolling/ScrollingThread.cpp:
(WebCore::ScrollingThread::dispatchBarrier):
- 5:00 PM Changeset in webkit [170615] by
-
- 2 edits in trunk/Source/WTF
Make TransformIterator::TransformIterator() take rvalue references
https://bugs.webkit.org/show_bug.cgi?id=134468
Reviewed by Darin Adler.
It's unnecessary to support TransformIterator::TransformIterator() taking const lvalue references
as we only call it with rvalues. As a side benefit, we can use move semantics to initialize the
members of TransformIterator.
- wtf/IteratorAdaptors.h:
(WTF::TransformIterator::TransformIterator): Make constructor take arguments as rvalue references.
(WTF::makeTransformIterator): Substitute std::move() for std::forward().
- 4:39 PM Changeset in webkit [170614] by
-
- 5 edits in trunk/Source/WebKit2
WebBackForwardListItem should not store back-forward data
https://bugs.webkit.org/show_bug.cgi?id=134469
Reviewed by Darin Adler.
Change WebBackForwardListItem::backForwardData to encode the main frame state lazily,
and change WebBackForwardListItem::setBackForwardData to decode it into the main frame state.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::backForwardData):
(WebKit::WebBackForwardListItem::setBackForwardData):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::backForwardData): Deleted.
- UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- 4:26 PM Changeset in webkit [170613] by
-
- 3 edits in trunk/Source/WebKit2
WebBackForwardListItems should hold on to PageState objects
https://bugs.webkit.org/show_bug.cgi?id=134467
Reviewed by Darin Adler.
- Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::WebBackForwardListItem):
(WebKit::WebBackForwardListItem::encode):
- Shared/WebBackForwardListItem.h:
(WebKit::WebBackForwardListItem::setOriginalURL):
(WebKit::WebBackForwardListItem::originalURL):
(WebKit::WebBackForwardListItem::setURL):
(WebKit::WebBackForwardListItem::url):
(WebKit::WebBackForwardListItem::setTitle):
(WebKit::WebBackForwardListItem::title):
- 4:24 PM Changeset in webkit [170612] by
-
- 2 edits in trunk/Source/WebKit2
Add a missing semicolon in WKContentViewInteraction
- UIProcess/ios/WKContentViewInteraction.mm:
(nsSizeForTapHighlightBorderRadius):
I messed up this when fixing the patch on landing.
- 4:05 PM Changeset in webkit [170611] by
-
- 6 edits in trunk/Source
Adopt the legacy session decoding inside WebPage::restoreSession for now
https://bugs.webkit.org/show_bug.cgi?id=134465
Reviewed by Sam Weinig.
Source/WebCore:
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::restoreSession):
- 3:58 PM Changeset in webkit [170610] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Don't crash on status bar tap with overflow scroll views
https://bugs.webkit.org/show_bug.cgi?id=134459
Reviewed by Tim Horton.
The tiled scrolling indicator parents UIViews under CALayers, but that causes
those views to miss -willMoveToWindow:nil notifications on teardown. This can leave
deleted UIScrollViews in UIKit's "scroll to top" list.
Fix by not making UIScrollViews in the debug layer tree host.
- UIProcess/ios/RemoteLayerTreeHostIOS.mm:
(WebKit::RemoteLayerTreeHost::createLayer):
- 3:52 PM Changeset in webkit [170609] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r170578.
https://bugs.webkit.org/show_bug.cgi?id=134462
causes assertions loading nytimes.com on iOS (Requested by
smfr on #webkit).
Reverted changeset:
"Create NSURLRequest lazily when USE(CFNETWORK) is enabled"
https://bugs.webkit.org/show_bug.cgi?id=134441
http://trac.webkit.org/changeset/170578
- 3:51 PM Changeset in webkit [170608] by
-
- 10 edits in trunk/Source/WebKit2
Restrict network process sandbox
https://bugs.webkit.org/show_bug.cgi?id=134360
Reviewed by Sam Weinig.
Add more restrictions to the network process sandbox.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
Always use the cache directory provided in the initialization parameters,
and make sure we consume the cookie directory extension.
- Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Make the sandbox profile much more restrictive.
- Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
- Shared/Network/NetworkProcessCreationParameters.h:
The network process now requires an extension to access
its cookie storage.
- Shared/mac/SandboxUtilities.cpp: (WebKit::pathForProcessContainer):
- Shared/mac/SandboxUtilities.h:
We need to be able to get hold of our container so
that we can get the correct cookie storage directory.
- UIProcess/WebContext.cpp: (WebKit::WebContext::ensureNetworkProcess):
We have to pass in the an extension for the cookie storage directory when
initalising the network process
- UIProcess/mac/WebContextMac.mm: (WebKit::WebContext::platformDefaultCookieStorageDirectory):
Make sure we provide the correct location on IOS
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Consume the cookie storage extension
- 3:50 PM Changeset in webkit [170607] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Turn off scrollsToTop on overflow UIScrollViews
https://bugs.webkit.org/show_bug.cgi?id=134456
Reviewed by Tim Horton.
Set scrollsToTop to NO on our UIScrollViews created for overflow scrolling, since
we don't have a good strategy for when to allow it, and doing so would also require
some smarts in the main UIScrollView.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
- 3:50 PM Changeset in webkit [170606] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (Okemo): The contextual menu on tap and hold does not cancel the other gestures.
https://bugs.webkit.org/show_bug.cgi?id=134463
<rdar://problem/17388907>
Reviewed by Benjamin Poulain.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):
- 3:48 PM Changeset in webkit [170605] by
-
- 7 edits in trunk/Source
Reduce dynamic memory allocation in css jit.
https://bugs.webkit.org/show_bug.cgi?id=134416
Reviewed by Benjamin Poulain.
Source/WebCore:
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::FunctionCall):
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
- cssjit/RegisterAllocator.h:
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generatePrologue):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
Use inlineCapacity template parameter to reduce malloc calls.
I use 16 and 32 as the inline capacity for non-register related vectors because that
is probably big enough for the selector compiler, and if it is not then a malloc
call will not be significant because the selector is very complex.
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::push):
Pass a vector of stack references to match calls to pop and to avoid a call to appendVector.
Source/WTF:
- wtf/Deque.h:
Added inlineCapacity optional template parameter.
- 3:22 PM Changeset in webkit [170604] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
CodeBlock::stronglyVisitWeakReferences should mark DFG::CommonData::weakStructureReferences
https://bugs.webkit.org/show_bug.cgi?id=134455
Reviewed by Geoffrey Garen.
Otherwise we get hanging pointers which can cause us to die later.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitWeakReferences):
- 3:14 PM Changeset in webkit [170603] by
-
- 2 edits in trunk/Source/WebKit2
Implement the last pieces of encodeFrameStateNode
https://bugs.webkit.org/show_bug.cgi?id=134460
Reviewed by Andreas Kling.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::isValidEnum):
(WebKit::encodeFormDataElement):
(WebKit::encodeFormData):
(WebKit::encodeFrameStateNode):
- 3:13 PM Changeset in webkit [170602] by
-
- 3 edits in trunk/LayoutTests
js/script-tests/function-apply-many-args.js fails on ARM
https://bugs.webkit.org/show_bug.cgi?id=126588
Reviewed by Mark Lam.
Removed three test cases that fail on some platforms and pass on others due
to stack size. Other test cases cover what will fit on a stack or what will
throw an out of stack exception.
- js/function-apply-many-args-expected.txt:
- js/script-tests/function-apply-many-args.js:
- 3:12 PM Changeset in webkit [170601] by
-
- 6 edits in trunk
Add option to run-jsc-stress-testes to filter out tests that use large heaps
https://bugs.webkit.org/show_bug.cgi?id=134458
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added test to skip js1_5/Regress/regress-159334.js when testing on a memory limited device.
- tests/mozilla/mozilla-tests.yaml:
Tools:
Added new --memory-limited to filter out tests that have large heap usage.
Such tests are either tagged with @largeHeap or logic is added to their .yaml file.
- Scripts/run-jsc-stress-tests:
LayoutTests:
- js/regress/script-tests/lots-of-fields.js: Added @largeHeap tag to skip when
running on a memoryLimited device.
- 3:10 PM Changeset in webkit [170600] by
-
- 5 edits in trunk/Source/WebKit2
[iOS][WK2] Move tap highlight to the inverseScaleRootView
https://bugs.webkit.org/show_bug.cgi?id=134424
<rdar://problem/17480880>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-30
Reviewed by Tim Horton.
Enrica introduced the inverseScaleRootView that is a dynamic version of _highlightRootView.
This patch moves the tap highlight from its own inverse root to inverseScaleRootView. This provides better handling
of scale, better behavior on crash, and remove one extra view from the hierarchy.
The code is pretty much the same, just moved around. Some of the changes:
Now the code needs to handle repainting live when the view scale. To do that, _showTapHighlightXXX was split in two:
-_showTapHighlight to setup the view.
-_updateTapHighlight to update the view based on the current scale.
Since the view updates live on scaling, we need to recompute the coordinates for each update. To do that, the _potentialTapHighlightInformation
was generalized to handle all cases of highlight.
Since we can no longer test for the nullity of _potentialTapHighlightInformation,
a new attribute is introduced for that: _hasTapHighlightForPotentialTap.
The last bit of change concern reentering the tap highlight. This becomes quite simple:
1) _isTapHighlightIDValid is updated before the animation starts
so that it can be set again during an animation.
2) The animation checks the "finished" flags before removing the view from its superview
to avoid breaking the new animation.
- UIProcess/API/Cocoa/WKWebView.mm:
(withinEpsilon): Deleted.
- UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:]):
Make _updateUnscaledView conditional to scale changes, that thing isn't cheap!
- UIProcess/ios/WKContentViewInteraction.h:
(withinEpsilon):
Move withinEpsilon() from WKContentView to use it from both classes.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]):
(-[WKContentView _updateUnscaledView]):
(-[WKContentView _updateTapHighlight]):
(-[WKContentView _showTapHighlight]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _cancelInteraction]):
(-[WKContentView _finishInteraction]):
(-[WKContentView _singleTapDidReset:]):
(-[WKContentView _singleTapCommited:]):
(-[WKContentView _showTapHighlightWithColor:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]): Deleted.
- 2:53 PM Changeset in webkit [170599] by
-
- 5 edits in trunk/Source
Add code for encoding legacy session history entries
https://bugs.webkit.org/show_bug.cgi?id=134452
Reviewed by Andreas Kling.
Source/WebKit2:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::HistoryEntryDataEncoder::HistoryEntryDataEncoder):
(WebKit::HistoryEntryDataEncoder::operator<<):
(WebKit::HistoryEntryDataEncoder::finishEncoding):
(WebKit::HistoryEntryDataEncoder::encodeArithmeticType):
(WebKit::HistoryEntryDataEncoder::encodeFixedLengthData):
(WebKit::HistoryEntryDataEncoder::grow):
(WebKit::HistoryEntryDataEncoder::growCapacity):
(WebKit::encodeFrameStateNode):
(WebKit::encodeLegacySessionHistoryEntryData):
(WebKit::decodeSessionHistoryEntryData):
(WebKit::decodeLegacySessionHistoryEntryData):
- UIProcess/mac/LegacySessionStateCoding.h:
Source/WTF:
- wtf/MallocPtr.h:
(WTF::MallocPtr::malloc):
(WTF::MallocPtr::realloc):
- 2:25 PM Changeset in webkit [170598] by
-
- 3 edits in trunk/Source/WebCore
Use non-thumb registers in armv7 css jit.
https://bugs.webkit.org/show_bug.cgi?id=134450
Reviewed by Geoff Garen.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isValidRegister):
(WebCore::RegisterAllocator::isCallerSavedRegister):
Use additional general purpose registers.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):
Always succeed when compiling css selectors.
- 2:21 PM Changeset in webkit [170597] by
-
- 5 edits2 adds in trunk
Tiles on bottom of screen are not always allocated when necessary
https://bugs.webkit.org/show_bug.cgi?id=134272
Reviewed by Simon Fraser.
Source/WebCore:
The initial visibleRect is in the coordinate of the root layer, so its origin
is at the top left of the view. The initial rect we were using doesn't
include the contents inset, so it was too short, which was causing tiles near
the bottom of the screen to not always be allocated if the tile threshold was
close to the bottom of the view. Instead, we want to include the contents
inset size so the visible rect includes the entire view.
GraphicsLayerCA::recursiveCommitChanges() takes care of mapping and cropping
the visible rect into the tiled layer's coordinate system, at which point it
is used for visible tile logic.
Test: platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html
- platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::update):
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
LayoutTests:
Apply a content inset, then dump visible rects.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset-expected.txt: Added.
- platform/mac-wk2/tiled-drawing/visible-rect-content-inset.html: Added.
- compositing/visible-rect/iframe-no-layers.html: For WK2, the size of the visibleRect
includes the size of the border of the iframe. In order to elliminate platform
differences, set this border to 0.
- 1:57 PM Changeset in webkit [170596] by
-
- 2 edits in trunk/Tools
DRT in iOS sim crashes while loading fonts
https://bugs.webkit.org/show_bug.cgi?id=134451
Reviewed by Geoffrey Garen.
The magic linker symbols had the same name, and were therefore being unified
to a single font file. Then, adding the same file twice was failing.
- DumpRenderTree/mac/DumpRenderTree.mm:
(activateFontsIOS):
- 12:01 PM Changeset in webkit [170595] by
-
- 3 edits in trunk/Source/WebCore
[Win] Unreviewed project gardening.
- WebCore.vcxproj/WebCore.vcxproj: Clean up path information so
files appear in appropriate places in project view.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- 11:48 AM Changeset in webkit [170594] by
-
- 4 edits in trunk/Source/JavaScriptCore
Avoid copying closed variables vector; actually use move semantics
Rubber-stamped by Oliver Hunt.
Currently we always copy the closed variables vector passed by Parser::closedVariables()
to ProgramNode::setClosedVariables() because these member functions return and take a const
rvalue reference, respectively. Instead, these member functions should take an return a non-
constant rvalue reference so that we actually move the closed variables vector from the Parser
object to the Node object.
- parser/Nodes.cpp:
(JSC::ProgramNode::setClosedVariables): Remove const qualifier for argument.
- parser/Nodes.h:
(JSC::ScopeNode::setClosedVariables): Ditto.
- parser/Parser.h:
(JSC::Parser::closedVariables): Remove const qualifier on return type.
(JSC::parse): Remove extraneous call to std::move(). Calling std::move() is unnecessary here
because Parser::closedVariables() returns an rvalue reference.
- 11:27 AM Changeset in webkit [170593] by
-
- 2 edits in tags/Safari-538.43.40/Source/WebKit2
Merged r170569. <rdar://problem/17500555>
- 11:24 AM Changeset in webkit [170592] by
-
- 2 edits in tags/Safari-538.43.40/Source/WebCore
Merged r170533. <rdar://problem/16801069>
- 11:22 AM Changeset in webkit [170591] by
-
- 2 edits in trunk/LayoutTests
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Reviewed by Mark Hahnenberg.
Reduce the loop count from 10000 to 4000 to further reduce memory requirements
on older devices.
- js/script-tests/typedarray-zero-size.js:
- 11:06 AM Changeset in webkit [170590] by
-
- 5 edits in trunk/Source/WebCore
Remove redundant repaintCompositedLayers() parameter and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=134431
Reviewed by Darin Adler.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::convertToPixelSnappedLayerCoords): Deleted.
(WebCore::RenderLayer::convertToLayerCoords): Deleted.
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::repaintCompositedLayers):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
- rendering/RenderLayerCompositor.h:
- 10:57 AM Changeset in webkit [170589] by
-
- 10 edits1 copy in trunk/Source/JavaScriptCore
JSContext Inspection: Provide a way to use a non-Main RunLoop for Inspector JavaScript Evaluations
https://bugs.webkit.org/show_bug.cgi?id=134371
Reviewed by Timothy Hatcher.
- API/JSContextPrivate.h:
- API/JSContext.mm:
(-[JSContext _debuggerRunLoop]):
(-[JSContext _setDebuggerRunLoop:]):
Private API for setting the CFRunLoop for a debugger to evaluate in.
- API/JSContextRefInternal.h: Added.
- API/JSContextRef.cpp:
(JSGlobalContextGetDebuggerRunLoop):
(JSGlobalContextSetDebuggerRunLoop):
Internal API for setting a CFRunLoop on a JSContextRef.
Set this on the debuggable.
- inspector/remote/RemoteInspectorDebuggable.h:
- inspector/remote/RemoteInspectorDebuggableConnection.h:
(Inspector::RemoteInspectorBlock::RemoteInspectorBlock):
(Inspector::RemoteInspectorBlock::~RemoteInspectorBlock):
(Inspector::RemoteInspectorBlock::operator=):
(Inspector::RemoteInspectorBlock::operator()):
Moved into the header.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::inspectorDebuggable):
Lets store the RunLoop on the debuggable instead of this core
platform agnostic class, so expose the debuggable.
- inspector/remote/RemoteInspectorDebuggableConnection.mm:
(Inspector::RemoteInspectorHandleRunSourceGlobal):
(Inspector::RemoteInspectorQueueTaskOnGlobalQueue):
(Inspector::RemoteInspectorInitializeGlobalQueue):
Rename the global functions for clarity.
(Inspector::RemoteInspectorHandleRunSourceWithInfo):
Handler for private run loops.
(Inspector::RemoteInspectorDebuggableConnection::RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::~RemoteInspectorDebuggableConnection):
(Inspector::RemoteInspectorDebuggableConnection::dispatchAsyncOnDebuggable):
(Inspector::RemoteInspectorDebuggableConnection::setupRunLoop):
(Inspector::RemoteInspectorDebuggableConnection::teardownRunLoop):
(Inspector::RemoteInspectorDebuggableConnection::queueTaskOnPrivateRunLoop):
Setup and teardown and use private run loop sources if the debuggable needs it.
- 10:42 AM Changeset in webkit [170588] by
-
- 5 edits in tags/Safari-538.43.40/Source
Versioning.
- 10:39 AM Changeset in webkit [170587] by
-
- 1 copy in tags/Safari-538.43.40
New Tag.
- 10:37 AM Changeset in webkit [170586] by
-
- 2 edits in trunk/LayoutTests
Reduce memory required for js/typedarray-zero-size.js
https://bugs.webkit.org/show_bug.cgi?id=134448
Reviewed by Darin Adler.
Making the loop count down reduces memory usage from ~190MB to ~22MB while
still testing the original issue.
- js/script-tests/typedarray-zero-size.js:
- 9:59 AM Changeset in webkit [170585] by
-
- 11 edits in trunk/Source/WebCore
Remove webkit prefix from pointer lock.
https://bugs.webkit.org/show_bug.cgi?id=134312
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-30
Reviewed by Dean Jackson.
- dom/Document.cpp:
(WebCore::Document::exitPointerLock):
(WebCore::Document::pointerLockElement):
(WebCore::Document::webkitExitPointerLock): Deleted.
(WebCore::Document::webkitPointerLockElement): Deleted.
- dom/Document.h:
- dom/Document.idl:
- dom/Element.cpp:
(WebCore::Element::requestPointerLock):
(WebCore::Element::webkitRequestPointerLock): Deleted.
- dom/Element.h:
- dom/Element.idl:
- dom/EventNames.h:
- dom/MouseEvent.idl:
- dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::movementX):
(WebCore::MouseRelatedEvent::movementY):
(WebCore::MouseRelatedEvent::webkitMovementX): Deleted.
(WebCore::MouseRelatedEvent::webkitMovementY): Deleted.
- page/PointerLockController.cpp:
(WebCore::PointerLockController::PointerLockController):
Initialize all data members.
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::didAcquirePointerLock):
(WebCore::PointerLockController::didNotAcquirePointerLock):
(WebCore::PointerLockController::didLosePointerLock):
- 8:13 AM Changeset in webkit [170584] by
-
- 2 edits in trunk/Source/WebCore
U16_IS_SURROGATE should not be called with a UChar32
https://bugs.webkit.org/show_bug.cgi?id=134440
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::advanceByCombiningCharacterSequence):
- 7:48 AM Changeset in webkit [170583] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add missing ENABLE(DFG_JIT) guards
https://bugs.webkit.org/show_bug.cgi?id=134444
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Darin Adler.
- dfg/DFGFunctionWhitelist.cpp:
- dfg/DFGFunctionWhitelist.h:
- 7:45 AM Changeset in webkit [170582] by
-
- 3 edits in trunk/Tools
Remove Qt cruft from webkitpy
https://bugs.webkit.org/show_bug.cgi?id=134445
Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Csaba Osztrogonác.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(QtPort): Deleted.
(QtPort.build_webkit_command): Deleted.
(QtPort.run_webkit_tests_command): Deleted.
(QtWK2Port): Deleted.
(QtWK2Port.build_webkit_command): Deleted.
(QtWK2Port.run_webkit_tests_command): Deleted.
- Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest): Deleted.
(DeprecatedPortTest.test_qt_port): Deleted.
(DeprecatedPortTest.test_qt_wk2_port): Deleted.
- 1:46 AM Changeset in webkit [170581] by
-
- 5 edits in trunk/Source/WebCore
[EFL] Remove m_evasObject from Widget
https://bugs.webkit.org/show_bug.cgi?id=134442
Reviewed by Gyuyoung Kim.
Since WebKit1/EFL was dropped, we don't need to keep the m_evasObject
in the Widget.cpp because it's not used for WebKit2/Efl.
- platform/Widget.h:
(WebCore::Widget::evasObject): Deleted.
- platform/efl/ScrollbarEfl.cpp:
Removed WebKit1/Efl specific code which uses m_evasObject.
It will be a dummy until WebKit2/Efl support proper scrollbar implementation.
(WebCore::ScrollbarEfl::ScrollbarEfl):
(WebCore::ScrollbarEfl::~ScrollbarEfl):
(WebCore::ScrollbarEfl::setParent):
(WebCore::ScrollbarEfl::frameRectsChanged):
(WebCore::ScrollbarEfl::invalidate):
(ScrollbarEfl::ScrollbarEfl): Deleted.
(ScrollbarEfl::~ScrollbarEfl): Deleted.
(scrollbarEflEdjeMessage): Deleted.
(ScrollbarEfl::setParent): Deleted.
(ScrollbarEfl::updateThumbPosition): Deleted.
(ScrollbarEfl::updateThumbProportion): Deleted.
(ScrollbarEfl::updateThumbPositionAndProportion): Deleted.
(ScrollbarEfl::frameRectsChanged): Deleted.
(ScrollbarEfl::invalidate): Deleted.
- platform/efl/ScrollbarEfl.h:
Removed unnecessary methods. In addition, applied final, override keyword.
(WebCore::ScrollbarEfl::handleMouseMoveEvent): Deleted.
(WebCore::ScrollbarEfl::handleMouseOutEvent): Deleted.
(WebCore::ScrollbarEfl::handleMousePressEvent): Deleted.
(WebCore::ScrollbarEfl::handleMouseReleaseEvent): Deleted.
- platform/efl/WidgetEfl.cpp:
(WebCore::Widget::Widget):
(WebCore::Widget::setEvasObject): Deleted.
- 1:35 AM Changeset in webkit [170580] by
-
- 3 edits in trunk/Source/WebCore
Fix deprecated warning with bison 3
https://bugs.webkit.org/show_bug.cgi?id=133791
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-30
Reviewed by Csaba Osztrogonác.
No new tests because no functional changes.
- css/CSSGrammar.y.in:
- xml/XPathGrammar.y:
- 1:32 AM Changeset in webkit [170579] by
-
- 3 edits in trunk/Source/WebCore
Remove HarfBuzzShaper::setDrawRange()
https://bugs.webkit.org/show_bug.cgi?id=134243
Reviewed by Gyuyoung Kim.
setDrawRange() is not used anywhere. Remove it.
And m_fromIndex and m_toIndex are changed by only setDrawRange().
So remove them too and use the default values instead of them.
No new tests, no behavior changes.
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzShaper):
(WebCore::HarfBuzzShaper::fillGlyphBufferFromHarfBuzzRun):
currentCharacterIndex is unsigned, always greater than 0. Clean up if statements.
(WebCore::HarfBuzzShaper::setDrawRange): Deleted.
- platform/graphics/harfbuzz/HarfBuzzShaper.h:
Jun 29, 2014:
- 11:36 PM Changeset in webkit [170578] by
-
- 4 edits in trunk/Source/WebCore
Create NSURLRequest lazily when USE(CFNETWORK) is enabled
https://bugs.webkit.org/show_bug.cgi?id=134441
Reviewed by Sam Weinig.
No new tests. Should be covered by exsting tests.
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::ResourceRequest):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest):
- 9:43 PM Changeset in webkit [170577] by
-
- 2 edits2 deletes in trunk/Source/WebCore
[EFL] Remove netscape plugin implementation from WebCore
https://bugs.webkit.org/show_bug.cgi?id=134438
Reviewed by Gyuyoung Kim.
Because WebKit1/Efl was dropped, PluginPackageEfl.cpp and PluginViewEfl.cpp are not necessary.
- PlatformEfl.cmake:
- plugins/efl/PluginPackageEfl.cpp: Removed.
- plugins/efl/PluginViewEfl.cpp: Removed.
- plugins/x11/PluginViewX11.cpp: Removed.
This file is to share common code between WebKit1/Efl and WebKit1/GTk.
Now, both ports are dropped WebKit1 support and the GTK port already removed the related files at r167016.
- 9:07 PM Changeset in webkit [170576] by
-
- 30 edits19 adds in trunk
Add support for HTMLImageElement's sizes attribute
https://bugs.webkit.org/show_bug.cgi?id=133620
Reviewed by Dean Jackson.
.:
Added an ENABLE_PICTURE_SIZES compile flag.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
Source/JavaScriptCore:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
Tests: fast/dom/HTMLImageElement/sizes/image-sizes-1x.html
fast/dom/HTMLImageElement/sizes/image-sizes-2x.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html
http/tests/loading/sizes/preload-image-sizes-2x.html
http/tests/loading/sizes/preload-image-sizes.html
This patch adds support for HTMLImageElement's sizes attribute and the
related srcset extended syntax as defined in
http://picture.responsiveimages.org/.
This sizes attribute syntax is added to the CSSGrammar and parsed by
the CSSParser.
The SourceSizeList class is generated by the parser, and used to get
the final source size.
HTMLImageElement and HTMLPreloadScanner send this value to
HTMLSrcsetParser.
HTMLSrcsetParser uses this value in order to pick the right resource.
- CMakeLists.txt: Added css/SourceSizeList.cpp.
- Configurations/FeatureDefines.xcconfig: Added the PICTURE_SIZES flag.
- WebCore.vcxproj/WebCore.vcxproj: Added css/SourceSizeList.*.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added css/SourceSizeList.*.
- WebCore.xcodeproj/project.pbxproj: Added css/SourceSizeList.*.
- css/CSSGrammar.y.in: Added 4 grammar rules that define a Media condition,
Source size list, Source size length and source size.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseSizesAttribute): Parse the sizes attribute.
(WebCore::CSSParser::detectAtToken): Set the token to SIZESATTR.
- css/CSSParser.h:
- css/SourceSizeList.cpp: Added. Defined the SourceSize and SourceSizeList classes.
(WebCore::SourceSize::match):
(WebCore::computeLength):
(WebCore::defaultValue):
(WebCore::SourceSize::length):
(WebCore::SourceSizeList::parseSizesAttribute):
(WebCore::SourceSizeList::getEffectiveSize):
- css/SourceSizeList.h: Added.
(WebCore::SourceSize::SourceSize):
(WebCore::SourceSizeList::append):
- html/HTMLImageElement.cpp: Integrated sizes attribute parsing and added currentSrc.
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::currentSrc):
- html/HTMLImageElement.h:
- html/HTMLImageElement.idl:
- html/parser/HTMLDocumentParser.cpp: Added information required for sizes parsing to
HTMLPreloadScanner calls.
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::appendCurrentInputStreamToPreloadScannerAndScan):
- html/parser/HTMLPreloadScanner.cpp: Integrated sizes attribute parsing.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::scan):
- html/parser/HTMLPreloadScanner.h:
- html/parser/HTMLSrcsetParser.cpp: Added 'w' descriptor parsing sizes based normalization.
(WebCore::parseDescriptors):
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):
- html/parser/HTMLSrcsetParser.h:
Source/WebKit/mac:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
Added an ENABLE_PICTURE_SIZES compile flag.
- Configurations/FeatureDefines.xcconfig:
Tools:
Added an ENABLE_PICTURE_SIZES compile flag.
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
These layout tests check that the sizes attribute and the related
srcset syntax are well supported, that the right resource is displayed,
that the currentSrc attribute is well supported and also that the right
resource is preloaded.
- fast/dom/HTMLImageElement/resources/currentSrcHelper.js: Added.
(fileName):
(currentSrcFileName):
- fast/dom/HTMLImageElement/resources/image-set-4x.png: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-1x-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-1x.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-2x.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-change.html: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml-expected.txt: Added.
- fast/dom/HTMLImageElement/sizes/image-sizes-js-innerhtml.html: Added.
- http/tests/loading/sizes/preload-image-sizes-2x-expected.txt: Added.
- http/tests/loading/sizes/preload-image-sizes-2x.html: Added.
- http/tests/loading/sizes/preload-image-sizes-expected.txt: Added.
- http/tests/loading/sizes/preload-image-sizes.html: Added.
- 2:51 PM Changeset in webkit [170575] by
-
- 4 edits in trunk/Source/WebCore
No need to lazily initialize ResourceResponse internals when accessing timing data.
<https://webkit.org/b/134437>
<rdar://problem/17499876>
When building with ENABLE(WEB_TIMING), the last thing that would happen when
serializing a ResourceResponse in the network process is that we'd retrieve
the ResourceLoadTiming to encode it as part of the response. Doing so would
trigger the lazy instantiation of ResourceResponse's internal data structures.
Since timing data is not actually lazily instantiated, we can just not do that.
This shaves off ~550ms of network process main thread time on PLT, reducing
response latency by not doing unnecessary stuff before letting the web process
look at the downloaded data.
Reviewed by Gavin Barraclough.
- WebCore.exp.in:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::resourceLoadTiming): Deleted.
(WebCore::ResourceResponseBase::setResourceLoadTiming): Deleted.
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::resourceLoadTiming):
- 1:59 PM Changeset in webkit [170574] by
-
- 4 edits1 copy2 adds in trunk/Source/WebCore
Refactor ResourceRequest into Cocoa and iOS specific files
https://bugs.webkit.org/show_bug.cgi?id=134430
Reviewed by Andreas Kling.
No new tests because no functional changes.
- WebCore.xcodeproj/project.pbxproj:
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::applyWebArchiveHackForMail): Deleted.
- platform/network/cocoa/ResourceRequestCocoa.mm: Copied from Source/WebCore/platform/network/mac/ResourceRequestMac.mm.
(WebCore::ResourceRequest::nsURLRequest):
(WebCore::ResourceRequest::cfURLRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdateResourceHTTPBody):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::setStorageSession):
- platform/network/ios/ResourceRequestIOS.mm: Added.
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::initQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::useQuickLookResourceCachingQuirks):
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::applyWebArchiveHackForMail):
(WebCore::ResourceRequest::nsURLRequest): Deleted.
(WebCore::ResourceRequest::cfURLRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceRequest): Deleted.
(WebCore::ResourceRequest::doUpdateResourceHTTPBody): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformRequest): Deleted.
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody): Deleted.
(WebCore::ResourceRequest::updateFromDelegatePreservingOldProperties): Deleted.
(WebCore::ResourceRequest::setStorageSession): Deleted.
- 10:10 AM Changeset in webkit [170573] by
-
- 3 edits2 adds in trunk
TextCodecICU::encode turns the whole string as yen signs if there is any backslash in it
https://bugs.webkit.org/show_bug.cgi?id=133678
Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-06-29
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: fast/encoding/backslash-encoding-jp.html
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::encode): fixed the copy of characters other than backslash.
LayoutTests:
- fast/encoding/backslash-encoding-jp-expected.txt: Added.
- fast/encoding/backslash-encoding-jp.html: Added.
- 8:27 AM BuildingQtOnWindows edited by
- small "typo" (diff)
- 8:18 AM BuildingQtOnWindows edited by
- Added the SQLite dependency information, added some notes and a bit … (diff)
Jun 28, 2014:
- 7:44 PM Changeset in webkit [170572] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Pinching into a video (fullscreen gesture) leaves page zoomed in
https://bugs.webkit.org/show_bug.cgi?id=134433
<rdar://problem/16630794>
Reviewed by Eric Carlson.
Detect the number of target touches (those directly on the
video element) and disable the page zoom if it looks
like the user is trying to trigger fullscreen.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.handleBaseGestureStart): If we are seeing
two touches in this video element, don't trigger fullscreen. The
exception is if we haven't yet started playback.
(ControllerIOS.prototype.handleBaseGestureChange): Don't allow fullscreen
if we haven't started playback (iOS 7 behaviour).
(ControllerIOS.prototype.handleWrapperTouchStart): Keep track of the
number of targetted touches.
- 4:49 PM Changeset in webkit [170571] by
-
- 17 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Reduce the GC's influence on optimization decisions
https://bugs.webkit.org/show_bug.cgi?id=134427
Reviewed by Oliver Hunt.
This is a slight speed-up on some platforms, that arises from a bunch of fixes that I made
while trying to make the GC keep more structures alive
(https://bugs.webkit.org/show_bug.cgi?id=128072).
The fixes are, roughly:
- If the GC clears an inline cache, then this no longer causes the IC to be forever polymorphic.
- If we exit in inlined code into a function that tries to OSR enter, then we jettison sooner.
- Some variables being uninitialized led to rage-recompilations.
This is a pretty strong step in the direction of keeping more Structures alive and not
blowing away code just because a Structure died. But, it seems like there is still a slight
speed-up to be had from blowing away code that references dead Structures.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpAssumingJITType):
(JSC::shouldMarkTransition):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::isSupportedForInlining):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForClosureCall):
(JSC::DFG::mightInlineFunctionForConstruct):
- dfg/DFGCapabilities.h:
- dfg/DFGCommonData.h:
- dfg/DFGDesiredWeakReferences.cpp:
(JSC::DFG::DesiredWeakReferences::reallyAdd):
- dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- ftl/FTLForOSREntryJITCode.cpp:
(JSC::FTL::ForOSREntryJITCode::ForOSREntryJITCode): These variables being uninitialized is benign in terms of correctness but can sometimes cause rage-recompilations. For some reason it took this patch to reveal this.
- ftl/FTLOSREntry.cpp:
(JSC::FTL::prepareOSREntry):
- runtime/Executable.cpp:
(JSC::ExecutableBase::destroy):
(JSC::NativeExecutable::destroy):
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::ScriptExecutable::destroy):
(JSC::ScriptExecutable::installCode):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
- runtime/Executable.h:
(JSC::ScriptExecutable::setDidTryToEnterInLoop):
(JSC::ScriptExecutable::didTryToEnterInLoop):
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop):
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
- runtime/StructureInlines.h:
(JSC::Structure::storedPrototypeObject):
(JSC::Structure::storedPrototypeStructure):
- 3:39 PM Changeset in webkit [170570] by
-
- 10 edits in trunk/Source/WebKit2
[iOS][WK2] PDFs never load inline again after the Web process crashes
https://bugs.webkit.org/show_bug.cgi?id=134432
<rdar://problem/17484205>
Reviewed by Dan Bernstein.
After a crash, the WebPage never gets mimeTypesWithCustomContentProviders filled back in.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Add mimeTypesWithCustomContentProviders to WebPageCreationParameters.
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.h:
- UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm:
(-[WKWebViewContentProviderRegistry addPage:]):
We don't need to send the MIME types across when a page is added, because it already got them in its creation parameters.
(-[WKWebViewContentProviderRegistry removePage:]):
(-[WKWebViewContentProviderRegistry _mimeTypesWithCustomContentProviders]):
Return a vector of all registered MIME types.
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::mimeTypesWithCustomContentProviders):
- UIProcess/PageClient.h:
Add (iOS only for now) mimeTypesWithCustomContentProviders to PageClient.
- 3:31 PM Changeset in webkit [170569] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION: WebPageProxy::attributedSubstringForCharacterRangeAsync never calls its callback function
https://bugs.webkit.org/show_bug.cgi?id=134429
Reviewed by Tim Horton.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::attributedSubstringForCharacterRangeAsync):
- 7:50 AM Changeset in webkit [170568] by
-
- 7 edits in trunk/Source
[iOS WK2] position:fixed inside accelerated overflow:scroll is jumpy
https://bugs.webkit.org/show_bug.cgi?id=134426
<rdar://problem/17474523>
Reviewed by Tim Horton.
After committing a new layer tree (with possibly stale position:fixed layer
positions), we need the scrolling tree to update those positions based on
the current scroll offset.
Source/WebCore:
Give ScrollingTreeScrollingNode an implementation of updateLayersAfterAncestorChange()
which is required to update fixed/sticky child nodes.
- WebCore.exp.in:
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateLayersAfterAncestorChange):
- page/scrolling/ScrollingTreeScrollingNode.h:
Source/WebKit2:
To achieve that, implement ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange()
and have it add to the cumulative delta the difference between the last committed scroll
position and the current scroll position.
Also make sure that ScrollingTreeOverflowScrollingNodeIOS doesn't call back to scrollViewDidScroll()
when we're updating its scroll position inside a scrolling tree commit.
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange):
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):
- 2:06 AM Changeset in webkit [170567] by
-
- 11 edits in trunk/Source/WebCore
[GTK] Use public getter/setter in GObject DOM bindings properties implementation.
https://bugs.webkit.org/show_bug.cgi?id=134390.
Patch by Juan A. Suarez Romero <jasuarez@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com> on 2014-06-28
Reviewed by Carlos Garcia Campos.
The current GObject DOM bindings generator is duplicating code when
implementing the get/set_property methods and the public
getters/setters, instead of making one invoking the other.
This commit changes this behaviour so the code is not duplicated,
making it easier to maintain.
No new tests needed.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(GenerateProperties):
(WriteData):
(GetCoreObject): Deleted.
- bindings/scripts/test/GObject/WebKitDOMTestActiveDOMObject.cpp:
(webkit_dom_test_active_dom_object_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestEventConstructor.cpp:
(webkit_dom_test_event_constructor_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestException.cpp:
(webkit_dom_test_exception_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
(webkit_dom_test_interface_set_property):
(webkit_dom_test_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestNondeterministic.cpp:
(webkit_dom_test_nondeterministic_set_property):
(webkit_dom_test_nondeterministic_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
(webkit_dom_test_serialized_script_value_interface_get_property):
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
(webkit_dom_test_typedefs_set_property):
(webkit_dom_test_typedefs_get_property):
- bindings/scripts/test/GObject/WebKitDOMattribute.cpp:
(webkit_dom_test_exception_get_property):
(webkit_dom_attribute_get_property):
- 1:44 AM Changeset in webkit [170566] by
-
- 3 edits2 adds in trunk
[New Multicolumn] Elements with rounded corners and overflow:hidden do not properly clip their content
https://bugs.webkit.org/show_bug.cgi?id=133941
Reviewed by Darin Adler.
Source/WebCore:
When having a multicol element inside an element with overflow:hidden and border-radius,
the fragments representing the columns need to have the border radius set also, to ensure
proper clipping.
Test: fast/multicol/newmulticol/multicol-clip-rounded-corners.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::collectFragments):
LayoutTests:
Added test for multicol element inside an element with overflow:hidden and border radius.
- fast/multicol/newmulticol/multicol-clip-rounded-corners-expected.html: Added.
- fast/multicol/newmulticol/multicol-clip-rounded-corners.html: Added.
Jun 27, 2014:
- 10:51 PM Changeset in webkit [170565] by
-
- 2 edits in trunk/Tools
check-webkit-style should check the order of #imports as well as #includes
https://bugs.webkit.org/show_bug.cgi?id=134428
Reviewed by Dan Bernstein.
- Scripts/webkitpy/style/checkers/cpp.py:
Allow "import" in addition to "include", so that the sort order of headers in ObjC files is checked.
- 10:43 PM Changeset in webkit [170564] by
-
- 38 edits1 add2 deletes in branches/ftlopt
[ftlopt] If a CodeBlock is jettisoned due to a watchpoint then it should be possible to figure out something about that watchpoint
https://bugs.webkit.org/show_bug.cgi?id=134333
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This is engineered to provide loads of information to the profiler without incurring any
costs when the profiler is disabled. It's the oldest trick in the book: the thing that
fires the watchpoint doesn't actually create anything to describe the reason why it was
fired; instead it creates a stack-allocated FireDetail subclass instance. Only if the
FireDetail::dump() virtual method is called does anything happen.
Currently we use this to produce very fine-grained data for Structure watchpoints and
some cases of variable watchpoints. For all other situations, the given reason is just a
string constant, by using StringFireDetail. If we find a situation where that string
constant is insufficient to diagnose an issue then we can change it to provide more
fine-grained information.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):
- bytecode/CodeBlock.h:
- bytecode/CodeBlockJettisoningWatchpoint.cpp:
(JSC::CodeBlockJettisoningWatchpoint::fireInternal):
- bytecode/CodeBlockJettisoningWatchpoint.h:
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.cpp: Removed.
- bytecode/ProfiledCodeBlockJettisoningWatchpoint.h: Removed.
- bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::fireInternal):
- bytecode/StructureStubClearingWatchpoint.h:
- bytecode/VariableWatchpointSet.h:
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
- bytecode/VariableWatchpointSetInlines.h:
(JSC::VariableWatchpointSet::notifyWrite):
- bytecode/Watchpoint.cpp:
(JSC::StringFireDetail::dump):
(JSC::WatchpointSet::fireAll):
(JSC::WatchpointSet::fireAllSlow):
(JSC::WatchpointSet::fireAllWatchpoints):
(JSC::InlineWatchpointSet::fireAll):
- bytecode/Watchpoint.h:
(JSC::FireDetail::FireDetail):
(JSC::FireDetail::~FireDetail):
(JSC::StringFireDetail::StringFireDetail):
(JSC::Watchpoint::fire):
(JSC::WatchpointSet::fireAll):
(JSC::WatchpointSet::touch):
(JSC::WatchpointSet::invalidate):
(JSC::InlineWatchpointSet::fireAll):
(JSC::InlineWatchpointSet::touch):
- dfg/DFGCommonData.h:
- dfg/DFGOperations.cpp:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- jsc.cpp:
(WTF::Masquerader::create):
- profiler/ProfilerCompilation.cpp:
(JSC::Profiler::Compilation::setJettisonReason):
(JSC::Profiler::Compilation::toJS):
- profiler/ProfilerCompilation.h:
(JSC::Profiler::Compilation::setJettisonReason): Deleted.
- runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::transfer):
- runtime/ArrayBufferNeuteringWatchpoint.cpp:
(JSC::ArrayBufferNeuteringWatchpoint::fireAll):
- runtime/ArrayBufferNeuteringWatchpoint.h:
- runtime/CommonIdentifiers.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/Identifier.cpp:
(JSC::Identifier::dump):
- runtime/Identifier.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addFunction):
(JSC::JSGlobalObject::haveABadTime):
- runtime/JSSymbolTableObject.cpp:
(JSC::VariableWriteFireDetail::dump):
- runtime/JSSymbolTableObject.h:
(JSC::VariableWriteFireDetail::VariableWriteFireDetail):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):
- runtime/PropertyName.h:
(JSC::PropertyName::dump):
- runtime/Structure.cpp:
(JSC::Structure::notifyTransitionFromThisStructure):
- runtime/Structure.h:
(JSC::Structure::notifyTransitionFromThisStructure): Deleted.
- runtime/SymbolTable.cpp:
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTable::WatchpointCleanup::finalizeUnconditionally):
- runtime/SymbolTable.h:
(JSC::SymbolTableEntry::notifyWrite):
- runtime/VM.cpp:
(JSC::VM::addImpureProperty):
Source/WebCore:
No new tests because no change in behavior.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
Tools:
- Scripts/display-profiler-output:
- 6:34 PM Changeset in webkit [170563] by
-
- 4 edits2 adds in trunk
Subpixel rendering: Background clipping with subpixel behaves differently when composited.
https://bugs.webkit.org/show_bug.cgi?id=134422
Reviewed by Simon Fraser.
Adjust cliprect with the subpixel offset from the graphics layer the same way we do it for painting.
It ensures that cliprect starts from the right position when graphics layer is not on the same
coordinates as the associated render layer.
Source/WebCore:
Test: compositing/hidpi-compositing-layer-with-subpixel-offset-accumulation-clipping.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::clipToRect):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::applyFilters):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::paintBackgroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragments):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):
(WebCore::RenderLayer::paintOutlineForFragments):
(WebCore::RenderLayer::paintMaskForFragments):
(WebCore::RenderLayer::paintOverflowControlsForFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
LayoutTests:
- compositing/hidpi-compositing-layer-with-subpixel-offset-accumulation-clipping-expected.html: Added.
- compositing/hidpi-compositing-layer-with-subpixel-offset-accumulation-clipping.html: Added.
- 5:19 PM Changeset in webkit [170562] by
-
- 18 edits4 adds in trunk/Source
[Win] Implement parts of the AVFOUNDATION_LOADER_DELEGATE logic for Windows
https://bugs.webkit.org/show_bug.cgi?id=134418
Reviewed by Eric Carlson.
../WebCore:
Land an initial implementation of AVFOUNDATION_LOADER_DELEGATE for
Windows.
- DerivedSources.cpp: Add new IDL files
- DerivedSources.make: Add check for AVFOUNDATION_LOADER_DELEGATE.
- Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp: Added (ported from
Objective C.)
- WebCore.vcxproj/WebCore.vcxproj: Update for new files.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.vcxproj/WebCoreCommon.props: Add new search paths.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj: Update for new files.
- WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extractKeyURIKeyIDAndCertificateFromInitData):
Moved from MediaPlayerPrivateAVFoundationObjC.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
- platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h:
Update for new API calls.
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp: Added.
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h: Added.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
Updated for new AVFOUNDATION_LOADER_DELEGATE methods.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp: Added.
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.h: Added.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
Remove method that was moved to base class.
../WebKit:
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add new
export.
- 4:32 PM Changeset in webkit [170561] by
-
- 5 edits in trunk/Source/WebCore
Remove BufferForAppendingHyphen
https://bugs.webkit.org/show_bug.cgi?id=134376
Reviewed by Darin Adler.
It is legacy, from a time when that code was using a Vector.
The problem is that StringBuilder's memory was also implicitly used to keep
the string alive for the lifespan of the TextRun. That seems quite dangerous
as changes in StringBuilder could have changed that.
To fix the lifetime issue, my first idea was to make it explicit by passing
a String reference to hold the memory alive, and a boolean to say if the text
need an hyphen. The problem with that is this code is very hot and I made things
worse.
The solution with this patch is to just pass a pointer to a String to do both
the buffer reference, and the decision to add the hyphen. Having a single
argument with 2 meanings is not pretty but that's not worse than the old buffer.
- editing/TextIterator.cpp:
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::constructTextRun):
(WebCore::adjustCharactersAndLengthForHyphen): Deleted.
- rendering/InlineTextBox.h:
(WebCore::BufferForAppendingHyphen::BufferForAppendingHyphen): Deleted.
- rendering/RenderText.cpp:
- 4:28 PM Changeset in webkit [170560] by
-
- 2 edits in trunk/Source/WebCore
Lazily link frameworks in WebVideoFullscreenInterfaceAVKit.
https://bugs.webkit.org/show_bug.cgi?id=134407
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-27
Reviewed by Eric Carlson.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerController init]):
Load AVPlayerController on use.
(WebVideoFullscreenInterfaceAVKit::WebVideoFullscreenInterfaceAVKit):
Remove loading on construction.
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): Load AVValueTiming on use.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): Load several classes on use.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): Load UIColor on use.
- 3:29 PM Changeset in webkit [170559] by
-
- 2 edits in trunk/Source/WebCore
Remove extra operations from 64-bit or on armv7.
https://bugs.webkit.org/show_bug.cgi?id=134408
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-27
Reviewed by Geoffrey Garen.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::addFlagsToElementStyleFromContext):
Only do or operations if it would change values.
Often we're only setting one flag, so half the operations are not necessary.
- 3:12 PM Changeset in webkit [170558] by
-
- 2 edits in trunk/Source/WebCore
ScrollView::rootViewToTotalContents() needs to take topContentInset into account
https://bugs.webkit.org/show_bug.cgi?id=134415
-and corresponding-
<rdar://problem/17473633>
Reviewed by Simon Fraser.
This affects hit testing in headers aka PageBanners.
The root view will be anchored above the start of the total contents if there is a
topContentInset, so the inset value should be subtracted to get into the right
coordinate space here.
- platform/ScrollView.cpp:
(WebCore::ScrollView::rootViewToTotalContents):
- 2:58 PM Changeset in webkit [170557] by
-
- 15 edits1 add in trunk/Source
Flush throttling with remote layers
https://bugs.webkit.org/show_bug.cgi?id=134398
Reviewed by Darin Adler.
Source/WebCore:
With remote layer trees the flush scheduling lives in the WebKit2 layer. The throttling code
needs to live there as well.
Add the required callbacks and disable the existing throttling code in RenderLayerCompositor
when remote layers are in use. Later we can get rid of the RenderLayerCompositor throttling code.
- WebCore.xcodeproj/project.pbxproj:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
- page/ChromeClient.h:
(WebCore::ChromeClient::adjustLayerFlushThrottling):
- page/FrameView.cpp:
(WebCore::FrameView::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::FrameView::loadProgressingStatusChanged):
Factor the progress status change activities to a function.
(WebCore::FrameView::updateLayerFlushThrottling):
(WebCore::FrameView::setExposedRect):
Move the call to adjustTiledBackingCoverage from WebKit to here.
(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames): Deleted.
- page/FrameView.h:
- page/LayerFlushThrottleState.h: Added.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::adjustLayerFlushThrottling):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
- WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::adjustLayerFlushThrottling):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::updateScrolledExposedRect):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
Delay layer flushes during page loading.
If use interacts with the page the next flush in unthrottled even if loading is in progress.
(WebKit::RemoteLayerTreeDrawingArea::adjustLayerFlushThrottling):
Compute the new delay. The first visual flush uses a shorter delay.
Flush immediately when we are no longer throttling.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updateScrolledExposedRect):
- 2:57 PM Changeset in webkit [170556] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
Unreviewed build fix after r169795.
Fixed ASSERT for 32 bit build.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::silentSavePlanForGPR):
- 2:44 PM Changeset in webkit [170555] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
Don't fold a UInt32ToNumber with DoOverflow to Identity since that would result in an Identity that takes an Int32 and returns a DoubleRep
https://bugs.webkit.org/show_bug.cgi?id=134412
Reviewed by Mark Hahnenberg.
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- tests/stress/uint32-to-number-fold-constant-with-do-overflow.js: Added.
(foo):
(bar):
(baz):
- 2:36 PM Changeset in webkit [170554] by
-
- 3 edits in trunk/Source/WebKit2
[iOS][WK2] <select> tapping "next" does not save new picker value
https://bugs.webkit.org/show_bug.cgi?id=134409
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-27
Reviewed by Enrica Casucci.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView accessoryTab:]):
We know the assisted node will change, so call endEditing
before the assisted node changes in the WebProcess.
(-[WKContentView _stopAssistingNode]):
Ensure we call endEditing to trigger controlEndEditing.
- UIProcess/ios/forms/WKFormSelectPicker.mm:
(-[WKMultipleSelectPicker initWithView:]):
(-[WKMultipleSelectPicker pickerView:row:column:checked:]):
(-[WKSelectSinglePicker dealloc]):
Style fixes.
- 2:11 PM Changeset in webkit [170553] by
-
- 6 edits in trunk/Source/WebCore
The user pressing a button on a gamepad should cause gamepads to become visible to all NavigatorGamepads.
https://bugs.webkit.org/show_bug.cgi?id=134375
Reviewed by Darin Adler.
No new tests (Not yet a tested config)
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::platformGamepadConnected): Also call to makeGamepadsVisibileToBlindNavigators.
(WebCore::GamepadManager::platformGamepadDisconnected):
(WebCore::GamepadManager::platformGamepadInputActivity): Call makeGamepadsVisibileToBlindNavigators.
(WebCore::GamepadManager::makeGamepadsVisibileToBlindNavigators): Walk through each blind navigator
notifying it of each connected Gamepad.
(WebCore::GamepadManager::registerNavigator): Also add to the blind navigator set.
(WebCore::GamepadManager::unregisterNavigator): Also remove from the blind navigator set.
- Modules/gamepad/GamepadManager.h:
- platform/GamepadProviderClient.h: Added platformGamepadInputActivity.
- platform/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::valuesChanged): Set the input notification timer which will notify the clients
that a button was pressed.
(WebCore::HIDGamepadProvider::inputNotificationTimerFired): Perform that notification.
- platform/mac/HIDGamepadProvider.h:
- 2:04 PM Changeset in webkit [170552] by
-
- 2 edits in trunk/Source/WebKit/mac
InfoClick (from Nisus Software) dies on viewing found items
<rdar://problem/17395601>
https://bugs.webkit.org/show_bug.cgi?id=134410
Reviewed by Andy Estes.
InfoClick was calling -[WebPreferences setPrivateBrowsingEnabled:] before
setting up a WebView (or anything else that would have set up WebKitSystemInterface),
which now requires a set up WebKitSystemInterface. We can fix this by initializing
it from +[WebPreferences initialize].
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
Add call to InitWebCoreSystemInterface().
(+[WebPreferences _switchNetworkLoaderToNewTestingSession]):
Remove now unnecessary call to InitWebCoreSystemInterface().
- 2:03 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 1:53 PM Changeset in webkit [170551] by
-
- 3 edits in trunk/Source/WebCore
HIDGamepads should populate themselves with initial input values
https://bugs.webkit.org/show_bug.cgi?id=134381
Reviewed by Darin Adler.
No new tests (Not yet a tested config)
- platform/mac/HIDGamepad.cpp:
(WebCore::HIDGamepad::getCurrentValueForElement):
(WebCore::HIDGamepad::initElements): Loop through all the saved elements to get current values.
(WebCore::HIDGamepad::maybeAddButton):
(WebCore::HIDGamepad::maybeAddAxis):
- platform/mac/HIDGamepad.h:
(WebCore::HIDGamepadElement::HIDGamepadElement):
(WebCore::HIDGamepadButton::HIDGamepadButton):
(WebCore::HIDGamepadAxis::HIDGamepadAxis):
- 1:47 PM Changeset in webkit [170550] by
-
- 8 edits in trunk/Source
Source/JavaScriptCore: Add feature flag for link long-press gesture.
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig: Add ENABLE_LINK_LONG_PRESS.
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
Source/WebCore: Add feature flag for link long-press gesture.
https://bugs.webkit.org/show_bug.cgi?id=134262
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_LINK_LONG_PRESS.
Source/WebKit/mac: Add feature flag for link long-press gesture.
https://bugs.webkit.org/show_bug.cgi?id=134262
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig:
Add ENABLE_LINK_LONG_PRESS.
Source/WebKit2: Add feature flag for link long-press gesture.
Reviewed by Enrica Casucci.
- Configurations/FeatureDefines.xcconfig: Add ENABLE_LINK_LONG_PRESS.
Patch by Peyton Randolph <prandolph@apple.com> on 2014-06-27
- 1:35 PM Changeset in webkit [170549] by
-
- 4 edits in trunk/Source/WebCore
HIDGamepadProvider should only be active when someone is interested in Gamepads.
https://bugs.webkit.org/show_bug.cgi?id=134374
Reviewed by Darin Adler.
No new tests (Not yet a tested config)
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::registerNavigator): Add some logging.
(WebCore::GamepadManager::unregisterNavigator): Ditto.
- platform/mac/HIDGamepadProvider.cpp:
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::connectionDelayTimerFired): Stop suppressing connection callbacks
(WebCore::HIDGamepadProvider::openAndScheduleManager):
(WebCore::HIDGamepadProvider::closeAndUnscheduleManager): Stop listening for gamepad events, and clear
all current gamepads.
(WebCore::HIDGamepadProvider::startMonitoringGamepads): If the first client, call openAndScheduleManager
(WebCore::HIDGamepadProvider::stopMonitoringGamepads): If the last client, call closeAndUnscheduleManager
(WebCore::HIDGamepadProvider::deviceAdded): If this callback came while we were suppressing connection
callbacks, it is a startup event for already-connected gamepads. Stop suppressing callbacks in a later
spin of the runloop.
(WebCore::HIDGamepadProvider::deviceRemoved):
- platform/mac/HIDGamepadProvider.h:
(WebCore::HIDGamepadProvider::setShouldDispatchCallbacks): Deleted.
- 1:31 PM Changeset in webkit [170548] by
-
- 3 edits in trunk/Source/WebCore
Prevent unnecessary register saving in css jit.
https://bugs.webkit.org/show_bug.cgi?id=133955
Reviewed by Geoff Garen.
- cssjit/FunctionCall.h:
(WebCore::FunctionCall::prepareAndCall):
(WebCore::FunctionCall::cleanupPostCall):
(WebCore::FunctionCall::saveAllocatedCallerSavedRegisters):
(WebCore::FunctionCall::restoreAllocatedCallerSavedRegisters):
(WebCore::FunctionCall::saveAllocatedRegisters): Renamed to saveAllocatedCallerSavedRegisters.
(WebCore::FunctionCall::restoreAllocatedRegisters): Renamed to restoreAllocatedCallerSavedRegisters.
Only push caller saved registers before function calls.
- cssjit/RegisterAllocator.h:
(WebCore::RegisterAllocator::isValidRegister):
Corrected register ranges.
(WebCore::RegisterAllocator::isCallerSavedRegister): Added.
- 12:54 PM Changeset in webkit [170547] by
-
- 35 edits in trunk/LayoutTests
Unreviewed gardening; fix whitespace issues in the W3C Media Source expected results.
- http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:
- http/tests/media/media-source/mediasource-append-buffer-expected.txt:
- http/tests/media/media-source/mediasource-append-stream-expected.txt:
- http/tests/media/media-source/mediasource-appendwindow-expected.txt:
- http/tests/media/media-source/mediasource-buffered-expected.txt:
- http/tests/media/media-source/mediasource-closed-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-duration-expected.txt:
- http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt:
- http/tests/media/media-source/mediasource-endofstream-invaliderror.html:
- http/tests/media/media-source/mediasource-getvideoplaybackquality-expected.txt:
- http/tests/media/media-source/mediasource-is-type-supported-expected.txt:
- http/tests/media/media-source/mediasource-multiple-attach-expected.txt:
- http/tests/media/media-source/mediasource-play-expected.txt:
- http/tests/media/media-source/mediasource-play-then-seek-back-expected.txt:
- http/tests/media/media-source/mediasource-redundant-seek-expected.txt:
- http/tests/media/media-source/mediasource-remove-expected.txt:
- http/tests/media/media-source/mediasource-seek-beyond-duration-expected.txt:
- http/tests/media/media-source/mediasource-seek-during-pending-seek-expected.txt:
- http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt:
- http/tests/media/media-source/mediasource-sourcebufferlist-expected.txt:
- 12:22 PM Changeset in webkit [170546] by
-
- 6 edits in trunk/Source/WebCore
Custom scrollbars should not create ScrollbarPainters on Mac
https://bugs.webkit.org/show_bug.cgi?id=134406
-and corresponding-
<rdar://problem/16178301>
Reviewed by Tim Horton.
The solution here is to return early in ScrollbarThemeMac::registerScrollbar() if
the scrollbar is custom. However, since this function is called during the
RenderScrollbar and Scrollbar constructor, we need to re-implement
Scrollbar::isCustomScrollbar() to return a member variable that is passed into the
constructor. Otherwise, we will get Scrollbar’s implementation is
isCustomScrollbar() wrongfully returning false since instead of the derived
class’s implementation.
Scrollbar constructor now has an option parameter isCustomScrollbar that defaults
to false. That value is returned by isCustomScrollbar()
- platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar):
- platform/Scrollbar.h:
Return early if this is a custom scrollbar since the rest of the function deals
with creating a native scrollbar and getting it in the right state.
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::registerScrollbar):
Send true to the Scrollbar constructor to indicate that this is a custom
scrollbar.
- rendering/RenderScrollbar.cpp:
(WebCore::RenderScrollbar::RenderScrollbar):
- rendering/RenderScrollbar.h:
- 12:17 PM Changeset in webkit [170545] by
-
- 2 edits in trunk/Source/WebCore
[Mac] AVMetadataKeySpaceISOUserData not defined on 10.8
https://bugs.webkit.org/show_bug.cgi?id=134401
Reviewed by Jer Noble.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::metadataType): Use SOFT_LINK_POINTER_OPTIONAL for AVMetadataKeySpaceISOUserData
so we don't have problems on OS versions where it isn't defined.
- 11:55 AM Changeset in webkit [170544] by
-
- 3 edits2 adds in trunk
REGRESSION (r168685): css calc() expression fails
https://bugs.webkit.org/show_bug.cgi?id=134059
Source/WebCore:
The expression 'calc((100% - 20px) / 3' did not work properly after r168685,
because primitiveType() function in CSSCalculationValue.cpp has handled
CalcPercentLength and CalcPercentNumber categories as if they were angles.
The patch fixes this incorrect behavior.
Reviewed by Simon Fraser.
Test: fast/css/calc-percentage-pixel.html
- css/CSSCalculationValue.cpp:
LayoutTests:
Added test demonstrates that expressions like
'calc((100% - 20px) / 3' work correctly again.
Reviewed by Simon Fraser.
- fast/css/calc-percentage-pixel-expected.html: Added.
- fast/css/calc-percentage-pixel.html: Added.
- 11:45 AM Changeset in webkit [170543] by
-
- 3 edits in trunk/Source/WebCore
[MSE] http/tests/media/media-source/mediasource-append-buffer.html is failing
https://bugs.webkit.org/show_bug.cgi?id=134389
Reviewed by Eric Carlson.
Two subtests in mediasource-append-buffer.html are failing. Bring setDuration() up to spec
by throwing an exception if the duration is called while any SourceBuffer is updating. Do
not cancel pending events when a SourceBuffer is removed from its MediaSource. And mark the
SourceBuffer as having pending activity if there are pending events to be fired.
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::setDuration):
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removedFromMediaSource):
(WebCore::SourceBuffer::hasPendingActivity):
- 11:43 AM Changeset in webkit [170542] by
-
- 47 edits22 copies46 adds44 deletes in trunk/LayoutTests
[MSE] Import latest Media Source tests from W3C test suite
https://bugs.webkit.org/show_bug.cgi?id=134388
Reviewed by Eric Carlson.
Import the most recent Media Source tests from the proposed W3C test suite:
<https://github.com/acolwell/web-platform-tests/tree/submission/acolwell/media-source/media-source>
No ports currently enable these tests, so update the expected results for each
test with the ideal expected result.
- http/tests/media/media-source/mediasource-addsourcebuffer-expected.txt:
- http/tests/media/media-source/mediasource-addsourcebuffer.html:
- http/tests/media/media-source/mediasource-append-buffer-expected.txt:
- http/tests/media/media-source/mediasource-append-buffer.html:
- http/tests/media/media-source/mediasource-append-stream-expected.txt: Added.
- http/tests/media/media-source/mediasource-append-stream.html: Added.
- http/tests/media/media-source/mediasource-appendwindow-expected.txt: Added.
- http/tests/media/media-source/mediasource-appendwindow.html: Added.
- http/tests/media/media-source/mediasource-buffered-expected.txt:
- http/tests/media/media-source/mediasource-buffered.html:
- http/tests/media/media-source/mediasource-closed-expected.txt:
- http/tests/media/media-source/mediasource-closed.html:
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-a-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-audio-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-framesize.html:
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-av-video-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framerate.html:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-mp4-v-framesize.html:
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-a-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-audio-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-framesize.html:
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-av-video-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-bitrate.html:
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framerate.html:
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize-expected.txt:
- http/tests/media/media-source/mediasource-config-change-webm-v-framesize.html:
- http/tests/media/media-source/mediasource-config-changes.js:
- http/tests/media/media-source/mediasource-duration-expected.txt: Added.
- http/tests/media/media-source/mediasource-duration.html: Added.
- http/tests/media/media-source/mediasource-endofstream-invaliderror-expected.txt: Added.
- http/tests/media/media-source/mediasource-endofstream-invaliderror.html: Added.
- http/tests/media/media-source/mediasource-getvideoplaybackquality-expected.txt: Added.
- http/tests/media/media-source/mediasource-getvideoplaybackquality.html: Added.
- http/tests/media/media-source/mediasource-is-type-supported-expected.txt:
- http/tests/media/media-source/mediasource-is-type-supported.html:
- http/tests/media/media-source/mediasource-multiple-attach-expected.txt:
- http/tests/media/media-source/mediasource-multiple-attach.html:
- http/tests/media/media-source/mediasource-play-expected.txt:
- http/tests/media/media-source/mediasource-play-then-seek-back-expected.txt: Added.
- http/tests/media/media-source/mediasource-play-then-seek-back.html: Added.
- http/tests/media/media-source/mediasource-play.html:
- http/tests/media/media-source/mediasource-redundant-seek-expected.txt: Added.
- http/tests/media/media-source/mediasource-redundant-seek.html: Added.
- http/tests/media/media-source/mediasource-remove-expected.txt: Added.
- http/tests/media/media-source/mediasource-remove.html: Added.
- http/tests/media/media-source/mediasource-seek-beyond-duration-expected.txt: Added.
- http/tests/media/media-source/mediasource-seek-beyond-duration.html: Added.
- http/tests/media/media-source/mediasource-seek-during-pending-seek-expected.txt: Added.
- http/tests/media/media-source/mediasource-seek-during-pending-seek.html: Added.
- http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt: Added.
- http/tests/media/media-source/mediasource-sourcebuffer-mode.html: Added.
- http/tests/media/media-source/mediasource-sourcebufferlist-expected.txt:
- http/tests/media/media-source/mediasource-sourcebufferlist.html:
- http/tests/media/media-source/mediasource-util.js:
- http/tests/media/media-source/mp4/test-a-128k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/mp4/test-a-128k-44100Hz-1ch.mp4: Added.
- http/tests/media/media-source/mp4/test-a-192k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/mp4/test-a-192k-44100Hz-1ch.mp4: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-24fps-8kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-128k-320x240-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-128k-640x480-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/mp4/test-v-256k-320x240-30fps-10kfr.mp4: Added.
- http/tests/media/media-source/mp4/test.mp4: Added.
- http/tests/media/media-source/seek-to-end-after-duration-change-expected.txt: Removed.
- http/tests/media/media-source/seek-to-end-after-duration-change.html: Removed.
- http/tests/media/media-source/video-media-source-abort-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-abort.html: Removed.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-add-and-remove-buffers.html: Removed.
- http/tests/media/media-source/video-media-source-append-in-ended-state-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-append-in-ended-state.html: Removed.
- http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-append-with-offset-in-ended-state.html: Removed.
- http/tests/media/media-source/video-media-source-async-events-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-async-events.html: Removed.
- http/tests/media/media-source/video-media-source-closed-on-htmlmediaelement-destruction-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-closed-on-htmlmediaelement-destruction.html: Removed.
- http/tests/media/media-source/video-media-source-duration-boundaryconditions-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-duration-boundaryconditions.html: Removed.
- http/tests/media/media-source/video-media-source-duration-changed-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-duration-changed.html: Removed.
- http/tests/media/media-source/video-media-source-duration-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-duration.html: Removed.
- http/tests/media/media-source/video-media-source-errors-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-errors.html: Removed.
- http/tests/media/media-source/video-media-source-event-attributes-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-event-attributes.html: Removed.
- http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-garbage-collection-before-sourceopen.html: Removed.
- http/tests/media/media-source/video-media-source-is-type-supported-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-is-type-supported.html: Removed.
- http/tests/media/media-source/video-media-source-objects-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-objects.html: Removed.
- http/tests/media/media-source/video-media-source-play-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-play.html: Removed.
- http/tests/media/media-source/video-media-source-reject-append-after-reopening-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-reject-append-after-reopening.html: Removed.
- http/tests/media/media-source/video-media-source-seek-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-seek.html: Removed.
- http/tests/media/media-source/video-media-source-sourcebufferlist-crash-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html: Removed.
- http/tests/media/media-source/video-media-source-state-changes-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-state-changes.html: Removed.
- http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state-expected.txt: Removed.
- http/tests/media/media-source/video-media-source-zero-byte-append-in-ended-state.html: Removed.
- http/tests/media/media-source/webm/segment-info.js: Added.
- http/tests/media/media-source/webm/test-a-128k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/webm/test-a-128k-44100Hz-1ch.webm: Added.
- http/tests/media/media-source/webm/test-a-192k-44100Hz-1ch-manifest.json: Added.
- http/tests/media/media-source/webm/test-a-192k-44100Hz-1ch.webm: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-320x240-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-384k-44100Hz-1ch-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-448k-44100Hz-1ch-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-av-640k-44100Hz-1ch-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-24fps-8kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-24fps-8kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-128k-320x240-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-128k-640x480-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-128k-640x480-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-v-256k-320x240-30fps-10kfr-manifest.json: Added.
- http/tests/media/media-source/webm/test-v-256k-320x240-30fps-10kfr.webm: Added.
- http/tests/media/media-source/webm/test-vp8-vorbis-webvtt.webm: Added.
- http/tests/media/media-source/webm/test.webm: Added.
- 11:28 AM Changeset in webkit [170541] by
-
- 14 edits in trunk/Source
[iOS WK2] Fix touch-scrollable elements with overflow:scroll on just one axis, and RTL scrolling
https://bugs.webkit.org/show_bug.cgi?id=134377
<rdar://problem/16762224>
Reviewed by Tim Horton.
Source/WebCore:
Make -webkit-overflow-scrolling:touch scrolling work correctly when one axis
has overflow:scroll and the other overflow:hidden. Also fix scrolling in RTL
contexts.
An RTL scroller with overflow-x:hidden will have a non-zero scroll origin,
and needs to truncate the scrolled content on the left side. To pass the
correct geometry to the UI process, we need to introduce the concept of
"reachable" size as well as total content size; normally these are the same,
but will differ when scrolling is only allowed on one axis but there is overflow
on both axes.
To get the reachable size, add RenderLayer::scrollableContentsSize().
RenderLayer::visibleSize() was wrong; the function should return the size of the
scrollable portion, but used layer size which includes borders. Fix to use pixelSnappedClientWidth()/Height(),
which is what we use for scrollbar computations.
- WebCore.exp.in:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateFrameScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
- page/scrolling/ScrollingCoordinator.h:
- page/scrolling/ScrollingStateScrollingNode.cpp:
(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setReachableContentsSize):
- page/scrolling/ScrollingStateScrollingNode.h:
(WebCore::ScrollingStateScrollingNode::reachableContentsSize):
- page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::updateBeforeChildren):
- page/scrolling/ScrollingTreeScrollingNode.h:
(WebCore::ScrollingTreeScrollingNode::reachableContentsSize):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::visibleSize):
(WebCore::RenderLayer::scrollableContentsSize):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::updateScrollingLayerWithClient):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
Source/WebKit2:
Make -webkit-overflow-scrolling:touch scrolling work correctly when one axis
has overflow:scroll and the other overflow:hidden. Also fix scrolling in RTL
contexts.
An RTL scroller with overflow-x:hidden will have a non-zero scroll origin,
and needs to truncate the scrolled content on the left side. To pass the
correct geometry to the UI process, we need to introduce the concept of
"reachable" size as well as total content size; normally these are the same,
but will differ when scrolling is only allowed on one axis but there is overflow
on both axes.
ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren() uses the total and
reachable content sizes to set a negative edge inset on the left (for RTL) or top
(for bottom-to-top) so prevent scrolling into these areas.
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateAfterChildren):
- 11:13 AM Changeset in webkit [170540] by
-
- 2 edits in trunk/Source/WebKit2
Fix various leaks, RetainPtrs should adopt allocs
https://bugs.webkit.org/show_bug.cgi?id=134308
Reviewed by Alexey Proskuryakov.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _remoteObjectRegistry]):
- 11:13 AM Changeset in webkit [170539] by
-
- 4 edits in trunk/Source/WebCore
[Feature Queries] Fix feature queries build on Mac
https://bugs.webkit.org/show_bug.cgi?id=134359
Reviewed by Antti Koivisto.
Update the XCode project and Feature Queries code to build on Mac.
There are existing tests for supports in the LayoutTests/css3 directory.
- WebCore.xcodeproj/project.pbxproj: Add the Feature Queries files
to the XCode project.
- css/CSSGrammar.y.in: Update CSSParserExpression to CSSParserValueList.
- css/DOMWindowCSS.idl: Add ImplementationLacksVTable metadata.
- 11:09 AM Changeset in webkit [170538] by
-
- 2 edits in trunk/Source/WebKit2
Remove unused definitions that were mistakenly added back in r170323 and then again in r170329
https://bugs.webkit.org/show_bug.cgi?id=134397
Reviewed by Geoff Garen.
- UIProcess/API/Cocoa/WKBackForwardList.mm:
- 11:08 AM Changeset in webkit [170537] by
-
- 17 edits7 adds in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Rebaseline tests after r170207, r170249, r170304, r170418 and r170433.
Update expectations for new crashing tests.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-27
- platform/gtk/TestExpectations: Report and mark new crashing tests. Adjust some tests expectations.
- platform/gtk/fast/canvas/canvas-blend-image-expected.txt: Rebaseline after r170433.
- platform/gtk/fast/canvas/canvas-blend-solid-expected.txt: Rebaseline after r170433.
- platform/gtk/fast/dom/navigator-detached-no-crash-expected.txt: Rebaseline after r170249.
- platform/gtk/fast/dynamic/text-combine-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt: Added. Add baseline after r170304.
- platform/gtk/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added. Rebaseline after r170418.
- platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added. Rebaseline after r170418.
- platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/emphasis-vertical-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/002-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/text-spliced-font-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/text/international/wrap-CJK-001-expected.txt: Added. Rebaseline after r170418.
- platform/gtk/fast/text/khmer-lao-font-expected.txt: Added. Add baseline after r170207.
- platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt: Rebaseline after r170418.
- platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt: Rebaseline after r170418.
- platform/gtk/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added. Rebaseline after r170433.
- platform/gtk/svg/filters/feBlend-all-blendmodes-expected.txt: Added. Add baseline after r170433.
- 11:06 AM Changeset in webkit [170536] by
-
- 2 edits in trunk/Source/WTF
[ARMv7] Skip one particularly expensive fastFree() alignment check.
<https://webkit.org/b/134402>
The size class alignment check in fastFree() was crazy expensive on ARMv7
due to its use of modulo. Disabling it shaves 470ms off of PLT main thread
time in the web process.
Note that this was very hard to identify in profiles due to TCO.
Reviewed by Gavin Barraclough.
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
- 10:50 AM Changeset in webkit [170535] by
-
- 2 edits in trunk/Source/WebCore
[MSE] media/media-source/media-source-tracks.html is crashy
https://bugs.webkit.org/show_bug.cgi?id=134385
Reviewed by Eric Carlson.
Fix the refactoring error (self assignment) introduced by r170488.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
- 10:49 AM Changeset in webkit [170534] by
-
- 3 edits2 adds in trunk
XHR should keep attributes on instance
https://bugs.webkit.org/show_bug.cgi?id=134363
Reviewed by Sam Weinig.
Source/WebCore:
Test: js/dom/xhr-prototype-define-property.html
Having them on the prototype broke some sites due to the fact that these DOM attributes are currently
not configurable. Once we make them configurable, we can move XHR attributes back to the prototype.
- bindings/scripts/CodeGeneratorJS.pm:
(InterfaceRequiresAttributesOnInstanceForCompatibility):
LayoutTests:
Added a new test for defining properties on XHR prototype.
- js/dom/xhr-prototype-define-property-expected.txt: Added.
- js/dom/xhr-prototype-define-property.html: Added.
- 10:06 AM Changeset in webkit [170533] by
-
- 2 edits in trunk/Source/WebCore
removeCodedFrames should modify ref to TrackBuffer no a copy.
https://bugs.webkit.org/show_bug.cgi?id=134380
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-06-27
Reviewed by Daniel Bates.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::removeCodedFrames):
Iterate with a reference.
- 9:55 AM Changeset in webkit [170532] by
-
- 2 edits in trunk/Source/WebCore
Set cliprect radius unconditionally in RenderLayer.
https://bugs.webkit.org/show_bug.cgi?id=134396
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- 9:41 AM Changeset in webkit [170531] by
-
- 8 edits4 adds in trunk
[CSS Grid Layout] Interaction between auto-placement and column / row spanning
https://bugs.webkit.org/show_bug.cgi?id=110633
Reviewed by Sergio Villar Senin.
Source/WebCore:
Modify auto-placement algorithm in order to support span in both
definite and automatic positions.
This patch fixes examples like:
grid-row: auto;
grid-column: 2 / span 3;
And also:
grid-row: auto;
grid-column: span 3;
Tests: fast/css-grid-layout/grid-item-auto-placement-automatic-span.html
fast/css-grid-layout/grid-item-auto-placement-definite-span.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::isEmptyAreaEnough): New method that
checks if a grid area is or not empty.
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea): Updated method
that now receives two arguments with the span value in both directions.
(WebCore::RenderGrid::ensureGridSize): Renamed from gridRow(). Adapted
method to grow in both directions at the same time if needed. It ensures
that the grid is big enough to insert a new item.
(WebCore::RenderGrid::insertItemIntoGrid): Only leave the method that
receives a GridCoordinate. It uses ensureGridSize() before inserting the
item in the grid.
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator): Ensure that
the grid is big enough to place the largest span for auto-positioned
items.
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
New method that returns a GridCoordinate outside current grid with the
requested dimensions.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid): Adapted
method to calculate the item's span and use the new version of
nextEmptyGridArea(). If an empty area is not found it uses
createEmptyGridAreaAtSpecifiedPositionsOutsideGrid() to place the item.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid): Ditto.
(WebCore::RenderGrid::growGrid): Renamed to ensureGridSize().
- rendering/RenderGrid.h: Modify methods headers and add new method
signature.
- rendering/style/GridCoordinate.h:
(WebCore::GridSpan::integerSpan): Add new simple method to return the
span value of a position.
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::resolveGridPositionsFromAutoPlacementPosition):
Implement method to take into account span in auto-placement algorithm.
(WebCore::GridResolvedPosition::adjustGridPositionsFromStyle): Add new
checks related with named grid line spans in auto-positioned items,
which is not allowed according to the spec.
- rendering/style/GridResolvedPosition.h: Update method header.
LayoutTests:
Add new specific test cases for span in auto-placement algorithm.
- fast/css-grid-layout/grid-item-auto-placement-automatic-span-expected.txt: Added.
- fast/css-grid-layout/grid-item-auto-placement-automatic-span.html: Added.
- fast/css-grid-layout/grid-item-auto-placement-definite-span-expected.txt: Added.
- fast/css-grid-layout/grid-item-auto-placement-definite-span.html: Added.
- fast/css-grid-layout/grid-item-spanning-resolution.html: Update test
case now that span in auto-positioned items is supported.
- 9:01 AM Changeset in webkit [170530] by
-
- 3 edits5 adds in trunk
[XHR] open method must uppercase only standard method types
https://bugs.webkit.org/show_bug.cgi?id=134264
Patch by Mahesh Kulkarni <mahesh.kk@samsung.com> on 2014-06-27
Reviewed by Darin Adler.
Source/WebCore:
As per step-5 of http://xhr.spec.whatwg.org/#the-open()-method only
DELETE, PUT, GET, POST, OPTIONS, HEAD are standard. Use other methods as is without case change.
All tests from w3c-test suite pass http://w3c-test.org/XMLHttpRequest/open-method-case-sensitive.htm.
This merges blink changes from r176592.
Tests: http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html
http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):
LayoutTests:
All tests from w3c-test suite pass http://w3c-test.org/XMLHttpRequest/open-method-case-sensitive.htm.
This merges blink changes from r176592.
- http/tests/xmlhttprequest/resources/echo-request-method.php: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html: Added.
- 8:51 AM Changeset in webkit [170529] by
-
- 2 edits in trunk/Source/WebCore
Increase priority on SharedTimer source.
http://bugs.webkit.org/show_bug.cgi?id=134109
While running webkit on a Debian virtual machine I stumbled upon an issue where JS
setTimeout callbacks were not being properly invoked due to machine limitations and the
usage of a low priority on setTimeout timers.
This patch increases the SharedTimer source priority to use the default glib priority which
fixes the issue, making setTimeout JS calls work properly on the test environment.
Reviewed by Gustavo Noronha Silva.
- platform/gtk/SharedTimerGtk.cpp:
(WebCore::setSharedTimerFireInterval):
- 7:20 AM Changeset in webkit [170528] by
-
- 2 edits in trunk/Source/WebCore
Remove redundant offsetFromAncestor() call from RenderLayer::localClipRect().
https://bugs.webkit.org/show_bug.cgi?id=134378
Reviewed by Simon Fraser.
No change in functionality.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::calculateClipRects):
- 7:00 AM Changeset in webkit [170527] by
-
- 6 edits in trunk/Tools
[EFL] Remove efl-wk2 from baseline search path
https://bugs.webkit.org/show_bug.cgi?id=134391
Reviewed by Gyuyoung Kim.
As WebKit1 EFL is removed and platform/efl and platform/efl-wk2 baselines and test expectations files
are merged efl-wk2 search path should be removed.
- Scripts/webkitpy/port/base.py:
(Port.test_expectations_file_postion): Added method to determine port test expectations file position in expectations_dict.
- Scripts/webkitpy/port/efl.py:
(EflPort._search_paths): Changed baseline search paths from efl-wk2 -> wk2 -> efl -> generic is changed to: efl -> wk2 -> generic.
(EflPort.test_expectations_file_postion): Added method to determine EFL port specific test expectation file position.
- Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_expectations_ordering): Changed constant value to one returned from test_expectations_file_postion().
- Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
(TestExpectationsTestCase.test_determine_port_from_expectations_path): Removed efl-wk2 test case.
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineTest.test_baseline_directory): Changed directory name in assertion from platform/efl-wk2 to platform/efl.
- 5:10 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 4:33 AM WebKitGTK/2.4.x edited by
- (diff)
- 4:28 AM Changeset in webkit [170526] by
-
- 3 edits in trunk/Source/WebCore
[GTK] 8tracks.com triggers annoying pop-up window/installation of "About protocol source plugin" (GStreamer?)
https://bugs.webkit.org/show_bug.cgi?id=133605
Reviewed by Carlos Garcia Campos.
Don't attempt to load blank URLs with the GStreamer media
player. Those URLs trigger the codec installer which is useless in
this scenario. This patch also renames some of the variables of
the ::load method, as suggested by Carlos.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Check video-sink validity before disconnecting its signal handlers.
(WebCore::MediaPlayerPrivateGStreamer::load): Don't load blank
URLs (about:blank).
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Disconnect repaint handler only if it's valid.
- 12:28 AM Changeset in webkit [170525] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JavaScriptCore] FTL buildfix for EFL platform.
https://bugs.webkit.org/show_bug.cgi?id=133546
Reviewed by Darin Adler.
- ftl/FTLAbstractHeap.cpp:
(JSC::FTL::IndexedAbstractHeap::IndexedAbstractHeap):
- ftl/FTLLocation.cpp:
(JSC::FTL::Location::forStackmaps):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::opposite):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
- ftl/FTLStackMaps.cpp:
(JSC::FTL::StackMaps::Constant::dump):
- llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX):
- 12:27 AM Changeset in webkit [170524] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Expose getter and setter functions for attributes named type
https://bugs.webkit.org/show_bug.cgi?id=134300
Reviewed by Martin Robinson.
We skip those because the getter conflicts with the get_type()
function of all GObjects. We should use a different name for them. As
a general rule we use the last word of the class name, something like:
webkit_dom_blob_get_type() -> webkit_dom_blob_get_blob_type()
webkit_dom_event_get_type() -> webkit_dom_event_get_event_type()
It's consistent with other existing DOM methods like
webkit_dom_xpath_result_get_result_type() or webkit_dom_css_value_get_css_value_type().
This patch also adds some exceptions for particular cases.
- bindings/gobject/webkitdom.symbols: Add new public symbols.
- bindings/scripts/CodeGeneratorGObject.pm:
(GetFunctionSigName): Helper function to return the function name
that takes into account all exceptions when generating getters and
setters of attributes named type. Otherwise the name is returned unmodified.
(GenerateFunction): Use GetFunctionSigName().
(GenerateFunctions): Do not skip functions for type attributes.
- 12:18 AM Changeset in webkit [170523] by
-
- 2 edits in trunk/Source/WebCore
Remove unnecessary #include in HistoryController
https://bugs.webkit.org/show_bug.cgi?id=134369
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-06-27
Reviewed by Daniel Bates.
After the landing of https://webkit.org/b/130099, HistoryController doesn't need
WebCore::Settings class. So we can remove the related header.
- loader/HistoryController.cpp:
Jun 26, 2014:
- 11:16 PM Changeset in webkit [170522] by
-
- 3 edits in trunk/Websites/webkit.org
Remove Qt instructions from http://www.webkit.org/building/tools.html
https://bugs.webkit.org/show_bug.cgi?id=134384
Reviewed by Tim Horton.
- building/tools.html:
- css/main.css:
(.mac-instructions, .unix-instructions, .windows-instructions, .gtk-instructions, .efl-instructions):
(.mac-instructions, .unix-instructions, .windows-instructions, .gtk-instructions, .qt-instructions, .efl-instructions): Deleted.
- 11:06 PM Changeset in webkit [170521] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog outputs (NS_ENUM): entries for Cocoa enums
https://bugs.webkit.org/show_bug.cgi?id=134387
Reviewed by Tim Horton.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp): Don’t consider {CF,NS}_{ENUM,OPTIONS} as function names.
- 10:35 PM Changeset in webkit [170520] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog mangles Objective-C selectors for methods with parameter types that contain colons
https://bugs.webkit.org/show_bug.cgi?id=134383
Reviewed by Tim Horton.
- Scripts/prepare-ChangeLog:
(method_decl_to_selector): Strip out the return type and parameter types before splitting at
colons.
- 10:33 PM Changeset in webkit [170519] by
-
- 6 edits in trunk/Source/WebCore
REGRESSION (r170287): SVGDocumentExtensions::rebuildElements() called on removed element
https://bugs.webkit.org/show_bug.cgi?id=134304
Patch by Jeongeun Kim <je_julie.kim@samsung.com> on 2014-06-26
Reviewed by Daniel Bates.
Roll out <http://trac.webkit.org/170287> (https://bugs.webkit.org/show_bug.cgi?id=134186)
as it led to SVGDocumentExtensions::rebuildElements() being called on an element(s) that
may no longer be in the document.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):
- dom/Document.cpp:
(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::startAnimations):
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
(WebCore::SVGDocumentExtensions::dispatchSVGLoadEventToOutermostSVGElements):
(WebCore::SVGDocumentExtensions::rebuildElements):
- svg/SVGDocumentExtensions.h:
- 9:31 PM Changeset in webkit [170518] by
-
- 4 edits2 adds in trunk
[iOS][WK2] Distant focusable element may not be scrolled into view when focused using keyboard
https://bugs.webkit.org/show_bug.cgi?id=134309
<rdar://problem/17427385>
Reviewed by Darin Adler.
.:
Add a manual test to ensure that we scroll to a distant focused text field when it's focused
using the keyboard.
- ManualTests/ios/scroll-to-distant-keyboard-focused-text-field.html: Added.
Source/WebKit2:
Fixes an issue where the focusable element may not be scrolled into view when it's focused by
using the keyboard accessory (i.e. the < and > buttons). In particular, we don't scroll a
keyboard focused text field into view when it's positioned significantly outside the visible region.
- UIProcess/ios/WKContentViewInteraction.h: Added an instance variable called _didAccessoryTabInitiateFocus
to track whether an accessory tab initiated the focus of the focusable element.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanupInteraction]): Clear _didAccessoryTabInitiateFocus so that we're in a good state
should the WebProcess crash between the time the UIProcess receives the accessory tab request and the
WebProcess calls back to the UIProcess to zoom/scroll to the newly focused element.
(-[WKContentView _displayFormNodeInputView]): Modified to pass an empty rectangle for the selection
rectangle to -_zoomToFocusRect to avoid constraining the scroll to the newly focused element when it
was focused using the keyboard accessory tab buttons
(-[WKContentView accessoryTab:]): Modified to set _didAccessoryTabInitiateFocus to YES. We'll set
this boolean to NO in -_displayFormNodeInputView.
- 8:20 PM Changeset in webkit [170517] by
-
- 3 edits6 adds in trunk
iOS 8 beta 2 ES6 'Set' clear() broken
https://bugs.webkit.org/show_bug.cgi?id=134346
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
The object map was not cleared :(.
Kudos to Ashley Gullen for tracking this and making a regression test.
Credit to Oliver for finding the missing code.
- runtime/MapData.h:
(JSC::MapData::clear):
LayoutTests:
- js/script-tests/set-clear.js: Added.
- js/set-clear-expected.txt: Added.
- js/set-clear.html: Added.
- 7:43 PM Changeset in webkit [170516] by
-
- 2 edits in trunk/Tools
MiniBrowser should support a preference to override the default URL
https://bugs.webkit.org/show_bug.cgi?id=134373
Reviewed by Darin Adler.
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate applicationDidFinishLaunching:]): See if there’s a pref
overriding the default URL, and use it if there is.
- 7:11 PM Changeset in webkit [170515] by
-
- 4 edits in trunk/Source/WebKit2
[iOS][WK2] Implement WKPDFView smart magnification
https://bugs.webkit.org/show_bug.cgi?id=134269
<rdar://problem/17272825>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _currentContentView]):
(contentZoomScale):
Factor _currentContentView out of contentZoomScale.
(-[WKWebView _zoomToRect:WebCore::atScale:origin:WebCore::]):
(-[WKWebView _scrollToRect:WebCore::origin:WebCore::minimumScrollDistance:]):
(-[WKWebView _contentRectForUserInteraction]):
Use it in a bunch more places so we query the right view when zooming/scrolling for smart magnification.
- UIProcess/ios/WKPDFView.h:
- UIProcess/ios/WKPDFView.mm:
(-[WKPDFView scrollViewDidScroll:]):
(-[WKPDFView _revalidateViews]):
(-[WKPDFView zoom:to:atPoint:kind:]):
(-[WKPDFView resetZoom:]):
Implement zoom:to:atPoint:kind: and resetZoom: UIPDFPageViewDelegate methods.
Convert the rects/points and forward them on to the WKWebView to do the zoom.
resetZoom: doesn't provide the gesture origin, so we zoom out using the view center as our origin.
Avoid parenting new UIPDFPageViews while starting a zoom; they'll end up with a bizarre
animation on them and go flying across the screen (even before _isAnimatingZoom is set).
- 7:05 PM Changeset in webkit [170514] by
-
- 5 edits in trunk/Source
[WK2] Pinch-zoom shadows can overlap headers and footers
https://bugs.webkit.org/show_bug.cgi?id=134372
<rdar://problem/16004095>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::shadowLayerPositionForFrame):
(WebKit::shadowLayerBoundsForFrame):
Compute the initial shadow layer and shadow bounds exactly as RenderLayerCompositor does
(in updateRootLayerPosition and friends). Also, clip the shadow layer to the old document rect,
otherwise it can extend over top of the header/footers. The content is automatically clipped to
this rect by the root content layer, but the shadow is outside of that.
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToLayers):
(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):
Pass all of the arguments to constrainScrollPositionForOverhang, not just half of them.
There's still a bug where we constrain incorrectly with header/footer layers, but that
will be addressed elsewhere.
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToPage):
Make use of the new helpers.
- WebCore.exp.in:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
Put header/footer layers in front of the root content layer instead of behind.
Ideally nothing would ever overlap them, but this will give them precedence regardless.
- 6:10 PM Changeset in webkit [170513] by
-
- 2 edits in trunk/Source/WebCore
[Win] Always NULL-terminate the string in createUTF8String()
<http://webkit.org/b/134353>
<rdar://problem/17471783>
Reviewed by Brent Fulgham.
- plugins/PluginView.cpp:
(WebCore::createUTF8String): Pull out CString length into local
variable. Switch to use memcpy. Always NULL-terminate the
string.
- 5:28 PM Changeset in webkit [170512] by
-
- 2 edits in trunk/Source/WebCore
[MSE][Mac] Crash in WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered const + 13
https://bugs.webkit.org/show_bug.cgi?id=134367
Reviewed by Darin Adler.
Add a couple of null-checks to protect against methods being called in the brief time
between when the object is created and when it's asked to load.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered):
- 5:27 PM Changeset in webkit [170511] by
-
- 2 edits in trunk/Source/WebCore
Rearrange conditions to find invalid protocol in NavigatorContentUtils::verifyProtocolHandlerScheme()
https://bugs.webkit.org/show_bug.cgi?id=134289
Reviewed by Darin Adler.
If we do early return when there is invalid protocol, we're able to avoid unnecessary call flow.
No new tests, covered by existing tests.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::verifyProtocolHandlerScheme):
- 4:59 PM Changeset in webkit [170510] by
-
- 2 edits in trunk/Tools
[Win] Fix potential buffer overrun in DLLLauncher
https://bugs.webkit.org/show_bug.cgi?id=134351
<rdar://problem/17469185>
Reviewed by Darin Adler.
- win/DLLLauncher/DLLLauncherMain.cpp: Correct error
in end-of-buffer calculation.
- 4:54 PM Changeset in webkit [170509] by
-
- 7 edits in tags/Safari-538.43/Source
Merged r170503. <rdar://problem/17271965>
- 4:53 PM Changeset in webkit [170508] by
-
- 2 edits in trunk/Source/WebKit2
Don't leak WKBrowsingContextControllers
https://bugs.webkit.org/show_bug.cgi?id=134368
<rdar://problem/17476582>
Reviewed by Sam Weinig.
- UIProcess/API/mac/WKView.mm:
(-[WKView browsingContextController]):
Adoption is important.
- 4:48 PM Changeset in webkit [170507] by
-
- 2 edits in tags/Safari-538.43/Source/WebCore
Merged r170478. <rdar://problem/17309186>
- 4:44 PM Changeset in webkit [170506] by
-
- 2 edits in trunk/Source/WebCore
[WK1] Use native touch event's timestamp for DOM touch event
https://bugs.webkit.org/show_bug.cgi?id=134326
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-26
Reviewed by Enrica Casucci.
- platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):
Use device event timestamp to get more accurate timing information. This also removes
the variance introduced by WebKit when computing velocity/acceleration/etc.
- 4:43 PM Changeset in webkit [170505] by
-
- 2 edits in tags/Safari-538.43/Source/WebCore
Merged r170485. <rdar://problem/16853657>
- 4:17 PM Changeset in webkit [170504] by
-
- 2 edits in trunk/Source/WebCore
Memcache migth not be pruned when it should for https pages
https://bugs.webkit.org/show_bug.cgi?id=134361
Reviewed by Geoffrey Garen.
There is no reason we should not try to prune in case of a https resource.
No observable change in behavior, no tests.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::removeClient):
Call prune unconditionally and remove an unnecessary branch.
- 4:15 PM Changeset in webkit [170503] by
-
- 7 edits in trunk/Source
REGRESSION: Mountain Lion: Gmail's "in new window" view of mail threads is very slow to load its content
https://bugs.webkit.org/show_bug.cgi?id=133882
<rdar://problem/17271965>
Reviewed by Brady Eidson.
Source/WebCore:
This goes to pre-r161796 behavior on 10.8 and 10.9. We schedule the requests internally,
and only give 6 of them to CFNetwork at a time. Except for synchronous requests,
which still use the improved approach, and don't count against 6 connections.
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
- platform/network/cf/ResourceRequest.h:
(WebCore::ResourceRequest::resourcePrioritiesEnabled):
- platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::initializeMaximumHTTPConnectionCountPerHost): Deleted.
- platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
Source/WebKit2:
- NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:
(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
Same fix as in WebCore.
- 4:07 PM Changeset in webkit [170502] by
-
- 2 edits in trunk/Tools
[EFL] Missing dependency between freetype6 and fontconfig libs.
https://bugs.webkit.org/show_bug.cgi?id=134190
Reviewed by Gyuyoung Kim.
The external dependencies contain the freetype6 and the fontconfig libs.
The fontconfig lib requires freetype, but the dependency is not set in
the efl/jhbuild.modules file. So, during building the external libs,
fontconfig uses the freetype package of the system, while WebKit
binaries will use freetype from the WebKitBuild/Dependency directory.
There are more similar dependencies that were not indicated in the
jhbuild.modules file.
- efl/jhbuild.modules: Added dependencies between libs.
- 4:03 PM Changeset in webkit [170501] by
-
- 2 edits in trunk/Source/WTF
Bump FastMalloc thread cache max size to 1MB on iOS.
<https://webkit.org/b/134365>
The previous limit (512kB) comes from the old days of very-low-memory
devices, and we can now afford to spend another 512kB here.
Note that we already have a mechanism to purge FastMalloc caches on
system memory pressure.
Looks like a ~400ms progression on PLT.
Reviewed by Geoff Garen.
- wtf/FastMalloc.cpp:
- 3:37 PM Changeset in webkit [170500] by
-
- 22 edits5 moves1 delete in trunk/Source
Remove use of PlatformStrategies for Gamepad API.
https://bugs.webkit.org/show_bug.cgi?id=134348
Source/WebCore:
Reviewed by Dean Jackson.
No new tests (Not yet a tested config)
Introduce a virtual GamepadProvider with a process-global shared provider.
The base implementation of the GamepadProvider does nothing.
- platform/GamepadProvider.cpp: Renamed from Source/WebKit/mac/WebCoreSupport/WebHIDGamepadController.h.
(WebCore::GamepadProvider::shared):
(WebCore::GamepadProvider::setSharedProvider):
(WebCore::GamepadProvider::startMonitoringGamepads):
(WebCore::GamepadProvider::stopMonitoringGamepads):
(WebCore::GamepadProvider::platformGamepads):
- platform/GamepadProvider.h: Renamed from Source/WebCore/platform/GamepadStrategy.h.
(WebCore::GamepadProvider::~GamepadProvider):
- platform/GamepadProviderClient.h: Renamed from Source/WebCore/platform/GamepadStrategyClient.h.
(WebCore::GamepadProviderClient::~GamepadProviderClient):
GamepadManager is now a GamepadProviderClient:
- Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::GamepadManager):
(WebCore::GamepadManager::registerNavigator):
(WebCore::GamepadManager::unregisterNavigator):
- Modules/gamepad/GamepadManager.h:
Remove the GamepadStrategy altogether:
- platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::gamepadStrategy): Deleted.
Call to the shared GamepadProvider instead of the strategy:
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::gamepads):
(WebCore::NavigatorGamepad::gamepadsBecameVisible):
(WebCore::NavigatorGamepad::gamepadConnected):
HIDGamepadListener is now a subclass of GamepadProvider that implements the HID based management.
LegacyWebKit on Mac will install the shared HIDGamepadProvider instead of the default GamepadProvider:
- platform/mac/HIDGamepadProvider.cpp: Renamed from Source/WebCore/platform/mac/HIDGamepadListener.cpp.
(WebCore::deviceMatchingDictionary):
(WebCore::deviceAddedCallback):
(WebCore::deviceRemovedCallback):
(WebCore::deviceValuesChangedCallback):
(WebCore::HIDGamepadProvider::shared):
(WebCore::HIDGamepadProvider::HIDGamepadProvider):
(WebCore::HIDGamepadProvider::indexForNewlyConnectedDevice):
(WebCore::HIDGamepadProvider::startMonitoringGamepads):
(WebCore::HIDGamepadProvider::stopMonitoringGamepads):
(WebCore::HIDGamepadProvider::deviceAdded):
(WebCore::HIDGamepadProvider::deviceRemoved):
(WebCore::HIDGamepadProvider::valuesChanged):
(WebCore::HIDGamepadProvider::removeGamepadForDevice):
- platform/mac/HIDGamepadProvider.h: Renamed from Source/WebCore/platform/mac/HIDGamepadListener.h.
(WebCore::HIDGamepadProvider::platformGamepads):
(WebCore::HIDGamepadProvider::setShouldDispatchCallbacks):
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- platform/mac/HIDGamepad.h: Fix incorrect comment
Source/WebKit:
Reviewed by Dean Jackson.
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Reviewed by Dean Jackson.
Remove all the GamepadStrategy gunk:
- WebCoreSupport/WebHIDGamepadController.mm: Removed.
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::createGamepadStrategy): Deleted.
(WebPlatformStrategies::startMonitoringGamepads): Deleted.
(WebPlatformStrategies::stopMonitoringGamepads): Deleted.
(WebPlatformStrategies::platformGamepads): Deleted.
Instead, install the HIDGamepadProvider as the shared GamepadProvider:
- WebView/WebView.mm:
(WebKitInitializeGamepadProviderIfNecessary):
(-[WebView _commonInitializationWithFrameName:groupName:]):
Source/WebKit/win:
Reviewed by Dean Jackson.
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createGamepadStrategy): Deleted.
- WebCoreSupport/WebPlatformStrategies.h:
- 3:22 PM Changeset in webkit [170499] by
-
- 2 edits in trunk/Source/WebCore
Skip memcmp()ing fully downloaded resources after they become mmap()able.
<https://webkit.org/b/134362>
When we receive word that a downloaded resource is now available for mmap()ing
from the file system, we don't need to compare against the buffered data,
since even if there were a mismatch, the cached version should be the canonical one.
This was added as belt-and-suspenders while the supporting mechanism was being
developed in CFNetwork, and there's no evidence of a race today. This change
turns the runtime checks into debug-only assertions.
Saves ~300ms of main thread time on PLT.
Reviewed by Geoff Garen.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData):
- 3:18 PM Changeset in webkit [170498] by
-
- 2 edits in trunk/Source/WTF
Define TARGET_OS_IPHONE to 0 for non-darwin ports
https://bugs.webkit.org/show_bug.cgi?id=134347
Reviewed by Darin Adler.
A follow-up to r169880 to make it easier to reason about
the code. The purpose of this change to allow
"#if TARGET_OS_IPHONE" in public header files.
- wtf/Platform.h:
- 3:15 PM Changeset in webkit [170497] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Command-/ (slash) now auto-comments code via CodeMirror 4. Should remove as command to pause
https://bugs.webkit.org/show_bug.cgi?id=134313
Reviewed by Timothy Hatcher.
Changed alternate command to pause/resume from command-slash to command-backslash.
Command-slash sets/unsets comments in all code editors.
- UserInterface/Models/KeyboardShortcut.js: Added Backslash.
- UserInterface/Views/DebuggerSidebarPanel.js: Changed pauseOrResumeAlternateKeyboardShortcut to use Backslash instead of Slash.
- 3:12 PM Changeset in webkit [170496] by
-
- 3 edits in trunk/Source/WebKit/mac
[iOS] Remove User Default for iOS TextField Debugging
https://bugs.webkit.org/show_bug.cgi?id=134356
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-06-26
Reviewed by Timothy Hatcher.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 2:23 PM Changeset in webkit [170495] by
-
- 6 edits in trunk/Source/WebKit2
[iOS] Add API for opting into character selection granularity
https://bugs.webkit.org/show_bug.cgi?id=134354
Reviewed by Geoff Garen.
- Shared/API/Cocoa/WKFoundation.h: Added a definition of WK_ENUM_AVAILABLE_IOS.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h:
(WKSelectionGranularity): Added this enum with two values, one representing dynamic
granularity( the current, default behavior) and one representing character granularity.
Delcared new selectionGranularity property.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]): Copy the _selectionGranularity ivar.
- UIProcess/ios/WKContentViewInteraction.mm:
(toUIWebSelectionMode): Added this helper function for mapping WKSelectionGranularity values
to UIWebSelectionMode values.
(-[WKContentView setupInteraction]): Use a selection assistant with the mode specified in
the configuration.
(-[WKContentView _stopAssistingKeyboard]): Ditto.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture): Changed the behavior of the loupe gesture type in
non-editable text to select a word, rather than an empty range, matching the UITextView
behavior.
- 2:14 PM Changeset in webkit [170494] by
-
- 8 edits in tags/Safari-538.43/Source
Fix up for <rdar://problem/17446703>
- 2:07 PM Changeset in webkit [170493] by
-
- 2 edits in tags/Safari-538.43/Source/WebKit2
Merged r170492.
- 1:37 PM Changeset in webkit [170492] by
-
- 2 edits in trunk/Source/WebKit2
Change the target membership of WKBackForwardListPrivate.h from WebKit2 to WebKit.
Rubber-stamped by Dan Bernstein.
- WebKit2.xcodeproj/project.pbxproj:
- 1:17 PM Changeset in webkit [170491] by
-
- 2 edits in trunk/Source/WebKit2
Remove a useless return in WebPageProxyIOS
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-26
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateVisibleContentRects):
Darin caught this mistake in r170460.
- 12:37 PM Changeset in webkit [170490] by
-
- 25 edits7 adds in branches/ftlopt/Source/JavaScriptCore
Web Inspector: debugger should be able to show variable types
https://bugs.webkit.org/show_bug.cgi?id=133395
Patch by Saam Barati <sbarati@apple.com> on 2014-06-24
Reviewed by Filip Pizlo.
Increase the amount of type information the VM gathers when directed
to do so. This initial commit is working towards the goal of
capturing, and then showing (via the Web Inspector) type information for all
assignment and load operations. This patch doesn't have the feature fully
implemented, but it ensures the VM has no performance regressions
unless the feature is specifically turned on.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/CodeBlock.h:
- bytecode/Instruction.h:
- bytecode/TypeLocation.h: Added.
(JSC::TypeLocation::TypeLocation):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitMove):
(JSC::BytecodeGenerator::emitProfileTypesWithHighFidelity):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitPutByVal):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::isProfilingTypesWithHighFidelity):
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::ConstDeclNode::emitCodeSingle):
(JSC::ForInNode::emitBytecode):
- heap/Heap.cpp:
(JSC::Heap::collect):
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypeForVariableInTextRange):
- inspector/agents/InspectorRuntimeAgent.h:
- inspector/protocol/Runtime.json:
- jsc.cpp:
(GlobalObject::finishCreation):
(functionDumpTypesForAllVariables):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::putToScopeCommon):
- llint/LLIntSlowPaths.h:
- llint/LowLevelInterpreter.asm:
- runtime/HighFidelityLog.cpp: Added.
(JSC::HighFidelityLog::initializeHighFidelityLog):
(JSC::HighFidelityLog::~HighFidelityLog):
(JSC::HighFidelityLog::recordTypeInformationForLocation):
(JSC::HighFidelityLog::processHighFidelityLog):
(JSC::HighFidelityLog::actuallyProcessLogThreadFunction):
- runtime/HighFidelityLog.h: Added.
(JSC::HighFidelityLog::HighFidelityLog):
- runtime/HighFidelityTypeProfiler.cpp: Added.
(JSC::HighFidelityTypeProfiler::getTypesForVariableInRange):
(JSC::HighFidelityTypeProfiler::getGlobalTypesForVariableInRange):
(JSC::HighFidelityTypeProfiler::getLocalTypesForVariableInRange):
(JSC::HighFidelityTypeProfiler::insertNewLocation):
(JSC::HighFidelityTypeProfiler::getLocationBasedHash):
- runtime/HighFidelityTypeProfiler.h: Added.
- runtime/Options.h:
- runtime/Structure.cpp:
(JSC::Structure::toStructureShape):
- runtime/Structure.h:
- runtime/SymbolTable.cpp:
(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::cloneCapturedNames):
(JSC::SymbolTable::uniqueIDForVariable):
(JSC::SymbolTable::uniqueIDForRegister):
(JSC::SymbolTable::globalTypeSetForRegister):
(JSC::SymbolTable::globalTypeSetForVariable):
- runtime/SymbolTable.h:
(JSC::SymbolTable::add):
(JSC::SymbolTable::set):
- runtime/TypeSet.cpp: Added.
(JSC::TypeSet::TypeSet):
(JSC::TypeSet::getRuntimeTypeForValue):
(JSC::TypeSet::addTypeForValue):
(JSC::TypeSet::removeDuplicatesInStructureHistory):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::dumpSeenTypes):
(JSC::StructureShape::StructureShape):
(JSC::StructureShape::markAsFinal):
(JSC::StructureShape::addProperty):
(JSC::StructureShape::propertyHash):
(JSC::StructureShape::leastUpperBound):
(JSC::StructureShape::stringRepresentation):
- runtime/TypeSet.h: Added.
(JSC::StructureShape::create):
(JSC::TypeSet::create):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::getTypesForVariableInRange):
(JSC::VM::updateHighFidelityTypeProfileState):
(JSC::VM::dumpHighFidelityProfilingTypes):
- runtime/VM.h:
(JSC::VM::isProfilingTypesWithHighFidelity):
(JSC::VM::highFidelityLog):
(JSC::VM::highFidelityTypeProfiler):
(JSC::VM::nextLocation):
(JSC::VM::getNextUniqueVariableID):
- 12:21 PM Changeset in webkit [170489] by
-
- 3 edits in branches/ftlopt/Source/JavaScriptCore
Remove unused instantiation of the WithScope structure.
<https://webkit.org/b/134331>
Reviewed by Oliver Hunt.
The WithScope structure instance is the VM is unused, and is now removed.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
- 11:49 AM Changeset in webkit [170488] by
-
- 2 edits in trunk/Source/WebCore
[MSE] Refactoring: Use C++11 for-loops in SourceBuffer.
https://bugs.webkit.org/show_bug.cgi?id=134352
Reviewed by Darin Adler.
Use C++11 style for-loops where appropriate in SourceBuffer now that the
SampleMap ordered objects support them.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime):
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime):
(WebCore::SourceBuffer::sourceBufferPrivateAppendComplete):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):
(WebCore::SourceBuffer::validateInitializationSegment):
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):
- 11:32 AM Changeset in webkit [170487] by
-
- 2 edits in trunk/Source/WebCore
[iOS]: Tapping <button> outside of a form is no longer working
https://bugs.webkit.org/show_bug.cgi?id=134319
<rdar://problem/17213346>
Reviewed by Daniel Bates.
Restore behavior of allowing <button> clicks outside of <form>.
This used to be iOS behavior before it was removed in favor of the
OpenSource (Android?) behavior. Now, willRespondToMouseClickEvents
is only used by iOS, so lets restore the iOS behavior.
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
- 11:31 AM Changeset in webkit [170486] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build-fix. Remove unintentionial rename of MediaTime.h -> MediaTimeHash.h.
- Modules/mediasource/SampleMap.h:
- 11:29 AM Changeset in webkit [170485] by
-
- 2 edits in trunk/Source/WebCore
[iOS] no need to deactivate audio session
https://bugs.webkit.org/show_bug.cgi?id=134350
Reviewed by Jer Noble.
- platform/audio/mac/MediaSessionManagerMac.cpp:
(MediaSessionManager::updateSessionState): Don't bother calling
AudioSession::setActive(false), WebCore's audio session will be deactivated
automatically if another application begins playing audio.
- 11:17 AM Changeset in webkit [170484] by
-
- 4 edits in trunk/Source/WebCore
[MSE] Refactoring: Differentiate between SampleMap decode and presentation order methods
https://bugs.webkit.org/show_bug.cgi?id=134349
Reviewed by Geoffrey Garen.
Refactor SampleMap to clarify the distinction between methods which return decode-order
iterators and ones which retun presentation-order iterators.
Add two classes, PresentationOrderSampleMap and DecodeOrderSampleMap, to contain the actual
MediaTime-to-Sample maps, and move the methods returning presentation-order and decode-order
iterators to each, respectively. Rename the {presentation,decode}{Begin,End}() methods to
begin() and end() so the objects can be used in C++11 for-loops.
Update all the call sites in SourceBuffer to use the new ordered objects.
- Modules/mediasource/SampleMap.cpp:
(WebCore::SampleIsLessThanMediaTimeComparator::operator()): Use new ordered objects.
(WebCore::SampleIsGreaterThanMediaTimeComparator::operator()): Ditto.
(WebCore::SampleMap::clear): Ditto.
(WebCore::SampleMap::addSample): Ditto.
(WebCore::SampleMap::removeSample): Ditto.
(WebCore::PresentationOrderSampleMap::findSampleContainingPresentationTime): Renamed from SampleMap version.
(WebCore::PresentationOrderSampleMap::findSampleAfterPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSampleWithDecodeTime): Ditto.
(WebCore::PresentationOrderSampleMap::reverseFindSampleContainingPresentationTime): Ditto.
(WebCore::PresentationOrderSampleMap::reverseFindSampleBeforePresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::reverseFindSampleWithDecodeTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSamplePriorToPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSamplePriorToDecodeIterator): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime): Ditto.
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterDecodeIterator): Ditto.
(WebCore::PresentationOrderSampleMap::findSamplesBetweenPresentationTimes): Ditto.
(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRange): Ditto.
(WebCore::DecodeOrderSampleMap::findDependentSamples): Ditto.
- Modules/mediasource/SampleMap.h:
(WebCore::PresentationOrderSampleMap::begin): Renamed from presentationBegin().
(WebCore::PresentationOrderSampleMap::end): Renamed from presentationEnd().
(WebCore::PresentationOrderSampleMap::rbegin): Renamed from reversePresentationBegin().
(WebCore::PresentationOrderSampleMap::rend): Renamed from reversePresentationEnd().
(WebCore::DecodeOrderSampleMap::begin): Renamed from decodeBegin().
(WebCore::DecodeOrderSampleMap::end): Renamed from decodeEnd().
(WebCore::DecodeOrderSampleMap::rbegin): Renamed from reverseDecodeBegin().
(WebCore::DecodeOrderSampleMap::rend): Renamed from reverseDecodeEnd().
(WebCore::SampleMap::SampleMap): Create new ordered objects.
(WebCore::SampleMap::sizeInBytes): Use new ordered objects.
(WebCore::SampleMap::decodeOrder): Simple accessor.
(WebCore::SampleMap::presentationOrder): Simple accessor.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime): Use new ordered objects.
(WebCore::SourceBuffer::sourceBufferPrivateFastSeekTimeForMediaTime): Ditto.
(WebCore::SourceBuffer::removeCodedFrames): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::bufferedSamplesForTrackID): Ditto.
- 10:22 AM Changeset in webkit [170483] by
-
- 18 edits in trunk
[Win] Expose Cache Information to WinLauncher
https://bugs.webkit.org/show_bug.cgi?id=134318
Reviewed by Dean Jackson.
Source/JavaScriptCore:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj: Add missing
MemoryStatistics files to the WIndows build.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
Source/WebKit:
- WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Copy the
CFDictionaryPropertyBag header to WebKit API directory.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Expose the dictionary accessor for the CFDictionaryPropertyBag.
Source/WebKit/win:
- Interfaces/IWebCoreStatistics.idl: Add missing
API added to WebKit since this was last updated.
- WebCache.cpp:
(WebCache::statistics): Add missing elements for
purgable and purged data.
- WebCoreStatistics.cpp: Provide implementaions.
- WebCoreStatistics.h: Ditto.
Tools:
- WinLauncher/Common.cpp: Update for new dialog.
- WinLauncher/WinLauncher.cpp: Add support for WebCache
and WebCoreStatistics.
- WinLauncher/WinLauncher.h:
- WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
Update for new Cache Dialog.
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to
WTF.lib
- WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
for new Dialog.
- 10:01 AM Changeset in webkit [170482] by
-
- 7 edits1 delete in trunk/Source
Add an undo group for each dictated utterance in WebKit
https://bugs.webkit.org/show_bug.cgi?id=134086
Applied review comments from Sam Weinig.
Move the associated USE #define into Platform.h.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- editing/mac/TextUndoInsertionMarkup.h: Removed.
- editing/mac/TextUndoInsertionMarkupMac.h:
Source/WebKit2:
- UIProcess/PageClient.h:
Source/WTF:
- wtf/Platform.h:
- 9:52 AM Changeset in webkit [170481] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed gardening. Use consistent line-endings in file.
- WinLauncher/WinLauncher.h: Use '\n' EOL marker, not DOS-style
'\r\n' EOL.
- 8:30 AM Changeset in webkit [170480] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::FunctionWhitelist::parseFunctionNamesInFile does not close file
<http://webkit.org/b/134343>
<rdar://problem/17459487>
Reviewed by Michael Saboff.
- dfg/DFGFunctionWhitelist.cpp:
(JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile):
Close the file handle, and log an error on failure.
- 8:00 AM Changeset in webkit [170479] by
-
- 2 edits in trunk/Source/WebCore
[EFL][WK2] Fix Debug Build Error in Webcore module.
https://bugs.webkit.org/show_bug.cgi?id=134345
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-06-26
Reviewed by Zalan Bujtas.
Use static cast to change the type of variable to fix error
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setDrawRange):
- 7:05 AM Changeset in webkit [170478] by
-
- 2 edits in trunk/Source/WebCore
[Mac] allow host application to canonicalize media urls
https://bugs.webkit.org/show_bug.cgi?id=134329
Reviewed by Dean Jackson.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::canonicalURL): New, use NSURLProtocol to canonicalize a URL.
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Call canonicalURL.
- 1:20 AM Changeset in webkit [170477] by
-
- 8 edits in tags/Safari-538.43/Source
Merge patch for <rdar://problem/17446703>.
- 12:48 AM Changeset in webkit [170476] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Add padding for future expansion to WebKitDOMEventTargetIface
https://bugs.webkit.org/show_bug.cgi?id=134298
Reviewed by Martin Robinson.
- bindings/gobject/WebKitDOMEventTarget.h:
- 12:45 AM Changeset in webkit [170475] by
-
- 5 edits in trunk/Source/WebCore
[GTK] Add support for constants in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=133983
Reviewed by Martin Robinson.
- bindings/gobject/webkitdom.symbols: Add stable constants.
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateHeader): Add constants to the header.
(Generate): Pass the interface object to GenerateHeader to get the constants
(IsInterfaceSymbol): Helper function that returns whether the given
symbol belongs to the interface. Check also constants now.
(ReadStableSymbols): Use IsInterfaceSymbol().
- bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- 12:30 AM Changeset in webkit [170474] by
-
- 5 edits6 adds in trunk
[CSS Grid Layout] Properly support for z-index on grid items
https://bugs.webkit.org/show_bug.cgi?id=103329
Reviewed by Benjamin Poulain.
From Blink r157620 by <jchaffraix@chromium.org> and r172402 by
<wangxianzhu@chromium.org>.
Source/WebCore:
The specification says that grid should match flexbox and force
grid items to be stacking context if z-index is set, regardless
of 'position'. After this change, this is what happens.
Previously z-index changes of static positioned objects were ignored.
However, z-index is applicable for some static positioned objects,
such as grid items. Ignoring them makes the object not to be properly
painted on z-index change.
As StyleResolver has ensured that z-index is non-auto only if
applicable, RenderStyle::changeRequiresLayerRepaint() should not check
again (with inconsistent conditions).
Tests: fast/css-grid-layout/grid-item-z-index-change-repaint.html
fast/css-grid-layout/grid-item-z-index-stacking-context.html
fast/css-grid-layout/grid-item-z-index-support.html
- css/StyleResolver.cpp:
(WebCore::isDisplayFlexibleOrGridBox): Add new method to check if parent
display is flexbox or grid.
(WebCore::StyleResolver::adjustRenderStyle): Use new method in z-index
condition.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayerRepaint): Move z-index checks
out of non-static positioned objects if.
LayoutTests:
- css3/blending/repaint/blend-mode-turn-off-isolation-expected.txt: Test rebaseline.
- fast/css-grid-layout/grid-item-z-index-change-repaint-expected.html: Added.
- fast/css-grid-layout/grid-item-z-index-change-repaint.html: Added.
- fast/css-grid-layout/grid-item-z-index-stacking-context-expected.html: Added.
- fast/css-grid-layout/grid-item-z-index-stacking-context.html: Added.
- fast/css-grid-layout/grid-item-z-index-support-expected.txt: Added.
- fast/css-grid-layout/grid-item-z-index-support.html: Added.
- 12:25 AM Changeset in webkit [170473] by
-
- 5 edits in trunk/Source
Versioning.
- 12:24 AM Changeset in webkit [170472] by
-
- 1 copy in tags/Safari-538.43
New Tag.
