Context Navigation

(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Cast the return value of
[getMPAudioVideoRoutingPopoverControllerClass() alloc] to resolve ambiguity about which
-initWithType: we are calling.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Cast to resolve ambiguity.
(-[WKAirPlayRoutePicker show:fromRect:]): Cast for consistency.

10:58 PM Changeset in webkit [176440] by bshafiei@apple.com

5 edits in tags/Safari-601.1.10.1/Source

Versioning.

10:55 PM Changeset in webkit [176439] by bshafiei@apple.com

1 copy in tags/Safari-601.1.10.1

New tag.

10:26 PM Changeset in webkit [176438] by commit-queue@webkit.org

2 edits in trunk/Tools

[EFL] The option value of fixed layout is false in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=138830

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-20
Reviewed by Gyuyoung Kim.

Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.

MiniBrowser/efl/main.c:

8:49 PM Changeset in webkit [176437] by benjamin@webkit.org

17 edits in trunk/Source

Remove the remaining vestiges of minimal-ui
https://bugs.webkit.org/show_bug.cgi?id=138890

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-20
Reviewed by Sam Weinig.

Source/WebCore:

In ViewportArguments' setViewportFeature(), I skip the warning for now.

WebCore.exp.in:
dom/ViewportArguments.cpp:

(WebCore::setViewportFeature):

dom/ViewportArguments.h:

(WebCore::ViewportArguments::ViewportArguments):
(WebCore::ViewportArguments::operator==):

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::ViewportConfiguration):
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::minimumScale):
(WebCore::ViewportConfiguration::updateConfiguration):
(WebCore::ViewportConfiguration::viewportArgumentsLength):
(WebCore::ViewportConfiguration::layoutWidth):
(WebCore::ViewportConfiguration::layoutHeight):
(WebCore::ViewportConfigurationTextStream::operator<<):
(WebCore::ViewportConfiguration::description):
(WebCore::ViewportConfiguration::setMinimumLayoutSizeForMinimalUI): Deleted.
(WebCore::ViewportConfiguration::activeMinimumLayoutSizeInScrollViewCoordinates): Deleted.
(WebCore::ViewportConfiguration::resetMinimalUI): Deleted.
(WebCore::ViewportConfiguration::didFinishDocumentLoad): Deleted.

page/ViewportConfiguration.h:

(WebCore::ViewportConfiguration::minimumLayoutSizeForMinimalUI): Deleted.
(WebCore::ViewportConfiguration::usesMinimalUI): Deleted.

Source/WebKit/ios:

WebCoreSupport/WebChromeClientIOS.mm:

(dictionaryForViewportArguments):

WebKit.iOS.exp:

Source/WebKit/mac:

History/WebHistoryItem.mm:
History/WebHistoryItemPrivate.h:

Source/WebKit2:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::didFinishDocumentLoad): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::savePageState):
(WebKit::WebPage::restorePageState):
(WebKit::WebPage::viewportConfigurationChanged):
(WebKit::WebPage::updateViewportSizeForCSSViewportUnits):

8:31 PM Changeset in webkit [176436] by benjamin@webkit.org

4 edits in trunk/Source/WebCore

Web Inspector: do not show invalid specificity for dynamic cases of :matches()
https://bugs.webkit.org/show_bug.cgi?id=138911

Reviewed by Joseph Pecoraro.

css/CSSSelector.cpp:

(WebCore::simpleSelectorFunctionalPseudoClassStaticSpecificity):
(WebCore::functionalPseudoClassStaticSpecificity):
(WebCore::staticSpecificityInternal):
(WebCore::CSSSelector::staticSpecificity):
(WebCore::CSSSelector::specificity): Deleted.

css/CSSSelector.h:

Add an additional computation path for the inspector.

The regular path ignores everything inside function pseudo classes.
This new path takes the static specificity of the regular path, then evaluate
recursively all the selector lists inside any level of :matches().

If two complex selector of selector list do not have the same specificity,
we bail out and refuse to compute a static specificity representing the selector.

inspector/InspectorStyleSheet.cpp:

(WebCore::buildObjectForSelectorHelper):
(WebCore::selectorsFromSource):
(WebCore::InspectorStyleSheet::buildObjectForSelector):
Do not add the complexity to the inspector's CSSSelector structure whenever
it is dynamic.

8:30 PM Changeset in webkit [176435] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Fix misc bugs and typos in app.js
https://bugs.webkit.org/show_bug.cgi?id=138946

Reviewed by Benjamin Poulain.

public/v2/app.js:

(App.DashboardPaneProxyForPicker._platformOrMetricIdChanged):
(App.ChartsController.init):
(App.buildPopup): Renamed from App.BuildPopup.
(App.InteractiveChartComponent._constructGraphIfPossible): Fixed the bug that we were calling
remove() on the wrong object (an array as opposed to elements in the array).
(App.InteractiveChartComponent._highlightedItemsChanged): Check the length of _highlights as
_highlights is always an array and evalutes to true.

8:26 PM Changeset in webkit [176434] by benjamin@webkit.org

3 edits in trunk/Source/WebCore

Remove InspectorCSSAgent::buildArrayForRuleList()
https://bugs.webkit.org/show_bug.cgi?id=138907

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-20
Reviewed by Andreas Kling.

inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::buildArrayForRuleList): Deleted.

inspector/InspectorCSSAgent.h:

7:47 PM Changeset in webkit [176433] by dbates@webkit.org

2 edits in trunk/LayoutTests

[iOS] Skip some tests that fail with stderr

platform/ios-simulator/TestExpectations:

7:17 PM Changeset in webkit [176432] by Alan Bujtas

3 edits
2 adds in trunk

REGRESSION (174986): CSS clip property is ignored when border-radius is present.
https://bugs.webkit.org/show_bug.cgi?id=138935
rdar://problem/18965984

Reviewed by Simon Fraser.

Revert back to r163382 and fix bug 127729 properly. Save the graphics context when paint and clip rects are
the same, but the clip rect has radius.
Each iteration on ::clipRect() from r163382 onwards just introduced yet another regression.

Source/WebCore:

Test: fast/clip/css-clip-does-not-work-when-border-radius-is-present.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipToRect):

LayoutTests:

fast/clip/css-clip-does-not-work-when-border-radius-is-present-expected.html: Added.
fast/clip/css-clip-does-not-work-when-border-radius-is-present.html: Added.

6:27 PM Changeset in webkit [176431] by ggaren@apple.com

9 edits
2 deletes in trunk/Source/WebCore

Removed the custom allocator for PODRedBlackTree
https://bugs.webkit.org/show_bug.cgi?id=138942

Reviewed by Sam Weinig.

bmalloc is fast enough.

WebCore.xcodeproj/project.pbxproj:
platform/PODArena.h: Removed.
platform/PODFreeListArena.h: Removed. This is the point of the patch.

platform/PODIntervalTree.h:

(WebCore::PODIntervalTree::PODIntervalTree): Deleted. As a side effect
of removing our custom allocator, we can no longer have a special
"I'm not initialized yet" state. Instead, the tree either exists or not,
like an idiomatic C++ object.

platform/PODRedBlackTree.h:

(WebCore::PODRedBlackTree::PODRedBlackTree): Ditto.

(WebCore::PODRedBlackTree::~PODRedBlackTree): We need to clear in our
destructor because we can no longer rely on the arena destructor
implicitly freeing our tree nodes.

Side note: This change basically removes the whole reason for having
a purpose-built tree for POD data. We should probably remove this whole
data structure in a follow-up patch, and just use a standard tree.

(WebCore::PODRedBlackTree::clear):
(WebCore::PODRedBlackTree::add):
(WebCore::PODRedBlackTree::remove):
(WebCore::PODRedBlackTree::contains):
(WebCore::PODRedBlackTree::visitInorder):
(WebCore::PODRedBlackTree::size):
(WebCore::PODRedBlackTree::checkInvariants):
(WebCore::PODRedBlackTree::dump):
(WebCore::PODRedBlackTree::deleteNode):
(WebCore::PODRedBlackTree::markFree): Use normal new/delete, and mark
ourselves as fast allocated so we get the bmalloc goodness.

(WebCore::PODRedBlackTree::isInitialized): Deleted.
(WebCore::PODRedBlackTree::initIfNeeded): Deleted.

rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clear):
(WebCore::FloatingObjects::addPlacedObject):
(WebCore::FloatingObjects::removePlacedObject):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::FloatingObjects::placedFloatsTree):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset): POD tree had a slightly
weird behavior in which it was valid to use some of its APIs without
first initializing it, but not others. It's not really possible to model
that behavior with normal C++ objects that use new/delete, so instead
I added some explicit NULL checks.

rendering/FloatingObjects.h:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):

rendering/RenderView.cpp:

(WebCore::RenderView::intervalArena): Deleted.

rendering/RenderView.h: Removed custom-allocator-related cruft.

6:10 PM Changeset in webkit [176430] by Beth Dakin

2 edits in trunk/Source/WebKit2

Preview popover needs minimum and maximum sizes
https://bugs.webkit.org/show_bug.cgi?id=138943
-and corresponding-
rdar://problem/18904651

Reviewed by Tim Horton.

Quick follow-up to get the right screen.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController largestPopoverSize]):

5:52 PM Changeset in webkit [176429] by Beth Dakin

3 edits in trunk/Source/WebKit2

Preview popover needs minimum and maximum sizes
https://bugs.webkit.org/show_bug.cgi?id=138943
-and corresponding-
rdar://problem/18904651

Reviewed by Tim Horton.

This patch enforces minimum and maximum popover sizes. If the popover needs to be
sized up to be above the minimum, it will end up covering some of the
_hitTestResult, so we should compute a new origin rect based on the original
event location.

UIProcess/mac/WKActionMenuController.h:
UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController prepareForMenu:withEvent:]):
(-[WKActionMenuController _previewURLFromActionMenu:]):
(-[WKActionMenuController _createPreviewPopover]):
(-[WKActionMenuController largestPopoverSize]):
(-[WKActionMenuController _preferredPopoverSize]):
(-[WKActionMenuController _preferredSizeForPopoverPresentedFromOriginRect:]): Deleted.

4:57 PM Changeset in webkit [176428] by Conrad Shultz

2 edits in trunk/Source/WebKit2

Clicks on previews can be recognized multiple times
https://bugs.webkit.org/show_bug.cgi?id=138944

Reviewed by Tim Horton.

UIProcess/mac/WKActionMenuController.mm:

(-[WKPagePreviewViewController _clickRecognized:]):
Only dispatch the delegate message on the appropriate gesture recognizer state transition.

4:36 PM Changeset in webkit [176427] by Conrad Shultz

4 edits in trunk/Source/WebKit2

Clients should be able to customize preview click behavior
https://bugs.webkit.org/show_bug.cgi?id=138940

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKViewPrivate.h:

Declare -_handleClickInPreviewView:URL:.

UIProcess/API/mac/WKView.mm:

(-[WKView _handleClickInPreviewView:URL:]):
Extracted from -[WKActionMenuController pagePreviewViewControllerWasClicked:].

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController pagePreviewViewControllerWasClicked:]):
Extract code to -[WKView _handleClickInPreviewView:URL:].

4:28 PM Changeset in webkit [176426] by dburkart@apple.com

1 copy in tags/Safari-600.3.8

Tagging.

3:39 PM Changeset in webkit [176425] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Add some comments to describe the DFG UseKind representations.
<https://webkit.org/b/138934>

Reviewed by Filip Pizlo.

dfg/DFGUseKind.h:
Also regrouped the UseKind enums by representation to be more readable.

3:28 PM Changeset in webkit [176424] by mark.lam@apple.com

8 edits
2 adds in trunk/Source/JavaScriptCore

Add Heap verification infrastructure.
<https://webkit.org/b/138851>

Reviewed by Geoffrey Garen.

The verification infrastructure code is always built in but disabled by
default. When disabled, the cost is minimal:

Heap has a m_verifier field.
GC does a few "if (m_verifier)" checks that should fail.
HeapVerifier takes up code space though not used.

When enabled:

The HeapVerifier will keep N number of GC cycle data. Each GC cycle will contain a "before marking" and "after marking" live object list. The GC cycles is a circular buffer. Only data for the last N GC cycles will be retained.
During GC, the current GC cycle's live objects lists will be populated before and after marking.
The current GC cycle's live object lists will be validated before GC, after marking, and after GC.

Currently, the only validation being done is to verify that object
butterflies are allocated from valid blocks in the Storage (aka Copied)
space.

CMakeLists.txt:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::collect):

heap/Heap.h:
heap/HeapVerifier.cpp: Added.

(JSC::LiveObjectList::findObject):
(JSC::HeapVerifier::HeapVerifier):
(JSC::HeapVerifier::collectionTypeName):
(JSC::HeapVerifier::phaseName):
(JSC::getButterflyDetails):
(JSC::HeapVerifier::initializeGCCycle):
(JSC::GatherLiveObjFunctor::GatherLiveObjFunctor):
(JSC::GatherLiveObjFunctor::operator()):
(JSC::HeapVerifier::gatherLiveObjects):
(JSC::HeapVerifier::liveObjectListForGathering):
(JSC::trimDeadObjectsFromList):
(JSC::HeapVerifier::trimDeadObjects):
(JSC::HeapVerifier::verifyButterflyIsInStorageSpace):
(JSC::HeapVerifier::verify):
(JSC::HeapVerifier::reportObject):
(JSC::HeapVerifier::checkIfRecorded):

heap/HeapVerifier.h: Added.

(JSC::LiveObjectData::LiveObjectData):
(JSC::LiveObjectList::LiveObjectList):
(JSC::LiveObjectList::reset):
(JSC::HeapVerifier::GCCycle::GCCycle):
(JSC::HeapVerifier::GCCycle::collectionTypeName):
(JSC::HeapVerifier::incrementCycle):
(JSC::HeapVerifier::currentCycle):
(JSC::HeapVerifier::cycleForIndex):

runtime/Options.h:

3:26 PM Changeset in webkit [176423] by dino@apple.com

32 edits
7 adds in trunk

Support unprefixed animation event types
https://bugs.webkit.org/show_bug.cgi?id=138931
<rdar://problem/18943167>

Reviewed by Simon Fraser.

Source/WebCore:

Tests: animations/unprefixed-events-mixed-with-prefixed.html

animations/unprefixed-events.html

Support the unprefixed animation event names:

animationstart (was webkitAnimationStart)
animationiteration (was webkitAnimationIteration)
animationend (was webkitAnimationEnd)

(Yes, event types are case sensitive and yes, this will
likely cause some head-scratching as people change content)

The approach here is to follow what transitions does:

listener only for old event name -> fire old event name
listener for both old and new event name -> fire new event name
listener only for new event name -> fire new event name

That way pages that were trying to anticipate the new event name
won't get duplicate events.

CMakeLists.txt: Add new AnimationEvent* stuff.
DerivedSources.make: Ditto.
WebCore.vcxproj/WebCore.vcxproj: Ditto.
WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

bindings/js/JSBindingsAllInOne.cpp: New files for all in one builds.
dom/DOMAllInOne.cpp:

dom/AnimationEvent.cpp: Added. Copied from WebKitAnimationEvent.cpp.

(WebCore::AnimationEventInit::AnimationEventInit):
(WebCore::AnimationEvent::AnimationEvent):
(WebCore::AnimationEvent::~AnimationEvent):
(WebCore::AnimationEvent::animationName):
(WebCore::AnimationEvent::elapsedTime):
(WebCore::AnimationEvent::eventInterface):

dom/AnimationEvent.h: Added. Copied from WebKitAnimationEvent.h.
dom/AnimationEvent.idl: Added. Copied from WebKitAnimationEvent.idl.

dom/Document.cpp:

(WebCore::Document::addListenerTypeIfNeeded): Handle new event types.

dom/EventNames.h: New names.
dom/EventNames.in:

dom/EventTarget.cpp:

(WebCore::legacyType): Provide a mapping from the new names to the older
prefixed forms.

html/HTMLAttributeNames.in: Support the on* attributes, even though I

hate them and wish this approach would die.

html/HTMLElement.cpp:

(WebCore::HTMLElement::populateEventNameForAttributeLocalNameMap):

page/DOMWindow.h: New names, and constructors.
page/DOMWindow.idl:

page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Fire new type.

page/animation/KeyframeAnimation.cpp: Fire the new types of events.

(WebCore::KeyframeAnimation::onAnimationStart):
(WebCore::KeyframeAnimation::onAnimationIteration):
(WebCore::KeyframeAnimation::onAnimationEnd):
(WebCore::KeyframeAnimation::sendAnimationEvent):

LayoutTests:

Add a test for unprefixed animation event names, as well
as a test that ensures we don't get multiple dispatches if
we're still listening for the old events.

And for the older tests, just add the new things from the
window namespace.

animations/unprefixed-events-expected.txt: Added.
animations/unprefixed-events-mixed-with-prefixed-expected.txt: Added.
animations/unprefixed-events-mixed-with-prefixed.html: Added.
animations/unprefixed-events.html: Added.

fast/events/event-creation-expected.txt:
fast/events/event-creation.html:
js/dom/constructor-length.html:
js/dom/global-constructors-attributes-expected.txt:
platform/efl/js/dom/constructor-length-expected.txt:
platform/efl/js/dom/global-constructors-attributes-expected.txt:
platform/gtk/js/dom/constructor-length-expected.txt:
platform/gtk/js/dom/global-constructors-attributes-expected.txt:
platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
platform/mac-mountainlion/js/dom/global-constructors-attributes-expected.txt:
platform/mac/js/dom/constructor-length-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:
platform/win/js/dom/global-constructors-attributes-expected.txt:

3:25 PM Changeset in webkit [176422] by rniwa@webkit.org

11 edits in trunk/Websites/perf.webkit.org

New perf dashboard should provide UI to create a new analysis task
https://bugs.webkit.org/show_bug.cgi?id=138910

Reviewed by Benjamin Poulain.

This patch reverts some parts of r175006 and re-introduces bugs associated with analysis tasks.
I'll add UI to show and edit bug numbers associated with an analysis task in a follow up patch.

With this patch, we can create a new analysis task by selection a range of points and opening
"analysis pane" (renamed from "bugs pane"). Each analysis task created is represented by a yellow bar
in the chart hyperlinked to the analysis task.

init-database.sql: Redefined the bugs to be associated with an analysis task instead of a test run.

public/api/analysis-tasks.php: Added the support for querying analysis tasks for a specific metric

on a specific platform. Also retrieve and return all bugs associated with analysis tasks.
(main):
(fetch_and_push_bugs_to_tasks): Added. Fetches all bugs associated with an array of analysis tasks
and adds the associated bugs to each task in the array.
(format_task):

public/api/runs.php: Reverted changes made in r175006.

(fetch_runs_for_config):
(format_run):

public/api/test-groups.php:

(fetch_test_groups_for_task): Use the newly added Database::select_rows.

public/include/db.php:

(Database::select_first_or_last_row):
(Database::select_rows): Extracted from select_first_or_last_row.

public/v2/analysis.js:

(App.AnalysisTask): Added "bugs" property.
(App.Bug): Added now that bugs are regular data store objects.

public/v2/app.js:

(App.Pane._fetch): Calls this.fetchAnalyticRanges to fetch analysis tasks as well as test runs.
(App.Pane.fetchAnalyticRanges): Added. Fetches analysis tasks for the current metric on the current
platform that are associated with a specific range of runs.
(App.PaneController.actions.toggleBugsPane): Updated per showingBugsPane to showingAnalysisPane rename.
(App.PaneController.actions.associateBug): Deleted.
(App.PaneController.actions.createAnalysisTask): Replaced the pre-condition checks with assertions as
this action should never be triggered when the pre-condition is not met. Also re-fetch analysis tasks
once we've created one.
(App.PaneController.toggleSearchPane): Updated per showingBugsPane to showingAnalysisPane rename.
(App.PaneController._detailsChanged): Ditto. Removed selectedSinglePoint since it's no longer used.
(App.PaneController._showDetails): Call _updateCanAnalyze to update the status of "Analyze" button.
(App.PaneController._updateBugs): Deleted.
(App.PaneController._updateMarkedPoints): Deleted.
(App.PaneController._updateCanAnalyze): Added. Disables the button to create an analysis task when
the name is missing or when at most one point is selected.

(App.InteractiveChartComponent._constructGraphIfPossible): Update the locations of range rects.
(App.InteractiveChartComponent._relayoutDataAndAxes): Ditto.
(App.InteractiveChartComponent._mousePointInGraph): Don't return a point unless the mouse cursor is
on our svg element to avoid locking the current item when a bar shown for an analysis task is clicked.
(App.InteractiveChartComponent._rangesChanged): Added. Creates an array of objects representing
clickable bars for analysis tasks.
(App.InteractiveChartComponent._updateRangeBarRects): Computes the inline style used by each clickable
bar for analysis tasks to place them at the right location.
(App.InteractiveChartComponent.actions.openRange): Added. Forwards the action to the parent controller.

public/v2/chart-pane.css:

(.chart .extent): Use the same color as the vertical indicator in the highlight behind the selection.
(.chart .rangeBar): Added.

public/v2/data.js:

(TimeSeries.prototype.nextPoint): Added. Used by _rangesChanged.

public/v2/index.html: Renamed "bugs pane" to "analysis pane" and removed the UI to associate bugs.

This ability will be reinstated in a follow up patch. Also added a container div and spans for analysis
task bars in the interactive chart component.

3:04 PM Changeset in webkit [176421] by Csaba Osztrogonác

2 edits in trunk/Source/WebKit2

URTBF after r176420 to fix non Apple builds.

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):

2:56 PM Changeset in webkit [176420] by andersca@apple.com

6 edits in trunk/Source/WebKit2

WebPlugInClient::m_webPage can never be null, use a reference
https://bugs.webkit.org/show_bug.cgi?id=138937

Reviewed by Andreas Kling.

WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::WebPlugInClient):
(WebKit::WebPlugInClient::shouldAutoStartFromOrigin):

WebProcess/WebCoreSupport/WebPlugInClient.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):

WebProcess/WebProcess.h:

2:33 PM Changeset in webkit [176419] by dbates@webkit.org

2 edits in trunk/LayoutTests

[iOS] Update TestExpectation file for LayoutTests/canvas tests

Also skip some LayoutTests/animation tests that are flaky or fail due to an assertion failure.

platform/ios-simulator/TestExpectations:

2:26 PM Changeset in webkit [176418] by timothy_horton@apple.com

4 edits in trunk/Source/WebKit2

TextIndicator should have getters for TextIndicator::Data properties
https://bugs.webkit.org/show_bug.cgi?id=138920

Reviewed by Beth Dakin.

Instead of having clients reach into the data(), add getters.
Remove frameRect(), which is identical to the textBoundingRectInWindowCoordinates getter.
Remove declarations for draw/drawContentImage, which were already removed.

Shared/TextIndicator.cpp:

(WebKit::TextIndicator::frameRect): Deleted.

Shared/TextIndicator.h:

(WebKit::TextIndicator::textBoundingRectInWindowCoordinates):
(WebKit::TextIndicator::textRectsInBoundingRectCoordinates):
(WebKit::TextIndicator::contentImageScaleFactor):
(WebKit::TextIndicator::contentImageWithHighlight):
(WebKit::TextIndicator::contentImage):

UIProcess/mac/TextIndicatorWindow.mm:

(-[WKTextIndicatorView initWithFrame:textIndicator:margin:]):
(-[WKTextIndicatorView presentWithCompletionHandler:]):
(WebKit::TextIndicatorWindow::setTextIndicator):

2:23 PM Changeset in webkit [176417] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Remove a piece of DataDetectors SPI that we aren't using anymore
https://bugs.webkit.org/show_bug.cgi?id=138917

Reviewed by Beth Dakin.

platform/spi/mac/DataDetectorsSPI.h:

2:17 PM Changeset in webkit [176416] by ap@apple.com

2 edits in trunk/LayoutTests

Skip flaky inspector-protocol/debugger tests.
webkit.org/b/100846, webkit.org/b/136715

platform/mac/TestExpectations:

2:16 PM Changeset in webkit [176415] by timothy_horton@apple.com

4 edits in trunk/Source

Cancel DataDetectors menu earlier if we know it can't be presented
https://bugs.webkit.org/show_bug.cgi?id=138922
<rdar://problem/18950441>

Reviewed by Beth Dakin.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController willOpenMenu:withEvent:]):
If we end up with a menu with no items, don't change selection or anything.

(-[WKActionMenuController menuNeedsUpdate:]):
Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
and use a bigger hammer (removeAllItems).

WebView/WebActionMenuController.mm:

(-[WebActionMenuController prepareForMenu:withEvent:]):
Move our call to shouldUseActionsWithContext earlier, to menuNeedsUpdate,
and use a bigger hammer (removeAllItems).

(-[WebActionMenuController willOpenMenu:withEvent:]):
If we end up with a menu with no items, don't change selection or anything.

2:10 PM Changeset in webkit [176414] by timothy_horton@apple.com

3 edits in trunk/Source/WebKit2

Don't use a TextIndicator BounceAndCrossfade transition if the selection highlight is never shown
https://bugs.webkit.org/show_bug.cgi?id=138919
<rdar://problem/19042207>

Reviewed by Beth Dakin.

Shared/TextIndicator.h:

(WebKit::TextIndicator::presentationTransition):
(WebKit::TextIndicator::setPresentationTransition):
Add getter and setter pair.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
If the selection highlight will never be shown because there's only a single menu item,
use a normal bounce animation instead of bounce + crossfade.

2:10 PM Changeset in webkit [176413] by ap@apple.com

262 edits
1 move
2 adds in trunk/LayoutTests

http tests should not use shared temporary files, part 2
https://bugs.webkit.org/show_bug.cgi?id=138894

Rubber-stamped by Tim Horton.

Made more scripts that access local files use per-test files. Some tests could use
HTTP referrer, others needed explicit parameters.

http/tests/security/contentSecurityPolicy/1.1/reflected-xss-allow.html:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-block.html:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-empty.html:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-filter.html:
http/tests/security/contentSecurityPolicy/1.1/reflected-xss-invalid.html:
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
http/tests/security/contentSecurityPolicy/report-uri-from-child-frame.html:
http/tests/security/contentSecurityPolicy/resources/echo-report.php:
http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html: Removed.
http/tests/security/contentSecurityPolicy/resources/generate-csp-report.php: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html.
http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.php: Added.
http/tests/security/contentSecurityPolicy/resources/reflected-xss-and-xss-protection.js:

(testMixedHeader):

http/tests/security/contentSecurityPolicy/resources/report-file-path.php: Added.
http/tests/security/contentSecurityPolicy/resources/save-report.php:
http/tests/security/contentSecurityPolicy/xmlhttprequest-protected-resource-does-not-crash.html:
http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
http/tests/security/xssAuditor/block-does-not-leak-location.html:
http/tests/security/xssAuditor/block-does-not-leak-referrer.html:
http/tests/security/xssAuditor/cookie-injection-expected.txt:
http/tests/security/xssAuditor/cookie-injection.html:
http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
http/tests/security/xssAuditor/embed-tag-code-attribute-2.html:
http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
http/tests/security/xssAuditor/embed-tag-code-attribute.html:
http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
http/tests/security/xssAuditor/embed-tag-control-char.html:
http/tests/security/xssAuditor/embed-tag-expected.txt:
http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
http/tests/security/xssAuditor/embed-tag-javascript-url.html:
http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
http/tests/security/xssAuditor/embed-tag-null-char.html:
http/tests/security/xssAuditor/embed-tag.html:
http/tests/security/xssAuditor/faux-script1.html:
http/tests/security/xssAuditor/faux-script2.html:
http/tests/security/xssAuditor/faux-script3.html:
http/tests/security/xssAuditor/form-action-expected.txt:
http/tests/security/xssAuditor/form-action.html:
http/tests/security/xssAuditor/formaction-on-button-expected.txt:
http/tests/security/xssAuditor/formaction-on-button.html:
http/tests/security/xssAuditor/formaction-on-input-expected.txt:
http/tests/security/xssAuditor/formaction-on-input.html:
http/tests/security/xssAuditor/frameset-injection-expected.txt:
http/tests/security/xssAuditor/frameset-injection.html:
http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
http/tests/security/xssAuditor/full-block-get-from-iframe.html:
http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
http/tests/security/xssAuditor/full-block-iframe-javascript-url.html:
http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
http/tests/security/xssAuditor/full-block-iframe-no-inherit.php:
http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
http/tests/security/xssAuditor/full-block-link-onclick.html:
http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
http/tests/security/xssAuditor/full-block-object-tag.html:
http/tests/security/xssAuditor/full-block-post-from-iframe.html:
http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
http/tests/security/xssAuditor/full-block-script-tag-with-source.html:
http/tests/security/xssAuditor/full-block-script-tag.html:
http/tests/security/xssAuditor/get-from-iframe-expected.txt:
http/tests/security/xssAuditor/get-from-iframe.html:
http/tests/security/xssAuditor/iframe-injection-allowed-2.html:
http/tests/security/xssAuditor/iframe-injection-allowed-3.html:
http/tests/security/xssAuditor/iframe-injection-allowed.html:
http/tests/security/xssAuditor/iframe-injection-expected.txt:
http/tests/security/xssAuditor/iframe-injection.html:
http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-more-encoding.html:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode.html:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2.html:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3.html:
http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
http/tests/security/xssAuditor/iframe-javascript-url-url-encoded.html:
http/tests/security/xssAuditor/iframe-javascript-url.html:
http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
http/tests/security/xssAuditor/iframe-onload-GBK-char.html:
http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
http/tests/security/xssAuditor/iframe-onload-in-svg-tag.html:
http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
http/tests/security/xssAuditor/iframe-srcdoc.html:
http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
http/tests/security/xssAuditor/img-onerror-GBK-char.html:
http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
http/tests/security/xssAuditor/img-onerror-accented-char.html:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char.html:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
http/tests/security/xssAuditor/img-onerror-non-ASCII-char2.html:
http/tests/security/xssAuditor/img-onerror-tricky.html:
http/tests/security/xssAuditor/img-tag-with-comma-expected.txt:
http/tests/security/xssAuditor/img-tag-with-comma.html:
http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
http/tests/security/xssAuditor/inline-event-HTML-entities.html:
http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
http/tests/security/xssAuditor/link-onclick-ampersand.html:
http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
http/tests/security/xssAuditor/link-onclick-control-char.html:
http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
http/tests/security/xssAuditor/link-onclick-entities.html:
http/tests/security/xssAuditor/link-onclick-expected.txt:
http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
http/tests/security/xssAuditor/link-onclick-null-char.html:
http/tests/security/xssAuditor/link-onclick.html:
http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
http/tests/security/xssAuditor/link-opens-new-window.html:
http/tests/security/xssAuditor/malformed-HTML-expected.txt:
http/tests/security/xssAuditor/malformed-HTML.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-1.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-2.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-3.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-4.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-5.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-6.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-7.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-8.html:
http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
http/tests/security/xssAuditor/malformed-xss-protection-header-9.html:
http/tests/security/xssAuditor/no-protection-script-tag.html:
http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-control-char.html:
http/tests/security/xssAuditor/object-embed-tag-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
http/tests/security/xssAuditor/object-embed-tag-null-char.html:
http/tests/security/xssAuditor/object-embed-tag.html:
http/tests/security/xssAuditor/object-tag-expected.txt:
http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
http/tests/security/xssAuditor/object-tag-javascript-url.html:
http/tests/security/xssAuditor/object-tag.html:
http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
http/tests/security/xssAuditor/open-event-handler-iframe.html:
http/tests/security/xssAuditor/open-iframe-src-03-expected.txt:
http/tests/security/xssAuditor/open-iframe-src-03.html:
http/tests/security/xssAuditor/post-from-iframe.html:
http/tests/security/xssAuditor/report-script-tag-expected.txt:
http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
http/tests/security/xssAuditor/report-script-tag-full-block.html:
http/tests/security/xssAuditor/report-script-tag-replace-state-expected.txt:
http/tests/security/xssAuditor/report-script-tag-replace-state.html:
http/tests/security/xssAuditor/report-script-tag.html:
http/tests/security/xssAuditor/resources/echo-intertag.pl:
http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode.html:
http/tests/security/xssAuditor/script-tag-Big5-char.html:
http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
http/tests/security/xssAuditor/script-tag-Big5-char2.html:
http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
http/tests/security/xssAuditor/script-tag-control-char.html:
http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
http/tests/security/xssAuditor/script-tag-convoluted.html:
http/tests/security/xssAuditor/script-tag-entities-expected.txt:
http/tests/security/xssAuditor/script-tag-entities.html:
http/tests/security/xssAuditor/script-tag-expected.txt:
http/tests/security/xssAuditor/script-tag-expression-follows-expected.txt:
http/tests/security/xssAuditor/script-tag-expression-follows.html:
http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
http/tests/security/xssAuditor/script-tag-inside-svg-tag.html:
http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
http/tests/security/xssAuditor/script-tag-inside-svg-tag2.html:
http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
http/tests/security/xssAuditor/script-tag-inside-svg-tag3.html:
http/tests/security/xssAuditor/script-tag-near-start-expected.txt:
http/tests/security/xssAuditor/script-tag-near-start.html:
http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-null-char.html:
http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
http/tests/security/xssAuditor/script-tag-open-redirect.html:
http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
http/tests/security/xssAuditor/script-tag-post-control-char.html:
http/tests/security/xssAuditor/script-tag-post-expected.txt:
http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-post-null-char.html:
http/tests/security/xssAuditor/script-tag-post.html:
http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
http/tests/security/xssAuditor/script-tag-redirect.html:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair.html:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
http/tests/security/xssAuditor/script-tag-with-16bit-unicode5.html:
http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
http/tests/security/xssAuditor/script-tag-with-actual-comma.html:
http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
http/tests/security/xssAuditor/script-tag-with-callbacks.html:
http/tests/security/xssAuditor/script-tag-with-comma-01-expected.txt:
http/tests/security/xssAuditor/script-tag-with-comma-01.html:
http/tests/security/xssAuditor/script-tag-with-comma-02-expected.txt:
http/tests/security/xssAuditor/script-tag-with-comma-02.html:
http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
http/tests/security/xssAuditor/script-tag-with-fancy-unicode.html:
http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag.html:
http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding.html:
http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-control-char.html:
http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-data-url.html:
http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-data-url2.html:
http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-data-url3.html:
http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-double-quote.html:
http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-entities.html:
http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-no-quote.html:
http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-null-char.html:
http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-relative-scheme.html:
http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query.html:
http/tests/security/xssAuditor/script-tag-with-source-same-host.html:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-01-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-01.html:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-02-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-02.html:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-03-expected.txt:
http/tests/security/xssAuditor/script-tag-with-source-unterminated-03.html:
http/tests/security/xssAuditor/script-tag-with-source.html:
http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode.html:
http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html:
http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment.html:
http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html:
http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html:
http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html:
http/tests/security/xssAuditor/script-tag-with-trailing-comment5-expected.txt:
http/tests/security/xssAuditor/script-tag-with-trailing-comment5.html:
http/tests/security/xssAuditor/script-tag.html:
http/tests/security/xssAuditor/svg-animate-expected.txt:
http/tests/security/xssAuditor/svg-animate.html:
http/tests/security/xssAuditor/svg-script-tag-expected.txt:
http/tests/security/xssAuditor/svg-script-tag.html:
http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
http/tests/security/xssAuditor/xss-filter-bypass-big5.html:
http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
http/tests/security/xssAuditor/xss-filter-bypass-sjis.html:
http/tests/security/xssAuditor/xss-protection-parsing-01.html:
http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-02.html:
http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-03.html:
http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
http/tests/security/xssAuditor/xss-protection-parsing-04.html:

2:03 PM Changeset in webkit [176412] by Beth Dakin

8 edits in trunk/Source

Invalid message WebPageProxy.DidPerformDictionaryLookup on Google stocks result
https://bugs.webkit.org/show_bug.cgi?id=138568
-and corresponding-
rdar://problem/18904600

Reviewed by Tim Horton.

Source/WebCore:

Add an optional parameter indicating whether or not to include images.

WebCore.exp.in:
editing/cocoa/HTMLConverter.h:
editing/cocoa/HTMLConverter.mm:

(WebCore::editingAttributedStringFromRange):

Source/WebKit/mac:

Skip images for lookup.

WebView/WebActionMenuController.mm:

(performDictionaryLookupForRange):

Source/WebKit2:

Skip images for lookup.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):

1:50 PM Changeset in webkit [176411] by dbates@webkit.org

6 edits in trunk/Source/WebKit2

[iOS] Add more ENABLE({TOUCH_EVENTS, IOS_TOUCH_EVENTS})-guards in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=138928

Reviewed by Simon Fraser.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

1:45 PM Changeset in webkit [176410] by mmaxfield@apple.com

3 edits in trunk/Source/WebCore

Fix the !ENABLE(SVG_FONTS) build after r176276
https://bugs.webkit.org/show_bug.cgi?id=138924

Reviewed by Csaba Osztrogonác.

No new tests because there is no behavior change.

css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestFont):

1:43 PM Changeset in webkit [176409] by dbates@webkit.org

2 edits
6 adds in trunk/LayoutTests

[iOS] Update expected results for LayoutTests/animations

platform/ios-simulator/TestExpectations:
platform/ios-simulator/animations/3d/replace-filling-transform-expected.txt: Added.
platform/ios-simulator/animations/animation-offscreen-to-onscreen-expected.txt: Added.
platform/ios-simulator/animations/missing-values-first-keyframe-expected.txt: Added.
platform/ios-simulator/animations/missing-values-last-keyframe-expected.txt: Added.
platform/ios-simulator/animations/opacity-transform-animation-expected.txt: Added.
platform/ios-simulator/animations/suspend-transform-animation-expected.txt: Added.

12:01 PM Changeset in webkit [176408] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Add -[WKWebView loadData:MIMEType:textEncodingName:baseURL:]
https://bugs.webkit.org/show_bug.cgi?id=138929
<rdar://problem/18683802>

Reviewed by Dan Bernstein.

Also, re-implement -[WKWebView loadHTMLString:baseURL:] in terms of this newly added function
and assume a UTF-8 encoding. This matches what Legacy WebKit does.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView loadHTMLString:baseURL:]):
(-[WKWebView loadData:MIMEType:textEncodingName:baseURL:]):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadData):

UIProcess/WebPageProxy.h:

11:56 AM Changeset in webkit [176407] by bshafiei@apple.com

3 edits
3 copies in tags/Safari-601.1.10

Merged r176402. rdar://problem/19040156

11:12 AM Changeset in webkit [176406] by eric.carlson@apple.com

3 edits in trunk/LayoutTests

Update media/track/track-in-band-cues-added-once.html to make failures easier to diagnose
https://bugs.webkit.org/show_bug.cgi?id=138908

Reviewed by Alexey Proskuryakov.

media/track/track-in-band-cues-added-once.html: Update test to remove one potential

source of flakeyness and to do more logging in the event of a failure to make debugging
failures simpler.

media/track/track-in-band-cues-added-once-expected.txt:

11:06 AM Changeset in webkit [176405] by dbates@webkit.org

2 edits in trunk/LayoutTests

[iOS] Temporarily skip almost all DRT tests

Towards updating the expected results on iOS, temporarily skip running almost
all DRT tests on iOS. We'll subsequently un-skip tests as we land updated/new
expected results for them.

platform/ios-simulator/TestExpectations:

10:50 AM Changeset in webkit [176404] by Yusuke Suzuki

5 edits
3 moves in trunk

Rename String.prototype.contains to String.prototype.includes
https://bugs.webkit.org/show_bug.cgi?id=138923

Source/JavaScriptCore:

As per the latest TC39 meeting[1, 2], String.prototype.contains is
renamed to String.prototype.includes. This is because the name
contains breaks the web since it conflicts with existing contains
implementations in major libraries.

[1]: https://github.com/mathiasbynens/String.prototype.includes
[2]: https://github.com/tc39/test262/pull/119

Reviewed by Geoffrey Garen.

runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::stringProtoFuncIncludes):
(JSC::stringProtoFuncContains): Deleted.

LayoutTests:

Reviewed by Geoffrey Garen.

js/Object-getOwnPropertyNames-expected.txt:
js/script-tests/Object-getOwnPropertyNames.js:
js/script-tests/string-includes.js: Renamed from LayoutTests/js/script-tests/string-contains.js.

(stringToSearchIn.toString):
(startOffset.valueOf):
(matchString.toString):
(endOffset.valueOf):

js/string-includes-expected.txt: Renamed from LayoutTests/js/string-contains-expected.txt.
js/string-includes.html: Renamed from LayoutTests/js/string-contains.html.

10:50 AM Changeset in webkit [176403] by adachan@apple.com

4 edits in trunk/Source/WebCore

Add a way to mute an AudioContext.
https://bugs.webkit.org/show_bug.cgi?id=138104

Reviewed by Eric Carlson.

Keep a muted state in AudioDestinationNode. If m_muted is true,
zero out the audio buffers.

No new tests, since it's difficult to test whether the audio is indeed muted.

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
Call pageMutedStateDidChange() so it'll initialize the destination audio node's muted state accordingly.
(WebCore::AudioContext::pageMutedStateDidChange):
Set the destination audio node's muted state to match the page's muted state.

Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):
Initialize m_muted.
(WebCore::AudioDestinationNode::render):
If m_muted is true, call AudioBus::zero() to zero out the buffers.

Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::setMuted):
Set m_muted.

10:44 AM Changeset in webkit [176402] by Chris Dumez

3 edits
3 adds in trunk

Crash when destroying a Document that has a throttled timer still running
https://bugs.webkit.org/show_bug.cgi?id=138914

Reviewed by Benjamin Poulain.

Source/WebCore:

Upon destruction, a throttled DOMTimer whose interval depends on
viewport changes will try to unregister itself from the view. It gets
the view pointer from its Document. However, scriptExecutionContext()
can return null if the Document is being destroyed (i.e. ~DOMTimer()
is called from ~ScriptExecutionContext(), as the ScriptExecutionContext
owns the DOMTimer).

This patch adds a null check for scriptExecutionContext() in the
DOMTimer destructor to avoid this issue.

Test: fast/dom/throttled-timer-running-on-document-destruction.html

page/DOMTimer.cpp:

(WebCore::DOMTimer::~DOMTimer):

(WebCore::DOMTimer::unregisterForViewportChanges):
Add assertion to make sure scriptExecutionContext() does not return
null.

(WebCore::DOMTimerFireState::setChangedStyleOfElementOutsideViewport): Deleted.
Killed this function as this was dead code.

LayoutTests:

Add a layout test to test the case where a Document gets destroyed while
throttled timer is still running.

fast/dom/resources/frame-with-throttled-timer.html: Added.
fast/dom/throttled-timer-running-on-document-destruction-expected.txt: Added.
fast/dom/throttled-timer-running-on-document-destruction.html: Added.

10:11 AM Changeset in webkit [176401] by Alan Bujtas

9 edits
2 adds in trunk

Simple line layout: Introduce text fragment continuation.
https://bugs.webkit.org/show_bug.cgi?id=138274

Source/WebCore:

This patch extends simple line layout coverage to multiple text renderers.
When a particular render flow has multiple text renderers (but not any other type)
then we use simple line layout to process and paint the content. -other, existing requirements still apply
so that for example if the content requires decoration, we bail out of simple line layout.

FlowContent now supports multiple renderes. It continuously reads content from sibling renderers
so that the simple line layout parser sees it as one monolithic block of content. Run positions
are all relative to the block and they get resolved to renderer's positions on demand.
(painting, computing bounding rects etc)

Reviewed by Antti Koivisto.

Performance test already been added for the multiple rendere use case,
correctness is covered by existing test cases.
Test: fast/text/simple-lines-mutliple-renderers.html

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor): Check if children are all 8bit RenderTexts.
(WebCore::SimpleLineLayout::removeTrailingWhitespace): Move the endofline check right before where we might overflow using end position.
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::splitRunsAtRendererBoundary): Split runs at renderers' boundary to be in sync with inline text renderering.
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::create):

rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::textWidth): Do not measure text across renderers. It could produce different width value due to
ligature which later can produce unexpected line breaks and out sync rendering in general.
(WebCore::SimpleLineLayout::FlowContents::renderer):
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Read the next renderer content if needed.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::runWidth):

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent):

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

LayoutTests:

Rebaseline for simple line layout's multiple rendere support.

Reviewed by Antti Koivisto.

fast/text/simple-lines-multiple-renderers-expected.html: Added.
fast/text/simple-lines-multiple-renderers.html: Added.
fast/tokenizer/script_extra_close-expected.txt: Multiple tab characters should collapse into a single whitespace. This

needs fixing in complex line layout.

tables/mozilla/bugs/bug157890-expected.txt: no-op endofline run is added by complex inline layout

when multiple text content is injected through JS into a <pre>. This requires fixing complex line layout.

9:43 AM Changeset in webkit [176400] by Antti Koivisto

3 edits in trunk/Source/WebKit2

Remove alignment code from cache coders
https://bugs.webkit.org/show_bug.cgi?id=138927

Failed to land this file.

NetworkProcess/cache/NetworkCacheCoders.cpp:

(WebKit::NetworkCacheCoder<CString>::encode):
(WebKit::NetworkCacheCoder<CString>::decode):
(WebKit::NetworkCacheCoder<String>::encode):
(WebKit::decodeStringText):
(WebKit::NetworkCacheCoder<WebCore::CertificateInfo>::encode):
(WebKit::NetworkCacheCoder<WebCore::CertificateInfo>::decode):

NetworkProcess/cache/NetworkCacheCoders.h:

9:42 AM Changeset in webkit [176399] by mark.lam@apple.com

4 edits
3 adds in trunk

WTFCrashWithSecurityImplication under SpeculativeJIT::compile() when loading a page from theblaze.com.
<https://webkit.org/b/137642>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

In the DFG, we have a ConstantFolding phase that occurs after all LocalCSE
phases have already transpired. Hence, Identity nodes introduced in the
ConstantFolding phase will be left in the node graph. Subsequently, the
DFG code generator asserts that CSE phases have consumed all Identity nodes.
This turns out to not be true. Hence, the crash. We fix this by teaching
the DFG code generator to emit code for Identity nodes.

Unlike the DFG, the FTL does not have this issue. That is because the FTL
plan has GlobalCSE phases that come after ConstantFolding and any other
phases that can generate Identity nodes. Hence, for the FTL, it is true that
CSE will consume all Identity nodes, and the code generator should not see any
Identity nodes.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

LayoutTests:

js/dfg-inline-identity-expected.txt: Added.
js/dfg-inline-identity.html: Added.
js/script-tests/dfg-inline-identity.js: Added.

(o.toKey):
(foo):
(test):

9:32 AM Changeset in webkit [176398] by Antti Koivisto

5 edits in trunk/Source/WebKit2

Remove alignment code from cache coders
https://bugs.webkit.org/show_bug.cgi?id=138927

Reviewed by Anders Carlsson.

Alignment code doesn't do anything useful, wastes space and produces wrong results
if the encoder and decoder buffers don't have the same 8-byte alignment.

NetworkProcess/cache/NetworkCacheDecoder.cpp:

(WebKit::NetworkCacheDecoder::NetworkCacheDecoder):
(WebKit::NetworkCacheDecoder::bufferIsLargeEnoughToContain):
(WebKit::NetworkCacheDecoder::decodeFixedLengthData):
(WebKit::NetworkCacheDecoder::decodeNumber):
(WebKit::roundUpToAlignment): Deleted.
(WebKit::alignedBufferIsLargeEnoughToContain): Deleted.
(WebKit::NetworkCacheDecoder::alignBufferPosition): Deleted.

NetworkProcess/cache/NetworkCacheDecoder.h:

(WebKit::NetworkCacheDecoder::currentOffset):
(WebKit::NetworkCacheDecoder::isInvalid):
(WebKit::NetworkCacheDecoder::markInvalid):
(WebKit::NetworkCacheDecoder::bufferIsLargeEnoughToContain):

NetworkProcess/cache/NetworkCacheEncoder.cpp:

(WebKit::NetworkCacheEncoder::grow):
(WebKit::NetworkCacheEncoder::encodeFixedLengthData):
(WebKit::NetworkCacheEncoder::encodeNumber):
(WebKit::roundUpToAlignment): Deleted.

NetworkProcess/cache/NetworkCacheEncoder.h:

8:33 AM Changeset in webkit [176397] by commit-queue@webkit.org

8 edits
2 deletes in trunk

Unreviewed, rolling out r176396.
https://bugs.webkit.org/show_bug.cgi?id=138926

revealed some WebCore::BidiResolver issue. rollout this for
now. (Requested by zalan on #webkit).

Reverted changeset:

"Simple line layout: Introduce text fragment continuation."
https://bugs.webkit.org/show_bug.cgi?id=138274
http://trac.webkit.org/changeset/176396

7:22 AM Changeset in webkit [176396] by Alan Bujtas

8 edits
2 adds in trunk

Simple line layout: Introduce text fragment continuation.
https://bugs.webkit.org/show_bug.cgi?id=138274

Source/WebCore:

Reviewed by Antti Koivisto.

Performance test already been added for the multiple rendere use case,
correctness is covered by existing test cases.
Test: fast/text/simple-lines-mutliple-renderers.html

rendering/SimpleLineLayout.cpp:

rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::FlowContents):
(WebCore::SimpleLineLayout::FlowContents::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContents::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::textWidth): Do not measure text across renderers. It could produce different width value due to
ligature which later can produce unexpected line breaks and out sync renderering in general.
(WebCore::SimpleLineLayout::FlowContents::renderer):
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions):
(WebCore::SimpleLineLayout::FlowContents::appendNextRendererContentIfNeeded): Read the next renderer content if needed.
(WebCore::SimpleLineLayout::FlowContents::nextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContents::runWidth):

rendering/SimpleLineLayoutFlowContents.h:

(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent):

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

LayoutTests:

Rebaseline for simple line layout's multiple rendere support.

Reviewed by Antti Koivisto.

fast/text/simple-lines-multiple-renderers-expected.html: Added.
fast/text/simple-lines-multiple-renderers.html: Added.
fast/tokenizer/script_extra_close-expected.txt: Multiple tab characters should collapse into a single whitespace. This

needs fixing in complex line layout.

tables/mozilla/bugs/bug157890-expected.txt: no-op endofline run is added by complex inline layout

when multiple text content is injected through JS into a <pre>. This requires fixing complex line layout.

7:20 AM Changeset in webkit [176395] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile error when GStreamer is enabled.
https://bugs.webkit.org/show_bug.cgi?id=138925

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-20
Reviewed by Philippe Normand.

A guard is missing for an overridden method.

platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

5:12 AM Changeset in webkit [176394] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r176198 - [GTK] Add library search paths from LDFLAGS before pkg-config --libs
https://bugs.webkit.org/show_bug.cgi?id=136018

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-17
Reviewed by Carlos Garcia Campos.

It is possible that the order of -L arguments in the output of
pkg-config is wrong, which causes the linker to find the wrong
version (usually older version) of libraries when running
gtkdoc-scangobj.

gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

4:46 AM Changeset in webkit [176393] by commit-queue@webkit.org

8 edits in trunk

[GTK] Provide convenience API in DOM bindings to post messages to user message handlers
https://bugs.webkit.org/show_bug.cgi?id=138871

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-11-20
Reviewed by Carlos Garcia Campos.

Source/WebCore:

Adds a convenience function in the WebKitGTK+ DOM bindings to post
messages to user message handlers in a way convenient way more
convenient than using the autogenerated bindings.

bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_dom_window_webkit_message_handlers_post_message):
Added new convenience API function to post messages to user message
handlers.

bindings/gobject/WebKitDOMCustom.h: Ditto.
bindings/gobject/WebKitDOMCustom.symbols: Ditto.

Tools:

Add a test case for the convenience API for posting user messages
added to the DOM bindings.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:

(testUserContentManagerMessageFromConvenienceDOMBindings):
(beforeAll):

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(documentLoadedCallback):

3:01 AM Changeset in webkit [176392] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r175451 - REGRESSION(r163656): Remote inspector doesn't work unless preferences change after page initialization
https://bugs.webkit.org/show_bug.cgi?id=138246

Reviewed by Joseph Pecoraro.

The problem is that initializeWebPage() is still using
pageGroup().preferences() instead of m_preferences to check if
developer extras are enabled to enable remote inspection of the page.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage): Use m_preferences
instead of pageGroup().preferences().

2:41 AM Changeset in webkit [176391] by Carlos Garcia Campos

7 edits in releases/WebKitGTK/webkit-2.6

Merge r175450 - REGRESSION(CMake): Make it possible to build without introspection
https://bugs.webkit.org/show_bug.cgi?id=138006

Reviewed by Philippe Normand.

Add ENABLE_INTROSPECTION option.

Source/PlatformGTK.cmake: Dot not add gir global target if

introspection is disabled.

Source/cmake/OptionsGTK.cmake: Do not add gir individual targets if

introspection is disabled.

Source/JavaScriptCore:

Do not install introspection files when introspection is disabled.

PlatformGTK.cmake:

Source/WebKit2:

Do not install introspection files when introspection is disabled.

PlatformGTK.cmake:

1:49 AM Changeset in webkit [176390] by svillar@igalia.com

9 edits in trunk/Source/WebCore

[CSS Grid Layout] Replace the usage of size_t by unsigned
https://bugs.webkit.org/show_bug.cgi?id=136218

Reviewed by Benjamin Poulain.

In general, size_t should be used for sizes of objects in
memory. We're using it to represent indexes and spans in the
grid. Now that the maximum number of tracks is 1 million, it
should be safe to replace them by unsigned integers.

No new tests as there is no change in functionality.

css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackRepeatFunction):

css/StyleResolver.cpp:

(WebCore::createImplicitNamedGridLinesFromGridArea):
(WebCore::createGridTrackList):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::GridIterator::nextGridItem):
(WebCore::RenderGrid::GridIterator::isEmptyAreaEnough):
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
(WebCore::RenderGrid::GridSizingData::GridSizingData):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::gridTrackSize):
(WebCore::RenderGrid::distributeSpaceToTracks):
(WebCore::RenderGrid::tracksAreWiderThanMinTrackBreadth):
(WebCore::RenderGrid::ensureGridSize):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::populateGridPositions):

rendering/RenderGrid.h:
rendering/style/GridCoordinate.h:

(WebCore::GridSpan::integerSpan):

rendering/style/GridResolvedPosition.cpp:

(WebCore::GridResolvedPosition::explicitGridColumnCount):
(WebCore::GridResolvedPosition::explicitGridRowCount):
(WebCore::explicitGridSizeForSide):
(WebCore::GridResolvedPosition::resolveNamedGridLinePositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionFromStyle):
(WebCore::GridResolvedPosition::resolveGridPositionAgainstOppositePosition):
(WebCore::firstNamedGridLineBeforePosition):
(WebCore::GridResolvedPosition::resolveRowStartColumnStartNamedGridLinePositionAgainstOppositePosition):
(WebCore::GridResolvedPosition::resolveRowEndColumnEndNamedGridLinePositionAgainstOppositePosition):

rendering/style/GridResolvedPosition.h:

(WebCore::GridResolvedPosition::adjustGridPositionForRowEndColumnEndSide):
(WebCore::GridResolvedPosition::adjustGridPositionForSide):
(WebCore::GridResolvedPosition::GridResolvedPosition):
(WebCore::GridResolvedPosition::toInt):

rendering/style/StyleGridData.h:

1:04 AM Changeset in webkit [176389] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176254 - AX: [ATK] Crash getting the orientation of a MenuListOption after the MenuList was removed from the document
https://bugs.webkit.org/show_bug.cgi?id=138727

Reviewed by Chris Fleizach.

Source/WebCore:

AccessibilityMenuListOption::elementRect() returns the value of the
grandparent MenuList, asserting that the grandparent exists with that
role. But it is possible to have an existing MenuListOption and remove
the element which had been backing that MenuList from the document.
Adding null checks prior to the assertions prevents our crashing if the
parent or grandparent was removed.

Test: platform/gtk/accessibility/combobox-descendants-orientation-crash.html

accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::elementRect):

LayoutTests:

platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt: Added.
platform/gtk/accessibility/combobox-descendants-orientation-crash.html: Added.

12:43 AM Changeset in webkit [176388] by akling@apple.com

6 edits in trunk/Source/WebCore

Remove "document has no sibling rules" optimization.
<https://webkit.org/b/138902>

Reviewed by Antti Koivisto.

We were keeping a document-level flag to track whether there are any
sibling rules in any active style sheets.

This information was used to do.. nothing.

css/StyleResolver.h:

(WebCore::StyleResolver::usesSiblingRules): Deleted.

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):

dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::usesSiblingRules): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride): Deleted.

mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::insertedInto): Deleted.

mathml/MathMLMathElement.h:

12:36 AM Changeset in webkit [176387] by akling@apple.com

7 edits in trunk/Source/WebCore

Caret renderer is always a RenderBlock.
<https://webkit.org/b/138912>

Reviewed by Chris Dumez.

Tighten typing in the code that finds and deals with the renderer
used to paint the caret (it's always a RenderBlock.)

editing/FrameSelection.cpp:

(WebCore::CaretBase::updateCaretRect):
(WebCore::FrameSelection::caretRendererWithoutUpdatingLayout):
(WebCore::DragCaretController::caretRenderer):
(WebCore::repaintCaretForLocalRect):
(WebCore::CaretBase::paintCaret):

editing/FrameSelection.h:
editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::absoluteCaretBounds):

editing/htmlediting.cpp:

(WebCore::rendererForCaretPainting):
(WebCore::localCaretRectInRendererForCaretPainting):
(WebCore::absoluteBoundsForLocalCaretRect):

editing/htmlediting.h:
rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret):

12:33 AM Changeset in webkit [176386] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r176316 - [GTK] Error in documentation of webkit_print_operation_get_page_setup()
https://bugs.webkit.org/show_bug.cgi?id=138868

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-19
Reviewed by Carlos Garcia Campos.

Fix copypaste error in documentation of
webkit_print_operation_get_page_setup().

UIProcess/API/gtk/WebKitPrintOperation.cpp:

12:29 AM Changeset in webkit [176385] by Csaba Osztrogonác

3 edits in trunk/Source/WebKit2

[GTK] URTBF after r176363.

UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::setTextIndicator):

UIProcess/API/gtk/PageClientImpl.h:

12:23 AM Changeset in webkit [176384] by Antti Koivisto

2 edits in trunk/Source/WebCore

REGRESSION (r172854): Web Viewer in FileMaker does not render a Base64 encoded animated-GIF
https://bugs.webkit.org/show_bug.cgi?id=138807
<rdar://problem/18829540>

Reviewed by Simon Fraser.

Animation gets paused because WebKit thinks the GIF is outside of the view.

page/FrameView.cpp:

(WebCore::FrameView::windowClipRect):

We need to convert to window coordinates in paintsEntireContents mode too so these functions are consistent.
This matters with some WK1 API clients.

Nov 19, 2014:

11:42 PM Changeset in webkit [176383] by Chris Dumez

4 edits in trunk/Source/WebCore

Move 'clip' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138909

Reviewed by Andreas Kling.

Move 'clip' CSS property from DeprecatedStyleBuilder to the new
StyleBuilder by using custom code.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyClip::convertToLength): Deleted.
(WebCore::ApplyPropertyClip::applyInheritValue): Deleted.
(WebCore::ApplyPropertyClip::applyInitialValue): Deleted.
(WebCore::ApplyPropertyClip::applyValue): Deleted.
(WebCore::ApplyPropertyClip::createHandler): Deleted.

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyInitialClip):
(WebCore::StyleBuilderFunctions::applyInheritClip):
(WebCore::StyleBuilderFunctions::applyValueClip):

9:45 PM Changeset in webkit [176382] by commit-queue@webkit.org

4 edits in trunk/Source/WebKit2

Don't track sub-resources that are started after main frame progress has completed.
https://bugs.webkit.org/show_bug.cgi?id=138582

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-11-19
Reviewed by Sam Weinig.

After main frame progress has finished, starting loading a sub-resource shouldn't affect
UI process's view of page loading status (i.e., the page has already completed loading
and the progress shouldn't change). To achive that, don't track the subresources that
are started after the main frame has finished, except for those triggered by user interaction.

WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Notify WebPage that the main frame progress

has started or finished.

(WebKit::WebProgressTrackerClient::progressStarted):
(WebKit::WebProgressTrackerClient::progressFinished):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::addResourceRequest): Don't track the resource request if it is initiated after

the main frame is loaded and it is not triggered by user interaction.

(WebKit::WebPage::removeResourceRequest):

WebProcess/WebPage/WebPage.h: Rename m_networkResourceRequestIdentifiers to m_trackedNetworkResourceRequestIdentifiers.

(WebKit::WebPage::setMainFrameProgressCompleted):

9:35 PM Changeset in webkit [176381] by ryuan.choi@navercorp.com

3 edits in trunk/Source/WebCore

Remove dead code from TiledBackingStore
https://bugs.webkit.org/show_bug.cgi?id=138864

Reviewed by Andreas Kling.

Since r168151, paint() method, m_commitTileUpdatesOnIdleEventLoop and related code are not used.

No new tests, no behavior change.

platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::TiledBackingStore):
(WebCore::TiledBackingStore::setTileSize):
(WebCore::TiledBackingStore::invalidate):
(WebCore::TiledBackingStore::createTiles):
(WebCore::TiledBackingStore::paint): Deleted.
(WebCore::TiledBackingStore::startTileBufferUpdateTimer): Deleted.
(WebCore::TiledBackingStore::tileBufferUpdateTimerFired): Deleted.
(WebCore::TiledBackingStore::startBackingStoreUpdateTimer): Deleted.
(WebCore::TiledBackingStore::backingStoreUpdateTimerFired): Deleted.

platform/graphics/TiledBackingStore.h:

(WebCore::TiledBackingStore::setCommitTileUpdatesOnIdleEventLoop): Deleted.

8:40 PM Changeset in webkit [176380] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176374. rdar://problem/18840128

8:37 PM Changeset in webkit [176379] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176374. rdar://problem/18840128

8:28 PM Changeset in webkit [176378] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Fix typos in r176203.

public/v2/app.js:

(App.ChartsController.actions.addPaneByMetricAndPlatform):
(App.AnalysisTaskRoute):

8:27 PM Changeset in webkit [176377] by dburkart@apple.com

24 edits
1 copy in branches/safari-600.3-branch/Source

Merge r176363. rdar://problem/18840128

6:19 PM Changeset in webkit [176376] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: LayoutTests/inspector should not have localStorage side effects
https://bugs.webkit.org/show_bug.cgi?id=138895

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Brian Burg.

When running inspector tests, do not restore/save WebInspector.Settings
to localStorage, as that will cause side effects. Instead each Setting
will be initialized with its default value and can be modified during
the run of the test.

UserInterface/Base/Test.js:

(WebInspector.loaded):
Name the setting to match the normal setting name now that persistence
is not an issue.

UserInterface/Models/Setting.js:

(WebInspector.Setting.prototype.get value):
(WebInspector.Setting.prototype.set value):
Do not restore/save when in tests.

6:03 PM Changeset in webkit [176375] by gyuyoung.kim@samsung.com

3 edits in trunk/Source/WebKit2

[EFL] Fix build failure since r176363.
https://bugs.webkit.org/show_bug.cgi?id=138903

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2014-11-19
Reviewed by Gyuyoung Kim.

The parameter for animation on setTextIndicator() was removed on 'PageClient' class.

UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::setTextIndicator):

UIProcess/CoordinatedGraphics/WebView.h:

5:55 PM Changeset in webkit [176374] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Try to fix the iOS build

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):

5:36 PM Changeset in webkit [176373] by akling@apple.com

9 edits in trunk/Source/WebCore

Remove "document has no ::before and/or ::after rules" optimization.
<https://webkit.org/b/138897>

Reviewed by Antti Koivisto.

This optimization has been dead for a long time, since the default UA
style contains both ::before and ::after rules.

css/RuleFeature.cpp:

(WebCore::recursivelyCollectFeaturesFromSelector):
(WebCore::RuleFeatureSet::add):
(WebCore::RuleFeatureSet::clear):

css/RuleFeature.h:

(WebCore::RuleFeatureSet::RuleFeatureSet):

css/StyleResolver.h:

(WebCore::StyleResolver::usesBeforeAfterRules): Deleted.

dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):

dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules): Deleted.
(WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride): Deleted.

html/HTMLQuoteElement.cpp:

(WebCore::HTMLQuoteElement::insertedInto): Deleted.

html/HTMLQuoteElement.h:
style/StyleResolveTree.cpp:

(WebCore::Style::needsPseudoElement):

5:35 PM Changeset in webkit [176372] by mmaxfield@apple.com

4 edits
3 adds in trunk

[OS X] Upright vertical text is completely broken for multi-code-unit codepoints
https://bugs.webkit.org/show_bug.cgi?id=138891

Reviewed by Dan Bernstein.

Source/WebCore:

We were assuming that we can use the string index (in UTF-16) as the glyph
index. This falls down when a single codepoint (and glyph) contians
multiple code units.

Test: platform/mac/fast/text/multiple-codeunit-vertical-upright.html

platform/graphics/GlyphPage.h:
platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

LayoutTests:

Make sure a single upright vertical multi-code-unit codepoint is rendered the same as
the same codepoint rendered horizontally.

platform/mac/fast/text/multiple-codeunit-vertical-upright-expected.html: Added.
platform/mac/fast/text/multiple-codeunit-vertical-upright.html: Added.
platform/mac/fast/text/resources/multiple-codeunit-vertical-upright.otf: Added.

5:23 PM Changeset in webkit [176371] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix the Apple Internal Mavericks build after <https://trac.webkit.org/changeset/176347>
(https://bugs.webkit.org/show_bug.cgi?id=136863)

Define enumerator NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain when building without
the Apple Internal SDK or with the Apple Internal SDK on OS X Mavericks or earlier.

platform/spi/cf/CFNetworkSPI.h:

5:16 PM Changeset in webkit [176370] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Fix the 32-bit build

UIProcess/mac/TextIndicatorWindow.mm:

(WebKit::TextIndicatorWindow::setTextIndicator):

5:02 PM Changeset in webkit [176369] by weinig@apple.com

7 edits
1 copy
1 add in trunk

Move the 'quotes' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138788

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/css/content/content-quotes-07.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Fix the parser to only accept none as a valid primitive identifier. Tested in
the newly added content-quotes-07.html.

css/CSSPropertyNames.in:
css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertQuotes):

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Move "quotes" to the new style builder.

rendering/style/RenderStyle.h:

Add an initialQuotes() function for use in the auto-generated style builder.

LayoutTests:

Add a test for the behavior of non-valid primitive identifiers being
used with the quotes property.

fast/css/content/content-quotes-07-expected.txt: Added.
fast/css/content/content-quotes-07.html: Added.

4:59 PM Changeset in webkit [176368] by dino@apple.com

4 edits
4 adds in trunk

Handle unprefixed @keyframes rule
https://bugs.webkit.org/show_bug.cgi?id=138899
<rdar://problem/18943117>

Reviewed by Simon Fraser.

Source/WebCore:

Support the parsing of unprefixed @keyframes. In
CSSParser, assign the same token identifier to
the prefixed and unprefixed forms. This will
keep compatibility with older content. If a page
has both forms, then whatever comes last will
win (as it does if you had duplicate names of the same
form).

Tests: animations/unprefixed-keyframes-rule.html

animations/unprefixed-keyframes.html

css/CSSGrammar.y.in: Rename the WEBKIT_KEYFRAME_RULE_SYM symbol to

be KEYFRAME_RULE_SYM. Same with KEYFRAMES_SYM.

css/CSSParser.cpp:

(WebCore::CSSParser::detectAtToken): Look for the @keyframes style
strings and assign the new token values.

LayoutTests:

Tests for @keyframes, both the OM side and the parsing.

animations/unprefixed-keyframes-expected.txt: Added.
animations/unprefixed-keyframes-rule-expected.txt: Added.
animations/unprefixed-keyframes-rule.html: Added.
animations/unprefixed-keyframes.html: Added.

4:34 PM Changeset in webkit [176367] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source

Merge r176356. rdar://problem/18996776

4:28 PM Changeset in webkit [176366] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source

Merge r176351. rdar://problem/18971616

4:17 PM Changeset in webkit [176365] by akling@apple.com

9 edits in trunk/Source/WebCore

Move pseudo-style code from RenderObject to RenderElement.
<https://webkit.org/b/138880>

Reviewed by Antti Koivisto.

Migrate get*PseudoStyle() to RenderElement, and the selection color
functions along with them. This gets rid of a DOM ancestor walk in
pseudo style lookup.

Narrow down some argument types to keep things building.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::styleForFirstLetter):
(WebCore::RenderBlock::updateFirstLetterStyle):
(WebCore::RenderBlock::createFirstLetterRenderer):

rendering/RenderBlock.h:
rendering/RenderElement.cpp:

(WebCore::RenderElement::getCachedPseudoStyle):
(WebCore::RenderElement::getUncachedPseudoStyle):
(WebCore::RenderElement::selectionColor):
(WebCore::RenderElement::selectionPseudoStyle):
(WebCore::RenderElement::selectionForegroundColor):
(WebCore::RenderElement::selectionEmphasisMarkColor):
(WebCore::RenderElement::selectionBackgroundColor):

rendering/RenderElement.h:
rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionBackgroundColor): Deleted.
(WebCore::RenderObject::selectionColor): Deleted.
(WebCore::RenderObject::selectionPseudoStyle): Deleted.
(WebCore::RenderObject::selectionForegroundColor): Deleted.
(WebCore::RenderObject::selectionEmphasisMarkColor): Deleted.
(WebCore::RenderObject::getCachedPseudoStyle): Deleted.
(WebCore::RenderObject::getUncachedPseudoStyle): Deleted.

rendering/RenderObject.h:
rendering/RenderText.h:

(WebCore::RenderText::getCachedPseudoStyle):
(WebCore::RenderText::selectionBackgroundColor):
(WebCore::RenderText::selectionForegroundColor):
(WebCore::RenderText::selectionEmphasisMarkColor):

rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::paint):

4:14 PM Changeset in webkit [176364] by bshafiei@apple.com

9 edits in tags/Safari-601.1.10/Source/WebKit2

Merged r176337. rdar://problem/18964359

4:10 PM Changeset in webkit [176363] by timothy_horton@apple.com

23 edits in trunk/Source

Add an optional entry transition (from selection highlight) to TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=138856
<rdar://problem/18840128>

Reviewed by Anders Carlsson.

Shared/TextIndicator.cpp:

(WebKit::outsetIndicatorRectIncludingShadow):
(WebKit::TextIndicator::createWithRange):
(WebKit::snapshotSelectionWithHighlight):
(WebKit::TextIndicator::createWithSelectionInFrame):
(WebKit::TextIndicator::frameRect):
(WebKit::TextIndicator::Data::encode):
(WebKit::TextIndicator::Data::decode):
Remove TextIndicator::draw and related functions; drawing is handled entirely
by the TextIndicatorWindow now, and TextIndicator just stores the required data.

Unify outsetIndicatorRectIncludingShadow.

Add an argument to createWithRange/createWithSelectionInFrame to indicate
if the TextIndicator should transition from the selection highlight to
the yellow bubble.

If we're doing the transition, paint the selection into a second bitmap,
without forcing the text to black and without hiding the blue highlight.

Encode/decode the second bitmap.

Shared/TextIndicator.h:
UIProcess/mac/TextIndicatorWindow.h:
UIProcess/mac/TextIndicatorWindow.mm:

(-[WKTextIndicatorView initWithFrame:textIndicator:margin:transitionFromSelectionColor:]):
(-[WKTextIndicatorView presentWithCompletionHandler:]):
(-[WKTextIndicatorView hideWithCompletionHandler:]):
(-[WKTextIndicatorView isFlipped]):
(WebKit::TextIndicatorWindow::TextIndicatorWindow):
(WebKit::TextIndicatorWindow::setTextIndicator):
(WebKit::TextIndicatorWindow::closeWindow):
(WebKit::TextIndicatorWindow::startFadeOutTimerFired):
Re-implement the bounce animation using CoreAnimation instead of
the WKSI-based WKWindowBounceAnimation*.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupOfCurrentSelection):
(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::WebPage::performActionMenuHitTestAtLocation):

WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

Use the aforementioned transition animation for performDictionaryLookupOfCurrentSelection,
the context menu lookup item, and for Data Detectors.

WebCore.exp.in:

Add an export.

platform/spi/cocoa/QuartzCoreSPI.h:

Add some SPI.

4:02 PM Changeset in webkit [176362] by andersca@apple.com

5 edits
1 add in trunk/Source/WebKit2

Add a version of API::Data::createWithoutCopying that takes an NSData
https://bugs.webkit.org/show_bug.cgi?id=138893

Reviewed by Dan Bernstein.

Shared/APIData.h:
Shared/Cocoa/APIDataCocoa.mm: Added.

(API::Data::createWithoutCopying):

UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
(releaseNSData): Deleted.

WebKit2.xcodeproj/project.pbxproj:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

3:58 PM Changeset in webkit [176361] by dburkart@apple.com

2 edits in trunk/Tools

Work around the fact that different masters may have different names for their codebases.
https://bugs.webkit.org/show_bug.cgi?id=138878

Reviewed by Mark Rowe.

BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(parseRevisionProperty): Changed.
Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
opensource / internal codebase naming convention.

3:55 PM Changeset in webkit [176360] by bshafiei@apple.com

5 edits in branches/safari-600.2-branch/Source

Versioning.

3:53 PM Changeset in webkit [176359] by Chris Dumez

4 edits in trunk/Source/WebCore

Move 'outline-style' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138882

Reviewed by Sam Weinig.

Move 'outline-style' CSS property from DeprecatedStyleBuilder to the
new StyleBuilder by using custom code.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyDefault::setValue): Deleted.
(WebCore::ApplyPropertyDefault::applyValue): Deleted.
(WebCore::ApplyPropertyDefault::createHandler): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::applyValue): Deleted.
(WebCore::ApplyPropertyOutlineStyle::createHandler): Deleted.

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyInheritOutlineStyle):
(WebCore::StyleBuilderFunctions::applyInitialOutlineStyle):
(WebCore::StyleBuilderFunctions::applyValueOutlineStyle):

3:49 PM Changeset in webkit [176358] by Joseph Pecoraro

14 edits
1 move
2 adds in trunk

Web Inspector: JSContext inspection Resource search does not work
https://bugs.webkit.org/show_bug.cgi?id=131252

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::searchInContent):

inspector/protocol/Debugger.json:

Do some cleanup of the description and implementation of content searching.

Source/WebCore:

Test: inspector/debugger/search-scripts.html

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::searchInResources):
A little cleanup.

Source/WebInspectorUI:

UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourceCallback):
(WebInspector.ResourceSidebarPanel.prototype.performSearch.resourcesCallback):
Cleanup by reordering things a bit.

(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
(WebInspector.ResourceSidebarPanel.prototype.performSearch.searchScripts):
(WebInspector.ResourceSidebarPanel.prototype.performSearch):
Search non-resource scripts individually.

(WebInspector.ResourceSidebarPanel.prototype._searchTreeElementForScript):
Lazily create a ScriptTreeElement for the search tree outline as needed.

(WebInspector.ResourceSidebarPanel.prototype._scriptsToSearch):
When searching scripts, just perform a shallow walk of the tree outline to find
Script resources that are not also Resources. Scripts are always guarenteed to
be in a folder when inspecting a web resource. For JSContext inspection, scripts
are promoted to the top level.

UserInterface/Main.html:
UserInterface/Models/SourceCodeSearchMatchObject.js: Renamed from Source/WebInspectorUI/UserInterface/Models/ResourceSearchMatchObject.js.

(WebInspector.SourceCodeSearchMatchObject):

UserInterface/Views/SearchIcons.css:

(.source-code-match-icon .icon):
(.resource-match-icon .icon): Deleted.

UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement):
Rename ResourceSearchMatchObject to SourceCodeSearchMatchObject.

LayoutTests:

inspector/debugger/search-scripts-expected.txt: Added.
inspector/debugger/search-scripts.html: Added.

Tests for Debugger.searchInContent.

3:49 PM Changeset in webkit [176357] by Joseph Pecoraro

19 edits
5 adds in trunk

Web Inspector: Provide $exception in the console for the thrown exception value
https://bugs.webkit.org/show_bug.cgi?id=138726

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::caughtValue):

debugger/DebuggerScope.h:

Access the caught value if this scope is a catch scope.

runtime/JSNameScope.h:

(JSC::JSNameScope::isFunctionNameScope):
(JSC::JSNameScope::isCatchScope):
(JSC::JSNameScope::value):
Provide an accessor for the single value in the JSNameScope (with / catch block).

inspector/InjectedScriptSource.js:

Save the exception value and expose it via $exception. Since the command line api
is recreated on each evaluation, $exception is essentially readonly.

inspector/ScriptDebugServer.h:
inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::dispatchDidPause):
(Inspector::ScriptDebugServer::exceptionOrCaughtValue):
When pausing, get the exception or caught value. The exception will be provided
if we are breaking on an explicit exception. When inside of a catch block, we
can get the caught value by walking up the scope chain.

inspector/agents/InspectorDebuggerAgent.h:
inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::stepOver):
(Inspector::InspectorDebuggerAgent::stepInto):
(Inspector::InspectorDebuggerAgent::stepOut):
Clearing state can be done in didContinue.

(Inspector::InspectorDebuggerAgent::didPause):
Set the exception value explicitly in the injected script when we have it.

(Inspector::InspectorDebuggerAgent::didContinue):
Clear state saved when we had paused, including clearly an exception value if needed.

(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
(Inspector::InspectorDebuggerAgent::clearExceptionValue):
Call into the injected script only when needed.

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):

inspector/InjectedScript.h:
inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::clearExceptionValue):

inspector/InjectedScriptManager.h:

Clear on all injected scripts.

Source/WebCore:

Tests: inspector/debugger/command-line-api-exception-nested-catch.html

inspector/debugger/command-line-api-exception.html

inspector/CommandLineAPIModuleSource.js:

Expose $exception in the more complete command line API.

Source/WebInspectorUI:

UserInterface/Base/Test.js:

(WebInspector.loaded):
In order to use RuntimeManager to execute in the global context or on the
active debugger call frame, we need to expose the quickConsole controller.

UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

Expose $exception to completion when we paused because of an exception.

LayoutTests:

Provide some tests to ensure $exception is the value we expect at different times,
such as on the exception line, when there is no exception, or when stepping through
catch blocks (it should always be the most recent caught exception).

inspector/debugger/command-line-api-exception-expected.txt: Added.
inspector/debugger/command-line-api-exception-nested-catch-expected.txt: Added.
inspector/debugger/command-line-api-exception-nested-catch.html: Added.
inspector/debugger/command-line-api-exception.html: Added.
inspector/debugger/resources/exceptions.js: Added.

(triggerUncaughtTypeException):
(triggerUncaughtReferenceException):
(triggerUncaughtSyntaxException):
(triggerUncaughtDOMException):
(throwString):
(throwNumber):
(throwNull):
(throwObject):
(throwNode):
(catcher):
(nestedCatchBlocks):

3:48 PM Changeset in webkit [176356] by Beth Dakin

4 edits in trunk/Source

Invoking an action menu on a selection should result in the text menu
https://bugs.webkit.org/show_bug.cgi?id=138892
-and corresponding-
rdar://problem/18996776

Reviewed by Tim Horton.

Source/WebKit/mac:

WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItems]):

Source/WebKit2:

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems]):

3:43 PM Changeset in webkit [176355] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Fix iOS build.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

3:40 PM Changeset in webkit [176354] by hyatt@apple.com

5 edits
9 adds in trunk

Images/replaced elements that are as tall as a page should be on their own page
https://bugs.webkit.org/show_bug.cgi?id=138886 - <rdar://problem/18296371>

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/multicol/tall-image-behavior.html (and RL/LR variants)

rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::computeReplacedAndTextLineTopAndBottom):

rendering/InlineFlowBox.h:

Add a new method that computes the line top and line bottom ignoring all margins,
overflow and line-height. This allows us to see if a line that is taller than a page
can be made to fit if we ignored margins and unused descent.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
Call the new helper function, computeReplacedAndTextLineTopAndBottom and push
to a new page if we see that we can fit on a page by ourselves without blank space
included.

LayoutTests:

fast/multicol/tall-image-behavior-lr.html: Added.
fast/multicol/tall-image-behavior-rl.html: Added.
fast/multicol/tall-image-behavior.html: Added.
platform/mac/fast/multicol/tall-image-behavior-expected.png: Added.
platform/mac/fast/multicol/tall-image-behavior-expected.txt: Added.
platform/mac/fast/multicol/tall-image-behavior-lr-expected.png: Added.
platform/mac/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
platform/mac/fast/multicol/tall-image-behavior-rl-expected.png: Added.
platform/mac/fast/multicol/tall-image-behavior-rl-expected.txt: Added.

3:36 PM Changeset in webkit [176353] by bshafiei@apple.com

1 copy in tags/Safari-600.2.3

New tag.

3:03 PM Changeset in webkit [176352] by andersca@apple.com

2 edits
2 moves in trunk/Source/WebKit2

Rename two Cocoa-only .cpp files to .mm.

Rubber-stamped by Sam Weinig.

Shared/APIWebArchive.mm: Renamed from Source/WebKit2/Shared/APIWebArchive.cpp.
Shared/APIWebArchiveResource.mm: Renamed from Source/WebKit2/Shared/APIWebArchiveResource.cpp.
WebKit2.xcodeproj/project.pbxproj:

3:00 PM Changeset in webkit [176351] by Beth Dakin

4 edits in trunk/Source

Data detected results with no menu items should not fall through to regular text
action menus
https://bugs.webkit.org/show_bug.cgi?id=138887
-and corresponding-
rdar://problem/18971616

Reviewed by Tim Horton.

Source/WebKit/mac:

WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItems]):

Source/WebKit2:

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItems]):

2:58 PM Changeset in webkit [176350] by adachan@apple.com

16 edits
2 adds in trunk

Take Web Audio into account for the Page::isPlayingAudio() API.
https://bugs.webkit.org/show_bug.cgi?id=137464

Reviewed by Jer Noble.

Source/WebCore:

Make AudioContext a subclass of AudioProducer. It figures out whether there's
audio playing by checking whether its AudioDestinationNode is playing (and not
silent). It calls Document::updateIsPlayingAudio() whenever its audio playing
state has changed.

Test: webaudio/web-audio-is-playing.html

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::lazyInitialize):
Add itself to the Document's list of AudioProducers if it's not an offline
audio context.
(WebCore::AudioContext::uninitialize):
Remove itself from the Document's list of AudioProducers if it's not an offline
audio context.
(WebCore::AudioContext::stop):
Tell the document to update its audio playing state.
(WebCore::AudioContext::isPlayingAudio):
Return true if the audio context hasn't been stopped and its destination node is
playing audio.
(WebCore::AudioContext::pageMutedStateDidChange):
Add a FIXME for now.
(WebCore::AudioContext::isPlayingAudioDidChange):
Call Document::updateIsPlayingAudio().

Modules/webaudio/AudioContext.h:

Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):
Initialize m_isSilent and m_isEffectivelyPlayingAudio.
(WebCore::AudioDestinationNode::render):
Call setIsSilent() with the appropriate value after rendering.
(WebCore::AudioDestinationNode::isPlayingDidChange):
Call updateIsEffectivelyPlayingAudio().
(WebCore::AudioDestinationNode::setIsSilent):
If m_isSilent has changed, call updateIsEffectivelyPlayingAudio().
(WebCore::AudioDestinationNode::updateIsEffectivelyPlayingAudio):
If m_isEffectivelyPlayingAudio has changed, call AudioContext::isPlayingAudioDidChange().

Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::isPlaying):
(WebCore::AudioDestinationNode::isPlayingAudio):

Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::isPlaying):
Return whether the AudioDestination is playing.

Modules/webaudio/DefaultAudioDestinationNode.h:

platform/audio/AudioIOCallback.h:
platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::start):
Call setIsPlaying() instead.
(WebCore::AudioDestinationIOS::stop):
Ditto.
(WebCore::AudioDestinationIOS::setIsPlaying):
If m_isPlaying has changed, call AudioIOCallback::isPlayingDidChange().

platform/audio/ios/AudioDestinationIOS.h:

platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::start):
Call setIsPlaying() instead.
(WebCore::AudioDestinationMac::stop):
Ditto.
(WebCore::AudioDestinationMac::setIsPlaying):
If m_isPlaying has changed, call AudioIOCallback::isPlayingDidChange().

platform/audio/mac/AudioDestinationMac.h:

testing/Internals.cpp:

(WebCore::Internals::isPagePlayingAudio):

testing/Internals.h:
testing/Internals.idl:

Add internals.isPagePlayingAudio() for testing.

LayoutTests:

This test checks that Page::isPlayingAudio() returns false before an audio context is created
and before the oscillator node makes a sound. It then starts the oscillator node and checks
that Page::isPlayingAudio() later returns true.

webaudio/web-audio-is-playing-expected.txt: Added.
webaudio/web-audio-is-playing.html: Added.

2:51 PM Changeset in webkit [176349] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix the Apple Internal Mountain Lion build after <https://trac.webkit.org/changeset/176347>
(https://bugs.webkit.org/show_bug.cgi?id=136863)

Only import header CFNSURLConnection.h when building for iOS or OS X Yosemite.

platform/spi/cf/CFNetworkSPI.h:

2:40 PM Changeset in webkit [176348] by Antti Koivisto

2 edits in trunk/Source/WebCore

Fix TilesAdded bitmask
https://bugs.webkit.org/show_bug.cgi?id=138883

Reviewed by Simon Fraser.

Simon spotted this.

platform/graphics/ca/GraphicsLayerCA.h:

Use 1LLU << 29 instead of 1LLU < 29
This worked before by pure luck as bit 0 is unused.

2:32 PM Changeset in webkit [176347] by dbates@webkit.org

24 edits
4 adds
1 delete in trunk/Source

[iOS] Make WebKit build with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=136863

Reviewed by David Kilzer.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj: Add private headers CFNetworkSPI.h and

NS{CalendarDate, String, URLDownload}SPI.h.

loader/cocoa/DiskCacheMonitorCocoa.mm: Move forward declaration of

CFNetwork data types and functions from here to file CFNetworkSPI.h and
include header CFNetworkSPI.h.

platform/network/mac/ResourceHandleMac.mm: Substitute CFNetworkSPI.h for

CFURLRequestSPI.h as the content of the latter was incorporated into the former.

platform/spi/cf/CFNetworkSPI.h: Added.
platform/spi/cf/CFURLRequestSPI.h: Removed; incorporated its functionality

into CFNetworkSPI.h

platform/spi/cocoa/NSCalendarDateSPI.h: Added.
platform/spi/cocoa/NSStringSPI.h: Added.
platform/spi/cocoa/NSURLDownloadSPI.h: Added.

Source/WebKit/ios:

Misc/WebGeolocationCoreLocationProvider.mm: Remove unnecessary include of header <CoreLocation/CoreLocationPriv.h>.
Misc/WebNSStringExtrasIOS.m: Substitute header <WebCore/NSStringSPI.h> for <Foundation/NSString_NSURLExtras.h>.
Misc/WebUIKitSupport.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.

Source/WebKit/mac:

History/WebHistory.mm: Include header NSCalendarDateSPI.h.
History/WebHistoryItemPrivate.h: Remove include of private header Foundation/NSCalendarDate.h.
Misc/WebDownload.h: Forward declare NSURLDownload when building without header Foundation/NSURLDownload.h.

We use has_include() instead of WTF_USE_APPLE_INTERNAL_SDK since this header
may be used by Apple internal clients that do not include wtf/Platform.h.

Misc/WebDownload.mm: Include header NSURLDownloadSPI.h instead of including

private Foundation headers directly.

Misc/WebNSURLExtras.mm: Remove unnecessary include of private Foundation header.
WebCoreSupport/WebFrameNetworkingContext.mm: Include header CFNetworkSPI.h

instead of including private CFNetwork headers directly. Also fixed up style and
ordering of header include directives.

WebView/WebView.mm: Include header CFNetworkSPI.h instead of including private

CFNetwork headers directly. Also sort the #import directives.

WebView/WebViewPrivate.h: Define ENABLE_TOUCH_EVENTS if not otherwise defined

and added ENABLE_TOUCH_EVENTS-guard around -_touchEventRegions.

Source/WebKit2:

NetworkProcess/cocoa/NetworkProcessCocoa.mm: Moved CFNetwork forward declarations

from this file to file CFNetworkSPI.h and included header CFNetworkSPI.h.

NetworkProcess/mac/NetworkDiskCacheMonitor.mm: Ditto.
NetworkProcess/mac/NetworkResourceLoaderMac.mm: Ditto.
UIProcess/API/Cocoa/WKProcessPool.mm: Ditto.
UIProcess/mac/WebContextMac.mm: Ditto.
WebProcess/cocoa/WebProcessCocoa.mm: Ditto.

2:24 PM Changeset in webkit [176346] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176299. rdar://problem/19024541

2:20 PM Changeset in webkit [176345] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r176296. rdar://problem/18912505

2:14 PM Changeset in webkit [176344] by dburkart@apple.com

7 edits in branches/safari-600.3-branch/Source

Merge r176288. rdar://problem/18840382

2:12 PM Changeset in webkit [176343] by Chris Fleizach

2 edits in trunk/Tools

AX: Screen braille input doesn't work on forms.
https://bugs.webkit.org/show_bug.cgi?id=138804

Unreviewed build fix.

DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::setValue):

2:10 PM Changeset in webkit [176342] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176238. rdar://problem/18990674

2:07 PM Changeset in webkit [176341] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176237. rdar://problem/18900839

2:07 PM Changeset in webkit [176340] by andersca@apple.com

5 edits in trunk/Source/WebKit2

Add APIs for customizing the user agent
https://bugs.webkit.org/show_bug.cgi?id=138881
rdar://problem/17233981

Reviewed by Dan Bernstein.

UIProcess/API/Cocoa/WKWebView.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView customUserAgent]):
(-[WKWebView setCustomUserAgent:]):
(-[WKWebView _customUserAgent]):
(-[WKWebView _setCustomUserAgent:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.h:
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(LazyInitialized::set):
(-[WKWebViewConfiguration copyWithZone:]):
(defaultApplicationNameForUserAgent):
(-[WKWebViewConfiguration applicationNameForUserAgent]):
(-[WKWebViewConfiguration setApplicationNameForUserAgent:]):

2:05 PM Changeset in webkit [176339] by Simon Fraser

2 edits in trunk/Source/WebKit2

[WK2 UI-side compositing] Initialize RemoteLayerTreeTransaction properties which are unset on Mac
https://bugs.webkit.org/show_bug.cgi?id=138877

Reviewed by Tim Horton.

These data members are unused on Mac, but still encoded, so initialize them with
reasonable values.

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::RemoteLayerTreeTransaction):

2:03 PM Changeset in webkit [176338] by dburkart@apple.com

9 edits in branches/safari-600.3-branch/Source

Merge r176221. rdar://problem/18991369

1:57 PM Changeset in webkit [176337] by enrica@apple.com

9 edits in trunk/Source/WebKit2

Refactor iOS selection gestures.
https://bugs.webkit.org/show_bug.cgi?id=138720
rdar://problem/18964359

Reviewed by Benjamin Poulain.

This is a first step towards refactoring the selection gestures code.
It introduces more general selection movement functions that can be used to build
the gestures.

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(toWKTextGranularity):
(toWKSelectionDirection):
(-[WKContentView selectPositionAtPoint:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView beginSelectionInDirection:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::beginSelectionInDirection):
(WebKit::WebPageProxy::updateSelectionWithExtentPoint):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::visiblePositionInFocusedNodeForPoint):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::beginSelectionInDirection):
(WebKit::WebPage::updateSelectionWithExtentPoint):

1:56 PM Changeset in webkit [176336] by dburkart@apple.com

9 edits in branches/safari-600.3-branch/Source

Merged r176220. rdar://problem/18944893

1:39 PM Changeset in webkit [176335] by Joseph Pecoraro

3 edits in trunk/Source/JavaScriptCore

Unreviewed build fixes after r176329.

export all of the codegen python files as they are included by the main generator
update the imports of the main generator to match init.py
remove bundling the python scripts as framework resources, just have them PrivateHeaders

JavaScriptCore.xcodeproj/project.pbxproj:
inspector/scripts/generate-inspector-protocol-bindings.py:

1:31 PM Changeset in webkit [176334] by Simon Fraser

6 edits in trunk/Source/WebKit2

[WK2 UI-side Compositing] Fix the position and scroll indicator of the UI-side tiled scrolling indicator
https://bugs.webkit.org/show_bug.cgi?id=138876

Reviewed by Beth Dakin.

Fix the position of the tiled scrolling indicator in MiniBrowser by taking top
content offset into account.

On Mac, pass the current scroll position back to the UI process via the RemoteLayerTreeTransaction
so that we can use it to show the correctly scroll offset in the indicator. This is temporary until
Mac does UI-side scrolling.

Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::scrollPosition):
(WebKit::RemoteLayerTreeTransaction::setScrollPosition):

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):

1:15 PM Changeset in webkit [176333] by Chris Dumez

1 edit
4 moves
2 adds in trunk/LayoutTests

Add layout test for throttling of DOM timer changing the style of visible and invisible elements
https://bugs.webkit.org/show_bug.cgi?id=138875

Reviewed by Simon Fraser.

Add a layout test to test that a repeating DOM timer changing the style
of both visible and invisible elements does not get throttled.

Also rename existing tests to use "display-none" instead of "invisible"
for clarity.

fast/dom/nested-timer-display-none-element-throttling-expected.txt: Renamed from LayoutTests/fast/dom/nested-timer-invisible-element-throttling-expected.txt.
fast/dom/nested-timer-display-none-element-throttling.html: Renamed from LayoutTests/fast/dom/nested-timer-invisible-element-throttling.html.
fast/dom/repeating-timer-display-none-element-throttling-expected.txt: Renamed from LayoutTests/fast/dom/repeating-timer-invisible-element-throttling-expected.txt.
fast/dom/repeating-timer-display-none-element-throttling.html: Renamed from LayoutTests/fast/dom/repeating-timer-invisible-element-throttling.html.
fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling-expected.txt: Added.
fast/dom/repeating-timer-mixed-visible-display-none-elements-throttling.html: Added.

1:01 PM Changeset in webkit [176332] by dburkart@apple.com

5 edits in branches/safari-600.3-branch/Source

Bump versioning

12:50 PM Changeset in webkit [176331] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Get rid of AccessibilityObject::setRoleValue()
https://bugs.webkit.org/show_bug.cgi?id=138861

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-19
Reviewed by Chris Fleizach.

accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::setRoleValue): Deleted.

12:46 PM Changeset in webkit [176330] by Chris Dumez

1 edit
2 adds in trunk/LayoutTests

Add layout test for DOM timer throttling and element moving into view after layout
https://bugs.webkit.org/show_bug.cgi?id=138874

Reviewed by Simon Fraser.

Add a layout test to make sure we unthrottle a DOM timer changing the
style of an element outside viewport if the element ends up inside
the viewport after layout.

fast/dom/timer-unthrottle-on-layout-expected.txt: Added.
fast/dom/timer-unthrottle-on-layout.html: Added.

11:16 AM Changeset in webkit [176329] by Brian Burg

10 edits
1 copy
18 moves
2 adds in trunk/Source/JavaScriptCore

Web Inspector: standardize language-specific protocol generator file, class, and method prefixes
https://bugs.webkit.org/show_bug.cgi?id=138237

Reviewed by Joseph Pecoraro.

Settle on cpp/objc/js file prefixes and Cpp/ObjC/JS class prefixes for generators.
Move C++-specific static methods into CppGenerator and add cpp_ prefixes where relevant.
Split the templates file into language-specific template files.

CMakeLists.txt:
DerivedSources.make:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
JavaScriptCore.xcodeproj/project.pbxproj:
inspector/scripts/codegen/init.py:
inspector/scripts/codegen/cpp_generator.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator.py.
inspector/scripts/codegen/cpp_generator_templates.py: Copied from Source/JavaScriptCore/inspector/scripts/codegen/generator_templates.py.

(CppGeneratorTemplates):

inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_alternate_backend_dispatcher_header.py.
inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_header.py.
inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_dispatcher_implementation.py.
inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_frontend_dispatcher_header.py.
inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_frontend_dispatcher_implementation.py.
inspector/scripts/codegen/generate_cpp_protocol_types_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_header.py.
inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_protocol_types_implementation.py.
inspector/scripts/codegen/generate_js_backend_commands.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_backend_commands.py.
inspector/scripts/codegen/generate_objc_backend_dispatcher_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_backend_dispatcher_header.py.
inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_backend_dispatcher_implementation.py.
inspector/scripts/codegen/generate_objc_configuration_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_configuration_header.py.
inspector/scripts/codegen/generate_objc_configuration_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_configuration_implementation.py.
inspector/scripts/codegen/generate_objc_conversion_helpers.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_conversion_helpers.py.
inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_frontend_dispatcher_implementation.py.
inspector/scripts/codegen/generate_objc_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_header.py.
inspector/scripts/codegen/generate_objc_internal_header.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_internal_header.py.
inspector/scripts/codegen/generate_objc_protocol_types_implementation.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c_types_implementation.py.
inspector/scripts/codegen/generator.py:
inspector/scripts/codegen/generator_templates.py:
inspector/scripts/codegen/objc_generator.py: Renamed from Source/JavaScriptCore/inspector/scripts/codegen/generate_objective_c.py.
inspector/scripts/codegen/objc_generator_templates.py: Added.
inspector/scripts/generate-inspector-protocol-bindings.py:

11:01 AM Changeset in webkit [176328] by bshafiei@apple.com

1 copy in tags/Safari-601.1.10

New tag.

10:59 AM Changeset in webkit [176327] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

10:46 AM Changeset in webkit [176326] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Update WebKit to build with LLVM TOT
https://bugs.webkit.org/show_bug.cgi?id=138519

Patch by Juergen Ributzka <juergen@apple.com> on 2014-11-19
Reviewed by Alexey Proskuryakov.

Configurations/LLVMForJSC.xcconfig:
llvm/LLVMAPIFunctions.h:
llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

10:34 AM Changeset in webkit [176325] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Debugger should not mutate variable when hovering mouse over ++n expression
https://bugs.webkit.org/show_bug.cgi?id=138839

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Timothy Hatcher.

UserInterface/Controllers/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype._processJavaScriptExpression):

10:32 AM Changeset in webkit [176324] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve basic JavaScript completion in inline <script>s
https://bugs.webkit.org/show_bug.cgi?id=138845

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-11-19
Reviewed by Timothy Hatcher.

UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype._generateJavaScriptCompletions):
Fix up CodeMirror mode handling for JavaScript completion when inside of mixed mode
input (html). Also add completion for CodeMirror's localVars list.

10:27 AM Changeset in webkit [176323] by Chris Dumez

1 edit
2 adds in trunk/LayoutTests

Add layout test for DOM timers throttling and 0 height element with visible overflowing content
https://bugs.webkit.org/show_bug.cgi?id=138873

Reviewed by Simon Fraser.

Add a layout test for verify that a DOM timer changing the style of a 0
height element with visible overflowing content does not get throttled.
If the implementation did not properly use the overflow rect to
determine if the element is visible, this test would fail.

This covers the case of the top scrolling banner on huffingtonpost.com.

fast/dom/repeating-timer-element-overflow-throttling-expected.txt: Added.
fast/dom/repeating-timer-element-overflow-throttling.html: Added.

9:52 AM Changeset in webkit [176322] by Philippe Normand

2 edits in trunk/Source/WebCore

Missing NULL-check in VideoTrack::setLanguage
https://bugs.webkit.org/show_bug.cgi?id=138867

Reviewed by Jer Noble.

html/track/VideoTrack.cpp:

(WebCore::VideoTrack::setLanguage): Prevent change event creation
on an empty video track list.

9:36 AM Changeset in webkit [176321] by Chris Fleizach

3 edits
2 adds in trunk

AX: Safari fails to load a web page with VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=138849

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Sometimes an inlineElementContinuation will continue to an inline RenderBlock, so we case this incorrectly and bad things happen.

Test: accessibility/inline-block-assertion.html

accessibility/AccessibilityRenderObject.cpp:

(WebCore::startOfContinuations):

LayoutTests:

accessibility/inline-block-assertion-expected.txt: Added.
accessibility/inline-block-assertion.html: Added.

9:26 AM Changeset in webkit [176320] by Alan Bujtas

2 edits in trunk/Source/WebCore

Simple line layout: RenderTreeAsText should use rangeForRenderer() when dumping simple line text.
https://bugs.webkit.org/show_bug.cgi?id=138847

Reviewed by Antti Koivisto.

This is in preparation to support multiple renderers for simple line layout.
Use rangeForRenderer() to get runs for a particular renderer as opposed to for the entire flow.

Not testable.

rendering/RenderTreeAsText.cpp:

(WebCore::write):

9:23 AM Changeset in webkit [176319] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile error when CSS_SELECTORS_LEVEL4 is not enabled.
https://bugs.webkit.org/show_bug.cgi?id=138870

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-19
Reviewed by Alex Christensen.

css/CSSSelector.cpp:

(WebCore::simpleSelectorSpecificityInternal):

7:47 AM Changeset in webkit [176318] by Chris Fleizach

8 edits
4 adds in trunk

AX: Screen braille input doesn't work on forms.
https://bugs.webkit.org/show_bug.cgi?id=138804

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Allow iOS to set values of text fields through the API.

Test: platform/ios-sim/accessibility/set-value.html

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilitySetValue:]):

Tools:

Add a method to setValue through the AX API in DRT.

DumpRenderTree/AccessibilityUIElement.cpp:

(setValueCallback):
(AccessibilityUIElement::getJSClass):

DumpRenderTree/AccessibilityUIElement.h:
DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::setValue):

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::setValue):

LayoutTests:

platform/ios-sim: Copied from LayoutTests/platform/ios-sim.
platform/ios-sim/accessibility/set-value-expected.txt: Added.
platform/ios-sim/accessibility/set-value.html: Added.

7:40 AM Changeset in webkit [176317] by Alan Bujtas

6 edits in trunk/Source/WebCore

Simple line layout: Add renderer based rect collecting to RunResolver.
https://bugs.webkit.org/show_bug.cgi?id=138818

Reviewed by Antti Koivisto.

This is in preparation to multiple renderers support.
RunResolver should be able to collect rects for a particular renderer
that might overlap multiple runs. (or might just be a subset of a Run)

Covered by existing tests.

rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::FlowContents::renderer): It operates on a single renderer currently.
(WebCore::SimpleLineLayout::FlowContents::resolveRendererPositions): It operates on a single renderer currently.

rendering/SimpleLineLayoutFlowContents.h:
rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::computeTextBoundingBox):
(WebCore::SimpleLineLayout::computeTextFirstRunLocation):
(WebCore::SimpleLineLayout::collectTextAbsoluteRects):
(WebCore::SimpleLineLayout::collectTextAbsoluteQuads):
(WebCore::SimpleLineLayout::showLineLayoutForFlow):

rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::baselinePosition):
(WebCore::SimpleLineLayout::linePosition):
(WebCore::SimpleLineLayout::lineSize):
(WebCore::SimpleLineLayout::RunResolver::Run::rect):
(WebCore::SimpleLineLayout::RunResolver::Run::rectForTextRenderer):
(WebCore::SimpleLineLayout::RunResolver::Run::baseline):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Run::computeRect):
(WebCore::SimpleLineLayout::RunResolver::RunResolver):

rendering/SimpleLineLayoutResolver.h:

6:24 AM Changeset in webkit [176316] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Error in documentation of webkit_print_operation_get_page_setup()
https://bugs.webkit.org/show_bug.cgi?id=138868

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-11-19
Reviewed by Carlos Garcia Campos.

Fix copypaste error in documentation of
webkit_print_operation_get_page_setup().

UIProcess/API/gtk/WebKitPrintOperation.cpp:

4:46 AM WebKitGTK/2.6.x edited by jdiggs@igalia.com

(diff)

1:55 AM Changeset in webkit [176315] by mrowe@apple.com

1 edit
1 delete in trunk/Source/WebKit2

Remove an unused file.

version.plist: Removed.

1:06 AM Changeset in webkit [176314] by commit-queue@webkit.org

2 edits in trunk

Fix the detection of toolchain support for Cortex-A53 erratum 835769 workaround
https://bugs.webkit.org/show_bug.cgi?id=138840

Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-11-19
Reviewed by Csaba Osztrogonác.

Source/cmake/OptionsCommon.cmake:

12:57 AM Changeset in webkit [176313] by commit-queue@webkit.org

5 edits
4 adds in trunk

Add selector checker for :lang pseudo class in Selectors level 4
https://bugs.webkit.org/show_bug.cgi?id=138281

Patch by Dhi Aurrahman <diorahman@rockybars.com> on 2014-11-19
Reviewed by Benjamin Poulain.

Source/WebCore:

Add selector checker for :lang pseudo class in Selectors level 4.

The language tags matching is specified in [1,2].

[1] http://www.ietf.org/rfc/rfc4647.txt
[2] http://dev.w3.org/csswg/selectors4/#the-lang-pseudo

Tests: fast/selectors/lang-extended-filtering.html

fast/selectors/lang-multiple.html

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorCheckerTestFunctions.h:

(WebCore::containslanguageSubtagMatchingRange):
(WebCore::matchesLangPseudoClass):
(WebCore::matchesLangPseudoClassDeprecated):

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

Add layout tests for :lang selector checker with multiple arguments and
related behaviors on extended filtering.

fast/selectors/lang-extended-filtering-expected.txt: Added.
fast/selectors/lang-extended-filtering.html: Added.
fast/selectors/lang-multiple-expected.txt: Added.
fast/selectors/lang-multiple.html: Added.

12:53 AM Changeset in webkit [176312] by mrowe@apple.com

1 edit
1 copy in trunk/Source/WebInspectorUI

Roll over WebInspectorUI's ChangeLog.

Nov 18, 2014:

11:49 PM Changeset in webkit [176311] by Philippe Normand

8 edits in trunk

start/stop method for AudioBufferSourceNodes and OscillatorNodes can take no args
https://bugs.webkit.org/show_bug.cgi?id=138739

Reviewed by Darin Adler.

Source/WebCore:

The patch is inspired by the following Blink revision by
<Raymond Toy>:
<https://src.chromium.org/viewvc/blink?view=rev&revision=160845>

Test: webaudio/dom-exceptions.html

Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::start):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::noteGrainOn):
(WebCore::AudioBufferSourceNode::startGrain): Deleted.

Modules/webaudio/AudioBufferSourceNode.h:
Modules/webaudio/AudioBufferSourceNode.idl:
Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::stop):

Modules/webaudio/AudioScheduledSourceNode.h:
Modules/webaudio/OscillatorNode.idl:

LayoutTests:

webaudio/dom-exceptions-expected.txt: Added.
webaudio/dom-exceptions.html: Added.

10:45 PM Changeset in webkit [176310] by rniwa@webkit.org

2 edits in trunk/LayoutTests

Aad failing test expectations to some tests imported in r176144.

platform/win/TestExpectations:

9:41 PM Changeset in webkit [176309] by ap@apple.com

2 edits in trunk/LayoutTests

Use of uninitialized value in string eq in many http tests
https://bugs.webkit.org/show_bug.cgi?id=138852

Reviewed by Daniel Bates.

http/tests/security/xssAuditor/resources/echo-intertag.pl: Don't use it uninitialized.

9:13 PM Changeset in webkit [176308] by benjamin@webkit.org

15 edits in trunk/Source/WebKit2

[WK2] Remove the minimalUI code from the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=138819

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-18
Reviewed by Sam Weinig.

It looks like the only interface we have to keep alive is
[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:].

Clean up everything else, it is a pile of useless code.

UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLoadForMainFrame]):
(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _didRelaunchProcess]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride:]):
(-[WKWebView _setUsesMinimalUI:]): Deleted.
(-[WKWebView _usesMinimalUI]): Deleted.
(activeMinimumLayoutSizeForMinimalUI): Deleted.
(-[WKWebView _setMinimumLayoutSizeOverrideForMinimalUI:]): Deleted.

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):

UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::setUsesMinimalUI): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::setViewportConfigurationMinimumLayoutSizeForMinimalUI): Deleted.
(WebKit::WebPageProxy::setUsesMinimalUI): Deleted.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::viewportPropertiesDidChange):
(WebKit::WebPage::dynamicViewportSizeUpdate):
(WebKit::WebPage::setViewportConfigurationMinimumLayoutSizeForMinimalUI): Deleted.

9:12 PM Changeset in webkit [176307] by benjamin@webkit.org

7 edits
20 adds in trunk

Add the initial implementation of dynamic specificity for :matches()
https://bugs.webkit.org/show_bug.cgi?id=138822

Reviewed by Andreas Kling.

Source/WebCore:

Previously we completely ignored the selector list of :matches() when computing
the specificity of the selector.

The spec (http://dev.w3.org/csswg/selectors4/#specificity) says:
"The specificity of a :matches() pseudo-class, however, is the specificity

of the most specific complex selector that matched the given element."

This patch does just that.

In the CSS JIT, we only consider specificities that can be computed statically
for now, this should be extended later.
When the specificity is dynamic, we fall back to SelectorChecker. In that case,
we execute every selector of the selector list and we keep the maximum value
as the specificity for the whole :matches().

Tests: fast/css/matches-specificity-1.html

fast/css/matches-specificity-2.html
fast/css/matches-specificity-3.html
fast/css/matches-specificity-4.html
fast/css/matches-specificity-5.html
fast/css/matches-specificity-6.html
fast/css/matches-specificity-7.html
fast/css/matches-specificity-8.html
fast/css/matches-specificity-9.html
fast/css/matches-specificity-10.html

css/CSSSelector.cpp:

(WebCore::selectorSpecificity):
(WebCore::maxSpecificity):
(WebCore::CSSSelector::specificity):
(WebCore::simpleSelectorSpecificityInternal):
(WebCore::CSSSelector::simpleSelectorSpecificity):
:matches() itself should not have any specificity. The specificity of its components
is computed in SelectorChecker.

Since :matches() is no longer accounted as a class B specificity, I had to finish
the specificity of :not() or some test breaks.

css/CSSSelector.h:
css/PageRuleCollector.cpp:

(WebCore::comparePageRules):

css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
We can no longer shortcut the execution when context.pseudoElementEffective is false.
There is no guarantee that a following selector wouldn't match with a higher specificity.

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSelectorChecker):

LayoutTests:

fast/css/matches-specificity-1-expected.html: Added.
fast/css/matches-specificity-1.html: Added.
fast/css/matches-specificity-2-expected.html: Added.
fast/css/matches-specificity-2.html: Added.
fast/css/matches-specificity-3-expected.html: Added.
fast/css/matches-specificity-3.html: Added.
fast/css/matches-specificity-4-expected.html: Added.
fast/css/matches-specificity-4.html: Added.
fast/css/matches-specificity-5-expected.html: Added.
fast/css/matches-specificity-5.html: Added.
fast/css/matches-specificity-6-expected.html: Added.
fast/css/matches-specificity-6.html: Added.
fast/css/matches-specificity-7-expected.html: Added.
fast/css/matches-specificity-7.html: Added.
fast/css/matches-specificity-8-expected.html: Added.
fast/css/matches-specificity-8.html: Added.
fast/css/matches-specificity-9-expected.html: Added.
fast/css/matches-specificity-9.html: Added.
fast/css/matches-specificity-10-expected.html: Added.
fast/css/matches-specificity-10.html: Added.

9:08 PM Changeset in webkit [176306] by Conrad Shultz

2 edits in trunk/Source/WebKit2

Unreviewed. Revision to the build fix in r176304.

The guarded method should simply be in the !TARGET_OS_IPHONE block.

UIProcess/API/Cocoa/WKViewPrivate.h:

9:06 PM Changeset in webkit [176305] by benjamin@webkit.org

3 edits in trunk/Source/WebKit2

iOS8 new "slow tap" heuristic fires mouse compat events despite preventDefault on touchend
https://bugs.webkit.org/show_bug.cgi?id=137069
rdar://problem/18481464

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-18
Reviewed by Simon Fraser.

On WebKit2, we let UIWebTouchEventsGestureRecognizer and _UIWebHighlightLongPressGestureRecognizer
run concurrently. This causes a race with an incorrect behavior:
1) If UIWebTouchEventsGestureRecognizer does not cancel the native gestures on start.
2) _UIWebHighlightLongPressGestureRecognizer starts after highlightDelay.
3) When the finger leaves the screen, both gestures end.
-> If the touch end sent to JavaScript in [3] ask the priority over native events, that no longer stops

the _UIWebHighlightLongPressGestureRecognizer.

The two gesture recognizers can run in any order, there is no guarantee on which one runs first.
To solve the bug, I must make sure the _UIWebHighlightLongPressGestureRecognizer never trigger a click
if the page wants the event.

To solve the order problem, I use the fact that event recognition goes in two phases for
non cancelled events:
1) Update the gesture recognizers.
2) Trigger the actions.

I do not know the order of recognizers in [1], but I know both have run before [2] is executed.
I use that to stop _UIWebHighlightLongPressGestureRecognizer from ending with a click in the case of the bug:
1) When _UIWebHighlightLongPressGestureRecognizer starts, I set _highlightLongPressCanClick signaling

the gesture can end normally. This is done on a timer and not direct input so I don't really have to worry
about a race here.

2) When processing the touch event for UIWebTouchEventsGestureRecognizer, I reset the flag _highlightLongPressCanClick

if the page wants the event.

3) When the actions of _UIWebHighlightLongPressGestureRecognizer are processed, the touch event

has already been processed by the page and the flag has been cleared if needed.

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _webTouchEvent:preventsNativeGestures:]):
(-[WKContentView _highlightLongPressRecognized:]):

8:31 PM Changeset in webkit [176304] by rniwa@webkit.org

2 edits in trunk/Source/WebKit2

iOS build fix after r176299. This method is not defined in WKViewIOS.mm.

UIProcess/API/Cocoa/WKViewPrivate.h:

6:42 PM Changeset in webkit [176303] by ddkilzer@apple.com

8 edits in trunk/Source

FeatureDefines.xcconfig: Switch from using PLATFORM_NAME to SDK selectors
<http://webkit.org/b/138813>

Reviewed by Mark Rowe.

Configurations/FeatureDefines.xcconfig: Switch to using SDK

selectors.

6:17 PM Changeset in webkit [176302] by rniwa@webkit.org

2 edits in branches/safari-600.2-branch/LayoutTests

nested-multicol-into-region-dynamic.html is flaky on WK1.

platform/mac-wk1/TestExpectations:

6:05 PM Changeset in webkit [176301] by Chris Dumez

3 edits
4 adds in trunk

Crash when setting 'z-index' / 'flex-shrink' CSS properties to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138783

Reviewed by Andreas Kling.

Source/WebCore:

Update operators converting CSSPrimitiveValue to integer / floating
point types to properly handle calculated values (e.g. 'calc(2 * 3)').
Previously, this was not working in release builds and we would hit an
ASSERT_NOT_REACHED() in debug builds.

Tests: fast/css/flex-shrink-calculated-value.html

fast/css/z-index-calculated-value.html

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator unsigned short):
(WebCore::CSSPrimitiveValue::operator int):
(WebCore::CSSPrimitiveValue::operator unsigned):
(WebCore::CSSPrimitiveValue::operator float):

LayoutTests:

Add layout tests to check that settings 'z-index' / 'flex-shrink' CSS
properties to a calculated value does not crash and behaves as
expected.

fast/css/flex-shrink-calculated-value-expected.txt: Added.
fast/css/flex-shrink-calculated-value.html: Added.
fast/css/z-index-calculated-value-expected.txt: Added.
fast/css/z-index-calculated-value.html: Added.

5:57 PM Changeset in webkit [176300] by dburkart@apple.com

1 copy in tags/Safari-600.3.7

Tagging.

5:43 PM Changeset in webkit [176299] by Conrad Shultz

4 edits in trunk/Source/WebKit2

Give clients a way to cancel preview popovers
https://bugs.webkit.org/show_bug.cgi?id=138855

Reviewed by Tim Horton.

Promote -[WKView _dismissActionMenuPopovers] from internal to private.

UIProcess/API/Cocoa/WKViewPrivate.h:
UIProcess/API/mac/WKView.mm:

(-[WKView _dismissActionMenuPopovers]):

UIProcess/API/mac/WKViewInternal.h:

5:19 PM Changeset in webkit [176298] by mmaxfield@apple.com

14 edits
2 moves in trunk

Unreviewed, rolling out r176263 and r176273.
https://bugs.webkit.org/show_bug.cgi?id=138854

Underlines are hideous. (Requested by litherum on #webkit).

Reverted changesets:

"Use underlining metrics from the font file"
https://bugs.webkit.org/show_bug.cgi?id=138762
http://trac.webkit.org/changeset/176263

"iOS build fix."
http://trac.webkit.org/changeset/176273

Patch by Commit Queue <commit-queue@webkit.org> on 2014-11-18# Please enter the commit message for your changes. Lines starting

4:56 PM Changeset in webkit [176297] by Chris Dumez

14 edits in trunk/Source

Add a setting to toggle DOMTimer throttling support
https://bugs.webkit.org/show_bug.cgi?id=138844
<rdar://problem/19020874>

Reviewed by Andreas Kling.

Add a setting to disable DOM timers throttling, in order to help
developers determine if a specific issue is caused by timer
throttling.

Source/WebCore:

page/DOMTimer.cpp:

(WebCore::DOMTimerFireState::contextDocument):
(WebCore::DOMTimerFireState::scriptMadeUserObservableChanges):
(WebCore::DOMTimer::isDOMTimersThrottlingEnabled):
(WebCore::DOMTimer::updateThrottlingStateIfNecessary):

page/DOMTimer.h:
page/Settings.in:

Source/WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences domTimersThrottlingEnabled]):
(-[WebPreferences setDOMTimersThrottlingEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDOMTimersThrottlingEnabled):
(WKPreferencesGetDOMTimersThrottlingEnabled):

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

4:49 PM Changeset in webkit [176296] by Beth Dakin

2 edits in trunk/Source/WebCore

REGRESSION: Invoking dictionary lookup on text in some search fields searches for
incorrect item
https://bugs.webkit.org/show_bug.cgi?id=138853
-and corresponding-
rdar://problem/18912505

Reviewed by Tim Horton.

Get the visible position based on the frame, not just the renderer.

editing/mac/DictionaryLookup.mm:

(WebCore::rangeForDictionaryLookupAtHitTestResult):

4:37 PM Changeset in webkit [176295] by hyatt@apple.com

3 edits
2 adds in trunk

REGRESSION (r167210): Invalid cast in WebCore::RenderBlock::blockSelectionGaps
https://bugs.webkit.org/show_bug.cgi?id=137590

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/block/selection-block-gaps-crash.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::blockSelectionGaps):
Check that we really are a RenderBlock before recurring.

LayoutTests:

fast/block/selection-block-gap-crash-expected.txt: Added.
fast/block/selection-block-gap-crash.html: Added.

4:20 PM Changeset in webkit [176294] by akling@apple.com

4 edits in trunk

Avoid synchronous style recalc in Document.activeElement
<https://webkit.org/b/138850>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This subtly changes the behavior of <input autofocus>, which was caught by
a layout test. Auto-focus doesn't happen until the render tree is attached,
although it was possible to force it by accessing document.activeElement.

Now auto-focus is always lazy. This is consistent with other browser engines.

~1% progression on Speedometer locally.

dom/Document.cpp:

(WebCore::Document::activeElement):

LayoutTests:

Tweak a test to run once the DOM is loaded instead of during parsing.

fast/forms/autofocus-in-sandbox-with-allow-scripts.html:

4:17 PM Changeset in webkit [176293] by Chris Dumez

5 edits in trunk/Source

Have Vector::capacity() return an unsigned instead of a size_t
https://bugs.webkit.org/show_bug.cgi?id=138842

Reviewed by Andreas Kling.

Source/WebCore:

Update the code base now that Vector::capacity() returns an unsigned
type instead of a size_t.

No new tests, no behavior change.

editing/TextIterator.cpp:

(WebCore::SearchBuffer::append):
(WebCore::SearchBuffer::prependContext):
(WebCore::SearchBuffer::search):
(WebCore::SearchBuffer::length):

platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::duplicateDataBufferIfNecessary):

Source/WTF:

Have Vector::capacity() return an unsigned instead of a size_t as
capacity is stored as an unsigned internally.

wtf/Vector.h:

(WTF::Vector::capacity):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):

3:07 PM Changeset in webkit [176292] by Simon Fraser

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r175679. rdar://problem/18978404

3:07 PM Changeset in webkit [176291] by Simon Fraser

5 edits
4 adds in branches/safari-600.3-branch

Merge r175656. rdar://problem/18978402

3:06 PM Changeset in webkit [176290] by ggaren@apple.com

13 edits in trunk/Source

Removed the custom allocator for ListHashSet nodes
https://bugs.webkit.org/show_bug.cgi?id=138841

Reviewed by Andreas Kling.

Source/WebCore:

Uses of ListHashSet no longer need to declare an inline capacity,
since that was only used to specify the capacity of the custom allocator.

dom/DOMNamedFlowCollection.h:
dom/DocumentEventQueue.h:
dom/DocumentStyleSheetCollection.h:
dom/NamedFlowCollection.h:
html/FormController.h:
rendering/FloatingObjects.h:
rendering/RenderBlock.h:

Source/WebKit2:

Uses of ListHashSet no longer need to declare an inline capacity,
since that was only used to specify the capacity of the custom allocator.

UIProcess/Plugins/PluginInfoStore.cpp:

(WebKit::PluginInfoStore::loadPluginsIfNecessary):

Source/WTF:

bmalloc is fast, so we don't need a custom allocator.

The MallocBench test for linked list node allocation (list_allocate) is
4.09X faster in bmalloc than TCMalloc. Also, I wrote a stress test to
add/remove link elements, which modify a ListHashSet on insertion and
removal, and it was 1% faster / in the noise with bmalloc enabled.

wtf/ListHashSet.h:

(WTF::ListHashSetNode::ListHashSetNode):
(WTF::ListHashSetTranslator::translate):
(WTF::U>::ListHashSet):
(WTF::=):
(WTF::U>::swap):
(WTF::U>::~ListHashSet):
(WTF::U>::size):
(WTF::U>::capacity):
(WTF::U>::isEmpty):
(WTF::U>::first):
(WTF::U>::removeFirst):
(WTF::U>::takeFirst):
(WTF::U>::last):
(WTF::U>::removeLast):
(WTF::U>::takeLast):
(WTF::U>::contains):
(WTF::U>::remove):
(WTF::U>::clear):
(WTF::U>::unlink):
(WTF::U>::unlinkAndDelete):
(WTF::U>::appendNode):
(WTF::U>::prependNode):
(WTF::U>::insertNodeBefore):
(WTF::U>::deleteAllNodes):
(WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): Deleted.
(WTF::ListHashSetNodeAllocator::allocate): Deleted.
(WTF::ListHashSetNodeAllocator::deallocate): Deleted.
(WTF::ListHashSetNodeAllocator::pool): Deleted.
(WTF::ListHashSetNodeAllocator::pastPool): Deleted.
(WTF::ListHashSetNodeAllocator::inPool): Deleted.
(WTF::ListHashSetNode::operator new): Deleted.
(WTF::ListHashSetNode::destroy): Deleted.

2:57 PM Changeset in webkit [176289] by eric.carlson@apple.com

2 edits in trunk/Source/WebKit2

Unreviewed build fix after r176283.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

2:54 PM Changeset in webkit [176288] by timothy_horton@apple.com

7 edits in trunk/Source

Avoid re-encoding action menu image data
https://bugs.webkit.org/show_bug.cgi?id=138817
<rdar://problem/18840382>

Reviewed by Anders Carlsson.

Shared/mac/ActionMenuHitTestResult.h:
Shared/mac/ActionMenuHitTestResult.mm:

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Store and encode a SharedMemory with the raw encoded image data,
instead of re-painting the image into a ShareableBitmap.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _hitTestResultImage]):
(-[WKActionMenuController _defaultMenuItemsForImage]):
(-[WKActionMenuController _copyImage:]):
(-[WKActionMenuController _addImageToPhotos:]):
(-[WKActionMenuController _defaultMenuItems]):
(-[WKActionMenuController _canAddMediaToPhotos]): Deleted.
Build a temporary filename from a UUID and the image's desired extension.
Use the Image's encoded data instead of re-encoding it with CGImageDestination.
Build an image menu only if we have an image, URL, data, and extension.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):

WebView/WebActionMenuController.mm:

(-[WebActionMenuController _defaultMenuItemsForImage:]):
(-[WebActionMenuController _addImageToPhotos:]):
Build a temporary filename from a UUID and the image's desired extension.
Use the Image's encoded data instead of re-encoding it with CGImageDestination.
Build an image menu only if we have an image, URL, data, and extension.

2:51 PM Changeset in webkit [176287] by hyatt@apple.com

3 edits
2 adds in trunk

REGRESSION(r152313): Inline-block element doesn't wrap properly
https://bugs.webkit.org/show_bug.cgi?id=138846 - <rdar://problem/18838703>

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/inline-block/inline-block-empty-spans.html

rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::canBreakAtThisPosition):

LayoutTests:

fast/inline-block/inline-block-empty-spans-expected.html: Added.
fast/inline-block/inline-block-empty-spans.html: Added.

2:45 PM Changeset in webkit [176286] by rniwa@webkit.org

2 edits in branches/safari-600.2-branch/LayoutTests

Add test expectations.

platform/mac/TestExpectations:

2:40 PM Changeset in webkit [176285] by mmaxfield@apple.com

3 edits
2 adds in trunk

Multicolumn layout with negative line spacing and orphans causes pieces of letters to be shown at the bottom of columns
https://bugs.webkit.org/show_bug.cgi?id=138204

Source/WebCore:

Reviewed by Dave Hyatt.

This code is responsible for pushing block elements to the next column if
the "orphans" CSS property is triggered. The mechanism by which this is
achieved is to push the block down such that the origin of the block is
at the origin of the next column. However, if there is negative line
spacing, the top portion of the text might actually be on top of the
origin of the block. Therefore, the block wasn't being pushed down enough
to entirely contain its text, so the top pieces were being drawn on the
previous column.

Test: fast/multicol/orphans-negative-line-spacing.html

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustLinePositionForPagination):

LayoutTests:

Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.

Create a layout where the "orphans" css property causes a block element to
be pushed to the next column.

fast/multicol/orphans-negative-line-spacing-expected.html: Added.
fast/multicol/orphans-negative-line-spacing.html: Added.

2:10 PM Changeset in webkit [176284] by dburkart@apple.com

6 edits in branches/safari-600.3-branch/Source

Merge r176166. rdar://problem/18953982

2:10 PM Changeset in webkit [176283] by eric.carlson@apple.com

5 edits in trunk/Source/WebKit2

[iOS] allow host application to opt-out of alternate fullscreen
https://bugs.webkit.org/show_bug.cgi?id=138787

Reviewed by Sam Weinig.

"allowsAlternateFullscreen" doesn't need to be in the public WKWebView header.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]): allowsAlternateFullscreen -> _allowsAlternateFullscreen.

UIProcess/API/Cocoa/WKWebViewConfiguration.h: Remove allowsAlternateFullscreen.
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _allowsAlternateFullscreen]): New.
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]): New.

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Declare _allowsAlternateFullscreen.

2:05 PM Changeset in webkit [176282] by Chris Dumez

3 edits
2 adds in trunk

DOMTimers sometimes don't get unthrottled on scrolling
https://bugs.webkit.org/show_bug.cgi?id=138838

Reviewed by Antti Koivisto.

Source/WebCore:

DOMTimers sometimes didn't get unthrottled on scrolling. This is
because we stopped listening for viewport changes every time the
timer fires, but we didn't listen for those changes again if we
decided the timer should stay throttled after the timer's action
was executed.

We should listen for viewport changes again after executing the
timer's action, if there are elements outside the viewport causing
the DOMTimer to be throttled, even if the throttleState hasn't
changed (i.e the timer stays throttled).

Test: fast/dom/timer-unthrottle-on-scroll.html

page/DOMTimer.cpp:

(WebCore::DOMTimer::updateThrottlingStateIfNecessary):
(WebCore::DOMTimer::updateTimerIntervalIfNecessary):
(WebCore::DOMTimer::updateThrottlingStateAfterViewportChange):

LayoutTests:

Add a layout test to verify that DOMTimers get unthrottled on scroll if
the element whose style they are changing is inside the viewport after
the scroll.

fast/dom/timer-unthrottle-on-scroll-expected.txt: Added.
fast/dom/timer-unthrottle-on-scroll.html: Added.

1:28 PM Changeset in webkit [176281] by dburkart@apple.com

28 edits
1 copy in branches/safari-600.3-branch/Source

Merge r176164. rdar://problem/18953982

1:01 PM Changeset in webkit [176280] by dburkart@apple.com

21 edits in branches/safari-600.3-branch/Source

Merge r176108. rdar://problem/19005904

12:59 PM Changeset in webkit [176279] by Csaba Osztrogonác

4 edits in trunk/Tools

Remove the WinCairo buildbot
https://bugs.webkit.org/show_bug.cgi?id=138805

Reviewed by Alex Christensen.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/master.cfg:

(appendCustomBuildFlags):

BuildSlaveSupport/test-result-archive:

(archiveTestResults):

12:56 PM Changeset in webkit [176278] by dbates@webkit.org

8 edits in trunk/Source/WebCore

[iOS] Make WebCore build and link with public SDK
https://bugs.webkit.org/show_bug.cgi?id=136487

Patch by Daniel Bates <dbates@webkit.org> on 2014-11-18
Reviewed by David Kilzer.

bindings/objc/DOMInternal.mm: Include header NSMapTableSPI.h.
bindings/objc/WebScriptObject.mm: Ditto; Also fix style nit, substitute

#import for #include when importing header WTFString.h.

bridge/objc/objc_instance.mm: Include header NSMapTableSPI.h and remove

#import NSMapTable.h as the former will import the latter.

platform/ios/PlatformEventFactoryIOS.mm: Include header wtf/CurrentTime.h

for the declaration of WTF::currentTime().

platform/ios/wak/WebCoreThread.mm: Remove unnecessary include of header CoreFoundation/CFPriv.h.
platform/spi/ios/AVKitSPI.h: Add more SPI.
platform/spi/ios/MPAVRoutingControllerSPI.h: Ditto.

12:12 PM Changeset in webkit [176277] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Unreviewed. Updated the install instruction.

Install.md:

12:04 PM Changeset in webkit [176276] by mmaxfield@apple.com

21 edits
1 copy
1 add in trunk/Source

Subclass CachedFont for SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=138686

Reviewed by Simon Fraser.

Re-landing due to flakey bots.

Source/WebCore:

CachedFont had many #if ENABLE(SVG_FONTS) scattered throughout it.
Splitting out this SVG-specific code into a subclass of CachedFont
cleans up the design.

No new tests because there is no behavior change.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::getFontData): There are two sections
in this function; one for SVG fonts and one for regular fonts.
I've moved these two sections into CachedFont and SVGCachedFont,
thereby simplifying this function.
(WebCore::CSSFontFaceSource::ensureFontData): Ditto.
(WebCore::CSSFontFaceSource::svgFontFaceElement): Moved to header.
(WebCore::CSSFontFaceSource::setSVGFontFaceElement): Ditto.
(WebCore::CSSFontFaceSource::isSVGFontFaceSource): Ditto.

css/CSSFontFaceSource.h: Put functions that are simple enough to

be inlined here.

css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::isSVGFontTarget): Convenience
function.
(WebCore::CSSFontFaceSrcValue::cachedFont): Pass through a boolean
from CSSFontSelector to CachedResourceHandle regarding if we should
be using SVGCachedFont instead of CachedFont.

css/CSSFontFaceSrcValue.h: New convenience function.
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Pass through a boolean

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceType): Update for new
CachedResource type
(WebCore::cachedResourcesForFrame): Ditto.

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData): Taken from
CSSFontFaceSource::getFontData()
(WebCore::CachedFont::getFontData): Ditto.
(WebCore::CachedFont::platformDataFromCustomData): Ditto.
(WebCore::CachedFont::ensureSVGFontData): Moved to SVGCachedFont.
(WebCore::CachedFont::getSVGFontById): Ditto.

loader/cache/CachedFont.h:
loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType): Update for new enum
type.

loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource): Takes new boolean.
(WebCore::CachedResourceLoader::requestFont): Ditto.
(WebCore::CachedResourceLoader::checkInsecureContent): Update for
new enum type
(WebCore::CachedResourceLoader::canRequest): Ditto.

loader/cache/CachedResourceLoader.h:
loader/cache/CachedSVGFont.cpp: Added.

(WebCore::CachedSVGFont::CachedSVGFont): Moved from
CSSFontFaceSource::getFontData() and CachedFont
(WebCore::CachedSVGFont::getFontData): Ditto.
(WebCore::CachedSVGFont::platformDataFromCustomData): Ditto.
(WebCore::CachedSVGFont::ensureCustomFontData): Ditto.
(WebCore::CachedSVGFont::getSVGFontById): Ditto.
(WebCore::CachedSVGFont::firstFontFace): Ditto.

loader/cache/CachedSVGFont.h: Subclass CachedFont.
loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getStatistics): Update for new enum.

svg/SVGFontFaceUriElement.cpp:

(WebCore::isSVGFontTarget): Convenience function.
(WebCore::SVGFontFaceUriElement::loadFont): Update for new
boolean.

Source/WebKit2:

Update for enum type.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::maximumBufferingTime):

11:56 AM Changeset in webkit [176275] by Chris Dumez

21 edits in trunk/Source

Update the Vector API to deal with unsigned types instead of size_t
https://bugs.webkit.org/show_bug.cgi?id=138824

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).

bytecode/PreciseJumpTargets.cpp:
replay/EncodedValue.h:

Source/WebCore:

Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).

No new tests, no behavior change.

WebCore.exp.in:
bindings/js/JSDOMBinding.h:

(WebCore::jsArray):

bindings/js/JSWebGLRenderingContextCustom.cpp:
cssjit/SelectorCompiler.cpp:
html/HTMLFormElement.cpp:

(WebCore::removeFromVector):

html/parser/HTMLParserIdioms.h:
html/parser/XSSAuditor.cpp:

Source/WebKit2:

Update code base to fix build errors related to the typing changes
in the Vector API (size_t -> unsigned).

Platform/IPC/ArgumentCoders.h:
Platform/IPC/DataReference.h:

Source/WTF:

Update part of the Vector API to deal with unsigned types instead of
size_t. The Vector class is already using unsigned type for its
capacity and size data members. However, the Vector API was never
updated accordingly.

The rest of the Vector API will be ported in follow-up patches to
make the change smaller and more easily reviewable.

wtf/Forward.h:
wtf/Vector.h:

(WTF::VectorTypeOperations::compare):
(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::shouldReallocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::capacity):
(WTF::VectorBufferBase::VectorBufferBase):
(WTF::VectorBuffer::VectorBuffer):
(WTF::VectorBuffer::allocateBuffer):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::VectorBuffer::shouldReallocateBuffer):
(WTF::VectorBuffer::reallocateBuffer):
(WTF::VectorBuffer::swap):
(WTF::VectorBuffer::swapInlineBuffer):
(WTF::VectorBuffer::swapInlineBuffers):
(WTF::Vector::Vector):
(WTF::Vector::at):
(WTF::Vector::operator[]):
(WTF::OverflowHandler>::find):
(WTF::OverflowHandler>::reverseFind):
(WTF::OverflowHandler>::fill):
(WTF::OverflowHandler>::expandCapacity):
(WTF::OverflowHandler>::tryExpandCapacity):
(WTF::OverflowHandler>::resize):
(WTF::OverflowHandler>::resizeToFit):
(WTF::OverflowHandler>::shrink):
(WTF::OverflowHandler>::grow):
(WTF::OverflowHandler>::reserveCapacity):
(WTF::OverflowHandler>::tryReserveCapacity):
(WTF::OverflowHandler>::reserveInitialCapacity):
(WTF::OverflowHandler>::shrinkCapacity):
(WTF::OverflowHandler>::append):
(WTF::OverflowHandler>::tryAppend):
(WTF::OverflowHandler>::insert):
(WTF::OverflowHandler>::insertVector):
(WTF::OverflowHandler>::remove):
(WTF::OverflowHandler>::reverse):
(WTF::OverflowHandler>::checkConsistency):

wtf/text/AtomicString.h:
wtf/text/StringImpl.h:

(WTF::StringImpl::adopt):
(WTF::equalIgnoringNullity):

wtf/text/StringView.h:

(WTF::append):

wtf/text/WTFString.h:

11:32 AM Changeset in webkit [176274] by mmaxfield@apple.com

1 edit in trunk/Source/WebCore/ChangeLog

Unreviewed iOS build fix

platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::platformInit):

11:31 AM Changeset in webkit [176273] by mitz@apple.com

2 edits in trunk/Source/WebCore

iOS build fix.

platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::platformInit):

11:31 AM Changeset in webkit [176272] by matthew_hanson@apple.com

1 edit
2 adds in branches/safari-600.2-branch/LayoutTests

Merge missing layout tests which were added to trunk in r175197.
rdar://problem/18976843

css3/infinite-word-spacing-expected.txt: Added.
css3/infinite-word-spacing.html: Added.

11:24 AM Changeset in webkit [176271] by matthew_hanson@apple.com

1 edit
2 adds in branches/safari-600.3-branch/LayoutTests

Merge missing layout tests which were added to trunk in r175197.
rdar://problem/18976843

css3/infinite-word-spacing-expected.txt: Added.
css3/infinite-word-spacing.html: Added.

11:14 AM Changeset in webkit [176270] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r175765. rdar://problem/19005917

11:10 AM Changeset in webkit [176269] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

[WinCairo] Compile errors when GStreamer is enabled.
https://bugs.webkit.org/show_bug.cgi?id=137000

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-18
Reviewed by Philippe Normand.

MSVC does not allow the keyword default on move constructors and move assignment operators.

wtf/gobject/GMainLoopSource.cpp:

(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::socketCallback):

wtf/gobject/GMainLoopSource.h:

(WTF::GMainLoopSource::Context::operator=):

11:08 AM Changeset in webkit [176268] by dburkart@apple.com

4 edits in branches/safari-600.3-branch/Source/WebInspectorUI

Merge r175763. rdar://problem/19005901

10:52 AM Changeset in webkit [176267] by commit-queue@webkit.org

21 edits
2 deletes in trunk/Source

Unreviewed, rolling out r176264.
https://bugs.webkit.org/show_bug.cgi?id=138837

caused many test failures (Requested by litherum on #webkit).

Reverted changeset:

"Subclass CachedFont for SVG fonts"
https://bugs.webkit.org/show_bug.cgi?id=138686
http://trac.webkit.org/changeset/176264

10:14 AM Changeset in webkit [176266] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r176207.
https://bugs.webkit.org/show_bug.cgi?id=138836

Not ready yet (Requested by ap on #webkit).

Reverted changeset:

"Update WebKit to build with LLVM TOT"
https://bugs.webkit.org/show_bug.cgi?id=138519
http://trac.webkit.org/changeset/176207

10:05 AM Changeset in webkit [176265] by dbates@webkit.org

15 edits
6 copies in trunk

[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138802

Reviewed by David Kilzer.

Source/WebCore:

Add SPI wrapper headers {Dispatch, DynamicLinker, IOPMLib, MachVM, NSPointerFunctions, MobileGestalt}SPI.h
that forward declare applicable libdispatch, dyld, IOKit, mach, Foundation, MobileGestalt SPI
and use these headers instead of the including private headers corresponding to these libraries/frameworks.

WebCore.xcodeproj/project.pbxproj: Add private headers MobileGestaltSPI.h and

MachVMSPI.h, and project headers DynamicLinkerSPI.h, NSPointerFunctionsSPI.h,
DispatchSPI.h and IOPMLibSPI.h. Also, sort files in Xcode project.

bindings/objc/DOMInternal.mm: Include header NSPointerFunctionsSPI.h.
bridge/objc/objc_instance.mm: Ditto; Also, sort #import directives.
platform/cocoa/DisplaySleepDisablerCocoa.cpp: Substitute header IOPMLibSPI.h

for private header IOKit/pwr_mgt/IOPMLib.h.

platform/cocoa/MemoryPressureHandlerCocoa.mm: Substitute header DispatchSPI.h

for private header dispatch/private.h.

platform/graphics/ios/FontServicesIOS.mm: Substitute header DynamicLinkerSPI.h

for private header mach-o/dyld_priv.h.

platform/ios/PlatformScreenIOS.mm: Substitute header MobileGestaltSPI.h for

private header MobileGestalt.h.

platform/spi/cocoa/DispatchSPI.h: Added.
platform/spi/cocoa/DynamicLinkerSPI.h: Added.
platform/spi/cocoa/IOPMLibSPI.h: Added.
platform/spi/cocoa/MachVMSPI.h: Added.
platform/spi/cocoa/NSPointerFunctionsSPI.h: Added.
platform/spi/ios/MobileGestaltSPI.h: Added.

Source/WebKit/mac:

Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
libdispatch and MobileGestalt headers directly.

WebView/WebView.mm:

Source/WebKit2:

Include headers DispatchSPI.h and MachVMSPI.h.h instead of including
libdispatch and Mach headers directly.

Platform/mac/SharedMemoryMac.cpp:
UIProcess/ios/WebMemoryPressureHandlerIOS.mm:

Tools:

Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.

DumpRenderTree/mac/CheckedMalloc.cpp:

10:04 AM Changeset in webkit [176264] by mmaxfield@apple.com

21 edits
1 copy
1 add in trunk/Source

Subclass CachedFont for SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=138686

Reviewed by Simon Fraser.

Source/WebCore:

CachedFont had many #if ENABLE(SVG_FONTS) scattered throughout it.
Splitting out this SVG-specific code into a subclass of CachedFont
cleans up the design.

No new tests because there is no behavior change.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
css/CSSFontFaceSource.cpp:

css/CSSFontFaceSource.h: Put functions that are simple enough to

be inlined here.

css/CSSFontFaceSrcValue.cpp:

css/CSSFontFaceSrcValue.h: New convenience function.
css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Pass through a boolean

inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::cachedResourceType): Update for new
CachedResource type
(WebCore::cachedResourcesForFrame): Ditto.

loader/cache/CachedFont.cpp:

loader/cache/CachedFont.h:
loader/cache/CachedResource.cpp:

(WebCore::defaultPriorityForResourceType): Update for new enum
type.

loader/cache/CachedResource.h:
loader/cache/CachedResourceLoader.cpp:

loader/cache/CachedResourceLoader.h:
loader/cache/CachedSVGFont.cpp: Added.

loader/cache/CachedSVGFont.h: Subclass CachedFont.
loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getStatistics): Update for new enum.

svg/SVGFontFaceUriElement.cpp:

(WebCore::isSVGFontTarget): Convenience function.
(WebCore::SVGFontFaceUriElement::loadFont): Update for new
boolean.

Source/WebKit2:

Update for enum type.

WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::maximumBufferingTime):

10:04 AM Changeset in webkit [176263] by mmaxfield@apple.com

14 edits
2 moves in trunk

Use underlining metrics from the font file
https://bugs.webkit.org/show_bug.cgi?id=138762

Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-11-18
Reviewed by Dave Hyatt.

Source/WebCore:

Test: platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness.html

platform/graphics/FontMetrics.h: Adding variables for text decoration thickness and

underline position.
(WebCore::FontMetrics::FontMetrics):
(WebCore::FontMetrics::decorationThickness):
(WebCore::FontMetrics::setDecorationThickness):
(WebCore::FontMetrics::underlinePosition):
(WebCore::FontMetrics::setUnderlinePosition):

platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit): Initialize new FontMetrics members.

platform/graphics/ios/SimpleFontDataIOS.mm:

(WebCore::SimpleFontData::platformInit): Ditto.

platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::SimpleFontData::platformInit): Ditto.

platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformInit): Ditto.

platform/graphics/win/SimpleFontDataCairoWin.cpp:

(WebCore::SimpleFontData::platformInit): Ditto.

platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::initGDIFont): Ditto.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration): Use FontMetrics data.

style/InlineTextBoxStyle.cpp:

(WebCore::computeUnderlineOffset): Ditto.
(WebCore::visualOverflowForDecorations): Ditto.

style/InlineTextBoxStyle.h:

(WebCore::textDecorationStrokeThickness): Deleted.

svg/SVGFontData.cpp:

(WebCore::SVGFontData::initializeFontData): Initialize new FontMetrics members.

LayoutTests:

This patch makes underline placement platform-dependent.

platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html: Renamed from LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness-expected.html.
platform/mac/fast/css3-text/css3-text-decoration/text-decoration-thickness.html: Renamed from LayoutTests/fast/css3-text/css3-text-decoration/text-decoration-thickness.html.

9:54 AM Changeset in webkit [176262] by hyatt@apple.com

8 edits
2 adds in trunk

Improve Ruby selection (getting rid of overlap and improving gap filling)
https://bugs.webkit.org/show_bug.cgi?id=138250

Reviewed by Dean Jackson.

Source/WebCore:

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::blockSelectionGaps):
Add Ruby text in along with the Ruby base.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::inlineSelectionGaps):
Don't let block gaps get filled in here.

rendering/RenderRubyBase.h:

Expose accessor to the ruby run.

rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::rubyRun):

rendering/RenderRubyText.h:

Add accessor to the ruby run.

rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::selectionTop):
(WebCore::RootInlineBox::selectionBottom):
Improve selectionTop and selectionBottom of ruby bases to avoid the
ruby text. Improve the selectionTop and selectionBottom of ruby texts
to fill the gap up to the previous/next line as appropriate.

LayoutTests:

Added fast/repaint/selection-ruby-rl.html

fast/repaint/selection-ruby-rl-expected.txt: Added.
fast/repaint/selection-ruby-rl.html: Added.

9:45 AM Changeset in webkit [176261] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

crypto: Use sequence<> instead of KeyUsage[] in IDL.
https://bugs.webkit.org/show_bug.cgi?id=138823

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-18
Reviewed by Darin Adler.

Use sequence<KeyUsage> instead of KeyUsage[] in crypto IDL as per spec: https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/
Overview.html#SubtleCrypto-method-generateKey

No new tests, no behavior change.

crypto/SubtleCrypto.idl:

9:21 AM Changeset in webkit [176260] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.

Forgot to fix this test before landing.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewDefaultContext):

8:31 AM Changeset in webkit [176259] by Philippe Normand

10 edits in trunk/Source/WebCore

HRTFDatabaseLoader is not an absolute condition to run audioContext
https://bugs.webkit.org/show_bug.cgi?id=138829

Reviewed by Jer Noble.

This patch is a port of the following Blink revision by
<keonho07.kim@samsung.com>:
<https://src.chromium.org/viewvc/blink?revision=167887&view=revision>

Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::isRunnable): Deleted.

Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::hrtfDatabaseLoader): Deleted.

Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::render):

Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::offlineRender):

Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::initialize):
(WebCore::PannerNode::setPanningModel):

Modules/webaudio/PannerNode.h:
Modules/webaudio/RealtimeAnalyser.cpp:
Modules/webaudio/RealtimeAnalyser.h:
platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):

8:09 AM Changeset in webkit [176258] by commit-queue@webkit.org

29 edits
5 deletes in trunk

Unreviewed, rolling out r176218.
https://bugs.webkit.org/show_bug.cgi?id=138827

seems to have caused regressions on the perf bots (Requested
by lajava on #webkit).

Reverted changeset:

"[CSS Grid Layout] Upgrade align-self and align-items parsing
to CSS 3"
https://bugs.webkit.org/show_bug.cgi?id=133359
http://trac.webkit.org/changeset/176218

7:24 AM Changeset in webkit [176257] by mihnea@adobe.com

5 edits in trunk/LayoutTests

fast/multicol/newmulticol tests use a non-existent resource
https://bugs.webkit.org/show_bug.cgi?id=138800

Reviewed by Andrei Bucur.

Fix path in tests.

fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination-expected.html:
fast/multicol/newmulticol/compare-with-old-impl/shrink-to-column-height-for-pagination.html:
fast/multicol/newmulticol/float-multicol-expected.html:
fast/multicol/newmulticol/float-multicol.html:

6:19 AM Changeset in webkit [176256] by Carlos Garcia Campos

31 edits in trunk

[GTK] Add API to create a WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=138826

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

We have always used a default web context without providing API to
create others. The main reason was that nobody requested it and we
haven't needed it either. The main problem of the default web
context is that you can't configure anything during
construction. This hasn't been a problem so far because all the
web context configuration we expose in the API can be configured
after construction. But now we need to expose API to allow the
user to configure the local storage directory, which is a
construct only configuration. The default web context was also a
problem for our unit tests, because sharing the same context made
it difficult to ensure tests cases are independent to each other.

UIProcess/API/gtk/WebKitGeolocationProvider.cpp:

(WebKitGeolocationProvider::~WebKitGeolocationProvider): Reset the
provider to avoid crashes when web context is destroyed and a new
one is created.

UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed): Add constructed implementation to
create the WebContext and initialize it.
(webkitWebContextDispose): Detach web context clients to avoid
crashes when a client callback is called on a disposed WebKitWebContext.
(webkit_web_context_class_init): Initialize gettext, add
constructed implementation and add the pointer to the vmethods
when creating signals.
(createDefaultWebContext): Simply create a WebKitWebContext.
(webkit_web_context_new): New public method to create a WebKitWebContext.
(injectedBundleFilename): Deleted.

UIProcess/API/gtk/WebKitWebContext.h: Add virtual methods for

signals, so that users can inherit from WebKitWebContext and
override the virtual methods.

UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

Use a different WebKitWebContext for every test to ensure test
cases are independent to each other. Tests using DBus to
communicate with the injected bundle extension now use a unique
name for the well known DBus name.

TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(beforeAll): Remove comment about the order of the tests and
move the success test before the failed one now that tests don't
depend on each others.

TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(beforeAll): Remove call to set the web extensions directory,
since this is now done for all test in the Test constructor.

TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:

(beforeAll): Do not create a temporary directory, a temporary data
directory is now created for all tests.
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
to the web process test runner.
(testWebKitDOMNodeInsertion): Ditto.
(testWebKitDOMNodeTagNames): Ditto.
(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:

(runTest): Pass the web extension ID to the web process test runner.
(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:

(runTest): Pass the web extension ID to the web process test runner.
(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:

(createFileAtDestination): Use Test::dataDirectory() as base dir
for temporary files.
(beforeAll): Do not create a temporary directory.
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:

(webkitFrameTestRun): Pass the web extension ID to the web process
test runner.
(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:

(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:

(testProcessPerWebView): Use local member instead of global variable.
(testMultiprocessWebViewCreateReadyClose): Ditto.
(beforeAll): Do not connect to initialize-web-extensions, Test now
connects to the signal for all tests and calls a virtual method
that test can override.
(afterAll):
(initializeWebExtensions): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:

(testPrintOperationPrint): Use Test::dataDirectory() as base dir
for temporary files.
(beforeAll): Do not create a temporary directory.
(afterAll):

TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:

(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:

(beforeAll): Remove comment about the tests order.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(testWebExtensionGetTitle): Build the DBus service name using the
web extension ID.
(testDocumentLoadedSignal): Ditto.
(testWebKitWebViewProcessCrashed): Ditto.
(testWebExtensionIsolatedWorld): Ditto.
(beforeAll): Remove initialization-user-data test, since now all
tests are passing user data to the web extension.
(testWebExtensionInitializationUserData): Deleted.
(initializeWebExtensions): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:

(testSetDirectory): Use the web context member inherited from Test.
(testClearDatabase): Ditto.
(testGetFaviconURI): Ditto.
(beforeAll): Do not create a temporary directory.
(afterAll):
(webkitFaviconDatabaseFinalizedCallback): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:

(UserContentManagerTest::UserContentManagerTest):
(beforeAll): Remove call to set the web extensions directory.

TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextDefault): Check also that a newly create web
context is not the default web context.
(testWebContextSpellChecker): Use the web context member inherited
from Test.
(testWebContextLanguages): Ditto.

TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(methodCallCallback): Remove GetInitializationUserData method.
(webkit_web_extension_initialize_with_user_data): Always create
the DBus name using the user data provided.
(makeBusName): Deleted.

TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(webkit_web_extension_initialize_with_user_data): Create the DBus
name using the user data provided.
(webkit_web_extension_initialize): Deleted.

TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:

(Test::dataDirectory): Return the temporary data directory.
(removeNonEmptyDirectory): Also remove directories recursively.
(main): Remove the disk cache directory initialization, since this
is now done in the Test constructor.

TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:

(Test::initializeWebExtensionsCallback): Call the virtual method
initializeWebExtensions()
(Test::Test): Create a new WebKitWebContext and initialize it.
(Test::~Test): Disconnect initialize-web-extensions signal.
(Test::initializeWebExtensions): Set the web extensions directory
and user data.

TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:

(WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
(WebProcessTestRunner::runTest): Build the DBus proxy using a
unique name created with the Test web extension ID.
(WebProcessTestRunner::proxy): Deleted.

TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::WebViewTest): Create the web view with the Test web
context.

TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user

content manager parameter to the constructor.

5:53 AM WebKitGTK/2.6.x edited by Ting-Wei Lan

Add another changeset which fix gtk-doc build problem on FreeBSD (diff)

5:40 AM Changeset in webkit [176255] by ChangSeok Oh

2 edits
1 add in trunk/Tools

[GTK] Mesa build fails over llvm-3.5
https://bugs.webkit.org/show_bug.cgi?id=138825

Reviewed by Gustavo Noronha Silva.

OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.

gtk/jhbuild.modules:
gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.

4:51 AM Changeset in webkit [176254] by jdiggs@igalia.com

3 edits
2 adds in trunk

AX: [ATK] Crash getting the orientation of a MenuListOption after the MenuList was removed from the document
https://bugs.webkit.org/show_bug.cgi?id=138727

Reviewed by Chris Fleizach.

Source/WebCore:

Test: platform/gtk/accessibility/combobox-descendants-orientation-crash.html

accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::elementRect):

LayoutTests:

platform/gtk/accessibility/combobox-descendants-orientation-crash-expected.txt: Added.
platform/gtk/accessibility/combobox-descendants-orientation-crash.html: Added.

3:55 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos

(diff)

3:55 AM WebKitGTK/2.6.x edited by clopez@igalia.com

(diff)

3:54 AM WebKitGTK/2.6.x edited by clopez@igalia.com

(diff)

3:49 AM Changeset in webkit [176253] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r176252 - [SOUP] [GnuTLS] Don't use a SSL3.0 record version in client hello.
https://bugs.webkit.org/show_bug.cgi?id=138794

Reviewed by Sergio Villar Senin.

It seems that following POODLE many sites incorrectly banned SSL 3.0
record packet versions. Since GnuTLS uses a SSL 3.0 record to
advertise TLS 1.2, they are effectively banning it even if it doesn't
advertise SSL 3.0. That is a server issue, but it can be worked around
by using the modifier %LATEST_RECORD_VERSION.

With this modifier, GnuTLS will use the latest TLS version record
in client hello instead of using the default SSL 3.0.

NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

2:35 AM WebKitGTK/2.6.x edited by clopez@igalia.com

(diff)

2:32 AM WebKitGTK/2.4.x edited by clopez@igalia.com

(diff)

2:27 AM WebKitGTK/2.6.x edited by clopez@igalia.com

(diff)

2:26 AM WebKitGTK/2.4.x edited by clopez@igalia.com

(diff)

1:32 AM Changeset in webkit [176252] by clopez@igalia.com

3 edits in trunk/Source/WebKit2

[SOUP] [GnuTLS] Don't use a SSL3.0 record version in client hello.
https://bugs.webkit.org/show_bug.cgi?id=138794

Reviewed by Sergio Villar Senin.

With this modifier, GnuTLS will use the latest TLS version record
in client hello instead of using the default SSL 3.0.

NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

Nov 17, 2014:

8:50 PM Changeset in webkit [176251] by benjamin@webkit.org

2 edits in trunk/Source/WebCore

Fix a small indentation mistake in SelectorCodeGenerator::generateNthFilterTest

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-17

cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateNthFilterTest):

8:30 PM Changeset in webkit [176250] by benjamin@webkit.org

14 edits in trunk/Source/WebCore

Fix two bad function names of HTMLFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=138790

Reviewed by Andreas Kling.

Darin suggested some name improvements in https://bugs.webkit.org/show_bug.cgi?id=138769

dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::updateValidityForAllButtons):
(WebCore::RadioButtonGroup::setNeedsValidityCheckForAllButtons): Deleted.

html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):

html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::computeWillValidate):
(WebCore::HTMLButtonElement::recalcWillValidate): Deleted.

html/HTMLButtonElement.h:
html/HTMLFieldSetElement.h:
html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::requiredAttributeChanged):
(WebCore::HTMLFormControlElement::computeWillValidate):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::isValidFormControlElement):
(WebCore::HTMLFormControlElement::updateValidity):
(WebCore::HTMLFormControlElement::setCustomValidity):
(WebCore::HTMLFormControlElement::recalcWillValidate): Deleted.
(WebCore::HTMLFormControlElement::setNeedsValidityCheck): Deleted.

html/HTMLFormControlElement.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::runPostTypeUpdateTasks):
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::setValueInternal):
(WebCore::HTMLInputElement::setValueFromRenderer):
(WebCore::HTMLInputElement::computeWillValidate):
(WebCore::HTMLInputElement::parseMaxLengthAttribute):
(WebCore::HTMLInputElement::recalcWillValidate): Deleted.

html/HTMLInputElement.h:
html/HTMLKeygenElement.h:
html/HTMLOutputElement.h:
html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::deselectItems):
(WebCore::HTMLSelectElement::optionSelectedByUser):
(WebCore::HTMLSelectElement::listBoxSelectItem):
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::parseAttribute):
(WebCore::HTMLSelectElement::childrenChanged):
(WebCore::HTMLSelectElement::optionElementChildrenChanged):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::selectAll):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::parseMultipleAttribute):
(WebCore::HTMLSelectElement::reset):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::parseAttribute):
(WebCore::HTMLTextAreaElement::subtreeHasChanged):
(WebCore::HTMLTextAreaElement::setValue):
(WebCore::HTMLTextAreaElement::setNonDirtyValue):

8:13 PM Changeset in webkit [176249] by dburkart@apple.com

28 edits
1 delete in branches/safari-600.3-branch/Source

Revert r176248

7:45 PM Changeset in webkit [176248] by dburkart@apple.com

28 edits
1 copy in branches/safari-600.3-branch/Source

Merge r176164. rdar://problem/18953982

7:29 PM Changeset in webkit [176247] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176150. rdar://problem/18982046

7:23 PM Changeset in webkit [176246] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176148. rdar://problem/18990684

7:05 PM Changeset in webkit [176245] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r176145. rdar://problem/18989840

7:01 PM Changeset in webkit [176244] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge 176143. rdar://problem/18989840

6:31 PM Changeset in webkit [176243] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebCore

Merge r175492. rdar://problem/18978410

6:25 PM Changeset in webkit [176242] by dburkart@apple.com

4 edits
4 copies in branches/safari-600.3-branch

Merge r173293. rdar://problem/18978414

6:21 PM Changeset in webkit [176241] by commit-queue@webkit.org

15 edits in trunk

Add parsing for :role()
https://bugs.webkit.org/show_bug.cgi?id=138310

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2014-11-17
Reviewed by Benjamin Poulain.

Source/WebCore:

Add support for parsing :role() pseudo class. The implementation of selector
matching will be in a follow-up patch.

css/CSSGrammar.y.in:
css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

css/CSSSelector.cpp:

(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):

css/CSSSelector.h:
css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

css/SelectorPseudoClassAndCompatibilityElementMap.in:
cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

fast/css/css-selector-text-expected.txt:
fast/css/css-selector-text.html:
fast/css/css-set-selector-text-expected.txt:
fast/css/css-set-selector-text.html:
fast/selectors/invalid-functional-pseudo-class-expected.txt:
fast/selectors/invalid-functional-pseudo-class.html:

5:49 PM Changeset in webkit [176240] by Simon Fraser

2 edits in trunk/Source/WebCore

[iOS WK1] Sometimes, missing tiles in -webkit-overflow-scrolling: touch in UIWebViews
https://bugs.webkit.org/show_bug.cgi?id=138815
rdar://problem/18746203

Reviewed by Tim Horton.

The scroll-velocity-related data members on FrameView, added in r168233, were uninitialized in UIWebViews,
so FrameView::computeCoverageRect() could return garbage results, leading to too much or too little tile coverage.

We still add additional coverage from the new inclusion of a margin area, but, for simplicity, leave that the same
between WK1 and WK2 for now.

page/FrameView.cpp:

(WebCore::FrameView::FrameView):

5:14 PM Changeset in webkit [176239] by Chris Dumez

6 edits
8 adds in trunk

Add initial layout testing coverage for timer throttling
https://bugs.webkit.org/show_bug.cgi?id=138809

Reviewed by Simon Fraser.

Source/WebCore:

Add isTimerThrottled() API to Internals so that we can add layout test
coverage for timer throttling.

Tests: fast/dom/nested-timer-invisible-element-throttling.html

fast/dom/nested-timer-visible-element-throttling.html
fast/dom/repeating-timer-invisible-element-throttling.html
fast/dom/repeating-timer-visible-element-throttling.html

page/DOMTimer.h:
testing/Internals.cpp:

(WebCore::Internals::isTimerThrottled):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

Add initial layout test coverage for timer throttling. It currently
covers the following cases:

Repeating timer changes the style of an Element that is visible
Repeating timer changes the style of an Element that is not visible (i.e. "display: none").
Repeating timer doing DOM mutations
Nested timer changes the style of an Element that is visible
Nested timer changes the style of an Element that is not visible (i.e. "display: none").
Nested timer doing DOM mutations

More layout tests are coming. In particular, we should add coverage for
changing the style of an Element outside the viewport. We should also
Test that the timer gets unthrottled if necessary on scrolling / layout.

fast/dom/nested-timer-invisible-element-throttling-expected.txt: Added.
fast/dom/nested-timer-invisible-element-throttling.html: Added.
fast/dom/nested-timer-visible-element-throttling-expected.txt: Added.
fast/dom/nested-timer-visible-element-throttling.html: Added.
fast/dom/repeating-timer-invisible-element-throttling-expected.txt: Added.
fast/dom/repeating-timer-invisible-element-throttling.html: Added.
fast/dom/repeating-timer-visible-element-throttling-expected.txt: Added.
fast/dom/repeating-timer-visible-element-throttling.html: Added.

5:13 PM Changeset in webkit [176238] by Conrad Shultz

2 edits in trunk/Source/WebKit2

Page previews should be loaded sooner
https://bugs.webkit.org/show_bug.cgi?id=138814

Reviewed by Tim Horton.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController willOpenMenu:withEvent:]):
Send -_createPreviewPopover..
(-[WKActionMenuController _previewURLFromActionMenu:]):
Relocate some logic to the new -_createPreviewPopover; gate early return on popover visibility.
(-[WKActionMenuController _createPreviewPopover]):
Renamed from -_createPreviewPopoverForURL:originRect:; explicitly send -loadView to warm up the preview view.
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]): Deleted.

4:47 PM Changeset in webkit [176237] by Beth Dakin

2 edits in trunk/Source/WebKit2

Preview is sometimes dismissed too early
https://bugs.webkit.org/show_bug.cgi?id=138811
-and corresponding-
rdar://problem/18900839

Reviewed by Tim Horton.

Don’t make the popover transient until didCloseMenu: time.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _createPreviewPopoverForURL:originRect:]):

3:26 PM Changeset in webkit [176236] by bweinstein@apple.com

2 edits in trunk/Source/WebKit/mac

Remove calls to deprecated NSMenu methods
https://bugs.webkit.org/show_bug.cgi?id=138808.

Reviewed by Anders Carlsson.

-[NSMenu menuChangedMessagesEnabled] and -[NSMenu setMenuChangedMessagesEnabled:] are no-ops as of 10.6.

WebCoreSupport/PopupMenuMac.mm:

(PopupMenuMac::populate):

3:17 PM Changeset in webkit [176235] by Alan Bujtas

6 edits
2 adds in trunk/Source/WebCore

Simple line layout: Rename FlowContentIterator and move implementation to SimpleLineLayoutFlowContents.cpp
https://bugs.webkit.org/show_bug.cgi?id=138799

Reviewed by Antti Koivisto.

This is in preparation to support multiple renderers.
The FlowContents class will be used not just when we create runs, but also when we resolve them at painting time.

No change in functionality.

CMakeLists.txt:
WebCore.vcxproj/WebCore.vcxproj:
WebCore.vcxproj/WebCore.vcxproj.filters:
WebCore.xcodeproj/project.pbxproj:
rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::FlowContentIterator::FlowContentIterator): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::findNextBreakablePosition): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::findNextNonWhitespacePosition): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::textWidth): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::isNewlineCharacter): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::isEndOfContent): Deleted.
(WebCore::SimpleLineLayout::FlowContentIterator::style): Deleted.
(WebCore::SimpleLineLayout::computeLineLeft): Deleted.

rendering/SimpleLineLayoutFlowContents.cpp: Added.

rendering/SimpleLineLayoutFlowContents.h: Added.

(WebCore::SimpleLineLayout::FlowContents::Style::Style):
(WebCore::SimpleLineLayout::FlowContents::style):
(WebCore::SimpleLineLayout::FlowContents::isNewlineCharacter):
(WebCore::SimpleLineLayout::FlowContents::isEndOfContent):

2:36 PM Changeset in webkit [176234] by dbates@webkit.org

15 edits
6 deletes in trunk

Unreviewed, rolling out r176232.

Broke the Mac build. Will investigate offline.

Reverted changeset:

"[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
MobileGestalt"
https://bugs.webkit.org/show_bug.cgi?id=138802
http://trac.webkit.org/changeset/176232

2:03 PM Changeset in webkit [176233] by mark.lam@apple.com

9 edits in trunk/Source/JavaScriptCore

Add printing functionality in JITted code for debugging purposes.
<https://webkit.org/b/138660>

Reviewed by Geoffrey Garen.

Sometimes, for debugging, it'd be nice to be able to just print the
values of constants or registers used in JITted code, or even just
a string to log that certain pieces of JITted code have been executed.
Using the JIT probe mechanism, we can make this happen.

assembler/ARMv7Assembler.h:
assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::CPUState::registerName):
(JSC::AbstractMacroAssembler::CPUState::registerValue):
(JSC::AbstractMacroAssembler::print):
(JSC::AbstractMacroAssembler::PrintArg::PrintArg):
(JSC::AbstractMacroAssembler::appendPrintArg):
(JSC::AbstractMacroAssembler::printInternal):
(JSC::AbstractMacroAssembler::printCallback):

assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssemblerARM::printCPURegisters):
(JSC::MacroAssemblerARM::printRegister):

assembler/MacroAssemblerARM.h:
assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssemblerARMv7::printCPURegisters):
(JSC::MacroAssemblerARMv7::printRegister):

assembler/MacroAssemblerARMv7.h:
assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssemblerX86Common::printRegister):

assembler/MacroAssemblerX86Common.h:

1:59 PM Changeset in webkit [176232] by dbates@webkit.org

15 edits
6 copies in trunk

[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138802

Reviewed by David Kilzer.

Source/WebCore:

WebCore.xcodeproj/project.pbxproj: Add private headers MobileGestaltSPI.h and

MachVMSPI.h, and project headers DynamicLinkerSPI.h, NSPointerFunctionsSPI.h,
DispatchSPI.h and IOPMLibSPI.h. Also, sort files in Xcode project.

bindings/objc/DOMInternal.mm: Include header NSPointerFunctionsSPI.h.
bridge/objc/objc_instance.mm: Ditto; Also, sort #import directives.
platform/cocoa/DisplaySleepDisablerCocoa.cpp: Substitute header IOPMLibSPI.h

for private header IOKit/pwr_mgt/IOPMLib.h.

platform/cocoa/MemoryPressureHandlerCocoa.mm: Substitute header DispatchSPI.h

for private header dispatch/private.h.

platform/graphics/ios/FontServicesIOS.mm: Substitute header DynamicLinkerSPI.h

for private header mach-o/dyld_priv.h.

platform/ios/PlatformScreenIOS.mm: Substitute header MobileGestaltSPI.h for

private header MobileGestalt.h.

platform/spi/cocoa/DispatchSPI.h: Added.
platform/spi/cocoa/DynamicLinkerSPI.h: Added.
platform/spi/cocoa/IOPMLibSPI.h: Added.
platform/spi/cocoa/MachVMSPI.h: Added.
platform/spi/cocoa/NSPointerFunctionsSPI.h: Added.
platform/spi/ios/MobileGestaltSPI.h: Added.

Source/WebKit/mac:

Include headers DispatchSPI.h and MobileGestaltSPI.h instead of including
libdispatch and MobileGestalt headers directly.

WebView/WebView.mm:

Source/WebKit2:

Include headers DispatchSPI.h and MachVMSPI.h.h instead of including
libdispatch and Mach headers directly.

Platform/mac/SharedMemoryMac.cpp:
UIProcess/ios/WebMemoryPressureHandlerIOS.mm:

Tools:

Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.

DumpRenderTree/mac/CheckedMalloc.cpp:

1:58 PM Changeset in webkit [176231] by dburkart@apple.com

1 edit in branches/safari-600.3-branch/Source/WebCore/editing/mac/DataDetection.h

Fix build failure. rdar://problem/18877535

1:56 PM Changeset in webkit [176230] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r176132. <rdar://problem/18979004>

1:52 PM Changeset in webkit [176229] by dbates@webkit.org

10 edits
1 add in trunk/Source

[iOS] CoreText and CoreUI SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138760

Reviewed by David Kilzer.

Source/WebCore:

Add a SPI wrapper header CoreUISPI.h that forward declares CoreUI SPI
and use this header instead of including private headers of CoreUI directly.

Additionally, add more forward declarations for CoreText SPI.

WebCore.xcodeproj/project.pbxproj: Add project header CoreUISPI.h.
platform/graphics/ios/FontCacheIOS.mm: Include header CoreTextSPI.h instead

of including CoreText headers directly.

platform/graphics/mac/FontMac.mm: Include header CoreUISPI.h instead

of including CoreUI headers directly.

platform/graphics/mac/GlyphPageTreeNodeMac.cpp: Remove unnecessary

include of CoreText headers. These headers will be included by header
CoreTextSPI.h (at the top of the file).

platform/graphics/mac/SimpleFontDataMac.mm: Remove forward declaration

of CTFontDescriptorIsSystemUIFont() and include of header CTFontDescriptorPriv.h
as this duplicates the logic in CoreTextSPI.h, which is included in this file.

platform/spi/cocoa/CoreTextSPI.h: Added more forward declarations. Simplified

#include directives.

platform/spi/ios/CoreUISPI.h: Added.
rendering/RenderThemeIOS.mm: Move CoreUI externs from this file to file

CoreUISPI.h and include header CoreUISPI.h.

Source/WebKit2:

Include header CoreTextSPI.h instead of including CoreText private headers.

WebProcess/WebPage/WebPage.cpp:

1:52 PM Changeset in webkit [176228] by ap@apple.com

2 edits in trunk/LayoutTests

media/track/track-in-band-cues-added-once.html fails sometimes
https://bugs.webkit.org/show_bug.cgi?id=138806

platform/mac/TestExpectations: Marked as flaky.

1:46 PM Changeset in webkit [176227] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit2

Merge r176131. <rdar://problem/18941927>

1:43 PM Changeset in webkit [176226] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r176107. <rdar://problem/18977222>

1:32 PM Changeset in webkit [176225] by dburkart@apple.com

3 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r176099. <rdar://problem/18877520>

1:26 PM Changeset in webkit [176224] by dburkart@apple.com

2 edits in branches/safari-600.3-branch/Source/WebKit/mac

Merge r176093. <rdar://problem/18975774>

1:14 PM Changeset in webkit [176223] by Alan Bujtas

2 edits in trunk/Source/WebCore

Simple line layout: Drop 16bit support temporarily.
https://bugs.webkit.org/show_bug.cgi?id=138796

Reviewed by Antti Koivisto.

This is in preparation to multiple renderers support.
It requires code refactoring on top of the coming multiple renderers codebase.
(Not expecting any significant coverage shrinking.)

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::FlowContentIterator::findNextBreakablePosition):
(WebCore::SimpleLineLayout::FlowContentIterator::findNextNonWhitespacePosition):
(WebCore::SimpleLineLayout::FlowContentIterator::textWidth):
(WebCore::SimpleLineLayout::removeTrailingWhitespace):
(WebCore::SimpleLineLayout::initializeNewLine):
(WebCore::SimpleLineLayout::splitFragmentToFitLine):
(WebCore::SimpleLineLayout::nextFragment):
(WebCore::SimpleLineLayout::createLineRuns):
(WebCore::SimpleLineLayout::closeLineEndingAndAdjustRuns):
(WebCore::SimpleLineLayout::createTextRuns):
(WebCore::SimpleLineLayout::create):

12:59 PM Changeset in webkit [176222] by ap@apple.com

2 edits in trunk/LayoutTests

fast/multicol/newmulticol/spanner-crash.html still crashes sometimes
https://bugs.webkit.org/show_bug.cgi?id=137316

TestExpectations: Skipped it.

12:27 PM Changeset in webkit [176221] by timothy_horton@apple.com

9 edits in trunk/Source

DataDetectors PageOverlay callbacks can come in to the wrong overlay
https://bugs.webkit.org/show_bug.cgi?id=138801
<rdar://problem/18991369>

Reviewed by Anders Carlsson.

We can call dataDetectorsDidHideUI on the wrong (or no) PageOverlay,
because it's possible to have another performActionMenuHitTestAtLocation
between the first one and the dataDetectorsDid*UI that correspond to it.

To make sure that the callbacks come to the right PageOverlay, plumb
an integer ID through all of the callbacks and find the overlay based on that.

Shared/mac/ActionMenuHitTestResult.h:

Store the ID of the PageOverlay that overrode data detection.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _defaultMenuItemsForDataDetectedText]):
Send the ID back to the Web process when replying from DD callbacks.

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
Store the ID of the PageOverlay that overrode data detection instead of
keeping the PageOverlay itself.

(WebKit::WebPage::dataDetectorsDidPresentUI):
(WebKit::WebPage::dataDetectorsDidChangeUI):
(WebKit::WebPage::dataDetectorsDidHideUI):
Find and reply to the correct page overlay.

page/PageOverlay.cpp:

(WebCore::generatePageOverlayID):
(WebCore::PageOverlay::PageOverlay):

page/PageOverlay.h:

Give each PageOverlay a unique ID.

12:09 PM Changeset in webkit [176220] by Beth Dakin

9 edits in trunk/Source

Whitespace action menus should focus the HitTestResult and create an insertion
point
https://bugs.webkit.org/show_bug.cgi?id=138786
-and corresponding-
rdar://problem/18944893

Reviewed by Tim Horton.

Whitespace menus should cause the HitTestResult to be focused, and they should set
the selection based on the HitTest location.
Source/WebKit/mac:

WebView/WebActionMenuController.mm:

(-[WebActionMenuController isMenuForTextContent]):
(-[WebActionMenuController focusAndSelectHitTestResult]):
(-[WebActionMenuController willOpenMenu:withEvent:]):

Source/WebKit2:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::focusAndSelectLastActionMenuHitTestResult):

UIProcess/WebPageProxy.h:
UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController isMenuForTextContent]):
(-[WKActionMenuController willOpenMenu:withEvent:]):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:
WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
(WebKit::WebPage::focusAndSelectLastActionMenuHitTestResult):

11:58 AM Changeset in webkit [176219] by andersca@apple.com

3 edits in trunk/Source/JavaScriptCore

Fix JavaScriptCore build with newer versions of clang.
<rdar://problem/18978716>

heap/Heap.cpp:

(JSC::Heap::visitTempSortVectors):
(JSC::Heap::deleteAllCompiledCode): Deleted.

inspector/agents/InspectorConsoleAgent.h:

11:52 AM Changeset in webkit [176218] by jfernandez@igalia.com

29 edits
5 adds in trunk

[CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3
https://bugs.webkit.org/show_bug.cgi?id=133359

Reviewed by David Hyatt.

Source/WebCore:

Broaden justify-self's parsing name as a preparation of migrating
align-self, align-items and justify-items to the CSS 3 Alignment syntax.

The current naming was too tied to justify-self and needs to
be broadened. This will reduce the follow-up implementations'
patches.

Upgrade align-self and align-items parsing to CSS 3

This change migrates the 2 properties to the CSS 3 Alignment
parsing. The new parsing is identical to how we parse
'justify-self'. The 2 properties need to be migrated together
as they are used in tandem in CSSComputedStyleDeclaration.

This change also removes EAlignItems as it is now unused.

Tests: css3/parse-align-items.html

css3/parse-align-self.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties.
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::isKeywordPropertyID): Removed align-items and align-self from the list.
(WebCore::isValidKeywordPropertyAndValue): Removed align-items and align-self from the list.
(WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties.
(WebCore::isBaselinePositionKeyword): Utility function added to identify Baseline keyword values.
(WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties.
(WebCore::CSSParser::parseJustifySelf): Deleted.

css/CSSParser.h:
css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Refactoring some mapping functions.

(WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration.

(WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added.
(WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted.

css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): Added a new adjustment to resolve the "auto" vale on the alignment properties.
(WebCore::StyleResolver::adjustStyleForAlignment): Added. Function to resolve the "auto" vale on the alignment properties.
(WebCore::StyleResolver::applyProperty):
(WebCore::isDisplayFlexibleBox): Deleted. Moved to the RenderStyle.
(WebCore::isDisplayGridBox): Deleted. Moved to the RenderStyle.
(WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to the RenderStyle.

css/StyleResolver.h:
rendering/RenderBox.cpp:

(WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPosition enum.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPosition enum.
(WebCore::resolveAlignment): Consider also that align-items could be "auto", since it's the default now.
(WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPosition enum.
(WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPosition enum.

rendering/RenderFlexibleBox.h:
rendering/RenderFullScreen.cpp:

(WebCore::createFullScreenStyle): Adapted to the new ItemPosition enum.

rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPosition enum.

rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPosition enum.

rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPosition enum.
(WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPosition enum.

rendering/style/RenderStyle.h: Adapted to the new ItemPosition enum.
rendering/style/RenderStyleConstants.h: Adapted to the new ItemPosition enum.
rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPosition enum.

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPosition enum.
(WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPosition enum.

rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPosition enum.
style/StyleResolveTree.cpp:

(WebCore::Style::determineChange): Changes in the alignItems property will cause a Detach.

LayoutTests:

From Blink r164817 and r165264 by <jchaffraix@chromium.org>

Broaden justify-self's parsing name and upgrade align-self and
align-items parsing to CSS 3.

css3/flexbox/css-properties-expected.txt:
css3/flexbox/css-properties.html:
css3/parse-align-items-expected.txt: Added.
css3/parse-align-items.html: Added.
css3/parse-align-self-expected.txt: Added.
css3/parse-align-self.html: Added.
css3/resources/alignment-parsing-utils.js: Added.

(checkValues):
(checkBadValues):
(checkInitialValues):
(checkInheritValues):
(checkLegacyValues):

fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
svg/css/getComputedStyle-basic-expected.txt:
platform/gtk/TestExpectations: Report new failures and update expectations.

11:48 AM Changeset in webkit [176217] by andersca@apple.com

3 edits in trunk/Source/WTF

Fix WTF build with newer versions of clang.
<rdar://problem/18978705>

wtf/HashTable.h:

(WTF::removeIterator):

wtf/dtoa/utils.h:

(WTF::double_conversion::BitCast):

11:45 AM Changeset in webkit [176216] by dburkart@apple.com

6 edits in branches/safari-600.3-branch/Source

Merged r176156. rdar://problem/18877535

11:44 AM Changeset in webkit [176215] by dburkart@apple.com

6 edits in branches/safari-600.3-branch/Source

Merged r176153. rdar://problem/18877535

11:36 AM Changeset in webkit [176214] by dburkart@apple.com

9 edits
4 copies
2 deletes in branches/safari-600.3-branch/Source

Merged r176137. rdar://problem/18877535

11:24 AM Changeset in webkit [176213] by commit-queue@webkit.org

5 edits
2 adds in trunk

Attribute text in HTMLAnchorElement should behave as per specification.
https://bugs.webkit.org/show_bug.cgi?id=138557

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-17
Reviewed by Darin Adler.

Source/WebCore:

attribute text in HTMLAnchorElement should not be readonly as per specification
http://www.w3.org/TR/html/text-level-semantics.html#dom-a-text. It should behave as textContent attribute.
Also This matches the behavior of Chrome 38 and FireFox.

Test: fast/dom/HTMLAnchorElement/anchor-text-attribute.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::text):
(WebCore::HTMLAnchorElement::setText):

html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:

LayoutTests:

fast/dom/HTMLAnchorElement/anchor-text-attribute-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-text-attribute.html: Added.

11:23 AM Changeset in webkit [176212] by Chris Dumez

16 edits in trunk/Source/WebCore

Throttle timers that change the style of elements outside the viewport
https://bugs.webkit.org/show_bug.cgi?id=138292

Reviewed by Antti Koivisto.

Throttle timers that change the style of elements outside the viewport
to 1 second, similarly to what was already done for timers interacting
with non user observable plugins. To be conservative, we don't throttle
timers that also cause DOM Tree modifications (e.g. adding/removing
nodes, modify element attributes).

On huffingtonpost.com, the CPU usage is at ~17% when the top scrolling
banner is inside the viewport on my machine. Without this patch, CPU
usage would stay ~17% when the banner is outside the viewport. Thanks
to timer throttling, CPU usage now goes down to ~1.5%, without user
observable side effects. The timers get unthrottled when they are
inside the viewport again (i.e. due to scrolling or layout).

On espn.com, the CPU usage goes down from ~7% at the top of the page
to ~1% when scrolling to the bottom of the page. On ebay.com, CPU
usage goes down from ~25% at the top of the page to less than 1% when
scrolling to the bottom of the page.

11:06 AM Changeset in webkit [176211] by commit-queue@webkit.org

3 edits in trunk/Tools

Having 30+ flaky failures breaks EWS
https://bugs.webkit.org/show_bug.cgi?id=138743

Patch by Jake Nielsen <jacob_nielsen@apple.com> on 2014-11-17
Reviewed by Alexey Proskuryakov.

Adds tests to ensure that the problem has been solved.

Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(test_first_failure_limit):
(test_first_failure_limit_with_some_tree_redness):
(test_second_failure_limit):
(test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
(test_first_and_second_failure_limit):
(test_first_and_clean_failure_limit):
(test_first_second_and_clean_failure_limit):
(test_very_red_tree_retry): Deleted.
Really this was renamed to test_first_second_and_clean_failure_limit.

Scripts/webkitpy/tool/bot/patchanalysistask.py:

Makes the appropriate changes to PatchAnalysisTask to make sure that
even when the first test run hits the failure limit, it will still try
a second run.
(PatchAnalysisTask._results_failed_different_tests):
(PatchAnalysisTask._test_patch):
(PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.

10:58 AM Changeset in webkit [176210] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile error, CoreGraphics header file included.
https://bugs.webkit.org/show_bug.cgi?id=138795

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-11-17
Reviewed by Brent Fulgham.

CoreGraphics is not available on WinCairo.

platform/graphics/win/FontCacheWin.cpp:

10:56 AM Changeset in webkit [176209] by ap@apple.com

2 edits in trunk/LayoutTests

media/track/track-cues-sorted-before-dispatch.html is flaky on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=138798

platform/mac/TestExpectations: Marked it as such.

10:48 AM Changeset in webkit [176208] by commit-queue@webkit.org

5 edits
2 deletes in trunk

Unreviewed, rolling out r176169.
https://bugs.webkit.org/show_bug.cgi?id=138797

Appears to have broken svg/custom/anchor-on-use.svg (Requested
by ap on #webkit).

Reverted changeset:

"Attribute text in HTMLAnchorElement should behave as per
specification."
https://bugs.webkit.org/show_bug.cgi?id=138557
http://trac.webkit.org/changeset/176169

10:42 AM Changeset in webkit [176207] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Update WebKit to build with LLVM TOT
https://bugs.webkit.org/show_bug.cgi?id=138519

Patch by Juergen Ributzka <juergen@apple.com> on 2014-11-17
Reviewed by Alexey Proskuryakov.

Configurations/LLVMForJSC.xcconfig:
llvm/LLVMAPIFunctions.h:
llvm/library/LLVMExports.cpp:

(initializeAndGetJSCLLVMAPI):

10:30 AM Changeset in webkit [176206] by dbates@webkit.org

6 edits
2 adds in trunk/Source

[iOS] AVKit and MediaPlayer SPI are not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138756

Reviewed by Eric Carlson.

Source/WebCore:

Add a SPI wrapper headers {AVKit, MPAVRoutingController}SPI.h that forward declares
AVKit and MPAVRoutingController SPI, respectively, and use these header instead of
including private headers of AVKit and MediaPlayer directly.

WebCore.xcodeproj/project.pbxproj: Add project and private header AVKitSPI.h

and MPAVRoutingControllerSPI.h, respectively.

platform/audio/ios/MediaSessionManagerIOS.mm: Include header MPAVRoutingControllerSPI.h

instead of including the private header MPAVRoutingController.h.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Include header AVKitSPI.h

instead of including AVKit headers directly.

Source/WebKit2:

Include header MPAVRoutingControllerSPI.h instead of including the
private header MPAVRoutingController.h.

Additionally, sort the list of #import directives.

UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

9:56 AM Changeset in webkit [176205] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Attempt to fix the Mac build after <https://trac.webkit.org/changeset/176204>
(https://bugs.webkit.org/show_bug.cgi?id=138751)

Move declaration of CAContext to be before the declaration of CALayer since
the latter depends on the former.

platform/spi/cocoa/QuartzCoreSPI.h:

9:44 AM Changeset in webkit [176204] by dbates@webkit.org

19 edits
1 add
1 delete in trunk/Source

[iOS] QuartzCore SPI not available in public SDK
https://bugs.webkit.org/show_bug.cgi?id=138751

Reviewed by David Kilzer.

Source/WebCore:

Add a SPI wrapper header called QuartzCoreSPI.h that forward declares
QuartzCore SPI and use this header instead of including private headers
of QuartzCore directly.

WebCore.xcodeproj/project.pbxproj: Added private header QuartzCoreSPI.h.
platform/graphics/ca/mac/PlatformCAFiltersMac.h: Removed; incorporated its

functionality into QuartzCoreSPI.h.

platform/graphics/ca/mac/PlatformCAFiltersMac.mm: Substitute header

QuartzCoreSPI.h for PlatformCAFiltersMac.h as the content of the latter
was incorporated into the former.

platform/graphics/ca/mac/PlatformCALayerMac.mm: Move CALayer and CATiledLayer

forward declarations from this file to file QuartzCoreSPI.h and include
header QuartzCoreSPI.h instead of including CATiledLayerPrivate.h directly. Also
remove header PlatformCAFiltersMac.h as its content is incorporated into QuartzCoreSPI.h

platform/ios/LegacyTileCache.mm: Include headers CoreGraphicsSPI.h and QuartzCoreSPI.h

instead of including QuartzCore headers directly.

platform/ios/LegacyTileGrid.mm: Include header QuartzCoreSPI.h instead

of including QuartzCore headers directly. Also sort the list of #include directives.

platform/ios/LegacyTileGridTile.mm: Include header QuartzCoreSPI.h

instead of including QuartzCore headers directly.

platform/spi/cocoa/QuartzCoreSPI.h: Added.

Source/WebKit/mac:

Include header QuartzCoreSPI.h instead of including QuartzCore headers directly.

WebInspector/WebNodeHighlight.mm:
WebView/WebIndicateLayer.mm:

Source/WebKit2:

Shared/mac/RemoteLayerBackingStore.mm: Move CALayer forward declaration

from this file to file QuartzCoreSPI.h and include header QuartzCoreSPI.h.

Shared/mac/RemoteLayerTreePropertyApplier.mm: Ditto.
UIProcess/API/Cocoa/WKWebView.mm: Include header QuartzCoreSPI.h instead

of including QuartzCore headers directly.

UIProcess/ios/ViewGestureControllerIOS.mm: Ditto.
UIProcess/ios/WKContentView.mm: Ditto.
UIProcess/ios/WKPDFPageNumberIndicator.mm: Ditto.
UIProcess/mac/ViewGestureControllerMac.mm: Move CAFilter forward declarations

from this file to fileQuartzCoreSPI.h and include header QuartzCoreSPI.h.
Also sort the list of #import directives.

UIProcess/mac/ViewSnapshotStore.mm: Include header QuartzCoreSPI.h

instead of including QuartzCore headers directly.

9:07 AM Changeset in webkit [176203] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

App.Manifest shouldn't use App.container.lookup
https://bugs.webkit.org/show_bug.cgi?id=138768

Reviewed by Andreas Kling.

Removed the hack to find the store object via App.container.lookup.
Pass around the store object instead.

public/v2/app.js:

(App.DashboardRow._createPane): Add "store" property to the pane.
(App.DashboardPaneProxyForPicker._platformOrMetricIdChanged): Ditto.
(App.IndexController.gridChanged): Ditto.
(App.IndexController.actions.addRow): Ditto.
(App.IndexController.init): Ditto.
(App.Pane._fetch): Ditto.
(App.ChartsController._parsePaneList): Ditto.
(App.ChartsController._updateQueryString): Ditto.
(App.ChartsController.actions.addPaneByMetricAndPlatform): Ditto.
(App.BuildPopup): Ditto.
(App.AnalysisTaskRoute.model): Ditto.
(App.AnalysisTaskViewModel._taskUpdated): Ditto.

public/v2/manifest.js:

(App.Manifest.fetch): Removed the code to find the store object.

8:43 AM Changeset in webkit [176202] by Chris Dumez

5 edits in trunk/Source/WebCore

Move more CSS properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138766

Reviewed by Darin Adler.

Move more CSS properties from DeprecatedStyleBuilder to the new
StyleBuilder:
line-height
word-spacing
-webkit-marquee-repetition
-webkit-text-underline-position

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::csstoLengthConversionDataWithTextZoomFactor): Deleted.
(WebCore::ApplyPropertyMarqueeRepetition::applyValue): Deleted.
(WebCore::ApplyPropertyMarqueeRepetition::createHandler): Deleted.
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue): Deleted.
(WebCore::ApplyPropertyTextUnderlinePosition::createHandler): Deleted.
(WebCore::ApplyPropertyLineHeight::applyValue): Deleted.
(WebCore::ApplyPropertyLineHeight::createHandler): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyInitialValue): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyInheritValue): Deleted.
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::createHandler): Deleted.
(WebCore::ApplyPropertyWordSpacing::applyValue): Deleted.
(WebCore::ApplyPropertyWordSpacing::createHandler): Deleted.

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertMarqueeRepetition):
(WebCore::StyleBuilderConverter::convertTextUnderlinePosition):

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::csstoLengthConversionDataWithTextZoomFactor):
(WebCore::StyleBuilderFunctions::convertLineHeight):
(WebCore::StyleBuilderFunctions::applyValueWordSpacing):
(WebCore::StyleBuilderFunctions::applyInheritLineHeight):
(WebCore::StyleBuilderFunctions::applyInitialLineHeight):
(WebCore::StyleBuilderFunctions::applyValueLineHeight):

8:22 AM Changeset in webkit [176201] by akling@apple.com

8 edits in trunk

Avoid synchronous style recalc when mutating a Node inside FrameSelection.
<https://webkit.org/b/138791>

Reviewed by Antti Koivisto.

Source/WebCore:

We can safely clear the RenderView's selection without doing a synchronous
style recalc first.

This is a small progression on Speedometer locally.

editing/FrameSelection.cpp:

(WebCore::DragCaretController::nodeWillBeRemoved):
(WebCore::FrameSelection::respondToNodeModification):
(WebCore::clearRenderViewSelection): Deleted.

Merged clearRenderViewSelection() into the call sites and removed
the now-unnecessary protection of the Document.

LayoutTests:

Rebaseline fast/dynamic/move-node-with-selection.html.
This is a progression, we avoid littering the render tree with some empty
text renderers due to deferring the style recalc in selection clearing.

platform/efl/fast/dynamic/move-node-with-selection-expected.txt:
platform/gtk/fast/dynamic/move-node-with-selection-expected.txt:
platform/ios-sim-deprecated/fast/dynamic/move-node-with-selection-expected.txt:
platform/ios-simulator/fast/dynamic/move-node-with-selection-expected.txt:
platform/mac/fast/dynamic/move-node-with-selection-expected.txt:

6:41 AM Changeset in webkit [176200] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

[EFL] Skip timeouting editing tests
https://bugs.webkit.org/show_bug.cgi?id=138693

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-11-17
Reviewed by Csaba Osztrogonác.

platform/efl/TestExpectations:

6:07 AM Changeset in webkit [176199] by eric.carlson@apple.com

20 edits in trunk/Source

[iOS] allow host application to opt-out of alternate fullscreen
https://bugs.webkit.org/show_bug.cgi?id=138787

Reviewed by Darin Adler.

Source/WebCore:

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::optimizedFullscreenSupported): Check mediaSession().allowsAlternateFullscreen.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enterFullscreenOptimized): Do nothing if

mediaSession().allowsAlternateFullscreen says it isn't allowed.

html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::allowsAlternateFullscreen): New, check settings.

html/HTMLMediaSession.h:

page/Settings.cpp: Add allowsAlternateFullscreen.
page/Settings.in: Ditto.

Source/WebKit/mac:

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences allowsAlternateFullscreen]):
(-[WebPreferences setAllowsAlternateFullscreen:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetAllowsAlternateFullscreen):
(WKPreferencesGetAllowsAlternateFullscreen):

UIProcess/API/C/WKPreferencesRefPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.h:
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

2:48 AM Changeset in webkit [176198] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Add library search paths from LDFLAGS before pkg-config --libs
https://bugs.webkit.org/show_bug.cgi?id=136018

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-17
Reviewed by Carlos Garcia Campos.

gtk/gtkdoc.py:

(GTKDoc._run_gtkdoc_scangobj):

2:27 AM Changeset in webkit [176197] by Carlos Garcia Campos

2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Skip more tests failing after r175776.

There is no network load scheduling or prioritization with NetworkProcess.

platform/gtk/TestExpectations:

1:53 AM Changeset in webkit [176196] by evab.u-szeged@partner.samsung.com

2 edits in trunk/Tools

Bump EFL version to 1.12.0
https://bugs.webkit.org/show_bug.cgi?id=138733

Reviewed by Gyuyoung Kim.

efl/jhbuild.modules:

1:06 AM Changeset in webkit [176195] by Carlos Garcia Campos

4 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176170 - Assertion hit when setting a very large value to 'border-width' / 'font-size' CSS properties
https://bugs.webkit.org/show_bug.cgi?id=138770

Reviewed by Darin Adler.

Source/WebCore:

When setting a very large value to a CSS property, it is represented internally as
infinity. r166114 already tried to deal with this by adding an std::isinf() check
in CSSValuePool::createValue() and returning an identifier CSSPrimitiveValue with
CSSValueInvalid value in such case. The issue is that doing leads to the
StyleBuilder getting a CSSValueInvalid CSSPrimitive value as input, which is not
handled and leads to assertions.

This patch updates the CSSParser to detect cases where the double value is
infinity earlier (in CSSParser::validUnit() and parseSimpleLengthValue()), so
that we mark the value as invalid and actually drop it. As a result,
CSSPrimitiveValues with CSSValueInvalid value no longer make their way to the
StyleBuilder.

Test: fast/css/style-builder-infinite-value.html

fast/css/infinite-floating-value.html

css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::validUnit):

css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createValue):

LayoutTests:

Add a layout test setting very large values to 'border-width' and
'font-size' CSS properties.

fast/css/style-builder-infinite-value-expected.txt: Added.
fast/css/style-builder-infinite-value.html: Added.

1:05 AM Changeset in webkit [176194] by Carlos Garcia Campos

5 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176169 - Attribute text in HTMLAnchorElement should behave as per specification.
https://bugs.webkit.org/show_bug.cgi?id=138557

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-16
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLAnchorElement/anchor-text-attribute.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::text):
(WebCore::HTMLAnchorElement::setText):

html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:

LayoutTests:

fast/dom/HTMLAnchorElement/anchor-text-attribute-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-text-attribute.html: Added.

12:52 AM Changeset in webkit [176193] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r176163 - AX: [ATK] REGRESSION(r166288): Accessible values are no longer accessible via AT-SPI2
https://bugs.webkit.org/show_bug.cgi?id=138776

Reviewed by Chris Fleizach.

r166288 used #if...#else instead of #if...#endif, thus disabling the old
AtkValue support. Unfortunately AT-SPI2 doesn't yet have support for the
new AtkValue API. Thus r166288 broke access to value-holding elements for
AT-SPI2 assistive technologies. Replacing #else with #endif fixes things.

No new tests because catching this regression would require AT-SPI2.

accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetMinimumIncrement):
(webkitAccessibleValueInterfaceInit):

12:49 AM Changeset in webkit [176192] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r176154 - Network process crash when running http/tests/appcache/fallback.html
https://bugs.webkit.org/show_bug.cgi?id=138740

Reviewed by Alexey Proskuryakov.

It happens because ResourceHandle::continueWillSendRequest() is
called with a null request. We could handle that case in the
ResourceHandle, but the thing is tha the behaviour is
not the same for async loads, or when loading in the web
process. In WebResourceLoader::willSendRequest(),
ResourceRequest::willSendRequest() is called, and cancels the load
if the client returns a null request. In this case, the
ResourceLoader is detached and WebResourceLoader::willSendRequest()
returns early without sending the ContinueWillSendRequest message
to the network process. However, for synchronous loads,
NetworkResourceLoader::continueWillSendRequest() is always called.

Fixes http/tests/appcache/fallback.html for GTK port when using
the network process.

NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::continueWillSendRequest): Do not
call ResourceHandle::continueWillSendRequest() if the client
request is null, since the load is going to be cancelled.

12:46 AM Changeset in webkit [176191] by Carlos Garcia Campos

5 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176124 - Table rows repaint entire table when their background color changes.
https://bugs.webkit.org/show_bug.cgi?id=26662

Reviewed by Simon Fraser.

Added fast/repaint/table-row-repaint.html

Source/WebCore:

rendering/RenderTableCell.h:
rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::clippedOverflowRectForRepaint):
Improve table row's function to unite with the cell rects that can possibly
have the the row's background color painted behind them.

LayoutTests:

fast/repaint/table-row-repaint-expected.txt: Added.
fast/repaint/table-row-repaint.html: Added.
platform/mac/accessibility/table-detection-expected.txt:

12:39 AM Changeset in webkit [176190] by Carlos Garcia Campos

3 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r176120 - [SOUP] Use GMainLoopSource for request timeout in ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=138695

Reviewed by Sergio Villar Senin.

We are currently using soup_timeout_add() that simply creates a
GSource and attaches it to the given context. Using
GMainLoopSource we simplify the code and fix any potential problem
of converting the double value into milliseconds.

platform/network/ResourceHandleInternal.h:
platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation):
(WebCore::ResourceHandle::sendPendingRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::requestTimeoutCallback): Deleted.

12:37 AM Changeset in webkit [176189] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r176119 - [SOUP] Encode/Decode allowCookies in ResourceRequest
https://bugs.webkit.org/show_bug.cgi?id=138730

Reviewed by Sergio Villar Senin.

We are not sending this information to the network process, making
cookies always available. Fixes
http/tests/xmlhttprequest/cross-origin-no-authorization.html when
network process is enabled.

Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):

12:27 AM Changeset in webkit [176188] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.6

Merge r176096 - Policy client not called for navigations through the page cache
https://bugs.webkit.org/show_bug.cgi?id=138703

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test added to TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadDifferentDocumentItem): When using a cached page, which already
has a document loader, set the document loader’s triggering action (so that the policy
client sees that this is a back/forward navigation) and clear its last checked request (so
that the policy client gets called).

Tools:

TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:

(-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
(-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):

12:23 AM Changeset in webkit [176187] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r176151 - STRH can store values with the wrong offset
https://bugs.webkit.org/show_bug.cgi?id=138723

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-14
Reviewed by Michael Saboff.

This is the counterpart of r176083 for the str instruction.

I believe this code is currently unreachable because there is only one client of strh()
in the MacroAssembler and it always setup the scale explicitely.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::strh):

12:22 AM Changeset in webkit [176186] by Carlos Garcia Campos

4 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r176083 - ARMv7(s) Assembler: LDRH with immediate offset is loading from the wrong offset
https://bugs.webkit.org/show_bug.cgi?id=136914

Reviewed by Michael Saboff.

TLDR: the immediate offset of half-word load was divided by 2.

Story time: So I started getting those weird reports of :nth-child() behaving bizarrely
on ARMv7 and ARMv7s. To make things worse, the behavior changes depending on style updates.

I started looking the disassembly on the tests cases...

The first thing I noticed was that the computation of An+B looked wrong. For example,
in the case of n+6, the instruction should have been:

subs r1, r1, #6

but was

subs r1, r1, #2

After spending a lot of time trying to find the error in the assembler, I discovered
the problem was not real, but just a bug in the disassembler.
This is the first fix: ARMv7DOpcodeAddSubtractImmediate3's immediate3() was truncating
the value to 2 bits instead of 3 bits.

The disassembler being fixed, I still have no lead on the weird bug. Some disassembly later,
I realize the LDRH instruction is not decoded at all. The reason is that both LDRH and STRH
were under the umbrella ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord but the pattern
only matched SRTH.

I fix that next, ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord is split into
ARMv7DOpcodeStoreRegisterImmediateHalfWord and ARMv7DOpcodeLoadRegisterImmediateHalfWord,
each with their own pattern and their instruction group.

Now that I can see the LDRHs correctly, there is something fishy about them, their offset
is way too small for the data I load.

This time, looking at the binary, the generated code is indeed incorrect. It turns out that
the ARMv7 assembler shifted the offset of half-word load as if they were byte load: divided by 4.
As a result, all the load of half-words with more than zero offset were loading
values with a smaller offset than what they should have.

That being fixed, I dump the assembly: still wrong. I am ready to throw my keyboard through
my screen at that point.

Looking at the disassembler, there is yet again a bug. The computation of the scale() adjustment
of the offset was incorrect for anything but word loads.
I replaced it by a switch-case to make it explicit.

STRH is likely incorrect too. I'll fix that in a follow up, I want to survey all the 16 bits cases
that are not directly used by the CSS JIT.

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::ldrh):
Fix the immediate scaling. Add an assertion to make sure the alignment of the input is correct.

disassembler/ARMv7/ARMv7DOpcode.cpp:

(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
Fix the scaling code. Just hardcode instruction-to-scale table.

disassembler/ARMv7/ARMv7DOpcode.h:

(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
The mask for a 3 bits immediate is not 3 :)

(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale): Deleted.

12:20 AM Changeset in webkit [176185] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176082 - REGRESSION (r172826): Password field placeholder text is missing if
placeholder attribute precedes type attribute

<https://bugs.webkit.org/show_bug.cgi?id=138682>
<rdar://problem/18574213>

Source/WebCore:

When the placeholder attribute is encountered, a shadow tree is created
to include the placeholder element. When the type attribute is
encountered, the previous shadow tree is destroyed, and a new shadow
tree is created. TextFieldInputType::createShadowSubtree() did not
handle creating the placeholder element.

This regressed in r172826 because prior to r172826, the placeholder
element would be recreated when
HTMLTextFormControlElement::updatePlaceholderVisibility() was called.
In r172826, updatePlaceholderVisibility() was changed to only show or
hide the placeholder element if it exists.

Reviewed by Benjamin Poulain.

html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtree):
Call updatePlaceholderVisibility() to insert the placeholder element
(after the inner text element has been inserted, as it appears before
it in the shadow DOM).

LayoutTests:

Reviewed by Benjamin Poulain.

fast/forms/placeholder-attribute-ordering-expected.html: Added.
fast/forms/placeholder-attribute-ordering.html: Added.

12:18 AM Changeset in webkit [176184] by Carlos Garcia Campos

2 edits in releases/WebKitGTK/webkit-2.6/Source/WebKit2

Merge r176071 - [SOUP] Missing ResourceRequest members encoded/decoded
https://bugs.webkit.org/show_bug.cgi?id=138694

Reviewed by Sergio Villar Senin.

At least timeoutInterval and priority should also be
encoded/decoded. This fixes all http/tests/xmlhttprequest/timeout/
tests when using the network process, since the timeout is always
0 for all requests that we send to the network process.

Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):

Nov 16, 2014:

11:59 PM Changeset in webkit [176183] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r175965 - [Frame Flattening] ASSERT(transaction->view == &view()) fails in RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction()
https://bugs.webkit.org/show_bug.cgi?id=138615
<rdar://problem/18928487>

Reviewed by David Hyatt.

Source/WebCore:

Fixes an issue where we always expected that the RenderView associated with the RenderBlock called in
RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction() is the same as the RenderView associated with
the top transaction in the UpdateScrollInfoAfterLayoutTransaction stack regardless of frame flattening. This
expectation is only true when frame flattening is disabled.

Test: fast/frames/flattening/iframe-flattening-inside-flexbox-with-delayed-scroll-update.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removeFromUpdateScrollInfoAfterLayoutTransaction):

LayoutTests:

Add a test that causes an assertion failure in affected builds.

fast/frames/flattening/iframe-flattening-inside-flexbox-with-delayed-scroll-update-expected.txt: Added.
fast/frames/flattening/iframe-flattening-inside-flexbox-with-delayed-scroll-update.html: Added.

11:50 PM Changeset in webkit [176182] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r175809 - Crash in WebCore::Node::getFlag
https://bugs.webkit.org/show_bug.cgi?id=137961

Reviewed by Antti Koivisto.

Source/WebCore:

editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle): Null pointer check added.

LayoutTests:

editing/execCommand/crash-137961-expected.txt: Added.
editing/execCommand/crash-137961.html: Added.

11:48 PM Changeset in webkit [176181] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r175807 - ASSERTION FAILED: !object

!object->parent()->isRuby()

is<RenderRubyRun>(*object)

(object->isInline() && (object->isBeforeContent()

object->isAfterContent()))

(object->isAnonymous() && ... ) in WebCore::isAnonymousRubyInlineBlock

https://bugs.webkit.org/show_bug.cgi?id=137958

Reviewed by Chris Dumez.

Source/WebCore:

When a ruby element, with block behavior, dynamically changes its style
from multicol to without multicol, we have to remove its special children,
RenderMultiColumnFlowThread and RenderMultiColumnSet, the normal way using
the method in RenderBlockFlow base class. This patch adds both
RenderMultiColumnFlowThread and RenderMultiColumnSet to the list of RenderRuby
children removed normally and adds a new function - isRubyChildForNormalRemove -
to test the condition and use it in the assertion in RenderRuby*::removeChild
method.

Test: fast/multicol/newmulticol/ruby-from-multicol-to-auto.html

rendering/RenderRuby.cpp:

(WebCore::isRubyChildForNormalRemove):
(WebCore::RenderRubyAsInline::removeChild):
(WebCore::RenderRubyAsBlock::removeChild):

LayoutTests:

fast/multicol/newmulticol/ruby-from-multicol-to-auto-expected.txt: Added.
fast/multicol/newmulticol/ruby-from-multicol-to-auto.html: Added.

11:44 PM Changeset in webkit [176180] by zandobersek@gmail.com

12 edits in trunk/Source/WebCore

Replace RenderSVGResource::cast<T>() with downcast<T>()
https://bugs.webkit.org/show_bug.cgi?id=138290

Reviewed by Chris Dumez.

Add type traits for the RenderSVGResource hierarchy. This enables
using the typecasting framework in getRenderSVGResourceById() that
in return renders the RenderSVGResource::cast<>() template and all
the static s_resourceType member variables in the hierarchy removable.

WebCore.order:
rendering/svg/RenderSVGResource.h:

(WebCore::RenderSVGResource::cast): Deleted.

rendering/svg/RenderSVGResourceClipper.h:
rendering/svg/RenderSVGResourceContainer.h:

(WebCore::getRenderSVGResourceById):

rendering/svg/RenderSVGResourceFilter.h:

(isType):

rendering/svg/RenderSVGResourceLinearGradient.h:
rendering/svg/RenderSVGResourceMarker.h:
rendering/svg/RenderSVGResourceMasker.h:
rendering/svg/RenderSVGResourcePattern.h:
rendering/svg/RenderSVGResourceRadialGradient.h:
rendering/svg/RenderSVGResourceSolidColor.h:

11:43 PM Changeset in webkit [176179] by Carlos Garcia Campos

3 edits
2 adds
1 delete in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r176080 - Web Inspector: Replace PDF Probes icon with SVG version
https://bugs.webkit.org/show_bug.cgi?id=137296

Reviewed by Joseph Pecoraro.

UserInterface/Images/NavigationItemProbes.pdf: Removed.
UserInterface/Images/NavigationItemProbes.svg: Added.
UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel): Use NavigationItemProbes.svg.

UserInterface/Images/gtk/NavigationItemProbes.svg: Added.

11:40 PM Changeset in webkit [176178] by Carlos Garcia Campos

5 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176091 - AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
https://bugs.webkit.org/show_bug.cgi?id=137867

Reviewed by Chris Fleizach.

Source/WebCore:

Return ATK_ROLE_INVALID for null or otherwise invalid accessible objects.

Test: platform/gtk/accessibility/detached-object-role.html

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetRole):

Tools:

Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
able to test for the presence of ATK_ROLE_INVALID.

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::role):

LayoutTests:

platform/gtk/accessibility/detached-object-role-expected.txt: Added.
platform/gtk/accessibility/detached-object-role.html: Added.

11:35 PM Changeset in webkit [176177] by Carlos Garcia Campos

3 edits
2 adds in releases/WebKitGTK/webkit-2.6

Merge r176076 - AX: [ATK] Accessible focus events are emitted when the selection is changed in non-focused combo boxes
https://bugs.webkit.org/show_bug.cgi?id=137866

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Check that the AccessibilityMenuList is really focused before notifying
the platform that it is focused. Likewise, only notify the platform of
an AccessibilityMenuListOption focus gain if the AccessibilityMenuList
containing that option is expanded.

Test: platform/gtk/accessibility/menu-list-unfocused-notifications.html

accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

platform/gtk/accessibility/menu-list-unfocused-notifications-expected.txt: Added.
platform/gtk/accessibility/menu-list-unfocused-notifications.html: Added.

11:31 PM Changeset in webkit [176176] by Carlos Garcia Campos

5 edits in releases/WebKitGTK/webkit-2.6

Merge r175724 - slow_path_get_direct_pname() needs to be hardened against a constant baseValue.
<https://webkit.org/b/138476>

Reviewed by Michael Saboff.

Source/JavaScriptCore:

slow_path_get_direct_pname() currently assumes that the baseValue is always a
non-constant virtual register. However, this is not always the case like in the
following:

function foo() {

var o = { a:1 };
for (var n in o)

0[n];

}
foo();

This patch fixes it to also check for constant virtual register indexes.

runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

LayoutTests:

js/get-by-pname-expected.txt:
js/script-tests/get-by-pname.js:

(getByPnameOnConstant):
(getByPnameOnVar):

Added more test cases.

11:03 PM Changeset in webkit [176175] by benjamin@webkit.org

3 edits in trunk/Source/WebKit2

Start cleaning up minimal UI from WKWebView
https://bugs.webkit.org/show_bug.cgi?id=138725

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-11-16
Reviewed by Sam Weinig.

Start removing the old update path for minimumLayoutSize/maximumUnobscuredSize.

Unfortunately, I cannot remove everything yet because the clients still did not have
alternatives to [_overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride]
and might change the minimal UI options.

This patch adds [_overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride] to move
in the right direction. Next we'll udpate the client code and get rid of all the useless code.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:minimumLayoutSizeForMinimalUI:maximumUnobscuredSizeOverride:]):
(-[WKWebView _overrideLayoutParametersWithMinimumLayoutSize:maximumUnobscuredSizeOverride:]):
(-[WKWebView _minimumLayoutSizeOverrideForMinimalUI]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:

11:01 PM Changeset in webkit [176174] by benjamin@webkit.org

18 edits
32 adds in trunk

Implement :valid and :invalid matching for the fieldset element
https://bugs.webkit.org/show_bug.cgi?id=138769

Reviewed by Darin Adler.

Source/WebCore:

In the latest HTML spec, the pseudo classes :valid and :invalid match
a fieldset element based on its descendants:

https://html.spec.whatwg.org/#selector-valid
https://html.spec.whatwg.org/#selector-invalid

This patch adds that behavior.

There are two key problems to solve with these pseudo classes on fieldset:
-Efficient matching.
-Style invalidation when any of the descendant changes.

To implement the style invalidation, I have modified HTMLFormControlElement
to notify its ancestor when its state changes.

The first change is making the state fully internal to HTMLFormControlElement,
we do not want subclass to be able to change the behavior and forget to update
the ancestors.

To achieve that encapsulation, the interface was changed a bit:
-Neither willValidate() nor isValidFormControlElement() inherit from Element.

Instead, willValidate() is the implementation of FormAssociatedElement's interface
and it is final. The method isValidFormControlElement() becomes completely internal
to HTMLFormControlElement.

-Since willValidate() should no longer be re-implemented by subclass, the elements

that were depending on it have been migrated to recalcWillValidate() to set
the initial state as needed.

With the validity state fully encapsulated in HTMLFormControlElement, all I need
is a way to communicate that information to HTMLFieldSetElement ancestors.
This is done in two cases:
-The validity state changes.
-The tree changes in a way that would make the input element not a descendant

of a HTMLFieldSetElement.

The invalidation is simply done by walking up the ancestors and adding the current
element to a "validity dependency list" on each HTMLFieldSetElement.

Tests: fast/css/pseudo-invalid-fieldset-invalidation-optimization.html

fast/css/pseudo-invalid-fieldset-style-sharing.html
fast/css/pseudo-invalid-fieldset.html
fast/css/pseudo-valid-fieldset-invalidation-optimization.html
fast/css/pseudo-valid-fieldset-style-sharing.html
fast/css/pseudo-valid-fieldset.html
fast/selectors/invalid-fieldset-style-update-1.html
fast/selectors/invalid-fieldset-style-update-2.html
fast/selectors/invalid-fieldset-style-update-3.html
fast/selectors/invalid-fieldset-style-update-4.html
fast/selectors/invalid-fieldset-style-update-5.html
fast/selectors/valid-fieldset-style-update-1.html
fast/selectors/valid-fieldset-style-update-2.html
fast/selectors/valid-fieldset-style-update-3.html
fast/selectors/valid-fieldset-style-update-4.html
fast/selectors/valid-fieldset-style-update-5.html

css/SelectorCheckerTestFunctions.h:

(WebCore::isInRange):
(WebCore::isOutOfRange):
(WebCore::isInvalid):
(WebCore::isValid):
The hack "ContainsValidityStyleRules" is in the way of correct styling
of FieldSet and Form.
It is not the right way to get stylesheet properties anyway.

css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):
Make sure style sharing does not incorrectly share style for fieldset elements.

dom/Document.cpp:

(WebCore::Document::Document):

dom/Document.h:

(WebCore::Document::containsValidityStyleRules): Deleted.
(WebCore::Document::setContainsValidityStyleRules): Deleted.

dom/Element.h:

(WebCore::Element::matchesValidPseudoClass):
(WebCore::Element::matchesInvalidPseudoClass):
(WebCore::Element::willValidate): Deleted.
(WebCore::Element::isValidFormControlElement): Deleted.

html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::customError):

html/FormAssociatedElement.h:

html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::matchesValidPseudoClass):
(WebCore::HTMLFieldSetElement::matchesInvalidPseudoClass):
(WebCore::HTMLFieldSetElement::addInvalidDescendant):
(WebCore::HTMLFieldSetElement::removeInvalidDescendant):
Each HTMLFormControlElement that has constraint validation adds or removes
itself from its HTMLFieldSetElement ancestors.

It should be possible to just keep track of a count instead of a HashSet.
I decided to got with the HashSet to make the code more robust and easier
to debug. A few assertions ensure that the HashSet is actually used as a counter.

html/HTMLFieldSetElement.h:
html/HTMLFormControlElement.cpp:

(WebCore::addInvalidElementToAncestorFromInsertionPoint):
(WebCore::removeInvalidElementToAncestorFromInsertionPoint):

(WebCore::HTMLFormControlElement::insertedInto):
(WebCore::HTMLFormControlElement::removedFrom):
One tricky part of those two functions is that we cannot use
matchesValidPseudoClass() or matchesInvalidPseudoClass().

The reason is that HTMLFieldSetElement is a subclass of HTMLFormControlElement
and it has its own definition of what Valid and Invalid mean when matching selectors.

In HTMLFormControlElement, we must use the internal state,
willValidate() and isValidFormControlElement() must be used directly.

(WebCore::HTMLFormControlElement::matchesValidPseudoClass):
(WebCore::HTMLFormControlElement::matchesInvalidPseudoClass):
(WebCore::HTMLFormControlElement::willValidate):
(WebCore::addInvalidElementToAncestors):
(WebCore::removeInvalidElementFromAncestors):
(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
(WebCore::HTMLFormControlElement::setNeedsValidityCheck):
(WebCore::HTMLFormControlElement::isValidFormControlElement): Deleted.

html/HTMLFormControlElement.h:

(WebCore::HTMLFormControlElement::isValidFormControlElement):

html/HTMLKeygenElement.h:
html/HTMLObjectElement.h:
html/HTMLOutputElement.h:

LayoutTests:

There are many ways to change the validation state of a submittable element.
I included a series of test trying to exercises as many combination
as possible.

fast/css/pseudo-valid-unapplied-expected.txt:
fast/css/pseudo-valid-unapplied.html:

This test was checking that :valid and :invalid are not applied
to fieldset. Such results are incorrect with the latest specification.

fast/css/pseudo-invalid-fieldset-expected.html: Added.
fast/css/pseudo-invalid-fieldset-invalidation-optimization-expected.txt: Added.
fast/css/pseudo-invalid-fieldset-invalidation-optimization.html: Added.
fast/css/pseudo-invalid-fieldset-style-sharing-expected.html: Added.
fast/css/pseudo-invalid-fieldset-style-sharing.html: Added.
fast/css/pseudo-invalid-fieldset.html: Added.
fast/css/pseudo-valid-fieldset-expected.html: Added.
fast/css/pseudo-valid-fieldset-invalidation-optimization-expected.txt: Added.
fast/css/pseudo-valid-fieldset-invalidation-optimization.html: Added.
fast/css/pseudo-valid-fieldset-style-sharing-expected.html: Added.
fast/css/pseudo-valid-fieldset-style-sharing.html: Added.
fast/css/pseudo-valid-fieldset.html: Added.
fast/selectors/invalid-fieldset-style-update-1-expected.txt: Added.
fast/selectors/invalid-fieldset-style-update-1.html: Added.
fast/selectors/invalid-fieldset-style-update-2-expected.txt: Added.
fast/selectors/invalid-fieldset-style-update-2.html: Added.
fast/selectors/invalid-fieldset-style-update-3-expected.txt: Added.
fast/selectors/invalid-fieldset-style-update-3.html: Added.
fast/selectors/invalid-fieldset-style-update-4-expected.txt: Added.
fast/selectors/invalid-fieldset-style-update-4.html: Added.
fast/selectors/invalid-fieldset-style-update-5-expected.txt: Added.
fast/selectors/invalid-fieldset-style-update-5.html: Added.
fast/selectors/valid-fieldset-style-update-1-expected.txt: Added.
fast/selectors/valid-fieldset-style-update-1.html: Added.
fast/selectors/valid-fieldset-style-update-2-expected.txt: Added.
fast/selectors/valid-fieldset-style-update-2.html: Added.
fast/selectors/valid-fieldset-style-update-3-expected.txt: Added.
fast/selectors/valid-fieldset-style-update-3.html: Added.
fast/selectors/valid-fieldset-style-update-4-expected.txt: Added.
fast/selectors/valid-fieldset-style-update-4.html: Added.
fast/selectors/valid-fieldset-style-update-5-expected.txt: Added.
fast/selectors/valid-fieldset-style-update-5.html: Added.

10:49 PM Changeset in webkit [176173] by zandobersek@gmail.com

8 edits in trunk/Source

[TexMap] Add typecasting support for GraphicsLayerTextureMapper
https://bugs.webkit.org/show_bug.cgi?id=138741

Reviewed by Martin Robinson.

Source/WebCore:

Add type traits for the GraphicsLayerTextureMapper class.
This enables using typecasting functions instead of
toGraphicsLayerTextureMapper().

Remove toTextureMapperLayer() casting function which actually
returned the TextureMapperLayer object that belonged to the
passed-in GraphicsLayerTextureMapper. Instead, the GraphicsLayer
object is now downcasted and the TextureMapperLayer is accessed
by calling the GraphicsLayerTextureMapper::layer() method.

platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::isGraphicsLayerTextureMapper):

platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::toTextureMapperLayerVector):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::toTextureMapperLayer): Deleted.

platform/graphics/texmap/GraphicsLayerTextureMapper.h:

(WebCore::toGraphicsLayerTextureMapper): Deleted.

Source/WebKit/win:

Switch to using downcast<GraphicsLayerTextureMapper>() and replace
uses of toTextureMapperLayer() with downcasting and calling
the GraphicsLayerTextureMapper::layer() method.

WebCoreSupport/AcceleratedCompositingContext.cpp:

(AcceleratedCompositingContext::initialize):
(AcceleratedCompositingContext::startedAnimation):
(AcceleratedCompositingContext::compositeLayersToContext):

Source/WebKit2:

Replace uses of toTextureMapperLayer() with downcasting and
calling the GraphicsLayerTextureMapper::layer() method.

WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::layerFlushTimerFired):
(WebKit::LayerTreeHostGtk::compositeLayersToContext):

10:46 PM Changeset in webkit [176172] by gyuyoung.kim@samsung.com

14 edits in trunk/Source/WebCore

Move WebCore/loader to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=138646

Reviewed by Chris Dumez.

Replace OwnPtr with std::unique_ptr<> and std::make_unique<>.
However this patch leaves ResourceRequest::adopt() because this need
to be handled by different patch.

No new tests, no behavior changes.

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::preflightSuccess):

loader/DocumentThreadableLoader.h:
loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::notifyDone):

loader/SubresourceLoader.h:
loader/TextTrackLoader.h:
loader/appcache/ApplicationCacheHost.h:
loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::storeCopyOfCache):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestPreload):
(WebCore::CachedResourceLoader::clearPreloads):
(WebCore::CachedResourceLoader::printPreloadStats):

loader/cache/CachedResourceLoader.h:
loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::deleteAllPreparedStatements):
(WebCore::readySQLiteStatement):

loader/icon/IconDatabase.h:
loader/icon/IconRecord.h:

9:41 PM Changeset in webkit [176171] by Chris Dumez

3 edits
2 adds in trunk

Crash when setting 'order' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138780

Reviewed by Darin Adler.

Source/WebCore:

CSS Calculated values were not handled by the CSS parser for 'order'
CSS property. As a result, using calculated values wouldn't work in
release builds and would hit an assertion in debug builds.

This patch updates the CSS parser to directly convert the
CSS Calculated value into a simple integer CSSPrimitiveValue for
'order' property. We could have marked CSS Calculated values as
valid in the CSS Parser instead but this would have brought issues:

The calculated value needs to be adjusted to INT_MIN + 2 if it is less than that. This would force us to calculate the expression anyway.
The StyleBuilder would need updating to properly handle CSS Calculated values for 'order'.

Test: fast/css/order-calculated-value.html

css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

LayoutTests:

Add a layout test to validate that setting a calculated value to the
'order' CSS property does not crash and behaves as expected.

fast/css/order-calculated-value-expected.txt: Added.
fast/css/order-calculated-value.html: Added.

9:38 PM Changeset in webkit [176170] by Chris Dumez

4 edits
2 adds in trunk

Assertion hit when setting a very large value to 'border-width' / 'font-size' CSS properties
https://bugs.webkit.org/show_bug.cgi?id=138770

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/style-builder-infinite-value.html

fast/css/infinite-floating-value.html

css/CSSParser.cpp:

(WebCore::parseSimpleLengthValue):
(WebCore::CSSParser::validUnit):

css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createValue):

LayoutTests:

Add a layout test setting very large values to 'border-width' and
'font-size' CSS properties.

fast/css/style-builder-infinite-value-expected.txt: Added.
fast/css/style-builder-infinite-value.html: Added.

9:14 PM Changeset in webkit [176169] by commit-queue@webkit.org

5 edits
2 adds in trunk

Attribute text in HTMLAnchorElement should behave as per specification.
https://bugs.webkit.org/show_bug.cgi?id=138557

Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-11-16
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/dom/HTMLAnchorElement/anchor-text-attribute.html

html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::text):
(WebCore::HTMLAnchorElement::setText):

html/HTMLAnchorElement.h:
html/HTMLAnchorElement.idl:

LayoutTests:

fast/dom/HTMLAnchorElement/anchor-text-attribute-expected.txt: Added.
fast/dom/HTMLAnchorElement/anchor-text-attribute.html: Added.

8:35 PM Changeset in webkit [176168] by Chris Dumez

4 edits in trunk/Source/WebCore

Move 'vertical-align' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=138764

Reviewed by Darin Adler.

Move 'vertical-align' CSS property from DeprecatedStyleBuilder to the
new StyleBuilder by using custom code.

No new tests, no behavior change.

css/CSSPropertyNames.in:
css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
(WebCore::ApplyPropertyVerticalAlign::applyValue): Deleted.
(WebCore::ApplyPropertyVerticalAlign::createHandler): Deleted.

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyValueVerticalAlign):

7:27 PM Changeset in webkit [176167] by ap@apple.com

2 edits in trunk/LayoutTests

Test expectation gardening.

platform/mac/TestExpectations:

5:57 PM Changeset in webkit [176166] by timothy_horton@apple.com

5 edits in trunk/Source

Use TextIndicator instead of the built in Lookup highlight
https://bugs.webkit.org/show_bug.cgi?id=138775
<rdar://problem/18953982>

Follow-up to r176164.

UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView initWithFrame:context:configuration:webView:]):

UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):
Include the softlinking macros directly in the files they're used
in, as they're supposed to be used.

platform/spi/mac/LookupSPI.h:

(WebCore::canDisableLookupIndicator): Deleted.
Remove canDisableLookupIndicator.

5:18 PM Changeset in webkit [176165] by Chris Dumez

3 edits
2 adds in trunk

Crash when setting '-webkit-line-clamp' CSS property to a calculated value
https://bugs.webkit.org/show_bug.cgi?id=138777

Reviewed by Benjamin Poulain.

Source/WebCore:

CSS Calculated values were not handled when converting a CSSPrimitiveValue
to a LineClampValue. As a result, we would hit an ASSERT_NOT_REACHED()
assertion. To address this issue, this patch updates the code to use
primitiveType() / getValue<>() instead of m_primitiveUnitType /
m_value.num, as those getter function properly handle CSS Calculated
values.

Test: fast/css/webkit-line-clamp-calculated-value.html

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator LineClampValue):

LayoutTests:

Add a layout test to check that assigning calculated values to the
'-webkit-line-clamp' CSS property does not crash and behaves as
expected.

fast/css/webkit-line-clamp-calculated-value-expected.txt: Added.
fast/css/webkit-line-clamp-calculated-value.html: Added.

12:41 PM Changeset in webkit [176164] by timothy_horton@apple.com

28 edits
1 add in trunk/Source

Use TextIndicator instead of the built in Lookup highlight
https://bugs.webkit.org/show_bug.cgi?id=138775
<rdar://problem/18953982>

Reviewed by Anders Carlsson.

In order to make the yellow highlight for Lookup more accurately match the
painted content of the web page (in light of e.g. Web fonts, and interesting
text features that only WebKit implements and cannot round-trip through
NSAttributedString), use a TextIndicator instead of the built-in Lookup
highlight where possible.

Configurations/BaseTarget.xcconfig:

Make it possible to include headers from private frameworks. This matches WebCore.

Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):

Shared/DictionaryPopupInfo.h:

Include the attributed string inside the DictionaryPopupInfo, instead of
as a secondary argument to DidPerformDictionaryLookup.
Add a TextIndicator to DictionaryPopupInfo, which can be used to highlight
the text in the UI process.

UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _dictionaryLookupPopoverWillClose:]):
(-[WKView _setTextIndicator:fadeOut:animate:animationCompletionHandler:]):
(-[WKView _setTextIndicator:fadeOut:animate:]):
(-[WKView initWithFrame:context:configuration:webView:]):
(+[WKView hideWordDefinitionWindow]):

UIProcess/API/mac/WKViewInternal.h:

Adopt the Lookup SPI header.
If we have the requisite API, register the notification that Lookup sends
when the popover closes, and hook that up to hide the text indicator.
Add a version of _setTextIndicator: that takes an animation completion handler.

UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didPerformDictionaryLookup):

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::didPerformDictionaryLookup):
Adjust to the new didPerformDictionaryLookup signature.

WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Remove a WKSI import.

UIProcess/mac/PageClientImpl.h:
UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):
If we have the requisite API, disable Lookup's built-in highlight and
present a TextIndicator instead.
We currently have to run the animations serially (first bounce the TextIndicator,
then animate in the Lookup popover) because the act of adding the Lookup popover
blocks us from getting any animation events for the TextIndicator, and breaks
the bounce. We could also fix this by using a threaded animation for the TextIndicator,
but it's not clear that it's safe to do so.

(WebKit::PageClientImpl::dismissDictionaryLookupPanel):
When explicitly dismissing the Lookup panel, also hide the text indicator.

UIProcess/mac/TextIndicatorWindow.h:
UIProcess/mac/TextIndicatorWindow.mm:

(WebKit::TextIndicatorWindow::setTextIndicator):
Store the completion handler.

(WebKit::TextIndicatorWindow::bounceAnimationDidEnd):
Call the completion handler when the animation completes.

UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController _createActionMenuItemForTag:]):
Disable the Lookup item if lookup is not available.

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::showDefinitionForAttributedString):
Adjust to the new didPerformDictionaryLookup signature.
Since PDFPlugin can't trivially repaint the required part of the PDF,
we don't build a TextIndicator. This will result in PDFPlugin continuing
to use Lookup's built-in highlight.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):
Build a TextIndicator from the Lookup range and pass it along with
the DictionaryPopupInfo.

WebCore.exp.in:
platform/mac/WebCoreSystemInterface.h:
platform/mac/WebCoreSystemInterface.mm:

Remove a WKSI import/export that we don't need anymore.

platform/spi/mac/LookupSPI.h: Added.

(WebCore::canDisableLookupIndicator):
Add Lookup SPI header.
Add a 'canDisableLookupIndicator', which must be called in any translation
unit that wants to use either of the soft-linked constants related to
that functionality, before calling the get* function.

WebCore.xcodeproj/project.pbxproj:
editing/mac/DictionaryLookup.mm:

(WebCore::rangeForDictionaryLookupForSelection):
(WebCore::rangeForDictionaryLookupAtHitTestResult):
Adopt the Lookup SPI header.

WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):
Remove a WKSI import.

WebView/WebActionMenuController.mm:

(-[WebActionMenuController _lookupText:]):
(-[WebActionMenuController _createActionMenuItemForTag:]):
Make use of the new Lookup SPI header.
Disable the Lookup item if lookup is not available.

9:13 AM Changeset in webkit [176163] by jdiggs@igalia.com

2 edits in trunk/Source/WebCore

AX: [ATK] REGRESSION(r166288): Accessible values are no longer accessible via AT-SPI2
https://bugs.webkit.org/show_bug.cgi?id=138776

Reviewed by Chris Fleizach.

No new tests because catching this regression would require AT-SPI2.

accessibility/atk/WebKitAccessibleInterfaceValue.cpp:

(webkitAccessibleValueGetMinimumIncrement):
(webkitAccessibleValueInterfaceInit):

8:51 AM Changeset in webkit [176162] by jdiggs@igalia.com

12 edits in trunk

AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
https://bugs.webkit.org/show_bug.cgi?id=138771

Reviewed by Chris Fleizach.

Source/WebCore:

Add BlockquoteRole and assigns it to blockquote elements. Make
corresponding changes to platform role mappings: ATK_ROLE_BLOCK_QUOTE
for GTK and EFL; AXGroup (which was being used already) for the Mac.

No new tests are required. Instead, updated the existing expectations
to reflect the new mapping.

accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):

accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isBlockquote):

accessibility/AccessibilityObject.h:
accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole):

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):

Tools:

Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()

WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Updated the expectations for GTK and EFL as there is a new role
being used. The Mac expectations were not updated because the
new role on that platform continues to be to AXGroup.

platform/efl/accessibility/roles-exposed-expected.txt: Updated
platform/gtk/accessibility/roles-exposed-expected.txt: Updated

7:54 AM Changeset in webkit [176161] by Chris Dumez

3 edits
2 adds in trunk

Crash when setting 'alt' CSS property to inherit or initial
https://bugs.webkit.org/show_bug.cgi?id=138774
<rdar://problem/18995409>

Reviewed by Chris Fleizach.

Source/WebCore:

The StyleResolver was not handling 'inherit' or 'initial' values for
'alt' CSS property. As a result, the code was assuming the CSSValue
was a CSSPrimitiveValue (although it could be a CSSInitialValue or
a CSSInheritValue). In such case, the code would dereference a null
pointer because primitiveValue is initialized using:
CSSPrimitiveValue* primitiveValue = is<CSSPrimitiveValue>(*value)

? downcast<CSSPrimitiveValue>(value)
: nullptr;

Test: fast/css/alt-inherit-initial.html

css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

LayoutTests:

Add a layout test to verify that setting the 'alt' CSS property to
inherit / initial is not crashing and working as intended.

fast/css/alt-inherit-initial-expected.txt: Added.
fast/css/alt-inherit-initial.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed