Timeline
Jan 4, 2015:
- 9:11 PM Changeset in webkit [177884] by
-
- 2 edits in trunk/Source/WebCore
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseXML):
Removed an incorrect assertion my last check-in added.
- 6:24 PM Changeset in webkit [177883] by
-
- 9 edits in trunk/Source/WebCore
Modernize and tighten up HTMLDocumentParser
https://bugs.webkit.org/show_bug.cgi?id=140041
Reviewed by Sam Weinig.
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::parseHTML): Pass a reference instead of
a pointer for the context element.
- html/FTPDirectoryDocument.cpp: Removed unneeded includes, made more
things in FTPDirectoryDocumentParser private. Use Ref instead of RefPtr
in a could places. Initialize in class instead of in constructor.
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
Less initialization here.
(WebCore::FTPDirectoryDocumentParser::createTDForFilename): More Ref here.
(WebCore::createTemplateDocumentData): Removed unneeded initialization
of RefPtr, which is initialized without explicitly asking for it.
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate): Reworded
comment slightly.
- html/parser/HTMLDocumentParser.cpp: Cut down on includes.
(WebCore::tokenizerStateForContextElement): Fixed URL. Changed argument
to be a reference rather than a pointer.
(WebCore::HTMLDocumentParser::inPumpSession):
(WebCore::HTMLDocumentParser::shouldDelayEnd):
(WebCore::HTMLDocumentParser::HTMLDocumentParser): Marked constructors
inline. Updated for data members that are now objects instead of pointers.
Removed explicit initialization for scalars that are now initialized in
the class definition.
(WebCore::HTMLDocumentParser::create): Moved the private creation
functions in here, out of the header file.
(WebCore::HTMLDocumentParser::~HTMLDocumentParser): Removed unused
m_haveBackgroundParser.
(WebCore::HTMLDocumentParser::prepareToStopParsing): Updated URL and
removed m_haveBackgroundParser reference.
(WebCore::HTMLDocumentParser::processingData): Removed a check of
m_haveBackgroundParser.
(WebCore::HTMLDocumentParser::resumeParsingAfterYield): Tweak comment.
(WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder): Added
a null check of the result of takeScriptToProcess, since there really
is no guarantee it's non-null.
(WebCore::HTMLDocumentParser::canTakeNextToken): Removed assertion
that was for m_haveBackgroundParser cases only. Rewrapped comment.
(WebCore::HTMLDocumentParser::contextForParsingSession): Use nullptr.
(WebCore::HTMLDocumentParser::pumpTokenizer): Rework comments,
remove assertions that no longer make sense, use auto instead of
repeating a long type name, update to use m_token and m_tokenizer.
(WebCore::HTMLDocumentParser::hasInsertionPoint): Rewrapped comment.
(WebCore::HTMLDocumentParser::insert): Got rid of braces around a
single-line if body.
(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd):
Removed comment about incorrect m_haveBackgroundParser assertion.
(WebCore::HTMLDocumentParser::isExecutingScript): Use && style instead
of early exit for a null check.
(WebCore::HTMLDocumentParser::textPosition): Tightened up code a little.
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution): Added
a Ref to protect the parser, as is already done in every other function
that calls pumpTokenizerIfPossible.
(WebCore::HTMLDocumentParser::parseDocumentFragment): Take a reference
instead of a pointer. Also use auto so we get a Ref instead of a RefPtr.
- html/parser/HTMLDocumentParser.h: Removed unneeded includes.
Made private inheritance explicit instead of just omitting public.
Moved function bodies out of the class, and in some cases, out of the
header entirely. Return a reference from tokenizer(). Marked most
virtual functions final. Made DocumentFragment version of the
constructor private rather than protected. Made the functions
suspendScheduledTasks() and resumeScheduledTasks() private, since
they are always called through a base class. Removed the private
token function since it is better to get at m_token directly.
Removed m_haveBackgroundParser, since we don't have that any more
and it's always false. Also removed forcePlaintextForTextDocument
since the tokenizer is exposed and can be used directly to do that.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Made the parser non-const.
It could only be const before because HTMLDocumentParser::tokenizer
took a const parser and returned a non-const tokenizer, but that doesn't
really make sense.
(WebCore::HTMLTreeBuilder::constructTree): Removed null check for
tokenizer, which was never null. Updated since tokenizer is a reference.
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processEndTag): Ditto. Also fixed and removed
some assertions like the ones I did recently in the rest of this file.
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processScriptStartTag): Ditto.
- html/parser/HTMLTreeBuilder.h: Made HTMLDocumentParser& non-const.
- html/parser/TextDocumentParser.cpp: Removed unneeded include and
unneeded explicit destructor.
(WebCore::TextDocumentParser::TextDocumentParser): Updated since
treeBuilder() returns a reference now, and set the tokenizer state
directly since tokenizer() is exposed.
- html/parser/TextDocumentParser.h: Moved initialization of the
data member here instead of the constructor. Also removed unneeded
explicitly defined destructor.
- 5:08 PM Changeset in webkit [177882] by
-
- 2 edits in trunk/LayoutTests
fast/events/autoscroll-should-not-stop-on-keypress.html is flaky in debug builds
https://bugs.webkit.org/show_bug.cgi?id=140060
Reviewed by Darin Adler.
- fast/events/autoscroll-should-not-stop-on-keypress.html: Instead of waiting a
fixed amount of time, check if the test succeeded every 100ms. In addition to making
the test more reliable on slow builds, it makes the test faster in release mode.
- 4:46 PM Changeset in webkit [177881] by
-
- 2 edits in trunk/Source/WebCore
Remove GlyphPageTree
https://bugs.webkit.org/show_bug.cgi?id=140015
Follow-up to follow-up, fonts/font-fallback-prefers-pictographs.html is now failing.
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForNormalVariant):
Make the loop again go one past the last fallback index, the pictograph special case depends on it.
- 4:16 PM Changeset in webkit [177880] by
-
- 4 edits in trunk/LayoutTests
http/tests/security/cross-frame-access-put.html is racy
https://bugs.webkit.org/show_bug.cgi?id=140059
Reviewed by Darin Adler.
This test used to run some code in a subframe on a zero delay timer, and some more
code in a main frame in onload. The order was undefined.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/cross-frame-access-put.html:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 4:04 PM Changeset in webkit [177879] by
-
- 2 edits in trunk/LayoutTests
REGRESSION: plugins/plugin-remove-readystatechange.html is failing on debug bots
https://bugs.webkit.org/show_bug.cgi?id=126169
Reviewed by Antti Koivisto.
- plugins/plugin-remove-readystatechange.html: Move the embed so that it's not the
last rendered element in the test. It's only a workaround, not a real fix - if
anyone is interested in fixing the issue for real, please file a new bug.
Also, demystified the test by using readyState instead of counting readystatechange
events.
- 3:38 PM Changeset in webkit [177878] by
-
- 2 edits in trunk/Source/WebCore
Remove GlyphPageTree
https://bugs.webkit.org/show_bug.cgi?id=140015
Follow-up to r177876 to fix mathml/opentype/munderover-layout-resize.html which is asserting in bots.
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForNormalVariant):
Always return system fallback if no glyph is found.
- 3:27 PM Changeset in webkit [177877] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix.
- platform/graphics/SimpleFontData.cpp:
(WebCore::createAndFillGlyphPage):
- 1:26 PM Changeset in webkit [177876] by
-
- 28 edits1 move2 deletes in trunk/Source
Remove GlyphPageTree
https://bugs.webkit.org/show_bug.cgi?id=140015
Reviewed by Darin Adler.
GlyphPageTree is a global cache consisting of a tree of nodes that match SimpleFontData instances.
The tree levels correspond to font fallback lists so that higher levels fill holes (missing glyphs)
in the lower levels. This patch replaces it with a simpler and easier to understand caching scheme.
In particular the goal is to have clearer ownership relations and better control over mutability.
The new scheme looks like this:
SimpleFontData instances cache GlyphPages for themselves. These pages are immutable after construction
and may contain holes. This is a global cache (since SimpleFontDatas are cached globally) with the same
lifetime as the GlyphPageTree used to have.
FontGlyphs instances cache resolved GlyphPages for the normal font variant. These are build by traversing
the fallback list as necessary and collecting glyphs from SimpleFontDatas. As a common case case optimization
the page from the primary font is cached directly as long as it has the requested glyphs.
FontGlyphs are shared between sufficiently similar Font instances so this is a shared cache as well.
- CMakeLists.txt:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FontCache.h:
(WebCore::FontDescriptionFontDataCacheKey::makeFlagKey):
nonCJKGlyphOrientation matters for glyph selection too and needs to be part of the FontDescription cache key.
- platform/graphics/FontData.h:
(WebCore::FontData::FontData):
(WebCore::FontData::setMaxGlyphPageTreeLevel): Deleted.
(WebCore::FontData::maxGlyphPageTreeLevel): Deleted.
- platform/graphics/FontFastPath.cpp:
(WebCore::Font::primaryFontHasGlyphForCharacter):
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::FontGlyphs):
(WebCore::glyphDataForCJKCharacterWithoutSyntheticItalic):
(WebCore::glyphDataForNonCJKCharacterWithGlyphOrientation):
(WebCore::FontGlyphs::glyphDataForSystemFallback):
(WebCore::FontGlyphs::glyphDataForVariant):
(WebCore::FontGlyphs::glyphDataForNormalCharacter):
Traverse the fallback list by using simple index instead of indirectly via GlyphPageTreeNode traversal.
(WebCore::pageFromFontData):
Fetch a page from the primary font and see if we can use it as-is.
Vertical fonts have special glyph selection and can't use this path.
(WebCore::FontGlyphs::createFlattenedGlyphPage):
Build a hole-free glyph page by pulling characters from the fallback list.
(WebCore::FontGlyphs::glyphDataForCharacter):
- platform/graphics/FontGlyphs.h:
(WebCore::FontGlyphs::primarySimpleFontData):
- platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createForMixedFontData):
(WebCore::GlyphPage::createCopyForMixedFontData):
Add copy version.
(WebCore::GlyphPage::createForSingleFontData):
Remove owner node field.
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::count):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage): Deleted.
(WebCore::GlyphPage::owner): Deleted.
- platform/graphics/GlyphPageTreeNode.cpp: Removed.
- platform/graphics/GlyphPageTreeNode.h: Removed.
- platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::SegmentedFontData):
(WebCore::SegmentedFontData::~SegmentedFontData):
(WebCore::SegmentedFontData::simpleFontDataForCharacter):
Return null when there is no usable range so the client can tell the difference.
Rename for clarity.
(WebCore::SegmentedFontData::simpleFontDataForFirstRange):
Add a way to get the fallback font separately. This is always available.
(WebCore::SegmentedFontData::isLoading):
(WebCore::SegmentedFontData::fontDataForCharacter): Deleted.
- platform/graphics/SegmentedFontData.h:
(WebCore::SegmentedFontData::SegmentedFontData): Deleted.
- platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::initCharWidths):
(WebCore::SimpleFontData::platformGlyphInit):
(WebCore::SimpleFontData::~SimpleFontData):
(WebCore::SimpleFontData::simpleFontDataForCharacter):
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):
Move code for initializing glyph pages here. The code is from GlyphPageTreeNode.
(WebCore::SimpleFontData::glyphPage):
Cache glyphs for this font. These pages may have holes.
(WebCore::SimpleFontData::glyphForCharacter):
(WebCore::SimpleFontData::glyphDataForCharacter):
(WebCore::SimpleFontData::DerivedFontData::~DerivedFontData):
Since the cache is now owned by the SimpleFontData all the custom pruning can go away.
The glyph page cache dies along with it owner.
(WebCore::SimpleFontData::fontDataForCharacter): Deleted.
- platform/graphics/SimpleFontData.h:
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(-[WebCascadeList objectAtIndex:]):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):
- platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::fontDataForCombiningCharacterSequence):
- platform/graphics/mac/GlyphPageMac.cpp: Copied from Source/WebCore/platform/graphics/mac/GlyphPageTreeNodeMac.cpp.
This was already misnamed.
(WebCore::GlyphPage::fill):
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp: Removed.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformInit):
- platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:
- platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
- platform/graphics/win/SimpleFontDataCGWin.cpp:
(WebCore::SimpleFontData::platformInit):
- platform/mac/DragImageMac.mm:
Add missing FontCachePurgePreventer.
(WebCore::createDragImageForLink):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::initializeFontData):
- svg/SVGFontElement.cpp:
- 12:14 PM Changeset in webkit [177875] by
-
- 33 edits in trunk/Source/WebKit2
Clean up some of the IPC code
https://bugs.webkit.org/show_bug.cgi?id=140057
Reviewed by Antti Koivisto.
Use std::mutex instead of WTF::Mutex. Change a couple of pointers to references in the connection client.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::didClose):
(WebKit::DatabaseProcess::didReceiveInvalidMessage):
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::didClose):
(WebKit::DatabaseToWebProcessConnection::didReceiveInvalidMessage):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::didReceiveInvalidMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
(WebKit::NetworkProcess::didReceiveInvalidMessage):
- NetworkProcess/NetworkProcess.h:
- Platform/IPC/Connection.cpp:
(IPC::Connection::sendMessage):
(IPC::Connection::waitForMessage):
(IPC::Connection::connectionDidClose):
(IPC::Connection::sendOutgoingMessages):
(IPC::Connection::dispatchDidReceiveInvalidMessage):
(IPC::Connection::enqueueIncomingMessage):
(IPC::Connection::dispatchMessage):
(IPC::Connection::dispatchOneMessage):
- Platform/IPC/Connection.h:
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::didClose):
(WebKit::PluginProcess::didReceiveInvalidMessage):
- PluginProcess/PluginProcess.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didClose):
(WebKit::WebProcessConnection::didReceiveInvalidMessage):
- PluginProcess/WebProcessConnection.h:
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didClose):
(WebKit::DatabaseProcessProxy::didReceiveInvalidMessage):
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didClose):
(WebKit::NetworkProcessProxy::didReceiveInvalidMessage):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didClose):
(WebKit::PluginProcessProxy::didReceiveInvalidMessage):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
- UIProcess/WebProcessProxy.h:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::didClose):
(WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage):
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didClose):
(WebKit::NetworkProcessConnection::didReceiveInvalidMessage):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didClose):
(WebKit::PluginProcessConnection::didReceiveInvalidMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/WebPage/WebInspector.h:
- WebProcess/WebPage/WebInspectorUI.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::didReceiveInvalidMessage):
- WebProcess/WebProcess.h:
- 11:39 AM Changeset in webkit [177874] by
-
- 5 edits in trunk/Source/WebCore
Remove an unused function
https://bugs.webkit.org/show_bug.cgi?id=140055
Reviewed by Sam Weinig.
- Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::setReadOnly): Deleted.
- Modules/webdatabase/DatabaseAuthorizer.h:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::setAuthorizerReadOnly): Deleted.
- Modules/webdatabase/DatabaseBackendBase.h:
- 10:57 AM Changeset in webkit [177873] by
-
- 7 edits in trunk/Source/WebCore
Modernize parts of the database code
https://bugs.webkit.org/show_bug.cgi?id=140054
Reviewed by Antti Koivisto.
- Modules/webdatabase/Database.cpp:
(WebCore::Database::runTransaction):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
- Modules/webdatabase/SQLStatement.h:
- Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::create):
(WebCore::SQLTransaction::SQLTransaction):
(WebCore::SQLTransaction::deliverQuotaIncreaseCallback):
(WebCore::SQLTransaction::executeSQL):
- Modules/webdatabase/SQLTransaction.h:
(WebCore::SQLTransaction::database):
Jan 3, 2015:
- 10:35 PM Changeset in webkit [177872] by
-
- 6 edits in trunk/Source/WebCore
Move the CSS Grid properties to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140051
Reviewed by Sam Weinig.
Move the CSS Grid properties from StyleResolver to the new
StyleBuilder.
This patch adds support for "ConditionalConverter" parameter in
CSSPropertyNames.in to support cases where we only want to call the
property setter conditionally. The converter function is then expected
to return a boolean to indicate if the setter should be called by the
StyleBuilder or not.
- 7:47 PM Changeset in webkit [177871] by
-
- 3 edits3 adds in trunk
Crash in operationNewFunction when scrolling on Google+
https://bugs.webkit.org/show_bug.cgi?id=140033
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
In DFG code, the scope register can be eliminated because all uses have been
dead code eliminated. In the case where one of the uses was creating a function
that is never used, the baseline code will still create the function. If we OSR
exit to a path where that function gets created, check the scope register value
and set the new, but dead, function to undefined instead of creating a new function.
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_new_func_exp):
LayoutTests:
New regerssion test.
- js/regress-140033-expected.txt: Added.
- js/regress-140033.html: Added.
- js/script-tests/regress-140033.js: Added.
(.unused):
(defineADeadFunction):
Jan 2, 2015:
- 2:49 PM Changeset in webkit [177870] by
-
- 8 edits in trunk/Tools
Simplify WebKitTestRunner timeout tracking
https://bugs.webkit.org/show_bug.cgi?id=140036
Reviewed by Darin Adler.
The code for configuring timeouts was mostly dead, because run-webkit-tests never
passes the --timeout option to WebKitTestRunner.
- WebKitTestRunner/Options.h:
- WebKitTestRunner/Options.cpp:
(WTR::Options::Options):
(WTR::OptionsHandler::OptionsHandler):
(WTR::handleOptionTimeout): Deleted.
Removed support for --timeout. Timeouts are passed for each test individually,
and defaults are good enough for the rare cases where WebKitTestRunner is run
manually without run-webkit-tests.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::reattachPageToWebProcess):
(WTR::TestController::runUntil):
- WebKitTestRunner/TestController.h:
Simplified runUntil by passing the actual timeout, not an enum.
Increased short timeout for ASan enabled builds, as WebProcess launching takes
quite a while.
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
- WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::platformRunUntil):
- WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::platformRunUntil):
Build fixes.
- 2:40 PM Changeset in webkit [177869] by
-
- 14 edits2 deletes in trunk/Source/WebCore
Kill the DeprecatedStyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140034
Reviewed by Darin Adler.
Move FillLayer properties to the new StyleBuilder and get rid of the
DeprecatedStyleBuilder now that all its CSS properties have been ported
to the new StyleBuilder.
- 12:07 PM Changeset in webkit [177868] by
-
- 8 edits2 deletes in trunk/Tools
Remove now unused storage tracker glue from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=140045
Reviewed by Darin Adler.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/StorageTrackerDelegate.h: Removed.
- DumpRenderTree/StorageTrackerDelegate.mm: Removed.
- DumpRenderTree/TestRunner.cpp:
(TestRunner::staticFunctions):
(syncLocalStorageCallback): Deleted.
(observeStorageTrackerNotificationsCallback): Deleted.
(deleteAllLocalStorageCallback): Deleted.
(deleteLocalStorageForOriginCallback): Deleted.
(localStorageDiskUsageForOriginCallback): Deleted.
(originsWithLocalStorageCallback): Deleted.
- DumpRenderTree/TestRunner.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(allocateGlobalControllers):
(releaseGlobalControllers):
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::syncLocalStorage): Deleted.
(TestRunner::localStorageDiskUsageForOrigin): Deleted.
(TestRunner::observeStorageTrackerNotifications): Deleted.
(TestRunner::deleteAllLocalStorage): Deleted.
(TestRunner::originsWithLocalStorage): Deleted.
(TestRunner::deleteLocalStorageForOrigin): Deleted.
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::syncLocalStorage): Deleted.
(TestRunner::localStorageDiskUsageForOrigin): Deleted.
(TestRunner::observeStorageTrackerNotifications): Deleted.
(TestRunner::deleteAllLocalStorage): Deleted.
(TestRunner::originsWithLocalStorage): Deleted.
(TestRunner::deleteLocalStorageForOrigin): Deleted.
- 11:57 AM Changeset in webkit [177867] by
-
- 8 edits1 delete in trunk/LayoutTests
Get rid of storage tracker layout tests
https://bugs.webkit.org/show_bug.cgi?id=140044
Reviewed by Darin Adler.
These tests are very flaky since they expect to be run in order. Furthermore, they were testing a WebKit Mac SPI
that is pretty hard to test reliably, due to its "design". It's not worth trying to make these tests work
or to rewrite them in Objective-C (which would be the right thing to do), so just get rid of them.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- platform/wincairo/TestExpectations:
- platform/wk2/TestExpectations:
- storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-1-prepare.html: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-2-create-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-2-create.html: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-3-delete-all.html: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-4-create-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-4-create.html: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-5-delete-one.html: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-6-create-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-6-create.html: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage-expected.txt: Removed.
- storage/domstorage/localstorage/storagetracker/storage-tracker-7-usage.html: Removed.
- 11:53 AM Changeset in webkit [177866] by
-
- 8 edits in trunk/Source/WebCore
Move 'font-size' CSS property to the new StyleBuilder
https://bugs.webkit.org/show_bug.cgi?id=140010
Reviewed by Darin Adler.
Move 'font-size' CSS property to the new StyleBuilder by using custom
code.
- 10:32 AM Changeset in webkit [177865] by
-
- 2 edits in trunk/LayoutTests
js/dom/Promise.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140043
- TestExpectations: Mark it as such.
- 10:18 AM Changeset in webkit [177864] by
-
- 18 edits in trunk/Source/WebCore
Pass Document instead of ScriptExecutionContext to non-worker constructors
https://bugs.webkit.org/show_bug.cgi?id=140040
Reviewed by Sam Weinig.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDefinition):
Generate code passing the document when ConstructorCallWith=Document is used.
Later, we could base this on whether the constructor is exposed to workers
or not, instead, but for now this seems a clean way to do it.
- bindings/scripts/IDLAttributes.txt: Allow ConstructorCallWith=Document.
- Modules/notifications/Notification.cpp:
(WebCore::Notification::create):
- Modules/notifications/Notification.h:
- Modules/notifications/Notification.idl:
- dom/Comment.cpp:
- dom/Comment.h:
- dom/Comment.idl:
- dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::nodeName): Use ASCIILiteral (just something
I noticed in passing).
- dom/DocumentFragment.h:
- dom/DocumentFragment.idl:
- dom/Range.cpp:
- dom/Range.h:
- dom/Range.idl:
- dom/Text.cpp:
- dom/Text.h:
- dom/Text.idl:
Change from ScriptExecutionContext to Document, and remove unneeded
overloads that were just casting. It's better to have the bindings
layer, which knows these are not ScriptExecutionContext, do the cast
than to have create functions that cast that are not in any position
to know the cast is safe.
- 10:17 AM Changeset in webkit [177863] by
-
- 5 edits in trunk/Source/WebCore
Re-land the HTMLTreeBuilder change with the assertion fixed.
https://bugs.webkit.org/show_bug.cgi?id=140032
Reviewed by Andreas Kling.
- 10:07 AM Changeset in webkit [177862] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed, rolling out r177859 and r177861.
https://bugs.webkit.org/show_bug.cgi?id=140042
Caused many assertion failures (Requested by ap on #webkit).
Reverted changesets:
"Modernize coding style of HTMLTreeBuilder"
https://bugs.webkit.org/show_bug.cgi?id=140032
http://trac.webkit.org/changeset/177859
"Tried to fix the iOS build."
http://trac.webkit.org/changeset/177861
- 9:45 AM Changeset in webkit [177861] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the iOS build.
- html/parser/HTMLTreeBuilder.cpp:
- 8:33 AM Changeset in webkit [177860] by
-
- 8 edits in trunk/Source
Rework code that hides characters in password fields to streamline a little
https://bugs.webkit.org/show_bug.cgi?id=140035
Reviewed by Sam Weinig.
Source/WebCore:
- editing/InsertIntoTextNodeCommand.cpp:
(WebCore::InsertIntoTextNodeCommand::doApply): Pass the offset after the character
we want to reveal instead of the offset before. This is more future proof if we
ever want to handling surrogate pairs or combining marks, rather than hard
coding the likely incorrect rule of "go back by one code unit". Also got rid of
the isSecure check here, since RenderText can do that check inside the
momentarilyRevealLastTypedCharacter instead.
- rendering/RenderText.cpp: Tweaked the SecureTextTimer class: Marked it final
and made it derive from TimerBase privately. Made the constructor explicit and
made it take a reference rather than a pointer. Use initialization in the class
to set up the variable, and use 0 as the special value instead of -1 since we
now store the offset *after* the character to be revealed.
(WebCore::secureTextTimers): Use this function and NeverDestroyed rather than
a global variable gSecureTextTimers. Also use unique_ptr for the map so we
don't have to delete explicitly any more.
(WebCore::SecureTextTimer::SecureTextTimer): Moved out of the class definition
so the class ia a little easier to read.
(WebCore::SecureTextTimer::restart): Renamed since the function name doesn't
have to describe its argument; the function is only called in one place.
(WebCore::SecureTextTimer::takeOffsetAfterLastTypedCharacter): Changed name
and made this a one-shot that always zeroes the offset.
(WebCore::SecureTextTimer::fired): Moved out of line and tweaked as above.
(WebCore::RenderText::willBeDestroyed): Simplified now that the function
secureTextTimers() always returns a map and we can just remove since the
values in the map are unique_ptr, so take care of deletion.
(WebCore::RenderText::setRenderedText): Tweaked the code that calls secureText
to make the iOS case clearer.
(WebCore::RenderText::secureText): Rewrote the function. New version no
longer relies on a special String::fill function; it's kind of strange that
String had a built in concept of replacing a string with one that has the
same length but all with a masking character. This new approach is cleaner.
I had written a version that handles surrogate pairs and combining marks,
but then instead wrote a comment explaining why that's not needed/helpful.
(WebCore::RenderText::momentarilyRevealLastTypedCharacter): Added a check so
this does nothing if we are not securing the text. Also updated logic so that
this doesn't double hash any more and updated for other changes like using
a reference instead of a pointer.
- rendering/RenderText.h: Removed the unneeded isSecure function and updated
the argument name in momentarilyRevealLastTypedCharacter since it's now the
offset after the character, not before the character.
Source/WTF:
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::fill): Deleted.
- wtf/text/StringImpl.h: Deleted StringImpl::fill.
- wtf/text/WTFString.h:
(WTF::String::fill): Deleted.
- 8:31 AM Changeset in webkit [177859] by
-
- 5 edits in trunk/Source/WebCore
Modernize coding style of HTMLTreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=140032
Reviewed by Andreas Kling.
Changes include:
- Use references rather than pointers.
- Mark data members const that are fully set up in the constructor.
- Remove many unneeded includes and forward declarations.
- Fix conditionals to be consistent and correct.
- Merge some multi-line constructs into a single line.
- Update whatwg.org URLs; not sure we should keep these, though.
- Cut down on use of WTF_MAKE_NONCOPYABLE since for many classes it's impossible to copy anyway due to references, or harmless to copy.
- Made more things private.
- Initialize scalars in the class definition rather than each constructor.
- Use Ref/RefPtr instead of PassRefPtr.
- html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::HTMLDocumentParser): Pass reference rather than pointer to
the context element.
(WebCore::HTMLDocumentParser::detach): Removed call to HTMLTreeBuilder::detach. This work
is instead done when the tree builder is destroyed.
(WebCore::HTMLDocumentParser::constructTreeFromHTMLToken): Pass reference rather than pointer.
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::uninitializedPositionValue1): Marked this inline because it's trivial. It was
probably getting inlined already.
(WebCore::isCaptionColOrColgroupTag): Format on a single line.
(WebCore::isTableBodyContextTag): Ditto.
(WebCore::isNonAnchorFormattingTag): Ditto.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):
Take reference instead of pointer.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeRemaining): Use makeString helper.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::skipLeading): Tweak formatting.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::takeLeading): Both of the above.
(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::makeString): Added.
(WebCore::HTMLTreeBuilder::isParsingTemplateContents): Moved the body of this function here,
since it's only used inside the class.
(WebCore::HTMLTreeBuilder::isParsingFragmentOrTemplateContents): Ditto.
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder): Get rid of dead code that handles a null context
element. The FIXME mentions a bug that is obsolete. Also reorder the data members to be a bit
more logical and set the new m_destructionProhibited to false at the end of the constructor,
to check if we accidentally destroy the tree builder while constructing it.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::FragmentParsingContext): Updated to take
a reference and to let m_fragment get initialized in the class definition.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::fragment): Moved this here since it's only
used inside the class.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElement): Ditto.
(WebCore::HTMLTreeBuilder::FragmentParsingContext::contextElementStackItem): Ditto.
(WebCore::HTMLTreeBuilder::takeScriptToProcess): Changed return type to RefPtr instead of
PassRefPtr. Added code to handle m_scriptToProcess of null, since reading the code at the
single call site makes it clear that it's not guaranteed to be non-null! Added destruction-
related assertions since this is a public function.
(WebCore::HTMLTreeBuilder::constructTree): Updated for reference rather than pointer. Also
added destruction-related assertions since this is a public function.
(WebCore::HTMLTreeBuilder::processToken): Updated to take a reference.
(WebCore::HTMLTreeBuilder::processDoctypeToken): Ditto.
(WebCore::HTMLTreeBuilder::processFakeStartTag): Ditto. Also take an rvalue reference for
the vector of attributes that we will put into the token.
(WebCore::HTMLTreeBuilder::processFakeEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processFakePEndTagIfPInButtonScope): Ditto.
(WebCore::HTMLTreeBuilder::attributesForIsindexInput): Ditto.
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody): Ditto.
(WebCore::isLi): Ditto.
(WebCore::isDdOrDt): Ditto.
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag): Changed loop to use reference
rather than pointer for never-null stackItem. Also use auto and a for loop to make the
loop easier to read.
(WebCore::createCaseMap): Tweaked formatting.
(WebCore::adjustAttributes): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInBody): Use reference instead of pointer.
Set insertion mode directly instead of using a setInsertionMode function.
(WebCore::HTMLTreeBuilder::processTemplateStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processTemplateEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processEndOfFileForInTemplateContents): Ditto.
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup): Ditto.
(WebCore::HTMLTreeBuilder::closeTheCell): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processStartTag): Ditto. Tweaked assertions, so that we
assert what state we are in before we fall through to each case, rather than asserting
inside each case. The per-case assertions were sort of excessive and repetitive and
even a bit hard to understand.
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency): Ditto.
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInRow): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInCell): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption): Ditto.
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow): Ditto.
(WebCore::HTMLTreeBuilder::processTableEndTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processEndTagForInTable): Ditto.
(WebCore::HTMLTreeBuilder::processEndTag): Ditto.
(WebCore::HTMLTreeBuilder::processComment): Ditto.
(WebCore::HTMLTreeBuilder::processCharacter): Ditto.
(WebCore::HTMLTreeBuilder::insertPhoneNumberLink): Ditto.
(WebCore::HTMLTreeBuilder::processCharacterBuffer): Ditto.
(WebCore::HTMLTreeBuilder::processCharacterBufferForInBody): Ditto.
(WebCore::HTMLTreeBuilder::processEndOfFile): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInitial): Ditto.
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML): Ditto.
(WebCore::HTMLTreeBuilder::defaultForBeforeHead): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInHead): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInHeadNoscript): Ditto.
(WebCore::HTMLTreeBuilder::defaultForAfterHead): Ditto.
(WebCore::HTMLTreeBuilder::defaultForInTableText): Ditto.
(WebCore::HTMLTreeBuilder::processStartTagForInHead): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag): Ditto.
(WebCore::HTMLTreeBuilder::processScriptStartTag): Ditto.
(WebCore::HTMLTreeBuilder::adjustedCurrentStackItem): Made this return a reference.
(WebCore::HTMLTreeBuilder::shouldProcessTokenInForeignContent): More of the same.
(WebCore::HTMLTreeBuilder::processTokenInForeignContent): Ditto.
(WebCore::HTMLTreeBuilder::finished): Changed m_isAttached assertion to !m_destroyed.
Also updated the comment.
(WebCore::HTMLTreeBuilder::parseError): Marked this empty function inline.
- html/parser/HTMLTreeBuilder.h: Removed most includes and forward declarations.
Changed the phone number functions conditional to be correct. Removed a non-helpful
FIXME about assertions we really don't need. Removed unneeded use of the inline keyword,
changed types to references rather than pointer. Removed unneeded public insertionMode
and setInsertionMode functions. Both are things that are only done inside this class and
m_insertionMode can be accessed directly instead. Added a destructor that implements
the destruction assertions. Asserted !m_destroyed at the start of all the public functions.
- html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::insertFakePreElement): Use reference rather than pointer.
- 2:01 AM Changeset in webkit [177858] by
-
- 23 edits in trunk
[CSS Grid Layout] Remove stack from grid-auto-flow syntax
https://bugs.webkit.org/show_bug.cgi?id=134842
Reviewed by Sergio Villar Senin.
Source/WebCore:
"stack" mode for grid-auto-flow property has been removed from the grid
layout spec. New syntax is:
[ row | column ] dense Modified parsing in order to adapt it to the new syntax.
Also the current behavior relying on "stack" has been updated following
the spec. Now it won't be possible to mimic the old "none" (or "stack")
unless you specify manually the grid-placement properties.
No new tests needed, updated current tests to adapt them to the new
behavior.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue): Adapt to new syntax.
- css/CSSParser.cpp:
(WebCore::isValidGridAutoFlowId): Remove "stack" from valid ids.
(WebCore::CSSParser::parseGridAutoFlow): Adapt to new syntax.
- css/CSSValueKeywords.in: Remove "stack".
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty): Adapt to new syntax.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::placeItemsOnGrid): Remove old "stack" code.
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle): If we
cannot resolve positions, we have to run the auto-placement algorithm.
- rendering/style/RenderStyle.h: Remove "stack".
- rendering/style/RenderStyleConstants.h: Ditto.
LayoutTests:
Update layout tests in order to adapt the results to the new behavior.
- fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
- fast/css-grid-layout/grid-auto-flow-get-set.html:
- fast/css-grid-layout/grid-auto-flow-update.html:
- fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
- fast/css-grid-layout/grid-item-z-index-change-repaint.html:
- fast/css-grid-layout/grid-item-z-index-stacking-context.html:
- fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
- fast/css-grid-layout/grid-shorthand-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html:
- fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
- ietestcenter/css3/grid/grid-column-001.htm:
- ietestcenter/css3/grid/grid-column-002.htm:
- ietestcenter/css3/grid/grid-column-003.htm:
Jan 1, 2015:
- 9:26 PM Changeset in webkit [177857] by
-
- 41 edits2 deletes in trunk/Source
Remove GroupSettings
https://bugs.webkit.org/show_bug.cgi?id=140037
Patch by Sam Weinig <sam@webkit.org> on 2015-01-01
Reviewed by Dan Bernstein.
Source/WebCore:
Nothing sets the values in GroupSettings and nothing uses them.
- The indexedDBDatabasePath is accessed and sent to the IndexedDB backend, but the backend then proceeds to not use it.
- CMakeLists.txt:
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getDatabaseNames):
(WebCore::IDBFactory::deleteDatabase):
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create):
- Modules/indexeddb/IDBFactoryBackendInterface.h:
- Modules/indexeddb/PageGroupIndexedDatabase.cpp:
(WebCore::PageGroupIndexedDatabase::PageGroupIndexedDatabase):
(WebCore::PageGroupIndexedDatabase::from):
(WebCore::PageGroupIndexedDatabase::factoryBackend):
- Modules/indexeddb/PageGroupIndexedDatabase.h:
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.cpp:
(WebCore::WorkerGlobalScopeIndexedDatabase::WorkerGlobalScopeIndexedDatabase):
(WebCore::WorkerGlobalScopeIndexedDatabase::from):
(WebCore::WorkerGlobalScopeIndexedDatabase::indexedDB):
- Modules/indexeddb/WorkerGlobalScopeIndexedDatabase.h:
- WebCore.exp.in:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- dom/DocumentStyleSheetCollection.cpp:
- page/CaptionUserPreferences.cpp:
- page/Frame.cpp:
- page/GroupSettings.cpp: Removed.
- page/GroupSettings.h: Removed.
- page/PageGroup.cpp:
(WebCore::PageGroup::PageGroup):
- page/PageGroup.h:
(WebCore::PageGroup::groupSettings): Deleted.
- platform/DatabaseStrategy.cpp:
(WebCore::DatabaseStrategy::createIDBFactoryBackend):
- platform/DatabaseStrategy.h:
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
- workers/DedicatedWorkerThread.h:
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
(WebCore::SharedWorkerProxy::groupSettings): Deleted.
- workers/SharedWorkerGlobalScope.cpp:
(WebCore::SharedWorkerGlobalScope::create):
(WebCore::SharedWorkerGlobalScope::SharedWorkerGlobalScope):
- workers/SharedWorkerGlobalScope.h:
- workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
(WebCore::SharedWorkerThread::createWorkerGlobalScope):
- workers/SharedWorkerThread.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::groupSettings): Deleted.
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h:
Source/WebKit2:
Remove unused databaseDirectoryIdentifier parameters.
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
(WebKit::WebIDBFactoryBackend::WebIDBFactoryBackend):
(WebKit::WebIDBFactoryBackend::getDatabaseNames):
(WebKit::WebIDBFactoryBackend::deleteDatabase):
- WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
- WebProcess/Storage/StorageNamespaceImpl.cpp:
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createIDBFactoryBackend):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 8:41 PM Changeset in webkit [177856] by
-
- 5 edits in trunk
Source/JavaScriptCore:
String includes methods perform toString on searchString before toInt32 on a offset
https://bugs.webkit.org/show_bug.cgi?id=140031
Reviewed by Darin Adler.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncStartsWith):
(JSC::stringProtoFuncEndsWith):
(JSC::stringProtoFuncIncludes):
LayoutTests:
String includes methods perform toString on searchString before toInteger on a offset
https://bugs.webkit.org/show_bug.cgi?id=140031
Reviewed by Darin Adler.
As per the latest ES6 draft, String.prototype.{startsWith, endsWith, includes}
perform toString on searchString (argument 0) before performing toInteger on offset (argument 1).
- js/script-tests/string-includes.js:
(searchString.toString):
(startOffset.valueOf):
(endOffset.valueOf):
(matchString.toString): Deleted.
- js/string-includes-expected.txt:
- 6:05 PM Changeset in webkit [177855] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the iOS build.
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):
- 5:13 PM Changeset in webkit [177854] by
-
- 3 edits in trunk/Source/JavaScriptCore
Change to return std::unique_ptr<> in fooCreate()
https://bugs.webkit.org/show_bug.cgi?id=139983
Reviewed by Darin Adler.
To avoid unnecessary std::unique_ptr<> casting, fooCreate() returns std::unique_ptr<> directly.
- create_regex_tables:
- yarr/YarrPattern.h:
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):
- 4:57 PM Changeset in webkit [177853] by
-
- 2 edits in trunk/Source/WebCore
Fix itearator typo
https://bugs.webkit.org/show_bug.cgi?id=140027
Reviewed by Csaba Osztrogonác.
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::nextBreakablePosition): Spelling mistake.
- 4:29 PM Changeset in webkit [177852] by
-
- 2 edits in trunk/Source/WebCore
Don't dereference end() in SimpleLineLayout::RunResolver::rangeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=139951
rdar://problem/19339881
Reviewed by Darin Adler.
- rendering/SimpleLineLayoutResolver.cpp:
(WebCore::SimpleLineLayout::RunResolver::rangeForRenderer):
- 3:53 PM Changeset in webkit [177851] by
-
- 3 edits in trunk/Source/WebCore
ASSERT that a null key is never used with FeatureCounter
https://bugs.webkit.org/show_bug.cgi?id=140030
Reviewed by Darin Adler.
- platform/FeatureCounter.cpp:
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):
- platform/ios/FeatureCounter.mm:
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):
- 2:35 PM Changeset in webkit [177850] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Fix memory leak in FeatureCounter
https://bugs.webkit.org/show_bug.cgi?id=140029
<rdar://problem/19255690>
Reviewed by Darin Adler.
Fix memory leak in FeatureCounter. The NSString for the counter key
was allocated but never released. The patch switches to using a
RetainPtr instead of a raw pointer to avoid the issue.
- platform/ios/FeatureCounter.mm:
(WebCore::FeatureCounter::incrementKey):
(WebCore::FeatureCounter::setKey):
- 2:21 PM Changeset in webkit [177849] by
-
- 27 edits in trunk
Update user-visible copyright strings to include 2015
https://bugs.webkit.org/show_bug.cgi?id=139880
Reviewed by Darin Adler.
Source/JavaScriptCore:
- Info.plist:
Source/WebCore:
- Info.plist:
Source/WebKit/mac:
- Info.plist:
Source/WebKit2:
- DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
- Info.plist:
- NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
- PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
- WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
- mac/Info-WebKit2.plist:
WebKitLibraries:
- win/tools/scripts/COPYRIGHT-END-YEAR:
- 1:20 PM Changeset in webkit [177848] by
-
- 9 edits in trunk/Source
Move scrolling code off of WTF::bind
https://bugs.webkit.org/show_bug.cgi?id=140019
Reviewed by Darin Adler.
Source/WebCore:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::tryToHandleWheelEvent):
(WebCore::ThreadedScrollingTree::invalidate):
(WebCore::ThreadedScrollingTree::scrollingTreeNodeDidScroll):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
(WebCore::derefScrollingCoordinator): Deleted.
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::invalidate):
(WebCore::ScrollingTreeIOS::scrollingTreeNodeDidScroll):
(WebCore::derefScrollingCoordinator): Deleted.
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::pageDestroyed):
(WebCore::ScrollingCoordinatorMac::handleWheelEvent):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::releaseMemory):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):
Source/WebKit2:
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::touchEvent):
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
- 12:49 PM Changeset in webkit [177847] by
-
- 9 edits in trunk/Source/WebCore
Remove FontData::containsCharacters
https://bugs.webkit.org/show_bug.cgi?id=140026
Reviewed by Dan Bernstein.
This virtual function has no clients.
- platform/graphics/FontData.h:
- platform/graphics/SegmentedFontData.cpp:
(WebCore::SegmentedFontData::containsCharacter): Deleted.
(WebCore::SegmentedFontData::containsCharacters): Deleted.
- platform/graphics/SegmentedFontData.h:
- platform/graphics/SimpleFontData.h:
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::containsCharacters): Deleted.
- platform/graphics/ios/SimpleFontDataIOS.mm:
(WebCore::SimpleFontData::containsCharacters): Deleted.
- platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::containsCharacters): Deleted.
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::containsCharacters): Deleted.
- 11:56 AM Changeset in webkit [177846] by
-
- 22 edits in trunk
We often misspell identifier as "identifer"
https://bugs.webkit.org/show_bug.cgi?id=140025
Reviewed by Michael Saboff.
Source/JavaScriptCore:
- runtime/ArrayConventions.h: Fix it.
Source/WebCore:
- html/MediaFragmentURIParser.cpp:
(WebCore::MediaFragmentURIParser::parseNPTFragment):
- html/parser/AtomicHTMLToken.h:
- html/parser/HTMLToken.h:
- html/shadow/SliderThumbElement.h:
- platform/graphics/ISOVTTCue.cpp:
(WebCore::ISOWebVTTCue::ISOWebVTTCue):
- platform/graphics/ISOVTTCue.h:
(WebCore::ISOWebVTTCue::id):
Fix mispellings.
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
(WebInspector._updateNavigationSidebarForCurrentContentView):
(WebInspector._contentBrowserCurrentContentViewDidChange):
Fix misspellings.
Source/WebKit2:
- Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::encode):
(WebKit::WebPageGroupData::decode):
- Shared/WebPageGroupData.h:
- UIProcess/WebPageGroup.cpp:
(WebKit::pageGroupData):
(WebKit::WebPageGroup::WebPageGroup):
- UIProcess/WebPageGroup.h:
(WebKit::WebPageGroup::identifier):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::createInspectorPage):
- WebProcess/WebPage/WebPageGroupProxy.cpp:
(WebKit::WebPageGroupProxy::WebPageGroupProxy):
- WebProcess/WebPage/WebPageGroupProxy.h:
(WebKit::WebPageGroupProxy::identifier):
Fix misspellings.
Tools:
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
- Scripts/webkitdirs.pm:
(appIdentifierFromBundle):
(installAndLaunchIOSWebKitAppInSimulator):
Fix misspellings
- 5:59 AM WebKitGTK/StartHacking edited by
- fixup (diff)
- 5:58 AM WebKitGTK/StartHacking edited by
- Don't recommend old unsupported distro releases (diff)
- 5:54 AM WebKitGTK/StartHacking edited by
- fix path to MiniBrowser (diff)
- 5:48 AM WebKitGTK/TrackingMemoryErrors edited by
- fix path to MiniBrowser (diff)
- 12:32 AM Changeset in webkit [177845] by
-
- 4 edits in trunk
Saturated arithmetics: Incorrect float/double clamping.
https://bugs.webkit.org/show_bug.cgi?id=139888
rdar://problem/19330885
Reviewed by Simon Fraser.
Clamp float and double values correctly when applying saturated arithmetics.
Source/WebCore:
Test: LayoutUnit test for float overflow.
- platform/LayoutUnit.h:
(WebCore::LayoutUnit::LayoutUnit):
Tools:
- TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
(TestWebKitAPI::TEST):
- 12:06 AM Changeset in webkit [177844] by
-
- 2 edits in trunk/LayoutTests
http/tests/xmlhttprequest/send-on-abort.html is flaky in debug builds
https://bugs.webkit.org/show_bug.cgi?id=140020
Reviewed by Darin Adler.
- XHR loads are aborted when a page load starts, not when it's committed (which
is a known bug in WebKit). This gave the failure timer an opportunity to fire between
these events. Fixed by extending the delay.
- Starting the test while parsing had a potential for a race with loading - we
could run it before all data was loaded. While this probably didn't happen in
practice here, it's better to run navigation tests under 100% reproducible conditions,
like during onload.
- http/tests/xmlhttprequest/send-on-abort.html:
- 12:05 AM Changeset in webkit [177843] by
-
- 12 edits in trunk/LayoutTests
http/tests/notifications/legacy/show.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=140023
http/tests/notifications/window-show-on-click.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112499
Reviewed by Darin Adler.
Remove 100 ms timeouts from notification tests. If they become broken, it will
be detected as timeout.
- http/tests/notifications/events-in-dictionary.html:
- http/tests/notifications/events.html:
- http/tests/notifications/legacy/double-show.html:
- http/tests/notifications/legacy/events.html:
- http/tests/notifications/legacy/request-no-callback.html:
- http/tests/notifications/legacy/request.html:
- http/tests/notifications/legacy/show.html:
- http/tests/notifications/legacy/window-show-on-click.html:
- http/tests/notifications/request.html:
- http/tests/notifications/window-show-on-click.html:
- platform/mac/TestExpectations: window-show-on-click.html should pass now.
- 12:04 AM Changeset in webkit [177842] by
-
- 3 edits in trunk/LayoutTests
fast/ruby/ruby-svg-crash.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=135610
Reviewed by Darin Adler.
- fast/ruby/ruby-svg-crash.html: Streamline the test to avoid timer races. I
verified that it still crashes without the original fix (it gets an
ASSERT_WITH_SECURITY_IMPILICATIONS).
- platform/mac/TestExpectations: Removed the expectation.
Dec 31, 2014:
- 5:25 PM Changeset in webkit [177841] by
-
- 2 edits in trunk/Source/WebCore
Fixed the iOS build.
- page/scrolling/ios/ScrollingCoordinatorIOS.mm:
(WebCore::ScrollingCoordinatorIOS::commitTreeState):
- 5:03 PM Changeset in webkit [177840] by
-
- 3 edits in trunk/Source/WebCore
URTBF after r177835.
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::ScrollingCoordinatorCoordinatedGraphics):
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
- 3:30 PM Changeset in webkit [177839] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r176476.
https://bugs.webkit.org/show_bug.cgi?id=140021
Sadly, this didn't reduce media test crashiness (Requested by
ap on #webkit).
Reverted changeset:
"[Mac] Random crashes inside media libraries when creating
then destroying media quickly."
https://bugs.webkit.org/show_bug.cgi?id=138980
http://trac.webkit.org/changeset/176476
- 1:34 PM Changeset in webkit [177838] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Suppress unused parameter warnings in ui clients
https://bugs.webkit.org/show_bug.cgi?id=140012
Drop the parameter name of WebKitUIClient::isPlayingAudioDidChange
to suppress warnings.
Reviewed by Benjamin Poulain.
- UIProcess/API/gtk/WebKitUIClient.cpp:
- 1:21 PM Changeset in webkit [177837] by
-
- 3 edits in trunk/LayoutTests
execDeleteCommand() does not update spellchecker sometimes
https://bugs.webkit.org/show_bug.cgi?id=139862
Updated test expectation for a test that always crashes on WK1 (it was already
skipped on mac-wk2, efl and gtk).
- TestExpectations:
- platform/mac-wk1/TestExpectations:
- 1:16 PM Changeset in webkit [177836] by
-
- 3 edits in trunk/LayoutTests
Test expectation gardening.
Add expectations for test that became flaky after enabling kerning and ligatures,
plus a few more that were mis-characterized.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- 12:01 PM Changeset in webkit [177835] by
-
- 23 edits in trunk/Source
Remove the remaining uses of OwnPtr from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=140017
Reviewed by Dan Bernstein.
Source/WebCore:
- WebCore.exp.in:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::AsyncScrollingCoordinator):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingStateTree.cpp:
(WebCore::ScrollingStateTree::commit):
(WebCore::ScrollingStateTree::create): Deleted.
- page/scrolling/ScrollingStateTree.h:
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::commitNewTreeState):
- page/scrolling/ScrollingTree.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::commitNewTreeState):
- page/scrolling/ThreadedScrollingTree.h:
- page/scrolling/ios/ScrollingTreeIOS.cpp:
(WebCore::ScrollingTreeIOS::commitNewTreeState):
- page/scrolling/ios/ScrollingTreeIOS.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::commitTreeState):
Source/WebKit2:
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
- Shared/Scrolling/RemoteScrollingCoordinatorTransaction.h:
(WebKit::RemoteScrollingCoordinatorTransaction::setStateTreeToEncode):
(WebKit::RemoteScrollingCoordinatorTransaction::scrollingStateTree):
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
- UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:
(WebKit::RemoteScrollingCoordinatorProxy::updateScrollingTree):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::PageClientImpl):
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(-[WKPrintingView _askPageToComputePageRects]):
(-[WKPrintingView _drawPreview:]):
- WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
- 11:03 AM Changeset in webkit [177834] by
-
- 2 edits in trunk/Source/WebCore
Don’t use AccessibilityAllInOne when building with Xcode
https://bugs.webkit.org/show_bug.cgi?id=139974
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Added all files included by AccessibilityAllInOne.cpp
to the WebCore target, and removed AccessibilityAllInOne.cpp from the project.
- 9:16 AM Changeset in webkit [177833] by
-
- 2 edits in trunk/Source/WebKit2
Fix build warnings after r177792.
https://bugs.webkit.org/show_bug.cgi?id=140005.
Patch by Bartlomiej Gajda <b.gajda@samsung.com> on 2014-12-31
Reviewed by Anders Carlsson.
Add UNUSED_PARAM(connection) for async messages.
- Scripts/webkit/messages.py:
(generate_message_handler):
- 3:33 AM Changeset in webkit [177832] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed build fix for the GTK port.
Move the ArgumentCodersGtk.h inclusion from WebPageProxy.cpp to
WebPageProxy.h. This makes GTK-specific IPC coders available to
WebPageProxyMessageReceiver, fixing a build error due to missing
ArgumentCoder template specializations for WebCore::DragData type
that is used in the GTK-specific StartDrag message.
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- 12:44 AM Changeset in webkit [177831] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r177824 and r177826.
https://bugs.webkit.org/show_bug.cgi?id=140011
The new test crashes (Requested by ap on #webkit).
Reverted changesets:
"Too large plugins are crashing."
https://bugs.webkit.org/show_bug.cgi?id=139856
http://trac.webkit.org/changeset/177824
"Fix bug number typo in the previous commit."
http://trac.webkit.org/changeset/177826
- 12:36 AM Changeset in webkit [177830] by
-
- 2 edits in trunk/LayoutTests
Update storage tracker test expectations after r177814.
- platform/mac/TestExpectations:
- 12:26 AM Changeset in webkit [177829] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed gardening, mark more timeouting tests.
- platform/win/TestExpectations: