Timeline



May 19, 2015:

11:29 PM Changeset in webkit [184619] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[SOUP] Network Cache: Disable network cache efficacy logging
https://bugs.webkit.org/show_bug.cgi?id=145172

Reviewed by Martin Robinson.

Disable network cache efficacy logging by default, since we are
not currently using the collected data.

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

11:14 PM Changeset in webkit [184618] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r184613 and r184614.
https://bugs.webkit.org/show_bug.cgi?id=145206

Broke 10 tests :| (Requested by kling on #webkit).

Reverted changesets:

"[JSC] Speed up URL encode/decode by using bitmaps instead of
strchr()."
https://bugs.webkit.org/show_bug.cgi?id=145115
http://trac.webkit.org/changeset/184613

"[JSC] Speed up URL encode/decode by using bitmaps instead of
strchr()."
https://bugs.webkit.org/show_bug.cgi?id=145115
http://trac.webkit.org/changeset/184614

10:57 PM Changeset in webkit [184617] by akling@apple.com
  • 8 edits in trunk/Source

Give StringView a utf8() API.
<https://webkit.org/b/145201>

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Use JSString::view() in a few places where we couldn't before due to StringView
lacking a utf8() API. This is a minor speed-up on Kraken's crypto subtests,
which like to call encode() with substring JSStrings.

  • jsc.cpp:

(functionPrint):
(functionDebug):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):

Source/WTF:

Reviewed by Anders Carlsson

Added an LChar version of StringImpl::utf8ForCharacters() and use that to give
StringView a utf8() API just like String has.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::utf8ForCharacters):

  • wtf/text/StringImpl.h:
  • wtf/text/StringView.cpp:

(WTF::StringView::utf8):

  • wtf/text/StringView.h:
10:41 PM Changeset in webkit [184616] by weinig@apple.com
  • 14 edits
    2 adds in trunk

Organize event handlers a bit
https://bugs.webkit.org/show_bug.cgi?id=145106

Reviewed by Darin Adler.

Source/WebCore:

There is one change in behavior here. Previously, the media related event handlers where only exposed on
Element and DOMWindow. The spec says they should also be on Document, so this adds support for that (this
is tested in fast/dom/event-handler-attributes.html).

  • Group remaining event handlers in Element, Document, DOMWindow, HTMLBodyElement and HTMLFrameSetElement by their grouping, and add some FIXMEs for future cleaning.
  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • Add GlobalEventHandlers.idl and WindowEventHandlers.idl.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Add special cases for WindowEventHandler when used on DOMWindow and DocumentEventHandler when used on Document
so that event handlers using those extended attributes can be set on shared interfaces. This is used to allow
DOMWindow to implement WindowEventHandlers.

  • dom/Document.idl:

Move event handlers to GlobalEventHandlers and have Document implement it. Group remaining event handlers.

  • dom/Element.idl:

Move event handlers to GlobalEventHandlers and have Element implement it. Group remaining event handlers.

  • dom/GlobalEventHandlers.idl:

Added.

  • html/HTMLBodyElement.idl:

Move event handlers to WindowEventHandlers and have HTMLBodyElement implement it. Group remaining event handlers.

  • html/HTMLFrameSetElement.idl:

Move event handlers to WindowEventHandlers and have HTMLFrameSetElement implement it. Group remaining event handlers.

  • page/DOMWindow.idl:

Move event handlers to GlobalEventHandlers and WindowEventHandlers and have DOMWindow implement both of them. Group
remaining event handlers.

  • page/WindowEventHandlers.idl:

Added.

LayoutTests:

  • fast/dom/event-handler-attributes-expected.txt:
  • fast/dom/event-handler-attributes.html:

Update for putting media related event handlers on Document in addition to
Element and DOMWindow.

10:28 PM Changeset in webkit [184615] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Crash under WebCore::invalidateStyleRecursively
https://bugs.webkit.org/show_bug.cgi?id=145186
rdar://problem/19736838

Reviewed by Andreas Kling

We have seen crashes where we run out of stack under invalidateStyleRecursively in StyleInvalidationAnalysis
on some devices.

Switch to iterative algorithm.

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::invalidateIfNeeded):
(WebCore::invalidateStyleForTree):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
(WebCore::invalidateStyleRecursively): Deleted.

9:51 PM Changeset in webkit [184614] by akling@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixup accidental ChangeLog switcheroo.

9:49 PM Changeset in webkit [184613] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Speed up URL encode/decode by using bitmaps instead of strchr().
<https://webkit.org/b/145115>

Incorporate review feedback from Darin, removing some unnecessary zero checks.

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2015-05-19

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):

9:19 PM Changeset in webkit [184612] by Yusuke Suzuki
  • 27 edits
    1 copy
    1 move in trunk

Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
https://bugs.webkit.org/show_bug.cgi?id=145109

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

  • runtime/Identifier.cpp:

(JSC::Identifier::add):
(JSC::Identifier::add8):

  • runtime/Identifier.h:

(JSC::Identifier::add):

  • runtime/IdentifierInlines.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::add):

  • runtime/JSString.cpp:

(JSC::JSRopeString::resolveRopeToExistingAtomicString):

  • runtime/JSString.h:

(JSC::JSString::toExistingAtomicString):

  • runtime/SmallStrings.cpp:

(JSC::SmallStringsStorage::SmallStringsStorage):

  • runtime/TypeSet.cpp:

(JSC::StructureShape::propertyHash):

Source/WebCore:

  • dom/TreeScope.cpp:

(WebCore::TreeScope::getElementById):

Source/WTF:

Now AtomicStringImpl table operations are located in AtomicString.
But they should be under AtomicStringImpl.
This patch simply moves these operations to AtomicStringImpl.

And this patch renames static AtomicString::find to static AtomicStringImpl::lookUp
because it conflicts with AtomicStringImpl's member function name.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.vcxproj/copy-files.cmd:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PlatformMac.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::lower):
(WTF::AtomicString::convertToASCIILowercase):
(WTF::AtomicString::fromUTF8Internal):
(WTF::AtomicStringTableLocker::AtomicStringTableLocker): Deleted.
(WTF::stringTable): Deleted.
(WTF::addToStringTable): Deleted.
(WTF::CStringTranslator::hash): Deleted.
(WTF::CStringTranslator::equal): Deleted.
(WTF::CStringTranslator::translate): Deleted.
(WTF::AtomicString::add): Deleted.
(WTF::UCharBufferTranslator::hash): Deleted.
(WTF::UCharBufferTranslator::equal): Deleted.
(WTF::UCharBufferTranslator::translate): Deleted.
(WTF::HashAndCharactersTranslator::hash): Deleted.
(WTF::HashAndCharactersTranslator::equal): Deleted.
(WTF::HashAndCharactersTranslator::translate): Deleted.
(WTF::HashAndUTF8CharactersTranslator::hash): Deleted.
(WTF::HashAndUTF8CharactersTranslator::equal): Deleted.
(WTF::HashAndUTF8CharactersTranslator::translate): Deleted.
(WTF::SubstringTranslator::translate): Deleted.
(WTF::SubstringTranslator8::hash): Deleted.
(WTF::SubstringTranslator8::equal): Deleted.
(WTF::SubstringTranslator16::hash): Deleted.
(WTF::SubstringTranslator16::equal): Deleted.
(WTF::LCharBufferTranslator::hash): Deleted.
(WTF::LCharBufferTranslator::equal): Deleted.
(WTF::LCharBufferTranslator::translate): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::hash): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::equal): Deleted.
(WTF::CharBufferFromLiteralDataTranslator::translate): Deleted.
(WTF::AtomicString::addFromLiteralData): Deleted.
(WTF::AtomicString::addSlowCase): Deleted.
(WTF::AtomicString::remove): Deleted.
(WTF::AtomicString::findSlowCase): Deleted.
(WTF::AtomicString::findInternal): Deleted.
(WTF::AtomicString::isInAtomicStringTable): Deleted.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::AtomicString):
(WTF::AtomicString::fromUTF8):
(WTF::AtomicString::find): Deleted.
(WTF::AtomicString::add): Deleted.
(WTF::AtomicString::addWithStringTableProvider): Deleted.

  • wtf/text/AtomicStringImpl.cpp: Copied from Source/WTF/wtf/text/AtomicString.cpp.

(WTF::AtomicStringTableLocker::AtomicStringTableLocker):
(WTF::stringTable):
(WTF::addToStringTable):
(WTF::CStringTranslator::hash):
(WTF::CStringTranslator::equal):
(WTF::CStringTranslator::translate):
(WTF::AtomicStringImpl::add):
(WTF::UCharBufferTranslator::hash):
(WTF::UCharBufferTranslator::equal):
(WTF::UCharBufferTranslator::translate):
(WTF::HashAndCharactersTranslator::hash):
(WTF::HashAndCharactersTranslator::equal):
(WTF::HashAndCharactersTranslator::translate):
(WTF::HashAndUTF8CharactersTranslator::hash):
(WTF::HashAndUTF8CharactersTranslator::equal):
(WTF::HashAndUTF8CharactersTranslator::translate):
(WTF::SubstringTranslator::translate):
(WTF::SubstringTranslator8::hash):
(WTF::SubstringTranslator8::equal):
(WTF::SubstringTranslator16::hash):
(WTF::SubstringTranslator16::equal):
(WTF::LCharBufferTranslator::hash):
(WTF::LCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::translate):
(WTF::CharBufferFromLiteralDataTranslator::hash):
(WTF::CharBufferFromLiteralDataTranslator::equal):
(WTF::CharBufferFromLiteralDataTranslator::translate):
(WTF::AtomicStringImpl::addLiteral):
(WTF::AtomicStringImpl::addSlowCase):
(WTF::AtomicStringImpl::remove):
(WTF::AtomicStringImpl::lookUpSlowCase):
(WTF::AtomicStringImpl::addUTF8):
(WTF::AtomicStringImpl::lookUpInternal):
(WTF::AtomicStringImpl::isInAtomicStringTable):

  • wtf/text/AtomicStringImpl.h:

(WTF::AtomicStringImpl::lookUp):
(WTF::AtomicStringImpl::add):
(WTF::AtomicStringImpl::addWithStringTableProvider):
(WTF::AtomicStringImpl::AtomicStringImpl): Deleted.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):

  • wtf/text/StringImpl.h:
  • wtf/text/WTFString.h:

(WTF::String::String):

  • wtf/text/cf/AtomicStringCF.cpp:

(WTF::AtomicString::add): Deleted.

  • wtf/text/cf/AtomicStringImplCF.cpp: Renamed from Source/WTF/wtf/text/cf/AtomicStringCF.cpp.

(WTF::AtomicStringImpl::add):

Tools:

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

8:34 PM Changeset in webkit [184611] by jonlee@apple.com
  • 7 edits in trunk/Source/WebCore

[iOS] Optimized fullscreen placeholder is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=145196
rdar://problem/21031188

Reviewed by Dean Jackson.

Add a new media part UI for the placeholder text when entering optimized fullscreen,
and use it as part of the title text in the placeholder. Now the wireless playback status
div serves as a multi-purpose placeholder.

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::mediaUIImageData): Return the placeholder text.

  • Modules/mediacontrols/MediaControlsHost.idl: Add a new UI part for placeholder text.
  • Modules/mediacontrols/mediaControlsApple.js: Add a new "optimized" ClassName when

the presentation mode is set to optimized.

  • Modules/mediacontrols/mediaControlsiOS.css:

(audio::-webkit-media-controls-wireless-playback-status): The text should be at
medium weight, not light weight.
(audio::-webkit-media-controls-wireless-playback-text-top): The title text should be
white for both wireless playback and optimized fullscreen. It matches the style
when taking a video fullscreen.

Add new CSS rules when the placard is used for optimized fullscreen.
(audio::-webkit-media-controls-wireless-playback-status.optimized): Accommodate the
size of the graphic, and position appropriately.
(audio::-webkit-media-controls-wireless-playback-text-top.optimized): One line is
needed, so use this one, and place it where the bottom one is since more room is
needed to accommodate the graphic.
(audio::-webkit-media-controls-wireless-playback-text-bottom.optimized): One line is
needed, so hide this one.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.createControls): Several of the container divs are already
created in Controller.prototype.createControls(). Fly-by fix to avoid creation of
those divs. Only the panelContainer is new for the iOS controls. Fly-by fix of a
missing semicolon.
(ControllerIOS.prototype.handlePresentationModeChange): When the presentation mode
changes do several things:

1- Update the background image. Clear the inline background image when going back

to inline or in wireless playback.

2- Add the "optimized" ClassName to the placeholder container, and the two text

divs when entering optimized fullscreen. Remove them in other cases.

3- Set -webkit-media-controls-wireless-playback-text-top to the placeholder text.

This is better than embedding it inside the graphic. Clear the -bottom text.

  • platform/ios/WebCoreSystemInterfaceIOS.h: Add a new enum to obtain the placeholder

text.

7:46 PM Changeset in webkit [184610] by ryuan.choi@navercorp.com
  • 6 edits
    2 deletes in trunk/Source/WebCore

[EFL] Use GSimpleProxyResolver instead of custom SoupProxyResolver
https://bugs.webkit.org/show_bug.cgi?id=145154

Reviewed by Gyuyoung Kim.

SoupProxyResolver was deprecated since libsoup 2.42.
So, this patch refactors the custom SoupProxyResolver to GSimpleProxyResolver
which provides same functionality in gio.

No new tests, because there is not behavior change.

  • PlatformEfl.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • platform/network/soup/ProxyResolverSoup.cpp: Removed.
  • platform/network/soup/ProxyResolverSoup.h: Removed.
  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::setHTTPProxy): Moved to private member.
(WebCore::SoupNetworkSession::httpProxy): Deleted because nobody calls it.

  • platform/network/soup/SoupNetworkSession.h:
6:48 PM Changeset in webkit [184609] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r184595.
https://bugs.webkit.org/show_bug.cgi?id=145197

Introduced a crash in 15 layout tests on Mavericks on #webkit
(Requested by rniwa on #webkit).

Reverted changeset:

"Media Controls stop updating after hovering for a few
seconds."
https://bugs.webkit.org/show_bug.cgi?id=144770
http://trac.webkit.org/changeset/184595

6:19 PM Changeset in webkit [184608] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32-branch/Source

Versioning.

6:19 PM Changeset in webkit [184607] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebCore

Merge r184589. <rdar://problem/21009192>

6:13 PM Changeset in webkit [184606] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.1.32.3

New Tag.

6:01 PM Changeset in webkit [184605] by clopez@igalia.com
  • 4 edits in trunk/Source

REGRESSION(r181571): Build broken when USE(OPENGL_ES_2) is defined.
https://bugs.webkit.org/show_bug.cgi?id=145156

Reviewed by Alex Christensen.

Source/ThirdParty/ANGLE:

  • include/GLES2/gl2softlinking.h: Revert r181589. Vertex Array Objects are not in GLESv2.

Source/WebCore:

No new tests, no behavior changes.

Vertex Array Objects are not available in OpenGLESv2.
Add guards to avoid using this when building with GLESv2.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::createVertexArray):
(WebCore::GraphicsContext3D::deleteVertexArray):
(WebCore::GraphicsContext3D::isVertexArray):
(WebCore::GraphicsContext3D::bindVertexArray):

5:57 PM Changeset in webkit [184604] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.16-branch/Source/WebCore

Merged r179010. rdar://problem/21008308

5:55 PM Changeset in webkit [184603] by bshafiei@apple.com
  • 7 edits in branches/safari-600.1.4.16-branch/Source/WebCore

Merged r183788. rdar://problem/21008265

5:35 PM Changeset in webkit [184602] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Improve Preview for NodeList / array like collections
https://bugs.webkit.org/show_bug.cgi?id=145177

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-19
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/InjectedScriptSource.js:

(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
For "array" like object previews skip over non-index properties.
We are not marking the object as lossless by choice, but we
may return to this decision later.

Source/WebInspectorUI:

  • UserInterface/Views/ObjectPreviewView.js:

(WebInspector.ObjectPreviewView.prototype._appendPreview):
Show the class name for a non-basic-Array, but still hide
it for a basic Array.

LayoutTests:

  • inspector/model/remote-object-expected.txt:
4:59 PM Changeset in webkit [184601] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Upper half of volume control should be filled, not hollow.
https://bugs.webkit.org/show_bug.cgi?id=145187.
<rdar://problem/21021970>

Reviewed by Dean Jackson.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.drawVolumeBackground):

4:09 PM Changeset in webkit [184600] by msaboff@apple.com
  • 8 edits in trunk/Source

REGRESSION(183787): JIT is enabled for all builds
https://bugs.webkit.org/show_bug.cgi?id=145179

Reviewed by Geoffrey Garen.

Eliminated the setting of ENABLE_JIT, as wtf/Platform.h has appropriate logic to
set it depending on OS and CPU type.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Only changed the way build options are initialized.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
3:52 PM Changeset in webkit [184599] by Chris Dumez
  • 5 edits in trunk

[Mac] Font lookups are flakey due to caching
https://bugs.webkit.org/show_bug.cgi?id=145180
<rdar://problem/21012406>

Reviewed by Darin Adler.

Source/WebCore:

Font lookups were flakey on Mac due to the cache in fontWithFamily().
The reason is that the "desired family" to "available family" mapping
is sometimes dependent on the desired traits. However, our cache was
only using the "desired family" as key.

This patch now uses a std::pair as key containing both the "desired
family" and the "desired traits" for correctness. I also updated the
cache to use WTF types instead of NS types.

Test: platform/mac/fast/text/font-weights.html

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::desiredFamilyToAvailableFamilyMap):
(WebCore::hasDesiredFamilyToAvailableFamilyMapping):
(WebCore::rememberDesiredFamilyToAvailableFamilyMapping):
(WebCore::fontWithFamily):
(WebCore::invalidateFontCache):
(WebCore::desiredFamilyToAvailableFamilyDictionary): Deleted.

LayoutTests:

  • platform/mac/TestExpectations:

Unskip platform/mac/fast/text/font-weights.html as it is no longer
flakey after this change.

  • platform/mac/fast/text/font-weights-expected.txt:

Rebaseline the test as the expected results were those based on the
bad caching behavior.

3:22 PM Changeset in webkit [184598] by beidson@apple.com
  • 13 edits
    4 adds in trunk

X-Frame-Options headers not respected when loading from application cache.
<rdar://problem/14877623> and https://bugs.webkit.org/show_bug.cgi?id=131800

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/appcache/x-frame-options-prevents-framing.php

This patch updates SubstituteData to hold on to a ResourceResponse instead of just a URL.

It also updates all users of SubstituteData to reflect this.

Finally it updates ApplicationCacheHost to put the full response (including x-frame-options header)
in the SubstituteData so they can be checked at the appropriate times.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::handleSubstituteDataLoadNow):
(WebCore::DocumentLoader::responseReceived): Update an ASSERT to reflect that it's okay to not have

a main resource as long as you have a substitute identifier for it.

(WebCore::DocumentLoader::documentURL):
(WebCore::DocumentLoader::contentFilterDidDecide):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::defaultSubstituteDataForURL):

  • loader/SubstituteData.h:

(WebCore::SubstituteData::SubstituteData):
(WebCore::SubstituteData::shouldRevealToSessionHistory):
(WebCore::SubstituteData::mimeType):
(WebCore::SubstituteData::textEncoding):
(WebCore::SubstituteData::response):
(WebCore::SubstituteData::responseURL): Deleted.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::maybeLoadMainResource): Put the full ResourceResponse here, which

includes x-frame-options headers sent back when the resources was initially loaded from the network.

  • platform/network/ResourceResponseBase.h:

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadData):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadDataImpl):

LayoutTests:

  • http/tests/appcache/resources/x-frame-options-prevents-framing-test.html: Added.
  • http/tests/appcache/resources/x-frame-options-prevents-framing.manifest: Added.
  • http/tests/appcache/x-frame-options-prevents-framing-expected.txt: Added.
  • http/tests/appcache/x-frame-options-prevents-framing.php: Added.
3:10 PM Changeset in webkit [184597] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Add PLUGIN_ARCHITECTURE(MAC) around WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h.
https://bugs.webkit.org/show_bug.cgi?id=145173

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-19
Reviewed by Anders Carlsson.

WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h is meaningful only for Mac.
So we need to add PLUGIN_ARCHITECTURE(MAC) around it.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
2:58 PM Changeset in webkit [184596] by Brent Fulgham
  • 19 edits in trunk/Source

REGRESSION(142590): Part 2: Scroll-snap points are improperly snapping to earlier index values (Scrolling Thread)
https://bugs.webkit.org/show_bug.cgi?id=145175
<rdar://problem/21023785>

Reviewed by Beth Dakin.

Source/WebCore:

Extend the main-thread scrolling changes done in Bug 145140 to also handle Scrolling Thread snapping.
The post-layout fixup (needed to handle window resize and device orientation changes) should not fire
while Scrolling Thread scroll-snap animations are running, since these animations will most likely
move the scroll view into the proper position. If we attempt to 'fix up' the scroll position before
these animations finish, we get an ugly 'jump' in the display.

  • page/FrameView.cpp:

(WebCore::FrameView::isScrollSnapInProgress): New method based on isRubberBandInProgress, which considers
both the ScrollAnimator (main thread) scrolling, as well as the ScrollingCoordinator (Scrolling Thread)
scrolling operations. Returns true if a scroll-snap animation is still active.

  • page/FrameView.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::isScrollSnapInProgress): Added. Returns scrolling tree's
'isScrollSnapInProgress' state.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::isScrollSnapInProgress): Added default 'false' stub.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree): Use modern C++11 initializers.
(WebCore::ScrollingTree::isScrollSnapInProgress): Added.
(WebCore::ScrollingTree::setMainFrameIsScrollSnapping): Added.

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::handleWheelEvent): Update scrolling tree state to match the
ScrollController's scroll-snap state.
(WebCore::ScrollingTreeFrameScrollingNodeMac::startScrollSnapTimer): Added. When starting a scroll snap timer,
always set the scrolling tree scroll-snapping state to true.
(WebCore::ScrollingTreeFrameScrollingNodeMac::stopScrollSnapTimer): Added. When ending a scroll snap timer,
only set the scrolling tree scroll-snapping state to false if the other axis animator is inactive.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::updateScrollSnapState): Revise implementation to use its 'isScrollSnapInProgress'
method, rather than only looking at the ScrollAnimator (main thread) state.

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::isScrollSnapInProgress): Added.

  • platform/cocoa/ScrollController.h:
  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::hasActiveScrollSnapTimerForAxis): Added. Reports if the scroll snap animation
timer on the requested axis is running or not.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::isScrollSnapInProgress): Added.

  • rendering/RenderLayer.h:

Source/WebKit2:

Add a stub implementation of isScrollSnapInProgress to match ScrollingCoordinator signature.

  • WebProcess/Scrolling/RemoteScrollingCoordinator.h:
  • WebProcess/Scrolling/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::isScrollSnapInProgress): Added stub.

2:52 PM Changeset in webkit [184595] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createBase):
We should never hide controls immediately as a result of mousing out of the controls.
It should only happen when the mouse leaves the video entirely.
(Controller.prototype.updateTimelineMetricsIfNeeded):
Don’t update if controls are hidden, timeline dimensions will be 0.
(Controller.prototype.handlePanelTransitionEnd):
Instead of adjusting visibility via adding and removing classes,
remove controls entirely from the tree.
(Controller.prototype.showControls):
Add controls back into the tree when showing controls.
(Controller.prototype.updateForShowingControls):
Helper method for showControls.
(Controller.prototype.controlsAreHidden):
Controls also hidden if removed from tree.

Remove forceUpdate logic, no longer necessary.
(Controller.prototype.handleDurationChange):
(Controller.prototype.updateProgress):
(Controller.prototype.updateTime):

Override methods to use add and remove panelContainer for iOS.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.handlePanelTransitionEnd):
(ControllerIOS.prototype.showControls):
(ControllerIOS.prototype.controlsAreHidden):

2:49 PM Changeset in webkit [184594] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix. Don't fall into an infinite loop when value (renamed from bytes) is zero.

  • public/v2/manifest.js:

(App.Manifest.Ember.Controller.extend.):
(App.Manifest.Ember.Controller.extend):

2:46 PM Changeset in webkit [184593] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.32.2.3/Source/WebCore

Merged r184406.

2:45 PM Changeset in webkit [184592] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merged r184406.

2:39 PM Changeset in webkit [184591] by rniwa@webkit.org
  • 6 edits in trunk/Websites/perf.webkit.org

Don't show unit (bytes) separaetly from SI suffixes (K, M, etc...)
https://bugs.webkit.org/show_bug.cgi?id=145181

Rubber-stamped by Chris Dumez.

Show 'MB' in each y-axis label instead of showing 'bytes' separately and suffixing each label with just 'M'
for clarity. This change also reduces the code complexity.

  • public/index.html:
  • public/v2/app.js:

(App.AnalysisTaskController._chartDataChanged):
(App.TestGroupPane._createConfigurationSummary):

  • public/v2/data.js:

(RunsData.unitFromMetricName): Use 'B' instead of 'bytes' as the unit.

  • public/v2/interactive-chart.js: Removed the support for showing units separately.

(App.InteractiveChartComponent._constructGraphIfPossible):
(App.InteractiveChartComponent._relayoutDataAndAxes)

  • public/v2/manifest.js:

(App.Manifest._makeFormatter): Renamed from _formatBytes. Support more SI suffixes such as micro and mili.
Now takes the unit as the first argument. Adjust the base unit if it's 'ms'.
(App.Manifest._formatFetchedData): Removed unit and formatWithUnit now that all all formatters would
automatically include unit.

2:37 PM Changeset in webkit [184590] by andersca@apple.com
  • 3 edits in trunk/Tools

Add alternate menu items for performing operations on the default data store
https://bugs.webkit.org/show_bug.cgi?id=145184

Reviewed by Sam Weinig.

This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
associated with a data store.

  • MiniBrowser/mac/AppDelegate.m:

(-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
(-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
(-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):

  • MiniBrowser/mac/MainMenu.xib:
2:27 PM Changeset in webkit [184589] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Scroll-snap animations should not start on axes with zero-delta
https://bugs.webkit.org/show_bug.cgi?id=145148

Reviewed by Dean Jackson.

Don't begin a scroll snap animation on an axis that had no change in position (on that axis)
during the gesture.

  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::processWheelEventForScrollSnapOnAxis): Don't begin a scroll snap
animation if no movement on this axis was ever made.

2:12 PM Changeset in webkit [184588] by youenn.fablet@crf.canon.fr
  • 4 edits in trunk

AudioContext should resolve promises with jsUndefined() and not jsNull()
https://bugs.webkit.org/show_bug.cgi?id=145063

Reviewed by Sam Weinig.

Source/WebCore:

Covered by updated test.

  • bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve): resolving std::nullptr_t as jsUndefined() and not jsNull()

LayoutTests:

  • webaudio/audiocontext-state.html: Added check of promise resolve value.
1:53 PM Changeset in webkit [184587] by eric.carlson@apple.com
  • 10 edits
    54 adds
    4 deletes in trunk/LayoutTests

iOS gardening. Update "fast" image and text results, delete wk2-only results.

Rubber-stamped by Brent Fulgham.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator-wk2/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/forms/search-vertical-alignment-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/forms/searchfield-heights-expected.txt: Removed.
  • platform/ios-simulator-wk2/fast/gradients/list-item-gradient-expected.txt: Removed.
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/fast/attachment/attachment-select-on-click-expected.txt: Added.
  • platform/ios-simulator/fast/attachment/attachment-select-on-click-inside-user-select-all-expected.txt: Added.
  • platform/ios-simulator/fast/backgrounds/selection-background-color-of-image-list-style-expected.txt: Added.
  • platform/ios-simulator/fast/backgrounds/selection-background-color-of-list-style-expected.txt: Added.
  • platform/ios-simulator/fast/block/basic/001-expected.png: Added.
  • platform/ios-simulator/fast/block/margin-collapse/001-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/001-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/002-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/003-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/004-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/005-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/006-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/007-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/008-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/009-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/010-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/011-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/012-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/013-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/014-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/015-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/016-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/017-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/018-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/019-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/020-expected.png: Added.
  • platform/ios-simulator/fast/block/positioning/021-expected.png: Added.
  • platform/ios-simulator/fast/css/font-weight-1-expected.png: Added.
  • platform/ios-simulator/fast/css/font-weight-1-expected.txt:
  • platform/ios-simulator/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
  • platform/ios-simulator/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/ios-simulator/fast/events/touch/gesture/long-press-on-draggable-element-triggers-drag-expected.txt:
  • platform/ios-simulator/fast/forms/box-shadow-override-expected.png: Added.
  • platform/ios-simulator/fast/forms/button-align-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-auto-fill-button-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-auto-fill-button-expected.txt: Added.
  • platform/ios-simulator/fast/forms/input-spaces-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-table-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-text-click-inside-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-text-click-outside-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-text-double-click-expected.png: Added.
  • platform/ios-simulator/fast/forms/input-text-drag-down-expected.png: Added.
  • platform/ios-simulator/fast/forms/listbox-hit-test-zoomed-expected.png: Added.
  • platform/ios-simulator/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/ios-simulator/fast/forms/option-index-expected.png: Added.
  • platform/ios-simulator/fast/forms/search-vertical-alignment-expected.png: Added.
  • platform/ios-simulator/fast/forms/search-vertical-alignment-expected.txt:
  • platform/ios-simulator/fast/forms/searchfield-heights-expected.png: Added.
  • platform/ios-simulator/fast/forms/searchfield-heights-expected.txt:
  • platform/ios-simulator/fast/forms/textarea-placeholder-pseudo-style-expected.png: Added.
  • platform/ios-simulator/fast/frames/calculate-fixed-expected.png: Added.
  • platform/ios-simulator/fast/frames/calculate-order-expected.png: Added.
  • platform/ios-simulator/fast/frames/calculate-percentage-expected.png: Added.
  • platform/ios-simulator/fast/frames/calculate-relative-expected.png: Added.
  • platform/ios-simulator/fast/frames/calculate-round-expected.png: Added.
  • platform/ios-simulator/fast/frames/content-opacity-1-expected.png: Added.
  • platform/ios-simulator/fast/frames/content-opacity-2-expected.png: Added.
  • platform/ios-simulator/fast/gradients/list-item-gradient-expected.png: Added.
  • platform/ios-simulator/fast/gradients/list-item-gradient-expected.txt:
  • platform/ios-simulator/fast/hidpi/broken-image-icon-very-hidpi-expected.txt: Added.
  • platform/ios-simulator/fast/images/animated-gif-with-offsets-expected.png: Added.
1:07 PM Changeset in webkit [184586] by youenn.fablet@crf.canon.fr
  • 5 edits in trunk/Source/JavaScriptCore

Rename createIterResultObject as createIteratorResultObject
https://bugs.webkit.org/show_bug.cgi?id=145116

Reviewed by Darin Adler.

Renamed createIterResultObject as createIteratorResultObject.
Made this function exportable for future use by streams API.

  • runtime/IteratorOperations.cpp:

(JSC::createIteratorResultObject):

  • runtime/IteratorOperations.h:
  • runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototypeFuncNext):

  • runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototypeFuncNext):

1:02 PM Changeset in webkit [184585] by youenn.fablet@crf.canon.fr
  • 7 edits in trunk/Source/WebCore

[Streams API] Migrate closed promise handling from ReadableStreamReader to ReadableStream
https://bugs.webkit.org/show_bug.cgi?id=145110

Reviewed by Darin Adler.

Reader is now just checking whether it is the reader locking the stream or not.
If not and stream is readable, it resolves the closed promise.
Otherwise, it delegates the promise handling to its stream.

No change in behavior.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::cleanCallbacks): Cleaning of closed callbacks.
(WebCore::ReadableStream::changeStateToClosed): Resolving closed promise if set.
(WebCore::ReadableStream::changeStateToErrored): Rejecting closed promise if set.
(WebCore::ReadableStream::getReader): Removed reader state notification.
(WebCore::ReadableStream::closed): Moved from reader to stream.

  • Modules/streams/ReadableStream.h:

(WebCore::ReadableStream::reader): Added to allow reader to check whether it is locking its stream or not.
(WebCore::ReadableStream::isReadable): Added as an improvement over internalState which is removed.
(WebCore::ReadableStream::internalState): Deleted.

  • Modules/streams/ReadableStreamReader.cpp:

(WebCore::ReadableStreamReader::closed):

  • Modules/streams/ReadableStreamReader.h: Removed state and closed promise callbacks.
  • bindings/js/JSReadableStreamControllerCustom.cpp:

(WebCore::JSReadableStreamController::close): Refactoring of internalState to isReadable.
(WebCore::JSReadableStreamController::error): Ditto.

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed): Refactoring to have the promise value as callback parameter.

12:59 PM Changeset in webkit [184584] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove use of deprecated AVKit SPI cancelOptimizedFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=145159

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-05-19
Reviewed by Eric Carlson.

Remove cancelOptimizedFullscreen, and use stopOptimizedFullscreen instead.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal):

  • platform/spi/cocoa/AVKitSPI.h: remove declaration.
12:56 PM Changeset in webkit [184583] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals.
https://bugs.webkit.org/show_bug.cgi?id=145158

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-05-19
Reviewed by Eric Carlson.

  • UIProcess/ios/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):

12:51 PM Changeset in webkit [184582] by Yusuke Suzuki
  • 23 edits
    1 copy in trunk

Array.prototype methods must use ToLength
https://bugs.webkit.org/show_bug.cgi?id=144128

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Per https://people.mozilla.org/~jorendorff/es6-draft.html#sec-tolength

This patch introduces ToLength and ToInteger JS implementation to encourage the DFG/FTL's inlining.
These implementations are located in GlobalObject.js.
And set to the JSGlobalObject with the private symbols @ToLength and @ToInteger manually.

  • builtins/Array.prototype.js:

(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):

  • builtins/ArrayConstructor.js:

(from):

  • builtins/GlobalObject.js: Copied from Source/JavaScriptCore/builtins/StringConstructor.js.

(ToInteger):
(ToLength):

  • builtins/StringConstructor.js:

(raw):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObjectFunctions.h:

LayoutTests:

  • fast/profiler/built-in-function-calls-anonymous-expected.txt:
  • fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
  • js/array-every-expected.txt:
  • js/array-fill-expected.txt:
  • js/array-filter-expected.txt:
  • js/array-find-expected.txt:
  • js/array-findIndex-expected.txt:
  • js/array-functions-non-arrays-expected.txt:
  • js/array-includes-expected.txt:
  • js/script-tests/array-every.js:

(throwError):

  • js/script-tests/array-fill.js:

(throwError):

  • js/script-tests/array-filter.js:

(throwError):

  • js/script-tests/array-find.js:

(throwError):

  • js/script-tests/array-findIndex.js:

(toObject):
(throwError):

  • js/script-tests/array-functions-non-arrays.js:

(throwError):

  • js/script-tests/array-includes.js:
12:31 PM Changeset in webkit [184581] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix the build of a universal binary with ARMv7k of JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=145143

Reviewed by Geoffrey Garen.

The offlineasm works in 3 phases:

Phase 1:

Parse the llint asm files for config options and desired offsets.
Let's say the offlineasm discovers C unique options and O unique offsets.
The offlineasm will then generate a LLIntDesiredOffsets.h file with
C x C build configurations, each with a set of O offsets.

Each of these build configurations is given a unique configuration index number.

Phase 2:

Compile the LLIntDesiredOffsets.h file into a JSCLLIntOffsetsExtractor binary.

If we're building a fat binary with 2 configurations: armv7, and armv7k,
then the fat binary will contain 2 blobs of offsets, one for each of these
build configurations.

Phase 3:

Parse the llint asm files and emit asm code using the offsets that are
extracted from the JSCLLIntOffsetsExtractor binary for the corresponding
configuration index number.

In the pre-existing code, there are no "if ARMv7k" statements in the llint asm
source. As a result, OFFLINE_ASM_ARMv7k is not one of the config options in
the set of C unique options.

For armv7k builds, OFFLINE_ASM_ARMv7 is also true. As a result, for an armv7k
target, we will end up building armv7 source. In general, this is fine except:

  1. armv7k has different alignment requirements from armv7. Hence, their offset values (in JSCLLIntOffsetsExtractor) will be different.
  1. The offlineasm was never told that it needed to make a different configuration for armv7k builds. Hence, the armv7k build of LLIntDesiredOffsets.h will build the armv7 configuration, and consequently, the armv7k blob of offsets in JSCLLIntOffsetsExtractor will have the same configuration index number as the armv7 blob of offsets.

In phase 3, when the offlineasm parses the JSCLLIntOffsetsExtractor fat binary
looking for the armv7 build's configuration index number, it discovers the
armv7k blob which has the same configuration number. As a result, it
erroneously thinks the armv7k offsets are appropriate for emitting armv7 code.
Needless to say, armv7 code using armv7k offsets will lead to incorrect behavior
and all round badness.

The fix is to add a simple "if ARMv7k" statement to the llint asm files. While
the if statement has no body, it does make the offlineasm aware of the need for
ARMv7k as a configuration option. As a result, it will generate an armv7k
variant configuration in the LLIntDesiredOffsets.h file with its own unique
configuration index number. With that, the JSCLLIntOffsetsExtractor fat binary
will no longer have duplicate configuration index numbers for the armv7 and
armv7k blobs of offsets, and the issue is resolved.

  • llint/LLIntOfflineAsmConfig.h:
  • llint/LowLevelInterpreter.asm:
12:24 PM Changeset in webkit [184580] by bshafiei@apple.com
  • 3 edits in branches/safari-600.7-branch/Source/JavaScriptCore

Merge patch for r182827. rdar://problem/20977128.

11:15 AM Changeset in webkit [184579] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.1.32.2.3

New Tag.

11:13 AM Changeset in webkit [184578] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

10:49 AM Changeset in webkit [184577] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Merged anonymous blocks should invalidate simple line layout path.
https://bugs.webkit.org/show_bug.cgi?id=145104
rdar://problem/20980930

Reviewed by Antti Koivisto.

When anonymous blocks are merged together, it's not guaranteed that the final block can use simple line layout.
This patch ensures that the flow block, where the other block's content gets moved to, is no longer on simple line layout path.
Whether the final flow block ends up using inline boxes or simple line layout will be determined during the next layout.

Source/WebCore:

Test: fast/block/crash-when-anonymous-blocks-are-merged-with-simple-line-layout.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::insertChildInternal):

LayoutTests:

  • fast/block/crash-when-anonymous-blocks-are-merged-with-simple-line-layout-expected.txt: Added.
  • fast/block/crash-when-anonymous-blocks-are-merged-with-simple-line-layout.html: Added.
10:26 AM Changeset in webkit [184576] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::RenderLayer::updateScrollbarsAfterLayout
https://bugs.webkit.org/show_bug.cgi?id=145142

Reviewed by Simon Fraser.

I have not been able to reproduce this crash, but according to symbolication
m_vBar is null. It seems like this crash was probably caused by
http://trac.webkit.org/changeset/173668 which made it so that overflow:scroll
behaves like overflow:auto when the scrollbars are overlay. I can see how you
could encounter this crash with that change if the layout caused
styleRequiresScrollbar() to return true when it used to return false. Then this
code, by failing to null-check the scrollbars, assumes that
styleRequiresScrollbar() could not have changed based on a layout. But it could
change if the css changed the scrollbars to be custom or if the user managed
switch to legacy style scrollbars at just the wrong time. Or I suppose it could
also happen if the user has legacy scrollbars and the style switched from auto to
scroll during the layout.

Anyway, we should null-check the scrollbars. This is a speculative fix.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollbarsAfterLayout):

10:06 AM Changeset in webkit [184575] by akling@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Give JSString a StringView getter and start using it.
<https://webkit.org/b/145131>

Reviewed by Anders Carlsson.

When JSString is a substring internally, calling value(ExecState*) on it
will reify the baseString/start/length tuple into a new StringImpl.

For clients that only want to look at the characters of a JSString, but
don't actually need a reffable StringImpl, adding a light-weight StringView
getter lets them avoid constructing anything.

This patch adds JSString::view(ExecState*) and uses it in a few places.
There are many more opportunities to use this API, but let's do a few things
at a time.

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::parseInt):
(JSC::jsToNumber):
(JSC::parseFloat):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/JSString.cpp:

(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):

  • runtime/JSString.h:

(JSC::JSRopeString::view):
(JSC::JSString::view):

9:46 AM Changeset in webkit [184574] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merge r184513. rdar://problem/21006738

9:46 AM Changeset in webkit [184573] by matthew_hanson@apple.com
  • 3 edits
    3 adds in branches/safari-601.1.32.2-branch

Merge r184510. rdar://problem/21004989

9:46 AM Changeset in webkit [184572] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merge r184439. rdar://problem/20975978

9:46 AM Changeset in webkit [184571] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch

Merge r183912. rdar://problem/20926150

9:46 AM Changeset in webkit [184570] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merge r184433. rdar://problem/20877518

9:46 AM Changeset in webkit [184569] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184542. rdar://problem/20679710

9:46 AM Changeset in webkit [184568] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184540. rdar://problem/20679710

9:37 AM Changeset in webkit [184567] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[SOUP] Use st_birthtime to get creation time of files on systems support it
https://bugs.webkit.org/show_bug.cgi?id=144989

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2015-05-19
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

FreeBSD and NetBSD have either st_birthtime field or compatiblity macro
with the same name in stat. It is better to use it instead of manually
setting xattr, which is unreliable because both operating systems and
file systems support are required.

  • NetworkProcess/cache/NetworkCacheFileSystemPosix.h:

(WebKit::NetworkCache::fileTimes):

  • NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::IOChannel::IOChannel):

Source/WTF:

Define HAVE(STAT_BIRTHTIME) as 1 on operating systems supporting
getting creation time of files using st_birthtime in stat.

  • wtf/Platform.h:
9:29 AM Changeset in webkit [184566] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/xml.
https://bugs.webkit.org/show_bug.cgi?id=145046

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-05-19
Reviewed by Chris Dumez.

No new tests, no new tests.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):

  • xml/XPathExpressionNode.cpp:

(WebCore::XPath::Expression::setSubexpressions):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunSum::evaluate):
(WebCore::XPath::populateFunctionMap):

  • xml/XPathNodeSet.cpp:

(WebCore::XPath::NodeSet::traversalSort):

  • xml/XPathParser.cpp:

(WebCore::XPath::populateAxisNamesMap):

  • xml/XPathPath.cpp:

(WebCore::XPath::Filter::evaluate):
(WebCore::XPath::LocationPath::evaluate):

  • xml/XPathPredicate.cpp:

(WebCore::XPath::EqTestOp::compare):
(WebCore::XPath::Union::evaluate):

  • xml/XPathStep.cpp:

(WebCore::XPath::Step::optimize):
(WebCore::XPath::Step::predicatesAreContextListInsensitive):
(WebCore::XPath::Step::evaluate):
(WebCore::XPath::nodeMatches):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::~XSLStyleSheet):
(WebCore::XSLStyleSheet::isLoading):
(WebCore::XSLStyleSheet::clearDocuments):
(WebCore::XSLStyleSheet::locateStylesheetSubResource):

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::xsltParamArrayFromParameterMap):

9:26 AM Changeset in webkit [184565] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Improve text rendering of placeholder
https://bugs.webkit.org/show_bug.cgi?id=145135

Reviewed by Eric Carlson.

  • Modules/mediacontrols/mediaControlsApple.css: The <p> elements of the wireless playback

text are being popped out into separate layers, causing the text to render antialiased, which
looks bad on non-retina machines. Explicitly set the background color (which is ok since the
container element for the placeholder is also black). Also extend the height out 1pt to prevent
clipping of descenders.
(audio::-webkit-media-controls-wireless-playback-text-top): Set background color to black and add
1 to the height.
(audio::-webkit-media-controls-wireless-playback-text-bottom): Ditto.

9:24 AM Changeset in webkit [184564] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Current time display should be right-aligned
https://bugs.webkit.org/show_bug.cgi?id=145163
rdar://problem/21014339

Reviewed by Eric Carlson.

  • Modules/mediacontrols/mediaControlsiOS.css: Use flex-start and flex-end

instead of right and left, similar to the Mac controls.
(video::-webkit-media-controls-current-time-display):
(video::-webkit-media-controls-time-remaining-display):

9:09 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
8:48 AM Changeset in webkit [184563] by Chris Fleizach
  • 3 edits
    2 adds in trunk

AX: Select text mechanism returns results outside of text control regions
https://bugs.webkit.org/show_bug.cgi?id=145041

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The behavior of the select text mechanism (inside accessibility) should make sure that results
returned stay within text control elements if the search was initiated inside a text control element.

Test: platform/mac/accessibility/select-text-stays-inside-text-controls.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::rangeClosestToRange):
(WebCore::AccessibilityObject::selectText):

LayoutTests:

  • platform/mac/accessibility/select-text-stays-inside-text-controls-expected.txt: Added.
  • platform/mac/accessibility/select-text-stays-inside-text-controls.html: Added.
8:10 AM Changeset in webkit [184562] by matthew_hanson@apple.com
  • 10 edits in branches/safari-601.1.32-branch/Source

Merge custom patch. rdar://problem/20950052

6:26 AM Changeset in webkit [184561] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Gardening 19th May
https://bugs.webkit.org/show_bug.cgi?id=145166

Unreviewed.

Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-19

  • platform/gtk/TestExpectations:
6:22 AM Changeset in webkit [184560] by eric.carlson@apple.com
  • 3 edits
    316 adds
    155 deletes in trunk/LayoutTests

iOS gardening. Update "editing" image and text results, delete wk2-only results.

Rubber-stamped by Brent Fulgham.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator-wk2/editing/deleting/delete-3775172-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-3857753-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-3865854-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-3928305-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-4083333-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-and-undo-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-contents-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-004-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-005-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-006-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-007-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-008-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-009-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-010-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-011-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-012-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-013-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-014-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-015-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-016-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-017-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-018-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-019-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-020-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-021-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-022-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-023-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-block-merge-contents-024-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-br-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-br-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-br-007-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-br-008-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-br-010-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-character-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-contiguous-ws-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-first-list-item-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-hr-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-image-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-image-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-image-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-004-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-005-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-006-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-007-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-008-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-009-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-010-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-012-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-013-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-014-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-015-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-016-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-line-017-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-listitem-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-listitem-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-selection-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-tab-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-tab-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-to-select-table-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-trailing-ws-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-trailing-ws-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-ws-fixup-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-ws-fixup-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-ws-fixup-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/delete-ws-fixup-004-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/forward-delete-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/list-item-1-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/merge-different-styles-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/merge-endOfParagraph-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/merge-no-br-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/merge-unrendered-space-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/non-smart-delete-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/pruning-after-merge-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/smart-delete-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/deleting/table-cells-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/4641880-1-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/4641880-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/create-list-with-hr-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/indent-empty-root-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/indent-list-item-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/indent-selection-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/insert-list-and-stitch-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/insertHorizontalRule-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/insertImage-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/nsresponder-indent-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/nsresponder-outdent-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/print-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/execCommand/remove-list-from-range-selection-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/pasteboard/4989774-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/3690703-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/3690703-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/3690719-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/4397952-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/4889598-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/4932260-1-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/4932260-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/4932260-3-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/4947387-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/5195166-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/7152-1-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/7152-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/after-line-wrap-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/focus_editable_html-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/iframe-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/image-before-linebreak-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/inline-table-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/leave-requested-block-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/mixed-editability-10-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/mixed-editability-3-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/mixed-editability-4-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/mixed-editability-5-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/mixed-editability-8-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/mixed-editability-9-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-3875618-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-3875641-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-backwords-by-word-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-between-blocks-no-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-between-blocks-yes-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-character-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-character-002-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-character-003-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-character-004-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-character-005-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-character-6-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-by-sentence-001-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/move-past-trailing-space-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/previous-line-position-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/replaced-boundaries-1-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/replaced-boundaries-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/replaced-boundaries-3-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/select-all-005-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/select-all-006-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/select-box-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/select-element-paragraph-boundary-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/selection-3748164-fix-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/table-caret-1-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/table-caret-2-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/table-caret-3-expected.txt: Removed.
  • platform/ios-simulator-wk2/editing/selection/unrendered-space-expected.txt: Removed.
  • platform/ios-simulator/editing/deleting/delete-3608462-fix-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-3608462-fix-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-3775172-fix-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-3857753-fix-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-3857753-fix-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-3865854-fix-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-3865854-fix-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-3928305-fix-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-3928305-fix-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-4083333-fix-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-4083333-fix-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-and-undo-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-and-undo-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-004-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-004-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-005-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-005-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-006-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-006-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-007-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-007-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-008-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-008-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-009-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-009-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-010-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-010-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-011-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-at-paragraph-boundaries-011-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-contents-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-contents-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-004-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-004-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-005-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-006-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-007-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-008-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-009-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-009-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-010-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-010-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-011-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-011-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-012-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-012-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-013-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-013-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-014-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-014-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-015-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-015-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-016-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-016-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-017-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-017-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-018-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-018-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-019-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-019-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-020-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-020-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-021-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-021-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-022-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-022-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-023-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-023-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-024-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-block-merge-contents-024-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-br-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-br-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-br-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-br-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-br-007-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-br-007-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-br-008-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-br-008-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-br-010-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-br-010-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-character-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-character-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-contiguous-ws-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-contiguous-ws-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-first-list-item-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-first-list-item-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-hr-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-hr-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-image-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-image-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-image-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-image-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-image-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-image-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-004-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-004-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-005-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-005-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-006-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-006-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-007-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-007-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-008-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-008-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-009-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-009-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-010-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-010-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-012-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-012-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-013-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-013-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-014-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-014-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-015-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-015-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-016-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-016-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-line-017-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-line-017-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-listitem-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-listitem-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-listitem-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-listitem-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-selection-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-selection-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-tab-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-tab-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-tab-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-tab-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-to-select-table-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-to-select-table-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-trailing-ws-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-trailing-ws-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-trailing-ws-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-trailing-ws-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-002-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-002-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-003-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-003-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-004-expected.png: Added.
  • platform/ios-simulator/editing/deleting/delete-ws-fixup-004-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/forward-delete-expected.png: Added.
  • platform/ios-simulator/editing/deleting/forward-delete-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/list-item-1-expected.png: Added.
  • platform/ios-simulator/editing/deleting/list-item-1-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/merge-different-styles-expected.png: Added.
  • platform/ios-simulator/editing/deleting/merge-different-styles-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/merge-endOfParagraph-expected.png: Added.
  • platform/ios-simulator/editing/deleting/merge-endOfParagraph-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/merge-no-br-expected.png: Added.
  • platform/ios-simulator/editing/deleting/merge-no-br-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/merge-unrendered-space-expected.png: Added.
  • platform/ios-simulator/editing/deleting/merge-unrendered-space-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/non-smart-delete-expected.png: Added.
  • platform/ios-simulator/editing/deleting/non-smart-delete-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/pruning-after-merge-2-expected.png: Added.
  • platform/ios-simulator/editing/deleting/pruning-after-merge-2-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/smart-delete-001-expected.png: Added.
  • platform/ios-simulator/editing/deleting/smart-delete-001-expected.txt: Added.
  • platform/ios-simulator/editing/deleting/table-cells-expected.png: Added.
  • platform/ios-simulator/editing/deleting/table-cells-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/4641880-1-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/4641880-1-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/4641880-2-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/4641880-2-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/5142012-1-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/5142012-1-expected.txt:
  • platform/ios-simulator/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/create-list-with-hr-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/indent-empty-root-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/indent-empty-root-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/indent-list-item-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/indent-list-item-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/indent-selection-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/indent-selection-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/insert-list-and-stitch-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/insert-list-and-stitch-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/insertHorizontalRule-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/insertHorizontalRule-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/insertImage-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/insertImage-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/nsresponder-indent-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/nsresponder-indent-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/nsresponder-outdent-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/nsresponder-outdent-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/print-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/print-expected.txt: Added.
  • platform/ios-simulator/editing/execCommand/remove-list-from-range-selection-expected.png: Added.
  • platform/ios-simulator/editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
  • platform/ios-simulator/editing/pasteboard/4989774-expected.png: Added.
  • platform/ios-simulator/editing/pasteboard/4989774-expected.txt: Added.
  • platform/ios-simulator/editing/pasteboard/drag-drop-dead-frame-expected.png: Added.
  • platform/ios-simulator/editing/selection/3690703-2-expected.png: Added.
  • platform/ios-simulator/editing/selection/3690703-2-expected.txt: Added.
  • platform/ios-simulator/editing/selection/3690703-expected.png: Added.
  • platform/ios-simulator/editing/selection/3690703-expected.txt: Added.
  • platform/ios-simulator/editing/selection/3690719-expected.png: Added.
  • platform/ios-simulator/editing/selection/3690719-expected.txt: Added.
  • platform/ios-simulator/editing/selection/4397952-expected.png: Added.
  • platform/ios-simulator/editing/selection/4397952-expected.txt: Added.
  • platform/ios-simulator/editing/selection/4889598-expected.png: Added.
  • platform/ios-simulator/editing/selection/4889598-expected.txt: Added.
  • platform/ios-simulator/editing/selection/4932260-1-expected.png: Added.
  • platform/ios-simulator/editing/selection/4932260-1-expected.txt: Added.
  • platform/ios-simulator/editing/selection/4932260-2-expected.png: Added.
  • platform/ios-simulator/editing/selection/4932260-2-expected.txt: Added.
  • platform/ios-simulator/editing/selection/4932260-3-expected.png: Added.
  • platform/ios-simulator/editing/selection/4932260-3-expected.txt: Added.
  • platform/ios-simulator/editing/selection/4947387-expected.png: Added.
  • platform/ios-simulator/editing/selection/4947387-expected.txt: Added.
  • platform/ios-simulator/editing/selection/5195166-2-expected.png: Added.
  • platform/ios-simulator/editing/selection/5195166-2-expected.txt: Added.
  • platform/ios-simulator/editing/selection/7152-1-expected.png: Added.
  • platform/ios-simulator/editing/selection/7152-1-expected.txt: Added.
  • platform/ios-simulator/editing/selection/7152-2-expected.png: Added.
  • platform/ios-simulator/editing/selection/7152-2-expected.txt: Added.
  • platform/ios-simulator/editing/selection/after-line-wrap-expected.png: Added.
  • platform/ios-simulator/editing/selection/after-line-wrap-expected.txt: Added.
  • platform/ios-simulator/editing/selection/extend-by-character-007-expected.txt: Added.
  • platform/ios-simulator/editing/selection/focus_editable_html-expected.png: Added.
  • platform/ios-simulator/editing/selection/focus_editable_html-expected.txt: Added.
  • platform/ios-simulator/editing/selection/iframe-expected.png: Added.
  • platform/ios-simulator/editing/selection/iframe-expected.txt: Added.
  • platform/ios-simulator/editing/selection/image-before-linebreak-expected.png: Added.
  • platform/ios-simulator/editing/selection/image-before-linebreak-expected.txt: Added.
  • platform/ios-simulator/editing/selection/inline-table-expected.png: Added.
  • platform/ios-simulator/editing/selection/inline-table-expected.txt: Added.
  • platform/ios-simulator/editing/selection/leave-requested-block-expected.png: Added.
  • platform/ios-simulator/editing/selection/leave-requested-block-expected.txt: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-10-expected.txt: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-3-expected.png: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-3-expected.txt: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-4-expected.png: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-4-expected.txt: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-5-expected.png: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-5-expected.txt: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-8-expected.png: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-8-expected.txt: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-9-expected.png: Added.
  • platform/ios-simulator/editing/selection/mixed-editability-9-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-3875618-fix-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-3875618-fix-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-3875641-fix-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-3875641-fix-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-backwords-by-word-001-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-backwords-by-word-001-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-between-blocks-no-001-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-between-blocks-no-001-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-between-blocks-yes-001-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-between-blocks-yes-001-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-character-001-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-character-001-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-character-002-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-character-002-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-character-003-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-character-003-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-character-004-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-character-004-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-character-005-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-character-005-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-character-6-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-character-6-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-by-sentence-001-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-by-sentence-001-expected.txt: Added.
  • platform/ios-simulator/editing/selection/move-past-trailing-space-expected.png: Added.
  • platform/ios-simulator/editing/selection/move-past-trailing-space-expected.txt: Added.
  • platform/ios-simulator/editing/selection/previous-line-position-expected.png: Added.
  • platform/ios-simulator/editing/selection/previous-line-position-expected.txt: Added.
  • platform/ios-simulator/editing/selection/range-between-block-and-inline-expected.png: Added.
  • platform/ios-simulator/editing/selection/replaced-boundaries-1-expected.png: Added.
  • platform/ios-simulator/editing/selection/replaced-boundaries-1-expected.txt: Added.
  • platform/ios-simulator/editing/selection/replaced-boundaries-2-expected.png: Added.
  • platform/ios-simulator/editing/selection/replaced-boundaries-2-expected.txt: Added.
  • platform/ios-simulator/editing/selection/replaced-boundaries-3-expected.png: Added.
  • platform/ios-simulator/editing/selection/replaced-boundaries-3-expected.txt: Added.
  • platform/ios-simulator/editing/selection/select-all-005-expected.png: Added.
  • platform/ios-simulator/editing/selection/select-all-005-expected.txt: Added.
  • platform/ios-simulator/editing/selection/select-all-006-expected.png: Added.
  • platform/ios-simulator/editing/selection/select-all-006-expected.txt: Added.
  • platform/ios-simulator/editing/selection/select-box-expected.png: Added.
  • platform/ios-simulator/editing/selection/select-box-expected.txt: Added.
  • platform/ios-simulator/editing/selection/select-element-paragraph-boundary-expected.png: Added.
  • platform/ios-simulator/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
  • platform/ios-simulator/editing/selection/selection-3748164-fix-expected.png: Added.
  • platform/ios-simulator/editing/selection/selection-3748164-fix-expected.txt: Added.
  • platform/ios-simulator/editing/selection/table-caret-1-expected.png: Added.
  • platform/ios-simulator/editing/selection/table-caret-1-expected.txt: Added.
  • platform/ios-simulator/editing/selection/table-caret-2-expected.png: Added.
  • platform/ios-simulator/editing/selection/table-caret-2-expected.txt: Added.
  • platform/ios-simulator/editing/selection/table-caret-3-expected.png: Added.
  • platform/ios-simulator/editing/selection/table-caret-3-expected.txt: Added.
  • platform/ios-simulator/editing/selection/unrendered-space-expected.png: Added.
  • platform/ios-simulator/editing/selection/unrendered-space-expected.txt: Added.
  • platform/ios-simulator/editing/unsupported-content: Added.
  • platform/ios-simulator/editing/unsupported-content/list-type-after-expected.png: Added.
4:54 AM Changeset in webkit [184559] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebInspectorUI

Unreviewed. Fix make distcheck.

  • GNUmakefile.am:
3:03 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
1:21 AM Changeset in webkit [184558] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Fix tautological-compare warning in AtomicString.cpp
https://bugs.webkit.org/show_bug.cgi?id=145120

Reviewed by Alexey Proskuryakov.

  • TestWebKitAPI/Tests/WTF/AtomicString.cpp:

(TestWebKitAPI::TEST): Removed always true assert.

12:58 AM Changeset in webkit [184557] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WTF

[GTK] Miscellaneous changes for msys/mingw
https://bugs.webkit.org/show_bug.cgi?id=143907

Patch by Milan Crha <mcrha@redhat.com> on 2015-04-17
Reviewed by Carlos Garcia Campos.

  • wtf/Platform.h: Remove autogenerated header not needed by GTK

port.

12:24 AM Changeset in webkit [184556] by Carlos Garcia Campos
  • 8 edits in releases/WebKitGTK/webkit-2.4

[GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
https://bugs.webkit.org/show_bug.cgi?id=138134

Patch by Milan Crha <mcrha@redhat.com> on 2015-04-17
Reviewed by Carlos Garcia Campos.

.:

  • GNUmakefile.am: Command line with expanded resources exceeds 32KB, which

is a limit on Windows. It's better to expand wildcards inside the
python script.

Source/WebInspectorUI:

  • GNUmakefile.am: Command line with expanded resources exceeds 32KB, which

is a limit on Windows. It's better to expand wildcards inside the
python script.

Source/WebKit2:

  • PlatformGTK.cmake: Command line with expanded resources exceeds 32KB, which

is a limit on Windows. It's better to expand wildcards inside the
python script.

Tools:

  • gtk/generate-inspector-gresource-manifest.py:

(get_filenames): Command line with expanded resources exceeds 32KB, which
is a limit on Windows. It's better to expand wildcards inside the
python script.

12:22 AM Changeset in webkit [184555] by Chris Dumez
  • 34 edits in trunk/Source

Mark static variables as const when possible
https://bugs.webkit.org/show_bug.cgi?id=145161

Reviewed by Andreas Kling.

Source/WebCore:

  • Modules/mediasession/WebMediaSessionManager.cpp:
  • Modules/mediasource/SourceBuffer.cpp:
  • Modules/webdatabase/SQLException.cpp:
  • dom/DOMCoreException.cpp:
  • inspector/NetworkResourcesData.cpp:
  • loader/icon/IconDatabase.cpp:

(WebCore::urlForLogging):

  • page/AutoscrollController.cpp:
  • page/Page.cpp:
  • platform/RuntimeApplicationChecksIOS.mm:

(WebCore::applicationIsAdSheet):
(WebCore::applicationIsMobileMail):
(WebCore::applicationIsMobileSafari):
(WebCore::applicationIsDumpRenderTree):
(WebCore::applicationIsWebApp):
(WebCore::applicationIsOkCupid):
(WebCore::applicationIsFacebook):
(WebCore::applicationIsEpicurious):
(WebCore::applicationIsDaijisenDictionary):
(WebCore::applicationIsNASAHD):
(WebCore::applicationIsMASH):
(WebCore::applicationIsTheEconomistOnIPhone):
(WebCore::applicationIsWebProcess):
(WebCore::applicationIsIBooksOnIOS):

  • platform/audio/HRTFElevation.cpp:
  • platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::processIsRunningPropertyDescriptor):
(WebCore::outputDevicePropertyDescriptor):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::toCoreTextFontWeight):
(WebCore::toAppKitFontWeight):
(WebCore::toNSFontWeight):

  • platform/mac/ScrollAnimatorMac.mm:

(supportsUIStateTransitionProgress):
(supportsExpansionTransitionProgress):
(supportsContentAreaScrolledInDirection):

  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::dataForURLComponentType):

  • platform/mock/ScrollbarThemeMock.cpp:
  • platform/text/icu/UTextProviderLatin1.cpp:
  • platform/text/ios/LocalizedDateCache.mm:

(WebCore::LocalizedDateCache::calculateMaximumWidth):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::matchedEndLine):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintTranslucentBorderSides):

  • rendering/RenderFrameBase.cpp:

(WebCore::shouldExpandFrame):

  • rendering/RenderTableSection.cpp:
  • rendering/RenderThemeIOS.mm:

(WebCore::getInsetGradient):
(WebCore::getShineGradient):
(WebCore::getShadeGradient):
(WebCore::getConvexGradient):
(WebCore::getConcaveGradient):
(WebCore::getSliderTrackGradient):
(WebCore::getReadonlySliderTrackGradient):
(WebCore::getSliderThumbOpaquePressedGradient):
(WebCore::RenderThemeIOS::paintCheckboxDecorations):
(WebCore::RenderThemeIOS::paintRadioDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::toFontWeight):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):

Source/WebKit2:

  • Platform/IPC/MessageEncoder.cpp:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::networkProcessLatencyQOS):
(WebKit::networkProcessThroughputQOS):
(WebKit::webProcessLatencyQOS):
(WebKit::webProcessThroughputQOS):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::pluginNeedsExecutableHeap):
(WebKit::pluginProcessLatencyQOS):
(WebKit::pluginProcessThroughputQOS):

  • WebProcess/WebPage/WebPage.cpp:

Source/WTF:

  • wtf/dtoa.cpp:

(WTF::pow5mult):

12:20 AM Changeset in webkit [184554] by Gyuyoung Kim
  • 3 edits in trunk/Source/WTF

[EFL] Remove unnecessary PLATFORM(EFL) macro in EFL specific files
https://bugs.webkit.org/show_bug.cgi?id=145160

Reviewed by Csaba Osztrogonác.

  • wtf/efl/EflTypedefs.h: Remove PLATFORM(EFL).
  • wtf/efl/UniquePtrEfl.h: ditto.
12:12 AM Changeset in webkit [184553] by Nikita Vasilyev
  • 8 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Convert stackTrace from raw payload data to an array of CallFrames
https://bugs.webkit.org/show_bug.cgi?id=144982

Reviewed by Joseph Pecoraro.

  • UserInterface/Controllers/LogManager.js:
  • UserInterface/Main.html:
  • UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame.fromPayload):
Consider an empty string url as a native code as it was in
WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame

  • UserInterface/Models/ConsoleMessage.js:

(WebInspector.ConsoleMessage):
Convert _stackTrace from an array of payload objects to WebInspector.StackTrace model.

  • UserInterface/Models/StackTrace.js: Added.

(WebInspector.StackTrace):
(WebInspector.StackTrace.prototype.get callFrames):
(WebInspector.StackTrace.prototype.get firstNonNativeCallFrame): Added.
(WebInspector.StackTrace.fromPayload):

  • UserInterface/Test.html:
  • UserInterface/Views/CallFrameView.js:

(WebInspector.CallFrameView):
Don't show a URL when sourceCodeLocation is missing, fix webkit.org/b/145071.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView):
(WebInspector.ConsoleMessageView.prototype.toClipboardString):
(WebInspector.ConsoleMessageView.prototype._appendLocationLink):
(WebInspector.ConsoleMessageView.prototype._appendStackTrace):
(WebInspector.ConsoleMessageView.prototype._shouldShowStackTrace):
(WebInspector.ConsoleMessageView.prototype._linkifyCallFrame):
(WebInspector.ConsoleMessageView.prototype._firstNonNativeCallFrame): Deleted.

May 18, 2015:

11:49 PM Changeset in webkit [184552] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WTF

[W32] weakCompareAndSwap assembler code is not used when building with MinGW GCC
https://bugs.webkit.org/show_bug.cgi?id=143754

Unreviewed.

Allow MinGW-GCC to use GCC asm code for weakCompareAndSwap.

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-16

  • wtf/Atomics.h:

(WTF::x86_mfence):
(WTF::weakCompareAndSwap):

11:43 PM Changeset in webkit [184551] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4

[W32] Buildsystem may use wrong Python interpreter
https://bugs.webkit.org/show_bug.cgi?id=143755

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Use confgured Python interpreter

Configure script has tests for Python (AC_PATH_PROG(PYTHON, python)),
use the interpretor they provide (which is overridable by user by
the way of passing PYTHON=... to configure) instead of the first
thing found in PATH.

Otherwise wrong version of Python might be used. Mingw-python,
for example, which has commandline length limit, which results in
errors like:
/usr/bin/env: python: Argument list too long
GNUmakefile:82317: recipe for target
'DerivedSources/WebInspectorUI/GResourceBundle.xml' failed

Source/WebInspectorUI:

  • GNUmakefile.am:

Tools:

  • gtk/GNUmakefile.am:
11:40 PM Changeset in webkit [184550] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

WebCore uses M_PI_2 instead of piOverTwoDouble
https://bugs.webkit.org/show_bug.cgi?id=143758

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Darin Adler.

Because M_PI_2 is not defined everywhere.
Fixes errors like:

CXX Source/WebCore/platform/graphics/freetype/libPlatformGtk_la-FontPlatformDataFreeType.lo

../webkitgtk-2.4.8/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp: In function 'void WebCore::rotateCairoMatrixForVerticalOrientation(cairo_matrix_t*)':
../webkitgtk-2.4.8/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp:123:34: error: 'M_PI_2' was not declared in this scope

cairo_matrix_rotate(matrix, -M_PI_2);


GNUmakefile:51663: recipe for target 'Source/WebCore/platform/graphics/freetype/libPlatformGtk_la-FontPlatformDataFreeType.lo' failed

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::rotateCairoMatrixForVerticalOrientation):

11:35 PM Changeset in webkit [184549] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

[GTK][W32] FileSystemGtk calls GetModuleHandleExA(), but does not include appropriate header
https://bugs.webkit.org/show_bug.cgi?id=143759

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Darin Adler.

Add missing includes to FileSystemGtk

Needed for GetModuleHandleExA() & Co.

  • platform/gtk/FileSystemGtk.cpp:
11:30 PM Changeset in webkit [184548] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

[W32] Compile-time assertion failure: RenderBlock_should_stay_small
https://bugs.webkit.org/show_bug.cgi?id=143760

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Move enum LineLayoutPath in RenderBlock

This removes the bitfield interruption, allowing more efficient
packing.
Otherwise compile-time assertion fails:
In file included from ../webkitgtk-2.4.8/Source/WTF/wtf/PossiblyNull.h:29:0,

from ../webkitgtk-2.4.8/Source/WTF/wtf/FastMalloc.h:27,
from ../webkitgtk-2.4.8/Source/WebCore/config.h:74,
from ../webkitgtk-2.4.8/Source/WebCore/rendering/RenderBlock.cpp:24:

../webkitgtk-2.4.8/Source/WTF/wtf/Assertions.h:326:35: error: static assertion failed: RenderBlock_should_stay_small


../webkitgtk-2.4.8/Source/WebCore/rendering/RenderBlock.cpp:88:1: note: in expansion of macro 'COMPILE_ASSERT'
COMPILE_ASSERT(sizeof(RenderBlock) == sizeof(SameSizeAsRenderBlock), RenderBlock_should_stay_small);

11:24 PM Changeset in webkit [184547] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4/Source

[W32] GraphicsContextCairoWin.cpp fails to compile: unallowed function template partial specialization
https://bugs.webkit.org/show_bug.cgi?id=143761

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Darin Adler.

Fix deleteObject prototypte, fix header case

Apparently, <T> is unneeded here:

Source/WebCore:

In file included from ../webkitgtk-2.4.8/Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:35:0:
../webkitgtk-2.4.8/Source/WTF/wtf/win/GdiObject.h:114:58: error: function template partial specialization 'deleteObject<T>' is not allowed
template<typename T> inline void deleteObject<T>(T object)


As a bonus, change GdiObject.h -> GDIObject.h (this matters when
cross-compiling or when using case-sensitive filesystems on W32).

Source/WTF:

In file included from ../webkitgtk-2.4.8/Source/WebCore/platform/graphics/win/GraphicsContextCairoWin.cpp:35:0:
../webkitgtk-2.4.8/Source/WTF/wtf/win/GdiObject.h:114:58: error: function template partial specialization 'deleteObject<T>' is not allowed

template<typename T> inline void deleteObject<T>(T object)


As a bonus, change GdiObject.h -> GDIObject.h (this matters when
cross-compiling or when using case-sensitive filesystems on W32).

  • wtf/win/GDIObject.h:

(WTF::deleteObject):

11:19 PM Changeset in webkit [184546] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/ThirdParty/ANGLE

[ANGLE][W32] Buildsystem is hardcoded for UNIX
https://bugs.webkit.org/show_bug.cgi?id=143762

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Don't hardcode ossource_posix.cpp in the makefile

Compile ossource_posix.cpp or ossource_win.cpp depending on the target.

Otherwise you get an error:
../webkitgtk-2.4.8/Source/ThirdParty/ANGLE/src/compiler/ossource_posix.cpp:13:2: error: #error Trying to build a posix specific file in a non-posix build.

  • GNUmakefile.am:
11:15 PM Changeset in webkit [184545] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

[W32][GTK] Conflict between NO_ERROR from W32API and GraphicsContext3D
https://bugs.webkit.org/show_bug.cgi?id=143768

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Work around name conflicts (NO_ERROR)

In file included from /mingw/include/_mingw.h:12:0,

from ../webkitgtk-2.4.8/Source/WTF/wtf/Compiler.h:93,
from ../webkitgtk-2.4.8/Source/WTF/wtf/Platform.h:32,
from ../webkitgtk-2.4.8/Source/JavaScriptCore/config.h:30,
from ../webkitgtk-2.4.8/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:27:

../webkitgtk-2.4.8/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp: In member function 'virtual int WebCore::Extensions3DOpenGLCommon::getGraphicsResetStatusARB()':
../webkitgtk-2.4.8/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:144:31: error: expected unqualified-id before numeric constant

return GraphicsContext3D::NO_ERROR;

because NO_ERROR is also a macro defined in Windows headers. Ouch.
Also expand this to the (PLATFORM(GTK) && OS(WINDOWS)) combination,
in addition to the workaround for VERSION already present there.

11:05 PM Changeset in webkit [184544] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

[W32] Fails to build - missing references to OpenGL context functions
https://bugs.webkit.org/show_bug.cgi?id=143769

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Also use GL-related files when compiling with MinGW
CXXLD libwebkitgtk-3.0.la
./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `GraphicsContext3DPrivate':
/src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `ZN7WebCore9GLContext14sharingContextEv'
/src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:59: undefined reference to `
ZN7WebCore9GLContext22createOffscreenContextEPS0_'
./.libs/../source/webcore/platform/graphics/.libs/libplatform_la-graphicscontext3dprivate.o: In function `platformContext':
/src/mingw/webkitgtk-2.4.8-1\bld/../webkitgtk-2.4.8/Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp:84: undefined reference to `ZN7WebCore9GLContext10getCurrentEv'

Becuase GLContext.cpp is not used, which happens because it's
under TARGET_X11_OR_WAYLAND condition in the GNUmakefile.list.am.
Move TARGET_X11_OR_WAYLAND up a bit to free up GLContext.cpp (now
only protected by USE_OPENGL).

  • GNUmakefile.list.am:
10:55 PM Changeset in webkit [184543] by Gyuyoung Kim
  • 16 edits in trunk/Source/WebCore

Use Ref instead of PassRefPtr in WebCore/bindings
https://bugs.webkit.org/show_bug.cgi?id=144981

Reviewed by Darin Adler.

As a step to purge PassRefPtr, remove PassRefPtr in WebCore/bindings.

No new tests, no behavior changes.

  • bindings/gobject/GObjectNodeFilterCondition.h:

(WebCore::GObjectNodeFilterCondition::create):

  • bindings/gobject/GObjectXPathNSResolver.h:

(WebCore::GObjectXPathNSResolver::create):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::create):

  • bindings/js/JSCustomXPathNSResolver.h:
  • bindings/js/JSDOMGlobalObjectTask.cpp:
  • bindings/js/JSErrorHandler.h:

(WebCore::JSErrorHandler::create):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::createForNode):
(WebCore::JSLazyEventListener::createForDOMWindow):

  • bindings/js/JSLazyEventListener.h:
  • bindings/js/JSMutationCallback.h:

(WebCore::JSMutationCallback::create):

  • bindings/js/JSNodeFilterCondition.h:

(WebCore::JSNodeFilterCondition::create):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):
(WebCore::SerializedScriptValue::numberValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::nullValue):

  • bindings/js/SerializedScriptValue.h:
  • bindings/objc/ObjCEventListener.h:
  • bindings/objc/ObjCEventListener.mm:

(WebCore::ObjCEventListener::wrap):

  • bindings/objc/ObjCNodeFilterCondition.h:

(WebCore::ObjCNodeFilterCondition::create):

9:46 PM Changeset in webkit [184542] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Better optimize 'if' with ternaries conditional tests.
https://bugs.webkit.org/show_bug.cgi?id=144136

Reviewed by Benjamin Poulain.

This is the last fix I'll do for this for now. BooleanToNumber(Untyped:) where the input
is proved to be either BoolInt32 or Boolean should be optimized to just masking the
lowest bit.

This is another 37% speed-up on JSRegress/slow-ternaries.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileBooleanToNumber):

8:39 PM Changeset in webkit [184541] by benjamin@webkit.org
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

<rdar://problem/21003555> cloberrize() is wrong for ArithRound because it doesn't account for the arith mode
https://bugs.webkit.org/show_bug.cgi?id=145147

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-05-18
Reviewed by Filip Pizlo.

Really stupid bug: ArithRound nodes with different rounding modes
were not distinguished and CSE would happily unify with a node of
a different rounding mode.

DFG::clobberize() already support additional data but I was not using it.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • tests/stress/math-round-arith-rounding-mode.js: Added.

(firstCareAboutZeroSecondDoesNot):
(firstDoNotCareAboutZeroSecondDoes):
(warmup):
(verifyNegativeZeroIsPreserved):

7:30 PM Changeset in webkit [184540] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add SpecBoolInt32 type that means "I'm an int and I'm either 0 or 1"
https://bugs.webkit.org/show_bug.cgi?id=145137

Reviewed by Benjamin Poulain.

It's super useful to know if an integer value could be either zero or one. We have an
immediate need for this because of Int32|Boolean uses, where knowing that the Int32 is
either 0 or 1 means that there is no actual polymorphism if you just look at the low bit
(1 behaves like true, 0 behaves like false, and the low bit of 1|true is 1, and the low
bit of 0|false is 0).

We do this by splitting the SpecInt32 type into SpecBoolInt32 and SpecNonBoolInt32. This
change doesn't have any effect on behavior, yet. But it does give us the ability to
predict and prove when values are SpecBoolInt32; it's just we don't leverage this yet.

This is perf-neutral.

  • bytecode/SpeculatedType.cpp:

(JSC::dumpSpeculation):
(JSC::speculationToAbbreviatedString):
(JSC::speculationFromValue):

  • bytecode/SpeculatedType.h:

(JSC::isStringOrStringObjectSpeculation):
(JSC::isBoolInt32Speculation):
(JSC::isInt32Speculation):
(JSC::isInt32OrBooleanSpeculation):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

7:02 PM Changeset in webkit [184539] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[EFL] Fix unsequenced warning in MiniBrowser's main.c
https://bugs.webkit.org/show_bug.cgi?id=145123

Reviewed by Gyuyoung Kim.

  • MiniBrowser/efl/main.c:

(on_key_down):

6:49 PM Changeset in webkit [184538] by mmaxfield@apple.com
  • 3 edits in trunk/LayoutTests

Improve coverage of platform/mac/fast/text/font-weights.html
https://bugs.webkit.org/show_bug.cgi?id=145152

Reviewed by Anders Carlsson.

Add coverage of italics.

  • platform/mac/fast/text/font-weights-expected.txt:
  • platform/mac/fast/text/font-weights.html:
6:39 PM Changeset in webkit [184537] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix uninitialized warnings in RealtimeMediaSourceCenterOwr.cpp
https://bugs.webkit.org/show_bug.cgi?id=145119

Reviewed by Gyuyoung Kim.

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::validateRequestConstraints):
(WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable):

6:35 PM Changeset in webkit [184536] by Michael Catanzaro
  • 21 edits in trunk

[CMake] Ignore warnings in system headers
https://bugs.webkit.org/show_bug.cgi?id=144747

Reviewed by Darin Adler.

.:

Require CMake 2.8.12 when compiling the GTK+ port. This is because we use the
target_include_directories command (added in 2.8.11) in GTK-specific cmake files, and also
use the SYSTEM argument to the command (added in 2.8.12).

  • CMakeLists.txt:

Source/JavaScriptCore:

Separate include directories into WebKit project includes and system includes. Suppress all
warnings from headers in system include directories using the SYSTEM argument to
the include_directories command.

  • CMakeLists.txt:
  • PlatformGTK.cmake:

Source/WebCore:

Separate include directories into WebKit project includes and system includes. Suppress all
warnings from headers in system include directories using the SYSTEM argument to
the include_directories command.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:

Source/WebKit:

Separate include directories into WebKit project includes and system includes. Suppress all
warnings from headers in system include directories using the SYSTEM argument to
the include_directories command.

  • CMakeLists.txt:
  • PlatformMac.cmake:

Source/WebKit2:

Separate include directories into WebKit project includes and system includes. Suppress all
warnings from headers in system include directories using the SYSTEM argument to
the include_directories command.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:

Source/WTF:

Separate include directories into WebKit project includes and system includes. Suppress all
warnings from headers in system include directories using the SYSTEM argument to
the include_directories command.

  • wtf/CMakeLists.txt:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
6:11 PM Changeset in webkit [184535] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Fix return-type warnings in test_ewk2_color_picker.cpp
https://bugs.webkit.org/show_bug.cgi?id=145122

Reviewed by Gyuyoung Kim.

  • UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:

(EWK2ColorPickerTest::hideColorPicker):
(EWK2ColorPickerTest::hideColorPickerByRemovingElement):

6:06 PM Changeset in webkit [184534] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184397. rdar://problem/20979071

6:06 PM Changeset in webkit [184533] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184367. rdar://problem/20979071

6:00 PM Changeset in webkit [184532] by mmaxfield@apple.com
  • 2 edits in trunk/LayoutTests

platform/mac/fast/text/font-weights.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=145149

Reviewed by Alexey Proskuryakov.

  • platform/mac/TestExpectations:
5:24 PM Changeset in webkit [184531] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

REGRESSION: v2 UI reports a higher memory usage
https://bugs.webkit.org/show_bug.cgi?id=145151

Reviewed by Chris Dumez.

The bug was caused by v2 UI using 1000 to divide the number of bytes instead of by 1024 as done in v1.
Fixed the bug by manually implementing the formatter as done in v1.

  • public/v2/manifest.js:

(App.Manfiest._formatBytes): Added.
(App.Manifest._formatFetchedData): Use _formatByte instead of format('s').

5:09 PM Changeset in webkit [184530] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.32-branch/Source/WebCore

Merge r184513. rdar://problem/21006738

5:09 PM Changeset in webkit [184529] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184439. rdar://problem/20975978

5:09 PM Changeset in webkit [184528] by matthew_hanson@apple.com
  • 3 edits
    3 adds in branches/safari-601.1.32-branch

Merge r184510. rdar://problem/21004989

5:09 PM Changeset in webkit [184527] by matthew_hanson@apple.com
  • 12 edits
    1 move
    3 adds
    1 delete in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merge r184445. rdar://problem/20979071

5:08 PM Changeset in webkit [184526] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merge r184397. rdar://problem/20979071

5:08 PM Changeset in webkit [184525] by matthew_hanson@apple.com
  • 15 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merge r184368. rdar://problem/20979071

5:08 PM Changeset in webkit [184524] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.32-branch/Source/JavaScriptCore

Merge r184367. rdar://problem/20979071

5:05 PM Changeset in webkit [184523] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.1.32.2.2/Source

Versioning.

5:03 PM Changeset in webkit [184522] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.32.2.2

New tag.

4:56 PM Changeset in webkit [184521] by dbates@webkit.org
  • 2 edits
    1 add in trunk/Tools

prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
when staged non-empty file for commit
https://bugs.webkit.org/show_bug.cgi?id=145082

Reviewed by Darin Adler.

Fixes two issues when running prepare-ChangeLog:

  1. The function above a deleted function is reported as changed.
  2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl, included in this patch).

Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
generated by svn diff and git diff, respectively. The logic for parsing these formats
has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
VCSUtil::parseChunkRange() has existing test coverage.

  • Scripts/prepare-ChangeLog:

(generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
examine files that only have deletions. Currently this works as a side effect of the behavior of
extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
(diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
(extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
We return (-1, -1) when the change represents a deletion.
(extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
We return (-1, -1) when the change represents an addition.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;

unit tests.

4:52 PM Changeset in webkit [184520] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.32.2-branch/Source

Versioning.

4:16 PM Changeset in webkit [184519] by mmaxfield@apple.com
  • 5 edits in trunk/Source

Addressing post-review comments on r184353
https://bugs.webkit.org/show_bug.cgi?id=145146

Reviewed by Benjamin Poulain.

Source/WebCore:

See per-file comments.

No new tests because there is no behavior change.

  • platform/graphics/mac/FontCacheMac.mm:

(WebCore::fontWithFamilySpecialCase): Use equalIgnoringASCIICase() AtomicString overload.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::updateCachedSystemFontDescription): Implement Ben's ideas for
cheaply constructing AtomicStrings only when necessary.

Source/WTF:

Create an overload for equalIgnoringASCIICase() for AtomicString and string literals.

  • wtf/text/AtomicString.h:

(WTF::equalIgnoringASCIICase):

4:01 PM Changeset in webkit [184518] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebCore

Merge r184417. rdar://problem/20770052

3:53 PM Changeset in webkit [184517] by commit-queue@webkit.org
  • 12 edits in trunk

[ES6] Arrow function syntax. Feature flag for arrow function
https://bugs.webkit.org/show_bug.cgi?id=145108

Patch by Skachkov Alexandr <gskachkov@gmail.com> on 2015-05-18
Reviewed by Ryosuke Niwa.

Added feature flag ENABLE_ES6_ARROWFUNCTION_SYNTAX for arrow function

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:
3:39 PM Changeset in webkit [184516] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

WKWebsiteDataStore should fully support session storage
https://bugs.webkit.org/show_bug.cgi?id=145145
rdar://problem/10690447

Reviewed by Sam Weinig.

Add a session store data type and handle it when clearing and fetching data.

  • Shared/WebsiteData/WebsiteDataTypes.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.mm:

(dataTypesToString):

  • UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:

(WebKit::toWebsiteDataTypes):
(WebKit::toWKWebsiteDataTypes):

  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore allWebsiteDataTypes]):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::SessionStorageNamespace::origins):
(WebKit::StorageManager::SessionStorageNamespace::clearStorageAreasMatchingOrigin):
(WebKit::StorageManager::SessionStorageNamespace::clearAllStorageAreas):
(WebKit::StorageManager::getSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageEntriesForOrigins):

  • UIProcess/Storage/StorageManager.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):

3:16 PM Changeset in webkit [184515] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Improve Reliability of Closing and Reopening Elements Tab
https://bugs.webkit.org/show_bug.cgi?id=145139

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-18
Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.highlightSearchResults):
(WebInspector.DOMTreeElement.prototype.hideSearchHighlights):
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight.animationEnded):
(WebInspector.DOMTreeElement.prototype.emphasizeSearchHighlight):
(WebInspector.DOMTreeElement.prototype._updateChildren):
(WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
(WebInspector.DOMTreeElement.prototype._startEditingAsHTML.dispose):
(WebInspector.DOMTreeElement.prototype._startEditingAsHTML):
(WebInspector.DOMTreeElement.prototype.updateTitle):
Stop using the delete operator.

  • UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype.setVisible):
Trigger an update when the outline is made visible.

  • UserInterface/Views/FrameDOMTreeContentView.js:

(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
Provide a reasonable default selection if there is no body or document element.
For example in an augmented DOM tree.

3:09 PM Changeset in webkit [184514] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Followup to: Networking process on iOS can be suspended and never exit
https://bugs.webkit.org/show_bug.cgi?id=144971.

Unreviewed. Fixing API tests that revealed the unintentional change in behavior.

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::shutDownProcess): The on WebProcessProxy code path that this

was adopted from had an m_connection null check, and that null check needs to remain.

3:01 PM Changeset in webkit [184513] by Brent Fulgham
  • 7 edits in trunk/Source/WebCore

REGRESSION(142590): Scroll-snap points are improperly snapping to earlier index values
https://bugs.webkit.org/show_bug.cgi?id=145140
<rdar://problem/21006738>

Reviewed by Beth Dakin.

The new "nearestActiveSnapPoint" logic is firing while scroll snap animations are running. We need
to add an "isScrollSnapInProgress" predicate, much like the existing "isRubberBandInProgress" to avoid
certain "fix-up" logic that we don't want running while we are in the process of moving to a new position.

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::ScrollAnimator::isScrollSnapInProgress): Added.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::updateScrollSnapState): If we are in the midst of a scroll snap operation,
do not attempt to reset position to the current active snap point.

  • platform/cocoa/ScrollController.h:
  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::isScrollSnapInProgress): Added.

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::isScrollSnapInProgress): Added.

2:28 PM Changeset in webkit [184512] by andersca@apple.com
  • 2 edits in trunk/Tools

Add ATS keys to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=145141

Reviewed by Sam Weinig.

  • MiniBrowser/mac/Info.plist:
1:45 PM Changeset in webkit [184511] by benjamin@webkit.org
  • 15 edits in trunk/Source/JavaScriptCore

[JSC] When entering a CheckTierUp without OSREntry, force the CheckTierUp for the outer loops with OSR Entry
https://bugs.webkit.org/show_bug.cgi?id=145092

Reviewed by Filip Pizlo.

When we have a hot loop without OSR Entry inside a slower loop that support OSR Entry,
we get the inside loop driving the tierUpCounter and we have very little chance of
doing a CheckTierUp on the outer loop. In turn, this give almost no opportunity to tier
up in the outer loop and OSR Enter there.

This patches changes CheckTierUp to force its outer loops to do a CheckTierUp themselves.

To do that, CheckTierUp sets a flag "nestedTriggerIsSet" to force the outer loop to
enter their CheckTierUp regardless of the tier-up counter.

  • bytecode/ExecutionCounter.cpp:

(JSC::ExecutionCounter<countingVariant>::setThreshold):
This is somewhat unrelated. This assertion is incorrect because it relies on
m_counter, which changes on an other thread.

I have hit it a couple of times with this patch because we are a bit more aggressive
on CheckTierUp. What happens is:
1) ExecutionCounter<countingVariant>::checkIfThresholdCrossedAndSet() first checks

hasCrossedThreshold(), and it is false.

2) On the main thread, the hot loops keeps running and the counter becomes large

enough to cross the threshold.

3) ExecutionCounter<countingVariant>::checkIfThresholdCrossedAndSet() runs the next

test, setThreshold(), where the assertion is. Since the counter is now large enough,
the assertion fails.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGJITCode.h:

I used a uint8_t instead of a boolean to make the code generation clearer
in DFGSpeculativeJIT64.

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):
This is a bit annoying: we have the NaturalLoops analysis that provides us
everything we need to know about loops, but the TierUpCheck are conservative
and set on LoopHint.

To make the two work together, we first find all the CheckTierUp that cannot
OSR enter and we keep a list of all the natural loops containing them.

Then we do a second pass over the LoopHints, get their NaturalLoop, and check
if it contains a loop that cannot OSR enter.

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):
(JSC::DFG::TierUpCheckInjectionPhase::canOSREnterAtLoopHint):

1:41 PM Changeset in webkit [184510] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Add a Int-or-Boolean speculation to Branch
https://bugs.webkit.org/show_bug.cgi?id=145134

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

After https://bugs.webkit.org/show_bug.cgi?id=126778 we no longer have a reason not to do the
int-or-boolean optimization that we already do everywhere else.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

LayoutTests:

Added the reduced asm.js test case from https://bugs.webkit.org/show_bug.cgi?id=144136. We don't yet
run it as fast as we should but this is a big step.

  • js/regress/script-tests/slow-ternaries.js: Added.

(.f):
(asmMod):

  • js/regress/slow-ternaries-expected.txt: Added.
  • js/regress/slow-ternaries.html: Added.
1:15 PM Changeset in webkit [184509] by matthew_hanson@apple.com
  • 9 edits in branches/safari-601.1.32.2-branch/Source

Merge custom patch. rdar://problem/20950052

12:53 PM Changeset in webkit [184508] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Tab Restoration incorrectly makes ContentViews "shown" in background tabs
https://bugs.webkit.org/show_bug.cgi?id=145080

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-18
Reviewed by Timothy Hatcher.

Many tabs have their own content browser / navigation sidebar. During
state restoration, each tab would immediately try to restore an
appropriate ContentView after the load / navigation. However, in doing
so, we weren't respecting whether or not the Tab the ContentBrowser
was in was hidden or not, so ContentViews in background tags were
still being treated as shown/visible.

This patch changes state restoration to only affect the foreground
tab, and be delayed on all background tabs until that tab is shown.
This reduces the amount of work on load and navigation to just a
single tab instead of all tabs. Most importantly, it avoids having
performing work on ContentBrowsers that are non-visible, so state
restoration only happens for visible ContentBrowsers.

For simplicity, in the case of a delayed tab restoration triggered
by the user switching tabs, we don't try twice (like we occasionally
do on load/reload). We could add back some hueristic here if needed.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector.activateExtraDomains):
(WebInspector._mainResourceDidChange):
(WebInspector._restoreCookieForOpenTabs):

  • UserInterface/Views/NavigationSidebarPanel.js:
  • UserInterface/Views/TabContentView.js:

(WebInspector.TabContentView.prototype.shown):
(WebInspector.TabContentView.prototype.restoreStateFromCookie):
(WebInspector.TabContentView.prototype.saveStateToCookie):
When asked to restore state, save that logic until the next time the tab is shown.

  • UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor.prototype.get visible):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.editingControllerDidStartEditing):
(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState): Deleted.
Although this didn't actually catch the issue, it could potentially
catch other issues in the future. We don't want to enable the annotators
in a non-visible text editor, as it could be a performance issue.

12:35 PM Changeset in webkit [184507] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32-branch

Merge r183912. rdar://problem/20926150

12:24 PM Changeset in webkit [184506] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[GTK] URTBF after r184503.

  • PlatformGTK.cmake:
11:44 AM Changeset in webkit [184505] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4

[W32] Wrong configure tests for OpenGL on Windows, wrong ifdefs
https://bugs.webkit.org/show_bug.cgi?id=143763

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Change OpenGL checks to work on W32, add libopengl32

AGain, use OS(WINDOWS) for things that are W32 but not necessarily MSVC.
Don't try to check for dlopen() on W32 (it might be available, but
native code is already here, so use it).

Correctly cast the result of GetProcAddress(), because C++.

Link W32 version to -lOpenGL32 instead of -lGL, otherwise libtool complains:
* Warning: linker path does not have real file for library -lGL.

.:

  • Source/autotools/FindDependencies.m4:

Source/WebCore:

  • platform/graphics/OpenGLShims.cpp:

(WebCore::getProcAddress):

11:24 AM Changeset in webkit [184504] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit/gtk

[W32][GTK] GI fails due to W32-incompatible arguments to the scanner
https://bugs.webkit.org/show_bug.cgi?id=143764

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Use correct .la files as --library arguments for GI scanner

This way it plays well with W32 gobject-introspection library resolution
code.
Without that one would get things like:
ERROR: can't resolve libraries to shared libraries: webkitgtk-3.0, javascriptcoregtk-3.0

  • GNUmakefile.am:
10:53 AM Changeset in webkit [184503] by beidson@apple.com
  • 12 edits
    1 add in trunk/Source/WebKit2

Networking process on iOS can be suspended and never exit.
<rdar://problem/20368630> and https://bugs.webkit.org/show_bug.cgi?id=144971

Reviewed by Darin Adler.

There's a few issues here.

1 - When the NetworkProcessProxy goes away, it takes its process assertion with it. This causes

the Network process to suspend indefinitely, unable to ever respond to IPC::Connection callbacks.
We already solved this with WebProcess with a watchdog timer keeping both the process assertion
and xpc_connection alive while the process shuts down. This patch expands that to the network
process, and it will be easy to expand that to database and plugin processes doing forward.

2 - All of our child processes either decide to self-terminate or listen for their connection to

close at which point they terminate. This leads to various races. We should
move to a model where the UI process explicitly tells them to shutdown, and this patch starts us
down that path.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebKit2.xcodeproj/project.pbxproj:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didReceiveMessage): Send ChildProcess messages to ChildProcess.

  • Shared/ChildProcess.cpp:

(WebKit::ChildProcess::shutDown): For now, just terminate the process. In the future have the

process do cleanup work before it is terminated.

  • Shared/ChildProcess.h:
  • Shared/ChildProcess.messages.in: Added.
  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::shutDownProcess): Set a watchdog and - if possible - explicitly message

the process to ShutDown.

(WebKit::ChildProcessProxy::abortProcessLaunchIfNeeded): Deleted.

  • Shared/ChildProcessProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::~WebProcessPool): Explicitly tell the network process to shut down.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::removeWebPage): Move abortProcessLaunchIfNeeded() and the watchdog timer

code to ChildProcessProxy::shutDownProcess.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessage): Send ChildProcess messages to ChildProcess::didReceiveMessage.

10:51 AM Changeset in webkit [184502] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4

[W32] Configure may misdetect ICU libraries
https://bugs.webkit.org/show_bug.cgi?id=143767

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Carlos Garcia Campos.

Try to use pkg-config to detect ICU libraries.

MinGW packages tend to have .pc files these days. Use them.

ICU naming and structure is complex enough to warrant this, and
asking pkg-config might result in things like
UNICODE_LIBS="-licui18n54 -licuuc54 -licudata54"
instead of the default
UNICODE_LIBS="-licui18n -licuuc"
and pkg-config usually knows best.

  • Source/autotools/FindDependencies.m4:
10:46 AM Changeset in webkit [184501] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Speed up URL encode/decode by using bitmaps instead of strchr().
<https://webkit.org/b/145115>

Reviewed by Anders Carlsson.

We were calling strchr() for every character when doing URL encoding/decoding and it stood out
like a sore O(n) thumb in Instruments. Optimize this by using a Bitmap<256> instead.

5.5% progression on Kraken/stanford-crypto-sha256-iterative.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::makeCharacterBitmap):
(JSC::encode):
(JSC::decode):
(JSC::globalFuncDecodeURI):
(JSC::globalFuncDecodeURIComponent):
(JSC::globalFuncEncodeURI):
(JSC::globalFuncEncodeURIComponent):
(JSC::globalFuncEscape):

10:01 AM Changeset in webkit [184500] by matthew_hanson@apple.com
  • 12 edits
    1 move
    3 adds
    1 delete in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184445. rdar://problem/20979071

10:01 AM Changeset in webkit [184499] by matthew_hanson@apple.com
  • 15 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184368. rdar://problem/20979071

10:01 AM Changeset in webkit [184498] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merge r184422. rdar://problem/20410944

10:01 AM Changeset in webkit [184497] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebKit2

Merge r184399. rdar://problem/20939743

10:01 AM Changeset in webkit [184496] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WebCore

Merge r184360. rdar://problem/20865442

10:01 AM Changeset in webkit [184495] by matthew_hanson@apple.com
  • 10 edits
    1 delete in branches/safari-601.1.32.2-branch

Merge r184353. rdar://problem/20809399

10:00 AM Changeset in webkit [184494] by matthew_hanson@apple.com
  • 9 edits in branches/safari-601.1.32.2-branch

Merge r184341. rdar://problem/20809399

10:00 AM Changeset in webkit [184493] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184289. rdar://problem/18717477

10:00 AM Changeset in webkit [184492] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/WTF

Merge r184245. rdar://problem/19611967

10:00 AM Changeset in webkit [184491] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32.2-branch/Source/JavaScriptCore

Merge r184019. rdar://problem/20764509

9:47 AM Changeset in webkit [184490] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

[W32] windowsVersion() and osVersionForUAString() are outdated
https://bugs.webkit.org/show_bug.cgi?id=143771

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Darin Adler

Update windowsVersion() and osVersionForUAString()

Add support for newer Windows versions to windowsVersion(), handle
all defined cases in osVersionForUAString(), avoiding warnings like
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp: In function 'WTF::String WebCore::osVersionForUAString()':
../webkitgtk-2.4.8/Source/WebCore/platform/win/SystemInfo.cpp:94:12: warning: enumeration value 'WindowsCE5' not handled in switch [-Wswitch]
repeated for each unhandled value

  • platform/win/SystemInfo.cpp:

(WebCore::windowsVersion):
(WebCore::osVersionForUAString):

  • platform/win/SystemInfo.h:
9:17 AM Changeset in webkit [184489] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4/Source

[GTK] Replace M_SQRT2 with sqrtOfTwoDouble
https://bugs.webkit.org/show_bug.cgi?id=143906

Patch by Milan Crha <mcrha@redhat.com> on 2015-04-17
Reviewed by Carlos Garcia Campos.

Source/WebCore:

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):

Source/WTF:

  • wtf/MathExtras.h:
7:24 AM Changeset in webkit [184488] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebInspectorUI

Merge r184364. rdar://problem/20965745

7:24 AM Changeset in webkit [184487] by matthew_hanson@apple.com
  • 20 edits in branches/safari-601.1.32-branch

Merge r184358. rdar://problem/19790341

7:24 AM Changeset in webkit [184486] by matthew_hanson@apple.com
  • 10 edits
    1 delete in branches/safari-601.1.32-branch

Merge r184353. rdar://problem/20809399

7:23 AM Changeset in webkit [184485] by matthew_hanson@apple.com
  • 9 edits in branches/safari-601.1.32-branch

Merge r184341. rdar://problem/20809399

7:23 AM Changeset in webkit [184484] by matthew_hanson@apple.com
  • 5 edits
    2 adds in branches/safari-601.1.32-branch

Merge r184308. rdar://problem/20895753

7:23 AM Changeset in webkit [184483] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.32-branch/Source/WebCore

Merge r184304. rdar://problem/19790341

7:23 AM Changeset in webkit [184482] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.32-branch/Source/WebCore

Merge r184296. rdar://problem/20100706

7:23 AM Changeset in webkit [184481] by matthew_hanson@apple.com
  • 11 edits in branches/safari-601.1.32-branch/Source

Merge r184290. rdar://problem/19790341

7:23 AM Changeset in webkit [184480] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.32-branch/Source/WebCore

Merge r184204. rdar://problem/20909871

7:22 AM Changeset in webkit [184479] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184052. rdar://problem/20890647

7:22 AM Changeset in webkit [184478] by matthew_hanson@apple.com
  • 10 edits
    1 add in branches/safari-601.1.32-branch/Source

Merge r184047. rdar://problem/20890647

7:22 AM Changeset in webkit [184477] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184024. rdar://problem/19790341

7:22 AM Changeset in webkit [184476] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184022. rdar://problem/19790341

7:22 AM Changeset in webkit [184475] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184016. rdar://problem/19790341

7:22 AM Changeset in webkit [184474] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184014. rdar://problem/19790341

7:21 AM Changeset in webkit [184473] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184012. rdar://problem/19790341

7:21 AM Changeset in webkit [184472] by matthew_hanson@apple.com
  • 13 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r184011. rdar://problem/19790341

7:21 AM Changeset in webkit [184471] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.32-branch/Source/WebKit2

Merge r183978. rdar://problem/20635659

6:54 AM Changeset in webkit [184470] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

[GTK] Make preprocessor.pm / make_names.pl work under msys/mingw
https://bugs.webkit.org/show_bug.cgi?id=143908

Patch by Milan Crha <mcrha@redhat.com> on 2015-04-17
Reviewed by Carlos Garcia Campos.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • dom/make_names.pl:
6:46 AM Changeset in webkit [184469] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WTF

Merge r182848 - Harmonize binary semaphore ifdefs

They should be either OS(WINDOWS) (in which case we'd need
BinarySemaphoreWin.cpp, which is not shipped by WebKitGTK)
or PLATFORM(WIN) (in which case Mutex/ThreadCondition-based
implementation is used).

This fixes errors like:

CXX Source/WTF/wtf/threads/libWTF_la-BinarySemaphore.lo

../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp: In constructor 'WTF::BinarySemaphore::BinarySemaphore()':
../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:34:7: error: class 'WTF::BinarySemaphore' does not have any field named 'm_isSet'

: m_isSet(false)


../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp: In member function 'void WTF::BinarySemaphore::signal()':
../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:44:24: error: 'm_mutex' was not declared in this scope

MutexLocker locker(m_mutex);


../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:46:5: error: 'm_isSet' was not declared in this scope

m_isSet = true;

../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:47:5: error: 'm_condition' was not declared in this scope

m_condition.signal();

../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp: In member function 'bool WTF::BinarySemaphore::wait(double)':
../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:52:24: error: 'm_mutex' was not declared in this scope

MutexLocker locker(m_mutex);


../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:55:13: error: 'm_isSet' was not declared in this scope

while (!m_isSet) {


../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:56:21: error: 'm_condition' was not declared in this scope

timedOut = !m_condition.timedWait(m_mutex, absoluteTime);


../webkitgtk-2.4.8/Source/WTF/wtf/threads/BinarySemaphore.cpp:62:5: error: 'm_isSet' was not declared in this scope

m_isSet = false;

GNUmakefile:52762: recipe for target 'Source/WTF/wtf/threads/libWTF_la-BinarySemaphore.lo' failed

[W32] Inconsistent ifdefs in BinarySemaphore.h and BinarySemaphore.cpp
https://bugs.webkit.org/show_bug.cgi?id=143756

Patch by Руслан Ижбулатов <lrn1986@gmail.com> on 2015-04-15
Reviewed by Darin Adler.

  • wtf/threads/BinarySemaphore.h:
6:38 AM Changeset in webkit [184468] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/JavaScriptCore

[GTK][Stable] Missing implementation of callToJavaScript/callToNativeFunction with msys/mingw32
https://bugs.webkit.org/show_bug.cgi?id=132856

Patch by Milan Crha <mcrha@redhat.com> on 2015-04-17

  • jit/JITStubsX86.h:
6:11 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
6:09 AM Changeset in webkit [184467] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

[GTK] fails to build with --disable-accelerated-compositing
https://bugs.webkit.org/show_bug.cgi?id=137640

Patch by Alexander Tsoy <alexander@tsoy.me> on 2015-05-18
Reviewed by Alberto Garcia.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):

5:41 AM WebKitGTK/2.4.x edited by Carlos Garcia Campos
(diff)
5:39 AM Changeset in webkit [184466] by Carlos Garcia Campos
  • 16 edits in releases/WebKitGTK/webkit-2.4/Source

[GTK] Add HighDPI support for non-accelerated compositing contents
https://bugs.webkit.org/show_bug.cgi?id=131562

Patch by Owen Taylor <otaylor@redhat.com> on 2014-05-29
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests. This will be tested once we have the proper dependencies in the WebKit testing
JHBuild.

Adapted by Michael Kuhn for 2.4 branch.

  • platform/cairo/WidgetBackingStore.h:

(WebCore::WidgetBackingStore::WidgetBackingStore): Accept a device scale argument.

  • platform/cairo/WidgetBackingStoreCairo.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
  • platform/cairo/WidgetBackingStoreCairo.h: Accept a device scale argument.
  • platform/graphics/cairo/CairoUtilities.cpp: Add a new helper to set the device scale if Cairo built against is new enough.
  • platform/graphics/cairo/CairoUtilities.h:
  • platform/gtk/GtkVersioning.h: Add the HAVE_GTK_SCALE_FACTOR macro.
  • platform/gtk/WidgetBackingStoreGtkX11.cpp: Use the device scale argument to make the surface the proper size and set the surface device scale.
  • platform/gtk/WidgetBackingStoreGtkX11.h: Accept a device scale argument.

Source/WebKit2:

Adapted by Michael Kuhn for 2.4 branch.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(deviceScaleFactorChanged): Added this callback to pass scale changes to the page proxy.
(webkitWebViewBaseCreateWebPage): Attach the callback to the notify signal.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::WebPageProxy::setCustomDeviceScaleFactor): Do not set a custom device scale factor for cairo when it's not supported.
(WebKit::createBackingStoreForGTK): Pass the scale factor to the WebCore backing store.
(WebKit::BackingStore::incorporateUpdate): Ditto.

5:23 AM Changeset in webkit [184465] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/JavaScriptCore

webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433

Don't include CoreFoundation.h when building the GTK port.

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-01-06

  • Source/JavaScriptCore/API/WebKitAvailability.h: Add

!defined(BUILDING_GTK) to defined(APPLE).

5:07 AM Changeset in webkit [184464] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r183729 - [GTK] API tests crashing on debug builds due to extra unref
https://bugs.webkit.org/show_bug.cgi?id=144508

Reviewed by Mario Sanchez Prada.

The problem is that we were assuming that when a new DOMWindow is
created, the DOM object cache was notified about the previous
DOMWindow being destroyed before objects for the new DOMWindow are
added to the cache. However, that's not always the case and we
only create a DOMWindowObserver for the first DOMWindow. We need
to keep a pointer to the DOMWindow being observed to clear() the
cache and create a new DOMWindowObserver when it changes in the
Frame.

Fixes crashes in several unit tests in debug builds.

  • bindings/gobject/DOMObjectCache.cpp:
5:05 AM Changeset in webkit [184463] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r181787 - [GTK] Crash due to empty drag image during drag-and-drop
https://bugs.webkit.org/show_bug.cgi?id=142671

Reviewed by Philippe Normand.

Return early from ImageBuffer constructor if an empty size is
given. This is a speculative fix for a crash while starting a drag
and drop operation, that I haven't been able to reproduce.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer):

5:02 AM Changeset in webkit [184462] by Carlos Garcia Campos
  • 4 edits
    1 add in releases/WebKitGTK/webkit-2.4/Source

Merge r181305 - 8-bit version of weakCompareAndSwap() can cause an infinite loop.
https://webkit.org/b/142513>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added a test that exercises the 8-bit CAS from multiple threads. The threads
will contend to set bits in a large array of bytes using the CAS function.

  • API/tests/CompareAndSwapTest.cpp: Added.

(Bitmap::Bitmap):
(Bitmap::numBits):
(Bitmap::clearAll):
(Bitmap::concurrentTestAndSet):
(setBitThreadFunc):
(testCompareAndSwap):

  • API/tests/testapi.c:

(main):

Source/WTF:

Presently, Bitmap::concurrentTestAndSet() uses the 8-bit version of
weakCompareAndSwap() (which compares and swaps an uint8_t value).
Bitmap::concurrentTestAndSet() has a loop that checks if a bit in the
byte of interest has been set. If not, it will call the 8-bit CAS
function to set the bit.

Under the covers, for ARM, the 8-bit CAS function actually works with a
32-bit CAS. The 8-bit CAS will first fetch the 32-bit value in memory
that should contain the 8-bit value, and check if it contains the
expected byte. If the value in memory doesn't have the expected byte,
it will return early to its caller. The expectation is that the caller
will reload the byte from memory and call the 8-bit CAS again.

Unfortunately, this code path that returns early does not have a
compiler fence. Without a compiler fence, the C++ compiler can
optimize away the reloading of the expected byte value, leaving it
unchanged. As a result, we'll have a infinite loop here that checks a
value that will never change, and the loop will not terminate until the
value changes.

The fix is to eliminate the early return check in the 8-bit CAS, and
have it always call down to the 32-bit CAS. The 32-bit CAS has a
compiler fence which will prevent this issue.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

4:29 AM Changeset in webkit [184461] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r181074 - [SOUP] Check TLS errors as soon as they are set in the SoupMessage
https://bugs.webkit.org/show_bug.cgi?id=142244

Reviewed by Sergio Villar Senin.

Source/WebCore:

Connect to the notify::tls-errors signal of SoupMessage to cancel
the load earlier in case of TLS failure, preventing any private
data from being sent to the server before the TLS errors are checked.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::tlsErrorsChangedCallback):
(WebCore::gotHeadersCallback):
(WebCore::createSoupMessageForHandleAndRequest):

4:27 AM Changeset in webkit [184460] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.4

Merge r180927 - [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
https://bugs.webkit.org/show_bug.cgi?id=141508

Reviewed by Sergio Villar Senin.

Source/WebCore:

Use SOUP_MESSAGE_IGNORE_CONNECTION_LIMITS flag when loading a
synchronous message instead of increasing the maximum number of
connections allowed if the soup version is recent enough.
The current solution of increasing/decreasing the limits doesn't
always work, because connections are not marked as IDLE in libsoup
until the message is unqueued, but we don't wait for the message
to be unqueued to finish our loads in WebKit, we finish them as
soon as we have finished reading the stream. This causes that
synchronous loads keep blocked in the nested main loop until the
timeout of 10 seconds is fired and the load fails.
Also marked WebCoreSynchronousLoader class as final, the virtual
methods as override and removed the unsused method isSynchronousClient.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest):
(WebCore::WebCoreSynchronousLoader::WebCoreSynchronousLoader):
(WebCore::WebCoreSynchronousLoader::isSynchronousClient): Deleted.
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::WebCoreSynchronousLoader::didReceiveData):
(WebCore::WebCoreSynchronousLoader::didReceiveBuffer):
(WebCore::WebCoreSynchronousLoader::didFinishLoading):
(WebCore::WebCoreSynchronousLoader::didFail):
(WebCore::WebCoreSynchronousLoader::didReceiveAuthenticationChallenge):
(WebCore::WebCoreSynchronousLoader::shouldUseCredentialStorage):

4:24 AM Changeset in webkit [184459] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r181744 - [GTK] Scrollbars look bad with GTK+ 3.16
https://bugs.webkit.org/show_bug.cgi?id=140800

Reviewed by Sergio Villar Senin.

Take margin into account when rendering scrollbars. This fixes the
huge scrollbars rendered with GTK+ 3.16. We don't need to check
the GTK+ version because in previous versions the marging were 0,
so the same code just works.

  • platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::adjustRectAccordingToMargin):
(WebCore::ScrollbarThemeGtk::paintTrackBackground):
(WebCore::ScrollbarThemeGtk::paintThumb):

4:10 AM Changeset in webkit [184458] by Carlos Garcia Campos
  • 6 edits
    4 adds
    2 deletes in releases/WebKitGTK/webkit-2.4

Merge r176930 - [Soup][Curl] HTTP header values should be treated as latin1, not UTF-8
https://bugs.webkit.org/show_bug.cgi?id=128739

Patch by Youenn Fablet <youenn.fablet@crf.canon.fr> on 2014-12-07
Reviewed by Martin Robinson.
Source/WebCore:

Removed UTF-8 conversion of HTTP header values (SOUP and CURL).
Removed unnecessary UTF-8 conversion of HTTP header names (SOUP).
Changed conversion of HTTP method from UTF-8 to ASCII (SOUP and CURL).
Added explicit UTF-8 conversion of Content-Disposition header to compute download suggested filename.

Test: http/tests/xmlhttprequest/response-special-characters.html

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::headerCallback): Removed header conversion.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::headerCallback): Ditto.
(WebCore::ResourceHandleManager::initializeHandle): Changed HTTP method conversion to ASCI.

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::ResourceRequest::updateFromSoupMessageHeaders): Removed header conversion.
(WebCore::ResourceRequest::updateSoupMessage): Changed HTTP method conversion to ASCII.
(WebCore::ResourceRequest::toSoupMessage): Ditto.
(WebCore::ResourceRequest::updateFromSoupMessage):

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessageHeaders): Rmoved header conversion.
(WebCore::ResourceResponse::platformSuggestedFilename): Added explicit conversion of contentDisposition to UTF-8.

LayoutTests:

Tests that non ascii header & reason phrase values are correctly retrieved by the web application.
headers.php script sends a response that includes non ascii header value.
not-ascii-status.php sends a response that includes non ascii reason phrase.
Removed specific gtk/efl expectations as now aligned with regular expectation.

  • http/tests/xmlhttprequest/resources/headers.php: Added.
  • http/tests/xmlhttprequest/resources/not-ascii-status.php: Added.
  • http/tests/xmlhttprequest/response-special-characters-expected.txt: Added.
  • http/tests/xmlhttprequest/response-special-characters.html: Added.
  • platform/efl/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
  • platform/gtk/http/tests/security/contentSecurityPolicy/source-list-parsing-nonascii-expected.txt: Removed.
4:06 AM Changeset in webkit [184457] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4/Source

Merge r176803 - Serialization of MapData object provides unsafe access to internal types
https://bugs.webkit.org/show_bug.cgi?id=138653

Patch by Oliver Hunt <oliver@apple.com> on 2014-12-04
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Converting these ASSERTs into RELEASE_ASSERTs, as it is now obvious
that despite trying hard to be safe in all cases it's simply to easy
to use an iterator in an unsafe state.

  • runtime/MapData.h:

(JSC::MapData::const_iterator::key):
(JSC::MapData::const_iterator::value):

Source/WebCore:

We now keep the value portion of the key/value pair in MapData as a
separate stack. This allows us to maintain the spec semantic of
"atomic" serialisation of the key/value pair without retaining the
use of a potentially invalid iterator.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

3:35 AM Changeset in webkit [184456] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.4

Merge r175363 - ASSERTION NOT REACHED because RenderStyle::setWordSpacing() does not handle a Length value of type 'Calculated'.
https://bugs.webkit.org/show_bug.cgi?id=138054.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-29
Reviewed by Zalan Bujtas.

Source/WebCore:

A Length of type 'Calculated' can be generated from blending two lengths of
different types. Setting the wordSpacing of the render style should be handled
correctly when the type of the new value is 'Calculated'.

Tests: css3/calculated-word-spacing.html.

Add a case for setting the render style wordSpacing to a <length> of type 'Calculated'.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::setWordSpacing):

LayoutTests:

Ensure the render style's wordSpacing can be set correctly when the type of
the new value is 'Calculated'. The 'Calculated' Length value can result from
blending two Length values of different types. And these two Length values
are defined in two consecutive css animation key frames.

  • css3/calculated-word-spacing-expected.txt: Added.
  • css3/calculated-word-spacing.html: Added.
3:32 AM Changeset in webkit [184455] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.4

Merge r175197 - Clamp wordSpacing percentage value.
https://bugs.webkit.org/show_bug.cgi?id=129350.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-24
Reviewed by Zalan Bujtas.

Source/WebCore:

When the CSS wordSpacing property is percentage, its value has to be within the
pre-defined min/max values for the CSS length type. This is done the same way
the wordSpacing of type <length> is handled.

Tests: css3/infinite-word-spacing.html.

Move the definitions of minValueForCssLength and maxValueForCssLength from the
.cpp file to the .h file.

  • css/CSSPrimitiveValue.cpp:
  • css/CSSPrimitiveValue.h:

Clamp the wordSpacing value to minValueForCssLength and maxValueForCssLength when
its type is percentage.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyWordSpacing::applyValue):

LayoutTests:

Make sure that setting the CSS style wordSpacing property to very huge percentage
value and blending this value with other values for animating key frames does
not assert or crash. The expectation is to have this huge value to be clamped to
the pre-defined min/max values for the CSS length type. So when blending the clamped
value with other wordSpacing values, the result can't be NaN. This should be very
similar to the case when it is set to a huge <length> value.

  • css3/infinite-word-spacing-expected.txt: Added.
  • css3/infinite-word-spacing.html: Added.
3:23 AM Changeset in webkit [184454] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r175177 - Replace INT_MIN/MAX / kFixedPointDenominator with intMin/MaxForLayoutUnit.
https://bugs.webkit.org/show_bug.cgi?id=138047

Reviewed by Andreas Kling.

No change in functionality.

  • css/CSSPrimitiveValue.cpp:
3:19 AM Changeset in webkit [184453] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.4

Merge r175345 - Remove invalid float from RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=137707

Reviewed by Antti Koivisto.

In certain cases, floating boxes get attached to the last (root) inline box.
When this particular floating box gets destroyed, it also needs to be detached
from the last inline box.
Source/WebCore:

  1. Introduce RootInlineBox::removeFloat() (vs. RootInlineBox::appendFloat())
  2. Ensure that it is called when the floating box is being destroyed.

Test: fast/inline/crash-when-inline-box-has-invalid-float.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout): During style recalc, while
tearing down the render tree, we can get to a state where a block element has both inline and block children.
It happens when the style change on an element makes sibling anonymous block wrappers detached.
In that case the markAllDescendantsWithFloatsForLayout() call does not get propagated down on the
block child elements as we return early at the childrenInline() check.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::removeFloat):

LayoutTests:

  • fast/inline/crash-when-inline-box-has-invalid-float-expected.txt: Added.
  • fast/inline/crash-when-inline-box-has-invalid-float.html: Added.
3:14 AM Changeset in webkit [184452] by Carlos Garcia Campos
  • 3 edits
    6 adds in releases/WebKitGTK/webkit-2.4

Merge r175243 - Crash when attempting to perform array iteration on a non-array with numeric keys not initialized.
<https://webkit.org/b/137814>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The arrayIteratorNextThunkGenerator() thunk was not checking for the case where
the butterfly may be NULL. This was the source of the crash, and is now fixed.

In addition, it is also not checking for the case where a property named "length"
may have been set on the iterated object. The thunk only checks the butterfly's
publicLength for its iteration operation. Array objects will work fine with this
because it always updates its butterfly's publicLength when its length changes.
In the case of iterable non-Array objects, the "length" property will require a
look up outside of the scope of this thunk. The fix is simply to limit the fast
case checks in this thunk to Array objects.

  • jit/ThunkGenerators.cpp:

(JSC::arrayIteratorNextThunkGenerator):

LayoutTests:

  • js/array-length-shortening-expected.txt: Added.
  • js/array-length-shortening.html: Added.
  • js/for-of-crash-expected.txt: Added.
  • js/for-of-crash.html: Added.
  • js/script-tests/array-length-shortening.js: Added.

(testLengthShortening):
(denseInt32Elements):
(denseDoubleElements):
(denseObjectElements):
(holeyInt32Elements):
(holeyDoubleElements):
(holeyObjectElements):
(arrayStorageInt32Elements):
(arrayStorageDoubleElements):
(arrayStorageObjectElements):
(sparseInt32Elements):
(sparseDoubleElements):
(sparseObjectElements):

  • js/script-tests/for-of-crash.js: Added.

(foo):

3:04 AM Changeset in webkit [184451] by Carlos Garcia Campos
  • 13 edits in releases/WebKitGTK/webkit-2.4

Merge r175078 - String(new Date(Mar 30 2014 01:00:00)) is wrong in CET
https://bugs.webkit.org/show_bug.cgi?id=130967

Patch by Byungseon Shin <sun.shin@lge.com> on 2014-10-22
Reviewed by Mark Lam.

Source/JavaScriptCore:

By definition of calculateLocalTimeOffset, input time should be UTC time.
But there are many cases when input time is based on local time.
So, it gives erroneous results while calculating offset of DST boundary time.
By adding a argument to distinguish UTC and local time, we can get the correct offset.

(JSC::constructDate):
(JSC::callDate):
(JSC::dateUTC):

  • runtime/DateInstance.cpp:

(JSC::DateInstance::calculateGregorianDateTime):
(JSC::DateInstance::calculateGregorianDateTimeUTC):

  • runtime/DatePrototype.cpp:

(JSC::setNewValueFromTimeArgs):
(JSC::setNewValueFromDateArgs):
(JSC::dateProtoFuncSetMilliSeconds):
(JSC::dateProtoFuncSetUTCMilliseconds):
(JSC::dateProtoFuncSetSeconds):
(JSC::dateProtoFuncSetUTCSeconds):
(JSC::dateProtoFuncSetMinutes):
(JSC::dateProtoFuncSetUTCMinutes):
(JSC::dateProtoFuncSetHours):
(JSC::dateProtoFuncSetUTCHours):
(JSC::dateProtoFuncSetDate):
(JSC::dateProtoFuncSetUTCDate):
(JSC::dateProtoFuncSetMonth):
(JSC::dateProtoFuncSetUTCMonth):
(JSC::dateProtoFuncSetFullYear):
(JSC::dateProtoFuncSetUTCFullYear):
(JSC::dateProtoFuncSetYear):

  • runtime/JSDateMath.cpp:

(JSC::localTimeOffset):
(JSC::gregorianDateTimeToMS):
(JSC::msToGregorianDateTime):
(JSC::parseDateFromNullTerminatedCharacters):

  • runtime/JSDateMath.h:
  • runtime/VM.h:

(JSC::LocalTimeOffsetCache::LocalTimeOffsetCache):
(JSC::LocalTimeOffsetCache::reset):
Passing TimeType argument to distingush UTC time and local time.

Source/WTF:

By definition of calculateLocalTimeOffset, input time should be UTC time.
But there are many cases when input time is based on local time.
So, it gives erroneous results while calculating offset of DST boundary time.
By adding a argument to distinguish UTC and local time, we can get the correct offset.

  • wtf/DateMath.cpp:

(WTF::calculateLocalTimeOffset):
(WTF::parseDateFromNullTerminatedCharacters):
Compensate time offset depends on UTC time or local time.

  • wtf/DateMath.h:

Add argument to differenciate UTC or local time.

LayoutTests:

Set latest DST timezone boundary values on
<http://www.timeanddate.com/time/zone/usa/los-angeles>

  • js/dom/script-tests/date-DST-time-cusps.js:
2:40 AM Changeset in webkit [184450] by Carlos Garcia Campos
  • 3 edits
    9 adds in releases/WebKitGTK/webkit-2.4

Merge r175074 - SVG loaded through html <img> can't request to load any external resources.
https://bugs.webkit.org/show_bug.cgi?id=137762.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-10-22
Reviewed by Daniel Bates.

Source/WebCore:

SVG images have unique security rules that prevent them from loading any external
resources. This patch enforces these rules in CachedResourceLoader::canRequest for
all non-data-uri resources.

The fix and the tests are ported but modified a little from the chromium fix:
http://src.chromium.org/viewvc/blink?view=rev&rev=176084

Test: http/tests/security/svg-image-with-cached-remote-image.html

http/tests/security/svg-image-with-css-cross-domain.html

For the SVG image, prevent loading any external sub-resource except for data urls.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):

LayoutTests:

Ensure that SVG images, which are loaded through the <img> tag or through the
CSS background image, cannot load any external sub-resource except for data-
URL resources (though this doesn't work at the time of writing, see bug #137941).
Also ensure the same rule is enforced on cached resources.

The tests are ported but modified a little from the chromium fix:
http://src.chromium.org/viewvc/blink?view=rev&rev=176084

Set the circle background to orange

  • http/tests/security/resources/image-with-css-cross-domain-circle.css: Added.

(circle):

Set the circle stroke-width = 2 and the circle stroke = red

  • http/tests/security/resources/image-with-css-cross-domain-circle2.css: Added.

(circle):

This svg references the two css files: one is relative path and the other is absolute path

  • http/tests/security/resources/image-with-css-cross-domain.svg: Added.

This svg references an external image.

  • http/tests/security/resources/image-with-remote-image.svg: Added.

A helper css which sets the formatting style for some html tags

  • http/tests/security/svg-image-with-css-cross-domain.css: Added.

(span):
(span.circle-css-cross-domain):
(embed):
(iframe):

Test the svg which is referenced as a cached image by an <object> tag, does not load
external sub-resource.

  • http/tests/security/svg-image-with-cached-remote-image-expected.html: Added.
  • http/tests/security/svg-image-with-cached-remote-image.html: Added.

Test loading sub-resources for an svg which is included in the html by different ways
and which references external css files.
Ensure the image object does not load any external sub-resources.

  • http/tests/security/svg-image-with-css-cross-domain-expected.html: Added.
  • http/tests/security/svg-image-with-css-cross-domain.html: Added.

May 17, 2015:

11:31 PM Changeset in webkit [184449] by Carlos Garcia Campos
  • 8 edits
    1 copy in trunk/Source/WebKit2

Network Cache: Make Data::adoptMap take the ownership of the file descriptor
https://bugs.webkit.org/show_bug.cgi?id=144950

Reviewed by Antti Koivisto.

It will be required to implement ShareableResource for soup
network backend. Also move the common code of Data to a common
file and add mapToFile(). The mapFile version that receives a file
descriptor has been renamed to adoptAndMapFile().

  • CMakeLists.txt: Add new file to compilation.
  • NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::add): Use mapToFile().

  • NetworkProcess/cache/NetworkCacheData.cpp: Added.

(WebKit::NetworkCache::Data::mapToFile): Write the data to the
given file and map it.
(WebKit::NetworkCache::mapFile):
(WebKit::NetworkCache::adoptAndMapFile):
(WebKit::NetworkCache::computeSHA1):
(WebKit::NetworkCache::bytesEqual):

  • NetworkProcess/cache/NetworkCacheData.h:
  • NetworkProcess/cache/NetworkCacheDataCocoa.mm:

(WebKit::NetworkCache::Data::adoptMap): Close the file descriptor.

  • NetworkProcess/cache/NetworkCacheDataSoup.cpp:

(WebKit::NetworkCache::Data::Data): Use a constructor that
receives a file descriptor instead of the one receiving
Backing. If the file descriptor is not -1 then the Data is a map.
(WebKit::NetworkCache::MapWrapper::~MapWrapper): Also close the
file descriptor.
(WebKit::NetworkCache::Data::adoptMap): Pass the file descriptor
to the MapWrapper and create the Data passing the file descriptor.

  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::openAndMapContentExtension): Use mapFile that receives a
file path.
(API::compiledToFile): Use adoptAndMapFile() and don't close the
descriptor.

11:26 PM Changeset in webkit [184448] by benjamin@webkit.org
  • 6 edits in trunk/Source

Do not use fastMallocGoodSize anywhere
https://bugs.webkit.org/show_bug.cgi?id=145103

Reviewed by Michael Saboff.

Source/JavaScriptCore:

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::grow):

Source/WTF:

It is silly we see fastMallocGoodSize in profiles, it does absolutely nothing.

This patch keeps fastMallocGoodSize() around for older code linking
with newer WebKit, but remove any use of it inside WebKit.

  • wtf/FastMalloc.cpp:

(WTF::fastMallocGoodSize):

  • wtf/FastMalloc.h:
  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

11:23 PM Changeset in webkit [184447] by benjamin@webkit.org
  • 4 edits
    3 adds in trunk

[JSC] Make StringRecursionChecker faster in the simple cases without any recursion
https://bugs.webkit.org/show_bug.cgi?id=145102

Reviewed by Darin Adler.

Source/JavaScriptCore:

In general, the array targeted by Array.toString() or Array.join() are pretty
simple. In those simple cases, we spend as much time in StringRecursionChecker
as we do on the actual operation.

The reason for this is the HashSet stringRecursionCheckVisitedObjects used
to detect recursion. We are constantly adding and removing objects which
dirty buckets and force constant rehash.

This patch adds a simple shortcut for those simple case: in addition to the HashSet,
we keep a pointer to the root object of the recursion.
In the vast majority of cases, we no longer touch the HashSet at all.

This patch is a 12% progression on the overall score of ArrayWeighted.

  • runtime/StringRecursionChecker.h:

(JSC::StringRecursionChecker::performCheck):
(JSC::StringRecursionChecker::~StringRecursionChecker):

  • runtime/VM.h:

LayoutTests:

Improve the coverage a tiny bit.

  • js/array-string-recursion-expected.txt: Added.
  • js/array-string-recursion.html: Added.
  • js/script-tests/array-string-recursion.js: Added.
11:16 PM Changeset in webkit [184446] by Manuel Rego Casasnovas
  • 3 edits
    2 adds in trunk

[CSS Grid Layout] Add scrollbar width in intrinsic logical widths computation
https://bugs.webkit.org/show_bug.cgi?id=145021

Source/WebCore:

Like for flexboxes we've to take into account the scrollbar logical
width while computing the intrinsic min and max logical widths.

Reviewed by Sergio Villar Senin.

Test: fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths): Add scrollbar
logical width.

LayoutTests:

Reviewed by Sergio Villar Senin.

  • fast/css-grid-layout/compute-intrinsic-widths-scrollbar-expected.txt: Added.
  • fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html: Added.
8:39 PM Changeset in webkit [184445] by fpizlo@apple.com
  • 12 edits
    4 adds
    2 deletes in trunk/Source/JavaScriptCore

Insert store barriers late so that IR transformations don't have to worry about them
https://bugs.webkit.org/show_bug.cgi?id=145015

Reviewed by Geoffrey Garen.

We have had three kinds of bugs with store barriers. For the sake of discussion we say
that a store barrier is needed when we have something like:

base.field = value


  • We sometimes fail to realize that we could remove a barrier when value is a non-cell. This might happen if we prove value to be a non-cell even though in the FixupPhase it wasn't predicted non-cell.


  • We sometimes have a barrier in the wrong place after object allocation sinking. We might sink an allocation to just above the store, but that puts it just after the StoreBarrier that FixupPhase inserted.


  • We don't remove redundant barriers across basic blocks.


This comprehensively fixes these issues by doing store barrier insertion late, and
removing the store barrier elision phase. Store barrier insertion uses an epoch-based
algorithm to determine when stores need barriers. Briefly, a barrier is not needed if
base is in the current GC epoch (i.e. was the last object that we allocated or had a
barrier since last GC) or if base has a newer GC epoch than value (i.e. value would have
always been allocated before base). We do conservative things when merging epoch state
between basic blocks, and we only do such inter-block removal in the FTL. FTL also
queries AI to determine what type we've proved about value, and avoids barriers when
value is not a cell. FixupPhase still inserts type checks on some stores, to maximize
the likelihood that this AI-based removal is effective.

Rolling back in after fixing some debug build test failures.

(JSC::DFG::BlockMap::at):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

  • dfg/DFGEpoch.h:

(JSC::DFG::Epoch::operator<):
(JSC::DFG::Epoch::operator>):
(JSC::DFG::Epoch::operator<=):
(JSC::DFG::Epoch::operator>=):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::speculateForBarrier):
(JSC::DFG::FixupPhase::insertStoreBarrier): Deleted.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGStoreBarrierElisionPhase.cpp: Removed.
  • dfg/DFGStoreBarrierElisionPhase.h: Removed.
  • dfg/DFGStoreBarrierInsertionPhase.cpp: Added.

(JSC::DFG::performFastStoreBarrierInsertion):
(JSC::DFG::performGlobalStoreBarrierInsertion):

  • dfg/DFGStoreBarrierInsertionPhase.h: Added.
  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR): Fix an unrelated debug-only bug.

  • tests/stress/load-varargs-then-inlined-call-and-exit.js: Test for that debug-only bug.
  • tests/stress/load-varargs-then-inlined-call-and-exit-strict.js: Strict version of that test.
11:44 AM Changeset in webkit [184444] by youenn.fablet@crf.canon.fr
  • 10 edits in trunk/Source/WebCore

[Streams API] Delegate ReadableStreamReader reference counting to ReadableStream
https://bugs.webkit.org/show_bug.cgi?id=144907

Reviewed by Darin Adler.

Changed the link between readadable stream and reader.
Controller ref()/deref() now increments/decrements its stream ref counter, similarly to ReadableStreamController.
This ensures that even if JS scripts do not keep track of the readable stream,
the readable stream will not be disposed as long as the JS script has access to its reader.

All readers of a given stream are kept by the stream, either in an array (for released readers)
or and in ReadableStream::m_reader for the active reader.
This removes the need for the code synchronizing stream and reader.

As a reader can now already count on its stream, the reader no longer needs to store the error in errored state.
Removal of ReadableJSStream::Reader as closed promise rejection error is directly retrieved from the ReadableStream.
Moved the creation of reader directly in ReadableStream.

Next step should be to remove ReadableStreamReader::m_state and to delegate the handling of ReadableStreamReader closed promise callbacks to ReadableStream.

No change in behavior.

  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::changeStateToClosed):
(WebCore::ReadableStream::changeStateToErrored):
(WebCore::ReadableStream::getReader):

  • Modules/streams/ReadableStream.h:

(WebCore::ReadableStream::reader):

  • Modules/streams/ReadableStreamReader.cpp:

(WebCore::ReadableStreamReader::clean):
(WebCore::ReadableStreamReader::ref):
(WebCore::ReadableStreamReader::deref):
(WebCore::ReadableStreamReader::closed):
(WebCore::ReadableStreamReader::changeStateToClosed):
(WebCore::ReadableStreamReader::changeStateToErrored):

  • Modules/streams/ReadableStreamReader.h:

(WebCore::ReadableStreamReader::ReadableStreamReader):

  • Modules/streams/ReadableStreamReader.idl:
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::getReader):

  • bindings/js/JSReadableStreamReaderCustom.cpp:

(WebCore::JSReadableStreamReader::closed):
(WebCore::constructJSReadableStreamReader):

  • bindings/js/ReadableJSStream.cpp:

(WebCore::ReadableJSStream::storeError):
(WebCore::ReadableJSStream::ReadableJSStream): Deleted.

  • bindings/js/ReadableJSStream.h:
10:39 AM Changeset in webkit [184443] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Crash when uploading huge files to YouTube or Google Drive
https://bugs.webkit.org/show_bug.cgi?id=145083
rdar://problem/15468529

Reviewed by Darin Adler.

This fixes the crash, but uploading will fail.

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start): Tell SubresourceLoader to not store a copy of
all received data, FileReaderLoader has its own buffer.
(WebCore::FileReaderLoader::didReceiveResponse): Fixed a bounds check - not every
64-bit value that doesn't fit into 32 bits is negative. With this, FileReader fails
on huge files right away, as intended.
(WebCore::FileReaderLoader::didReceiveData): Fixed multiple bugs in code that's
executed when size is not available upfront. This is the code that used to crash,
but with the above fix, it's not executed by YouTube.
Not only overflow was handled incorrectly, but even simply growing a buffer for
append was buggy.

10:36 AM Changeset in webkit [184442] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

bisect-builds: Add 'retry' option when prompting whether the bug reproduced
<http://webkit.org/b/145100>

Reviewed by Darin Adler.

  • Scripts/bisect-builds:
  • Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
  • Switch to using PROMPT_RESPONSE_* constants when testing the value of $didReproduceBug.
  • Add do { } while loops to implement 'retry' mode.

(promptForTest):

  • Switch to returning PROMPT_RESPONSE_* constants.
  • Add support for 'retry' response.

May 16, 2015:

5:24 PM Changeset in webkit [184441] by aestes@apple.com
  • 7 edits in trunk/Source/WebKit2

[iOS] WKPDFView should not follow javascript: links
https://bugs.webkit.org/show_bug.cgi?id=145101

Reviewed by Dan Bernstein.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::navigateToPDFLinkWithSimulatedClick): Returned early if url's protocol is javascript:.
(WebKit::WebPageProxy::navigateToURLWithSimulatedClick): Renamed to navigateToPDFLinkWithSimulatedClick to
reflect that this function is exclusively for following PDF links.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView annotation:wasTouchedAtPoint:controller:]):
(-[WKPDFView actionSheetAssistant:openElementAtLocation:]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick): Renamed from navigateToURLWithSimulatedClick.
(WebKit::WebPage::navigateToURLWithSimulatedClick): Renamed to navigateToPDFLinkWithSimulatedClick.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:24 PM Changeset in webkit [184440] by Alan Bujtas
  • 3 edits
    4 adds in trunk

REGRESSION (Subpixel): Dashed underline is missing when box is positioned at subpixels.
https://bugs.webkit.org/show_bug.cgi?id=145097
rdar://problem/18588415

Reviewed by Simon Fraser.

Dashed and dotted border painting needs clipping in order to properly display corners.
Similarly to solid border's quad calculation, we pixelsnap the border positions before computing the clipping quad values.

Source/WebCore:

Test: fast/borders/dashed-border-on-subpixel-position.html

fast/borders/dotted-border-on-subpixel-position.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

LayoutTests:

  • fast/borders/dashed-border-on-subpixel-position-expected.html: Added.
  • fast/borders/dashed-border-on-subpixel-position.html: Added.
  • fast/borders/dotted-border-on-subpixel-position-expected.html: Added.
  • fast/borders/dotted-border-on-subpixel-position.html: Added.
4:00 PM Changeset in webkit [184439] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit2

[iOS] Remote scrolling tree needs to coordinate scroll snap state during resize/rotations
https://bugs.webkit.org/show_bug.cgi?id=145059
<rdar://problem/20975978>

Reviewed by Simon Fraser.

The web view needs to update its scroll snap point offsets to take into account any
adjustments to the view size caused by content insets. We also need to update the
offstes after device rotation.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Retrieve the proper
computed content inset for the view and incorporate into any scroll snap point adjustments.
(-[WKWebView _updateVisibleContentRects]): If we have active scroll snap points,

  • UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
  • UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping): Update to account
for content inset.
(WebKit::RemoteScrollingCoordinatorProxy::shouldSnapForMainFrameScrolling): Also validate that the
active index is valid.
(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling): Update to track
current active snap offset index.
(WebKit::RemoteScrollingCoordinatorProxy::hasActiveSnapPoint): Added.
(WebKit::RemoteScrollingCoordinatorProxy::nearestActiveSnapPoint): Added. It calculates the proper
scroll position incorporating any snap point and content insets.

2:01 PM Changeset in webkit [184438] by commit-queue@webkit.org
  • 11 edits
    1 move
    1 add
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r184415.
https://bugs.webkit.org/show_bug.cgi?id=145096

Broke several tests (Requested by msaboff on #webkit).

Reverted changeset:

"Insert store barriers late so that IR transformations don't
have to worry about them"
https://bugs.webkit.org/show_bug.cgi?id=145015
http://trac.webkit.org/changeset/184415

1:00 PM Changeset in webkit [184437] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove styleText() and applyStyleText() from InspectorStyle.
https://bugs.webkit.org/show_bug.cgi?id=145093

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-16
Reviewed by Darin Adler.

styleText() and applyStyleText() in InspectorStyle are private aliases for the public
accessors in the same class but are rarely used. I think it would be better off removing
these aliases and updating all the current call sites to use the public accessors directly
as noted in InspectorStyleSheet.h.

No new tests, no behavior change.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::populateAllProperties):

  • inspector/InspectorStyleSheet.h:
12:57 PM Changeset in webkit [184436] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove MessageType variant of addMessageToConsole() from ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=145095

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-16
Reviewed by Darin Adler.

All addMessageToConsole() in ChromeClient are exactly the same thing.
So there is no reason to keep all this methods.

No new tests, no behavior change.

  • page/ChromeClient.h:
  • page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::messageWithTypeAndLevel):

11:16 AM Changeset in webkit [184435] by weinig@apple.com
  • 12 edits
    1 copy
    2 adds in trunk

Add getElementById to DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=145094

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Match the latest DOM standard and other browsers by adding getElementById
to DocumentFragment in addition to Document and SVGSVGElement. Add NonElementParentNode
interface that the DOM standard defines.

Test: fast/dom/DocumentFragment/getElementById.html

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

Add NonElementParentNode.idl

  • dom/Document.idl:

Mark Document as implementing NonElementParentNode and remove now redundant getElementById
declaration.

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::getElementById):

  • dom/DocumentFragment.h:

Add implementation of getElementById for DocumentFragments. Add a fast path for ShadowRoots
which can take advantage of the fact that they are TreeScopes to use the elements by id cache
in TreeScrope.

  • dom/DocumentFragment.idl:

Mark DocumentFragment as implementing NonElementParentNode.

  • dom/NonElementParentNode.idl: Copied from Source/WebCore/dom/NonDocumentTypeChildNode.idl.

Added.

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::getElementById):

  • svg/SVGSVGElement.h:
  • svg/SVGSVGElement.idl:

Convert to taking an AtomicString to match other getElementByIds.

LayoutTests:

  • fast/dom/DocumentFragment/getElementById-expected.txt: Added.
  • fast/dom/DocumentFragment/getElementById.html: Added.
6:53 AM Changeset in webkit [184434] by Antti Koivisto
  • 11 edits
    2 adds in trunk

When redirecting to data URL use HTTP response for same origin policy checks
https://bugs.webkit.org/show_bug.cgi?id=145054
rdar://problem/20299050

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/tests/security/canvas-remote-read-data-url-image-redirect.html

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::notifyFinished):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::sanitizeScriptError):

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::wouldTaintOrigin):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::responseReceived):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::notifyFinished):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isOriginClean):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::passesAccessControlCheck):
(WebCore::CachedResource::passesSameOriginPolicyCheck):

Factor repeatedly used same origin policy test into a function.

(WebCore::CachedResource::redirectReceived):

When redirecting to a data URL save the redirect response.

(WebCore::CachedResource::responseForSameOriginPolicyChecks):

In case we got redirected to data use that response instead of the final data response for policy checks.

  • loader/cache/CachedResource.h:

LayoutTests:

  • http/tests/security/canvas-remote-read-data-url-image-redirect-expected.txt: Added.
  • http/tests/security/canvas-remote-read-data-url-image-redirect.html: Added.
12:52 AM Changeset in webkit [184433] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] wireless playback picker button is drawn incorrectly
https://bugs.webkit.org/show_bug.cgi?id=145057
rdar://problem/20877518

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.updateWirelessTargetPickerButton): This method is
defined in Controller, but is only meant to run on Macs. Override it with
an empty function for iOS.

12:11 AM Changeset in webkit [184432] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Add search icon to search bar
https://bugs.webkit.org/show_bug.cgi?id=139773

Patch by Tanay C <tanay.c@samsung.com> on 2015-05-16
Reviewed by Gyuyoung Kim.

  • MiniBrowser/efl/main.c:

(search_icon_show): Added.
(search_box_show): Modified.

May 15, 2015:

11:42 PM Changeset in webkit [184431] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run_benchmark should have an option to specify the number of runs
https://bugs.webkit.org/show_bug.cgi?id=145091

Reviewed by Stephanie Lewis.

Added --count option.

  • Scripts/run-benchmark:

(main):

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init):

9:24 PM Changeset in webkit [184430] by Simon Fraser
  • 4 edits
    2 adds in trunk

REGRESSION (r183300): Background missing on top links on apple.com
https://bugs.webkit.org/show_bug.cgi?id=145079
rdar://problem/20914252

Reviewed by Tim Horton.

Source/WebCore:

Re-land r184421 with a fix to check against rects.coverageRect
rather than the stale m_coverageRect.

Test: compositing/visible-rect/backing-change-height-from-zero.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldSkipLayerInDump):

LayoutTests:

Re-land.

  • compositing/visible-rect/backing-change-height-from-zero-expected.txt: Added.
  • compositing/visible-rect/backing-change-height-from-zero.html: Added.
8:47 PM Changeset in webkit [184429] by Matt Baker
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: empty timeline should not use previous timeline's zoom interval
https://bugs.webkit.org/show_bug.cgi?id=132754

Reviewed by Joseph Pecoraro.

When a timeline recording is started in response to a provisional load, TimelineManager should check whether
the main resource url is changing before loading a new timeline recording. If the main resource is changing,
set the selection start, selection duration, and duration-per-pixel settings of the TimelineOverview to their
default values.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.isCapturingPageReload):
(WebInspector.TimelineManager.prototype.capturingStopped):
(WebInspector.TimelineManager.prototype.pageDidLoad):
(WebInspector.TimelineManager.prototype._startAutoCapturing):
Added a property for checking whether auto capture was triggered by a page reload.

  • UserInterface/Views/LinearTimelineOverview.js:

(WebInspector.LinearTimelineOverview):
Increase default selection time to 15 seconds.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):
Reset selection and zoom if TimelineManager isn't capturing in response to a page reload.

(WebInspector.TimelineOverview.prototype.reset):
Reset selection and zoom.

(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
(WebInspector.TimelineOverview.prototype._resetSelection):
Added a helper function for resetting selection and zoom to their default values.

8:46 PM Changeset in webkit [184428] by Matt Baker
  • 2 edits in trunk/Source/WebCore

Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty
https://bugs.webkit.org/show_bug.cgi?id=144882

Reviewed by Joseph Pecoraro.

A timeline recording will always be stopped before the end of the current run loop is observed. Before
dispatching the recording stopped event, any events that are currently in progress should be considered
complete and sent to the frontend.

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStop):

8:00 PM Changeset in webkit [184427] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timeline data grid displays wrong records after switching between Timelines/Frames mode
https://bugs.webkit.org/show_bug.cgi?id=145084

Reviewed by Timothy Hatcher.

Update timeline sidebar filter whenever the view mode changes.

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
(WebInspector.TimelineSidebarPanel.get else):
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if):
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject):

7:31 PM Changeset in webkit [184426] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Bump image format number to force image regeneration
https://bugs.webkit.org/show_bug.cgi?id=145074

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-15
Reviewed by Timothy Hatcher.

  • UserInterface/Base/ImageUtilities.js:
7:24 PM Changeset in webkit [184425] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Don't reset the preview recognizer in [WKContentViewInteraction cleanupInteraction]
https://bugs.webkit.org/show_bug.cgi?id=145081

We shouldn't reset the recognizer in [WKContentViewInteraction cleanupInteraction] since we don't re-add it
back to WKContentView when the process relaunched. Since we already add/remove it when the view is move into/
removed from the window, we don't need reset it in cleanupInteraction.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-05-15
Reviewed by Dan Bernstein.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):

6:46 PM Changeset in webkit [184424] by mmaxfield@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Test the interaction between font-family and font-weight
https://bugs.webkit.org/show_bug.cgi?id=145078

Reviewed by Dean Jackson.

This test is designed to test the interaction between font-family and font-weight. In particular,
our implementation of font-family accepts PostScript names, which may name a font with a particular
weight. However, there is another CSS property, font-weight, in which the author may also name a
particular weight. Our font selection algorithm takes both of these signals into account when
choosing fonts.

There is currently no good way in JavaScript to find the actual font chosen for some text.
Therefore, the best way to test this aspect of the font selection algorithm is to dump the render
tree, therefore testing glyph advances (which are a property of font weight).

  • platform/mac/fast/text/font-weights-expected.txt: Added.
  • platform/mac/fast/text/font-weights.html: Added.
6:37 PM Changeset in webkit [184423] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r184421.
https://bugs.webkit.org/show_bug.cgi?id=145087

Introduced 42 layout test failures (Requested by rniwa on
#webkit).

Reverted changeset:

"REGRESSION (r183300): Background missing on top links on
apple.com"
https://bugs.webkit.org/show_bug.cgi?id=145079
http://trac.webkit.org/changeset/184421

5:21 PM Changeset in webkit [184422] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r181910): WKWebView incorrectly scales snapshot
https://bugs.webkit.org/show_bug.cgi?id=145076

Patch by James Savage <James Savage> on 2015-05-15
Reviewed by Tim Horton.

We added a fast path to snapshotting using IOSurfaces with
http://trac.webkit.org/changeset/181910 which incorrectly determined
scale and transform and resulted in bad snapshots in some situations.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):
When snapshotting an IOSurface we need to compute our scale based off of
the rect in the WKWebView coordinates, we also failed to account for
non-zero origins in the snapshot rect. Remove an unused varible while
we're here.

4:29 PM Changeset in webkit [184421] by Simon Fraser
  • 4 edits
    2 adds in trunk

REGRESSION (r183300): Background missing on top links on apple.com
https://bugs.webkit.org/show_bug.cgi?id=145079
rdar://problem/20914252

Reviewed by Tim Horton.

Source/WebCore:

GraphicsLayerCA::setVisibleAndCoverageRects() only set the m_intersectsCoverageRect
flag if the coverage rect changed, but it doesn't if you simply change the size of
the layer.

Instead, always re-evaluate the intersection, and set the CoverageRectChanged bit
if it changes.

Test: compositing/visible-rect/backing-change-height-from-zero.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldSkipLayerInDump): Don't skip any layers in a
debug layer dump, to assist debugging.

LayoutTests:

Composited box that toggles to a non-zero height and dumps layers.

  • compositing/visible-rect/backing-change-height-from-zero-expected.txt: Added.
  • compositing/visible-rect/backing-change-height-from-zero.html: Added.
3:55 PM Changeset in webkit [184420] by weinig@apple.com
  • 13 edits
    2 adds in trunk

Move HTMLElement's children property to ParentNode
https://bugs.webkit.org/show_bug.cgi?id=145072

Reviewed by Chris Dumez.

Source/WebCore:

Match the latest DOM standard and other browsers by moving the children property
to ParentNode, thus exposing it on Element, Document and DocumentFragment.

Test: fast/dom/ParentNode-children.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::children):
Moved implementation from HTMLElement to here.

(WebCore::ContainerNode::ensureCachedHTMLCollection):
(WebCore::ContainerNode::cachedHTMLCollection):
Moved implementation from Element to here so that ContainerNode::children
can use it.

(WebCore::ContainerNode::firstElementChild):
(WebCore::ContainerNode::lastElementChild):
(WebCore::ContainerNode::childElementCount):
Remove unnecessary assertions.

  • dom/ContainerNode.h:

Moved declarations from HTMLElement and Element to here.

  • dom/Element.cpp:

(WebCore::Element::ensureCachedHTMLCollection): Deleted.
(WebCore::Element::cachedHTMLCollection): Deleted.

  • dom/Element.h:

Moved to ContainerNode.

  • dom/Node.cpp:

(WebCore::Node::previousElementSibling):
(WebCore::Node::nextElementSibling):
Remove unnecessary assertions.

  • dom/ParentNode.idl:

Moved the children property here from HTMLElement.

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::children): Deleted.

  • html/HTMLElement.h:

Moved to ContainerNode.

  • html/HTMLElement.idl:

Get rid of the children property for all bindings except Objective-C which needs
to keep it to avoid changing the public API.

LayoutTests:

  • fast/dom/ParentNode-children-expected.txt: Added.
  • fast/dom/ParentNode-children.html: Added.

Test children on Element, Document and DocumentFragment.

  • fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:

Update results since document.children is no longer undefined.

  • js/dom/dom-static-property-for-in-iteration-expected.txt:

Update results.

3:10 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
2:59 PM Changeset in webkit [184419] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

WebCore ASan debug build fails. ERROR: WebCore has a weak external symbol in it.
https://bugs.webkit.org/show_bug.cgi?id=145070

Reviewed by David Kilzer.

Build fix.

  • Configurations/WebCore.unexp:
2:36 PM Changeset in webkit [184418] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce type annotation update frequency
https://bugs.webkit.org/show_bug.cgi?id=145066

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-15
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/TypeTokenAnnotator.js:

Reduce the frequency which could commonly be 16-24ms
to a minimum of 100ms and maximum of 2000ms.

2:31 PM Changeset in webkit [184417] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Prefix force on MouseEvent and add constants for click and force click values
https://bugs.webkit.org/show_bug.cgi?id=145065
-and corresponding-
rdar://problem/20770052

Reviewed by Tim Horton.

(WebCore::MouseEvent::webkitForce):

  • dom/MouseEvent.idl:
2:30 PM Changeset in webkit [184416] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebCore

[MediaControls] Refactor media controls & bring improvements made to iOS controls to Mac.
https://bugs.webkit.org/show_bug.cgi?id=144973

Reviewed by Dean Jackson.

Pull improvements made to the iOS media controls back into the Mac controls by moving
code from mediaControlsiOS.js into MediaControlsApple.js.

The largest refactored feature is the ability to drop individual controls from the media
controls when the video is too small to contain them. To allow these controls to resize
dynamically, a new "resize" event is fired inside the media element's shadow DOM.

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel .dropped): Added; sets "display: none".

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller): Set defaults for new variables.
(Controller.prototype.updateControls): Update the controls width; moved from iOS.js.
(Controller.prototype.handleReadyStateChange): Update the controls; moved from iOS.js.
(Controller.prototype.handleTimeUpdate): Update the progress; moved from iOS.js.
(Controller.prototype.handleTimelineInput): Pause if scrubbing; moved from iOS.js.
(Controller.prototype.handleTimelineChange): Update the progress; moved from iOS.js.
(Controller.prototype.showControls): Update the controls width; moved from iOS.js.
(Controller.prototype.hideControls): Removed _potentiallyScrubbing check; not needed due to changes

to controlsAlwaysVisible().

(Controller.prototype.scheduleUpdateLayoutForDisplayedWidth): Moved from iOS.js.
(Controller.prototype.isControlVisible): Added; checks whether control is parented & not hidden.
(Controller.prototype.updateLayoutForDisplayedWidth): Moved from iOS.js and refactored.
(Controller.prototype.controlsAlwaysVisible): Return true if scrubbing.
(Controller.prototype.updateHasAudio): Check currentPlaybackTargetIsWireless(); moved from iOS.js.
(Controller.prototype.get scrubbing): Simple getter for _scrubbing.
(Controller.prototype.set scrubbing): Check play state if scrubbing; start playback (if necessary)

if not scrubbing.

(Controller.prototype.get pageScaleFactor): Moved from iOS.js.
(Controller.prototype.set pageScaleFactor): Ditto.
(Controller.prototype.handleRootResize): Schedule an update of the contrtols width.

Remove a bunch of newly unnecessary code from the iOS media controls:

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS):
(ControllerIOS.prototype.createControls): Remove ivars moved into Apple.js.
(ControllerIOS.prototype.configureInlineControls): Remove spacer; made unnecessary.
(ControllerIOS.prototype.showControls): Deleted.
(ControllerIOS.prototype.updateTime): Deleted.
(ControllerIOS.prototype.handleTimelineTouchStart): Just call "scrubbing = true", handled in Apple.js.
(ControllerIOS.prototype.handleTimelineTouchEnd): Just call "scrubbing = false", handled in Apple.js.
(ControllerIOS.prototype.handleReadyStateChange): Deleted.
(ControllerIOS.prototype.setPlaying): Don't check _timelineIsHidden; not needed.
(ControllerIOS.prototype.get pageScaleFactor): Deleted.
(ControllerIOS.prototype.set pageScaleFactor): Deleted.
(ControllerIOS.prototype.scheduleUpdateLayoutForDisplayedWidth): Deleted.
(ControllerIOS.prototypeupdateLayoutForDisplayedWidth): Deleted.

Fire a "resize" event at the shadow DOM root when layout results in a size change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::layoutSizeChanged): Fire the "resize" event at the shadow DOM.

  • html/HTMLMediaElement.h:
  • rendering/RenderMedia.cpp:

(WebCore::RenderMedia::layout): Trigger layoutSizeChanged()

  • rendering/RenderMedia.h:

Drive-by fixes:

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls): aria-label text is totally wrong; removed.
(Controller.prototype.updateWirelessPlaybackStatus): Use class-names to hide controls, not inline styles.

2:11 PM Changeset in webkit [184415] by fpizlo@apple.com
  • 11 edits
    2 adds
    2 deletes in trunk/Source/JavaScriptCore

Insert store barriers late so that IR transformations don't have to worry about them
https://bugs.webkit.org/show_bug.cgi?id=145015

Reviewed by Geoffrey Garen.

We have had three kinds of bugs with store barriers. For the sake of discussion we say
that a store barrier is needed when we have something like:

base.field = value


  • We sometimes fail to realize that we could remove a barrier when value is a non-cell. This might happen if we prove value to be a non-cell even though in the FixupPhase it wasn't predicted non-cell.


  • We sometimes have a barrier in the wrong place after object allocation sinking. We might sink an allocation to just above the store, but that puts it just after the StoreBarrier that FixupPhase inserted.


  • We don't remove redundant barriers across basic blocks.


This comprehensively fixes these issues by doing store barrier insertion late, and
removing the store barrier elision phase. Store barrier insertion uses an epoch-based
algorithm to determine when stores need barriers. Briefly, a barrier is not needed if
base is in the current GC epoch (i.e. was the last object that we allocated or had a
barrier since last GC) or if base has a newer GC epoch than value (i.e. value would have
always been allocated before base). We do conservative things when merging epoch state
between basic blocks, and we only do such inter-block removal in the FTL. FTL also
queries AI to determine what type we've proved about value, and avoids barriers when
value is not a cell. FixupPhase still inserts type checks on some stores, to maximize
the likelihood that this AI-based removal is effective.

(JSC::DFG::BlockMap::at):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):

  • dfg/DFGEpoch.h:

(JSC::DFG::Epoch::operator<):
(JSC::DFG::Epoch::operator>):
(JSC::DFG::Epoch::operator<=):
(JSC::DFG::Epoch::operator>=):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::speculateForBarrier):
(JSC::DFG::FixupPhase::insertStoreBarrier): Deleted.

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGStoreBarrierElisionPhase.cpp: Removed.
  • dfg/DFGStoreBarrierElisionPhase.h: Removed.
  • dfg/DFGStoreBarrierInsertionPhase.cpp: Added.

(JSC::DFG::performFastStoreBarrierInsertion):
(JSC::DFG::performGlobalStoreBarrierInsertion):

  • dfg/DFGStoreBarrierInsertionPhase.h: Added.
2:10 PM Changeset in webkit [184414] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[ARM64] Do not fail branchConvertDoubleToInt32 when the result is zero and not negative zero
https://bugs.webkit.org/show_bug.cgi?id=144976

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-05-15
Reviewed by Michael Saboff.

Failing the conversion on zero is pretty dangerous as we discovered on x86.

This patch does not really impact performance significantly because
r184220 removed the zero checks from Kraken. This patch is just to be
on the safe side for cases not covered by existing benchmarks.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::branchConvertDoubleToInt32):

1:48 PM Changeset in webkit [184413] by achristensen@apple.com
  • 5 edits in trunk/Source

[Content Extensions] Fail to load old content extension files
https://bugs.webkit.org/show_bug.cgi?id=145027

Reviewed by Eric Carlson.

Source/WebCore:

  • contentextensions/DFABytecode.h:

Source/WebKit2:

  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::openAndMapContentExtension):

  • UIProcess/API/APIUserContentExtensionStore.h:
1:47 PM Changeset in webkit [184412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove unnecessary forward declarations in PropertyNameArray.h.
https://bugs.webkit.org/show_bug.cgi?id=145058

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-15
Reviewed by Andreas Kling.

No new tests, no behavior change.

  • runtime/PropertyNameArray.h:
1:47 PM Changeset in webkit [184411] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix some possible event listener leakers in content views
https://bugs.webkit.org/show_bug.cgi?id=145068

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-15
Reviewed by Timothy Hatcher.

Now that some content views can be closed that weren't closable before, ensure
we clean up after global event listeners that may strongly reference "this".

  • UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView.prototype.closed):

  • UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype.close):

  • UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView.prototype.closed):

  • UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView.prototype.closed):

  • UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView.prototype.closed):

  • UserInterface/Views/ScriptContentView.js:

(WebInspector.ScriptContentView.prototype.closed):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.closed):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.close):

  • UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView.prototype.closed):

  • UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype.closed):
(WebInspector.TimelineDataGrid.prototype.handleEvent):

1:45 PM Changeset in webkit [184410] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Initiator Popovers no longer work in Layout Timeline
https://bugs.webkit.org/show_bug.cgi?id=145067

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-05-15
Reviewed by Timothy Hatcher.

  • UserInterface/Views/LayoutTimelineDataGrid.js:

(WebInspector.LayoutTimelineDataGrid.prototype.callFramePopoverAnchorElement):
Update the column name, which changed in r183134.

1:45 PM Changeset in webkit [184409] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Temporarily disable failing API test.

  • TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:

(TestWebKitAPI::TEST):

1:21 PM Changeset in webkit [184408] by rniwa@webkit.org
  • 4 edits in branches/safari-600.7-branch/Tools

Merge r182018 and r181280.

2015-03-26 Jer Noble <jer.noble@apple.com>

Add --allowed-host support to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=142938

Reviewed by Brent Fulgham.

Accept --allowed-host arguments from run-webkit-tests and pass them through to
DumpRenderTree and WebKitTestRunner.

Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
are placed in the wrong location. The argument is compared with each tests's path, and if a
relative path or a path with '..' was used, results are placed alongside the test. Take the
absolute path of the --layout-test-dir argument, collapsing path components like '..'.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
  • Scripts/webkitpy/port/base.py: (Port.init): (Port.allowed_hosts):
  • Scripts/webkitpy/port/driver.py: (Driver.cmd_line):

2015-03-06 Jer Noble <jer.noble@apple.com>

Add an option to run-webkit-tests to override the LayoutTests/ directory
https://bugs.webkit.org/show_bug.cgi?id=142418

Reviewed by David Kilzer.

Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
directory. The base port will parse the options during initialization and store the override
location if present. layout_tests_dir() will return this overridden location if set.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
  • Scripts/webkitpy/port/base.py: (Port.init): (Port.layout_tests_dir):
1:02 PM Changeset in webkit [184407] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

JSArray::setLength() should reallocate instead of zero-filling if the reallocation would be small enough.
https://bugs.webkit.org/show_bug.cgi?id=144622

Reviewed by Geoffrey Garen.

When setting the array to a new length that is shorter, we now check if it is worth
just making a new butterfly instead of clearing out the slots in the old butterfly
that resides beyond the new length. If so, we will make a new butterfly instead.

There is no perf differences in the benchmark results. However, this does benefit
the perf of pathological cases where we need to shorten the length of a very large
array, as is the case in tests/mozilla/js1_5/Array/regress-101964.js. With this
patch, we can expect that test to complete in a short time again.

  • runtime/JSArray.cpp:

(JSC::JSArray::setLength):

  • runtime/JSObject.cpp:

(JSC::JSObject::reallocateAndShrinkButterfly):

  • makes a new butterfly with a new shorter length.
  • runtime/JSObject.h:
  • tests/mozilla/js1_5/Array/regress-101964.js:
  • Undo this test change since this patch will prevent us from spending a lot of time clearing a large butterfly.
1:02 PM Changeset in webkit [184406] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Add clang pragmas to ignore

deprecation warnings.

12:30 PM Changeset in webkit [184405] by basile_clement@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFGLICMPhase shouldn't create NodeOrigins with forExit but without semantic
https://bugs.webkit.org/show_bug.cgi?id=145062

Reviewed by Filip Pizlo.

We assert in various places (including NodeOrigin::isSet()) that a
NodeOrigin's semantic and forExit must be either both set, or both
unset. However, LICM'ing a node with unset NodeOrigin would only set
forExit, and leave semantic unset. This can for instance happen when a
Phi node is constant-folded into a JSConstant, which in turn gets
LICM'd.

This patch changes DFGLICMPhase to set the NodeOrigin's semantic in
addition to its forExit if semantic was previously unset.

It also adds two validators to DFGValidate.cpp:

  • In both SSA and CPS form, a NodeOrigin semantic and forExit must be either both set or both unset
  • In CPS form, all nodes must have a set NodeOrigin forExit (this is the CPS counterpart to the SSA validator that checks that all nodes must have a set NodeOrigin except possibly for a continuous chunk of nodes at the top of a block)
  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::attemptHoist):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::validateCPS):

12:12 PM Changeset in webkit [184404] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Limit alternate fullscreen with linked on or after.
https://bugs.webkit.org/show_bug.cgi?id=144894

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-05-15
Reviewed by Dean Jackson.

Source/WebCore:

  • platform/ios/WebCoreSystemInterfaceIOS.h: add new wkIOSSystemVersion

Source/WebKit/mac:

  • WebView/WebView.mm:

(shouldAllowAlternateFullscreen): Added.
(-[WebView _preferencesChanged:]):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(shouldAllowAlternateFullscreen): Added.
(-[WKWebView initWithFrame:configuration:]):

12:07 PM Changeset in webkit [184403] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Revert part of r184361.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.configureInlineControls):
HI wants the buttons flipped.

11:44 AM Changeset in webkit [184402] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix trivial typo in TextEncodingDetectorICU.cpp.
https://bugs.webkit.org/show_bug.cgi?id=145055

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-05-15
Reviewed by Alexey Proskuryakov.

No new tests, no behavior change..

  • platform/text/TextEncodingDetectorICU.cpp:

(WebCore::detectTextEncoding):

11:41 AM Changeset in webkit [184401] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Cyrillic top-level domains are displayed as punycode
https://bugs.webkit.org/show_bug.cgi?id=145024
rdar://problem/17747133
rdar://problem/14116594

Reviewed by Tim Horton.

Handling each TLD in code is annoying, but we can probably survive like this
for a few more years, and maybe we'll think of an entirely different way to deal
with non-ASCII domain labels in the meanwhile.

  • platform/mac/WebCoreNSURLExtras.mm:

(WebCore::isSecondLevelDomainNameAllowedByTLDRules):
(WebCore::allCharactersAllowedByTLDRules):

11:40 AM Changeset in webkit [184400] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Cursor is displayed after full screen video controls fade away.
https://bugs.webkit.org/show_bug.cgi?id=145034.
<rdar://problem/20458604>

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsApple.css:

(video::-webkit-media-controls-panel):
Unnecessary cursor style is on the control panel while hidden but
the cursor will already be hidden anyways from being auto-hidden.
Causes style to change when controls are hidden,
which causes the cursor to reappear.

11:25 AM Changeset in webkit [184399] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][Cocoa] Back swipe tab snapshot takes a long time to be removed on bing.com
https://bugs.webkit.org/show_bug.cgi?id=145061
<rdar://problem/20939743>

Reviewed by Tim Horton.

When swiping back from a video search result to the list of video
search results on bing.com, the back swipe gesture tab snapshot takes
~3 seconds to be removed, even though the page gets loaded almost
instantly from PageCache. The tab snapshot should be removed as soon as
the load is done.

The issue is that we only cleared the back swipe gesture tab snapshot
after PageClient::didFinishLoadForMainFrame() has been called. However,
PageClient::didFinishLoadForMainFrame() was only being called by
WebPageProxy if the main frame loaded *without* error. In case the main
frame loaded with an error, only WebPageProxy::didFailLoadForFrame() is
called, not WebPageProxy::didFinishLoadForFrame() and we would fail to
remove the gesture snapshot until the 3 seconds timeout.

This patch calls PageClient::didFinishLoadForMainFrame() from
WebPageProxy::didFailLoadForFrame() so we remove the snapshot in the
error case as well.

The reason didFailLoadForFrame() is being called on bing.com video
search results is because a "ping" load is aborted when the page is
entering PageCache. Aborting any kind of resource load sets a
"cancellation" error on the main document.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didFailLoadForFrame):

11:21 AM Changeset in webkit [184398] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, remove an unused declaration.

  • dfg/DFGSpeculativeJIT.h:
11:09 AM Changeset in webkit [184397] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Remove unused constant-base and constant-value store barrier code in the DFG
https://bugs.webkit.org/show_bug.cgi?id=145039

Reviewed by Andreas Kling.

Just killing dead code.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::storeToWriteBarrierBuffer): Deleted.
(JSC::DFG::SpeculativeJIT::writeBarrier): Deleted.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::writeBarrier):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::writeBarrier):

10:58 AM Changeset in webkit [184396] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Checkmark on OFF option of captions sometimes does not appear.
https://bugs.webkit.org/show_bug.cgi?id=145060.
<rdar://problem/19388333>

Reviewed by Eric Carlson.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.buildCaptionMenu):
Audio tracks don’t have an OFF option.
Remove related code to allow OFF option for subtitles to work properly.

10:39 AM Changeset in webkit [184395] by Alan Bujtas
  • 17 edits
    2 adds in trunk

White edge on animating panel on http://rokkosunnyvale.com
https://bugs.webkit.org/show_bug.cgi?id=144986
rdar://problem/20907683

Reviewed by Simon Fraser.

Background image geometry calculation needs to be based on the final painting size of the container
in order to accurately compute tile sizes, repeating positions etc.
The container's size is pixelsnapped at painting using absolute coordinates. This patch
ensures that we snap to the same size while computing background geometry.

Source/WebCore:

Test: fast/images/background-image-size-changes-fractional-position.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintBackground):
(WebCore::RenderBox::getBackgroundPaintedExtent):
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderBox::maskClipRect):
(WebCore::RenderBox::repaintLayerRectsForImage): unable to get absolute coords.

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage):
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderFieldset.cpp:

(WebCore::RenderFieldset::paintBoxDecorations):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground):
(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured):

  • rendering/RenderImage.h:
  • rendering/RenderLayer.cpp: unable to get absolute coords.

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage): currently not used.

  • rendering/RenderObject.h:

(WebCore::RenderObject::computeBackgroundIsKnownToBeObscured):
(WebCore::RenderObject::backgroundIsKnownToBeObscured):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground):

  • rendering/RenderTableCell.h:

LayoutTests:

  • fast/backgrounds/hidpi-bitmap-background-repeat-on-subpixel-position-expected.html: progression.
  • fast/images/background-image-size-changes-fractional-position-expected.html: Added.
  • fast/images/background-image-size-changes-fractional-position.html: Added.
10:15 AM Changeset in webkit [184394] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Crash in RenderFlowThread::popFlowThreadLayoutState() due to mismatched push/pop count
https://bugs.webkit.org/show_bug.cgi?id=145042

Reviewed by David Hyatt.

RenderFlowThread previously used a ListHashSet to store its stack of active objects. This
is problematic because, if the same object is pushed twice, only a single entry of that
object is added to the stack. After this occurs, a matching number of pushes will pop too
many items off the stack, causing a crash when popping a stack with zero items. This
specifically happens in FrameView::layout(), which will push its root renderer on the stack
of active items, and then ask the root to layout(), which will attempt to push itself on the
stack of active items.

Instead of a ListHashSet, use a Vector, which has similar memory characteristics and no
uniqueness requirements.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::pushFlowThreadLayoutState):
(WebCore::RenderFlowThread::popFlowThreadLayoutState):

  • rendering/RenderFlowThread.h:
9:46 AM Changeset in webkit [184393] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Build fix for some versions of clang.

  • wtf/SaturatedArithmetic.h:

(signedAddOverflows):
(signedSubtractOverflows):

8:32 AM Changeset in webkit [184392] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/LayoutTests

[GTK] Gardening 15th May.
https://bugs.webkit.org/show_bug.cgi?id=145047

Unreviewed.

Patch by Marcos Chavarría Teijeiro <mchavarria@igalia.com> on 2015-05-15

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
6:53 AM Changeset in webkit [184391] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.8.3

WebKitGTK+ 2.8.3

6:52 AM Changeset in webkit [184390] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.8

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.8.3 release.

.:

  • Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.8.3.
6:50 AM Changeset in webkit [184389] by peavo@outlook.com
  • 3 edits in trunk/Source/WebCore

[Curl] WebSocket platform part is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=144628

Reviewed by Darin Adler.

Add Curl platform code implementation for WebSockets.

  • platform/network/curl/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):
(WebCore::SocketStreamHandle::SocketData::SocketData):

  • platform/network/curl/SocketStreamHandleCurl.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::readData):
(WebCore::SocketStreamHandle::sendData):
(WebCore::SocketStreamHandle::waitForAvailableData):
(WebCore::SocketStreamHandle::startThread):
(WebCore::SocketStreamHandle::stopThread):
(WebCore::SocketStreamHandle::didReceiveData):
(WebCore::SocketStreamHandle::didOpenSocket):
(WebCore::SocketStreamHandle::createCopy):

5:56 AM Changeset in webkit [184388] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process
https://bugs.webkit.org/show_bug.cgi?id=144738

When converting the main resource handle to a download, the
NetworkResourceLoader is aborted, but the ResourceHandle shouldn't
be cleaned up because it's still used for the download.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::cleanup):

5:49 AM Changeset in webkit [184387] by Carlos Garcia Campos
  • 3 edits
    4 adds in releases/WebKitGTK/webkit-2.8

Merge r184373 - Images on www.fitstylelife.com jiggle on hover.
https://bugs.webkit.org/show_bug.cgi?id=145020
rdar://problem/20885337

Reviewed by Simon Fraser.

This patch ensures that the clipping layer of a composited content is pixel snapped properly.

Source/WebCore:

Tests: compositing/composited-parent-clipping-layer-on-subpixel-position.html

compositing/parent-clipping-layer-on-subpixel-position.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

LayoutTests:

  • compositing/composited-parent-clipping-layer-on-subpixel-position-expected.html: Added.
  • compositing/composited-parent-clipping-layer-on-subpixel-position.html: Added.
  • compositing/parent-clipping-layer-on-subpixel-position-expected.html: Added.
  • compositing/parent-clipping-layer-on-subpixel-position.html: Added.
5:46 AM Changeset in webkit [184386] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r184355 - Crash in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
https://bugs.webkit.org/show_bug.cgi?id=119068

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by makeInsertedContentRoundTrippableWithHTMLTreeBuilder not updating
nodes kept tracked by insertedNodes and moveNodeOutOfAncestor stumbling upon it.

Fixed the bug by updating insertedNodes in makeInsertedContentRoundTrippableWithHTMLTreeBuilder.

Test: editing/inserting/insert-table-in-paragraph-crash.html

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
(WebCore::ReplaceSelectionCommand::moveNodeOutOfAncestor):

  • editing/ReplaceSelectionCommand.h:

LayoutTests:

Added a test based on https://chromium.googlesource.com/chromium/blink/+/3500267482e60550ce84fadd6c0db883937ce744

  • editing/inserting/insert-table-in-paragraph-crash-expected.txt: Added.
  • editing/inserting/insert-table-in-paragraph-crash.html: Added.
5:44 AM Changeset in webkit [184385] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/JavaScriptCore

Merge r184346 - String.prototype.split() should create efficient substrings.
<https://webkit.org/b/144985>
<rdar://problem/20949344>

Reviewed by Geoffrey Garen.

Teach split() how to make substring JSStrings instead of relying on StringImpl's
substring sharing mechanism. The optimization works by deferring the construction
of a StringImpl until the substring's value is actually needed.

This knocks ~2MB off of theverge.com by avoiding the extra StringImpl allocations.
Out of ~70000 substrings created by split(), only ~2000 of them get reified.

  • runtime/StringPrototype.cpp:

(JSC::jsSubstring):
(JSC::splitStringByOneCharacterImpl):
(JSC::stringProtoFuncSplit):

5:38 AM Changeset in webkit [184384] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebKit2

Merge r184334 - [GTK] Add missing ENABLE(NETSCAPE_PLUGIN_API) build guards
https://bugs.webkit.org/show_bug.cgi?id=144994

Reviewed by Carlos Garcia Campos.

This fixes the build when configured with Netscape plugin API
support disabled.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkit_web_context_set_additional_plugins_directory):
(webkitWebContextGetPluginThread):

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::launchProcess):

5:37 AM Changeset in webkit [184383] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r184323 - REGRESION (r179958): Crash in WebCore::DocumentLoader::detachFromFrame when -[id<WebPolicyDelegate> decidePolicyForMIMEType:request:frame:decisionListener:] fails to call -[id<WebPolicyDecisionListener> download|ignore|use]
<http://webkit.org/b/144975>

Reviewed by Andy Estes.

This change reverts r179958. It changes RELEASE_ASSERT*()
statements back to Debug-only ASSERT*() statements.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::detachFromFrame):

5:22 AM Changeset in webkit [184382] by Csaba Osztrogonác
  • 6 edits in trunk/Tools

User interruption while running of run-webkit-tests should also generate results.html
https://bugs.webkit.org/show_bug.cgi?id=122154

Patch by Ravi Phaneendra Kasibhatla <r.kasibhatla@samsung.com> on 2015-05-15
Reviewed by Csaba Osztrogonác.

Generation of results.html on execution of run-webkit-tests happens only
on completion of entire layout tests run. It should be created even when
the execution has been interrupted - either by user (by pressing Ctrl+C)
or because of other interruptions (like exit-after-n-failures option).

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.init):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_keyboard_interrupt):
(MainTest.test_exception_handling):

5:04 AM Changeset in webkit [184381] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r184293 - Don't compute selection painting info when we don't have selection.
https://bugs.webkit.org/show_bug.cgi?id=144920
<rdar://problem/20919920>

Reviewed by Simon Fraser.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

Just set the selection paint style to the text paint style when we don't have a selection
at all. Computing the selection style takes time in the case where a ::selection pseudo is
used on the page, so we don't want to waste time computing that info unless it's actually
needed.

4:59 AM Changeset in webkit [184380] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.8

Merge r184219 - REGRESSION(r175617): Some text doesn't render on internationalculinarycenter.com
https://bugs.webkit.org/show_bug.cgi?id=144917
rdar://problem/20545878

Reviewed by Andreas Kling.

This patch ensures that text stroke width value is taken into account while
calculating visual overflow for simple line layout.
Ceiling the text stroke width value matches the normal text layout behaviour.

Source/WebCore:

Test: fast/text/simple-line-layout-text-stroke-width.html

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):
(WebCore::SimpleLineLayout::collectFlowOverflow):

LayoutTests:

  • fast/text/simple-line-layout-text-stroke-width-expected.txt: Added.
  • fast/text/simple-line-layout-text-stroke-width.html: Added.
4:54 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
4:00 AM Changeset in webkit [184379] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[buildbot] Fix the URL of the performance bots
https://bugs.webkit.org/show_bug.cgi?id=145043

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2:50 AM WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
2:22 AM Changeset in webkit [184378] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Fix typo in function name parseFunctionParamters -> parseFunctionParameters
https://bugs.webkit.org/show_bug.cgi?id=145040

Patch by Alexandr Skachkov <gskachkov@gmail.com> on 2015-05-15
Reviewed by Mark Lam.

  • parser/Parser.h:
  • parser/Parser.cpp:
1:42 AM Changeset in webkit [184377] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.8/Source/WebCore

Merge r184273 - [EGL][X11] XPixmap created in GLContextEGL::createPixmapContext() is leaked
https://bugs.webkit.org/show_bug.cgi?id=144909

Reviewed by Sergio Villar Senin and Žan Doberšek.

The pixmap is created and passed to eglCreatePixmapSurface(), but
never released. eglCreatePixmapSurface() doesn't take the
ownership of the pixmap, so we should explicitly free it when the
GLContextEGL is destroyed.

  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createPixmapContext): Use XUniquePixmap
and transfer the ownership to the context by using the new
constructor that receives a XUniquePixmap&&.
(WebCore::GLContextEGL::createContext): createPixmapContext() is
now only defined for X11.
(WebCore::GLContextEGL::GLContextEGL): New constructor that
receives a XUniquePixmap&&.

  • platform/graphics/egl/GLContextEGL.h: Add new constructor and

initialize the cairo device when defined to simplify constructors.

1:03 AM Changeset in webkit [184376] by Carlos Garcia Campos
  • 5 edits in trunk/Source

REGRESSION(r183861): [SOUP] Downloads are broken when using the Network Process
https://bugs.webkit.org/show_bug.cgi?id=144738

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Add ResourceHandle::releaseForDownload() that releases the current
handle to be used as a download.

  • platform/network/ResourceHandle.h:
  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::releaseForDownload):

Source/WebKit2:

When converting the main resource handle to a download, the
NetworkResourceLoader is aborted, and the ResourceHandle is
cleaned up aborting the download operation. We need to use a
different ResourceHandle for the download operation.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::startWithHandle): Use ResourceHandle::releaseForDownload()
instead of reusing the given handle.

1:01 AM Changeset in webkit [184375] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Removed failing test expectations from passing tests.

12:05 AM Changeset in webkit [184374] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[GTK] Fix PlatformDisplayWayland construction error, implement the destructor
https://bugs.webkit.org/show_bug.cgi?id=144997

Reviewed by Carlos Garcia Campos.

The PlatformDisplayWayland constructor is private, so we can't use
std::make_unique<>() to construct an object of this class.

Implement the PlatformDisplayWayland destructor, cleaning out all
the Wayland resources, if present.

  • platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::create):
(WebCore::PlatformDisplayWayland::PlatformDisplayWayland):
(WebCore::PlatformDisplayWayland::~PlatformDisplayWayland):

Note: See TracTimeline for information about the timeline view.