Timeline



May 13, 2017:

11:05 PM Changeset in webkit [216838] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Unused lambda in JSWebKitSubtleCrypto::wrapKey()
<https://webkit.org/b/172087>

Reviewed by Chris Dumez.

Fixes the following warning with newer clang:

Source/WebCore/bindings/js/JSWebKitSubtleCryptoCustom.cpp:594:35: error: lambda capture 'keyFormat' is not used [-Werror,-Wunused-lambda-capture]

auto exportSuccessCallback = [keyFormat, algorithm, parameters, wrappingKey, wrapper](const Vector<uint8_t>& exportedKeyData) mutable {


  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::JSWebKitSubtleCrypto::wrapKey): Remove unused lambda.

10:37 PM Changeset in webkit [216837] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unused lambda capture in JSContextGroupAddMarkingConstraint()
<https://webkit.org/b/172084>

Reviewed by Saam Barati.

Fixes the following warning with newer clang:

Source/JavaScriptCore/API/JSMarkingConstraintPrivate.cpp:78:11: error: lambda capture 'vm' is not used [-Werror,-Wunused-lambda-capture]

[&vm, constraintCallback, userData]


  • API/JSMarkingConstraintPrivate.cpp:

(JSContextGroupAddMarkingConstraint): Remove unused lambda
capture for '&vm'.

10:27 PM Changeset in webkit [216836] by eric.carlson@apple.com
  • 39 edits
    2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::~MediaDevices): m_deviceChangedToken is a std::optional<>.

  • Modules/mediastream/MediaDevices.h:
  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.
(WebCore::RealtimeMediaSource::supportsConstraints):
(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::validateRequestConstraints): Implement.

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.
(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): Deleted.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Deleted.

  • platform/mock/MockRealtimeMediaSourceCenter.h:

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

  • UIProcess/UserMediaPermissionCheckProxy.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

Tools:

The device ID hash salt is now required for getUserMedia to check deviceId constraint, so
implement the "checkUserMediaPermission" callback.

  • TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
(TestWebKitAPI::checkUserMediaPermissionCallback):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/UserMediaDisabled.mm:

(-[UserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):

LayoutTests:

  • fast/mediastream/get-user-media-device-id-expected.txt: Added.
  • fast/mediastream/get-user-media-device-id.html: Added.
  • fast/mediastream/apply-constraints-video-expected.txt: Updated.
  • fast/mediastream/apply-constraints-video.html: Ditto.
10:21 PM Changeset in webkit [216835] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] config.rb fails when checking some clang versions
<https://webkit.org/b/172082>

Reviewed by Mark Lam.

  • offlineasm/config.rb:
  • Add support for quad-dotted version of Apple clang (800.0.12.1).
  • Add support for checking open source clang version (5.0.0).
9:27 PM Changeset in webkit [216834] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

TestExpectations: Remove last refereneces to Legacy Notifications

Unreviewed test gardening fixes these lint warnings:

LayoutTests/TestExpectations:1222 Path does not exist. fast/notifications/notifications-event-stop-propagation.html
LayoutTests/TestExpectations:1223 Path does not exist. fast/notifications/notifications-multi-events.html

Notification support was removed in r216641.

9:04 PM Changeset in webkit [216833] by Chris Dumez
  • 28 edits in trunk

Stop using RefPtr::release()
https://bugs.webkit.org/show_bug.cgi?id=172074

Reviewed by Geoffrey Garen.

Source/WebCore:

  • css/parser/CSSPropertyParser.cpp:

(WebCore::FontVariantLigaturesParser::finalizeValue):
(WebCore::FontVariantNumericParser::finalizeValue):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeValue):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::create):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/archive/mhtml/MHTMLArchive.h:
  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::parseArchiveWithHeader):

  • platform/audio/ios/AudioFileReaderIOS.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/glib/SharedBufferGlib.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):

  • platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::copyCairoImageSurface):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::getImageData):

  • platform/graphics/gtk/IconGtk.cpp:

(WebCore::Icon::createIconForFiles):

  • platform/graphics/win/FontCacheWin.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

  • platform/win/SharedBufferWin.cpp:

(WebCore::SharedBuffer::createFromReadingFile):

Source/WebKit/win:

  • WebFrame.cpp:

(WebFrame::loadPlainTextString):
(WebFrame::loadHTMLString):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::receivedPolicyDecision):

Source/WebKit2:

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createImageBacking):

  • Shared/cairo/ShareableBitmapCairo.cpp:

(WebKit::ShareableBitmap::createCairoSurface):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMNodeFilter.cpp:

(WebKit::core):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getContentsAsMHTMLData):

Source/WTF:

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::dispatchAfter):

Tools:

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

7:20 PM Changeset in webkit [216832] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
7:18 PM Changeset in webkit [216831] by Ryan Haddad
  • 3 edits in branches/safari-603-branch/LayoutTests

Merge r216614.

6:07 PM Changeset in webkit [216830] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove flaky expectation for LayoutTest media/media-controls-clone-crash.html.
https://bugs.webkit.org/show_bug.cgi?id=171978

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:36 PM Changeset in webkit [216829] by jfernandez@igalia.com
  • 7 edits
    2 adds in trunk

[css-align] Implement the place-self shorthand
https://bugs.webkit.org/show_bug.cgi?id=168846

Reviewed by Zalan Bujtas.

Source/WebCore:

The CSS Box Alignment specification defines a new shorthand to set the
Content Alignment properties (align-self and justify-self) at the
same time.

This patch provides the implementation of the CSS parsing logic and the
required regression tests.

Test: css3/parse-place-self.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSProperties.json:
  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumePlaceSelfShorthand):
(WebCore::CSSPropertyParser::parseShorthand):

  • css/parser/CSSPropertyParser.h:

LayoutTests:

Regression tests for the new place-self alignment shorthand.

  • css3/parse-place-self-expected.txt: Added.
  • css3/parse-place-self.html: Added.
1:46 PM Changeset in webkit [216828] by jmarcell@apple.com
  • 6 edits
    2 adds in branches/safari-603-branch/Source

Cherry-pick r214313. rdar://problem/32080658

1:32 PM Changeset in webkit [216827] by commit-queue@webkit.org
  • 24 edits
    1 delete in trunk

Unreviewed, rolling out r216808.
https://bugs.webkit.org/show_bug.cgi?id=172075

caused lldb to hang when debugging (Requested by smfr on
#webkit).

Reverted changeset:

"Use Mach exceptions instead of signals where possible"
https://bugs.webkit.org/show_bug.cgi?id=171865
http://trac.webkit.org/changeset/216808

12:10 PM Changeset in webkit [216826] by commit-queue@webkit.org
  • 15 edits in trunk

Unreviewed, rolling out r216801.
https://bugs.webkit.org/show_bug.cgi?id=172072

Many memory corruption crashes on worker threads (Requested by
ap on #webkit).

Reverted changeset:

"WorkerRunLoop::Task::performTask() should check
!scriptController->isTerminatingExecution()."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216801

11:43 AM Changeset in webkit [216825] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

AccessibilityRenderObject::textUnderElement needs to assert on unclean tree.
https://bugs.webkit.org/show_bug.cgi?id=172065

Reviewed by Simon Fraser.

r192103 changed the assert logic incorrectly. If the tree is dirty, regardless of the renderer's type,
TextIterator will end up forcing style update/layout on the render tree.
The original assert would have hit with bug 171546 prior to r216726.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement):

11:24 AM Changeset in webkit [216824] by Simon Fraser
  • 7 edits
    2 adds in trunk

event.clientX/clientY should be in layout viewport coordinates
https://bugs.webkit.org/show_bug.cgi?id=172018

Reviewed by Zalan Bujtas.
Source/WebCore:

Fix clientX and clientY on mouse events to be relative to the layout viewport, to match
getBoundingClientRect(), getClientRects() and fixed-position objects.

Also minor cleanup of MouseRelatedEvent to use initializers.

Test: fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html

  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::MouseRelatedEvent::init):
(WebCore::MouseRelatedEvent::initCoordinates):
(WebCore::contentsScrollOffset): Deleted.

  • dom/MouseRelatedEvent.h:

LayoutTests:

  • fast/events/clientXY-in-zoom-and-scroll.html:
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport-expected.txt: Added.
  • fast/visual-viewport/client-coordinates-relative-to-layout-viewport.html: Added.
  • platform/ios/TestExpectations:
  • platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt:
10:33 AM Changeset in webkit [216823] by Chris Dumez
  • 37 edits in trunk/Source/WebKit/win

Drop uses of PassRefPtr in WebKit/win
https://bugs.webkit.org/show_bug.cgi?id=172067

Reviewed by Yusuke Suzuki.

  • DOMEventsClasses.cpp:

(DOMEvent::DOMEvent):
(DOMEvent::createInstance):

  • DOMEventsClasses.h:

(DOMUIEvent::DOMUIEvent):
(DOMKeyboardEvent::DOMKeyboardEvent):
(DOMMouseEvent::DOMMouseEvent):
(DOMMutationEvent::DOMMutationEvent):
(DOMOverflowEvent::DOMOverflowEvent):
(DOMWheelEvent::DOMWheelEvent):

  • MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::createInstance):

  • MemoryStream.h:
  • Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):
(WebCore::PluginDatabase::add):
(WebCore::PluginDatabase::loadPersistentMetadataCache):

  • Plugins/PluginDatabase.h:
  • Plugins/PluginPackage.cpp:

(WebCore::PluginPackage::createPackage):
(WebCore::PluginPackage::createPackageFromCache):

  • Plugins/PluginPackage.h:
  • Plugins/PluginStream.h:

(WebCore::PluginStream::create):

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::createInstance):

  • WebActionPropertyBag.h:
  • WebArchive.cpp:

(WebArchive::createInstance):
(WebArchive::WebArchive):

  • WebArchive.h:
  • WebBackForwardList.cpp:

(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::createInstance):

  • WebBackForwardList.h:
  • WebCoreSupport/EmbeddedWidget.cpp:

(EmbeddedWidget::create):

  • WebCoreSupport/EmbeddedWidget.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebFrame.cpp:

(WebFrame::loadData):
(WebFrame::createSubframeWithOwnerElement):

  • WebFrame.h:
  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::createInstance):

  • WebFramePolicyListener.h:
  • WebGeolocationPolicyListener.cpp:

(WebGeolocationPolicyListener::createInstance):
(WebGeolocationPolicyListener::WebGeolocationPolicyListener):

  • WebGeolocationPolicyListener.h:
  • WebHistoryItem.cpp:

(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::createInstance):

  • WebHistoryItem.h:
  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::setFormData):
(WebMutableURLRequest::formData):

  • WebMutableURLRequest.h:
  • WebResource.cpp:

(WebResource::createInstance):

  • WebResource.h:
  • WebScriptWorld.cpp:

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::createInstance):

  • WebScriptWorld.h:
  • WebURLAuthenticationChallengeSender.cpp:

(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::createInstance):

  • WebURLAuthenticationChallengeSender.h:
  • WebView.cpp:

(WebView::setFullScreenElement):

  • WebView.h:

May 12, 2017:

11:51 PM Changeset in webkit [216822] by jmarcell@apple.com
  • 36 edits
    15 moves
    1 add
    1 delete in branches/safari-604.1.21-branch

Cherry-pick r216809. rdar://problem/32141005

11:51 PM Changeset in webkit [216821] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216792. rdar://problem/32084098

11:51 PM Changeset in webkit [216820] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216774. rdar://problem/31587957

11:39 PM Changeset in webkit [216819] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/WebCore

[WebIDL] Remove need for custom binding for Worker constructor
https://bugs.webkit.org/show_bug.cgi?id=172050

Patch by Sam Weinig <sam@webkit.org> on 2017-05-12
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWorkerCustom.cpp: Removed.

Remove JSWorkerCustom.cpp

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/IDLAttributes.json:

Add RuntimeFlags as a new option for the ConstructorCallWith extended attribute.

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/Worker.h:

Update order of arguments to appease the generator.

  • workers/Worker.idl:

Add extended attributes for the constructor.

11:23 PM Changeset in webkit [216818] by jmarcell@apple.com
  • 8 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216599. rdar://problem/32081484

10:41 PM Changeset in webkit [216817] by Simon Fraser
  • 21 edits in trunk

The rects returned by Element/Range.getClientRects() should not be rounded
https://bugs.webkit.org/show_bug.cgi?id=172057

Reviewed by Chris Dumez.

Source/WebCore:

Fix createDOMRectVector() to not expand the rects to integer boundaries (which
quad.enclosingBoundingBox() does), but to return rects with floating point
values. This matches Chrome and Firefox, and matches getBoundingClientRect(),
which does not integral snap.

  • dom/DOMRect.cpp:

(WebCore::createDOMRectVector):

LayoutTests:

Fix tests that were sensitive to rounding. I had to mark fast/text/multiglyph-characters.html
as failing (webkit.org/b/172056).

  • TestExpectations:
  • fast/dom/Document/CaretRangeFromPoint/caretRangeFromPoint-in-zoom-and-scroll.html:
  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:
  • fast/dom/Range/simple-line-layout-getclientrects-expected.html:
  • fast/dom/Range/simple-line-layout-getclientrects.html:
  • fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
  • platform/ios/TestExpectations:
  • platform/ios/fast/multicol/client-rects-expected.txt:
  • platform/ios/fast/multicol/client-rects-spanners-complex-expected.txt:
  • platform/ios/fast/multicol/client-rects-spanners-expected.txt:
  • platform/ios/fast/multicol/newmulticol/client-rects-expected.txt:
  • platform/ios/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/mac/fast/multicol/client-rects-expected.txt:
  • platform/mac/fast/multicol/client-rects-spanners-complex-expected.txt:
  • platform/mac/fast/multicol/client-rects-spanners-expected.txt:
  • platform/mac/fast/multicol/newmulticol/client-rects-expected.txt:
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
10:26 PM Changeset in webkit [216816] by Chris Dumez
  • 43 edits in trunk/Source/WebKit

Drop uses of PassRefPtr in WebKit/mac
https://bugs.webkit.org/show_bug.cgi?id=172066

Reviewed by Sam Weinig.

Source/WebKit/ios:

Build fix.

  • Misc/WebGeolocationProviderIOS.mm:

Source/WebKit/mac:

  • History/WebBackForwardListInternal.h:
  • History/WebHistoryItem.mm:

(kit):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):

  • History/WebHistoryItemInternal.h:
  • Plugins/Hosted/HostedNetscapePluginStream.h:

(WebKit::HostedNetscapePluginStream::create):

  • Plugins/Hosted/NetscapePluginHostManager.h:
  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
(WebKit::NetscapePluginInstanceProxy::create):
(WebKit::NetscapePluginInstanceProxy::setManualStream):

  • Plugins/Hosted/ProxyInstance.h:

(WebKit::ProxyInstance::create):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::ProxyInstance):
(WebKit::ProxyInstance::newRuntimeObject):

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create):

  • Plugins/Hosted/ProxyRuntimeObject.mm:

(WebKit::ProxyRuntimeObject::ProxyRuntimeObject):

  • Plugins/Hosted/WebHostedNetscapePluginView.h:
  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

  • Plugins/WebNetscapePluginStream.h:

(WebNetscapePluginStream::create):

  • Plugins/WebNetscapePluginView.h:
  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:]):

  • WebCoreSupport/WebChromeClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebNotificationClient.mm:

(WebNotificationClient::requestPermission):
(-[WebNotificationPolicyListener initWithCallback:]):

  • WebCoreSupport/WebOpenPanelResultListener.mm:
  • WebCoreSupport/WebUserMediaClient.mm:

(WebUserMediaClient::requestUserMediaAccess):
(WebUserMediaClient::enumerateMediaDevices):
(-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
(-[WebUserMediaPolicyCheckerListener initWithMediaDevicesEnumerationRequest:]):

  • WebView/WebArchive.mm:

(-[WebArchivePrivate initWithCoreArchive:]):
(-[WebArchivePrivate setCoreArchive:]):
(-[WebArchive initWithData:]):
(-[WebArchive subframeArchives]):
(-[WebArchive _initWithCoreLegacyWebArchive:]):

  • WebView/WebArchiveInternal.h:
  • WebView/WebDataSource.mm:

(WebDataSourcePrivate::WebDataSourcePrivate):
(WebDataSourcePrivate::~WebDataSourcePrivate):
(-[WebDataSource _initWithDocumentLoader:]):

  • WebView/WebDataSourceInternal.h:
  • WebView/WebDeviceOrientation.mm:

(-[WebDeviceOrientation initWithCoreDeviceOrientation:]):

  • WebView/WebDeviceOrientationInternal.h:
  • WebView/WebFrame.mm:

(-[WebFrame _convertToDOMRange:]):
(-[WebFrame _convertToDOMRange:rangeIsRelativeTo:]):

  • WebView/WebFrameInternal.h:
  • WebView/WebFullScreenController.h:
  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController setElement:]):

  • WebView/WebGeolocationPosition.mm:

(-[WebGeolocationPositionInternal initWithCoreGeolocationPosition:]):
(-[WebGeolocationPosition initWithGeolocationPosition:]):

  • WebView/WebHTMLView.mm:

(currentKeyboardEvent):

  • WebView/WebResource.mm:
  • WebView/WebScriptWorld.mm:

(-[WebScriptWorld initWithWorld:]):
(+[WebScriptWorld standardWorld]):
(+[WebScriptWorld findOrCreateWorld:]):

  • WebView/WebViewData.h:

(LayerFlushController::create):

9:59 PM Changeset in webkit [216815] by ggaren@apple.com
  • 14 edits
    3 deletes in trunk/Source/JavaScriptCore

[JSC] DFG::Node should not have its own allocator
https://bugs.webkit.org/show_bug.cgi?id=160098

Reviewed by Saam Barati.

I just rebased the patch from <http://trac.webkit.org/changeset/203808>.

I ran Octane and JetStream locally on a MacBook Air and I wasn't able to
reproduce a regression. Let's land this again and see what the bots say.

(JSC::B3::SparseCollection::packIndices):

  • dfg/DFGAllocator.h: Removed.
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(JSC::DFG::Graph::deleteNode):
(JSC::DFG::Graph::packNodeIndices):
(JSC::DFG::Graph::addNodeToMapByIndex): Deleted.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addNode):
(JSC::DFG::Graph::maxNodeCount):
(JSC::DFG::Graph::nodeAt):

  • dfg/DFGLongLivedState.cpp: Removed.
  • dfg/DFGLongLivedState.h: Removed.
  • dfg/DFGNode.h:
  • dfg/DFGNodeAllocator.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPlan.h:
  • dfg/DFGWorklist.cpp:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
8:09 PM Changeset in webkit [216814] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216307. rdar://problem/32119568

8:03 PM Changeset in webkit [216813] by jiewen_tan@apple.com
  • 3 edits
    2 adds in trunk

Elements should be inserted into a template element as its content's last child
https://bugs.webkit.org/show_bug.cgi?id=171373
<rdar://problem/31862949>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Before this change, our HTML parser obeys the following premises:
1) A fostering child whose parent is a table should be inserted before its parent and under its grandparent.
2) When inserting into a template element, an element should be inserted into its content.

Let's walk through the example:
a) Before eventhandler takes place
template
table

svg <- parser

b) After eventhandler takes place
template

table

svg <- parser

c) after parsing svg
template

content

svg
(table)

table

Finally, in the example, the svg element will be inserted into the content of the template element while
having its next sibling point to the table element. However, the table element is actually under the
template element not its content.

This messy tree is constructed because the second premise is incompleted. It should be: When inserting into
a template element, an element should be inserted into its content as its last child.
Quoted from Step 3 of https://html.spec.whatwg.org/multipage/syntax.html#appropriate-place-for-inserting-a-node
A correct tree will then looks like:
template

content

svg

table

Tests: fast/dom/HTMLTemplateElement/insert-fostering-child-crash.html

fast/dom/HTMLTemplateElement/insert-fostering-child.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
By nullifying task.nextChild, it will force the parser to append the element as task.parent's last child.

LayoutTests:

  • fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/insert-fostering-child.html: Added.
7:05 PM Changeset in webkit [216812] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

7:02 PM Changeset in webkit [216811] by rniwa@webkit.org
  • 699 adds in trunk/Websites/browserbench.org

Add Websites/browserbench.org
https://bugs.webkit.org/show_bug.cgi?id=172049

Rubber-stamped by Geoffrey Garen.

Added the current contents of browserbench.org.

  • ARES-6/ARES-6.svg: Added.
  • ARES-6/Air/README.md: Added.
  • ARES-6/Air/airjs-tests.yaml: Added.
  • ARES-6/Air/all.js: Added.
  • ARES-6/Air/allocate_stack.js: Added.
  • ARES-6/Air/arg.js: Added.
  • ARES-6/Air/basic_block.js: Added.
  • ARES-6/Air/benchmark.js: Added.
  • ARES-6/Air/code.js: Added.
  • ARES-6/Air/custom.js: Added.
  • ARES-6/Air/frequented_block.js: Added.
  • ARES-6/Air/insertion_set.js: Added.
  • ARES-6/Air/inst.js: Added.
  • ARES-6/Air/liveness.js: Added.
  • ARES-6/Air/make_dist.sh: Added.
  • ARES-6/Air/opcode.js: Added.
  • ARES-6/Air/payload-airjs-ACLj8C.js: Added.
  • ARES-6/Air/payload-gbemu-executeIteration.js: Added.
  • ARES-6/Air/payload-imaging-gaussian-blur-gaussianBlur.js: Added.
  • ARES-6/Air/payload-typescript-scanIdentifier.js: Added.
  • ARES-6/Air/reg.js: Added.
  • ARES-6/Air/stack_slot.js: Added.
  • ARES-6/Air/stress-test.js: Added.
  • ARES-6/Air/strip-hash.rb: Added.
  • ARES-6/Air/symbols.js: Added.
  • ARES-6/Air/test.html: Added.
  • ARES-6/Air/test.js: Added.
  • ARES-6/Air/tmp.js: Added.
  • ARES-6/Air/tmp_base.js: Added.
  • ARES-6/Air/util.js: Added.
  • ARES-6/Babylon/AUTHORS: Added.
  • ARES-6/Babylon/air-blob.js: Added.
  • ARES-6/Babylon/babylon-blob.js: Added.
  • ARES-6/Babylon/basic-blob.js: Added.
  • ARES-6/Babylon/benchmark.js: Added.
  • ARES-6/Babylon/index.js: Added.
  • ARES-6/Babylon/inspector-blob.js: Added.
  • ARES-6/Basic/ast.js: Added.
  • ARES-6/Basic/basic-tests.yaml: Added.
  • ARES-6/Basic/basic.js: Added.
  • ARES-6/Basic/benchmark.js: Added.
  • ARES-6/Basic/caseless_map.js: Added.
  • ARES-6/Basic/lexer.js: Added.
  • ARES-6/Basic/number.js: Added.
  • ARES-6/Basic/parser.js: Added.
  • ARES-6/Basic/random.js: Added.
  • ARES-6/Basic/state.js: Added.
  • ARES-6/Basic/stress-test.js: Added.
  • ARES-6/Basic/test.html: Added.
  • ARES-6/Basic/test.js: Added.
  • ARES-6/Basic/util.js: Added.
  • ARES-6/about.html: Added.
  • ARES-6/air_benchmark.js: Added.
  • ARES-6/babylon_benchmark.js: Added.
  • ARES-6/basic_benchmark.js: Added.
  • ARES-6/cli.js: Added.
  • ARES-6/driver.js: Added.
  • ARES-6/glue.js: Added.
  • ARES-6/index.html: Added.
  • ARES-6/ml/benchmark.js: Added.
  • ARES-6/ml/index.js: Added.
  • ARES-6/ml_benchmark.js: Added.
  • ARES-6/results.js: Added.
  • ARES-6/stats.js: Added.
  • ARES-6/styles.css: Added.
  • ARES-6/swoop.svg: Added.
  • JetStream/CDjsSetup.js: Added.
  • JetStream/JetStream-Logo.png: Added.
  • JetStream/JetStream-Logo@2x.png: Added.
  • JetStream/JetStream.css: Added.
  • JetStream/JetStreamDriver.js: Added.
  • JetStream/LLVM-test-suite-LICENSE.txt: Added.
  • JetStream/Octane/base.js: Added.
  • JetStream/Octane/code-load.js: Added.
  • JetStream/Octane2/base.js: Added.
  • JetStream/Octane2/box2d.js: Added.
  • JetStream/Octane2/code-load.js: Added.
  • JetStream/Octane2/crypto.js: Added.
  • JetStream/Octane2/deltablue.js: Added.
  • JetStream/Octane2/earley-boyer.js: Added.
  • JetStream/Octane2/gbemu-part1.js: Added.
  • JetStream/Octane2/gbemu-part2.js: Added.
  • JetStream/Octane2/mandreel.js: Added.
  • JetStream/Octane2/navier-stokes.js: Added.
  • JetStream/Octane2/pdfjs.js: Added.
  • JetStream/Octane2/raytrace.js: Added.
  • JetStream/Octane2/regexp.js: Added.
  • JetStream/Octane2/richards.js: Added.
  • JetStream/Octane2/run.js: Added.
  • JetStream/Octane2/splay.js: Added.
  • JetStream/Octane2/typescript-compiler.js: Added.
  • JetStream/Octane2/typescript-input.js: Added.
  • JetStream/Octane2/typescript.js: Added.
  • JetStream/Octane2/zlib-data.js: Added.
  • JetStream/Octane2/zlib.js: Added.
  • JetStream/Octane2Setup.js: Added.
  • JetStream/OctaneSetup.js: Added.
  • JetStream/Reference.js: Added.
  • JetStream/SimplePayload.js: Added.
  • JetStream/SimpleSetup.js: Added.
  • JetStream/SunSpiderPayload.js: Added.
  • JetStream/SunSpiderSetup.js: Added.
  • JetStream/Swoosh.png: Added.
  • JetStream/Swoosh@2x.png: Added.
  • JetStream/TestingSetup.js: Added.
  • JetStream/cdjs/benchmark.js: Added.
  • JetStream/cdjs/call_sign.js: Added.
  • JetStream/cdjs/collision.js: Added.
  • JetStream/cdjs/collision_detector.js: Added.
  • JetStream/cdjs/constants.js: Added.
  • JetStream/cdjs/motion.js: Added.
  • JetStream/cdjs/red_black_tree.js: Added.
  • JetStream/cdjs/reduce_collision_set.js: Added.
  • JetStream/cdjs/simulator.js: Added.
  • JetStream/cdjs/util.js: Added.
  • JetStream/cdjs/vector_2d.js: Added.
  • JetStream/cdjs/vector_3d.js: Added.
  • JetStream/in-depth.html: Added.
  • JetStream/index.html: Added.
  • JetStream/simple/bigfib.cpp: Added.
  • JetStream/simple/bigfib.cpp.js: Added.
  • JetStream/simple/container.cpp: Added.
  • JetStream/simple/container.cpp.js: Added.
  • JetStream/simple/dry.c: Added.
  • JetStream/simple/dry.c.js: Added.
  • JetStream/simple/float-mm.c: Added.
  • JetStream/simple/float-mm.c.js: Added.
  • JetStream/simple/gcc-loops.cpp: Added.
  • JetStream/simple/gcc-loops.cpp.js: Added.
  • JetStream/simple/hash-map.js: Added.
  • JetStream/simple/n-body.c: Added.
  • JetStream/simple/n-body.c.js: Added.
  • JetStream/simple/quicksort.c: Added.
  • JetStream/simple/quicksort.c.js: Added.
  • JetStream/simple/towers.c: Added.
  • JetStream/simple/towers.c.js: Added.
  • JetStream/sources/3d-cube.js: Added.
  • JetStream/sources/3d-raytrace.js: Added.
  • JetStream/sources/base64.js: Added.
  • JetStream/sources/bigfib.cpp: Added.
  • JetStream/sources/bigfib.cpp.js: Added.
  • JetStream/sources/box2d.js: Added.
  • JetStream/sources/cdjs-benchmark.js: Added.
  • JetStream/sources/cdjs-call_sign.js: Added.
  • JetStream/sources/cdjs-collision.js: Added.
  • JetStream/sources/cdjs-collision_detector.js: Added.
  • JetStream/sources/cdjs-constants.js: Added.
  • JetStream/sources/cdjs-motion.js: Added.
  • JetStream/sources/cdjs-red_black_tree.js: Added.
  • JetStream/sources/cdjs-reduce_collision_set.js: Added.
  • JetStream/sources/cdjs-simulator.js: Added.
  • JetStream/sources/cdjs-util.js: Added.
  • JetStream/sources/cdjs-vector_2d.js: Added.
  • JetStream/sources/cdjs-vector_3d.js: Added.
  • JetStream/sources/code-first-load-code-load.js: Added.
  • JetStream/sources/code-multi-load-code-load.js: Added.
  • JetStream/sources/container.cpp: Added.
  • JetStream/sources/container.cpp.js: Added.
  • JetStream/sources/crypto-aes.js: Added.
  • JetStream/sources/crypto-md5.js: Added.
  • JetStream/sources/crypto-sha1.js: Added.
  • JetStream/sources/crypto.js: Added.
  • JetStream/sources/date-format-tofte.js: Added.
  • JetStream/sources/date-format-xparb.js: Added.
  • JetStream/sources/deltablue.js: Added.
  • JetStream/sources/dry.c: Added.
  • JetStream/sources/dry.c.js: Added.
  • JetStream/sources/earley-boyer.js: Added.
  • JetStream/sources/float-mm.c: Added.
  • JetStream/sources/float-mm.c.js: Added.
  • JetStream/sources/gbemu-part1.js: Added.
  • JetStream/sources/gbemu-part2.js: Added.
  • JetStream/sources/gcc-loops.cpp: Added.
  • JetStream/sources/gcc-loops.cpp.js: Added.
  • JetStream/sources/hash-map.js: Added.
  • JetStream/sources/mandreel.js: Added.
  • JetStream/sources/n-body.c: Added.
  • JetStream/sources/n-body.c.js: Added.
  • JetStream/sources/n-body.js: Added.
  • JetStream/sources/navier-stokes.js: Added.
  • JetStream/sources/pdfjs.js: Added.
  • JetStream/sources/quicksort.c: Added.
  • JetStream/sources/quicksort.c.js: Added.
  • JetStream/sources/raytrace.js: Added.
  • JetStream/sources/regex-dna.js: Added.
  • JetStream/sources/regexp.js: Added.
  • JetStream/sources/richards.js: Added.
  • JetStream/sources/splay.js: Added.
  • JetStream/sources/tagcloud.js: Added.
  • JetStream/sources/towers.c: Added.
  • JetStream/sources/towers.c.js: Added.
  • JetStream/sources/typescript-compiler.js: Added.
  • JetStream/sources/typescript-input.js: Added.
  • JetStream/sources/typescript.js: Added.
  • JetStream/sources/zlib-data.js: Added.
  • JetStream/sources/zlib.js: Added.
  • JetStream/sunspider/3d-cube.js: Added.
  • JetStream/sunspider/3d-raytrace.js: Added.
  • JetStream/sunspider/base64.js: Added.
  • JetStream/sunspider/crypto-aes.js: Added.
  • JetStream/sunspider/crypto-md5.js: Added.
  • JetStream/sunspider/crypto-sha1.js: Added.
  • JetStream/sunspider/date-format-tofte.js: Added.
  • JetStream/sunspider/date-format-xparb.js: Added.
  • JetStream/sunspider/n-body.js: Added.
  • JetStream/sunspider/regex-dna.js: Added.
  • JetStream/sunspider/tagcloud.js: Added.
  • MotionMark/about.html: Added.
  • MotionMark/developer.html: Added.
  • MotionMark/index.html: Added.
  • MotionMark/resources/debug-runner/animometer.css: Added.
  • MotionMark/resources/debug-runner/animometer.js: Added.
  • MotionMark/resources/debug-runner/d3.min.js: Added.
  • MotionMark/resources/debug-runner/graph.js: Added.
  • MotionMark/resources/debug-runner/tests.js: Added.
  • MotionMark/resources/extensions.js: Added.
  • MotionMark/resources/runner/animometer.css: Added.
  • MotionMark/resources/runner/animometer.js: Added.
  • MotionMark/resources/runner/benchmark-runner.js: Added.
  • MotionMark/resources/runner/crystal.svg: Added.
  • MotionMark/resources/runner/lines.svg: Added.
  • MotionMark/resources/runner/logo.svg: Added.
  • MotionMark/resources/runner/tests.js: Added.
  • MotionMark/resources/statistics.js: Added.
  • MotionMark/resources/strings.js: Added.
  • MotionMark/tests/3d/resources/webgl.js: Added.
  • MotionMark/tests/3d/webgl.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-canvas-images.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-canvas-shapes.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-css-images.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-css-shapes.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-svg-images.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-svg-shapes.html: Added.
  • MotionMark/tests/bouncing-particles/bouncing-tagged-images.html: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-canvas-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-canvas-particles.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-canvas-shapes.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-css-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-css-shapes.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-particles.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-svg-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-svg-particles.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-svg-shapes.js: Added.
  • MotionMark/tests/bouncing-particles/resources/bouncing-tagged-images.js: Added.
  • MotionMark/tests/bouncing-particles/resources/image1.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image2.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image3.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image4.jpg: Added.
  • MotionMark/tests/bouncing-particles/resources/image5.jpg: Added.
  • MotionMark/tests/dom/compositing-transforms.html: Added.
  • MotionMark/tests/dom/focus.html: Added.
  • MotionMark/tests/dom/leaves.html: Added.
  • MotionMark/tests/dom/particles.html: Added.
  • MotionMark/tests/dom/resources/compositing-transforms.js: Added.
  • MotionMark/tests/dom/resources/dom-particles.js: Added.
  • MotionMark/tests/dom/resources/focus.js: Added.
  • MotionMark/tests/dom/resources/leaves.js: Added.
  • MotionMark/tests/master/canvas-stage.html: Added.
  • MotionMark/tests/master/focus.html: Added.
  • MotionMark/tests/master/image-data.html: Added.
  • MotionMark/tests/master/leaves.html: Added.
  • MotionMark/tests/master/multiply.html: Added.
  • MotionMark/tests/master/resources/canvas-stage.js: Added.
  • MotionMark/tests/master/resources/canvas-tests.js: Added.
  • MotionMark/tests/master/resources/compass.svg: Added.
  • MotionMark/tests/master/resources/compass100.png: Added.
  • MotionMark/tests/master/resources/console.svg: Added.
  • MotionMark/tests/master/resources/console100.png: Added.
  • MotionMark/tests/master/resources/contribute.svg: Added.
  • MotionMark/tests/master/resources/contribute100.png: Added.
  • MotionMark/tests/master/resources/debugger.svg: Added.
  • MotionMark/tests/master/resources/debugger100.png: Added.
  • MotionMark/tests/master/resources/focus.js: Added.
  • MotionMark/tests/master/resources/image-data.js: Added.
  • MotionMark/tests/master/resources/inspector.svg: Added.
  • MotionMark/tests/master/resources/inspector100.png: Added.
  • MotionMark/tests/master/resources/layout.svg: Added.
  • MotionMark/tests/master/resources/layout100.png: Added.
  • MotionMark/tests/master/resources/leaves.js: Added.
  • MotionMark/tests/master/resources/multiply.js: Added.
  • MotionMark/tests/master/resources/particles.js: Added.
  • MotionMark/tests/master/resources/performance.svg: Added.
  • MotionMark/tests/master/resources/performance100.png: Added.
  • MotionMark/tests/master/resources/script.svg: Added.
  • MotionMark/tests/master/resources/script100.png: Added.
  • MotionMark/tests/master/resources/shortcuts.svg: Added.
  • MotionMark/tests/master/resources/shortcuts100.png: Added.
  • MotionMark/tests/master/resources/standards.svg: Added.
  • MotionMark/tests/master/resources/standards100.png: Added.
  • MotionMark/tests/master/resources/storage.svg: Added.
  • MotionMark/tests/master/resources/storage100.png: Added.
  • MotionMark/tests/master/resources/styles.svg: Added.
  • MotionMark/tests/master/resources/styles100.png: Added.
  • MotionMark/tests/master/resources/svg-particles.js: Added.
  • MotionMark/tests/master/resources/text.js: Added.
  • MotionMark/tests/master/resources/timeline.svg: Added.
  • MotionMark/tests/master/resources/timeline100.png: Added.
  • MotionMark/tests/master/svg-particles.html: Added.
  • MotionMark/tests/master/text.html: Added.
  • MotionMark/tests/resources/main.js: Added.
  • MotionMark/tests/resources/math.js: Added.
  • MotionMark/tests/resources/stage.css: Added.
  • MotionMark/tests/resources/star.svg: Added.
  • MotionMark/tests/resources/yin-yang.png: Added.
  • MotionMark/tests/resources/yin-yang.svg: Added.
  • MotionMark/tests/simple/resources/simple-canvas-paths.js: Added.
  • MotionMark/tests/simple/resources/simple-canvas.js: Added.
  • MotionMark/tests/simple/resources/tiled-canvas-image.js: Added.
  • MotionMark/tests/simple/simple-canvas-paths.html: Added.
  • MotionMark/tests/simple/tiled-canvas-image.html: Added.
  • MotionMark/tests/template/resources/template-canvas.js: Added.
  • MotionMark/tests/template/resources/template-css.js: Added.
  • MotionMark/tests/template/resources/template-svg.js: Added.
  • MotionMark/tests/template/template-canvas.html: Added.
  • MotionMark/tests/template/template-css.html: Added.
  • MotionMark/tests/template/template-svg.html: Added.
  • MotionMark/version: Added.
  • Speedometer/Full.html: Added.
  • Speedometer/InteractiveRunner.html: Added.
  • Speedometer/resources/benchmark-report.js: Added.
  • Speedometer/resources/benchmark-runner.js: Added.
  • Speedometer/resources/flightjs-example-app/LICENSE.md: Added.
  • Speedometer/resources/flightjs-example-app/README.md: Added.
  • Speedometer/resources/flightjs-example-app/app/boot/page.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_data/compose_box.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_data/mail_items.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_data/move_to.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/compose_box.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/folders.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/mail_controls.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/mail_items.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/move_to_selector.js: Added.
  • Speedometer/resources/flightjs-example-app/app/component_ui/with_select.js: Added.
  • Speedometer/resources/flightjs-example-app/app/css/custom.css: Added.
  • Speedometer/resources/flightjs-example-app/app/data.js: Added.
  • Speedometer/resources/flightjs-example-app/app/templates.js: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/js/bootstrap.js: Added.
  • Speedometer/resources/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/.gitignore: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/CHANGES: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/LICENSE: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/README.md: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/component.json: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-sham.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-sham.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-shim.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/es5-shim.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/package.json: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/index.html: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Added.
  • Speedometer/resources/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/.travis.yml: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/advice.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/component.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/compose.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/index.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/logger.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/registry.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/lib/utils.js: Added.
  • Speedometer/resources/flightjs-example-app/components/flight/tools/debug/debug.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/LICENSE.md: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/README.md: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/bower.json: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/component.json: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/composer.json: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/jquery.js: Added.
  • Speedometer/resources/flightjs-example-app/components/jquery/jquery.min.js: Added.
  • Speedometer/resources/flightjs-example-app/components/mustache/mustache.js: Added.
  • Speedometer/resources/flightjs-example-app/components/requirejs/require.js: Added.
  • Speedometer/resources/flightjs-example-app/index.html: Added.
  • Speedometer/resources/flightjs-example-app/karma.conf.js: Added.
  • Speedometer/resources/flightjs-example-app/package.json: Added.
  • Speedometer/resources/flightjs-example-app/requireMain.js: Added.
  • Speedometer/resources/gauge.png: Added.
  • Speedometer/resources/gauge@2x.png: Added.
  • Speedometer/resources/logo.png: Added.
  • Speedometer/resources/logo@2x.png: Added.
  • Speedometer/resources/main.css: Added.
  • Speedometer/resources/main.js: Added.
  • Speedometer/resources/statistics.js: Added.
  • Speedometer/resources/tests.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/collections/todos.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/models/todo.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/routers/router.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/views/app-view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/views/todo-view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-data/ember-data.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/helpers/pluralize.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/models/todo.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/router.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/todos_view.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/test.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/css/app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/readme.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/.gitignore: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/.jshintrc: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/app.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/stats.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/todos.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/main.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/store.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/main_selector.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/new_item.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/stats.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/todo_list.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/toggle_all.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/with_filters.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/utils.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/templates/stats.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/templates/todo.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/depot/depot.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-sham.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-shim.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/advice.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/base.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/component.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/compose.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/debug.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/index.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/logger.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/registry.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/utils.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/jquery/jquery.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text/text.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs/require.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/index.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/karma.conf.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/readme.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/.jshintrc: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/footer.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/new_todo.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/toggle_all.html: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/mock/datastore.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/stats_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/todos_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/new_item_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/stats_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/toggle_all_spec.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/test-main.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower.json: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/index.html: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/app.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/footer.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/js/utils.jsx: Added.
  • Speedometer/resources/todomvc/labs/architecture-examples/react/readme.md: Added.
  • Speedometer/resources/todomvc/learn.json: Added.
  • Speedometer/resources/todomvc/license.md: Added.
  • Speedometer/resources/todomvc/readme.md: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower.json: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/app.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/controller.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/helpers.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/model.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/view.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/readme.md: Added.
  • index.html: Added.
  • resources/ARES-6-Logo.png: Added.
  • resources/ARES-6-Logo@2x.png: Added.
  • resources/JetStream-Logo.png: Added.
  • resources/JetStream-Logo@2x.png: Added.
  • resources/MotionMark-Logo.png: Added.
  • resources/MotionMark-Logo@2x.png: Added.
  • resources/Speedometer-Logo.png: Added.
  • resources/Speedometer-Logo@2x.png: Added.
  • resources/main.css: Added.
6:55 PM Changeset in webkit [216810] by Chris Dumez
  • 44 edits in trunk/Source/WebKit2

Drop remaining uses of PassRefPtr in WebKit2/WebProcess
https://bugs.webkit.org/show_bug.cgi?id=172055

Reviewed by Alex Christensen.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:

(+[WKWebProcessPlugInScriptWorld normalWorld]):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(contextMenuItems):

  • WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:

(WKBundleScriptWorldNormalWorld):

  • WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp:

(webkitScriptWorldCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.cpp:

(WebKit::InjectedBundleCSSStyleDeclarationHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleCSSStyleDeclarationHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):
(WebKit::InjectedBundleRangeHandle::create):
(WebKit::InjectedBundleRangeHandle::coreRange):
(WebKit::InjectedBundleRangeHandle::renderedImage):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::create):
(WebKit::InjectedBundle::createWebDataFromUint8Array):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.cpp:

(WebKit::InjectedBundleBackForwardList::itemAtIndex):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:

(WebKit::InjectedBundleBackForwardList::detach):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:

(WebKit::InjectedBundleBackForwardListItem::create):
(WebKit::InjectedBundleBackForwardListItem::InjectedBundleBackForwardListItem):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::nodeHandle):
(WebKit::InjectedBundleHitTestResult::urlElementHandle):

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:

(WebKit::InjectedBundleNavigationAction::create):
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):

  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::InjectedBundleScriptWorld::getOrCreate):
(WebKit::InjectedBundleScriptWorld::normalWorld):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::create):
(WebKit::NetscapePlugin::NetscapePlugin):
(WebKit::NetscapePlugin::supportsSnapshotting):

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::create):

  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):

  • WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
  • WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:

(WebKit::PDFPluginPasswordField::createAnnotationElement):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):

  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::worldMap):
(WebKit::WebUserMessageHandlerDescriptorProxy::create):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::addUserScript):
(WebKit::WebPage::addUserStyleSheet):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::create):

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::rangeForPosition):
(WebKit::rangeAtWordBoundaryForPosition):

  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
6:33 PM Changeset in webkit [216809] by achristensen@apple.com
  • 36 edits
    16 moves in trunk

Rename WKContentExtension to WKContentRuleList
https://bugs.webkit.org/show_bug.cgi?id=172053
<rdar://problem/32141005>

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by existing API tests.

  • English.lproj/Localizable.strings:

Source/WebKit2:

  • Shared/API/APIObject.h:
  • Shared/API/Cocoa/WebKit.h:
  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPageGroupAddUserContentFilter):
(WKPageGroupRemoveUserContentFilter):

  • Shared/Cocoa/APIObject.mm:

(API::Object::newObject):

  • Shared/WebCompiledContentExtension.cpp: Removed.
  • Shared/WebCompiledContentExtension.h: Removed.
  • Shared/WebCompiledContentExtensionData.cpp: Removed.
  • Shared/WebCompiledContentExtensionData.h: Removed.
  • Shared/WebCompiledContentRuleList.cpp: Copied from Source/WebKit2/Shared/WebCompiledContentExtension.cpp.

(WebKit::WebCompiledContentRuleList::create):
(WebKit::WebCompiledContentRuleList::WebCompiledContentRuleList):
(WebKit::WebCompiledContentRuleList::~WebCompiledContentRuleList):
(WebKit::WebCompiledContentRuleList::conditionsApplyOnlyToDomain):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecode):
(WebKit::WebCompiledContentRuleList::filtersWithoutConditionsBytecodeLength):
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecode):
(WebKit::WebCompiledContentRuleList::filtersWithConditionsBytecodeLength):
(WebKit::WebCompiledContentRuleList::topURLFiltersBytecode):
(WebKit::WebCompiledContentRuleList::topURLFiltersBytecodeLength):
(WebKit::WebCompiledContentRuleList::actions):
(WebKit::WebCompiledContentRuleList::actionsLength):
(WebKit::WebCompiledContentExtension::create): Deleted.
(WebKit::WebCompiledContentExtension::WebCompiledContentExtension): Deleted.
(WebKit::WebCompiledContentExtension::~WebCompiledContentExtension): Deleted.
(WebKit::WebCompiledContentExtension::conditionsApplyOnlyToDomain): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithoutConditionsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecode): Deleted.
(WebKit::WebCompiledContentExtension::filtersWithConditionsBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::topURLFiltersBytecode): Deleted.
(WebKit::WebCompiledContentExtension::topURLFiltersBytecodeLength): Deleted.
(WebKit::WebCompiledContentExtension::actions): Deleted.
(WebKit::WebCompiledContentExtension::actionsLength): Deleted.

  • Shared/WebCompiledContentRuleList.h: Copied from Source/WebKit2/Shared/WebCompiledContentExtension.h.
  • Shared/WebCompiledContentRuleListData.cpp: Copied from Source/WebKit2/Shared/WebCompiledContentExtensionData.cpp.

(WebKit::WebCompiledContentRuleListData::encode):
(WebKit::WebCompiledContentRuleListData::decode):
(WebKit::WebCompiledContentExtensionData::encode): Deleted.
(WebKit::WebCompiledContentExtensionData::decode): Deleted.

  • Shared/WebCompiledContentRuleListData.h: Copied from Source/WebKit2/Shared/WebCompiledContentExtensionData.h.

(WebKit::WebCompiledContentRuleListData::WebCompiledContentRuleListData):
(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData): Deleted.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/APIContentExtension.cpp: Removed.
  • UIProcess/API/APIContentExtension.h: Removed.
  • UIProcess/API/APIContentExtensionStore.cpp: Removed.
  • UIProcess/API/APIContentExtensionStore.h: Removed.
  • UIProcess/API/APIContentRuleList.cpp: Copied from Source/WebKit2/UIProcess/API/APIContentExtension.cpp.

(API::ContentRuleList::ContentRuleList):
(API::ContentRuleList::~ContentRuleList):
(API::ContentExtension::ContentExtension): Deleted.
(API::ContentExtension::~ContentExtension): Deleted.

  • UIProcess/API/APIContentRuleList.h: Copied from Source/WebKit2/UIProcess/API/APIContentExtension.h.
  • UIProcess/API/APIContentRuleListStore.cpp: Copied from Source/WebKit2/UIProcess/API/APIContentExtensionStore.cpp.

(API::ContentRuleListStore::legacyDefaultStore):
(API::ContentRuleListStore::nonLegacyDdefaultStore):
(API::ContentRuleListStore::defaultStore):
(API::ContentRuleListStore::storeWithPath):
(API::ContentRuleListStore::ContentRuleListStore):
(API::ContentRuleListStore::~ContentRuleListStore):
(API::constructedPathPrefix):
(API::ContentRuleListMetaData::fileSize):
(API::encodeContentRuleListMetaData):
(API::decodeContentRuleListMetaData):
(API::openAndMapContentRuleList):
(API::compiledToFile):
(API::createExtension):
(API::ContentRuleListStore::lookupContentRuleList):
(API::ContentRuleListStore::getAvailableContentRuleListIdentifiers):
(API::ContentRuleListStore::compileContentRuleList):
(API::ContentRuleListStore::removeContentRuleList):
(API::ContentRuleListStore::synchronousRemoveAllContentRuleLists):
(API::ContentRuleListStore::invalidateContentRuleListVersion):
(API::ContentRuleListStore::getContentRuleListSource):
(API::contentRuleListStoreErrorCategory):
(API::ContentExtensionStore::defaultStore): Deleted.
(API::ContentExtensionStore::storeWithPath): Deleted.
(API::ContentExtensionStore::ContentExtensionStore): Deleted.
(API::ContentExtensionStore::~ContentExtensionStore): Deleted.
(API::ContentExtensionMetaData::fileSize): Deleted.
(API::encodeContentExtensionMetaData): Deleted.
(API::decodeContentExtensionMetaData): Deleted.
(API::openAndMapContentExtension): Deleted.
(API::ContentExtensionStore::lookupContentExtension): Deleted.
(API::ContentExtensionStore::getAvailableContentExtensionIdentifiers): Deleted.
(API::ContentExtensionStore::compileContentExtension): Deleted.
(API::ContentExtensionStore::removeContentExtension): Deleted.
(API::ContentExtensionStore::synchronousRemoveAllContentExtensions): Deleted.
(API::ContentExtensionStore::invalidateContentExtensionVersion): Deleted.
(API::ContentExtensionStore::getContentExtensionSource): Deleted.
(API::contentExtensionStoreErrorCategory): Deleted.

  • UIProcess/API/APIContentRuleListStore.h: Copied from Source/WebKit2/UIProcess/API/APIContentExtensionStore.h.

(API::make_error_code):

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPageGroup.cpp:
  • UIProcess/API/C/WKUserContentControllerRef.cpp:

(WKUserContentControllerAddUserContentFilter):
(WKUserContentControllerRemoveAllUserContentFilters):

  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(WKUserContentExtensionStoreGetTypeID):

  • UIProcess/API/Cocoa/APIUserContentExtensionStoreCocoa.mm:

(API::ContentRuleListStore::defaultStorePath):
(API::ContentExtensionStore::defaultStorePath): Deleted.

  • UIProcess/API/Cocoa/WKContentExtension.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtension.mm: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionInternal.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStore.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStore.mm: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStoreInternal.h: Removed.
  • UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h: Removed.
  • UIProcess/API/Cocoa/WKContentRuleList.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtension.h.
  • UIProcess/API/Cocoa/WKContentRuleList.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtension.mm.

(-[WKContentRuleList dealloc]):
(-[WKContentRuleList _apiObject]):
(-[WKContentRuleList identifier]):
(-[WKContentExtension dealloc]): Deleted.
(-[WKContentExtension _apiObject]): Deleted.
(-[WKContentExtension identifier]): Deleted.

  • UIProcess/API/Cocoa/WKContentRuleListInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionInternal.h.

(WebKit::wrapper):

  • UIProcess/API/Cocoa/WKContentRuleListStore.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.h.
  • UIProcess/API/Cocoa/WKContentRuleListStore.mm: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStore.mm.

(toWKErrorCode):
(-[WKContentRuleListStore dealloc]):
(+[WKContentRuleListStore defaultStore]):
(+[WKContentRuleListStore storeWithURL:]):
(-[WKContentRuleListStore compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:]):
(-[WKContentRuleListStore _compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:releasesArgument:]):
(-[WKContentRuleListStore lookUpContentRuleListForIdentifier:completionHandler:]):
(-[WKContentRuleListStore getAvailableContentRuleListIdentifiers:]):
(-[WKContentRuleListStore removeContentRuleListForIdentifier:completionHandler:]):
(-[WKContentRuleListStore _apiObject]):
(-[WKContentRuleListStore _removeAllContentRuleLists]):
(-[WKContentRuleListStore _invalidateContentRuleListVersionForIdentifier:]):
(-[WKContentRuleListStore _getContentRuleListSourceForIdentifier:completionHandler:]):
(-[WKContentRuleListStore _compileContentRuleListForIdentifier:encodedContentRuleList:completionHandler:]):
(-[WKContentExtensionStore dealloc]): Deleted.
(+[WKContentExtensionStore defaultStore]): Deleted.
(+[WKContentExtensionStore storeWithURL:]): Deleted.
(-[WKContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]): Deleted.
(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:releasesArgument:]): Deleted.
(-[WKContentExtensionStore lookUpContentExtensionForIdentifier:completionHandler:]): Deleted.
(-[WKContentExtensionStore getAvailableContentExtensionIdentifiers:]): Deleted.
(-[WKContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]): Deleted.
(-[WKContentExtensionStore _apiObject]): Deleted.
(-[WKContentExtensionStore _removeAllContentExtensions]): Deleted.
(-[WKContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]): Deleted.
(-[WKContentExtensionStore _getContentExtensionSourceForIdentifier:completionHandler:]): Deleted.
(-[WKContentExtensionStore _compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]): Deleted.

  • UIProcess/API/Cocoa/WKContentRuleListStoreInternal.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStoreInternal.h.

(WebKit::wrapper):

  • UIProcess/API/Cocoa/WKContentRuleListStorePrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKContentExtensionStorePrivate.h.
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKError.mm:

(localizedDescriptionForErrorCode):

  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserContentController.mm:

(-[WKUserContentController addContentRuleList:]):
(-[WKUserContentController removeContentRuleList:]):
(-[WKUserContentController removeAllContentRuleLists]):
(-[WKUserContentController _addUserContentFilter:]):
(-[WKUserContentController _removeUserContentFilter:]):
(-[WKUserContentController _removeAllUserContentFilters]):
(-[WKUserContentController addContentExtension:]): Deleted.
(-[WKUserContentController removeContentExtension:]): Deleted.
(-[WKUserContentController removeAllContentExtensions]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(toUserContentRuleListStoreError):
(+[_WKUserContentExtensionStore defaultStore]):
(+[_WKUserContentExtensionStore storeWithURL:]):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore _apiObject]):
(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
(-[_WKUserContentExtensionStore _invalidateContentExtensionVersionForIdentifier:]):
(-[_WKUserContentExtensionStore _initWithWKContentRuleListStore:]):
(toUserContentExtensionStoreError): Deleted.
(-[_WKUserContentExtensionStore _initWithWKContentExtensionStore:]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStoreInternal.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h:
  • UIProcess/API/Cocoa/_WKUserContentFilter.mm:

(-[_WKUserContentFilter _apiObject]):
(-[_WKUserContentFilter _initWithWKContentRuleList:]):
(-[_WKUserContentFilter _initWithWKContentExtension:]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentFilterInternal.h:
  • UIProcess/API/Cocoa/_WKUserContentFilterPrivate.h:
  • UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::addProcess):
(WebKit::WebUserContentControllerProxy::addContentRuleList):
(WebKit::WebUserContentControllerProxy::removeContentRuleList):
(WebKit::WebUserContentControllerProxy::removeAllContentRuleLists):
(WebKit::WebUserContentControllerProxy::addContentExtension): Deleted.
(WebKit::WebUserContentControllerProxy::removeContentExtension): Deleted.
(WebKit::WebUserContentControllerProxy::removeAllContentExtensions): Deleted.

  • UIProcess/UserContent/WebUserContentControllerProxy.h:
  • UIProcess/WebPageGroup.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/UserContent/WebUserContentController.cpp:

(WebKit::WebUserContentController::addContentRuleLists):
(WebKit::WebUserContentController::removeContentRuleList):
(WebKit::WebUserContentController::removeAllContentRuleLists):
(WebKit::WebUserContentController::addContentExtensions): Deleted.
(WebKit::WebUserContentController::removeContentExtension): Deleted.
(WebKit::WebUserContentController::removeAllContentExtensions): Deleted.

  • WebProcess/UserContent/WebUserContentController.h:
  • WebProcess/UserContent/WebUserContentController.messages.in:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_backgroundCPULimit):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKContentExtensionStore.mm:

(WKContentRuleListStoreTest::SetUp):
(TEST_F):
(-[ContentRuleListDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(WKContentExtensionStoreTest::SetUp): Deleted.
(-[ContentExtensionDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.

6:30 PM Changeset in webkit [216808] by keith_miller@apple.com
  • 24 edits
    1 copy in trunk

Use Mach exceptions instead of signals where possible
https://bugs.webkit.org/show_bug.cgi?id=171865

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch adds some new JSC options. The first is an option that
enables or disables web assembly tier up. The second controls
whether or not we use mach exceptions (where available).

  • API/tests/ExecutionTimeLimitTest.cpp:

(dispatchTermitateCallback):
(testExecutionTimeLimit):

  • runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

  • runtime/Options.cpp:

(JSC::overrideDefaults):
(JSC::Options::initialize):

  • runtime/Options.h:
  • runtime/VMTraps.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::adjustPCToPointToTrappingInstruction):
(JSC::installSignalHandler):
(JSC::VMTraps::SignalSender::send):

  • tools/SigillCrashAnalyzer.cpp:

(JSC::SignalContext::SignalContext):
(JSC::SignalContext::dump):
(JSC::installCrashHandler):

  • wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::compileFunctions):

  • wasm/WasmFaultSignalHandler.cpp:

(JSC::Wasm::trapHandler):
(JSC::Wasm::enableFastMemory):

  • wasm/WasmMachineThreads.cpp:

(JSC::Wasm::resetInstructionCacheOnAllThreads):

Source/WTF:

This patch enables using mach exceptions on darwin. The way the
mach exception api works is that we create a mach port, which is
like a file descriptor. We then wait for a message to arrive on
that port in a thread. When another thread raises an exception (say
due to a bad memory access) the OS sends our thread a message. The
payload of that message is the register file of the crashing
thread. We then call our custom handlers that change the state as
needed. In order to restart the thread we send a payload back to
the OS with an updated register file along with a success message
header.

This patch also makes thread messages work without signals by
simply suspending the thread, and then running the message at that
time.

You can read more about mach exceptions here:
http://www.cs.cmu.edu/afs/cs/project/mach/public/doc/unpublished/exception.ps
and the Mach interface Generator (MiG) here:
http://www.cs.cmu.edu/afs/cs/project/mach/public/doc/unpublished/mig.ps

  • Configurations/WTF.xcconfig:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/Platform.h:
  • wtf/PlatformRegisters.h:

(WTF::registersFromUContext):

  • wtf/StackBounds.h:

(WTF::StackBounds::StackBounds):

  • wtf/ThreadHolder.cpp:

(WTF::ThreadHolder::~ThreadHolder):

  • wtf/ThreadMessage.cpp:

(WTF::sendMessageUsingSignal):
(WTF::sendMessageUsingMach):
(WTF::deliverMessagesUsingMach):
(WTF::sendMessageScoped):

  • wtf/ThreadMessage.h:

(WTF::sendMessage):

  • wtf/Threading.h:

(WTF::Thread::machThread):

  • wtf/mac/MachExceptions.defs: Copied from Source/WTF/wtf/ThreadMessage.h.
  • wtf/threads/Signals.cpp:

(WTF::startMachExceptionHandlerThread):
(WTF::fromMachException):
(WTF::toMachMask):
(WTF::handleSignalsWithMach):
(WTF::setExceptionPorts):
(WTF::activeThreads):
(WTF::registerThreadForMachExceptionHandling):
(WTF::unregisterThreadForMachExceptionHandling):
(WTF::installSignalHandler):
(WTF::jscSignalHandler):

  • wtf/threads/Signals.h:

Tools:

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(runThreadMessageTest):
(TEST):

6:00 PM Changeset in webkit [216807] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Don't use LinkPresentation URL shortening if it's not available
https://bugs.webkit.org/show_bug.cgi?id=172064
<rdar://problem/32169232>

Rubber-stamped by Wenson Hsieh.

  • platform/mac/DragImageMac.mm:

(WebCore::LinkImageLayout::LinkImageLayout):

  • platform/spi/cocoa/LinkPresentationSPI.h:
5:32 PM Changeset in webkit [216806] by commit-queue@webkit.org
  • 13 edits in trunk

Add objc version of WK2 UIPageClient setHasVideoInPictureInPicture and rename it to hasVideoInPictureInPictureDidChange.
https://bugs.webkit.org/show_bug.cgi?id=172048
rdar://problem/32163054

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-12
Reviewed by Simon Fraser.

Source/WebKit2:

Rename UIPageClient setHasVideoInPictureInPicture to hasVideoInPictureInPictureDidChange.
Add missing _allowsPictureInPictureMediaPlayback property to WKPreferences.
Add -hasVideoInPictureInPictureDidChange to UIDelegate.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::hasVideoInPictureInPictureDidChange):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _allowsPictureInPictureMediaPlayback]):
(-[WKPreferences _setAllowsPictureInPictureMediaPlayback:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::hasVideoInPictureInPictureDidChange):

  • UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):

Tools:

Add a WKWebView test for hasVideoInPictureInPictureDidChange UIDelegate callback.

  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html:
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm:

(hasVideoInPictureInPictureDidChange):
(-[PictureInPictureUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
(-[PictureInPictureUIDelegate userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):

5:31 PM Changeset in webkit [216805] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030

Unreviewed - Test gardening

Try to resolve this once and for all by using the WebsiteDataStore API to nuke everything
before the test starts.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(defaultWebsiteCacheDirectory):
(defaultApplicationCacheDirectory):
(TEST):
(defaultWebsiteDataDirectory): Deleted.

5:00 PM Changeset in webkit [216804] by bshafiei@apple.com
  • 7 edits in trunk/Source

Versioning.

4:48 PM Changeset in webkit [216803] by Simon Fraser
  • 19 edits
    5 adds in trunk

Incorrect position when dragging jQuery Draggable elements with position fixed after pinch zoom
https://bugs.webkit.org/show_bug.cgi?id=171113
Source/WebCore:

rdar://problem/31746516

Reviewed by Tim Horton.

Make getBoundingClientRect() and getClientRects() return rects which are relative to the layout
viewport, rather than the visual viewport. This goes part of the way to fixing webkit.org/b/170981,
which aims to make pinch-zoom invisible to web pages ("inert visual viewport"). It fixes issues on various
sites like Facebook when zoomed.

Factor coordinate conversion code into functions on FrameView, which now documents
the various coordinate systems in a big comment. Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale()
and Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale() are renamed and factored
to use these helpers.

There are two behavior changes here:

  1. FrameView::documentToClientOffset() now uses the origin of the layout viewport in the "document to client" coordinate mapping.
  1. The two document functions would apply the scale and offset in the wrong order. We need to first undo the effects of CSS zoom, page zoom and page scale, and then map from document to client coordinates.

Tests: fast/visual-viewport/client-rects-relative-to-layout-viewport.html

fast/zooming/client-rects-with-css-and-page-zoom.html

  • dom/Document.cpp:

(WebCore::Document::convertAbsoluteToClientQuads):
(WebCore::Document::convertAbsoluteToClientRect):
(WebCore::Document::adjustFloatQuadsForScrollAndAbsoluteZoomAndFrameScale): Deleted.
(WebCore::Document::adjustFloatRectForScrollAndAbsoluteZoomAndFrameScale): Deleted.

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):

  • dom/Range.cpp:

(WebCore::Range::borderAndTextQuads):

  • page/FrameView.cpp:

(WebCore::FrameView::absoluteToDocumentScaleFactor):
(WebCore::FrameView::absoluteToDocumentRect):
(WebCore::FrameView::absoluteToDocumentPoint):
(WebCore::FrameView::documentToClientOffset):
(WebCore::FrameView::documentToClientRect):
(WebCore::FrameView::documentToClientPoint):

  • page/FrameView.h:
  • platform/ScrollableArea.h: #pragma once
  • platform/Scrollbar.h: #pragma once
  • platform/Widget.h: #pragma once

LayoutTests:

Reviewed by Tim Horton.

Rebaseline tests which dumped the getBoundingClientRect for fixed elements; now that these
are layout viewport-relative, getBoundingClientRect() for a fixed element is unchanging.

New test that exercises getBoundingClientRect() and getClientRects() for fixed and absolute
elements after zooming.

  • fast/events/autoscroll-when-zoomed.html: Adjust to account for behavior change.
  • fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt: Added.
  • fast/visual-viewport/client-rects-relative-to-layout-viewport.html: Added.
  • fast/visual-viewport/zoomed-fixed-expected.txt:
  • fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
  • fast/zooming/client-rect-in-fixed-zoomed.html:
  • fast/zooming/client-rects-with-css-and-page-zoom-expected.txt: Added.
  • fast/zooming/client-rects-with-css-and-page-zoom.html: Added.
  • platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt: Added.
  • platform/ios/TestExpectations: Mark imported/w3c/web-platform-tests/cssom-view/elementFromPoint.html as failing;

it will be fixed via webkit.org/b/172019

  • platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
  • platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
4:29 PM Changeset in webkit [216802] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
https://bugs.webkit.org/show_bug.cgi?id=172000
rdar://problem/32144756

Patch by David Quesada <david_quesada@apple.com> on 2017-05-12
Reviewed by Simon Fraser.

Source/WebKit2:

Extract -[WKWebView _visibleContentRect]'s use of -_scroller to a new property
_enclosingViewForExposedRectComputation, which is declared in the private
header for subclasses to implement custom logic for determining the view to
clip rendering to.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _enclosingViewForExposedRectComputation]):
(-[WKWebView _visibleRectInEnclosingView:]):
(-[WKWebView _visibleContentRect]):
(-[WKWebView _visibleRectInEnclosingScrollView:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:

Added API tests to verify that WKWebView provides the expected value for
_visibleContentRect in various configurations. (i.e. not inside a scrollview,
inside a scrollview but not clipped, clipped by an ancestor scrollview,
clipped by the webview's _enclosingViewForExposedRectComputation)

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/VisibleContentRect.mm: Added.

(-[TestWKWebViewWithEnclosingView _enclosingViewForExposedRectComputation]):
(TestWebKitAPI::TEST):

4:12 PM Changeset in webkit [216801] by mark.lam@apple.com
  • 15 edits in trunk

WorkerRunLoop::Task::performTask() should check !scriptController->isTerminatingExecution().
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Saam Barati.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

  • runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/Options.h:
  • Added the unexpectedExceptionStackTraceLimit option.
  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before the run loop is terminated, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by changing WorkerRunLoop::Task::performTask() to check
!context->script()->isTerminatingExecution() instead of !runLoop.terminated().
Since WorkerThread::stop() always scheduleExecutionTermination() before it
terminates the run loop, !context->script()->isTerminatingExecution() implies
!runLoop.terminated().

The only time that runLoop is terminated without scheduleExecutionTermination()
being called is when WorkerThread::stop() is called before the WorkerThread has
finished creating its WorkerGlobalScope. In this scenario, WorkerThread::stop()
will still terminate the run loop. Hence, after the WorkerGlobalScope is created
(in WorkerThread::workerThread()), we will check if the run loop has been
terminated (i.e. stop() was called). If so, we'll scheduleExecutionTermination()
there, and guarantee that if runloop.terminated() is true, then
context->script()->isTerminatingExecution() is also true.

Solutions that were considered but did not work (recorded for future reference):

  1. In WorkerThread::stop(), call scheduleExecutionTermination() only after it posts the cleanup task and terminate the run loop.

This did not work because this creates a race where the worker thread may run
the cleanup task before WorkerThread::stop() finishes. As a result, the
scriptController may be deleted before we get to invoke scheduleExecutionTermination()
on it, thereby resulting in a use after free.

To make this work, we would have to change the life cycle management strategy
of the WorkerScriptController. This is a more risky change that we would
want to take on at this time, and may also not be worth the gain.

  1. Break scheduleExecutionTermination() up into 2 parts i.e. WorkerThread::stop() will:
    1. set the scriptControllers m_isTerminatingExecution flag before posting the cleanup task and terminating the run loop, and
    2. invoke VM::notifyNeedsTermination() after posting the cleanup task and terminating the run loop.

This requires that we protect the liveness of the VM until we can invoke
notifyNeedsTermination() on it.

This did not work because:

  1. We may end up destructing the VM in WorkerThread::stop() i.e. in the main web frame, but only the worker thread holds the JS lock for the VM.

We can make the WorkerThread::stop() acquire the JS lock just before it
releases the protected VM's RefPtr, but that would mean the main thread
may be stuck waiting a bit for the worker thread to release its JSLock.
This is not desirable.

  1. In practice, changing the liveness period of the Worker VM relative to its WorkerScriptController and WorkerGlobalScope also has unexpected ramifications. We observed many worker tests failing with assertion failures and crashes due to this change.

Hence, this approach is also a more risky change than it appears on the
surface, and is not worth exploring at this time.

In the end, changing WorkerRunLoop::Task::performTask() to check for
!scriptController->isTerminatingExecution() is the most straight forward solution
that is easy to prove correct.

Also fixed a race in WorkerThread::workerThread() where it can delete the
WorkerGlobalScope while WorkerThread::stop() is in the midst of accessing it.
We now guard the the nullifying of m_workerGlobalScope with the
m_threadCreationAndWorkerGlobalScopeMutex as well.

This issue is covered by an existing test that I just unskipped in TestExpectations.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::scheduleExecutionTermination):

  • Added a check to do nothing and return early if the scriptController is already terminating execution.
  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):
(WebCore::WorkerRunLoop::runCleanupTasks):
(WebCore::WorkerRunLoop::Task::performTask):

  • workers/WorkerRunLoop.h:
  • Made Task::performTask() private and make Task befriend the WorkerRunLoop class. This ensures that only the WorkerRunLoop may call performTask(). Note: this change only formalizes and hardens a relationship that was already in place before this.
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):
(WebCore::WorkerThread::workerThread):
(WebCore::WorkerThread::stop):

  • workers/WorkerThread.h:
  • Renamed m_threadCreationMutex to m_threadCreationAndWorkerGlobalScopeMutex so that it more accurately describes what it guards.

LayoutTests:

3:51 PM Changeset in webkit [216800] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030

Unreviewed - Test gardening, in effect...

More exploration as to why this continues to fail on the bots.

This change should give us a smoking gun.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(TEST):

3:47 PM Changeset in webkit [216799] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
following <http://trac.webkit.org/changeset/216789>
(https://bugs.webkit.org/show_bug.cgi?id=171712)

In r216798 I inadvertently added testRunner.setPopupBlockingEnabled(true) instead
instead of testRunner.setPopupBlockingEnabled(false) to disable the popup blocker.

  • plugins/navigator-plugin-crash.html:
3:43 PM Changeset in webkit [216798] by dbates@webkit.org
  • 2 edits in trunk/LayoutTests

Attempt to fix timeout failure of test plugins/navigator-plugin-crash.html in WebKit1
following <http://trac.webkit.org/changeset/216789>
(https://bugs.webkit.org/show_bug.cgi?id=171712)

On WebKit1 we need to explicitly allow the test tool to open windows by calling
testRunner.setCanOpenWindows(). We should also call testRunner.setCloseRemainingWindowsWhenComplete(true)
to have the test tool close any open windows after running the test.

It is also good practice to explicitly disable the popup blocker by calling
testRunner.setPopupBlockingEnabled(true);.

  • plugins/navigator-plugin-crash.html:
3:15 PM Changeset in webkit [216797] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.22

Tag Safari-604.1.22.

3:05 PM Changeset in webkit [216796] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Include algorithm before using std::min
https://bugs.webkit.org/show_bug.cgi?id=171733

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2017-05-12
Reviewed by Chris Dumez.

  • wtf/text/StringCommon.h:
3:02 PM Changeset in webkit [216795] by hyungwook.lee@navercorp.com
  • 2 edits in trunk/Tools

[GTK] Fix compile warnings in PlatformImageCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=171850

Reviewed by Michael Catanzaro.

  • ImageDiff/cairo/PlatformImageCairo.cpp:

(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

3:00 PM Changeset in webkit [216794] by Chris Dumez
  • 52 edits in trunk/Source/WebKit2

Stop using PassRefPtr under WebKit2/UIProcess
https://bugs.webkit.org/show_bug.cgi?id=172029

Reviewed by Alex Christensen.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously):

  • UIProcess/API/gtk/WebKitWebContext.cpp:
  • UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):

  • UIProcess/API/wpe/PageClientImpl.h:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::registerEditCommand):

  • UIProcess/DefaultUndoController.cpp:

(WebKit::DefaultUndoController::registerEditCommand):

  • UIProcess/DefaultUndoController.h:
  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::create):

  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/GeolocationPermissionRequestManagerProxy.cpp:

(WebKit::GeolocationPermissionRequestManagerProxy::createRequest):

  • UIProcess/GeolocationPermissionRequestManagerProxy.h:
  • UIProcess/InspectorServer/HTTPRequest.cpp:

(WebKit::HTTPRequest::parseHTTPRequestFromBuffer):

  • UIProcess/InspectorServer/HTTPRequest.h:
  • UIProcess/InspectorServer/WebInspectorServer.cpp:

(WebKit::WebInspectorServer::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebInspectorServer::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebInspectorServer::didEstablishWebSocketConnection):

  • UIProcess/InspectorServer/WebInspectorServer.h:
  • UIProcess/InspectorServer/WebSocketServerClient.h:

(WebKit::WebSocketServerClient::didReceiveUnrecognizedHTTPRequest):
(WebKit::WebSocketServerClient::didReceiveWebSocketUpgradeHTTPRequest):
(WebKit::WebSocketServerClient::didEstablishWebSocketConnection):

  • UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::readHTTPMessage):
(WebKit::WebSocketServerConnection::upgradeToWebSocketServerConnection):

  • UIProcess/InspectorServer/WebSocketServerConnection.h:
  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.cpp:

(WebKit::NotificationPermissionRequestManagerProxy::createRequest):

  • UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::notificationPermissions):

  • UIProcess/Notifications/WebNotificationProvider.h:
  • UIProcess/PageClient.h:
  • UIProcess/Storage/LocalStorageDatabase.cpp:
  • UIProcess/WebContextMenuListenerProxy.h:
  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebEditCommandProxy.h:
  • UIProcess/WebGrammarDetail.cpp:

(WebKit::WebGrammarDetail::create):

  • UIProcess/WebGrammarDetail.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::ExceededDatabaseQuotaRecords::createRecord):
(WebKit::WebPageProxy::registerEditCommand):
(WebKit::WebPageProxy::didReceiveAuthenticationChallengeProxy):
(WebKit::WebPageProxy::exceededDatabaseQuota):
(WebKit::WebPageProxy::reachedApplicationCacheOriginQuota):
(WebKit::WebPageProxy::takeViewSnapshot):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::plugInAutoStartOriginHashes):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(-[WKEditCommandObjC initWithWebEditCommandProxy:]):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::saveImageToLibrary):
(WebKit::PageClientImpl::setDragImage):
(WebKit::PageClientImpl::takeViewSnapshot):

  • UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::saveImageToLibrary):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::setDragImage):
(WebKit::PageClientImpl::setPromisedDataForImage):
(WebKit::PageClientImpl::takeViewSnapshot):

  • UIProcess/mac/WKImmediateActionController.mm:

(-[WKImmediateActionController _webHitTestResult]):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::setPromisedDataForImage):

  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
2:56 PM Changeset in webkit [216793] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.21.2

Tag Safari-604.1.21.2.

1:54 PM Changeset in webkit [216792] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[iOS WK1] Do not try to layout a subframe if its document has not been constructed yet.
https://bugs.webkit.org/show_bug.cgi?id=172042
<rdar://problem/32084098>

Reviewed by Antti Koivisto.

On iOS WK1 we can end up in an inconsistent state, where

  1. the web thread is inside a newly injected iframe's document's c'tor and
  2. waiting on a delegate callback on the main thread

while the main thread

  1. executes a pending didLayout() task
  2. triggers layout on the newly injected iframe.
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::updateWidgetPosition):

1:49 PM Changeset in webkit [216791] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Add UIClient callback for when picture-in-picture is activated.
https://bugs.webkit.org/show_bug.cgi?id=172023

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-12
Reviewed by Simon Fraser.

Source/WebKit2:

Add WKUIPageClientV10 with setHasVideoInPictureInPicture.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::setHasVideoInPictureInPicture):

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
(WebKit::WebVideoFullscreenManagerProxy::fullscreenModeChanged):

Tools:

Added a test for WKPageUIClientV10 setHasVideoInPictureInPicture.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/PictureInPictureDelegate.mm: Added.

(onLoadedCompletedCallback):
(waitUntilOnLoadIsCompleted):
(didFinishLoadForFrame):
(setHasVideoInPictureInPicture):
(TestWebKitAPI::TEST):

1:43 PM Changeset in webkit [216790] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r213564): Flash audio playback failures
https://bugs.webkit.org/show_bug.cgi?id=171876
<rdar://problem/32082745>

Reviewed by Alexey Proskuryakov.

The IOKit property filters added in r213564 need to be expanded to support
some Flash features.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
1:37 PM Changeset in webkit [216789] by jiewen_tan@apple.com
  • 3 edits
    2 adds in trunk

Check existence of a page before accessing its plugins
https://bugs.webkit.org/show_bug.cgi?id=171712
<rdar://problem/32007806>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: plugins/navigator-plugin-crash.html

  • plugins/DOMPlugin.cpp:

(WebCore::DOMPlugin::item):
(WebCore::DOMPlugin::namedItem):

LayoutTests:

  • plugins/navigator-plugin-crash-expected.txt: Added.
  • plugins/navigator-plugin-crash.html: Added.
1:37 PM Changeset in webkit [216788] by Jonathan Bedard
  • 4 edits in trunk/Tools

Unreviewed follow-up to r216776.

  • Scripts/webkitpy/port/base.py:

(Port.path_to_crash_logs): Raise not implemented.

  • Scripts/webkitpy/port/test.py:

(TestPort.path_to_crash_logs): Return results directory as the location of crash logs.

  • Scripts/webkitpy/port/win.py:

(WinPort.path_to_crash_logs): Ditto.

1:32 PM Changeset in webkit [216787] by jmarcell@apple.com
  • 7 edits
    2 adds in branches/safari-604.1.21-branch/Source/JavaScriptCore

Cherry-pick r216460. rdar://problem/32027549

1:32 PM Changeset in webkit [216786] by ap@apple.com
  • 2 edits in trunk/Tools

Bot watcher's dashboard shows results links twice sometimes
https://bugs.webkit.org/show_bug.cgi?id=172043

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):

1:32 PM Changeset in webkit [216785] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WTF

Cherry-pick r216772. rdar://problem/31969082

1:32 PM Changeset in webkit [216784] by jmarcell@apple.com
  • 5 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216766. rdar://problem/32151246

1:32 PM Changeset in webkit [216783] by jmarcell@apple.com
  • 13 edits in branches/safari-604.1.21-branch

Cherry-pick r216349. rdar://problem/32117885

1:32 PM Changeset in webkit [216782] by jmarcell@apple.com
  • 23 edits
    3 adds in branches/safari-604.1.21-branch

Cherry-pick r216712. rdar://problem/32117885

1:32 PM Changeset in webkit [216781] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216710. rdar://problem/32146527

1:31 PM Changeset in webkit [216780] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216215. rdar://problem/31999512

1:27 PM Changeset in webkit [216779] by Brent Fulgham
  • 5 edits in trunk/Source/WebKit2

[WK2][macOS] Add a mach-lookup exception for 'com.apple.analyticsd'
https://bugs.webkit.org/show_bug.cgi?id=172040
<rdar://problem/31765514>

Reviewed by Alexey Proskuryakov.

  • DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
1:09 PM Changeset in webkit [216778] by Simon Fraser
  • 6 edits in trunk/Source

Add some logging for layer tree commits, and resize and orientation change events
https://bugs.webkit.org/show_bug.cgi?id=172041

Reviewed by Tim Horton.

Add some logging that's useful during rotation investigations.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::orientationChanged):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):

  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _didCommitLayerTree:]):

1:09 PM Changeset in webkit [216777] by beidson@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r216711): API test WKWebView.ClearAppCache is failing.
https://bugs.webkit.org/show_bug.cgi?id=172030

Unreviewed - Test gardening, in effect...

This failure is only being seen by the bots.

I believe this test is utterly broken in the first place; when it checks the .wal file's
size that is not actually an indicator that the records were deleted.

But that isn't what's coming up as failure on the bots.

This patch is an attempt to:
1 - More forcefully clear the Website data directory of leftovers before the test starts.
2 - Give an earlier indication of the failure that the bots are seeing, to possibly reveal more.

  • TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:

(defaultWebsiteDataDirectory):
(defaultApplicationCacheDirectory):
(TEST):

12:52 PM Changeset in webkit [216776] by Jonathan Bedard
  • 15 edits in trunk/Tools

webkitpy: Pass directory with crash logs into CrashLogs
https://bugs.webkit.org/show_bug.cgi?id=172033
<rdar://problem/32157616>

Reviewed by Daniel Bates.

Refactor CrashLogs and the callers of CrashLogs so that the port object owns
the location of crash logs.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.init): Pass mandatory crash_log_directory when constructing.
(CrashLogs._find_newest_log_darwin): Use self._crash_log_directory instead of
generating one.
(CrashLogs._find_newest_log_win): Use self._crash_log_directory instead of
self._results_directory.
(CrashLogs._find_all_logs_darwin): Use self._crash_log_directory instead of
generating one.
(CrashLogs._log_directory_darwin): Moved to port.

  • Scripts/webkitpy/common/system/crashlogs_unittest.py: Update tests since the path

to the crash log is no longer owned by CrashLogs.

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Use the general

directory for uploading crash logs. Note that crash logs are only supported on Mac
and Windows.

  • Scripts/webkitpy/port/apple.py: Remove unneeded CrashLogs import.
  • Scripts/webkitpy/port/base.py:

(Port.path_to_crash_logs): Unless ports declare otherwise, crash logs are assumed
to be in the results directory.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort.path_to_crash_logs): Moved from CrashLogs._log_directory_darwin.
(DarwinPort._look_for_all_crash_logs_in_log_dir): Use port specific crash log path.
(DarwinPort._get_crash_log): Ditto.

  • Scripts/webkitpy/port/darwin_testcase.py:

(DarwinTest.test_crashlog_path): Test that the Darwin ports are correctly calculating
the path to crash logs.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.path_to_crash_logs): Currently, crash log retrieval is undefined for iOS.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.test_crashlog_path): Currently, crash log retrieval is undefined for iOS.

  • Scripts/webkitpy/port/ios_simulator.py: Remove unneeded CrashLogs import.
  • Scripts/webkitpy/port/mac.py: Ditto.
  • Scripts/webkitpy/port/test.py:

(TestDriver.run_test): Use port specific crash log path when retrieving crash logs.

  • Scripts/webkitpy/port/win.py:

(WinPort._get_crash_log): Ditto.

  • Scripts/webkitpy/tool/commands/queries.py:

(execute): Construct a port object since this is the object which owns the path to crash logs.

12:18 PM Changeset in webkit [216775] by commit-queue@webkit.org
  • 8 edits in trunk

[Readable Streams API] Add ReadableStreamBYOBReader closed getter
https://bugs.webkit.org/show_bug.cgi?id=172024

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-05-12
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated.
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated.

Source/WebCore:

Added tests to check closed getter behaviour.

  • Modules/streams/ReadableStreamBYOBReader.js:

(closed): Implemented.

LayoutTests:

Added tests to check closed getter behaviour.

  • streams/readable-stream-byob-reader-expected.txt: Updated.
  • streams/readable-stream-byob-reader.js: Updated.
12:14 PM Changeset in webkit [216774] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Stop setting a status on PKPaymentRequestShippingContactUpdate when there are errors
https://bugs.webkit.org/show_bug.cgi?id=172036
<rdar://problem/31587957>

Reviewed by Anders Carlsson.

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::WebPaymentCoordinatorProxy::platformCompleteShippingContactSelection):

12:10 PM Changeset in webkit [216773] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216432. rdar://problem/32051782

11:48 AM Changeset in webkit [216772] by akling@apple.com
  • 2 edits in trunk/Source/WTF

More aggressive memory kill limits.
https://bugs.webkit.org/show_bug.cgi?id=172037
<rdar://problem/31969082>

Reviewed by Michael Saboff.

Bring down the memory kill limits to 4GB for active processes, and 2GB for inactive.
Also make MemoryUsagePolicy::Strict kick in above 1.5GB.

  • wtf/MemoryPressureHandler.cpp:

(WTF::MemoryPressureHandler::thresholdForMemoryKill):
(WTF::thresholdForPolicy):

11:34 AM Changeset in webkit [216771] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

MediaResourceLoader shouldn't keep its HTMLMediaElement alive.
https://bugs.webkit.org/show_bug.cgi?id=172032
<rdar://problem/30816144>

Reviewed by Joseph Pecoraro.

Use a WeakPtr<HTMLMediaElement> in MediaResourceLoader instead, since the loader
is retained by a NSURLSession object we hand over to AVFoundation.

This prevents AVFoundation from keeping entire documents alive outside our control.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::createWeakPtr):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::MediaResourceLoader):
(WebCore::MediaResourceLoader::requestResource):

  • loader/MediaResourceLoader.h:
11:21 AM Changeset in webkit [216770] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Memory pressure response should only do sync bmalloc scavenge in sync mode.
https://bugs.webkit.org/show_bug.cgi?id=172035

Reviewed by Michael Saboff.

Only call WTF::releaseFastMallocFreeMemory() and his threading-related friends
when releaseMemory() is invoked with Synchronous::Yes, or if it's a critical
pressure response (maintaining the behavior added in r215775.)

  • page/MemoryRelease.cpp:

(WebCore::releaseMemory):

10:54 AM Changeset in webkit [216769] by dbates@webkit.org
  • 9 edits in trunk/Source/WebCore

Cleanup: Use Ref instead of RefPtr to hold DOMWrapperWorld
https://bugs.webkit.org/show_bug.cgi?id=171988

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::JSCustomElementInterface):
(WebCore::JSCustomElementInterface::upgradeElement):
(WebCore::JSCustomElementInterface::invokeCallback):

  • bindings/js/JSCustomElementInterface.h:
  • bindings/js/JSMutationCallback.cpp:

(WebCore::JSMutationCallback::JSMutationCallback):
(WebCore::JSMutationCallback::call):

  • bindings/js/JSMutationCallback.h:
  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::execute):

  • bindings/js/ScheduledAction.h:

(WebCore::ScheduledAction::ScheduledAction):

  • page/DOMWindowExtension.cpp:

(WebCore::DOMWindowExtension::DOMWindowExtension):

  • page/DOMWindowExtension.h:

(WebCore::DOMWindowExtension::world):

10:53 AM Changeset in webkit [216768] by dbates@webkit.org
  • 12 edits in trunk/Source

Cleanup: Make QueueTaskToEventLoopFunctionPtr take JSGlobalObject&
https://bugs.webkit.org/show_bug.cgi?id=172021

Reviewed by Mark Lam.

Source/JavaScriptCore:

Change the function alias for QueueTaskToEventLoopFunctionPtr to take JSGlobalObject&
instead of a const JSGlobalObject* as all implementations expect to be passed a non-
const, non-null JSGlobalObject object.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::queueMicrotask):

  • runtime/JSGlobalObject.h:
  • runtime/VM.cpp:

(JSC::VM::queueMicrotask):

  • runtime/VM.h: Remove JS_EXPORT_PRIVATE annotation from queueMicrotask() as

it is only called from JavaScriptCore code.

Source/WebCore:

  • bindings/js/JSDOMGlobalObjectTask.cpp: Include header JSDOMGlobalObject.h.

(WebCore::JSGlobalObjectTask::JSGlobalObjectTask): Change type of first argument from JSDOMGlobalObject*
to JSDOMGlobalObject& and update code as necessary. Also, use C++11 brace initialization syntax
for member initializer list.

  • bindings/js/JSDOMGlobalObjectTask.h: Remove header JSDOMGlobalObject.h and forward declare

JSDOMGlobalObject and JSC::Microtask.

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowMicrotaskCallback::create):
(WebCore::JSDOMWindowMicrotaskCallback::JSDOMWindowMicrotaskCallback): Change type of first argument
from JSDOMWindowBase* to JSDOMWindowBase& and update code as necessary. Also, use C++11 brace
initialization syntax for member initializer list.
(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

  • bindings/js/JSWorkerGlobalScopeBase.h:
10:14 AM Changeset in webkit [216767] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked webrtc/closing-peerconnection.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172034

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:05 AM Changeset in webkit [216766] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[MediaStream] Streams while play while page is in background can get "stuck" when page is forgrounded.
https://bugs.webkit.org/show_bug.cgi?id=172022

Reviewed by Youenn Fablet.

When an AVSampleBufferDisplayLayer is disconnected from the CA renderer, none of its samples will be decoded
and enqueued for rendering. Once the layer is attached to a renderer again, it's stuffed full of samples which
will never be decoded as their decode time has long passed.

Pass the visibility state of the element through to the MediaPlayer so that MediaPlayerPrivateMediaStreamAVFObjC
can flush its renderers when going from not visible -> visible.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::visibilityStateChanged):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::updatePlayer):

8:37 AM Changeset in webkit [216765] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:
7:33 AM Changeset in webkit [216764] by Chris Dumez
  • 34 edits in trunk/Source/WebKit2

Stop using PassRefPtr under WebKit2/Shared
https://bugs.webkit.org/show_bug.cgi?id=172017

Reviewed by Antti Koivisto.

  • Shared/API/APIDictionary.cpp:

(API::Dictionary::add):
(API::Dictionary::set):

  • Shared/API/APIDictionary.h:
  • Shared/API/APISecurityOrigin.h:

(API::SecurityOrigin::createFromString):
(API::SecurityOrigin::create):
(API::SecurityOrigin::securityOrigin):
(API::SecurityOrigin::SecurityOrigin):

  • Shared/API/APISerializedScriptValue.h:

(API::SerializedScriptValue::create):
(API::SerializedScriptValue::SerializedScriptValue):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::ProxyingRefPtr::ProxyingRefPtr):

  • Shared/APIWebArchiveResource.h:
  • Shared/APIWebArchiveResource.mm:

(API::WebArchiveResource::create):
(API::WebArchiveResource::WebArchiveResource):

  • Shared/AsyncRequest.h:

(WebKit::AsyncRequestMap::add):

  • Shared/BlobDataFileReferenceWithSandboxExtension.cpp:

(WebKit::BlobDataFileReferenceWithSandboxExtension::BlobDataFileReferenceWithSandboxExtension):

  • Shared/BlobDataFileReferenceWithSandboxExtension.h:
  • Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStoreTile::setBackBuffer):
(WebKit::CoordinatedBackingStore::updateTile):

  • Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createUpdateAtlas):
(WebKit::CoordinatedGraphicsScene::updateImageBacking):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
  • Shared/Plugins/Netscape/NetscapePluginModule.cpp:

(WebKit::NetscapePluginModule::getOrCreate):

  • Shared/Plugins/Netscape/NetscapePluginModule.h:
  • Shared/VisitedLinkTable.cpp:

(WebKit::VisitedLinkTable::setSharedMemory):

  • Shared/VisitedLinkTable.h:
  • Shared/WebBackForwardListItem.h:

(WebKit::WebBackForwardListItem::setSnapshot):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::create):

  • Shared/WebContextMenuItem.h:
  • Shared/WebGeolocationPosition.h:
  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::createArrayFromLayerList):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Shared/WebRenderLayer.h:
  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):

  • Shared/WebRenderObject.h:
  • UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::resizeTable):

  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::setVisitedLinkTable):

7:15 AM Changeset in webkit [216763] by msaboff@apple.com
  • 15 edits
    2 adds in trunk/Source

[iOS] Use memory footprint to dynamically adjust behavior of allocators
https://bugs.webkit.org/show_bug.cgi?id=171944

Reviewed by Filip Pizlo.

Source/bmalloc:

This change is iOS only.

After the scavenger thread completes scavenging, it asks the OS for how much total memory the
process is using. This information is used to update the sleep delay for the scanvenger thread,
as well as to provide memory in use data for other parts of the system.

The scavenger sleep time is calculated using the following quadradic equation.

scavengerSleep = 1.2*percentFreeMemory2 - percentFreeMemory + 2

Where percentFreeMemory is between 0 and 100. The result is constrained to the values 2 and 250.

This equation empirically works out to providing a 2ms sleep time when we have less than 10%
memory available, 30ms when 20% is available and 250ms when 50% or more is available. In testing,
this exponentially agressive scavenging delay by itself reduced memory usage and made it much
more deterministic when used without the corresponding change in the JSC Heap.

Changed the scavenger thread to use the User Initiated QOS priority to ensure it doesn't
get starved.

Moved the non-Windows functionality of WTF::RAMSize() to new files AvailableMemory.{cpp,h}
and implemented in the function availableMemory(). That functions limits the value returned
on iOS to a maximum of 840MB as that is the jetsam soft memory limit.
Added a new API availableMemory() so that WTF::RAMSize() will use this value.

  • CMakeLists.txt:
  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/BPlatform.h:
  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::updateMemoryInUseParameters):
(bmalloc::Heap::concurrentScavenge):
(bmalloc::Heap::scavenge):

  • bmalloc/Heap.h:

(bmalloc::Heap::memoryFootprint):
(bmalloc::Heap::percentAvailableMemoryInUse):

  • bmalloc/Sizes.h:
  • bmalloc/bmalloc.h:

(bmalloc::api::availableMemory):
(bmalloc::api::memoryFootprint):
(bmalloc::api::percentAvailableMemoryInUse):

  • bmalloc/AvailableMemory.cpp: Added.

(bmalloc::computeAvailableMemory):
(bmalloc::availableMemory):

  • bmalloc/AvailableMemory.h: Added.

Source/JavaScriptCore:

This change is iOS only.

Added the ability to react to when memory usage is critical. This is defined as memory
usage being above the newly added option criticalGCMemoryThreshold. When we are in this
critical state, all collections are Full and we limit the amount of memory we allocate
between collections to 1/4th the memory above the critical threshold.

Changed the calculation of proportionalHeapSize to be based on process memory footprint
and not how big the heap is. Also, the values of Options::smallHeapRAMFraction and
Options::mediumHeapRAMFraction are overriden so that most of the heap growth is happens
using the more agressive Options::smallHeapGrowthFactor.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::overCriticalMemoryThreshold):
(JSC::Heap::shouldDoFullCollection):
(JSC::Heap::collectIfNecessaryOrDefer):

  • heap/Heap.h:
  • runtime/Options.cpp:

(JSC::overrideDefaults):
(JSC::Options::initialize):

  • runtime/Options.h:

Source/WTF:

Moved the non-Windows implementation of RAMSize() to bmalloc/AvailableMemory.cpp and
called the function availableMemory().

  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

5:58 AM Changeset in webkit [216762] by Claudio Saavedra
  • 12 edits in trunk/LayoutTests

[GTK] After upgrading glib and glib-networking, resources with zero bytes are always identified as text/plain
https://bugs.webkit.org/show_bug.cgi?id=171058

Reviewed by Carlos Garcia Campos.

GLib-based ports have issues detecting the mimetypes of empty
files, as they are all considered to be text/plain by
glib. Replace these resources with a minimal valid file for its
type (that is, 1x1 PNG files and 1 whitespace for text files).

  • fast/preloader/resources/base-image1.png:
  • fast/preloader/resources/base-image2.png:
  • fast/preloader/resources/base-image3.png:
  • fast/preloader/resources/image1.png:
  • fast/preloader/resources/link1.css:
  • fast/preloader/resources/noscript-image1.png:
  • fast/preloader/resources/noscript-image2.png:
  • fast/preloader/resources/script1.js:
  • fast/preloader/resources/style1.css:
  • tables/mozilla/core/col_widths_fix_autoFixPer.html:
  • platform/gtk/TestExpectations: Unskip the now passing tests.
5:31 AM Changeset in webkit [216761] by Antti Koivisto
  • 7 edits
    2 adds in trunk

Updating class name of a shadow host does not update the style applied by descendants of :host()
https://bugs.webkit.org/show_bug.cgi?id=170762
<rdar://problem/31572668>

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to invalidate shadow tree style when host classes or attributes change if it may be
affected by host rules.

Test: fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html

  • css/RuleSet.cpp:

(WebCore::isHostSelectorMatchingInShadowTree):
(WebCore::RuleSet::addRule):

Check if we have :host selectors that affect shadow tree.

  • css/RuleSet.h:

(WebCore::RuleSet::hasHostPseudoClassRulesMatchingInShadowTree):

  • style/AttributeChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::AttributeChangeInvalidation::invalidateStyle):

Invalidate the whole subtree if there is a class change that may affect shadow tree style.

  • style/ClassChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):

  • style/IdChangeInvalidation.cpp:

(WebCore::Style::mayBeAffectedByHostRules):
(WebCore::Style::IdChangeInvalidation::invalidateStyle):

Same for classes and ids.
This should be refactored at some point to reduce copy-code.

LayoutTests:

  • fast/shadow-dom/css-scoping-host-class-and-attribute-mutation-expected.html: Added.
  • fast/shadow-dom/css-scoping-host-class-and-attribute-mutation.html: Added.
4:53 AM Changeset in webkit [216760] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[WPE] Unreviewed gardening.

ClientRect, ClientRectList were removed, PromiseRejectionEvent was
added, update global constructors attributes test expectations.

  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
4:42 AM Changeset in webkit [216759] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] ASSERTION FAILED: !m_flushingLayers
https://bugs.webkit.org/show_bug.cgi?id=172025

Reviewed by Žan Doberšek.

Source/WebCore:

The problem is that syncImageBacking() is calling didChangeLayerState(). All sync methods are called by
flushCompositingStateForThisLayerOnly() while flushing layers, so none of them should call didChange method that
will schedule a new flush while flushing.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncImageBacking):

LayoutTests:

  • platform/gtk/TestExpectations:
3:29 AM Changeset in webkit [216758] by Carlos Garcia Campos
  • 3 edits
    2 adds in trunk

[GTK] GIF images are not properly loaded the first time
https://bugs.webkit.org/show_bug.cgi?id=170432

Reviewed by Carlos Alberto Lopez Perez.

Source/WebCore:

When the GIF image is loaded for the first time, it's always read from the network, and the decoder is usually
fetched with chunks of data. Then the data is cached in disk by the network process, so that when loaded from
the cache, the whole encoded data is available to fetch the encoder. The problem is that we are failing to
decode the image when giving chunks of data, that's why it only happens the first time loaded. If the first
chunk of data provided is enough to get some metadata, including the size, but not frame contents, the load fails
in CachedImage::addIncrementalDataBuffer() because the EncodedDataStatus reported is SizeAvailable but
Image::isNull() returns true. An Image is considered to be Null when its size is empty, and the size is
calculated always using the first frame in ImageFrameCache. Since we still don't have frames, the image is
always Null in this case. It is not expected that EncodedDataStatus returns SizeAvailable and the image is Null,
that's why it's considered an error and the load finishes with a decode error. However, the non CG ImageDecoder
has a m_size member to handle this particular case, and it's when m_size is set when EncodedDataStatus changes
to SizeAvailable. We should return the ImageEncoder size as the ImageSize when we have a decoder but
not frames yet.

Test: http/tests/images/gif-progressive-load.html

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::size): Return ImageDecoder::size() without caching it, if frame list is empty.

LayoutTests:

  • http/tests/images/gif-progressive-load-expected.html: Added.
  • http/tests/images/gif-progressive-load.html: Added.
3:08 AM Changeset in webkit [216757] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

The iBooks application is not able to get current position.
https://bugs.webkit.org/show_bug.cgi?id=171982
rdar://problem/29318409

Reviewed by Brent Fulgham.

Geolocation requests from iBooks are currently blocked. Make an exemption from the policy for iBooks.

No new tests since we currently can't mock the iBooks application bundle ID.

  • Modules/geolocation/Geolocation.cpp:

(WebCore::isRequestFromIBooks):
(WebCore::Geolocation::shouldBlockGeolocationRequests):

2:43 AM Changeset in webkit [216756] by Manuel Rego Casasnovas
  • 6 edits in trunk/LayoutTests

[selectors4] css/selectors4/focus-within-006.html test from WPT is failing
https://bugs.webkit.org/show_bug.cgi?id=170900

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

The issue has been fixed in WPT repo:
https://github.com/w3c/web-platform-tests/pull/5786

This patch is importing the changes so we can close this bug on WebKit.

  • web-platform-tests/css/selectors4/focus-within-006-expected.html:
  • web-platform-tests/css/selectors4/focus-within-006.html:
  • web-platform-tests/css/selectors4/w3c-import.log:

LayoutTests:

2:01 AM Changeset in webkit [216755] by Claudio Saavedra
  • 2 edits in trunk/Source/WTF

[WPE] Add MemoryFootprintLinux to build

Unreviewed build fix after r216731.

  • wtf/PlatformWPE.cmake:
2:00 AM Changeset in webkit [216754] by commit-queue@webkit.org
  • 1 edit
    39 adds in trunk/PerformanceTests

Speedometer: Add a React.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171444

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-12
Reviewed by Ryosuke Niwa.

Adds a more recent React.js TodoMVC implemenation to Speedometer

  • Speedometer/resources/todomvc/architecture-examples/react/build.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/js/app.jsx: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/license.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/bind.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/dedupe.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/classnames/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/director/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/dist/react-dom-server.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/dist/react-dom.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react-dom/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/LICENSE: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/dist/react-with-addons.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/dist/react.min.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/react/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/npm-shrinkwrap.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react/yarn.lock: Added.
1:08 AM Changeset in webkit [216753] by pvollan@apple.com
  • 3 edits
    2 adds in trunk

Geolocation requests should not be blocked when the security origin is local.
https://bugs.webkit.org/show_bug.cgi?id=171857
Source/WebCore:

rdar://problem/29318409

Reviewed by Brent Fulgham.

Geolocation requests from security origins where the url scheme is registered as local,
should not be blocked. This applies to the file url scheme, but also to other local url
schemes.

Test: fast/misc/geolocation-local-security-origin.html

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::shouldBlockGeolocationRequests):

LayoutTests:

Reviewed by Brent Fulgham.

  • fast/misc/geolocation-local-security-origin-expected.txt: Added.
  • fast/misc/geolocation-local-security-origin.html: Added.
12:52 AM Changeset in webkit [216752] by jmarcell@apple.com
  • 5 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216691. rdar://problem/32136567

12:52 AM Changeset in webkit [216751] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216650. rdar://problem/32111991

12:52 AM Changeset in webkit [216750] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216645. rdar://problem/31995807

12:52 AM Changeset in webkit [216749] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216623. rdar://problem/32116336

12:52 AM Changeset in webkit [216748] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216616. rdar://problem/32116375

12:52 AM Changeset in webkit [216747] by jmarcell@apple.com
  • 16 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216612. rdar://problem/32080713

12:52 AM Changeset in webkit [216746] by jmarcell@apple.com
  • 8 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216599. rdar://problem/31201793

12:52 AM Changeset in webkit [216745] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216559. rdar://problem/31771707

12:52 AM Changeset in webkit [216744] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.21-branch/Source/WebKit/win

Cherry-pick r216554. rdar://problem/27362159

12:52 AM Changeset in webkit [216743] by jmarcell@apple.com
  • 29 edits
    5 adds in branches/safari-604.1.21-branch

Cherry-pick r216541. rdar://problem/27362159

12:52 AM Changeset in webkit [216742] by jmarcell@apple.com
  • 13 edits
    3 adds in branches/safari-604.1.21-branch

Cherry-pick r216279. rdar://problem/31735695

12:52 AM Changeset in webkit [216741] by jmarcell@apple.com
  • 16 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216216. rdar://problem/31814074

12:52 AM Changeset in webkit [216740] by jmarcell@apple.com
  • 26 edits
    1 add in branches/safari-604.1.21-branch

Cherry-pick r216212. rdar://problem/31544320

12:51 AM Changeset in webkit [216739] by jmarcell@apple.com
  • 33 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216197. rdar://problem/31821492

12:50 AM Changeset in webkit [216738] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/create-navigation-data after r216615.

In r216615 the custom code for window.open() was removed. The generated code now correctly handles the optional
URL parameter using the default value "about:blank" when not provided.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewCreateNavigationData):

12:48 AM Changeset in webkit [216737] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WTF

Unreviewed trivial JSCOnly buildfix after r216731.
https://bugs.webkit.org/show_bug.cgi?id=171693

  • wtf/PlatformJSCOnly.cmake:

May 11, 2017:

11:58 PM Changeset in webkit [216736] by Manuel Rego Casasnovas
  • 12 edits
    6 adds in trunk/LayoutTests

[selectors4] :focus-within tests using shadow DOM don't pass on WK1
https://bugs.webkit.org/show_bug.cgi?id=170935

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

The issue has been fixed modifying the tests upstream:
https://github.com/w3c/web-platform-tests/pull/5594

This patch updates "selectors4" Test Suite with the last changes
from WPT repository.
This means that this issue is fixed and at the same time some new tests
are being imported.
Two of the new imported tests are failing due to bug #47182,
anyway the -expected.txt files with FAIL messages are added.

  • resources/import-expectations.json:
  • web-platform-tests/css/selectors4/focus-display-none-001-expected.txt: Added.
  • web-platform-tests/css/selectors4/focus-display-none-001.html: Added.
  • web-platform-tests/css/selectors4/focus-within-009-expected.txt:
  • web-platform-tests/css/selectors4/focus-within-009.html:
  • web-platform-tests/css/selectors4/focus-within-010-expected.html: Added.
  • web-platform-tests/css/selectors4/focus-within-010.html: Added.
  • web-platform-tests/css/selectors4/focus-within-display-none-001-expected.txt: Added.
  • web-platform-tests/css/selectors4/focus-within-display-none-001.html: Added.
  • web-platform-tests/css/selectors4/focus-within-shadow-001.html:
  • web-platform-tests/css/selectors4/focus-within-shadow-002.html:
  • web-platform-tests/css/selectors4/focus-within-shadow-003.html:
  • web-platform-tests/css/selectors4/focus-within-shadow-004.html:
  • web-platform-tests/css/selectors4/focus-within-shadow-005.html:
  • web-platform-tests/css/selectors4/w3c-import.log:

LayoutTests:

  • platform/mac-wk1/TestExpectations: Remove tests as they're passing now.
11:32 PM Changeset in webkit [216735] by commit-queue@webkit.org
  • 2 edits
    1 copy
    68 adds
    5 deletes in trunk/PerformanceTests

Speedometer: Update the Ember.js TodoMVC to a more recent version
https://bugs.webkit.org/show_bug.cgi?id=171342

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Update the Ember TodoMVC app in Speedometer to latest

  • Speedometer/resources/todomvc/architecture-examples/emberjs/assets/todomvc.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/assets/todomvc.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/assets/vendor.css: Renamed from PerformanceTests/Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/assets/vendor.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower.json: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-data/ember-data.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/crossdomain.xml: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/index.html:
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/app.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/helpers/pluralize.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/models/todo.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/router.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/js/views/todos_view.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/readme.md: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/robots.txt: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.bowerrc: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.editorconfig: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.ember-cli: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.gitignore: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.jshintrc: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.travis.yml: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/.watchmanconfig: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/todo-item.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/todo-list.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/controllers/active.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/controllers/application.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/controllers/completed.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/helpers/gt.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/helpers/pluralize.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers/global.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/models/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/resolver.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/router.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/routes/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/routes/application.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/memory.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/styles/app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/active.hbs: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/application.hbs: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/completed.hbs: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/todo-item.hbs: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/todo-list.hbs: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/index.hbs: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/bower.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/config/environment.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/ember-cli-build.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/public/crossdomain.xml: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/public/robots.txt: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/testem.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/.jshintrc: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/destroy-app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/module-for-acceptance.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/resolver.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/start-app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/integration/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/test-helper.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/unit/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/test.html: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/testem.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/tests/index.html: Added.
11:05 PM Changeset in webkit [216734] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Computing optionalDefArgWidth in CheckSpecial should not consider Scratch roles
https://bugs.webkit.org/show_bug.cgi?id=171962

Reviewed by Filip Pizlo.

The purpose of getting the result width is to get the width of
the result of the arithmetic. It does not care about that the
Check happens to define scratches.

  • b3/B3CheckSpecial.cpp:

(JSC::B3::CheckSpecial::forEachArg):

  • b3/testb3.cpp:

(JSC::B3::testCheckMul):
(JSC::B3::testCheckMulMemory):
(JSC::B3::testCheckMul64):
(JSC::B3::testCheckMulFold):
(JSC::B3::testCheckMulFoldFail):
(JSC::B3::testCheckMulArgumentAliasing64):
(JSC::B3::testCheckMulArgumentAliasing32):
(JSC::B3::testCheckMul64SShr):

11:04 PM Changeset in webkit [216733] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

isValidForm for SimpleAddr should use ptr() instead of tmp()
https://bugs.webkit.org/show_bug.cgi?id=171992

Reviewed by Filip Pizlo.

Arg::tmp() asserts that its kind is Tmp. Inst::isValidForm for
SimpleAddr was using Arg::tmp() instead of ptr() to check
if the address Tmp isGP(). It should be using Arg::ptr() instead
of Arg::tmp() since Arg::ptr() is designed for SimpleAddr.

This patch also fixes an incorrect assertion in the ARM64
macro assembler. We were asserting various atomic ops were
only over 32/64 bit operations. However, the code was properly handling
8/16/32/64 bit ops. I changed the assertion to reflect what is
actually going on.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::ldar):
(JSC::ARM64Assembler::ldxr):
(JSC::ARM64Assembler::ldaxr):
(JSC::ARM64Assembler::stxr):
(JSC::ARM64Assembler::stlr):
(JSC::ARM64Assembler::stlxr):

  • b3/air/opcode_generator.rb:
  • b3/testb3.cpp:

(JSC::B3::testLoadAcq42):
(JSC::B3::testStoreRelAddLoadAcq32):
(JSC::B3::testStoreRelAddLoadAcq8):
(JSC::B3::testStoreRelAddFenceLoadAcq8):
(JSC::B3::testStoreRelAddLoadAcq16):
(JSC::B3::testStoreRelAddLoadAcq64):
(JSC::B3::testAtomicWeakCAS):
(JSC::B3::testAtomicStrongCAS):
(JSC::B3::testAtomicXchg):

10:50 PM Changeset in webkit [216732] by commit-queue@webkit.org
  • 1 edit
    38 adds in trunk/PerformanceTests

Speedometer: Add a React + Redux TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171329

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adds React and Redux TodoMVC implementation for Speedometer

  • Speedometer/resources/todomvc/architecture-examples/react-redux/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/css/main.d43d2909.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.946269ff.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/public/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/actions/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/actions/index.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Footer.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Footer.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Header.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/Header.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/MainSection.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/MainSection.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoItem.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoItem.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoTextInput.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/components/TodoTextInput.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/constants/ActionTypes.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/constants/TodoFilters.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/containers/App.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.spec.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/yarn.lock: Added.
10:21 PM Changeset in webkit [216731] by Yusuke Suzuki
  • 8 edits
    1 copy
    1 move
    1 add in trunk/Source/WTF

[Win] Implement memoryFootprint for Windows
https://bugs.webkit.org/show_bug.cgi?id=171693

Reviewed by Alex Christensen.

This patch implements memoryFootprint for Windows. In Windows, we calculate the size
of private working set. This can be done by enumerating private pages in working set.

And we also split MemoryFootprint.cpp to cocoa, linux, and win versions.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/MallocPtr.h:

(WTF::MallocPtr::operator*):
(WTF::MallocPtr::operator->):

  • wtf/PlatformGTK.cmake:
  • wtf/PlatformJSCOnly.cmake:
  • wtf/PlatformMac.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/cocoa/MemoryFootprintCocoa.cpp: Copied from Source/WTF/wtf/MemoryFootprint.cpp.

(WTF::memoryFootprint):

  • wtf/linux/MemoryFootprintLinux.cpp: Renamed from Source/WTF/wtf/MemoryFootprint.cpp.

(WTF::forEachLine):
(WTF::memoryFootprint):

  • wtf/win/MemoryFootprintWin.cpp: Added.

(WTF::memoryFootprint):

10:02 PM Changeset in webkit [216730] by Chris Dumez
  • 12 edits in trunk/Source

Drop remaining uses of PassRefPtr in WebCore
https://bugs.webkit.org/show_bug.cgi?id=172013

Reviewed by Yusuke Suzuki.

Source/WebCore:

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::createRootObject):

  • bindings/js/ScriptController.h:
  • bindings/js/ScriptControllerMac.mm:
  • bridge/objc/WebScriptObject.mm:

(WebCore::createJSWrapper):
(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):
(-[WebScriptObject _initWithJSObject:originRootObject:rootObject:]):

  • bridge/objc/WebScriptObjectPrivate.h:

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.h:
  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::demarshalValueFromArray):
(WebKit::NetscapePluginInstanceProxy::createBindingsInstance):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView createPluginBindingsInstance:]):

Source/WebKit/win:

  • Plugins/PluginView.cpp:

(WebCore::PluginView::bindingInstance):

9:32 PM Changeset in webkit [216729] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

8:55 PM Changeset in webkit [216728] by Alan Bujtas
  • 8 edits
    2 adds in trunk

RenderImageResource::hasImage is redundant and RenderImageResourceStyleImage's override is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=172010
<rdar://problem/31086735>

Reviewed by Simon Fraser.

Source/WebCore:

RenderImageResourceStyleImage::hasImage() always returns true even when ::cachedImage()
returns nullptr (e.g. image is pending).
Remove it and use cachedImage() instead.

Test: fast/images/missing-content-image-crash.html

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::didAttachRenderers):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::updateIntrinsicSizeIfNeeded):
(WebCore::RenderImage::isShowingMissingOrImageError):
(WebCore::RenderImage::hasNonBitmapImage):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::cachedImage):
(WebCore::RenderImageResource::hasImage): Deleted.

  • rendering/RenderImageResourceStyleImage.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paint):

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::hasSingleSecurityOrigin):
(WebCore::SVGImageElement::didAttachRenderers):

LayoutTests:

  • fast/images/missing-content-image-crash-expected.txt: Added.
  • fast/images/missing-content-image-crash.html: Added.
8:41 PM Changeset in webkit [216727] by commit-queue@webkit.org
  • 1 edit
    31 adds in trunk/PerformanceTests

Speedometer: Add an ES2015 (Babel + Webpack) TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171452

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adds ES2015 Babel + Webpack TodoMVC implem

  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/.babelrc: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/.eslintignore: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package.json: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/app.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/app.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/bootstrap.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/controller.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/controller.test.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/helpers.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/index.html: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/memory.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/model.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/template.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/todo.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/view.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/webpack.config.babel.js: Added.
8:18 PM Changeset in webkit [216726] by Alan Bujtas
  • 7 edits
    2 adds in trunk

AX: Defer text changes until after the tree is clean if needed.
https://bugs.webkit.org/show_bug.cgi?id=171546
<rdar://problem/31934942>

Reviewed by Simon Fraser.

Source/WebCore:

While updating an accessibility object state, we might
trigger unintentional style updates. This style update could
end up destroying renderes that are still referenced by functions
on the callstack.
To avoid that, defer such changes and let AXObjectCache operate on a clean tree.

Test: accessibility/crash-when-render-tree-is-not-clean.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.

  • accessibility/AXObjectCache.h: Decouple different type of changes.

(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLines):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):

  • rendering/RenderText.cpp:

(WebCore::RenderText::setText):

LayoutTests:

  • accessibility/crash-when-render-tree-is-not-clean-expected.txt: Added.
  • accessibility/crash-when-render-tree-is-not-clean.html: Added.
8:16 PM Changeset in webkit [216725] by commit-queue@webkit.org
  • 7 edits
    5 moves
    2 adds in trunk

Tools:
Allow WPT server to serve specific WebKit test
https://bugs.webkit.org/show_bug.cgi?id=171479

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adding a new mount point to WPT server.
It points to LayoutTests/http/wpt folder and is triggered on "/WebKit" urls.

Updating the webkitpy infrastructure to launch WPT server and do test url mapping for LayoutTests/wpt tests.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager._is_http_test):
(Manager._needs_web_platform_test):
(Manager._run_tests):
(Manager._is_web_platform_test): Deleted.

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:

(build_routes):
(main):

  • Scripts/webkitpy/port/driver.py:

(Driver):
(Driver.is_webkit_specific_web_platform_test):
(Driver.test_to_uri):
(Driver._command_from_driver_input):

LayoutTests:
Allow WPT server to serve specific WebKit tests
https://bugs.webkit.org/show_bug.cgi?id=171479

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Moving tests to ensure they are correctly runned.

  • http/wpt/fetch/fetch-as-blob-expected.txt: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob-expected.txt.
  • http/wpt/fetch/fetch-as-blob-worker-expected.txt: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob-worker-expected.txt.
  • http/wpt/fetch/fetch-as-blob-worker.html: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob-worker.html.
  • http/wpt/fetch/fetch-as-blob.html: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob.html.
  • http/wpt/fetch/fetch-as-blob.js: Renamed from LayoutTests/http/tests/fetch/fetch-as-blob.js.

(promise_test):

8:14 PM Changeset in webkit [216724] by Chris Dumez
  • 23 edits in trunk/Source/WebCore

Drop remaining uses of PassRefPtr under platform/
https://bugs.webkit.org/show_bug.cgi?id=172007

Reviewed by Geoffrey Garen.

  • platform/graphics/wpe/ImageWPE.cpp:

(WebCore::Image::loadPlatformResource):

  • platform/ios/LegacyTileGrid.h:
  • platform/ios/LegacyTileGrid.mm:

(WebCore::LegacyTileGrid::tileForIndex):
(WebCore::LegacyTileGrid::tileForPoint):

  • platform/ios/LegacyTileGridTile.h:

(WebCore::LegacyTileGridTile::create):

  • platform/mediastream/RTCIceCandidateDescriptor.cpp:

(WebCore::RTCIceCandidateDescriptor::create):

  • platform/mediastream/RTCIceCandidateDescriptor.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mediastream/RTCSessionDescriptionDescriptor.cpp:

(WebCore::RTCSessionDescriptionDescriptor::create):

  • platform/mediastream/RTCSessionDescriptionDescriptor.h:
  • platform/mediastream/RTCSessionDescriptionRequest.h:

(WebCore::RTCSessionDescriptionRequest::extraData):
(WebCore::RTCSessionDescriptionRequest::setExtraData):

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.h:
  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::firstSource):

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
  • platform/mock/DeviceOrientationClientMock.cpp:

(WebCore::DeviceOrientationClientMock::setOrientation):

  • platform/mock/DeviceOrientationClientMock.h:
  • platform/mock/GeolocationClientMock.cpp:

(WebCore::GeolocationClientMock::setPosition):

  • platform/mock/GeolocationClientMock.h:
  • platform/mock/RTCNotifiersMock.cpp:

(WebCore::SessionRequestNotifier::SessionRequestNotifier):
(WebCore::SessionRequestNotifier::fire):
(WebCore::VoidRequestNotifier::VoidRequestNotifier):

  • platform/mock/RTCNotifiersMock.h:
  • platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEventBasedMock::removeEvent):
(WebCore::TimerEvent::TimerEvent):
(WebCore::TimerEvent::timerFired):

  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockSourceBufferPrivateHasAudio):
(WebCore::MockSourceBufferPrivateHasVideo):

  • platform/wpe/RenderThemeWPE.h:
8:00 PM Changeset in webkit [216723] by rniwa@webkit.org
  • 1 edit
    22 adds in trunk/PerformanceTests

Speedometer: Add an Inferno TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171411

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adds a Inferno implem of TodoMVC to Speedometer

  • Speedometer/resources/todomvc/architecture-examples/inferno/dist/bundle.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-app-css/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-app-css/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/node_modules/todomvc-common/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/src/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/src/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/src/item.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/src/model.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/src/share.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/inferno/webpack.config.js: Added.
7:57 PM Changeset in webkit [216722] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore

[WPE] Stop using PassRefPtr in platform/graphics/wpe
https://bugs.webkit.org/show_bug.cgi?id=171977

Unreviewed build fix after r216702.

  • platform/graphics/wpe/ImageWPE.cpp:

(WebCore::Image::loadPlatformResource):

7:55 PM Changeset in webkit [216721] by rniwa@webkit.org
  • 1 edit
    50 adds in trunk/PerformanceTests

Speedometer: Add an Angular 2 (4.x) TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171343

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Add a TodoMVC Angular 2 (4.x) implem for the benchmark

  • Speedometer/resources/todomvc/architecture-examples/angular/.angular-cli.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/.editorconfig: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/assets/css/todomvc-app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/assets/css/todomvc-common.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/favicon.ico: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/inline.b342d102ba4a53bf2002.bundle.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/main.779eb2f1ddbe23ac61c7.bundle.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/polyfills.2d45a4c73c85e24fe474.bundle.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/styles.d41d8cd98f00b204e980.bundle.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/dist/vendor.b4be818cb6d8028f9192.bundle.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/e2e/app.e2e-spec.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/e2e/app.po.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/e2e/tsconfig.e2e.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/karma.conf.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/protractor.conf.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.spec.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.module.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo-data.service.spec.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo-data.service.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo.spec.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/app/todo.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/assets/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/assets/css/todomvc-app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/assets/css/todomvc-common.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/environments/environment.prod.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/environments/environment.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/favicon.ico: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/main.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/polyfills.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/styles.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/test.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/tsconfig.app.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/tsconfig.spec.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/src/typings.d.ts: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/tsconfig.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angular/tslint.json: Added.
7:54 PM Changeset in webkit [216720] by rniwa@webkit.org
  • 1 edit
    28 adds in trunk/PerformanceTests

Speedometer: Add a Vue.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171325

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adds a Vue.js TodoMVC implementation to Speedometer

  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.babelrc: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.editorconfig: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.eslintignore: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/.eslintrc.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/dev.env.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/prod.env.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/css/app.677b45842d9f8b96e5b23c18969233b7.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/app.b0e835874bc8949670d1.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/manifest.84b2b4fceb74ab1f91f3.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/vendor.a52517c5aa98e7fbea2e.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/App.vue: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/Todos.vue: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/todo.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/main.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/vuejs-cli/yarn.lock: Added.
7:53 PM Changeset in webkit [216719] by rniwa@webkit.org
  • 8 edits
    8 adds
    2 deletes in trunk/PerformanceTests

Speedometer: Update the vanilla JavaScript TodoMVC implem to a more recent version
https://bugs.webkit.org/show_bug.cgi?id=171306

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Update vanilla JS TodoMVC implementation to the latest.

  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower.json: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/index.html:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/app.js:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/controller.js:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/helpers.js:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/model.js:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/template.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/js/view.js:
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/vanillajs/package.json: Added.
7:52 PM Changeset in webkit [216718] by rniwa@webkit.org
  • 1 edit
    22 adds in trunk/PerformanceTests

Speedometer: Add an ES2015 TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171448

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adds ES2015 TodoMVC implementation for Speedometer

  • Speedometer/resources/todomvc/vanilla-examples/es2015/index.html: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/package.json: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-app-css/readme.md: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/package.json: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/node_modules/todomvc-common/readme.md: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/package.json: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/.jshintrc: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/app.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/controller.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/helpers.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/model.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/template.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/view.js: Added.
7:50 PM Changeset in webkit [216717] by rniwa@webkit.org
  • 1 edit
    16 adds in trunk/PerformanceTests

Speedometer: Add an Elm TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171464

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Speedometer: Add Elm TodoMVC implementation

  • Speedometer/resources/todomvc/functional-prog-examples/elm/Todo.elm: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/Todo/Task.elm: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/dist/elm.js: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/index.html: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/package.json: Added.
  • Speedometer/resources/todomvc/functional-prog-examples/elm/readme.md: Added.
7:46 PM Changeset in webkit [216716] by rniwa@webkit.org
  • 8 edits
    15 adds
    2 deletes in trunk/PerformanceTests

Speedometer: Update the Backbone.js implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171305

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Updates the Backbone.js TodoMVC implementation to latest

  • Speedometer/resources/todomvc/architecture-examples/backbone/bower.json: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/backbone/index.html:
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/app.js:
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/backbone.sync.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/collections/todos.js:
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/models/todo.js:
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/routers/router.js:
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/views/app-view.js:
  • Speedometer/resources/todomvc/architecture-examples/backbone/js/views/todo-view.js:
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/backbone/package.json: Added.
7:45 PM Changeset in webkit [216715] by rniwa@webkit.org
  • 1 edit
    22 adds in trunk/PerformanceTests

Speedometer: Add a Preact.js TodoMVC implementation
https://bugs.webkit.org/show_bug.cgi?id=171323

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Adds Preact.js TodoMVC implementation to Speedometer

  • Speedometer/resources/todomvc/architecture-examples/preact/.babelrc: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/dist/app.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/dist/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/dist/todomvc.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/rollup.config.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/footer.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/item.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/model.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/util.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/index.html: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/index.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/preact/webpack.config.babel.js: Added.
7:13 PM Changeset in webkit [216714] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-604.1.21.1

Tag Safari-604.1.21.1.

5:55 PM Changeset in webkit [216713] by commit-queue@webkit.org
  • 4 edits
    17 adds
    2 deletes in trunk/PerformanceTests

Speedometer: Update the jQuery implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171308

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Updates the jQuery implementation of TodoMVC to a more recent version

  • Speedometer/resources/todomvc/architecture-examples/jquery/bower.json: Removed.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Removed.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Removed.
  • Speedometer/resources/todomvc/architecture-examples/jquery/index.html:
  • Speedometer/resources/todomvc/architecture-examples/jquery/js/app.js:
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/handlebars/dist/handlebars.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/jquery/dist/jquery.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-app-css/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-app-css/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/node_modules/todomvc-common/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/jquery/readme.md:
5:52 PM Changeset in webkit [216712] by commit-queue@webkit.org
  • 23 edits
    3 adds in trunk

[iOS] Unset active media capture source when stopped capturing
https://bugs.webkit.org/show_bug.cgi?id=171815
<rdar://problem/32117885>

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/ios/mediastream/getUserMedia-single-capture.html

Introducing SingleSourceFactory template class to be used by capture factories for iOS.
This class ensures that only one source is active at a time.
Update all capture sources accordingly.
Ensure sources are no longer considered as active sources when being destroyed.
Add support for mock sources and introducing m_isProducingData for them as well.

Update WebRTC outgoing source classes to handle the case of replaced track and resetting the enabled/mute
state according the new source.

Update the way we handle timestamps for audio data. We now consider that we read/write as a flow.
This allows smooth audio track replacing.

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::~AVAudioCaptureSource):
(WebCore::AVAudioCaptureSourceFactory::setActiveSource): Deleted.

  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::~AVVideoCaptureSource):
(WebCore::AVVideoCaptureSourceFactory::setActiveSource): Deleted.

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::~CoreAudioCaptureSource):
(WebCore::CoreAudioCaptureSource::stopProducingData):
(WebCore::CoreAudioCaptureSourceFactory::setActiveSource): Deleted.

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::setSource):
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSource::pullAudioData):

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
  • platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::setSource):
(WebCore::RealtimeOutgoingVideoSource::sourceMutedChanged):
(WebCore::RealtimeOutgoingVideoSource::sourceEnabledChanged):

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::mockAudioCaptureSourceFactory):
(WebCore::MockRealtimeAudioSource::factory):
(WebCore::MockRealtimeAudioSource::~MockRealtimeAudioSource):
(WebCore::MockRealtimeAudioSource::startProducingData):
(WebCore::MockRealtimeAudioSource::stopProducingData):

  • platform/mock/MockRealtimeAudioSource.h:
  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::mockVideoCaptureSourceFactory):
(WebCore::MockRealtimeVideoSource::factory):
(WebCore::MockRealtimeVideoSource::~MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::startProducingData):
(WebCore::MockRealtimeVideoSource::stopProducingData):

  • platform/mock/MockRealtimeVideoSource.h:

(WebCore::MockRealtimeVideoSource::~MockRealtimeVideoSource): Deleted.

LayoutTests:

Improving the existing tests for better reliability and debugability.
Updating tests to use less webkitAudioContext.

  • platform/ios/mediastream/getUserMedia-single-capture-expected.txt: Added.
  • platform/ios/mediastream/getUserMedia-single-capture.html: Added.
  • webrtc/audio-peer-connection-webaudio.html:
  • webrtc/audio-replace-track-expected.txt:
  • webrtc/audio-replace-track.html:
  • webrtc/peer-connection-audio-mute.html:
  • webrtc/peer-connection-audio-mute2.html:
  • webrtc/peer-connection-remote-audio-mute.html:
  • webrtc/peer-connection-remote-audio-mute2.html:
  • webrtc/routines.js:
  • webrtc/video-replace-track-expected.txt:
  • webrtc/video-replace-track.html:
5:49 PM Changeset in webkit [216711] by beidson@apple.com
  • 7 edits in trunk

[WKWebsiteDataStore removeDataOfTypes:...] doesn't work for IndexedDB if the data store has a custom IDB path.
<rdar://problem/30612463> and https://bugs.webkit.org/show_bug.cgi?id=171994

Reviewed by Andy Estes.
Informal review by Maureen Daum.

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::deleteWebsiteData): Instead of accessing the m_idbServers set directly, make

the method call that creates the server on demand.

(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins): Ditto.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureDatabaseProcessAndWebsiteDataStore): Not only create the DatabaseProcess if necessary,

but also notify it about the passed-in WebsiteDataStore.

(WebKit::WebProcessPool::getDatabaseProcessConnection):
(WebKit::WebProcessPool::ensureDatabaseProcess): Deleted.

  • UIProcess/WebProcessPool.h:

(WebKit::WebProcessPool::sendToDatabaseProcessRelaunchingIfNecessary):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::databaseProcessParameters):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

5:47 PM Changeset in webkit [216710] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Modern Media Controls shouldn't be an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=172004
<rdar://problem/32146522>

Reviewed by Simon Fraser.

This is either always on or always off, so shouldn't
show up in an Experimental Features menu.

  • Shared/WebPreferencesDefinitions.h: Move ModernMediaControlsEnabled

to a normal preference.

5:43 PM Changeset in webkit [216709] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS build

  • platform/spi/mac/NSSpellCheckerSPI.h:
5:15 PM Changeset in webkit [216708] by commit-queue@webkit.org
  • 1 edit
    23 copies
    1 move
    50 adds
    9 deletes in trunk/PerformanceTests

Speedometer: Update the Flight.js implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171471

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Speedometer: Update FlightJS TodoMVC implementation

  • Speedometer/resources/todomvc/dependency-examples/flight/.gitignore: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/.jshintrc: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/main.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/app/js/store.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower.json: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-shim.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/compose.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/index.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/logger.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/jquery/jquery.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.css: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/bg.png: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/data/stats.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/stats.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/data/todos.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/data/todos.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/main.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/page/app.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/app.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/store.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/main_selector.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/main_selector.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/new_item.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/new_item.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/stats.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/stats.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/todo_list.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/todo_list.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/toggle_all.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/toggle_all.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/ui/with_filters.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/ui/with_filters.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/js/utils.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/js/utils.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/templates/stats.html: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/templates/stats.html.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/app/templates/todo.html: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/app/templates/todo.html.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/index.html: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/index.html.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/README.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/depot.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/depot/depot.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/depot.min.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/depot/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/LICENSE: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-sham.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/es5-shim/es5-sham.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-sham.min.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-shim.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/es5-shim/es5-shim.min.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/LICENSE: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/index.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/advice.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/advice.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/base.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/base.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/component.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/component.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/compose.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/debug.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/debug.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/logger.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/registry.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/registry.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/flight/lib/utils.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/flight/lib/utils.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/README.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/dist/jquery.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/dist/jquery.min.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/jquery/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/memorystorage/memorystorage.js: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/LICENSE: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/README.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/bower.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs-text/text.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs-text/text.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/README.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/requirejs/require.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/requirejs/require.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-app-css/readme.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/base.js: Renamed from PerformanceTests/Speedometer/resources/todomvc/dependency-examples/flight/bower_components/todomvc-common/base.js.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/node_modules/todomvc-common/readme.md: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/flight/package.json: Added.
  • Speedometer/resources/todomvc/dependency-examples/flight/karma.conf.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/package.json: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/readme.md: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/.jshintrc: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/footer.html: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/new_todo.html: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/fixture/toggle_all.html: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/mock/datastore.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/stats_spec.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/data/todos_spec.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/new_item_spec.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/stats_spec.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/spec/ui/toggle_all_spec.js: Removed.
  • Speedometer/resources/todomvc/dependency-examples/flight/test/test-main.js: Removed.
5:13 PM Changeset in webkit [216707] by Matt Lewis
  • 10 edits in trunk

Unreviewed, rolling out r216677.

Patch caused layout test crashes.

Reverted changeset:

"WorkerThread::stop() should call
scheduleExecutionTermination() last."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216677

5:12 PM Changeset in webkit [216706] by commit-queue@webkit.org
  • 8 edits
    18 adds
    4 deletes in trunk/PerformanceTests

Speedometer: Update the AngularJS implementation to a more recent library version
https://bugs.webkit.org/show_bug.cgi?id=171307

Patch by Addy Osmani <addyosmani@gmail.com> on 2017-05-11
Reviewed by Ryosuke Niwa.

Updates the AngularJS implementation of TodoMVC to 1.4.x

  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower.json: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/index.html:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/app.js:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/js/services/todoStorage.js:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/index.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/base.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/base.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/readme.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Added.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md:
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/package.json: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/readme.md: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/angularjs/todomvc-index.html: Added.
5:04 PM Changeset in webkit [216705] by commit-queue@webkit.org
  • 11 edits in trunk

[CMake] Add HAVE check for regex.h
https://bugs.webkit.org/show_bug.cgi?id=171950

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-11
Reviewed by Michael Catanzaro.

.:

  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

  • runtime/ConfigFile.cpp:

(JSC::ConfigFile::parse):

Source/ThirdParty:

  • gtest/include/gtest/internal/gtest-port.h:

Source/WebCore:

No new tests. No change in behavior.

  • WebCorePrefix.h:
  • testing/js/WebCoreTestSupportPrefix.h:

Source/WTF:

  • wtf/Platform.h:
4:55 PM Changeset in webkit [216704] by timothy_horton@apple.com
  • 8 edits in trunk/Source

Mail spins launching spell checker when typing
https://bugs.webkit.org/show_bug.cgi?id=171986
<rdar://problem/26305327>

Reviewed by Beth Dakin.

  • platform/spi/mac/NSSpellCheckerSPI.h:
  • WebView/WebView.mm:

(-[WebView setEditable:]):
Asynchronously pre-warm the spell checker when a WebView becomes editable.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setEditable:]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::didBecomeEditable):
(WebKit::WebViewImpl::startObservingFontPanel): Deleted.
Asynchronously pre-warm the spell checker when a WKWebView becomes editable.

4:46 PM Changeset in webkit [216703] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Remove the code for old syncing script configuration in BuildbotSyncer
https://bugs.webkit.org/show_bug.cgi?id=171963

Reviewed by Chris Dumez.

Removed the code for specifying {"root": ~}, {"rootOptions": [~]}, and {"rootsExcluding": [~]} in buildbot
properties in the syncing script's configurations since they are no longer used after r215061.

Also removed the support for using "arguments" as an alias to "properties", and updated the tests accordingly.

  • tools/js/buildbot-syncer.js:

(BuildbotSyncer._parseRepositoryGroup): Removed the unused code.
(BuildbotSyncer._validateAndMergeConfig): Just allow string values in properties.
(BuildbotSyncer._validateAndMergeProperties): Deleted.

  • unit-tests/buildbot-syncer-tests.js:

(sampleiOSConfig): Use "properties" instead of "arguments" to specify the buildbot properties.
(sampleiOSConfigWithExpansions): Ditto.

4:40 PM Changeset in webkit [216702] by Chris Dumez
  • 121 edits in trunk/Source

Stop using PassRefPtr in platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=171977

Reviewed by Alex Christensen.

Source/WebCore:

Stop using PassRefPtr in platform/graphics.

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::image):

  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::brokenImage):
(WebCore::CachedImage::image):
(WebCore::CachedImage::imageForRenderer):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::addImageToResources):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawCrossfade):

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::nullImage):

  • platform/graphics/Image.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::createResourceLoader):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/Pattern.cpp:

(WebCore::Pattern::create):
(WebCore::Pattern::Pattern):

  • platform/graphics/Pattern.h:
  • platform/graphics/PlatformTextTrack.h:

(WebCore::PlatformTextTrack::create):
(WebCore::PlatformTextTrack::createOutOfBand):
(WebCore::PlatformTextTrack::captionMenuOffItem):
(WebCore::PlatformTextTrack::captionMenuAutomaticItem):

  • platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.cpp:

(WebCore::InbandMetadataTextTrackPrivateAVF::create):
(WebCore::InbandMetadataTextTrackPrivateAVF::addDataCue):

  • platform/graphics/avfoundation/InbandMetadataTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings):

  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.h:
  • platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionOptionAVFObjC::create):
(WebCore::MediaSelectionGroupAVFObjC::create):
(WebCore::MediaSelectionGroupAVFObjC::updateOptions):

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:

(WebCore::InbandTextTrackPrivateAVCF::create):

  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h:

(WebCore::InbandTextTrackPrivateLegacyAVCF::create):

  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::create):

  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:

(WebCore::InbandTextTrackPrivateAVFObjC::create):

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:

(WebCore::InbandTextTrackPrivateLegacyAVFObjC::create):

  • platform/graphics/avfoundation/objc/OutOfBandTextTrackPrivateAVF.h:

(WebCore::OutOfBandTextTrackPrivateAVF::create):

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::create):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createPlatformCALayer):
(WebCore::GraphicsLayerCA::createPlatformCAAnimation):
(WebCore::GraphicsLayerCA::setContentsToPlatformLayer):
(WebCore::GraphicsLayerCA::replicatedLayerRoot):
(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createBasicAnimation):
(WebCore::GraphicsLayerCA::createKeyframeAnimation):
(WebCore::GraphicsLayerCA::createSpringAnimation):

  • platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):

  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.h:
  • platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:

(PlatformCAAnimationCocoa::create):
(PlatformCAAnimationCocoa::copy):

  • platform/graphics/ca/win/AbstractCACFLayerTreeHost.h:
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::create):
(WebCore::CACFLayerTreeHost::addPendingAnimatedLayer):

  • platform/graphics/ca/win/CACFLayerTreeHost.h:
  • platform/graphics/ca/win/PlatformCAAnimationWin.cpp:

(PlatformCAAnimationWin::create):
(PlatformCAAnimationWin::copy):

  • platform/graphics/ca/win/PlatformCAAnimationWin.h:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::addAnimationForKey):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:

(WebCore::WKCACFViewLayerTreeHost::create):

  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
  • platform/graphics/cairo/PatternCairo.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::clipForPatternFilling):

  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/cg/PatternCG.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/filters/FEDiffuseLighting.cpp:

(WebCore::FEDiffuseLighting::FEDiffuseLighting):
(WebCore::FEDiffuseLighting::create):
(WebCore::FEDiffuseLighting::lightSource):

  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::FELighting):
(WebCore::FELighting::drawLighting):

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FESpecularLighting.cpp:

(WebCore::FESpecularLighting::FESpecularLighting):
(WebCore::FESpecularLighting::create):
(WebCore::FESpecularLighting::lightSource):

  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asUnmultipliedImage):
(WebCore::FilterEffect::asPremultipliedImage):

  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::ReferenceFilterOperation::setFilterEffect):
(WebCore::BasicColorMatrixFilterOperation::blend):
(WebCore::BasicComponentTransferFilterOperation::blend):
(WebCore::BlurFilterOperation::blend):
(WebCore::DropShadowFilterOperation::blend):

  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::blend):
(WebCore::PassthroughFilterOperation::create):
(WebCore::ReferenceFilterOperation::create):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::create):

  • platform/graphics/gpu/Texture.h:
  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/ImageGStreamer.h:

(WebCore::ImageGStreamer::createImage):
(WebCore::ImageGStreamer::image):

  • platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:

(WebCore::InbandMetadataTextTrackPrivateGStreamer::create):
(WebCore::InbandMetadataTextTrackPrivateGStreamer::addGenericCue):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:

(WebCore::InbandTextTrackPrivateGStreamer::create):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processTableOfContentsEntry):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::paint):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::enqueueSample):

  • platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
  • platform/graphics/gstreamer/mse/MediaSourceGStreamer.cpp:
  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample):

  • platform/graphics/gstreamer/mse/PlaybackPipeline.h:
  • platform/graphics/gtk/ImageGtk.cpp:

(WebCore::loadImageFromGResource):
(WebCore::loadResourceSharedBuffer):
(WebCore::loadMissingImageIconFromTheme):
(WebCore::Image::loadPlatformResource):

  • platform/graphics/harfbuzz/HarfBuzzFace.cpp:

(WebCore::FaceCacheEntry::create):

  • platform/graphics/harfbuzz/HarfBuzzFace.h:

(WebCore::HarfBuzzFace::create):

  • platform/graphics/mac/ImageMac.mm:

(WebCore::Image::loadPlatformResource):

  • platform/graphics/opentype/OpenTypeMathData.h:

(WebCore::OpenTypeMathData::create):

  • platform/graphics/texmap/BitmapTexture.h:

(WebCore::BitmapTexture::applyFilters):

  • platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::applyFilters):

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::FilterInfo::FilterInfo):

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):

  • platform/graphics/texmap/TextureMapper.cpp:

(WebCore::TextureMapper::acquireTextureFromPool):

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::createTexture):

  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::commitSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
(WebCore::TextureMapperLayer::setBackingStore):

  • platform/graphics/texmap/TextureMapperLayer.h:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.h:

(WebCore::TextureMapperTiledBackingStore::create):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::syncImageBacking):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::create):
(WebCore::CoordinatedImageBacking::CoordinatedImageBacking):

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.h:
  • platform/graphics/win/ImageWin.cpp:

(WebCore::Image::loadPlatformResource):

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:

(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):

  • platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
  • platform/graphics/win/PatternDirect2D.cpp:

(WebCore::Pattern::createPlatformPattern):

  • platform/graphics/win/SharedGDIObject.h:

(WebCore::SharedGDIObject::create):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute):
(WebCore::SVGFEDiffuseLightingElement::build):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute):
(WebCore::SVGFESpecularLightingElement::build):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

Source/WebKit/win:

Build fix.

  • FullscreenVideoController.cpp:

(FullscreenVideoController::enterFullscreen):

  • WebKitDLL.cpp:

(loadResourceIntoBuffer):

Source/WebKit2:

Build fix.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::createBackingStoreIfNeeded):
(WebKit::CoordinatedGraphicsScene::removeBackingStoreIfNeeded):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<Cursor>::decode):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::createImageBackingIfNeeded):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
  • WebProcess/WebPage/mac/GraphicsLayerCARemote.cpp:

(WebKit::GraphicsLayerCARemote::createPlatformCALayer):
(WebKit::GraphicsLayerCARemote::createPlatformCAAnimation):

  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::copy):

4:34 PM Changeset in webkit [216701] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r216217): lldb_webkit.py no longer prints out a WTFString, StringImpl needs to handle StringImplShape change
https://bugs.webkit.org/show_bug.cgi?id=171989

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-11
Reviewed by Brian Burg.

  • lldb/lldb_webkit.py:

(WTFStringImplProvider.get_data8):
(WTFStringImplProvider.get_data16):
m_data8 and m_data16 are now part of the superclass StringImplShape
instead of directly in StringImpl. So first get the shape by getting
index 0, and the data properties are the same offset within that.

4:33 PM Changeset in webkit [216700] by Chris Dumez
  • 2 edits in trunk/Source/WTF

Annotate Ref::ptr() with RETURNS_NONNULL
https://bugs.webkit.org/show_bug.cgi?id=171996

Reviewed by Andreas Kling.

Annotate Ref::ptr() with RETURNS_NONNULL as it can never return null.

  • wtf/Ref.h:

(WTF::Ref::ptr): Deleted.

4:05 PM Changeset in webkit [216699] by fpizlo@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Callers of JSString::unsafeView() should check exceptions
https://bugs.webkit.org/show_bug.cgi?id=171995

Reviewed by Mark Lam.

unsafeView() can throw OOME. So, callers of unsafeView() should check for exceptions before trying
to access the view.

Also, I made the functions surrounding unsafeView() take ExecState* not ExecState&, to comply with
the rest of JSC.

  • dfg/DFGOperations.cpp:
  • jsc.cpp:

(printInternal):
(functionDebug):

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncJoin):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorFuncCompare):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncJoin):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncParseFloat):

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/JSString.cpp:

(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):

  • runtime/JSString.h:

(JSC::JSString::getIndex):
(JSC::JSRopeString::unsafeView):
(JSC::JSRopeString::viewWithUnderlyingString):
(JSC::JSString::unsafeView):
(JSC::JSString::viewWithUnderlyingString):

  • runtime/JSStringJoiner.h:

(JSC::JSStringJoiner::appendWithoutSideEffects):
(JSC::JSStringJoiner::append):

  • runtime/ParseInt.h:

(JSC::toStringView):

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncRepeatCharacter):
(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncNormalize):

4:03 PM Changeset in webkit [216698] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Data loss when saving a PDF form where only radio buttons/checkboxes were modified
https://bugs.webkit.org/show_bug.cgi?id=171991
<rdar://problem/32115945>

Reviewed by Andy Estes.

  • WebProcess/Plugins/PDF/PDFLayerControllerSPI.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(-[WKPDFLayerControllerDelegate didChangeAnnotationState]):
Mark the PDF as dirty (so we re-encode it when asked to save) if annotations
that only PDFKit knows about change.

3:31 PM Changeset in webkit [216697] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked tiled-drawing/scrolling/fast-scroll-iframe-latched-mainframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168937

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:45 PM Changeset in webkit [216696] by Joseph Pecoraro
  • 29 edits
    21 deletes in trunk

Remove Vibration API
https://bugs.webkit.org/show_bug.cgi?id=171766

Rubber-stamped by Alexey Proskuryakov.

.:

  • Source/cmake/WebKitFeatures.cmake:

Source/WebCore:

  • features.json:

Mark the Vibration API as removed.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • Modules/vibration/NavigatorVibration.cpp: Removed.
  • Modules/vibration/NavigatorVibration.h: Removed.
  • Modules/vibration/NavigatorVibration.idl: Removed.
  • Modules/vibration/Vibration.cpp: Removed.
  • Modules/vibration/Vibration.h: Removed.
  • Modules/vibration/VibrationClient.h: Removed.
  • testing/Internals.cpp:

(WebCore::Internals::isVibrating): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

  • CMakeLists.txt:
  • Shared/API/APIObject.h:
  • Shared/API/c/WKBase.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetVibration): Deleted.

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKVibration.cpp: Removed.
  • UIProcess/API/C/WKVibration.h: Removed.
  • UIProcess/WebPageProxy.cpp:

(WebKit::m_weakPtrFactory):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::vibration): Deleted.

  • UIProcess/WebVibrationProvider.cpp: Removed.
  • UIProcess/WebVibrationProvider.h: Removed.
  • UIProcess/WebVibrationProxy.cpp: Removed.
  • UIProcess/WebVibrationProxy.h: Removed.
  • UIProcess/WebVibrationProxy.messages.in: Removed.
  • WebProcess/WebCoreSupport/WebVibrationClient.cpp: Removed.
  • WebProcess/WebCoreSupport/WebVibrationClient.h: Removed.
  • WebProcess/WebPage/WebPage.cpp:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wpe/TestExpectations:
  • vibration/cancelVibration-after-pagevisibility-changed-to-hidden-expected.txt: Removed.
  • vibration/cancelVibration-after-pagevisibility-changed-to-hidden.html: Removed.
  • vibration/cancelVibration-during-pattern-vibrating-expected.txt: Removed.
  • vibration/cancelVibration-during-pattern-vibrating.html: Removed.
  • vibration/navigator-vibration-expected.txt: Removed.
  • vibration/navigator-vibration.html: Removed.
2:39 PM Changeset in webkit [216695] by dino@apple.com
  • 18 edits
    2 adds
    1 delete in trunk

WebGLRenderingContext should implement WebGLRenderingContextBase
https://bugs.webkit.org/show_bug.cgi?id=171961
<rdar://problem/32124920>

Reviewed by Sam Weinig.

Source/WebCore:

WebGLRenderingContext and WebGL2RenderingContext are both
defined to "implement" WebGLRenderingContextBase. However, we
were doing it via inheritance, which meant that some things
were not visible on the WebGLRenderingContext prototype.

Test: fast/canvas/webgl/constants-on-interface.html

  • WebCore.xcodeproj/project.pbxproj: Move the Custom.cpp files

out of the GC-only area now they have real content.

  • bindings/js/JSDocumentCustom.cpp: Handle the fact that we

don't use the base class from the bindings, so we need to
translate WebGL1 and WebGL2 contexts into the right JS classes.
(WebCore::JSDocument::getCSSCanvasContext):

  • bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::JSHTMLCanvasElement::getContext):

  • bindings/js/JSWebGL2RenderingContextCustom.cpp: Implement the

custom methods. In this case, we don't yet expose any
extensions for WebGL 2.
(WebCore::toJS):
(WebCore::JSWebGL2RenderingContext::getExtension):

  • bindings/js/JSWebGLRenderingContextBaseCustom.cpp: Removed.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):
(WebCore::JSWebGLRenderingContext::getExtension):

  • html/canvas/WebGL2RenderingContext.h: Make some things public.
  • html/canvas/WebGLRenderingContext.h: Ditto.
  • html/canvas/WebGL2RenderingContext.idl: Use implements.
  • html/canvas/WebGLRenderingContext.idl: Ditto.
  • testing/Internals.cpp: This now takes a WebGLRenderingContext.

(WebCore::Internals::simulateWebGLContextChanged):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

New test to make sure constants from WebGLRenderingContextBase are
visible on the WebGLRenderingContext prototype.

Also, fix up some existing tests that were expecting to see
instances of WebGLRenderingContextBase.

  • fast/canvas/webgl/constants-on-interface-expected.txt: Added.
  • fast/canvas/webgl/constants-on-interface.html: Added.
  • fast/canvas/webgl/gl-object-get-calls-expected.txt:
  • fast/canvas/webgl/null-object-behaviour-expected.txt:
  • fast/canvas/webgl/texImageTest-expected.txt:
1:58 PM Changeset in webkit [216694] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed typo errors in TestExpectations.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:55 PM Changeset in webkit [216693] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed typo errors in TestExpectations.

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:52 PM Changeset in webkit [216692] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: "Elements > Styles - Rules" rule and media query headers should be left aligned
https://bugs.webkit.org/show_bug.cgi?id=171954
<rdar://problem/31961976>

Reviewed by Matt Baker.

  • UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section > .header):
(.style-declaration-section.locked > .header > .locked-icon):
(.style-declaration-section > .header > .icon):
(.style-declaration-section > .header > textarea):
(.style-declaration-section.invalid-selector > .header > .icon):
(body[dir=ltr] .style-declaration-section > .header): Deleted.
(body[dir=rtl] .style-declaration-section > .header): Deleted.
(body[dir=ltr] .style-declaration-section.locked > .header > .locked-icon): Deleted.
(body[dir=rtl] .style-declaration-section.locked > .header > .locked-icon): Deleted.
(body[dir=ltr] .style-declaration-section > .header > .icon): Deleted.
(body[dir=rtl] .style-declaration-section > .header > .icon): Deleted.
(body[dir=ltr] .style-declaration-section > .header > textarea): Deleted.
(body[dir=rtl] .style-declaration-section > .header > textarea): Deleted.
Remove RTL rules.

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):
Set dir="ltr" so selector's textareas work correctly.

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style .rules):

1:30 PM Changeset in webkit [216691] by aestes@apple.com
  • 5 edits in trunk/Source

Fix a spelling mistake in ApplePayErrorCode
https://bugs.webkit.org/show_bug.cgi?id=171981
<rdar://problem/32136567>

Reviewed by Beth Dakin.

Source/WebCore:

  • Modules/applepay/ApplePayError.idl:
  • Modules/applepay/PaymentRequest.h:

Source/WebKit2:

  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toPKPaymentErrorCode):
(WebKit::toPKPaymentAuthorizationStatus):

1:04 PM Changeset in webkit [216690] by wilander@apple.com
  • 7 edits
    1 add in trunk/Source

Resource Load Statistics: Enable configuration through preferences
https://bugs.webkit.org/show_bug.cgi?id=171949
<rdar://problem/31894518>

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. Just an added setter.

  • loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::setReducedTimestampResolution):

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:

Added ResourceLoadStatisticsTimeToLiveUserInteraction,
ResourceLoadStatisticsTimeToLiveCookiePartitionFree, and
ResourceLoadStatisticsReducedTimestampResolution.

  • UIProcess/Cocoa/WebResourceLoadStatisticsManagerCocoa.mm: Added.

(WebKit::WebResourceLoadStatisticsManager::registerUserDefaultsIfNeeded):

  • UIProcess/WebResourceLoadStatisticsManager.h:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):

Now calls WebResourceLoadStatisticsManager::registerUserDefaultsIfNeeded().

  • WebKit2.xcodeproj/project.pbxproj:
12:59 PM Changeset in webkit [216689] by fpizlo@apple.com
  • 6 edits
    4 adds in trunk/Source/JavaScriptCore

Offer SPI to notify clients that GC has happened
https://bugs.webkit.org/show_bug.cgi?id=171980

Reviewed by Geoffrey Garen.

Sometimes when you're programming with weak references, it's most convenient if the GC tells
you when it finishes. This adds exactly such an API. This API is called at the *flip*: the
moment when the GC knows for sure which objects are dead and has definitely not allocated any
new objects or executed any JS code. The finalization part of the flip, which is where this
callback gets called, runs on the "main" thread - i.e. some thread that is attempting to
execute JS code and holds the JS lock. This will usually run as a side-effect of some
allocation or from the runloop.

This means, for example, that if you implemented a vector of weak references and registered a
callback to prune the vector of null weak references, then aside from the callback, nobody
would ever see a null weak reference in the vector.

  • API/JSHeapFinalizerPrivate.cpp: Added.

(JSContextGroupAddHeapFinalizer):
(JSContextGroupRemoveHeapFinalizer):

  • API/JSHeapFinalizerPrivate.h: Added.
  • API/tests/testapi.c:

(heapFinalizer):
(testMarkingConstraintsAndHeapFinalizers):
(main):
(testMarkingConstraints): Deleted.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.cpp:

(JSC::Heap::finalize):
(JSC::Heap::addHeapFinalizerCallback):
(JSC::Heap::removeHeapFinalizerCallback):

  • heap/Heap.h:
  • heap/HeapFinalizerCallback.cpp: Added.

(JSC::HeapFinalizerCallback::dump):

  • heap/HeapFinalizerCallback.h: Added.

(JSC::HeapFinalizerCallback::HeapFinalizerCallback):
(JSC::HeapFinalizerCallback::operator==):
(JSC::HeapFinalizerCallback::operator!=):
(JSC::HeapFinalizerCallback::operator bool):
(JSC::HeapFinalizerCallback::run):

11:49 AM Changeset in webkit [216688] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Unify hasTouchScrollableOverflow/needsCompositedScrolling concepts
https://bugs.webkit.org/show_bug.cgi?id=171974

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-11
Reviewed by Simon Fraser.

This commit moves the following pattern in a single RenderLayer::usesAcceleratedScrolling function:
#if PLATFORM(IOS)
...hasTouchScrollableOverflow()...
#else
...needsCompositedScrolling()...
#endif

No new tests, behavior unchanged.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::usesAcceleratedScrolling): Introduce helper function.

  • rendering/RenderLayer.h: Declare the function.
  • rendering/RenderLayerBacking.cpp:

(WebCore::layerOrAncestorIsTransformedOrUsingCompositedScrolling): Use the new function.
(WebCore::RenderLayerBacking::updateConfiguration): Ditto.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::useCoordinatedScrollingForLayer): Ditto.

11:38 AM Changeset in webkit [216687] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/webappapis/timers/negative-settimeout.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170699

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:32 AM Changeset in webkit [216686] by commit-queue@webkit.org
  • 9 edits in trunk

[Readable Streams API] Implement ReadableStreamBYOBReader cancel()
https://bugs.webkit.org/show_bug.cgi?id=171919

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-05-11
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Updated expectations.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:

Source/WebCore:

Implemented ReadableStreamBYOBReader cancel() method.

Added tests checking cancel().

  • Modules/streams/ReadableStreamBYOBReader.js:

(cancel): Implemented.

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamError): Updated to support ReadableStreamBYOBReader case.

LayoutTests:

Added test cases to check cancel() behaviour.

  • streams/readable-stream-byob-reader-expected.txt: Updated.
  • streams/readable-stream-byob-reader.js: Updated.
11:18 AM Changeset in webkit [216685] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/media-controls-clone-crash.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171978

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:01 AM Changeset in webkit [216684] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSWeakCreate/Retain/Release should take a JSContextGroupRef and not a JSContextRef
https://bugs.webkit.org/show_bug.cgi?id=171979

Reviewed by Mark Lam.

Functions that don't execute arbitrary JS but just need access to the VM should take a
JSContextGroupRef, not a JSContextRef.

  • API/JSWeakPrivate.cpp:

(JSWeakCreate):
(JSWeakRetain):
(JSWeakRelease):

  • API/JSWeakPrivate.h:
  • API/tests/testapi.c:

(testMarkingConstraints):

10:55 AM Changeset in webkit [216683] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Stop using PassRefPtr in WebGPU code
https://bugs.webkit.org/show_bug.cgi?id=171965

Reviewed by Alex Christensen.

Stop using PassRefPtr in WebGPU code.

  • html/canvas/WebGPUDrawable.cpp:

(WebCore::WebGPUDrawable::WebGPUDrawable):

  • html/canvas/WebGPURenderingContext.cpp:

(WebCore::WebGPURenderingContext::create):
(WebCore::WebGPURenderingContext::WebGPURenderingContext):

  • html/canvas/WebGPURenderingContext.h:
  • html/canvas/WebGPUTexture.cpp:

(WebCore::WebGPUTexture::createFromDrawableTexture):
(WebCore::WebGPUTexture::WebGPUTexture):

  • html/canvas/WebGPUTexture.h:
10:31 AM Changeset in webkit [216682] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Name WebRTC Threads
https://bugs.webkit.org/show_bug.cgi?id=171975

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-11
Reviewed by Eric Carlson.

No change of behavior.

  • platform/mediastream/libwebrtc/LibWebRTCAudioModule.cpp:

(WebCore::LibWebRTCAudioModule::LibWebRTCAudioModule): Setting audio module thread name.

  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::initializePeerConnectionFactoryAndThreads): Setting signaling and networking thread names.

10:14 AM Changeset in webkit [216681] by Matt Baker
  • 7 edits in trunk

Web Inspector: Error trying to delete DOM breakpoints from the Debugger tab
https://bugs.webkit.org/show_bug.cgi?id=171970
<rdar://problem/32129262>

Reviewed by Brian Burg.

Source/WebInspectorUI:

In the Debugger sidebar, DOM breakpoints can be cleared from a DOM node
in two ways: by using the DOM node tree element's context menu, or by
pressing the delete key while the element is selected. Each method used
a different code path, and the latter had an error which caused it to fail.

Add a removeDOMBreakpointsForNode method to DOMDebuggerManager to make
the operation convenient, and call it from both event handlers.

  • UserInterface/Controllers/DOMBreakpointTreeController.js:

(WebInspector.DOMBreakpointTreeController.appendBreakpointContextMenuItems):
Use convenience method.

  • UserInterface/Controllers/DOMDebuggerManager.js:

(WebInspector.DOMDebuggerManager.prototype.removeDOMBreakpointsForNode):
Helper function for removing all of a node's breakpoints.

  • UserInterface/Views/DOMNodeTreeElement.js:

(WebInspector.DOMNodeTreeElement.prototype.ondelete):
Use convenience method.

LayoutTests:

Add test for DOMDebuggerManager.prototype.removeDOMBreakpointsForNode.

  • inspector/dom-debugger/dom-breakpoints-expected.txt:
  • inspector/dom-debugger/dom-breakpoints.html:
9:31 AM Changeset in webkit [216680] by pvollan@apple.com
  • 3 edits in trunk/LayoutTests

LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749

Reviewed by Eric Carlson.

Revert parts of r216588. The position of the 'canplaythrough' event in the event sequence
is not always the same, causing flakiness. Stop listening to the 'canplaythrough' event,
this was introduced in r216588.

  • http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
  • http/tests/media/track-in-band-hls-metadata-crash.html:
9:29 AM Changeset in webkit [216679] by Chris Dumez
  • 14 edits in trunk/Source/WebCore

Stop using PassRefPtr in platform/audio
https://bugs.webkit.org/show_bug.cgi?id=171966

Reviewed by Ryosuke Niwa.

Stop using PassRefPtr in platform/audio.

  • platform/audio/AudioBus.h:

(WebCore::AudioBus::AudioBus):

  • platform/audio/AudioFileReader.h:
  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::createAndLoadAsynchronouslyIfNecessary):

  • platform/audio/HRTFDatabaseLoader.h:
  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::createInterpolatedKernel):

  • platform/audio/HRTFKernel.h:

(WebCore::HRTFKernel::create):

  • platform/audio/glib/AudioBusGLib.cpp:

(WebCore::AudioBus::loadPlatformResource):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/ios/AudioFileReaderIOS.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/ios/AudioFileReaderIOS.h:
  • platform/audio/mac/AudioBusMac.mm:

(WebCore::AudioBus::loadPlatformResource):

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):

  • platform/audio/mac/AudioFileReaderMac.h:
9:29 AM Changeset in webkit [216678] by clopez@igalia.com
  • 5 edits in trunk/Tools

Add WPE release bots
https://bugs.webkit.org/show_bug.cgi?id=171973

Reviewed by Žan Doberšek.

This adds a WPE Release Build bot (64-bit) and a WPE Release Test bot.
It also adds a new WPE buildbot category.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(InstallWpeDependencies):
(appendCustomBuildFlags):
(Factory.init):
(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
8:26 AM Changeset in webkit [216677] by mark.lam@apple.com
  • 10 edits in trunk

WorkerThread::stop() should call scheduleExecutionTermination() last.
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

  • runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):
(JSC::ExceptionScope::releaseAssertIsTerminatedExecutionException):

  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before run loop is terminate, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by ensuring that having WorkerThread::stop() terminate
the run loop before it scheduleExecutionTermination() which throws the
TerminatedExecutionException. This way, by the time JS code unwinds out of the
VM due to the TerminatedExecutionException, runLoop.terminated() is guaranteed
to be true and thereby prevents re-entry into the VM.

This issue is covered by an existing test that I just unskipped in TestExpectations.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):

LayoutTests:

6:33 AM Changeset in webkit [216676] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of tests failing after r216450.

  • platform/gtk/TestExpectations:
5:54 AM Changeset in webkit [216675] by Claudio Saavedra
  • 2 edits in trunk/Source/WebKit2

[GTK] Remove notifications guards from GTK API layer
https://bugs.webkit.org/show_bug.cgi?id=170014

Reviewed by Michael Catanzaro.

ENABLE_NOTIFICATIONS in the GTK port is a private option and
disabling it is unsupported, hence remove its guards from the GTK API
layer.

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed):

2:09 AM Changeset in webkit [216674] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.17.2

WebKitGTK+ 2.17.2

1:34 AM Changeset in webkit [216673] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.17.2.
12:56 AM Changeset in webkit [216672] by jfbastien@apple.com
  • 3 edits
    1 add in trunk

WebAssembly: stop supporting 0xD
https://bugs.webkit.org/show_bug.cgi?id=168788
<rdar://problem/31880922>

Reviewed by Saam Barati.

JSTests:

Test that only version 1 is supported.

  • wasm/js-api/version.js: Added.

Source/JavaScriptCore:

Only version 1 is supported by other browsers, and there shouldn't
be any 0xD binaries in the wild anymore.

  • wasm/WasmModuleParser.cpp:
12:56 AM Changeset in webkit [216671] by commit-queue@webkit.org
  • 1 edit
    18 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add new GTK+ icons for resources in large sizes (32px @ 1x/2x)
https://bugs.webkit.org/show_bug.cgi?id=155802
<rdar://problem/25320686>

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-11
Reviewed by Carlos Garcia Campos.

Add more free icons for the Web Inspector in GTK+.

12:55 AM Changeset in webkit [216670] by Claudio Saavedra
  • 2 edits in trunk/Source/WebKit2

[GTK] JavaScript prompt uses title of page to be loaded rather than title of current page
https://bugs.webkit.org/show_bug.cgi?id=152690

Reviewed by Michael Catanzaro.

webkit_web_view_get_uri() returns the page to be loaded, use
internal api for this.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateJavaScriptDialog):

12:35 AM Changeset in webkit [216669] by Chris Dumez
  • 8 edits
    1 delete in trunk/Source/WebCore

Drop custom bindings code for HTMLFormControlsCollection's named property getter
https://bugs.webkit.org/show_bug.cgi?id=171964

Reviewed by Sam Weinig.

Drop custom bindings code for HTMLFormControlsCollection's named property getter as
we are able to generate it.

No new tests, no expected Web-facing behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateNamedGetter):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::namedItemOrItems):

  • html/HTMLFormControlsCollection.h:
  • html/HTMLFormControlsCollection.idl:
12:27 AM Changeset in webkit [216668] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216530. rdar://problem/32080319

12:27 AM Changeset in webkit [216667] by jmarcell@apple.com
  • 11 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216477. rdar://problem/32058957

12:27 AM Changeset in webkit [216666] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216475. rdar://problem/32041569

12:27 AM Changeset in webkit [216665] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216471. rdar://problem/31132092

12:27 AM Changeset in webkit [216664] by jmarcell@apple.com
  • 16 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216463. rdar://problem/32041545

12:27 AM Changeset in webkit [216663] by jmarcell@apple.com
  • 4 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216455. rdar://problem/32053243

12:27 AM Changeset in webkit [216662] by jmarcell@apple.com
  • 8 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216446. rdar://problem/31848689

12:27 AM Changeset in webkit [216661] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.21-branch/Source/WebKit2

Cherry-pick r216442. rdar://problem/32051789

12:27 AM Changeset in webkit [216660] by jmarcell@apple.com
  • 4 edits in branches/safari-604.1.21-branch/Source

Cherry-pick r216436. rdar://problem/32041544

12:27 AM Changeset in webkit [216659] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216331. rdar://problem/31122612

12:27 AM Changeset in webkit [216658] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-604.1.21-branch

Cherry-pick r216307. rdar://problem/31955660

12:27 AM Changeset in webkit [216657] by jmarcell@apple.com
  • 4 edits in branches/safari-604.1.21-branch

Cherry-pick r216292. rdar://problem/32027327

12:27 AM Changeset in webkit [216656] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Source/WebCore

Cherry-pick r216285. rdar://problem/32041544

12:27 AM Changeset in webkit [216655] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/Tools

Cherry-pick r216272. rdar://problem/32027327

12:27 AM Changeset in webkit [216654] by jmarcell@apple.com
  • 4 edits in branches/safari-604.1.21-branch

Cherry-pick r216258. rdar://problem/32017975

12:27 AM Changeset in webkit [216653] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.21-branch/LayoutTests

Cherry-pick r216252. rdar://problem/32040952

May 10, 2017:

9:53 PM Changeset in webkit [216652] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Null deref in WebPage::dictionaryPopupInfoForRange
https://bugs.webkit.org/show_bug.cgi?id=171959
<rdar://problem/20886282>

Reviewed by Beth Dakin.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::dictionaryPopupInfoForRange):
Speculative fix for non-reproducible crash when the startContainer of
the range is in an anonymous node.

9:23 PM Changeset in webkit [216651] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Another build fix after r215633 to make the bar graphs render even when the confidence intervals aren't available.

  • public/v3/components/bar-graph-group.js:

(BarGraphGroup.prototype._computeRange):

9:22 PM Changeset in webkit [216650] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[MediaStream] CoreAudioCaptureSource claims to never be muted
https://bugs.webkit.org/show_bug.cgi?id=171946
<rdar://problem/32111991>

Reviewed by Jer Noble.

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioCaptureSource::stopProducingData): Set m_muted to true.

9:06 PM Changeset in webkit [216649] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Build fix after r215633.

  • public/v3/models/test-group.js:

(TestGroup.prototype._computeRequestedCommitSets):
(TestGroup.prototype.requestsForCommitSet):

7:58 PM Changeset in webkit [216648] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.3.1

Tag Safari-603.3.1.

7:32 PM Changeset in webkit [216647] by rniwa@webkit.org
  • 12 edits
    2 adds in trunk/Websites/perf.webkit.org

Add API to upload a patched build for a custom A/B testing
https://bugs.webkit.org/show_bug.cgi?id=171956

Reviewed by Chris Dumez.

Added /api/upload-root to upload a root file, the build product of a patch associated with a commit set.

Extracted more functions out of privileged-api/upload-file.php to uploaded-file-helpers.php to share code
with /api/upload-root.php.

  • public/api/upload-root.php: Added.

(main):
(compute_commit_set_items_to_update): Find the list of commit set items to associate this root with.
A root can be associated with multiple repositories and there fore commit set items; e.g. if a software
is built from multiple repositories and there is a patch associated with one of them, the built product
must be associated with all those repositories.

  • public/include/build-requests-fetcher.php:

(BuildRequestsFetcher::fetch_commits_for_set_if_needed): Include the root file is there is one.

  • public/include/json-header.php:

(validate_arguments): Added the support for validating json string.
(verify_slave): Return the slave ID found.

  • public/include/uploaded-file-helpers.php:

(validate_uploaded_file): Extracted from /privileged-api/upload-file to be shared with /api/upload-root.
(query_total_file_size): Ditto.
(create_uploaded_file_from_form_data): Ditto.
(upload_file_in_transaction): Ditto. Takes a lambda to do the extra work inside the transaction.

  • public/privileged-api/upload-file.php:

(main):

  • public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Resolve the rootFIle of each commit set item.

  • public/v3/models/commit-set.js:

(CommitSet): Added _repositoryToRootMap and _allRootFiles as instance variables.
(CommitSet.prototype.updateSingleton): Added. Previously, each commit set's states never changed after
its creation. After this patch, each item can be newly associated with a root so we must update its
_repositoryToRootMap and _allRootFiles. For simplicity, we update all states.
(CommitSet.prototype._updateFromObject): Extracted from the constructor.
(CommitSet.prototype.allRootFiles): Added. Includes custom roots and roots created for patches.
(CommitSet.prototype.rootForRepository): Added.
(CommitSet.prototype.equals): Fixed the bug that we were comparing _repositoryToPatchMap to
_repositoryToCommitMap, and added a check for _repositoryToRootMap.

  • public/v3/models/test-group.js:

(TestGroup.prototype.task): Added.
(TestGroup.createWithTask):
(TestGroup.createWithCustomConfiguration):
(TestGroup.createAndRefetchTestGroups):
(TestGroup._fetchTestGroupsForTask): Deleted. Now fetchForTask takes a boolean argument: ignoreCache.
(TestGroup.findAllByTask): Added.
(TestGroup.fetchForTask): Renamed from fetchByTask.

  • public/v3/pages/analysis-task-page.js:

(AnalysisTaskPage.prototype._fetchRelatedInfoForTaskId):

  • server-tests/api-build-requests-tests.js:
  • server-tests/api-upload-root-tests.js: Added. Added tests for /api/upload-root.

(makeReport): Added.
(addSlaveAndCreateRootFile): Added.
(createTestGroupWihPatch): Added.

  • server-tests/privileged-api-create-test-group-tests.js:
  • server-tests/resources/mock-data.js:

(MockData.sharedRepositoryId): Added.
(MockData.addMockData): Added "Shared" repository along with commits.

7:26 PM Changeset in webkit [216646] by rniwa@webkit.org
  • 1 edit
    1 add
    1 delete in trunk/Websites/perf.webkit.org

Rename server-tests/api-update-triggerable.js to server-tests/api-update-triggerable-tests.js
https://bugs.webkit.org/show_bug.cgi?id=171905

Reviewed by Chris Dumez.

  • server-tests/api-update-triggerable-tests.js: Renamed from server-tests/api-update-triggerable.js.
6:51 PM Changeset in webkit [216645] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711

Reviewed by Youenn Fablet.

Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.

  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):

5:56 PM Changeset in webkit [216644] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked fast/animation/request-animation-frame-time-unit.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171957

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
5:33 PM Changeset in webkit [216643] by aestes@apple.com
  • 8 edits in trunk

REGRESSION (r167845): ASSERT(!m_renderView.needsLayout()) in svg/custom/bug79798.html
https://bugs.webkit.org/show_bug.cgi?id=132297

Reviewed by Simon Fraser.

Source/WebCore:

We don't know why m_renderView needs layout in this case, but we know that we don't need to
assert if the client hasn't set the ScrollableInnerFrameTrigger compositing trigger.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForScrollableFrame):

LayoutTests:

  • http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
  • http/tests/navigation/resources/keyboard-events-test.js:

(runTest):

  • platform/ios-wk2/TestExpectations:
  • platform/wk2/TestExpectations:
5:32 PM Changeset in webkit [216642] by Ryan Haddad
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r216630.

This change caused assertion failures with webrtc LayoutTests.

Reverted changeset:

"RELEASE_ASSERT at
WebAudioSourceProviderAVFObjC::provideInput()"
https://bugs.webkit.org/show_bug.cgi?id=171711
http://trac.webkit.org/changeset/216630

5:29 PM Changeset in webkit [216641] by weinig@apple.com
  • 63 edits
    11 deletes in trunk

Remove support for legacy Notifications
https://bugs.webkit.org/show_bug.cgi?id=171487

Reviewed by Jon Lee.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Remove files.

  • Configurations/FeatureDefines.xcconfig:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

  • DerivedSources.make:

Remove IDL files.

  • Modules/notifications/DOMWindowNotifications.cpp: Removed.
  • Modules/notifications/DOMWindowNotifications.h: Removed.
  • Modules/notifications/DOMWindowNotifications.idl: Removed.
  • Modules/notifications/NotificationCenter.cpp: Removed.
  • Modules/notifications/NotificationCenter.h: Removed.
  • Modules/notifications/NotificationCenter.idl: Removed.
  • Modules/notifications/NotificationClient.h:
  • Modules/notifications/NotificationController.cpp:
  • Modules/notifications/NotificationController.h:
  • Modules/notifications/WorkerGlobalScopeNotifications.cpp: Removed.
  • Modules/notifications/WorkerGlobalScopeNotifications.h: Removed.
  • Modules/notifications/WorkerGlobalScopeNotifications.idl: Removed.
  • Modules/notifications/Notification.idl:
  • Modules/notifications/Notification.cpp:
  • Modules/notifications/Notification.h:
  • dom/EventTargetFactory.in:
  • page/DOMWindow.cpp:
  • workers/WorkerThread.h:

Remove code legacy Notification code. Replace use of NotificationCenter with direct
calls to the NotificationClient.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebNotificationClient.mm:
  • WebView/WebNotification.mm:
  • WebView/WebNotificationInternal.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _notificationIDForTesting:]):
Remove legacy notification specific code.

Source/WebKit/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::WebChromeClient):

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
  • WebCoreSupport/WebDesktopNotificationsDelegate.h:

Remove legacy notification specific code.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/WebProcessCreationParameters.cpp:
  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebProcessPool.cpp:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
  • WebProcess/Notifications/NotificationPermissionRequestManager.h:
  • WebProcess/Notifications/WebNotificationManager.cpp:
  • WebProcess/Notifications/WebNotificationManager.h:
  • WebProcess/WebCoreSupport/WebNotificationClient.cpp:
  • WebProcess/WebCoreSupport/WebNotificationClient.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebProcess.cpp:

Remove legacy notification specific code.

Source/WTF:

  • wtf/FeatureDefines.h:

Remove definition of ENABLE_LEGACY_NOTIFICATIONS.

Tools:

  • DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:

(DRTDesktopNotificationPresenter::checkNotificationPermission):

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Remove use and definition of ENABLE_LEGACY_NOTIFICATIONS.

LayoutTests:

  • Remove fast/notifications/. It was skipped on all platforms and use legacy Notifications API.
  • Remove http/notifications/legacy. It tested the legacy API.
  • Update two tests in fast/history to use the non-legacy API to test page cache + notifications.
  • Update TestExpectations for removals.
  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • fast/history/page-cache-notification-non-suspendable.html:
  • fast/history/page-cache-notification-suspendable.html:
  • fast/notifications: Removed.
  • fast/notifications/notification-after-close-expected.txt: Removed.
  • fast/notifications/notification-after-close.html: Removed.
  • fast/notifications/notification-permisssion-deletable-expected.txt: Removed.
  • fast/notifications/notification-permisssion-deletable.html: Removed.
  • fast/notifications/notifications-cancel-request-permission-expected.txt: Removed.
  • fast/notifications/notifications-cancel-request-permission.html: Removed.
  • fast/notifications/notifications-check-permission-expected.txt: Removed.
  • fast/notifications/notifications-check-permission.html: Removed.
  • fast/notifications/notifications-click-event-expected.txt: Removed.
  • fast/notifications/notifications-click-event-focus-expected.txt: Removed.
  • fast/notifications/notifications-click-event-focus.html: Removed.
  • fast/notifications/notifications-click-event.html: Removed.
  • fast/notifications/notifications-constructor-request-permission-expected.txt: Removed.
  • fast/notifications/notifications-constructor-request-permission.html: Removed.
  • fast/notifications/notifications-constructor-with-permission-expected.txt: Removed.
  • fast/notifications/notifications-constructor-with-permission.html: Removed.
  • fast/notifications/notifications-constructor-without-permission-expected.txt: Removed.
  • fast/notifications/notifications-constructor-without-permission.html: Removed.
  • fast/notifications/notifications-display-close-events-expected.txt: Removed.
  • fast/notifications/notifications-display-close-events.html: Removed.
  • fast/notifications/notifications-document-close-crash-expected.txt: Removed.
  • fast/notifications/notifications-document-close-crash.html: Removed.
  • fast/notifications/notifications-event-stop-propagation-expected.txt: Removed.
  • fast/notifications/notifications-event-stop-propagation.html: Removed.
  • fast/notifications/notifications-multi-events-expected.txt: Removed.
  • fast/notifications/notifications-multi-events.html: Removed.
  • fast/notifications/notifications-no-icon-expected.txt: Removed.
  • fast/notifications/notifications-no-icon.html: Removed.
  • fast/notifications/notifications-permission-expected.txt: Removed.
  • fast/notifications/notifications-permission.html: Removed.
  • fast/notifications/notifications-replace-expected.txt: Removed.
  • fast/notifications/notifications-replace.html: Removed.
  • fast/notifications/notifications-request-permission-expected.txt: Removed.
  • fast/notifications/notifications-request-permission-optional-expected.txt: Removed.
  • fast/notifications/notifications-request-permission-optional.html: Removed.
  • fast/notifications/notifications-request-permission.html: Removed.
  • fast/notifications/notifications-rtl-expected.txt: Removed.
  • fast/notifications/notifications-rtl.html: Removed.
  • fast/notifications/notifications-sandbox-permission-expected.txt: Removed.
  • fast/notifications/notifications-sandbox-permission.html: Removed.
  • fast/notifications/notifications-window-close-crash-expected.txt: Removed.
  • fast/notifications/notifications-window-close-crash.html: Removed.
  • fast/notifications/notifications-with-permission-expected.txt: Removed.
  • fast/notifications/notifications-with-permission.html: Removed.
  • fast/notifications/notifications-without-permission-expected.txt: Removed.
  • fast/notifications/notifications-without-permission.html: Removed.
  • fast/notifications/request-notification-permission-while-reloading-expected.txt: Removed.
  • fast/notifications/request-notification-permission-while-reloading.html: Removed.
  • fast/notifications/resources: Removed.
  • fast/notifications/resources/notifications-cancel-request-permission.html: Removed.
  • fast/notifications/resources/notifications-iframe.html: Removed.
  • http/tests/notifications/legacy: Removed.
  • http/tests/notifications/legacy/double-show-expected.txt: Removed.
  • http/tests/notifications/legacy/double-show.html: Removed.
  • http/tests/notifications/legacy/events-expected.txt: Removed.
  • http/tests/notifications/legacy/events.html: Removed.
  • http/tests/notifications/legacy/notification-request-permission-then-navigate-expected.txt: Removed.
  • http/tests/notifications/legacy/notification-request-permission-then-navigate.html: Removed.
  • http/tests/notifications/legacy/request-expected.txt: Removed.
  • http/tests/notifications/legacy/request-no-callback-expected.txt: Removed.
  • http/tests/notifications/legacy/request-no-callback.html: Removed.
  • http/tests/notifications/legacy/request.html: Removed.
  • http/tests/notifications/legacy/resources: Removed.
  • http/tests/notifications/legacy/resources/notify-opener-done.html: Removed.
  • http/tests/notifications/legacy/resources/request-permission-then-navigate.html: Removed.
  • http/tests/notifications/legacy/show-expected.txt: Removed.
  • http/tests/notifications/legacy/show.html: Removed.
  • http/tests/notifications/legacy/window-show-on-click-expected.txt: Removed.
  • http/tests/notifications/legacy/window-show-on-click.html: Removed.
5:25 PM Changeset in webkit [216640] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=169876

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:20 PM Changeset in webkit [216639] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark inspector/protocol/inspector-backend-invocation-return-value.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168146

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:48 PM Changeset in webkit [216638] by mark.lam@apple.com
  • 10 edits in trunk

Unreviewed, rolling out r216635.
https://bugs.webkit.org/show_bug.cgi?id=171953

"Some worker tests are failing". (Requested by mlam on #webkit).

Reverted changeset:

"WorkerThread::stop() should call
scheduleExecutionTermination() last."
https://bugs.webkit.org/show_bug.cgi?id=171775
http://trac.webkit.org/changeset/216635

Patch by Commit Queue <commit-queue@webkit.org> on 2017-05-10

4:43 PM Changeset in webkit [216637] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>

Not reviewed.

Updated a comment per Geoff's suggestion.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStack):

4:39 PM Changeset in webkit [216636] by matthew_hanson@apple.com
  • 8 edits in branches/safari-603-branch/Source

Cherry-pick r214320. rdar://problem/32057095

4:22 PM Changeset in webkit [216635] by mark.lam@apple.com
  • 10 edits in trunk

WorkerThread::stop() should call scheduleExecutionTermination() last.
https://bugs.webkit.org/show_bug.cgi?id=171775
<rdar://problem/30975761>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Increased the number of frames captured in VM::nativeStackTraceOfLastThrow()
from 25 to 100. From experience, I found that 25 is sometimes not sufficient
for our debugging needs.

Also added VM::throwingThread() to track which thread an exception was thrown in.
This may be useful if the client is entering the VM from different threads.

  • runtime/ExceptionScope.cpp:

(JSC::ExceptionScope::unexpectedExceptionMessage):
(JSC::ExceptionScope::releaseAssertIsTerminatedExecutionException):

  • runtime/ExceptionScope.h:

(JSC::ExceptionScope::exception):
(JSC::ExceptionScope::unexpectedExceptionMessage):

  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/VM.h:

(JSC::VM::throwingThread):
(JSC::VM::clearException):

Source/WebCore:

Currently, WorkerThread::stop() calls scheduleExecutionTermination() to terminate
JS execution first, followed by posting a cleanup task to the worker, and lastly,
it invokes terminate() on the WorkerRunLoop.

As a result, before run loop is terminate, the worker thread may observe the
TerminatedExecutionException in JS code, bail out, see another JS task to run,
re-enters the VM to run said JS code, and fails with an assertion due to the
TerminatedExecutionException still being pending on VM entry.

WorkerRunLoop::Task::performTask() already has a check to only allow a task to
run if and only if !runLoop.terminated() and the task is not a clean up task.
We'll fix the above race by ensuring that having WorkerThread::stop() terminate
the run loop before it scheduleExecutionTermination() which throws the
TerminatedExecutionException. This way, by the time JS code unwinds out of the
VM due to the TerminatedExecutionException, runLoop.terminated() is guaranteed
to be true and thereby prevents re-entry into the VM.

This issue is covered by an existing test that I just unskipped in TestExpectations.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::stop):

LayoutTests:

4:05 PM Changeset in webkit [216634] by timothy_horton@apple.com
  • 12 edits in trunk

Add an experimental feature flag for viewport-fit
https://bugs.webkit.org/show_bug.cgi?id=171948
<rdar://problem/31995518>

Reviewed by Simon Fraser.

  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.

  • dom/ViewportArguments.cpp:

(WebCore::setViewportFeature):

  • page/Settings.in:

Disable parsing of viewport-fit if the experimental feature is disabled.

  • fast/css/variables/constants/ios/safe-area-inset-set-expected.html:
  • fast/css/variables/constants/ios/safe-area-inset-set.html:
  • fast/viewport/ios/viewport-fit-auto.html:
  • fast/viewport/ios/viewport-fit-contain.html:
  • fast/viewport/ios/viewport-fit-cover.html:
3:57 PM Changeset in webkit [216633] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked fast/hidpi/filters-and-image-buffer-resolution.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171951

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
3:25 PM Changeset in webkit [216632] by Chris Dumez
  • 19 edits in trunk/Source

Simplify relationship between Attr and Element now that Attr is childless
https://bugs.webkit.org/show_bug.cgi?id=171909

Reviewed by Ryosuke Niwa.

Source/WebCore:

Simplify relationship between Attr and Element now that Attr is childless
after r216259.

No new tests, no Web facing behavior change.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
Attr::setValue() was only called by Element::setAttributeInternal() to make sure
we updated the Attr node's Text child. However, now that Attr has no Text child,
Element no longer needs to update the Attr node's value.
Attr::setValueForBindings() was thus renamed to setValue(). Its implementation
was also simplified by calling Element::setAttribute() on its ownerElement, if
it has one, instead of duplicating a bunch of code from Element::setAttributeInternal().

(WebCore::Attr::setNodeValue):
Call setValue() instead of setValueForBindings() now that it has been renamed.

  • dom/Attr.h:
  • dom/Attr.idl:

Rename valueForBindings / setValueForBindings to value / setValue.

  • dom/Document.h:

Split shouldInvalidateNodeListAndCollectionCaches() into 2 methods, one taking an Attr name
and another that does not. There are now 2 calls sites instead of one, so we no longer need
to branch in this function.

  • dom/Element.cpp:

(WebCore::Element::setAttributeInternal):
Drop code calling Attr::setValue() on the Attr node since Attr::setValue() was only
duplicating logic from Element::setAttributeInternal() after r216259. There is nothing
on Attr that needs updating when an element attribute gets updated.

(WebCore::Element::attributeChanged):
Call the new invalidateNodeListAndCollectionCachesInAncestorsForAttribute(). This
is the only call site that passes an attribute name.

  • dom/Node.cpp:

(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCachesForAttribute):
Split into 2 to avoid branching, as explained above.

(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestorsForAttribute):

  • invalidateNodeListAndCollectionCachesInAncestors() used to invalidate childNodeLists if the Node was an attribute node. Drop this as this is no longer needed as of r216259.
  • After the change to Attr::setValue(), call sites for invalidateNodeListAndCollectionCachesInAncestors() either had no parameters, or both parameters present and non-null. There is therefore no longer any need to handle having an attrName but no attributeOwnerElement. To make this obvious, I split this into 2 methods: invalidateNodeListAndCollectionCachesInAncestors() and invalidateNodeListAndCollectionCachesInAncestorsForAttribute(attrName). We no longer need the attributeOwnerElement parameter as it was only used to exit early.
  • dom/Node.h:

Source/WebKit/mac:

Build fix.

  • DOM/DOMAttr.mm:

(-[DOMAttr value]):
(-[DOMAttr setValue:]):

3:23 PM Changeset in webkit [216631] by Antti Koivisto
  • 6 edits
    2 adds in trunk

REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>

Reviewed by Simon Fraser.

Source/WebCore:

The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.

Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

  • rendering/RenderElement.h:

(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

  • animations/animation-initial-inheritance-expected.html: Added.
  • animations/animation-initial-inheritance.html: Added.
3:03 PM Changeset in webkit [216630] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

RELEASE_ASSERT at WebAudioSourceProviderAVFObjC::provideInput()
https://bugs.webkit.org/show_bug.cgi?id=171711

Reviewed by Youenn Fablet.

Before iterating over the channels in either the WebAudioBufferList or the AudioBus, ensure
we don't walk over the end of either by only iterating over the minimum length of either.
Also, when the internal format of WebAudioSourceProviderAVFObjC changes, notify the
MediaStreamAudioSourceNode that the number of channels and sample rate have changed.

  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::prepare):

3:01 PM Changeset in webkit [216629] by BJ Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: in Timelines > JavaScript & Events, digits for timer and animation frame number are not localized
https://bugs.webkit.org/show_bug.cgi?id=171818

Reviewed by Joseph Pecoraro.

These numbers need to be formatted with %d, not %s.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName):

2:59 PM Changeset in webkit [216628] by BJ Burg
  • 10 edits in trunk/Source/WebInspectorUI

Web Inspector: remove dead code for switching Toolbar display options
https://bugs.webkit.org/show_bug.cgi?id=170738

Reviewed by Joseph Pecoraro.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):

  • UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button > .glyph):
(.toolbar .item.button > .label):
(.toolbar.icon-and-label-vertical .item.button): Deleted.
(.toolbar.icon-and-label-horizontal .item.button): Deleted.
(.toolbar.small-size .item.button > .glyph): Deleted.
(.toolbar.label-only .item.button > .glyph): Deleted.
(.toolbar.label-only .item.activate.button.activated > .label): Deleted.
(.toolbar.icon-and-label-horizontal .item.button > .label): Deleted.
(.toolbar.icon-only .item.button > .label): Deleted.

  • UserInterface/Views/ControlToolbarItem.css:

(.toolbar .item.control):
(.toolbar:matches(.icon-and-label-horizontal, .icon-only) .item.control): Deleted.

  • UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
(.toolbar.icon-and-label-vertical:matches(.small-size, .normal-size) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard-container): Deleted.
(.toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=ltr] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.
(body[dir=rtl] .toolbar.label-only .dashboard-container .advance-arrow): Deleted.

  • UserInterface/Views/DefaultDashboardView.css:

(.toolbar .dashboard.default > .item):
(.toolbar.label-only .dashboard.default > .item,): Deleted.
(.toolbar.normal-size:matches(.icon-only, .icon-and-label-vertical, .icon-and-label-horizontal) .dashboard.default > .item): Deleted.

  • UserInterface/Views/ReplayDashboardView.css:

(.toolbar .dashboard.replay .item.button > .glyph):
(.toolbar.label-only .dashboard.replay .item.button > .glyph): Deleted.

  • UserInterface/Views/Toolbar.css:

(.toolbar .control-section):
(.toolbar:matches(.icon-and-label-horizontal.small-size, .icon-only.small-size, .label-only) .control-section): Deleted.

  • UserInterface/Views/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype.layout):
(WebInspector.Toolbar.prototype.get displayMode): Deleted.
(WebInspector.Toolbar.prototype.set displayMode): Deleted.
(WebInspector.Toolbar.prototype.get sizeMode): Deleted.
(WebInspector.Toolbar.prototype.set sizeMode): Deleted.
(WebInspector.Toolbar.prototype._handleContextMenuEvent): Deleted.
(WebInspector.Toolbar.prototype._changeDisplayMode): Deleted.
(WebInspector.Toolbar.prototype._toggleSmallIcons): Deleted.

2:59 PM Changeset in webkit [216627] by matthew_hanson@apple.com
  • 1 edit in branches/safari-603-branch/Source/WebCore/ChangeLog

Fix order of merge from r212528. rdar://problem/31153819

2:59 PM Changeset in webkit [216626] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Fix order of merge from r212528

2:57 PM Changeset in webkit [216625] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

GCController.cpp's collect() should be Async
https://bugs.webkit.org/show_bug.cgi?id=171708

Reviewed by Saam Barati and Geoffrey Garen.

No new tests because no change in behavior.

This is one step towards not requesting sync GCs in WebCore. I'm landing this incrementally to
make bisecting super easy.

This is a ~7% JetStream iOS "regression", because JetStream has a bug where it allows trunk
to sneakily hide GC work between when JetStream measures time. After this change, we are no
longer trying to be sneaky.

  • bindings/js/GCController.cpp:

(WebCore::collect):

2:34 PM Changeset in webkit [216624] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked transitions/extra-transition.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171947

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:31 PM Changeset in webkit [216623] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

CoreAudioCaptureSource reports 3 or 5 channel audio output; actually only mono
https://bugs.webkit.org/show_bug.cgi?id=171940

Reviewed by Eric Carlson.

Asking for the Input VPIO stream format will return the internal mic format, before processing. Instead
ask for the input bus's output format, which is post processing, which will return the correct number
of channels (one).

  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::configureMicrophoneProc):

2:23 PM Changeset in webkit [216622] by matthew_hanson@apple.com
  • 23 edits in branches/safari-603-branch/Source

Additional ENABLE_STREAMS cleanup

2:23 PM Changeset in webkit [216621] by matthew_hanson@apple.com
  • 46 edits in branches/safari-603-branch

Cherry-pick r215429. rdar://problem/32057106

2:23 PM Changeset in webkit [216620] by matthew_hanson@apple.com
  • 10 edits in branches/safari-603-branch

Cherry-pick r215250. rdar://problem/32057106

2:14 PM Changeset in webkit [216619] by Ryan Haddad
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r216591.

This change broke an internal build.

Reverted changeset:

"REGRESSION (r207372) Visibility property is not inherited
when used in an animation"
https://bugs.webkit.org/show_bug.cgi?id=171883
http://trac.webkit.org/changeset/216591

2:11 PM Changeset in webkit [216618] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed, remove TestExpectation for a test that was removed in r216259.

  • platform/mac/TestExpectations:
2:02 PM Changeset in webkit [216617] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked perf/class-list-remove.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171945

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
1:52 PM Changeset in webkit [216616] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Include headers in WebKit.h
https://bugs.webkit.org/show_bug.cgi?id=171943

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WebKit.h:
1:50 PM Changeset in webkit [216615] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Drop custom bindings code now window.open()
https://bugs.webkit.org/show_bug.cgi?id=171933

Reviewed by Geoffrey Garen.

Drop custom bindings code now window.open() as it is not doing anything special.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::open): Deleted.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

1:44 PM Changeset in webkit [216614] by aestes@apple.com
  • 3 edits in trunk/LayoutTests

r216599 accidentally included two copies of the new layout test and expected result
https://bugs.webkit.org/show_bug.cgi?id=171938

Unreviewed.

  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt:
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html:
1:41 PM Changeset in webkit [216613] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=171880

Unreviewed test gardening.

This test times out on ios-simulator because it relies on eventSender.keyDown.

  • platform/ios/TestExpectations:
1:29 PM Changeset in webkit [216612] by timothy_horton@apple.com
  • 16 edits in trunk/Source/WebKit2

Disable block selection for dynamic selection granularity
https://bugs.webkit.org/show_bug.cgi?id=171908
<rdar://problem/32098024>

Reviewed by Enrica Casucci.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsBlockSelection]):
(-[WKWebViewConfiguration _setAllowsBlockSelection:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:

Add a private configuration parameter to re-enable block selection.

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsBlockSelection]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/Cocoa/VersionChecks.h:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::creationParameters):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::allowsBlockSelection):

  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

Plumb allowsBlockSelection through from WKWebViewConfiguration to WebPage.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView useSelectionAssistantWithGranularity:]):
(-[WKContentView _startAssistingKeyboard]):
(-[WKContentView _stopAssistingKeyboard]):
(toUIWebSelectionMode): Deleted.
(-[WKContentView useSelectionAssistantWithMode:]): Deleted.
Stop needlessly converting to UIWebSelectionMode.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::shouldSwitchToBlockModeForHandle):
Don't switch to block selection unless allowsBlockSelection is set.

1:26 PM Changeset in webkit [216611] by timothy_horton@apple.com
  • 16 edits in trunk

Add an experimental feature flag for constant properties
https://bugs.webkit.org/show_bug.cgi?id=171913
<rdar://problem/31995518>

Reviewed by Ryosuke Niwa.

  • css/parser/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):

  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeCustomPropertyValue):

  • css/parser/CSSParserMode.h:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseValueStart):

  • css/parser/CSSVariableParser.cpp:

(WebCore::classifyBlock):
(WebCore::isValidVariableReference):
(WebCore::isValidConstantReference):
(WebCore::classifyVariableRange):
(WebCore::CSSVariableParser::containsValidVariableReferences):
(WebCore::CSSVariableParser::parseDeclarationValue):

  • css/parser/CSSVariableParser.h:

Plumb the experimental feature flag down into CSSVariableParser by way
of CSSParserContext.

  • page/Settings.in:
  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add an experimental feature flag.

  • fast/css/variables/constants/invalid-constant-name-fallback.html:
  • fast/css/variables/constants/ios/safe-area-inset-set.html:
  • fast/css/variables/constants/safe-area-inset-cannot-override.html:
  • fast/css/variables/constants/safe-area-inset-zero.html:
1:16 PM Changeset in webkit [216610] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Disable WebGL2 by default
https://bugs.webkit.org/show_bug.cgi?id=171894
<rdar://problem/32089917>

Reviewed by Tim Horton.

Some WASM and WebGL2 content is failing because it
detects our WebGL2RenderingContext, but doesn't realise
that we don't implement enough of it to be useful.

  • Shared/WebPreferencesDefinitions.h:
1:07 PM Changeset in webkit [216609] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/track/track-cue-rendering-on-resize.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171939

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:07 PM Changeset in webkit [216608] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash in JavaScriptCore GC when using JSC on dispatch queues (thread_get_state returns NULL stack pointer).
https://bugs.webkit.org/show_bug.cgi?id=160337
<rdar://problem/27611733>

Reviewed by Filip Pizlo and Geoffrey Garen.

This is a workaround for <rdar://problem/27607384>. During thread initialization,
for some target platforms, thread state is momentarily set to 0 before being
filled in with the target thread's real register values. As a result, there's
a race condition that may result in us getting a null stackPointer during a GC scan.
This issue may manifest with workqueue threads where the OS may choose to recycle
a thread for an expired task.

The workaround is simply to indicate that there's nothing to copy and return.
This is correct because we will only ever observe a null pointer during thread
initialization. Hence, by definition, there's nothing there that we need to scan
yet, and therefore, nothing that needs to be copied.

  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::tryCopyOtherThreadStack):

12:52 PM Changeset in webkit [216607] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

REGRESSION (r206960): Possible null pointer dereference under DOMSelection::getRangeAt()
https://bugs.webkit.org/show_bug.cgi?id=171925
<rdar://problem/29931223>

Reviewed by Wenson Hsieh.

We have evidence that selection().firstRange() can return null in DOMSelection::getRangeAt().
When this happens, we now throw an INDEX_SIZE_ERR instead of dereferencing it.

I believe this can happen if the VisibleSelection is orphaned but not none, because
rangeCount() only checks for isNone() but VisibleSelection::firstRange() can return null
if isNoneOrOrphaned().

No new tests, I do not know how to reproduce.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::getRangeAt):

12:41 PM Changeset in webkit [216606] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/dom/nodes/ParentNode-querySelector-All tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171937

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
12:34 PM Changeset in webkit [216605] by Ryan Haddad
  • 2 edits in branches/safari-603-branch/LayoutTests

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
12:29 PM Changeset in webkit [216604] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked tiled-drawing/scrolling/fast-scroll-select-latched-mainframe.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171935

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:24 PM Changeset in webkit [216603] by mrajca@apple.com
  • 2 edits in trunk/Source/WebCore

DumpRenderTree crashed in com.apple.WebCore: std::optional<WTF::MediaTime>::operator-> + 71 :: CRASHING TEST: fullscreen/video-controls-timeline.html
https://bugs.webkit.org/show_bug.cgi?id=171932

Reviewed by Eric Carlson.

Explicitly initialize m_playbackWithoutUserGesture to "None".

  • html/HTMLMediaElement.h:
11:53 AM Changeset in webkit [216602] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Copy to clipboard fails via InspectorFrontendHostStub
https://bugs.webkit.org/show_bug.cgi?id=171907

Patch by Ross Kirsling <Ross Kirsling> on 2017-05-10
Reviewed by Joseph Pecoraro.

  • UserInterface/Base/InspectorFrontendHostStub.js:

(WebInspector.InspectorFrontendHostStub.prototype.copyText):
Actually make a text selection before attempting to copy to clipboard.

11:43 AM Changeset in webkit [216601] by matthew_hanson@apple.com
  • 11 edits
    7 adds in branches/safari-603-branch

Cherry-pick r216352. rdar://problem/32057098

11:43 AM Changeset in webkit [216600] by matthew_hanson@apple.com
  • 16 edits
    6 adds in branches/safari-603-branch

Cherry-pick r211379. rdar://problem/32057099

11:30 AM Changeset in webkit [216599] by aestes@apple.com
  • 8 edits
    2 adds in trunk

Keyboard input suppression should extend to subframes
https://bugs.webkit.org/show_bug.cgi?id=171880
<rdar://problem/31201793>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html

  • dom/EventDispatcher.cpp:

(WebCore::shouldSuppressEventDispatchInDOM): Changed to call shouldSuppressKeyboardInput()
on the main frame's loader.

  • editing/Editor.cpp:

(WebCore::Editor::shouldInsertText): Ditto.

LayoutTests:

  • http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt:
  • http/tests/navigation/keyboard-events-during-provisional-navigation.html:
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation-expected.txt: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt.
  • http/tests/navigation/keyboard-events-during-provisional-subframe-navigation.html: Copied from LayoutTests/http/tests/navigation/keyboard-events-during-provisional-navigation.html.
  • http/tests/navigation/resources/keyboard-events-after-navigation.html:
  • http/tests/navigation/resources/keyboard-events-test.js:

(runTest):
(waitForProvisionalNavigation.xhr.onreadystatechange):
(waitForProvisionalNavigation):

11:22 AM Changeset in webkit [216598] by jfbastien@apple.com
  • 3 edits
    1 add in trunk/JSTests

WebAssemby: builder doesn't do Memory section maximum correctly
https://bugs.webkit.org/show_bug.cgi?id=171931

Reviewed by Keith Miller.

  • wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.const.section.in.WASM.description.section.switch.section.case.string_appeared_here.this.section):

  • wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Memory):

  • wasm/function-tests/memory-grow-invalid.js: Added.
11:15 AM Changeset in webkit [216597] by jfbastien@apple.com
  • 19 edits
    4 copies
    3 adds in trunk

WebAssembly: support name section
JSTests:

https://bugs.webkit.org/show_bug.cgi?id=171263

Reviewed by Keith Miller.

  • wasm/function-tests/nameSection.js: Added.

(const.compile):

  • wasm/function-tests/nameSection.wasm: Added.
  • wasm/function-tests/stack-trace.js: Update format

Source/JavaScriptCore:

https://bugs.webkit.org/show_bug.cgi?id=171263

Reviewed by Keith Miller.

The name section is an optional custom section in the WebAssembly
spec. At least when debugging, developers expect to be able to use
this section to obtain intelligible stack traces, otherwise we
just number the wasm functions which is somewhat painful.

This patch parses this section, dropping its content eagerly on
error, and if there is a name section then backtraces use their
value instead of numbers. Otherwise we stick to numbers as before.

Note that the format of name sections changed in mid-February:

https://github.com/WebAssembly/design/pull/984

And binaryen was only updated in early March:

https://github.com/WebAssembly/binaryen/pull/933

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • interpreter/Interpreter.cpp:

(JSC::GetStackTraceFunctor::operator()):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readNonInlinedFrame):
(JSC::StackVisitor::Frame::functionName):

  • interpreter/StackVisitor.h:

(JSC::StackVisitor::Frame::wasmFunctionIndexOrName):

  • runtime/StackFrame.cpp:

(JSC::StackFrame::functionName):

  • runtime/StackFrame.h:

(JSC::StackFrame::StackFrame):
(JSC::StackFrame::wasm):

  • wasm/WasmBBQPlanInlines.h:

(JSC::Wasm::BBQPlan::initializeCallees):

  • wasm/WasmCallee.cpp:

(JSC::Wasm::Callee::Callee):

  • wasm/WasmCallee.h:

(JSC::Wasm::Callee::create):
(JSC::Wasm::Callee::indexOrName):

  • wasm/WasmFormat.cpp:

(JSC::Wasm::makeString):

  • wasm/WasmFormat.h:

(JSC::Wasm::isValidExternalKind):
(JSC::Wasm::isValidNameType):
(JSC::Wasm::NameSection::get):

  • wasm/WasmIndexOrName.cpp: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.

(JSC::Wasm::IndexOrName::IndexOrName):
(JSC::Wasm::makeString):

  • wasm/WasmIndexOrName.h: Copied from Source/JavaScriptCore/wasm/WasmFormat.cpp.
  • wasm/WasmModuleInformation.h:
  • wasm/WasmModuleParser.cpp:
  • wasm/WasmName.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.
  • wasm/WasmNameSectionParser.cpp: Added.
  • wasm/WasmNameSectionParser.h: Copied from Source/JavaScriptCore/wasm/WasmCallee.cpp.

(JSC::Wasm::NameSectionParser::NameSectionParser):

  • wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

  • wasm/WasmParser.h:

(JSC::Wasm::Parser<SuccessType>::consumeUTF8String):

10:30 AM Changeset in webkit [216596] by Matt Lewis
  • 26 edits
    2 deletes in trunk

Unreviewed, rolling out r216563.

Revision caused 2 api failures

Reverted changeset:

"[MediaStream] deviceId constraint doesn't work with
getUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=171877
http://trac.webkit.org/changeset/216563

10:29 AM Changeset in webkit [216595] by jmarcell@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r215102. rdar://problem/32057110

10:16 AM Changeset in webkit [216594] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171930

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
10:00 AM Changeset in webkit [216593] by fpizlo@apple.com
  • 3 edits
    3 adds in trunk

Null pointer dereference in WTF::RefPtr<WTF::StringImpl>::operator!() under slow_path_get_direct_pname
https://bugs.webkit.org/show_bug.cgi?id=171801

Reviewed by Michael Saboff.

JSTests:

These tests used to crash. The prefix and postfix tests cover different paths, except
postfix-ignored goes down the same path as prefix due to an optimization.

  • stress/for-in-postfix-ignored-index.js: Added.

(foo):

  • stress/for-in-postfix-index.js: Added.

(foo):

  • stress/for-in-prefix-index.js: Added.

(foo):

Source/JavaScriptCore:

This was a goofy oversight. The for-in optimization relies on the bytecode generator
to detect when the loop's index variable gets mutated. We forgot to have the hooks for
detecting this in prefix and postfix operations (++i and i++).

  • bytecompiler/NodesCodegen.cpp:

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):

9:57 AM Changeset in webkit [216592] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Refactor ScrollingCoordinator::setSynchronousScrollingReasons to accept a FrameView
https://bugs.webkit.org/show_bug.cgi?id=171923

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-10
Reviewed by Simon Fraser.

Currently ScrollingCoordinator::setSynchronousScrollingReasons implementations assumes
SynchronousScrollingReasons apply to the main frame. This commit allows to specify
a FrameView in order to prepare support for fast scrolling of frames.

No new tests, no behavior changes.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::setSynchronousScrollingReasons): Use the FrameView to
find the state node.
(WebCore::AsyncScrollingCoordinator::updateScrollLayerPosition): Rename this function
updateMainFrameScrollLayerPosition and use the specified FrameView.

  • page/scrolling/AsyncScrollingCoordinator.h: Add FrameView parameter.
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons): Remove the const since
AsyncScrollingCoordinator uses scrollLayerForFrameView. Pass the frameView to
setSynchronousScrollingReasons.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::setSynchronousScrollingReasons): Add FrameView parameter.

9:50 AM Changeset in webkit [216591] by Antti Koivisto
  • 6 edits
    2 adds in trunk

REGRESSION (r207372) Visibility property is not inherited when used in an animation
https://bugs.webkit.org/show_bug.cgi?id=171883
<rdar://problem/32086550>

Reviewed by Simon Fraser.

Source/WebCore:

The problem here is that our animation code is tied to renderers. We don't have renderers during
the initial style resolution so animations are not applied yet. When constructing renderers we set
their style to the initial animated style but this step can't implement inheritance.

Normally this is invisible as the first animation frame will immediately inherit the style correctly.
However in this case the animation is discrete and the first frame is the same as the initial state.
With r207372 we optimize the descendant style change away.

This patch fixes the problem by tracking that the renderer has initial animated style and inheriting
it to descendants during next style resolution even if it doesn't change.

Test: animations/animation-initial-inheritance.html

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

  • rendering/RenderElement.h:

(WebCore::RenderElement::hasInitialAnimatedStyle):
(WebCore::RenderElement::setHasInitialAnimatedStyle):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::createRenderer):

Set a bit on renderer indicating it has initial animated style.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Return at least 'Inherit' for style change when updating renderer with initial animated style.

LayoutTests:

  • animations/animation-initial-inheritance-expected.html: Added.
  • animations/animation-initial-inheritance.html: Added.
9:44 AM Changeset in webkit [216590] by matthew_hanson@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Remove inadvertant change to ScrollView.h that was included in r216589.

Unreviewed build fix.

  • platform/ScrollView.h:

(WebCore::ScrollView::children):

9:34 AM Changeset in webkit [216589] by matthew_hanson@apple.com
  • 14 edits
    3 adds in branches/safari-603-branch

Cherry-pick r216279. rdar://problem/31967829

9:29 AM Changeset in webkit [216588] by pvollan@apple.com
  • 3 edits in trunk/LayoutTests

LayoutTest http/tests/media/track-in-band-hls-metadata-crash.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167749

Reviewed by Eric Carlson.

This is a speculative fix of the test. I have not been able to reproduce the timeout.
When the test times out, the 'addtrack' event is never received. In case the event
was dispatched before we added the event listener, the event listener is added before
the video source is set. In case the test will continue to time out, a couple of
error event callbacks have been added to get more information. Also, video playback
will begin when the 'canplaythrough' event is received.

  • http/tests/media/track-in-band-hls-metadata-crash-expected.txt:
  • http/tests/media/track-in-band-hls-metadata-crash.html:
9:08 AM Changeset in webkit [216587] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r216131. rdar://problem/31967895

9:06 AM Changeset in webkit [216586] by mmaxfield@apple.com
  • 4 edits in trunk/Source/WebCore

Tiny cleanup in Font::DerivedFonts
https://bugs.webkit.org/show_bug.cgi?id=171893

Reviewed by Jon Lee.

This variable was written to but never read.

No new tests because there is no behavior change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

  • platform/graphics/Font.cpp:

(WebCore::Font::verticalRightOrientationFont):
(WebCore::Font::uprightOrientationFont):
(WebCore::Font::smallCapsFont):
(WebCore::Font::noSynthesizableFeaturesFont):
(WebCore::Font::emphasisMarkFont):
(WebCore::Font::brokenIdeographFont):
(WebCore::Font::DerivedFonts::~DerivedFonts): Deleted.

  • platform/graphics/Font.h:

(WebCore::Font::DerivedFonts::DerivedFonts): Deleted.

7:50 AM Changeset in webkit [216585] by Michael Catanzaro
  • 4 edits in trunk

Remove user agent quirk for Slack
https://bugs.webkit.org/show_bug.cgi?id=171869

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The user agent quirk for Slack does not seem to be necessary anymore. I am able to use Slack
without difficulty using our default user agent.

  • platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the corresponding test.

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

7:46 AM Changeset in webkit [216584] by Claudio Saavedra
  • 2 edits in trunk/Source/WebKit2

[GTK] HTTP authentication dialog should focus on first input field
https://bugs.webkit.org/show_bug.cgi?id=151349

Reviewed by Michael Catanzaro.

Setting focus on a widget before it's mapped does nothing. Move
the call to the right place.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):
(webkitAuthenticationDialogMap):

7:31 AM Changeset in webkit [216583] by commit-queue@webkit.org
  • 2 edits in trunk

[Win] Specify source file type when preprocessing IDL files
https://bugs.webkit.org/show_bug.cgi?id=171864

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-10
Reviewed by Alex Christensen.

  • Source/cmake/OptionsCommon.cmake:
7:26 AM Changeset in webkit [216582] by Michael Catanzaro
  • 5 edits in trunk/Source

[GTK] -Wmissing-field-initializers triggered by RemoteInspectorServer.cpp:128
https://bugs.webkit.org/show_bug.cgi?id=171273

Reviewed by Carlos Garcia Campos.

Source/JavaScriptCore:

  • inspector/remote/glib/RemoteInspectorGlib.cpp:
  • inspector/remote/glib/RemoteInspectorServer.cpp:

Source/WebKit2:

  • UIProcess/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::RemoteInspectorClient):

7:05 AM Changeset in webkit [216581] by hyungwook.lee@navercorp.com
  • 2 edits in trunk/Source/WebCore

[GTK] Fix compile warnings in CryptoKeyECGCrypt.cpp
https://bugs.webkit.org/show_bug.cgi?id=171851

Reviewed by Alex Christensen.

  • crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::curveSize):
(WebCore::curveName):
(WebCore::uncompressedPointSizeForCurve):
(WebCore::uncompressedFieldElementSizeForCurve):

7:01 AM Changeset in webkit [216580] by commit-queue@webkit.org
  • 3 edits
    4 deletes in trunk

Remove some last remnants of the EFL port
https://bugs.webkit.org/show_bug.cgi?id=171922

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2017-05-10
Reviewed by Antonio Gomes.

The EFL port is no more.

.:

  • Source/PlatformEfl.cmake: Removed.

Source/JavaScriptCore:

  • PlatformEfl.cmake: Removed.
  • shell/PlatformEfl.cmake: Removed.

Source/WTF:

  • wtf/PlatformEfl.cmake: Removed.
5:35 AM Changeset in webkit [216579] by commit-queue@webkit.org
  • 399 edits
    2 adds
    9 deletes in trunk

Unreviewed, rolling out r216578.
https://bugs.webkit.org/show_bug.cgi?id=171920

Broke the GTK+ build with Wayland enabled (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK] Bump GTK+ and its dependencies in jhbuild"
https://bugs.webkit.org/show_bug.cgi?id=171918
http://trac.webkit.org/changeset/216578

4:53 AM Changeset in webkit [216578] by Carlos Garcia Campos
  • 399 edits
    9 adds
    2 deletes in trunk

[GTK] Bump GTK+ and its dependencies in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=171918

Reviewed by Carlos Alberto Lopez Perez.

Tools:

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeGtkSettings):

  • gtk/jhbuild.modules:
  • gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
  • gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.

LayoutTests:

Rebaseline tests for new GTK+ versin.

  • platform/gtk/css1/box_properties/acid_test-expected.txt:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.png:
  • platform/gtk/css2.1/20110323/replaced-elements-001-expected.txt:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.png:
  • platform/gtk/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/gtk/css3/flexbox/button-expected.png:
  • platform/gtk/css3/flexbox/button-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-161-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-19b-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-25-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/gtk/css3/selectors3/html/css3-modsel-70-expected.png:
  • platform/gtk/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-19b-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.png:
  • platform/gtk/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-19b-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.png:
  • platform/gtk/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/gtk/editing/pasteboard/4641033-expected.png:
  • platform/gtk/editing/pasteboard/4641033-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-1-expected.png:
  • platform/gtk/editing/pasteboard/4944770-1-expected.txt:
  • platform/gtk/editing/pasteboard/4944770-2-expected.png:
  • platform/gtk/editing/pasteboard/4944770-2-expected.txt:
  • platform/gtk/editing/selection/3690703-2-expected.png:
  • platform/gtk/editing/selection/3690703-2-expected.txt:
  • platform/gtk/editing/selection/3690703-expected.png:
  • platform/gtk/editing/selection/3690703-expected.txt:
  • platform/gtk/editing/selection/3690719-expected.png:
  • platform/gtk/editing/selection/3690719-expected.txt:
  • platform/gtk/editing/selection/4397952-expected.png:
  • platform/gtk/editing/selection/4397952-expected.txt:
  • platform/gtk/editing/selection/5240265-expected.png:
  • platform/gtk/editing/selection/5240265-expected.txt:
  • platform/gtk/editing/selection/caret-before-select-expected.png:
  • platform/gtk/editing/selection/caret-before-select-expected.txt:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.png:
  • platform/gtk/editing/selection/replaced-boundaries-3-expected.txt:
  • platform/gtk/editing/selection/select-box-expected.png:
  • platform/gtk/editing/selection/select-box-expected.txt:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.png:
  • platform/gtk/editing/selection/select-element-paragraph-boundary-expected.txt:
  • platform/gtk/editing/selection/selection-button-text-expected.png:
  • platform/gtk/editing/selection/selection-button-text-expected.txt:
  • platform/gtk/fast/block/basic/011-expected.png:
  • platform/gtk/fast/block/basic/011-expected.txt:
  • platform/gtk/fast/block/float/float-avoidance-expected.png:
  • platform/gtk/fast/block/float/float-avoidance-expected.txt:
  • platform/gtk/fast/block/margin-collapse/103-expected.png:
  • platform/gtk/fast/block/margin-collapse/103-expected.txt:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.png:
  • platform/gtk/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/gtk/fast/box-sizing/percentage-height-expected.png:
  • platform/gtk/fast/box-sizing/percentage-height-expected.txt:
  • platform/gtk/fast/css/continuationCrash-expected.png:
  • platform/gtk/fast/css/continuationCrash-expected.txt:
  • platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.png:
  • platform/gtk/fast/css/focus-ring-exists-for-search-field-expected.txt:
  • platform/gtk/fast/css/input-search-padding-expected.png:
  • platform/gtk/fast/css/input-search-padding-expected.txt:
  • platform/gtk/fast/css/margin-top-bottom-dynamic-expected.png:
  • platform/gtk/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.png:
  • platform/gtk/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/gtk/fast/css/rtl-ordering-expected.png:
  • platform/gtk/fast/css/rtl-ordering-expected.txt:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.png:
  • platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.png:
  • platform/gtk/fast/css/text-overflow-input-expected.txt:
  • platform/gtk/fast/css/text-transform-select-expected.png:
  • platform/gtk/fast/css/text-transform-select-expected.txt:
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.png:
  • platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png:
  • platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.png:
  • platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:
  • platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
  • platform/gtk/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
  • platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/gtk/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
  • platform/gtk/fast/forms/001-expected.png:
  • platform/gtk/fast/forms/001-expected.txt:
  • platform/gtk/fast/forms/003-expected.png:
  • platform/gtk/fast/forms/003-expected.txt:
  • platform/gtk/fast/forms/004-expected.png:
  • platform/gtk/fast/forms/004-expected.txt:
  • platform/gtk/fast/forms/basic-buttons-expected.png:
  • platform/gtk/fast/forms/basic-buttons-expected.txt:
  • platform/gtk/fast/forms/basic-inputs-expected.png:
  • platform/gtk/fast/forms/basic-inputs-expected.txt:
  • platform/gtk/fast/forms/basic-selects-expected.png:
  • platform/gtk/fast/forms/basic-selects-expected.txt:
  • platform/gtk/fast/forms/blankbuttons-expected.png:
  • platform/gtk/fast/forms/blankbuttons-expected.txt:
  • platform/gtk/fast/forms/box-shadow-override-expected.png:
  • platform/gtk/fast/forms/box-shadow-override-expected.txt:
  • platform/gtk/fast/forms/button-align-expected.png:
  • platform/gtk/fast/forms/button-align-expected.txt:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.png:
  • platform/gtk/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/gtk/fast/forms/button-default-title-expected.png:
  • platform/gtk/fast/forms/button-default-title-expected.txt:
  • platform/gtk/fast/forms/button-generated-content-expected.png:
  • platform/gtk/fast/forms/button-generated-content-expected.txt:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.png:
  • platform/gtk/fast/forms/button-inner-block-reuse-expected.txt:
  • platform/gtk/fast/forms/button-positioned-expected.png:
  • platform/gtk/fast/forms/button-positioned-expected.txt:
  • platform/gtk/fast/forms/button-sizes-expected.png:
  • platform/gtk/fast/forms/button-sizes-expected.txt:
  • platform/gtk/fast/forms/button-style-color-expected.png:
  • platform/gtk/fast/forms/button-style-color-expected.txt:
  • platform/gtk/fast/forms/button-table-styles-expected.png:
  • platform/gtk/fast/forms/button-table-styles-expected.txt:
  • platform/gtk/fast/forms/button-text-transform-expected.png:
  • platform/gtk/fast/forms/button-text-transform-expected.txt:
  • platform/gtk/fast/forms/button-white-space-expected.png:
  • platform/gtk/fast/forms/button-white-space-expected.txt:
  • platform/gtk/fast/forms/control-clip-expected.png:
  • platform/gtk/fast/forms/control-clip-expected.txt:
  • platform/gtk/fast/forms/control-clip-overflow-expected.png:
  • platform/gtk/fast/forms/control-clip-overflow-expected.txt:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/control-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.png:
  • platform/gtk/fast/forms/disabled-select-change-index-expected.txt:
  • platform/gtk/fast/forms/file/file-input-direction-expected.png:
  • platform/gtk/fast/forms/file/file-input-direction-expected.txt:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.png:
  • platform/gtk/fast/forms/file/file-input-disabled-expected.txt:
  • platform/gtk/fast/forms/form-element-geometry-expected.png:
  • platform/gtk/fast/forms/form-element-geometry-expected.txt:
  • platform/gtk/fast/forms/formmove-expected.png:
  • platform/gtk/fast/forms/formmove-expected.txt:
  • platform/gtk/fast/forms/formmove2-expected.png:
  • platform/gtk/fast/forms/formmove2-expected.txt:
  • platform/gtk/fast/forms/formmove3-expected.png:
  • platform/gtk/fast/forms/formmove3-expected.txt:
  • platform/gtk/fast/forms/indeterminate-expected.png:
  • platform/gtk/fast/forms/indeterminate-expected.txt:
  • platform/gtk/fast/forms/input-appearance-height-expected.png:
  • platform/gtk/fast/forms/input-appearance-height-expected.txt:
  • platform/gtk/fast/forms/input-button-sizes-expected.png:
  • platform/gtk/fast/forms/input-button-sizes-expected.txt:
  • platform/gtk/fast/forms/input-first-letter-expected.png:
  • platform/gtk/fast/forms/input-first-letter-expected.txt:
  • platform/gtk/fast/forms/input-number-click-expected.txt: Added.
  • platform/gtk/fast/forms/input-value-expected.png:
  • platform/gtk/fast/forms/input-value-expected.txt:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.png:
  • platform/gtk/fast/forms/menulist-deselect-update-expected.txt:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.png:
  • platform/gtk/fast/forms/menulist-narrow-width-expected.txt:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.png:
  • platform/gtk/fast/forms/menulist-no-overflow-expected.txt:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.png:
  • platform/gtk/fast/forms/menulist-restrict-line-height-expected.txt:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.png:
  • platform/gtk/fast/forms/menulist-separator-painting-expected.txt:
  • platform/gtk/fast/forms/menulist-style-color-expected.png:
  • platform/gtk/fast/forms/menulist-style-color-expected.txt:
  • platform/gtk/fast/forms/menulist-width-change-expected.png:
  • platform/gtk/fast/forms/menulist-width-change-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.png:
  • platform/gtk/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
  • platform/gtk/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/gtk/fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Added.
  • platform/gtk/fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added.
  • platform/gtk/fast/forms/number/number-spinbutton-gets-disabled-or-readonly-expected.txt: Added.
  • platform/gtk/fast/forms/option-script-expected.png:
  • platform/gtk/fast/forms/option-script-expected.txt:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.png:
  • platform/gtk/fast/forms/option-strip-whitespace-expected.txt:
  • platform/gtk/fast/forms/option-text-clip-expected.png:
  • platform/gtk/fast/forms/option-text-clip-expected.txt:
  • platform/gtk/fast/forms/placeholder-position-expected.png:
  • platform/gtk/fast/forms/placeholder-position-expected.txt:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.png:
  • platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.png:
  • platform/gtk/fast/forms/range/input-appearance-range-expected.txt:
  • platform/gtk/fast/forms/range/slider-padding-expected.png:
  • platform/gtk/fast/forms/range/slider-padding-expected.txt:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.png:
  • platform/gtk/fast/forms/range/slider-thumb-shared-style-expected.txt:
  • platform/gtk/fast/forms/range/slider-transformed-expected.txt:
  • platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.png:
  • platform/gtk/fast/forms/range/thumbslider-no-parent-slider-expected.txt:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.png:
  • platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.png:
  • platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/gtk/fast/forms/search-input-rtl-expected.png:
  • platform/gtk/fast/forms/search-input-rtl-expected.txt: Added.
  • platform/gtk/fast/forms/search-rtl-expected.png:
  • platform/gtk/fast/forms/search-rtl-expected.txt:
  • platform/gtk/fast/forms/search-styled-expected.png:
  • platform/gtk/fast/forms/search-styled-expected.txt:
  • platform/gtk/fast/forms/search/search-size-with-decorations-expected.png:
  • platform/gtk/fast/forms/search/search-size-with-decorations-expected.txt:
  • platform/gtk/fast/forms/searchfield-heights-expected.png:
  • platform/gtk/fast/forms/searchfield-heights-expected.txt:
  • platform/gtk/fast/forms/select-align-expected.png:
  • platform/gtk/fast/forms/select-align-expected.txt:
  • platform/gtk/fast/forms/select-background-none-expected.png:
  • platform/gtk/fast/forms/select-background-none-expected.txt:
  • platform/gtk/fast/forms/select-baseline-expected.png:
  • platform/gtk/fast/forms/select-baseline-expected.txt:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.png:
  • platform/gtk/fast/forms/select-change-listbox-to-popup-expected.txt:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.png:
  • platform/gtk/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.png:
  • platform/gtk/fast/forms/select-disabled-appearance-expected.txt:
  • platform/gtk/fast/forms/select-element-focus-ring-expected.png: Added.
  • platform/gtk/fast/forms/select-element-focus-ring-expected.txt:
  • platform/gtk/fast/forms/select-initial-position-expected.png:
  • platform/gtk/fast/forms/select-initial-position-expected.txt:
  • platform/gtk/fast/forms/select-non-native-rendering-direction-expected.png: Added.
  • platform/gtk/fast/forms/select-non-native-rendering-direction-expected.txt: Added.
  • platform/gtk/fast/forms/select-selected-expected.png:
  • platform/gtk/fast/forms/select-selected-expected.txt:
  • platform/gtk/fast/forms/select-style-expected.png:
  • platform/gtk/fast/forms/select-style-expected.txt:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.png:
  • platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.png:
  • platform/gtk/fast/forms/select-writing-direction-natural-expected.txt:
  • platform/gtk/fast/forms/select/optgroup-rendering-expected.png:
  • platform/gtk/fast/forms/select/optgroup-rendering-expected.txt:
  • platform/gtk/fast/forms/selectlist-minsize-expected.png:
  • platform/gtk/fast/forms/selectlist-minsize-expected.txt:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.png:
  • platform/gtk/fast/forms/stuff-on-my-optgroup-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.png:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/forms/validation-message-appearance-expected.png:
  • platform/gtk/fast/forms/validation-message-appearance-expected.txt:
  • platform/gtk/fast/html/details-replace-summary-child-expected.png:
  • platform/gtk/fast/html/details-replace-summary-child-expected.txt:
  • platform/gtk/fast/html/details-replace-text-expected.png:
  • platform/gtk/fast/html/details-replace-text-expected.txt:
  • platform/gtk/fast/html/keygen-expected.png:
  • platform/gtk/fast/html/keygen-expected.txt:
  • platform/gtk/fast/inline/positionedLifetime-expected.png:
  • platform/gtk/fast/inline/positionedLifetime-expected.txt:
  • platform/gtk/fast/invalid/014-expected.png:
  • platform/gtk/fast/invalid/014-expected.txt:
  • platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.png:
  • platform/gtk/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.png:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/parser/bad-xml-slash-expected.png:
  • platform/gtk/fast/parser/bad-xml-slash-expected.txt:
  • platform/gtk/fast/parser/document-write-option-expected.png:
  • platform/gtk/fast/parser/document-write-option-expected.txt:
  • platform/gtk/fast/repaint/search-field-cancel-expected.png:
  • platform/gtk/fast/repaint/search-field-cancel-expected.txt:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.png:
  • platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.png:
  • platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/gtk/fast/replaced/three-selects-break-expected.png:
  • platform/gtk/fast/replaced/three-selects-break-expected.txt:
  • platform/gtk/fast/replaced/width100percent-button-expected.png:
  • platform/gtk/fast/replaced/width100percent-button-expected.txt:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.png:
  • platform/gtk/fast/replaced/width100percent-menulist-expected.txt:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.png:
  • platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/gtk/fast/scrolling/overflow-scrollable-after-back-expected.txt: Added.
  • platform/gtk/fast/table/append-cells2-expected.png:
  • platform/gtk/fast/table/append-cells2-expected.txt:
  • platform/gtk/fast/table/remove-td-display-none-expected.png:
  • platform/gtk/fast/table/remove-td-display-none-expected.txt:
  • platform/gtk/fast/text/international/bidi-menulist-expected.png:
  • platform/gtk/fast/text/international/bidi-menulist-expected.txt:
  • platform/gtk/fast/text/international/hindi-spacing-expected.png:
  • platform/gtk/fast/text/international/hindi-spacing-expected.txt:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
  • platform/gtk/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.png:
  • platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.png:
  • platform/gtk/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.png:
  • platform/gtk/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/gtk/svg/custom/foreign-object-skew-expected.png:
  • platform/gtk/svg/custom/foreign-object-skew-expected.txt:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.png:
  • platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug138725-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug39209-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4429-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug51727-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug52505-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug52506-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug60749-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug68912-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug68912-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png:
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
  • platform/gtk/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/gtk/tables/mozilla/core/margins-expected.png:
  • platform/gtk/tables/mozilla/core/margins-expected.txt:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png:
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
  • platform/gtk/tables/mozilla/other/move_row-expected.png:
  • platform/gtk/tables/mozilla/other/move_row-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.png:
  • platform/gtk/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/gtk/transforms/2d/zoom-menulist-expected.png:
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt:
3:04 AM Changeset in webkit [216577] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Win] Set CMake args in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=171436

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2017-05-10
Reviewed by Per Arne Vollan.

  • Scripts/build-webkit:
1:16 AM Changeset in webkit [216576] by commit-queue@webkit.org
  • 11 edits
    1 add
    3 deletes in trunk/Tools

ImageDiff: Add CG implementation for new ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=170608

Reviewed Alex Christensen.

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-05-10

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/win/ImageDiffCairo.cpp: Removed.
  • DumpRenderTree/win/ImageDiffWin.cpp: Removed.
  • ImageDiff/CMakeLists.txt:
  • ImageDiff/Cairo.cmake:
  • ImageDiff/ImageDiff.cpp:

(main):

  • ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
  • ImageDiff/PlatformImage.cpp:
  • ImageDiff/PlatformImage.h:
  • ImageDiff/cairo/PlatformImageCairo.cpp:
  • ImageDiff/cg/ImageDiff.cpp: Removed.
  • ImageDiff/cg/PlatformImageCG.cpp: Added.

(ImageDiff::PlatformImage::createFromStdin):
(ImageDiff::PlatformImage::createFromDiffData):
(ImageDiff::PlatformImage::PlatformImage):
(ImageDiff::PlatformImage::~PlatformImage):
(ImageDiff::PlatformImage::width):
(ImageDiff::PlatformImage::height):
(ImageDiff::PlatformImage::rowBytes):
(ImageDiff::PlatformImage::hasAlpha):
(ImageDiff::PlatformImage::pixels):
(ImageDiff::PlatformImage::writeAsPNGToStdout):

1:04 AM Changeset in webkit [216575] by zandobersek@gmail.com
  • 8 edits in trunk

Enable FTL JIT by default on AArch64
https://bugs.webkit.org/show_bug.cgi?id=144039

Reviewed by Yusuke Suzuki.

.:

  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/WebKitFeatures.cmake: Set FTL as enabled by default

when targeting either WTF_CPU_X86_64 or WTF_CPU_ARM64.

Tools:

  • Scripts/build-jsc: Enable the FTL JIT option by default on ARM64.
  • Scripts/run-jsc-stress-tests: Unmark the ARM64 and Linux combination

as an unsupported FTL platform.

  • Scripts/webkitdirs.pm:

(isARM64): Returns 1 if the determined architecture is 'arm64'.

  • Scripts/webkitperl/FeatureList.pm: Enable FTL_JIT and WEBASSEMBLY on ARM64.
12:42 AM Changeset in webkit [216574] by svillar@igalia.com
  • 6 edits in trunk

[css-grid] Remove Blink-specific code for handling orthogonal grid items
https://bugs.webkit.org/show_bug.cgi?id=171807

Reviewed by Darin Adler.

Source/WebCore:

This code was added in r203252 as part of a patch improving the handling of
{min|max}-content with orthogonal flows. The original code came from Blink which performs a
pre-layout of orthogonal boxes in FrameView. That is not true in the case of WebKit so we do
not need this code at all. Actually it was causing incorrect renderings in some tests.

I'm also removing an invalid return statement just after another return.

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::minContentForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::maxContentForChild):

LayoutTests:

Updated the expectations. They should now be compatible with Firefox and Chrome.

  • fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html:
  • fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html:
  • fast/css-grid-layout/repeating-layout-must-produce-the-same-results.html:
12:40 AM Changeset in webkit [216573] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216443. rdar://problem/31971375

12:40 AM Changeset in webkit [216572] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216159. rdar://problem/31971329

12:40 AM Changeset in webkit [216571] by jmarcell@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216104. rdar://problem/32057088

12:40 AM Changeset in webkit [216570] by jmarcell@apple.com
  • 6 edits
    1 add in branches/safari-603-branch

Cherry-pick r215748. rdar://problem/31971413

12:40 AM Changeset in webkit [216569] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-603-branch

Cherry-pick r215197. rdar://problem/31971401

12:40 AM Changeset in webkit [216568] by jmarcell@apple.com
  • 7 edits
    5 adds in branches/safari-603-branch

Cherry-pick r214375. rdar://problem/32057082

12:40 AM Changeset in webkit [216567] by jmarcell@apple.com
  • 2 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r213727. rdar://problem/32086123

12:22 AM Changeset in webkit [216566] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Win] StaticStringImpl in HTMLNames.cpp aren't constructed
https://bugs.webkit.org/show_bug.cgi?id=171800

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-10
Reviewed by Yusuke Suzuki.

Global variables of StaticStringImpl in HTMLNames.cpp aren't
constructed on Windows since Bug 171586. It seems that
reinterpret_cast prevents constexpr's compile time initialization
in VC++.

  • wtf/text/StringImpl.h:

(WTF::StringImplShape::StringImplShape): Added const char* and
const char16_t* members in the union. Do not use reinterpret_cast
in constexpr constructors.

May 9, 2017:

10:51 PM Changeset in webkit [216565] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/wpe/WidgetWPE.cpp:

(WebCore::Widget::paint): Add the missing SecurityOriginPaintPolicy parameter.

10:28 PM Changeset in webkit [216564] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Provide resource load error reason text in details sidebar
https://bugs.webkit.org/show_bug.cgi?id=171901
<rdar://problem/29850995>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-05-09
Reviewed by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.resourceRequestDidFailLoading):

  • UserInterface/Models/Resource.js:

(WebInspector.Resource):
(WebInspector.Resource.prototype.get failureReasonText):
(WebInspector.Resource.prototype.markAsFailed):

  • UserInterface/Protocol/NetworkObserver.js:

(WebInspector.NetworkObserver.prototype.loadingFailed):
Include the error text we got from the backend. In most cases this should
be a localized error description.

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshErrorReason):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
Include an Error field alongside the status code section when there was an error.

9:42 PM Changeset in webkit [216563] by eric.carlson@apple.com
  • 26 edits
    2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

  • UIProcess/UserMediaPermissionCheckProxy.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

LayoutTests:

  • fast/mediastream/get-user-media-device-id-expected.txt: Added.
  • fast/mediastream/get-user-media-device-id.html: Added.
7:30 PM Changeset in webkit [216562] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

[GTK][Win] Web Inspector: Cann't open "Quick Open" dialog by pressing Ctrl+Shift+O
https://bugs.webkit.org/show_bug.cgi?id=171798

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Michael Catanzaro.

PC can't input the shortcut keys Command+Shift+O and Command+P.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Use CommandOrControl instead of Command.

6:01 PM Changeset in webkit [216561] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSInjectedScriptHost should get a copy of the boundArgs
https://bugs.webkit.org/show_bug.cgi?id=171897

Reviewed by Joseph Pecoraro.

The boundArgs array is very special - it cannot be mutated in any way. So, it makes sense
for the inspector to get a copy of it.

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::getInternalProperties):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::boundArgsCopy):

  • runtime/JSBoundFunction.h:

(JSC::JSBoundFunction::boundArgs):

5:33 PM Changeset in webkit [216560] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Mark webrtc/libwebrtc/release-while-setting-local-description.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171899

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
5:21 PM Changeset in webkit [216559] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Video fullscreen window level should be below status bar.
https://bugs.webkit.org/show_bug.cgi?id=171892
rdar://problem/31771707

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-05-09
Reviewed by Jer Noble.

No new tests because it only affects platform window level.

Move the fullscreen window below the status bar, but above the input field window level.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setupFullscreen):

5:13 PM WebKitGTK/2.16.x edited by Michael Catanzaro
Propose r215166 to make Gentoo happy (diff)
5:03 PM Changeset in webkit [216558] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unindent some code in Watchdog::shouldTerminate().
https://bugs.webkit.org/show_bug.cgi?id=171896

Rubber stamped by Keith Miller.

I should have done this before I landed r213107, but I forgot. Unindenting it now.

  • runtime/Watchdog.cpp:

(JSC::Watchdog::shouldTerminate):

4:27 PM Changeset in webkit [216557] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Mark webrtc/audio-replace-track.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171895

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:19 PM Changeset in webkit [216556] by Jonathan Bedard
  • 8 edits in trunk/Tools

webkitpy: Remove unneeded crash log retrieval, refactor Darwin crash retrieval
https://bugs.webkit.org/show_bug.cgi?id=170857
<rdar://problem/31635373>

Reviewed by Aakash Jain.

Since LayoutTestRelay has been removed, iOS Simulators and Macs can use the same
code to search for crash logs.

  • Scripts/webkitpy/port/darwin.py:

(DarwinPort._get_crash_log): Moved from MacPort.

  • Scripts/webkitpy/port/darwin_testcase.py:

(DarwinTest.test_get_crash_log): Moved from MacTest.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort._get_crash_log): Implement pass-through for iOS device, since iOS
devices must search for crash-logs remotely.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._get_crash_log): Deleted.

  • Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest.test_get_crash_log): Deleted.

  • Scripts/webkitpy/port/mac.py:

(MacPort._get_crash_log): Moved to DarwinPort

  • Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_get_crash_log): Moved to DarwinTest.

4:14 PM Changeset in webkit [216555] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Buffer media in NetworkProcess to reduce IPC overhead
https://bugs.webkit.org/show_bug.cgi?id=171834
<rdar://problem/31485485>

Patch by Alex Christensen <achristensen@webkit.org> on 2017-05-09
Reviewed by Jer Noble.

I have measured a significant CPU usage reduction when buffering media data in the NetworkProcess,
especially on arm64 processors. Buffering data in the NetworkProcess introduces no additional data
copies after r215686, and it reduces the number of messages sent from the NetworkProcess to the WebProcess,
each of which must also be forwarded to mediaserverd by AVFoundation. This reduces the number of messages
from thousands per second to a maximum of 20 per second. This adds 1/20 second additional latency in
media loading, which will probably not be noticed by most users. This also adds the possibility of large
allocations when decoding IPC messages in the WebProcess, and if that becomes the source of crashes we can
add a maximum buffered amount in addition to a maximum buffered time, but we are likely not to receive
so much data in 1/20 second to have problems allocating the buffer.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::maximumBufferingTime):
Buffer data in the NetworkProcess for up to 50ms before sending it to the WebProcess in one message.
This value is used in NetworkResourceLoader::didReceiveBuffer to append to m_bufferedData instead of
sending the small chunks immediately.

4:00 PM Changeset in webkit [216554] by dino@apple.com
  • 3 edits in trunk/Source/WebKit/win

Fix Windows build.

  • Plugins/PluginView.h:
  • Plugins/PluginViewWin.cpp:

(WebCore::PluginView::paint):

3:53 PM Changeset in webkit [216553] by weinig@apple.com
  • 14 edits
    9 adds in trunk

LayoutTests/imported/w3c:
Implement Subresource Integrity (SRI)
https://bugs.webkit.org/show_bug.cgi?id=148363
<rdar://problem/18945879>

Reviewed by Youenn Fablet.

  • web-platform-tests/fetch/api/basic/integrity-expected.txt:
  • web-platform-tests/fetch/api/basic/integrity-worker-expected.txt:

Update results now that integrity is implemented.

Source/WebCore:
Implement Subresource Integrity (SRI) [Part 2 - Fetch]
https://bugs.webkit.org/show_bug.cgi?id=148363
<rdar://problem/18945879>

Reviewed by Youenn Fablet.

Tests: http/tests/subresource-integrity/sri-fetch-worker.html

http/tests/subresource-integrity/sri-fetch.html

  • loader/FetchOptions.h:
  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::isolatedCopy):

  • loader/ThreadableLoader.h:
  • loader/WorkerThreadableLoader.cpp:

(WebCore::LoaderTaskOptions::LoaderTaskOptions):
Add integrity metadata to the fetch options, and fix the implementation of
ThreadableLoaderOptions::isolatedCopy to work correctly (it was missing isolated
copy derivedCachedDataTypesToRetrieve).

  • Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions):
(WebCore::FetchRequest::initializeOptions):

  • Modules/fetch/FetchRequest.h:

Switch to using the integrity metadata on the fetchOptions, removing the need to
store them directly on the internal request.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::didReceiveData):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):

  • loader/DocumentThreadableLoader.h:

Add a new flag, m_delayCallbacksForIntegrityCheck, which is used when integrity metadata
is present, so we can implement the 'wait' concept from the fetch spec, and delay informing
the clients until we have validated the integrity metadata.

LayoutTests:
Implement Subresource Integrity (SRI)
https://bugs.webkit.org/show_bug.cgi?id=148363
<rdar://problem/18945879>

Reviewed by Youenn Fablet.

Add tests for Subresource Integrity for Fetch based off the ones from Web
Platform Tests. Additional tests for more CORS combinations have been added.

  • http/tests/subresource-integrity/resources/crossorigin-anon-resource.txt: Added.
  • http/tests/subresource-integrity/resources/crossorigin-creds-resource.txt: Added.
  • http/tests/subresource-integrity/resources/crossorigin-ineligible-resource.txt: Added.
  • http/tests/subresource-integrity/resources/resource.txt: Added.
  • http/tests/subresource-integrity/sri-fetch-expected.txt: Added.
  • http/tests/subresource-integrity/sri-fetch-worker-expected.txt: Added.
  • http/tests/subresource-integrity/sri-fetch-worker.html: Added.
  • http/tests/subresource-integrity/sri-fetch.html: Added.
  • http/tests/subresource-integrity/sri-fetch.js: Added.
3:52 PM Changeset in webkit [216552] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked webrtc/captureCanvas-webrtc.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=170870

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:38 PM Changeset in webkit [216551] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Cap the number of FTL compilation threads on iOS to 2
https://bugs.webkit.org/show_bug.cgi?id=171887

Reviewed by Filip Pizlo.

Set an iOS specific max of 2 threads.

  • runtime/Options.h:
3:35 PM Changeset in webkit [216550] by commit-queue@webkit.org
  • 25 edits
    2 deletes in trunk

Unreviewed, rolling out r216545.
https://bugs.webkit.org/show_bug.cgi?id=171889

Caused a test failure (Requested by eric_carlson on #webkit).

Reverted changeset:

"[MediaStream] deviceId constraint doesn't work with
getUserMedia"
https://bugs.webkit.org/show_bug.cgi?id=171877
http://trac.webkit.org/changeset/216545

3:30 PM Changeset in webkit [216549] by Alan Bujtas
  • 6 edits
    2 adds in trunk

resetFlowThreadContainingBlockAndChildInfoIncludingDescendants should not ignore RenderElement subtrees.
https://bugs.webkit.org/show_bug.cgi?id=171873
<rdar://problem/32004954>

Reviewed by Simon Fraser.

Source/WebCore:

Normally a RenderBlock's parent is another RenderBlock, but In some cases (e.g. tables) a RenderBlock can
have a non-RenderBlock(RenderBox) ancestor.
While updating the flow thread state on a subtree, we should descent into subtrees with RenderElement
roots and not just RenderBlocks so that we clear the state on the entire subtree.

Test: fast/multicol/crash-when-column-inside-table.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::resetFlowThreadContainingBlockAndChildInfoIncludingDescendants):

  • rendering/RenderBlock.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::resetFlowThreadContainingBlockAndChildInfoIncludingDescendants):

  • rendering/RenderElement.h:

LayoutTests:

  • fast/multicol/crash-when-column-inside-table-expected.txt: Added.
  • fast/multicol/crash-when-column-inside-table.html: Added.
3:28 PM Changeset in webkit [216548] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

[iOS Simulator] Flaky failure LayoutTest/webrtc/libwebrtc/release-while-setting-local-description.html
https://bugs.webkit.org/show_bug.cgi?id=171742

Reviewed by Youenn Fablet.

Silence the console messages for unhandled rejections in this test.

  • webrtc/libwebrtc/release-while-setting-local-description-expected.txt:
  • webrtc/libwebrtc/release-while-setting-local-description.html:
3:27 PM Changeset in webkit [216547] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Heap::heap() should behave gracefully for null pointers
https://bugs.webkit.org/show_bug.cgi?id=171888
<rdar://problem/32005315>

Reviewed by Mark Lam.

Some callers of Heap::heap() can pass a null cell and they will behave gracefully if we
return a null Heap. So, let's do that.

This fixes a crash and it does not hurt performance. I'm seeing a possible 0.5% regression
with 74% probability. That's a neutral result by our usual 95% standard.

  • heap/HeapInlines.h:

(JSC::Heap::heap):

3:18 PM Changeset in webkit [216546] by BJ Burg
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Assertion failed: Cannot select item with unexpected parent bar. (at NavigationBar.js:132)
https://bugs.webkit.org/show_bug.cgi?id=171885

Reviewed by Matt Baker.

This new assertion revealed a real misuse of the NavigationBar API.

  • UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype.set selectedNavigationItem):
Improve this to be an assertion so it can be paused at using the debugger.

  • UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype._changeViewMode):
We need to set a NavigationItem as the selected item, not its identifier.
Look up the corresponding item for the identifier that we received (the view mode).

3:06 PM Changeset in webkit [216545] by eric.carlson@apple.com
  • 25 edits
    2 adds in trunk

[MediaStream] deviceId constraint doesn't work with getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=171877
<rdar://problem/31899730>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/get-user-media-device-id.html

  • Modules/mediastream/MediaConstraintsImpl.h:

(WebCore::MediaConstraintsData::MediaConstraintsData): Add a constructor that
takes a const MediaConstraints&.

  • Modules/mediastream/MediaDevicesEnumerationRequest.cpp:

(WebCore::MediaDevicesEnumerationRequest::topLevelDocumentOrigin): Don't return
NULL for the main frame so the origin matches that returned for a UserMediaRequest.

  • Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::setDeviceIDHashSalt): Deleted, not used.
(WebCore::UserMediaController::deviceIDHashSalt): Deleted, not used.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow): Add device ID hash salt parameter, set it on
constraints.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaConstraints.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance): ASSERT if called for DeviceId.
(WebCore::RealtimeMediaSource::selectSettings): Special case DeviceId because it
we have to hash the device ID before comparing, and because the DeviceId can't be
changed so it should never be added to the flattened constraints.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.cpp:

(WebCore::RealtimeMediaSourceSupportedConstraints::nameForConstraint): Deleted, unused.
(WebCore::RealtimeMediaSourceSupportedConstraints::constraintFromName): Deleted, unused.

  • platform/mediastream/RealtimeMediaSourceSupportedConstraints.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:
  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::bestSourcesForTypeAndConstraints): Pass device
id, not empty string.

Source/WebKit2:

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<MediaConstraintsData>::encode): Encode deviceIDHashSalt.
(IPC::ArgumentCoder<MediaConstraintsData>::decode): Decode deviceIDHashSalt.

  • UIProcess/UserMediaPermissionCheckProxy.cpp:

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy): Initialize
completion handler, frame ID, and security origins.
(WebKit::UserMediaPermissionCheckProxy::setUserMediaAccessInfo): Complete by calling
completion handler because we now sometimes request access info before calling gUM.
(WebKit::UserMediaPermissionCheckProxy::invalidate): Clear completion handler.

  • UIProcess/UserMediaPermissionCheckProxy.h:
  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::FrameAuthorizationState::FrameAuthorizationState): Take security origins, not
UserMediaPermissionRequestProxy, so it can be constructed with a UserMediaPermissionCheckProxy.
(WebKit::FrameAuthorizationState::ensureSecurityOriginsAreEqual): Ditto. Clear has salt
when origins don't match.
(WebKit::UserMediaPermissionRequestManagerProxy::stateForRequest): Templatize.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied): Fix typo.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted): Ditto.
Don't set state for empty UIDs. Pass hash salt to web process.
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
The device ID hash salt is now required to validate constraints, so get it first.
(WebKit::UserMediaPermissionRequestManagerProxy::getUserMediaPermissionInfo): Helper
method used to get the device ID hash salt.
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame): Restructure
to use getUserMediaPermissionInfo.
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck): Deleted.

  • UIProcess/UserMediaPermissionRequestManagerProxy.h:
  • WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::userMediaAccessWasGranted): Add device ID
hash salt parameter.

  • WebProcess/MediaStream/UserMediaPermissionRequestManager.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::userMediaAccessWasGranted): Ditto.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::createCaptureSource): Use new MediaConstraintsData
constructor.

LayoutTests:

  • fast/mediastream/get-user-media-device-id-expected.txt: Added.
  • fast/mediastream/get-user-media-device-id.html: Added.
2:52 PM Changeset in webkit [216544] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Modern Media Controls] Localized strings aren't loaded
https://bugs.webkit.org/show_bug.cgi?id=171884

Patch by Antoine Quint <Antoine Quint> on 2017-05-09
Reviewed by Dean Jackson.

Remove the extraneous file extension in the file name.

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsScript):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsScript):

2:49 PM Changeset in webkit [216543] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked multiple test flaky.
https://bugs.webkit.org/show_bug.cgi?id=171886

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
2:40 PM Changeset in webkit [216542] by Chris Dumez
  • 8 edits
    3 adds in trunk

Introduce DocumentAndElementEventHandlers IDL interface
https://bugs.webkit.org/show_bug.cgi?id=171879

Reviewed by Simon Fraser and Ryosuke Niwa.

Source/WebCore:

Introduce DocumentAndElementEventHandlers IDL interface:

This avoids duplication between Document.idl and Element.idl.

Also mark oncopy / oncut / onpaste EventHandlers as enumerable to match
the specification.

Test: fast/events/DocumentAndElementEventHandlers.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.idl:
  • dom/DocumentAndElementEventHandlers.idl: Added.
  • dom/Element.idl:

LayoutTests:

  • fast/events/DocumentAndElementEventHandlers-expected.txt: Added.
  • fast/events/DocumentAndElementEventHandlers.html: Added.

Add layout test coverage.

  • js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline now that those event handlers are enumerable.

2:35 PM Changeset in webkit [216541] by dino@apple.com
  • 29 edits
    5 adds in trunk

Restrict SVG filters to accessible security origins
https://bugs.webkit.org/show_bug.cgi?id=118689
<rdar://problem/27362159>

Reviewed by Brent Fulgham.

Source/WebCore:

Certain SVG filters should only be allowed to operate
on content that is has SecurityOrigin access to. Implement
this by including a flag in PaintInfo and LayerPaintingInfo,
and have RenderWidget make sure the documents have acceptable
SecurityOrigins as it goes to paint.

This could be used as the first step in a "safe painting"
strategy, allowing some content to be rendered into a
canvas or via the element() CSS function... but it is only
a small first step.

Test: http/tests/css/filters-on-iframes.html

  • page/FrameView.cpp:

(WebCore::FrameView::paintContents):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::paint):

  • platform/ScrollView.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::paint):

  • platform/Scrollbar.h:
  • platform/Widget.h:
  • platform/graphics/filters/FilterOperation.h:

(WebCore::FilterOperation::shouldBeRestrictedBySecurityOrigin):

  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::FilterOperations::hasFilterThatShouldBeRestrictedBySecurityOrigin):

  • platform/graphics/filters/FilterOperations.h:
  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::build):

  • rendering/FilterEffectRenderer.h:
  • rendering/PaintInfo.h:

(WebCore::PaintInfo::PaintInfo):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::setupFilters):
(WebCore::RenderLayer::paintForegroundForFragmentsWithPhase):

  • rendering/RenderLayer.h:
  • rendering/RenderScrollbar.cpp:

(WebCore::RenderScrollbar::paint):

  • rendering/RenderScrollbar.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::paintContents):

Source/WebKit2:

Update parameter lists.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::paint):

  • WebProcess/Plugins/PluginView.h:

LayoutTests:

Add a test that shows safe frames, unsafe frames, and
then a safe frame that itself has an unsafe frame, to
show that the security requirements are being forwarded
down the tree.

  • http/tests/css/filters-on-iframes-expected.html: Added.
  • http/tests/css/filters-on-iframes.html: Added.
  • http/tests/css/resources/blank.html: Added.
  • http/tests/css/resources/references-external.html: Added.
  • http/tests/css/resources/solid-red.html: Added.
2:21 PM Changeset in webkit [216540] by Chris Dumez
  • 9 edits
    2 adds in trunk

Move onanimation* EventHandlers to GlobalEventHandlers
https://bugs.webkit.org/show_bug.cgi?id=171874

Reviewed by Simon Fraser.

Source/WebCore:

Move onanimation* EventHandlers to GlobalEventHandlers to match the specification:

We previously have those on Window and Element only. Firefox complies with the
specification.

Test: fast/css/onanimation-eventhandlers.html

  • dom/Element.idl:
  • dom/GlobalEventHandlers.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/css/onanimation-eventhandlers-expected.txt: Added.
  • fast/css/onanimation-eventhandlers.html: Added.

Add layout test coverage.

  • fast/dom/event-handler-attributes-expected.txt:
  • fast/dom/event-handler-attributes.html:
  • js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline existing tests to reflect behavior change.

2:04 PM Changeset in webkit [216539] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed a typo in expectations file.
https://bugs.webkit.org/show_bug.cgi?id=162710

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
2:01 PM Changeset in webkit [216538] by Jon Davis
  • 3 edits in trunk/PerformanceTests

[ARES6] Improved the running test indicator
https://bugs.webkit.org/show_bug.cgi?id=171400

Running tests show a triangle before the test title and the titles are white.

Reviewed by Joseph Pecoraro.

  • ARES-6/index.html:
  • ARES-6/styles.css:

(.test .running):
(.test .running:before):
(.test .indicator): Deleted.
(.test .indicator.running): Deleted.
(@keyframes test-running): Deleted.

1:58 PM Changeset in webkit [216537] by commit-queue@webkit.org
  • 9 edits
    2 copies
    20 adds in trunk

Refresh webrtc WPT tests
https://bugs.webkit.org/show_bug.cgi?id=171878

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-09
Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • web-platform-tests/webrtc/OWNERS:
  • web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize-expected.txt: Added.
  • web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize.html: Added.
  • web-platform-tests/webrtc/RTCDataChannel-id-expected.txt: Added.
  • web-platform-tests/webrtc/RTCDataChannel-id.html: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates-expected.txt: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates.html: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-constructor-expected.txt: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-constructor.html: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-createDataChannel-expected.txt: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-createDataChannel.html: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState-expected.txt: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-idl-expected.txt: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-idl.html: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt: Added.
  • web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription.html: Added.
  • web-platform-tests/webrtc/datachannel-idlharness-expected.txt: Added.
  • web-platform-tests/webrtc/datachannel-idlharness.html: Added.
  • web-platform-tests/webrtc/getstats-expected.txt: Added.
  • web-platform-tests/webrtc/getstats.html: Added.
  • web-platform-tests/webrtc/interfaces-expected.txt: Added.
  • web-platform-tests/webrtc/interfaces.html: Added.
  • web-platform-tests/webrtc/no-media-call.html:
  • web-platform-tests/webrtc/promises-call.html:
  • web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt:
  • web-platform-tests/webrtc/simplecall.html:
  • web-platform-tests/webrtc/w3c-import.log:

Source/WebCore:

Tests: imported/w3c/web-platform-tests/webrtc/RTCConfiguration-iceCandidatePoolSize.html

imported/w3c/web-platform-tests/webrtc/RTCDataChannel-id.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-canTrickleIceCandidates.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-constructor.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-createDataChannel.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-iceGatheringState.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-idl.html
imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription.html
imported/w3c/web-platform-tests/webrtc/datachannel-idlharness.html
imported/w3c/web-platform-tests/webrtc/getstats.html
imported/w3c/web-platform-tests/webrtc/interfaces.html

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::createDataChannel): exiting early if libwebrtc is not creating a data channel.

1:48 PM Changeset in webkit [216536] by jfernandez@igalia.com
  • 16 edits in trunk

space-evenly misbehaves with flexbox
https://bugs.webkit.org/show_bug.cgi?id=170445

Reviewed by David Hyatt.

Source/WebCore:

The CSS Box Alignment specification defines the <content-distribution>
set as some of the allowed values for the Content Distribution
properties, align-content and justify-content. The 'space-evenly' value
is not among the ones allowed for these properties according to the CSS
Flexible Box specification.

The CSS Flexbible box specification states that it must follow the CSS
Box Alignment specification, so this new value must be considered as
part of an upgraded level of the spec, which should be implemented
eventually.

Since we have already shipped an implementation of the new CSS Box
Alignment values for CSS Grid Layout, we need to implement it for
Flexbox as well.

No new tests, but several new test cases added.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::initialJustifyContentOffset):
(WebCore::justifyContentSpaceBetweenChildren):
(WebCore::initialAlignContentOffset):
(WebCore::alignContentSpaceBetweenChildren):

LayoutTests:

Added test cases for the 'space-evenly' value for align-content and justify-content.

  • css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line-expected.txt:
  • css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/flexbox/flex-justify-content-expected.txt:
  • css3/flexbox/flex-justify-content.html:
  • css3/flexbox/multiline-align-content-expected.txt:
  • css3/flexbox/multiline-align-content-horizontal-column-expected.txt:
  • css3/flexbox/multiline-align-content-horizontal-column.html:
  • css3/flexbox/multiline-align-content.html:
  • css3/flexbox/resources/flexbox.css:

(.align-content-space-around):
(.justify-content-space-around):

  • css3/flexbox/true-centering-expected.txt:
  • css3/flexbox/true-centering.html:
1:24 PM Changeset in webkit [216535] by Michael Catanzaro
  • 3 edits in trunk/Source/WebCore

Avoid -Wformat warnings in RenderLayerCompositor.cpp and RenderLayerBacking.cpp
https://bugs.webkit.org/show_bug.cgi?id=171875

Reviewed by Simon Fraser.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

1:01 PM Changeset in webkit [216534] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Drop custom bindings code for Window.location setter
https://bugs.webkit.org/show_bug.cgi?id=171846

Reviewed by Sam Weinig.

Drop custom bindings code for Window.location setter as the custom code was merely needed
to address a very old Mac widget that has long been fixed (rdar://problem/5695330).

No new tests, no Web-facing behavior change.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation): Deleted.
Drop custom code.

  • page/DOMWindow.idl:

Align Window.location with https://html.spec.whatwg.org/#the-window-object:

  • Mark property as readonly.
  • Add [PutsForward=href] IDL extended attribute.

Also, we need to mark the atribute as nullable as this reflects our current implementation.
We currently return null if the associated Window does not have a frame. This does not match
the specification and we should update our implementation in the future to never return null.

12:27 PM Changeset in webkit [216533] by Ryan Haddad
  • 8 edits
    1 add in branches/safari-603-branch/Tools

Merge r213654. rdar://problem/32074957

12:15 PM Changeset in webkit [216532] by Matt Lewis
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r216508.

The layout test enabled in this change is failing on Sierra.

Reverted changeset:

"Invalid MediaSource duration value should throw TyperError
instead of InvalidStateError"
https://bugs.webkit.org/show_bug.cgi?id=171653
http://trac.webkit.org/changeset/216508

11:44 AM Changeset in webkit [216531] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Update Chrome and Firefox versions in user agent quirks
https://bugs.webkit.org/show_bug.cgi?id=171823

Reviewed by Carlos Alberto Lopez Perez.

  • platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::stringForQuirk):
(WebCore::UserAgentQuirks::firefoxRevisionString):

11:42 AM Changeset in webkit [216530] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

RealtimeOutgoingAudioSource is crashing when given data with more than two channels
https://bugs.webkit.org/show_bug.cgi?id=171868

Patch by Youenn Fablet <youenn@apple.com> on 2017-05-09
Reviewed by Eric Carlson.

Manual testing.

  • platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::libwebrtcAudioFormat): Capping the number of channels to 2.
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):

11:34 AM Changeset in webkit [216529] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/element-containing-pip-video-going-into-fullscreen.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=162710

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
11:07 AM Changeset in webkit [216528] by Jonathan Bedard
  • 3 edits in trunk/Tools

build ImageDiff with host SDK from Make
https://bugs.webkit.org/show_bug.cgi?id=171835

Reviewed by Alexey Proskuryakov.

ImageDiff should be built for the default SDK and default architecture when
the SDKROOT is set to either iOS device or iOS simulator. Check the
DO_NOT_BUILD_IMAGE_DIFF flag to skip the ImageDiff build.

  • ImageDiff/Makefile: Use Mac SDK when building for iOS Simulator or iOS device.
  • Makefile: Do not build ImageDiff if the DO_NOT_BUILD_IMAGE_DIFF flag is set.
11:05 AM Changeset in webkit [216527] by matthew_hanson@apple.com
  • 5 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216431. rdar://problem/31971208

11:05 AM Changeset in webkit [216526] by matthew_hanson@apple.com
  • 4 edits in branches/safari-603-branch/Source/JavaScriptCore

Cherry-pick r216309. rdar://problem/31971364

11:05 AM Changeset in webkit [216525] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216120. rdar://problem/31970955

11:05 AM Changeset in webkit [216524] by matthew_hanson@apple.com
  • 6 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216096. rdar://problem/31971264

11:05 AM Changeset in webkit [216523] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r216023. rdar://problem/31971371

11:05 AM Changeset in webkit [216522] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-603-branch

Cherry-pick r215971. rdar://problem/31971140

11:05 AM Changeset in webkit [216521] by matthew_hanson@apple.com
  • 3 edits
    1 add in branches/safari-603-branch

Cherry-pick r215596. rdar://problem/31971150

11:05 AM Changeset in webkit [216520] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r215528. rdar://problem/31971331

11:05 AM Changeset in webkit [216519] by matthew_hanson@apple.com
  • 3 edits
    1 add in branches/safari-603-branch

Cherry-pick r215351. rdar://problem/31631922

11:04 AM Changeset in webkit [216518] by matthew_hanson@apple.com
  • 3 edits in branches/safari-603-branch/Source/WebCore

Cherry-pick r214554. rdar://problem/31971164

11:02 AM Changeset in webkit [216517] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

font-stretch: normal selects expanded fonts instead of condensed fonts
https://bugs.webkit.org/show_bug.cgi?id=171838
<rdar://problem/31005481>

Reviewed by Jon Lee.

Source/WebCore:

CSS Fonts level 3 says: "If the value of ‘font-stretch’ is ‘normal’ or one of the condensed
values, narrower width values are checked first, then wider values."

CSS Fonts level 4 erroneously was incompatible with this, but was updated in
https://github.com/w3c/csswg-drafts/commit/4559389d183bbaaf3321af5ba1c924caa7c488bb
to be consistent with this.

Now, CSS Fonts level 4 states: "If the desired stretch value is less than or equal to100,
stretch values below the desired stretch value are checked in descending order followed by
stretch values above the desired stretch value in ascending order"

Test: fast/text/font-width-100.html

  • platform/graphics/FontSelectionAlgorithm.cpp:

LayoutTests:

  • fast/text/font-width-100-expected.html: Added.
  • fast/text/font-width-100.html: Added.
10:56 AM Changeset in webkit [216516] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.21-branch/Source

Versioning.

10:36 AM Changeset in webkit [216515] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Mark storage/indexeddb/modern/idbtransaction-objectstore-failures.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=171862

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:34 AM Changeset in webkit [216514] by Matt Lewis
  • 2 edits in trunk/Tools

Unreviewed, adding myself to contributors.json

  • Scripts/webkitpy/common/config/contributors.json:
10:15 AM Changeset in webkit [216513] by commit-queue@webkit.org
  • 15 edits
    5 adds in trunk

[Readable Streams API] Enable creation of ReadableStreamBYOBReader
https://bugs.webkit.org/show_bug.cgi?id=171665

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-05-09
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:

Updated expectations.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt:

Source/WebCore:

Enabled the creation of ReadableStreamBYOBReader.

Test: streams/readable-stream-byob-reader.html

  • CMakeLists.txt: Updated to support ReadableStreamBYOBReader.
  • DerivedSources.cpp: Updated to support ReadableStreamBYOBReader.
  • DerivedSources.make: Updated to support ReadableStreamBYOBReader.
  • Modules/streams/ReadableByteStreamInternals.js: Updated to support ReadableStreamBYOBReader.

(privateInitializeReadableStreamBYOBReader):
(isReadableStreamBYOBReader):

  • Modules/streams/ReadableStream.js: Updated to support ReadableStreamBYOBReader.

(getReader):

  • Modules/streams/ReadableStreamBYOBReader.idl: Added.
  • Modules/streams/ReadableStreamBYOBReader.js: Added.

(cancel): To be implemented.
(read): To be implemented.
(releaseLock): To be implemented.
(closed): To be implemented.

  • WebCore.xcodeproj/project.pbxproj: Updated to support ReadableStreamBYOBReader.
  • bindings/js/JSDOMGlobalObject.cpp: Updated to support ReadableStreamBYOBReader.

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp: Updated to support ReadableStreamBYOBReader.

(WebCore::constructJSReadableStreamReaderGeneric):
(WebCore::constructJSReadableStreamDefaultReader):
(WebCore::constructJSReadableStreamBYOBReader):
(WebCore::JSBuiltinReadableStreamBYOBReaderPrivateConstructor::initializeExecutable):
(WebCore::createReadableStreamBYOBReaderPrivateConstructor):

  • bindings/js/JSReadableStreamPrivateConstructors.h: Updated to support ReadableStreamBYOBReader.
  • bindings/js/WebCoreBuiltinNames.h: Updated to support ReadableStreamBYOBReader.

LayoutTests:

Added test to check the creation of ReadableStreamBYOBReader. Also check
that created object has the right methods and properties.

  • streams/readable-stream-byob-reader-expected.txt: Added.
  • streams/readable-stream-byob-reader.html: Added.
  • streams/readable-stream-byob-reader.js: Added.
10:11 AM Changeset in webkit [216512] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Force StaticStringImpl constructor to use the constexpr versions of StringImplShape constructors.
https://bugs.webkit.org/show_bug.cgi?id=171861

Reviewed by Yusuke Suzuki.

This is strictly necessary for correctness of the StaticStringImpl implementation.
We force the constructor selection by adding an extra dummy argument to the
constexpr versions of the StringImplShape constructors to disambiguate them from
the non-constexpr versions.

  • wtf/text/StringImpl.h:

(WTF::StringImplShape::StringImplShape):
(WTF::StringImpl::StaticStringImpl::StaticStringImpl):

10:10 AM Changeset in webkit [216511] by commit-queue@webkit.org
  • 36 edits in trunk

Print more properties in the output of scrolling trees
https://bugs.webkit.org/show_bug.cgi?id=171858

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-09
Reviewed by Simon Fraser.

Source/WebCore:

No new tests, no behavior changes.

  • page/scrolling/ScrollingCoordinator.cpp: Implement << operator to print ScrollableAreaParameters.

(WebCore::operator<<):

  • page/scrolling/ScrollingCoordinator.h: Declare new << operator.
  • page/scrolling/ScrollingStateFrameScrollingNode.cpp: Print new properties.

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):

  • page/scrolling/ScrollingStateScrollingNode.cpp: ditto.

(WebCore::ScrollingStateScrollingNode::dumpProperties):

  • page/scrolling/ScrollingTreeScrollingNode.cpp: ditto.

(WebCore::ScrollingTreeScrollingNode::dumpProperties):

LayoutTests:

Update text expectations to include new properties.

  • fast/scrolling/ios/remove-scrolling-role-expected.txt:
  • fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-expected.txt:
  • fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolled-down-then-up-expected.txt:
  • fast/visual-viewport/tiled-drawing/zoomed-fixed-scrolling-layers-state-expected.txt:
  • tiled-drawing/scrolling/clamp-out-of-bounds-scrolls-expected.txt:
  • tiled-drawing/scrolling/fixed/absolute-inside-fixed-expected.txt:
  • tiled-drawing/scrolling/fixed/absolute-inside-out-of-view-fixed-expected.txt:
  • tiled-drawing/scrolling/fixed/fixed-in-overflow-expected.txt:
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-expected.txt:
  • tiled-drawing/scrolling/fixed/fixed-position-out-of-view-negative-zindex-expected.txt:
  • tiled-drawing/scrolling/fixed/four-bars-expected.txt:
  • tiled-drawing/scrolling/fixed/four-bars-with-header-and-footer-expected.txt:
  • tiled-drawing/scrolling/fixed/four-bars-zoomed-expected.txt:
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-expected.txt:
  • tiled-drawing/scrolling/fixed/negative-scroll-offset-in-view-expected.txt:
  • tiled-drawing/scrolling/fixed/nested-fixed-expected.txt:
  • tiled-drawing/scrolling/fixed/percentage-inside-fixed-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-in-fixed-expected.txt:
  • tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor-expected.txt:
  • tiled-drawing/scrolling/frames/fixed-inside-frame-expected.txt:
  • tiled-drawing/scrolling/frames/remove-coordinated-frame-expected.txt:
  • tiled-drawing/scrolling/frames/scroll-region-after-frame-layout-expected.txt:
  • tiled-drawing/scrolling/scrolling-tree-after-scroll-expected.txt:
  • tiled-drawing/scrolling/scrolling-tree-slow-scrolling-expected.txt:
  • tiled-drawing/scrolling/sticky/negative-scroll-offset-expected.txt:
  • tiled-drawing/scrolling/sticky/sticky-horizontal-expected.txt:
  • tiled-drawing/scrolling/sticky/sticky-vertical-expected.txt:
9:51 AM Changeset in webkit [216510] by Chris Dumez
  • 9 edits
    2 adds in trunk

ontransitionend eventHandler should be in GlobalEventHandlers
https://bugs.webkit.org/show_bug.cgi?id=171836

Reviewed by Ryosuke Niwa.

Source/WebCore:

ontransitionend eventHandler should be in GlobalEventHandlers:

WebKit currently has in on Window and Element only. Firefox matches the specification.

Test: fast/css/ontransitionend-eventhandler.html

  • dom/Element.idl:
  • dom/GlobalEventHandlers.idl:
  • page/DOMWindow.idl:

LayoutTests:

  • fast/css/ontransitionend-eventhandler-expected.txt: Added.
  • fast/css/ontransitionend-eventhandler.html: Added.

Add layout test coverage.

  • fast/dom/event-handler-attributes-expected.txt:
  • fast/dom/event-handler-attributes.html:
  • js/dom/dom-static-property-for-in-iteration-expected.txt:

Rebaseline existing tests to reflect behavior change.

9:00 AM Changeset in webkit [216509] by nael.ouedraogo@crf.canon.fr
  • 4 edits in trunk/Source/WebCore

MediaSource.readyState should use an IDL enum
https://bugs.webkit.org/show_bug.cgi?id=171672

Reviewed by Eric Carlson and Chris Dumez.

MediaSource.readyState should use an IDL enum as per specification
(https://www.w3.org/TR/2016/CR-media-source-20160503/#idl-def-ReadyState).

No new tests required since no behavior change.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::toString):
(WebCore::MediaSource::MediaSource):
(WebCore::MediaSource::setPrivateAndOpen):
(WebCore::MediaSource::buffered):
(WebCore::MediaSource::setReadyState):
(WebCore::MediaSource::streamEndedWithError):
(WebCore::MediaSource::isOpen):
(WebCore::MediaSource::isClosed):
(WebCore::MediaSource::isEnded):
(WebCore::MediaSource::detachFromElement):
(WebCore::MediaSource::openIfInEndedState):
(WebCore::MediaSource::stop):
(WebCore::MediaSource::onReadyStateChange):

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/MediaSource.idl:
8:58 AM Changeset in webkit [216508] by nael.ouedraogo@crf.canon.fr
  • 5 edits
    2 adds in trunk

Invalid MediaSource duration value should throw TyperError instead of InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=171653

Reviewed by Youenn Fablet.

Modify MediaSource::setDuration to throw a TypeError when duration value is invalid as per MSE specification
(https://www.w3.org/TR/2016/REC-media-source-20161117/#dom-mediasource-duration).

Update expectation of corresponding WPT test.

Source/WebCore:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::setDuration):
(WebCore::MediaSource::setDurationInternal):

LayoutTests:

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
  • platform/mac/TestExpectations:
  • platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-duration-boundaryconditions-expected.txt: Added.
8:06 AM Changeset in webkit [216507] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

Unreviewed, update binding-tests results
https://bugs.webkit.org/show_bug.cgi?id=166752

  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
8:04 AM Changeset in webkit [216506] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Update DocumentOrShadowRoot.idl to match specifications
https://bugs.webkit.org/show_bug.cgi?id=171845

Reviewed by Ryosuke Niwa.

Update DocumentOrShadowRoot.idl to match specifications:

No Web-facing behavior change. Things that do not match the specification were merely
annotated with FIXME comments.

  • dom/Document.idl:
  • dom/DocumentOrShadowRoot.idl:
7:53 AM Changeset in webkit [216505] by Jonathan Bedard
  • 2 edits in trunk/Tools

REGRESSION: ImageDiff not building with make
https://bugs.webkit.org/show_bug.cgi?id=171788

Reviewed by Alex Christensen.

  • Makefile: Build ImageDiff for all platforms.
7:50 AM Changeset in webkit [216504] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[Win] ImageDiff isn't built since Bug 168945
https://bugs.webkit.org/show_bug.cgi?id=171847

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Alex Christensen.

  • CMakeLists.txt: Add 'ImageDiff' sub-directory to build if WIN32.
  • ImageDiff/ImageDiff.cpp: Include some header files to fix compilation errors.
  • ImageDiff/PlatformWin.cmake: Define USE_CAIRO if WinCairo port.
6:00 AM Changeset in webkit [216503] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebCore

Unreviewed, attempt to fix macOS ports using ApplePay
https://bugs.webkit.org/show_bug.cgi?id=166752

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

5:38 AM Changeset in webkit [216502] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Coordinated Graphics] Debug Visuals don't hide
https://bugs.webkit.org/show_bug.cgi?id=162704

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-05-09
Reviewed by Žan Doberšek.

Source/WebCore:

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setShowDebugBorder):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::setDebugBorder):
showDebugBorders() and showRepaintCounter() of CoordinatedGraphicsLayer should reflect
the "show" argument to the layer state.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:

(WebCore::DebugVisuals::DebugVisuals):
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
To set the debug visuals of a layer, the visibility flags of the borders and the repaint
counters as well as the border width and color are needed. Thus a new bundle struct
DebugVisuals and its change flag debugVisualsChanged have been introduced in order to
send the information at once.

Source/WebKit2:

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::decode):
(IPC::ArgumentCoder<DebugVisuals>::encode):
(IPC::ArgumentCoder<DebugVisuals>::decode):
The encoder and decoder for DebugVisuals have been added.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::setLayerState):
Update the debug visuals of a layer according to the DebugVisuals information
if the debugVisualsChanged flag is set to true.

5:17 AM Changeset in webkit [216501] by Yusuke Suzuki
  • 59 edits
    2 copies
    1 move
    4 adds in trunk

Handle IDLPromise<> properly
https://bugs.webkit.org/show_bug.cgi?id=166752

Reviewed by Youenn Fablet.

Source/JavaScriptCore:

Add JSPromise::resolve static function.
This applies Promise.resolve() conversion to a given value.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::promiseResolveFunction):

  • runtime/JSPromise.cpp:

(JSC::JSPromise::resolve):

  • runtime/JSPromise.h:

Source/WebCore:

This patch implements WebIDL Promise type conversion. According to the spec,
Promise takes a value and convert it to Promise by using Promise.resolve function.
We implement JSPromise::resolve in JSC and use it in JSDOMConvertPromise.

In conversion phase, we just convert the value to JSC::JSPromise* and hold it in
PromiseRejectionEvent. On the other hand, In this patch, we newly introduce a new
type DOMPromise and use it in RejectedPromiseTracker. And we also rename the previous
DOMPromise to DOMPromiseDeferred since it is corresponding to JSPromiseDeferred.
DOMPromise is DOMGuarded object. So it is strongly referenced from ScriptExecutionContext
and it is weakly referenced from the object itself. This is important since Strong<JSPromise>
reference in C++ object that has a wrapper (in this case, PromiseRejectionEvent) easily causes
cyclic reference. We hold it as DOMPromise instead of Strong<JSPromise> in RejectedPromiseTracker
to break the cyclic reference edge with weak reference.

In the meantime, we still use JSC::Strong<> in PromiseRejectionEvent. It leaks memory if promise
refers the wrapper object of PromiseRejectionEvent. CustomEvent also has the same problem.
This is a general problem that attribute any can create cyclic reference. And they should be
fixed in a different patch.

Currently, we do not take the following approach. e.g. There is C++ object that represents Promise.
And its wrapper object is JSPromise thing. When exposing the C++ object, it will be converted to a
wrapper object. We do not take this approach because PromiseRejectionEvent can take user-provided promise.
For example, users can create PromiseRejectionEvent in a form
new PromiseRejectionEvent("...", { promise: promise }). In this case, event.promise === promise
is required. And this is not suitable for the above C++ object model.

Large part of this patch is mechanical one to replace DOMPromise with DOMPromiseDeferred.

  • CMakeLists.txt:
  • Modules/applepay/ApplePaySession.cpp:
  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeySystemAccess.h:
  • Modules/encryptedmedia/MediaKeys.h:
  • Modules/encryptedmedia/NavigatorEME.h:
  • Modules/fetch/DOMWindowFetch.h:
  • Modules/fetch/FetchBody.h:
  • Modules/fetch/FetchBodyConsumer.h:
  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/WorkerGlobalScopeFetch.h:
  • Modules/mediastream/MediaDevices.h:
  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::replaceTrack):
(WebCore::MediaEndpointPeerConnection::replaceTrackTask):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::applyConstraints):

  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::setLocalDescription):
(WebCore::PeerConnectionBackend::setRemoteDescription):
(WebCore::PeerConnectionBackend::addIceCandidate):

  • Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::endOfIceCandidates):

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::enqueueReplaceTrackTask):
(WebCore::RTCPeerConnection::replaceTrack):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack):

  • Modules/mediastream/RTCRtpSender.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start):
(WebCore::UserMediaRequest::UserMediaRequest):

  • Modules/mediastream/UserMediaRequest.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::replaceTrack):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
  • Modules/streams/ReadableStreamSource.h:

(WebCore::ReadableStreamSource::start):
(WebCore::ReadableStreamSource::pull):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::addReaction):
(WebCore::AudioContext::setState):
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):

  • Modules/webaudio/AudioContext.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/IDLTypes.h:
  • bindings/js/CachedModuleScriptLoaderClient.h:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSCustomElementRegistryCustom.cpp:
  • bindings/js/JSDOMConvertPromise.h:

(WebCore::Converter<IDLPromise<T>>::convert):
(WebCore::JSConverter<IDLPromise<T>>::convert):

  • bindings/js/JSDOMExceptionHandling.cpp:
  • bindings/js/JSDOMGlobalObject.cpp:
  • bindings/js/JSDOMGuardedObject.h:
  • bindings/js/JSDOMPromise.h:

(WebCore::DOMPromise::create):
(WebCore::DOMPromise::promise):
(WebCore::DOMPromise::DOMPromise):
(WebCore::DeferredPromise::create): Deleted.
(WebCore::DeferredPromise::resolve): Deleted.
(WebCore::DeferredPromise::resolveWithNewlyCreated): Deleted.
(WebCore::DeferredPromise::reject): Deleted.
(WebCore::DeferredPromise::resolveWithCallback): Deleted.
(WebCore::DeferredPromise::rejectWithCallback): Deleted.
(WebCore::DeferredPromise::DeferredPromise): Deleted.
(WebCore::DeferredPromise::deferred): Deleted.
(WebCore::DOMPromiseBase::DOMPromiseBase): Deleted.
(WebCore::DOMPromiseBase::operator=): Deleted.
(WebCore::DOMPromiseBase::reject): Deleted.
(WebCore::DOMPromiseBase::rejectType): Deleted.
(WebCore::DOMPromiseBase::promise): Deleted.
(WebCore::DOMPromise::resolve): Deleted.
(WebCore::DOMPromise<void>::resolve): Deleted.
(WebCore::callPromiseFunction): Deleted.
(WebCore::bindingPromiseFunctionAdapter): Deleted.

  • bindings/js/JSDOMPromiseDeferred.cpp: Renamed from Source/WebCore/bindings/js/JSDOMPromise.cpp.

(WebCore::DeferredPromise::promise):
(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::reject):
(WebCore::rejectPromiseWithExceptionIfAny):
(WebCore::createDeferredPromise):
(WebCore::createRejectedPromiseWithTypeError):
(WebCore::parseAsJSON):
(WebCore::fulfillPromiseWithJSON):
(WebCore::fulfillPromiseWithArrayBuffer):

  • bindings/js/JSDOMPromiseDeferred.h: Copied from Source/WebCore/bindings/js/JSDOMPromise.h.

(WebCore::DeferredPromise::create):
(WebCore::DeferredPromise::resolve):
(WebCore::DeferredPromise::resolveWithNewlyCreated):
(WebCore::DeferredPromise::reject):
(WebCore::DeferredPromise::resolveWithCallback):
(WebCore::DeferredPromise::rejectWithCallback):
(WebCore::DeferredPromise::DeferredPromise):
(WebCore::DeferredPromise::deferred):
(WebCore::DOMPromiseDeferredBase::DOMPromiseDeferredBase):
(WebCore::DOMPromiseDeferredBase::operator=):
(WebCore::DOMPromiseDeferredBase::reject):
(WebCore::DOMPromiseDeferredBase::rejectType):
(WebCore::DOMPromiseDeferredBase::promise):
(WebCore::DOMPromiseDeferred::resolve):
(WebCore::DOMPromiseDeferred<void>::resolve):
(WebCore::callPromiseFunction):
(WebCore::bindingPromiseFunctionAdapter):

  • bindings/js/JSSubtleCryptoCustom.cpp:
  • bindings/js/JSWebGPUCommandBufferCustom.cpp:
  • bindings/js/JSWebKitSubtleCryptoCustom.cpp:
  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp: Added.

(WebCore::convertDictionary<TestPromiseRejectionEvent::Init>):
(WebCore::JSTestPromiseRejectionEventPrototype::create):
(WebCore::JSTestPromiseRejectionEventPrototype::createStructure):
(WebCore::JSTestPromiseRejectionEventPrototype::JSTestPromiseRejectionEventPrototype):
(WebCore::JSTestPromiseRejectionEventConstructor::construct):
(WebCore::JSTestPromiseRejectionEventConstructor::prototypeForStructure):
(WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):
(WebCore::JSTestPromiseRejectionEventPrototype::finishCreation):
(WebCore::JSTestPromiseRejectionEvent::JSTestPromiseRejectionEvent):
(WebCore::JSTestPromiseRejectionEvent::finishCreation):
(WebCore::JSTestPromiseRejectionEvent::createPrototype):
(WebCore::JSTestPromiseRejectionEvent::prototype):
(WebCore::BindingCaller<JSTestPromiseRejectionEvent>::castForAttribute):
(WebCore::jsTestPromiseRejectionEventPromise):
(WebCore::jsTestPromiseRejectionEventPromiseGetter):
(WebCore::jsTestPromiseRejectionEventReason):
(WebCore::jsTestPromiseRejectionEventReasonGetter):
(WebCore::jsTestPromiseRejectionEventConstructor):
(WebCore::setJSTestPromiseRejectionEventConstructor):
(WebCore::JSTestPromiseRejectionEvent::getConstructor):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):

  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.h: Added.

(WebCore::JSTestPromiseRejectionEvent::create):
(WebCore::JSTestPromiseRejectionEvent::createStructure):
(WebCore::JSTestPromiseRejectionEvent::wrapped):
(WebCore::toJS):
(WebCore::toJSNewlyCreated):

  • bindings/scripts/test/TestPromiseRejectionEvent.idl: Copied from Source/WebCore/bindings/js/CachedModuleScriptLoaderClient.h.
  • css/FontFace.h:
  • css/FontFaceSet.h:
  • dom/CustomElementRegistry.h:
  • dom/PromiseRejectionEvent.h:
  • dom/RejectedPromiseTracker.cpp:

(WebCore::UnhandledPromise::UnhandledPromise):
(WebCore::UnhandledPromise::callStack):
(WebCore::UnhandledPromise::promise):
(WebCore::RejectedPromiseTracker::promiseRejected):
(WebCore::RejectedPromiseTracker::promiseHandled):
(WebCore::RejectedPromiseTracker::reportUnhandledRejections):
(WebCore::RejectedPromiseTracker::reportRejectionHandled):
(WebCore::RejectedPromise::RejectedPromise): Deleted.
(WebCore::RejectedPromise::globalObject): Deleted.
(WebCore::RejectedPromise::promise): Deleted.

  • dom/RejectedPromiseTracker.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rejectPendingPlayPromises):
(WebCore::HTMLMediaElement::resolvePendingPlayPromises):
(WebCore::HTMLMediaElement::play):

  • html/HTMLMediaElement.h:
  • platform/graphics/gpu/GPUCommandBuffer.h:
  • testing/Internals.h:

LayoutTests:

  • js/dom/promise-rejection-event-should-follow-webidl-promise-conversion-rule-expected.txt: Added.
  • js/dom/promise-rejection-event-should-follow-webidl-promise-conversion-rule.html: Added.
5:03 AM Changeset in webkit [216500] by zandobersek@gmail.com
  • 1 edit
    3007 adds in trunk/LayoutTests

Unreviewed. Landing the WPE layout test baselines.

Baseline filenames are omitted for brevity.

  • platform/wpe/TestExpectations: Added.
  • platform/wpe/animations/: Added.
  • platform/wpe/css1/: Added.
  • platform/wpe/css2.1/: Added.
  • platform/wpe/css3/: Added.
  • platform/wpe/fast/: Added.
  • platform/wpe/ietestcenter/: Added.
  • platform/wpe/js/: Added.
  • platform/wpe/scrollbars/: Added.
  • platform/wpe/security/: Added.
  • platform/wpe/sputnik/: Added.
  • platform/wpe/tables/: Added.
  • platform/wpe/transforms/: Added.
  • platform/wpe/transitions/: Added.
4:14 AM Changeset in webkit [216499] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.14.7

WebKitGTK+ 2.14.7

4:09 AM Changeset in webkit [216498] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.14

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.14.7 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.14.7.
4:07 AM Changeset in webkit [216497] by zandobersek@gmail.com
  • 95 edits
    130 adds in trunk

Upstream the WPE port
https://bugs.webkit.org/show_bug.cgi?id=171110

Reviewed by Alex Christensen.

.:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

  • CMakeLists.txt: Add the WPE port identifier.
  • Source/cmake/FindLibGBM.cmake: Added.
  • Source/cmake/FindWPEBackend-mesa.cmake: Added.
  • Source/cmake/FindWPEBackend.cmake: Added.
  • Source/cmake/OptionsWPE.cmake: Added.

Source/JavaScriptCore:

  • PlatformWPE.cmake: Added.
  • shell/PlatformWPE.cmake: Added.

Source/ThirdParty/ANGLE:

  • include/EGL/eglplatform.h:

Allow building WPE on platforms that don't provide X11 libraries.

Source/WebCore:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Existing files mostly changed to properly use PLATFORM(WPE) build guards.
In-file changes removed from this ChangeLog entry for brevity.

  • CMakeLists.txt:
  • PlatformWPE.cmake: Added.
  • accessibility/AccessibilityObject.h:
  • accessibility/wpe/AXObjectCacheWPE.cpp: Added.
  • accessibility/wpe/AccessibilityObjectWPE.cpp: Copied from Source/WebCore/platform/audio/glib/AudioBusGLib.cpp.
  • config.h:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • editing/Editor.cpp:
  • editing/Editor.h:
  • editing/wpe/EditorWPE.cpp: Added.
  • page/EventHandler.cpp:
  • page/wpe/EventHandlerWPE.cpp: Added.
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/MainThreadSharedTimer.cpp:
  • platform/MainThreadSharedTimer.h:
  • platform/Pasteboard.h:
  • platform/PasteboardStrategy.h:
  • platform/PlatformPasteboard.h:
  • platform/SchemeRegistry.cpp:
  • platform/Widget.h:
  • platform/audio/glib/AudioBusGLib.cpp:
  • platform/glib/FileSystemGlib.cpp:
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GLContext.cpp:
  • platform/graphics/GLContext.h:
  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/PlatformDisplay.cpp:
  • platform/graphics/PlatformDisplay.h:
  • platform/graphics/egl/GLContextEGL.cpp:
  • platform/graphics/egl/GLContextEGL.h:
  • platform/graphics/egl/GLContextEGLWPE.cpp: Copied from Source/WebCore/platform/audio/glib/AudioBusGLib.cpp.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
  • platform/graphics/wpe/IconWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/graphics/wpe/ImageWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/graphics/wpe/PlatformDisplayWPE.cpp: Added.
  • platform/graphics/wpe/PlatformDisplayWPE.h: Added.
  • platform/wpe/CursorWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/LocalizedStringsWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/PasteboardWPE.cpp: Added.
  • platform/wpe/PlatformKeyboardEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/PlatformPasteboardWPE.cpp: Added.
  • platform/wpe/PlatformScreenWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/RenderThemeWPE.cpp: Copied from Source/WebKit2/Shared/NativeWebWheelEvent.h.
  • platform/wpe/RenderThemeWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/ScrollbarThemeWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/ScrollbarThemeWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/SoundWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/ThemeWPE.cpp: Added.
  • platform/wpe/ThemeWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • platform/wpe/WidgetWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.

Source/WebCore/PAL:

  • pal/PlatformWPE.cmake: Added.

Source/WebKit2:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Existing files changed to properly use PLATFORM(WPE) build guards or other
WPE-specific additions (e.g. pasteboard support).
In-file changes removed from this ChangeLog entry for brevity.

  • Platform/IPC/glib/GSocketMonitor.cpp:
  • PlatformWPE.cmake: Added.
  • Scripts/generate-forwarding-headers.pl:
  • Shared/API/c/WKBase.h:
  • Shared/API/c/wpe/WKBaseWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • Shared/API/c/wpe/WebKit.h: Added.
  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
  • Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
  • Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
  • Shared/DrawingAreaInfo.h:
  • Shared/NativeWebKeyboardEvent.h:
  • Shared/NativeWebMouseEvent.h:
  • Shared/NativeWebTouchEvent.h:
  • Shared/NativeWebWheelEvent.h:
  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebPreferencesDefinitions.h:
  • Shared/wpe/NativeWebKeyboardEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • Shared/wpe/NativeWebMouseEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • Shared/wpe/NativeWebTouchEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • Shared/wpe/NativeWebWheelEventWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • Shared/wpe/ProcessExecutablePathWPE.cpp: Added.
  • Shared/wpe/WebEventFactory.cpp: Added.
  • Shared/wpe/WebEventFactory.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/wpe/WKAPICastWPE.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/C/wpe/WKView.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/C/wpe/WKView.h: Copied from Source/WebKit2/Shared/NativeWebWheelEvent.h.
  • UIProcess/API/wpe/CompositingManagerProxy.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/wpe/CompositingManagerProxy.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/wpe/CompositingManagerProxy.messages.in: Added.
  • UIProcess/API/wpe/DrawingAreaProxyWPE.cpp: Added.
  • UIProcess/API/wpe/DrawingAreaProxyWPE.h: Copied from Source/WebKit2/Shared/NativeWebWheelEvent.h.
  • UIProcess/API/wpe/PageClientImpl.cpp: Added.
  • UIProcess/API/wpe/PageClientImpl.h: Added.
  • UIProcess/API/wpe/ScrollGestureController.cpp: Added.
  • UIProcess/API/wpe/ScrollGestureController.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/wpe/WPEView.cpp: Added.
  • UIProcess/API/wpe/WPEView.h: Added.
  • UIProcess/API/wpe/WPEViewClient.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/wpe/WPEViewClient.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/API/wpe/WebKit2InspectorGResourceBundle.xml: Added.
  • UIProcess/ChildProcessProxy.cpp:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp: Added.
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebPasteboardProxy.h:
  • UIProcess/WebPasteboardProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:
  • UIProcess/wpe/TextCheckerWPE.cpp: Added.
  • UIProcess/wpe/WebInspectorProxyWPE.cpp: Added.
  • UIProcess/wpe/WebPageProxyWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/wpe/WebPasteboardProxyWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • UIProcess/wpe/WebPreferencesWPE.cpp: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
  • UIProcess/wpe/WebProcessPoolWPE.cpp: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebKit2Prefix.h:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/wpe/WebContextMenuClientWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp: Added.
  • WebProcess/WebCoreSupport/wpe/WebPopupMenuWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
  • WebProcess/WebPage/DrawingArea.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/wpe/CompositingManager.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebProcess/WebPage/wpe/CompositingManager.h: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebProcess/WebPage/wpe/DrawingAreaWPE.cpp: Added.
  • WebProcess/WebPage/wpe/DrawingAreaWPE.h: Added.
  • WebProcess/WebPage/wpe/WebInspectorUIWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebProcess/WebPage/wpe/WebInspectorWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebProcess/WebPage/wpe/WebPageWPE.cpp: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
  • WebProcess/wpe/WebProcessMainWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • wpe/wpe-webkit.pc.in: Added.

Source/WTF:

  • wtf/Platform.h:
  • wtf/PlatformWPE.cmake: Added.
  • wtf/glib/RunLoopSourcePriority.h:

Tools:

webkit-dev thread:
https://lists.webkit.org/pipermail/webkit-dev/2017-April/028923.html

Add WPE support to various tooling scripts, TestWebKitAPI and WebKitTestRunner.
In-file changes removed from this ChangeLog entry for brevity.

  • BuildSlaveSupport/built-product-archive:
  • BuildSlaveSupport/test-result-archive:
  • CMakeLists.txt:
  • ImageDiff/PlatformWPE.cmake: Added.
  • Scripts/build-dumprendertree:
  • Scripts/build-webkit:
  • Scripts/build-webkittestrunner:
  • Scripts/update-webkit-libs-jhbuild:
  • Scripts/update-webkitwpe-libs: Added.
  • Scripts/webkitdirs.pm:
  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  • Scripts/webkitpy/port/factory.py:
  • Scripts/webkitpy/port/wpe.py: Added.
  • TestWebKitAPI/PlatformWPE.cmake: Added.
  • TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • TestWebKitAPI/wpe/PlatformUtilitiesWPE.cpp: Added.
  • TestWebKitAPI/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Added.
  • WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Added.
  • WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp: Added.
  • WebKitTestRunner/InjectedBundle/wpe/InjectedBundleWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • WebKitTestRunner/PlatformWPE.cmake: Added.
  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp:
  • WebKitTestRunner/wpe/EventSenderProxyWPE.cpp: Added.
  • WebKitTestRunner/wpe/HeadlessViewBackend.cpp: Added.
  • WebKitTestRunner/wpe/HeadlessViewBackend.h: Copied from Source/WebKit2/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h.
  • WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Added.
  • WebKitTestRunner/wpe/TestControllerWPE.cpp: Added.
  • WebKitTestRunner/wpe/main.cpp: Copied from Source/WebKit2/Shared/DrawingAreaInfo.h.
  • jhbuild/jhbuild-wrapper:
  • wpe/generate-inspector-gresource-manifest.py: Added.
  • wpe/jhbuild.modules: Added.
  • wpe/jhbuildrc: Added.
  • wpe/patches/cairo-egl-device-create-for-egl-surface.patch: Added.
  • wpe/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
  • wpe/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Added.
  • wpe/patches/gdate-suppress-string-format-literal-warning.patch: Added.
  • wpe/patches/glib-warning-fix.patch: Added.
  • wpe/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
  • wpe/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
  • wpe/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
  • wpe/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
  • wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Added.
3:21 AM Changeset in webkit [216496] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216343 - [GTK] Cannot sign in with new Google sign-in page
https://bugs.webkit.org/show_bug.cgi?id=171770

Reviewed by Carlos Garcia Campos.

Google's new authentication page does not work with the Firefox user
agent that's required to make various Google websites work. Special-case
accounts.google.com so that it receives our standard user agent.

  • platform/UserAgentQuirks.cpp:

(WebCore::isGoogle):
(WebCore::urlRequiresFirefoxBrowser):

3:21 AM Changeset in webkit [216495] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.14

Merge r216139 - YouTube user agent quirk breaks new YouTube
https://bugs.webkit.org/show_bug.cgi?id=171603

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Our user agent quirk to make YouTube 360 work breaks the new YouTube UI, causing it to
attempt to use the obsolete custom elements v0 API. WebKit only supports the v1 API. We
have to remove this quirk.

Note this does not affect Safari as Apple ports don't use our user agent quirks.

  • platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):

Tools:

Remove the YouTube quirk test.

  • TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

3:11 AM Changeset in webkit [216494] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r215613 - Do not paint the border of the box if the dirty region does not intersect with border area
https://bugs.webkit.org/show_bug.cgi?id=170988

Reviewed by Simon Fraser.

No new tests, since there is no change in behavior.

  • platform/graphics/GeometryUtilities.cpp:

(WebCore::ellipseContainsPoint):
Checks if a point is within an ellipse.

  • platform/graphics/GeometryUtilities.h:

Replace header-guards with #pragma once.

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::contains):
Implemented to know the dirty rectangle intersects with rounded rectangle or not.

  • platform/graphics/RoundedRect.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):
When typing in decorated text box, the dirty rect generated only for the
inside of the text box, not for the decorations. So we can avoid the
calculations to draw borders if the inner border totally covers the
target surface. It will optimize the rendering process since we don't
have to render border decorations whenever we type somethings in side of
the text input element.

3:00 AM Changeset in webkit [216493] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216240 - [GStreamer] Do not report more errors after the first one
https://bugs.webkit.org/show_bug.cgi?id=171722

Reviewed by Xabier Rodriguez-Calvar.

We can receive several error messages for the same error from different elements. That's not expected by the
media source selection algorithm implementation. I don't know if didn't happen with previous versions of GST,
but since the upgrade to 1.10.4 several tests are failing because of this.

Fixes: media/video-error-does-not-exist.html

media/video-load-networkState.html
media/video-source-error.html
media/video-source-none-supported.html
media/video-source-moved.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Return early also when an error already occured.

2:59 AM Changeset in webkit [216492] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216239 - [GStreamer] Fix handling of gst errors in MediaPlayerPrivateGStreamer::handleMessage
https://bugs.webkit.org/show_bug.cgi?id=171721

Reviewed by Xabier Rodriguez-Calvar.

We are checking the GError only comparing the code, and ignoring the domain in some cases. Use g_error_matches()
in those cases instead of only checking the code.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

2:58 AM Changeset in webkit [216491] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216067 - [GStreamer] Dailymotion live stream videos don't play
https://bugs.webkit.org/show_bug.cgi?id=170767

Reviewed by Sergio Villar Senin.

The video shows a message saying that an error occurred and nothing is played. There are actually several
problems with dailymotion. The main issue is that URLs are redirected by the server, and GStreamer needs to
know the redirected URL. Once GStreamer knows the redirected URL the error message no longer appears, the video
starts but it always stops after a few seconds. This is because the source receives an early EOS while still
downloading the fragments. The reason of the early EOS is because dailymotion sends a wrong Content-Length header,
something that is expected to happen and we correctly handle that case when receiving the data, by updating the
size accordingly if the bytes received are longer than the expected content length. This particular case
doesn't work well with GStreamer automatic EOS handling, which is the default. At some point, GStreamer detects
that the bytes received are at least the expected ones and emits a GST_EVENT_EOS that the GstUriDownloader
handles finishing the download early. We should always disable automatic EOS, since we know when EOS actually
happens and we already call gst_app_src_end_of_stream(). This patch also emits a GST_EVENT_CUSTOM_DOWNSTREAM_STICKY
event to let GStreamer know about the HTTP headers sent and received.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webkit_web_src_init): Disable automatic EOS.
(webKitWebSrcGetProperty): Return the redirected URL in case of redirection.
(webKitWebSrcStart): Pass the ResourceRequest to the stream clients.
(webKitWebSrcQueryWithParent): Set the redirected URL in the query in case of redirection.
(webKitWebSrcSetUri): Clear also the redirected URL when setting a new URI.
(StreamingClient::StreamingClient): Use GRefPtr for the source and initialize the request too.
(StreamingClient::~StreamingClient): Remove explicit unref.
(StreamingClient::createReadBuffer):
(StreamingClient::handleResponseReceived): Initialize the redirected URL in case of redirection. Create and push
the HTTP headers event.
(StreamingClient::handleDataReceived):
(StreamingClient::handleNotifyFinished):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::accessControlCheckFailed):
(CachedResourceStreamingClient::loadFailed):
(ResourceHandleStreamingClient::ResourceHandleStreamingClient):
(ResourceHandleStreamingClient::didFail):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

2:58 AM Changeset in webkit [216490] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r212349 - [GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
https://bugs.webkit.org/show_bug.cgi?id=168322

Reviewed by Žan Doberšek.

It currently returns true unconditionally. Add resolved-location property to WebKitWebSourceGStreamer to track
the resolved url returned by the server and use that from MediaPlayerPrivate to check if there was a cross
origin redirection.

Fixes: http/tests/security/canvas-remote-read-remote-video-redirect.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcFinalize):
(webKitWebSrcGetProperty):
(webKitWebSrcStart):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(StreamingClient::handleResponseReceived):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

2:58 AM Changeset in webkit [216489] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r216065 - [GTK] Crash at WebCore::ResourceHandle::clearClient() when streaming live video from dailymotion
https://bugs.webkit.org/show_bug.cgi?id=169725

Reviewed by Michael Catanzaro.

Make ResourceHandleStreamingClient refcounted and add an invalidate method to do the cleanup in the networking
thread while keeping a reference.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStop): Call invalidate before reseting client pointer.
(webKitWebSrcStart): Ditto.
(ResourceHandleStreamingClient::ResourceHandleStreamingClient): Remove all cleanup code after the run loop run call.
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Just detach the thread.
(ResourceHandleStreamingClient::invalidate): Schedule a task on the networking thread to clean up and fiish the
run loop, protecting this.
(ResourceHandleStreamingClient::setDefersLoading): Protect this.
(ResourceHandleStreamingClient::didReceiveResponse): Do nothing if client was invalidated.
(ResourceHandleStreamingClient::didReceiveBuffer): Ditto.
(ResourceHandleStreamingClient::didFinishLoading): Ditto.

2:41 AM Changeset in webkit [216488] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix property names in ScrollingTreeScrollingNode::dumpProperties
https://bugs.webkit.org/show_bug.cgi?id=171848

Patch by Frederic Wang <fwang@igalia.com> on 2017-05-09
Reviewed by Gyuyoung Kim.

No new tests, this function is only used for debugging purpose.

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::dumpProperties):

2:40 AM Changeset in webkit [216487] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r215102 - REGRESSION(r204512): WebSocket errors with "Failed to send WebSocket frame." if too much data is sent
https://bugs.webkit.org/show_bug.cgi?id=170463

Reviewed by Michael Catanzaro.

This only reproduces when using WebSockets to communicate with an external server.
When communicating with a local server, CFWriteStreamWrite succeeds too reliably, so
CFWriteStreamCanAcceptBytes returns true, when sometimes it doesn't when communicating
across the real internet.

  • platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):

  • platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::platformSendInternal):
Returning std::nullopt means there was an error, which is not true when the socket stream
is in a state where it cannot be written to because it is actively communicating.
Returning 0 means 0 new bytes were sent, so we will try again later.

2:00 AM Changeset in webkit [216486] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.16.2

WebKitGTK+ 2.16.2

1:59 AM Changeset in webkit [216485] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.16

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.16.2.
12:46 AM Changeset in webkit [216484] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.16/Source

Merge r216483 - [GTK] Building Webkit2Gtk without OpenGL fails.
https://bugs.webkit.org/show_bug.cgi?id=170959

Reviewed by Žan Doberšek.

Source/WebCore:

  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:

Source/WebKit2:

  • UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

12:45 AM Changeset in webkit [216483] by Carlos Garcia Campos
  • 6 edits in trunk/Source

[GTK] Building Webkit2Gtk without OpenGL fails.
https://bugs.webkit.org/show_bug.cgi?id=170959

Reviewed by Žan Doberšek.

Source/WebCore:

  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:

Source/WebKit2:

  • UIProcess/gtk/HardwareAccelerationManager.cpp:

(WebKit::HardwareAccelerationManager::HardwareAccelerationManager):

12:37 AM Changeset in webkit [216482] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[AppleWin] CaptureDeviceManager.cpp: error C2813: #import is not supported with /MP
https://bugs.webkit.org/show_bug.cgi?id=171849

Patch by Fujii Hironori <Fujii Hironori> on 2017-05-09
Reviewed by Per Arne Vollan.

  • platform/mediastream/CaptureDeviceManager.cpp: Replaced #import with #include.
12:15 AM Changeset in webkit [216481] by sbarati@apple.com
  • 10 edits
    2 adds in trunk/Source/JavaScriptCore

CallLinkInfos belonging to Wasm->JS stubs need to be informed when we clearCode() from all Executables
https://bugs.webkit.org/show_bug.cgi?id=171707
<rdar://problem/31891649>

Reviewed by Filip Pizlo.

This patch fixes a bug where a Wasm->JS IC call stub would go stale
and point into a CodeBlock no longer owned by any executable. The
problematic scenario is this:

  1. We generate the call IC which has a branch on a callee check. This callee owns the Executable in question. If the branch succeeds, it will call code belonging to a particular CodeBlock associated with that Executable.
  1. Heap::deleteAllCodeBlocks is called. This leads the Executable to clear its various CodeBlock references.
  1. Wasm has no idea this happened, so now it has stale ICs that point into code from a CodeBlock no longer belonging to an Executable.

This patch fixes the bug by informing all JSWebAssemblyCodeBlocks to unlink
their CallLinkInfo when Heap::deleteAllCodeBlocks is called.

We track all JSWebAssemblyCodeBlocks by creating a new subspace for them.
This allows us to quickly iterate over the live JSWebAssemblyCodeBlocks in the
heap.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.cpp:

(JSC::Heap::deleteAllCodeBlocks):

  • heap/Subspace.h:
  • heap/SubspaceInlines.h:

(JSC::Subspace::forEachLiveCell):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::clearJSCallICs):

  • wasm/js/JSWebAssemblyCodeBlock.h:

(JSC::JSWebAssemblyCodeBlock::createStructure): Deleted.
(JSC::JSWebAssemblyCodeBlock::functionImportCount): Deleted.
(JSC::JSWebAssemblyCodeBlock::module): Deleted.
(JSC::JSWebAssemblyCodeBlock::jsEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyCodeBlock::wasmEntrypointLoadLocationFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyCodeBlock::wasmToJsCallStubForImport): Deleted.
(JSC::JSWebAssemblyCodeBlock::offsetOfImportWasmToJSStub): Deleted.
(JSC::JSWebAssemblyCodeBlock::codeBlock): Deleted.
(JSC::JSWebAssemblyCodeBlock::offsetOfImportStubs): Deleted.
(JSC::JSWebAssemblyCodeBlock::allocationSize): Deleted.
(JSC::JSWebAssemblyCodeBlock::importWasmToJSStub): Deleted.

  • wasm/js/JSWebAssemblyCodeBlockSubspace.cpp: Added.

(JSC::JSWebAssemblyCodeBlockSubspace::JSWebAssemblyCodeBlockSubspace):
(JSC::JSWebAssemblyCodeBlockSubspace::~JSWebAssemblyCodeBlockSubspace):
(JSC::JSWebAssemblyCodeBlockSubspace::finishSweep):
(JSC::JSWebAssemblyCodeBlockSubspace::destroy):

  • wasm/js/JSWebAssemblyCodeBlockSubspace.h: Added.
Note: See TracTimeline for information about the timeline view.