Timeline



Aug 22, 2017:

11:45 PM Changeset in webkit [221069] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed. The WPE port should build TestWebKitAPI with the same
compiler flags as the GTK+ port, disabling a few flags that are
sprouting a lot of warning output.

  • TestWebKitAPI/PlatformWPE.cmake:
9:59 PM Changeset in webkit [221068] by timothy_horton@apple.com
  • 29 edits in trunk/Source

_WKThumbnailView should use the screen color space instead of sRGB
https://bugs.webkit.org/show_bug.cgi?id=175858
<rdar://problem/33925559>

Reviewed by Dean Jackson.

Currently, _WKThumbnailView uses software snapshotting via
WebPage's takeSnapshot and friends, which always use sRGB.
However, it is immediately presented in display space, which
causes an expensive color conversion, which could have been avoided
if the snapshot was instead originally taken in display space.

To solve this, add:

  • a mechanism allowing ShareableBitmap to be constructed with a configuration, which can include a color space as well as the existing flags (flipping SupportsAlpha to be IsOpaque instead because most callers want alpha)
  • a WebImage constructor allowing callers to pass a ShareableBitmap configuration through
  • a bit in SnapshotOptions for callers to indicate that they want to snapshot in the display's color space (repurposed from the ExtendedColor bit)

And then make use of that bit in _WKThumbnailView.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::snapshotOptionsFromImageOptions):
Remove this incorrect conversion (WKImageOptions doesn't include
kWKSnapshotOptionsExtendedColor).

(WebKit::toSnapshotOptions):
Plumb kWKSnapshotOptionsExtendedColor to WebKit::SnapshotOptions
as the "UseScreenColorSpace". Leave the SPI name intact because
it has clients, but the difference isn't so huge that it will be
a problem.

  • Shared/ImageOptions.h:

(WebKit::snapshotOptionsToImageOptions):
Remove ImageOptionsExtendedColor, and rename
SnapshotOptionsExtendedColor to SnapshotOptionsUseScreenColorSpace.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::Handle):
(WebKit::ShareableBitmap::Handle::encode const):
(WebKit::ShareableBitmap::Handle::decode):
(WebKit::ShareableBitmap::Handle::clear):
(WebKit::ShareableBitmap::Configuration::encode const):
(WebKit::ShareableBitmap::Configuration::decode):
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::createHandle const):
(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::calculateBytesPerPixel): Deleted.

  • Shared/ShareableBitmap.h:

(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::sizeInBytes const):

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::colorSpace):
(WebKit::bitmapInfo):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::createCGImage const):
Remove ShareableBitmap's flags parameter, and replace it with
a configuration parameter. Configuration is a struct that currently
encompasses the newly-flipped IsOpaque bit and (on Cocoa platforms)
a platform colorspace object. Compute bytesPerPixel dynamically
based on the colorspace and whether it uses extended colors or not.

  • Shared/WebImage.cpp:

(WebKit::WebImage::create):

  • Shared/WebImage.h:

Pass ShareableBitmap::Configuration through to the ShareableBitmap
constructor, if provided.

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView requestSnapshot]):
Make use of the new bit, and use the screen's color space.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::snapshotOptionsToBitmapConfiguration):
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
If the snapshot option to use the display color space is set,
fill in the colorSpace field in the ShareableBitmap::Configuration
with the screen's color space.

(WebKit::WebPage::drawRectToImage):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeImage):

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::snapshot):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):
(WebKit::convertCGImageToBitmap):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot const):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):
Adopt ShareableBitmap::Configuration. Since IsOpaque
defaults to false, all callers who previously constructed
ShareableBitmap with SupportsAlpha now don't have to do anything.

  • platform/PlatformScreen.h:
  • platform/ios/PlatformScreenIOS.mm:

(WebCore::screenColorSpace):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenColorSpace):
(WebCore::screenSupportsExtendedColor):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenColorSpace):
Add screenColorSpace, which returns the active color space for the
given Widget's screen. On Windows, just fall back to sRGB like we usually do.

9:54 PM Changeset in webkit [221067] by rniwa@webkit.org
  • 5 edits in trunk

Consolidate the code to normalize MIME type in DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=175810

Rubber-stamped by Wenson Hsieh.

Address the forgotten review comment by Wenson.

Source/WebCore:

Tests: editing/pasteboard/datatransfer-getdata-plaintext.html

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::clearData):

LayoutTests:

  • editing/pasteboard/datatransfer-getdata-plaintext-expected.txt:
  • editing/pasteboard/datatransfer-getdata-plaintext.html:
9:47 PM Changeset in webkit [221066] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed, try to fix the Windows build after r221064

didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.

  • WebCoreSupport/WebEditorClient.h:
8:16 PM Changeset in webkit [221065] by wenson_hsieh@apple.com
  • 27 edits
    4 adds in trunk

[iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
https://bugs.webkit.org/show_bug.cgi?id=175116
<rdar://problem/28279301>

Reviewed by Darin Adler and Ryosuke Niwa.

Source/WebCore:

WebCore support for WebPage::editorState refactoring. See WebKit ChangeLogs for more detail.

Tests: EditorStateTests.TypingAttributesBold

EditorStateTests.TypingAttributesItalic
EditorStateTests.TypingAttributesUnderline
EditorStateTests.TypingAttributesTextAlignmentAbsoluteAlignmentOptions
EditorStateTests.TypingAttributesTextAlignmentStartEnd
EditorStateTests.TypingAttributesTextAlignmentDirectionalText
EditorStateTests.TypingAttributesTextColor
EditorStateTests.TypingAttributesMixedStyles
EditorStateTests.TypingAttributesLinkColor

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::propertyAsColor const):
(WebCore::StyleProperties::propertyAsValueID const):

Introduces some helper functions in StyleProperties to convert CSS property values to Color or a CSSValueID.

  • css/StyleProperties.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::hasStyle):

Pull out logic in selectionStartHasStyle that asks for a style TriState into EditingStyle::hasStyle. This is
because WebPage::editorState will now query for multiple styles at the selection start, but
selectionStartHasStyle currently recomputes styleAtSelectionStart every time it is called. To prevent extra work
from being done, we can just call selectionStartHasStyle once and use ask for EditingStyle::hasStyle on the
computed EditingStyle at selection start.

  • editing/EditingStyle.h:
  • editing/Editor.cpp:

(WebCore::Editor::selectionStartHasStyle const):

Source/WebKit:

Refactors WebPage::editorState to only use the StyleProperties derived from EditingStyle, instead of inserting
and removing a temporary node to figure out the style. Also adds hooks to notify the UI delegate of EditorState
changes.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(nsTextAlignment):
(dictionaryRepresentationForEditorState):
(-[WKWebView _didChangeEditorState]):

Alerts the private UI delegate of UI-side EditorState updates.

(-[WKWebView _web_editorStateDidChange]):
(-[WKWebView _executeEditCommand:argument:completion:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _web_editorStateDidChange]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::selectionDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::executeEditCommand):

Change executeEditCommand(name, callback) to executeEditCommand(name, argument, callback) and lift out of iOS
platform code and into WebPage.cpp.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView executeEditCommandWithCallback:]):
(-[WKContentView _selectionChanged]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::executeEditCommand): Deleted.

Move the iOS-specific implementation of executeEditCommand that invokes a callback when the web process responds
out of WebPageProxyIOS, and into cross-platform WebPageProxy code. Additionally, add a parameter for the edit
command's argument.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

Use EditingStyle::styleAtSelectionStart instead of Editor::styleForSelectionStart when computing an EditorState.
Tweak bold, italic and underline to use EditingStyle TriStates.

(WebKit::WebPage::executeEditCommandWithCallback):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::executeEditCommandWithCallback): Deleted.

Tools:

Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
EditorStateTests run on both iOS and Mac.

  • TestWebKitAPI/EditingTestHarness.h: Added.
  • TestWebKitAPI/EditingTestHarness.mm: Added.

EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
the state of the latest observed EditorState.

(-[EditingTestHarness initWithWebView:]):
(-[EditingTestHarness dealloc]):
(-[EditingTestHarness webView]):
(-[EditingTestHarness latestEditorState]):
(-[EditingTestHarness editorStateHistory]):
(-[EditingTestHarness insertText:andExpectEditorStateWith:]):
(-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
(-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
(-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness toggleBold]):
(-[EditingTestHarness toggleItalic]):
(-[EditingTestHarness toggleUnderline]):
(-[EditingTestHarness setForegroundColor:]):
(-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
(-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
(-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
(-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
(-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
(-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness _execCommand:argument:expectEntries:]):

Dispatches an editing command to the web process, and blocks until a response is received. If an expected
entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
keys and values.

(-[EditingTestHarness latestEditorStateContains:]):
(-[EditingTestHarness _webView:editorStateDidChange:]):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.

(TestWebKitAPI::setUpEditorStateTestHarness):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.

LayoutTests:

  • platform/ios-wk2/editing/style/unbold-in-bold-expected.txt:
  • platform/mac-wk2/editing/style/unbold-in-bold-expected.txt:

Rebaseline a WK2 LayoutTest expectations. This test currently expects an empty anonymous RenderBlock to be
inserted into the render tree, but this is only a result of us adding and removing a temporary <span> when
computing a RenderStyle in WebPage::editorState -- this patch removes these empty RenderBlocks, making these
expectations' RenderTrees consistent with WebKit1.

8:15 PM Changeset in webkit [221064] by wenson_hsieh@apple.com
  • 57 edits in trunk

[WK2] EditorState updates should be rolled into the layer update lifecycle when possible
https://bugs.webkit.org/show_bug.cgi?id=175370
<rdar://problem/33799806>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove didChangeSelectionAndUpdateLayout -- EditorState updates that are scheduled due to missing post-layout
data will now be scheduled for the next presentation update. Additionally, add editor client hooks to notify the
WebKit layer when we've updated the current composition. See WebKit ChangeLog for more details. This patch
adjusts and rebaselines existing layout tests.

  • editing/Editor.cpp:

(WebCore::SetCompositionScope::SetCompositionScope):
(WebCore::SetCompositionScope::~SetCompositionScope):

Introduce a helper RAII class to ensure that we ignore selection changes during the scope of
Editor::setComposition and call out to the client with WebEditorClient::didUpdateComposition afterwards. This
also maintains a UserTypingGestureIndicator over its lifetime, so we don't additionally need to create a
UserTypingGestureIndicator in Editor::setComposition.

(WebCore::Editor::setComposition):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::setSelectedRange):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::defaultSetSelectionOptions):

Plumb state about whether or not the selection change was triggered by the user to FrameSelection::setSelection,
and if so, notify the editing client. A separate SetSelectionOptions flag is used here instead of
RevealSelection to avoid calling out to the client in places where we want to reveal the selection regardless of
whether or not the selection is user triggered.

  • loader/EmptyClients.cpp:
  • page/EditorClient.h:

Source/WebKit:

See per-method comments for more detail. WebPage::didChangeSelection now schedules EditorState updates to be sent
during the next layer tree transaction rather than sending them synchronously. To ensure that iOS and Mac continue
to behave correctly w.r.t. EditorState updates, we immediately dispatch EditorStates in the following cases:

  • After the composition changes, is confirmed, or is canceled.
  • After an edit command is executed.
  • After ending user-triggered selection changes.
  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::hasEditorState const):
(WebKit::RemoteLayerTreeTransaction::editorState const):
(WebKit::RemoteLayerTreeTransaction::setEditorState):

Attaches an optional EditorState to the RemoteLayerTreeTransaction. This EditorState is computed and sent over
when setting up the transaction in WebPage, if something previously scheduled an EditorState update.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):

Add coder support for sending over a layer tree transaction's EditorState.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _doAfterNextPresentationUpdate:]):

Add _doAfterNextPresentationUpdate to WKView (used in TestWebKitAPI -- refer to
WebKitAgnosticTest::waitForNextPresentationUpdate).

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::dispatchPresentationCallbacksAfterFlushingLayers):

  • UIProcess/DrawingAreaProxy.messages.in:

Add a new IPC messages, DispatchPresentationCallbacksAfterFlushingLayers, to invoke in-flight presentation
callbacks in the UI process following a layer flush in the web process.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::~TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchPresentationCallbacksAfterFlushingLayers):

Run all pending _doAfterNextPresentationUpdate callbacks.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::didApplyStyle):
(WebKit::WebEditorClient::respondToChangedContents):
(WebKit::WebEditorClient::didEndUserTriggeredSelectionChanges):
(WebKit::WebEditorClient::didUpdateComposition):

Forward editor client calls to the WebPage.

(WebKit::WebEditorClient::didChangeSelectionAndUpdateLayout): Deleted.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):
(WebKit::WebPage::updateEditorStateAfterLayoutIfEditabilityChanged):
(WebKit::WebPage::willCommitLayerTree):
(WebKit::WebPage::didApplyStyle):

Allow style application to immediately trigger EditorState updates, if we're not currently ignoring selection
changes in the Editor.

(WebKit::WebPage::didChangeContents):

Allow applying top-level edit commands to immediately trigger EditorState updates, if we're not currently
ignoring selection changes in the Editor.

(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::didUpdateComposition):
(WebKit::WebPage::didEndUserTriggeredSelectionChanges):
(WebKit::WebPage::discardedComposition):
(WebKit::WebPage::canceledComposition):

When handling composition updates, always send an EditorState to the UI process. Unlike other cases, IME
requires immediate EditorState data, so we need to be explicit here in sending updates right away.

(WebKit::WebPage::sendEditorStateUpdate):
(WebKit::WebPage::sendPartialEditorStateAndSchedulePostLayoutUpdate):
(WebKit::WebPage::flushPendingEditorStateUpdate):

Helper methods to schedule an EditorState update to be sent upon the next layer tree update, or flush any
pending EditorState update that has been scheduled. The private, more aggressive variant of this is
sendEditorStateUpdate, which ignores whether or not there was already an EditorState update scheduled, and sends
one anyways (this still fulfills any EditorState update that was previously scheduled).

These helper methods are treated as no-ops when invoked while ignoring selection changes. This is to prevent
temporary selection state and editor commands during operations such as text indicator snapshotting from pushing
bogus information about transient editor states to the UI process.

(WebKit::WebPage::sendPostLayoutEditorStateIfNeeded): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::executeEditCommandWithCallback):
(WebKit::selectionIsInsideFixedPositionContainer):
(WebKit::WebPage::updateVisibleContentRects):

Fix a hack that was computing an EditorState to figure out whether the current selection starts or ends in a
fixed position container. Factors out relevant logic into a separate helper, and also schedules an EditorState
update instead of immediately computing it.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::addTransactionCallbackID):

Add support for registering and dispatching presentation callbacks that hook into the layer flush lifecycle,
using the tiled CA drawing area. These are used by Mac LayoutTests and API tests that need to wait until the
next flush before checking for state that depends on EditorState updates in the UI process.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

Tell the WebPage to flush any pending EditorState updates.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformEditorState const):

Source/WebKitLegacy/mac:

Adjust WebEditorClient for interface changes.

  • WebCoreSupport/WebEditorClient.h:

Source/WebKitLegacy/win:

Adjust WebEditorClient for interface changes.

  • WebCoreSupport/WebEditorClient.h:

Tools:

Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
to the UI process.

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:

(-[CandidateTestWebView typeString:inputMessage:]):
(+[CandidateTestWebView setUpWithFrame:testPage:]):

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
  • TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:

(TestWebKitAPI::AcceptsFirstMouse::runTest):

  • TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
  • TestWebKitAPI/cocoa/TestWKWebView.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView waitForNextPresentationUpdate]):

Add a new helper method to spin until the next presentation update.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h:
  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):

LayoutTests:

Rebaseline and adjust LayoutTests.

  • editing/caret/ios/absolute-caret-position-after-scroll-expected.txt:
  • editing/caret/ios/absolute-caret-position-after-scroll.html:
  • editing/caret/ios/fixed-caret-position-after-scroll-expected.txt:
  • editing/caret/ios/fixed-caret-position-after-scroll.html:
  • editing/secure-input/password-input-changed-type.html:
  • editing/secure-input/password-input-focusing.html:
  • editing/secure-input/removed-password-input.html:
  • editing/secure-input/reset-state-on-navigation.html:
  • editing/selection/character-granularity-rect.html:

Delay checking for secure input state and caret rects until after the next presentation update.

  • editing/selection/ios/absolute-selection-after-scroll-expected.txt:
  • editing/selection/ios/absolute-selection-after-scroll.html:
  • editing/selection/ios/fixed-selection-after-scroll-expected.txt:
  • editing/selection/ios/fixed-selection-after-scroll.html:

Refactor and simplify these tests. These tests are not run on the OpenSource bots, since they depend on long
press and tap gestures.

  • platform/ios-wk2/editing/inserting/insert-div-024-expected.txt:
  • platform/ios-wk2/editing/inserting/insert-div-026-expected.txt:
  • platform/ios-wk2/editing/style/5084241-expected.txt:

Rebaselines these tests, removing an anonymous RenderBlock inserted as a result of inserting and removing a
dummy span in order to compute a RenderStyle in WebPage::editorState. This is because editorState is no longer
invoked immediately on page load; https://bugs.webkit.org/show_bug.cgi?id=175116 tracks preventing this render
tree thrashing altogether.

  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/editing/style/unbold-in-bold-expected.txt:
  • resources/ui-helper.js:

Introduce new UIHelper functions.

(window.UIHelper.ensurePresentationUpdate.return.new.Promise):
(window.UIHelper.ensurePresentationUpdate):

Returns a Promise, resolved after the next presentation update.

(window.UIHelper.activateAndWaitForInputSessionAt.return.new.Promise.):
(window.UIHelper.activateAndWaitForInputSessionAt.return.new.Promise):
(window.UIHelper.activateAndWaitForInputSessionAt):

Returns a Promise, resolved after tapping at the given location and waiting for the keyboard to appear on iOS.

(window.UIHelper.getUICaretRect.return.new.Promise.):
(window.UIHelper.getUICaretRect.return.new.Promise):
(window.UIHelper.getUICaretRect):
(window.UIHelper.getUISelectionRects.return.new.Promise.):
(window.UIHelper.getUISelectionRects.return.new.Promise):
(window.UIHelper.getUISelectionRects):

Helpers to fetch selection and caret rect information in the UI process.

7:57 PM Changeset in webkit [221063] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

Consolidate the code to normalize MIME type in DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=175810

Reviewed by Wenson Hsieh.

Source/WebCore:

Factored out the code to convert MIME type to lowercase after stripping whitespace,
and treat "text" as "text/plain" and "url" as "text/uri-list".

Specifications:
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-getdata-2
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdata-2
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-cleardata-2

Stripping of whitespace only happens in WebKit/Blink but it's probably required for compatbility.
Spec bug: https://github.com/whatwg/html/issues/2946

Test: editing/pasteboard/datatransfer-getdata-plaintext.html

  • dom/DataTransfer.cpp:

(WebCore::normalizeType):
(WebCore::DataTransfer::clearData):
(WebCore::DataTransfer::getData const):
(WebCore::DataTransfer::setData):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::selectionDataTypeFromHTMLClipboardType):

  • platform/ios/PasteboardIOS.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

  • platform/win/PasteboardWin.cpp:

(WebCore::clipboardTypeFromMIMEType):

LayoutTests:

Added a regression test. Some test cases were failing on some platforms.

  • editing/pasteboard/datatransfer-getdata-plaintext-expected.txt: Added.
  • editing/pasteboard/datatransfer-getdata-plaintext.html: Added.
6:12 PM Changeset in webkit [221062] by Matt Lewis
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r221033.

This revision caused assertion failures on all Open Source
Debug testers. See Radar for more information.

Reverted changeset:

"Ensure media controls host exists before using it"
https://bugs.webkit.org/show_bug.cgi?id=175833
http://trac.webkit.org/changeset/221033

6:05 PM Changeset in webkit [221061] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

Relax keychain access to permit users to permanently allow client certificates
https://bugs.webkit.org/show_bug.cgi?id=175857
<rdar://problem/32293867>

Reviewed by Alex Christensen.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
5:32 PM Changeset in webkit [221060] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked http/tests/loading/basic-auth-remove-credentials.html as falky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=173500

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:09 PM Changeset in webkit [221059] by Chris Dumez
  • 10 edits
    1 add in trunk/Source

Introduce a new CompletionHandler type and use it for NetworkDataTaskClient's completion handlers to help catch bugs
https://bugs.webkit.org/show_bug.cgi?id=175832

Reviewed by Alex Christensen.

Source/WebKit:

Use new CompletionHandler type for NetworkDataTaskClient's completion handlers to help catch bugs.
It actually already found a bug in our HTTP 0.9 error handling which is fixed in this patch
as well.

  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::didReceiveResponse):

  • NetworkProcess/NetworkDataTask.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::tryPasswordBasedAuthentication):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):

Source/WTF:

Introduce a new CompletionHandler type which wraps a WTF::Function and ensures via assertions
that the function is always called once and only once.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CompletionHandler.h: Added.

(WTF::CompletionHandler<Out):

5:06 PM Changeset in webkit [221058] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Fix compile errors.
https://bugs.webkit.org/show_bug.cgi?id=175860

Reviewed by Brent Fulgham.

Add required header files.

  • platform/network/cf/CookieJarCFNet.cpp:
5:00 PM Changeset in webkit [221057] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org against at r221056.

Rubber-stamped by Joseph Pecoraro.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
  • Speedometer2.0/resources/main.js:

(window.benchmarkClient.didFinishLastIteration):

  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.a55034b424c795b1a9a8.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.a55034b424c795b1a9a8.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.bade2cb8992d8a68d0d7.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.bade2cb8992d8a68d0d7.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.9debb1b0a94f14d0ebe9.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.9debb1b0a94f14d0ebe9.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.bade2cb8992d8a68d0d7.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.bade2cb8992d8a68d0d7.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015/src/store.js:
4:46 PM Changeset in webkit [221056] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Correct SOUP builds after r221017 and r221050.
https://bugs.webkit.org/show_bug.cgi?id=175846

Reviewed by Michael Catanzaro.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForDOM): Revise return type.

4:15 PM Changeset in webkit [221055] by achristensen@apple.com
  • 7 edits
    1 add in trunk

Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
https://bugs.webkit.org/show_bug.cgi?id=175797
<rdar://problem/29270035>

Reviewed by Geoffrey Garen.

Source/WebKit:

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::showPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::registerURLSchemeHandler):
window.open, createWebViewWithConfiguration, and WKURLSchemeHandlers all used together
make it so that URLSchemeHandlers are added to WebPages that already have them. The
assertions are no longer valid.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.

(-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[UITestDelegate _showPage:]):
(-[UITestDelegate webView:startURLSchemeTask:]):
(-[UITestDelegate webView:stopURLSchemeTask:]):
(TEST):

4:11 PM Changeset in webkit [221054] by rniwa@webkit.org
  • 4 edits
    10 adds
    10 deletes in trunk/PerformanceTests

REGRESSION(R220043): Speedometer 2.0: Fix vanilla JS examples
https://bugs.webkit.org/show_bug.cgi?id=175815

Reviewed by Saam Barati.

Both vanilla ES2015 and Babel + WebPack test cases were failing to mark Todo items as completed since they were relying on
new Date().getTime() to generate an unique ID. That's not going to work if mulitple todo items are added within 1ms.

  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js.map: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html:
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js:
4:04 PM Changeset in webkit [221053] by Dewei Zhu
  • 12 edits in trunk/Websites/perf.webkit.org

Performance Dashboard should be compatible with PHP 7.
https://bugs.webkit.org/show_bug.cgi?id=175813

Reviewed by Ryosuke Niwa.

Use file_get_contents('php://input') instead of '$HTTP_RAW_POST_DATA'.
Update test harness script to load right php module in httpd.

  • ReadMe.md: JSON example format fix.
  • public/api/report-commits.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/api/report.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/api/update-triggerable.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/include/json-header.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/include/report-processor.php: Stop using '$HTTP_RAW_POST_DATA'.
  • server-tests/resources/test-server.conf: Load php5 or php7 module conditionally.
  • server-tests/resources/test-server.js: Pass PHP version info while launching httpd.

(TestServer.prototype._startApache):

  • tools/remote-cache-server.py: Pass PHP version info while launching httpd.

(start_httpd):

  • tools/remote-server-relay.conf: Load php5 or php7 module conditionally.
  • tools/sync-buildbot.js:

(syncLoop.const.makeTriggerable):
(syncLoop):

3:43 PM Changeset in webkit [221052] by msaboff@apple.com
  • 14 edits in trunk

Implement Unicode RegExp support in the YARR JIT
https://bugs.webkit.org/show_bug.cgi?id=174646

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This support is only implemented for 64 bit platforms. It wouldn't be too hard to add support
for 32 bit platforms with a reasonable number of spare registers. This code slightly refactors
register usage to reduce the number of callee save registers used for non-Unicode expressions.
For Unicode expressions, there are several more registers used to store constants values for
processing surrogate pairs as well as discerning whether a character belongs to the Basic
Multilingual Plane (BMP) or one of the Supplemental Planes.

This implements JIT support for Unicode expressions very similar to how the interpreter works.
Just like in the interpreter, backtracking code uses more space on the stack to save positions.
Moved the BackTrackInfo* structs to YarrPattern as separate functions. Added xxxIndex()
functions to each of these to simplify how the JIT code reads and writes the structure fields.

Given that reading surrogate pairs and transforming them into a single code point takes a
little processing, the code that implements reading a Unicode character is implemented as a
leaf function added to the end of the JIT'ed code. The calling convention for
"tryReadUnicodeCharacterHelper()" is non-standard given that the rest of the code assumes
that argument values stay in argument registers for most of the generated code.
That helper takes the starting character address in one register, regUnicodeInputAndTrail,
and uses another dedicated temporary register, regUnicodeTemp. The result is typically
returned in regT0. If another return register is requested, we'll create an inline copy of
that function.

Added a new flag to CharacterClass to signify if a class has non-BMP characters. This flag
is used in optimizeAlternative() where we swap the order of a fixed character class term with
a fixed character term that immediately follows it. Since the non-BMP character class may
increment "index" when matching, that must be done first before trying to match a fixed
character term later in the string.

Given the usefulness of the LEA instruction on X86 to create a single pointer value from a
base with index and offset, which the YARR JIT uses heavily, I added a new macroAssembler
function, getEffectiveAddress64(), with an ARM64 implementation. It just calls x86Lea64()
on X86-64. Also added an ImplicitAddress version of load16Unaligned().

(JSC::MacroAssemblerARM64::load16Unaligned):
(JSC::MacroAssemblerARM64::getEffectiveAddress64):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load16Unaligned):
(JSC::MacroAssemblerX86Common::load16):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::getEffectiveAddress64):

  • create_regex_tables:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):

  • yarr/YarrInterpreter.cpp:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::matchCharacterClass):
(JSC::Yarr::YarrGenerator::tryReadUnicodeCharImpl):
(JSC::Yarr::YarrGenerator::tryReadUnicodeChar):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::generateTryReadUnicodeCharacterHelper):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):

  • yarr/YarrJIT.h:
  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::CharacterClassConstructor::reset):
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::CharacterClassConstructor::addSorted):
(JSC::Yarr::CharacterClassConstructor::addSortedRange):
(JSC::Yarr::CharacterClassConstructor::hasNonBMPCharacters):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):

  • yarr/YarrPattern.h:

(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::BackTrackInfoPatternCharacter::beginIndex):
(JSC::Yarr::BackTrackInfoPatternCharacter::matchAmountIndex):
(JSC::Yarr::BackTrackInfoCharacterClass::beginIndex):
(JSC::Yarr::BackTrackInfoCharacterClass::matchAmountIndex):
(JSC::Yarr::BackTrackInfoBackReference::beginIndex):
(JSC::Yarr::BackTrackInfoBackReference::matchAmountIndex):
(JSC::Yarr::BackTrackInfoAlternative::offsetIndex):
(JSC::Yarr::BackTrackInfoParentheticalAssertion::beginIndex):
(JSC::Yarr::BackTrackInfoParenthesesOnce::beginIndex):
(JSC::Yarr::BackTrackInfoParenthesesTerminal::beginIndex):

LayoutTests:

Updated tests.

  • js/regexp-unicode-expected.txt:
  • js/script-tests/regexp-unicode.js:
2:54 PM Changeset in webkit [221051] by jfbastien@apple.com
  • 1 edit
    1873 adds in trunk/PerformanceTests

StitchMarker: threading, locking, and atomics benchmark

2:54 PM Changeset in webkit [221050] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

Correct SOUP and cURL builds after r221017.
https://bugs.webkit.org/show_bug.cgi?id=175846

Reviewed by Michael Catanzaro.

Correct the method signatures for 'cookiesForDOM' on the SOUP and cURL backends.
Note that these ports will need to add specific logic to find/filter secure cookies
if requested by the caller.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::CookieJarCurlFileSystem::cookiesForDOM):
(WebCore::cookiesForDOM):

  • platform/network/curl/CookieJarCurl.h:
  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForDOM):

2:37 PM Changeset in webkit [221049] by webkit@devinrousso.com
  • 2 edits in trunk/Tools

Unreviewed, change my IRC nick.

  • Scripts/webkitpy/common/config/contributors.json:
2:31 PM Changeset in webkit [221048] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[EnabledBySetting] in WebIDL uses Document but does not include Document.h
https://bugs.webkit.org/show_bug.cgi?id=175843

Reviewed by Sam Weinig.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

2:10 PM Changeset in webkit [221047] by Matt Lewis
  • 7 edits
    1 delete in trunk

Unreviewed, rolling out r221026.

This caused a consistent API failure on iOS Simulator.

Reverted changeset:

"Add UIDelegatePrivate SPI corresponding to
WKPageUIClient.showPage"
https://bugs.webkit.org/show_bug.cgi?id=175797
http://trac.webkit.org/changeset/221026

2:04 PM Changeset in webkit [221046] by jer.noble@apple.com
  • 12 edits in trunk/Source/WebCore

Refactor videoPerformanceQuality() MediaPlayer methods into single call.
https://bugs.webkit.org/show_bug.cgi?id=175830

Reviewed by Eric Carlson.

Allow MediaPlayerPrivate subclasses to return all the metrics required for VideoPerformanceQuality in
a single call. For clients which incur significant overhead to request this data, this reduces the cost
of requesting data by the number of calls removed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::videoPlaybackQualityMetrics):
(WebCore::MediaPlayer::totalVideoFrames): Deleted.
(WebCore::MediaPlayer::droppedVideoFrames): Deleted.
(WebCore::MediaPlayer::corruptedVideoFrames): Deleted.
(WebCore::MediaPlayer::totalFrameDelay): Deleted.

  • platform/graphics/MediaPlayer.h:

(WebCore::PlatformVideoPlaybackQualityMetrics::PlatformVideoPlaybackQualityMetrics):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::videoPlaybackQualityMetrics):
(WebCore::MediaPlayerPrivateInterface::totalVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateInterface::droppedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateInterface::corruptedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateInterface::totalFrameDelay): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::videoPlaybackQualityMetrics):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::droppedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::corruptedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalFrameDelay): Deleted.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::videoPlaybackQualityMetrics):
(WebCore::MockMediaPlayerMediaSource::totalVideoFrames): Deleted.
(WebCore::MockMediaPlayerMediaSource::droppedVideoFrames): Deleted.
(WebCore::MockMediaPlayerMediaSource::corruptedVideoFrames): Deleted.
(WebCore::MockMediaPlayerMediaSource::totalFrameDelay): Deleted.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::videoPlaybackQualityMetrics):

  • platform/mock/mediasource/MockMediaSourcePrivate.h:
2:03 PM Changeset in webkit [221045] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Commit the change meant to be included in the previous commit.

  • Speedometer/resources/main.js:

(startBenchmark):

2:00 PM Changeset in webkit [221044] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Make it possible to change the iteration count via query string
https://bugs.webkit.org/show_bug.cgi?id=175811

Reviewed by Saam Barati.

Added the support for specifying the iteration count by "iterationCount" query parameter, and replaced "ms"
query parameter by "unit=ms".

Finally, reduced the number of iterations from 20 to 10 to reduce the time needed to run the benchmark
since Speedometer 2.0 contains more than twice the number of libraries and frameworks than Speedometer 1.0.

  • Speedometer/resources/main.js:

(window.benchmarkClient.didFinishLastIteration):
(startBenchmark):

1:53 PM Changeset in webkit [221043] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r221027.

This change caused LayoutTests to exit early with assertion
failures.

Reverted changeset:

"Add sanity check for source origin in
WebLoaderStrategy::startPingLoad()"
https://bugs.webkit.org/show_bug.cgi?id=175827
http://trac.webkit.org/changeset/221027

1:53 PM Changeset in webkit [221042] by commit-queue@webkit.org
  • 1 edit in trunk/PerformanceTests/ChangeLog

Speedometer: Add missing stylesheet to Angular example
https://bugs.webkit.org/show_bug.cgi?id=175820

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-22
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/angular/dist/styles.d41d8cd98f00b204e980.bundle.css: Added.
1:48 PM Changeset in webkit [221041] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[WK2] Enable Beacon API by default
https://bugs.webkit.org/show_bug.cgi?id=175839

Reviewed by Youenn Fablet.

  • Shared/WebPreferencesDefinitions.h:
1:42 PM Changeset in webkit [221040] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed test gardening. rdar://problem/33789505

  • platform/mac/TestExpectations:
1:42 PM Changeset in webkit [221039] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Add button to select and unselect all tests to InteractiveRunner.html
https://bugs.webkit.org/show_bug.cgi?id=175816

Reviewed by Saam Barati.

Added buttons to select and unselect all subtests to aid debugging.

  • Speedometer/InteractiveRunner.html:

(createUIForSuites):

1:19 PM Changeset in webkit [221038] by Brent Fulgham
  • 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix after r221017.

Correct copy/paste error.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookiesForDOM):

1:13 PM Changeset in webkit [221037] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Fix Windows build after r221017.
https://bugs.webkit.org/show_bug.cgi?id=157053

  • wtf/PlatformWin.cmake:
1:10 PM Changeset in webkit [221036] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (High Sierra): PDFPlugin won't render PostScript Files
https://bugs.webkit.org/show_bug.cgi?id=175840
<rdar://problem/33877923>

Reviewed by Brent Fulgham.

  • WebProcess/com.apple.WebProcess.sb.in:

Add a sandbox exception for the PostScript conversion process.

1:09 PM Changeset in webkit [221035] by Brent Fulgham
  • 3 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix after r221017.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookiesForDOM): Update for new signature.

  • WebCoreSupport/WebPlatformStrategies.h:
12:56 PM Changeset in webkit [221034] by Brent Fulgham
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed test fix after r221017.

I forgot to check-in the expected result!

  • http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-expected.txt: Added.
12:54 PM Changeset in webkit [221033] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Ensure media controls host exists before using it
https://bugs.webkit.org/show_bug.cgi?id=175833
<rdar://problem/34001219>

Reviewed by Jer Noble.

Source/WebCore:

Although we ensure that the media controls shadow root exists before updating the text track
container, we don't check that the media controls host has been created yet. We do check
and create in other places in HTMLMediaElement.

Tests: media/track/track-display-before-controls-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateTextTrackDisplay):

LayoutTests:

  • media/track/track-display-before-controls-crash-expected.txt: Added.
  • media/track/track-display-before-controls-crash.html: Added.
12:22 PM Changeset in webkit [221032] by pvollan@apple.com
  • 5 edits in trunk/Source

Implement 64-bit MacroAssembler::probe support for Windows.
https://bugs.webkit.org/show_bug.cgi?id=175724

Reviewed by Mark Lam.

Source/JavaScriptCore:

This is needed to enable the DFG. MSVC does no longer support inline assembly
for 64-bit, which means we have to put the code in an asm file.

  • assembler/MacroAssemblerX86Common.cpp:

(JSC::booleanTrueForAvoidingNoReturnDeclaration): Deleted.

  • jit/JITStubsMSVC64.asm:

Source/WTF:

Enable masm probe and DFG.

  • wtf/Platform.h:
11:46 AM Changeset in webkit [221031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cache API] Optimize whitespace trimming in Vary header values
https://bugs.webkit.org/show_bug.cgi?id=175837

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-22
Reviewed by Alex Christensen.

No change of behavior.

Introducing a StringView version of stripLeadingAndTrailingHTTPSpaces.

  • Modules/cache/Cache.cpp:

(WebCore::hasResponseVaryStarHeaderValue):

  • platform/network/HTTPParsers.h:

(WebCore::stripLeadingAndTrailingHTTPSpaces):

11:45 AM Changeset in webkit [221030] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, beacon/contentextensions is only expected to work on Sierra+.

  • platform/mac-wk2/TestExpectations:
11:27 AM Changeset in webkit [221029] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Clean up PingLoad::processContentExtensionRulesForLoad()
https://bugs.webkit.org/show_bug.cgi?id=175834

Reviewed by Alex Christensen.

  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::processContentExtensionRulesForLoad):

  • NetworkProcess/PingLoad.h:
11:19 AM Changeset in webkit [221028] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Remove ChromeClient::scrollbarsModeDidChange
https://bugs.webkit.org/show_bug.cgi?id=175805

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-22
Reviewed by Daniel Bates.

Source/WebCore:

No change in behavior. It was never called, and no implementations did anything.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::scrollbarsModeDidChange const): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.h:
11:16 AM Changeset in webkit [221027] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
https://bugs.webkit.org/show_bug.cgi?id=175827

Reviewed by Geoffrey Garen.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):

11:12 AM Changeset in webkit [221026] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
https://bugs.webkit.org/show_bug.cgi?id=175797
<rdar://problem/29270035>

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-22
Reviewed by Geoffrey Garen.

Source/WebKit:

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::showPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::registerURLSchemeHandler):
window.open, createWebViewWithConfiguration, and WKURLSchemeHandlers all used together
make it so that URLSchemeHandlers are added to WebPages that already have them. The
assertions are no longer valid.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.

(-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[UITestDelegate _showPage:]):
(-[UITestDelegate webView:startURLSchemeTask:]):
(-[UITestDelegate webView:stopURLSchemeTask:]):
(TEST):

11:08 AM Changeset in webkit [221025] by webkit@devinrousso.com
  • 15 edits
    1 copy
    2 adds in trunk

Web Inspector: provide way for ShaderPrograms to be enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=175400

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add setShaderProgramDisabled command that sets the disabled flag on the given shader
program to the supplied boolean value. If this value is true, calls to drawArrays and
drawElements when that program is in use will have no effect.

Source/WebCore:

Test: inspector/canvas/setShaderProgramDisabled.html

  • inspector/InspectorShaderProgram.h:

(WebCore::InspectorShaderProgram::disabled):
(WebCore::InspectorShaderProgram::setDisabled):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::drawArrays):
(WebCore::WebGLRenderingContextBase::drawElements):
If the current program is disabled, return early. This will prevent the current shader
program from drawing anything to the canvas.

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
(WebCore::InspectorCanvasAgent::isShaderProgramDisabled):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::isShaderProgramDisabled):
(WebCore::InspectorInstrumentation::isShaderProgramDisabledImpl):

Source/WebInspectorUI:

Adds a status element to ShaderProgramTreeElement that, when clicked, will toggle the
disabled state of the corresponding ShaderProgram. Disabled shader programs will not draw
anything to the context.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram):
(WI.ShaderProgram.prototype.get disabled):
(WI.ShaderProgram.prototype.toggleDisabled):

  • UserInterface/Views/ShaderProgramTreeElement.js:

(WI.ShaderProgramTreeElement):
(WI.ShaderProgramTreeElement.prototype.selectOnMouseDown):
(WI.ShaderProgramTreeElement.prototype._disabledImageElementClicked):

  • UserInterface/Views/ShaderProgramTreeElement.css: Added.

(.item.shader-program .status > img):
(.item.shader-program:not(:hover, .selected, .disabled) .status > img):
(.tree-outline:matches(:focus, .force-focus) .item.shader-program.selected .status > img):
(.item.shader-program.disabled > *):

LayoutTests:

  • inspector/canvas/setShaderProgramDisabled-expected.txt: Added.
  • inspector/canvas/setShaderProgramDisabled.html: Added.
11:02 AM Changeset in webkit [221024] by commit-queue@webkit.org
  • 15 edits
    6 adds in trunk

[Cache API] Add support for overwriting responses with put on an existing record
https://bugs.webkit.org/show_bug.cgi?id=175825

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-22
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Tests: http/wpt/cache-storage/cache-put-keys.https.any.html

http/wpt/cache-storage/cache-put-keys.https.any.worker.html

Adding support for the new response update counter.
Overwriting local cached response with new retrieved response when the counter is different.
Adding support for passing this value from/to workers.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::queryCacheWithTargetStorage):
(WebCore::toConnectionRecord):
(WebCore::Cache::updateRecords):

  • Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::Record::copy const):

  • Modules/cache/CacheStorageConnection.h:
  • Modules/cache/CacheStorageRecord.h:
  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):

Source/WebKit:

Add support for encoding/decoding the update counter.
Incrementing it when overwriting an existing response.
Storing the new body in addition to the new response.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorageEngine::putRecords):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

LayoutTests:

Adding update counter for response
Skipping new test on WK1.

  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • http/wpt/cache-storage/cache-put-keys.https.any-expected.txt: Added.
  • http/wpt/cache-storage/cache-put-keys.https.any.html: Added.
  • http/wpt/cache-storage/cache-put-keys.https.any.js: Added.

(cache_test):

  • http/wpt/cache-storage/cache-put-keys.https.any.worker-expected.txt: Added.
  • http/wpt/cache-storage/cache-put-keys.https.any.worker.html: Added.
10:56 AM Changeset in webkit [221023] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/fetch/http-cache/invalidate.html as flaky on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=173672

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:38 AM Changeset in webkit [221022] by achristensen@apple.com
  • 15 edits in trunk/Source

Remove ChromeClient::hasOpenedPopup
https://bugs.webkit.org/show_bug.cgi?id=175804

Reviewed by Sam Weinig.

Source/WebCore:

No change in behavior. All implementations just returned false.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::hasOpenedPopup const): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • rendering/RenderMenuList.cpp:

(RenderMenuList::showPopup):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::hasOpenedPopup const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::hasOpenedPopup const): Deleted.

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::hasOpenedPopup const): Deleted.

  • WebCoreSupport/WebChromeClient.h:
10:33 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
Adjust calendar format (diff)
10:31 AM Changeset in webkit [221021] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unriviewed, fix windows build... for realz.

  • CMakeLists.txt:
9:59 AM Changeset in webkit [221020] by aestes@apple.com
  • 10 edits in trunk

[Payment Request] Implement error checking for show(), abort(), and canMakePayment()
https://bugs.webkit.org/show_bug.cgi?id=175789

Reviewed by Brady Eidson.
LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:

Source/WebCore:

Implement many of the exceptions and promise rejections specified for PaymentRequest's
show(), abort(), and canMakePayment() methods. Also implement basic state tracking.

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create): Changed serializedMethodData from a
HashMap<String, String> to a Vector<PaymentRequest::Method>.
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::show): Added promise rejection for invalid state, updated the
state to Interactive, stored the promise in m_showPromise, and dispatched finishShowing().
(WebCore::PaymentRequest::finishShowing): Added JSON parsing of payment method serialized
data and exception propagation. If there are no exceptions, rejected m_showPromise with
NotSupportedError since we don't yet support any payment methods.
(WebCore::PaymentRequest::abort): Added promise rejection for invalid state and stored the
promise in m_abortPromise. Dispatched a lambda to update the state to Closed, reject
m_showPromise, and resolve m_abortPromise.
(WebCore::PaymentRequest::canMakePayment): Added promise rejection for invalid state and
stored the promise in m_canMakePaymentPromise. Dispatched a lambda to resolve
m_canMakePaymentPromise with false since we don't yet support any payment methods.

  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.idl: Annotated abort() with MayThrowException.

LayoutTests:

Stopped marking payment-request-abort-method.https.html and payment-request-show-method.https.html as flaky.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
9:29 AM Changeset in webkit [221019] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, enable http/wpt/beacon/contentextensions on Mac WK2 only.

It seems content extensions are not supported by WKTR on iOS.

9:28 AM Changeset in webkit [221018] by sbarati@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

We are using valueProfileForBytecodeOffset when there may not be a value profile
https://bugs.webkit.org/show_bug.cgi?id=175812

Reviewed by Michael Saboff.

This patch uses the type system to aid the code around CodeBlock's ValueProfile
accessor methods. valueProfileForBytecodeOffset used to return ValueProfile*,
so there were callers of this that thought it could return nullptr when there
was no such ValueProfile. This was not the case, it always returned a non-null
pointer. This patch changes valueProfileForBytecodeOffset to return ValueProfile&
and adds a new tryGetValueProfileForBytecodeOffset method that returns ValueProfile*
and does the right thing if there is no such ValueProfile.

This patch also changes the other ValueProfile accessors on CodeBlock to
return ValueProfile& instead of ValueProfile*. Some callers handled the null
case unnecessarily, and using the type system to specify the result can't be
null removes these useless branches.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::dumpValueProfiles):
(JSC::CodeBlock::tryGetValueProfileForBytecodeOffset):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::validate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::getFromAllValueProfiles):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSite):

  • profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

  • tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateJSCell):

9:22 AM Changeset in webkit [221017] by Brent Fulgham
  • 21 edits
    23 adds in trunk

Disable access to secure cookies if an HTTPS site loads mixed content
https://bugs.webkit.org/show_bug.cgi?id=157053
<rdar://problem/11290808>

Patch by Brent Fulgham <Brent Fulgham> and Pranjal Jumde <pjumde@apple.com> on 2017-08-22
Reviewed by Dan Bates.

Source/WebCore:

Tests: http/tests/security/mixedContent/insecure-css-with-secure-cookies.html

http/tests/security/mixedContent/insecure-image-with-securecookie-block.html
http/tests/security/mixedContent/insecure-image-with-securecookie.html
http/tests/security/mixedContent/insecure-script-with-secure-cookies.html
http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block.html
http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies.html

  • dom/SecurityContext.h:

(WebCore::SecurityContext::secureCookiesAccessed): Added.
(WebCore::SecurityContext::setSecureCookiesAccessed): Added.

  • loader/CookieJar.cpp:

(WebCore::cookies): Pass Document as non-const so we can call 'setSecureCookiesAccessed' if necessary.

  • loader/CookieJar.h:
  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::canRunInsecureContent): Updated checks to avoid running insecure content
if secure cookies were accessed.

  • platform/CookiesStrategy.h:

(WebCore::CookiesStrategy::cookiesForDOM): Pass new argument indicating whether secure cookies should be included in the response.

  • platform/network/PlatformCookieJar.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(copyCookiesForURLWithFirstPartyURL): Revise to accept new 'IncludeSecureCookiesOrNot' argument.
(WebCore::cookiesForSession): Updated to accept new 'IncludeSecureCookiesOrNot' argument. Also determine if secure cookies were
included in the response, and return this to the caller.
(WebCore::cookieRequestHeaderFieldValue): Revise for new 'copyCookiesForURLWithFirstPartyURL' signature.
(WebCore::getRawCookies): Ditto.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesForSession): Updated checks to keep track of secure cookies and filter out secure cookies if insecure content
was accessed.
(WebCore::cookiesForDOM): Update for new arguments and to return a pair.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM): Pass new arguments needed by WebCore.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Updated the CookiesForDOM message with the new foundMixedContent

argument and the new didAccessSecureCookies reply.

  • Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Drive-by fix to use the right message.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
indicating whether secure cookies should be included in the response.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
indicating whether secure cookies should be included in the response.

LayoutTests:

  • http/tests/security/mixedContent/insecure-css-with-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-css-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie-block-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie-block.html: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie.html: Added.
  • http/tests/security/mixedContent/insecure-script-with-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-script-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-css-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-executable-css-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-image-secure-cookie-block.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-image-secure-cookie.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-script-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-image-secure-cookie-block.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-image-secure-cookie.html: Added.
  • http/tests/security/mixedContent/resources/insecure-executable.css: Added.
  • http/tests/security/mixedContent/resources/insecure.css: Added.
  • http/tests/security/resources/greenbox-hotspot5-4.cur: Added.
9:13 AM Changeset in webkit [221016] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

Autoplay Muted Videos Don't Play When Outside Viewport
https://bugs.webkit.org/show_bug.cgi?id=175748
<rdar://problem/33974383>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-restricted-invisible-autoplay-not-allowed-source.html

The media session is notified that its client (the media element) will begin autoplaying inside
prepareForLoad(), where the m_autoplaying flag is also set. But loading via <source> elements does not go
through prepareForLoad(); the HTML standard states that the <source> element loading path does not trigger the
"media element load algorithm" which is implemented in prepareForLoad(). Since the m_autoplaying flag is
initially set to true, notify the media session that the element will begin autoplaying inside the element's
constructor.

Drive-by fix: Doing the above causes other tests to crash, as purturbing play state during style change can cause
re-entrancy in the native controls code, or fail, since we will transition from autoplay -> play even if there's
not yet a src or source to the media element. Add a task queue for updating the autoplay state and check the ready
state before allowing autoplay to transition to play.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::canTransitionFromAutoplayToPlay const):
(WebCore::HTMLMediaElement::isVisibleInViewportChanged):

LayoutTests:

  • media/video-restricted-invisible-autoplay-not-allowed-source-expected.txt: Added.
  • media/video-restricted-invisible-autoplay-not-allowed-source.html: Added.
9:03 AM Changeset in webkit [221015] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix windows build... maybe.

  • CMakeLists.txt:
8:56 AM Changeset in webkit [221014] by mrajca@apple.com
  • 6 edits
    2 adds in trunk

Call updateIsPlayingMedia whenever m_userHasInteractedWithMediaElement changes
https://bugs.webkit.org/show_bug.cgi?id=175796

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-user-gesture-tracking.html

The page media state depends on m_userHasInteractedWithMediaElement, so force it to update
as soon as m_userHasInteractedWithMediaElement changes. This fixes an issue where the media
state would not reflect the user interaction flag until a call to updateIsPlayingMedia was made.

  • dom/Document.cpp:

(WebCore::Document::noteUserInteractionWithMediaElement):

  • dom/Document.h:

(WebCore::Document::noteUserInteractionWithMediaElement): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::pageMediaState):

LayoutTests:

Skip the test on iOS like all the other tests that use runWithKeyDown.

  • media/video-user-gesture-tracking-expected.txt: Added.
  • media/video-user-gesture-tracking.html: Added.
8:54 AM Changeset in webkit [221013] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix cloop build.

8:50 AM Changeset in webkit [221012] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win][Release] Crash when running testmasm executable.
https://bugs.webkit.org/show_bug.cgi?id=175772

Reviewed by Mark Lam.

We need to save and restore the modified registers in case one or more registers are callee saved
on the relevant platforms.

  • assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):

8:46 AM Changeset in webkit [221011] by Jonathan Bedard
  • 2 edits in trunk/Tools

Fix leak-checking for iOS Simulators
https://bugs.webkit.org/show_bug.cgi?id=175735

Reviewed by David Kilzer.

Follow-up fix to r220942. _proc may be undefined.

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._wait_for_stop): Handle case where _proc is undefined.

7:44 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:43 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:42 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:41 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:41 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
6:47 AM Changeset in webkit [221010] by clopez@igalia.com
  • 3 edits in trunk/Tools

[GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
https://bugs.webkit.org/show_bug.cgi?id=175822

Reviewed by Xabier Rodriguez-Calvar.

  • gtk/install-dependencies: Add the bad plugins to the list.
  • wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
2:54 AM Changeset in webkit [221009] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r221006.
https://bugs.webkit.org/show_bug.cgi?id=175821

generates build failures in the bots (Requested by calvaris[m]
on #webkit).

Reverted changeset:

"[GStreamer][GTK][WPE] Move common things to GStreamer cmake
files"
https://bugs.webkit.org/show_bug.cgi?id=175625
http://trac.webkit.org/changeset/221006

2:51 AM Changeset in webkit [221008] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
https://bugs.webkit.org/show_bug.cgi?id=175819

Reviewed by Xabier Rodriguez-Calvar.

  • platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is

allocated on heap, so the embedded GLContext pointer can contain a
non-null value that can cause problems when e.g. checking for a current
GLContext on some specific thread on which a GLContext hasn't yet been
made current. Zero-initializing this pointer will avoid false positives
that can occur in these circumstances.

2:13 AM Changeset in webkit [221007] by zandobersek@gmail.com
  • 3 edits
    2 adds
    1 delete in trunk/Source/WebKit

[GTK][WPE] Rename StorageProcessMainGtk.cpp to StorageProcessMainGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=175814

Reviewed by Gyuyoung Kim.

Both GTK+ and WPE ports already compile the StorageProcessMainGtk.cpp
file, but it should be renamed to StorageProcessMainGLib and moved into
the StorageProcess/glib/ directory.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • StorageProcess/glib/StorageProcessMainGLib.cpp: Renamed from Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp.
1:44 AM Changeset in webkit [221006] by calvaris@igalia.com
  • 3 edits
    3 adds in trunk

[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
https://bugs.webkit.org/show_bug.cgi?id=175625

Three files were created as kind of hooks for the GTK and WPE
CMake option files. The definitions one is to enable, disable and
create the common options (that can be and are actually overriden
in some cases. The dependencies one adds dependencies for the
option switches that are set. The checks one ensure the
dependencies are met depending on the option switches.

Reviewed by Žan Doberšek.

  • Source/cmake/GStreamerChecks.cmake: Added.
  • Source/cmake/GStreamerDefinitions.cmake: Added.
  • Source/cmake/GStreamerDependencies.cmake: Added.
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Aug 21, 2017:

11:31 PM Changeset in webkit [221005] by zandobersek@gmail.com
  • 9 edits in trunk/Source/WebKit

[WK] Add missing ENABLE(NETWORK_CACHE) build guards
https://bugs.webkit.org/show_bug.cgi?id=175769

Reviewed by Carlos Alberto Lopez Perez.

Given that the build guard exists, it should be possible to
compile the WebKit layer with the feature disabled. Missing
guards are added in order to achieve that.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::clearDiskCache):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::storeDerivedDataToCache):

10:54 PM Changeset in webkit [221004] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220940. rdar://problem/33994308

9:57 PM Changeset in webkit [221003] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

[Follow up]: Add back the ability to disable MASM_PROBE from the build.
https://bugs.webkit.org/show_bug.cgi?id=175656
<rdar://problem/33933720>

Not reviewed.

Fixed a typo: should be "OS(WINDOWS)", not "OS(WINDOW)".

  • wtf/Platform.h:
9:41 PM Changeset in webkit [221002] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Change probe code to use static_assert instead of COMPILE_ASSERT.
https://bugs.webkit.org/show_bug.cgi?id=175762

Reviewed by JF Bastien.

  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe): Deleted.

  • assembler/MacroAssemblerARMv7.cpp:
  • assembler/MacroAssemblerX86Common.cpp:
9:12 PM Changeset in webkit [221001] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org

Rubber-stamped by Joseph Pecoraro.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
  • Speedometer2.0/resources/benchmark-runner.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/inline.b342d102ba4a53bf2002.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/main.779eb2f1ddbe23ac61c7.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/polyfills.2d45a4c73c85e24fe474.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/vendor.b4be818cb6d8028f9192.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e/app.e2e-spec.ts: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e/app.po.ts: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e/tsconfig.e2e.json: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css:
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers/global.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/config/environment.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/tests/.jshintrc: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/module-for-acceptance.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/start-app.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/react-redux/dist/static/css/main.d43d2909.css: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.946269ff.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/css/app.677b45842d9f8b96e5b23c18969233b7.css: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/app.b0e835874bc8949670d1.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/manifest.84b2b4fceb74ab1f91f3.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/vendor.a52517c5aa98e7fbea2e.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
8:19 PM Changeset in webkit [221000] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make generate_offset_extractor.rb architectures argument more robust
https://bugs.webkit.org/show_bug.cgi?id=175809

Reviewed by Joseph Pecoraro.

It turns out that some of our builders pass their architectures as
space separated lists. I decided to just make the splitting of
our list robust to any reasonable combination of spaces and
commas.

  • offlineasm/generate_offset_extractor.rb:
7:25 PM Changeset in webkit [220999] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add Sony to domain affiliations on team page
https://bugs.webkit.org/show_bug.cgi?id=175806

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-21
Reviewed by Alex Christensen.

  • wp-content/themes/webkit/team.php:
7:03 PM Changeset in webkit [220998] by commit-queue@webkit.org
  • 9 edits in trunk

[Cache API] Add support for Cache.add/addAll
https://bugs.webkit.org/show_bug.cgi?id=175677

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-21
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Cache.addAll implementation is then as follow:

  • Fetch the resources in parallel.
  • Wait for all them to complete using FetchTaskCounter.
  • If an error happens in any load or if the response is not as expected for Cache API, reject the promise.
  • Call the batch put operation with all received FetchResponse objects.

FetchTaskCounter is responsible to wait for each response to arrive.
It then checks whether the response is fine,
If not, the addAll promise is rejected.
Otherwise, it waits for the body to be received.

Introducing a helper routine to create a FetchRequest from a given RequestInfo.
Introducing a helper routine to check for Vary Header '*' value in response headers.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::doMatch):
(WebCore::Cache::add):
(WebCore::queryCacheMatch):
(WebCore::hasResponseVaryStarHeaderValue):
(WebCore::FetchTaskCounter::FetchTaskCounter):
(WebCore::FetchTaskCounter::~FetchTaskCounter):
(WebCore::FetchTaskCounter::addRecord):
(WebCore::FetchTaskCounter::isDone const):
(WebCore::FetchTaskCounter::reject):
(WebCore::Cache::requestFromInfo):
(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::Cache::remove):
(WebCore::Cache::keys):
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

  • Modules/cache/Cache.h:
6:50 PM Changeset in webkit [220997] by mmaxfield@apple.com
  • 5 edits in trunk

DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
https://bugs.webkit.org/show_bug.cgi?id=175787
<rdar://problem/33996612>

Reviewed by Wenson Hsieh.

Source/WebCore:

The variation axis values of San Francisco changed from the GX-style scale to the CSS-style
scale. Previously, we were normalizing the values we got from Core Text to fit the CSS scale;
however, this is no longer necessary since the font now does this itself.

The assertion was getting hit because the normalized values were huge and were overflowing
a single FontSelectionValue (and going negative). This patch adds handling for this
situation.

Test: DataInteractionTests.ExternalSourceBoldSystemAttributedStringToContentEditable

  • platform/graphics/FontSelectionAlgorithm.h: Typedef the backing type for a FontSelectionValue.

(WebCore::FontSelectionValue::rawValue const):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::FontSelectionValue):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Opt-out of normalization for San Francisco.

(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::capabilitiesForFontDescriptor):

Tools:

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

6:32 PM Changeset in webkit [220996] by Chris Dumez
  • 16 edits
    7 adds in trunk

[Beacon] Content extensions should be able to intercept Beacon / Ping redirects
https://bugs.webkit.org/show_bug.cgi?id=175746
<rdar://problem/33946050>

Reviewed by Alex Christensen.

Source/WebCore:

Update PingLoad to process content extension rules upon redirect. This allows content
extensions to block and upgrade to HTTPS beacon / ping loads.

Because ping loads can outlive the WebProcess, the content extensions rules are passed
to the NetworkProcess when starting the Ping load. The PingLoad can then consult those
rules upon redirect, on the NetworkProcess side.

Tests: http/wpt/beacon/contentextensions/beacon-blocked.html

http/wpt/beacon/contentextensions/beacon-redirect-blocked.html

  • contentextensions/ContentExtensionActions.h:
  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::forEach):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForPingLoad):

  • contentextensions/ContentExtensionsBackend.h:
  • page/Page.h:
  • page/UserContentProvider.cpp:

(WebCore::UserContentProvider::forEachContentExtension):

  • page/UserContentProvider.h:

Source/WebKit:

Update PingLoad to process content extension rules upon redirect. This allows content
extensions to block and upgrade to HTTPS beacon / ping loads.

Because ping loads can outlive the WebProcess, the content extensions rules are passed
to the NetworkProcess when starting the Ping load. The PingLoad can then consult those
rules upon redirect, on the NetworkProcess side.

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentExtensionsBackend):
(WebKit::PingLoad::processContentExtensionRulesForLoad):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):

LayoutTests:

Add layout test coverage for blocking beacon loads via content extensions.

  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt:
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html:
  • http/wpt/beacon/contentextensions/beacon-blocked-expected.txt: Added.
  • http/wpt/beacon/contentextensions/beacon-blocked.html: Added.
  • http/wpt/beacon/contentextensions/beacon-blocked.html.json: Added.
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked-expected.txt: Added.
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked.html: Added.
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked.html.json: Added.
6:14 PM Changeset in webkit [220995] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE][GTK] Unused variables in UserMediaProcessManager.cpp
https://bugs.webkit.org/show_bug.cgi?id=175799

Reviewed by Alex Christensen.

The code which uses the "audioExtensionPath" and "videoExtensionPath" variables is guarded
with "#if ENABLE(SANDBOX_EXTENSIONS)”, so do the same for the variables themselves.

  • UIProcess/UserMediaProcessManager.cpp: Add missing guards.
6:07 PM Changeset in webkit [220994] by keith_miller@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Only generate offline asm for the ARCHS (xcodebuild) or the current system (CMake)
https://bugs.webkit.org/show_bug.cgi?id=175690

Reviewed by Michael Saboff.

This should reduce some of the time we spend building offline asm
in our builds (except for linux since they already did this).

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • offlineasm/backends.rb:
  • offlineasm/generate_offset_extractor.rb:
6:07 PM Changeset in webkit [220993] by clopez@igalia.com
  • 2 edits in trunk/Source/WTF

[GTK] ARMv7 build fails to build MacroAssemblerARMv7.cpp.
https://bugs.webkit.org/show_bug.cgi?id=175514

Reviewed by Keith Miller.

  • wtf/Platform.h: Enable DFG and MASM_PROBE back for GTK ARM_THUMB2.
5:23 PM Changeset in webkit [220992] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: !m_connections.contains(&connection) in WebCore::SWServer::unregisterConnection(WebCore::SWServer::Connection&).
https://bugs.webkit.org/show_bug.cgi?id=175795

Rubber-stamped by Andy Estes.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::unregisterConnection): Flip the ASSERT to be... correct.

4:39 PM Changeset in webkit [220991] by mmaxfield@apple.com
  • 2 edits in trunk/Tools

Typo in "webkit-patch land"
https://bugs.webkit.org/show_bug.cgi?id=175788

Reviewed by Tim Horton.

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._commit_warning):

4:31 PM Changeset in webkit [220990] by Ryan Haddad
  • 3 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed, land test updates for rdar://problem/34000704.

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
4:31 PM Changeset in webkit [220989] by Ryan Haddad
  • 3 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed, land test updates for rdar://problem/34000704.

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
4:21 PM Changeset in webkit [220988] by dbates@webkit.org
  • 5 edits in trunk/Source/WebCore

Cleanup TextPainter
https://bugs.webkit.org/show_bug.cgi?id=175782

Reviewed by Myles C. Maxfield.

Remove redundant mention of "text" in the name of TextPainter member functions, add separate
setters for selection and non-selection shadows, and do some other minor cleanups.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Update code for renamed functions.

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Ditto.

  • rendering/TextPainter.cpp: Include ShadowData.h.

(WebCore::ShadowApplier::ShadowApplier): Use C++11 brace-initialization syntax.
(WebCore::ShadowApplier::isLastShadowIteration): Moved from TextPainter.h.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.
(WebCore::TextPainter::paintTextOrEmphasisMarks): Renamed; formerly named drawTextOrEmphasisMarks.
(WebCore::TextPainter::paintTextWithShadows): Update code for renamed functions.
(WebCore::TextPainter::paintRange): Renamed; formerly named paintTextInRange.
(WebCore::TextPainter::paint): Renamed; formerly named paintText.
(WebCore::TextPainter::drawTextOrEmphasisMarks): Renamed to paintTextOrEmphasisMarks() to match
the naming convention of all the other paint functions in this class.
(WebCore::TextPainter::paintTextInRange): Renamed to paintRange.
(WebCore::TextPainter::paintText): Renamed to paint.

  • rendering/TextPainter.h: Forward declare ShadowData.

(WebCore::TextPainter::setStyle): Renamed; formerly named setTextPaintStyle.
(WebCore::TextPainter::setSelectionStyle): Renamed; formerly named setSelectionPaintStyle.
(WebCore::TextPainter::setShadow): Added.
(WebCore::TextPainter::setSelectionShadow): Added.
(WebCore::TextPainter::setEmphasisMark): Renamed; formerly named addEmphasis.
(WebCore::TextPainter::setTextPaintStyle): Renamed to setStyle.
(WebCore::TextPainter::setSelectionPaintStyle): Renamed to setSelectionStyle.
(WebCore::TextPainter::addEmphasis): Renamed to setEmphasisMark.
(WebCore::TextPainter::addTextShadow): Split functionality into setShadow and setSelectionShadow.
(WebCore::ShadowApplier::isLastShadowIteration): Moved to TextPainter.cpp.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.

4:15 PM Changeset in webkit [220987] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed expectations.

Unreviewed test expectations.

  • platform/mac/TestExpectations:
4:04 PM Changeset in webkit [220986] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments after r220725
https://bugs.webkit.org/show_bug.cgi?id=175382

Reviewed by Darin Adler.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setUnicodeRange):

3:17 PM Changeset in webkit [220985] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/LayoutTests

Stop media/video-controls-toggling.html from timing out.
https://bugs.webkit.org/show_bug.cgi?id=116266

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21
Reviewed by Dean Jackson.

Use getComputedStyle to check the display property. Element::style only
contains properties set in the style attribute, but the display property
is set through CSS using the 'hidden' class.

  • media/video-controls-toggling-expected.txt:
  • media/video-controls-toggling.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/media/video-controls-toggling-expected.txt: Copied from LayoutTests/media/video-controls-toggling-expected.txt. I'm not sure where the console message comes from, but it seems to be in the GTK-specific code.
2:58 PM Changeset in webkit [220984] by commit-queue@webkit.org
  • 13 edits in trunk

[Cache API] Add support for CacheStorage.match
https://bugs.webkit.org/show_bug.cgi?id=175747

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-21
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Introducing Cache::doMatch so that CacheStorage can use it.
Make Cache::match use Cache::doMatch as well.

Implementing CacheStorage.match as per spec:

  • If name is provided, query only the cache with the given name.
  • Otherwise pick the first matching response in the caches.

The sequential asynchronous search is done in doSequentialMatch.

Making sure that response with a status code are returning false to isNull.
This allows passing more tests.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::match):
(WebCore::Cache::doMatch):
(WebCore::Cache::matchAll):
(WebCore::toConnectionRecord):

  • Modules/cache/Cache.h:
  • Modules/cache/CacheStorage.cpp:

(WebCore::doSequentialMatch):
(WebCore::copyCaches):
(WebCore::CacheStorage::match):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setHTTPStatusCode):

2:51 PM Changeset in webkit [220983] by dino@apple.com
  • 3 edits
    2 adds in trunk

Persistent WebGL Warning "vertex WARNING: 0:1: extension 'GL_ARB_gpu_shader5' is not supported" in Safari 10.1.2
https://bugs.webkit.org/show_bug.cgi?id=175783
<rdar://problem/33623867>

Reviewed by Alex Christensen.

Source/WebCore:

The version of ANGLE we use inserts this line into each shader:
It causes our lower-level GLSL compiler to give a warning, which is
confusing to developers because they didn't write this code.

Until we upgrade our OpenGL support to version 4.1, we should remove
this error message from the log returned to the developer.
See https://bugs.webkit.org/show_bug.cgi?id=175785

Test: fast/canvas/webgl/no-info-log-for-simple-shaders.html

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getUnmangledInfoLog): Search for and remove
this warning.

LayoutTests:

  • fast/canvas/webgl/no-info-log-for-simple-shaders-expected.txt: Added.
  • fast/canvas/webgl/no-info-log-for-simple-shaders.html: Added.
2:10 PM Changeset in webkit [220982] by weinig@apple.com
  • 4 edits in trunk

StringView could use a function to strip leading/trailing characters without allocation
https://bugs.webkit.org/show_bug.cgi?id=175757

Reviewed by Darin Adler.

Source/WTF:

There are many places in WebCore/WebKit that we call functions like,
WebCore::stripLeadingAndTrailingHTMLSpaces, or String::stripWhiteSpace() only to use
the allocated String as a temporary for either another transformation or a comparison.
Now that we have StringView, we can avoid that extra allocation, by having returning a
StringView substring in these scenarios.

For instance, the check (from ScriptElement.cpp:287):

if (!stripLeadingAndTrailingHTMLSpaces(sourceURL).isEmpty()) {

...

}

currently allocates a string just to make this check. With a new
stripLeadingAndTrailingHTMLSpaces such as:

StringView stripLeadingAndTrailingHTMLSpaces(StringView stringView)
{

return stringView.stripLeadingAndTrailingMatchedCharacters([] (auto c) {

return isHTMLSpace(c);

});

}

We could instead have exact same code from ScriptElement.cpp now avoid an allocation.

  • wtf/text/StringView.h:

(WTF::StringView::stripLeadingAndTrailingMatchedCharacters):

Tools:

  • TestWebKitAPI/Tests/WTF/StringView.cpp:

Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().

1:55 PM Changeset in webkit [220981] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked svg/animations/smil-leak-list-property-instances.svg as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=174218

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
1:53 PM Changeset in webkit [220980] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[Payment Request] Use ExistingExceptionError to propagate JS exceptions thrown during JSON stringification
https://bugs.webkit.org/show_bug.cgi?id=175776

Reviewed by Darin Adler.

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create):

  • Modules/paymentrequest/PaymentRequest.h:
1:35 PM Changeset in webkit [220979] by commit-queue@webkit.org
  • 59 edits
    25 copies
    1 add
    1 delete in trunk

[PAL] Move spi/mac directory into PAL
https://bugs.webkit.org/show_bug.cgi?id=175649

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-21
Reviewed by Myles C. Maxfield.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/DataDetection.mm:
  • editing/mac/DictionaryLookup.h:
  • editing/mac/DictionaryLookup.mm:
  • page/mac/ServicesOverlayController.mm:
  • page/mac/WheelEventDeltaFilterMac.mm:
  • page/scrolling/mac/ScrollingMomentumCalculatorMac.mm:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/mac/MediaTimeQTKit.h:
  • platform/mac/MediaRemoteSoftLink.cpp:
  • platform/mac/MediaRemoteSoftLink.h:
  • platform/mac/PasteboardWriter.mm:
  • platform/mac/PlatformEventFactoryMac.mm:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/VideoFullscreenInterfaceMac.mm:
  • platform/mac/WebVideoFullscreenController.mm:
  • rendering/RenderThemeMac.mm:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/mac/AVFoundationSPI.h: Renamed from Source/WebCore/platform/spi/mac/AVFoundationSPI.h.
  • pal/spi/mac/DataDetectorsSPI.h: Renamed from Source/WebCore/platform/spi/mac/DataDetectorsSPI.h.
  • pal/spi/mac/LookupSPI.h: Renamed from Source/WebCore/platform/spi/mac/LookupSPI.h.
  • pal/spi/mac/MediaRemoteSPI.h: Renamed from Source/WebCore/platform/spi/mac/MediaRemoteSPI.h.
  • pal/spi/mac/NSAccessibilitySPI.h: Renamed from Source/WebCore/platform/spi/mac/NSAccessibilitySPI.h.
  • pal/spi/mac/NSApplicationSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSApplicationSPI.h.
  • pal/spi/mac/NSEventSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSEventSPI.h.
  • pal/spi/mac/NSFontSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSFontSPI.h.
  • pal/spi/mac/NSImmediateActionGestureRecognizerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h.
  • pal/spi/mac/NSMenuSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSMenuSPI.h.
  • pal/spi/mac/NSPasteboardSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSPasteboardSPI.h.
  • pal/spi/mac/NSPopoverSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSPopoverSPI.h.
  • pal/spi/mac/NSScrollerImpSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollerImpSPI.h.
  • pal/spi/mac/NSScrollingInputFilterSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollingInputFilterSPI.h.
  • pal/spi/mac/NSScrollingMomentumCalculatorSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollingMomentumCalculatorSPI.h.
  • pal/spi/mac/NSSharingServicePickerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSharingServicePickerSPI.h.
  • pal/spi/mac/NSSharingServiceSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSharingServiceSPI.h.
  • pal/spi/mac/NSSpellCheckerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSpellCheckerSPI.h.
  • pal/spi/mac/NSTextFinderSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSTextFinderSPI.h.
  • pal/spi/mac/NSViewSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSViewSPI.h.
  • pal/spi/mac/NSWindowSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSWindowSPI.h.
  • pal/spi/mac/PIPSPI.h: Renamed from Source/WebCore/platform/spi/mac/PIPSPI.h.
  • pal/spi/mac/QTKitSPI.h: Renamed from Source/WebCore/platform/spi/mac/QTKitSPI.h.
  • pal/spi/mac/QuickLookMacSPI.h: Renamed from Source/WebCore/platform/spi/mac/QuickLookMacSPI.h.
  • pal/spi/mac/TUCallSPI.h: Renamed from Source/WebCore/platform/spi/mac/TUCallSPI.h.

Source/WebKit:

  • Platform/mac/MenuUtilities.mm:
  • Shared/mac/WebCoreArgumentCodersMac.mm:
  • Shared/mac/WebEventFactory.mm:
  • Shared/mac/WebHitTestResultData.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/Cocoa/WebViewImpl.mm:
  • UIProcess/mac/ServicesController.mm:
  • UIProcess/mac/TextCheckerMac.mm:
  • UIProcess/mac/ViewGestureControllerMac.mm:
  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:
  • UIProcess/mac/WKSharingServicePickerDelegate.mm:
  • UIProcess/mac/WKTextFinderClient.mm:
  • UIProcess/mac/WebContextMenuProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/mac:

  • Misc/WebSharingServicePickerController.h:
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebSelectionServiceController.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:
  • WebView/WebView.mm:

Tools:

  • TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1:16 PM Changeset in webkit [220978] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GTK][WPE][GSTREAMER_GL] Overriden virtual function not marked “override” in MediaPlayerPrivateGStreamerBase.h
https://bugs.webkit.org/show_bug.cgi?id=175780

Reviewed by Konstantin Tokarev.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Add missing "override" qualifier.
1:02 PM Changeset in webkit [220977] by beidson@apple.com
  • 19 edits
    5 copies
    3 moves
    1 add in trunk/Source

Split the one SWServer::Connection into SWClientConnection and SWServer::Connection.
https://bugs.webkit.org/show_bug.cgi?id=175745

Reviewed by Andy Estes.

Source/WebCore:

No new tests (No behavior change).

Each of these has a much different environment that it lives in, so being the same object
hinders clean development.

This split will also make it easier for the WebCore objects to directly handle WK2 messages.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Logging.h:
  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/ServiceWorkerProvider.h:
  • workers/service/server/SWClientConnection.cpp: Copied from Source/WebCore/workers/service/server/SWServer.cpp.

(WebCore::SWClientConnection::SWClientConnection):
(WebCore::SWClientConnection::~SWClientConnection):
(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::jobRejectedInServer):

  • workers/service/server/SWClientConnection.h: Copied from Source/WebCore/workers/service/server/SWServer.h.
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::Connection::~Connection):
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::scheduleJob):
(WebCore::SWServer::registerConnection):
(WebCore::SWServer::unregisterConnection):
(WebCore::SWServer::Connection::scheduleJob): Deleted.
(WebCore::SWServer::Connection::jobRejected): Deleted.

  • workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::server):
(WebCore::SWServer::Connection::~Connection): Deleted.

Source/WebKit:

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebKit.xcodeproj/project.pbxproj:
  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp: Renamed from Source/WebKit/WebProcess/Storage/WebSWServerConnection.cpp.

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::disconnectedFromWebProcess):
(WebKit::WebSWServerConnection::rejectJobInClient):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h: Copied from Source/WebKit/WebProcess/Storage/WebSWServerConnection.h.

(WebKit::WebSWServerConnection::identifier const):

  • StorageProcess/ServiceWorker/WebSWServerConnection.messages.in: Copied from Source/WebKit/WebProcess/Storage/WebSWServerConnection.messages.in.
  • StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):

  • StorageProcess/StorageToWebProcessConnection.h:
  • WebProcess/Storage/WebSWClientConnection.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.

(WebKit::WebSWClientConnection::WebSWClientConnection):
(WebKit::WebSWClientConnection::~WebSWClientConnection):
(WebKit::WebSWClientConnection::scheduleJobInServer):

  • WebProcess/Storage/WebSWClientConnection.h: Renamed from Source/WebKit/WebProcess/Storage/WebSWServerConnection.h.

(WebKit::WebSWClientConnection::identifier const):

  • WebProcess/Storage/WebSWClientConnection.messages.in: Renamed from Source/WebKit/WebProcess/Storage/WebSWServerConnection.messages.in.
  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):

  • WebProcess/Storage/WebServiceWorkerProvider.h:
  • WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

  • WebProcess/Storage/WebToStorageProcessConnection.h:
12:54 PM Changeset in webkit [220976] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.3.1/Source

Versioning.

12:50 PM Changeset in webkit [220975] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.3.1

New tag.

12:06 PM Changeset in webkit [220974] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/LayoutTests

Re-enable tests based on media-fullscreen.js for GTK.
https://bugs.webkit.org/show_bug.cgi?id=175770

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21
Reviewed by Eric Carlson.

The media-fullscreen-not-in-document test checks that a disconnected
element can go fullscreen, while the code explicitly disallows that
(in Document::requestFullScreenForElement). Update the test to match
the code.

The media-fullscreen-inline test will now fail more clearly if the
attempt to go fullscreen is rejected (which it isn't).

  • media/media-fullscreen-not-in-document-expected.txt: rebaseline.
  • media/media-fullscreen.js:

(fullscreenerror): pass the test if the webkitfullscreenerror
(addEventListeners): add a webkitfullscreenerror event handler

  • platform/gtk/TestExpectations: remove failure expectations.
  • platform/gtk/media/media-fullscreen-not-in-document-expected.txt: Copied from LayoutTests/media/media-fullscreen-not-in-document-expected.txt. This copy leaves out the webkitSupportsPresentationMode check that's disabled on GTK.
11:45 AM Changeset in webkit [220973] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Can't copy text from "View variable value" popover in Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=175758

Reviewed by Matt Baker.

  • UserInterface/Views/InlineSwatch.js:

(WI.InlineSwatch.prototype._swatchElementClicked):
Change CodeMirror readOnly from "nocursor" to true. The former prevents the editor from
being focused during selection, therefore preventing the content from being copied.

11:15 AM Changeset in webkit [220972] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked inspector/css/add-rule.html as flaky on macOS
https://bugs.webkit.org/show_bug.cgi?id=173560

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:41 AM Changeset in webkit [220971] by aestes@apple.com
  • 9 edits in trunk

[Payment Request] Implement the PaymentRequest constructor
https://bugs.webkit.org/show_bug.cgi?id=175755

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-id.https-expected.txt:

Source/WebCore:

  • Modules/paymentrequest/PaymentDetailsModifier.h: Changed total to an std::optional<PaymentItem>.
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::isWellFormedCurrencyCode): Implements the IsWellFormedCurrencyCode abstract operation from ECMA 402.
(WebCore::isValidDecimalMonetaryValue): Implements the "valid decimal monetary value" validity checker.
(WebCore::checkAndCanonicalizeAmount): Implements the "check and canonicalize amount" validity checker.
(WebCore::checkAndCanonicalizeTotal): Implements the "check and canonicalize total" validity checker.
(WebCore::PaymentRequest::create): Implements the PaymentRequest Constructor
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::id const): Implements the PaymentRequest id attribute.
(WebCore::PaymentRequest::shippingType const): Implements the PaymentRequest shippingType attribute.

  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.idl: Annotated PaymentRequest with ConstructorMayThrowException.
  • WebCore.xcodeproj/project.pbxproj:
10:21 AM Changeset in webkit [220970] by pvollan@apple.com
  • 4 edits in trunk

[Win] DRT should only allow any https certificate for localhost.
https://bugs.webkit.org/show_bug.cgi?id=175147

Reviewed by Brent Fulgham.

Source/WebCore:

Disabling validation of certificate chains, breaks SSL on Windows. In order
for SSL tests to succeed on Windows, we should avoid disabling it.

No new tests, covered by existing tests.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

Tools:

Add check to make sure only localhost requests allow any https certificate.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

10:00 AM Changeset in webkit [220969] by Matt Lewis
  • 5 edits in trunk/LayoutTests

Rebaselined js/dom/global-constructors-attributes.html on macOS.

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:45 AM Changeset in webkit [220968] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip imported/w3c/web-platform-tests/payment-request/payment-request-constructor-crash.https.html.
https://bugs.webkit.org/show_bug.cgi?id=175773

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:36 AM Changeset in webkit [220967] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[GTK][WPE] Rebaseline tests with list item markers.
https://bugs.webkit.org/show_bug.cgi?id=175771

Unreviewed test gardening.

The output was changed in r220858 and rebaselined for ios and mac only.
They're changes in render tree dumps that don't affect rendering.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21

  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/gtk/fast/doctypes/002-expected.txt:
  • platform/gtk/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
9:30 AM Changeset in webkit [220966] by eric.carlson@apple.com
  • 2 edits in trunk/Tools

Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Unreviewed build fix.

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::LoggingTest::output): Disable testing output by default because it
fails on some of the bots.

8:44 AM Changeset in webkit [220965] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

media-captions.html improvements
https://bugs.webkit.org/show_bug.cgi?id=175768

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21
Reviewed by Eric Carlson.

  • media/media-captions.html: remove reference to unused script file.
  • platform/gtk/TestExpectations: remove Timeout, Crash annotations.
6:03 AM Changeset in webkit [220964] by eric.carlson@apple.com
  • 7 edits
    1 add in trunk

Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/MemoryPressureHandler.cpp:
  • wtf/RefCountedLeakCounter.cpp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.

(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

5:59 AM Changeset in webkit [220963] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
https://bugs.webkit.org/show_bug.cgi?id=175571

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-21
Reviewed by Antti Koivisto.

  • Shared/CacheModel.cpp:

(WebKit::calculateMemoryCacheSizes): Ensure cacheTotalCapacity is
set to a reasonable value even in low-memory environments.

5:56 AM Changeset in webkit [220962] by zandobersek@gmail.com
  • 9 edits in trunk/Source/WebCore

[EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'
https://bugs.webkit.org/show_bug.cgi?id=175761

Reviewed by Xabier Rodriguez-Calvar.

Add initial and incomplete implementations of the 'Attempt to Decrypt' and
'Attempt to Resume Playback If Necessary' algorithms. The implementations
are interleaved with the specification text for clarity.

'Attempt to Decrypt' implementation doesn't yet address the encrypted block
queue or the 'decryption blocked waiting for key' flag since it's not yet
clear whether it would make more sense for this state to reside lower, in
the platform layer. The gist of the algorithm is to invoke the decryption
attempt through the MediaPlayer object, passing along the CDMInstance object
retrieved from the MediaKeys object that is associated with this media
element.

'Attempt to Resume Playback if Necessary' implementation similarly for now
omits the various state flag operations. The main task at this point is to
dispatch the 'Attempt to Decrypt' algorithm.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() method now
invokes the attemptToResumePlaybackIfNecessary() method.

MediaKeys::hasOpenSessions() is introduced, returning true if any session
that was created through this MediaKeys instance is still open. This allows
the 'Attempt to Decrypt' algorithm to proceed with the decryption attempt
dispatch into the MediaPlayer hierarchy.

For that, the MediaPlayer::attemptToDecryptWithInstance() method is added,
which simply dispatches the mirror method on MediaPlayerPrivate interface.
This will enable the platform-layer implementations to use the passed-in
CDMInstance object for decryption purposes.

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::hasOpenSessions const):

  • Modules/encryptedmedia/MediaKeys.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attemptToDecrypt):
(WebCore::HTMLMediaElement::attemptToResumePlaybackIfNecessary):
(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):

  • html/HTMLMediaElement.h: Mark cdmClientAttemptToResumePlaybackIfNecessary() as final.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::attemptToDecryptWithInstance):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::attemptToDecryptWithInstance):

1:28 AM Changeset in webkit [220961] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Remove some old flaky crash expectations.
https://bugs.webkit.org/show_bug.cgi?id=108682

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21

  • platform/gtk/TestExpectations:

Aug 20, 2017:

11:56 PM Changeset in webkit [220960] by mark.lam@apple.com
  • 7 edits in trunk/Source

Gardening: fix CLoop build.
https://bugs.webkit.org/show_bug.cgi?id=175688
<rdar://problem/33436870>

Not reviewed.

Source/JavaScriptCore:

Make these files dependent on ENABLE(MASM_PROBE).

  • assembler/ProbeContext.cpp:
  • assembler/ProbeContext.h:
  • assembler/ProbeStack.cpp:
  • assembler/ProbeStack.h:

Source/WTF:

Disable MASM_PROBE if !ENABLE(JIT).

  • wtf/Platform.h:
11:21 PM Changeset in webkit [220959] by zandobersek@gmail.com
  • 9 edits in trunk

[EME] Add basic implementation of HTMLMediaElement::setMediaKeys()
https://bugs.webkit.org/show_bug.cgi?id=175717

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Add an initial and incomplete implementation of HTMLMediaElement::setMediaKeys(),
interleaved with the specification wording of how this operation should behave.
The implementation still doesn't cover cases of CDM instances being already
associated with a different HTMLMediaElement, of CDM instances that can't be
disassociated from the current HTMLMediaElement, and of failures during both
association and disassociation of MediaKeys with the HTMLMediaElement.

The HTMLMediaElement (as a CDMClient inheritor) has to be attached or detached
from the MediaKeys object as appropriate. This attachment allows MediaKeys to
initiate an attempt to resume playback whenever the key statuses of the
associated MediaKeys object are updated.

Upon association and disassociation with MediaKeys, the CDMInstance object of
that specific MediaKeys instance is attached to or detached from the MediaPlayer
instance. This allows the platform layer to gather information about the
CDMInstance that will be used for decryption of media content for this specific
media element.

Additionally, the detachment from both MediaKeys and MediaPlayer is done upon
HTMLMediaElement destruction.

Upon setting the MediaKeys object, a task is queued that launches the 'Attempt to
Resume Playback If Necessary' algorithm. A placeholder method is added that will
implement the algorithm in the future.

The HTMLMediaElement::mediaKeys() getter is also implemented, returning pointer
held in m_mediaKeys.

Covered to a degree by existing imported W3C tests, with a setMediaKeys()-oriented
test having WPE-specific baseline update.

  • Modules/encryptedmedia/MediaKeys.h:

(WebCore::MediaKeys::cdmInstance const):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::mediaKeys const):
(WebCore::HTMLMediaElement::setMediaKeys):
(WebCore::HTMLMediaElement::attemptToResumePlaybackIfNecessary):
(WebCore::HTMLMediaElement::contextDestroyed):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::cdmInstanceAttached):
(WebCore::MediaPlayer::cdmInstanceDetached):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateInterface::cdmInstanceDetached):

LayoutTests:

  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-expected.txt:

Update the baseline, with the test no longer timing out but instead
failing with a NotAllowed exception thrown.

9:26 PM Changeset in webkit [220958] by mark.lam@apple.com
  • 17 edits
    4 adds in trunk/Source/JavaScriptCore

Enhance MacroAssembler::probe() to allow the probe function to resize the stack frame and alter stack data in one pass.
https://bugs.webkit.org/show_bug.cgi?id=175688
<rdar://problem/33436870>

Reviewed by JF Bastien.

With this patch, the clients of the MacroAssembler::probe() can now change
stack values without having to worry about whether there is enough room in the
current stack frame for it or not. This is done using the Probe::Context's stack
member like so:

jit.probe([] (Probe::Context& context) {

auto cpu = context.cpu;
auto stack = context.stack();
uintptr_t* currentSP = cpu.sp<uintptr_t*>();

Get a value at the current stack pointer location.
auto value = stack.get<uintptr_t>(currentSP);

Set a value above the current stack pointer (within current frame).
stack.set<uintptr_t>(currentSP + 10, value);

Set a value below the current stack pointer (out of current frame).
stack.set<uintptr_t>(currentSP - 10, value);

Set the new stack pointer.
cpu.sp() = currentSP - 20;

});

What happens behind the scene:

  1. the generated JIT probe code will now call Probe::executeProbe(), and Probe::executeProbe() will in turn call the client's probe function.

Probe::executeProbe() receives the Probe::State on the machine stack passed
to it by the probe trampoline. Probe::executeProbe() will instantiate a
Probe::Context to be passed to the client's probe function. The client will
no longer see the Probe::State directly.

  1. The Probe::Context comes with a Probe::Stack which serves as a manager of stack pages. Currently, each page is 1K in size. Probe::Context::stack() returns a reference to an instance of Probe::Stack.
  1. Invoking get() of set() on Probe::Stack with an address will lead to the following:
  1. the address will be decoded to a baseAddress that points to the 1K page that contains that address.
  1. the Probe::Stack will check if it already has a cached 1K page for that baseAddress. If so, go to step (f). Else, continue with step (c).
  1. the Probe::Stack will malloc a 1K mirror page, and memcpy the 1K stack page for that specified baseAddress to this mirror page.
  1. the mirror page will be added to the ProbeStack's m_pages HashMap, keyed on the baseAddress.
  1. the ProbeStack will also cache the last baseAddress and its corresponding mirror page in use. With memory accesses tending to be localized, this will save us from having to look up the page in the HashMap.
  1. get() will map the requested address to a physical address in the mirror page, and return the value at that location.
  1. set() will map the requested address to a physical address in the mirror page, and set the value at that location in the mirror page.

set() will also set a dirty bit corresponding to the "cache line" that
was modified in the mirror page.

  1. When the client's probe function returns, Probe::executeProbe() will check if there are stack changes that need to be applied. If stack changes are needed:
  1. Probe::executeProbe() will adjust the stack pointer to ensure enough stack space is available to flush the dirty stack pages. It will also register a flushStackDirtyPages callback function in the Probe::State. Thereafter, Probe::executeProbe() returns to the probe trampoline.
  1. the probe trampoline adjusts the stack pointer, moves the Probe::State to a safe place if needed, and then calls the flushStackDirtyPages callback if needed.
  1. the flushStackDirtyPages() callback iterates the Probe::Stack's m_pages HashMap and flush all dirty "cache lines" to the machine stack. Thereafter, flushStackDirtyPages() returns to the probe trampoline.
  1. lastly, the probe trampoline will restore all register values and return to the pc set in the Probe::State.

To make this patch work, I also had to do the following work:

  1. Refactor MacroAssembler::CPUState into Probe::CPUState. Mainly, this means moving the code over to ProbeContext.h. I also added some convenience accessor methods for spr registers.

Moved Probe::Context over to its own file ProbeContext.h/cpp.

  1. Fix all probe trampolines to pass the address of Probe::executeProbe in addition to the client's probe function and arg.

I also took this opportunity to optimize the generated JIT probe code to
minimize the amount of memory stores needed.

  1. Simplified the ARM64 probe trampoline. The ARM64 probe only supports changing either lr or pc (or neither), but not both at in the same probe invocation. The ARM64 probe trampoline used to have to check for this invariant in the assembly trampoline code. With the introduction of Probe::executeProbe(), we can now do it there and simplify the trampoline.
  1. Fix a bug in the old ARM64 probe trampoline for the case where the client changes lr. That code path never worked before, but has now been fixed.
  1. Removed trustedImm32FromPtr() helper functions in MacroAssemblerARM and MacroAssemblerARMv7.

We can now use move() with TrustedImmPtr, and it does the same thing but in a
more generic way.

  1. ARMv7's move() emitter may encode a T1 move instruction, which happens to have

the same semantics as movs (according to the Thumb spec). This means these
instructions may trash the APSR flags before we have a chance to preserve them.

This patch changes MacroAssemblerARMv7's probe() to preserve the APSR register
early on. This entails adding support for the mrs instruction in the
ARMv7Assembler.

  1. Change testmasm's testProbeModifiesStackValues() to now modify stack values

the easy way.

Also fixed testmasm tests which check flag registers to only compare the
portions that are modifiable by the client i.e. some masking is applied.

This patch has passed the testmasm tests on x86, x86_64, arm64, and armv7.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::mrs):

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::CPUState::gprName): Deleted.
(JSC::MacroAssembler::CPUState::sprName): Deleted.
(JSC::MacroAssembler::CPUState::fprName): Deleted.
(JSC::MacroAssembler::CPUState::gpr): Deleted.
(JSC::MacroAssembler::CPUState::spr): Deleted.
(JSC::MacroAssembler::CPUState::fpr): Deleted.
(JSC:: const): Deleted.
(JSC::MacroAssembler::CPUState::fpr const): Deleted.
(JSC::MacroAssembler::CPUState::pc): Deleted.
(JSC::MacroAssembler::CPUState::fp): Deleted.
(JSC::MacroAssembler::CPUState::sp): Deleted.
(JSC::MacroAssembler::CPUState::pc const): Deleted.
(JSC::MacroAssembler::CPUState::fp const): Deleted.
(JSC::MacroAssembler::CPUState::sp const): Deleted.
(JSC::Probe::State::gpr): Deleted.
(JSC::Probe::State::spr): Deleted.
(JSC::Probe::State::fpr): Deleted.
(JSC::Probe::State::gprName): Deleted.
(JSC::Probe::State::sprName): Deleted.
(JSC::Probe::State::fprName): Deleted.
(JSC::Probe::State::pc): Deleted.
(JSC::Probe::State::fp): Deleted.
(JSC::Probe::State::sp): Deleted.

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr): Deleted.

  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):
(JSC::arm64ProbeError): Deleted.

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::armV7Condition):
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr): Deleted.

  • assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:

(JSC::ctiMasmProbeTrampoline):
(JSC::MacroAssembler::probe):

  • assembler/Printer.h:

(JSC::Printer::Context::Context):

  • assembler/ProbeContext.cpp: Added.

(JSC::Probe::executeProbe):
(JSC::Probe::handleProbeStackInitialization):
(JSC::Probe::probeStateForContext):

  • assembler/ProbeContext.h: Added.

(JSC::Probe::CPUState::gprName):
(JSC::Probe::CPUState::sprName):
(JSC::Probe::CPUState::fprName):
(JSC::Probe::CPUState::gpr):
(JSC::Probe::CPUState::spr):
(JSC::Probe::CPUState::fpr):
(JSC::Probe:: const):
(JSC::Probe::CPUState::fpr const):
(JSC::Probe::CPUState::pc):
(JSC::Probe::CPUState::fp):
(JSC::Probe::CPUState::sp):
(JSC::Probe::CPUState::pc const):
(JSC::Probe::CPUState::fp const):
(JSC::Probe::CPUState::sp const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe::Context::stack):
(JSC::Probe::Context::hasWritesToFlush):
(JSC::Probe::Context::releaseStack):

  • assembler/ProbeStack.cpp: Added.

(JSC::Probe::Page::Page):
(JSC::Probe::Page::flushWrites):
(JSC::Probe::Stack::Stack):
(JSC::Probe::Stack::hasWritesToFlush):
(JSC::Probe::Stack::flushWrites):
(JSC::Probe::Stack::ensurePageFor):

  • assembler/ProbeStack.h: Added.

(JSC::Probe::Page::baseAddressFor):
(JSC::Probe::Page::chunkAddressFor):
(JSC::Probe::Page::baseAddress):
(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::hasWritesToFlush const):
(JSC::Probe::Page::flushWritesIfNeeded):
(JSC::Probe::Page::dirtyBitFor):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::Stack):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):
(JSC::Probe::Stack::newStackPointer const):
(JSC::Probe::Stack::setNewStackPointer):
(JSC::Probe::Stack::isValid):
(JSC::Probe::Stack::pageFor):

  • assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::testProbeModifiesStackValues):
(JSC::run):
(): Deleted.
(JSC::fillStack): Deleted.
(JSC::testProbeModifiesStackWithCallback): Deleted.

4:11 PM Changeset in webkit [220957] by Chris Dumez
  • 12 edits in trunk/Source

Simplify calls to LoaderStrategy::startPingLoad()
https://bugs.webkit.org/show_bug.cgi?id=175756

Reviewed by Sam Weinig.

Source/WebCore:

Simplify calls to LoaderStrategy::startPingLoad() by passing the Frame to it
and let its implementation gets what it needs from the frame. This reduces
the number of parameters to startPingLoad() and is more easily extensible.

  • dom/Document.h:
  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

Source/WebKit:

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

  • WebCoreSupport/WebResourceLoadScheduler.h:
2:42 AM Changeset in webkit [220956] by Antti Koivisto
  • 7 edits
    2 adds in trunk/Source/WebCore

Factor :before/:after render tree mutations into a RenderTreeUpdater helper class
https://bugs.webkit.org/show_bug.cgi?id=175752

Reviewed by Andreas Kling.

Move code that constructs generated content renderers out from PseudoElement.
Also refactor the related code from RenderTreeUpdater main class into
RenderTreeUpdater::GeneratedContent helper class.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::resolveCustomStyle): Deleted.

Not needed anymore.

(WebCore::PseudoElement::didAttachRenderers): Deleted.

Moves to createContentRenderers in GeneratedContent.

(WebCore::PseudoElement::didRecalcStyle): Deleted.

Moves to updateStyleForContentRenderers in GeneratedContent.

  • dom/PseudoElement.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::RenderTreeUpdater):
(WebCore::RenderTreeUpdater::~RenderTreeUpdater):
(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::needsPseudoElement): Deleted.
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement): Deleted.
(WebCore::RenderTreeUpdater::updateQuotesUpTo): Deleted.

Quotes and other :before/:after support moves to GeneratedContent helpwe.

  • style/RenderTreeUpdater.h:

(WebCore::RenderTreeUpdater::generatedContent):

  • style/RenderTreeUpdaterGeneratedContent.cpp: Added.

(WebCore::RenderTreeUpdater::GeneratedContent::GeneratedContent):
(WebCore::RenderTreeUpdater::GeneratedContent::updateBeforePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateAfterPseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateRemainingQuotes):
(WebCore::RenderTreeUpdater::GeneratedContent::updateQuotesUpTo):
(WebCore::createContentRenderers):
(WebCore::updateStyleForContentRenderers):
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):

  • style/RenderTreeUpdaterGeneratedContent.h: Added.

Aug 19, 2017:

7:11 PM Changeset in webkit [220955] by aestes@apple.com
  • 30 edits
    36 adds in trunk

[Payment Request] Add interface stubs
https://bugs.webkit.org/show_bug.cgi?id=175730

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt:
  • web-platform-tests/payment-request/historical.https-expected.txt:
  • web-platform-tests/payment-request/interfaces.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-id.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-in-iframe-expected.txt:
  • web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt:
  • web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt:

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Source/WebCore:

  • DerivedSources.make:
  • Modules/paymentrequest/PaymentAddress.h: Added.
  • Modules/paymentrequest/PaymentAddress.idl: Added.
  • Modules/paymentrequest/PaymentComplete.h: Added.
  • Modules/paymentrequest/PaymentComplete.idl: Added.
  • Modules/paymentrequest/PaymentCurrencyAmount.h: Added.
  • Modules/paymentrequest/PaymentCurrencyAmount.idl: Added.
  • Modules/paymentrequest/PaymentDetailsBase.h: Added.
  • Modules/paymentrequest/PaymentDetailsBase.idl: Added.
  • Modules/paymentrequest/PaymentDetailsInit.h: Added.
  • Modules/paymentrequest/PaymentDetailsInit.idl: Added.
  • Modules/paymentrequest/PaymentDetailsModifier.h: Added.
  • Modules/paymentrequest/PaymentDetailsModifier.idl: Added.
  • Modules/paymentrequest/PaymentDetailsUpdate.h: Added.
  • Modules/paymentrequest/PaymentDetailsUpdate.idl: Added.
  • Modules/paymentrequest/PaymentItem.h: Added.
  • Modules/paymentrequest/PaymentItem.idl: Added.
  • Modules/paymentrequest/PaymentMethodData.h: Added.
  • Modules/paymentrequest/PaymentMethodData.idl: Added.
  • Modules/paymentrequest/PaymentOptions.h: Added.
  • Modules/paymentrequest/PaymentOptions.idl: Added.
  • Modules/paymentrequest/PaymentRequest.cpp: Added.

(WebCore::PaymentRequest::create):
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::abort):
(WebCore::PaymentRequest::canMakePayment):

  • Modules/paymentrequest/PaymentRequest.h: Added.
  • Modules/paymentrequest/PaymentRequest.idl: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEvent.cpp: Added.

(WebCore::PaymentRequestUpdateEvent::~PaymentRequestUpdateEvent):
(WebCore::PaymentRequestUpdateEvent::updateWith):

  • Modules/paymentrequest/PaymentRequestUpdateEvent.h: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEvent.idl: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEventInit.h: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEventInit.idl: Added.
  • Modules/paymentrequest/PaymentResponse.cpp: Added.

(WebCore::PaymentResponse::complete):

  • Modules/paymentrequest/PaymentResponse.h: Added.
  • Modules/paymentrequest/PaymentResponse.idl: Added.
  • Modules/paymentrequest/PaymentShippingOption.h: Added.
  • Modules/paymentrequest/PaymentShippingOption.idl: Added.
  • Modules/paymentrequest/PaymentShippingType.h: Added.
  • Modules/paymentrequest/PaymentShippingType.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventNames.in:
  • dom/EventTargetFactory.in:

LayoutTests:

  • TestExpectations: Skipped payment-request tests.
  • platform/ios-wk2/TestExpectations: Enabled payment-request tests on ios-wk2.
  • platform/mac-wk2/TestExpectations: Ditto for mac-wk2.
10:28 AM Changeset in webkit [220954] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

[WebCrypto] Remove the KeyAlgorithm type hierarchy
https://bugs.webkit.org/show_bug.cgi?id=175750

Patch by Sam Weinig <sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Removes the unnecessary indirection that existed to generate a
KeyAlgorithm dictionary (or rather, one of its derived dictionaries)
for a CryptoKey. We were calling the virtual buildAlgorithm(), which
return a std::unique_ptr<KeyAlgorithm>, which we then casted to the
correct derived class and called dictionary() on. This can now be
simplified by making each CryptoKey derived class override a function
that returns the KeyAlgorithm variant.

  • crypto/CryptoKey.cpp:

(WebCore::CryptoKey::algorithm const): Deleted.

  • crypto/CryptoKey.h:

(WebCore::CryptoKey::extractable const):
(WebCore::KeyAlgorithm::~KeyAlgorithm): Deleted.
(WebCore::KeyAlgorithm::name const): Deleted.
(WebCore::KeyAlgorithm::KeyAlgorithm): Deleted.

  • crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::algorithm const):
(WebCore::AesKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyAES::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::algorithm const):
(WebCore::EcKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyEC::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyEC.h:

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm): Deleted.
(WebCore::EcKeyAlgorithm::namedCurve const): Deleted.

  • crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::algorithm const):
(WebCore::HmacKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyHMAC::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.cpp:

(WebCore::RsaKeyAlgorithm::dictionary const): Deleted.
(WebCore::RsaHashedKeyAlgorithm::dictionary const): Deleted.

  • crypto/keys/CryptoKeyRSA.h:

(WebCore::RsaKeyAlgorithm::RsaKeyAlgorithm): Deleted.
(WebCore::RsaKeyAlgorithm::modulusLength const): Deleted.
(WebCore::RsaKeyAlgorithm::publicExponent const): Deleted.

  • crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::algorithm const):
(WebCore::RawKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyRaw::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyRaw.h:

(WebCore::RawKeyAlgorithm::RawKeyAlgorithm): Deleted.

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

9:41 AM Changeset in webkit [220953] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Mac] Change uint8_t* to Vector<uint8_t> type in all crypto algorithm implementation
https://bugs.webkit.org/show_bug.cgi?id=164939

Patch by Sam Weinig <sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Address FIXMEs, replacing uint8_t*/size_t parameters with Vector<uint8_t>&.

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::wrapKeyAES_KW):
(WebCore::unwrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::encryptRSAES_PKCS1_v1_5):
(WebCore::decryptRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::signRSASSA_PKCS1_v1_5):
(WebCore::verifyRSASSA_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::encryptRSA_OAEP):
(WebCore::decryptRSA_OAEP):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

1:46 AM Changeset in webkit [220952] by wenson_hsieh@apple.com
  • 2 edits in trunk/Tools

[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
https://bugs.webkit.org/show_bug.cgi?id=175509
<rdar://problem/33728169>

Reviewed by Ryosuke Niwa.

Removes ExternalSourceAttributedStringToContentEditable and adds
ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
other style attribute, such as color, carries over from the NSAttributedString to the DOM.

Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

Aug 18, 2017:

11:40 PM Changeset in webkit [220951] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Forbid setDragImage after dragstart
https://bugs.webkit.org/show_bug.cgi?id=175751

Reviewed by Wenson Hsieh.

Removed the code to allow setting the drag mage after dragstart had happened.

The feature was apparently used in Mac WebKit1 port but using it today causes the drag image
to disapepar while the user is moving the mouse cursor and being drawn once it's stopped
and results in the contionus flickering of the drag image.

The feaure was never supported in WebKit2 and doesn't match the HTML5 specification:
https://html.spec.whatwg.org/multipage/dnd.html#concept-dnd-rw
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdragimage
or the behaviors of other browsers such as Chrome and Firefox.

No new tests. This patch simply removes code.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::canSetDragImage const): Deleted.

  • dom/DataTransfer.h:

(WebCore::DataTransfer::makeDragImageWritable): Deleted.

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

8:05 PM Changeset in webkit [220950] by rniwa@webkit.org
  • 4 edits in trunk

REGRESSION(r219640): Speedometer no longer runs on Safari 7
https://bugs.webkit.org/show_bug.cgi?id=175749

Reviewed by Joseph Pecoraro.

PerformanceTests:

Use regular string instead of template literal to make the script compatible with older versions of Safari.

  • Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

Websites/browserbench.org:

Fix the bug on browserbench.org.

  • Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

6:40 PM Changeset in webkit [220949] by weinig@apple.com
  • 24 edits
    2 moves
    3 deletes in trunk/Source/WebCore

[WebCrypto] Get rid of CryptoKeyData class and all its subclasses
https://bugs.webkit.org/show_bug.cgi?id=169806

Reviewed by Chris Dumez.

  • Replaces the CryptoKeyData type hierarchy

CryptoKeyData

  • CryptoKeyDataOctetSequence
  • CryptoKeyDataRSAComponents

with the renamed CryptoKeyRSAComponents.

  • Removes pure virtual exportData function on CryptoKey, and all the implementations except the one on CryptoKeyRSA, which now is non-virtual, and returns a CryptoKeyRSAComponents. Update the one external caller, SerializedScriptValue, to handle this.
  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/SerializedScriptValue.cpp:
  • crypto/CryptoAlgorithm.h:
  • crypto/CryptoKey.h:
  • crypto/CryptoKeyData.h: Removed.
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
  • crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

  • crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::exportData const): Deleted.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyDataOctetSequence.cpp: Removed.
  • crypto/keys/CryptoKeyDataOctetSequence.h: Removed.
  • crypto/keys/CryptoKeyDataRSAComponents.cpp: Removed.
  • crypto/keys/CryptoKeyDataRSAComponents.h: Removed.
  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportData const): Deleted.

  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::exportData const): Deleted.

  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):
(WebCore::CryptoKeyRSA::exportJwk const):

  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRSAComponents.cpp: Copied from crypto/keys/CryptoKeyDataRSAComponents.cpp.

(WebCore::CryptoKeyRSAComponents::CryptoKeyRSAComponents):
(WebCore::CryptoKeyRSAComponents::~CryptoKeyRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents): Deleted.
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents): Deleted.

  • crypto/keys/CryptoKeyRSAComponents.h: Copied from crypto/keys/CryptoKeyDataRSAComponents.h.

(WebCore::CryptoKeyRSAComponents::createPublic):
(WebCore::CryptoKeyRSAComponents::createPrivate):
(WebCore::CryptoKeyRSAComponents::createPrivateWithAdditionalData):

  • crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::exportData const): Deleted.

  • crypto/keys/CryptoKeyRaw.h:
  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::getPrivateKeyComponents):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

6:29 PM Changeset in webkit [220948] by commit-queue@webkit.org
  • 11 edits in trunk

[Cache API] Add support for being loaded responses
https://bugs.webkit.org/show_bug.cgi?id=175732

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/common.https-expected.txt:

Source/WebCore:

Covered by existing and rebased tests.

Introducing a callback-based method to consume the body when the load is finished.
Using that new method in Cache::put and calling batchPutOperation when the load is finished.

Fixing the case of a fetch response being cloned, in which case its body should be marked as ReadableStream.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::put): Changing order of checks to reduce test flakiness risks as there is not yet support for putting responses with ReadableStream.
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

  • Modules/cache/Cache.h:
  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::readableStreamBody): Deleted.

  • Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::setAsReadableStream):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::consumeBodyWhenLoaded):

  • Modules/fetch/FetchResponse.h:

LayoutTests:

5:30 PM Changeset in webkit [220947] by Ryan Haddad
  • 7 edits
    1 delete in trunk

Unreviewed, rolling out r220938.

The API tests added with this change are failing.

Reverted changeset:

"Add WTFLogChannel level to allow runtime log filtering"
https://bugs.webkit.org/show_bug.cgi?id=175731
http://trac.webkit.org/changeset/220938

5:27 PM Changeset in webkit [220946] by Chris Dumez
  • 24 edits
    2 adds in trunk

[Beacon] Improve error reporting
https://bugs.webkit.org/show_bug.cgi?id=175723

Reviewed by Darin Adler.

Source/WebCore:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

Test: http/wpt/beacon/beacon-async-error-logging.html

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::NavigatorBeacon):
(WebCore::NavigatorBeacon::~NavigatorBeacon):
(WebCore::NavigatorBeacon::from):
(WebCore::NavigatorBeacon::supplementName):
(WebCore::NavigatorBeacon::notifyFinished):
(WebCore::NavigatorBeacon::logError):
(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/beacon/NavigatorBeacon.h:
  • loader/LoaderStrategy.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestBeaconResource):

  • loader/cache/CachedResourceLoader.h:
  • platform/network/PingHandle.h:

Source/WebKit:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::didFinish):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::currentRequest const):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/beacon-async-error-logging-expected.txt: Added.
  • http/wpt/beacon/beacon-async-error-logging.html: Added.
5:27 PM Changeset in webkit [220945] by webkit@devinrousso.com
  • 2 edits in trunk/Tools

Unreviewed, change my email.

  • Scripts/webkitpy/common/config/contributors.json:
5:20 PM Changeset in webkit [220944] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked fast/scrolling/arrow-key-scroll-in-rtl-document.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173779

Unreviewed Test gardening.

  • platform/mac-wk2/TestExpectations:
5:03 PM Changeset in webkit [220943] by Ryan Haddad
  • 2 edits in trunk/JSTests

Skip flaky JSC test microbenchmarks/generator-with-several-types.js.
https://bugs.webkit.org/show_bug.cgi?id=172543

Unreviewed test gardening.

  • microbenchmarks/generator-with-several-types.js:
4:26 PM Changeset in webkit [220942] by Jonathan Bedard
  • 3 edits in trunk/Tools

Fix leak-checking for iOS Simulators
https://bugs.webkit.org/show_bug.cgi?id=175735

Reviewed by Darin Adler.

If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
Simulator (or device) because the process will have already been killed by the time we
check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
(ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
and SimulatorProcess.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Before closing the process, check for leaks.

4:24 PM Changeset in webkit [220941] by weinig@apple.com
  • 51 edits
    23 deletes in trunk

Remove the deprecated WebKitSubtleCrypto interface
https://bugs.webkit.org/show_bug.cgi?id=164938
<rdar://problem/29894563>

Reviewed by Chris Dumez.

Source/WebCore:

Remove WebKitSubtleCrypto and all of its helper classes / functionality.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmDictionary.cpp: Removed.
  • bindings/js/JSCryptoAlgorithmDictionary.h: Removed.
  • bindings/js/JSCryptoKeySerializationJWK.cpp: Removed.
  • bindings/js/JSCryptoKeySerializationJWK.h: Removed.
  • bindings/js/JSCryptoOperationData.cpp: Removed.
  • bindings/js/JSCryptoOperationData.h: Removed.
  • bindings/js/JSWebKitSubtleCryptoCustom.cpp: Removed.
  • crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::deriveKey): Deleted.
(WebCore::CryptoAlgorithm::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithm::decryptForUnwrapKey): Deleted.

  • crypto/CryptoAlgorithm.h:
  • crypto/CryptoAlgorithmParametersDeprecated.h: Removed.
  • crypto/CryptoKeySerialization.h: Removed.
  • crypto/WebKitSubtleCrypto.cpp: Removed.
  • crypto/WebKitSubtleCrypto.h: Removed.
  • crypto/WebKitSubtleCrypto.idl: Removed.
  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches const): Deleted.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey): Deleted.

  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches const): Deleted.

  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches const): Deleted.

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches const): Deleted.

  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.cpp:
  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.

  • crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
  • crypto/keys/CryptoKeySerializationRaw.cpp: Removed.
  • crypto/keys/CryptoKeySerializationRaw.h: Removed.
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:
  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
  • crypto/parameters/CryptoAlgorithmAesCbcParamsDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmAesKeyGenParamsDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmHmacKeyParamsDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmHmacParamsDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmRsaKeyGenParamsDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHashDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmRsaOaepParamsDeprecated.h: Removed.
  • crypto/parameters/CryptoAlgorithmRsaSsaParamsDeprecated.h: Removed.
  • features.json:
  • page/Crypto.cpp:
  • page/Crypto.h:
  • page/Crypto.idl:

LayoutTests:

  • crypto/webkitSubtle: Removed.
  • crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt.html: Removed.
  • crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt.html: Removed.
  • crypto/webkitSubtle/aes-cbc-encrypt-decrypt-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding.html: Removed.
  • crypto/webkitSubtle/aes-cbc-encrypt-decrypt.html: Removed.
  • crypto/webkitSubtle/aes-cbc-generate-key-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-generate-key.html: Removed.
  • crypto/webkitSubtle/aes-cbc-import-jwk-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-import-jwk.html: Removed.
  • crypto/webkitSubtle/aes-cbc-invalid-length-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-invalid-length.html: Removed.
  • crypto/webkitSubtle/aes-cbc-unwrap-failure-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-unwrap-failure.html: Removed.
  • crypto/webkitSubtle/aes-cbc-unwrap-rsa-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-unwrap-rsa.html: Removed.
  • crypto/webkitSubtle/aes-cbc-wrap-rsa-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable.html: Removed.
  • crypto/webkitSubtle/aes-cbc-wrap-rsa.html: Removed.
  • crypto/webkitSubtle/aes-cbc-wrong-key-class-expected.txt: Removed.
  • crypto/webkitSubtle/aes-cbc-wrong-key-class.html: Removed.
  • crypto/webkitSubtle/aes-export-key-expected.txt: Removed.
  • crypto/webkitSubtle/aes-export-key.html: Removed.
  • crypto/webkitSubtle/aes-kw-key-manipulation-expected.txt: Removed.
  • crypto/webkitSubtle/aes-kw-key-manipulation.html: Removed.
  • crypto/webkitSubtle/aes-kw-wrap-unwrap-aes-expected.txt: Removed.
  • crypto/webkitSubtle/aes-kw-wrap-unwrap-aes.html: Removed.
  • crypto/webkitSubtle/aes-postMessage-expected.txt: Removed.
  • crypto/webkitSubtle/aes-postMessage.html: Removed.
  • crypto/webkitSubtle/argument-conversion-expected.txt: Removed.
  • crypto/webkitSubtle/argument-conversion.html: Removed.
  • crypto/webkitSubtle/array-buffer-view-offset-expected.txt: Removed.
  • crypto/webkitSubtle/array-buffer-view-offset.html: Removed.
  • crypto/webkitSubtle/disallowed-in-worker-expected.txt: Removed.
  • crypto/webkitSubtle/disallowed-in-worker.html: Removed.
  • crypto/webkitSubtle/gc-2-expected.txt: Removed.
  • crypto/webkitSubtle/gc-2.html: Removed.
  • crypto/webkitSubtle/gc-3-expected.txt: Removed.
  • crypto/webkitSubtle/gc-3.html: Removed.
  • crypto/webkitSubtle/gc-expected.txt: Removed.
  • crypto/webkitSubtle/gc.html: Removed.
  • crypto/webkitSubtle/hmac-check-algorithm-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-check-algorithm.html: Removed.
  • crypto/webkitSubtle/hmac-export-key-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-export-key.html: Removed.
  • crypto/webkitSubtle/hmac-generate-key-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-generate-key.html: Removed.
  • crypto/webkitSubtle/hmac-import-jwk-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-import-jwk.html: Removed.
  • crypto/webkitSubtle/hmac-postMessage-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-postMessage.html: Removed.
  • crypto/webkitSubtle/hmac-sign-verify-empty-key-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-sign-verify-empty-key.html: Removed.
  • crypto/webkitSubtle/hmac-sign-verify-expected.txt: Removed.
  • crypto/webkitSubtle/hmac-sign-verify.html: Removed.
  • crypto/webkitSubtle/import-export-raw-key-leak-expected.txt: Removed.
  • crypto/webkitSubtle/import-export-raw-key-leak.html: Removed.
  • crypto/webkitSubtle/import-jwk-expected.txt: Removed.
  • crypto/webkitSubtle/import-jwk.html: Removed.
  • crypto/webkitSubtle/jwk-export-use-values-expected.txt: Removed.
  • crypto/webkitSubtle/jwk-export-use-values.html: Removed.
  • crypto/webkitSubtle/jwk-import-use-values-expected.txt: Removed.
  • crypto/webkitSubtle/jwk-import-use-values.html: Removed.
  • crypto/webkitSubtle/resources: Removed.
  • crypto/webkitSubtle/resources/disallowed-in-worker.js: Removed.
  • crypto/webkitSubtle/resources/rsa-indexeddb-non-exportable.js: Removed.
  • crypto/webkitSubtle/resources/rsa-indexeddb.js: Removed.
  • crypto/webkitSubtle/rsa-export-generated-keys-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-export-generated-keys.html: Removed.
  • crypto/webkitSubtle/rsa-export-key-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-export-key.html: Removed.
  • crypto/webkitSubtle/rsa-export-private-key-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-export-private-key.html: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-non-exportable-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-non-exportable-private-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-non-exportable-private.html: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-non-exportable.html: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-private-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-indexeddb-private.html: Removed.
  • crypto/webkitSubtle/rsa-indexeddb.html: Removed.
  • crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key.html: Removed.
  • crypto/webkitSubtle/rsa-oaep-key-manipulation-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-oaep-key-manipulation.html: Removed.
  • crypto/webkitSubtle/rsa-oaep-plaintext-length-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-oaep-plaintext-length.html: Removed.
  • crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes.html: Removed.
  • crypto/webkitSubtle/rsa-postMessage-expected.txt: Removed.
  • crypto/webkitSubtle/rsa-postMessage.html: Removed.
  • crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Removed.
  • crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt.html: Removed.
  • crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Removed.
  • crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key.html: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key.html: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk.html: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Removed.
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify.html: Removed.
  • crypto/webkitSubtle/sha-1-expected.txt: Removed.
  • crypto/webkitSubtle/sha-1.html: Removed.
  • crypto/webkitSubtle/sha-224-expected.txt: Removed.
  • crypto/webkitSubtle/sha-224.html: Removed.
  • crypto/webkitSubtle/sha-256-expected.txt: Removed.
  • crypto/webkitSubtle/sha-256.html: Removed.
  • crypto/webkitSubtle/sha-384-expected.txt: Removed.
  • crypto/webkitSubtle/sha-384.html: Removed.
  • crypto/webkitSubtle/sha-512-expected.txt: Removed.
  • crypto/webkitSubtle/sha-512.html: Removed.
  • crypto/webkitSubtle/unimplemented-unwrap-crash-expected.txt: Removed.
  • crypto/webkitSubtle/unimplemented-unwrap-crash.html: Removed.
  • crypto/webkitSubtle/unwrapKey-check-usage-expected.txt: Removed.
  • crypto/webkitSubtle/unwrapKey-check-usage.html: Removed.
  • crypto/webkitSubtle/wrapKey-check-usage-expected.txt: Removed.
  • crypto/webkitSubtle/wrapKey-check-usage.html: Removed.

Remove webkitSubtleCrypto tests.

  • fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt:

Remove webkitSubtleCrypto deprecation warning that no longer happens.

  • platform/ios-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wpe/TestExpectations:

Remove webkitSubtle tests from expectations files.

4:15 PM Changeset in webkit [220940] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Remove classic mode screen scale clamping
https://bugs.webkit.org/show_bug.cgi?id=175739
<rdar://problem/33894531>

Reviewed by Andy Estes.

  • platform/ios/PlatformScreenIOS.mm:

(WebCore::screenScaleFactor):
This code is no longer needed.

4:02 PM Changeset in webkit [220939] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 add in trunk/Source/WebCore

[Curl] Improve multi-threaded networking
https://bugs.webkit.org/show_bug.cgi?id=175713

Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-08-18
Reviewed by Alex Christensen.

  • platform/Curl.cmake:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::m_failureTimer): Deleted.

  • platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::didReceiveResponse):

  • platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::init):
(WebCore::CurlDownload::start):
(WebCore::CurlDownload::cancel):
(WebCore::CurlDownload::retain):
(WebCore::CurlDownload::release):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::notifyFinish):
(WebCore::CurlDownload::notifyFail):

  • platform/network/curl/CurlDownload.h:
  • platform/network/curl/CurlJobManager.cpp:

(WebCore::CurlJobList::isEmpty const):
(WebCore::CurlJobList::startJobs):
(WebCore::CurlJobList::finishJobs):
(WebCore::CurlJobList::notifyResult):
(WebCore::CurlJobManager::add):
(WebCore::CurlJobManager::cancel):
(WebCore::CurlJobManager::callOnJobThread):
(WebCore::CurlJobManager::startThreadIfNeeded):
(WebCore::CurlJobManager::updateJobList):
(WebCore::CurlJobManager::workerThread):
(WebCore::CurlJobList::append): Deleted.
(WebCore::CurlJobList::cancel): Deleted.
(WebCore::CurlJobList::complete): Deleted.
(WebCore::CurlJobList::withJob): Deleted.
(WebCore::CurlJobList::withCurlHandle): Deleted.
(WebCore::CurlJob::invoke): Deleted.
(WebCore::CurlJobManager::updateJobs): Deleted.

  • platform/network/curl/CurlJobManager.h:

(WebCore::CurlJob::CurlJob): Deleted.
(WebCore::CurlJob::~CurlJob): Deleted.
(WebCore::CurlJob::operator=): Deleted.
(WebCore::CurlJob::curlHandle const): Deleted.
(WebCore::CurlJob::ticket const): Deleted.
(WebCore::CurlJob::finished): Deleted.
(WebCore::CurlJob::error): Deleted.
(WebCore::CurlJob::cancel): Deleted.
(WebCore::CurlJobManager::isActiveJob const): Deleted.

  • platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveData):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandleInternal::initialize): Deleted.
(WebCore::ResourceHandleInternal::applyAuthentication): Deleted.
(WebCore::getFormElementsCount): Deleted.
(WebCore::ResourceHandleInternal::setupPUT): Deleted.
(WebCore::ResourceHandleInternal::setupPOST): Deleted.
(WebCore::ResourceHandleInternal::setupFormData): Deleted.
(WebCore::ResourceHandleInternal::didFinish): Deleted.
(WebCore::ResourceHandleInternal::didFail): Deleted.
(WebCore::ResourceHandleInternal::calculateWebTimingInformations): Deleted.
(WebCore::ResourceHandleInternal::handleLocalReceiveResponse): Deleted.
(WebCore::isHttpInfo): Deleted.
(WebCore::isHttpRedirect): Deleted.
(WebCore::isHttpAuthentication): Deleted.
(WebCore::isHttpNotModified): Deleted.
(WebCore::isAppendableHeader): Deleted.
(WebCore::removeLeadingAndTrailingQuotes): Deleted.
(WebCore::getProtectionSpace): Deleted.
(WebCore::ResourceHandleInternal::willPrepareSendData): Deleted.
(WebCore::ResourceHandleInternal::didReceiveHeaderLine): Deleted.
(WebCore::ResourceHandleInternal::didReceiveAllHeaders): Deleted.
(WebCore::ResourceHandleInternal::didReceiveContentData): Deleted.
(WebCore::ResourceHandleInternal::readCallback): Deleted.
(WebCore::ResourceHandleInternal::headerCallback): Deleted.
(WebCore::ResourceHandleInternal::writeCallback): Deleted.
(WebCore::ResourceHandleInternal::dispatchSynchronousJob): Deleted.
(WebCore::ResourceHandleInternal::handleDataURL): Deleted.

  • platform/network/curl/ResourceHandleCurlDelegate.cpp: Added.

(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::~ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::hasHandle const):
(WebCore::ResourceHandleCurlDelegate::releaseHandle):
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::cancel):
(WebCore::ResourceHandleCurlDelegate::setDefersLoading):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::dispatchSynchronousJob):
(WebCore::ResourceHandleCurlDelegate::retain):
(WebCore::ResourceHandleCurlDelegate::release):
(WebCore::ResourceHandleCurlDelegate::setupRequest):
(WebCore::ResourceHandleCurlDelegate::notifyFinish):
(WebCore::ResourceHandleCurlDelegate::notifyFail):
(WebCore::ResourceHandleCurlDelegate::response):
(WebCore::ResourceHandleCurlDelegate::setupAuthentication):
(WebCore::removeLeadingAndTrailingQuotes):
(WebCore::ResourceHandleCurlDelegate::getProtectionSpace):
(WebCore::isHttpInfo):
(WebCore::isHttpRedirect):
(WebCore::isHttpAuthentication):
(WebCore::isHttpNotModified):
(WebCore::isAppendableHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderLine):
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::didReceiveContentData):
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::prepareSendData):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::didFail):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::setupPOST):
(WebCore::ResourceHandleCurlDelegate::setupPUT):
(WebCore::ResourceHandleCurlDelegate::getFormElementsCount):
(WebCore::ResourceHandleCurlDelegate::setupFormData):
(WebCore::ResourceHandleCurlDelegate::applyAuthentication):
(WebCore::ResourceHandleCurlDelegate::setWebTimings):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveData):
(WebCore::ResourceHandleCurlDelegate::willSendData):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderCallback):
(WebCore::ResourceHandleCurlDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCurlDelegate::willSendDataCallback):

  • platform/network/curl/ResourceHandleCurlDelegate.h: Added.
3:46 PM Changeset in webkit [220938] by eric.carlson@apple.com
  • 7 edits
    1 add in trunk

Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/MemoryPressureHandler.cpp:
  • wtf/RefCountedLeakCounter.cpp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.

(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

3:34 PM Changeset in webkit [220937] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

iOS 10 debug build fix.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer):

3:15 PM Changeset in webkit [220936] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Marking canvas/webgl tests as failing
https://bugs.webkit.org/show_bug.cgi?id=175736

Unreviewed test gardening.

  • platform/ios-device/TestExpectations:
2:53 PM Changeset in webkit [220935] by rniwa@webkit.org
  • 8 edits
    1 delete in trunk/Source/WebCore

Rename DataTransferAccessPolicy to match spec and refactor related node
https://bugs.webkit.org/show_bug.cgi?id=175704

Reviewed by Wenson Hsieh.

Renamed DataTransferAccessPolicy to DataTransfer::StoreMode to match the drag data store mode concept
in the HTML5 specification:
https://html.spec.whatwg.org/multipage/dnd.html#drag-data-store-mode

DataTransfer in addition to those states can be disassociated from the drag data store when it becomes
no longer valid. We also support a special mode which allows only updating the drag image.
These two states, Invalid and DragImageWritable, are added in addition to the three states in the spec.

Also split DragAndDrop type of DataTransfer into DragAndDropData and DragAndDropFiles, and refactored
the related code.

No new tests since there should be no behavioral change.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer): No longer takes forFileDrag boolean since it's folded into type.
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy): Deleted.
(WebCore::DataTransfer::canReadTypes const):
(WebCore::DataTransfer::canReadData const):
(WebCore::DataTransfer::canWriteData const):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):
(WebCore::DataTransfer::canSetDragImage const):

  • dom/DataTransfer.h:

(WebCore::DataTransfer::makeInvalidForSecurity): Added.
(WebCore::DataTransfer::makeDragImageWritable): Added.

  • dom/DataTransferAccessPolicy.h: Removed.
  • editing/Editor.cpp:

(WebCore::dispatchClipboardEvent): Moved and renamed from dispatchCPPEvent. Now computes the store mode
inside the function to match the spec: https://w3c.github.io/clipboard-apis/#fire-a-clipboard-event
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent): Deleted.

  • editing/Editor.h:
  • page/DragController.cpp:

(WebCore::createDataTransferToUpdateDrag): Extracted to share code.
(WebCore::DragController::dragExited):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::tryDHTMLDrag):

  • page/EventHandler.cpp:

(WebCore::EventHandler::invalidateDataTransfer):
(WebCore::EventHandler::handleDrag):

2:40 PM Changeset in webkit [220934] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

Followup (r220289): RenderImageResourceStyleImage code clean up
https://bugs.webkit.org/show_bug.cgi?id=175444

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-08-18
Reviewed by Darin Adler.

RenderImageResourceStyleImage may be created with a StyleImage of type
StyleGeneratedImage. It may also be associated with a CachedImage which
is loaded through a source URL. In this case, adding and removing m_renderer
as a client of the CachedImage will be done through
RenderImageResource::setCachedImage().

RenderImageResource::setCachedImage() is already called from
ImageLoader::updateRenderer() when the CachedImage finishes loading. This
call adds m_renderer to the clients of the CachedImage.
RenderImageResource::setCachedImage() will also be called from
RenderImageResourceStyleImage::shutdown() via RenderImageResource::shutdown()
to remove m_renderer from the clients of CachedImage by passing a null pointer.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::styleWillChange):

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::shutdown):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerSizeForRenderer):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::~RenderImageResource): Deleted.
(WebCore::RenderImageResource::errorOccurred const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeWidth const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeHeight const): Deleted.
(WebCore::RenderImageResource::intrinsicSize const): Deleted.
(WebCore::RenderImageResource::getImageSize const): Deleted.

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::renderer const):
(WebCore::RenderImageResource::errorOccurred const):
(WebCore::RenderImageResource::imageHasRelativeWidth const):
(WebCore::RenderImageResource::imageHasRelativeHeight const):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::intrinsicSize const):
(WebCore::RenderImageResource::imagePtr const):

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):
(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image const):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
(WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): Deleted.

  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):

2:30 PM Changeset in webkit [220933] by jiewen_tan@apple.com
  • 8 edits
    2 adds in trunk

[WebCrypto][Mac] Replace CCECCryptorGetKeyComponents with CCECCryptorExportKey for exporting ECC JWKs
https://bugs.webkit.org/show_bug.cgi?id=175657
<rdar://problem/33797150>

Reviewed by Brent Fulgham.

Source/WebCore:

CCECCryptorGetKeyComponents returns components in unpadded formats. In some minor cases, the ECC components
do need padding. Therefore, we occasionally see some corrupted outputs in JWKs. To overcome that, this patch
replaces CCECCryptorGetKeyComponents with CCECCryptorExportKey which does padding all the time.

In the meantime, this patch also makes export* methods return OperationError if any error occur in the
underlying operations though very unlikely.

Test: crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html

  • crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::exportKey):

  • crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::exportKey):

  • crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::CryptoKeyEC::platformAddFieldElements const):

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportRaw const):
(WebCore::CryptoKeyEC::exportJwk const):
(WebCore::CryptoKeyEC::exportSpki const):
(WebCore::CryptoKeyEC::exportPkcs8 const):

  • crypto/keys/CryptoKeyEC.h:
  • crypto/mac/CryptoKeyECMac.cpp:

(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):

LayoutTests:

  • crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify-expected.txt: Added.
  • crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html: Added.
2:07 PM Changeset in webkit [220932] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=172044

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:53 PM Changeset in webkit [220931] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

REGRESSION (r220601): Crash when closing google doc after switching the order of tabs in safari
https://bugs.webkit.org/show_bug.cgi?id=175721
<rdar://problem/33928369>

Reviewed by Geoffrey Garen.

Make sure WebProcess::markAllLayersVolatile() does not call WTFMove() multiple times
on the same completion handler. Use a RefCounter to hold on to the completion handler
and make sure the handler gets called when the RefCounter's value becomes 0.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::cancelMarkAllLayersVolatile):

  • WebProcess/WebProcess.h:
1:50 PM Changeset in webkit [220930] by pvollan@apple.com
  • 4 edits in trunk/Source

[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
https://bugs.webkit.org/show_bug.cgi?id=173536

Reviewed by Brent Fulgham.

If the tree state is dirty, accessible objects are deleted while iterating over children
under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
style is updated before this method is called.

Source/WebCore:

No new tests, covered by existing tests.

  • accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):

Source/WebKitLegacy/win:

  • AccessibleBase.cpp:

(AccessibleBase::getAccessibilityObjectForChild):

1:16 PM Changeset in webkit [220929] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked js/slow-stress/Int32Array-alloc-huge.html as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=173010

Unreviewed test gardening.

  • platform/mac/TestExpectations:
12:32 PM Changeset in webkit [220928] by commit-queue@webkit.org
  • 20 edits in trunk

[Cache API] Add response body storage
https://bugs.webkit.org/show_bug.cgi?id=175658

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Covered by rebased tests.
Tests are still flaky until waiting for end of fetch load is implemented.

Adding a response body within CacheStorageConnection::Record.
Adding ability to pass this body from/to the main thread.

Adding response body consumption into a CacheStorageConnection::Record.
Adding response body setting from a CacheStorageConnection::Record.

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/cache/Cache.cpp:

(WebCore::Cache::put):
(WebCore::toConnectionRecord):
(WebCore::Cache::updateRecords):

  • Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::copyResponseBody):
(WebCore::CacheStorageConnection::isolatedResponseBody):
(WebCore::CacheStorageConnection::Record::copy const):

  • Modules/cache/CacheStorageConnection.h:
  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::bodyAsFormData const):
(WebCore::FetchBody::take):
(WebCore::FetchBody::bodyForInternalRequest const): Deleted.

  • Modules/fetch/FetchBody.h:

(WebCore::FetchBody::setAsFormData):

  • Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::setData):

  • Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::resourceRequest const):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::setBodyData):

  • Modules/fetch/FetchResponse.h:

Source/WebKit:

Added IPC serialization of Record response body.
Updated CacheStorageEngine implementation as Record has no longer a copy constructor.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

12:32 PM Changeset in webkit [220927] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Fetch API] Add support for a callback-based fetch
https://bugs.webkit.org/show_bug.cgi?id=175710

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

No change of behavior.

Moving from a DOMPromise to a Callback taking an ExceptionOr<FetchResponse&>.
Updating window and worker call sites.

  • Modules/fetch/DOMWindowFetch.cpp:

(WebCore::DOMWindowFetch::fetch):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::BodyLoader::stop):

  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/WorkerGlobalScopeFetch.cpp:

(WebCore::WorkerGlobalScopeFetch::fetch):

12:20 PM Changeset in webkit [220926] by pvollan@apple.com
  • 7 edits in trunk/Source

Implement 32-bit MacroAssembler::probe support for Windows.
https://bugs.webkit.org/show_bug.cgi?id=175449

Reviewed by Mark Lam.

Source/JavaScriptCore:

This is needed to enable the DFG.

  • assembler/MacroAssemblerX86Common.cpp:
  • assembler/testmasm.cpp:

(JSC::run):
(dllLauncherEntryPoint):

  • shell/CMakeLists.txt:
  • shell/PlatformWin.cmake:

Source/WTF:

Enable the DFG on Win32.

  • wtf/Platform.h:
11:56 AM Changeset in webkit [220925] by ap@apple.com
  • 2 edits in trunk/Tools

Add Dean Johnson to contributors.json for Bugzilla autocomplete.

  • Scripts/webkitpy/common/config/contributors.json:
11:52 AM Changeset in webkit [220924] by beidson@apple.com
  • 66 edits
    7 copies
    3 adds in trunk

Bounce ServiceWorker jobs to the Storage Process.
https://bugs.webkit.org/show_bug.cgi?id=175650

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

Now that the serviceWorker.register() call is asynchronous, update a whole bunch of test results.

  • web-platform-tests/FileAPI/historical.https-expected.txt:
  • web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
  • web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by both changes and consistencies in existing tests)

This lays the groundwork for the SW job queue being in the StorageProcess by actually
setting up some objects for IPC communication and actually sending things over the wire.

The main point of IPC is the WebCore abstract base class "SWServer::Connection"

A collection of them will soon be managed by the SWServer itself in the StorageProcess.

That object will be the stand-in for IPC on both the WebProcess and StorageProcess side.

Currently, any job that we try to schedule still immediately rejects (though now it does
so asynchronously instead of synchronously).

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ExceptionData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::ExceptionData::toException const):
(WebCore::ExceptionData::encode const):
(WebCore::ExceptionData::decode):

  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException):
(WebCore::ServiceWorkerJob::data const):

  • workers/service/ServiceWorkerJob.h:
  • workers/service/ServiceWorkerJobData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

  • workers/service/ServiceWorkerJobType.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.
  • workers/service/ServiceWorkerProvider.h:
  • workers/service/ServiceWorkerRegistrationParameters.h:
  • workers/service/server/SWServer.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.

(WebCore::SWServer::Connection::scheduleJob):
(WebCore::SWServer::Connection::jobRejected):

  • workers/service/server/SWServer.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::SWServer::Connection::~Connection):

Source/WebKit:

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebKit.xcodeproj/project.pbxproj:
  • Platform/Logging.h:
  • StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):

  • StorageProcess/StorageToWebProcessConnection.h:
  • StorageProcess/StorageToWebProcessConnection.messages.in:
  • WebProcess/Storage/WebSWServerConnection.cpp: Added.

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::disconnectedFromWebProcess):
(WebKit::WebSWServerConnection::scheduleJob):
(WebKit::WebSWServerConnection::scheduleStorageJob):

  • WebProcess/Storage/WebSWServerConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerJob.h.

(WebKit::WebSWServerConnection::create):
(WebKit::WebSWServerConnection::identifier const):

  • WebProcess/Storage/WebSWServerConnection.messages.in: Copied from Source/WebKit/StorageProcess/StorageToWebProcessConnection.messages.in.
  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):
(WebKit::WebServiceWorkerProvider::scheduleJob): Deleted.

  • WebProcess/Storage/WebServiceWorkerProvider.h:
  • WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

  • WebProcess/Storage/WebToStorageProcessConnection.h:

LayoutTests:

Service worker tests will always be dumpAsText and always be asynchronous.

  • http/tests/workers/service/basic-register.html:
  • http/tests/workers/service/resources/basic-register.js:
  • http/tests/workers/service/resources/sw-test-pre.js: Added.
10:58 AM Changeset in webkit [220923] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed, update TestExpectations.

  • platform/mac-highsierra/TestExpectations:
10:58 AM Changeset in webkit [220922] by Chris Dumez
  • 21 edits in trunk

[Beacon] Add support for quota limitation
https://bugs.webkit.org/show_bug.cgi?id=175443
<rdar://problem/33729002>

Reviewed by Youenn Fablet.

Source/WebCore:

LoaderStrategy::startPingLoad() now takes a completion handler parameter, allowing CachedResource::load()
to know when a Beacon load is complete. This was needed in order for the fetch in-flight keepalive request
quota limit to work properly for beacon loads as well. We need to know when the beacon load completes in
order to know if the beacon is in-flight or not and only free up its allocated quota once it is no longer
in-flight.

No new tests, updated existing test.

  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::startPingLoad):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • platform/network/PingHandle.h:

Source/WebKit:

WebLoaderStrategy now generates an identifier for ping loads and keep
the completion handler in a local HashMap. Once the ping load is done,
the network process sends an IPC message back to the WebContent process
so that WebLoaderStrategy can look up the completion handler for the
ping load and call it.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.messages.in:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::generatePingLoadIdentifier):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Extend layout test coverage and rebaseline test.

  • http/wpt/beacon/beacon-quota-expected.txt:
  • http/wpt/beacon/beacon-quota.html:
10:54 AM Changeset in webkit [220921] by mark.lam@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Rename ProbeContext and ProbeFunction to Probe::State and Probe::Function.
https://bugs.webkit.org/show_bug.cgi?id=175725
<rdar://problem/33965477>

Rubber-stamped by JF Bastien.

This is purely a refactoring patch (in preparation for the introduction of a
Probe::Context data structure in https://bugs.webkit.org/show_bug.cgi?id=175688
later). This patch does not change any semantics / behavior.

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

  • assembler/MacroAssembler.h:

(JSC::ProbeContext::gpr): Deleted.
(JSC::ProbeContext::spr): Deleted.
(JSC::ProbeContext::fpr): Deleted.
(JSC::ProbeContext::gprName): Deleted.
(JSC::ProbeContext::sprName): Deleted.
(JSC::ProbeContext::fprName): Deleted.
(JSC::ProbeContext::pc): Deleted.
(JSC::ProbeContext::fp): Deleted.
(JSC::ProbeContext::sp): Deleted.

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

  • assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeError):
(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

  • assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssembler::probe):

  • assembler/Printer.h:

(JSC::Printer::Context::Context):

  • assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack): Deleted.

10:49 AM Changeset in webkit [220920] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unreviewed, land TestExpectations for rdar://problem/33850189.

  • platform/mac-highsierra/TestExpectations:
10:42 AM Changeset in webkit [220919] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for El Capitan WK2.

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
9:08 AM Changeset in webkit [220918] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/Tools

[Tools] Add script to download a GitHub release
https://bugs.webkit.org/show_bug.cgi?id=175279

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-18
Reviewed by Brent Fulgham.

  • Scripts/download-latest-github-release.py: Added.
8:51 AM Changeset in webkit [220917] by commit-queue@webkit.org
  • 35 edits
    2 copies
    7 adds in trunk

[Cache API] Add a WK2 implementation of CacheStorageConnection
https://bugs.webkit.org/show_bug.cgi?id=175640

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen & Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

  • Modules/cache/CacheStorageConnection.cpp: Adding Internal error.
  • Modules/cache/CacheStorageConnection.h: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Exporting CacheQueryOptions.h header.

Source/WebKit:

Adding WebCacheStorageConnection as an implementation of CacheStorageConnection.
Making WebCacheStorageProvider instantiates such class.
One WebCacheStorageConnection is created for each session of a given WebProcess.

WebCacheStorageConnection is sending IPC calls to the network process.
Main implementation of the cache API is done in the network process by CacheStorageEngineConnection and CacheStorageEngine.
There is one WebCacheStorageConnection per session.
WebCacheStorageConnection is passing the session ID for each call to the network process to ensure the right cache storage engine is used.

CacheStorageEngineConnection mirrors WebCacheStorageConnection on the network process.
There is one CacheStorageEngine per session and CacheStorageEngineConnection will select the right CacheStorageEngine using the given session ID.

CacheStorageEngine is responsible of storing and matching cache API records.
Current implementation only keeps in memory the cached objects.

CacheStorageEngine is keeping (for each different origin) caches and records as a Vector as the order of insertion is important as per spec.
It also keeps a list of removed caches. These caches should remain functional until the last web page having access to these is gone.
The mechanism to fully remove these caches is not implemented yet.

Adding IPC encodings for WTF::Expected, CacheQueryOptions, FetchOptions, CacheStorageConnection Record and CacheInfo.

  • CMakeLists.txt:
  • DerivedSources.make:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::generateCacheStorageConnectionIdentifier):
(WebKit::NetworkConnectionToWebProcess::createCacheStorageConnection):
(WebKit::NetworkConnectionToWebProcess::closeCacheStorageConnection):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/cache/CacheStorageEngine.cpp: Added.

(WebKit::defaultCacheStorageEngine):
(WebKit::globalEngineMap):
(WebKit::CacheStorageEngine::from):
(WebKit::CacheStorageEngine::destroyEngine):
(WebKit::CacheStorageEngine::defaultEngine):
(WebKit::CacheStorageEngine::open):
(WebKit::CacheStorageEngine::remove):
(WebKit::CacheStorageEngine::retrieveCaches):
(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::putRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):
(WebKit::CacheStorageEngine::writeCachesToDisk):
(WebKit::CacheStorageEngine::readCachesFromDisk):
(WebKit::CacheStorageEngine::readCache):
(WebKit::CacheStorageEngine::writeCacheRecords):
(WebKit::CacheStorageEngine::removeCacheRecords):
(WebKit::CacheStorageEngine::cache):
(WebKit::CacheStorageEngine::caches const):
(WebKit::CacheStorageEngine::records):
(WebKit::CacheStorageEngine::queryCache):

  • NetworkProcess/cache/CacheStorageEngine.h: Added.
  • NetworkProcess/cache/CacheStorageEngineConnection.cpp: Added.

(WebKit::CacheStorageEngineConnection::CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::records):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):

  • NetworkProcess/cache/CacheStorageEngineConnection.h: Added.

(WebKit::CacheStorageEngineConnection::create):

  • NetworkProcess/cache/CacheStorageEngineConnection.messages.in: Added.
  • Platform/IPC/ArgumentCoders.h:
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<CacheQueryOptions>::encode):
(IPC::ArgumentCoder<CacheQueryOptions>::decode):
(IPC::ArgumentCoder<FetchOptions>::encode):
(IPC::ArgumentCoder<FetchOptions>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Cache/WebCacheStorageConnection.cpp: Added.

(WebKit::WebCacheStorageConnection::WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::~WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::messageSenderConnection):
(WebKit::WebCacheStorageConnection::doOpen):
(WebKit::WebCacheStorageConnection::doRemove):
(WebKit::WebCacheStorageConnection::doRetrieveCaches):
(WebKit::WebCacheStorageConnection::doRetrieveRecords):
(WebKit::WebCacheStorageConnection::doBatchDeleteOperation):
(WebKit::WebCacheStorageConnection::doBatchPutOperation):
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):

  • WebProcess/Cache/WebCacheStorageConnection.h: Added.
  • WebProcess/Cache/WebCacheStorageConnection.messages.in: Added.
  • WebProcess/Cache/WebCacheStorageProvider.cpp: Copied from Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.h.

(WebKit::WebCacheStorageProvider::createCacheStorageConnection):

  • WebProcess/Cache/WebCacheStorageProvider.h:
  • WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):

LayoutTests:

  • TestExpectations: Marking some tests as flaky until being loaded resources can be cached.
7:52 AM Changeset in webkit [220916] by Antti Koivisto
  • 9 edits
    2 adds in trunk/Source/WebCore

Factor render tree mutation code from RenderListItem to RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175718

Reviewed by Andreas Kling.

We already stopped doing layout time mutations. We can now move the code out too.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderListItem.cpp:

(WebCore::isHTMLListElement):
(WebCore::getParentOfFirstLineBox): Deleted.
(WebCore::firstNonMarkerChild): Deleted.
(WebCore::RenderListItem::updateMarkerRenderer): Deleted.

Moved to RenderTreeUpdater::ListItem.

  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::willBeDestroyed):

  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

Factor pre/post update into functions.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

  • style/RenderTreeUpdater.h:
  • style/RenderTreeUpdaterListItem.cpp: Added.

Mutation functions move here.

(WebCore::getParentOfFirstLineBox):
(WebCore::firstNonMarkerChild):
(WebCore::RenderTreeUpdater::ListItem::updateMarker):

  • style/RenderTreeUpdaterListItem.h: Added.
6:41 AM Changeset in webkit [220915] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Layout Test media/video-controls-no-scripting.html is failing
https://bugs.webkit.org/show_bug.cgi?id=141835

Unreviewed test gardening.

The output appears to be consistent based on local testing.

Rebaseline video-controls-no-scripting.html.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-18

  • platform/gtk/TestExpectations:
  • platform/gtk/media/video-controls-no-scripting-expected.txt:
4:06 AM Changeset in webkit [220914] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.17.91

WebKitGTK+ 2.17.91

4:04 AM Changeset in webkit [220913] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.91 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.17.91.
2:24 AM Changeset in webkit [220912] by commit-queue@webkit.org
  • 7 edits in trunk/LayoutTests

Update track-datacue.html test to the current code.
https://bugs.webkit.org/show_bug.cgi?id=175624

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-18
Reviewed by Eric Carlson.

  • media/track/track-datacue-expected.txt: rebaselined.
  • media/track/track-datacue.html: updated for IDL, exception changes, addition of a new constructor.
  • platform/gtk/TestExpectations: removed failure expectation.
  • platform/ios/TestExpectations: enable.
  • platform/mac/TestExpectations: enable.
  • platform/win/TestExpectations: enable.
2:12 AM Changeset in webkit [220911] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Remove some obsolete expected failures.
https://bugs.webkit.org/show_bug.cgi?id=175674

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-18

  • platform/gtk/TestExpectations:
    • imported/w3c/web-platform-tests/IndexedDB/keyorder.htm: passing since r204279.
    • imported/w3c/web-platform-tests/resource-timing/rt-cors.html: passing since r212944 and r212993.
    • imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html: passing since r212944 and r212993.
    • imported/w3c/web-platform-tests/webrtc/getstats.html: passing since test update and rebaseline in r217225.
    • mathml/opentype/large-operators-displaystyle-dynamic.html: used to be flaky, seems to be passing consistently now.
    • media/media-fullscreen-return-to-inline.html: likely passing since r218270.
    • media/video-fast-seek.html: passing since r207879-r207894.
    • platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html: passing since r205075.
    • security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html: flaky.
    • storage/indexeddb/cursor-key-order.html: likely passing since r209135.
    • svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg: flaky.
    • svg/repaint/add-outline-property-on-root.html: passing since r211277
    • svg/repaint/remove-outline-property-on-root.html: passing since r211277
1:58 AM Changeset in webkit [220910] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Show controls if a video element isn't allowed to play inline.
https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

  • Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

  • platform/gtk/TestExpectations: enable test for this case.
12:53 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos
(diff)
12:53 AM Changeset in webkit [220909] by Carlos Garcia Campos
  • 2 edits
    1 add
    1 delete in releases/WebKitGTK/webkit-2.18/Tools

Merge r220902 - [GTK] Make TestContextMenu work on Fedora
https://bugs.webkit.org/show_bug.cgi?id=175708

Reviewed by Carlos Garcia Campos.

TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
and my student last summer who was trying to work on a context menu API. It's trying to load
an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
don't care to investigate. Let's switch it to WebM so I can move on.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(prepareContextMenuTestView):

  • TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
  • TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
12:50 AM Changeset in webkit [220908] by Carlos Garcia Campos
  • 4 edits
    3 adds in releases/WebKitGTK/webkit-2.18

Merge r220894 - WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>

Reviewed by Saam Barati.

JSTests:

Add a regression directory for WebAssembly tests.

  • wasm.yaml:
  • wasm/regress/175693.js: Added.

(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):

  • wasm/regress/175693.wasm: Added.

Source/JavaScriptCore:

64-bit constants in an unreachable context were being decoded as
32-bit constants. This is pretty benign because unreachable code
shouldn't occur often. The effect is that 64-bit constants which
can't be encoded as 32-bit constants would cause the binary to be
rejected.

At the same time, 32-bit integer constants should be decoded as signed.

  • wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

12:48 AM Changeset in webkit [220907] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220860 - [WPE][GTK] Ensure proper casting of data in gvariants
https://bugs.webkit.org/show_bug.cgi?id=175667

Patch by Jacobo Aragunde Pérez <jaragunde@igalia.com> on 2017-08-17
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

g_variant_new requires data to have the correct width for their types, using
casting if necessary. Some data of type unsigned were being saved to guint64
types without explicit casting, leading to undefined behavior in some platforms.

  • inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::listingForInspectionTarget const):
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendMessageToRemote):

Source/WebKit:

g_variant_builder_add requires data to have the correct width for their types, using
casting if necessary. Corrected a call where a single precision float was being put
into a double precision parameter without a cast.

  • UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(encodeFrameState):

12:47 AM Changeset in webkit [220906] by Carlos Garcia Campos
  • 11 edits in releases/WebKitGTK/webkit-2.18

Merge r220858 - RenderListItem - Avoid render tree mutation during layout
https://bugs.webkit.org/show_bug.cgi?id=175666

Reviewed by Andreas Kling.

Source/WebCore:

Mutations should be done by RenderTreeUpdater only.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerRenderer):

This is now called by RenderTreeUpdater only.
Remove code dealing with this being called at layout time.
Merged marker construction code from styleDidChange here and renamed for clarity.

(WebCore::RenderListItem::layout):
(WebCore::RenderListItem::computePreferredLogicalWidths):

Remove mutating calls.

(WebCore::RenderListItem::styleDidChange): Deleted.
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded): Deleted.

  • rendering/RenderListItem.h:
  • rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

Call updateMarkerRenderer.

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

Call updateMarkerRenderer.

LayoutTests:

Changes in render tree dumps that don't affect rendering.

  • platform/ios/fast/doctypes/002-expected.txt:
  • platform/ios/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/mac/fast/doctypes/002-expected.txt:
  • platform/mac/fast/lists/marker-before-empty-inline-expected.txt:
12:45 AM Changeset in webkit [220905] by zandobersek@gmail.com
  • 7 edits
    1 add in trunk/Source/WebCore

[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=175671

Reviewed by Xabier Rodriguez-Calvar.

In MediaKeySession::updateKeyStatuses(), HTMLMediaElement objects that are
associated with the MediaKeys instance that created this session have to
be notified in order to run the 'Attempt to Resume Playback If Necessary'
algorithm.

MediaKeys object now tracks the sessions that were created through it.
MediaKeySession object is passed a MediaKeys reference, and has that
reference invalidated if/when the MediaKeys object is destroyed.

In MediaKeySession::updateKeyStatuses(), a task is now queued, notifying
the MediaKeys object, if any, that the associated HTMLMediaElement
instances have to run the mentioned algorithm. The associated media
elements are stored through CDMClient pointers, with HTMLMediaElement
class inheriting from the newly-introduced CDMClient interface.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() is left
unimplemented for now. The object will attach itself to and detach from
the associated MediaKeys object in setMediaKeys() and the destructor,
enabling the MediaKeys object to properly dispatch the playback resume
requests for the attached clients.

  • Modules/encryptedmedia/CDMClient.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeys.h.

(WebCore::CDMClient::~CDMClient):

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::detachKeys):
(WebCore::MediaKeySession::updateKeyStatuses):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::~MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::attachCDMClient):
(WebCore::MediaKeys::detachCDMClient):
(WebCore::MediaKeys::attemptToResumePlaybackOnClients):

  • Modules/encryptedmedia/MediaKeys.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):

  • html/HTMLMediaElement.h:
12:27 AM Changeset in webkit [220904] by Carlos Garcia Campos
  • 17 edits in releases/WebKitGTK/webkit-2.18

Merge r220903 - Unreviewed, rolling out r220854.
https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
https://bugs.webkit.org/show_bug.cgi?id=122952
http://trac.webkit.org/changeset/220854

12:22 AM Changeset in webkit [220903] by commit-queue@webkit.org
  • 17 edits in trunk

Unreviewed, rolling out r220854.
https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
https://bugs.webkit.org/show_bug.cgi?id=122952
http://trac.webkit.org/changeset/220854

Note: See TracTimeline for information about the timeline view.