Timeline



Aug 23, 2017:

11:17 PM Changeset in webkit [221130] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Build fix. Copy the missing statistics.js for Speedometer 2.0.

  • resources/statistics.js: Copied from PerformanceTests/resources/statistics.js.
11:13 PM Changeset in webkit [221129] by rniwa@webkit.org
  • 1 edit
    1 add in trunk/PerformanceTests

Speedometer: Add missing stylesheet to Angular example
https://bugs.webkit.org/show_bug.cgi?id=175820

Fix r221042. It was supposed to add an empty file but git-svn failed to do so.

  • Speedometer/resources/todomvc/architecture-examples/angular/dist/styles.d41d8cd98f00b204e980.bundle.css: Added.
9:12 PM Changeset in webkit [221128] by wenson_hsieh@apple.com
  • 4 edits
    2 adds in trunk

DeleteSelectionCommand should be robust when starting and ending editable positions cannot be found
https://bugs.webkit.org/show_bug.cgi?id=175914
<rdar://problem/29792688>

Reviewed by Ryosuke Niwa.

Source/WebCore:

DeleteSelectionCommand can cause a null dereference if editable start and end positions are not found. This can
happen when attempting to delete after selecting the contents within a canvas or output element with read-write
-webkit-user-modify style. To fix this, we make the initialization step of the DeleteSelectionCommand robust
when editable start and end positions are missing.

Test: editing/execCommand/forward-delete-read-write-canvas.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::initializePositionData):

Make this initialization helper indicate failure via a bool return value. DeleteSelectionCommand::doApply bails
early if initializePositionData returned false.

(WebCore::DeleteSelectionCommand::doApply):

  • editing/DeleteSelectionCommand.h:

LayoutTests:

Adds a new LayoutTest. This test passes if WebKit successfully loaded the page.

  • editing/execCommand/forward-delete-read-write-canvas-expected.txt: Added.
  • editing/execCommand/forward-delete-read-write-canvas.html: Added.
7:12 PM Changeset in webkit [221127] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org against at r221126.

Rubber-stamped by Yusuke Suzuki.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
  • Speedometer2.0/resources/todomvc/architecture-examples/preact/dist/app.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/preact/dist/todomvc.css:
  • Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/footer.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/index.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/item.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/preact/src/app/util.js:

(export.uuid):

7:11 PM Changeset in webkit [221126] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix Titzer bench on iOS.
https://bugs.webkit.org/show_bug.cgi?id=175917

Reviewed by Ryosuke Niwa.

Currently, Titzer bench doesn't run on iOS since the benchmark
allocates lots of physical pages that it never actually writes
to. We limited the total number wasm physical pages to the ram
size of the phone, which caused us to fail a memory
allocation. This patch changes it so we will allocate up to 3x ram
size, which seems to fix the problem.

  • wasm/WasmMemory.cpp:
6:07 PM Changeset in webkit [221125] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix for test262
https://bugs.webkit.org/show_bug.cgi?id=175915

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

6:05 PM Changeset in webkit [221124] by Yusuke Suzuki
  • 5 edits in trunk/Source

Unreviewed, build fix in GTK port
https://bugs.webkit.org/show_bug.cgi?id=174590

Source/JavaScriptCore:

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCatch):

  • bytecompiler/BytecodeGenerator.h:

Source/WTF:

  • wtf/SingleRootGraph.h:

(WTF::SingleRootGraph::successors const):
(WTF::SingleRootGraph::predecessors const):

5:39 PM Changeset in webkit [221123] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Cache API] Unify WebCore and WebKit error handling
https://bugs.webkit.org/show_bug.cgi?id=175902
<rdar://problem/34045933>

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23

  • Modules/cache/DOMCache.h: Fixing Windows build.
5:31 PM Changeset in webkit [221122] by Ryan Haddad
  • 6 edits in trunk/Source/WebCore

Unreviewed, rolling out r221109.

This change caused assertion failures on iOS and macOS debug
bots.

Reverted changeset:

"Stop using PolicyCallback for new window policies"
https://bugs.webkit.org/show_bug.cgi?id=175907
http://trac.webkit.org/changeset/221109

5:14 PM Changeset in webkit [221121] by commit-queue@webkit.org
  • 13 edits
    2 adds in trunk/PerformanceTests

Speedometer: Update to modern Preact version
https://bugs.webkit.org/show_bug.cgi?id=175763

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-23
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/preact/README.md: Documented build steps.
  • Speedometer/resources/todomvc/architecture-examples/preact/dist/*: Renamed from build to dist so it can be checked in, and updated per build steps.
  • Speedometer/resources/todomvc/architecture-examples/preact/package-lock.json: Locked dependencies to ensure builds are deterministic.
  • Speedometer/resources/todomvc/architecture-examples/preact/package.json: Updated build commands and dependencies.
  • Speedometer/resources/todomvc/architecture-examples/preact/rollup.config.js: Updated configuration.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/footer.js: Updated to modern Preact version.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/index.js: Updated to modern Preact version.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/app/util.js: Updated to modern Preact version.
  • Speedometer/resources/todomvc/architecture-examples/preact/src/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/preact/webpack.config.babel.js: Updated configuration.
5:09 PM Changeset in webkit [221120] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org against at r221119.

Rubber-stamped by Joseph Pecoraro.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
4:58 PM Changeset in webkit [221119] by sbarati@apple.com
  • 82 edits
    6 adds
    2 deletes in trunk

Support compiling catch in the DFG
https://bugs.webkit.org/show_bug.cgi?id=174590

Reviewed by Filip Pizlo.

JSTests:

  • microbenchmarks/delta-blue-try-catch.js: Added.

(exception):
(value):
(OrderedCollection):
(OrderedCollection.prototype.add):
(OrderedCollection.prototype.at):
(OrderedCollection.prototype.size):
(OrderedCollection.prototype.removeFirst):
(OrderedCollection.prototype.remove):
(Strength):
(Strength.stronger):
(Strength.weaker):
(Strength.weakestOf):
(Strength.strongest):
(Strength.prototype.nextWeaker):
(Constraint):
(Constraint.prototype.addConstraint):
(Constraint.prototype.satisfy):
(Constraint.prototype.destroyConstraint):
(Constraint.prototype.isInput):
(UnaryConstraint):
(UnaryConstraint.prototype.addToGraph):
(UnaryConstraint.prototype.chooseMethod):
(UnaryConstraint.prototype.isSatisfied):
(UnaryConstraint.prototype.markInputs):
(UnaryConstraint.prototype.output):
(UnaryConstraint.prototype.recalculate):
(UnaryConstraint.prototype.markUnsatisfied):
(UnaryConstraint.prototype.inputsKnown):
(UnaryConstraint.prototype.removeFromGraph):
(StayConstraint):
(StayConstraint.prototype.execute):
(EditConstraint.prototype.isInput):
(EditConstraint.prototype.execute):
(BinaryConstraint):
(BinaryConstraint.prototype.chooseMethod):
(BinaryConstraint.prototype.addToGraph):
(BinaryConstraint.prototype.isSatisfied):
(BinaryConstraint.prototype.markInputs):
(BinaryConstraint.prototype.input):
(BinaryConstraint.prototype.output):
(BinaryConstraint.prototype.recalculate):
(BinaryConstraint.prototype.markUnsatisfied):
(BinaryConstraint.prototype.inputsKnown):
(BinaryConstraint.prototype.removeFromGraph):
(ScaleConstraint):
(ScaleConstraint.prototype.addToGraph):
(ScaleConstraint.prototype.removeFromGraph):
(ScaleConstraint.prototype.markInputs):
(ScaleConstraint.prototype.execute):
(ScaleConstraint.prototype.recalculate):
(EqualityConstraint):
(EqualityConstraint.prototype.execute):
(Variable):
(Variable.prototype.addConstraint):
(Variable.prototype.removeConstraint):
(Planner):
(Planner.prototype.incrementalAdd):
(Planner.prototype.incrementalRemove):
(Planner.prototype.newMark):
(Planner.prototype.makePlan):
(Planner.prototype.extractPlanFromConstraints):
(Planner.prototype.addPropagate):
(Planner.prototype.removePropagateFrom):
(Planner.prototype.addConstraintsConsumingTo):
(Plan):
(Plan.prototype.addConstraint):
(Plan.prototype.size):
(Plan.prototype.constraintAt):
(Plan.prototype.execute):
(chainTest):
(projectionTest):
(change):
(deltaBlue):

  • microbenchmarks/fake-iterators-that-throw-when-finished.js: Added.

(assert):
(Numbers):
(Numbers.prototype.next):
(return.Transpose):
(return.Transpose.prototype.next):
(transpose):
(verifyEven):
(verifyString):
(foo):
(runIterators):

  • microbenchmarks/try-catch-word-count.js: Added.

(let.assert):
(EOF):
(let.texts):
(let.o.apply):
(foo):
(bar):
(f):
(run):
(test1):
(test2):
(test3):
(fn):
(A):
(B):
(A.prototype.getValue):
(B.prototype.getParentValue):
(strlen):
(sum.0):
(test):
(result.test.o):
(set add.set add):
(set forEach):
(stringHash):
(set if):
(testFunction):
(set delete.set has.set add):

  • stress/catch-set-argument-speculation-failure.js: Added.

(o):
(e):
(e2):
(escape):
(baz):
(noInline.run):
(noInline):

  • stress/osr-enter-to-catch-with-set-local-type-check-failure.js: Added.

(foo):
(e):
(baz):
(bar):

Source/JavaScriptCore:

This patch implements OSR entry into op_catch in the DFG. We will support OSR entry
into the FTL in a followup: https://bugs.webkit.org/show_bug.cgi?id=175396

To implement catch in the DFG, this patch introduces the concept of multiple
entrypoints into CPS/LoadStore DFG IR. A lot of this patch is stringing this concept
through the DFG. Many phases used to assume that Graph::block(0) is the only root, and this
patch contains many straight forward changes generalizing the code to handle more than
one entrypoint.

A main building block of this is moving to two CFG types: SSACFG and CPSCFG. SSACFG
is the same CFG we used to have. CPSCFG is a new type that introduces a fake root
that has an outgoing edge to all the entrypoints. This allows our existing graph algorithms
to Just Work over CPSCFG. For example, there is now the concept of SSADominators vs CPSDominators,
and SSANaturalLoops vs CPSNaturalLoops.

The way we compile the catch entrypoint is by bootstrapping the state
of the program by loading all live bytecode locals from a buffer. The OSR
entry code will store all live values into that buffer before jumping to
the entrypoint. The OSR entry code is also responsible for performing type
proofs of the arguments before doing an OSR entry. If there is a type
mismatch, it's not legal to OSR enter into the DFG compilation. Currently,
each catch entrypoint knows the argument type proofs it must perform to enter
into the DFG. Currently, all entrypoints' arguments flush format are unified
via ArgumentPosition, but this is just an implementation detail. The code is
written more generally to assume that each entrypoint may perform its own distinct
proof.

op_catch now performs value profiling for all live bytecode locals in the
LLInt and baseline JIT. This information is then fed into the DFG via the
ExtractCatchLocal node in the prediction propagation phase.

This patch also changes how we generate op_catch in bytecode. All op_catches
are now split out at the end of the program in bytecode. This ensures that
no op_catch is inside a try block. This is needed to ensure correctness in
the DFGLiveCatchVariablePreservationPhase. That phase only inserts flushes
before SetLocals inside a try block. If an op_catch were in a try block, this
would cause the phase to insert a Flush before one of the state bootstrapping
SetLocals, which would generate invalid IR. Moving op_catch to be generated on
its own at the end of a bytecode stream seemed like the most elegant solution since
it better represents that we treat op_catch as an entrypoint. This is true
both in the DFG and in the baseline and LLInt: we don't reach an op_catch
via normal control flow. Because op_catch cannot throw, this will not break
any previous semantics of op_catch. Logically, it'd be valid to split try
blocks around any non-throwing bytecode operation.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::validate):

  • bytecode/CodeBlock.h:
  • bytecode/ValueProfile.h:

(JSC::ValueProfile::ValueProfile):
(JSC::ValueProfileAndOperandBuffer::ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::~ValueProfileAndOperandBuffer):
(JSC::ValueProfileAndOperandBuffer::forEach):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::emitEnumeration):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::TryNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGBackwardsCFG.h:

(JSC::DFG::BackwardsCFG::BackwardsCFG):

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::findTerminal const):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::DelayedSetLocal):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::execute):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCFG.h:

(JSC::DFG::CFG::root):
(JSC::DFG::CFG::roots):
(JSC::DFG::CPSCFG::CPSCFG):
(JSC::DFG::selectCFG):

  • dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::specialCaseArguments):

  • dfg/DFGCSEPhase.cpp:
  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGControlEquivalenceAnalysis.h:

(JSC::DFG::ControlEquivalenceAnalysis::ControlEquivalenceAnalysis):

  • dfg/DFGDCEPhase.cpp:

(JSC::DFG::DCEPhase::run):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::createDumpList):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGDominators.h:

(JSC::DFG::Dominators::Dominators):
(JSC::DFG::ensureDominatorsForCFG):

  • dfg/DFGEdgeDominates.h:

(JSC::DFG::EdgeDominates::EdgeDominates):
(JSC::DFG::EdgeDominates::operator()):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupChecksInBlock):

  • dfg/DFGFlushFormat.h:
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::unboxLoopNode):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::blocksInPreOrder):
(JSC::DFG::Graph::blocksInPostOrder):
(JSC::DFG::Graph::ensureCPSDominators):
(JSC::DFG::Graph::ensureSSADominators):
(JSC::DFG::Graph::ensureCPSNaturalLoops):
(JSC::DFG::Graph::ensureSSANaturalLoops):
(JSC::DFG::Graph::ensureBackwardsCFG):
(JSC::DFG::Graph::ensureBackwardsDominators):
(JSC::DFG::Graph::ensureControlEquivalenceAnalysis):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::clearCPSCFGData):
(JSC::DFG::Graph::ensureDominators): Deleted.
(JSC::DFG::Graph::ensurePrePostNumbering): Deleted.
(JSC::DFG::Graph::ensureNaturalLoops): Deleted.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::willCatchExceptionInMachineFrame):
(JSC::DFG::Graph::isEntrypoint const):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::mergeToSuccessors):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::shrinkToFit):

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::catchOSREntryDataForBytecodeIndex):
(JSC::DFG::JITCode::finalizeCatchOSREntrypoints):
(JSC::DFG::JITCode::appendCatchEntrypoint):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::noticeCatchEntrypoint):
(JSC::DFG::JITCompiler::noticeOSREntry):
(JSC::DFG::JITCompiler::makeCatchOSREntryBuffer):

  • dfg/DFGJITCompiler.h:
  • dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):

  • dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::run):
(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlockForTryCatch):
(JSC::DFG::LiveCatchVariablePreservationPhase::newVariableAccessData):
(JSC::DFG::LiveCatchVariablePreservationPhase::willCatchException): Deleted.
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlock): Deleted.

  • dfg/DFGLoopPreHeaderCreationPhase.cpp:

(JSC::DFG::createPreHeader):
(JSC::DFG::LoopPreHeaderCreationPhase::run):

  • dfg/DFGMaximalFlushInsertionPhase.cpp:

(JSC::DFG::MaximalFlushInsertionPhase::run):
(JSC::DFG::MaximalFlushInsertionPhase::treatRegularBlock):
(JSC::DFG::MaximalFlushInsertionPhase::treatRootBlock):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNaturalLoops.h:

(JSC::DFG::NaturalLoops::NaturalLoops):

  • dfg/DFGNode.h:

(JSC::DFG::Node::isSwitch const):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::catchOSREntryIndex const):
(JSC::DFG::Node::catchLocalPrediction):
(JSC::DFG::Node::isSwitch): Deleted.

  • dfg/DFGNodeType.h:
  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareCatchOSREntry):

  • dfg/DFGOSREntry.h:
  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::handleExitCounts):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPrePostNumbering.cpp:

(JSC::DFG::PrePostNumbering::PrePostNumbering): Deleted.
(JSC::DFG::PrePostNumbering::~PrePostNumbering): Deleted.
(WTF::printInternal): Deleted.

  • dfg/DFGPrePostNumbering.h:

(): Deleted.
(JSC::DFG::PrePostNumbering::preNumber const): Deleted.
(JSC::DFG::PrePostNumbering::postNumber const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isAncestorOf const): Deleted.
(JSC::DFG::PrePostNumbering::isStrictDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::isDescendantOf const): Deleted.
(JSC::DFG::PrePostNumbering::edgeKind const): Deleted.

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGPutStackSinkingPhase.cpp:
  • dfg/DFGSSACalculator.cpp:

(JSC::DFG::SSACalculator::nonLocalReachingDef):
(JSC::DFG::SSACalculator::reachingDefAtTail):

  • dfg/DFGSSACalculator.h:

(JSC::DFG::SSACalculator::computePhis):

  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):
(JSC::DFG::performSSAConversion):

  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStaticExecutionCountEstimationPhase.cpp:

(JSC::DFG::StaticExecutionCountEstimationPhase::run):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):
(JSC::DFG::TierUpCheckInjectionPhase::buildNaturalLoopToLoopHintMap):

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

  • dfg/DFGValidate.cpp:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::safelyInvalidateAfterTermination):
(JSC::FTL::DFG::LowerDFGToB3::isValid):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::callOperation):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:

Source/WTF:

This patch generalizes the BackwardsGraph fake root into a more generalizable
class called SingleRootGraph. SingleRootGraph exposes the general graph interface
used in Dominators and NaturalLoops. SingleRootGraph takes as input a graph with
the normal graph interface, but also allows the input graph to contain more than
one root. SingleRootGraph then exposes a single root, which it creates, that has
an outgoing edge to all the roots in the original graph.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/BackwardsGraph.h:

(WTF::BackwardsGraph::dump const):
(WTF::BackwardsGraph::rootName): Deleted.
(WTF::BackwardsGraph::Node::Node): Deleted.
(WTF::BackwardsGraph::Node::root): Deleted.
(WTF::BackwardsGraph::Node::operator== const): Deleted.
(WTF::BackwardsGraph::Node::operator!= const): Deleted.
(WTF::BackwardsGraph::Node::operator bool const): Deleted.
(WTF::BackwardsGraph::Node::isRoot const): Deleted.
(WTF::BackwardsGraph::Node::node const): Deleted.
(): Deleted.
(WTF::BackwardsGraph::Set::Set): Deleted.
(WTF::BackwardsGraph::Set::add): Deleted.
(WTF::BackwardsGraph::Set::remove): Deleted.
(WTF::BackwardsGraph::Set::contains): Deleted.
(WTF::BackwardsGraph::Set::dump const): Deleted.
(WTF::BackwardsGraph::Map::Map): Deleted.
(WTF::BackwardsGraph::Map::clear): Deleted.
(WTF::BackwardsGraph::Map::size const): Deleted.
(WTF::BackwardsGraph::Map::operator[]): Deleted.
(WTF::BackwardsGraph::Map::operator[] const): Deleted.

  • wtf/Dominators.h:

(WTF::Dominators::Dominators):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOf):
(WTF::Dominators::forAllBlocksInPrunedIteratedDominanceFrontierOf):
(WTF::Dominators::iteratedDominanceFrontierOf const):
(WTF::Dominators::forAllBlocksInIteratedDominanceFrontierOfImpl const):

  • wtf/SingleRootGraph.h: Added.

(WTF::SingleRootGraphNode::rootName):
(WTF::SingleRootGraphNode::SingleRootGraphNode):
(WTF::SingleRootGraphNode::root):
(WTF::SingleRootGraphNode::operator== const):
(WTF::SingleRootGraphNode::operator!= const):
(WTF::SingleRootGraphNode::operator bool const):
(WTF::SingleRootGraphNode::isRoot const):
(WTF::SingleRootGraphNode::node const):
(WTF::SingleRootGraphSet::add):
(WTF::SingleRootGraphSet::remove):
(WTF::SingleRootGraphSet::contains):
(WTF::SingleRootGraphSet::dump const):
(WTF::SingleRootMap::SingleRootMap):
(WTF::SingleRootMap::clear):
(WTF::SingleRootMap::size const):
(WTF::SingleRootMap::operator[]):
(WTF::SingleRootMap::operator[] const):
(WTF::SingleRootGraph::SingleRootGraph):
(WTF::SingleRootGraph::root const):
(WTF::SingleRootGraph::newMap):
(WTF::SingleRootGraph::successors const):
(WTF::SingleRootGraph::predecessors const):
(WTF::SingleRootGraph::index const):
(WTF::SingleRootGraph::node const):
(WTF::SingleRootGraph::numNodes const):
(WTF::SingleRootGraph::dump const):
(WTF::SingleRootGraph::assertIsConsistent const):

4:54 PM Changeset in webkit [221118] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908

Address Joe's review comments.

  • Speedometer/resources/main.js:

(startBenchmark):

4:53 PM Changeset in webkit [221117] by Jonathan Bedard
  • 2 edits in trunk/Tools

Leaking CARenderServerBuffer in PlatformWebView::windowSnapshotImage()
https://bugs.webkit.org/show_bug.cgi?id=175905

Reviewed by Tim Horton.

  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage): Pass CARenderServerBuffer to CGDataProviderCreateWithData
so that the buffer can be destroyed.

4:23 PM Changeset in webkit [221116] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[EME] WebCoreDecompressionSession should only report having an available frame if it has one for the current time.
https://bugs.webkit.org/show_bug.cgi?id=175901

Reviewed by Eric Carlson.

The WebCoreDecompressionSession will trigger the hasAvailableFrame callback whenever a frame is decoded,
regardless of its presentation time. For formats which have out-of-order decoding, the newly decoded frame could
have a presentation time far in the future. Instead, only fire the callback if the decoded frame's presentation
times contains the timebase's current time.

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::enqueueDecodedSample):

4:06 PM Changeset in webkit [221115] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked loader/stateobjects/replacestate-size.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172829

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:04 PM Changeset in webkit [221114] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Add the capability to run a specific suite
https://bugs.webkit.org/show_bug.cgi?id=175908

Reviewed by Saam Barati.

Added ?suite=X query parameter to specify a specific suite (e.g. React-TodoMVC) to run.

  • Speedometer/resources/main.js:

(enableOneSuite): Added.
(startBenchmark): Return true if the benchmark actually had started running.
(startTest): Don't transition to the "running" state if the benchmark failed to start (e.g. no tests to run).

3:53 PM Changeset in webkit [221113] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, debug build fix
https://bugs.webkit.org/show_bug.cgi?id=174355

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):

3:33 PM Changeset in webkit [221112] by commit-queue@webkit.org
  • 23 edits
    1 move
    1 add in trunk/Source

[Cache API] Unify WebCore and WebKit error handling
https://bugs.webkit.org/show_bug.cgi?id=175902

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.

Introducing a DOMCache namespace enclosing structures, callbacks and function definitions
previously found in either WebCore::CacheStorageConnection or WebKit::CacheStorage.

Some previously used callbacks had no way to pass errors in WebCore while they had in WebKit.
Updated Cache, CacheStorage, CacheStorageConnection and WorkerCacheStorageConnection to deal with these potential errors.

  • CMakeLists.txt:
  • Modules/cache/Cache.cpp:

(WebCore::FetchTasksHandler::FetchTasksHandler):
(WebCore::FetchTasksHandler::records const):
(WebCore::FetchTasksHandler::addRecord):
(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::Cache::retrieveRecords):
(WebCore::queryCacheMatch):
(WebCore::Cache::batchDeleteOperation):
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):
(WebCore::Cache::updateRecords):

  • Modules/cache/Cache.h:
  • Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::retrieveCaches):
(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):

  • Modules/cache/CacheStorage.h:
  • Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::retrieveCaches):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):
(WebCore::CacheStorageConnection::openOrRemoveCompleted):
(WebCore::CacheStorageConnection::updateCaches):
(WebCore::CacheStorageConnection::updateRecords):
(WebCore::CacheStorageConnection::deleteRecordsCompleted):
(WebCore::CacheStorageConnection::putRecordsCompleted):

  • Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):

  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::recordsDataFromRecords):
(WebCore::recordsDataOrErrorFromRecords):
(WebCore::recordsFromRecordsData):
(WebCore::recordsOrErrorFromRecordsData):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):

  • Modules/cache/DOMCache.cpp: Added.
  • Modules/cache/DOMCache.h: Added.
  • Modules/cache/WorkerCacheStorageConnection.h:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

Removing all callbacks and error definitions from WebKit
and reusing DOMCache ones instead.

  • NetworkProcess/cache/CacheStorage.h: Removed.
  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::caches const):
(WebKit::CacheStorage::Engine::queryCache):

  • NetworkProcess/cache/CacheStorageEngine.h:
  • NetworkProcess/cache/CacheStorageEngineCache.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::putRecords):

  • NetworkProcess/cache/CacheStorageEngineConnection.h:
  • NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DOMCache::CacheInfo>::encode):
(IPC::ArgumentCoder<DOMCache::CacheInfo>::decode):
(IPC::ArgumentCoder<DOMCache::Record>::encode):
(IPC::ArgumentCoder<DOMCache::Record>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::doBatchPutOperation):
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):

  • WebProcess/Cache/WebCacheStorageConnection.h:
  • WebProcess/Cache/WebCacheStorageConnection.messages.in:
3:24 PM Changeset in webkit [221111] by msaboff@apple.com
  • 5 edits in trunk

REGRESSION (r221052): DumpRenderTree crashed in com.apple.JavaScriptCore: JSC::Yarr::YarrCodeBlock::execute + 137
https://bugs.webkit.org/show_bug.cgi?id=175903

Reviewed by Saam Barati.

Source/JavaScriptCore:

In generateCharacterClassGreedy we were incrementing the "count" register before checking
for the end of the input string. The at-end-of-input check is the final check before
knowing that the current character matched. In this case, the end of input check
indicates that we ran out of prechecked characters and therefore should fail the match of
the current character. The backtracking code uses the value in the "count" register as
the number of character that successfully matched, which shouldn't include the current
character. Therefore we need to move the incrementing of "count" to after the
at end of input check.

Through code inspection of the expectations of other backtracking code, I determined that
the non greedy character class matching code had a similar issue. I fixed that as well
and added a new test case.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):

LayoutTests:

New regression test case.

  • js/regexp-unicode-expected.txt:
  • js/script-tests/regexp-unicode.js:
3:19 PM Changeset in webkit [221110] by Yusuke Suzuki
  • 56 edits
    2 copies
    2 adds in trunk

[JSC] Optimize Map iteration with intrinsic
https://bugs.webkit.org/show_bug.cgi?id=174355

Reviewed by Saam Barati.

JSTests:

  • stress/map-iterator-result-should-have-expected-shape.js: Added.

(shouldBe):
(throw.new.Error):

  • stress/set-iterator-result-should-have-expected-shape.js: Added.

(shouldBe):
(throw.new.Error.let.iterator.set Symbol):
(throw.new.Error.set add):
(let.iterator.set Symbol):

Source/JavaScriptCore:

This patch optimizes Map/Set iteration by taking the approach similar to Array iteration.
We create a simple iterator object instead of JSMapIterator and JSSetIterator. And we
directly handles Map/Set buckets in JS builtins. We carefully create mapIteratorNext and
setIteratorNext functions which should be inlined. This leads significant performance boost
when they are inlined in for-of iteration.

This patch changes how DFG and FTL handles MapBucket if the bucket is not found.
Previously, we use nullptr for that, and DFG and FTL specially handle this nullptr as bucket.
Instead, this patch introduces sentinel buckets. They are marked as deleted, and not linked
to any hash maps. And its key and value fields are filled with Undefined. By returning this
sentinel bucket instead of returning nullptr, we simplify DFG and FTL's LoadXXXFromMapBucket
code.

We still keep JSMapIterator and JSSetIterator because they are useful to serialize Map and Set
in WebCore. So they are not used in user observable JS. We change them from JS objects to JS cells.

Existing microbenchmarks shows performance improvements.

large-map-iteration 164.1622+-4.1618 56.6284+-1.5355 definitely 2.8989x faster
set-for-of 15.4369+-1.0631 9.2955+-0.5979 definitely 1.6607x faster
map-for-each 7.5889+-0.5792 6.3011+-0.4816 definitely 1.2044x faster
map-for-of 32.3904+-1.3003 12.6907+-0.6118 definitely 2.5523x faster
map-rehash 13.9275+-0.9187 11.5367+-0.6430 definitely 1.2072x faster

  • CMakeLists.txt:
  • DerivedSources.make:
  • builtins/ArrayPrototype.js:

(globalPrivate.createArrayIterator):

  • builtins/BuiltinNames.h:
  • builtins/MapIteratorPrototype.js: Copied from Source/JavaScriptCore/builtins/MapPrototype.js.

(globalPrivate.mapIteratorNext):
(next):

  • builtins/MapPrototype.js:

(globalPrivate.createMapIterator):
(values):
(keys):
(entries):
(forEach):

  • builtins/SetIteratorPrototype.js: Copied from Source/JavaScriptCore/builtins/MapPrototype.js.

(globalPrivate.setIteratorNext):
(next):

  • builtins/SetPrototype.js:

(globalPrivate.createSetIterator):
(values):
(entries):
(forEach):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/SpeculatedType.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

  • dfg/DFGHeapLocation.h:
  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasBucketOwnerType):
(JSC::DFG::Node::bucketOwnerType):
(JSC::DFG::Node::OpInfoWrapper::as const):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetMapBucketHead):
(JSC::DFG::SpeculativeJIT::compileGetMapBucketNext):
(JSC::DFG::SpeculativeJIT::compileLoadKeyFromMapBucket):
(JSC::DFG::SpeculativeJIT::compileLoadValueFromMapBucket):
(JSC::DFG::SpeculativeJIT::compileCompareEqPtr): Deleted.

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compileCompareEqPtr):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compileCompareEqPtr):
(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketHead):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucketNext):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadValueFromMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadKeyFromMapBucket):
(JSC::FTL::DFG::LowerDFGToB3::setStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadFromJSMapBucket): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::compileIsNonEmptyMapBucket): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::lowMapBucket): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::setMapBucket): Deleted.

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::cloneMapIteratorObject):
(Inspector::cloneSetIteratorObject):
(Inspector::JSInjectedScriptHost::iteratorEntries):

  • runtime/HashMapImpl.h:

(JSC::HashMapBucket::createSentinel):
(JSC::HashMapBucket::offsetOfNext):
(JSC::HashMapBucket::offsetOfDeleted):
(JSC::HashMapImpl::offsetOfHead):

  • runtime/Intrinsic.cpp:

(JSC::intrinsicName):

  • runtime/Intrinsic.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObject.h:
  • runtime/JSMap.h:
  • runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::clone): Deleted.

  • runtime/JSMapIterator.h:

(JSC::JSMapIterator::iteratedValue const):

  • runtime/JSSet.h:
  • runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::clone): Deleted.

  • runtime/JSSetIterator.h:

(JSC::JSSetIterator::iteratedValue const):

  • runtime/MapConstructor.cpp:

(JSC::mapPrivateFuncMapBucketHead):
(JSC::mapPrivateFuncMapBucketNext):
(JSC::mapPrivateFuncMapBucketKey):
(JSC::mapPrivateFuncMapBucketValue):

  • runtime/MapConstructor.h:
  • runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncNext): Deleted.

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues): Deleted.
(JSC::mapProtoFuncEntries): Deleted.
(JSC::mapProtoFuncKeys): Deleted.
(JSC::privateFuncMapIterator): Deleted.
(JSC::privateFuncMapIteratorNext): Deleted.

  • runtime/MapPrototype.h:
  • runtime/SetConstructor.cpp:

(JSC::setPrivateFuncSetBucketHead):
(JSC::setPrivateFuncSetBucketNext):
(JSC::setPrivateFuncSetBucketKey):

  • runtime/SetConstructor.h:
  • runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototype::finishCreation):
(JSC::SetIteratorPrototypeFuncNext): Deleted.

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncSize):
(JSC::setProtoFuncValues): Deleted.
(JSC::setProtoFuncEntries): Deleted.
(JSC::privateFuncSetIterator): Deleted.
(JSC::privateFuncSetIteratorNext): Deleted.

  • runtime/SetPrototype.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WebCore:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

3:11 PM Changeset in webkit [221109] by achristensen@apple.com
  • 6 edits in trunk/Source/WebCore

Stop using PolicyCallback for new window policies
https://bugs.webkit.org/show_bug.cgi?id=175907

Reviewed by Andy Estes.

PolicyCallback is an artifact from the days before C++11. Let's use lambdas instead!
No change in behaviour.

  • loader/PolicyCallback.cpp:

(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):

  • loader/PolicyCallback.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::continueAfterNewWindowPolicy): Deleted.

  • loader/PolicyChecker.h:
3:03 PM Changeset in webkit [221108] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

2:42 PM Changeset in webkit [221107] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.5

Tag Safari-604.2.5.

2:40 PM Changeset in webkit [221106] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Async time is not always capturing layout time
https://bugs.webkit.org/show_bug.cgi?id=175871

Reviewed by Simon Fraser.

Speedometer harness was designed to capture the time browser engine spends relayouting and repainting the content
after DOM mutations this in its async time measurement, which is the time between each test case's code had finished
running and when a newly scheduled 0s timer is fired immediately afterwards.

It turns out that modern web browsers defer this reflow and repaint work until the next animation frame is requested.
This results in Speedometer harness measuring reflow and repaint cost only sometimes depending on when each test case
had finished running relative to the next frame request.

While such a behavior makes sense and might be desirable for a modern browser engine, we would like to capture it in
the async time for the purpose of Speedometer. Unfortunately, there isn't an interoperable API for browsers to report
the total layout and repaint time, and relying on 16ms-granularity requestAnimationFrame is too coarse for Speedometer.

This patch works around these limitations by manually forcing the layout in async time measurement by calling
getBoundingClientRect() in iframe's document. Since the height of the document depends on the number of todo items,
this should cause browser engines to do most if not all of the work needed to reflow the document at least for now.

Note that even new async time doesn't always capture painting time but there isn't a good cross-browser mechanism
to measure paint time in the granurality we need for Speedometer at the moment anyway. (Should such a mechanism exist,
that could be a huge timing attack surface so it's probably best that we don't have one.)

  • Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

2:39 PM Changeset in webkit [221105] by rniwa@webkit.org
  • 4 edits
    2 adds
    3 deletes in trunk/PerformanceTests

Speedometer: Make React/Redux item order consistent
https://bugs.webkit.org/show_bug.cgi?id=175818

Reviewed by Joseph Pecoraro.

Based on the patch made by Mathias Bynens. Re-generated project files.

Also tweaked the instruction in package.json so that newly generated files in build/* replace dist/* instead of
being moved under dist/build/ by rm -rf'ing dist directory first.

  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/index.html:
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.43a0948c.js.map: Removed.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.69cd9655.js.map: Added.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/package.json:
  • Speedometer/resources/todomvc/architecture-examples/react-redux/src/reducers/todos.js: Forced new items to be appended rather than prepended.
  • Speedometer/resources/todomvc/architecture-examples/react-redux/yarn.lock: Removed unnecessary file.
2:37 PM Changeset in webkit [221104] by commit-queue@webkit.org
  • 4 edits
    1 move
    3 adds
    8 deletes in trunk

Speedometer: Update to modern React version
https://bugs.webkit.org/show_bug.cgi?id=175715

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-23
Reviewed by Ryosuke Niwa.

This patch pins React and react-dom to v15.5.4 (released in May 2017).

  • Speedometer/resources/todomvc/architecture-examples/react/README.md: Documented build steps.
  • Speedometer/resources/todomvc/architecture-examples/react/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/react/node_modules/*: Remove unneeded files and update per build instructions.
  • Speedometer/resources/todomvc/architecture-examples/react/npm-shrinkwrap.json: Removed in favor of package-lock.json.
  • Speedometer/resources/todomvc/architecture-examples/react/package-lock.json: Pinned dependencies to make build deterministic.
  • Speedometer/resources/todomvc/architecture-examples/react/package.json: Update dependencies.
  • Speedometer/resources/todomvc/architecture-examples/react/yarn.lock: Removed in favor of package-lock.json.
2:10 PM Changeset in webkit [221103] by achristensen@apple.com
  • 8 edits in trunk/Source/WebCore

Stop using PolicyChecker for ContentPolicy
https://bugs.webkit.org/show_bug.cgi?id=175904

Reviewed by Tim Horton.

PolicyChecker is an artifact from the days before C++11. Now we have lambdas which
have a cleaner flow than one class that exists to be effectively one of three lambda types.
Let's remove them one at a time, starting with ContentPolicy checks.

No change in behaviour.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkContentPolicy):

  • loader/FrameLoader.h:
  • loader/PolicyCallback.cpp:

(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):

  • loader/PolicyCallback.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkContentPolicy): Deleted.
(WebCore::PolicyChecker::continueAfterContentPolicy): Deleted.

  • loader/PolicyChecker.h:
2:08 PM Changeset in webkit [221102] by achristensen@apple.com
  • 5 edits in trunk/Source/WebKit

Clean up UIClients
https://bugs.webkit.org/show_bug.cgi?id=175906

Reviewed by Tim Horton.

There were some unnecessary checks to see if the client implements something,
when the default behavior is to do nothing if the client doesn't implement the callback.
Also, make some overrides finals and fix some spacing.

  • UIProcess/API/APIUIClient.h:

(API::UIClient::didNotHandleKeyEvent):
(API::UIClient::implementsDidNotHandleKeyEvent const): Deleted.
(API::UIClient::implementsDidNotHandleWheelEvent const): Deleted.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReceiveEvent):

2:04 PM Changeset in webkit [221101] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked webrtc/filtering-ice-candidate-after-reload.html a flaky.
https://bugs.webkit.org/show_bug.cgi?id=174471

Unreviewed test gardening.

  • platform/wk2/TestExpectations:
1:41 PM Changeset in webkit [221100] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Build fix for 32-bit Mac after r221098. Make sure constant used in WebCoreDecompressionSession is SoftLinked.

  • platform/cf/CoreMediaSoftLink.cpp:
  • platform/cf/CoreMediaSoftLink.h:
1:35 PM Changeset in webkit [221099] by achristensen@apple.com
  • 6 edits in trunk

Add WKUIDelegatePrivate callbacks corresponding to WKPageUIClient's takeFocus, focus, and unfocus
https://bugs.webkit.org/show_bug.cgi?id=175896

Reviewed by Tim Horton.
Source/WebKit:


I also renamed _webViewShow to _showWebView based on feedback from https://bugs.webkit.org/show_bug.cgi?id=175797

Added an API test.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::toWKFocusDirection):
(WebKit::UIDelegate::UIClient::takeFocus):
(WebKit::UIDelegate::UIClient::focus):
(WebKit::UIDelegate::UIClient::unfocus):
(WebKit::UIDelegate::UIClient::showPage):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm:

(-[UITestDelegate _showWebView:]):
(TEST):
(tabEvent):
(synthesizeTab):
(-[FocusDelegate _webView:takeFocus:]):
(-[FocusDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[UITestDelegate _webViewShow:]): Deleted.

1:16 PM Changeset in webkit [221098] by jer.noble@apple.com
  • 8 edits
    3 adds in trunk

Track VideoPlaybackQuality metrics when using WebCoreDecompressionSession.
https://bugs.webkit.org/show_bug.cgi?id=175835
<rdar://problem/34022234>

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/media-source/videoplaybackquality-decompressionsession.html

Track the total number of frames decoded, dropped, & corrupted, as well as the total
delay imposed by decoding in the WebCoreDecompressionSession.

Drive-by fix: implement frame dropping by skipping frames whose presentation times are
before the video's current time and which aren't depended upon by other frames.

  • platform/cf/CoreMediaSoftLink.cpp:
  • platform/cf/CoreMediaSoftLink.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::videoPlaybackQualityMetrics):

  • platform/graphics/cocoa/WebCoreDecompressionSession.h:

(WebCore::WebCoreDecompressionSession::totalVideoFrames):
(WebCore::WebCoreDecompressionSession::droppedVideoFrames):
(WebCore::WebCoreDecompressionSession::corruptedVideoFrames):
(WebCore::WebCoreDecompressionSession::totalFrameDelay):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::shouldDecodeSample):
(WebCore::WebCoreDecompressionSession::decodeSample):
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

LayoutTests:

  • platform/mac/media/media-source/videoplaybackquality-decompressionsession-expected.txt: Added.
  • platform/mac/media/media-source/videoplaybackquality-decompressionsession.html: Added.
1:14 PM Changeset in webkit [221097] by ddkilzer@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix -Wcast-qual warnings in JavaScriptCore with new clang compiler
<https://webkit.org/b/175889>
<rdar://problem/33667497>

Reviewed by Mark Lam.

  • API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsConstructor): Use
const_cast<JSObjectRef>() since JSValueRef is const while
JSObjectRef is not.

  • API/tests/CurrentThisInsideBlockGetterTest.mm:

(+[JSValue valueWithConstructorDescriptor:inContext:]): Use
const_cast<void*>() since JSObjectMake() takes a void*, but
CFBridgingRetain() returns const void*.

1:05 PM Changeset in webkit [221096] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Removed flaky timeout expectation for inspector/codemirror/prettyprinting-css.html.

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:01 PM Changeset in webkit [221095] by eric.carlson@apple.com
  • 4 edits
    1 add in trunk

Platform code should be able to safely log in release builds
https://bugs.webkit.org/show_bug.cgi?id=175854
<rdar://problem/34022930>

Reviewed by Jer Noble.

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/Logger.h: Added.

(PAL::Logger::create):
(PAL::Logger::error const):
(PAL::Logger::warning const):
(PAL::Logger::notice const):
(PAL::Logger::info const):
(PAL::Logger::debug const):
(PAL::Logger::willLog const):
(PAL::Logger::enabled const):
(PAL::Logger::setEnabled):
(PAL::Logger::Logger):
(PAL::Logger::log):

Tools:

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F):

12:50 PM Changeset in webkit [221094] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[Payment Request] Update to "In Development" in features.json
https://bugs.webkit.org/show_bug.cgi?id=175897

Reviewed by Sam Weinig.

  • features.json:
12:45 PM Changeset in webkit [221093] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source/WebKit

[CacheAPI] Introduce a WebKit::CacheStorage namespace
https://bugs.webkit.org/show_bug.cgi?id=175885

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Introducing WebKit::CacheStorage namespace.
Splitting CacheStorageEngine.h in three files.
Updating client code accordingly.

  • NetworkProcess/cache/CacheStorage.h: Added.
  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::globalEngineMap):
(WebKit::CacheStorage::Engine::from):
(WebKit::CacheStorage::Engine::destroyEngine):
(WebKit::CacheStorage::Engine::defaultEngine):
(WebKit::CacheStorage::Engine::open):
(WebKit::CacheStorage::Engine::remove):
(WebKit::CacheStorage::Engine::retrieveCaches):
(WebKit::CacheStorage::Engine::retrieveRecords):
(WebKit::CacheStorage::Engine::putRecords):
(WebKit::CacheStorage::Engine::deleteMatchingRecords):
(WebKit::CacheStorage::Engine::writeCachesToDisk):
(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::readCache):
(WebKit::CacheStorage::Engine::writeCacheRecords):
(WebKit::CacheStorage::Engine::removeCacheRecords):
(WebKit::CacheStorage::Engine::cache):
(WebKit::CacheStorage::Engine::caches const):
(WebKit::CacheStorage::Engine::queryCache):

  • NetworkProcess/cache/CacheStorageEngineCache.h: Added.
  • NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::records):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):

  • WebProcess/Cache/WebCacheStorageConnection.h:
12:22 PM Changeset in webkit [221092] by dino@apple.com
  • 8 edits
    4 adds in trunk

Default passive touch event listeners on the root
https://bugs.webkit.org/show_bug.cgi?id=175346
<rdar://problem/33164597>

Reviewed by Sam Weinig.

Source/WebCore:

Make any touchstart or touchmove event listeners passive by default
if they are on the document, window, body or document element targets.
This follows the "intervention" first implemented by Chrome/Blink:

https://github.com/WICG/interventions/issues/35
https://docs.google.com/document/d/1II7oSIpd8pK91V5kEM3tDLKcIj398jOJn8Niqy6_loI/edit
https://github.com/whatwg/dom/issues/365

If the event listener explicitly defines "passive" to false in their
options dictionary, then they'll still get a non-passive listener.

NOTE: Any fallout from this bug should be collected in:
https://bugs.webkit.org/show_bug.cgi?id=175869
Please do not revert this change just because a site is broken. We'll
gather the issues and see if we can evangelise or detect via code.

Tests: fast/events/touch/ios/passive-by-default-on-document-and-window.html

fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html

  • dom/EventNames.h:

(WebCore::EventNames::isTouchScrollBlockingEventType const): Added this helper
to identify the types of touches we want to check for.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener): Check for the event being one of the touch-types
that we care about, and the target being one of the Node/Window types we care about. If
so, tell the event listener to be passive.

  • dom/EventTarget.h: Use an optional for the passive member.

(WebCore::EventTarget::AddEventListenerOptions::AddEventListenerOptions):

  • dom/EventTarget.idl: Change "passive" to not have a default value, so we

can detect if it was explicitly set to false.

LayoutTests:

  • fast/events/touch/ios/passive-by-default-on-document-and-window-expected.txt: Added.
  • fast/events/touch/ios/passive-by-default-on-document-and-window.html: Added.
  • fast/events/touch/ios/passive-by-default-overridden-on-document-and-window-expected.txt: Added.
  • fast/events/touch/ios/passive-by-default-overridden-on-document-and-window.html: Added.
  • fast/events/touch/ios/tap-with-active-listener-on-window.html: Explicitly set passive to false.
  • fast/events/touch/ios/touch-event-regions/document.html: Ditto.
12:10 PM Changeset in webkit [221091] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 38

Added a tag for Safari Technology Preview release 38.

11:47 AM Changeset in webkit [221090] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Make lock icon crispier
https://bugs.webkit.org/show_bug.cgi?id=175868

Reviewed by Matt Baker.

  • UserInterface/Images/Locked.svg:
11:35 AM Changeset in webkit [221089] by Jonathan Bedard
  • 2 edits in trunk/Tools

Access expectations path through apple_additions
https://bugs.webkit.org/show_bug.cgi?id=174800
<rdar://problem/33498899>

Unreviewed follow-up fix for r221087.

  • Scripts/webkitpy/port/ios.py:

(IOSPort._apple_additions_path): Use iOS mapping instead of Mac mapping.

11:14 AM Changeset in webkit [221088] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the WinCairo build after r221068

  • platform/win/PlatformScreenWin.cpp:
11:09 AM Changeset in webkit [221087] by Jonathan Bedard
  • 7 edits in trunk/Tools

Access expectations path through apple_additions
https://bugs.webkit.org/show_bug.cgi?id=174800
<rdar://problem/33498899>

Reviewed by David Kilzer.

Follow-up fix. Mapping of operating system names was done incorrectly.

  • Scripts/webkitpy/port/ios.py:

(IOSPort._apple_additions_path): Correctly find the operating system to be replaced.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
system name replacement.

  • Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Add test for operating
system name replacement.

  • Scripts/webkitpy/port/mac.py: Correctly find the operating system to be replaced.

(MacPort._apple_additions_path):

  • Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_layout_test_searchpath_with_apple_additions): Add test for operating system
name replacement.

  • Scripts/webkitpy/port/port_testcase.py:

(bind_mock_apple_additions.MockAppleAdditions.ios_os_name): Change the passed name so that
operating system name replacement can be tested.
(bind_mock_apple_additions.MockAppleAdditions.mac_os_name): Ditto.

10:54 AM Changeset in webkit [221086] by commit-queue@webkit.org
  • 9 edits in trunk/Source

[Cache API] Enable persistent coder to encode FetchOptions
https://bugs.webkit.org/show_bug.cgi?id=175883

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Source/WebCore:

No change of behavior.
Adding encode/decode routines for FetchOptions.

  • loader/FetchOptions.h:

(WebCore::FetchOptions::encode const):
(WebCore::FetchOptions::decode):

  • platform/ReferrerPolicy.h:

Source/WebKit:

Removing FetchOptions related ArgumentCoders specific code.

  • Shared/WebCoreArgumentCoders.cpp:
  • Shared/WebCoreArgumentCoders.h:

Source/WTF:

Enabling encoding/decoding of enums with EnumTraits.
This code is similar to the one of IPC encoder/decoder.

  • wtf/persistence/PersistentDecoder.h:

(WTF::Persistence::Decoder::decode):

  • wtf/persistence/PersistentEncoder.h:

(WTF::Persistence::Encoder::encode):

10:52 AM Changeset in webkit [221085] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

CacheStorageEngine readCachesFromDisk callback should return the read Caches
https://bugs.webkit.org/show_bug.cgi?id=175882

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-23
Reviewed by Alex Christensen.

Callback of readCachesFromDisk takes now a Caches or error parameter.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorageEngine::open):
(WebKit::CacheStorageEngine::retrieveCaches):
(WebKit::CacheStorageEngine::readCachesFromDisk):

  • NetworkProcess/cache/CacheStorageEngine.h:
10:41 AM Changeset in webkit [221084] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

JSTests:
Add a micro-benchmark for checking that accessing a variable within a 'with'
block does not automatically prevent type prediction.
https://bugs.webkit.org/show_bug.cgi?id=175738

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-23
Reviewed by Saam Barati.

  • stress/with_and_arith.js: Added.

(with):

Source/JavaScriptCore:
Make GetDynamicVar propagate heap predictions instead of saying HeapTop
https://bugs.webkit.org/show_bug.cgi?id=175738

Patch by Robin Morisset <rmorisset@apple.com> on 2017-08-23
Reviewed by Saam Barati.

The heap prediction always end up in m_opInfo2. But GetDynamicVar was already storing getPutInfo in there.
So we move that one into m_opInfo. We can do this because it is 32-bit, and the already present identifierNumber
is also 32-bit, so we can pack both in m_opInfo (which is 64 bits).

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::makeDynamicVarOpInfo):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::getPutInfo):
(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGPredictionPropagationPhase.cpp:
10:41 AM Changeset in webkit [221083] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebCore

Race condition in StartWebThread causing crash
https://bugs.webkit.org/show_bug.cgi?id=175852

Reviewed by Mark Lam.

When starting web thread, the main thread waits for completion of web thread initialization
by using pthread_cond_t. However, the main thread may be woken up due to the existence of
the spurious wake up of pthread_cond_t.

Instead, we should use WTF::Lock and WTF::Condition. Since our StartWebThread already calls
WTF::initializeThreading, it is safe to use WTF::Lock and WTF::Condition. And our WTF::Condition
does not have the spurious wake up problem as described in Condition.h.

  • platform/ios/wak/WebCoreThread.mm:

(RunWebThread):
(StartWebThread):

10:16 AM Changeset in webkit [221082] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/webappapis/timers/type-long-settimeout.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173780

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:14 AM Changeset in webkit [221081] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Regression(r221059): NetworkDataTask::didReceiveResponse() should not use PolicyUse for HTTP/0.9
https://bugs.webkit.org/show_bug.cgi?id=175872

Reviewed by Daniel Bates.

r221059 was calling the ResponseCompletionHandler with {} which ended up being
PolicyUse. Since this is an error case and do not want to receive the data, it
makes more sense to use PolicyIgnore instead. There should not be a behavior
change on WebKit side though since we are cancelling the load right after
calling the completion handler anyway.

Tests under http/tests/security/http-0.9/ are still passing.

  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::didReceiveResponse):

10:05 AM Changeset in webkit [221080] by gskachkov@gmail.com
  • 57 edits
    21 adds in trunk

[ESNext] Async iteration - Implement Async Generator - runtime
https://bugs.webkit.org/show_bug.cgi?id=175240

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/async-iteration-async-from-sync.js: Added.

(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(foo):
(async.boo):
(bar):
(async.baz):
(async.goo):

  • stress/async-iteration-basic.js: Added.

(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(async.generator):
(iterator.next.then):
(async.baz):
(async.boo):
(async.foo):
(async.goo):
(A.prototype.async.foo):
(A.prototype.async.boo):
(A):
(asyncGenExp.async):
(async.joo):
(j.next.then):
(then):
(async.koo):
(async.loo):
(async.moo):
(async.noo):
(async.ooo):
(async.roo):
(async.poo):
(async.soo):
(async.too):

  • stress/async-iteration-evaluation.js: Added.

(assert):
(async.foo):
(catch):

  • stress/async-iteration-syntax.js:
  • stress/async-iteration-yield-promise.js: Added.

(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(async.foo):
(async.boo):
(async.bar):

  • stress/async-iteration-yield-star-interface.js: Added.

(assert):
(const.getPromise.promiseHolder.return.new.Promise):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.custom):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(let.asyncIter.Symbol.asyncIterator):
(let.asyncIter.next):
(let.asyncIter.throw):
(let.asyncIter.return):
(async.foo):
(asyncIter.Symbol.asyncIterator):
(asyncIter.next):
(async.boo):
(asyncIter.return):
(async.bar):
(async.baz):
(async.foobar):

  • stress/async-iteration-yield-star.js: Added.

(assert):
(const.Logger):
(this.fullfilled):
(this.fullfilledDone):
(this.rejected):
(this.catched):
(this.custom):
(this.isFinal):
(_assertLogger):
(const.assertLogger):
(const.getPromise.promiseHolder.return.new.Promise):
(async.foo):
(async.boo):
(async.bar):
(async.baz):
(async.joo):
(async.goo):
(async.koo):
(async.loo):
(let.asyncIter.Symbol.asyncIterator):
(let.asyncIter.next):
(let.asyncIter.throw):
(let.asyncIter.return):
(async.moo):
(async.noo):

  • test262.yaml:

Source/JavaScriptCore:

Current implementation is draft version of Async Iteration.
Link to spec https://tc39.github.io/proposal-async-iteration/

To implement async generator added new states that show reason why async generator was suspended:

The main difference between async function and async generator is that,
async function returns promise but async generator returns
object with methods (next, throw and return) that return promise that
can be resolved with pair of properties value and done.
Async generator functions are similar to generator functions, with the following differences:
whose methods (next, throw, and return) return promises for { value, done },
instead of directly returning { value, done }.
This automatically makes the returned async generator objects async iterators.

delegation to sync and async iterables

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/AsyncFromSyncIteratorPrototype.js: Added.

(next.try):
(next):
(return.try):
(return):
(throw.try):
(throw):
(globalPrivate.createAsyncFromSyncIterator):
(globalPrivate.AsyncFromSyncIteratorConstructor):

  • builtins/AsyncGeneratorPrototype.js: Added.

(globalPrivate.createAsyncGeneratorQueue):
(globalPrivate.asyncGeneratorQueueIsEmpty):
(globalPrivate.asyncGeneratorQueueCreateItem):
(globalPrivate.asyncGeneratorQueueEnqueue):
(globalPrivate.asyncGeneratorQueueDequeue):
(globalPrivate.asyncGeneratorQueueGetFirstValue):
(globalPrivate.asyncGeneratorDequeue):
(globalPrivate.isExecutionState):
(globalPrivate.isSuspendYieldState):
(globalPrivate.asyncGeneratorReject):
(globalPrivate.asyncGeneratorResolve):
(asyncGeneratorYieldAwaited):
(globalPrivate.asyncGeneratorYield):
(const.onRejected):
(globalPrivate.awaitValue):
(const.onFulfilled):
(globalPrivate.doAsyncGeneratorBodyCall):
(globalPrivate.asyncGeneratorResumeNext.):
(globalPrivate.asyncGeneratorResumeNext):
(globalPrivate.asyncGeneratorEnqueue):
(next):
(return):
(throw):

  • builtins/AsyncIteratorPrototype.js: Added.

(symbolAsyncIteratorGetter):

  • builtins/BuiltinNames.h:
  • bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumper<Block>::dumpBytecode):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCreateAsyncGeneratorQueue):
(JSC::BytecodeGenerator::emitPutAsyncGeneratorFields):
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
(JSC::BytecodeGenerator::emitNewFunction):
(JSC::BytecodeGenerator::emitIteratorNextWithValue):
(JSC::BytecodeGenerator::emitIteratorClose):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitYield):
(JSC::BytecodeGenerator::emitCallIterator):
(JSC::BytecodeGenerator::emitAwait):
(JSC::BytecodeGenerator::emitGetIterator):
(JSC::BytecodeGenerator::emitGetAsyncIterator):
(JSC::BytecodeGenerator::emitDelegateYield):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ReturnNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
(JSC::YieldExprNode::emitBytecode):
(JSC::AwaitExprNode::emitBytecode):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGClobbersExitState.cpp:

(JSC::DFG::clobbersExitState):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGMayExit.cpp:
  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPhantomNewFunction):
(JSC::DFG::Node::convertToPhantomNewAsyncGeneratorFunction):
(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::isFunctionAllocation):
(JSC::DFG::Node::isPhantomFunctionAllocation):
(JSC::DFG::Node::isPhantomAllocation):

  • dfg/DFGNodeType.h:
  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunction):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStoreBarrierInsertionPhase.cpp:
  • dfg/DFGValidate.cpp:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationPopulateObjectInOSR):
(JSC::FTL::operationMaterializeObjectInOSR):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emit_op_new_async_generator_func):
(JSC::JIT::emit_op_new_async_func):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_async_generator_func_exp):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createFunctionMetadata):

  • runtime/AsyncFromSyncIteratorPrototype.cpp: Added.

(JSC::AsyncFromSyncIteratorPrototype::AsyncFromSyncIteratorPrototype):
(JSC::AsyncFromSyncIteratorPrototype::finishCreation):
(JSC::AsyncFromSyncIteratorPrototype::create):

  • runtime/AsyncFromSyncIteratorPrototype.h: Added.

(JSC::AsyncFromSyncIteratorPrototype::createStructure):

  • runtime/AsyncGeneratorFunctionConstructor.cpp: Added.

(JSC::AsyncGeneratorFunctionConstructor::AsyncGeneratorFunctionConstructor):
(JSC::AsyncGeneratorFunctionConstructor::finishCreation):
(JSC::callAsyncGeneratorFunctionConstructor):
(JSC::constructAsyncGeneratorFunctionConstructor):
(JSC::AsyncGeneratorFunctionConstructor::getCallData):
(JSC::AsyncGeneratorFunctionConstructor::getConstructData):

  • runtime/AsyncGeneratorFunctionConstructor.h: Added.

(JSC::AsyncGeneratorFunctionConstructor::create):
(JSC::AsyncGeneratorFunctionConstructor::createStructure):

  • runtime/AsyncGeneratorFunctionPrototype.cpp: Added.

(JSC::AsyncGeneratorFunctionPrototype::AsyncGeneratorFunctionPrototype):
(JSC::AsyncGeneratorFunctionPrototype::finishCreation):

  • runtime/AsyncGeneratorFunctionPrototype.h: Added.

(JSC::AsyncGeneratorFunctionPrototype::create):
(JSC::AsyncGeneratorFunctionPrototype::createStructure):

  • runtime/AsyncGeneratorPrototype.cpp: Added.

(JSC::AsyncGeneratorPrototype::finishCreation):

  • runtime/AsyncGeneratorPrototype.h: Added.

(JSC::AsyncGeneratorPrototype::create):
(JSC::AsyncGeneratorPrototype::createStructure):
(JSC::AsyncGeneratorPrototype::AsyncGeneratorPrototype):

  • runtime/AsyncIteratorPrototype.cpp: Added.

(JSC::AsyncIteratorPrototype::finishCreation):

  • runtime/AsyncIteratorPrototype.h: Added.

(JSC::AsyncIteratorPrototype::create):
(JSC::AsyncIteratorPrototype::createStructure):
(JSC::AsyncIteratorPrototype::AsyncIteratorPrototype):

  • runtime/CommonIdentifiers.h:
  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/FunctionConstructor.h:
  • runtime/FunctionExecutable.h:
  • runtime/JSAsyncGeneratorFunction.cpp: Added.

(JSC::JSAsyncGeneratorFunction::JSAsyncGeneratorFunction):
(JSC::JSAsyncGeneratorFunction::createImpl):
(JSC::JSAsyncGeneratorFunction::create):
(JSC::JSAsyncGeneratorFunction::createWithInvalidatedReallocationWatchpoint):

  • runtime/JSAsyncGeneratorFunction.h: Added.

(JSC::JSAsyncGeneratorFunction::allocationSize):
(JSC::JSAsyncGeneratorFunction::createStructure):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::asyncIteratorPrototype const):
(JSC::JSGlobalObject::asyncGeneratorPrototype const):
(JSC::JSGlobalObject::asyncGeneratorFunctionPrototype const):
(JSC::JSGlobalObject::asyncGeneratorFunctionStructure const):

  • runtime/Options.h:

LayoutTests:

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
10:04 AM Changeset in webkit [221079] by Jonathan Bedard
  • 9 edits in trunk/Tools

Access expectations path through apple_additions
https://bugs.webkit.org/show_bug.cgi?id=174800
<rdar://problem/33498899>

Reviewed by Alexey Proskuryakov.

When external test expectations are imported through additional-platform-directory, they will
over-write any WebKit expectations. Access some expectations from apple_additions to correct
these precedence issues.

  • Scripts/webkitpy/port/ios.py:

(IOSPort._apple_additions_path): Convert test expectation directory to a path
coming from apple_additions.
(IOSPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
path for layout test expectations.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.

  • Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.

  • Scripts/webkitpy/port/mac.py:

(MacPort._apple_additions_path): Convert test expectation directory to a path
coming from apple_additions.
(MacPort.default_baseline_search_path): Alternate between WebKit path and apple_additions
path for layout test expectations.

  • Scripts/webkitpy/port/mac_unittest.py:

(MacTest.test_layout_test_searchpath_with_apple_additions): Added to test layout-test search paths.

  • Scripts/webkitpy/port/port_testcase.py:

(bind_mock_apple_additions): Added to create mock apple_additions for a block.
(bind_mock_apple_additions.MockAppleAdditions): Contains apple_addition stubs for testing.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_baseline_search_path): Include apple_additions test expectation for Windows.

9:28 AM Changeset in webkit [221078] by jfbastien@apple.com
  • 2 edits in trunk/JSTests

Fix verbose in tests

9:25 AM Changeset in webkit [221077] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Ensure media controls host exists before using it
https://bugs.webkit.org/show_bug.cgi?id=175833
<rdar://problem/34001219>

Reviewed by Jer Noble.

Source/WebCore:

Although we ensure that the media controls shadow root exists before updating the text track
container, we don't check that the media controls host has been created yet. We do check
and create in other places in HTMLMediaElement.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateTextTrackDisplay):

LayoutTests:

  • media/track/track-display-before-controls-crash-expected.txt: Added.
  • media/track/track-display-before-controls-crash.html: Added.
9:21 AM Changeset in webkit [221076] by pvollan@apple.com
  • 2 edits in trunk/Source/WTF

[Win] Compile error, include file <wtf/AVFoundationHeaderDetection.h> is not found.
https://bugs.webkit.org/show_bug.cgi?id=175853

Reviewed by Brent Fulgham.

Copy generated WTF header files to the same place as we copy forwarding headers.

  • WTF.vcxproj/WTF.proj:
8:16 AM Changeset in webkit [221075] by clopez@igalia.com
  • 5 edits
    1 move
    1 add
    1 delete in trunk

[WPE] Some event handlers not working.
https://bugs.webkit.org/show_bug.cgi?id=175864

Reviewed by Michael Catanzaro.

Source/WebCore:

Share the EventHandler implementation with the GTK port and add ifdefs where needed.

Covered by existing tests.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • page/wpe/EventHandlerWPE.cpp: Removed.
  • platform/glib/EventHandlerGlib.cpp: Renamed from Source/WebCore/page/gtk/EventHandlerGtk.cpp.

(WebCore::EventHandler::shouldTurnVerticalTicksIntoHorizontal const):

LayoutTests:

Remove expected failures for tests that now pass, add new expectation
for a test that is failing also on GTK+ and rebaseline a test with
the same expected result than on GTK+.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/events/focus-label-legend-elements-with-tab-expected.txt: Added.
6:02 AM Changeset in webkit [221074] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Remove some flaky annotations for passing tests.
https://bugs.webkit.org/show_bug.cgi?id=175881

Unreviewed test gardening.

None of these tests have had their alternative status in months.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-23

  • platform/gtk/TestExpectations:
5:56 AM Changeset in webkit [221073] by zandobersek@gmail.com
  • 2 edits
    12 adds in trunk/LayoutTests

Unreviewed WPE gardening. Unskipping tests under fast/canvas/, adding
failure expectations for actual failures, and providing port-specific
baselines for tests that require them.

  • platform/wpe/TestExpectations:
  • platform/wpe/fast/canvas: Added.
  • platform/wpe/fast/canvas/canvas-size-change-after-layout-expected.txt: Added.
  • platform/wpe/fast/canvas/canvas-zoom-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl: Added.
  • platform/wpe/fast/canvas/webgl/angle-instanced-arrays-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/angle-instanced-arrays-out-of-bounds-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/glsl-conformance-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/oes-texture-half-float-expected.txt: Added.
  • platform/wpe/fast/canvas/webgl/webgl-draw-buffers-expected.txt: Added.
5:42 AM Changeset in webkit [221072] by calvaris@igalia.com
  • 3 edits
    3 adds in trunk

[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
https://bugs.webkit.org/show_bug.cgi?id=175625

Three files were created as kind of hooks for the GTK and WPE
CMake option files. The definitions one is to enable, disable and
create the common options (that can be and are actually overriden
in some cases. The dependencies one adds dependencies for the
option switches that are set. The checks one ensure the
dependencies are met depending on the option switches.

Reviewed by Carlos Alberto Lopez Perez.

  • Source/cmake/GStreamerChecks.cmake: Added.
  • Source/cmake/GStreamerDefinitions.cmake: Added.
  • Source/cmake/GStreamerDependencies.cmake: Added.
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:
4:23 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
2:47 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
Update log (diff)
2:17 AM Changeset in webkit [221071] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=175878

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-23

  • platform/gtk/TestExpectations:
    • Mark fast/mediastream/captureStream/canvas2d-heavy-drawing.html as flaky.
    • Add crash annotations for cache-storage tests.
  • platform/gtk/http/wpt/beacon/beacon-async-error-logging-expected.txt: Added: logs a different error message to the console on GTK.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt: Update for the disabling of the CSS Regions code in r220870.
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt: Update for the disabling of the CSS Regions code in r220870.
2:16 AM Changeset in webkit [221070] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Disable intermittently crashing CSS Regions tests.
https://bugs.webkit.org/show_bug.cgi?id=135051

Unreviewed test gardening.

They have been failing since the CSS Regions code was disabled in r220870.
That commit also skipped these tests, but the older crash expectation
overrode the skipping.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-23

  • platform/gtk/TestExpectations:
1:57 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
Update log (diff)

Aug 22, 2017:

11:45 PM Changeset in webkit [221069] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed. The WPE port should build TestWebKitAPI with the same
compiler flags as the GTK+ port, disabling a few flags that are
sprouting a lot of warning output.

  • TestWebKitAPI/PlatformWPE.cmake:
9:59 PM Changeset in webkit [221068] by timothy_horton@apple.com
  • 29 edits in trunk/Source

_WKThumbnailView should use the screen color space instead of sRGB
https://bugs.webkit.org/show_bug.cgi?id=175858
<rdar://problem/33925559>

Reviewed by Dean Jackson.

Currently, _WKThumbnailView uses software snapshotting via
WebPage's takeSnapshot and friends, which always use sRGB.
However, it is immediately presented in display space, which
causes an expensive color conversion, which could have been avoided
if the snapshot was instead originally taken in display space.

To solve this, add:

  • a mechanism allowing ShareableBitmap to be constructed with a configuration, which can include a color space as well as the existing flags (flipping SupportsAlpha to be IsOpaque instead because most callers want alpha)
  • a WebImage constructor allowing callers to pass a ShareableBitmap configuration through
  • a bit in SnapshotOptions for callers to indicate that they want to snapshot in the display's color space (repurposed from the ExtendedColor bit)

And then make use of that bit in _WKThumbnailView.

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::snapshotOptionsFromImageOptions):
Remove this incorrect conversion (WKImageOptions doesn't include
kWKSnapshotOptionsExtendedColor).

(WebKit::toSnapshotOptions):
Plumb kWKSnapshotOptionsExtendedColor to WebKit::SnapshotOptions
as the "UseScreenColorSpace". Leave the SPI name intact because
it has clients, but the difference isn't so huge that it will be
a problem.

  • Shared/ImageOptions.h:

(WebKit::snapshotOptionsToImageOptions):
Remove ImageOptionsExtendedColor, and rename
SnapshotOptionsExtendedColor to SnapshotOptionsUseScreenColorSpace.

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::Handle):
(WebKit::ShareableBitmap::Handle::encode const):
(WebKit::ShareableBitmap::Handle::decode):
(WebKit::ShareableBitmap::Handle::clear):
(WebKit::ShareableBitmap::Configuration::encode const):
(WebKit::ShareableBitmap::Configuration::decode):
(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::createShareable):
(WebKit::ShareableBitmap::createHandle const):
(WebKit::ShareableBitmap::ShareableBitmap):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::calculateBytesPerPixel): Deleted.

  • Shared/ShareableBitmap.h:

(WebKit::ShareableBitmap::numBytesForSize):
(WebKit::ShareableBitmap::sizeInBytes const):

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::colorSpace):
(WebKit::bitmapInfo):
(WebKit::ShareableBitmap::calculateBytesPerPixel):
(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::createCGImage const):
Remove ShareableBitmap's flags parameter, and replace it with
a configuration parameter. Configuration is a struct that currently
encompasses the newly-flipped IsOpaque bit and (on Cocoa platforms)
a platform colorspace object. Compute bytesPerPixel dynamically
based on the colorspace and whether it uses extended colors or not.

  • Shared/WebImage.cpp:

(WebKit::WebImage::create):

  • Shared/WebImage.h:

Pass ShareableBitmap::Configuration through to the ShareableBitmap
constructor, if provided.

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView requestSnapshot]):
Make use of the new bit, and use the screen's color space.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::snapshotOptionsToBitmapConfiguration):
(WebKit::WebPage::snapshotAtSize):
(WebKit::WebPage::snapshotNode):
If the snapshot option to use the display color space is set,
fill in the colorSpace field in the ShareableBitmap::Configuration
with the screen's color space.

(WebKit::WebPage::drawRectToImage):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeImage):

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):

  • Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::snapshot):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):
(WebKit::PluginProxy::updateBackingStore):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::convertImageToBitmap):
(WebKit::convertCGImageToBitmap):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot const):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):
Adopt ShareableBitmap::Configuration. Since IsOpaque
defaults to false, all callers who previously constructed
ShareableBitmap with SupportsAlpha now don't have to do anything.

  • platform/PlatformScreen.h:
  • platform/ios/PlatformScreenIOS.mm:

(WebCore::screenColorSpace):

  • platform/mac/PlatformScreenMac.mm:

(WebCore::screenColorSpace):
(WebCore::screenSupportsExtendedColor):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::screenColorSpace):
Add screenColorSpace, which returns the active color space for the
given Widget's screen. On Windows, just fall back to sRGB like we usually do.

9:54 PM Changeset in webkit [221067] by rniwa@webkit.org
  • 5 edits in trunk

Consolidate the code to normalize MIME type in DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=175810

Rubber-stamped by Wenson Hsieh.

Address the forgotten review comment by Wenson.

Source/WebCore:

Tests: editing/pasteboard/datatransfer-getdata-plaintext.html

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::clearData):

LayoutTests:

  • editing/pasteboard/datatransfer-getdata-plaintext-expected.txt:
  • editing/pasteboard/datatransfer-getdata-plaintext.html:
9:47 PM Changeset in webkit [221066] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed, try to fix the Windows build after r221064

didEndUserTriggeredSelectionChanges is virtual, and needs to be overridden in WebEditorClient.

  • WebCoreSupport/WebEditorClient.h:
8:16 PM Changeset in webkit [221065] by wenson_hsieh@apple.com
  • 27 edits
    4 adds in trunk

[iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
https://bugs.webkit.org/show_bug.cgi?id=175116
<rdar://problem/28279301>

Reviewed by Darin Adler and Ryosuke Niwa.

Source/WebCore:

WebCore support for WebPage::editorState refactoring. See WebKit ChangeLogs for more detail.

Tests: EditorStateTests.TypingAttributesBold

EditorStateTests.TypingAttributesItalic
EditorStateTests.TypingAttributesUnderline
EditorStateTests.TypingAttributesTextAlignmentAbsoluteAlignmentOptions
EditorStateTests.TypingAttributesTextAlignmentStartEnd
EditorStateTests.TypingAttributesTextAlignmentDirectionalText
EditorStateTests.TypingAttributesTextColor
EditorStateTests.TypingAttributesMixedStyles
EditorStateTests.TypingAttributesLinkColor

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::propertyAsColor const):
(WebCore::StyleProperties::propertyAsValueID const):

Introduces some helper functions in StyleProperties to convert CSS property values to Color or a CSSValueID.

  • css/StyleProperties.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::hasStyle):

Pull out logic in selectionStartHasStyle that asks for a style TriState into EditingStyle::hasStyle. This is
because WebPage::editorState will now query for multiple styles at the selection start, but
selectionStartHasStyle currently recomputes styleAtSelectionStart every time it is called. To prevent extra work
from being done, we can just call selectionStartHasStyle once and use ask for EditingStyle::hasStyle on the
computed EditingStyle at selection start.

  • editing/EditingStyle.h:
  • editing/Editor.cpp:

(WebCore::Editor::selectionStartHasStyle const):

Source/WebKit:

Refactors WebPage::editorState to only use the StyleProperties derived from EditingStyle, instead of inserting
and removing a temporary node to figure out the style. Also adds hooks to notify the UI delegate of EditorState
changes.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(nsTextAlignment):
(dictionaryRepresentationForEditorState):
(-[WKWebView _didChangeEditorState]):

Alerts the private UI delegate of UI-side EditorState updates.

(-[WKWebView _web_editorStateDidChange]):
(-[WKWebView _executeEditCommand:argument:completion:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _web_editorStateDidChange]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::selectionDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::executeEditCommand):

Change executeEditCommand(name, callback) to executeEditCommand(name, argument, callback) and lift out of iOS
platform code and into WebPage.cpp.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView executeEditCommandWithCallback:]):
(-[WKContentView _selectionChanged]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::executeEditCommand): Deleted.

Move the iOS-specific implementation of executeEditCommand that invokes a callback when the web process responds
out of WebPageProxyIOS, and into cross-platform WebPageProxy code. Additionally, add a parameter for the edit
command's argument.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

Use EditingStyle::styleAtSelectionStart instead of Editor::styleForSelectionStart when computing an EditorState.
Tweak bold, italic and underline to use EditingStyle TriStates.

(WebKit::WebPage::executeEditCommandWithCallback):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::executeEditCommandWithCallback): Deleted.

Tools:

Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
EditorStateTests run on both iOS and Mac.

  • TestWebKitAPI/EditingTestHarness.h: Added.
  • TestWebKitAPI/EditingTestHarness.mm: Added.

EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
the state of the latest observed EditorState.

(-[EditingTestHarness initWithWebView:]):
(-[EditingTestHarness dealloc]):
(-[EditingTestHarness webView]):
(-[EditingTestHarness latestEditorState]):
(-[EditingTestHarness editorStateHistory]):
(-[EditingTestHarness insertText:andExpectEditorStateWith:]):
(-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
(-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
(-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness toggleBold]):
(-[EditingTestHarness toggleItalic]):
(-[EditingTestHarness toggleUnderline]):
(-[EditingTestHarness setForegroundColor:]):
(-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
(-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
(-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
(-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
(-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
(-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness _execCommand:argument:expectEntries:]):

Dispatches an editing command to the web process, and blocks until a response is received. If an expected
entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
keys and values.

(-[EditingTestHarness latestEditorStateContains:]):
(-[EditingTestHarness _webView:editorStateDidChange:]):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.

(TestWebKitAPI::setUpEditorStateTestHarness):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.

LayoutTests:

  • platform/ios-wk2/editing/style/unbold-in-bold-expected.txt:
  • platform/mac-wk2/editing/style/unbold-in-bold-expected.txt:

Rebaseline a WK2 LayoutTest expectations. This test currently expects an empty anonymous RenderBlock to be
inserted into the render tree, but this is only a result of us adding and removing a temporary <span> when
computing a RenderStyle in WebPage::editorState -- this patch removes these empty RenderBlocks, making these
expectations' RenderTrees consistent with WebKit1.

8:15 PM Changeset in webkit [221064] by wenson_hsieh@apple.com
  • 57 edits in trunk

[WK2] EditorState updates should be rolled into the layer update lifecycle when possible
https://bugs.webkit.org/show_bug.cgi?id=175370
<rdar://problem/33799806>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove didChangeSelectionAndUpdateLayout -- EditorState updates that are scheduled due to missing post-layout
data will now be scheduled for the next presentation update. Additionally, add editor client hooks to notify the
WebKit layer when we've updated the current composition. See WebKit ChangeLog for more details. This patch
adjusts and rebaselines existing layout tests.

  • editing/Editor.cpp:

(WebCore::SetCompositionScope::SetCompositionScope):
(WebCore::SetCompositionScope::~SetCompositionScope):

Introduce a helper RAII class to ensure that we ignore selection changes during the scope of
Editor::setComposition and call out to the client with WebEditorClient::didUpdateComposition afterwards. This
also maintains a UserTypingGestureIndicator over its lifetime, so we don't additionally need to create a
UserTypingGestureIndicator in Editor::setComposition.

(WebCore::Editor::setComposition):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::updateAndRevealSelection):
(WebCore::FrameSelection::setSelectedRange):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::defaultSetSelectionOptions):

Plumb state about whether or not the selection change was triggered by the user to FrameSelection::setSelection,
and if so, notify the editing client. A separate SetSelectionOptions flag is used here instead of
RevealSelection to avoid calling out to the client in places where we want to reveal the selection regardless of
whether or not the selection is user triggered.

  • loader/EmptyClients.cpp:
  • page/EditorClient.h:

Source/WebKit:

See per-method comments for more detail. WebPage::didChangeSelection now schedules EditorState updates to be sent
during the next layer tree transaction rather than sending them synchronously. To ensure that iOS and Mac continue
to behave correctly w.r.t. EditorState updates, we immediately dispatch EditorStates in the following cases:

  • After the composition changes, is confirmed, or is canceled.
  • After an edit command is executed.
  • After ending user-triggered selection changes.
  • Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::hasEditorState const):
(WebKit::RemoteLayerTreeTransaction::editorState const):
(WebKit::RemoteLayerTreeTransaction::setEditorState):

Attaches an optional EditorState to the RemoteLayerTreeTransaction. This EditorState is computed and sent over
when setting up the transaction in WebPage, if something previously scheduled an EditorState update.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode const):
(WebKit::RemoteLayerTreeTransaction::decode):

Add coder support for sending over a layer tree transaction's EditorState.

  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _doAfterNextPresentationUpdate:]):

Add _doAfterNextPresentationUpdate to WKView (used in TestWebKitAPI -- refer to
WebKitAgnosticTest::waitForNextPresentationUpdate).

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::dispatchPresentationCallbacksAfterFlushingLayers):

  • UIProcess/DrawingAreaProxy.messages.in:

Add a new IPC messages, DispatchPresentationCallbacksAfterFlushingLayers, to invoke in-flight presentation
callbacks in the UI process following a layer flush in the web process.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::~TiledCoreAnimationDrawingAreaProxy):
(WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::TiledCoreAnimationDrawingAreaProxy::dispatchPresentationCallbacksAfterFlushingLayers):

Run all pending _doAfterNextPresentationUpdate callbacks.

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::didApplyStyle):
(WebKit::WebEditorClient::respondToChangedContents):
(WebKit::WebEditorClient::didEndUserTriggeredSelectionChanges):
(WebKit::WebEditorClient::didUpdateComposition):

Forward editor client calls to the WebPage.

(WebKit::WebEditorClient::didChangeSelectionAndUpdateLayout): Deleted.

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):
(WebKit::WebPage::updateEditorStateAfterLayoutIfEditabilityChanged):
(WebKit::WebPage::willCommitLayerTree):
(WebKit::WebPage::didApplyStyle):

Allow style application to immediately trigger EditorState updates, if we're not currently ignoring selection
changes in the Editor.

(WebKit::WebPage::didChangeContents):

Allow applying top-level edit commands to immediately trigger EditorState updates, if we're not currently
ignoring selection changes in the Editor.

(WebKit::WebPage::didChangeSelection):
(WebKit::WebPage::didUpdateComposition):
(WebKit::WebPage::didEndUserTriggeredSelectionChanges):
(WebKit::WebPage::discardedComposition):
(WebKit::WebPage::canceledComposition):

When handling composition updates, always send an EditorState to the UI process. Unlike other cases, IME
requires immediate EditorState data, so we need to be explicit here in sending updates right away.

(WebKit::WebPage::sendEditorStateUpdate):
(WebKit::WebPage::sendPartialEditorStateAndSchedulePostLayoutUpdate):
(WebKit::WebPage::flushPendingEditorStateUpdate):

Helper methods to schedule an EditorState update to be sent upon the next layer tree update, or flush any
pending EditorState update that has been scheduled. The private, more aggressive variant of this is
sendEditorStateUpdate, which ignores whether or not there was already an EditorState update scheduled, and sends
one anyways (this still fulfills any EditorState update that was previously scheduled).

These helper methods are treated as no-ops when invoked while ignoring selection changes. This is to prevent
temporary selection state and editor commands during operations such as text indicator snapshotting from pushing
bogus information about transient editor states to the UI process.

(WebKit::WebPage::sendPostLayoutEditorStateIfNeeded): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::executeEditCommandWithCallback):
(WebKit::selectionIsInsideFixedPositionContainer):
(WebKit::WebPage::updateVisibleContentRects):

Fix a hack that was computing an EditorState to figure out whether the current selection starts or ends in a
fixed position container. Factors out relevant logic into a separate helper, and also schedules an EditorState
update instead of immediately computing it.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::addTransactionCallbackID):

Add support for registering and dispatching presentation callbacks that hook into the layer flush lifecycle,
using the tiled CA drawing area. These are used by Mac LayoutTests and API tests that need to wait until the
next flush before checking for state that depends on EditorState updates in the UI process.

(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

Tell the WebPage to flush any pending EditorState updates.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformEditorState const):

Source/WebKitLegacy/mac:

Adjust WebEditorClient for interface changes.

  • WebCoreSupport/WebEditorClient.h:

Source/WebKitLegacy/win:

Adjust WebEditorClient for interface changes.

  • WebCoreSupport/WebEditorClient.h:

Tools:

Tweaks API tests that involve editing to wait for a presentation update before checking against UI process-side
information sent via EditorState updates. This allows any EditorState update scheduled by the test to propagate
to the UI process.

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:

(-[CandidateTestWebView typeString:inputMessage:]):
(+[CandidateTestWebView setUpWithFrame:testPage:]):

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
  • TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:

(TestWebKitAPI::AcceptsFirstMouse::runTest):

  • TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
  • TestWebKitAPI/cocoa/TestWKWebView.h:
  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView waitForNextPresentationUpdate]):

Add a new helper method to spin until the next presentation update.

  • TestWebKitAPI/mac/WebKitAgnosticTest.h:
  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

(TestWebKitAPI::WebKitAgnosticTest::waitForNextPresentationUpdate):

LayoutTests:

Rebaseline and adjust LayoutTests.

  • editing/caret/ios/absolute-caret-position-after-scroll-expected.txt:
  • editing/caret/ios/absolute-caret-position-after-scroll.html:
  • editing/caret/ios/fixed-caret-position-after-scroll-expected.txt:
  • editing/caret/ios/fixed-caret-position-after-scroll.html:
  • editing/secure-input/password-input-changed-type.html:
  • editing/secure-input/password-input-focusing.html:
  • editing/secure-input/removed-password-input.html:
  • editing/secure-input/reset-state-on-navigation.html:
  • editing/selection/character-granularity-rect.html:

Delay checking for secure input state and caret rects until after the next presentation update.

  • editing/selection/ios/absolute-selection-after-scroll-expected.txt:
  • editing/selection/ios/absolute-selection-after-scroll.html:
  • editing/selection/ios/fixed-selection-after-scroll-expected.txt:
  • editing/selection/ios/fixed-selection-after-scroll.html:

Refactor and simplify these tests. These tests are not run on the OpenSource bots, since they depend on long
press and tap gestures.

  • platform/ios-wk2/editing/inserting/insert-div-024-expected.txt:
  • platform/ios-wk2/editing/inserting/insert-div-026-expected.txt:
  • platform/ios-wk2/editing/style/5084241-expected.txt:

Rebaselines these tests, removing an anonymous RenderBlock inserted as a result of inserting and removing a
dummy span in order to compute a RenderStyle in WebPage::editorState. This is because editorState is no longer
invoked immediately on page load; https://bugs.webkit.org/show_bug.cgi?id=175116 tracks preventing this render
tree thrashing altogether.

  • platform/mac-wk2/TestExpectations:
  • platform/mac-wk2/editing/style/unbold-in-bold-expected.txt:
  • resources/ui-helper.js:

Introduce new UIHelper functions.

(window.UIHelper.ensurePresentationUpdate.return.new.Promise):
(window.UIHelper.ensurePresentationUpdate):

Returns a Promise, resolved after the next presentation update.

(window.UIHelper.activateAndWaitForInputSessionAt.return.new.Promise.):
(window.UIHelper.activateAndWaitForInputSessionAt.return.new.Promise):
(window.UIHelper.activateAndWaitForInputSessionAt):

Returns a Promise, resolved after tapping at the given location and waiting for the keyboard to appear on iOS.

(window.UIHelper.getUICaretRect.return.new.Promise.):
(window.UIHelper.getUICaretRect.return.new.Promise):
(window.UIHelper.getUICaretRect):
(window.UIHelper.getUISelectionRects.return.new.Promise.):
(window.UIHelper.getUISelectionRects.return.new.Promise):
(window.UIHelper.getUISelectionRects):

Helpers to fetch selection and caret rect information in the UI process.

7:57 PM Changeset in webkit [221063] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

Consolidate the code to normalize MIME type in DataTransfer
https://bugs.webkit.org/show_bug.cgi?id=175810

Reviewed by Wenson Hsieh.

Source/WebCore:

Factored out the code to convert MIME type to lowercase after stripping whitespace,
and treat "text" as "text/plain" and "url" as "text/uri-list".

Specifications:
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-getdata-2
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdata-2
https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-cleardata-2

Stripping of whitespace only happens in WebKit/Blink but it's probably required for compatbility.
Spec bug: https://github.com/whatwg/html/issues/2946

Test: editing/pasteboard/datatransfer-getdata-plaintext.html

  • dom/DataTransfer.cpp:

(WebCore::normalizeType):
(WebCore::DataTransfer::clearData):
(WebCore::DataTransfer::getData const):
(WebCore::DataTransfer::setData):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::selectionDataTypeFromHTMLClipboardType):

  • platform/ios/PasteboardIOS.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):

  • platform/win/PasteboardWin.cpp:

(WebCore::clipboardTypeFromMIMEType):

LayoutTests:

Added a regression test. Some test cases were failing on some platforms.

  • editing/pasteboard/datatransfer-getdata-plaintext-expected.txt: Added.
  • editing/pasteboard/datatransfer-getdata-plaintext.html: Added.
6:12 PM Changeset in webkit [221062] by Matt Lewis
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r221033.

This revision caused assertion failures on all Open Source
Debug testers. See Radar for more information.

Reverted changeset:

"Ensure media controls host exists before using it"
https://bugs.webkit.org/show_bug.cgi?id=175833
http://trac.webkit.org/changeset/221033

6:05 PM Changeset in webkit [221061] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

Relax keychain access to permit users to permanently allow client certificates
https://bugs.webkit.org/show_bug.cgi?id=175857
<rdar://problem/32293867>

Reviewed by Alex Christensen.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
5:32 PM Changeset in webkit [221060] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked http/tests/loading/basic-auth-remove-credentials.html as falky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=173500

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:09 PM Changeset in webkit [221059] by Chris Dumez
  • 10 edits
    1 add in trunk/Source

Introduce a new CompletionHandler type and use it for NetworkDataTaskClient's completion handlers to help catch bugs
https://bugs.webkit.org/show_bug.cgi?id=175832

Reviewed by Alex Christensen.

Source/WebKit:

Use new CompletionHandler type for NetworkDataTaskClient's completion handlers to help catch bugs.
It actually already found a bug in our HTTP 0.9 error handling which is fixed in this patch
as well.

  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::didReceiveResponse):

  • NetworkProcess/NetworkDataTask.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::tryPasswordBasedAuthentication):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):

  • Shared/Authentication/AuthenticationManager.h:
  • Shared/Authentication/mac/AuthenticationManager.mac.mm:

(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):

Source/WTF:

Introduce a new CompletionHandler type which wraps a WTF::Function and ensures via assertions
that the function is always called once and only once.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CompletionHandler.h: Added.

(WTF::CompletionHandler<Out):

5:06 PM Changeset in webkit [221058] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Fix compile errors.
https://bugs.webkit.org/show_bug.cgi?id=175860

Reviewed by Brent Fulgham.

Add required header files.

  • platform/network/cf/CookieJarCFNet.cpp:
5:00 PM Changeset in webkit [221057] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org against at r221056.

Rubber-stamped by Joseph Pecoraro.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
  • Speedometer2.0/resources/main.js:

(window.benchmarkClient.didFinishLastIteration):

  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.a55034b424c795b1a9a8.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.a55034b424c795b1a9a8.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.bade2cb8992d8a68d0d7.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.bade2cb8992d8a68d0d7.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.9debb1b0a94f14d0ebe9.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.9debb1b0a94f14d0ebe9.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.bade2cb8992d8a68d0d7.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.bade2cb8992d8a68d0d7.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015/src/store.js:
4:46 PM Changeset in webkit [221056] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Correct SOUP builds after r221017 and r221050.
https://bugs.webkit.org/show_bug.cgi?id=175846

Reviewed by Michael Catanzaro.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForDOM): Revise return type.

4:15 PM Changeset in webkit [221055] by achristensen@apple.com
  • 7 edits
    1 add in trunk

Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
https://bugs.webkit.org/show_bug.cgi?id=175797
<rdar://problem/29270035>

Reviewed by Geoffrey Garen.

Source/WebKit:

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::showPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::registerURLSchemeHandler):
window.open, createWebViewWithConfiguration, and WKURLSchemeHandlers all used together
make it so that URLSchemeHandlers are added to WebPages that already have them. The
assertions are no longer valid.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.

(-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[UITestDelegate _showPage:]):
(-[UITestDelegate webView:startURLSchemeTask:]):
(-[UITestDelegate webView:stopURLSchemeTask:]):
(TEST):

4:11 PM Changeset in webkit [221054] by rniwa@webkit.org
  • 4 edits
    10 adds
    10 deletes in trunk/PerformanceTests

REGRESSION(R220043): Speedometer 2.0: Fix vanilla JS examples
https://bugs.webkit.org/show_bug.cgi?id=175815

Reviewed by Saam Barati.

Both vanilla ES2015 and Babel + WebPack test cases were failing to mark Todo items as completed since they were relying on
new Date().getTime() to generate an unique ID. That's not going to work if mulitple todo items are added within 1ms.

  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.71bb1f671e4e65604d05.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.9debb1b0a94f14d0ebe9.js.map: Removed.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.2102040c9a6e04cc046e.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.b16cc08e016d07886f5f.js.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/index.html:
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.71bb1f671e4e65604d05.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.b16cc08e016d07886f5f.css.map: Added.
  • Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/store.js:
  • Speedometer/resources/todomvc/vanilla-examples/es2015/src/store.js:
4:04 PM Changeset in webkit [221053] by Dewei Zhu
  • 12 edits in trunk/Websites/perf.webkit.org

Performance Dashboard should be compatible with PHP 7.
https://bugs.webkit.org/show_bug.cgi?id=175813

Reviewed by Ryosuke Niwa.

Use file_get_contents('php://input') instead of '$HTTP_RAW_POST_DATA'.
Update test harness script to load right php module in httpd.

  • ReadMe.md: JSON example format fix.
  • public/api/report-commits.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/api/report.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/api/update-triggerable.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/include/json-header.php: Stop using '$HTTP_RAW_POST_DATA'.
  • public/include/report-processor.php: Stop using '$HTTP_RAW_POST_DATA'.
  • server-tests/resources/test-server.conf: Load php5 or php7 module conditionally.
  • server-tests/resources/test-server.js: Pass PHP version info while launching httpd.

(TestServer.prototype._startApache):

  • tools/remote-cache-server.py: Pass PHP version info while launching httpd.

(start_httpd):

  • tools/remote-server-relay.conf: Load php5 or php7 module conditionally.
  • tools/sync-buildbot.js:

(syncLoop.const.makeTriggerable):
(syncLoop):

3:43 PM Changeset in webkit [221052] by msaboff@apple.com
  • 14 edits in trunk

Implement Unicode RegExp support in the YARR JIT
https://bugs.webkit.org/show_bug.cgi?id=174646

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This support is only implemented for 64 bit platforms. It wouldn't be too hard to add support
for 32 bit platforms with a reasonable number of spare registers. This code slightly refactors
register usage to reduce the number of callee save registers used for non-Unicode expressions.
For Unicode expressions, there are several more registers used to store constants values for
processing surrogate pairs as well as discerning whether a character belongs to the Basic
Multilingual Plane (BMP) or one of the Supplemental Planes.

This implements JIT support for Unicode expressions very similar to how the interpreter works.
Just like in the interpreter, backtracking code uses more space on the stack to save positions.
Moved the BackTrackInfo* structs to YarrPattern as separate functions. Added xxxIndex()
functions to each of these to simplify how the JIT code reads and writes the structure fields.

Given that reading surrogate pairs and transforming them into a single code point takes a
little processing, the code that implements reading a Unicode character is implemented as a
leaf function added to the end of the JIT'ed code. The calling convention for
"tryReadUnicodeCharacterHelper()" is non-standard given that the rest of the code assumes
that argument values stay in argument registers for most of the generated code.
That helper takes the starting character address in one register, regUnicodeInputAndTrail,
and uses another dedicated temporary register, regUnicodeTemp. The result is typically
returned in regT0. If another return register is requested, we'll create an inline copy of
that function.

Added a new flag to CharacterClass to signify if a class has non-BMP characters. This flag
is used in optimizeAlternative() where we swap the order of a fixed character class term with
a fixed character term that immediately follows it. Since the non-BMP character class may
increment "index" when matching, that must be done first before trying to match a fixed
character term later in the string.

Given the usefulness of the LEA instruction on X86 to create a single pointer value from a
base with index and offset, which the YARR JIT uses heavily, I added a new macroAssembler
function, getEffectiveAddress64(), with an ARM64 implementation. It just calls x86Lea64()
on X86-64. Also added an ImplicitAddress version of load16Unaligned().

(JSC::MacroAssemblerARM64::load16Unaligned):
(JSC::MacroAssemblerARM64::getEffectiveAddress64):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::load16Unaligned):
(JSC::MacroAssemblerX86Common::load16):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::getEffectiveAddress64):

  • create_regex_tables:
  • runtime/RegExp.cpp:

(JSC::RegExp::compile):

  • yarr/YarrInterpreter.cpp:
  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::optimizeAlternative):
(JSC::Yarr::YarrGenerator::matchCharacterClass):
(JSC::Yarr::YarrGenerator::tryReadUnicodeCharImpl):
(JSC::Yarr::YarrGenerator::tryReadUnicodeChar):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::generatePatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::generateTryReadUnicodeCharacterHelper):
(JSC::Yarr::YarrGenerator::generateEnter):
(JSC::Yarr::YarrGenerator::generateReturn):
(JSC::Yarr::YarrGenerator::YarrGenerator):
(JSC::Yarr::YarrGenerator::compile):

  • yarr/YarrJIT.h:
  • yarr/YarrPattern.cpp:

(JSC::Yarr::CharacterClassConstructor::CharacterClassConstructor):
(JSC::Yarr::CharacterClassConstructor::reset):
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::CharacterClassConstructor::addSorted):
(JSC::Yarr::CharacterClassConstructor::addSortedRange):
(JSC::Yarr::CharacterClassConstructor::hasNonBMPCharacters):
(JSC::Yarr::YarrPatternConstructor::setupAlternativeOffsets):

  • yarr/YarrPattern.h:

(JSC::Yarr::CharacterClass::CharacterClass):
(JSC::Yarr::BackTrackInfoPatternCharacter::beginIndex):
(JSC::Yarr::BackTrackInfoPatternCharacter::matchAmountIndex):
(JSC::Yarr::BackTrackInfoCharacterClass::beginIndex):
(JSC::Yarr::BackTrackInfoCharacterClass::matchAmountIndex):
(JSC::Yarr::BackTrackInfoBackReference::beginIndex):
(JSC::Yarr::BackTrackInfoBackReference::matchAmountIndex):
(JSC::Yarr::BackTrackInfoAlternative::offsetIndex):
(JSC::Yarr::BackTrackInfoParentheticalAssertion::beginIndex):
(JSC::Yarr::BackTrackInfoParenthesesOnce::beginIndex):
(JSC::Yarr::BackTrackInfoParenthesesTerminal::beginIndex):

LayoutTests:

Updated tests.

  • js/regexp-unicode-expected.txt:
  • js/script-tests/regexp-unicode.js:
2:54 PM Changeset in webkit [221051] by jfbastien@apple.com
  • 1 edit
    1873 adds in trunk/PerformanceTests

StitchMarker: threading, locking, and atomics benchmark

2:54 PM Changeset in webkit [221050] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

Correct SOUP and cURL builds after r221017.
https://bugs.webkit.org/show_bug.cgi?id=175846

Reviewed by Michael Catanzaro.

Correct the method signatures for 'cookiesForDOM' on the SOUP and cURL backends.
Note that these ports will need to add specific logic to find/filter secure cookies
if requested by the caller.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::CookieJarCurlFileSystem::cookiesForDOM):
(WebCore::cookiesForDOM):

  • platform/network/curl/CookieJarCurl.h:
  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookiesForDOM):

2:37 PM Changeset in webkit [221049] by webkit@devinrousso.com
  • 2 edits in trunk/Tools

Unreviewed, change my IRC nick.

  • Scripts/webkitpy/common/config/contributors.json:
2:31 PM Changeset in webkit [221048] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

[EnabledBySetting] in WebIDL uses Document but does not include Document.h
https://bugs.webkit.org/show_bug.cgi?id=175843

Reviewed by Sam Weinig.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

2:10 PM Changeset in webkit [221047] by Matt Lewis
  • 7 edits
    1 delete in trunk

Unreviewed, rolling out r221026.

This caused a consistent API failure on iOS Simulator.

Reverted changeset:

"Add UIDelegatePrivate SPI corresponding to
WKPageUIClient.showPage"
https://bugs.webkit.org/show_bug.cgi?id=175797
http://trac.webkit.org/changeset/221026

2:04 PM Changeset in webkit [221046] by jer.noble@apple.com
  • 12 edits in trunk/Source/WebCore

Refactor videoPerformanceQuality() MediaPlayer methods into single call.
https://bugs.webkit.org/show_bug.cgi?id=175830

Reviewed by Eric Carlson.

Allow MediaPlayerPrivate subclasses to return all the metrics required for VideoPerformanceQuality in
a single call. For clients which incur significant overhead to request this data, this reduces the cost
of requesting data by the number of calls removed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::videoPlaybackQualityMetrics):
(WebCore::MediaPlayer::totalVideoFrames): Deleted.
(WebCore::MediaPlayer::droppedVideoFrames): Deleted.
(WebCore::MediaPlayer::corruptedVideoFrames): Deleted.
(WebCore::MediaPlayer::totalFrameDelay): Deleted.

  • platform/graphics/MediaPlayer.h:

(WebCore::PlatformVideoPlaybackQualityMetrics::PlatformVideoPlaybackQualityMetrics):

  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::videoPlaybackQualityMetrics):
(WebCore::MediaPlayerPrivateInterface::totalVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateInterface::droppedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateInterface::corruptedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateInterface::totalFrameDelay): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::videoPlaybackQualityMetrics):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::droppedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::corruptedVideoFrames): Deleted.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::totalFrameDelay): Deleted.

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::videoPlaybackQualityMetrics):
(WebCore::MockMediaPlayerMediaSource::totalVideoFrames): Deleted.
(WebCore::MockMediaPlayerMediaSource::droppedVideoFrames): Deleted.
(WebCore::MockMediaPlayerMediaSource::corruptedVideoFrames): Deleted.
(WebCore::MockMediaPlayerMediaSource::totalFrameDelay): Deleted.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::videoPlaybackQualityMetrics):

  • platform/mock/mediasource/MockMediaSourcePrivate.h:
2:03 PM Changeset in webkit [221045] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Commit the change meant to be included in the previous commit.

  • Speedometer/resources/main.js:

(startBenchmark):

2:00 PM Changeset in webkit [221044] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Make it possible to change the iteration count via query string
https://bugs.webkit.org/show_bug.cgi?id=175811

Reviewed by Saam Barati.

Added the support for specifying the iteration count by "iterationCount" query parameter, and replaced "ms"
query parameter by "unit=ms".

Finally, reduced the number of iterations from 20 to 10 to reduce the time needed to run the benchmark
since Speedometer 2.0 contains more than twice the number of libraries and frameworks than Speedometer 1.0.

  • Speedometer/resources/main.js:

(window.benchmarkClient.didFinishLastIteration):
(startBenchmark):

1:53 PM Changeset in webkit [221043] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r221027.

This change caused LayoutTests to exit early with assertion
failures.

Reverted changeset:

"Add sanity check for source origin in
WebLoaderStrategy::startPingLoad()"
https://bugs.webkit.org/show_bug.cgi?id=175827
http://trac.webkit.org/changeset/221027

1:53 PM Changeset in webkit [221042] by commit-queue@webkit.org
  • 1 edit in trunk/PerformanceTests/ChangeLog

Speedometer: Add missing stylesheet to Angular example
https://bugs.webkit.org/show_bug.cgi?id=175820

Patch by Mathias Bynens <mathias@qiwi.be> on 2017-08-22
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/angular/dist/styles.d41d8cd98f00b204e980.bundle.css: Added.
1:48 PM Changeset in webkit [221041] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[WK2] Enable Beacon API by default
https://bugs.webkit.org/show_bug.cgi?id=175839

Reviewed by Youenn Fablet.

  • Shared/WebPreferencesDefinitions.h:
1:42 PM Changeset in webkit [221040] by Ryan Haddad
  • 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed test gardening. rdar://problem/33789505

  • platform/mac/TestExpectations:
1:42 PM Changeset in webkit [221039] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Speedometer 2.0: Add button to select and unselect all tests to InteractiveRunner.html
https://bugs.webkit.org/show_bug.cgi?id=175816

Reviewed by Saam Barati.

Added buttons to select and unselect all subtests to aid debugging.

  • Speedometer/InteractiveRunner.html:

(createUIForSuites):

1:19 PM Changeset in webkit [221038] by Brent Fulgham
  • 2 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix after r221017.

Correct copy/paste error.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookiesForDOM):

1:13 PM Changeset in webkit [221037] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Fix Windows build after r221017.
https://bugs.webkit.org/show_bug.cgi?id=157053

  • wtf/PlatformWin.cmake:
1:10 PM Changeset in webkit [221036] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

REGRESSION (High Sierra): PDFPlugin won't render PostScript Files
https://bugs.webkit.org/show_bug.cgi?id=175840
<rdar://problem/33877923>

Reviewed by Brent Fulgham.

  • WebProcess/com.apple.WebProcess.sb.in:

Add a sandbox exception for the PostScript conversion process.

1:09 PM Changeset in webkit [221035] by Brent Fulgham
  • 3 edits in trunk/Source/WebKitLegacy/win

Unreviewed build fix after r221017.

  • WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookiesForDOM): Update for new signature.

  • WebCoreSupport/WebPlatformStrategies.h:
12:56 PM Changeset in webkit [221034] by Brent Fulgham
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed test fix after r221017.

I forgot to check-in the expected result!

  • http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-expected.txt: Added.
12:54 PM Changeset in webkit [221033] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Ensure media controls host exists before using it
https://bugs.webkit.org/show_bug.cgi?id=175833
<rdar://problem/34001219>

Reviewed by Jer Noble.

Source/WebCore:

Although we ensure that the media controls shadow root exists before updating the text track
container, we don't check that the media controls host has been created yet. We do check
and create in other places in HTMLMediaElement.

Tests: media/track/track-display-before-controls-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateTextTrackDisplay):

LayoutTests:

  • media/track/track-display-before-controls-crash-expected.txt: Added.
  • media/track/track-display-before-controls-crash.html: Added.
12:22 PM Changeset in webkit [221032] by pvollan@apple.com
  • 5 edits in trunk/Source

Implement 64-bit MacroAssembler::probe support for Windows.
https://bugs.webkit.org/show_bug.cgi?id=175724

Reviewed by Mark Lam.

Source/JavaScriptCore:

This is needed to enable the DFG. MSVC does no longer support inline assembly
for 64-bit, which means we have to put the code in an asm file.

  • assembler/MacroAssemblerX86Common.cpp:

(JSC::booleanTrueForAvoidingNoReturnDeclaration): Deleted.

  • jit/JITStubsMSVC64.asm:

Source/WTF:

Enable masm probe and DFG.

  • wtf/Platform.h:
11:46 AM Changeset in webkit [221031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[Cache API] Optimize whitespace trimming in Vary header values
https://bugs.webkit.org/show_bug.cgi?id=175837

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-22
Reviewed by Alex Christensen.

No change of behavior.

Introducing a StringView version of stripLeadingAndTrailingHTTPSpaces.

  • Modules/cache/Cache.cpp:

(WebCore::hasResponseVaryStarHeaderValue):

  • platform/network/HTTPParsers.h:

(WebCore::stripLeadingAndTrailingHTTPSpaces):

11:45 AM Changeset in webkit [221030] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, beacon/contentextensions is only expected to work on Sierra+.

  • platform/mac-wk2/TestExpectations:
11:27 AM Changeset in webkit [221029] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Clean up PingLoad::processContentExtensionRulesForLoad()
https://bugs.webkit.org/show_bug.cgi?id=175834

Reviewed by Alex Christensen.

  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::processContentExtensionRulesForLoad):

  • NetworkProcess/PingLoad.h:
11:19 AM Changeset in webkit [221028] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Remove ChromeClient::scrollbarsModeDidChange
https://bugs.webkit.org/show_bug.cgi?id=175805

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-22
Reviewed by Daniel Bates.

Source/WebCore:

No change in behavior. It was never called, and no implementations did anything.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::scrollbarsModeDidChange const): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/HostWindow.h:

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.h:
11:16 AM Changeset in webkit [221027] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
https://bugs.webkit.org/show_bug.cgi?id=175827

Reviewed by Geoffrey Garen.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):

11:12 AM Changeset in webkit [221026] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk

Add UIDelegatePrivate SPI corresponding to WKPageUIClient.showPage
https://bugs.webkit.org/show_bug.cgi?id=175797
<rdar://problem/29270035>

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-22
Reviewed by Geoffrey Garen.

Source/WebKit:

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/Cocoa/UIDelegate.h:
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::showPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::registerURLSchemeHandler):
window.open, createWebViewWithConfiguration, and WKURLSchemeHandlers all used together
make it so that URLSchemeHandlers are added to WebPages that already have them. The
assertions are no longer valid.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/UIDelegate.mm: Added.

(-[UITestDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(-[UITestDelegate _showPage:]):
(-[UITestDelegate webView:startURLSchemeTask:]):
(-[UITestDelegate webView:stopURLSchemeTask:]):
(TEST):

11:08 AM Changeset in webkit [221025] by webkit@devinrousso.com
  • 15 edits
    1 copy
    2 adds in trunk

Web Inspector: provide way for ShaderPrograms to be enabled/disabled
https://bugs.webkit.org/show_bug.cgi?id=175400

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add setShaderProgramDisabled command that sets the disabled flag on the given shader
program to the supplied boolean value. If this value is true, calls to drawArrays and
drawElements when that program is in use will have no effect.

Source/WebCore:

Test: inspector/canvas/setShaderProgramDisabled.html

  • inspector/InspectorShaderProgram.h:

(WebCore::InspectorShaderProgram::disabled):
(WebCore::InspectorShaderProgram::setDisabled):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::drawArrays):
(WebCore::WebGLRenderingContextBase::drawElements):
If the current program is disabled, return early. This will prevent the current shader
program from drawing anything to the canvas.

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
(WebCore::InspectorCanvasAgent::isShaderProgramDisabled):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::isShaderProgramDisabled):
(WebCore::InspectorInstrumentation::isShaderProgramDisabledImpl):

Source/WebInspectorUI:

Adds a status element to ShaderProgramTreeElement that, when clicked, will toggle the
disabled state of the corresponding ShaderProgram. Disabled shader programs will not draw
anything to the context.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram):
(WI.ShaderProgram.prototype.get disabled):
(WI.ShaderProgram.prototype.toggleDisabled):

  • UserInterface/Views/ShaderProgramTreeElement.js:

(WI.ShaderProgramTreeElement):
(WI.ShaderProgramTreeElement.prototype.selectOnMouseDown):
(WI.ShaderProgramTreeElement.prototype._disabledImageElementClicked):

  • UserInterface/Views/ShaderProgramTreeElement.css: Added.

(.item.shader-program .status > img):
(.item.shader-program:not(:hover, .selected, .disabled) .status > img):
(.tree-outline:matches(:focus, .force-focus) .item.shader-program.selected .status > img):
(.item.shader-program.disabled > *):

LayoutTests:

  • inspector/canvas/setShaderProgramDisabled-expected.txt: Added.
  • inspector/canvas/setShaderProgramDisabled.html: Added.
11:02 AM Changeset in webkit [221024] by commit-queue@webkit.org
  • 15 edits
    6 adds in trunk

[Cache API] Add support for overwriting responses with put on an existing record
https://bugs.webkit.org/show_bug.cgi?id=175825

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-22
Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Tests: http/wpt/cache-storage/cache-put-keys.https.any.html

http/wpt/cache-storage/cache-put-keys.https.any.worker.html

Adding support for the new response update counter.
Overwriting local cached response with new retrieved response when the counter is different.
Adding support for passing this value from/to workers.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::queryCacheWithTargetStorage):
(WebCore::toConnectionRecord):
(WebCore::Cache::updateRecords):

  • Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::Record::copy const):

  • Modules/cache/CacheStorageConnection.h:
  • Modules/cache/CacheStorageRecord.h:
  • Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):

Source/WebKit:

Add support for encoding/decoding the update counter.
Incrementing it when overwriting an existing response.
Storing the new body in addition to the new response.

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorageEngine::putRecords):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

LayoutTests:

Adding update counter for response
Skipping new test on WK1.

  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • http/wpt/cache-storage/cache-put-keys.https.any-expected.txt: Added.
  • http/wpt/cache-storage/cache-put-keys.https.any.html: Added.
  • http/wpt/cache-storage/cache-put-keys.https.any.js: Added.

(cache_test):

  • http/wpt/cache-storage/cache-put-keys.https.any.worker-expected.txt: Added.
  • http/wpt/cache-storage/cache-put-keys.https.any.worker.html: Added.
10:56 AM Changeset in webkit [221023] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/fetch/http-cache/invalidate.html as flaky on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=173672

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:38 AM Changeset in webkit [221022] by achristensen@apple.com
  • 15 edits in trunk/Source

Remove ChromeClient::hasOpenedPopup
https://bugs.webkit.org/show_bug.cgi?id=175804

Reviewed by Sam Weinig.

Source/WebCore:

No change in behavior. All implementations just returned false.

  • loader/EmptyClients.h:
  • page/Chrome.cpp:

(WebCore::Chrome::hasOpenedPopup const): Deleted.

  • page/Chrome.h:
  • page/ChromeClient.h:
  • rendering/RenderMenuList.cpp:

(RenderMenuList::showPopup):

Source/WebKit:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::hasOpenedPopup const): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::hasOpenedPopup const): Deleted.

Source/WebKitLegacy/win:

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::hasOpenedPopup const): Deleted.

  • WebCoreSupport/WebChromeClient.h:
10:33 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
Adjust calendar format (diff)
10:31 AM Changeset in webkit [221021] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unriviewed, fix windows build... for realz.

  • CMakeLists.txt:
9:59 AM Changeset in webkit [221020] by aestes@apple.com
  • 10 edits in trunk

[Payment Request] Implement error checking for show(), abort(), and canMakePayment()
https://bugs.webkit.org/show_bug.cgi?id=175789

Reviewed by Brady Eidson.
LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:

Source/WebCore:

Implement many of the exceptions and promise rejections specified for PaymentRequest's
show(), abort(), and canMakePayment() methods. Also implement basic state tracking.

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create): Changed serializedMethodData from a
HashMap<String, String> to a Vector<PaymentRequest::Method>.
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::show): Added promise rejection for invalid state, updated the
state to Interactive, stored the promise in m_showPromise, and dispatched finishShowing().
(WebCore::PaymentRequest::finishShowing): Added JSON parsing of payment method serialized
data and exception propagation. If there are no exceptions, rejected m_showPromise with
NotSupportedError since we don't yet support any payment methods.
(WebCore::PaymentRequest::abort): Added promise rejection for invalid state and stored the
promise in m_abortPromise. Dispatched a lambda to update the state to Closed, reject
m_showPromise, and resolve m_abortPromise.
(WebCore::PaymentRequest::canMakePayment): Added promise rejection for invalid state and
stored the promise in m_canMakePaymentPromise. Dispatched a lambda to resolve
m_canMakePaymentPromise with false since we don't yet support any payment methods.

  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.idl: Annotated abort() with MayThrowException.

LayoutTests:

Stopped marking payment-request-abort-method.https.html and payment-request-show-method.https.html as flaky.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
9:29 AM Changeset in webkit [221019] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, enable http/wpt/beacon/contentextensions on Mac WK2 only.

It seems content extensions are not supported by WKTR on iOS.

9:28 AM Changeset in webkit [221018] by sbarati@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

We are using valueProfileForBytecodeOffset when there may not be a value profile
https://bugs.webkit.org/show_bug.cgi?id=175812

Reviewed by Michael Saboff.

This patch uses the type system to aid the code around CodeBlock's ValueProfile
accessor methods. valueProfileForBytecodeOffset used to return ValueProfile*,
so there were callers of this that thought it could return nullptr when there
was no such ValueProfile. This was not the case, it always returned a non-null
pointer. This patch changes valueProfileForBytecodeOffset to return ValueProfile&
and adds a new tryGetValueProfileForBytecodeOffset method that returns ValueProfile*
and does the right thing if there is no such ValueProfile.

This patch also changes the other ValueProfile accessors on CodeBlock to
return ValueProfile& instead of ValueProfile*. Some callers handled the null
case unnecessarily, and using the type system to specify the result can't be
null removes these useless branches.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC::CodeBlock::dumpValueProfiles):
(JSC::CodeBlock::tryGetValueProfileForBytecodeOffset):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::validate):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::valueProfileForArgument):
(JSC::CodeBlock::valueProfile):
(JSC::CodeBlock::valueProfilePredictionForBytecodeOffset):
(JSC::CodeBlock::getFromAllValueProfiles):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

  • dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

  • jit/JIT.h:
  • jit/JITInlines.h:

(JSC::JIT::emitValueProfilingSite):

  • profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::BytecodeSequence):

  • tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateJSCell):

9:22 AM Changeset in webkit [221017] by Brent Fulgham
  • 21 edits
    23 adds in trunk

Disable access to secure cookies if an HTTPS site loads mixed content
https://bugs.webkit.org/show_bug.cgi?id=157053
<rdar://problem/11290808>

Patch by Brent Fulgham <Brent Fulgham> and Pranjal Jumde <pjumde@apple.com> on 2017-08-22
Reviewed by Dan Bates.

Source/WebCore:

Tests: http/tests/security/mixedContent/insecure-css-with-secure-cookies.html

http/tests/security/mixedContent/insecure-image-with-securecookie-block.html
http/tests/security/mixedContent/insecure-image-with-securecookie.html
http/tests/security/mixedContent/insecure-script-with-secure-cookies.html
http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block.html
http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies.html

  • dom/SecurityContext.h:

(WebCore::SecurityContext::secureCookiesAccessed): Added.
(WebCore::SecurityContext::setSecureCookiesAccessed): Added.

  • loader/CookieJar.cpp:

(WebCore::cookies): Pass Document as non-const so we can call 'setSecureCookiesAccessed' if necessary.

  • loader/CookieJar.h:
  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::canRunInsecureContent): Updated checks to avoid running insecure content
if secure cookies were accessed.

  • platform/CookiesStrategy.h:

(WebCore::CookiesStrategy::cookiesForDOM): Pass new argument indicating whether secure cookies should be included in the response.

  • platform/network/PlatformCookieJar.h:
  • platform/network/cf/CookieJarCFNet.cpp:

(copyCookiesForURLWithFirstPartyURL): Revise to accept new 'IncludeSecureCookiesOrNot' argument.
(WebCore::cookiesForSession): Updated to accept new 'IncludeSecureCookiesOrNot' argument. Also determine if secure cookies were
included in the response, and return this to the caller.
(WebCore::cookieRequestHeaderFieldValue): Revise for new 'copyCookiesForURLWithFirstPartyURL' signature.
(WebCore::getRawCookies): Ditto.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesForSession): Updated checks to keep track of secure cookies and filter out secure cookies if insecure content
was accessed.
(WebCore::cookiesForDOM): Update for new arguments and to return a pair.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

Source/WebKit:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::cookiesForDOM): Pass new arguments needed by WebCore.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in: Updated the CookiesForDOM message with the new foundMixedContent

argument and the new didAccessSecureCookies reply.

  • Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Drive-by fix to use the right message.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
indicating whether secure cookies should be included in the response.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::cookiesForDOM): Check and return whether secure cookies were accessed. Accept a new argument
indicating whether secure cookies should be included in the response.

LayoutTests:

  • http/tests/security/mixedContent/insecure-css-with-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-css-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/insecure-executable-css-with-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie-block-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie-block.html: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-image-with-securecookie.html: Added.
  • http/tests/security/mixedContent/insecure-script-with-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/insecure-script-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block.html: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-expected.txt: Added.
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-css-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-executable-css-with-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-image-secure-cookie-block.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-image-secure-cookie.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-insecure-script-secure-cookies.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-image-secure-cookie-block.html: Added.
  • http/tests/security/mixedContent/resources/frame-with-redirect-https-to-http-image-secure-cookie.html: Added.
  • http/tests/security/mixedContent/resources/insecure-executable.css: Added.
  • http/tests/security/mixedContent/resources/insecure.css: Added.
  • http/tests/security/resources/greenbox-hotspot5-4.cur: Added.
9:13 AM Changeset in webkit [221016] by jer.noble@apple.com
  • 4 edits
    2 adds in trunk

Autoplay Muted Videos Don't Play When Outside Viewport
https://bugs.webkit.org/show_bug.cgi?id=175748
<rdar://problem/33974383>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-restricted-invisible-autoplay-not-allowed-source.html

The media session is notified that its client (the media element) will begin autoplaying inside
prepareForLoad(), where the m_autoplaying flag is also set. But loading via <source> elements does not go
through prepareForLoad(); the HTML standard states that the <source> element loading path does not trigger the
"media element load algorithm" which is implemented in prepareForLoad(). Since the m_autoplaying flag is
initially set to true, notify the media session that the element will begin autoplaying inside the element's
constructor.

Drive-by fix: Doing the above causes other tests to crash, as purturbing play state during style change can cause
re-entrancy in the native controls code, or fail, since we will transition from autoplay -> play even if there's
not yet a src or source to the media element. Add a task queue for updating the autoplay state and check the ready
state before allowing autoplay to transition to play.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::canTransitionFromAutoplayToPlay const):
(WebCore::HTMLMediaElement::isVisibleInViewportChanged):

LayoutTests:

  • media/video-restricted-invisible-autoplay-not-allowed-source-expected.txt: Added.
  • media/video-restricted-invisible-autoplay-not-allowed-source.html: Added.
9:03 AM Changeset in webkit [221015] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix windows build... maybe.

  • CMakeLists.txt:
8:56 AM Changeset in webkit [221014] by mrajca@apple.com
  • 6 edits
    2 adds in trunk

Call updateIsPlayingMedia whenever m_userHasInteractedWithMediaElement changes
https://bugs.webkit.org/show_bug.cgi?id=175796

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/video-user-gesture-tracking.html

The page media state depends on m_userHasInteractedWithMediaElement, so force it to update
as soon as m_userHasInteractedWithMediaElement changes. This fixes an issue where the media
state would not reflect the user interaction flag until a call to updateIsPlayingMedia was made.

  • dom/Document.cpp:

(WebCore::Document::noteUserInteractionWithMediaElement):

  • dom/Document.h:

(WebCore::Document::noteUserInteractionWithMediaElement): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::pageMediaState):

LayoutTests:

Skip the test on iOS like all the other tests that use runWithKeyDown.

  • media/video-user-gesture-tracking-expected.txt: Added.
  • media/video-user-gesture-tracking.html: Added.
8:54 AM Changeset in webkit [221013] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix cloop build.

8:50 AM Changeset in webkit [221012] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win][Release] Crash when running testmasm executable.
https://bugs.webkit.org/show_bug.cgi?id=175772

Reviewed by Mark Lam.

We need to save and restore the modified registers in case one or more registers are callee saved
on the relevant platforms.

  • assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):

8:46 AM Changeset in webkit [221011] by Jonathan Bedard
  • 2 edits in trunk/Tools

Fix leak-checking for iOS Simulators
https://bugs.webkit.org/show_bug.cgi?id=175735

Reviewed by David Kilzer.

Follow-up fix to r220942. _proc may be undefined.

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._wait_for_stop): Handle case where _proc is undefined.

7:44 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:43 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:42 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:41 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
7:41 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
6:47 AM Changeset in webkit [221010] by clopez@igalia.com
  • 3 edits in trunk/Tools

[GTK][WPE] install-dependencies should install the required gstreamer packages needed for production builds.
https://bugs.webkit.org/show_bug.cgi?id=175822

Reviewed by Xabier Rodriguez-Calvar.

  • gtk/install-dependencies: Add the bad plugins to the list.
  • wpe/install-dependencies: Add all the gst related packages (copied from GTK listing).
2:54 AM Changeset in webkit [221009] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r221006.
https://bugs.webkit.org/show_bug.cgi?id=175821

generates build failures in the bots (Requested by calvaris[m]
on #webkit).

Reverted changeset:

"[GStreamer][GTK][WPE] Move common things to GStreamer cmake
files"
https://bugs.webkit.org/show_bug.cgi?id=175625
http://trac.webkit.org/changeset/221006

2:51 AM Changeset in webkit [221008] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

GLContext: zero-initialize the GLContext pointer in ThreadGlobalGLContext
https://bugs.webkit.org/show_bug.cgi?id=175819

Reviewed by Xabier Rodriguez-Calvar.

  • platform/graphics/GLContext.cpp: The ThreadGlobalGLContext object is

allocated on heap, so the embedded GLContext pointer can contain a
non-null value that can cause problems when e.g. checking for a current
GLContext on some specific thread on which a GLContext hasn't yet been
made current. Zero-initializing this pointer will avoid false positives
that can occur in these circumstances.

2:13 AM Changeset in webkit [221007] by zandobersek@gmail.com
  • 3 edits
    2 adds
    1 delete in trunk/Source/WebKit

[GTK][WPE] Rename StorageProcessMainGtk.cpp to StorageProcessMainGLib.cpp
https://bugs.webkit.org/show_bug.cgi?id=175814

Reviewed by Gyuyoung Kim.

Both GTK+ and WPE ports already compile the StorageProcessMainGtk.cpp
file, but it should be renamed to StorageProcessMainGLib and moved into
the StorageProcess/glib/ directory.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • StorageProcess/glib/StorageProcessMainGLib.cpp: Renamed from Source/WebKit/StorageProcess/gtk/StorageProcessMainGtk.cpp.
1:44 AM Changeset in webkit [221006] by calvaris@igalia.com
  • 3 edits
    3 adds in trunk

[GStreamer][GTK][WPE] Move common things to GStreamer cmake files
https://bugs.webkit.org/show_bug.cgi?id=175625

Three files were created as kind of hooks for the GTK and WPE
CMake option files. The definitions one is to enable, disable and
create the common options (that can be and are actually overriden
in some cases. The dependencies one adds dependencies for the
option switches that are set. The checks one ensure the
dependencies are met depending on the option switches.

Reviewed by Žan Doberšek.

  • Source/cmake/GStreamerChecks.cmake: Added.
  • Source/cmake/GStreamerDefinitions.cmake: Added.
  • Source/cmake/GStreamerDependencies.cmake: Added.
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:

Aug 21, 2017:

11:31 PM Changeset in webkit [221005] by zandobersek@gmail.com
  • 9 edits in trunk/Source/WebKit

[WK] Add missing ENABLE(NETWORK_CACHE) build guards
https://bugs.webkit.org/show_bug.cgi?id=175769

Reviewed by Carlos Alberto Lopez Perez.

Given that the build guard exists, it should be possible to
compile the WebKit layer with the feature disabled. Missing
guards are added in order to achieve that.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::NetworkResourceLoader):

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::clearDiskCache):

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::storeDerivedDataToCache):

10:54 PM Changeset in webkit [221004] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220940. rdar://problem/33994308

9:57 PM Changeset in webkit [221003] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

[Follow up]: Add back the ability to disable MASM_PROBE from the build.
https://bugs.webkit.org/show_bug.cgi?id=175656
<rdar://problem/33933720>

Not reviewed.

Fixed a typo: should be "OS(WINDOWS)", not "OS(WINDOW)".

  • wtf/Platform.h:
9:41 PM Changeset in webkit [221002] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Change probe code to use static_assert instead of COMPILE_ASSERT.
https://bugs.webkit.org/show_bug.cgi?id=175762

Reviewed by JF Bastien.

  • assembler/MacroAssemblerARM.cpp:
  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe): Deleted.

  • assembler/MacroAssemblerARMv7.cpp:
  • assembler/MacroAssemblerX86Common.cpp:
9:12 PM Changeset in webkit [221001] by rniwa@webkit.org
  • 1 edit
    1 copy in trunk/Websites/browserbench.org

Merge the latest version of Speedometer 2.0 to browserbench.org

Rubber-stamped by Joseph Pecoraro.

  • Speedometer2.0: Replaced with PerformanceTests/Speedometer.
  • Speedometer2.0/resources/benchmark-runner.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/inline.b342d102ba4a53bf2002.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/main.779eb2f1ddbe23ac61c7.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/polyfills.2d45a4c73c85e24fe474.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/dist/vendor.b4be818cb6d8028f9192.bundle.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e/app.e2e-spec.ts: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e/app.po.ts: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angular/e2e/tsconfig.e2e.json: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css:
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers/global.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/config/environment.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/tests/.jshintrc: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/module-for-acceptance.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/start-app.js:
  • Speedometer2.0/resources/todomvc/architecture-examples/react-redux/dist/static/css/main.d43d2909.css: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/react-redux/dist/static/js/main.946269ff.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/css/app.677b45842d9f8b96e5b23c18969233b7.css: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/app.b0e835874bc8949670d1.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/manifest.84b2b4fceb74ab1f91f3.js: Removed.
  • Speedometer2.0/resources/todomvc/architecture-examples/vuejs-cli/dist/static/js/vendor.a52517c5aa98e7fbea2e.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.app.73bcc5d3c1d07180f0e3.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.manifest.112bf70a7f3deebf1f93.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/bundle.vendor.efaa3e0e20077c8e7471.js.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.app.73bcc5d3c1d07180f0e3.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/styles.vendor.efaa3e0e20077c8e7471.css.map: Removed.
  • Speedometer2.0/resources/todomvc/vanilla-examples/vanillajs/js/store.js:
8:19 PM Changeset in webkit [221000] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make generate_offset_extractor.rb architectures argument more robust
https://bugs.webkit.org/show_bug.cgi?id=175809

Reviewed by Joseph Pecoraro.

It turns out that some of our builders pass their architectures as
space separated lists. I decided to just make the splitting of
our list robust to any reasonable combination of spaces and
commas.

  • offlineasm/generate_offset_extractor.rb:
7:25 PM Changeset in webkit [220999] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Add Sony to domain affiliations on team page
https://bugs.webkit.org/show_bug.cgi?id=175806

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-21
Reviewed by Alex Christensen.

  • wp-content/themes/webkit/team.php:
7:03 PM Changeset in webkit [220998] by commit-queue@webkit.org
  • 9 edits in trunk

[Cache API] Add support for Cache.add/addAll
https://bugs.webkit.org/show_bug.cgi?id=175677

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-21
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Cache.addAll implementation is then as follow:

  • Fetch the resources in parallel.
  • Wait for all them to complete using FetchTaskCounter.
  • If an error happens in any load or if the response is not as expected for Cache API, reject the promise.
  • Call the batch put operation with all received FetchResponse objects.

FetchTaskCounter is responsible to wait for each response to arrive.
It then checks whether the response is fine,
If not, the addAll promise is rejected.
Otherwise, it waits for the body to be received.

Introducing a helper routine to create a FetchRequest from a given RequestInfo.
Introducing a helper routine to check for Vary Header '*' value in response headers.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::doMatch):
(WebCore::Cache::add):
(WebCore::queryCacheMatch):
(WebCore::hasResponseVaryStarHeaderValue):
(WebCore::FetchTaskCounter::FetchTaskCounter):
(WebCore::FetchTaskCounter::~FetchTaskCounter):
(WebCore::FetchTaskCounter::addRecord):
(WebCore::FetchTaskCounter::isDone const):
(WebCore::FetchTaskCounter::reject):
(WebCore::Cache::requestFromInfo):
(WebCore::Cache::addAll):
(WebCore::Cache::put):
(WebCore::Cache::remove):
(WebCore::Cache::keys):
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

  • Modules/cache/Cache.h:
6:50 PM Changeset in webkit [220997] by mmaxfield@apple.com
  • 5 edits in trunk

DataInteractionTests.ExternalSourceAttributedStringToContentEditable hits a debug assertion
https://bugs.webkit.org/show_bug.cgi?id=175787
<rdar://problem/33996612>

Reviewed by Wenson Hsieh.

Source/WebCore:

The variation axis values of San Francisco changed from the GX-style scale to the CSS-style
scale. Previously, we were normalizing the values we got from Core Text to fit the CSS scale;
however, this is no longer necessary since the font now does this itself.

The assertion was getting hit because the normalized values were huge and were overflowing
a single FontSelectionValue (and going negative). This patch adds handling for this
situation.

Test: DataInteractionTests.ExternalSourceBoldSystemAttributedStringToContentEditable

  • platform/graphics/FontSelectionAlgorithm.h: Typedef the backing type for a FontSelectionValue.

(WebCore::FontSelectionValue::rawValue const):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::FontSelectionValue):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Opt-out of normalization for San Francisco.

(WebCore::variationCapabilitiesForFontDescriptor):
(WebCore::capabilitiesForFontDescriptor):

Tools:

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

6:32 PM Changeset in webkit [220996] by Chris Dumez
  • 16 edits
    7 adds in trunk

[Beacon] Content extensions should be able to intercept Beacon / Ping redirects
https://bugs.webkit.org/show_bug.cgi?id=175746
<rdar://problem/33946050>

Reviewed by Alex Christensen.

Source/WebCore:

Update PingLoad to process content extension rules upon redirect. This allows content
extensions to block and upgrade to HTTPS beacon / ping loads.

Because ping loads can outlive the WebProcess, the content extensions rules are passed
to the NetworkProcess when starting the Ping load. The PingLoad can then consult those
rules upon redirect, on the NetworkProcess side.

Tests: http/wpt/beacon/contentextensions/beacon-blocked.html

http/wpt/beacon/contentextensions/beacon-redirect-blocked.html

  • contentextensions/ContentExtensionActions.h:
  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::forEach):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForPingLoad):

  • contentextensions/ContentExtensionsBackend.h:
  • page/Page.h:
  • page/UserContentProvider.cpp:

(WebCore::UserContentProvider::forEachContentExtension):

  • page/UserContentProvider.h:

Source/WebKit:

Update PingLoad to process content extension rules upon redirect. This allows content
extensions to block and upgrade to HTTPS beacon / ping loads.

Because ping loads can outlive the WebProcess, the content extensions rules are passed
to the NetworkProcess when starting the Ping load. The PingLoad can then consult those
rules upon redirect, on the NetworkProcess side.

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentExtensionsBackend):
(WebKit::PingLoad::processContentExtensionRulesForLoad):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):

LayoutTests:

Add layout test coverage for blocking beacon loads via content extensions.

  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt:
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html:
  • http/wpt/beacon/contentextensions/beacon-blocked-expected.txt: Added.
  • http/wpt/beacon/contentextensions/beacon-blocked.html: Added.
  • http/wpt/beacon/contentextensions/beacon-blocked.html.json: Added.
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked-expected.txt: Added.
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked.html: Added.
  • http/wpt/beacon/contentextensions/beacon-redirect-blocked.html.json: Added.
6:14 PM Changeset in webkit [220995] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE][GTK] Unused variables in UserMediaProcessManager.cpp
https://bugs.webkit.org/show_bug.cgi?id=175799

Reviewed by Alex Christensen.

The code which uses the "audioExtensionPath" and "videoExtensionPath" variables is guarded
with "#if ENABLE(SANDBOX_EXTENSIONS)”, so do the same for the variables themselves.

  • UIProcess/UserMediaProcessManager.cpp: Add missing guards.
6:07 PM Changeset in webkit [220994] by keith_miller@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Only generate offline asm for the ARCHS (xcodebuild) or the current system (CMake)
https://bugs.webkit.org/show_bug.cgi?id=175690

Reviewed by Michael Saboff.

This should reduce some of the time we spend building offline asm
in our builds (except for linux since they already did this).

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • offlineasm/backends.rb:
  • offlineasm/generate_offset_extractor.rb:
6:07 PM Changeset in webkit [220993] by clopez@igalia.com
  • 2 edits in trunk/Source/WTF

[GTK] ARMv7 build fails to build MacroAssemblerARMv7.cpp.
https://bugs.webkit.org/show_bug.cgi?id=175514

Reviewed by Keith Miller.

  • wtf/Platform.h: Enable DFG and MASM_PROBE back for GTK ARM_THUMB2.
5:23 PM Changeset in webkit [220992] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: !m_connections.contains(&connection) in WebCore::SWServer::unregisterConnection(WebCore::SWServer::Connection&).
https://bugs.webkit.org/show_bug.cgi?id=175795

Rubber-stamped by Andy Estes.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::unregisterConnection): Flip the ASSERT to be... correct.

4:39 PM Changeset in webkit [220991] by mmaxfield@apple.com
  • 2 edits in trunk/Tools

Typo in "webkit-patch land"
https://bugs.webkit.org/show_bug.cgi?id=175788

Reviewed by Tim Horton.

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._commit_warning):

4:31 PM Changeset in webkit [220990] by Ryan Haddad
  • 3 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed, land test updates for rdar://problem/34000704.

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
4:31 PM Changeset in webkit [220989] by Ryan Haddad
  • 3 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed, land test updates for rdar://problem/34000704.

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
4:21 PM Changeset in webkit [220988] by dbates@webkit.org
  • 5 edits in trunk/Source/WebCore

Cleanup TextPainter
https://bugs.webkit.org/show_bug.cgi?id=175782

Reviewed by Myles C. Maxfield.

Remove redundant mention of "text" in the name of TextPainter member functions, add separate
setters for selection and non-selection shadows, and do some other minor cleanups.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Update code for renamed functions.

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Ditto.

  • rendering/TextPainter.cpp: Include ShadowData.h.

(WebCore::ShadowApplier::ShadowApplier): Use C++11 brace-initialization syntax.
(WebCore::ShadowApplier::isLastShadowIteration): Moved from TextPainter.h.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.
(WebCore::TextPainter::paintTextOrEmphasisMarks): Renamed; formerly named drawTextOrEmphasisMarks.
(WebCore::TextPainter::paintTextWithShadows): Update code for renamed functions.
(WebCore::TextPainter::paintRange): Renamed; formerly named paintTextInRange.
(WebCore::TextPainter::paint): Renamed; formerly named paintText.
(WebCore::TextPainter::drawTextOrEmphasisMarks): Renamed to paintTextOrEmphasisMarks() to match
the naming convention of all the other paint functions in this class.
(WebCore::TextPainter::paintTextInRange): Renamed to paintRange.
(WebCore::TextPainter::paintText): Renamed to paint.

  • rendering/TextPainter.h: Forward declare ShadowData.

(WebCore::TextPainter::setStyle): Renamed; formerly named setTextPaintStyle.
(WebCore::TextPainter::setSelectionStyle): Renamed; formerly named setSelectionPaintStyle.
(WebCore::TextPainter::setShadow): Added.
(WebCore::TextPainter::setSelectionShadow): Added.
(WebCore::TextPainter::setEmphasisMark): Renamed; formerly named addEmphasis.
(WebCore::TextPainter::setTextPaintStyle): Renamed to setStyle.
(WebCore::TextPainter::setSelectionPaintStyle): Renamed to setSelectionStyle.
(WebCore::TextPainter::addEmphasis): Renamed to setEmphasisMark.
(WebCore::TextPainter::addTextShadow): Split functionality into setShadow and setSelectionShadow.
(WebCore::ShadowApplier::isLastShadowIteration): Moved to TextPainter.cpp.
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText): Ditto.

4:15 PM Changeset in webkit [220987] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Fixed expectations.

Unreviewed test expectations.

  • platform/mac/TestExpectations:
4:04 PM Changeset in webkit [220986] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments after r220725
https://bugs.webkit.org/show_bug.cgi?id=175382

Reviewed by Darin Adler.

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setUnicodeRange):

3:17 PM Changeset in webkit [220985] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/LayoutTests

Stop media/video-controls-toggling.html from timing out.
https://bugs.webkit.org/show_bug.cgi?id=116266

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21
Reviewed by Dean Jackson.

Use getComputedStyle to check the display property. Element::style only
contains properties set in the style attribute, but the display property
is set through CSS using the 'hidden' class.

  • media/video-controls-toggling-expected.txt:
  • media/video-controls-toggling.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/media/video-controls-toggling-expected.txt: Copied from LayoutTests/media/video-controls-toggling-expected.txt. I'm not sure where the console message comes from, but it seems to be in the GTK-specific code.
2:58 PM Changeset in webkit [220984] by commit-queue@webkit.org
  • 13 edits in trunk

[Cache API] Add support for CacheStorage.match
https://bugs.webkit.org/show_bug.cgi?id=175747

Patch by Youenn Fablet <youenn@apple.com> on 2017-08-21
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

Introducing Cache::doMatch so that CacheStorage can use it.
Make Cache::match use Cache::doMatch as well.

Implementing CacheStorage.match as per spec:

  • If name is provided, query only the cache with the given name.
  • Otherwise pick the first matching response in the caches.

The sequential asynchronous search is done in doSequentialMatch.

Making sure that response with a status code are returning false to isNull.
This allows passing more tests.

  • Modules/cache/Cache.cpp:

(WebCore::Cache::match):
(WebCore::Cache::doMatch):
(WebCore::Cache::matchAll):
(WebCore::toConnectionRecord):

  • Modules/cache/Cache.h:
  • Modules/cache/CacheStorage.cpp:

(WebCore::doSequentialMatch):
(WebCore::copyCaches):
(WebCore::CacheStorage::match):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setHTTPStatusCode):

2:51 PM Changeset in webkit [220983] by dino@apple.com
  • 3 edits
    2 adds in trunk

Persistent WebGL Warning "vertex WARNING: 0:1: extension 'GL_ARB_gpu_shader5' is not supported" in Safari 10.1.2
https://bugs.webkit.org/show_bug.cgi?id=175783
<rdar://problem/33623867>

Reviewed by Alex Christensen.

Source/WebCore:

The version of ANGLE we use inserts this line into each shader:
It causes our lower-level GLSL compiler to give a warning, which is
confusing to developers because they didn't write this code.

Until we upgrade our OpenGL support to version 4.1, we should remove
this error message from the log returned to the developer.
See https://bugs.webkit.org/show_bug.cgi?id=175785

Test: fast/canvas/webgl/no-info-log-for-simple-shaders.html

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getUnmangledInfoLog): Search for and remove
this warning.

LayoutTests:

  • fast/canvas/webgl/no-info-log-for-simple-shaders-expected.txt: Added.
  • fast/canvas/webgl/no-info-log-for-simple-shaders.html: Added.
2:10 PM Changeset in webkit [220982] by weinig@apple.com
  • 4 edits in trunk

StringView could use a function to strip leading/trailing characters without allocation
https://bugs.webkit.org/show_bug.cgi?id=175757

Reviewed by Darin Adler.

Source/WTF:

There are many places in WebCore/WebKit that we call functions like,
WebCore::stripLeadingAndTrailingHTMLSpaces, or String::stripWhiteSpace() only to use
the allocated String as a temporary for either another transformation or a comparison.
Now that we have StringView, we can avoid that extra allocation, by having returning a
StringView substring in these scenarios.

For instance, the check (from ScriptElement.cpp:287):

if (!stripLeadingAndTrailingHTMLSpaces(sourceURL).isEmpty()) {

...

}

currently allocates a string just to make this check. With a new
stripLeadingAndTrailingHTMLSpaces such as:

StringView stripLeadingAndTrailingHTMLSpaces(StringView stringView)
{

return stringView.stripLeadingAndTrailingMatchedCharacters([] (auto c) {

return isHTMLSpace(c);

});

}

We could instead have exact same code from ScriptElement.cpp now avoid an allocation.

  • wtf/text/StringView.h:

(WTF::StringView::stripLeadingAndTrailingMatchedCharacters):

Tools:

  • TestWebKitAPI/Tests/WTF/StringView.cpp:

Add tests for StringView::stripLeadingAndTrailingMatchedCharacters().

1:55 PM Changeset in webkit [220981] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked svg/animations/smil-leak-list-property-instances.svg as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=174218

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
1:53 PM Changeset in webkit [220980] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[Payment Request] Use ExistingExceptionError to propagate JS exceptions thrown during JSON stringification
https://bugs.webkit.org/show_bug.cgi?id=175776

Reviewed by Darin Adler.

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::create):

  • Modules/paymentrequest/PaymentRequest.h:
1:35 PM Changeset in webkit [220979] by commit-queue@webkit.org
  • 59 edits
    25 copies
    1 add
    1 delete in trunk

[PAL] Move spi/mac directory into PAL
https://bugs.webkit.org/show_bug.cgi?id=175649

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-21
Reviewed by Myles C. Maxfield.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/DataDetection.mm:
  • editing/mac/DictionaryLookup.h:
  • editing/mac/DictionaryLookup.mm:
  • page/mac/ServicesOverlayController.mm:
  • page/mac/WheelEventDeltaFilterMac.mm:
  • page/scrolling/mac/ScrollingMomentumCalculatorMac.mm:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:
  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/mac/MediaTimeQTKit.h:
  • platform/mac/MediaRemoteSoftLink.cpp:
  • platform/mac/MediaRemoteSoftLink.h:
  • platform/mac/PasteboardWriter.mm:
  • platform/mac/PlatformEventFactoryMac.mm:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/VideoFullscreenInterfaceMac.mm:
  • platform/mac/WebVideoFullscreenController.mm:
  • rendering/RenderThemeMac.mm:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/spi/mac/AVFoundationSPI.h: Renamed from Source/WebCore/platform/spi/mac/AVFoundationSPI.h.
  • pal/spi/mac/DataDetectorsSPI.h: Renamed from Source/WebCore/platform/spi/mac/DataDetectorsSPI.h.
  • pal/spi/mac/LookupSPI.h: Renamed from Source/WebCore/platform/spi/mac/LookupSPI.h.
  • pal/spi/mac/MediaRemoteSPI.h: Renamed from Source/WebCore/platform/spi/mac/MediaRemoteSPI.h.
  • pal/spi/mac/NSAccessibilitySPI.h: Renamed from Source/WebCore/platform/spi/mac/NSAccessibilitySPI.h.
  • pal/spi/mac/NSApplicationSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSApplicationSPI.h.
  • pal/spi/mac/NSEventSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSEventSPI.h.
  • pal/spi/mac/NSFontSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSFontSPI.h.
  • pal/spi/mac/NSImmediateActionGestureRecognizerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h.
  • pal/spi/mac/NSMenuSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSMenuSPI.h.
  • pal/spi/mac/NSPasteboardSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSPasteboardSPI.h.
  • pal/spi/mac/NSPopoverSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSPopoverSPI.h.
  • pal/spi/mac/NSScrollerImpSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollerImpSPI.h.
  • pal/spi/mac/NSScrollingInputFilterSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollingInputFilterSPI.h.
  • pal/spi/mac/NSScrollingMomentumCalculatorSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSScrollingMomentumCalculatorSPI.h.
  • pal/spi/mac/NSSharingServicePickerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSharingServicePickerSPI.h.
  • pal/spi/mac/NSSharingServiceSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSharingServiceSPI.h.
  • pal/spi/mac/NSSpellCheckerSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSSpellCheckerSPI.h.
  • pal/spi/mac/NSTextFinderSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSTextFinderSPI.h.
  • pal/spi/mac/NSViewSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSViewSPI.h.
  • pal/spi/mac/NSWindowSPI.h: Renamed from Source/WebCore/platform/spi/mac/NSWindowSPI.h.
  • pal/spi/mac/PIPSPI.h: Renamed from Source/WebCore/platform/spi/mac/PIPSPI.h.
  • pal/spi/mac/QTKitSPI.h: Renamed from Source/WebCore/platform/spi/mac/QTKitSPI.h.
  • pal/spi/mac/QuickLookMacSPI.h: Renamed from Source/WebCore/platform/spi/mac/QuickLookMacSPI.h.
  • pal/spi/mac/TUCallSPI.h: Renamed from Source/WebCore/platform/spi/mac/TUCallSPI.h.

Source/WebKit:

  • Platform/mac/MenuUtilities.mm:
  • Shared/mac/WebCoreArgumentCodersMac.mm:
  • Shared/mac/WebEventFactory.mm:
  • Shared/mac/WebHitTestResultData.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/Cocoa/WebViewImpl.mm:
  • UIProcess/mac/ServicesController.mm:
  • UIProcess/mac/TextCheckerMac.mm:
  • UIProcess/mac/ViewGestureControllerMac.mm:
  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:
  • UIProcess/mac/WKSharingServicePickerDelegate.mm:
  • UIProcess/mac/WKTextFinderClient.mm:
  • UIProcess/mac/WebContextMenuProxyMac.mm:
  • UIProcess/mac/WebPageProxyMac.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/mac:

  • Misc/WebSharingServicePickerController.h:
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebEditorClient.mm:
  • WebCoreSupport/WebSelectionServiceController.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:
  • WebView/WebView.mm:

Tools:

  • TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1:16 PM Changeset in webkit [220978] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GTK][WPE][GSTREAMER_GL] Overriden virtual function not marked “override” in MediaPlayerPrivateGStreamerBase.h
https://bugs.webkit.org/show_bug.cgi?id=175780

Reviewed by Konstantin Tokarev.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h: Add missing "override" qualifier.
1:02 PM Changeset in webkit [220977] by beidson@apple.com
  • 19 edits
    5 copies
    3 moves
    1 add in trunk/Source

Split the one SWServer::Connection into SWClientConnection and SWServer::Connection.
https://bugs.webkit.org/show_bug.cgi?id=175745

Reviewed by Andy Estes.

Source/WebCore:

No new tests (No behavior change).

Each of these has a much different environment that it lives in, so being the same object
hinders clean development.

This split will also make it easier for the WebCore objects to directly handle WK2 messages.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/Logging.h:
  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):

  • workers/service/ServiceWorkerContainer.h:
  • workers/service/ServiceWorkerProvider.h:
  • workers/service/server/SWClientConnection.cpp: Copied from Source/WebCore/workers/service/server/SWServer.cpp.

(WebCore::SWClientConnection::SWClientConnection):
(WebCore::SWClientConnection::~SWClientConnection):
(WebCore::SWClientConnection::scheduleJob):
(WebCore::SWClientConnection::jobRejectedInServer):

  • workers/service/server/SWClientConnection.h: Copied from Source/WebCore/workers/service/server/SWServer.h.
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::Connection::Connection):
(WebCore::SWServer::Connection::~Connection):
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::Connection::scheduleJobInServer):
(WebCore::SWServer::scheduleJob):
(WebCore::SWServer::registerConnection):
(WebCore::SWServer::unregisterConnection):
(WebCore::SWServer::Connection::scheduleJob): Deleted.
(WebCore::SWServer::Connection::jobRejected): Deleted.

  • workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::server):
(WebCore::SWServer::Connection::~Connection): Deleted.

Source/WebKit:

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebKit.xcodeproj/project.pbxproj:
  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp: Renamed from Source/WebKit/WebProcess/Storage/WebSWServerConnection.cpp.

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::disconnectedFromWebProcess):
(WebKit::WebSWServerConnection::rejectJobInClient):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h: Copied from Source/WebKit/WebProcess/Storage/WebSWServerConnection.h.

(WebKit::WebSWServerConnection::identifier const):

  • StorageProcess/ServiceWorker/WebSWServerConnection.messages.in: Copied from Source/WebKit/WebProcess/Storage/WebSWServerConnection.messages.in.
  • StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):

  • StorageProcess/StorageToWebProcessConnection.h:
  • WebProcess/Storage/WebSWClientConnection.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.

(WebKit::WebSWClientConnection::WebSWClientConnection):
(WebKit::WebSWClientConnection::~WebSWClientConnection):
(WebKit::WebSWClientConnection::scheduleJobInServer):

  • WebProcess/Storage/WebSWClientConnection.h: Renamed from Source/WebKit/WebProcess/Storage/WebSWServerConnection.h.

(WebKit::WebSWClientConnection::identifier const):

  • WebProcess/Storage/WebSWClientConnection.messages.in: Renamed from Source/WebKit/WebProcess/Storage/WebSWServerConnection.messages.in.
  • WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):

  • WebProcess/Storage/WebServiceWorkerProvider.h:
  • WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

  • WebProcess/Storage/WebToStorageProcessConnection.h:
12:54 PM Changeset in webkit [220976] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.3.1/Source

Versioning.

12:50 PM Changeset in webkit [220975] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.3.1

New tag.

12:06 PM Changeset in webkit [220974] by commit-queue@webkit.org
  • 4 edits
    1 copy in trunk/LayoutTests

Re-enable tests based on media-fullscreen.js for GTK.
https://bugs.webkit.org/show_bug.cgi?id=175770

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21
Reviewed by Eric Carlson.

The media-fullscreen-not-in-document test checks that a disconnected
element can go fullscreen, while the code explicitly disallows that
(in Document::requestFullScreenForElement). Update the test to match
the code.

The media-fullscreen-inline test will now fail more clearly if the
attempt to go fullscreen is rejected (which it isn't).

  • media/media-fullscreen-not-in-document-expected.txt: rebaseline.
  • media/media-fullscreen.js:

(fullscreenerror): pass the test if the webkitfullscreenerror
(addEventListeners): add a webkitfullscreenerror event handler

  • platform/gtk/TestExpectations: remove failure expectations.
  • platform/gtk/media/media-fullscreen-not-in-document-expected.txt: Copied from LayoutTests/media/media-fullscreen-not-in-document-expected.txt. This copy leaves out the webkitSupportsPresentationMode check that's disabled on GTK.
11:45 AM Changeset in webkit [220973] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Can't copy text from "View variable value" popover in Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=175758

Reviewed by Matt Baker.

  • UserInterface/Views/InlineSwatch.js:

(WI.InlineSwatch.prototype._swatchElementClicked):
Change CodeMirror readOnly from "nocursor" to true. The former prevents the editor from
being focused during selection, therefore preventing the content from being copied.

11:15 AM Changeset in webkit [220972] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked inspector/css/add-rule.html as flaky on macOS
https://bugs.webkit.org/show_bug.cgi?id=173560

Unreviewed test gardening.

  • platform/mac/TestExpectations:
10:41 AM Changeset in webkit [220971] by aestes@apple.com
  • 9 edits in trunk

[Payment Request] Implement the PaymentRequest constructor
https://bugs.webkit.org/show_bug.cgi?id=175755

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-id.https-expected.txt:

Source/WebCore:

  • Modules/paymentrequest/PaymentDetailsModifier.h: Changed total to an std::optional<PaymentItem>.
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::isWellFormedCurrencyCode): Implements the IsWellFormedCurrencyCode abstract operation from ECMA 402.
(WebCore::isValidDecimalMonetaryValue): Implements the "valid decimal monetary value" validity checker.
(WebCore::checkAndCanonicalizeAmount): Implements the "check and canonicalize amount" validity checker.
(WebCore::checkAndCanonicalizeTotal): Implements the "check and canonicalize total" validity checker.
(WebCore::PaymentRequest::create): Implements the PaymentRequest Constructor
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::id const): Implements the PaymentRequest id attribute.
(WebCore::PaymentRequest::shippingType const): Implements the PaymentRequest shippingType attribute.

  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.idl: Annotated PaymentRequest with ConstructorMayThrowException.
  • WebCore.xcodeproj/project.pbxproj:
10:21 AM Changeset in webkit [220970] by pvollan@apple.com
  • 4 edits in trunk

[Win] DRT should only allow any https certificate for localhost.
https://bugs.webkit.org/show_bug.cgi?id=175147

Reviewed by Brent Fulgham.

Source/WebCore:

Disabling validation of certificate chains, breaks SSL on Windows. In order
for SSL tests to succeed on Windows, we should avoid disabling it.

No new tests, covered by existing tests.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):

Tools:

Add check to make sure only localhost requests allow any https certificate.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

10:00 AM Changeset in webkit [220969] by Matt Lewis
  • 5 edits in trunk/LayoutTests

Rebaselined js/dom/global-constructors-attributes.html on macOS.

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:45 AM Changeset in webkit [220968] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip imported/w3c/web-platform-tests/payment-request/payment-request-constructor-crash.https.html.
https://bugs.webkit.org/show_bug.cgi?id=175773

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:36 AM Changeset in webkit [220967] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[GTK][WPE] Rebaseline tests with list item markers.
https://bugs.webkit.org/show_bug.cgi?id=175771

Unreviewed test gardening.

The output was changed in r220858 and rebaselined for ios and mac only.
They're changes in render tree dumps that don't affect rendering.

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21

  • platform/gtk/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/gtk/fast/doctypes/002-expected.txt:
  • platform/gtk/fast/lists/marker-before-empty-inline-expected.txt:
  • platform/wpe/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
9:30 AM Changeset in webkit [220966] by eric.carlson@apple.com
  • 2 edits in trunk/Tools

Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Unreviewed build fix.

  • TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::LoggingTest::output): Disable testing output by default because it
fails on some of the bots.

8:44 AM Changeset in webkit [220965] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

media-captions.html improvements
https://bugs.webkit.org/show_bug.cgi?id=175768

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-21
Reviewed by Eric Carlson.

  • media/media-captions.html: remove reference to unused script file.
  • platform/gtk/TestExpectations: remove Timeout, Crash annotations.
6:03 AM Changeset in webkit [220964] by eric.carlson@apple.com
  • 7 edits
    1 add in trunk

Add WTFLogChannel level to allow runtime log filtering
https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/MemoryPressureHandler.cpp:
  • wtf/RefCountedLeakCounter.cpp:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.

(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

5:59 AM Changeset in webkit [220963] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

MemoryCache::setCapacities assertion failure maxDeadBytes <= totalBytes
https://bugs.webkit.org/show_bug.cgi?id=175571

Patch by Charlie Turner <cturner@igalia.com> on 2017-08-21
Reviewed by Antti Koivisto.

  • Shared/CacheModel.cpp:

(WebKit::calculateMemoryCacheSizes): Ensure cacheTotalCapacity is
set to a reasonable value even in low-memory environments.

5:56 AM Changeset in webkit [220962] by zandobersek@gmail.com
  • 9 edits in trunk/Source/WebCore

[EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary'
https://bugs.webkit.org/show_bug.cgi?id=175761

Reviewed by Xabier Rodriguez-Calvar.

Add initial and incomplete implementations of the 'Attempt to Decrypt' and
'Attempt to Resume Playback If Necessary' algorithms. The implementations
are interleaved with the specification text for clarity.

'Attempt to Decrypt' implementation doesn't yet address the encrypted block
queue or the 'decryption blocked waiting for key' flag since it's not yet
clear whether it would make more sense for this state to reside lower, in
the platform layer. The gist of the algorithm is to invoke the decryption
attempt through the MediaPlayer object, passing along the CDMInstance object
retrieved from the MediaKeys object that is associated with this media
element.

'Attempt to Resume Playback if Necessary' implementation similarly for now
omits the various state flag operations. The main task at this point is to
dispatch the 'Attempt to Decrypt' algorithm.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() method now
invokes the attemptToResumePlaybackIfNecessary() method.

MediaKeys::hasOpenSessions() is introduced, returning true if any session
that was created through this MediaKeys instance is still open. This allows
the 'Attempt to Decrypt' algorithm to proceed with the decryption attempt
dispatch into the MediaPlayer hierarchy.

For that, the MediaPlayer::attemptToDecryptWithInstance() method is added,
which simply dispatches the mirror method on MediaPlayerPrivate interface.
This will enable the platform-layer implementations to use the passed-in
CDMInstance object for decryption purposes.

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::hasOpenSessions const):

  • Modules/encryptedmedia/MediaKeys.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::attemptToDecrypt):
(WebCore::HTMLMediaElement::attemptToResumePlaybackIfNecessary):
(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):

  • html/HTMLMediaElement.h: Mark cdmClientAttemptToResumePlaybackIfNecessary() as final.
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::attemptToDecryptWithInstance):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::attemptToDecryptWithInstance):

1:28 AM Changeset in webkit [220961] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Remove some old flaky crash expectations.
https://bugs.webkit.org/show_bug.cgi?id=108682

Unreviewed test gardening.

Patch by Ms2ger <Ms2ger@gmail.com> on 2017-08-21

  • platform/gtk/TestExpectations:

Aug 20, 2017:

11:56 PM Changeset in webkit [220960] by mark.lam@apple.com
  • 7 edits in trunk/Source

Gardening: fix CLoop build.
https://bugs.webkit.org/show_bug.cgi?id=175688
<rdar://problem/33436870>

Not reviewed.

Source/JavaScriptCore:

Make these files dependent on ENABLE(MASM_PROBE).

  • assembler/ProbeContext.cpp:
  • assembler/ProbeContext.h:
  • assembler/ProbeStack.cpp:
  • assembler/ProbeStack.h:

Source/WTF:

Disable MASM_PROBE if !ENABLE(JIT).

  • wtf/Platform.h:
11:21 PM Changeset in webkit [220959] by zandobersek@gmail.com
  • 9 edits in trunk

[EME] Add basic implementation of HTMLMediaElement::setMediaKeys()
https://bugs.webkit.org/show_bug.cgi?id=175717

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Add an initial and incomplete implementation of HTMLMediaElement::setMediaKeys(),
interleaved with the specification wording of how this operation should behave.
The implementation still doesn't cover cases of CDM instances being already
associated with a different HTMLMediaElement, of CDM instances that can't be
disassociated from the current HTMLMediaElement, and of failures during both
association and disassociation of MediaKeys with the HTMLMediaElement.

The HTMLMediaElement (as a CDMClient inheritor) has to be attached or detached
from the MediaKeys object as appropriate. This attachment allows MediaKeys to
initiate an attempt to resume playback whenever the key statuses of the
associated MediaKeys object are updated.

Upon association and disassociation with MediaKeys, the CDMInstance object of
that specific MediaKeys instance is attached to or detached from the MediaPlayer
instance. This allows the platform layer to gather information about the
CDMInstance that will be used for decryption of media content for this specific
media element.

Additionally, the detachment from both MediaKeys and MediaPlayer is done upon
HTMLMediaElement destruction.

Upon setting the MediaKeys object, a task is queued that launches the 'Attempt to
Resume Playback If Necessary' algorithm. A placeholder method is added that will
implement the algorithm in the future.

The HTMLMediaElement::mediaKeys() getter is also implemented, returning pointer
held in m_mediaKeys.

Covered to a degree by existing imported W3C tests, with a setMediaKeys()-oriented
test having WPE-specific baseline update.

  • Modules/encryptedmedia/MediaKeys.h:

(WebCore::MediaKeys::cdmInstance const):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::mediaKeys const):
(WebCore::HTMLMediaElement::setMediaKeys):
(WebCore::HTMLMediaElement::attemptToResumePlaybackIfNecessary):
(WebCore::HTMLMediaElement::contextDestroyed):

  • html/HTMLMediaElement.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::cdmInstanceAttached):
(WebCore::MediaPlayer::cdmInstanceDetached):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateInterface::cdmInstanceDetached):

LayoutTests:

  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-expected.txt:

Update the baseline, with the test no longer timing out but instead
failing with a NotAllowed exception thrown.

9:26 PM Changeset in webkit [220958] by mark.lam@apple.com
  • 17 edits
    4 adds in trunk/Source/JavaScriptCore

Enhance MacroAssembler::probe() to allow the probe function to resize the stack frame and alter stack data in one pass.
https://bugs.webkit.org/show_bug.cgi?id=175688
<rdar://problem/33436870>

Reviewed by JF Bastien.

With this patch, the clients of the MacroAssembler::probe() can now change
stack values without having to worry about whether there is enough room in the
current stack frame for it or not. This is done using the Probe::Context's stack
member like so:

jit.probe([] (Probe::Context& context) {

auto cpu = context.cpu;
auto stack = context.stack();
uintptr_t* currentSP = cpu.sp<uintptr_t*>();

Get a value at the current stack pointer location.
auto value = stack.get<uintptr_t>(currentSP);

Set a value above the current stack pointer (within current frame).
stack.set<uintptr_t>(currentSP + 10, value);

Set a value below the current stack pointer (out of current frame).
stack.set<uintptr_t>(currentSP - 10, value);

Set the new stack pointer.
cpu.sp() = currentSP - 20;

});

What happens behind the scene:

  1. the generated JIT probe code will now call Probe::executeProbe(), and Probe::executeProbe() will in turn call the client's probe function.

Probe::executeProbe() receives the Probe::State on the machine stack passed
to it by the probe trampoline. Probe::executeProbe() will instantiate a
Probe::Context to be passed to the client's probe function. The client will
no longer see the Probe::State directly.

  1. The Probe::Context comes with a Probe::Stack which serves as a manager of stack pages. Currently, each page is 1K in size. Probe::Context::stack() returns a reference to an instance of Probe::Stack.
  1. Invoking get() of set() on Probe::Stack with an address will lead to the following:
  1. the address will be decoded to a baseAddress that points to the 1K page that contains that address.
  1. the Probe::Stack will check if it already has a cached 1K page for that baseAddress. If so, go to step (f). Else, continue with step (c).
  1. the Probe::Stack will malloc a 1K mirror page, and memcpy the 1K stack page for that specified baseAddress to this mirror page.
  1. the mirror page will be added to the ProbeStack's m_pages HashMap, keyed on the baseAddress.
  1. the ProbeStack will also cache the last baseAddress and its corresponding mirror page in use. With memory accesses tending to be localized, this will save us from having to look up the page in the HashMap.
  1. get() will map the requested address to a physical address in the mirror page, and return the value at that location.
  1. set() will map the requested address to a physical address in the mirror page, and set the value at that location in the mirror page.

set() will also set a dirty bit corresponding to the "cache line" that
was modified in the mirror page.

  1. When the client's probe function returns, Probe::executeProbe() will check if there are stack changes that need to be applied. If stack changes are needed:
  1. Probe::executeProbe() will adjust the stack pointer to ensure enough stack space is available to flush the dirty stack pages. It will also register a flushStackDirtyPages callback function in the Probe::State. Thereafter, Probe::executeProbe() returns to the probe trampoline.
  1. the probe trampoline adjusts the stack pointer, moves the Probe::State to a safe place if needed, and then calls the flushStackDirtyPages callback if needed.
  1. the flushStackDirtyPages() callback iterates the Probe::Stack's m_pages HashMap and flush all dirty "cache lines" to the machine stack. Thereafter, flushStackDirtyPages() returns to the probe trampoline.
  1. lastly, the probe trampoline will restore all register values and return to the pc set in the Probe::State.

To make this patch work, I also had to do the following work:

  1. Refactor MacroAssembler::CPUState into Probe::CPUState. Mainly, this means moving the code over to ProbeContext.h. I also added some convenience accessor methods for spr registers.

Moved Probe::Context over to its own file ProbeContext.h/cpp.

  1. Fix all probe trampolines to pass the address of Probe::executeProbe in addition to the client's probe function and arg.

I also took this opportunity to optimize the generated JIT probe code to
minimize the amount of memory stores needed.

  1. Simplified the ARM64 probe trampoline. The ARM64 probe only supports changing either lr or pc (or neither), but not both at in the same probe invocation. The ARM64 probe trampoline used to have to check for this invariant in the assembly trampoline code. With the introduction of Probe::executeProbe(), we can now do it there and simplify the trampoline.
  1. Fix a bug in the old ARM64 probe trampoline for the case where the client changes lr. That code path never worked before, but has now been fixed.
  1. Removed trustedImm32FromPtr() helper functions in MacroAssemblerARM and MacroAssemblerARMv7.

We can now use move() with TrustedImmPtr, and it does the same thing but in a
more generic way.

  1. ARMv7's move() emitter may encode a T1 move instruction, which happens to have

the same semantics as movs (according to the Thumb spec). This means these
instructions may trash the APSR flags before we have a chance to preserve them.

This patch changes MacroAssemblerARMv7's probe() to preserve the APSR register
early on. This entails adding support for the mrs instruction in the
ARMv7Assembler.

  1. Change testmasm's testProbeModifiesStackValues() to now modify stack values

the easy way.

Also fixed testmasm tests which check flag registers to only compare the
portions that are modifiable by the client i.e. some masking is applied.

This patch has passed the testmasm tests on x86, x86_64, arm64, and armv7.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::mrs):

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::CPUState::gprName): Deleted.
(JSC::MacroAssembler::CPUState::sprName): Deleted.
(JSC::MacroAssembler::CPUState::fprName): Deleted.
(JSC::MacroAssembler::CPUState::gpr): Deleted.
(JSC::MacroAssembler::CPUState::spr): Deleted.
(JSC::MacroAssembler::CPUState::fpr): Deleted.
(JSC:: const): Deleted.
(JSC::MacroAssembler::CPUState::fpr const): Deleted.
(JSC::MacroAssembler::CPUState::pc): Deleted.
(JSC::MacroAssembler::CPUState::fp): Deleted.
(JSC::MacroAssembler::CPUState::sp): Deleted.
(JSC::MacroAssembler::CPUState::pc const): Deleted.
(JSC::MacroAssembler::CPUState::fp const): Deleted.
(JSC::MacroAssembler::CPUState::sp const): Deleted.
(JSC::Probe::State::gpr): Deleted.
(JSC::Probe::State::spr): Deleted.
(JSC::Probe::State::fpr): Deleted.
(JSC::Probe::State::gprName): Deleted.
(JSC::Probe::State::sprName): Deleted.
(JSC::Probe::State::fprName): Deleted.
(JSC::Probe::State::pc): Deleted.
(JSC::Probe::State::fp): Deleted.
(JSC::Probe::State::sp): Deleted.

  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr): Deleted.

  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):
(JSC::arm64ProbeError): Deleted.

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::armV7Condition):
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr): Deleted.

  • assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:

(JSC::ctiMasmProbeTrampoline):
(JSC::MacroAssembler::probe):

  • assembler/Printer.h:

(JSC::Printer::Context::Context):

  • assembler/ProbeContext.cpp: Added.

(JSC::Probe::executeProbe):
(JSC::Probe::handleProbeStackInitialization):
(JSC::Probe::probeStateForContext):

  • assembler/ProbeContext.h: Added.

(JSC::Probe::CPUState::gprName):
(JSC::Probe::CPUState::sprName):
(JSC::Probe::CPUState::fprName):
(JSC::Probe::CPUState::gpr):
(JSC::Probe::CPUState::spr):
(JSC::Probe::CPUState::fpr):
(JSC::Probe:: const):
(JSC::Probe::CPUState::fpr const):
(JSC::Probe::CPUState::pc):
(JSC::Probe::CPUState::fp):
(JSC::Probe::CPUState::sp):
(JSC::Probe::CPUState::pc const):
(JSC::Probe::CPUState::fp const):
(JSC::Probe::CPUState::sp const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe::Context::stack):
(JSC::Probe::Context::hasWritesToFlush):
(JSC::Probe::Context::releaseStack):

  • assembler/ProbeStack.cpp: Added.

(JSC::Probe::Page::Page):
(JSC::Probe::Page::flushWrites):
(JSC::Probe::Stack::Stack):
(JSC::Probe::Stack::hasWritesToFlush):
(JSC::Probe::Stack::flushWrites):
(JSC::Probe::Stack::ensurePageFor):

  • assembler/ProbeStack.h: Added.

(JSC::Probe::Page::baseAddressFor):
(JSC::Probe::Page::chunkAddressFor):
(JSC::Probe::Page::baseAddress):
(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::hasWritesToFlush const):
(JSC::Probe::Page::flushWritesIfNeeded):
(JSC::Probe::Page::dirtyBitFor):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::Stack):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):
(JSC::Probe::Stack::newStackPointer const):
(JSC::Probe::Stack::setNewStackPointer):
(JSC::Probe::Stack::isValid):
(JSC::Probe::Stack::pageFor):

  • assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::testProbeModifiesStackValues):
(JSC::run):
(): Deleted.
(JSC::fillStack): Deleted.
(JSC::testProbeModifiesStackWithCallback): Deleted.

4:11 PM Changeset in webkit [220957] by Chris Dumez
  • 12 edits in trunk/Source

Simplify calls to LoaderStrategy::startPingLoad()
https://bugs.webkit.org/show_bug.cgi?id=175756

Reviewed by Sam Weinig.

Source/WebCore:

Simplify calls to LoaderStrategy::startPingLoad() by passing the Frame to it
and let its implementation gets what it needs from the frame. This reduces
the number of parameters to startPingLoad() and is more easily extensible.

  • dom/Document.h:
  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

Source/WebKit:

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::startPingLoad):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

  • WebCoreSupport/WebResourceLoadScheduler.h:
2:42 AM Changeset in webkit [220956] by Antti Koivisto
  • 7 edits
    2 adds in trunk/Source/WebCore

Factor :before/:after render tree mutations into a RenderTreeUpdater helper class
https://bugs.webkit.org/show_bug.cgi?id=175752

Reviewed by Andreas Kling.

Move code that constructs generated content renderers out from PseudoElement.
Also refactor the related code from RenderTreeUpdater main class into
RenderTreeUpdater::GeneratedContent helper class.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/PseudoElement.cpp:

(WebCore::PseudoElement::resolveCustomStyle): Deleted.

Not needed anymore.

(WebCore::PseudoElement::didAttachRenderers): Deleted.

Moves to createContentRenderers in GeneratedContent.

(WebCore::PseudoElement::didRecalcStyle): Deleted.

Moves to updateStyleForContentRenderers in GeneratedContent.

  • dom/PseudoElement.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::RenderTreeUpdater):
(WebCore::RenderTreeUpdater::~RenderTreeUpdater):
(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::needsPseudoElement): Deleted.
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement): Deleted.
(WebCore::RenderTreeUpdater::updateQuotesUpTo): Deleted.

Quotes and other :before/:after support moves to GeneratedContent helpwe.

  • style/RenderTreeUpdater.h:

(WebCore::RenderTreeUpdater::generatedContent):

  • style/RenderTreeUpdaterGeneratedContent.cpp: Added.

(WebCore::RenderTreeUpdater::GeneratedContent::GeneratedContent):
(WebCore::RenderTreeUpdater::GeneratedContent::updateBeforePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateAfterPseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::updateRemainingQuotes):
(WebCore::RenderTreeUpdater::GeneratedContent::updateQuotesUpTo):
(WebCore::createContentRenderers):
(WebCore::updateStyleForContentRenderers):
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
(WebCore::RenderTreeUpdater::GeneratedContent::needsPseudoElement):

  • style/RenderTreeUpdaterGeneratedContent.h: Added.

Aug 19, 2017:

7:11 PM Changeset in webkit [220955] by aestes@apple.com
  • 30 edits
    36 adds in trunk

[Payment Request] Add interface stubs
https://bugs.webkit.org/show_bug.cgi?id=175730

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt:
  • web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt:
  • web-platform-tests/payment-request/historical.https-expected.txt:
  • web-platform-tests/payment-request/interfaces.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-id.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-in-iframe-expected.txt:
  • web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:
  • web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt:
  • web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt:

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Source/WebCore:

  • DerivedSources.make:
  • Modules/paymentrequest/PaymentAddress.h: Added.
  • Modules/paymentrequest/PaymentAddress.idl: Added.
  • Modules/paymentrequest/PaymentComplete.h: Added.
  • Modules/paymentrequest/PaymentComplete.idl: Added.
  • Modules/paymentrequest/PaymentCurrencyAmount.h: Added.
  • Modules/paymentrequest/PaymentCurrencyAmount.idl: Added.
  • Modules/paymentrequest/PaymentDetailsBase.h: Added.
  • Modules/paymentrequest/PaymentDetailsBase.idl: Added.
  • Modules/paymentrequest/PaymentDetailsInit.h: Added.
  • Modules/paymentrequest/PaymentDetailsInit.idl: Added.
  • Modules/paymentrequest/PaymentDetailsModifier.h: Added.
  • Modules/paymentrequest/PaymentDetailsModifier.idl: Added.
  • Modules/paymentrequest/PaymentDetailsUpdate.h: Added.
  • Modules/paymentrequest/PaymentDetailsUpdate.idl: Added.
  • Modules/paymentrequest/PaymentItem.h: Added.
  • Modules/paymentrequest/PaymentItem.idl: Added.
  • Modules/paymentrequest/PaymentMethodData.h: Added.
  • Modules/paymentrequest/PaymentMethodData.idl: Added.
  • Modules/paymentrequest/PaymentOptions.h: Added.
  • Modules/paymentrequest/PaymentOptions.idl: Added.
  • Modules/paymentrequest/PaymentRequest.cpp: Added.

(WebCore::PaymentRequest::create):
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::abort):
(WebCore::PaymentRequest::canMakePayment):

  • Modules/paymentrequest/PaymentRequest.h: Added.
  • Modules/paymentrequest/PaymentRequest.idl: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEvent.cpp: Added.

(WebCore::PaymentRequestUpdateEvent::~PaymentRequestUpdateEvent):
(WebCore::PaymentRequestUpdateEvent::updateWith):

  • Modules/paymentrequest/PaymentRequestUpdateEvent.h: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEvent.idl: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEventInit.h: Added.
  • Modules/paymentrequest/PaymentRequestUpdateEventInit.idl: Added.
  • Modules/paymentrequest/PaymentResponse.cpp: Added.

(WebCore::PaymentResponse::complete):

  • Modules/paymentrequest/PaymentResponse.h: Added.
  • Modules/paymentrequest/PaymentResponse.idl: Added.
  • Modules/paymentrequest/PaymentShippingOption.h: Added.
  • Modules/paymentrequest/PaymentShippingOption.idl: Added.
  • Modules/paymentrequest/PaymentShippingType.h: Added.
  • Modules/paymentrequest/PaymentShippingType.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventNames.in:
  • dom/EventTargetFactory.in:

LayoutTests:

  • TestExpectations: Skipped payment-request tests.
  • platform/ios-wk2/TestExpectations: Enabled payment-request tests on ios-wk2.
  • platform/mac-wk2/TestExpectations: Ditto for mac-wk2.
10:28 AM Changeset in webkit [220954] by commit-queue@webkit.org
  • 15 edits in trunk/Source/WebCore

[WebCrypto] Remove the KeyAlgorithm type hierarchy
https://bugs.webkit.org/show_bug.cgi?id=175750

Patch by Sam Weinig <sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Removes the unnecessary indirection that existed to generate a
KeyAlgorithm dictionary (or rather, one of its derived dictionaries)
for a CryptoKey. We were calling the virtual buildAlgorithm(), which
return a std::unique_ptr<KeyAlgorithm>, which we then casted to the
correct derived class and called dictionary() on. This can now be
simplified by making each CryptoKey derived class override a function
that returns the KeyAlgorithm variant.

  • crypto/CryptoKey.cpp:

(WebCore::CryptoKey::algorithm const): Deleted.

  • crypto/CryptoKey.h:

(WebCore::CryptoKey::extractable const):
(WebCore::KeyAlgorithm::~KeyAlgorithm): Deleted.
(WebCore::KeyAlgorithm::name const): Deleted.
(WebCore::KeyAlgorithm::KeyAlgorithm): Deleted.

  • crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::algorithm const):
(WebCore::AesKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyAES::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::algorithm const):
(WebCore::EcKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyEC::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyEC.h:

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm): Deleted.
(WebCore::EcKeyAlgorithm::namedCurve const): Deleted.

  • crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::algorithm const):
(WebCore::HmacKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyHMAC::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.cpp:

(WebCore::RsaKeyAlgorithm::dictionary const): Deleted.
(WebCore::RsaHashedKeyAlgorithm::dictionary const): Deleted.

  • crypto/keys/CryptoKeyRSA.h:

(WebCore::RsaKeyAlgorithm::RsaKeyAlgorithm): Deleted.
(WebCore::RsaKeyAlgorithm::modulusLength const): Deleted.
(WebCore::RsaKeyAlgorithm::publicExponent const): Deleted.

  • crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::algorithm const):
(WebCore::RawKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyRaw::buildAlgorithm const): Deleted.

  • crypto/keys/CryptoKeyRaw.h:

(WebCore::RawKeyAlgorithm::RawKeyAlgorithm): Deleted.

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

9:41 AM Changeset in webkit [220953] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Mac] Change uint8_t* to Vector<uint8_t> type in all crypto algorithm implementation
https://bugs.webkit.org/show_bug.cgi?id=164939

Patch by Sam Weinig <sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Address FIXMEs, replacing uint8_t*/size_t parameters with Vector<uint8_t>&.

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

  • crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::wrapKeyAES_KW):
(WebCore::unwrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

  • crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::encryptRSAES_PKCS1_v1_5):
(WebCore::decryptRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

  • crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::signRSASSA_PKCS1_v1_5):
(WebCore::verifyRSASSA_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

  • crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::encryptRSA_OAEP):
(WebCore::decryptRSA_OAEP):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

1:46 AM Changeset in webkit [220952] by wenson_hsieh@apple.com
  • 2 edits in trunk/Tools

[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
https://bugs.webkit.org/show_bug.cgi?id=175509
<rdar://problem/33728169>

Reviewed by Ryosuke Niwa.

Removes ExternalSourceAttributedStringToContentEditable and adds
ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
other style attribute, such as color, carries over from the NSAttributedString to the DOM.

Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

Note: See TracTimeline for information about the timeline view.