Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Sep 10, 2017:

11:53 PM Changeset in webkit [221850] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Drop libgcrypt initialization in webkit_media_clear_key_decrypt_init()
​https://bugs.webkit.org/show_bug.cgi?id=176656

Reviewed by Michael Catanzaro.

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_init): Don't re-initialize libgcrypt here
since that's already done in the WebProcess main(), and the calls here
only result in libgcrypt writing out 'Oops' warnings on stderr.

11:23 PM Changeset in webkit [221849] by mark.lam@apple.com

• 72 edits in trunk/Source

Fix all ExceptionScope verification failures in JavaScriptCore.
​https://bugs.webkit.org/show_bug.cgi?id=176662
<rdar://problem/34352085>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

1. Introduced EXCEPTION_ASSERT macros so that we can enable exception scope verification for release builds too (though this requires manually setting ENABLE_EXCEPTION_SCOPE_VERIFICATION to 1 in Platform.h).

This is useful because it allows us to run the tests more quickly to check
if any regressions have occurred. Debug builds run so much slower and not
good for a quick turn around. Debug builds are necessary though to get
trace information without inlining by the C++ compiler. This is necessary to
diagnose where the missing exception check is.

2. Repurposed the JSC_dumpSimulatedThrows=true options to capture and dump the last simulated throw when an exception scope verification fails.

Previously, this option dumps the stack trace on all simulated throws. That
turned out to not be very useful, and slows down the debugging process.
Instead, the new implementation captures the stack trace and only dumps it
if we have a verification failure.

3. Fixed missing exception checks and book-keeping needed to allow the JSC tests to pass with JSC_validateExceptionChecks=true.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::executeOSRExit):

• dfg/DFGOperations.cpp:
• interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::loadVarargs):
(JSC::Interpreter::unwind):
(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):

• jit/JITOperations.cpp:

(JSC::getByVal):

• jsc.cpp:

(WTF::CustomGetter::customGetterAcessor):
(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderResolve):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getByVal):
(JSC::LLInt::setUpCall):

• parser/Parser.h:

(JSC::Parser::popScopeInternal):

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::hostResolveImportedModule):
(JSC::AbstractModuleRecord::resolveImport):
(JSC::AbstractModuleRecord::resolveExportImpl):
(JSC::getExportedNames):
(JSC::AbstractModuleRecord::getModuleNamespace):

• runtime/ArrayPrototype.cpp:

(JSC::getProperty):
(JSC::unshift):
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
(JSC::arrayProtoFuncJoin):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncPush):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncShift):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoFuncSplice):
(JSC::arrayProtoFuncUnShift):
(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):
(JSC::concatAppendOne):
(JSC::arrayProtoPrivateFuncConcatMemcpy):
(JSC::arrayProtoPrivateFuncAppendMemcpy):

• runtime/CatchScope.h:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncSetTime):
(JSC::setNewValueFromTimeArgs):

• runtime/DirectArguments.h:

(JSC::DirectArguments::length const):

• runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

• runtime/ExceptionFuzz.cpp:

(JSC::doExceptionFuzzing):

• runtime/ExceptionScope.h:

(JSC::ExceptionScope::needExceptionCheck):
(JSC::ExceptionScope::assertNoException):

• runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::defineOwnProperty):

• runtime/HashMapImpl.h:

(JSC::HashMapImpl::rehash):

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::formatToParts):

• runtime/JSArray.cpp:

(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):
(JSC::JSValue::putToPrimitiveByIndex):

• runtime/JSCJSValueInlines.h:

(JSC::JSValue::toIndex const):
(JSC::JSValue::get const):
(JSC::JSValue::getPropertySlot const):
(JSC::JSValue::equalSlowCaseInline):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewFromIterator):
(JSC::constructGenericTypedArrayViewWithArguments):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::set):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::put):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::globalFuncEval):
(JSC::globalFuncProtoGetter):
(JSC::globalFuncProtoSetter):
(JSC::globalFuncImportModule):

• runtime/JSInternalPromise.cpp:

(JSC::JSInternalPromise::then):

• runtime/JSInternalPromiseDeferred.cpp:

(JSC::JSInternalPromiseDeferred::create):

• runtime/JSJob.cpp:

(JSC::JSJobMicrotask::run):

• runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::getOwnPropertySlot):
(JSC::JSModuleEnvironment::put):
(JSC::JSModuleEnvironment::deleteProperty):

• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::provide):
(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::requestImportModule):

• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::link):
(JSC::JSModuleRecord::instantiateDeclarations):

• runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):
(JSC::Stringifier::toJSON):
(JSC::JSONProtoFuncParse):

• runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):
(JSC::ordinarySetSlow):
(JSC::JSObject::putInlineSlow):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::toPrimitive const):
(JSC::JSObject::hasInstance):
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::toNumber const):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::validateAndApplyPropertyDescriptor):
(JSC::JSObject::defineOwnNonIndexProperty):
(JSC::JSObject::getGenericPropertyNames):

• runtime/JSObject.h:

(JSC::JSObject::get const):

• runtime/JSObjectInlines.h:

(JSC::JSObject::getPropertySlot const):
(JSC::JSObject::getPropertySlot):
(JSC::JSObject::getNonIndexPropertySlot):
(JSC::JSObject::putInlineForJSObject):

• runtime/JSPromiseConstructor.cpp:

(JSC::constructPromise):

• runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::create):

• runtime/JSScope.cpp:

(JSC::abstractAccess):
(JSC::JSScope::resolve):
(JSC::JSScope::resolveScopeForHoistingFuncDeclInEval):
(JSC::JSScope::abstractResolve):

• runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::tryJSONPParse):
(JSC::LiteralParser<CharType>::parse):

• runtime/Lookup.h:

(JSC::putEntry):

• runtime/MapConstructor.cpp:

(JSC::constructMap):

• runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToString):

• runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyDescriptors):
(JSC::objectConstructorAssign):
(JSC::objectConstructorValues):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::defineProperties):
(JSC::objectConstructorDefineProperties):
(JSC::ownPropertyKeys):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncHasOwnProperty):
(JSC::objectProtoFuncIsPrototypeOf):
(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):
(JSC::objectProtoFuncToLocaleString):
(JSC::objectProtoFuncToString):

• runtime/Options.h:
• runtime/ParseInt.h:

(JSC::toStringView):

• runtime/ProxyObject.cpp:

(JSC::performProxyGet):
(JSC::ProxyObject::performPut):

• runtime/ReflectObject.cpp:

(JSC::reflectObjectDefineProperty):

• runtime/RegExpConstructor.cpp:

(JSC::toFlags):
(JSC::regExpCreate):
(JSC::constructRegExp):

• runtime/RegExpObject.cpp:

(JSC::collectMatches):

• runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::execInline):
(JSC::RegExpObject::matchInline):

• runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncTestFast):
(JSC::regExpProtoFuncExec):
(JSC::regExpProtoFuncMatchFast):
(JSC::regExpProtoFuncToString):
(JSC::regExpProtoFuncSplitFast):

• runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl):

• runtime/SetConstructor.cpp:

(JSC::constructSet):

• runtime/ThrowScope.cpp:

(JSC::ThrowScope::simulateThrow):

• runtime/VM.cpp:

(JSC::VM::verifyExceptionCheckNeedIsSatisfied):

• runtime/VM.h:
• runtime/WeakMapPrototype.cpp:

(JSC::protoFuncWeakMapSet):

• runtime/WeakSetPrototype.cpp:

(JSC::protoFuncWeakSetAdd):

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::createModule):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

• wasm/js/WebAssemblyPrototype.cpp:

(JSC::reject):
(JSC::webAssemblyCompileFunc):
(JSC::resolve):
(JSC::webAssemblyInstantiateFunc):

Source/WebCore:

No new tests because this is covered by existing tests with the JSC_validateExceptionChecks=true enabled.

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::tryToConstructCustomElement):

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::whenDefinedPromise):

• bindings/js/JSDOMConvertRecord.h:
• bindings/js/JSDOMMapLike.cpp:

(WebCore::createBackingMap):

• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::reject):

• bindings/js/JSDOMPromiseDeferred.h:

(WebCore::callPromiseFunction):

11:16 PM Changeset in webkit [221848] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.18

Merge r221847 - REGRESSION: [GTK] Generated HTML API documentation is missing descriptions
​https://bugs.webkit.org/show_bug.cgi?id=176667

Reviewed by Michael Catanzaro.

Source/WebKit:

Fix several typos in API documentation.

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_class_init):

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

Tools:

This is happening since we moved the implementation files to glib dirs. The generate-gtkdoc script assumes that
header and implementation files are always in the same directory. To reduce the input we pass to gtk-doc we
ignore cpp files for which there isn't a public header. The code to do this check doesn't consider cpp files in
a different directory than the header file. It also assumes that header and cpp files have the same filename
except for the extension, which is true in all cases but WebKitWebView that we have two files WebKitWebView.cpp
and WebKitWebViewGtk.cpp.

• gtk/generate-gtkdoc:

(files_to_ignore): Check also cpp files with the Gtk suffix.
(files_to_ignore.add_file_if_exists): Check if a file with the given name exists in any of the source dirs.

11:14 PM Changeset in webkit [221847] by Carlos Garcia Campos

• 7 edits in trunk

REGRESSION: [GTK] Generated HTML API documentation is missing descriptions
​https://bugs.webkit.org/show_bug.cgi?id=176667

Reviewed by Michael Catanzaro.

Source/WebKit:

Fix several typos in API documentation.

• UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkit_web_view_class_init):

• UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:

Tools:

This is happening since we moved the implementation files to glib dirs. The generate-gtkdoc script assumes that
header and implementation files are always in the same directory. To reduce the input we pass to gtk-doc we
ignore cpp files for which there isn't a public header. The code to do this check doesn't consider cpp files in
a different directory than the header file. It also assumes that header and cpp files have the same filename
except for the extension, which is true in all cases but WebKitWebView that we have two files WebKitWebView.cpp
and WebKitWebViewGtk.cpp.

• gtk/generate-gtkdoc:

(files_to_ignore): Check also cpp files with the Gtk suffix.
(files_to_ignore.add_file_if_exists): Check if a file with the given name exists in any of the source dirs.

10:59 PM Changeset in webkit [221846] by jmarcell@apple.com

• 1 copy in branches/safari-604.2-branch

New Branch.

10:50 PM Changeset in webkit [221845] by fred.wang@free.fr

• 2 edits in trunk/Source/WebCore

Make RenderLayerCompositor always use isRootLayer()
​https://bugs.webkit.org/show_bug.cgi?id=176591

Patch by Frederic Wang <​fwang@igalia.coml> on 2017-09-10
Reviewed by Darin Adler.

RenderLayerCompositor contains a few comparisons of the form &layer == m_renderView.layer().
This patch replaces them with "layer.isRootLayer()" which simply verifies that "layer" is
associated to the one (and only one) RenderView of the RenderLayerCompositor. It makes things
more readable and more consistent with the rest of the file.

No new tests, behavior unchanged.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::repaintInCompositedAncestor):
(WebCore::RenderLayerCompositor::needsFixedRootBackgroundLayer const):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

9:49 PM Changeset in webkit [221844] by Matt Baker

• 6 edits
  19 adds in trunk/Source/WebInspectorUI

Web Inspector: change style of RecordingNavigationSidebarPanel
​https://bugs.webkit.org/show_bug.cgi?id=175451
<rdar://problem/34040769>

Reviewed by Devin Rousso.

This patch adds UI polish to the Canvas recording navigation sidebar:

• New icons for Canvas2D operations
• Removed extraneous colors: zebra striping, frame element background color
• Visual action color changed to match details sidebar "changed" color
• Make tree item indent a convenient multiple of the base indent
• Move RecordingActionTreeElement styles to a separate file

• UserInterface/Images/Clip.svg: Added.
• UserInterface/Images/Composite.svg: Added.
• UserInterface/Images/Fill.svg: Added.
• UserInterface/Images/LineStyle.svg: Added.
• UserInterface/Images/Palette.svg: Added.
• UserInterface/Images/PathArc.svg: Added.
• UserInterface/Images/PathCurve.svg: Added.
• UserInterface/Images/PathEllipse.svg: Added.
• UserInterface/Images/PathLineTo.svg: Added.
• UserInterface/Images/PathMoveTo.svg: Added.
• UserInterface/Images/PathRect.svg: Added.
• UserInterface/Images/Pixels.svg: Added.
• UserInterface/Images/PointInPath.svg: Added.
• UserInterface/Images/PointInStroke.svg: Added.
• UserInterface/Images/Shadow.svg: Added.
• UserInterface/Images/Stroke.svg: Added.
• UserInterface/Images/Text.svg: Added.
• UserInterface/Images/Transform.svg: Added.

New icons for Canvas2D operations.

• UserInterface/Main.html:

New file.

• UserInterface/Views/GeneralTreeElement.js:

(WI.GeneralTreeElement.prototype.customTitleTooltip):
(WI.GeneralTreeElement.prototype._updateTitleTooltip):
Allow derived classes to supply a custom tooltip, when
simply getting the title element text is insufficient.

• UserInterface/Views/RecordingActionTreeElement.css: Added.

(.item.action.initial-state > .icon):
(.tree-outline:not(:focus, .force-focus) .item.action:not(.initial-state, .parent, .invalid) > .icon):
(.item.action:not(.initial-state)::before):
(body[dir=ltr] .item.action::before):
(body[dir=rtl] .item.action::before):
(.tree-outline:matches(:focus, .force-focus) .item.action.selected:not(.initial-state, .invalid) > .icon):
(body:not(.window-inactive, .window-docked-inactive) :matches(:focus, .force-focus) .item.action.selected > .titles .parameter.swizzled,):
(.tree-outline[data-indent="1"] .item.action::before,):
(.tree-outline[data-indent="3"] .item.action::before):
(.tree-outline[data-indent="4"] .item.action::before):
(.tree-outline[data-indent="5"] .item.action::before):
(.tree-outline[data-indent="6"] .item.action::before):
(.tree-outline[data-indent="7"] .item.action::before):
(body[dir=ltr] .tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon):
(body[dir=rtl] .tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon):
(.item.action.visual:not(.selected, .invalid)):
(.item.action.attribute > .titles .parameters::before):
(.item.action:not(.attribute) > .titles .parameters::before):
(.item.action:not(.attribute) > .titles .parameters::after):
(.item.action > .titles .parameter:not(:last-child)::after):
(.item.action:not(.selected) > .titles .parameter.swizzled):
(.item.action.composite > .icon):
(.item.action.fill > .icon):
(.item.action.image > .icon):
(.item.action.line-style > .icon):
(.item.action.shadow > .icon):
(.item.action.stroke > .icon):
(.item.action.style > .icon):
(.item.action.text > .icon):
(.item.action.transform > .icon):
(.item.action.arc > .icon):
(.item.action.clip > .icon):
(.item.action.curve > .icon):
(.item.action.ellipse > .icon):
(.item.action.line-to > .icon):
(.item.action.move-to > .icon):
(.item.action.point-in-path > .icon):
(.item.action.point-in-stroke > .icon):
(.item.action.rect > .icon):
(.item.action.restore > .icon):
(.item.action.save > .icon):
(.item.action.invalid > .icon):

• UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement):
(WI.RecordingActionTreeElement._generateDOM.createParameterElement):
(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement._getClassNames):
Broke out into its own helper, to simplify _generateDOM which had
too many responsibilities.

(WI.RecordingActionTreeElement._classNameForAction.classNameForActionName):
(WI.RecordingActionTreeElement._classNameForAction):
Get an icon for the action "type". Actions are grouped by similar
operations. For example, lineCap, lineDash, lineJoin, lineWidth, and
miterLimit are assigned the icon LineStyle.svg.

(WI.RecordingActionTreeElement.prototype.customTitleTooltip):

• UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content > .tree-outline .item.folder-icon > .icon):
(.sidebar > .panel.navigation.recording > .content > .tree-outline:not(:empty)): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline > .item.parent:not(.action, .selected).expanded): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline .item.action:not(.initial-state)::before): Deleted.
(body[dir=ltr] .sidebar > .panel.navigation.recording > .content > .tree-outline .item.action:not(.initial-state)::before): Deleted.
(body[dir=rtl] .sidebar > .panel.navigation.recording > .content > .tree-outline .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline[data-indent="2"] .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline[data-indent="3"] .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline[data-indent="4"] .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline[data-indent="5"] .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline[data-indent="6"] .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline[data-indent="7"] .item.action:not(.initial-state)::before): Deleted.
(.sidebar > .panel.navigation.recording > .content .action > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.function > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.attribute.getter > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .tree-outline:matches(:focus, .force-focus) .action.attribute.getter.selected > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.attribute.boolean > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.attribute.number > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.attribute.object > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.attribute.string > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content > .tree-outline > .item.parent:not(.action) > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action:matches(.invalid, .missing) > .icon): Deleted.
(body[dir=ltr] .sidebar > .panel.navigation.recording > .content .action:not(.initial-state) > .icon): Deleted.
(body[dir=rtl] .sidebar > .panel.navigation.recording > .content .action:not(.initial-state) > .icon): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.visual:not(.selected, .invalid)): Deleted.
(.sidebar > .panel.navigation.recording > .content .action:not(.selected, .initial-state) > .titles .parameter.swizzled): Deleted.
(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles :matches(.name, .parameter.invalid)): Deleted.

• UserInterface/Views/RecordingNavigationSidebarPanel.js:

9:18 PM Changeset in webkit [221843] by tpopela@redhat.com

• 1 edit
  2 adds in trunk/LayoutTests

[GTK] DOM operations could behave unexpectedly with certain fonts or font sizes
​https://bugs.webkit.org/show_bug.cgi?id=149703

Reviewed by Michael Catanzaro.

Before r221670 (FreeType rebase) this test case would fail due to
bug in FreeType where it was providing wrong font extents for specific
fonts and sizes. Before the rebase the selection was incorrectly
restored on the end of the first line. Adding this new test to catch
any possible regression in the FreeType.

• fast/dom/Document/CaretRangeFromPoint/restore-selection-from-point-expected.txt: Added.
• fast/dom/Document/CaretRangeFromPoint/restore-selection-from-point.html: Added.

6:05 PM Changeset in webkit [221842] by mmaxfield@apple.com

• 18 edits
  6 copies in trunk/Tools

WSL should support while loops
​https://bugs.webkit.org/show_bug.cgi?id=176581

Reviewed by Filip Pizlo.

There are a few interesting pieces to this patch:

1. Because the evaluator is just a node-based descent through the tree, the implementation of break

and continue are just "throw".

2. The ReturnChecker now has to return a three-state enum because of nested blocks. The outer block

cares about if the inner block has "break" as opposed to it having no returns nor breaks/continues.

3. ReturnChecker will treat "while (true)" the same as { }, but will not descend deeper for things

like "while (3 == 3)".

4. This patch also adds a few more boolean conditional functions like operator<().
5. I added another pass which makes sure there are no bare break/return keywords outside of loops.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/Break.js: Copied from Tools/WebGPUShadingLanguageRI/CheckUnreachableCode.js.

(Break):
(Break.prototype.get origin):
(Break.prototype.toString):

• WebGPUShadingLanguageRI/CheckLoops.js: Copied from Tools/WebGPUShadingLanguageRI/CheckReturns.js.

(checkLoops):

• WebGPUShadingLanguageRI/CheckReturns.js:

(checkReturns):

• WebGPUShadingLanguageRI/CheckUnreachableCode.js:

(checkUnreachableCode):

• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Continue.js: Copied from Tools/WebGPUShadingLanguageRI/CheckReturns.js.

(Continue):
(Continue.prototype.get origin):
(Continue.prototype.toString):

• WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitWhileLoop):
(Evaluator.prototype.visitBreak):
(Evaluator.prototype.visitContinue):

• WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

• WebGPUShadingLanguageRI/Lexer.js:

(Lexer.prototype.next):
(Lexer):

• WebGPUShadingLanguageRI/LoopChecker.js: Copied from Tools/WebGPUShadingLanguageRI/ReturnChecker.js.

(LoopChecker):
(LoopChecker.prototype.visitFuncDef):
(LoopChecker.prototype.visitWhileLoop):
(LoopChecker.prototype.visitBreak):
(LoopChecker.prototype.visitContinue):

• WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitWhileLoop):

• WebGPUShadingLanguageRI/Node.js:

(Node.prototype.visit):

• WebGPUShadingLanguageRI/Parse.js:

(parsePossibleRelationalInequality):
(parseBreak):
(parseContinue):
(parseWhile):

• WebGPUShadingLanguageRI/Prepare.js:

(prepare):

• WebGPUShadingLanguageRI/ReturnChecker.js:

(ReturnChecker):
(ReturnChecker.prototype.visitFuncDef):
(ReturnChecker.prototype.visitBlock):
(ReturnChecker.prototype.visitIfStatement):
(ReturnChecker.prototype.visitWhileLoop):
(ReturnChecker.prototype.visitReturn):
(ReturnChecker.prototype.visitBreak):
(ReturnChecker.prototype.visitContinue):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitContinue):
(Rewriter.prototype.visitBreak):
(Rewriter.prototype.visitWhileLoop):
(Rewriter):

• WebGPUShadingLanguageRI/StandardLibraryPrologue.js:
• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(TEST_returnIf):
(TEST_simpleWhile):

• WebGPUShadingLanguageRI/UnreachableCodeChecker.js:

(UnreachableCodeChecker):
(UnreachableCodeChecker.prototype.visitBlock):

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitWhileLoop):
(Visitor.prototype.visitContinue):
(Visitor.prototype.visitBreak):

• WebGPUShadingLanguageRI/WhileLoop.js: Copied from Tools/WebGPUShadingLanguageRI/CheckReturns.js.

(WhileLoop):
(WhileLoop.prototype.get origin):
(WhileLoop.prototype.get conditional):
(WhileLoop.prototype.get body):
(WhileLoop.prototype.toString):

5:59 PM Changeset in webkit [221841] by commit-queue@webkit.org

• 4 edits
  6 adds
  4 deletes in trunk/PerformanceTests

Speedometer: Reduce duplication in react-redux test
​https://bugs.webkit.org/show_bug.cgi?id=176227

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-09-10
Reviewed by Ryosuke Niwa.

Updating react-scripts to a modern version avoids an issue where the generated bundle included the same Object.assign
polyfill multiple times.

• Speedometer/resources/todomvc/architecture-examples/react-redux/dist/*: Update dist per build instructions.
• Speedometer/resources/todomvc/architecture-examples/react-redux/package-lock.json: Update dependencies.
• Speedometer/resources/todomvc/architecture-examples/react-redux/package.json: Update dependencies.

4:34 PM Changeset in webkit [221840] by Jon Davis

• 3 edits in trunk/Websites/browserbench.org

Minor design changes for browserbench.org landing page
​https://bugs.webkit.org/show_bug.cgi?id=176612

Reviewed by Darin Adler.

• index.html:
• resources/main.css: Shrink the logos and arrange them into a grid.

(main):
(.benchmarks):
(.benchmarks a):
(.benchmark):
(.benchmark:hover):
(.benchmark img):
(#ares-6-logo): Deleted.
(#motionmark-logo): Deleted.
(#speedometer-logo): Deleted.
(#jetstream-logo): Deleted.

3:56 PM Changeset in webkit [221839] by weinig@apple.com

• 22 edits in trunk

Finish off the FormData implementation
​https://bugs.webkit.org/show_bug.cgi?id=176659

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/XMLHttpRequest/FormData-append-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-delete-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-foreach-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-get-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-has-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-set-expected.txt:
• web-platform-tests/XMLHttpRequest/interfaces-expected.txt:

Update results.

Source/WebCore:

• fileapi/Blob.cpp:
• fileapi/Blob.h:
• fileapi/File.cpp:
• fileapi/File.h:

Add constructors / create functions for making File objects
from an existing Blob or File with an override name.

• html/DOMFormData.cpp:
• html/DOMFormData.h:

Add missing operations and iterator implementation
and bring append up to spec by no ignoring empty names.

• html/DOMFormData.idl:

Bring IDL up to spec. Leave its exposure to just the window for
now, as FormData currently depends on the Document/Page for replace
file generation and therefore cannot operate in a worker.

• html/FormDataList.cpp:
• html/FormDataList.h:

Changes FormDataList::Item to a String key and Variant<RefPtr<File>, String>
data, matching spec concepts more cleanly. Normalization / encoding has also
been made lazy, and now does not happen until creating a FormData from the
FormDataList.

Since we now store Files, rather than Blobs, we follow the spec's 'create an
entry' algorithm to convert Blobs into Files with the same backing bytes. This
was previously done as part of FormData::appendKeyValuePairItems.

• html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::appendFormData):

Remove unnecessary conversion to utf8, the data is base64 encoded, allowing
us to remove an overload of appendData that took a CString.

• inspector/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForResourceRequest):

Update for new signature of FormData::flatten() which now
returns a Vector, rather than takes one in.

• platform/network/FormData.h:
• platform/network/FormData.cpp:

(WebCore::FormData::FormData):
(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):

Cleanup redundancy by using auto.

(WebCore::FormData::appendKeyValuePairItems):

Updated to handle new FormDataList item format (e.g. pairs of key / data) allowing
us to remove two-by-two iteration. Some complexity was removed around Blobs, as
FormDataList now always creates File.

Since FormDataList no longer eagerly encodes / normalizes the keys and string data
values, we now perform those operations here.

(WebCore::FormData::expandDataStore):
(WebCore::appendBlobResolved):
(WebCore::FormData::resolveBlobReferences):
(WebCore::FormData::generateFiles):
(WebCore::FormData::hasGeneratedFiles const):
(WebCore::FormData::hasOwnedGeneratedFiles const):
(WebCore::FormData::removeGeneratedFilesIfNeeded):

Adopt auto and modern for-in loops.

(WebCore::FormData::flatten const):
(WebCore::FormData::flattenToString const):

Update flatten to return a Vector, rather than take it in.

3:17 PM Changeset in webkit [221838] by Darin Adler

• 2 edits in trunk/Source/WebCore

Refactor Document::updateTitleElement to use traits instead of function pointers
​https://bugs.webkit.org/show_bug.cgi?id=176671

Reviewed by Sam Weinig.

This template implementation seems slightly more readable and
also likely to be slightly more efficient. Also takes a suggestion
from Antti of factoring out the "select a new title element" into a
function, which is a natural thing to do in this version.

• dom/Document.cpp:

(WebCore::TitleTraits<HTMLTitleElement>::isInEligibleLocation): Added.
(WebCore::TitleTraits<HTMLTitleElement>::findTitleElement): Added.
(WebCore::TitleTraits<SVGTitleElement>::isInEligibleLocation): Added.
(WebCore::TitleTraits<SVGTitleElement>::findTitleElement): Added.
(WebCore::selectNewTitleElement): Added.
(WebCore::findHTMLTitle): Deleted.
(WebCore::isHTMLTitle): Deleted.
(WebCore::isHTMLTitleEligible): Deleted.
(WebCore::findSVGTitle): Deleted.
(WebCore::isSVGTitle): Deleted.
(WebCore::isSVGTitleEligible): Deleted.
(WebCore::Document::updateTitleElement): Call selectNewTitleElement
instead of having the logic here.

2:49 PM Changeset in webkit [221837] by fpizlo@apple.com

• 27 edits
  2 adds
  3 deletes in trunk/Tools

WSL overload resolution should not be cascading
​https://bugs.webkit.org/show_bug.cgi?id=176333

Reviewed by Myles Maxfield.

This removes the cascading nature of overload resolution that WSL used to have, and replaces it with
something C++-like. If there are multiple overload candidates that match the callsite, then we resolve
them against each other. Anytime a function cannot be resolved onto another function, it is removed,
since this means that this function is in some way more general than the other one, and we are just
looking for the most specific function.

If this process ends with only one function being selected, then we succeed, else we fail.

Also changed the syntax for defining generic casts to:

operator<T> Thingy<T>(things)

Also fixed parsing of cast expressions. It's now possible to say a cast expression in WSL.

The removal of cascading causes some problems. For example, the following two operators in our standard
library are ambiguous for bool(bool):

operator<T> T(T)
operator<T:Equatable> bool(T)

I think that what we really want is to say that the following operators are restricted to the standard
library:

operator<T> T()
operator<T> T(T)

It should not be possible to ever overload these.

These changes are mostly tested by existing tests and the changes in the standard library, which has to
be parsed for every test.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/ArrayRefType.js:

(ArrayRefType.prototype.unifyImpl):

• WebGPUShadingLanguageRI/CallExpression.js:

(CallExpression):
(CallExpression.prototype.get isCast):
(CallExpression.prototype.get returnType):
(CallExpression.prototype.resolve):
(CallExpression.prototype.becomeCast):
(CallExpression.prototype.setCastData):
(CallExpression.prototype.toString):

• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitLogicalNot):

• WebGPUShadingLanguageRI/Func.js:

(Func.prototype.get returnTypeForOverloadResolution):

• WebGPUShadingLanguageRI/FuncDef.js:

(FuncDef):

• WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.FindTypeVariable.prototype.visitTypeVariable):
(FuncInstantiator.prototype.getUnique.FindTypeVariable):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution):

• WebGPUShadingLanguageRI/FunctionLikeBlock.js:

(FunctionLikeBlock.prototype.toString):
(FunctionLikeBlock):

• WebGPUShadingLanguageRI/InferTypesForCall.js: Added.

(inferTypesForCall):

• WebGPUShadingLanguageRI/Inline.js:

(resolveInlinedFunction):

• WebGPUShadingLanguageRI/Lexer.js:

(Lexer):
(Lexer.prototype.next):

• WebGPUShadingLanguageRI/NameContext.js:

(NameContext):
(NameContext.prototype.mapFor):
(NameContext.prototype.add):
(NameContext.prototype.get let):
(NameContext.prototype.Symbol.iterator):
(NameContext.get currentStatement): Deleted.

• WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProgram):
(NameResolver.prototype.determinePossibleOverloads):
(NameResolver.prototype.visitProtocolFuncDecl):
(NameResolver.prototype.visitCallExpression):
(NameResolver):

• WebGPUShadingLanguageRI/NativeFunc.js:

(NativeFunc):

• WebGPUShadingLanguageRI/Node.js:

(Node.prototype.visit):

• WebGPUShadingLanguageRI/Parse.js:

(parsePossiblePrefix):
(parseFuncDecl):
(parseNativeFunc):
(parseNative):
(parsePreferredFuncDef):
(parse):

• WebGPUShadingLanguageRI/Prepare.js:

(prepare):

• WebGPUShadingLanguageRI/Program.js:

(Program.prototype.resolveFuncOverload): Deleted.
(Program.prototype.get nameContext): Deleted.

• WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.inherits):
(ProtocolDecl.prototype.hasHeir):

• WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.unifyImpl):

• WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitProtocolFuncDecl):
(Rewriter.prototype.processDerivedCallData):
(Rewriter.prototype.visitCastExpression): Deleted.

• WebGPUShadingLanguageRI/StandardLibrary.js: Added.

(preferred.operator.T.T):
(operator.T.Equatable.bool):

• WebGPUShadingLanguageRI/StandardLibraryEpilogue.js: Removed.
• WebGPUShadingLanguageRI/StandardLibraryPrologue.js: Removed.
• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(doLex):
(checkUInt):
(checkBool):

• WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.prototype.toString):
(TypeRef):

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitCallExpression):
(Visitor.prototype.visitCastExpression): Deleted.

12:04 PM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

12:00 PM Changeset in webkit [221836] by fpizlo@apple.com

• 15 edits
  2 adds in trunk

Error should compute .stack and friends lazily
​https://bugs.webkit.org/show_bug.cgi?id=176645

Reviewed by Saam Barati.
JSTests:

• ChakraCore.yaml: Skip test that was testing non-standard behavior of these fields.
• microbenchmarks/new-error.js: Added.
• microbenchmarks/throw.js: Added.

Source/JavaScriptCore:

Building the string portion of the stack trace after we walk the stack accounts for most of
the cost of computing the .stack property. So, this patch makes ErrorInstance hold onto the
Vector<StackFrame> so that it can build the string only once it's really needed.

This is an enormous speed-up for programs that allocate and throw exceptions.

It's a 5.6x speed-up for "new Error()" with a stack that is 4 functions deep.

It's a 2.2x speed-up for throwing and catching an Error.

It's a 1.17x speed-up for the WSL test suite (which throws a lot).

It's a significant speed-up on many of our existing try-catch microbenchmarks. For example,
delta-blue-try-catch is 1.16x faster.

• interpreter/Interpreter.cpp:

(JSC::GetStackTraceFunctor::GetStackTraceFunctor):
(JSC::GetStackTraceFunctor::operator() const):
(JSC::Interpreter::getStackTrace):

• interpreter/Interpreter.h:
• runtime/Error.cpp:

(JSC::getStackTrace):
(JSC::getBytecodeOffset):
(JSC::addErrorInfo):
(JSC::addErrorInfoAndGetBytecodeOffset): Deleted.

• runtime/Error.h:
• runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::ErrorInstance):
(JSC::ErrorInstance::finishCreation):
(JSC::ErrorInstance::materializeErrorInfoIfNeeded):
(JSC::ErrorInstance::visitChildren):
(JSC::ErrorInstance::getOwnPropertySlot):
(JSC::ErrorInstance::getOwnNonIndexPropertyNames):
(JSC::ErrorInstance::defineOwnProperty):
(JSC::ErrorInstance::put):
(JSC::ErrorInstance::deleteProperty):

• runtime/ErrorInstance.h:
• runtime/Exception.cpp:

(JSC::Exception::visitChildren):
(JSC::Exception::finishCreation):

• runtime/Exception.h:
• runtime/StackFrame.cpp:

(JSC::StackFrame::visitChildren):

• runtime/StackFrame.h:

(JSC::StackFrame::StackFrame):

11:55 AM Changeset in webkit [221835] by Darin Adler

• 2 edits in trunk/Source/WebCore

Fix double resolve assertion in FontFaceSet seen while running tests
​https://bugs.webkit.org/show_bug.cgi?id=176525

Reviewed by Brent Fulgham.

• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::FontFaceSet): Only resolve the promise if the CSSFontFaceSet
is already loaded. Otherwise, we will resolve it later when it calls completedLoading.

9:36 AM Changeset in webkit [221834] by beidson@apple.com

• 12 edits in trunk

Try to avoid creating the default WKWebsiteDataStore until its actually needed.
<rdar://problem/33164453> and ​https://bugs.webkit.org/show_bug.cgi?id=176551

Reviewed by Tim Horton.

Source/WebKit:

• UIProcess/API/APIHTTPCookieStore.cpp:

(API::HTTPCookieStore::cookies):
(API::HTTPCookieStore::setCookie):
(API::HTTPCookieStore::deleteCookie):

• UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultDataStore):
(API::WebsiteDataStore::defaultDataStoreExists):

• UIProcess/API/APIWebsiteDataStore.h:

• UIProcess/API/C/WKContext.cpp:

(WKContextGetWebsiteDataStore):

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(+[WKWebsiteDataStore _defaultDataStoreExists]):

• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::m_hiddenPageThrottlingTimer):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore):
(WebKit::WebProcessPool::warmInitialProcess):
(WebKit::WebProcessPool::createNewWebProcessRespectingProcessCountLimit):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::pageAddedToProcess):

• UIProcess/WebProcessPool.h:

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::isAssociatedProcessPool const):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

2:54 AM Changeset in webkit [221833] by Michael Catanzaro

• 2 edits in trunk/Tools

[GTK] Improve Ctrl+W and Ctrl+Q shortcuts in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=176619

Reviewed by Carlos Garcia Campos.

There are two different problems here. First, Ctrl+W is closing the entire window. That made
sense when I implemented the shortcut a couple years ago, but now MiniBrowser supports tabs
and it should really close only one single tab. Fix that.

Next, the keyboard shortcuts are not using webkit_web_view_try_close() and so are bypassing
onbeforeunload handlers, which are respected when closing with the mouse. Fix that too.

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowTryCloseCurrentWebView):
(browserWindowTryClose):
(browser_window_init):

Sep 9, 2017:

5:21 PM Changeset in webkit [221832] by mark.lam@apple.com

• 39 edits
  1 copy in trunk

[Re-landing] Use JIT probes for DFG OSR exit.
​https://bugs.webkit.org/show_bug.cgi?id=175144
<rdar://problem/33437050>

Not reviewed. Original patch reviewed by Saam Barati.

JSTests:

Disable these tests for debug builds because they run too slow with the new OSR exit.

• stress/op_mod-ConstVar.js:
• stress/op_mod-VarConst.js:
• stress/op_mod-VarVar.js:

Source/JavaScriptCore:

Relanding r221774.

• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):

• assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

• assembler/ProbeContext.h:

(JSC::Probe::CPUState::gpr const):
(JSC::Probe::CPUState::spr const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::arg):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::gpr const):
(JSC::Probe::Context::spr const):
(JSC::Probe::Context::fpr const):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe:: const): Deleted.

• assembler/ProbeFrame.h: Copied from Source/JavaScriptCore/assembler/ProbeFrame.h.
• assembler/ProbeStack.cpp:

(JSC::Probe::Page::Page):

• assembler/ProbeStack.h:

(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):

• bytecode/ArithProfile.cpp:
• bytecode/ArithProfile.h:
• bytecode/ArrayProfile.h:

(JSC::ArrayProfile::observeArrayMode):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::addressOfOSRExitCounter): Deleted.

• bytecode/ExecutionCounter.h:

(JSC::ExecutionCounter::hasCrossedThreshold const):
(JSC::ExecutionCounter::setNewThresholdForOSRExit):

• bytecode/MethodOfGettingAValueProfile.cpp:

(JSC::MethodOfGettingAValueProfile::reportValue):

• bytecode/MethodOfGettingAValueProfile.h:
• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::findPC): Deleted.

• dfg/DFGJITCode.h:
• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::jsValueFor):
(JSC::DFG::restoreCalleeSavesFor):
(JSC::DFG::saveCalleeSavesFor):
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::saveOrCopyCalleeSavesFor):
(JSC::DFG::createDirectArgumentsDuringExit):
(JSC::DFG::createClonedArgumentsDuringExit):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::emitRestoreArguments):
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
(JSC::DFG::printOSRExit):
(JSC::DFG::OSRExit::setPatchableCodeOffset): Deleted.
(JSC::DFG::OSRExit::getPatchableCodeOffsetAsJump const): Deleted.
(JSC::DFG::OSRExit::codeLocationForRepatch const): Deleted.
(JSC::DFG::OSRExit::correctJump): Deleted.
(JSC::DFG::OSRExit::emitRestoreArguments): Deleted.
(JSC::DFG::OSRExit::compileOSRExit): Deleted.
(JSC::DFG::OSRExit::compileExit): Deleted.
(JSC::DFG::OSRExit::debugOperationPrintSpeculationFailure): Deleted.

• dfg/DFGOSRExit.h:

(JSC::DFG::OSRExitState::OSRExitState):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):

• dfg/DFGOSRExitCompilerCommon.cpp:
• dfg/DFGOSRExitCompilerCommon.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGThunks.cpp:

(JSC::DFG::osrExitThunkGenerator):
(JSC::DFG::osrExitGenerationThunkGenerator): Deleted.

• dfg/DFGThunks.h:
• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall): Deleted.

• jit/AssemblyHelpers.h:
• jit/JITOperations.cpp:
• jit/JITOperations.h:
• profiler/ProfilerOSRExit.h:

(JSC::Profiler::OSRExit::incCount):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:
• runtime/VM.h:

3:54 PM Changeset in webkit [221831] by dino@apple.com

• 4 edits
  2 adds in trunk

gl.detachShader breaks shader program
​https://bugs.webkit.org/show_bug.cgi?id=137689
<rdar://problem/34025056>

Reviewed by Sam Weinig.

Source/WebCore:

It should be possible to compile shaders, attach them to a program,
link the program, detach the shaders, delete the shaders, and then
ask for the uniform and attribute locations. That is, once you've
linked, the shaders can be thrown away.

We were using the attached shaders to look up uniform locations, so
we now keep around a separate map that remembers what shaders were
attached when the program links.

This fixes the bug, but the whole area is still a bit messy. For one,
we're keeping around all the shader information even after it is
no longer used.
See ​https://bugs.webkit.org/show_bug.cgi?id=98204

Test: fast/canvas/webgl/detachShader-before-accessing-uniform.html

• platform/graphics/GraphicsContext3D.h: Add another map to remember

what shaders were used when a program was linked.

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::mappedSymbolInShaderSourceMap): New helper
to look up a name in our source maps.
(WebCore::GraphicsContext3D::mappedSymbolName): Use the helper, and look
at linked shaders if there are no attached shaders.
(WebCore::GraphicsContext3D::originalSymbolInShaderSourceMap): Does the
reverse of the above.
(WebCore::GraphicsContext3D::originalSymbolName):
(WebCore::GraphicsContext3D::linkProgram): Add to the new map.
(WebCore::GraphicsContext3D::deleteProgram): Delete the program from
our shader entries.

LayoutTests:

Test that detaches and deletes shaders after linking, but before
asking for uniform locations.

• fast/canvas/webgl/detachShader-before-accessing-uniform-expected.txt: Added.
• fast/canvas/webgl/detachShader-before-accessing-uniform.html: Added.

3:35 PM Changeset in webkit [221830] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176661

Unreviewed test gardening.

• platform/win/TestExpectations:

3:07 PM Changeset in webkit [221829] by fpizlo@apple.com

• 13 edits
  1 add in trunk/Tools

Add "if" statements to WSL
​https://bugs.webkit.org/show_bug.cgi?id=176294

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2017-09-07
Reviewed by Filip Pizlo.

Rolling back in after skipping Test.js on debug.

Fairly straightforward implementation. ReturnChecker only returns true iff there is an else block,
and both the if body and the else body recursively return true.

In order to accept both syntaxes:
if (foo)

bar;

... and ...
if (foo) {

bar;

}
This patch lets parseStatement() call parseBlock(). This means that the following is valid:
int x = 7;
if (foo) {

int x = 8;
x is 8 here!

}
x is 7 here!

This production means that these blocks don't require "if" statements, so you can just have:
int foo() {

int x = 7;
{

int x = 8;
x is 8 here!

}
x is 7 here!

}

However, this patch doesn't touch the following use-case:
if (int x = bar()) {

use x here

}

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitIfStatement):

• WebGPUShadingLanguageRI/IfStatement.js: Copied from Tools/WebGPUShadingLanguageRI/TypeDef.js.

(IfStatement):
(IfStatement.prototype.get origin):
(IfStatement.prototype.get conditional):
(IfStatement.prototype.get body):
(IfStatement.prototype.get elseBody):
(IfStatement.prototype.toString):

• WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitIfStatement):

• WebGPUShadingLanguageRI/Parse.js:

(parseTypeParameters):
(parseIfStatement):
(parseStatement):

• WebGPUShadingLanguageRI/ReturnChecker.js:

(ReturnChecker.prototype.visitIfStatement):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitIfStatement):
(Rewriter):

• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(TEST_variableShadowing):
(TEST_ifStatement):
(TEST_ifElseStatement):
(TEST_ifElseIfStatement):
(TEST_ifElseIfElseStatement):
(TEST_returnIf):
(TEST_protocolMonoPolySigDoublePolyDefExplicit): Deleted.

• WebGPUShadingLanguageRI/TypeDef.js:

(TypeDef.prototype.toString):
(TypeDef):

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitIfStatement):

2:35 PM Changeset in webkit [221828] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark svg/animations/animations-paused-in-background-page-iframe.html as a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=176660

Unreviewed test gardening.

• platform/win/TestExpectations:

12:26 PM Changeset in webkit [221827] by Michael Catanzaro

• 2 edits in trunk/Tools

[GTK] Unreviewed, fix typo forwad -> forward

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowUpdateNavigationActions):
(backForwardlistChanged):
(browserWindowSwitchTab):
(backForwadlistChanged): Deleted.

11:06 AM Changeset in webkit [221826] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Skip web platform tests on Windows since many of them are very slow.
​https://bugs.webkit.org/show_bug.cgi?id=176657

Unreviewed test gardening.

• platform/win/TestExpectations:

9:58 AM Changeset in webkit [221825] by Ryan Haddad

• 4 edits in trunk/Tools

Unreviewed, rolling out r221801.

This change introduced a webkitpy test failure.

Reverted changeset:

"bisect-builds doesn't work due to missing requests module"
​https://bugs.webkit.org/show_bug.cgi?id=175709
​http://trac.webkit.org/changeset/221801

9:56 AM Changeset in webkit [221824] by Ryan Haddad

• 12 edits
  1 delete in trunk/Tools

Unreviewed, rolling out r221776.

This change caused wsl-tests.yaml/Test.js to time out on Debug
JSC bots.

Reverted changeset:

"Add "if" statements to WSL"
​https://bugs.webkit.org/show_bug.cgi?id=176294
​http://trac.webkit.org/changeset/221776

9:54 AM Changeset in webkit [221823] by Ryan Haddad

• 35 edits
  1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r221774.

This change introduced three debug JSC test timeouts.

Reverted changeset:

"Use JIT probes for DFG OSR exit."
​https://bugs.webkit.org/show_bug.cgi?id=175144
​http://trac.webkit.org/changeset/221774

9:21 AM Changeset in webkit [221822] by mark.lam@apple.com

• 191 edits in trunk/Source

Avoid duplicate computations of ExecState::vm().
​https://bugs.webkit.org/show_bug.cgi?id=176647

Reviewed by Saam Barati.

Source/JavaScriptCore:

Because while computing ExecState::vm() is cheap, it is not free.

This patch also:

1. gets rids of some convenience methods in CallFrame that implicitly does a ExecState::vm() computation. This minimizes the chance of us accidentally computing ExecState::vm() more than necessary.
2. passes vm (when available) to methodTable().
3. passes vm (when available) to JSLockHolder.

• API/JSBase.cpp:

(JSCheckScriptSyntax):
(JSGarbageCollect):
(JSReportExtraMemoryCost):
(JSSynchronousGarbageCollectForDebugging):
(JSSynchronousEdenCollectForDebugging):

• API/JSCallbackConstructor.h:

(JSC::JSCallbackConstructor::create):

• API/JSCallbackObject.h:

(JSC::JSCallbackObject::create):

• API/JSContext.mm:

(-[JSContext setException:]):

• API/JSContextRef.cpp:

(JSContextGetGlobalObject):
(JSContextCreateBacktrace):

• API/JSManagedValue.mm:

(-[JSManagedValue value]):

• API/JSObjectRef.cpp:

(JSObjectMake):
(JSObjectMakeFunctionWithCallback):
(JSObjectMakeConstructor):
(JSObjectMakeFunction):
(JSObjectSetPrototype):
(JSObjectHasProperty):
(JSObjectGetProperty):
(JSObjectSetProperty):
(JSObjectSetPropertyAtIndex):
(JSObjectDeleteProperty):
(JSObjectGetPrivateProperty):
(JSObjectSetPrivateProperty):
(JSObjectDeletePrivateProperty):
(JSObjectIsFunction):
(JSObjectCallAsFunction):
(JSObjectCallAsConstructor):
(JSObjectCopyPropertyNames):
(JSPropertyNameAccumulatorAddName):

• API/JSScriptRef.cpp:
• API/JSTypedArray.cpp:

(JSValueGetTypedArrayType):
(JSObjectMakeTypedArrayWithArrayBuffer):
(JSObjectMakeTypedArrayWithArrayBufferAndOffset):
(JSObjectGetTypedArrayBytesPtr):
(JSObjectGetTypedArrayBuffer):
(JSObjectMakeArrayBufferWithBytesNoCopy):
(JSObjectGetArrayBufferBytesPtr):

• API/JSWeakObjectMapRefPrivate.cpp:
• API/JSWrapperMap.mm:

(constructorHasInstance):
(makeWrapper):

• API/ObjCCallbackFunction.mm:

(objCCallbackFunctionForInvocation):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::jettison):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::replaceConstant):

• bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):

• dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::globalThisObjectFor):

• dfg/DFGOperations.cpp:
• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

• ftl/FTLOperations.cpp:

(JSC::FTL::operationPopulateObjectInOSR):
(JSC::FTL::operationMaterializeObjectInOSR):

• heap/GCAssertions.h:
• inspector/InjectedScriptHost.cpp:

(Inspector::InjectedScriptHost::wrapper):

• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::subtype):
(Inspector::constructInternalProperty):
(Inspector::JSInjectedScriptHost::getInternalProperties):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::weakSetEntries):
(Inspector::JSInjectedScriptHost::iteratorEntries):

• inspector/JSJavaScriptCallFrame.cpp:

(Inspector::valueForScopeLocation):
(Inspector::JSJavaScriptCallFrame::scopeDescriptions):
(Inspector::toJS):

• inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):
(Inspector::createScriptArguments):

• interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

• interpreter/CallFrame.h:

(JSC::ExecState::atomicStringTable const): Deleted.
(JSC::ExecState::propertyNames const): Deleted.
(JSC::ExecState::emptyList const): Deleted.
(JSC::ExecState::interpreter): Deleted.
(JSC::ExecState::heap): Deleted.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeModuleProgram):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JITOperations.cpp:
• jit/JITWorklist.cpp:

(JSC::JITWorklist::compileNow):

• jsc.cpp:

(WTF::RuntimeArray::create):
(WTF::RuntimeArray::getOwnPropertySlot):
(WTF::DOMJITGetter::DOMJITAttribute::slowCall):
(WTF::DOMJITFunctionObject::unsafeFunction):
(WTF::DOMJITCheckSubClassObject::unsafeFunction):
(GlobalObject::moduleLoaderFetch):
(functionDumpCallFrame):
(functionCreateRoot):
(functionGetElement):
(functionSetElementRoot):
(functionCreateSimpleObject):
(functionSetHiddenValue):
(functionCreateProxy):
(functionCreateImpureGetter):
(functionCreateCustomGetterObject):
(functionCreateDOMJITNodeObject):
(functionCreateDOMJITGetterObject):
(functionCreateDOMJITGetterComplexObject):
(functionCreateDOMJITFunctionObject):
(functionCreateDOMJITCheckSubClassObject):
(functionGCAndSweep):
(functionFullGC):
(functionEdenGC):
(functionHeapSize):
(functionShadowChickenFunctionsOnStack):
(functionSetGlobalConstRedeclarationShouldNotThrow):
(functionJSCOptions):
(functionFailNextNewCodeBlock):
(functionMakeMasquerader):
(functionDumpTypesForAllVariables):
(functionFindTypeForExpression):
(functionReturnTypeFor):
(functionDumpBasicBlockExecutionRanges):
(functionBasicBlockExecutionCount):
(functionDrainMicrotasks):
(functionGenerateHeapSnapshot):
(functionEnsureArrayStorage):
(functionStartSamplingProfiler):
(runInteractive):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• parser/ModuleAnalyzer.cpp:

(JSC::ModuleAnalyzer::ModuleAnalyzer):

• profiler/ProfilerBytecode.cpp:

(JSC::Profiler::Bytecode::toJS const):

• profiler/ProfilerBytecodeSequence.cpp:

(JSC::Profiler::BytecodeSequence::addSequenceProperties const):

• profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::toJS const):

• profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::toJS const):

• profiler/ProfilerCompiledBytecode.cpp:

(JSC::Profiler::CompiledBytecode::toJS const):

• profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::toJS const):

• profiler/ProfilerEvent.cpp:

(JSC::Profiler::Event::toJS const):

• profiler/ProfilerOSRExit.cpp:

(JSC::Profiler::OSRExit::toJS const):

• profiler/ProfilerOrigin.cpp:

(JSC::Profiler::Origin::toJS const):

• profiler/ProfilerProfiledBytecodes.cpp:

(JSC::Profiler::ProfiledBytecodes::toJS const):

• runtime/AbstractModuleRecord.cpp:

(JSC::identifierToJSValue):
(JSC::AbstractModuleRecord::resolveExportImpl):
(JSC::getExportedNames):

• runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):

• runtime/BooleanConstructor.cpp:

(JSC::constructBooleanFromImmediateBoolean):

• runtime/CallData.cpp:

(JSC::call):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):

• runtime/Completion.cpp:

(JSC::checkSyntax):
(JSC::evaluate):
(JSC::loadAndEvaluateModule):
(JSC::loadModule):
(JSC::linkAndEvaluateModule):
(JSC::importModule):

• runtime/ConstructData.cpp:

(JSC::construct):

• runtime/DatePrototype.cpp:

(JSC::dateProtoFuncToJSON):

• runtime/DirectArguments.h:

(JSC::DirectArguments::length const):

• runtime/DirectEvalExecutable.cpp:

(JSC::DirectEvalExecutable::create):

• runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

• runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):
(JSC::errorDescriptionForValue):

• runtime/FunctionConstructor.cpp:

(JSC::constructFunction):

• runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::getOwnPropertyNames):

• runtime/IdentifierInlines.h:

(JSC::Identifier::add):

• runtime/IndirectEvalExecutable.cpp:

(JSC::IndirectEvalExecutable::create):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::createSubclassStructureSlow):

• runtime/JSArray.cpp:

(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::put):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnNonIndexPropertyNames):
(JSC::JSArray::isIteratorProtocolFastAndNonObservable):

• runtime/JSArray.h:

(JSC::JSArray::shiftCountForShift):

• runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpForBacktrace const):

• runtime/JSDataView.cpp:

(JSC::JSDataView::getOwnPropertySlot):
(JSC::JSDataView::deleteProperty):
(JSC::JSDataView::getOwnNonIndexPropertyNames):

• runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::reifyName):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

• runtime/JSInternalPromise.cpp:

(JSC::JSInternalPromise::then):

• runtime/JSLexicalEnvironment.cpp:

(JSC::JSLexicalEnvironment::deleteProperty):

• runtime/JSMap.cpp:

(JSC::JSMap::isIteratorProtocolFastAndNonObservable):

• runtime/JSMapIterator.h:

(JSC::JSMapIterator::advanceIter):

• runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::getOwnNonIndexPropertyNames):

• runtime/JSModuleLoader.cpp:

(JSC::printableModuleKey):
(JSC::JSModuleLoader::provide):
(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::requestImportModule):

• runtime/JSModuleNamespaceObject.h:
• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::evaluate):

• runtime/JSONObject.cpp:

(JSC::Stringifier::Stringifier):
(JSC::Stringifier::appendStringifiedValue):
(JSC::Stringifier::Holder::appendNextProperty):

• runtime/JSObject.cpp:

(JSC::JSObject::calculatedClassName):
(JSC::JSObject::putByIndex):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::toPrimitive const):
(JSC::JSObject::hasInstance):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
(JSC::getCustomGetterSetterFunctionForGetterSetter):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::JSObject::getMethod):

• runtime/JSObject.h:

(JSC::JSObject::createRawObject):
(JSC::JSFinalObject::create):

• runtime/JSObjectInlines.h:

(JSC::JSObject::canPerformFastPutInline):
(JSC::JSObject::putInlineForJSObject):
(JSC::JSObject::hasOwnProperty const):

• runtime/JSScope.cpp:

(JSC::isUnscopable):
(JSC::JSScope::resolveScopeForHoistingFuncDeclInEval):

• runtime/JSSet.cpp:

(JSC::JSSet::isIteratorProtocolFastAndNonObservable):

• runtime/JSSetIterator.h:

(JSC::JSSetIterator::advanceIter):

• runtime/JSString.cpp:

(JSC::JSString::getStringPropertyDescriptor):

• runtime/JSString.h:

(JSC::JSString::getStringPropertySlot):

• runtime/MapConstructor.cpp:

(JSC::constructMap):

• runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::create):

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToLocaleString):

• runtime/ProgramExecutable.h:
• runtime/RegExpObject.cpp:

(JSC::RegExpObject::getOwnPropertySlot):
(JSC::RegExpObject::deleteProperty):
(JSC::RegExpObject::getOwnNonIndexPropertyNames):
(JSC::RegExpObject::getPropertyNames):
(JSC::RegExpObject::getGenericPropertyNames):
(JSC::RegExpObject::put):

• runtime/ScopedArguments.h:

(JSC::ScopedArguments::length const):

• runtime/StrictEvalActivation.h:

(JSC::StrictEvalActivation::create):

• runtime/StringObject.cpp:

(JSC::isStringOwnProperty):
(JSC::StringObject::deleteProperty):
(JSC::StringObject::getOwnNonIndexPropertyNames):

• tools/JSDollarVMPrototype.cpp:

(JSC::JSDollarVMPrototype::gc):
(JSC::JSDollarVMPrototype::edenGC):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

Source/WebCore:

No new tests because this is only a refactoring patch. There is no
significant behavior change.

• Modules/mediastream/SDPProcessor.cpp:

(WebCore::SDPProcessor::callScript const):

• Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::installReplacement):

• bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::constructCustomElementSynchronously):
(WebCore::JSCustomElementInterface::upgradeElement):
(WebCore::JSCustomElementInterface::invokeCallback):

• bindings/js/JSDOMConvertRecord.h:
• bindings/js/JSDOMMapLike.h:

(WebCore::forwardSizeToMapLike):
(WebCore::forwardEntriesToMapLike):
(WebCore::forwardKeysToMapLike):
(WebCore::forwardValuesToMapLike):
(WebCore::forwardGetToMapLike):
(WebCore::forwardHasToMapLike):

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::addCrossOriginWindowOwnPropertyNames):

• bindings/js/JSDocumentCustom.cpp:

(WebCore::reportMemoryForDocumentIfFrameless):

• bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

• bindings/js/JSImageDataCustom.cpp:

(WebCore::toJSNewlyCreated):

• bindings/js/JSLocationCustom.cpp:

(WebCore::getOwnPropertySlotCommon):
(WebCore::putCommon):
(WebCore::addCrossOriginLocationPropertyNames):
(WebCore::addCrossOriginLocationOwnPropertyNames):
(WebCore::JSLocation::defineOwnProperty):
(WebCore::JSLocationPrototype::put):
(WebCore::JSLocationPrototype::defineOwnProperty):

• bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::setJSInterfaceNameConstructor):

• bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::setJSMapLikeConstructor):

• bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::setJSReadOnlyMapLikeConstructor):

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::setJSTestActiveDOMObjectConstructor):

• bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::setJSTestCEReactionsConstructor):

• bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::setJSTestCEReactionsStringifierConstructor):

• bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::setJSTestCallTracerConstructor):

• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::setJSTestClassWithJSBuiltinConstructorConstructor):

• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor):
(WebCore::setJSTestCustomConstructorWithNoInterfaceObjectConstructor):

• bindings/scripts/test/JS/JSTestDOMJIT.cpp:

(WebCore::setJSTestDOMJITConstructor):

• bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::setJSTestEnabledBySettingConstructor):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::setJSTestEventConstructorConstructor):

• bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::setJSTestEventTargetConstructor):

• bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::setJSTestExceptionConstructor):

• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::setJSTestGenerateIsReachableConstructor):

• bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::setJSTestGlobalObjectConstructor):

• bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::setJSTestIndexedSetterNoIdentifierConstructor):

• bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::setJSTestIndexedSetterThrowingExceptionConstructor):

• bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::setJSTestIndexedSetterWithIdentifierConstructor):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceConstructor):

• bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:

(WebCore::setJSTestInterfaceLeadingUnderscoreConstructor):

• bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::setJSTestIterableConstructor):

• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::setJSTestJSBuiltinConstructorConstructor):

• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::setJSTestMediaQueryListListenerConstructor):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::setJSTestNamedAndIndexedSetterNoIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::setJSTestNamedAndIndexedSetterThrowingExceptionConstructor):

• bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::setJSTestNamedAndIndexedSetterWithIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::setJSTestNamedConstructorConstructor):

• bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::setJSTestNamedDeleterNoIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::setJSTestNamedDeleterThrowingExceptionConstructor):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::setJSTestNamedDeleterWithIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::setJSTestNamedDeleterWithIndexedGetterConstructor):

• bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::setJSTestNamedGetterCallWithConstructor):

• bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::setJSTestNamedGetterNoIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::setJSTestNamedGetterWithIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::setJSTestNamedSetterNoIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::setJSTestNamedSetterThrowingExceptionConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::setJSTestNamedSetterWithIdentifierConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::setJSTestNamedSetterWithIndexedGetterConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::setJSTestNamedSetterWithIndexedGetterAndSetterConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:

(WebCore::setJSTestNamedSetterWithOverrideBuiltinsConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::setJSTestNamedSetterWithUnforgablePropertiesConstructor):

• bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::setJSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsConstructor):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::setJSTestNodeConstructor):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjConstructor):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::setJSTestOverloadedConstructorsConstructor):

• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::setJSTestOverloadedConstructorsWithSequenceConstructor):

• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::setJSTestOverrideBuiltinsConstructor):

• bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::setJSTestPluginInterfaceConstructor):

• bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::setJSTestPromiseRejectionEventConstructor):

• bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::setJSTestSerializationConstructor):

• bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:

(WebCore::setJSTestSerializationIndirectInheritanceConstructor):

• bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::setJSTestSerializationInheritConstructor):

• bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::setJSTestSerializationInheritFinalConstructor):

• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::setJSTestSerializedScriptValueInterfaceConstructor):

• bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::setJSTestStringifierConstructor):

• bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::setJSTestStringifierAnonymousOperationConstructor):

• bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::setJSTestStringifierNamedOperationConstructor):

• bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::setJSTestStringifierOperationImplementedAsConstructor):

• bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::setJSTestStringifierOperationNamedToStringConstructor):

• bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::setJSTestStringifierReadOnlyAttributeConstructor):

• bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::setJSTestStringifierReadWriteAttributeConstructor):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::setJSTestTypedefsConstructor):

• bridge/NP_jsobject.cpp:

(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_Enumerate):

• bridge/c/c_instance.cpp:

(JSC::Bindings::CRuntimeMethod::create):

• bridge/objc/WebScriptObject.mm:

(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject setWebScriptValueAtIndex:value:]):

• bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create):

• bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create):

• bridge/runtime_array.cpp:

(JSC::RuntimeArray::getOwnPropertyNames):
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::put):

• bridge/runtime_array.h:

(JSC::RuntimeArray::create):

• bridge/runtime_method.cpp:

(JSC::RuntimeMethod::getOwnPropertySlot):

• bridge/runtime_method.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateCaptionContainer):
(WebCore::HTMLMediaElement::setControllerJSProperty):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::updateMediaControlsAfterPresentationModeChange):
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):

• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

• testing/Internals.cpp:

(WebCore::Internals::cloneArrayBuffer):

Source/WebKit:

• WebProcess/Plugins/Netscape/JSNPMethod.h:

(WebKit::JSNPMethod::create):

• WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::NPJSObject::setProperty):
(WebKit::NPJSObject::removeProperty):
(WebKit::NPJSObject::enumerate):

Source/WebKitLegacy/mac:

• Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):
(WebKit::NetscapePluginInstanceProxy::setProperty):
(WebKit::NetscapePluginInstanceProxy::removeProperty):
(WebKit::NetscapePluginInstanceProxy::enumerate):

• Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyRuntimeMethod::create):

9:15 AM Changeset in webkit [221821] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/security/canvas-remote-read-remote-video-allowed-with-credentials.html as a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=176653

Unreviewed test gardening.

• platform/win/TestExpectations:

8:55 AM Changeset in webkit [221820] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark web platform tests as slow on Windows.

Unreviewed test gardening.

• platform/win/TestExpectations:

8:31 AM Changeset in webkit [221819] by Michael Catanzaro

• 2 edits in trunk/Tools

MiniBrowser closes tab instead of window on close signal
​https://bugs.webkit.org/show_bug.cgi?id=176587

Reviewed by Carlos Garcia Campos.

This has been broken since we added support for multiple tabs. We need to run try_close for
every open tab, not just the current one. If there are no onbeforeonload handlers then all
tabs will close; if there are some, then they'll be respected, but the remaining tabs will
be closed.

Note that we cannot simply iterate through the tabs of the GtkNotebook, as we'd be deleting
tabs as we go, so save all the tabs into a separate list and then try to close each in turn.

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowTryClose):
(browserWindowDeleteEvent):

8:28 AM Changeset in webkit [221818] by zandobersek@gmail.com

• 4 edits in trunk/LayoutTests

Unreviewed GTK+ gardening.

Added failure expectation for the HTTP test introduced in r221633,
and updated baselines for the editing/execCommand/print.html test.

• platform/gtk/TestExpectations:
• platform/gtk/editing/execCommand/print-expected.png:
• platform/gtk/editing/execCommand/print-expected.txt:

8:02 AM Changeset in webkit [221817] by zandobersek@gmail.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Adding ImageOnlyFailure expectations
for reference tests failing after Freetype changes in r221670
and r221724.

• platform/gtk/TestExpectations:

5:42 AM Changeset in webkit [221816] by zandobersek@gmail.com

• 5 edits in trunk/Source/WebCore

[EME] MediaKeySession: handle MediaKeys association through a WeakPtr
​https://bugs.webkit.org/show_bug.cgi?id=176584

Reviewed by Xabier Rodriguez-Calvar.

Don't keep a raw pointer to the originating MediaKeys object in
MediaKeySession that gets nulled out once MediaKeys is destroyed.
Instead, make MediaKeys a WeakPtrFactory and use a WeakPtr<MediaKeys>
object to maintain the association between MediaKeySession and
MediaKeys.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::detachKeys): Deleted.

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::~MediaKeys): Deleted.

• Modules/encryptedmedia/MediaKeys.h:

5:38 AM Changeset in webkit [221815] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline
​https://bugs.webkit.org/show_bug.cgi?id=176646

Reviewed by Carlos Garcia Campos.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::registerWebKitGStreamerElements): Adopt the return value
of gst_element_factory_find(), which is transferred in full.

• platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::flush): Adopt the return values
of gst_element_get_static_pad() and gst_pad_get_peer(), both being
transferred in full.

5:29 AM Changeset in webkit [221814] by zandobersek@gmail.com

• 2 edits in trunk/Tools

Unreviewed WPE build fix.

• TestWebKitAPI/PlatformWPE.cmake:

Link WebCore archives into the TestWebCore binary as a group.

2:35 AM Changeset in webkit [221813] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Use RenderLayerBacking::renderer() when possible
​https://bugs.webkit.org/show_bug.cgi?id=176585

The private member renderer() is a shorthand for m_owningLayer.renderer(). This patch uses
it in RenderLayerBacking when possible.

Patch by Frederic Wang <​fwang@igalia.com> on 2017-09-09
Reviewed by Carlos Garcia Campos.

No new tests, behavior not changed.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::setContentsNeedDisplay):
(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

12:46 AM Changeset in webkit [221812] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r221808 - WebDriver: ensure we close all windows handles when closing the session
​https://bugs.webkit.org/show_bug.cgi?id=176508

Reviewed by Brian Burg.

The spec says that when closing the session all top level browsing contexts should be closed. We are currently
checking if we have an active top level browsing context and then we try to close it before trying with the
rest. It can happen that we are in an inconsistent state, for example if the current top level browsing context
has been closed by JavaScript or another action and the user didn't switch to another one before closing the
session. In such case, closing the session will fail with NoSuchwindow and any other window open will not be
closed. It's safer to always ask for all window handles and close them, which is what the spec says too.

• Session.cpp:

(WebDriver::firstWindowHandleInResult): Helper class to get the first window handle in the result array.
(WebDriver::Session::closeAllToplevelBrowsingContexts): Use firstWindowHandleInResult().
(WebDriver::Session::close): Close the current top level browsing context and get all window handles to close
them all if needed.

12:45 AM Changeset in webkit [221811] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221677 - Missing break in URLParser
​https://bugs.webkit.org/show_bug.cgi?id=176357

Reviewed by Darin Adler.

Add a missing break so the currently set state is not overwritten
after the block. Found by Coverity scan.

• platform/URLParser.cpp:

(WebCore::URLParser::parse):

12:44 AM Changeset in webkit [221810] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r221742 - [ARM] Building FELightningNEON.cpp fails due to missing {Point,Spot}LightSource declarations
​https://bugs.webkit.org/show_bug.cgi?id=176531

Reviewed by Žan Doberšek.

The m_lightSource member is a Ref<LightSource>, and its get() method returns
a reference, therefore the casts have to be done to the corresponding reference
types.

• platform/graphics/cpu/arm/filters/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon): Adjust casts and member accesses accordingly.

12:42 AM Changeset in webkit [221809] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/bmalloc

Merge r221588 - Unreviewed build fix for Clang with libc++

Fixes a build failure when building with Clang, -stdlib=libc++, and gigacage
support enabled, which resulted in "stderr" being undefined.

• bmalloc/Gigacage.cpp: Add missing <ctsdio> include to pull the definition.

12:14 AM Changeset in webkit [221808] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebDriver

WebDriver: ensure we close all windows handles when closing the session
​https://bugs.webkit.org/show_bug.cgi?id=176508

Reviewed by Brian Burg.

The spec says that when closing the session all top level browsing contexts should be closed. We are currently
checking if we have an active top level browsing context and then we try to close it before trying with the
rest. It can happen that we are in an inconsistent state, for example if the current top level browsing context
has been closed by JavaScript or another action and the user didn't switch to another one before closing the
session. In such case, closing the session will fail with NoSuchwindow and any other window open will not be
closed. It's safer to always ask for all window handles and close them, which is what the spec says too.

• Session.cpp:

(WebDriver::firstWindowHandleInResult): Helper class to get the first window handle in the result array.
(WebDriver::Session::closeAllToplevelBrowsingContexts): Use firstWindowHandleInResult().
(WebDriver::Session::close): Close the current top level browsing context and get all window handles to close
them all if needed.

Sep 8, 2017:

10:19 PM Changeset in webkit [221807] by Yusuke Suzuki

• 3 edits
  1 add in trunk

[DFG] NewArrayWithSize(size)'s size does not care negative zero
​https://bugs.webkit.org/show_bug.cgi?id=176300

Reviewed by Saam Barati.

JSTests:

• stress/new-array-with-size-div.js: Added.

(shouldBe):
(test):
(i.i):

Source/JavaScriptCore:

NewArrayWithSize(size)'s size does not care negative zero as
is the same to NewTypedArray. We propagate this information
in DFGBackwardsPropagationPhase. This removes negative zero
check in kraken fft's deinterleave function.

• dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

8:32 PM Changeset in webkit [221806] by commit-queue@webkit.org

• 13 edits
  2 deletes in trunk/Source/WebCore

Replace JS builtin implementation of the FetchResponse constructor with a C++ one
​https://bugs.webkit.org/show_bug.cgi?id=176627

Patch by Sam Weinig <​sam@webkit.org> on 2017-09-08
Reviewed by Alex Christensen.

Removes the last of the Fetch related JS builtin code.

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• Modules/fetch/FetchInternals.js: Removed.
• Modules/fetch/FetchResponse.js: Removed.

Remove FetchInternals.js and FetchResponse.js.

• Modules/fetch/FetchBody.idl:
• Modules/fetch/FetchBodyConsumer.h:

Remove no longer correct FIXMEs.

• Modules/fetch/FetchBodySource.cpp:

Add missing newline between functions.

• Modules/fetch/FetchHeaders.idl:
• Modules/fetch/FetchResponse.idl:

Remove builtin related operations and extended attributes.

• Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::fastHas const):

• Modules/fetch/FetchHeaders.cpp:

Added fastHas to allow checking for a header using a HTTPHeaderName. Remove
now unused filter function.

• Modules/fetch/FetchResponse.cpp:

(WebCore::isNullBodyStatus):

Added helper predicate for 'null body status' concept.

(WebCore::FetchResponse::create):

Add spec defined constructor implementation.

(WebCore::FetchResponse::setBodyData):

Reformatted to match more common WTF::switchOn style.

(WebCore::FetchResponse::setStatus): Deleted.
(WebCore::FetchResponse::initializeWith): Deleted.

Removed now unused functions.

• Modules/fetch/FetchResponse.h:

(WebCore::FetchResponse::create):

Move inline create out of the class definition to make things a bit less crowded.

8:09 PM Changeset in webkit [221805] by commit-queue@webkit.org

• 10 edits
  10 adds in trunk

Implement HTMLImageElement.decoode() method
​https://bugs.webkit.org/show_bug.cgi?id=176016

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-09-08
Reviewed by Simon Fraser.

Source/WebCore:

The specs is:
​https://html.spec.whatwg.org/multipage/embedded-content.html#dom-img-decode.

-- img.decode() waits till loading the image finishes. Otherwise it starts
decoding the image immediately.
-- If the image frame is already decoded, the promise will be resolved
before return.
-- If an error happens in loading the image or decoding the image frame,
the promise will be rejected with 'EncodingError' exception.
-- Animated image resolves the promise when the next frame is decoded and
the animation is advanced it. If the image is not displayed, decode() will
request the decoding the first frame and start animating the image.

Tests: fast/images/decode-animated-image.html

fast/images/decode-render-animated-image.html
fast/images/decode-render-static-image.html
fast/images/decode-static-image-reject.html
fast/images/decode-static-image-resolve.html

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::decode):

• html/HTMLImageElement.h:
• html/HTMLImageElement.idl:
• loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):
(WebCore::ImageLoader::decode):
(WebCore::ImageLoader::decodeError):

• loader/ImageLoader.h:

(WebCore::ImageLoader::hasPendingDecodePromise const):

• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::internalStartAnimation):
(WebCore::BitmapImage::internalAdvanceAnimation):
(WebCore::BitmapImage::decode):
(WebCore::BitmapImage::imageFrameAvailableAtIndex):

• platform/graphics/BitmapImage.h:
• platform/graphics/Image.h:

(WebCore::Image::decode):

LayoutTests:

• fast/images/decode-animated-image-expected.html: Added.
• fast/images/decode-animated-image.html: Added.
• fast/images/decode-render-animated-image-expected.html: Added.
• fast/images/decode-render-animated-image.html: Added.
• fast/images/decode-render-static-image-expected.html: Added.
• fast/images/decode-render-static-image.html: Added.
• fast/images/decode-static-image-reject-expected.txt: Added.
• fast/images/decode-static-image-reject.html: Added.
• fast/images/decode-static-image-resolve-expected.html: Added.
• fast/images/decode-static-image-resolve.html: Added.

5:33 PM Changeset in webkit [221804] by commit-queue@webkit.org

• 5 edits
  7 adds in trunk

Fetch's Response.statusText is unexpectedly the full http status line for HTTP/2 responses
​https://bugs.webkit.org/show_bug.cgi?id=176479

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-08
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/wpt/fetch/response-status-text.html

HTTP/2 doesn't include a status reason phrase. So the "status line"
ends up just being the version and status code. Fallback to the empty
string instead of the full line.

• platform/network/HTTPParsers.cpp:

(WebCore::extractReasonPhraseFromHTTPStatusLine):

Source/WebKit:

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
Initialize AtomicString statics like emptyAtom().

LayoutTests:

• http/wpt/fetch/resources/status-garbage.asis: Added.
• http/wpt/fetch/resources/status-normal.txt: Added.
• http/wpt/fetch/resources/status-with-message.asis: Added.
• http/wpt/fetch/resources/status-without-message.asis: Added.

Various text HTTP responses with different status lines.

• http/wpt/fetch/response-status-text-expected.txt: Added.
• http/wpt/fetch/response-status-text.html: Added.

Test the Fetch Response's status / statusText for different HTTP status lines.
The status without a message is similiar to HTTP/2 because HTTP/2 only
has a :status pseudo-header and lacks a reason phrase.

5:10 PM Changeset in webkit [221803] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

Implement the attribute HTMLImageElement.async
​https://bugs.webkit.org/show_bug.cgi?id=176204

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-09-08
Reviewed by Darin Adler.

Source/WebCore:

Adding this attribute to the <img> element will force async decoding for
this image all the times. None of the heuristics, which prevents flickering
the image, will be checked.

Test: fast/images/async-attribute-with-small-image.html

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

• html/HTMLImageElement.h:

(WebCore::HTMLImageElement::async const):

• html/HTMLImageElement.idl:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::decodingModeForImageDraw const):

LayoutTests:

• fast/images/async-attribute-with-small-image-expected.html: Added.
• fast/images/async-attribute-with-small-image.html: Added.

4:11 PM Changeset in webkit [221802] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Fix duplicate entry warnings on Windows.

Unreviewed test gardening.

• platform/win/TestExpectations:

4:00 PM Changeset in webkit [221801] by Lucas Forschler

• 4 edits in trunk/Tools

bisect-builds doesn't work due to missing requests module
​https://bugs.webkit.org/show_bug.cgi?id=175709

Reviewed by Ryosuke Niwa.

• Scripts/bisect-builds: update import to webkitpy.thirdparty.autoinstalled
• Scripts/webkitpy/thirdparty/init.py: add logic to install requests module.

(AutoinstallImportHook.find_module):
(AutoinstallImportHook):
(AutoinstallImportHook._install_requests):

• Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_imports):

3:09 PM Changeset in webkit [221800] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: this._heapSnapshot.addEventListener is not a function.
​https://bugs.webkit.org/show_bug.cgi?id=176633

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-08
Reviewed by Michael Saboff.

• UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WI.HeapSnapshotDiffProxy):
This class has listeners of another object's events. It should extend WI.Object.

2:27 PM Changeset in webkit [221799] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/websocket/tests/hybi/websocket-pending-activity.html as a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=176632

Unreviewed test gardening.

• platform/win/TestExpectations:

1:37 PM Changeset in webkit [221798] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: changes to currentX/currentY aren't highlighted in the details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=176569

Reviewed by Matt Baker.

• UserInterface/Models/RecordingAction.js:

Add entries to WI.RecordingAction._stateModifiers for each path function.

1:31 PM Changeset in webkit [221797] by Matt Lewis

• 2 edits in trunk/LayoutTests

Added timeout expectation to imported/w3c/web-platform-tests/IndexedDB/large-nested-cloning.html on mac.
​https://bugs.webkit.org/show_bug.cgi?id=173487

Unreviewed test gardening.

• platform/mac/TestExpectations:

1:24 PM Changeset in webkit [221796] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/security/canvas-remote-read-remote-video-allowed-anonymous.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176626.

Unreviewed test gardening.

• platform/win/TestExpectations:

12:30 PM Changeset in webkit [221795] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-element.html as slow.

Unreviewed test gardening.

• platform/win/TestExpectations:

12:03 PM Changeset in webkit [221794] by commit-queue@webkit.org

• 11 edits in trunk/Source

Unreviewed, rolling out r221773.
​https://bugs.webkit.org/show_bug.cgi?id=176614

This caused build failures. (Requested by mlewis13 on
#webkit).

Reverted changeset:

"[Mac] Upstream QTKit-related WebKitSystemInterface functions"
​https://bugs.webkit.org/show_bug.cgi?id=176472
​http://trac.webkit.org/changeset/221773

11:58 AM Changeset in webkit [221793] by Yusuke Suzuki

• 11 edits
  2 adds in trunk

[DFG] PutByVal with Array::Generic is too generic
​https://bugs.webkit.org/show_bug.cgi?id=176345

Reviewed by Filip Pizlo.

JSTests:

• stress/object-assign-symbols.js: Added.

(shouldBe):
(test):

• stress/object-assign.js: Added.

(shouldBe):
(test):
(i.shouldBe.JSON.stringify.test):

Source/JavaScriptCore:

Our DFG/FTL's PutByVal with Array::Generic is too generic implementation.
We could have the case like,

dst[key] = src[key];

with string or symbol keys. But they are handled in slow path.
This patch adds PutByVal(CellUse, StringUse/SymbolUse, UntypedUse). They go
to optimized path that does not have generic checks like (isInt32() / isDouble() etc.).

This improves SixSpeed object-assign.es5 by 9.1%.

object-assign.es5 424.3159+-11.0471 ^{388.8771+-10.9239} definitely 1.0911x faster

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGOperations.cpp:

(JSC::DFG::putByVal):
(JSC::DFG::putByValInternal):
(JSC::DFG::putByValCellInternal):
(JSC::DFG::putByValCellStringInternal):
(JSC::DFG::operationPutByValInternal): Deleted.

• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForCellWithString):
(JSC::DFG::SpeculativeJIT::compilePutByValForCellWithSymbol):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePutByVal):

• jit/JITOperations.h:

11:55 AM Changeset in webkit [221792] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Test commit to verify trac sync is working.

11:46 AM Changeset in webkit [221791] by commit-queue@webkit.org

• 2 edits
  5 adds in trunk/Source/WebKit

[WinCairo] Add Storage Process files for wincairo webkit
​https://bugs.webkit.org/show_bug.cgi?id=176567

Patch by Stephan Szabo <​stephan.szabo@am.sony.com> on 2017-09-08
Reviewed by Alex Christensen.

• PlatformWin.cmake:
• StorageProcess/EntryPoint/win/StorageProcessMain.cpp: Added.

(main):

• StorageProcess/win/StorageProcessMainWin.cpp: Added.

(WebKit::StorageProcessMainWin):

• StorageProcess/win/StorageProcessMainWin.h: Added.

11:45 AM Changeset in webkit [221790] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Test commit to verify git sync is working.

10:25 AM Changeset in webkit [221789] by Lucas Forschler

• 2 edits in trunk/Tools

bisect-builds should not print out extracting command
​https://bugs.webkit.org/show_bug.cgi?id=175632

Reviewed by Alexey Proskuryakov.

• Scripts/bisect-builds:

(extract_archive):

9:35 AM Changeset in webkit [221788] by Antti Koivisto

• 40 edits
  10 deletes in trunk

Remove support for >> descendant combinator syntax
​https://bugs.webkit.org/show_bug.cgi?id=175765

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Tests for these have been removed in WPT master, just update expectations until new version is imported.

• web-platform-tests/dom/nodes/Element-matches-expected.txt:
• web-platform-tests/dom/nodes/Element-webkitMatchesSelector-expected.txt:
• web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
• web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:

Source/WebCore:

This is an alternative syntax for the normal descendant combinator (just space) that was
advertised as being consistent with > (child combinator) and >>> (shadow piercing combinator).
The latter has been killed so it is not consistent with anything anymore.

No other engine besides WebKit has implemented this and the WPT tests have been removed
(in ​https://github.com/w3c/web-platform-tests/pull/6785). Full removal from spec is still
open (​https://github.com/w3c/csswg-drafts/issues/641) but we shouldn't encourage adoption of
this pointless feature.

While this has shipped the compatibility risk is low as no other engine implemented it and
there were no incentives to use it over the standard syntax.

• css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

• css/CSSSelector.h:

(WebCore::CSSSelector::hasDescendantRelation const):

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::matchRecursively const):

• css/SelectorFilter.cpp:

(WebCore::SelectorFilter::collectIdentifierHashes):

• css/parser/CSSParserSelector.cpp:

(WebCore::CSSParserSelector::appendTagHistory):

• css/parser/CSSParserSelector.h:
• css/parser/CSSSelectorParser.cpp:

(WebCore::isDescendantCombinator):
(WebCore::CSSSelectorParser::consumeCombinator):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::fragmentRelationForSelectorRelation):

LayoutTests:

• fast/css/ancestor-of-hovered-element-removed.html:
• fast/css/css-selector-text-expected.txt:
• fast/css/css-selector-text.html:
• fast/css/css-set-selector-text-expected.txt:
• fast/css/css-set-selector-text.html:
• fast/css/currentColor-value-style-update.html:
• fast/css/descendant-combinator-doubled-child-syntax-styling-expected.html: Removed.
• fast/css/descendant-combinator-doubled-child-syntax-styling.html: Removed.
• fast/css/parsing-css-attribute-case-insensitive-value-1-expected.txt:
• fast/css/parsing-css-attribute-case-insensitive-value-1.html:
• fast/css/parsing-css-attribute-case-insensitive-value-4-expected.txt:
• fast/css/parsing-css-attribute-case-insensitive-value-4.html:
• fast/css/parsing-css-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
• fast/css/parsing-css-descendant-combinator-doubled-child-syntax.html: Removed.
• fast/selectors/case-insensitive-attribute-register-requirement-2.html:
• fast/selectors/element-closest-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
• fast/selectors/element-closest-descendant-combinator-doubled-child-syntax.html: Removed.
• fast/selectors/element-matches-attribute-ascii-case-insensitive-html.html:
• fast/selectors/element-matches-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
• fast/selectors/element-matches-descendant-combinator-doubled-child-syntax.html: Removed.
• fast/selectors/id-attribute-querySelector-used-as-id-selector-quirks.html:
• fast/selectors/id-attribute-querySelector-used-as-id-selector.html:
• fast/selectors/nth-child-matching-first.html:
• fast/selectors/nth-last-child-matching-first.html:
• fast/selectors/querySelector-attribute-ascii-case-insensitive-html.html:
• fast/selectors/querySelector-descendant-combinator-doubled-child-syntax-expected.txt: Removed.
• fast/selectors/querySelector-descendant-combinator-doubled-child-syntax.html: Removed.

9:19 AM Changeset in webkit [221787] by Ryan Haddad

• 9 edits in trunk/Source/WebKit

Unreviewed, rolling out r221771.

This change caused two API tests to crash.

Reverted changeset:

"Clean up API::UIClient"
​https://bugs.webkit.org/show_bug.cgi?id=176568
​http://trac.webkit.org/changeset/221771

9:03 AM Changeset in webkit [221786] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/websocket/tests/hybi/close-code-and-reason.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176609.

Unreviewed test gardening.

• platform/win/TestExpectations:

8:57 AM Changeset in webkit [221785] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/preload/single_download_preload_headers.php as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176606.

Unreviewed test gardening.

• platform/win/TestExpectations:

8:43 AM Changeset in webkit [221784] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark http/tests/security/contentSecurityPolicy/audio-redirect-allowed2.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176598.

Unreviewed test gardening.

• platform/win/TestExpectations:

8:36 AM Changeset in webkit [221783] by Yusuke Suzuki

• 10 edits
  4 adds in trunk

[DFG][FTL] GetByVal(ObjectUse with Array::Generic, StringUse/SymbolUse) should be supported
​https://bugs.webkit.org/show_bug.cgi?id=176590

Reviewed by Saam Barati.

JSTests:

• microbenchmarks/object-iterate-symbols.js: Added.

(test):

• microbenchmarks/object-iterate.js: Added.

(test):

• stress/object-iterate-symbols.js: Added.

(shouldBe):
(test):

• stress/object-iterate.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

We add fixup edges for GetByVal(Array::Generic) to call faster operation instead of generic operationGetByVal.

baseline patched

object-iterate 5.8531+-0.3029 5.7903+-0.2795 might be 1.0108x faster
object-iterate-symbols 7.4099+-0.3993 ^{5.8254+-0.2276} definitely 1.2720x faster

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGOperations.cpp:

(JSC::DFG::getByValObject):

• dfg/DFGOperations.h:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValForObjectWithString):
(JSC::DFG::SpeculativeJIT::compileGetByValForObjectWithSymbol):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

8:06 AM WebKitGTK/Gardening/Calendar edited by zandobersek@gmail.com

(diff)

3:57 AM Changeset in webkit [221782] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[GStreamer] initializationDataEncountered() dispatch can outlive MediaPlayerPrivateGStreamerBase
​https://bugs.webkit.org/show_bug.cgi?id=176544

Reviewed by Xabier Rodriguez-Calvar.

The RunLoop dispatch that invokes MediaPlayer::initializationDataEncountered()
can outlive the MediaPlayerPrivateGStreamerBase object that is referenced
from the dispatched functor. To avoid this, a WeakPtrFactory is placed onto
MediaPlayerPrivateGStreamerBase and a WeakPtr object is kept in the functor,
bailing during dispatch if the factory (along with MediaPlayerPrivateGStreamerBase)
has already been destroyed since the schedule of this dispatch.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Also remove the unused sessionId string.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

3:55 AM Changeset in webkit [221781] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[GStreamer] Add GRefPtr specializations for GstGLDisplay, GstGLContext
​https://bugs.webkit.org/show_bug.cgi?id=176543

Reviewed by Xabier Rodriguez-Calvar.

Both GstGLDisplay and GstGLContext inherit from GstObject, meaning
gst_object_ref_sink() and gst_object_unref() should be used for
incrementing and decrementing reference count. Template specializations
for the adoptGRef(), refGPtr() and derefGPtr() are added for both types,
preventing GRefPtr<> from falling back to using g_object_ref() and
g_object_unref() for reference count modification purposes.

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::adoptGRef):
(WTF::refGPtr<GstGLDisplay>):
(WTF::derefGPtr<GstGLDisplay>):
(WTF::refGPtr<GstGLContext>):
(WTF::derefGPtr<GstGLContext>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h:

3:54 AM Changeset in webkit [221780] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Incorrect GstCaps unreffing in GStreamerEMEUtilities::createDecryptor()
​https://bugs.webkit.org/show_bug.cgi?id=176540

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:

Include the GRefPtrGStreamer.h header in order to use specialized template
functions that correctly adopt and dereference GstCaps object that is
wrapped the GRefPtr<>.

Sep 7, 2017:

11:31 PM Changeset in webkit [221779] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK][WPE] UI process crash in WebBackForwardList::restoreFromState
​https://bugs.webkit.org/show_bug.cgi?id=176303

Reviewed by Michael Catanzaro.

Ensure the current index provided by the session state is not out of actual item list bounds. This is a bug in
the session state decoder, but WebBackForwardList::backForwardListState() is already doing the check and using
the last item index instead, so it's not easy to know where the actual problem is. In any case we should
still protect the decoder.

• UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(decodeSessionState):

11:21 PM Changeset in webkit [221778] by commit-queue@webkit.org

• 8 edits
  2 adds in trunk

WebKit should claim that it can show responses for a broader range of JSON MIMETypes
​https://bugs.webkit.org/show_bug.cgi?id=176252
<rdar://problem/34212885>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-07
Reviewed by Ryosuke Niwa.

Source/WebCore:

• platform/MIMETypeRegistry.h:
• platform/MIMETypeRegistry.cpp:

(WebCore::MIMETypeRegistry::canShowMIMEType):
Extend this to support JavaScript and JSON MIMETypes that WebKit
knows how to treat as text.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm: Added.

(-[WKNavigationResponseTestNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[WKNavigationResponseTestNavigationDelegate webView:didCommitNavigation:]):
(-[WKNavigationResponseTestSchemeHandler webView:startURLSchemeTask:]):
(-[WKNavigationResponseTestSchemeHandler webView:stopURLSchemeTask:]):
(TEST):
Test for canShowMIMEType with multiple JSON mime types and a garbage mime type.
Previously canShowMIMEType would have been YES for "application/json" but
NO for "application/vnd.api+json". Now it shows YES for both.

• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/PlatformWPE.cmake:
• TestWebKitAPI/PlatformWin.cmake:
• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/MIMETypeRegistry.cpp: Added.

(TestWebKitAPI::TEST):
Tests for MIMETypeRegistry's dynamic JSON mime type detection.

7:58 PM Changeset in webkit [221777] by commit-queue@webkit.org

• 1 edit
  15 adds in trunk/Tools

Add Live PLT implemented with WebDriver
​https://bugs.webkit.org/show_bug.cgi?id=176436

Patch by Matthew Stewart <​matthew_r_stewart@apple.com> on 2017-09-07
Reviewed by Stephanie Lewis.

Adds a new PLT that runs on live websites.

• Scripts/run-webdriver-plt.py: Added.

(parse_args):
(start):
(make_suites):
(main):

• Scripts/webkitpy/webdriver_plt/init.py: Added.
• Scripts/webkitpy/webdriver_plt/liveplt.py: Added.

(PageLoadTest):
(PageLoadTest.init):
(PageLoadTest.start):
(PageLoadTest.run_suite):
(PageLoadTest._get_driver_for_browser):
(PageLoadTest._setup_browser_window):
(PageLoadTest.run_one_test):
(PageLoadTest.get_results):

• Scripts/webkitpy/webdriver_plt/pltresults.py: Added.

(PLTResults):
(PLTResults.init):
(PLTResults.add):
(PLTResults.add_timing_result):
(PLTResults.mean):
(PLTResults.geometric_mean):
(PLTResults.mean_coef_variance):
(PLTResults.print_results):
(PLTResults.print_url_results):
(PLTResults._format_time):

• Scripts/webkitpy/webdriver_plt/suites/init.py: Added.
• Scripts/webkitpy/webdriver_plt/suites/arabic.suite: Added.
• Scripts/webkitpy/webdriver_plt/suites/cjk.suite: Added.
• Scripts/webkitpy/webdriver_plt/suites/news.suite: Added.
• Scripts/webkitpy/webdriver_plt/suites/search.suite: Added.
• Scripts/webkitpy/webdriver_plt/suites/shopping.suite: Added.
• Scripts/webkitpy/webdriver_plt/suites/social.suite: Added.
• Scripts/webkitpy/webdriver_plt/suites/suite.py: Added.

(Suite):
(Suite.init):
(Suite.get_available_suites):

• Scripts/webkitpy/webdriver_plt/urlresults.py: Added.

(URLResults):
(URLResults.init):
(URLResults.add):
(URLResults.mean):
(URLResults.coef_variance):
(URLResults.print_results):
(URLResults._format_time):

7:57 PM Changeset in webkit [221776] by mmaxfield@apple.com

• 12 edits
  1 copy in trunk/Tools

Add "if" statements to WSL
​https://bugs.webkit.org/show_bug.cgi?id=176294

Reviewed by Filip Pizlo.

Fairly straightforward implementation. ReturnChecker only returns true iff there is an else block,
and both the if body and the else body recursively return true.

In order to accept both syntaxes:
if (foo)

bar;

... and ...
if (foo) {

bar;

}
This patch lets parseStatement() call parseBlock(). This means that the following is valid:
int x = 7;
if (foo) {

int x = 8;
x is 8 here!

}
x is 7 here!

This production means that these blocks don't require "if" statements, so you can just have:
int foo() {

int x = 7;
{

int x = 8;
x is 8 here!

}
x is 7 here!

}

However, this patch doesn't touch the following use-case:
if (int x = bar()) {

use x here

}

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitIfStatement):

• WebGPUShadingLanguageRI/IfStatement.js: Copied from Tools/WebGPUShadingLanguageRI/TypeDef.js.

(IfStatement):
(IfStatement.prototype.get origin):
(IfStatement.prototype.get conditional):
(IfStatement.prototype.get body):
(IfStatement.prototype.get elseBody):
(IfStatement.prototype.toString):

• WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitIfStatement):

• WebGPUShadingLanguageRI/Parse.js:

(parseTypeParameters):
(parseIfStatement):
(parseStatement):

• WebGPUShadingLanguageRI/ReturnChecker.js:

(ReturnChecker.prototype.visitIfStatement):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitIfStatement):
(Rewriter):

• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(TEST_variableShadowing):
(TEST_ifStatement):
(TEST_ifElseStatement):
(TEST_ifElseIfStatement):
(TEST_ifElseIfElseStatement):
(TEST_returnIf):
(TEST_protocolMonoPolySigDoublePolyDefExplicit): Deleted.

• WebGPUShadingLanguageRI/TypeDef.js:

(TypeDef.prototype.toString):
(TypeDef):

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitIfStatement):

6:49 PM Changeset in webkit [221775] by Lucas Forschler

• 1 edit in trunk/Tools/ChangeLog

Test commit after server upgrade from subversion 1.9.5 to 1.9.7

6:14 PM Changeset in webkit [221774] by mark.lam@apple.com

• 35 edits
  1 add in trunk/Source/JavaScriptCore

Use JIT probes for DFG OSR exit.
​https://bugs.webkit.org/show_bug.cgi?id=175144
<rdar://problem/33437050>

Reviewed by Saam Barati.

This patch does the following:

1. Replaces osrExitGenerationThunkGenerator() with osrExitThunkGenerator(). While osrExitGenerationThunkGenerator() generates a thunk that compiles a unique OSR offramp for each DFG OSR exit site, osrExitThunkGenerator() generates a thunk that just executes the OSR exit.

The osrExitThunkGenerator() generated thunk works by using a single JIT probe
to call OSRExit::executeOSRExit(). The JIT probe takes care of preserving
CPU registers, and providing the Probe::Stack mechanism for modifying the
stack frame.

OSRExit::executeOSRExit() replaces OSRExit::compileOSRExit() and
OSRExit::compileExit(). It is basically a re-write of those functions to
execute the OSR exit work instead of compiling code to execute the work.

As a result, we get the following savings:

1. no more OSR exit ramp compilation time.
2. no use of JIT executable memory for storing each unique OSR exit ramp.

On the negative side, we incur these costs:

3. the OSRExit::executeOSRExit() ramp may be a little slower than the compiled version of the ramp. However, OSR exits are rare. Hence, this small difference should not matter much. It is also offset by the savings from (a).

4. the Probe::Stack allocates 1K pages for memory for buffering stack modifcations. The number of these pages depends on the span of stack memory that the OSR exit ramp reads from and writes to. Since the OSR exit ramp tends to only modify values in the current DFG frame and the current VMEntryRecord, the number of pages tends to only be 1 or 2.

Using the jsc tests as a workload, the vast majority of tests that do OSR
exit, uses 3 or less 1K pages (with the overwhelming number using just 1 page).
A few tests that are pathological uses up to 14 pages, and one particularly
bad test (function-apply-many-args.js) uses 513 pages.

Similar to the old code, the OSR exit ramp still has 2 parts: 1 part that is
only executed once to compute some values for the exit site that is used by
all exit operations from that site, and a 2nd part to execute the exit. The
1st part is protected by a checking if exit.exitState has already been
initialized. The computed values are cached in exit.exitState.

Because the OSR exit thunk no longer compiles an OSR exit off-ramp, we no
longer need the facility to patch the site that jumps to the OSR exit ramp.
The DFG::JITCompiler has been modified to remove this patching code.

2. Fixed the bottom most Probe::Context and Probe::Stack get/set methods to use std::memcpy to avoid strict aliasing issues.

Also optimized the implementation of Probe::Stack::physicalAddressFor().

3. Miscellaneous convenience methods added to make the Probe::Context easier of use.

4. Added a Probe::Frame class that makes it easier to get/set operands and arguments in a given frame using the deferred write properties of the Probe::Stack. Probe::Frame makes it easier to do some of the recovery work in the OSR exit ramp.

5. Cloned or converted some functions needed by the OSR exit ramp. The original JIT versions of these functions are still left in place because they are still needed for FTL OSR exit. A FIXME comment has been added to remove them later. These functions include:

DFGOSRExitCompilerCommon.cpp's handleExitCounts() ==>

CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize()

DFGOSRExitCompilerCommon.cpp's reifyInlinedCallFrames() ==>

DFGOSRExit.cpp's reifyInlinedCallFrames()

DFGOSRExitCompilerCommon.cpp's adjustAndJumpToTarget() ==>

DFGOSRExit.cpp's adjustAndJumpToTarget()

MethodOfGettingAValueProfile::emitReportValue() ==>

MethodOfGettingAValueProfile::reportValue()

DFGOperations.cpp's operationCreateDirectArgumentsDuringExit() ==>

DFGOSRExit.cpp's createDirectArgumentsDuringExit()

DFGOperations.cpp's operationCreateClonedArgumentsDuringExit() ==>

DFGOSRExit.cpp's createClonedArgumentsDuringExit()

• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):

• assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

• assembler/ProbeContext.h:

(JSC::Probe::CPUState::gpr const):
(JSC::Probe::CPUState::spr const):
(JSC::Probe::Context::Context):
(JSC::Probe::Context::arg):
(JSC::Probe::Context::gpr):
(JSC::Probe::Context::spr):
(JSC::Probe::Context::fpr):
(JSC::Probe::Context::gprName):
(JSC::Probe::Context::sprName):
(JSC::Probe::Context::fprName):
(JSC::Probe::Context::gpr const):
(JSC::Probe::Context::spr const):
(JSC::Probe::Context::fpr const):
(JSC::Probe::Context::pc):
(JSC::Probe::Context::fp):
(JSC::Probe::Context::sp):
(JSC::Probe:: const): Deleted.

• assembler/ProbeFrame.h: Added.

(JSC::Probe::Frame::Frame):
(JSC::Probe::Frame::getArgument):
(JSC::Probe::Frame::getOperand):
(JSC::Probe::Frame::get):
(JSC::Probe::Frame::setArgument):
(JSC::Probe::Frame::setOperand):
(JSC::Probe::Frame::set):

• assembler/ProbeStack.cpp:

(JSC::Probe::Page::Page):

• assembler/ProbeStack.h:

(JSC::Probe::Page::get):
(JSC::Probe::Page::set):
(JSC::Probe::Page::physicalAddressFor):
(JSC::Probe::Stack::lowWatermark):
(JSC::Probe::Stack::get):
(JSC::Probe::Stack::set):

• bytecode/ArithProfile.cpp:
• bytecode/ArithProfile.h:
• bytecode/ArrayProfile.h:

(JSC::ArrayProfile::observeArrayMode):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateOSRExitCounterAndCheckIfNeedToReoptimize):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::addressOfOSRExitCounter): Deleted.

• bytecode/ExecutionCounter.h:

(JSC::ExecutionCounter::hasCrossedThreshold const):
(JSC::ExecutionCounter::setNewThresholdForOSRExit):

• bytecode/MethodOfGettingAValueProfile.cpp:

(JSC::MethodOfGettingAValueProfile::reportValue):

• bytecode/MethodOfGettingAValueProfile.h:
• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::findPC): Deleted.

• dfg/DFGJITCode.h:
• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::jsValueFor):
(JSC::DFG::restoreCalleeSavesFor):
(JSC::DFG::saveCalleeSavesFor):
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer):
(JSC::DFG::saveOrCopyCalleeSavesFor):
(JSC::DFG::createDirectArgumentsDuringExit):
(JSC::DFG::createClonedArgumentsDuringExit):
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::emitRestoreArguments):
(JSC::DFG::OSRExit::executeOSRExit):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):
(JSC::DFG::printOSRExit):
(JSC::DFG::OSRExit::setPatchableCodeOffset): Deleted.
(JSC::DFG::OSRExit::getPatchableCodeOffsetAsJump const): Deleted.
(JSC::DFG::OSRExit::codeLocationForRepatch const): Deleted.
(JSC::DFG::OSRExit::correctJump): Deleted.
(JSC::DFG::OSRExit::emitRestoreArguments): Deleted.
(JSC::DFG::OSRExit::compileOSRExit): Deleted.
(JSC::DFG::OSRExit::compileExit): Deleted.
(JSC::DFG::OSRExit::debugOperationPrintSpeculationFailure): Deleted.

• dfg/DFGOSRExit.h:

(JSC::DFG::OSRExitState::OSRExitState):
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSite):

• dfg/DFGOSRExitCompilerCommon.cpp:
• dfg/DFGOSRExitCompilerCommon.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGThunks.cpp:

(JSC::DFG::osrExitThunkGenerator):
(JSC::DFG::osrExitGenerationThunkGenerator): Deleted.

• dfg/DFGThunks.h:
• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::debugCall): Deleted.

• jit/AssemblyHelpers.h:
• jit/JITOperations.cpp:
• jit/JITOperations.h:
• profiler/ProfilerOSRExit.h:

(JSC::Profiler::OSRExit::incCount):

• runtime/JSCJSValue.h:
• runtime/JSCJSValueInlines.h:
• runtime/VM.h:

5:24 PM Changeset in webkit [221773] by aestes@apple.com

• 11 edits in trunk/Source

[Mac] Upstream QTKit-related WebKitSystemInterface functions
​https://bugs.webkit.org/show_bug.cgi?id=176472

Reviewed by Eric Carlson.

Source/WebCore:

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::disableComponentsOnce):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions const):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::selectPreferredAlternateTrackForMediaType):
(WebCore::selectPreferredAlternates):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::mimeModernTypesCache):
(WebCore::MediaPlayerPrivateQTKit::originsInMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCache):
(WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForOrigins):
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin const):
(WebCore::MediaPlayerPrivateQTKit::movieLoadType const):
(WebCore::MediaPlayerPrivateQTKit::canSaveMediaData const):

• platform/mac/WebCoreSystemInterface.h:
• platform/mac/WebCoreSystemInterface.mm:
• platform/mac/WebVideoFullscreenHUDWindowController.mm:

(createMediaUIControl):
(createControlWithMediaUIControlType):
(createMediaUIBackgroundView):
(-[WebVideoFullscreenHUDWindowController windowDidLoad]):

Source/WebCore/PAL:

• pal/spi/mac/QTKitSPI.h:

Source/WebKit:

• WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKitLegacy/mac:

• WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

4:23 PM Changeset in webkit [221772] by commit-queue@webkit.org

• 24 edits in trunk

Align FetchResponse and FetchRequest body handling
​https://bugs.webkit.org/show_bug.cgi?id=176539

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-07
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-idl-expected.txt:
• web-platform-tests/fetch/api/request/request-structure-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-empty-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/url/urlencoded-parser-expected.txt:

Source/WebCore:

Covered by rebased tests.

Removing most of FetchResponse JS Builtins now that ReadableStream has full support.
Implementing FetchResponse body cloning through ReadableStream.
Cloning a loading FetchResponse still requires to create a ReadableStream for the purpose of teeing.

Moving exposure of the body from FetchResponse to FetchBodyOwner.
This is controlled by a boolean flag set according response tainting.

Moving handling of body ReadableStream consuming from FetchResponse to FetchBodyConsumer.
For that purpose, a loading boolean flag is added to FetchBodyConsumer so that it will resolve consume promises
when loading is finished.

Added support for getting a body in case the request/response body is already consumed.
In that case, a locked ReadableStream is returned.

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::doMatch):
(WebCore::DOMCache::matchAll):

• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::FetchBody):

• Modules/fetch/FetchBody.idl:
• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::resolve):
(WebCore::FetchBodyConsumer::loadingFailed):
(WebCore::FetchBodyConsumer::loadingSucceeded):

• Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::setAsLoading):

• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
(WebCore::FetchBodyOwner::readableStream):

• Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::isBodyNullOrOpaque const):
(WebCore::FetchBodyOwner::setBodyAsOpaque):
(WebCore::FetchBodyOwner::isBodyOpaque const):

• Modules/fetch/FetchInternals.js:

(fillFetchHeaders):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::setBodyData):
(WebCore::FetchResponse::consumeChunk):
(WebCore::FetchResponse::consumeBodyAsStream):

• Modules/fetch/FetchResponse.h:
• Modules/fetch/FetchResponse.idl:
• Modules/fetch/FetchResponse.js:

(initializeFetchResponse):

• bindings/js/ReadableStream.cpp:

(WebCore::ReadableStream::create):
(WebCore::ReadableStream::lock):

• bindings/js/ReadableStream.h:
• bindings/js/WebCoreBuiltinNames.h:

4:18 PM Changeset in webkit [221771] by achristensen@apple.com

• 9 edits in trunk/Source/WebKit

Clean up API::UIClient
​https://bugs.webkit.org/show_bug.cgi?id=176568

Reviewed by Brady Eidson.

We don't need createNewPage and createNewPageAsync.
An async version can support synchronous delegate calls by just calling the completion handler synchronously.

• UIProcess/API/APIUIClient.h:

(API::UIClient::createNewPage):
(API::UIClient::createNewPageAsync): Deleted.
(API::UIClient::canCreateNewPageAsync): Deleted.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/glib/WebKitUIClient.cpp:
• UIProcess/API/glib/WebKitUIClient.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::createNewPageCommon): Deleted.
(WebKit::UIDelegate::UIClient::canCreateNewPageAsync): Deleted.
(WebKit::UIDelegate::UIClient::createNewPageAsync): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::createNewPage):

• UIProcess/WebPageProxy.h:

4:16 PM Changeset in webkit [221770] by achristensen@apple.com

• 6 edits in trunk/Source/WebKit

Make DragControllerAction an enum class
​https://bugs.webkit.org/show_bug.cgi?id=176565

Reviewed by Andy Estes.

• Shared/DragControllerAction.h:

(): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::dragEntered):
(WebKit::WebPageProxy::dragUpdated):
(WebKit::WebPageProxy::dragExited):
(WebKit::WebPageProxy::performDragOperation):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::performDragControllerAction):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

4:13 PM Changeset in webkit [221769] by msaboff@apple.com

• 18 edits
  3 adds in trunk

Add support for RegExp named capture groups
​https://bugs.webkit.org/show_bug.cgi?id=176435

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Added parsing for both naming a captured parenthesis as well and using a named group in
a back reference. Also added support for using named groups with String.prototype.replace().

This patch does not throw Syntax Errors as described in the current spec text for the two
cases of malformed back references in String.prototype.replace() as I believe that it
is inconsistent with the current semantics for handling of other malformed replacement
tokens. I filed an issue for the requested change to the proposed spec and also filed
a FIXME bug ​https://bugs.webkit.org/show_bug.cgi?id=176434.

This patch does not implement strength reduction in the optimizing JITs for named capture
groups. Filed ​https://bugs.webkit.org/show_bug.cgi?id=176464.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

• runtime/CommonIdentifiers.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::haveABadTime):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpMatchesArrayWithGroupsStructure const):

• runtime/RegExp.cpp:

(JSC::RegExp::finishCreation):

• runtime/RegExp.h:
• runtime/RegExpMatchesArray.cpp:

(JSC::createStructureImpl):
(JSC::createRegExpMatchesArrayWithGroupsStructure):
(JSC::createRegExpMatchesArrayWithGroupsSlowPutStructure):

• runtime/RegExpMatchesArray.h:

(JSC::createRegExpMatchesArray):

• runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):
(JSC::replaceUsingRegExpSearch):

• yarr/YarrParser.h:

(JSC::Yarr::Parser::CharacterClassParserDelegate::atomNamedBackReference):
(JSC::Yarr::Parser::parseEscape):
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::tryConsumeUnicodeEscape):
(JSC::Yarr::Parser::tryConsumeIdentifierCharacter):
(JSC::Yarr::Parser::isIdentifierStart):
(JSC::Yarr::Parser::isIdentifierPart):
(JSC::Yarr::Parser::tryConsumeGroupName):

• yarr/YarrPattern.cpp:

(JSC::Yarr::YarrPatternConstructor::atomParenthesesSubpatternBegin):
(JSC::Yarr::YarrPatternConstructor::atomNamedBackReference):
(JSC::Yarr::YarrPattern::errorMessage):

• yarr/YarrPattern.h:

(JSC::Yarr::YarrPattern::reset):

• yarr/YarrSyntaxChecker.cpp:

(JSC::Yarr::SyntaxChecker::atomParenthesesSubpatternBegin):
(JSC::Yarr::SyntaxChecker::atomNamedBackReference):

Source/WebCore:

Implemented stub routines to support named capture groups. These are no-ops
just like for number capture group.

No new tests as this is covered by existing tests.

• contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::PatternParser::atomNamedBackReference):
(WebCore::ContentExtensions::PatternParser::atomParenthesesSubpatternBegin):

LayoutTests:

New regression tests.

• js/regexp-named-capture-groups-expected.txt: Added.
• js/regexp-named-capture-groups.html: Added.
• js/script-tests/regexp-named-capture-groups.js: Added.

4:11 PM Changeset in webkit [221768] by mmaxfield@apple.com

• 44 edits
  5 moves
  1 delete in trunk/Source

[PAL] Unify PlatformUserPreferredLanguages.h with Language.h
​https://bugs.webkit.org/show_bug.cgi?id=176561

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

• runtime/IntlObject.cpp:

(JSC::defaultLocale):

Source/WebCore:

No new tests because there is no behavior change.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• accessibility/AccessibilitySVGElement.cpp:
• bindings/js/JSDOMWindowBase.cpp:
• bindings/js/JSWorkerGlobalScopeBase.cpp:
• dom/Document.cpp:
• html/HTMLInputElement.cpp:
• html/HTMLMediaElement.cpp:
• html/shadow/MediaControlElements.cpp:
• html/track/TrackBase.cpp:
• page/CaptionUserPreferences.cpp:
• page/CaptionUserPreferencesMediaAF.cpp:
• page/DOMWindow.cpp:
• page/Navigator.cpp:
• page/NavigatorBase.cpp:
• platform/graphics/FontGenericFamilies.cpp:
• platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:
• platform/network/HTTPParsers.cpp:
• platform/text/PlatformLocale.h:
• platform/text/cf/HyphenationCF.cpp:
• platform/text/mac/LocaleMac.mm:
• svg/SVGTests.cpp:
• testing/InternalSettings.cpp:
• testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::userPreferredLanguages const):
(WebCore::Internals::setUserPreferredLanguages):

Source/WebKit:

• UIProcess/WebProcessPool.cpp:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::userPreferredLanguagesChanged const):

Source/WebKitLegacy/mac:

• Misc/WebNSUserDefaultsExtras.mm:

Source/WTF:

WebCore/platform/Language was the only* user of PlatformUserPreferredLanguages (with 1 exception).
That exception is that JavaScriptCore needed the functionality of WebCore/platform/Language, but it
couldn't get it because of the layering violation, so instead it erroneously called into
PlatformUserPreferredLanguages instead. This patch merges these two files into WTF so JSC gets the
right function and the PAL effort has one less file to move from WebCore/platform into PAL.

• WTF.xcodeproj/project.pbxproj:
• wtf/CMakeLists.txt:
• wtf/Language.cpp: Renamed from Source/WebCore/platform/Language.cpp.

(WTF::addLanguageChangeObserver):
(WTF::userPreferredLanguages):

• wtf/Language.h: Renamed from Source/WebCore/platform/Language.h.
• wtf/PlatformGTK.cmake:
• wtf/PlatformJSCOnly.cmake:
• wtf/PlatformMac.cmake:
• wtf/PlatformUserPreferredLanguages.h: Removed.
• wtf/PlatformWPE.cmake:
• wtf/PlatformWin.cmake:
• wtf/cf/LanguageCF.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesMac.mm.

(WTF::httpStyleLanguageCode):
(WTF::languagePreferencesDidChange):
(WTF::platformUserPreferredLanguages):

• wtf/unix/LanguageUnix.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesUnix.cpp.
• wtf/win/LanguageWin.cpp: Renamed from Source/WTF/wtf/PlatformUserPreferredLanguagesWin.cpp.

4:06 PM Changeset in webkit [221767] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Remove entry from CacheStorageEngineConnection lock map when unlocking a Cache
​https://bugs.webkit.org/show_bug.cgi?id=176548

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-07
Reviewed by Alex Christensen.

• NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::dereference):

3:49 PM Changeset in webkit [221766] by Chris Dumez

• 16 edits in trunk

[WK2] Add C API to retrieve the originating page of a WKDownload
​https://bugs.webkit.org/show_bug.cgi?id=176557
<rdar://problem/34314776>

Reviewed by Alex Christensen.

Source/WebKit:

Add C API to retrieve the original page of a WKDownload. This is the C API equivalent to
_WKDownload.originatingWebView which already exists in ObjC. The pointer is weak so as
to not keep alive the page for the duration of the download.

• UIProcess/API/C/WKDownload.cpp:

(WKDownloadGetOriginatingPage):

• UIProcess/API/C/WKDownload.h:
• UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload originatingWebView]):

• UIProcess/API/Cocoa/_WKDownloadInternal.h:
• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::originatingPage const):
(WebKit::DownloadProxy::setOriginatingPage):

• UIProcess/Downloads/DownloadProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::createDownloadProxy):

• UIProcess/WebProcessPool.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::handleDownloadRequest):

• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::handleDownloadRequest):

Tools:

Add layout test coverage for both the ObjC and C API.

• TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:

(TestWebKitAPI::decideDestinationWithSuggestedFilename):
(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[RedirectedDownloadDelegate _downloadDidStart:]):
(TEST):

3:22 PM Changeset in webkit [221765] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Augmented Inspector: Provide a way to inspect a DOM Node (DOM.inspect)
​https://bugs.webkit.org/show_bug.cgi?id=176563
<rdar://problem/19639583>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-07
Reviewed by Matt Baker.

Source/JavaScriptCore:

• inspector/protocol/DOM.json:

Add an event that is useful for augmented inspectors to inspect
a node. Web pages will still prefer Inspector.inspect.

Source/WebInspectorUI:

• UserInterface/Base/Main.js:

(WI.contentLoaded):
Always create the element search toolbar icon. Only show it if the DOM domain
is available. With augmented agents the DOM domain may be activated later.

• UserInterface/Protocol/DOMObserver.js:

(WI.DOMObserver.prototype.inspect):
Select the node in the DOM tree outline.

LayoutTests:

• inspector/dom/inspect-expected.txt: Added.
• inspector/dom/inspect.html: Added.

Test the frontend on receiving DOM.inspect events.

3:20 PM Changeset in webkit [221764] by achristensen@apple.com

• 17 edits in trunk/Source/WebKit

Clean up Geolocation request handling
​https://bugs.webkit.org/show_bug.cgi?id=176562

Reviewed by Tim Horton.

Instead of passing a GeolocationPermissionRequestProxy& to each client and returning a bool if the request will be handled,
pass a Function<void(bool)>&& completionHandler and return the function if it won't be handled.
This allows to temporarily support our UIClient/PageClient hybrid design while moving towards a sane design.

• UIProcess/API/APIUIClient.h:

(API::UIClient::Function<void):
(API::UIClient::decidePolicyForGeolocationPermissionRequest): Deleted.

• UIProcess/API/C/WKAPICast.h:
• UIProcess/API/C/WKGeolocationPermissionRequest.cpp:

(WKGeolocationPermissionRequestGetTypeID):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/GeolocationPermissionRequestProxy.cpp:

(WebKit::GeolocationPermissionRequestProxy::allow):
(WebKit::GeolocationPermissionRequestProxy::deny):
(WebKit::GeolocationPermissionRequestProxy::invalidate):

• UIProcess/GeolocationPermissionRequestProxy.h:

(WebKit::GeolocationPermissionRequest::create):
(WebKit::GeolocationPermissionRequest::allow):
(WebKit::GeolocationPermissionRequest::deny):
(WebKit::GeolocationPermissionRequest::GeolocationPermissionRequest):

• UIProcess/PageClient.h:

(WebKit::PageClient::decidePolicyForGeolocationPermissionRequest): Deleted.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

• UIProcess/ios/PageClientImplIOS.h:
• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::Function<void):
(WebKit::PageClientImpl::decidePolicyForGeolocationPermissionRequest): Deleted.

• UIProcess/ios/WKContentView.h:
• UIProcess/ios/WKGeolocationProviderIOS.h:
• UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:completionHandler:view:]):
(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):
(-[WKGeolocationProviderIOS geolocationAuthorizationDenied]):
(-[WKWebAllowDenyPolicyListener initWithCompletionHandler:]):
(-[WKWebAllowDenyPolicyListener allow]):
(-[WKWebAllowDenyPolicyListener deny]):
(-[WKGeolocationProviderIOS decidePolicyForGeolocationRequestFromOrigin:frame:request:view:]): Deleted.
(-[WKWebAllowDenyPolicyListener initWithPermissionRequestProxy:]): Deleted.

3:08 PM Changeset in webkit [221763] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Marked http/tests/misc/delete-frame-during-readystatechange.html as flaky on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=176564

Unreviewed test gardening.

• platform/win/TestExpectations:

3:01 PM Changeset in webkit [221762] by dino@apple.com

• 11 edits
  6 adds in trunk

[WebGL] accelerated texImage2D for video doesn't respect flipY
​https://bugs.webkit.org/show_bug.cgi?id=176491
<rdar://problem/33833511>

Reviewed by Jer Noble.

Source/WebCore:

Previously, if UNPACK_FLIP_Y_WEBGL was set to true, we'd either fall
back to software or fail to upload texture data. Fix this by intercepting
the texImage2D call, checking the orientation of the video, and running
a small shader program to flip it if necessary.

While there, implement UNPACK_PREMULTIPLY_ALPHA_WEBGL as well, although
none of our media decoders support video with alpha, so unfortunately
this will have no visible change.

Tests: fast/canvas/webgl/texImage2D-video-flipY-false.html

fast/canvas/webgl/texImage2D-video-flipY-true.html

• platform/cocoa/CoreVideoSoftLink.cpp: Add link to CVOpenGL(ES)TextureGetCleanTexCoords,

which is used to check the orientation of the source video.

• platform/cocoa/CoreVideoSoftLink.h:

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::copyVideoTextureToPlatformTexture): We can
now handle flipped or premultiplied requests.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::copyVideoTextureToPlatformTexture): Ditto.

• platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::VideoTextureCopierCV): Rename readFramebuffer to
simply framebuffer.
(WebCore::VideoTextureCopierCV::~VideoTextureCopierCV): Delete the program and buffer
if they were created.
(WebCore::VideoTextureCopierCV::initializeContextObjects): Sets up the shader program
and the vertex buffer for drawing. Also records the location of the uniforms.
(WebCore::VideoTextureCopierCV::copyVideoTextureToPlatformTexture): Create a new
framebuffer object, and render the video texture into that framebuffer using a
shader that can flip the coordinates.
(WebCore::VideoTextureCopierCV::GC3DStateSaver::GC3DStateSaver): Helper to restore
the state of the user's GraphicsContext3D while we're intercepting calls.
(WebCore::VideoTextureCopierCV::GC3DStateSaver::~GC3DStateSaver):

• platform/graphics/cv/VideoTextureCopierCV.h:

• platform/graphics/GraphicsContext3D.h: Add two new entry points, for direct shader

compilation and attribute access. This avoids going through ANGLE.

• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::compileShaderDirect):
(WebCore::GraphicsContext3D::getAttribLocationDirect):

LayoutTests:

Test that exercises UNPACK_FLIP_Y_WEBGL for video on the accelerated
path.

• fast/canvas/webgl/resources/orientation-flipped.mp4: Added.
• fast/canvas/webgl/resources/orientation-normal.mp4: Added.
• fast/canvas/webgl/texImage2D-video-flipY-false-expected.txt: Added.
• fast/canvas/webgl/texImage2D-video-flipY-false.html: Added.
• fast/canvas/webgl/texImage2D-video-flipY-true-expected.txt: Added.
• fast/canvas/webgl/texImage2D-video-flipY-true.html: Added.
• platform/ios/TestExpectations:

2:58 PM Changeset in webkit [221761] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html as slow.

Unreviewed test gardening.

• platform/win/TestExpectations:

2:57 PM Changeset in webkit [221760] by achristensen@apple.com

• 5 edits in trunk/Source/WebKit

Allow modern decoding of enums and OptionSets
​https://bugs.webkit.org/show_bug.cgi?id=176480

Reviewed by Andy Estes.

• Platform/IPC/ArgumentCoders.h:

(IPC::ArgumentCoder<OptionSet<T>>::decode):

• Platform/IPC/Decoder.h:

(IPC::Decoder::operator>>):

• Platform/IPC/Encoder.h:
• Shared/WebsitePolicies.h:

(WebKit::WebsitePolicies::encode const):
(WebKit::WebsitePolicies::decode):

2:52 PM Changeset in webkit [221759] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked media/video-controls-drop-and-restore-timeline.html as flaky on macOS WK2.
​https://bugs.webkit.org/show_bug.cgi?id=176122

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

2:38 PM Changeset in webkit [221758] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-query-exception-order.html as flaky on El Capitan.
​https://bugs.webkit.org/show_bug.cgi?id=176229

Unreviewed test gardening.

• platform/mac-elcapitan/TestExpectations:

2:18 PM Changeset in webkit [221757] by fpizlo@apple.com

• 7 edits
  1 add in trunk/Tools

WSL Node.prototype.visit should probably do memoization
​https://bugs.webkit.org/show_bug.cgi?id=176286

Reviewed by Mark Lam.

Visitors can sometimes revisit the same thing. For example, we may visit a FuncDef because it belongs
to Program and we may visit it again because a CallExpression resolved to it. That's just plain silly.

Our tests don't currently do this, so it's not a performance problem, yet. Also, we usually avoid that
kind of repetitive visiting inside the visitor implementations. But as far as I can tell, this is an
emergent property rather than a deliberate design.

This change just makes the policy super explicit. If you visit something more than once with the same
visitor, you get the same answer back. This is achieved by means of a memo table inside each visitor.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/FuncInstantiator.js:
• WebGPUShadingLanguageRI/Node.js:

(Node.prototype.visit):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter):

• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Visitor.js:

(Visitor):

• WebGPUShadingLanguageRI/VisitorBase.js: Added.

(VisitorBase):

1:55 PM Changeset in webkit [221756] by webkit@devinrousso.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas RecordingAction tree outline virtualization is broken
​https://bugs.webkit.org/show_bug.cgi?id=176547

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TreeOutline.js:

(WI.TreeOutline.prototype.updateVirtualizedElements.walk):
(WI.TreeOutline.prototype.updateVirtualizedElements):
Pass the current count to each recursive call of walk so that the cumulative index of a
TreeElement in any given sub-tree is correct.
Drive-by: if there is a focused TreeElement when scrolling, only change the current
scrollTop if it is not already visible. Also rewrote some loops for clarity.

1:46 PM Changeset in webkit [221755] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

1:41 PM Changeset in webkit [221754] by jmarcell@apple.com

• 1 copy in tags/Safari-604.2.9

Tag Safari-604.2.9.

1:21 PM Changeset in webkit [221753] by commit-queue@webkit.org

• 7 edits in trunk/Source

Move more code from ScrollingTreeScrollingNodeDelegateIOS to ScrollingTreeScrollingNodeDelegate
​https://bugs.webkit.org/show_bug.cgi?id=174130

Reviewed by Simon Fraser.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Remove some members, headers and pre-declaration that are moved into the delegate. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollLayer): Deleted.
• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Remove some headers and WKOverflowScrollViewDelegate since they are moved into the delegate file. Also fix the comment to closing the WebKit namespace. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::~ScrollingTreeOverflowScrollingNodeIOS): Remove some code moved into the delegate and call the corresponding helper function to preserve the current behavior. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateBeforeChildren): Ditto. Note that it is only necessary to cast the parameter to a ScrollingStateTreeNode. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterAncestorChange): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollPosition): Ditto. (WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Ditto. (-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Deleted. (-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Deleted.
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Import headers and members from ScrollingTreeOverflowScrollingNodeIOS. Define new helper functions for the code imported from ScrollingTreeOverflowScrollingNodeIOS. Remove the friendship with ScrollingTreeOverflowScrollingNodeIOS and only makes public the function used by that class. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollLayer): This function is moved from ScrollingTreeOverflowScrollingNodeIOS.
• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Add headers, WKOverflowScrollViewDelegate (renamed WKScrollingNodeScrollViewDelegate) and some helper code imported from ScrollingTreeOverflowScrollingNodeIOS. (-[WKScrollingNodeScrollViewDelegate scrollViewDidScroll:]): Moved from ScrollingTreeOverflowScrollingNodeIOS. (-[WKScrollingNodeScrollViewDelegate scrollViewWillBeginDragging:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Ditto. (-[WKScrollingNodeScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS): Import code from ScrollingTreeOverflowScrollingNodeIOS. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::resetScrollViewDelegate): New helper function importing code from ScrollingTreeOverflowScrollingNodeIOS. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateBeforeChildren): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::commitStateAfterChildren): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateLayersAfterAncestorChange): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollPosition): Ditto. (WebKit::ScrollingTreeScrollingNodeDelegateIOS::setScrollLayerPosition): Ditto.

Patch by Frederic Wang <​fwang@igalia.com> on 2017-09-07

1:12 PM Changeset in webkit [221752] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

[Win] tests/security/contentSecurityPolicy/report-only.php is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176541

Reviewed by Brent Fulgham.

The function call rename will sometimes fail on Windows because one of the files is
opened by another process. If rename fails, wait, and try again.

• http/tests/security/contentSecurityPolicy/resources/save-report.php:

1:12 PM Changeset in webkit [221751] by Wenson Hsieh

• 6 edits
  1 add in trunk

[Directory Upload] Extend drag and drop support to iOS
​https://bugs.webkit.org/show_bug.cgi?id=176492
<rdar://problem/34291584>

Reviewed by Tim Horton.

Source/WebCore:

Adds support for accepting dropped folders on iOS.

Tests: DataInteractionTests.ExternalSourceDataTransferItemGetFolderAsEntry

DataInteractionTests.ExternalSourceDataTransferItemGetPlainTextFileAsEntry

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::supportedFileUploadPasteboardTypes):

Add "public.folder" as a compatible pasteboard type for drops on iOS. This means file inputs and custom drop
targets that preventDefault() will, by default, be able to accept incoming folders.

• platform/ios/WebItemProviderPasteboard.mm:

(linkTemporaryItemProviderFilesToDropStagingDirectory):

Tweak temporaryFileURLForDataInteractionContent to also hard link UIKit's temporary files instead, and return
a non-null destination URL only if the necessary file operations succeeded. Also renames this helper to
linkTemporaryItemProviderFilesToDropStagingDirectory to better reflect its new purpose. This makes logic much
cleaner at the call site, which no longer checks against various conditions before proceeding to set the data
transfer URL.

(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
(temporaryFileURLForDataInteractionContent): Deleted.

Tools:

Adds two new iOS drag and drop unit tests, which both exercise the DataTransferItem.webKitGetAsEntry codepath
upon drop. (...)GetFolderAsEntry creates a new folder in the temporary directory and uses it to generate an item
provider. This item provider is then dropped over a custom drop handling element, which writes information about
the exposed FileSystemEntries into a textarea. (...)ExternalSourceDataTransferItemGetPlainTextFileAsEntry does
something similar, except that it only drops a plain text file instead.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKitCocoa/DataTransferItem-getAsEntry.html: Added.

Introduce a new test page that dumps information about DataTransferItems' file system entries upon drop.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(runTestWithTemporaryTextFile):
(runTestWithTemporaryFolder):

Introduce helpers to set up and tear down temporary files and folders over the duration of a test.

(TestWebKitAPI::setUpTestWebViewForDataTransferItems):
(TestWebKitAPI::TEST):

12:56 PM Changeset in webkit [221750] by fpizlo@apple.com

• 5 edits
  2 adds in trunk/Tools

WSL should check recursion
​https://bugs.webkit.org/show_bug.cgi?id=176553

Reviewed by Michael Saboff and Mark Lam.

This adds a recursion checker. Previously, we would only check for recursion during inlining, but that
generally only happens when we call the function.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/CheckRecursion.js: Added.

(checkRecursion):

• WebGPUShadingLanguageRI/Prepare.js:

(prepare):

• WebGPUShadingLanguageRI/RecursionChecker.js: Added.

(RecursionChecker):
(RecursionChecker.prototype.visitFuncDef):
(RecursionChecker.prototype.visitCallExpression):

• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:

(TEST_simpleRecursion):

12:51 PM Changeset in webkit [221749] by Chris Dumez

• 21 edits
  2 adds in trunk

[WK2] Notify client when downloads are redirected
​https://bugs.webkit.org/show_bug.cgi?id=176481
<rdar://problem/34309065>

Reviewed by Geoffrey Garen.

Source/WebKit:

Notify client when downloads are redirected via both ObjC and C
API.

• NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::willSendRedirectedRequest):

• NetworkProcess/Downloads/Download.h:
• NetworkProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:willSendRequest:redirectResponse:]):

• UIProcess/API/APIDownloadClient.h:

(API::DownloadClient::willSendRequest):

• UIProcess/API/C/WKContext.cpp:

(WKContextSetDownloadClient):

• UIProcess/API/C/WKContextDownloadClient.h:
• UIProcess/API/Cocoa/_WKDownloadDelegate.h:
• UIProcess/Cocoa/DownloadClient.h:
• UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::willSendRequest):

• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::willSendRequest):

• UIProcess/Downloads/DownloadProxy.h:
• UIProcess/Downloads/DownloadProxy.messages.in:

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenuWithItems):
Set menu proxy before calling menuFromProposedMenu() client delegate.
This allows me to perform one of the menu item's action from the
menuFromProposedMenu() client delegate in my API test.

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
(-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
(-[RedirectedDownloadDelegate _download:didReceiveServerRedirectToURL:]):
(-[RedirectedDownloadDelegate _downloadDidFinish:]):
(TEST):
Add API test coverage.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::downloadDidReceiveServerRedirectToURL):

• WebKitTestRunner/TestController.h:

Add layout test infrastructure.

LayoutTests:

Add layout test coverage.

• http/tests/download/anchor-download-redirect-expected.txt: Added.
• http/tests/download/anchor-download-redirect.html: Added.
• platform/ios-wk2/TestExpectations:
• platform/mac-wk1/TestExpectations:

12:39 PM Changeset in webkit [221748] by webkit@devinrousso.com

• 32 edits in trunk/Source/WebInspectorUI

Unreviewed, change my copyright email.

• Scripts/copy-user-interface-resources.pl:
• UserInterface/Controllers/CodeMirrorSpringEditingController.js:
• UserInterface/Images/AnimationPlayStatePaused.svg:
• UserInterface/Images/AnimationPlayStateRunning.svg:
• UserInterface/Images/CSSVariable.svg:
• UserInterface/Images/ListStylePositionInside.svg:
• UserInterface/Images/ListStylePositionOutside.svg:
• UserInterface/Images/StyleRule.svg:
• UserInterface/Images/StyleRulePseudoElement.svg:
• UserInterface/Models/Collection.js:
• UserInterface/Models/ResourceCollection.js:
• UserInterface/Views/CollectionContentView.css:
• UserInterface/Views/CollectionContentView.js:
• UserInterface/Views/ContextMenuUtilities.js:
• UserInterface/Views/GeneralTabBarItem.js:
• UserInterface/Views/GradientEditor.css:
• UserInterface/Views/GradientEditor.js:
• UserInterface/Views/InlineSwatch.css:
• UserInterface/Views/InlineSwatch.js:
• UserInterface/Views/PinnedTabBarItem.js:
• UserInterface/Views/SettingsTabContentView.css:
• UserInterface/Views/SettingsTabContentView.js:
• UserInterface/Views/SpringEditor.css:
• UserInterface/Views/SpringEditor.js:
• UserInterface/Views/StyleRuleIcons.css:
• UserInterface/Views/TabBarItem.js:
• UserInterface/Views/TitleView.css:
• UserInterface/Views/TitleView.js:
• UserInterface/Views/VisualStyleBackgroundPicker.css:
• UserInterface/Views/VisualStyleBackgroundPicker.js:
• UserInterface/Views/VisualStyleBasicInput.js:

12:31 PM Changeset in webkit [221747] by pvollan@apple.com

• 3 edits in trunk/JSTests

[Win32] 10 JSC stress tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=176538

Reviewed by Mark Lam.

Skip tests on Windows to make the bots green.

• ChakraCore.yaml:
• stress/date-relaxed.js:

12:30 PM Changeset in webkit [221746] by pvollan@apple.com

• 8 edits in trunk

[Win] fast/canvas/2d.getPath.modification.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=176534

Reviewed by Alex Christensen.

We need to enable Inspector additions at runtime in order to expose the getPath function.

Source/WebKitLegacy/win:

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setDataTransferItemsEnabled):
(WebPreferences::inspectorAdditionsEnabled):
(WebPreferences::setInspectorAdditionsEnabled):

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

12:25 PM Changeset in webkit [221745] by fpizlo@apple.com

• 2 edits
  1 add in trunk/Tools

WSL tests should run in run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=176550

Reviewed by Keith Miller.

• Scripts/run-javascriptcore-tests:

(runJSCStressTests):

• WebGPUShadingLanguageRI/wsl-tests.yaml: Added.

12:16 PM Changeset in webkit [221744] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage.html as slow.

Unreviewed test gardening.

• platform/win/TestExpectations:

12:01 PM Changeset in webkit [221743] by achristensen@apple.com

• 42 edits in trunk/Source

Modernize Geolocation code
​https://bugs.webkit.org/show_bug.cgi?id=176496

Reviewed by Andy Estes.

Source/WebCore:

No change in behavior. Just more references instead of pointers.

• Modules/geolocation/Geolocation.cpp:

(WebCore::createPositionError):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::requestPermission):
(WebCore::Geolocation::setError):
(WebCore::Geolocation::startUpdating):
(WebCore::Geolocation::stopUpdating):

• Modules/geolocation/Geolocation.h:
• Modules/geolocation/GeolocationClient.h:
• Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::addObserver):
(WebCore::GeolocationController::removeObserver):
(WebCore::GeolocationController::requestPermission):
(WebCore::GeolocationController::cancelPermissionRequest):
(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):
(WebCore::GeolocationController::activityStateDidChange):
(WebCore::provideGeolocationTo):

• Modules/geolocation/GeolocationController.h:

Source/WebKit:

Making the GeolocationPermissionRequestManager take a reference instead of a pointer
spilled into making the other supplement constructors do the same.

• NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp:

(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):

• NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h:
• NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::addSupplement):

• Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::AuthenticationManager):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):

• Shared/Authentication/AuthenticationManager.h:
• UIProcess/API/APIUIClient.h:

(API::UIClient::decidePolicyForGeolocationPermissionRequest):

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestGeolocationPermissionForFrame):

• WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::getAllCookies):
(WebKit::WebCookieManager::getCookies):
(WebKit::WebCookieManager::setCookie):
(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::notifyCookiesDidChange):
(WebKit::WebCookieManager::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::getHTTPCookieAcceptPolicy):

• WebProcess/Cookies/WebCookieManager.h:
• WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:

(WebKit::GeolocationPermissionRequestManager::GeolocationPermissionRequestManager):
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
(WebKit::GeolocationPermissionRequestManager::cancelRequestForGeolocation):

• WebProcess/Geolocation/GeolocationPermissionRequestManager.h:
• WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::WebGeolocationManager):
(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::setEnableHighAccuracyForPage):
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
(WebKit::WebGeolocationManager::resetPermissions):

• WebProcess/Geolocation/WebGeolocationManager.h:
• WebProcess/MediaCache/WebMediaKeyStorageManager.h:

(WebKit::WebMediaKeyStorageManager::WebMediaKeyStorageManager):

• WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::WebNotificationManager):
(WebKit::WebNotificationManager::show):
(WebKit::WebNotificationManager::cancel):
(WebKit::WebNotificationManager::clearNotifications):
(WebKit::WebNotificationManager::didDestroyNotification):

• WebProcess/Notifications/WebNotificationManager.h:
• WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::requestPermission):
(WebKit::WebGeolocationClient::cancelPermissionRequest):

• WebProcess/WebCoreSupport/WebGeolocationClient.h:

(WebKit::WebGeolocationClient::WebGeolocationClient):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

• WebProcess/WebProcess.h:

(WebKit::WebProcess::addSupplement):

• WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::UserMediaCaptureManager):

• WebProcess/cocoa/UserMediaCaptureManager.h:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebGeolocationClient.h:
• WebCoreSupport/WebGeolocationClient.mm:

(WebGeolocationClient::requestPermission):
(-[WebGeolocationPolicyListener initWithGeolocation:]):
(-[WebGeolocationPolicyListener initWithGeolocation:forWebView:]):
(-[WebGeolocationProviderInitializationListener initWithGeolocation:]):

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _geolocationDidFailWithMessage:]):

Source/WebKitLegacy/win:

• WebCoreSupport/WebGeolocationClient.cpp:

(WebGeolocationClient::requestPermission):

• WebCoreSupport/WebGeolocationClient.h:

(WebGeolocationClient::setEnableHighAccuracy): Deleted.
(WebGeolocationClient::cancelPermissionRequest): Deleted.

• WebGeolocationPolicyListener.h:
• WebView.cpp:

(WebView::initWithFrame):
(WebView::geolocationDidFailWithError):

11:52 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

11:22 AM Changeset in webkit [221742] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebCore

[ARM] Building FELightningNEON.cpp fails due to missing {Point,Spot}LightSource declarations
​https://bugs.webkit.org/show_bug.cgi?id=176531

Reviewed by Žan Doberšek.

The m_lightSource member is a Ref<LightSource>, and its get() method returns
a reference, therefore the casts have to be done to the corresponding reference
types.

• platform/graphics/cpu/arm/filters/FELightingNEON.h:

(WebCore::FELighting::platformApplyNeon): Adjust casts and member accesses accordingly.

10:56 AM Changeset in webkit [221741] by Lucas Forschler

• 2 edits in trunk/Tools

bisect-builds started failing with invalid json
​https://bugs.webkit.org/show_bug.cgi?id=176478

Once we hit 1000 items in our dynamoDB, we ran into an upper limit on the AWS API Gateway looping mechanism.
This prevented us from doing a body mapping template to reformat the json. This fix is to simply return the raw json,
and adjust the json parsing in our code. The AWS rest API has been fixed, and updated to v2.

This change is for the script which operates against the endpoint.

Reviewed by Aakash Jain.

• Scripts/bisect-builds:

(get_sorted_revisions):

10:53 AM Changeset in webkit [221740] by fpizlo@apple.com

• 4 edits in trunk/Tools

[WSL] Rationalize how protocol inheritance deals with type parameters
​https://bugs.webkit.org/show_bug.cgi?id=176334

Reviewed by Mark Lam.

This adds a bunch of tests for structs, protocols, and functions interacting in interesting
ways. The most complex of these tests triggers the case where the protocol contains a function
with one type parameter and the real function has more than one. This should give a WTypeError,
and now it does.

• WebGPUShadingLanguageRI/ProtocolDecl.js:

(ProtocolDecl.prototype.hasHeir): Fix the handling of a mismatch of number of type parameters by actually passing the type parameters and then correctly handling the error.

• WebGPUShadingLanguageRI/Test.js: Add a bunch of tests for this case and a lot of other protocol cases.

(TEST_protocolMonoSigPolyDef):
(TEST_protocolPolySigPolyDef):
(TEST_protocolDoublePolySigDoublePolyDef):
(TEST_protocolDoublePolySigDoublePolyDefExplicit):
(TEST_protocolMonoPolySigDoublePolyDefExplicit):

• WebGPUShadingLanguageRI/TypeVariable.js:

(TypeVariable.prototype.get origin): This wasn't implemented before, which made error reporting harder.

10:20 AM Changeset in webkit [221739] by matthew_hanson@apple.com

• 2 edits in tags/Safari-605.1.5/Source/WebCore/PAL

Cherry-pick r221738. rdar://problem/34296289

10:03 AM Changeset in webkit [221738] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore/PAL

[Mac] Stop importing NSFunctionBar_Private.h in NSTouchBarSPI.h on the macOS 10.13+ SDK
​https://bugs.webkit.org/show_bug.cgi?id=176521
<rdar://problem/34296289>

Reviewed by Andy Estes.

We don't need to import NSFunctionBar_Private.h when building against the macOS 10.13 SDK, or later. Guard this
header import with an SDK version check.

• pal/spi/cocoa/NSTouchBarSPI.h:

9:43 AM Changeset in webkit [221737] by pvollan@apple.com

• 2 edits in trunk/Tools

[Win] Dashboard test is failing.
​https://bugs.webkit.org/show_bug.cgi?id=176527

Reviewed by Brent Fulgham.

Skip test on Windows since WebKitTestRunner is required, but not built on Windows.

• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(TestFactory.init):

9:40 AM Changeset in webkit [221736] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked svg/animations/smil-leak-elements.svg as flaky on macOS WK1.
​https://bugs.webkit.org/show_bug.cgi?id=174180

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

9:20 AM Changeset in webkit [221735] by commit-queue@webkit.org

• 2 edits in trunk/PerformanceTests

Optimize the call to browserPrefix() in MotionMark
​https://bugs.webkit.org/show_bug.cgi?id=176489

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-09-07
Reviewed by Jon Lee.

This function is expensive and it does not change for the browser. No need
to recalculate it every time it is called; just cache the returned value.

• MotionMark/resources/extensions.js:

(Utilities.browserPrefix):

9:00 AM Changeset in webkit [221734] by Adrian Perez de Castro

• 2 edits
  3 adds in trunk

[WPE][CMake] Add "dist" and "distcheck" targets
​https://bugs.webkit.org/show_bug.cgi?id=176448

Reviewed by Carlos Garcia Campos.

Add "dist" and "distcheck" CMake targets, which create release tarballs.
These are available only when configuring with -DDEVELOPER_MODE=TRUE.

.:

• Source/PlatformWPE.cmake: Added.
• Source/cmake/FindXz.cmake: Added.

Tools:

• wpe/manifest.txt.in: Added.

8:55 AM Changeset in webkit [221733] by pvollan@apple.com

• 8 edits in trunk

[Win] Enable DatatransferItems in DRT.
​https://bugs.webkit.org/show_bug.cgi?id=176424

Reviewed by Brent Fulgham.

Source/WebKitLegacy/win:

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::QueryInterface):
(WebPreferences::isSecureContextAttributeEnabled):
(WebPreferences::dataTransferItemsEnabled):
(WebPreferences::setDataTransferItemsEnabled):

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

8:42 AM Changeset in webkit [221732] by Ryan Haddad

• 3 edits
  3 deletes in trunk

Unreviewed, rolling out r221716.

This change caused assertion failures on macOS Debug WK2.

Reverted changeset:

"Fetch's Response.statusText is unexpectedly the full http
status line for HTTP/2 responses"
​https://bugs.webkit.org/show_bug.cgi?id=176479
​http://trac.webkit.org/changeset/221716

8:39 AM Changeset in webkit [221731] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Update test expectations for failing tests on Windows.

Unreviewed test gardening.

• platform/win/TestExpectations:

8:30 AM Changeset in webkit [221730] by matthew_hanson@apple.com

• 1 copy in tags/Safari-605.1.5

Tag Safari-605.1.5.

7:53 AM Changeset in webkit [221729] by matthew_hanson@apple.com

• 7 edits in trunk/Source

Versioning.

5:57 AM Changeset in webkit [221728] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[EME] CDMClearKey: implement remaining methods of CDMPrivate derivative
​https://bugs.webkit.org/show_bug.cgi?id=176495

Reviewed by Xabier Rodriguez-Calvar.

Implement the remaining CDMPrivateClearKey methods, following the
ClearKey specification:

• server certificates are not supported, but sessions are;
• 'keyids' init data in JSON format is acceptable;
• JSON responses are acceptable;
• session IDs must use the 32-bit integer format.

No new tests -- covered by imported W3C tests that utilize ClearKey.

• platform/encryptedmedia/clearkey/CDMClearKey.cpp:

(WebCore::parseJSONObject):
(WebCore::CDMPrivateClearKey::loadAndInitialize):
(WebCore::CDMPrivateClearKey::supportsServerCertificates const):
(WebCore::CDMPrivateClearKey::supportsSessions const):
(WebCore::CDMPrivateClearKey::supportsInitData const):
(WebCore::CDMPrivateClearKey::sanitizeResponse const):
(WebCore::CDMPrivateClearKey::sanitizeSessionId const):

5:14 AM Changeset in webkit [221727] by Carlos Garcia Campos

• 9 edits
  3 adds in trunk

[GTK] Bump libxml2 version to 1.9.5
​https://bugs.webkit.org/show_bug.cgi?id=176502

Reviewed by Carlos Alberto Lopez Perez.

Tools:

It has been released very recently, but it fixes the issues that prevented us from upgrading to 1.9.4.

• gtk/jhbuild.modules:

LayoutTests:

Rebaselines several tests where only the line number changed in error messages.

• platform/gtk/fast/dom/adopt-attribute-crash-expected.txt:
• platform/gtk/fast/parser/xml-colon-entity-expected.txt: Added.
• platform/gtk/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
• platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
• platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
• platform/gtk/svg/custom/bug78807-expected.txt: Added.
• platform/gtk/svg/custom/missing-xlink-expected.txt:
• platform/gtk/svg/custom/path-bad-data-expected.txt:
• platform/gtk/svg/custom/use-font-face-crash-expected.txt:

3:43 AM WebDriverStatus created by Carlos Garcia Campos

3:12 AM WebKitGTK/2.18.x edited by tpopela@redhat.com

(diff)

2:17 AM Changeset in webkit [221726] by magomez@igalia.com

• 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Marking some service-worker related tests as crashing.

• platform/gtk/TestExpectations:

2:04 AM Changeset in webkit [221725] by Carlos Garcia Campos

• 996 edits
  1 add in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after r221724.

1:52 AM Changeset in webkit [221724] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GTK] Bring back line height rounding when computing font metrics
​https://bugs.webkit.org/show_bug.cgi?id=176497

Reviewed by Žan Doberšek.

In r221670 we changed the way we get the metrics to avoid rounding that was causing a negative line gap to be
computed. Since the font metrics value is indeed a float value, we also removed the rounding when setting the
line height. However, this caused some test failures because now we report non integer line heights.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

1:40 AM WebKitGTK/2.16.x edited by tpopela@redhat.com

(diff)

1:40 AM WebKitGTK/2.18.x edited by tpopela@redhat.com

(diff)

1:36 AM WebKitGTK/2.16.x edited by Adrian Perez de Castro

(diff)

1:36 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

1:21 AM WebKitGTK/2.16.x edited by Adrian Perez de Castro

(diff)

1:20 AM WebKitGTK/2.18.x edited by Adrian Perez de Castro

(diff)

1:14 AM Changeset in webkit [221723] by Yusuke Suzuki

• 4 edits in trunk/Source/JavaScriptCore

[JSC] Remove "malloc" and "free" from JSC/API
​https://bugs.webkit.org/show_bug.cgi?id=176331

Reviewed by Keith Miller.

Remove "malloc" and "free" manual calls in JSC/API.

• API/JSValue.mm:

(createStructHandlerMap):

• API/JSWrapperMap.mm:

(parsePropertyAttributes):
(makeSetterName):
(copyPrototypeProperties):
Use RetainPtr<NSString> to keep NSString. We avoid repeated "char*" to "NSString" conversion.

• API/ObjcRuntimeExtras.h:

(adoptSystem):
Add adoptSystem to automate calling system free().

(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):
(StringRange::StringRange):
(StringRange::operator const char* const):
(StringRange::get const):
Use CString for backend.

(StructBuffer::StructBuffer):
(StructBuffer::~StructBuffer):
(StringRange::~StringRange): Deleted.
Use fastAlignedMalloc/astAlignedFree to get aligned memory.

12:35 AM Changeset in webkit [221722] by bshafiei@apple.com

• 7 edits in tags/Safari-605.1.4.0.1/Source

Versioning.

12:32 AM Changeset in webkit [221721] by bshafiei@apple.com

• 1 copy in tags/Safari-605.1.4.0.1

New Tag.

12:32 AM Changeset in webkit [221720] by Carlos Garcia Campos

• 27 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline more tests after Freetype version bump in r221670.

• platform/gtk/editing/execCommand/print-expected.png:
• platform/gtk/editing/execCommand/print-expected.txt:
• platform/gtk/fast/forms/large-toggle-elements-expected.png:
• platform/gtk/fast/forms/large-toggle-elements-expected.txt:
• platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.png:
• platform/gtk/fast/forms/number/number-size-spinbutton-nocover-expected.txt:
• platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.png:
• platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
• platform/gtk/fonts/complex-text-shadows-expected.png:
• platform/gtk/fonts/complex-text-shadows-expected.txt:
• platform/gtk/fonts/custom-font-missing-glyphs-expected.png:
• platform/gtk/fonts/custom-font-missing-glyphs-expected.txt:
• platform/gtk/fonts/font-face-with-complex-text-expected.png:
• platform/gtk/fonts/font-face-with-complex-text-expected.txt:
• platform/gtk/fonts/font-with-no-valid-encoding-expected.png:
• platform/gtk/fonts/font-with-no-valid-encoding-expected.txt:
• platform/gtk/fonts/fontconfig-aliasing-settings-expected.png:
• platform/gtk/fonts/fontconfig-aliasing-settings-expected.txt:
• platform/gtk/fonts/non-bmp-characters-expected.png:
• platform/gtk/fonts/non-bmp-characters-expected.txt:
• platform/gtk/fonts/xsettings_antialias_settings-expected.png:
• platform/gtk/fonts/xsettings_antialias_settings-expected.txt:
• platform/gtk/fonts/zero-pixel-sized-fonts-expected.png:
• platform/gtk/fonts/zero-pixel-sized-fonts-expected.txt:
• platform/gtk/transitions/svg-text-shadow-transition-expected.png:
• platform/gtk/transitions/svg-text-shadow-transition-expected.txt:

Sep 6, 2017:

11:20 PM Changeset in webkit [221719] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Temporary disable the changes introduced in r221670 for WPE.

It caused a lot of test failures. Once WPE upgrades to Freetype 2.8 and removes the 2.4.11 patch, we can enable
it again.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::Font::platformInit):

10:58 PM Changeset in webkit [221718] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[GStreamer] Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance()
​https://bugs.webkit.org/show_bug.cgi?id=176445

Reviewed by Xabier Rodriguez-Calvar.

Implement MediaPlayerPrivateGStreamerMSE::attempToDecryptWithInstance(), also
adding support for dispatching ClearKey keys into the append pipelines.

CDMInstanceClearKey::Key is added, containing key ID and value buffers as well
as the key status value. Vector of keys for a specific CDMInstance is
accessible through the CDMInstanceClearKey::keys() getter.

In MediaPlayerPrivateGStreamerMSE, that Vector is retrieved and then iterated
over, constructing corresponding key ID and key value lists that contain
GstBuffer objects into which each key ID and value data is copied. Both lists
are then set on the 'drm-cipher-clearkey' structure before it's dispatched
against each AppendPipeline object.

• platform/encryptedmedia/clearkey/CDMClearKey.h:
• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

9:23 PM Changeset in webkit [221717] by aakash_jain@apple.com

• 5 edits in trunk/Websites/perf.webkit.org

Add initSyncers method in BuildbotTriggerable
​https://bugs.webkit.org/show_bug.cgi?id=176125

Reviewed by Ryosuke Niwa.

• tools/sync-buildbot.js:

(syncLoop): Use initSyncers() which returns a promise. Modified to handle the promise.

• tools/js/buildbot-triggerable.js:

(BuildbotTriggerable): Invokes initSyncers() appropriately.
(BuildbotTriggerable.prototype.initSyncers): Returns a promise which initialize all the syncers.

• server-tests/tools-buildbot-triggerable-tests.js: Updated tests to handle initSyncers().
• server-tests/tools-sync-buildbot-integration-tests.js: Ditto.

9:05 PM Changeset in webkit [221716] by commit-queue@webkit.org

• 3 edits
  7 adds in trunk

Fetch's Response.statusText is unexpectedly the full http status line for HTTP/2 responses
​https://bugs.webkit.org/show_bug.cgi?id=176479

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Test: http/wpt/fetch/response-status-text.html

HTTP/2 doesn't include a status reason phrase. So the "status line"
ends up just being the version and status code. Fallback to the empty
string instead of the full line.

• platform/network/HTTPParsers.cpp:

(WebCore::extractReasonPhraseFromHTTPStatusLine):

LayoutTests:

• http/wpt/fetch/resources/status-garbage.asis: Added.
• http/wpt/fetch/resources/status-normal.txt: Added.
• http/wpt/fetch/resources/status-with-message.asis: Added.
• http/wpt/fetch/resources/status-without-message.asis: Added.

Various text HTTP responses with different status lines.

• http/wpt/fetch/response-status-text-expected.txt: Added.
• http/wpt/fetch/response-status-text.html: Added.

Test the Fetch Response's status / statusText for different HTTP status lines.
The status without a message is similiar to HTTP/2 because HTTP/2 only
has a :status pseudo-header and lacks a reason phrase.

9:02 PM Changeset in webkit [221715] by commit-queue@webkit.org

• 1 edit
  1 delete in trunk/Tools

Remove new-run-webkit-httpd as it appears to be old
​https://bugs.webkit.org/show_bug.cgi?id=176493

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Alexey Proskuryakov.

• Scripts/new-run-webkit-httpd: Removed.

8:42 PM Changeset in webkit [221714] by achristensen@apple.com

• 6 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pageDidScroll
​https://bugs.webkit.org/show_bug.cgi?id=176482
<rdar://problem/29270035>

Reviewed by Tim Horton.
Source/WebKit:

Covered by a new API test!

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::UIClient::pageDidScroll):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[DidScrollDelegate _webViewDidScroll:]):
(TEST):

8:29 PM Changeset in webkit [221713] by Matt Baker

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Relax the maximum sidebar width
​https://bugs.webkit.org/show_bug.cgi?id=175808
<rdar://problem/34005339>

Reviewed by Devin Rousso.

This patch introduces a constant, minimumContentBrowserWidth, which
constrains the maximum width of either sidebar:

maxSidebarWidth = window.innerWidth - minimumContentBrowserWidth - otherSidebarWidth

A value of 100px for minimumContentBrowserWidth leaves enough space for
three NavigationItems at their minimum width (32px), with a few pixels
left over for good measure. For most tabs this will ensure that the buttons
for showing the sidebars will be visible, along with an addition button.

• UserInterface/Base/Main.js:
• UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.get maximumWidth):

7:32 PM Changeset in webkit [221712] by eric.carlson@apple.com

• 11 edits in trunk

Require LoggingHelper overrides to provide identifier
​https://bugs.webkit.org/show_bug.cgi?id=176477

Reviewed by Jer Noble.

Source/WebCore:

No new tests, updated API test.

• html/HTMLMediaElement.cpp:

(WebCore::nextLogIdentifier): New.
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_logIdendifier. LOGTHIS -> LOGIDENTIFIER.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Ditto.

• html/HTMLMediaElement.h:

Source/WebCore/PAL:

• pal/Logger.h:

(PAL::Logger::LogSiteIdentifier::LogSiteIdentifier):
(PAL::LogArgument<Logger::LogSiteIdentifier>::toString):
(PAL::Logger::notice const): Deleted.
(PAL::Logger::MethodAndPointer::MethodAndPointer): Deleted.
(PAL::LogArgument<Logger::MethodAndPointer>::toString): Deleted.

• pal/LoggerHelper.h:

Source/WTF:

• wtf/Assertions.cpp: No more WTFLogLevelNotice.
• wtf/Assertions.h: Ditto.

Tools:

• TestWebKitAPI/Tests/WebCore/Logging.cpp:

(TestWebKitAPI::TEST_F):

5:57 PM Changeset in webkit [221711] by mark.lam@apple.com

• 3 edits
  1 add in trunk

constructGenericTypedArrayViewWithArguments() is missing an exception check.
​https://bugs.webkit.org/show_bug.cgi?id=176485
<rdar://problem/33898874>

Reviewed by Keith Miller.

JSTests:

• stress/regress-176485.js: Added.

Source/JavaScriptCore:

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):

5:03 PM Changeset in webkit [221710] by commit-queue@webkit.org

• 24 edits
  2 adds in trunk

NetworkProcess Cache and Caches should be cleared when the last related WebProcess Cache or CacheStorage is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=176249

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/cache-storage/cache-representation.https.html

Each Cache construction/destruction is notified to the CacheStorageConnection
so that the WebKit2 engine can handle memory management accordingly.

Adding an internal API to grab the representation of an engine at any time.

• Modules/cache/Cache.cpp:

(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):

• Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::reference):
(WebCore::CacheStorageConnection::dereference):

• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::WorkerCacheStorageConnection::reference):
(WebCore::WorkerCacheStorageConnection::dereference):

• Modules/cache/WorkerCacheStorageConnection.h:
• testing/Internals.cpp:

(WebCore::Internals::cacheStorageEngineRepresentation):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit:

CacheStorageEngineConnection will store the number of Caches references for its related WebProcess.
For a new reference, CacheStorageEngineConnection will notify its engine to lock the related Cache.
When the last reference is gone, CacheStorageEngineConnection will ask the engine to release the lock.

CacheStorageEngine will keep locks as a counter for each Cache object.
When the counter goes to zero, the engine asks the Cache to dispose itself.
Disposal is done by its parent Caches as only Caches knows whether the Cache is persistent or has been removed.

The Caches will remove the Cache from memory.
For removed caches, all information will be lost.
For caches that are not removed, they will keep their identifiers but all in-memory record information will be discarded.
If there is a need to reopen the Cache, it will need to read its information from the filesystem.
If the Caches has no longer any active Cache object, it will ask the engine to release itself.

WebProcess crashing is handled correctly as the CacheStorageEngineConnection will release its locks at destruction
time of the connection to the web process.

Adding the possiblity to grab an engine representation for test purposes.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readCachesFromDisk):
(WebKit::CacheStorage::Engine::removeCaches):
(WebKit::CacheStorage::Engine::lock):
(WebKit::CacheStorage::Engine::unlock):

• NetworkProcess/cache/CacheStorageEngine.h:
• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::dispose):
(WebKit::CacheStorage::Cache::clearMemoryRepresentation):

• NetworkProcess/cache/CacheStorageEngineCache.h:

(WebKit::CacheStorage::Cache::isActive const):

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::Caches):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::dispose):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::clearMemoryRepresentation):

• NetworkProcess/cache/CacheStorageEngineCaches.h:

(WebKit::CacheStorage::Caches::create):

• NetworkProcess/cache/CacheStorageEngineConnection.cpp:

(WebKit::CacheStorageEngineConnection::~CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::reference):
(WebKit::CacheStorageEngineConnection::dereference):

• NetworkProcess/cache/CacheStorageEngineConnection.h:
• NetworkProcess/cache/CacheStorageEngineConnection.messages.in:
• WebProcess/Cache/WebCacheStorageConnection.cpp:

(WebKit::WebCacheStorageConnection::reference):
(WebKit::WebCacheStorageConnection::dereference):

• WebProcess/Cache/WebCacheStorageConnection.h:

LayoutTests:

• http/tests/cache-storage/cache-representation.https-expected.txt: Added.
• http/tests/cache-storage/cache-representation.https.html: Added.
• http/tests/cache-storage/resources/cache-persistency-iframe.html:

5:02 PM Changeset in webkit [221709] by mrajca@apple.com

• 2 edits in trunk/Source/WebCore

Support new autoplay quirk for arbitrary user gestures.
​https://bugs.webkit.org/show_bug.cgi?id=176402

Reviewed by Eric Carlson.

This quirk allows any user gesture to allow autoplay in a document.

No new tests because this specifically targets one host.

• html/MediaElementSession.cpp:

(WebCore::needsArbitraryUserGestureAutoplayQuirk):
(WebCore::MediaElementSession::playbackPermitted const):

4:33 PM Changeset in webkit [221708] by Matt Lewis

• 3 edits in trunk/LayoutTests

Marked media/video-main-content-allow-then-scroll.html as flaky on macOS and failing on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=161491

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

4:27 PM Changeset in webkit [221707] by achristensen@apple.com

• 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
​https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.

Covered by a new API test.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):

• UIProcess/PageClient.h:

(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):

3:01 PM Changeset in webkit [221706] by mitz@apple.com

• 9 copies
  1 add in releases/Apple/Safari Technology Preview 39

Added a tag for Safari Technology Preview release 39.

2:37 PM Changeset in webkit [221705] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebKit

Introduce asynchronous opening of CacheStorageEngine cache
​https://bugs.webkit.org/show_bug.cgi?id=176425

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

Introducing Cache::open to allow reading from the filesystem to fill the Cache.
This is called by Caches when engine requests to open an existing Cache.

• NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::Cache):
(WebKit::CacheStorage::Cache::open):
(WebKit::CacheStorage::Cache::finishOpening):
(WebKit::CacheStorage::Cache::readRecordsList):

• NetworkProcess/cache/CacheStorageEngineCache.h:
• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::find):
(WebKit::CacheStorage::Caches::open):
(WebKit::CacheStorage::Caches::remove):
(WebKit::CacheStorage::Caches::readCachesFromDisk):
(WebKit::CacheStorage::Caches::find const): Deleted.

• NetworkProcess/cache/CacheStorageEngineCaches.h:

2:25 PM Changeset in webkit [221704] by commit-queue@webkit.org

• 24 edits
  5 adds in trunk

Support caching of Response with a ReadableStream body
​https://bugs.webkit.org/show_bug.cgi?id=176462

Patch by Youenn Fablet <​youenn@apple.com> on 2017-09-06
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Tests: http/wpt/cache-storage/cache-put-stream.https.any.html

http/wpt/cache-storage/cache-put-stream.https.any.worker.html

Making FetchResponse use more of ReadableStream:

• Cloning of its body is done through ReadableStream.
• Computation of disturbed and locked is done through ReadableStream.
• Storing of the ReadableStream body given at constructor time is done in FetchBody for FetchResponse.

This allows making FetchResponse closer to FetchRequest.
This also allows to correctly compute disturbed and locked in clone cases.

Adding the ability to consume a Response ReadableStream body as a SharedBuffer.
Using that ability in DOMCache.

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::putWithResponseData):
(WebCore::DOMCache::put):

• Modules/cache/DOMCache.h:
• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::readableStream const):

• Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::extract):

• Modules/fetch/FetchBodyConsumer.h:
• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::isDisturbed const):
(WebCore::FetchBodyOwner::isDisturbedOrLocked const):

• Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::hasReadableStreamBody const):

• Modules/fetch/FetchBodySource.cpp:
• Modules/fetch/FetchBodySource.h:
• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBodyFromReadableStream):
(WebCore::FetchResponse::consumeBodyWhenLoaded):
(WebCore::FetchResponse::consumeBodyAsStream):

• Modules/fetch/FetchResponse.h:
• Modules/fetch/FetchResponse.idl:
• Modules/fetch/FetchResponse.js:

(initializeFetchResponse):
(clone):

• bindings/js/ReadableStream.cpp:

(WebCore::callFunction):
(WebCore::ReadableStream::pipeTo):
(WebCore::ReadableStream::tee):
(WebCore::checkReadableStream):
(WebCore::ReadableStream::isLocked const):
(WebCore::ReadableStream::isDisturbed const):
(WebCore::ReadableStream::isDisturbed):

• bindings/js/ReadableStream.h:
• bindings/js/ReadableStreamDefaultController.cpp:
• bindings/js/ReadableStreamDefaultController.h:
• bindings/js/WebCoreBuiltinNames.h:
• testing/Internals.cpp:

(WebCore::Internals::isReadableStreamDisturbed):

LayoutTests:

• TestExpectations: Removing flakiness expectation for cache-put tests.
• http/wpt/cache-storage/cache-put-stream.https.any-expected.txt: Added.
• http/wpt/cache-storage/cache-put-stream.https.any.html: Added.
• http/wpt/cache-storage/cache-put-stream.https.any.js: Added.

(cache_test.):
(cache_test):
(string_appeared_here.cache_test.return.reader.read.then.):
(string_appeared_here.cache_test):

• http/wpt/cache-storage/cache-put-stream.https.any.worker-expected.txt: Added.
• http/wpt/cache-storage/cache-put-stream.https.any.worker.html: Added.

2:04 PM Changeset in webkit [221703] by sbarati@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Air should have a Vector of prologue generators instead of a HashMap representing an optional prologue generator
​https://bugs.webkit.org/show_bug.cgi?id=176346

Reviewed by Mark Lam.

• b3/B3Procedure.cpp:

(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::setNumEntrypoints):

• b3/B3Procedure.h:

(JSC::B3::Procedure::setNumEntrypoints): Deleted.

• b3/air/AirCode.cpp:

(JSC::B3::Air::defaultPrologueGenerator):
(JSC::B3::Air::Code::Code):
(JSC::B3::Air::Code::setNumEntrypoints):

• b3/air/AirCode.h:

(JSC::B3::Air::Code::setPrologueForEntrypoint):
(JSC::B3::Air::Code::prologueGeneratorForEntrypoint):
(JSC::B3::Air::Code::setEntrypoints):
(JSC::B3::Air::Code::setEntrypointLabels):

• b3/air/AirGenerate.cpp:

(JSC::B3::Air::generate):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):

1:54 PM Changeset in webkit [221702] by achristensen@apple.com

• 11 edits in trunk

Unreviewed, rolling out r221694.

broke build

Reverted changeset:

"Add WKUIDelegatePrivate equivalent of WKPageUIClient's
pinnedStateDidChange"
​https://bugs.webkit.org/show_bug.cgi?id=176474
​http://trac.webkit.org/changeset/221694

1:51 PM Changeset in webkit [221701] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

ASSERTION FAILED: op() == CheckStructure in Source/JavaScriptCore/dfg/DFGNode.h(443)
​https://bugs.webkit.org/show_bug.cgi?id=176470

Reviewed by Mark Lam.

Update Node::convertToCheckStructureImmediate's assertion to allow
the node to either be a CheckStructure or CheckStructureOrEmpty.

• dfg/DFGNode.h:

(JSC::DFG::Node::convertToCheckStructureImmediate):

1:48 PM Changeset in webkit [221700] by pvollan@apple.com

• 2 edits in trunk/Tools

[Win] test-webkitpy test timeout_context_unittest is failing.
​https://bugs.webkit.org/show_bug.cgi?id=176471

Reviewed by Brent Fulgham.

This assert failure is possibly caused by different time resolution on
various platforms.

• Scripts/webkitpy/common/timeout_context_unittest.py:

(TimeoutContextTests.test_timeout_data):

1:40 PM Changeset in webkit [221699] by Ryan Haddad

• 24 edits
  1 delete in trunk

Unreviewed, rolling out r221461.

The LayoutTest added with this change crashes under
GuardMalloc.

Reverted changeset:

"Add (entirely incorrect) fetching of ServiceWorker scripts."
​https://bugs.webkit.org/show_bug.cgi?id=176179
​http://trac.webkit.org/changeset/221461

1:26 PM Changeset in webkit [221698] by achristensen@apple.com

• 5 edits in trunk/Source/WebKit

Add modern decoders for POD types
​https://bugs.webkit.org/show_bug.cgi?id=176456

Reviewed by Geoffrey Garen.

• Platform/IPC/Decoder.cpp:

(IPC::Decoder::getOptional):
(IPC::Decoder::operator>>):

• Platform/IPC/Decoder.h:
• Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::decode):

• Shared/NavigationActionData.h:

1:24 PM Changeset in webkit [221697] by matthew_hanson@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

1:21 PM Changeset in webkit [221696] by aakash_jain@apple.com

• 2 edits in trunk/Tools

status-bubbles turn orange after checking relevance of patch
​https://bugs.webkit.org/show_bug.cgi?id=176457

Reviewed by Alexey Proskuryakov.

• QueueStatusServer/handlers/statusbubble.py: Added "Checked relevance of patch" as a progress_statuses.

1:16 PM Changeset in webkit [221695] by webkit@devinrousso.com

• 16 edits
  1 add in trunk

Web Inspector: Support overloaded CanvasRenderingContext2D actions with identical parameter counts
​https://bugs.webkit.org/show_bug.cgi?id=176178
<rdar://problem/34192229>

Reviewed by Matt Baker.

Source/WebCore:

Update existing tests.

• WebCore.xcodeproj/project.pbxproj:

• inspector/InspectorCanvas.cpp:

(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildAction):
Add another array to each action that contains a swizzle type for each parameter. This is
used by the frontend to determine how to regenerate the value from what is given in the JSON.

• inspector/RecordingSwizzleTypes.h: Added.

Contains a value-specified enum of types that translate into int values, which are mirrored
by an object in the frontend, that indicate the type of each parameter. This enum matches
the values in WI.Recording.Swizzle.

Source/WebInspectorUI:

• UserInterface/Models/Recording.js:

(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.swizzle):
Replace WI.Recording.Swizzle with an object of swizzle type keys to int values. This object
matches the values in WebCore::RecordingSwizzleTypes.h.

• UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.fromPayload):
(WI.RecordingAction.prototype.get swizzleTypes):
(WI.RecordingAction.prototype.swizzle):
(WI.RecordingAction.prototype.toJSON):
(WI.RecordingAction.prototype.parameterSwizzleTypeForTypeAtIndex): Deleted.
Replace WI.RecordingAction._parameterSwizzleTypeForTypeAtIndex with an array of parameter
types sent in the payload. This gives more control over the swizzling to the JSON, but also
simplifies the way we regenerate the data in the frontend.

• UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):

• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView.prototype._applyAction):

• UserInterface/Views/RecordingNavigationSidebarPanel.css:

(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles :matches(.name, .parameter.invalid)):
(.sidebar > .panel.navigation.recording > .content .action.invalid:not(.selected, .initial-state) > .titles .name,): Deleted.

LayoutTests:

• inspector/canvas/recording-2d-expected.txt:
• inspector/canvas/recording-webgl-expected.txt:
• inspector/canvas/recording-webgl-snapshots-expected.txt:
• inspector/model/recording-expected.txt:
• inspector/model/recording.html:

1:15 PM Changeset in webkit [221694] by achristensen@apple.com

• 11 edits in trunk

Add WKUIDelegatePrivate equivalent of WKPageUIClient's pinnedStateDidChange
​https://bugs.webkit.org/show_bug.cgi?id=176474
<rdar://problem/29270035>

Reviewed by Tim Horton.

Source/WebKit:

Rather than telling the UIClient that the pinned state changed and having the application check 4 bools
like we do with WKPage, I made a KVO property on the WKWebView. I introduce _WKRectEdge for this purpose,
which is like UIRectEdge but unfortunately NSRectEdge and CGRectEdge cannot be used as NS_OPTIONS/flags.
This same structure is used for rubber band state.

Covered by a new API test.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pinnedState]):
(-[WKWebView _rubberBandState]):
(-[WKWebView _setRubberBandState:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pinnedState):
(WebKit::WebViewImpl::rubberBandState):
(WebKit::WebViewImpl::setRubberBandState):

• UIProcess/PageClient.h:

(WebKit::PageClient::pinnedStateWillChange):
(WebKit::PageClient::pinnedStateDidChange):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollOffsetPinningForMainFrame):

• UIProcess/mac/PageClientImplMac.h:
• UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::pinnedStateWillChange):
(WebKit::PageClientImpl::pinnedStateDidChange):

Tools:

• TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:

(-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
(TEST):

1:09 PM Changeset in webkit [221693] by pvollan@apple.com

• 8 edits
  1 move in trunk/Source

[Win] WebCore failed to build, InbandTextTrackPrivateAVF: base class undefined.
​https://bugs.webkit.org/show_bug.cgi?id=176431

Reviewed by Alex Christensen.

Source/WebCore:

AVFoundation header detection should be done in WebCore because of build dependencies.

No new tests, covered by existing tests.

• AVFoundationSupport.py: Copied from Source/WTF/AVFoundationSupport.py.
• PlatformWin.cmake:
• config.h:
• platform/graphics/ca/win/PlatformCALayerWin.cpp:
• platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:

Source/WTF:

AVFoundation header detection should be done in WebCore because of build dependencies.

• AVFoundationSupport.py: Removed.
• wtf/Platform.h:
• wtf/PlatformWin.cmake:

1:03 PM Changeset in webkit [221692] by fpizlo@apple.com

• 5 edits in trunk/Tools

WSL: Inliner doesn't allow double-negation
​https://bugs.webkit.org/show_bug.cgi?id=176440

Reviewed by Mylex Maxfield.

The problem was that we were visiting the operands to calls while inside doVisit. This is too strict
since it rejects nested calls like foo(foo(x)). The solution is to visit the operands to calls before
entering doVisit.

This also fixes some other issues in the parser that made the Inliner's error really strange.

• WebGPUShadingLanguageRI/Func.js:

(Func):

• WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):

• WebGPUShadingLanguageRI/Parse.js:

(parseOperatorFuncDefValues):
(parseNonOperatorFuncDefValues):
(parseGenericFuncDefValues):
(parseFuncDecl):

• WebGPUShadingLanguageRI/Test.js:
• WebGPUShadingLanguageRI/VisitingSet.js:

(VisitingSet.prototype.doVisit):
(VisitingSet):

12:46 PM Changeset in webkit [221691] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebInspectorUI

Web Inspector: ⌘E and ⌘G do not work in main content area when quick console drawer is open
​https://bugs.webkit.org/show_bug.cgi?id=176433

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-06
Reviewed by Brian Burg.

Make the ⌘E and ⌘G keyboard shortcuts behave more like the global ⌘K clear shortcut.
Instead of keeping them inside of FindBanner, and enabling/disabling them when they
make sense to apply, we make a single global instance of the keyboard shortcut and
apply it to whatever content view / content browser is active. This avoids conflicts
in situations where there are two ContentViews that are visible and each can handle
the keyboard shortcut.

• UserInterface/Base/Main.js:

(WI.contentLoaded):
New keyboard shortcuts.

(WI._populateFind):
(WI._findNext):
(WI._findPrevious):
Perform the shortcut on the active content view or content browser.

• UserInterface/Views/ContentBrowser.js:

(WI.ContentBrowser.prototype.shown):
(WI.ContentBrowser.prototype.hidden):
(WI.ContentBrowser.prototype.handlePopulateFindShortcut):
(WI.ContentBrowser.prototype.handleFindNextShortcut):
(WI.ContentBrowser.prototype.handleFindPreviousShortcut):
(WI.ContentBrowser.prototype.findBannerSearchQueryForSelection): Deleted.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView.prototype.handlePopulateFindShortcut):
(WI.LogContentView.prototype.handleFindNextShortcut):
(WI.LogContentView.prototype.handleFindPreviousShortcut):
ContentBrowser and LogContentView (the only content view with a custom find banner)
now each handle the global keyboard shortcut handlers to do the right thing for
their respective cases.

• UserInterface/Views/FindBanner.js:

(WI.FindBanner.prototype.enableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype.disableKeyboardShortcuts): Deleted.
(WI.FindBanner.prototype._populateSearchQueryFromSelection): Deleted.
Move keyboard shortcut handling up to Main.js to be global.

• UserInterface/Views/ContentView.js:

(WI.ContentView.prototype.searchQueryWithSelection):
Default implementation should grab the selected text from the selection.
Previously shortcut selections only worked for selections in text editors.

12:34 PM Changeset in webkit [221690] by mmaxfield@apple.com

• 1 edit
  2 adds in trunk/Tools

WSL should support the bool type
​https://bugs.webkit.org/show_bug.cgi?id=176285

Reviewed by Filip Pizlo.

I forgot to commit a couple files.

• WebGPUShadingLanguageRI/StandardLibraryEpilogue.js: Added.

(const.standardLibraryEpilogue.operator.bool.T.Equatable):

• WebGPUShadingLanguageRI/StandardLibraryPrologue.js: Added.

(operator.T.T):

11:49 AM Changeset in webkit [221689] by commit-queue@webkit.org

• 3 edits
  4 adds in trunk

REGRESSION (r221598): Legacy "round" and "bevel" options can no longer be used with the legacy CanvasRenderingContext2D setLineJoin operation
​https://bugs.webkit.org/show_bug.cgi?id=176461

Patch by Sam Weinig <​sam@webkit.org> on 2017-09-06
Reviewed by Alex Christensen.

Source/WebCore:

Tests: fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html

fast/canvas/canvas-strokePath-cap-join-legacy.html

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setLineJoin):

Fix silly typo, ifs -> else ifs.

LayoutTests:

Add tests showing that the legacy setLineJoin and setLineCap operations are correct
and match the corresponding standard attributes.

• fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute-expected.html: Added.
• fast/canvas/canvas-strokePath-cap-join-legacy-functions-match-attribute.html: Added.
• fast/canvas/canvas-strokePath-cap-join-legacy-expected.txt: Added.
• fast/canvas/canvas-strokePath-cap-join-legacy.html: Added.

11:45 AM Changeset in webkit [221688] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Rebaseline printing/width-overflow.html after r219121.

Unreviewed test gardening.

• platform/win/printing/width-overflow-expected.txt:

11:26 AM Changeset in webkit [221687] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked js/arraybuffer-wrappers.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=155092

Unreviewed test gardening.

• platform/ios/TestExpectations:

11:25 AM Changeset in webkit [221686] by mmaxfield@apple.com

• 18 edits
  1 copy
  1 delete in trunk/Tools

WSL should correctly handle the interaction between casting operators and complex types
​https://bugs.webkit.org/show_bug.cgi?id=176316

Reviewed by Filip Pizlo.

This allows the standard library to include all identity cast operators for all exsting
and yet-to-exist types. The standard library now has a function with the signature:
operator T<><T>(T). This means "for all T, define a cast operator from T to T<>." The
duplicate <>s lets us say things like operator OutputVector<T><T>(InputVector<T> x).

For testing, this patch also adds the ability to cast an arbitrary Equatable type to bool,
by comparing the value to the default value for that type.

• WebGPUShadingLanguageRI/All.js:
• WebGPUShadingLanguageRI/CastExpression.js: Copied from Tools/WebGPUShadingLanguageRI/NativeFuncInstance.js.

(CastExpression):
(CastExpression.prototype.get functionName):
(CastExpression.prototype.get returnType):
(CastExpression.prototype.toString):

• WebGPUShadingLanguageRI/Checker.js:
• WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toDeclString):

• WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitNativeFunc):
(FuncInstantiator.prototype.getUnique.Instantiate):
(FuncInstantiator.prototype.getUnique):
(FuncInstantiator):

• WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCastExpression):
(Inliner):

• WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

• WebGPUShadingLanguageRI/NativeFunc.js:
• WebGPUShadingLanguageRI/NativeFuncInstance.js:

(NativeFuncInstance):

• WebGPUShadingLanguageRI/Parse.js:

(parsePossiblePrefix):
(parseFuncDecl):
(parseOperatorFuncDefValues): Deleted.
(parseNonOperatorFuncDefValues): Deleted.
(parseGenericFuncDefValues): Deleted.

• WebGPUShadingLanguageRI/Prepare.js:

(prepare):

• WebGPUShadingLanguageRI/Program.js:

(Program.prototype.resolveFuncOverload):

• WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

• WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.processDerivedCallData):
(Rewriter.prototype.visitCastExpression):
(Rewriter.prototype.visitCallExpression):

• WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
• WebGPUShadingLanguageRI/Test.html:
• WebGPUShadingLanguageRI/Test.js:
• WebGPUShadingLanguageRI/TypeDefResolver.js:

(TypeDefResolver):
(TypeDefResolver.prototype.visitFuncDef): Deleted.

• WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitCastExpression):

11:16 AM Changeset in webkit [221685] by fpizlo@apple.com

• 1 edit
  5 adds in trunk/PerformanceTests

We should have more tests of tail calls
​https://bugs.webkit.org/show_bug.cgi?id=175754

Reviewed by Sam Weinig.

This introduces a new test suite called TailBench9000, which will have benchmarks written in
JavaScript that avoid all looping except by tail call. As a warmup, I wrote a mergesort
benchmark and I proted n-body to use tail calls instead of for loops.

• TailBench9000: Added.
• TailBench9000/merge-sort-run.js: Added.
• TailBench9000/merge-sort.js: Added.

(TEST_mergeSort.createRNG):
(TEST_mergeSort.):
(TEST_mergeSort.merge):
(TEST_mergeSort.mergeSorted):
(TEST_mergeSort.checkSorted.check):
(TEST_mergeSort.checkSorted):
(TEST_mergeSort.add):
(TEST_mergeSort.build):
(TEST_mergeSort.compare):
(TEST_mergeSort.checkSpectrum):
(TEST_mergeSort.buildArray):
(TEST_mergeSort):

• TailBench9000/n-body-run.js: Added.
• TailBench9000/n-body.js: Added.

(TEST_nBody.Body):
(TEST_nBody.Body.prototype.offsetMomentum):
(TEST_nBody.Jupiter):
(TEST_nBody.Saturn):
(TEST_nBody.Uranus):
(TEST_nBody.Neptune):
(TEST_nBody.Sun):
(TEST_nBody.NBodySystem):
(TEST_nBody.NBodySystem.prototype.advance):
(TEST_nBody.NBodySystem.prototype.energy):
(TEST_nBody):

10:47 AM Changeset in webkit [221684] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

[Win] Compile errors in Document::updateTitleElement.
​https://bugs.webkit.org/show_bug.cgi?id=176381

Reviewed by Alex Christensen.

MSVC is not able to compile the statement:
'auto result = boolExpression ? lambda1 : lambda2;'
where 'lambda1' and 'lambda2' have the same signature.

• dom/Document.cpp:

(WebCore::findHTMLTitle):
(WebCore::isHTMLTitle):
(WebCore::isHTMLTitleEligible):
(WebCore::findSVGTitle):
(WebCore::isSVGTitle):
(WebCore::isSVGTitleEligible):
(WebCore::Document::updateTitleElement):

10:30 AM Changeset in webkit [221683] by Brent Fulgham

• 15 edits
  2 adds in trunk

Deny third-party cookie creation for prevalent resources without interaction
​https://bugs.webkit.org/show_bug.cgi?id=175232
<rdar://problem/33709386>

Reviewed by Alex Christensen.

Source/WebCore:

Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.

This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.

Tests: http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html

• platform/network/NetworkStorageSession.h:
• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::shouldPartitionCookies const): Revise for new naming.
(WebCore::NetworkStorageSession::shouldAllowThirdPartyCookies const): Allow third party cookies when the
user interaction property applies.
(WebCore::NetworkStorageSession::shouldBlockCookies const): Deny cookies for origins that are not allowed by
user interaction, and that are not being partitioned.
(WebCore::NetworkStorageSession::setPrevalentDomainsWithAndWithoutInteraction): Revise for new naming, and
to track prevalent origins with and without user interaction.
(WebCore::NetworkStorageSession::setShouldPartitionCookiesForHosts): Renamed to setPrevalentDomainsWithAndWithoutInteraction.
(WebCore::NetworkStorageSession::removePrevalentDomains): New helper function for testing.

Source/WebKit:

Prior to Intelligent Tracking Prevention, WebKit would deny the ability to create a third party cookie if the user's
settings prohibited it. Due to the internal mechanics of cookie partitioning, we now accept the third party cookie,
but destroy it at some arbitrary moment which is difficult for websites to work with.

This patch revises WebKit so that attempts to set third party cookies without user interaction fails immediately,
which is what sites are expecting from Safari.

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updatePrevalentDomainsWithAndWithoutInteraction):
(WebKit::NetworkProcess::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in: Renamed the UpdateCookiePartitioningForTopPrivatelyOwnedDomains message

to UpdatePrevalentDomainsWithAndWithoutInteraction.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa): Recognize cases where a network session should block cookies, and
use the stateless session so we fail immediately when attempting an invalid cookie set operation.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(WebKit::WKWebsiteDataStore::_resourceLoadStatisticsSetShouldPartitionCookies): Use new helper function to clear partitioning state.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning): Track domains with and without interaction so that we can recognize
domains that should be immediately blocked from setting cookies.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains): Update for revised naming.
(WebKit::WebResourceLoadStatisticsStore::scheduleClearPartitioningStateForDomains): Added helper function for testing.

• UIProcess/WebResourceLoadStatisticsStore.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updatePrevalentDomainsWithAndWithoutInteraction): Update for revised naming.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback): Ditto.
(WebKit::WebsiteDataStore::updateCookiePartitioningForTopPrivatelyOwnedDomains): Renamed to updatePrevalentDomainsWithAndWithoutInteraction.

• UIProcess/WebsiteData/WebsiteDataStore.h:

LayoutTests:

• http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html: Added.
• platform/mac-highsierra-wk2/TestExpectations: Add new test expectation.

10:24 AM Changeset in webkit [221682] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Layout Test http/tests/preload/single_download_preload.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=176465.

Unreviewed test gardening.

• platform/win/TestExpectations:

10:05 AM Changeset in webkit [221681] by Adrian Perez de Castro

• 2 edits in trunk/Source/WebKit

[WPE][CMake] Fix path to the WebKitApplicationInfo.h header.

Unreviewed build fix.

This doesn't really make a difference for the build bots, but it makes
it possible to craft working release tarballs of WPE.

• PlatformWPE.cmake: Use the WPE version of WebKitApplicationInfo.h

10:02 AM Changeset in webkit [221680] by commit-queue@webkit.org

• 2 edits
  10 adds in trunk/LayoutTests

[WPE] Add missing test expectations
​https://bugs.webkit.org/show_bug.cgi?id=176453

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-09-06

• platform/wpe/TestExpectations:
• platform/wpe/fast/events/context-no-deselect-expected.txt: Added.
• platform/wpe/fast/events/event-listener-on-link-expected.txt: Added.
• platform/wpe/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
• platform/wpe/fast/events/onload-re-entry-expected.txt: Added.
• platform/wpe/fast/events/pointer-events-2-expected.txt: Added.
• platform/wpe/fast/events/resize-events-expected.txt: Added.
• platform/wpe/fast/events/reveal-link-when-focused-expected.txt: Added.
• platform/wpe/fast/events/updateLayoutForHitTest-expected.txt: Added.
• platform/wpe/fast/inspector-support/matchedrules-expected.txt: Added.

9:55 AM Changeset in webkit [221679] by dbates@webkit.org

• 2 edits in trunk/Tools

Copy WebKit Permalink may generate wrong URL with SVN checkout
​https://bugs.webkit.org/show_bug.cgi?id=176427

Reviewed by Darin Adler.

Fixes an issue where Copy WebKit Permalink would generate an incorrect URL for
any file not in the top-level directory of the repository when using an SVN
checkout of WebKit.

Copy WebKit Permalink changes directories to the containing directory D of the
active Xcode document F before running "svn info <path to F>". Currently we use
the value of "Path" from the output of "svn info" when generating the permalink.
This path is relative to D. But we want the path to F relative to the top-level
checkout directory. We need to explicitly compute this.

• CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow:

9:39 AM Changeset in webkit [221678] by Carlos Garcia Campos

• 1800 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 7.

9:37 AM Changeset in webkit [221677] by tpopela@redhat.com

• 2 edits in trunk/Source/WebCore

Missing break in URLParser
​https://bugs.webkit.org/show_bug.cgi?id=176357

Reviewed by Darin Adler.

Add a missing break so the currently set state is not overwritten
after the block. Found by Coverity scan.

• platform/URLParser.cpp:

(WebCore::URLParser::parse):

9:25 AM Changeset in webkit [221676] by Carlos Garcia Campos

• 945 edits
  304 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 6.

9:15 AM Changeset in webkit [221675] by Carlos Garcia Campos

• 1457 edits
  1 copy
  4 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 5.

9:11 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com

(diff)

9:04 AM Changeset in webkit [221674] by Carlos Garcia Campos

• 1806 edits
  1 copy
  2 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 4.

8:51 AM Changeset in webkit [221673] by Carlos Garcia Campos

• 1791 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 3.

8:37 AM Changeset in webkit [221672] by Carlos Garcia Campos

• 1562 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 2.

8:25 AM Changeset in webkit [221671] by Carlos Garcia Campos

• 1853 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline tests after Freetype version bump in r221670. Part 1.

8:10 AM Changeset in webkit [221670] by Carlos Garcia Campos

• 4 edits
  1 delete in trunk

[GTK] Bump freetype version to 2.8.0
​https://bugs.webkit.org/show_bug.cgi?id=176351

Source/WebCore:

Patch by Dominik Röttsches <​dominik.rottsches@intel.com> on 2017-09-06
Reviewed by Carlos Alberto Lopez Perez.

Retrieving line spacing info without metrics hinting - FreeType's metric hinting
uses rounding which results in the sum of ascent and descent being larger
than the line height. To work around this without globally disabling font metrics
hinting, I am temporarily creating a new cairo scaled font with metrics hinting
off and retrieving the height values from this one.

• platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::scaledFontWithoutMetricsHinting): New function to clone the existing font, only with metrics hinting
disabled.
(WebCore::Font::platformInit): Get height info from non-metrics hinted font, disable rounding for linespacing.

Tools:

Reviewed by Carlos Alberto Lopez Perez.

Remove the patch we were using since it was reverted upstream.

• gtk/jhbuild.modules:
• gtk/patches/freetype6-2.4.11-truetype-font-height-fix.patch: Removed.

7:52 AM WebKitGTK/2.16.x edited by Michael Catanzaro

(diff)

5:42 AM Changeset in webkit [221669] by commit-queue@webkit.org

• 7 edits
  4 adds in trunk/Source

Introduce ScrollingTreeScrollingNodeDelegateIOS to share code between overflow and frame scrolling
​https://bugs.webkit.org/show_bug.cgi?id=174097

Patch by Frédéric Wang <​fwang@igalia.com> on 2017-09-06
Reviewed by Darin Adler.

Source/WebCore:

No new tests, behavior unchanged.

• WebCore.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegate.
• page/scrolling/ScrollingTreeScrollingNode.h: Make ScrollingTreeScrollingNodeDelegate a

friend so that it can access private members.

• page/scrolling/ScrollingTreeScrollingNodeDelegate.cpp: Added. New delegate class for a

scrolling node, which is used by the UI process.
(WebCore::ScrollingTreeScrollingNodeDelegate::ScrollingTreeScrollingNodeDelegate):
Constructor, taking the scrolling node as a parameter.
(WebCore::ScrollingTreeScrollingNodeDelegate::~ScrollingTreeScrollingNodeDelegate):
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingTree const): Expose the scrolling
tree containing the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::lastCommittedScrollPosition const): Expose
the last committed scroll position of the scrolling node.

• page/scrolling/ScrollingTreeScrollingNodeDelegate.h: Added.

(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode): Expose the scrolling node.
(WebCore::ScrollingTreeScrollingNodeDelegate::scrollingNode const): Ditto.

Source/WebKit:

This patch introduces a new ScrollingTreeScrollingNodeDelegateIOS that can be used by
WKOverflowScrollViewDelegate to communicate to the scrolling tree and nodes. It can also be
used as a helper class by ScrollingTreeOverflowScrollingNodeIOS. For now, only the non-
overriden member functions of ScrollingTreeOverflowScrollingNodeIOS are moved to that new
class. In follow-up commits, WKOverflowScrollViewDelegate can become a generic
ScrollViewDelegate and more code can be moved into the ScrollingTreeScrollingNodeDelegateIOS
file. Frame scrolling nodes will then be able to share the same UI code as overflow:auto when
iOS frame scrolling is implemented (bug 149264).

• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.h: Move non-overriden member

functions and m_updatingFromStateNode into the delegate class. Also define a member to store
that delegate.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeOverflowScrollingNodeIOS.mm: Use the node delegate to

communicate to the scrolling tree and node.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNodeDelegate:]): Init with a delegate.
(-[WKOverflowScrollViewDelegate scrollViewDidScroll:]): Call the delegate function.
(-[WKOverflowScrollViewDelegate scrollViewWillBeginDragging:]): Ditto.
(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):
Use the delegate functions or pass by ScrollingTreeScrollingNodeDelegateIOS::scrollingNode().
(-[WKOverflowScrollViewDelegate scrollViewDidEndDragging:willDecelerate:]): Use the delegate
functions.
(-[WKOverflowScrollViewDelegate scrollViewDidEndDecelerating:]): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::ScrollingTreeOverflowScrollingNodeIOS):
Init the delegate for this class.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::commitStateAfterChildren): Use the delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::setScrollLayerPosition): Use the delegate
function.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateLayersAfterDelegatedScroll): Ditto.
(-[WKOverflowScrollViewDelegate initWithScrollingTreeNode:]): Deleted. This is renamed
initWithScrollingTreeNodeDelegate and accepts a delegate.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::updateChildNodesAfterScroll): Deleted. Moved
to ScrollingTreeScrollingNodeDelegateIOS.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollWillStart): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollDidEnd): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::overflowScrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::currentSnapPointIndicesDidChange): Ditto.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Added. New delegate class

for ScrollingTreeOverflowScrollingNodeIOS. The members used by WKOverflowScrollViewDelegate
are public and the others are private. ScrollingTreeOverflowScrollingNodeIOS is a friend of
ScrollingTreeScrollingNodeDelegateIOS so that it can access private members e.g.
updateChildNodesAfterScroll() or m_updatingFromStateNode.

• UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm: Added.

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::~ScrollingTreeScrollingNodeDelegateIOS):
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll): Code extracted
from ScrollingTreeOverflowScrollingNodeIOS.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollWillStart): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollDidEnd): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewWillStartPanGesture): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::scrollViewDidScroll): Ditto.
(WebKit::ScrollingTreeScrollingNodeDelegateIOS::currentSnapPointIndicesDidChange): Ditto.

• WebKit.xcodeproj/project.pbxproj: Add ScrollingTreeScrollingNodeDelegateIOS files to the

build system.

3:54 AM WebKitGTK/Debugging edited by tpopela@redhat.com

(diff)

2:59 AM Changeset in webkit [221668] by Manuel Rego Casasnovas

• 8 edits
  2 adds in trunk

[css-grid] grid shorthand should not reset the gutter properties
​https://bugs.webkit.org/show_bug.cgi?id=176375

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Import new test from WPT.

• web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001-expected.txt: Added.
• web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html: Added.
• web-platform-tests/css/css-grid-1/grid-definition/w3c-import.log:

Source/WebCore:

The CSS WG has resolved that the "grid" shorthand shouldn't reset
the gutter properties anymore:
​https://github.com/w3c/csswg-drafts/issues/1036

This was originally implemented in r195529, so this is somehow
a revert of that change.

Test: imported/w3c/web-platform-tests/css/css-grid-1/grid-definition/grid-shorthand-001.html

• css/CSSProperties.json:
• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeGridShorthand):

LayoutTests:

Update the test to check the new behavior.

• fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
• fast/css-grid-layout/grid-shorthand-get-set.html:

1:17 AM Changeset in webkit [221667] by zandobersek@gmail.com

• 11 edits
  2 adds in trunk

[WebGL2] Implement getActiveUniforms()
​https://bugs.webkit.org/show_bug.cgi?id=175203

Reviewed by Darin Adler.

Source/WebCore:

Align getActiveUniforms() WebIDL signature with the spec -- making it
return a WebGLAny object, making the program parameter non-nullable,
and making the uniformIndices parameter a sequence on GLuint values.

The getActiveUniforms() implementation in WebGL2RenderingContext
validates the passed-in program and parameter name and then calls the
GraphicsContext3D::getActiveUniforms() method, retrieving an array of
integers that represent values of the requested parameter name for
each uniform whose index was passed through uniformIndices.

Test: fast/canvas/webgl/webgl2-getActiveUniforms.html

• bindings/js/JSDOMConvertWebGL.cpp:

(WebCore::convertToJSValue):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getActiveUniforms):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLAny.h:
• platform/graphics/GraphicsContext3D.h:
• platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getActiveUniforms):

LayoutTests:

Add a basic gl.getActiveUniforms() test that checks proper return values
for a mat4 uniform in the simple vertex shader that's used when creating
the 'standard' program through webgl-test.js utilities. The test remains
skipped on GTK+ and Windows (WebGL 2.0 disabled). Mac port skips it as
well since the shader can't be compiled properly. WPE and iOS run the
test and are passing it.

• fast/canvas/webgl/webgl2-getActiveUniforms-expected.txt: Added.
• fast/canvas/webgl/webgl2-getActiveUniforms.html: Added.
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:

12:23 AM Changeset in webkit [221666] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[Win] Tools/TestWebKitAPI/Tests/WTF/PriorityQueue.cpp fails to compile with MSVC 2015
​https://bugs.webkit.org/show_bug.cgi?id=176442

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-09-06
Reviewed by Keith Miller.

• TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):