Timeline



Dec 13, 2017:

11:45 PM Changeset in webkit [225895] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Network Tab - Make text filter just a URL filter and update incrementally
https://bugs.webkit.org/show_bug.cgi?id=180796

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-13
Reviewed by Brian Burg.

Revert the Network Tab's text filter back to being just a URL filter with the
normal behaviors of our other text filters that update as you type (incremental).
This also renames the "text filter" to "url filter" everywhere in the ContentView
for clarity. A follow-up change will make the url filter be case-insensitive
to fully match the filter bars in other tabs.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.get filterNavigationItems):
(WI.NetworkTableContentView.prototype._checkURLFilterAgainstFinishedResource):
(WI.NetworkTableContentView.prototype._updateURLFilterActiveIndicator):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFinish):
(WI.NetworkTableContentView.prototype._resourceLoadingDidFail):
(WI.NetworkTableContentView.prototype._hasURLFilter):
(WI.NetworkTableContentView.prototype._hasActiveFilter):
(WI.NetworkTableContentView.prototype._passURLFilter):
(WI.NetworkTableContentView.prototype._passFilter):
(WI.NetworkTableContentView.prototype._updateFilteredEntries):
(WI.NetworkTableContentView.prototype._resetFilters):
(WI.NetworkTableContentView.prototype._urlFilterDidChange):
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFinishedResource): Deleted.
(WI.NetworkTableContentView.prototype._checkTextFilterAgainstFailedResource): Deleted.
(WI.NetworkTableContentView.prototype._updateTextFilterActiveIndicator): Deleted.
(WI.NetworkTableContentView.prototype._hasTextFilter): Deleted.
(WI.NetworkTableContentView.prototype._passTextFilter): Deleted.
(WI.NetworkTableContentView.prototype._textFilterDidChange): Deleted.

11:00 PM Changeset in webkit [225894] by dbates@webkit.org
  • 1 edit
    3 adds in trunk/LayoutTests

Add more auto fill button types
https://bugs.webkit.org/show_bug.cgi?id=180651
<rdar://problem/35891125>
And
<rdar://problem/35977943>

Add macOS El Capitan-specific and Windows expected results. I included results from the Apple Windows bot
as a baseline. The results are incorrect as they render the password field text using bullets instead of
plain text. Further investigation required.

  • platform/mac-elcapitan/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
  • platform/win/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
  • platform/win/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
10:04 PM Changeset in webkit [225893] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Octane/richards regressed by a whopping 20% because eliminateCommonSubexpressions has a weird fixpoint requirement
https://bugs.webkit.org/show_bug.cgi?id=180783

Reviewed by Saam Barati.

This fixes the regression by fixpointing CSE. We need to fixpoint CSE because of this case:

BB#1:

a: Load(@x)
b: Load(@x)
c: Load(@b)

BB#2:

d: Load(@b)

BB#3:

e: Load(@b)


Lets assume that #3 loops around to #2, so to eliminate @d, we need to prove that it's redundant
with both @c and @e. The problem is that by the time we get to @d, the CSE state will look like
this:

BB#1:

a: Load(@x)
b: Load(@x)
c: Load(@a)
memoryAtTail: {@x=>@a, @a=>@c}

BB#2:

d: Load(@a) [sic]
memoryAtTail: {@b=>@d}

BB#3:

e: Load(@b)
memoryAtTail: {@b=>@e} [sic]


Note that #3's atTail map is keyed on @b, which was the old (no longer canonical) version of @a.
But @d's children were already substituted, so it refers to @a. Since @a is not in #3's atTail
map, we don't find it and leave the redundancy.

I think that the cleanest solution is to fixpoint. CSE is pretty cheap, so hopefully we can afford
this. It fixes the richards regression, since richards is super dependent on B3 CSE.

  • b3/B3EliminateCommonSubexpressions.cpp: Logging.
  • b3/B3Generate.cpp:

(JSC::B3::generateToAir): Fix the bug.

  • b3/air/AirReportUsedRegisters.cpp:

(JSC::B3::Air::reportUsedRegisters): Logging.

  • dfg/DFGByteCodeParser.cpp:
  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run): Don't generate EntrySwitch if we don't need it (makes IR easier to read).

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower): Don't generate EntrySwitch if we don't need it (makes IR easier to read).

8:47 PM Changeset in webkit [225892] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk

REGRESSION: Web Inspector: Opening inspector crashes page if there are empty resources
https://bugs.webkit.org/show_bug.cgi?id=180787
<rdar://problem/35934838>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-13
Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):
For empty / null strings just return. There is no use
trying to search them for a long common syntax.

Source/WebInspectorUI:

  • UserInterface/Test/TestUtilities.js:

Add a generic sanitizeURL used by many tests.

  • UserInterface/TestStub.html:

Include TestUtilities.

LayoutTests:

  • inspector/page/resources/empty.css: Added.
  • inspector/page/resources/empty.js: Added.
  • inspector/page/empty-or-missing-resources-expected.txt: Added.
  • inspector/page/empty-or-missing-resources.html: Added.

Test no crashes inspecting a page with empty/missing resources.
Previously the test would crash.

  • inspector/canvas/recording-webgl-snapshots.html:
  • inspector/canvas/resources/create-context-utilities.js:
  • inspector/canvas/resources/recording-utilities.js:
  • inspector/css/getAllStyleSheets.html:
  • inspector/css/stylesheet-events-basic.html:
  • inspector/css/stylesheet-events-imports.html:
  • inspector/css/stylesheet-events-multiple-documents.html:
  • inspector/worker/console-basic.html:
  • inspector/worker/debugger-scripts.html:
  • inspector/worker/resources-in-worker.html:
  • inspector/worker/runtime-basic.html:
  • inspector/worker/worker-create-and-terminate.html:

Promote sanitizeURL to a TestUtility function since it is common.

8:10 PM Changeset in webkit [225891] by sbarati@apple.com
  • 11 edits
    1 add in trunk

Arrow functions need their own structure because they have different properties than sloppy functions
https://bugs.webkit.org/show_bug.cgi?id=180779
<rdar://problem/35814591>

Reviewed by Mark Lam.

JSTests:

  • stress/arrow-function-needs-its-own-structure.js: Added.

(assert):
(readPrototype):
(noInline.let.f1):
(noInline):

Source/JavaScriptCore:

We were using the same structure for sloppy functions and
arrow functions. This broke our IC caching machinery because
these two types of functions actually have different properties.
This patch gives them different structures.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunction):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::selectStructureForNewFuncExp):
(JSC::JSFunction::create):

  • runtime/JSFunction.h:
  • runtime/JSFunctionInlines.h:

(JSC::JSFunction::createWithInvalidatedReallocationWatchpoint):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::arrowFunctionStructure const):

7:05 PM Changeset in webkit [225890] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Fix copy/paste error in ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration()
https://bugs.webkit.org/show_bug.cgi?id=180782

Reviewed by Youenn Fablet.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):

6:37 PM Changeset in webkit [225889] by dbates@webkit.org
  • 5 edits
    2 adds in trunk/LayoutTests

Add more auto fill button types
https://bugs.webkit.org/show_bug.cgi?id=180651
<rdar://problem/35891125>
And
<rdar://problem/35977943>

Update expected results. I included results from the GTK bot as a baseline. The results are incorrect as they
render the password field text using bullets instead of plain text. This likely indicates that the bots did not
regenerate the user-agent style sheet.

  • platform/gtk/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
  • platform/gtk/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
  • platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
  • platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
  • platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt:
  • platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt:
5:45 PM Changeset in webkit [225888] by clopez@igalia.com
  • 2 edits in trunk

[WPE] WebCrypto should be a public option.
https://bugs.webkit.org/show_bug.cgi?id=180780

Reviewed by Konstantin Tokarev.

Make ENABLE_WEB_CRYPTO public and lower the dependency requirements
when this option is not enabled. This is also how the GTK+ port
configures the visibility of this option and its dependencies.

  • Source/cmake/OptionsWPE.cmake:
5:12 PM Changeset in webkit [225887] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

InferredValue should use IsoSubspace
https://bugs.webkit.org/show_bug.cgi?id=180738

Reviewed by Keith Miller.

This moves InferredValue into an IsoSubspace and then takes advantage of this to get rid of
its UnconditionalFinalizer.

(JSC::Heap::finalizeUnconditionalFinalizers):

  • runtime/InferredValue.cpp:

(JSC::InferredValue::visitChildren):
(JSC::InferredValue::ValueCleanup::ValueCleanup): Deleted.
(JSC::InferredValue::ValueCleanup::~ValueCleanup): Deleted.
(JSC::InferredValue::ValueCleanup::finalizeUnconditionally): Deleted.

  • runtime/InferredValue.h:

(JSC::InferredValue::subspaceFor):

  • runtime/InferredValueInlines.h: Added.

(JSC::InferredValue::finalizeUnconditionally):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
5:07 PM Changeset in webkit [225886] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173742

Unreviewed test gardening

  • platform/mac-wk2/TestExpectations:
5:02 PM Changeset in webkit [225885] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Windows build after <https://trac.webkit.org/changeset/225879>
(https://bugs.webkit.org/show_bug.cgi?id=180651)

  • html/TextFieldInputType.cpp:

(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):

4:57 PM Changeset in webkit [225884] by webkit@devinrousso.com
  • 23 edits
    6 adds in trunk

Web Inspector: add instrumentation for ImageBitmapRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=180736

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:
  • inspector/scripts/codegen/generator.py:

Source/WebCore:

Tests: inspector/canvas/create-context-bitmaprenderer.html

inspector/canvas/requestContent-bitmaprenderer.html
inspector/canvas/resolveCanvasContext-bitmaprenderer.html

  • CMakeLists.txt:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::createContextBitmapRenderer):
Support passing an optional settings dictionary when creating an ImageBitmapRenderingContext.

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::requestContent):
(WebCore::contextAsScriptValue):

  • bindings/js/CallTracerTypes.h:
  • inspector/InspectorCanvas.h:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildObjectForCanvas):
(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForImageBitmap): Deleted.

Source/WebInspectorUI:

  • UserInterface/Base/ImageUtilities.js:

(WI.ImageUtilities.promisifyLoad):
(WI.ImageUtilities.imageFromImageBitmap):

  • UserInterface/Models/Canvas.js:

(WI.Canvas.fromPayload):
(WI.Canvas.displayNameForContextType):

  • UserInterface/Models/NativeFunctionParameters.js:
  • UserInterface/Models/Recording.js:

(WI.Recording.displayNameForSwizzleType):
(WI.Recording.prototype.async swizzle):

  • UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement._generateDOM.createParameterElement):

LayoutTests:

  • inspector/canvas/context-attributes-expected.txt:
  • inspector/canvas/context-attributes.html:
  • inspector/canvas/create-context-bitmaprenderer-expected.txt: Added.
  • inspector/canvas/create-context-bitmaprenderer.html: Added.
  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-2d.html:
  • inspector/canvas/requestContent-bitmaprenderer-expected.txt: Added.
  • inspector/canvas/requestContent-bitmaprenderer.html: Added.
  • inspector/canvas/resolveCanvasContext-bitmaprenderer-expected.txt: Added.
  • inspector/canvas/resolveCanvasContext-bitmaprenderer.html: Added.
4:50 PM Changeset in webkit [225883] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.17.1/Source

Cherry-pick r225863. rdar://problem/35996158

4:49 PM Changeset in webkit [225882] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.17.1/Source

Versioning.

4:47 PM Changeset in webkit [225881] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.17.1

New tag.

4:31 PM Changeset in webkit [225880] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Take a value driven approach to how we emit structure checks in TypeCheckHoistingPhase to obviate the need for static_assert guards
https://bugs.webkit.org/show_bug.cgi?id=180771

Reviewed by JF Bastien.

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

4:29 PM Changeset in webkit [225879] by dbates@webkit.org
  • 29 edits
    14 adds in trunk

Add more auto fill button types
https://bugs.webkit.org/show_bug.cgi?id=180651
<rdar://problem/35891125>
And
<rdar://problem/35977943>

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html

fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html
fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html
fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html
fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html
fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html

  • English.lproj/Localizable.strings:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]): Add strings for new auto fill button types.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isAutofilledStrongPassword):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • css/html.css:

(input::-webkit-strong-password-auto-fill-button):
(input:-webkit-autofill-strong-password):
(input:-webkit-autofill, input:-webkit-autofill-strong-password):
(input:-webkit-autofill): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
Add new CSS pseudo class and CSS styles.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::reset): Hide the auto fill button when the form is reset. This is also called
whenever we suspend the page to put it into the page cache.
(WebCore::HTMLInputElement::setShowAutoFillButton): Modified to update the editability of the inner text element
and invalidate styles for the subtree as the editability may have changed depending on the auto fill button type.

(WebCore::autoFillStrongPasswordMaskImage):
(WebCore::HTMLInputElement::createInnerTextStyle):
(WebCore::HTMLInputElement::createInnerTextStyle const): Deleted.
Adjust the look of the inner text field. This function is not const because we may need to resolve style to
generate a mask image.

  • html/HTMLInputElement.h:

(WebCore::HTMLInputElement::autoFillButtonType const): Fix style nit; use a C++ style cast while I am in
this area.
(WebCore::HTMLInputElement::hasAutoFillStrongPasswordButton const): Added.

  • html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createInnerTextStyle):
(WebCore::HTMLTextAreaElement::createInnerTextStyle const): Deleted.
Made this non-const because HTMLInputElement::createInnerTextStyle() needs to be non-const. See above.

  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::isInnerTextElementEditable const):
(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability):
Extract out the query to determine if the inner text element is editable into a virtual function isInnerTextElementEditable()
and have updateInnerTextElementEditability() make use of it. By default a field is considered editable if it is not disabled
or read-only. We override updateInnerTextElementEditability() in HTMLInputElement to also consider the auto fill button type.

  • html/HTMLTextFormControlElement.h:
  • html/TextFieldInputType.cpp:

(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):
(WebCore::TextFieldInputType::createAutoFillButton):
(WebCore::TextFieldInputType::updateAutoFillButton):
Support having text for the auto fill button.

  • platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillStrongPasswordLabel):
(WebCore::AXAutoFillStrongConfirmationPasswordLabel):
(WebCore::autoFillStrongPasswordLabel):

  • platform/LocalizedStrings.h:

Add localized strings.

  • rendering/RenderTextControlSingleLine.h: Disallow scrolling depending on the auto fill button type.
  • testing/Internals.cpp:

(WebCore::toAutoFillButtonType):

  • testing/Internals.h:
  • testing/Internals.idl:

Add support for testing.

Source/WebKit:

Adds enumerators for the new auto fill button types.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(toAutoFillButtonType):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(toAutoFillButtonType):

  • WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

LayoutTests:

  • fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button-expected.html: Added.
  • fast/forms/auto-fill-button/input-autofilled-disabled-strong-password-auto-fill-button.html: Added.
  • fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button-expected.html: Added.
  • fast/forms/auto-fill-button/input-autofilled-readonly-strong-password-auto-fill-button.html: Added.
  • fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html: Added.
  • fast/forms/auto-fill-button/input-disabled-strong-password-and-strong-confirmation-password-auto-fill-buttons.html: Added.
  • fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons-expected.html: Added.
  • fast/forms/auto-fill-button/input-readonly-strong-password-and-strong-confirmation-password-auto-fill-buttons.html: Added.
  • fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button.html: Added.
  • fast/forms/auto-fill-button/input-strong-password-auto-fill-button.html: Added.
  • platform/ios/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
  • platform/ios/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
  • platform/mac/fast/forms/auto-fill-button/input-strong-confirmation-password-auto-fill-button-expected.txt: Added.
  • platform/mac/fast/forms/auto-fill-button/input-strong-password-auto-fill-button-expected.txt: Added.
4:05 PM Changeset in webkit [225878] by rniwa@webkit.org
  • 17 edits in trunk/Source/WebCore

Crash inside ImageLoader::updateFromElement()
https://bugs.webkit.org/show_bug.cgi?id=180769
<rdar://problem/35278782>

Reviewed by Antti Koivisto.

Fixed the crash by moving all call sites of ImageLoader::updateFromElement() to be post insertion callbacks
where it's safe to execute arbitrary scripts.

No new test since existing tests cover this with a newly added release assert in ImageLoader.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::didFinishInsertingNode): Extracted from insertedIntoAncestor to call
selectImageSource or updateFromElement.

  • html/HTMLImageElement.h: Made many member functions final.
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didAttachRenderers): Delay the call to ImageLoader::updateFromElement() in
ImageInputType using a post style resolution callback.

  • html/HTMLMetaElement.h:
  • html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::sourcesChanged): Store the list of child image elements into a vector before
calling selectImageSource since each call may execute arbitrary scripts.

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedIntoAncestor): Delay the call to ImageLoader::updateFromElement()
using a post style resolution callback.
(WebCore::HTMLSourceElement::didFinishInsertingNode): Extracted from insertedIntoAncestor.

  • html/HTMLSourceElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::didAttachRenderers):
(WebCore::HTMLVideoElement::updateAfterStyleResolution): Extracted from didAttachRenderers.

  • html/HTMLVideoElement.h:
  • html/ImageInputType.cpp:

(WebCore::ImageInputType::needsPostStyleResolutionCallback): Added. Returns true so that HTMLInputElement's
didAttachRenderers would register a post style resolution callback.
(WebCore::ImageInputType::updateAfterStyleResolution): Extracted from attach.
(WebCore::ImageInputType::attach): Deleted.

  • html/ImageInputType.h:
  • html/InputType.cpp:

(WebCore::InputType::needsPostStyleResolutionCallback): Added. All but ImageInputType returns false.
(WebCore::InputType::updateAfterStyleResolution): Added.
(WebCore::InputType::attach): Deleted.

  • html/InputType.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): Added a release assertion. There is no direct security implication
so there is no need to use RELEASE_ASSERT_WITH_SECURITY_IMPLICATION here.

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::insertedIntoAncestor):
(WebCore::SVGImageElement::didFinishInsertingNode):

  • svg/SVGImageElement.h:
3:58 PM Changeset in webkit [225877] by Matt Lewis
  • 15 edits in trunk

Unreviewed, rolling out r225864.

This caused the Layout test step to crash out on Debug testers

Reverted changeset:

"REGRESSION (r225789): API tests
WKProcessPool.InitialWarmedProcessUsed and
WebKit.WebsiteDataStoreCustomPaths are failing."
https://bugs.webkit.org/show_bug.cgi?id=180722
https://trac.webkit.org/changeset/225864

3:10 PM Changeset in webkit [225876] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.5.2.1

Tag Safari-604.5.2.1.

3:07 PM Changeset in webkit [225875] by jmarcell@apple.com
  • 5 edits in branches/safari-604.5.2-branch/Source

Cherry-pick r225535. rdar://problem/34531264

3:05 PM Changeset in webkit [225874] by jmarcell@apple.com
  • 7 edits in branches/safari-604.5.2-branch/Source

Versioning.

2:55 PM Changeset in webkit [225873] by jmarcell@apple.com
  • 1 copy in branches/safari-604.5.2-branch

New branch.

2:13 PM Changeset in webkit [225872] by Alan Bujtas
  • 5 edits
    2 adds in trunk

RenderImage can be destroyed even before setting the style on it.
https://bugs.webkit.org/show_bug.cgi?id=180767
<rdar://problem/33965995>

Reviewed by Simon Fraser.

Source/WebCore:

In certain cases, when the newly constructed renderer can't be inserted into the tree (parent can only have specific type of children etc),
RenderTreeUpdater destroys it right away. While destroying a RenderImage, the associated image resource assumes
that the image renderer has been initialized through RenderElement::initializeStyle(). This is an incorrect
assumption.
This patch also makes RenderImageResource's m_renderer a weak pointer.

Test: fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html

  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerContext):
(WebCore::RenderImageResource::imageSize const):

  • rendering/RenderImageResource.h:

(WebCore::RenderImageResource::renderer const):

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::shutdown):

LayoutTests:

  • fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle-expected.txt: Added.
  • fast/images/crash-when-image-renderer-is-destroyed-before-calling-initializeStyle.html: Added.
1:58 PM Changeset in webkit [225871] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.18/Source

Cherry-pick r225863. rdar://problem/35996158

1:46 PM Changeset in webkit [225870] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
https://bugs.webkit.org/show_bug.cgi?id=180713
<rdar://problem/36003031>

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-13
Reviewed by Andy Estes.

Reenable the check for non High Sierra builds.

  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:

(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):

1:16 PM Changeset in webkit [225869] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked accessibility/mac/html5-input-number.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=180560

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:12 PM Changeset in webkit [225868] by rniwa@webkit.org
  • 7 edits in trunk/Source/WebCore

Update the SVG use element's shadow trees explicitly before the style recall
https://bugs.webkit.org/show_bug.cgi?id=180729
<rdar://problem/36009806>

Reviewed by Antti Koivisto.

Update the SVG use element's shadow trees before start resolving styles. Document now has a hash set of all
connected SVG use elements with invalidated shadow trees. SVGUseElement adds itself to this set when its
shadow tree gets invalidated, or it gets newly connected to a document with the invalidated shadow tree.
SVGUseElement removes itself from this set when it updates its shadow tree or it gets disconnected from
a document with the invalidated shadow tree.

No new tests. Covered by existing tests.

  • dom/Document.cpp:

(WebCore::Document::~Document): Assert that m_svgUseElements has been cleared.
(WebCore::Document::resolveStyle): Update the shadow trees of SVG use elements with invalidated shadow trees.
(WebCore::Document::addSVGUseElement): Added.
(WebCore::Document::removeSVGUseElement): Added.

  • dom/Document.h:

(WebCore::Document::svgUseElements const): Added.

  • dom/Element.cpp:

(WebCore::Element::cloneElementWithChildren): Removed EventAllowedScope since the SVG use element's shadow
tree is no longer updated when there is a NoEventDispatchAssertion in the stack.
(WebCore::Element::cloneElementWithoutChildren): Ditto.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree): No longer drops the assertion now that SVG use element's
shadow tree is updated before calling this function.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::insertedIntoAncestor): Add the element to the document's hash set if this use element's
shadow tree needs to be updated (m_shadowTreeNeedsUpdate is set), and it got newly connected.
(WebCore::SVGUseElement::removedFromAncestor): Ditto for removal. We have to check m_shadowTreeNeedsUpdate before
calling SVGGraphicsElement::removedFromAncestor or updateExternalDocument since either function can invoke
m_shadowTreeNeedsUpdate to true.
(WebCore::SVGUseElement::willRecalcStyle): Deleted. We no longer call updateShadowTree during style recalc.
(WebCore::SVGUseElement::updateShadowTree): Remove this element from the document's hah set. We can't clear all
the entries in the map at once in Document::resolveStyle because updating the shadow trees of a SVG use element
can result in a sync IPC in ImageLoader::updateFromElement, which end up executing arbitrary author scripts.
(WebCore::SVGUseElement::cloneTarget const): Removed EventAllowedScope since the SVG use element's shadow tree
is no longer updated when there is a NoEventDispatchAssertion in the stack.
(WebCore::SVGUseElement::expandUseElementsInShadowTree const): Ditto.
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree const): Ditto.
(WebCore::SVGUseElement::invalidateShadowTree): Add the element to the document's hash set if it's connected.

  • svg/SVGUseElement.h:
12:54 PM Changeset in webkit [225867] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Removed debug only expectations from platform/ios/ios/plugin/youtube-flash-plugin-iframe.html
https://bugs.webkit.org/show_bug.cgi?id=163362

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
12:47 PM Changeset in webkit [225866] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Updated expectations for contentextension tests to be flaky.
https://bugs.webkit.org/show_bug.cgi?id=162942

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
12:46 PM Changeset in webkit [225865] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r225844): Around 850 new JSC failures on 32-bit
https://bugs.webkit.org/show_bug.cgi?id=180764

Unreviewed. We should only emit CheckStructureOrEmpty on 64 bit platforms.

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

12:20 PM Changeset in webkit [225864] by beidson@apple.com
  • 15 edits in trunk

REGRESSION (r225789): API tests WKProcessPool.InitialWarmedProcessUsed and WebKit.WebsiteDataStoreCustomPaths are failing.
https://bugs.webkit.org/show_bug.cgi?id=180722

Reviewed by Chris Dumez.

Source/WebKit:

  • Add a test-only accessor to get the number of WebProcesses hosting WebPages
  • Have WebsiteDataStore keep track of all instances so they can be looked up by SessionID
  • When the StorageProcess needs to establish a SW context connection on behalf of a specific SessionID, the UI process will now prefer using the WebsiteDataStore associated with that SessionID. This allows us to continue deferring creation of the default data store if it's not needed.
  • StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::connectionToContextProcessWasClosed):
(WebKit::StorageProcess::createServerToContextConnection):

  • StorageProcess/StorageProcess.h:
  • StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::establishSWServerConnection):

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _webPageContentProcessCount]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcess):
(WebKit::StorageProcessProxy::establishWorkerContextConnectionToStorageProcessForExplicitSession):

  • UIProcess/Storage/StorageProcessProxy.h:
  • UIProcess/Storage/StorageProcessProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):
(WebKit::WebsiteDataStore::existingDataStoreForSessionID):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/InitialWarmedProcessUsed.mm:

(TEST): Call a new SPI to get the count of WebProcesses hosting WebPages.

12:19 PM Changeset in webkit [225863] by pvollan@apple.com
  • 7 edits in trunk/Source

REGRESSION(225597): Can't select a text box or web view on a page when VO is on.
https://bugs.webkit.org/show_bug.cgi?id=180756
<rdar://problem/35996158>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests.

  • platform/mac/EventLoopMac.mm:

(WebCore::EventLoop::cycle):

Source/WebKit:

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::AccessibilityProcessSuspendedNotification):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::shouldLeakBoost):

  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeProcess):

12:01 PM Changeset in webkit [225862] by graouts@webkit.org
  • 8 edits in trunk

[Web Animations] Implement the "updating the finished state" procedure
https://bugs.webkit.org/show_bug.cgi?id=180743
<rdar://problem/36017232>

Reviewed by Simon Fraser.

Source/WebCore:

The Web Animations spec defines a procedure for "updating the finished state", which should run as the timeline time
changes and is responsible for ultimately triggering finish events and fulfil the "finished" promise. The procedure
allows for two flags to control its behavior: didSeek and synchronouslyNotify. When synchronouslyNotify is true, the
"finish notification steps" procedure is ran right away, otherwise it's queued as a microtask.

In this patch we introduce the notion of "hold time", which is the time held while an animation is paused. It will be
set by the pause() and play() method in future patches.

  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::updateAnimations): Update the finished state as the timeline time changes with both flags
set to false.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::currentTime const): Add a private currentTime(bool) variant which allows for the hold time to
be ignored in case updateFinishedState() was called with the didSeek flag set to false.
(WebCore::WebAnimation::updateFinishedState): Implement the procedure as specified with all spec-mandated steps inline.
(WebCore::WebAnimation::scheduleMicrotaskIfNeeded): Schedule a microtask to complete the "finish notification steps"
if we haven't scheduled a microtask before.
(WebCore::WebAnimation::performMicrotask): Perform the microtask if the "finish notification steps" procedure hasn't
been canceled after it was originally scheduled, as tracked by the m_finishNotificationStepsMicrotaskPending flag, since
microtasks are not presently cancelable.
(WebCore::WebAnimation::finishNotificationSteps): Implement the procedure as specified with all spec-mandated steps inline,
dispatching a "finish" events and fulfilling the "finished" promise.

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:
  • dom/EventNames.h:

LayoutTests:

Rebase some WPT expectations with minor progressions due to exposing the "onfinish" property.

  • http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt:
11:38 AM Changeset in webkit [225861] by msaboff@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Unreviewed rollout of r225695. Caused a crash on yahoo login page.

That bug tracked in https://bugs.webkit.org/show_bug.cgi?id=180761.

11:31 AM Changeset in webkit [225860] by jmarcell@apple.com
  • 11 edits in tags/Safari-605.1.18/Source/JavaScriptCore

Revert r225695. rdar://problem/35914716

11:26 AM Changeset in webkit [225859] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix crash under Document::visualUpdatesSuppressionTimerFired()
https://bugs.webkit.org/show_bug.cgi?id=180758
Document::visualUpdatesSuppressionTimerFired

Reviewed by Zalan Bujtas.

Speculative fix for crash under visualUpdatesSuppressionTimerFired() where view()
can be null. Add null checks for the view() in all code called from this function.

  • dom/Document.cpp:

(WebCore::Document::setVisualUpdatesAllowed):
(WebCore::Document::visualUpdatesSuppressionTimerFired):

11:24 AM Changeset in webkit [225858] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[iOS] Further Trim WebContent Process sandbox
https://bugs.webkit.org/show_bug.cgi?id=180727
<rdar://problem/18899506>

Reviewed by Eric Carlson.

Take another pass over the contents of the file and remove addition items that
don't have call sites in WebKit.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
11:22 AM Changeset in webkit [225857] by mark.lam@apple.com
  • 8 edits
    2 adds in trunk

Fill out some Poisoned APIs, fix some bugs, and add some tests.
https://bugs.webkit.org/show_bug.cgi?id=180724
<rdar://problem/36006884>

Reviewed by JF Bastien.

Source/JavaScriptCore:

  • runtime/StructureTransitionTable.h:

Source/WTF:

Also rename Int32Poisoned to ConstExprPoisoned. The key it takes is actually a
uint32_t. So, Int32 is really a misnomer. In addition, the key needs to be a
constexpr. So, ConstExprPoisoned is a better name for it.

  • wtf/Poisoned.cpp:

(WTF::makePoison):

  • wtf/Poisoned.h:

(WTF::PoisonedImplHelper::asReference):
(WTF::PoisonedImpl::PoisonedImpl):
(WTF::PoisonedImpl::clear):
(WTF::PoisonedImpl::operator* const):
(WTF::PoisonedImpl::operator-> const):
(WTF::PoisonedImpl::operator== const):
(WTF::PoisonedImpl::operator!= const):
(WTF::PoisonedImpl::operator< const):
(WTF::PoisonedImpl::operator<= const):
(WTF::PoisonedImpl::operator> const):
(WTF::PoisonedImpl::operator>= const):
(WTF::PoisonedImpl::operator=):
(WTF::PoisonedImpl::swap):
(WTF::PoisonedImpl::exchange):
(WTF::swap):
(WTF::makePoison):
(WTF::PoisonedImpl::operator==): Deleted.

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Added.

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/Poisoned.cpp: Added.

(TestWebKitAPI::initializeTestPoison):
(TestWebKitAPI::TEST):

11:04 AM Changeset in webkit [225856] by Jonathan Bedard
  • 29 edits in trunk/Tools

webkitpy: Better name-version mapping (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=179621
<rdar://problem/35589585>

Reviewed by David Kilzer.

Now that we have a central mapping of version numbers to version names, this
mapping should be used to compute version names. This patch treats passes versions
as objects, only mapping them to names when strings are needed.

  • Scripts/webkitpy/common/system/platforminfo.py:

(PlatformInfo.init): Store os_version as a version object instead of a string.
(PlatformInfo.os_version_name): Convert os_version to a string through the VersionNameMap.

  • Scripts/webkitpy/common/system/platforminfo_mock.py:

(MockPlatformInfo.init): Store os_version as a version object.
(MockPlatformInfo.os_version_name): Mirror PlatformInfo.

  • Scripts/webkitpy/common/system/platforminfo_unittest.py:

(TestPlatformInfo.test_real_code): Only Mac and Windows have defined version objects.
(TestPlatformInfo.test_os_version): Deleted, this behavior is now managed by VersionNameMap.

  • Scripts/webkitpy/common/version.py:

(Version.cmp): Allow a version object to be compared with 'None'.

  • Scripts/webkitpy/common/version_name_map.py:

(VersionNameMap.map): Check for the apple_additions VersionNameMap.
(VersionNameMap.init): Add a wincairo mapping, the same as the win mapping.

  • Scripts/webkitpy/common/version_unittest.py:

(VersionTestCase.test_compare_versions): Test comparing a version object to 'None'.

  • Scripts/webkitpy/layout_tests/models/test_configuration.py:

(TestConfiguration.init): Strip formatting from version name. Note that this object still
accepts a string because the version string implicitly contains the platform as well.

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Win7 should be 7SP0 as

it is in the VersionNameMap.

  • Scripts/webkitpy/port/apple.py:

(ApplePort): Replace VERSION_FALLBACK_ORDER with a minimum and maximum version. This is required
because it may be the case that scripts are aware of more versions than the port actually supports.
(ApplePort.determine_full_port_name): Use the host operating system to compute the full port name.
(ApplePort._allowed_versions): Return a list of valid port versions by iterating through the
VersionNameMap.
(ApplePort._generate_all_test_configurations): Compute a list of configurations by iterating through
_allowed_versions and converting each version to a string.
(ApplePort._apple_baseline_path): Return a layout test expectation directory inside apple_additions.
(ApplePort._skipped_file_search_paths): Deleted.
(ApplePort._allowed_port_names): Deleted.
(ApplePort._future_port_name): Deleted.

  • Scripts/webkitpy/port/base.py:

(Port.init): Replace _version string with _os_version object.
(Port.version_name): Convert version object to string.
(Port.test_configuration): Pass version string to TestConfiguration.
(Port.version): Deleted.

  • Scripts/webkitpy/port/darwin_testcase.py:

(DarwinTest.assert_name): Convert an os_version_string to a version object and construct a port.

  • Scripts/webkitpy/port/factory_unittest.py:

(FactoryTest.test_mac): Replace version strings with version objects.
(FactoryTest.test_win): Ditto.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort._generate_all_test_configurations): Replace _version with version_name().

  • Scripts/webkitpy/port/ios.py:

(IOSPort.version_name): Both Simulator and device share the same version-name convention.
(IOSPort._generate_all_test_configurations): Replace _version with version_name().
(IOSPort.default_baseline_search_path): Use the internal mapping of version names to construct
apple_additions expectations.
(IOSPort._apple_additions_path): Deleted.

  • Scripts/webkitpy/port/ios_device.py:

(IOSDevicePort.ios_version): Return None if no version is defined.

  • Scripts/webkitpy/port/ios_device_unittest.py:

(IOSDeviceTest):
(IOSDeviceTest.test_layout_test_searchpath_with_apple_additions): Conform with the new mock
apple_additions.
(IOSDeviceTest.make_port): Deleted.

  • Scripts/webkitpy/port/ios_simulator.py:

(IOSSimulatorPort._create_devices): Use Version object over list of version strings.

  • Scripts/webkitpy/port/ios_simulator_unittest.py:

(IOSSimulatorTest):
(IOSSimulatorTest.make_port): Use iOS 11 as the default version for testing.
(IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions): Conform with the new
mock apple_additions.

  • Scripts/webkitpy/port/ios_testcase.py:

(IOSTest.make_port): Use iOS 11 as the default version for testing.

  • Scripts/webkitpy/port/mac.py:

(MacPort):
(MacPort.init): Use Version object for _os_version.
(MacPort.default_baseline_search_path): Use the internal mapping of version names to construct
apple_additions expectations.
(MacPort.configuration_specifier_macros): Automatically construct macros based on VersionNameMap.
(MacPort._apple_additions_path): Deleted.

  • Scripts/webkitpy/port/mac_unittest.py:

(MacTest): Use Version object instead of version string.
(MacTest.test_version):

  • Scripts/webkitpy/port/port_testcase.py:

(bind_mock_apple_additions): Add a mock VersionNameMap to mock apple_additions.
(bind_mock_apple_additions.MockAppleAdditions):
(bind_mock_apple_additions.MockAppleAdditions.version_name_mapping):

  • Scripts/webkitpy/port/test.py:

(TestPort):
(TestPort.init): Use VersionNameMap to compute the correct Version from a port name.
(TestPort.version_name): Mirror Port object.
(TestPort.baseline_search_path): Replace win7 with 7sp0.
(TestPort._all_systems): Ditto.
(TestPort.configuration_specifier_macros): Ditto.

  • Scripts/webkitpy/port/win.py:

(WinPort):
(WinPort.init): Construct Version object from port name.
(WinPort.default_baseline_search_path): Use the internal mapping of version names to construct
apple_additions expectations.
(WinCairoPort):
(WinCairoPort.default_baseline_search_path): Use MIN/MAX instead of the VERSION_FALLBACK_ORDER.
(WinCairoPort._future_port_name): Deleted.

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_baseline_search_path): Add new Windows versions not previously included.
(WinPortTest._assert_version): Handle expected_version as a Version object.
(WinPortTest.test_versions): Pass Version objects instead of version strings.

  • Scripts/webkitpy/port/wpe.py:

(WPEPort._generate_all_test_configurations): Replace _version with version_name().

  • Scripts/webkitpy/tool/commands/queries_unittest.py:

(PrintExpectationsTest.test_multiple): Replace win7 with 7sp0.
(PrintBaselinesTest.test_multiple): Ditto.

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._new_port_name_from_old): Use os_version_name() instead of Version object.

10:43 AM Changeset in webkit [225855] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

ASSERT(LayoutDisallowedScope::isLayoutAllowed()) whenever hitting Enter in Web Inspector console
https://bugs.webkit.org/show_bug.cgi?id=180690

Reviewed by Simon Fraser.

Defer text replacement notification until after layout is done to avoid unexpected forced layouts.

Covered by existing tests.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::disableAccessibility):
(WebCore::AXObjectCache::remove):
(WebCore::filterMapForRemoval):
(WebCore::filterListForRemoval):
(WebCore::AXObjectCache::prepareForDocumentDestruction):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferTextReplacementNotificationForTextControl):
(WebCore::filterForRemoval): Deleted.

  • accessibility/AXObjectCache.h: Need to use the base (Element) class since

we can't call is<HTMLTextFormControlElement> in Node d'tor.
(WebCore::AXObjectCache::deferTextReplacementNotificationForTextControl):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setInnerTextValue):

10:36 AM Changeset in webkit [225854] by Ryan Haddad
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r225836.

Broke the Windows build.

Reverted changeset:

"Unify some WebGL sources"
https://bugs.webkit.org/show_bug.cgi?id=180726
https://trac.webkit.org/changeset/225836

10:35 AM Changeset in webkit [225853] by dbates@webkit.org
  • 4 edits in trunk/Source/WebKit

Move out-parameter in API::FormClient::willBeginInputSession() to the end of the parameter list
https://bugs.webkit.org/show_bug.cgi?id=180754

Reviewed by Wenson Hsieh.

Group all in-parameters in the signature of API::FormClient::willBeginInputSession() at
the front of the parameter list instead of interspersing in- and out- parameters.

No functionality changed. So, no new tests.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController _setFormDelegate:]):

  • WebProcess/InjectedBundle/APIInjectedBundleFormClient.h:

(API::InjectedBundle::FormClient::willBeginInputSession):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::elementDidFocus):

10:26 AM Changeset in webkit [225852] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Updated Expectations for http/tests/cache/disk-cache/disk-cache-204-status-code.html
https://bugs.webkit.org/show_bug.cgi?id=162685

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:20 AM Changeset in webkit [225851] by Caio Lima
  • 3 edits in trunk/Source/JavaScriptCore

[ESNext][BigInt] Breking tests on Debug build and 32-bits due to missing Exception check
https://bugs.webkit.org/show_bug.cgi?id=180746

Reviewed by Saam Barati.

We have some uncatched exceptions that could happen due to OOM into
JSBigInt::allocateFor and JSBigInt::toStringGeneric. This patching is
catching such exceptions properly.

  • runtime/JSBigInt.cpp:

(JSC::JSBigInt::allocateFor):
(JSC::JSBigInt::parseInt):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toStringSlowCase const):

10:13 AM Changeset in webkit [225850] by Chris Dumez
  • 5 edits in trunk/Source/WebKit

[iOS] Take process assertion to prevent the service worker process from getting suspended
https://bugs.webkit.org/show_bug.cgi?id=180735

Reviewed by Brady Eidson.

Take process assertion to prevent the service worker process from getting suspended while
it is still needed. We use the same policy as for the network process, meaning that
unsuspended WebContent processes prevent the service worker process from getting suspended.

This patch still does not enable service workers on iOS. The demo at https://mdn.github.io/sw-test/
appears to work. However, things are not working as expected for mobile.twitter.com where I
see the fetches intercepted by the service worker fail when offline for some reason (unrelated
to process suspension).

  • UIProcess/WebProcessPool.cpp:

(WebKit::m_foregroundWebProcessCounter):
(WebKit::m_backgroundWebProcessCounter):
(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::establishWorkerContextConnectionToStorageProcess):
(WebKit::WebProcessPool::disconnectProcess):
(WebKit::WebProcessPool::updateProcessAssertions):
(WebKit::WebProcessPool::reinstateNetworkProcessAssertionState):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didSetAssertionState):

  • UIProcess/WebProcessProxy.h:
10:02 AM Changeset in webkit [225849] by aestes@apple.com
  • 17 edits
    3 copies
    1 move
    2 adds
    4 deletes in trunk

[Payment Request] Remove ApplePayPaymentMethodUpdateEvent and use PaymentDetailsModifiers instead
https://bugs.webkit.org/show_bug.cgi?id=180737
<rdar://problem/36013152>

Reviewed by Brady Eidson.

Source/WebCore:

Instead of firing a non-standard "applepaypaymentmethodupdate" event when the payment method
changes, use the PaymentDetailsModifier mechanism to allow the merchant to specify override
totals and additional display items per payment method type.

Test: http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html

  • DerivedSources.make:
  • Modules/applepay/ApplePayLineItem.idl:
  • Modules/applepay/ApplePayPaymentMethod.h:
  • Modules/applepay/ApplePayPaymentMethod.idl:
  • Modules/applepay/ApplePayPaymentMethodType.h: Added.
  • Modules/applepay/ApplePayPaymentMethodType.idl: Added.
  • Modules/applepay/cocoa/PaymentMethodCocoa.mm:
  • Modules/applepay/paymentrequest/ApplePayModifier.h: Added.
  • Modules/applepay/paymentrequest/ApplePayModifier.idl: Added.
  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::show):
(WebCore::ApplePayPaymentHandler::computeTotalAndLineItems):
(WebCore::ApplePayPaymentHandler::detailsUpdated):
(WebCore::ApplePayPaymentHandler::shippingAddressUpdated):
(WebCore::ApplePayPaymentHandler::shippingOptionUpdated):
(WebCore::ApplePayPaymentHandler::paymentMethodUpdated):
(WebCore::ApplePayPaymentHandler::didSelectPaymentMethod):

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
  • Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp: Removed.
  • Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.h: Removed.
  • Modules/paymentrequest/PaymentRequest.h:
  • Modules/paymentrequest/PaymentRequest.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:
  • dom/EventNames.in:
  • testing/MockPaymentCoordinator.cpp:

(WebCore::convert):
(WebCore::MockPaymentCoordinator::updateTotalAndLineItems):
(WebCore::MockPaymentCoordinator::completeShippingMethodSelection):
(WebCore::MockPaymentCoordinator::completeShippingContactSelection):
(WebCore::MockPaymentCoordinator::completePaymentMethodSelection):

  • testing/MockPaymentCoordinator.h:
  • testing/MockPaymentCoordinator.idl:

LayoutTests:

  • http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https-expected.txt: Added.
  • http/tests/ssl/applepay/ApplePayPaymentDetailsModifier.https.html: Added.
  • http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https-expected.txt: Removed.
  • http/tests/ssl/applepay/ApplePayPaymentMethodUpdateEvent.https.html: Removed.
9:57 AM Changeset in webkit [225848] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Added missing expectation file for fast/text/user-installed-fonts/shadow-postscript-family.html
https://bugs.webkit.org/show_bug.cgi?id=180062

Unreviewed test gardening.

  • platform/ios/TestExpectations:
9:37 AM Changeset in webkit [225847] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.18

Tag Safari-605.1.18.

9:29 AM Changeset in webkit [225846] by Ms2ger@igalia.com
  • 5 edits
    8 adds in trunk/LayoutTests

[GTK][WPE] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=180751

Unreviewed test gardening.

  • platform/gtk/TestExpectations:
  • platform/gtk/http/tests/inspector/network/fetch-response-body-expected.txt:
  • platform/gtk/http/tests/inspector/network/xhr-response-body-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte-expected.txt: Added.
  • platform/wpe/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-drawImage-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/encoding/textdecoder-fatal-single-byte-expected.txt: Added.
9:29 AM Changeset in webkit [225845] by sbarati@apple.com
  • 3 edits
    1 add in trunk

Fix how JSFunction handles "caller" and "arguments" for functions that don't have those properties
https://bugs.webkit.org/show_bug.cgi?id=163579
<rdar://problem/35455798>

Reviewed by Mark Lam.

JSTests:

  • stress/caller-and-arguments-properties-for-functions-that-dont-have-them.js: Added.

(assert):
(test1):
(i.test1):
(i.test1.C):
(i.test1.async.foo):
(i.test1.foo):
(test2):

Source/JavaScriptCore:

Some functions in JavaScript do not have the "caller" and "arguments" properties.
For example, strict functions do not. When reading our code that dealt with these
types of functions, it was simply all wrong. We were doing weird things depending
on the method table hook. This patch fixes this by doing what we should've been
doing all along: when the JSFunction does not own the "caller"/"arguments" property,
it should defer to its base class implementation for the various method table hooks.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):

9:19 AM Changeset in webkit [225844] by sbarati@apple.com
  • 3 edits
    1 add in trunk

TypeCheckHoistingPhase needs to emit a CheckStructureOrEmpty if it's doing it for |this|
https://bugs.webkit.org/show_bug.cgi?id=180734
<rdar://problem/35640547>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/type-check-hoisting-phase-hoist-check-structure-on-tdz-this-value.js: Added.

(isPropertyOfType):
(
getProperties):
(getObjects):
(
getRandomObject):
(theClass.):
(theClass):
(childClass):
(counter.catch):

Source/JavaScriptCore:

The |this| value may be TDZ. If type check hoisting phase
hoists a CheckStructure to it, it will crash. This patch
makes it so we emit CheckStructureOrEmpty for |this|.

  • dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

9:10 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
(diff)
6:51 AM WebKitGTK/Releasing edited by Claudio Saavedra
Update location of the make-dist script. (diff)
4:39 AM Changeset in webkit [225843] by Konstantin Tokarev
  • 1 edit in trunk/LayoutTests/ChangeLog

Unreviewed, rolling out r179000.

There are tests failing in 32-bits and Debug builds

Reverted changeset:

https://trac.webkit.org/changeset/179000

4:09 AM Changeset in webkit [225842] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.19.3

WebKitGTK+ 2.19.3

4:08 AM Changeset in webkit [225841] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.19.3 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.19.3.

Dec 12, 2017:

11:51 PM Changeset in webkit [225840] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Optimize Object.assign by single transition acceleration
https://bugs.webkit.org/show_bug.cgi?id=180644

Reviewed by Saam Barati.

Handling single transition is critical. Since this get() function is only used
in Structure.cpp's 2 functions and it is quite small, we can annotate inline
to accelerate it.

This improves SixSpeed/object-assign.es6 by 2.8%.

baseline patched

object-assign.es6 382.3548+-8.0461 371.6496+-5.7439 might be 1.0288x faster

  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::get const):

10:19 PM Changeset in webkit [225839] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: navigating away from empty value should remove CSS property
https://bugs.webkit.org/show_bug.cgi?id=180508

Reviewed by Devin Rousso.

Remove a property when navigating away from it (e.g. to the next/previous property,
or outside of the styles panel entirely) and either its name or value is empty:

color: [ ]->
<-[ ]: red
<-[color]:

Don't remove a property when navigating from an empty value to a non-empty name:

color: <-[ ]

Always remove a property when both name and value are empty.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._handleBlur):
(WI.SpreadsheetTextField.prototype.get valueBeforeEditing): Deleted.

8:47 PM Changeset in webkit [225838] by Chris Dumez
  • 3 edits in trunk/LayoutTests/imported/w3c

Re-sync imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html
https://bugs.webkit.org/show_bug.cgi?id=180698

Reviewed by Alex Christensen.

Re-sync imported/w3c/web-platform-tests/service-workers/service-worker/interfaces-sw.https.html
after https://github.com/w3c/web-platform-tests/pull/8622.

  • web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/resources/interfaces-worker.sub.js:
8:05 PM Changeset in webkit [225837] by Alan Bujtas
  • 13 edits in trunk/Source/WebCore

is<HTMLTextFormControlElement> reports the input type.
https://bugs.webkit.org/show_bug.cgi?id=180721
<rdar://problem/36005123>

Reviewed by Ryosuke Niwa.

This patch ensures that is<HTMLTextFormControlElement> consistently returns true even
when the input type changes from text to non-text (checkbox etc).

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::selectText):

  • dom/Element.h:

(WebCore::Element::isTextFormControlElement const):
(WebCore::Element::isTextField const):
(WebCore::Element::isTextFormControl const): Deleted.

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • html/FormController.cpp:

(WebCore::FormController::formElementsCharacterCount const):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::directionality const):

  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):
(WebCore::HTMLTextFormControlElement::selectedText const):
(WebCore::HTMLTextFormControlElement::setSelectionRange):
(WebCore::HTMLTextFormControlElement::selectionStart const):
(WebCore::HTMLTextFormControlElement::computeSelectionStart const):
(WebCore::HTMLTextFormControlElement::selectionEnd const):
(WebCore::HTMLTextFormControlElement::computeSelectionEnd const):
(WebCore::HTMLTextFormControlElement::selectionDirection const):
(WebCore::HTMLTextFormControlElement::computeSelectionDirection const):
(WebCore::HTMLTextFormControlElement::selection const):
(WebCore::HTMLTextFormControlElement::selectionChanged):
(WebCore::HTMLTextFormControlElement::lastChangeWasUserEdit const):
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
(WebCore::HTMLTextFormControlElement::valueWithHardLineBreaks const):
(WebCore::enclosingTextFormControl):

  • html/HTMLTextFormControlElement.h:

(isType):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::isOverTextInsideFormControlElement const):

7:51 PM Changeset in webkit [225836] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Unify some WebGL sources
https://bugs.webkit.org/show_bug.cgi?id=180726

Rubber-stamped by Keith, weeks ago.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLRenderingContextBase.cpp:
7:26 PM Changeset in webkit [225835] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Structure, StructureRareData, and PropertyTable should be in IsoSubspaces
https://bugs.webkit.org/show_bug.cgi?id=180732

Rubber stamped by Mark Lam.

We should eventually move all fixed-size cells into IsoSubspaces. I don't know if they are
scalable enough to support that, so we should do it carefully.

  • heap/MarkedSpace.cpp:
  • runtime/PropertyMapHashTable.h:
  • runtime/Structure.h:
  • runtime/StructureRareData.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
7:04 PM Changeset in webkit [225834] by sbarati@apple.com
  • 4 edits
    1 add in trunk

We need to model effects of Spread(@PhantomCreateRest) in Clobberize/PreciseLocalClobberize
https://bugs.webkit.org/show_bug.cgi?id=180725
<rdar://problem/35970511>

Reviewed by Michael Saboff.

JSTests:

  • stress/model-effects-properly-of-spread-over-phantom-create-rest.js: Added.

(f1):
(f2):
(let.o2.valueOf):

Source/JavaScriptCore:

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

6:52 PM Changeset in webkit [225833] by dbates@webkit.org
  • 6 edits
    1 copy in trunk

[WK] Add modern WebKit SPI to set auto fill button type and query if the auto fill button is enabled
https://bugs.webkit.org/show_bug.cgi?id=180686

Reviewed by Alex Christensen.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(-[WKWebProcessPlugInNodeHandle isHTMLInputElementAutoFillButtonEnabled]):
(toAutoFillButtonType):
(-[WKWebProcessPlugInNodeHandle setHTMLInputElementAutoFillButtonEnabledWithButtonType:]):

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandleInternal.h:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ClickAutoFillButton.mm:

(-[ClickAutoFillButton webProcessPlugIn:didCreateBrowserContextController:]):

6:49 PM Changeset in webkit [225832] by Yusuke Suzuki
  • 42 edits
    1 copy
    12 adds
    2 deletes in trunk

[JSC] Implement optimized WeakMap and WeakSet
https://bugs.webkit.org/show_bug.cgi?id=179929

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/weak-map-key.js:
  • microbenchmarks/weak-set-key.js: Copied from JSTests/microbenchmarks/weak-map-key.js.

(assert):
(objectKey):
(let.start.Date.now):

  • stress/basic-weakmap.js: Added.

(shouldBe):
(test):

  • stress/basic-weakset.js: Added.

(shouldBe):
(test.set new):

  • stress/weakmap-cse-set-break.js: Added.

(shouldBe):
(test):

  • stress/weakmap-cse.js: Added.

(shouldBe):
(test):

  • stress/weakmap-gc.js: Added.

(test):

  • stress/weakset-cse-add-break.js: Added.

(shouldBe):
(test.set new):

  • stress/weakset-cse.js: Added.

(shouldBe):
(test.set new):

  • stress/weakset-gc.js: Added.

(test.set add):
(test.set new):
(test):

Source/JavaScriptCore:

This patch introduces WeakMapImpl to optimize WeakMap and WeakSet.
This is similar to HashMapImpl. But,

  1. WeakMapImpl's bucket is not allocated in GC heap since WeakMap

do not need to have iterators.

  1. WeakMapImpl's buffer is allocated in JSValue Gigacage instead

of auxiliary buffer. This is because we would like to allocate buffer
when finalizing GC. At that time, WeakMapImpl prunes dead entries and
shrink it if necessary. However, allocating from the GC heap during
finalization is not allowed.

In particular, (2) is important since it ensures any WeakMap operations
do not cause GC. Since GC may collect dead keys in WeakMap, rehash WeakMap,
and reallocate/change WeakMap's buffer, ensuring that any WeakMap operations
do not cause GC makes our implementation simple. To ensure this, we place
DisallowGC for each WeakMap's interface.

In DFG, we introduce WeakMapGet and ExtractValueFromWeakMapGet nodes.
WeakMapGet looks up entry in WeakMapImpl and returns value. If it is
WeakMap, it returns value. And it returns key if it is WeakSet. If it
does not find a corresponding entry, it returns JSEmpty.
ExtractValueFromWeakMapGet converts JSEmpty to JSUndefined.

This patch improves WeakMap and WeakSet operations.

baseline patched

weak-set-key 240.6932+-10.4923 148.7606+-6.1784 definitely 1.6180x faster
weak-map-key 174.3176+-8.2680 151.7053+-6.8723 definitely 1.1491x faster

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • dfg/DFGAbstractHeap.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileExtractValueFromWeakMapGet):
(JSC::DFG::SpeculativeJIT::compileWeakMapGet):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileExtractValueFromWeakMapGet):
(JSC::FTL::DFG::LowerDFGToB3::compileWeakMapGet):

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::weakSetEntries):
Existing code is incorrect. They can run GC and break WeakMap's iterator.
We introduce takeSnapshot function to WeakMapImpl, which retrieves live
entries without causing any GC.

  • runtime/HashMapImpl.h:

(JSC::shouldShrink):
(JSC::shouldRehashAfterAdd):
(JSC::nextCapacity):
(JSC::HashMapImpl::shouldRehashAfterAdd const):
(JSC::HashMapImpl::shouldShrink const):
(JSC::HashMapImpl::rehash):
(JSC::WeakMapHash::hash): Deleted.
(JSC::WeakMapHash::equal): Deleted.

  • runtime/Intrinsic.cpp:

(JSC::intrinsicName):

  • runtime/Intrinsic.h:
  • runtime/JSWeakMap.cpp:
  • runtime/JSWeakMap.h:
  • runtime/JSWeakSet.cpp:
  • runtime/JSWeakSet.h:
  • runtime/VM.cpp:
  • runtime/WeakGCMap.h:

(JSC::WeakGCMap::forEach): Deleted.

  • runtime/WeakMapBase.cpp: Removed.
  • runtime/WeakMapBase.h: Removed.
  • runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

  • runtime/WeakMapImpl.cpp: Added.

(JSC::WeakMapImpl<WeakMapBucket>::destroy):
(JSC::WeakMapImpl<WeakMapBucket>::visitChildren):
(JSC::WeakMapImpl<WeakMapBucket>::estimatedSize):
(JSC::WeakMapImpl<WeakMapBucket<WeakMapBucketDataKey>>::visitWeakReferences):
(JSC::WeakMapImpl<WeakMapBucket<WeakMapBucketDataKeyValue>>::visitWeakReferences):
(JSC::WeakMapImpl<WeakMapBucket>::finalizeUnconditionally):
(JSC::WeakMapImpl<WeakMapBucket<WeakMapBucketDataKey>>::takeSnapshot):
(JSC::WeakMapImpl<WeakMapBucket<WeakMapBucketDataKeyValue>>::takeSnapshot):

  • runtime/WeakMapImpl.h: Added.

(JSC::jsWeakMapHash):
(JSC::nextCapacityAfterRemoveBatching):
(JSC::WeakMapBucket::setKey):
(JSC::WeakMapBucket::setValue):
(JSC::WeakMapBucket::key const):
(JSC::WeakMapBucket::value const):
(JSC::WeakMapBucket::copyFrom):
(JSC::WeakMapBucket::offsetOfKey):
(JSC::WeakMapBucket::offsetOfValue):
(JSC::WeakMapBucket::extractValue):
(JSC::WeakMapBucket::isEmpty):
(JSC::WeakMapBucket::deletedKey):
(JSC::WeakMapBucket::isDeleted):
(JSC::WeakMapBucket::makeDeleted):
(JSC::WeakMapBucket::visitAggregate):
(JSC::WeakMapBucket::clearValue):
(JSC::WeakMapBuffer::allocationSize):
(JSC::WeakMapBuffer::buffer const):
(JSC::WeakMapBuffer::create):
(JSC::WeakMapBuffer::reset):
(JSC::WeakMapImpl::WeakMapImpl):
(JSC::WeakMapImpl::finishCreation):
(JSC::WeakMapImpl::get):
(JSC::WeakMapImpl::has):
(JSC::WeakMapImpl::add):
(JSC::WeakMapImpl::remove):
(JSC::WeakMapImpl::size const):
(JSC::WeakMapImpl::offsetOfBuffer):
(JSC::WeakMapImpl::offsetOfCapacity):
(JSC::WeakMapImpl::findBucket):
(JSC::WeakMapImpl::buffer const):
(JSC::WeakMapImpl::forEach):
(JSC::WeakMapImpl::shouldRehashAfterAdd const):
(JSC::WeakMapImpl::shouldShrink const):
(JSC::WeakMapImpl::canUseBucket):
(JSC::WeakMapImpl::addInternal):
(JSC::WeakMapImpl::findBucketAlreadyHashed):
(JSC::WeakMapImpl::rehash):
(JSC::WeakMapImpl::checkConsistency const):
(JSC::WeakMapImpl::makeAndSetNewBuffer):
(JSC::WeakMapImpl::assertBufferIsEmpty const):
(JSC::WeakMapImpl::DeadKeyCleaner::target):

  • runtime/WeakMapPrototype.cpp:

(JSC::WeakMapPrototype::finishCreation):
(JSC::protoFuncWeakMapGet):
(JSC::protoFuncWeakMapHas):

  • runtime/WeakSetConstructor.cpp:

(JSC::constructWeakSet):

  • runtime/WeakSetPrototype.cpp:

(JSC::WeakSetPrototype::finishCreation):
(JSC::protoFuncWeakSetHas):
(JSC::protoFuncWeakSetAdd):

Source/WTF:

We introduce JSValueMalloc, which is specialized malloc scheme with Gigacage::JSValue.
This is used for WeakMapImpl's buffer.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/JSValueMalloc.cpp: Added.

(WTF::tryJSValueMalloc):
(WTF::jsValueMalloc):
(WTF::jsValueRealloc):
(WTF::jsValueFree):

  • wtf/JSValueMalloc.h: Added.

(WTF::JSValueMalloc::malloc):
(WTF::JSValueMalloc::tryMalloc):
(WTF::JSValueMalloc::realloc):
(WTF::JSValueMalloc::free):

  • wtf/MallocPtr.h:

(WTF::MallocPtr::~MallocPtr):
(WTF::MallocPtr::malloc):
(WTF::MallocPtr::tryMalloc):
(WTF::MallocPtr::realloc):
We extend MallocPtr to adopt malloc scheme as its template parameter.

6:35 PM Changeset in webkit [225831] by fpizlo@apple.com
  • 27 edits
    7 adds in trunk/Source

It should be possible to flag a cell for unconditional finalization
https://bugs.webkit.org/show_bug.cgi?id=180636

Reviewed by Saam Barati.

Source/JavaScriptCore:

UnconditionalFinalizers were annoying - you had to allocate them and you had to manage a
global linked list - but they had some nice properties:

  • You only did the hardest work (creating the UnconditionalFinalizer) on first GC where you survived and needed it.

-> Just needing it wasn't enough.
-> Just surviving wasn't enough.


The new API based on IsoSubspaces meant that just surviving was enough to cause unconditional
finalizer logic to be invoked. I think that's not great. InferredType got around this by
making InferredStructure a cell, but this was a gross hack. For one, it meant that
InferredStructure would survive during the GC in which its finalizer obviated the need for its
existence. It's not really an idiom I want us to repeat because it sounds like the sort of
thing that turns out to be subtly broken.

We really need to have a way of indicating when you have entered into the state that requires
your unconditional finalizer to be invoked. Basically, we want to be able to track the set of
objects that need unconditional finalizers. Only the subset of that set that overlaps with the
set of marked objects needs to be accurate. The easiest way to do this is a hierarchy of
bitvectors: one to say which MarkedBlocks have objects that have unconditional finalizers, and
another level to say which atoms within a MarkedBlock have unconditional finalizers.

This change introduces IsoCellSet, which couples itself to the MarkedAllocator of some
IsoSubspace to allow maintaining a set of objects (well, cells - you could do this with
auxiliaries) that belong to that IsoSubspace. It'll have undefined behavior if you try to
add/remove/contains an object that isn't in that IsoSubspace. For objects in that subspace,
you can add/remove/contains and forEachMarkedCell. The cost of each IsoCellSet is at worst
about 0.8% increase in size to every object in the subspace that the set is attached to. So,
it makes sense to have a handful per subspace max. This change only needs one per subspace,
but you could imagine more if we do this for WeakReferenceHarvester.

To absolutely minimize the possibility that this incurs costs, the add/remove/contains
functions can be used from any thread so long as forEachMarkedCell isn't running. This means
that InferredType only needs to add itself to the set during visitChildren. Thus, it needs to
both survive and need it for the hardest work to take place. The work of adding does involve
a gnarly load chain that ends in a CAS: load block handle from block, load index, load
segment, load bitvector, load bit -> if not set, then CAS. That's five dependent loads!
However, it's perfect for running in parallel since the only write operations are to widely
dispersed cache lines that contain the bits underlying the set.

The best part is how forEachMarkedCell works. That skips blocks that don't have any objects
that need unconditional finalizers, and only touches the memory of marked objects that have
the unconditional finalizer bit set. It will walk those objects in roughly address order. I
previously found that this speeds up walking over a lot of objects when I made similar changes
for DOM GC (calling visitAdditionalChildren via forEachMarkedCell rather than by walking a
HashSet).

This change makes InferredStructure be a malloc object again, but now it's in an IsoHeap.

My expectation for this change is that it's perf-neutral. Long-term, it gives us a path
forward for eliminating UnconditionalFinalizer and WeakReferenceHarvester while using
IsoSubspace in more places.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • heap/AtomIndices.h: Added.

(JSC::AtomIndices::AtomIndices):

  • heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionalFinalizers):

  • heap/Heap.h:
  • heap/IsoCellSet.cpp: Added.

(JSC::IsoCellSet::IsoCellSet):
(JSC::IsoCellSet::~IsoCellSet):
(JSC::IsoCellSet::addSlow):
(JSC::IsoCellSet::didResizeBits):
(JSC::IsoCellSet::didRemoveBlock):
(JSC::IsoCellSet::sweepToFreeList):

  • heap/IsoCellSet.h: Added.
  • heap/IsoCellSetInlines.h: Added.

(JSC::IsoCellSet::add):
(JSC::IsoCellSet::remove):
(JSC::IsoCellSet::contains const):
(JSC::IsoCellSet::forEachMarkedCell):

  • heap/IsoSubspace.cpp:

(JSC::IsoSubspace::didResizeBits):
(JSC::IsoSubspace::didRemoveBlock):
(JSC::IsoSubspace::didBeginSweepingToFreeList):

  • heap/IsoSubspace.h:
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):

  • heap/MarkedAllocator.h:
  • heap/MarkedAllocatorInlines.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::sweep):
(JSC::MarkedBlock::Handle::isEmpty): Deleted.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::marks const):
(JSC::MarkedBlock::Handle::newlyAllocated const):

  • heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::Handle::isAllocated):
(JSC::MarkedBlock::Handle::isEmpty):
(JSC::MarkedBlock::Handle::emptyMode):
(JSC::MarkedBlock::Handle::forEachMarkedCell):

  • heap/Subspace.cpp:

(JSC::Subspace::didResizeBits):
(JSC::Subspace::didRemoveBlock):
(JSC::Subspace::didBeginSweepingToFreeList):

  • heap/Subspace.h:
  • heap/SubspaceInlines.h:

(JSC::Subspace::forEachMarkedCell):

  • runtime/InferredStructure.cpp:

(JSC::InferredStructure::InferredStructure):
(JSC::InferredStructure::create): Deleted.
(JSC::InferredStructure::destroy): Deleted.
(JSC::InferredStructure::createStructure): Deleted.
(JSC::InferredStructure::visitChildren): Deleted.
(JSC::InferredStructure::finalizeUnconditionally): Deleted.
(JSC::InferredStructure::finishCreation): Deleted.

  • runtime/InferredStructure.h:
  • runtime/InferredStructureWatchpoint.cpp:

(JSC::InferredStructureWatchpoint::fireInternal):

  • runtime/InferredType.cpp:

(JSC::InferredType::visitChildren):
(JSC::InferredType::willStoreValueSlow):
(JSC::InferredType::makeTopSlow):
(JSC::InferredType::set):
(JSC::InferredType::removeStructure):
(JSC::InferredType::finalizeUnconditionally):

  • runtime/InferredType.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

This adds ConcurrentVector, which is like SegmentedVector, but wastes some space to allow
resizing to proceed concurrently to access. It's not possible to resize concurrently to
resizing, concurrent read/writes aren't protected from racing if they access the same element,
and who knows what you'll get if you iterate up to size() while someone else append()s. The
key insight is to stash all prior copies of the spine, so that nobody crashes trying to access
a stale spine.

I'm going to want to do the same thing for FastBitVector, by creating a segmented WordOwner
class. That would require repeating the dance of having a spine that can resize while stashing
old versions. So, the spine resizing logic is abstracted behind ConcurrentBuffer. You could
use that as a kind of "concurrent vector" for immutable data. That's how ConcurrentVector uses
it: it's an immutable array of segment pointers.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/ConcurrentBuffer.h: Added.

(WTF::ConcurrentBuffer::ConcurrentBuffer):
(WTF::ConcurrentBuffer::~ConcurrentBuffer):
(WTF::ConcurrentBuffer::growExact):
(WTF::ConcurrentBuffer::grow):
(WTF::ConcurrentBuffer::array const):
(WTF::ConcurrentBuffer::operator[]):
(WTF::ConcurrentBuffer::operator[] const):
(WTF::ConcurrentBuffer::createArray):

  • wtf/ConcurrentVector.h: Added.

(WTF::ConcurrentVectorIterator::~ConcurrentVectorIterator):
(WTF::ConcurrentVectorIterator::operator* const):
(WTF::ConcurrentVectorIterator::operator-> const):
(WTF::ConcurrentVectorIterator::operator++):
(WTF::ConcurrentVectorIterator::operator== const):
(WTF::ConcurrentVectorIterator::operator!= const):
(WTF::ConcurrentVectorIterator::operator=):
(WTF::ConcurrentVectorIterator::ConcurrentVectorIterator):
(WTF::ConcurrentVector::~ConcurrentVector):
(WTF::ConcurrentVector::size const):
(WTF::ConcurrentVector::isEmpty const):
(WTF::ConcurrentVector::at):
(WTF::ConcurrentVector::at const):
(WTF::ConcurrentVector::operator[]):
(WTF::ConcurrentVector::operator[] const):
(WTF::ConcurrentVector::first):
(WTF::ConcurrentVector::first const):
(WTF::ConcurrentVector::last):
(WTF::ConcurrentVector::last const):
(WTF::ConcurrentVector::takeLast):
(WTF::ConcurrentVector::append):
(WTF::ConcurrentVector::alloc):
(WTF::ConcurrentVector::removeLast):
(WTF::ConcurrentVector::grow):
(WTF::ConcurrentVector::begin):
(WTF::ConcurrentVector::end):
(WTF::ConcurrentVector::segmentExistsFor):
(WTF::ConcurrentVector::segmentFor):
(WTF::ConcurrentVector::subscriptFor):
(WTF::ConcurrentVector::ensureSegmentsFor):
(WTF::ConcurrentVector::ensureSegment):
(WTF::ConcurrentVector::allocateSegment):

5:57 PM Changeset in webkit [225830] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix !ENABLE(MEDIA_STREAM) build after r225822
https://bugs.webkit.org/show_bug.cgi?id=180666
<rdar://problem/36008948>

  • html/HTMLMediaElement.cpp:
5:54 PM Changeset in webkit [225829] by achristensen@apple.com
  • 4 edits in trunk

Fix possible out-of-bounds read in protocolIsInHTTPFamily
https://bugs.webkit.org/show_bug.cgi?id=180688

Reviewed by Daniel Bates.

Source/WebCore:

It wouldn't read very far out of bounds, and it would just change a bool return value,
but it's still out of bounds. Covered by an API test that ASAN wouldn't like.

  • platform/URL.cpp:

(WebCore::protocolIsInHTTPFamily):
Check bounds before reading a string.

Tools:

  • TestWebKitAPI/Tests/WebCore/URL.cpp:

(TestWebKitAPI::TEST_F):

5:39 PM Changeset in webkit [225828] by commit-queue@webkit.org
  • 8 edits in trunk

getUserMedia is resolving before the document knows it is capturing
https://bugs.webkit.org/show_bug.cgi?id=180699

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12
Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Ensure the document state is capturing when getUserMedia promise is resolved by doing the following:

  • Promise is resolved when MediaStream is producing data.
  • MediaStream asks Document to update its state when MediaStream state is updated.

Introduce PendingActivationMediaStream for waiting for the MediaStream to produce data.

  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::statusDidChange):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::allow):
(WebCore::UserMediaRequest::contextDestroyed):
(WebCore::UserMediaRequest::PendingActivationMediaStream::PendingActivationMediaStream):
(WebCore::UserMediaRequest::PendingActivationMediaStream::~PendingActivationMediaStream):
(WebCore::UserMediaRequest::PendingActivationMediaStream::characteristicsChanged):
(WebCore::UserMediaRequest::mediaStreamIsReady):

  • Modules/mediastream/UserMediaRequest.h:

(WebCore::UserMediaRequest::PendingActivationMediaStream::create):

  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • WebCore/WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • webrtc/video.html: Adding a check that document is capturing within getUserMedia promise resolution callback.

Adding this check without the changes to WebCore makes the test flaky, sometimes the promise resolution happens
after document state is updated.

5:20 PM Changeset in webkit [225827] by wilander@apple.com
  • 31 edits
    2 copies
    2 moves in trunk

Storage Access API: Implement frame-specific access in the network storage session layer
https://bugs.webkit.org/show_bug.cgi?id=180679
<rdar://problem/35982116>

Reviewed by Alex Christensen.

Source/WebCore:

Tests: http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame.html

http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-but-try-access-from-wrong-frame.html

This changes adds frameID and pageID to what is communicated for
storage access and also stored in the network process' table of
partitioning exceptions.

  • dom/Document.cpp:

(WebCore::Document::hasStorageAccess):

Now makes use of the new m_hasFrameSpecificStorageAccess to check
if access has already been granted to this document's domain and
frame.

(WebCore::Document::requestStorageAccess):

Now submits frameID and pageID in the request call and sets
m_hasFrameSpecificStorageAccess upon granted access callback.

  • dom/Document.h:
  • page/ChromeClient.h:
  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::cookieStoragePartition const):
(WebCore::NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies):
(WebCore::NetworkStorageSession::isStorageAccessGranted const):
(WebCore::NetworkStorageSession::setStorageAccessGranted):

Now makes use of frameID and pageID for partitioning exceptions.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesInPartitionForURL):
(WebCore::setCookiesFromDOM):

Submits std::nullopt for frameID and pageID.
Follow-up work tracked in https://bugs.webkit.org/show_bug.cgi?id=180682.

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::applySniffingPoliciesAndStoragePartitionIfNeeded):

Submits std::nullopt for frameID and pageID.
Follow-up work tracked in https://bugs.webkit.org/show_bug.cgi?id=180682.

Source/WebKit:

This changes adds frameID and pageID to what is communicated for
storage access and also stored in the network process' table of
partitioning exceptions.

  • NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::create):

Now stores frameID and pageID for the task for easy retrieval
in the HSTS checks.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updateStorageAccessForPrevalentDomains):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):

These two methods now submit frameID and pageID to the
partitioning query call.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:_schemeUpgraded:completionHandler:]):

These two methods now submit frameID and pageID to the
partitioning query call.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updateStorageAccessForPrevalentDomains):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestStorageAccess):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::requestStorageAccess):

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updateStorageAccessForPrevalentDomainsHandler):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
(WebKit::WebsiteDataStore::requestStorageAccess):

  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::requestStorageAccess):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::requestStorageAccess):

  • WebProcess/WebPage/WebPage.h:

LayoutTests:

Note that the expected results for
request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame.html
accepts the missing part where document.cookie is still partitioned
after storage access has been granted. Follow-up work tracked in
https://bugs.webkit.org/show_bug.cgi?id=180682.

  • http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame-expected.txt: Added.
  • http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-and-try-access-from-right-frame.html: Added.
  • http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-but-try-access-from-wrong-frame-expected.txt: Copied from LayoutTests/http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-expected.txt.
  • http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-but-try-access-from-wrong-frame.html: Copied from LayoutTests/http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html.
  • http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction-expected.txt: Removed.
  • http/tests/storageAccess/request-and-grant-storage-access-cross-origin-sandboxed-iframe-from-prevalent-domain-with-non-recent-user-interaction.html: Removed.
  • platform/mac-wk2/TestExpectations:
5:18 PM Changeset in webkit [225826] by achristensen@apple.com
  • 10 edits in trunk/Source/WebKit

Modernize WebsiteDataStoreParameters and SandboxExtension::Handle decoding
https://bugs.webkit.org/show_bug.cgi?id=180621

Reviewed by Youenn Fablet.

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/LoadParameters.cpp:

(WebKit::LoadParameters::decode):

  • Shared/SandboxExtension.h:

(WebKit::decode):
(WebKit::SandboxExtension::Handle::decode): Deleted.

  • Shared/Storage/StorageProcessCreationParameters.cpp:

(WebKit::StorageProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::decode):

  • Shared/WebsiteDataStoreParameters.h:
  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::HandleArray):
(WebKit::SandboxExtension::HandleArray::encode const):
(WebKit::SandboxExtension::HandleArray::decode):
(WebKit::SandboxExtension::SandboxExtension):

5:13 PM Changeset in webkit [225825] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

4:50 PM Changeset in webkit [225824] by jfbastien@apple.com
  • 7 edits in trunk

makeString: support more integral types
https://bugs.webkit.org/show_bug.cgi?id=180720

Reviewed by Sam Weinig.

Source/WTF:

Only some integral types worked. Add more types by using template
magic. While we're here, also use the same magic for
floating-point types in the theoretical future where short float
or long double matter.

The core of the magic is a second, defaulted, template
parameter. It's declared in Forward.h (as void), and then in
classes where we want to enable_if we use it (in C++ speak we
create a partial class template specialization), otherwise we
leave it as void.

Also clean up some constructors which were being way too verbose
in stating that they were declarations for this template
specialization right here, when really we already knew that.

  • wtf/Forward.h:
  • wtf/text/StringConcatenate.h:

(WTF::StringTypeAdapter<char>::StringTypeAdapter<char>): Deleted.
(WTF::StringTypeAdapter<char>::length): Deleted.
(WTF::StringTypeAdapter<char>::is8Bit): Deleted.
(WTF::StringTypeAdapter<char>::writeTo const): Deleted.
(WTF::StringTypeAdapter<char>::toString const): Deleted.
(WTF::StringTypeAdapter<UChar>::StringTypeAdapter<UChar>): Deleted.
(WTF::StringTypeAdapter<UChar>::length const): Deleted.
(WTF::StringTypeAdapter<UChar>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<UChar>::writeTo const): Deleted.
(WTF::StringTypeAdapter<UChar>::toString const): Deleted.
(WTF::StringTypeAdapter<char::StringTypeAdapter): Deleted.
(WTF::StringTypeAdapter<ASCIILiteral>::StringTypeAdapter): Deleted.
(WTF::StringTypeAdapter<Vector<char>>::StringTypeAdapter): Deleted.
(WTF::StringTypeAdapter<Vector<char>>::length const): Deleted.
(WTF::StringTypeAdapter<Vector<char>>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<Vector<char>>::writeTo const): Deleted.
(WTF::StringTypeAdapter<Vector<char>>::toString const): Deleted.
(WTF::StringTypeAdapter<String>::StringTypeAdapter<String>): Deleted.
(WTF::StringTypeAdapter<String>::length const): Deleted.
(WTF::StringTypeAdapter<String>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<String>::writeTo const): Deleted.
(WTF::StringTypeAdapter<String>::toString const): Deleted.
(WTF::StringTypeAdapter<AtomicString>::StringTypeAdapter): Deleted.

  • wtf/text/StringConcatenateNumbers.h:

(WTF::StringTypeAdapter<FormattedNumber>::StringTypeAdapter):
(WTF::StringTypeAdapter<int>::StringTypeAdapter<int>): Deleted.
(WTF::StringTypeAdapter<int>::length const): Deleted.
(WTF::StringTypeAdapter<int>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<int>::writeTo const): Deleted.
(WTF::StringTypeAdapter<int>::toString const): Deleted.
(WTF::StringTypeAdapter<unsigned>::StringTypeAdapter<unsigned>): Deleted.
(WTF::StringTypeAdapter<unsigned>::length const): Deleted.
(WTF::StringTypeAdapter<unsigned>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<unsigned>::writeTo const): Deleted.
(WTF::StringTypeAdapter<unsigned>::toString const): Deleted.
(WTF::StringTypeAdapter<double>::StringTypeAdapter<double>): Deleted.
(WTF::StringTypeAdapter<double>::length const): Deleted.
(WTF::StringTypeAdapter<double>::is8Bit const): Deleted.
(WTF::StringTypeAdapter<double>::writeTo const): Deleted.
(WTF::StringTypeAdapter<double>::toString const): Deleted.
(WTF::StringTypeAdapter<float>::StringTypeAdapter<float>): Deleted.
(WTF::StringTypeAdapter<FormattedNumber>::StringTypeAdapter<FormattedNumber>): Deleted.

  • wtf/text/StringView.h:

(WTF::StringTypeAdapter<StringView>::StringTypeAdapter<StringView>): Deleted.
(WTF::StringTypeAdapter<StringView>::length): Deleted.
(WTF::StringTypeAdapter<StringView>::is8Bit): Deleted.
(WTF::StringTypeAdapter<StringView>::writeTo): Deleted.
(WTF::StringTypeAdapter<StringView>::toString const): Deleted.

Tools:

Test a few more types can be made string'd.

  • TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:

(TestWebKitAPI::TEST):

4:43 PM Changeset in webkit [225823] by jmarcell@apple.com
  • 11 edits in tags/Safari-605.1.17/Source/JavaScriptCore

Revert r225695. rdar://problem/35914716

4:40 PM Changeset in webkit [225822] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Playing webrtc video tracks should prevent from display to got to sleep
https://bugs.webkit.org/show_bug.cgi?id=180666

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12
Reviewed by Darin Adler.

Done through manual testing by checking screen assertions taken on webrtc sites.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::shouldDisableSleep const):

4:32 PM Changeset in webkit [225821] by sbarati@apple.com
  • 3 edits
    1 add in trunk

ConstantFoldingPhase rule for GetMyArgumentByVal must check for negative indices
https://bugs.webkit.org/show_bug.cgi?id=180723
<rdar://problem/35859726>

Reviewed by JF Bastien.

JSTests:

  • stress/get-my-argument-by-val-constant-folding.js: Added.

(test):
(catch):

Source/JavaScriptCore:

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

4:31 PM Changeset in webkit [225820] by Brian Burg
  • 5 edits in trunk

Web Inspector: support async setup() and async teardown() in AsyncTestSuite
https://bugs.webkit.org/show_bug.cgi?id=180626

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

This can make some code simpler by removing Promise-related boilerplate. I'm splitting
this patch from the new use-site in the interest of making it easier to review.

  • UserInterface/Test/TestSuite.js:

(AsyncTestSuite.prototype.runTestCases):
(AsyncTestSuite):

LayoutTests:

Update tests to cover async setup() and async teardown() in the case
of success, runtime failure, and explicit failure.

  • inspector/unit-tests/async-test-suite-expected.txt:
  • inspector/unit-tests/async-test-suite.html:
4:11 PM Changeset in webkit [225819] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Flakiness dashboard: Make GTK and WPE builds inherit expectations from WK2
https://bugs.webkit.org/show_bug.cgi?id=178782

Patch by Alicia Boya García <aboya@igalia.com> on 2017-12-12
Reviewed by Michael Catanzaro.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
3:54 PM Changeset in webkit [225818] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Dispatch resource load statistics telemetry on the main thread
https://bugs.webkit.org/show_bug.cgi?id=180602
<rdar://problem/35942205>

Reviewed by Brent Fulgham.

  • UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

Now switches to the main thread for the telemetry submission
through a webpage proxy. The reason is that the webpage we
use may go away while we're still using it. This kind of
telemetry isn't associated with a specific webpage but the
infrastructure requires a webpage proxy.

3:41 PM Changeset in webkit [225817] by don.olmstead@sony.com
  • 2 edits in trunk

[WinCairo] Enable WebP support
https://bugs.webkit.org/show_bug.cgi?id=179908

Reviewed by Konstantin Tokarev.

  • Source/cmake/OptionsWinCairo.cmake:
3:35 PM Changeset in webkit [225816] by dino@apple.com
  • 12 edits
    3 copies
    3 adds in trunk/Source/WebCore

Add CanvasRenderingContext2DBase class and OffscreenCanvasRenderingContext2D
https://bugs.webkit.org/show_bug.cgi?id=180718
<rdar://problem/36004015>

Reviewed by Sam Weinig.

Add an OffscreenCanvasRenderingContext2D class, and in the process create a shared
base class for it and CanvasRenderingContext2D, called CanvasRenderingContext2DBase.
The base class has nearly all the functionality, with the exception of the text
and focus rendering APIs, which are only exposed on CanvasRenderingContext2D.

At the moment CanvasRenderingContext2DBase's implementation still expects the attached
canvas to be an HTMLCanvasElement, but that's ok since you can't yet create an
OffscreenCanvasRenderingContext2D. A subsequent patch will do the right thing.

No change in functionality at the moment, so covered by the existing tests.

  • DerivedSources.make: Add the new IDL file.
  • Sources.txt: Add all the new files to compile.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: Removed some unnecessary headers, and

added JSC:: where appropriate.
(WebCore::JSCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSCanvasRenderingContext2D::visitAdditionalChildren):

  • bindings/js/JSOffscreenCanvasRenderingContext2DCustom.cpp: Copied from Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp.

(WebCore::root): New root function that just returns the address of the OffscreenCanvas.
(WebCore::JSOffscreenCanvasRenderingContext2DOwner::isReachableFromOpaqueRoots):
(WebCore::JSOffscreenCanvasRenderingContext2D::visitAdditionalChildren):

  • bindings/js/JSWorkerNavigatorCustom.cpp: Add JSC:: to fix a compilation error.

(WebCore::JSWorkerNavigator::visitAdditionalChildren):

  • bindings/js/WebCoreBuiltinNames.h: New IDL types.
  • html/OffscreenCanvas.idl: Explicitly generates an IsReachable.
  • html/canvas/CanvasRenderingContext.h:

(WebCore::CanvasRenderingContext::isOffscreen2d const): Helper for is<> trait.

  • html/canvas/CanvasRenderingContext2D.cpp: Nearly everything has been moved to the Base class.
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2DBase.cpp: Copied from Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp.
  • html/canvas/CanvasRenderingContext2DBase.h: Copied from Source/WebCore/html/canvas/CanvasRenderingContext2D.h.
  • html/canvas/OffscreenCanvasRenderingContext2D.cpp: Added. Basic implementation that

just uses the Base class.
(WebCore::OffscreenCanvasRenderingContext2D::OffscreenCanvasRenderingContext2D):

  • html/canvas/OffscreenCanvasRenderingContext2D.h: Added.
  • html/canvas/OffscreenCanvasRenderingContext2D.idl: Added.
3:13 PM Changeset in webkit [225815] by Jonathan Bedard
  • 3 edits in trunk/Tools

MobileMiniBrowser using the wrong toolchain
https://bugs.webkit.org/show_bug.cgi?id=180716
<rdar://problem/36002951>

Reviewed by Tim Horton.

Move Debug/Release configurations from xcodeproj into Base.xcconfig.

  • MobileMiniBrowser/Configurations/Base.xcconfig:
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
3:13 PM Changeset in webkit [225814] by Brian Burg
  • 5 edits in trunk

Web Inspector: SyncTestSuite should complain if passed an async setup/test/teardown function
https://bugs.webkit.org/show_bug.cgi?id=180717

Reviewed by Devin Rousso.

Source/WebInspectorUI:

  • UserInterface/Test/TestSuite.js:

(SyncTestSuite.prototype.addTestCase):
Raise an exception if test/setup/teardown is an async function. It won't work.

LayoutTests:

Add new test cases for more strict requirements for test case arguments.

  • inspector/unit-tests/sync-test-suite-expected.txt:
  • inspector/unit-tests/sync-test-suite.html:
3:12 PM Changeset in webkit [225813] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebCore

[EME] Support FPS-over-HLS in the Modern EME API
https://bugs.webkit.org/show_bug.cgi?id=180707

Reviewed by Eric Carlson.

Add support for the "skd" initDataType, where the initData is the URI provided in the
EXT-X-KEY tag in a HLS manifest:

  • platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::CDMPrivateFairPlayStreaming::sinfName):
(WebCore::CDMPrivateFairPlayStreaming::skdName):
(WebCore::extractSinfData):
(WebCore::CDMPrivateFairPlayStreaming::sanitizeSkd):
(WebCore::CDMPrivateFairPlayStreaming::extractKeyIDsSkd):
(WebCore::validInitDataTypes):
(WebCore::CDMFactory::platformRegisterFactories):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitDataType const):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):
(WebCore::CDMPrivateFairPlayStreaming::supportsInitData const):
(WebCore::sinfName): Deleted.

Add support for creating a AVContentKeyRequest from a skd key URI rather than from
initialization data, and for extracting keyIDs from the AVContentKeyRequest identifier.

  • platform/graphics/avfoundation/CDMFairPlayStreaming.h:
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keyIDs):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest):

Add support for AVContentKeySession to MediaPlayerPrivateAVFoundationObjC, and for emitting
initializationData messages when encountering a loading request for a "skd" URI.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):

3:12 PM Changeset in webkit [225812] by graouts@webkit.org
  • 7 edits in trunk

[Web Animations] Expose promises on Animation interface
https://bugs.webkit.org/show_bug.cgi?id=180710
<rdar://problem/36000604>

Reviewed by Dean Jackson.

Source/WebCore:

Expose the "ready" and "finished" promises on Animation. A future patch will fulfil or reject them.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::WebAnimation):
(WebCore::WebAnimation::readyPromiseResolve):
(WebCore::WebAnimation::finishedPromiseResolve):

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:

LayoutTests:

Rebase some WPT expectations with progressions due to exposing the "ready" and "finished" promises.

  • http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt:
  • http/wpt/web-animations/timing-model/animations/current-time-expected.txt:
3:11 PM Changeset in webkit [225811] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

IPC code doesn't understand NSDictionaries with non-NSString keys
https://bugs.webkit.org/show_bug.cgi?id=180307
<rdar://problem/35812382>

Reviewed by Alex Christensen.

Source/WebKit:

Variable fonts have a dictionary inside its descriptor which represents the values
of all the axes of the variable font. Our IPC code wasn't expecting this.

  • Shared/mac/ArgumentCodersMac.mm:

(IPC::encode):
(IPC::decode):

LayoutTests:

  • fast/text/variations/ipc-expected.txt: Added.
  • fast/text/variations/ipc.html: Added.
3:10 PM Changeset in webkit [225810] by Brian Burg
  • 7 edits
    2 adds in trunk

Web Inspector: add InspectorTest.expectException() and use it
https://bugs.webkit.org/show_bug.cgi?id=180719

Reviewed by Matt Baker.

Source/WebInspectorUI:

This helps straighten out async test() functions that need
to test exceptional cases. Without this, every such method
needs try/catch boilerplate to leak the error outside the
scope of the catch-block and then assert that it exists.

  • UserInterface/Test/TestHarness.js:

(TestHarness.prototype.expectException):
Added. This method takes a callback which is expected to raise
an exception either by throwing an Error instance or returning
a Promise that rejects with an Error instance. The method returns
a Promise that is either resolved with the expected exception
from one of the above sources, or is rejected with the non-exception
result that was returned or resolved by the callback.

LayoutTests:

  • inspector/dom/highlightNode-expected.txt:
  • inspector/dom/highlightNode.html:

Adopt the new helper method.

  • inspector/unit-tests/test-harness-expect-functions-async-expected.txt: Added.
  • inspector/unit-tests/test-harness-expect-functions-async.html: Added.

Add a separate async test suite for async expect* functions.

  • inspector/unit-tests/test-harness-expect-functions-expected.txt:
  • inspector/unit-tests/test-harness-expect-functions.html:

Standardize the naming for these two suites.

3:01 PM Changeset in webkit [225809] by commit-queue@webkit.org
  • 4 edits in trunk

Fetch Event header filtering should apply in CORS mode only
https://bugs.webkit.org/show_bug.cgi?id=180708

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:

Source/WebCore:

Covered by no-longer failing test.

  • workers/service/context/ServiceWorkerFetch.cpp: cleaning headers only in case of CORS mode.
2:51 PM Changeset in webkit [225808] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

REGRESSION (Safari 11): custom <font-face> tag crashes a page
https://bugs.webkit.org/show_bug.cgi?id=177848

Reviewed by Darin Adler.

Source/WebCore:

We currently use the CSS property parsers to parse SVG's <font-face> element attributes. Instead,
we should be using the CSS descriptor parsers to parse these attributes. However, this is a
fairly involved task, so until I can finish that, this patch fixes the crash. The crash is simple;
the descriptors shouldn't accept the universal keywords ("initial", "inherit", etc.) and our
font-face machinery assumes this. So the fix is just detect these keywords and explicitly disallow
them.

Test: svg/text/font-style-keyword.html

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::parseAttribute):

LayoutTests:

  • svg/text/font-style-keyword-expected.txt: Added.
  • svg/text/font-style-keyword.html: Added.
2:24 PM Changeset in webkit [225807] by commit-queue@webkit.org
  • 8 edits in trunk

[Web Animations] Implement the playState property on Animation
https://bugs.webkit.org/show_bug.cgi?id=180711
<rdar://problem/36000982>

Patch by Antoine Quint <Antoine Quint> on 2017-12-12
Reviewed by Dean Jackson.

Source/WebCore:

Expose the playState and pending properties. The playState property has a complete implementation but
has some test failures due to Animation lacking correct behavior while running animations which will
be fixed in a followup patch. The pending property is a placeholder until we implement pending play
and pause tasks in followup patches.

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::playState const):
(WebCore::WebAnimation::effectEndTime const):

  • animation/WebAnimation.h:
  • animation/WebAnimation.idl:

LayoutTests:

Rebase some WPT expectations with progressions due to exposing the "playState" and "pending" properties.

  • http/wpt/web-animations/interfaces/Animation/constructor-expected.txt:
  • http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt:
  • http/wpt/web-animations/timing-model/animations/set-the-timeline-of-an-animation-expected.txt:
2:23 PM Changeset in webkit [225806] by Michael Catanzaro
  • 2 edits in trunk/Source/WebInspectorUI

Don't require perl(File::Copy::Recursive)
https://bugs.webkit.org/show_bug.cgi?id=180479
<rdar://problem/35944218>

Reviewed by Daniel Bates.

Fix the error handling. I added this at the last moment and failed to test. The logic is
inverted, causing an error to always be reported on success.

Add a missing 'mkdir -p' using File::Path::make_path. This has its own built-in error
reporting, so no need to add our own.

  • Scripts/copy-user-interface-resources.pl:

(ditto):

2:19 PM Changeset in webkit [225805] by jfernandez@igalia.com
  • 55 edits in trunk

[css-grid] Implement alignment for absolute positioned grid items
https://bugs.webkit.org/show_bug.cgi?id=180632

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

These tests now pass and verify the alignment logic for positioned grid items.

  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-002-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-005-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-007-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-009-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-011-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-013-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-014-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-column-axis-alignment-positioned-items-016-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-002-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-003-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-004-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-005-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-007-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-009-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-010-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-013-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-014-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-015-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-001-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-002-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-003-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-004-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-005-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-006-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-007-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-008-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-009-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-009.html:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-010-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-011-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-non-static-positioned-items-012-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-001-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-002-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-003-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-004-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-005-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-006-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-007-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-008-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-009-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-010-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-011-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-012-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-013-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-014-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-015-expected.txt:
  • web-platform-tests/css/css-grid/alignment/grid-self-alignment-positioned-items-with-margin-border-padding-016-expected.txt:

Source/WebCore:

We are changing how we compute the grid area's size of positioned
items, trying to make the logic as independent as possible of the
grid container's direction.

The new way of placing absolute positioned elements in their grid area
is based on the previously computed area's size. This provide a
mechanism to place an item in its area respecting the offsets derived
from the Content Alignment CSS properties and, which is more important,
ignoring the grid container's direction.

Additionally, we use the already implemented alignment logic that's
used for regular grid items. This patch provides almost full alignment
capabilities for positioned objects, with the exception of 'stretch'.

It's worth mentioning that some of the test cases using vertical-rl
writing mode will fail because of the bug 180633.

Updated web-platform-tests results of the test cases that pass now.

  • rendering/GridLayoutFunctions.cpp:

(WebCore::GridLayoutFunctions::hasOverrideContainingBlockContentSizeForChild):

(WebCore::GridLayoutFunctions::overrideContainingBlockContentSizeForChild):

  • rendering/GridLayoutFunctions.h:
  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::updateOverrideContainingBlockContentSizeForChild const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridItemOffset const):
(WebCore::RenderGrid::hasStaticPositionForChild const):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):
(WebCore::RenderGrid::columnAxisPositionForChild const):
(WebCore::RenderGrid::rowAxisPositionForChild const):
(WebCore::RenderGrid::columnAxisOffsetForChild const):
(WebCore::RenderGrid::rowAxisOffsetForChild const):
(WebCore::RenderGrid::gridPositionIsAutoForOutOfFlow const):
(WebCore::RenderGrid::resolveAutoStartGridPosition const):
(WebCore::RenderGrid::resolveAutoEndGridPosition const):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::RenderGrid::logicalOffsetForChild const):
(WebCore::RenderGrid::gridAreaPositionForOutOfFlowChild const):
(WebCore::RenderGrid::gridAreaPositionForInFlowChild const):
(WebCore::RenderGrid::gridAreaPositionForChild const):
(WebCore::RenderGrid::translateOutOfFlowRTLCoordinate const):
(WebCore::RenderGrid::findChildLogicalPosition const):

  • rendering/RenderGrid.h:
  • rendering/style/GridPositionsResolver.cpp:

(WebCore::adjustGridPositionsFromStyle):
(WebCore::GridPositionsResolver::initialPositionSide):
(WebCore::GridPositionsResolver::finalPositionSide):

  • rendering/style/GridPositionsResolver.h:
1:49 PM Changeset in webkit [225804] by Brian Burg
  • 8 edits in trunk/Source/JavaScriptCore

Web Inspector: modernize InjectedScript a bit
https://bugs.webkit.org/show_bug.cgi?id=180367

Reviewed by Timothy Hatcher.

Stop using out parameters passed by pointer, use references instead.
Stop using OptOutput<T> in favor of std::optional where possible.
If there is only one out-parameter and a void return type, then return the value.

  • inspector/InjectedScript.h:
  • inspector/InjectedScript.cpp:

(Inspector::InjectedScript::evaluate):
(Inspector::InjectedScript::callFunctionOn):
(Inspector::InjectedScript::evaluateOnCallFrame):
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):

  • inspector/InjectedScriptBase.h:
  • inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::InjectedScriptBase):
Declare m_environment with a default initializer.

(Inspector::InjectedScriptBase::makeCall):
(Inspector::InjectedScriptBase::makeEvalCall):
Just return the result, no need for an out-parameter.
Rearrange some code paths now that we can just return a result.
Return a Ref<JSON::Value> since it is either a result value or error value.
Use out_ prefixes in a few places to improve readability.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::getFunctionDetails):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::getPreview):

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::evaluate):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::InspectorRuntimeAgent::getCollectionEntries):
(Inspector::InspectorRuntimeAgent::saveResult):
Adapt to InjectedScript changes. In some cases we need to bridge OptOutput<T>
and std::optional until the former is removed from generated method signatures.

1:36 PM Changeset in webkit [225803] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update ContentFiltering.LazilyLoadPlatformFrameworks test to account for libwebrtc using VideoProcessing framework
https://bugs.webkit.org/show_bug.cgi?id=180713

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12
Reviewed by Andy Estes.

Temporarily disabling a subcheck until we make the test more robust and/or libwebrtc weak linking VideoProcessing framework.

  • TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:

(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):

1:35 PM Changeset in webkit [225802] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[EME] Support reporting and restoring persistent usage data.
https://bugs.webkit.org/show_bug.cgi?id=180684

Reviewed by Eric Carlson.

Add support for reading and acknowledging persistent usage data from the MediaKeys storage
directory.

Add a mechanism for passing the storage location down to CDMPrivate and CDMInstance objects
inside of the CDM class itself:

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::createInstance):
(WebCore::CDM::storageDirectory const):

  • Modules/encryptedmedia/CDM.h:

Support loading expired session data, acknowledging expired session data, closing sessions
and removing usable key data.

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::isEqual):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::removeSessionData):

1:16 PM Changeset in webkit [225801] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix after r225763.

Remove dangling close-parentheses character.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
1:11 PM Changeset in webkit [225800] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebGL TextureMapperShaderProgram shaders don't compile in MSVC
https://bugs.webkit.org/show_bug.cgi?id=180709

Patch by Christopher Reid <chris.reid@sony.com> on 2017-12-12
Reviewed by Myles C. Maxfield.

No new tests, no change in behavior.

Vertex and Fragment shaders were not compiling because TextureMapperShaderProgram.cpp was
stringifying "#if USE(OPENGL_ES_2) ... #endif" into the shaders rather than evaluating these
preprocessor directives before the STRINGIFY expansion.

Moved these #if conditions outside of STRINGIFY to remove compiler ambiguity.

  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:
1:01 PM Changeset in webkit [225799] by Caio Lima
  • 46 edits
    9 adds in trunk

[ESNext][BigInt] Implement BigInt literals and JSBigInt
https://bugs.webkit.org/show_bug.cgi?id=179000

Reviewed by Darin Adler and Yusuke Suzuki.

JSTests:

  • bigIntTests.yaml: Added.
  • stress/big-int-literal-line-terminator.js: Added.
  • stress/big-int-literals.js: Added.
  • stress/big-int-operations-error.js: Added.
  • stress/big-int-type-of.js: Added.
  • stress/big-int-white-space-trailing-leading.js: Added.
  • stress/big-int-function-apply.js: Added.

Source/JavaScriptCore:

This patch starts the implementation of BigInt primitive on
JavaScriptCore. We are introducing BigInt primitive and
implementing it on JSBigInt as a subclass of JSCell with BigIntData?
field implemented contiguosly on memory as inline storage of JSBigInt to
take advantages on performance due to cache locality. The
implementation allows 64 or 32 bitwise arithmetic operations.
JSBigInt also has m_sign to store the sign of BigIntData? and
m_length that keeps track of BigInt length.
The implementation is following the V8 one. BigIntData? is manipulated
by JSBigInt::setDigit(index, value) and JSBigInt::digit(index) operations.
We also have some operations to support arithmetics over digits.

It is important to notice that on our representation,
JSBigInt::dataStorage()[0] represents the least significant digit and
JSBigInt::dataStorage()[m_length - 1] represents the most siginificant digit.

We are also introducing into this Patch the BigInt literals lexer and
syntax parsing support. The operation Strict Equals on BigInts is also being
implemented to enable tests.
These features are being implemented behind a runtime flage "--useBigInt" and
are disabled by default.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • bytecode/CodeBlock.cpp:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEqualityOp):
(JSC::BytecodeGenerator::addBigIntConstant):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::BigIntEntryHash::hash):
(JSC::BytecodeGenerator::BigIntEntryHash::equal):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BigIntNode::jsValue const):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::isToThisAnIdentity):

  • interpreter/Interpreter.cpp:

(JSC::sizeOfVarargs):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LowLevelInterpreter.asm:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createBigInt):

  • parser/Lexer.cpp:

(JSC::Lexer<T>::parseBinary):
(JSC::Lexer<T>::parseOctal):
(JSC::Lexer<T>::parseDecimal):
(JSC::Lexer<T>::lex):
(JSC::Lexer<T>::parseHex): Deleted.

  • parser/Lexer.h:
  • parser/NodeConstructors.h:

(JSC::BigIntNode::BigIntNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isBigInt const):
(JSC::BigIntNode::value):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parsePrimaryExpression):

  • parser/ParserTokens.h:
  • parser/ResultType.h:

(JSC::ResultType::definitelyIsBigInt const):
(JSC::ResultType::mightBeBigInt const):
(JSC::ResultType::isNotBigInt const):
(JSC::ResultType::addResultType):
(JSC::ResultType::bigIntType):
(JSC::ResultType::forAdd):
(JSC::ResultType::forLogicalOp):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createBigInt):

  • runtime/CommonIdentifiers.h:
  • runtime/JSBigInt.cpp: Added.

(JSC::JSBigInt::visitChildren):
(JSC::JSBigInt::JSBigInt):
(JSC::JSBigInt::initialize):
(JSC::JSBigInt::createStructure):
(JSC::JSBigInt::createZero):
(JSC::JSBigInt::allocationSize):
(JSC::JSBigInt::createWithLength):
(JSC::JSBigInt::finishCreation):
(JSC::JSBigInt::toPrimitive const):
(JSC::JSBigInt::singleDigitValueForString):
(JSC::JSBigInt::parseInt):
(JSC::JSBigInt::toString):
(JSC::JSBigInt::isZero):
(JSC::JSBigInt::inplaceMultiplyAdd):
(JSC::JSBigInt::digitAdd):
(JSC::JSBigInt::digitSub):
(JSC::JSBigInt::digitMul):
(JSC::JSBigInt::digitPow):
(JSC::JSBigInt::digitDiv):
(JSC::JSBigInt::internalMultiplyAdd):
(JSC::JSBigInt::equalToBigInt):
(JSC::JSBigInt::absoluteDivSmall):
(JSC::JSBigInt::calculateMaximumCharactersRequired):
(JSC::JSBigInt::toStringGeneric):
(JSC::JSBigInt::rightTrim):
(JSC::JSBigInt::allocateFor):
(JSC::JSBigInt::estimatedSize):
(JSC::JSBigInt::toNumber const):
(JSC::JSBigInt::getPrimitiveNumber const):

  • runtime/JSBigInt.h: Added.

(JSC::JSBigInt::setSign):
(JSC::JSBigInt::sign const):
(JSC::JSBigInt::setLength):
(JSC::JSBigInt::length const):
(JSC::JSBigInt::parseInt):
(JSC::JSBigInt::offsetOfData):
(JSC::JSBigInt::dataStorage):
(JSC::JSBigInt::digit):
(JSC::JSBigInt::setDigit):
(JSC::asBigInt):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::synthesizePrototype const):
(JSC::JSValue::toStringSlowCase const):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::isBigInt const):
(JSC::JSValue::strictEqualSlowCaseInline):

  • runtime/JSCell.cpp:

(JSC::JSCell::put):
(JSC::JSCell::putByIndex):
(JSC::JSCell::toPrimitive const):
(JSC::JSCell::getPrimitiveNumber const):
(JSC::JSCell::toNumber const):
(JSC::JSCell::toObjectSlow const):

  • runtime/JSCell.h:
  • runtime/JSCellInlines.h:

(JSC::JSCell::isBigInt const):

  • runtime/JSType.h:
  • runtime/MathCommon.h:

(JSC::clz64):

  • runtime/NumberPrototype.cpp:
  • runtime/Operations.cpp:

(JSC::jsTypeStringForValue):
(JSC::jsIsObjectTypeOrNull):

  • runtime/Options.h:
  • runtime/ParseInt.h:
  • runtime/SmallStrings.h:

(JSC::SmallStrings::typeString const):

  • runtime/StructureInlines.h:

(JSC::prototypeForLookupPrimitiveImpl):

  • runtime/TypeofType.cpp:

(WTF::printInternal):

  • runtime/TypeofType.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/HashFunctions.h:

Tools:

  • Scripts/run-jsc-stress-tests:
1:01 PM Changeset in webkit [225798] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[WK2] Expose image via WKBundleHitTestResult API.
https://bugs.webkit.org/show_bug.cgi?id=180552.
rdar://problem/23951521

Patch by Zach Li <zachli@apple.com> on 2017-12-12
Reviewed by Simon Fraser.

Source/WebCore:

  • platform/graphics/ImageSource.h:

This method will be used by clients outside WebCore, so
add WEBCORE_EXPORT.

Source/WebKit:

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultGetImage):

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::image const):
Convert from WebCore::Image to WebImage by creating a WebImage
and paint the WebCore::Image into its graphics context. For now,
only handle bitmap images.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
1:00 PM Changeset in webkit [225797] by Simon Fraser
  • 19 edits in trunk/Source

Remove ColorSpaceDeviceRGB and most users of the obsolete deviceRGB colorspace
https://bugs.webkit.org/show_bug.cgi?id=180689

Reviewed by Tim Horton.

Source/WebCore:

Remove the ColorSpaceDeviceRGB enum and users.

ImageBuffer now uses sRGB instead of deviceRGB in the few cases that used the latter.

Switch Windows CG code to use sRGBColorSpaceRef() instead of deviceRGBColorSpaceRef().

Have linearRGBColorSpaceRef() use kCGColorSpaceLinearSRGB, which is present in iOS 9 and 10.11 and later.

  • page/win/FrameCGWin.cpp:

(WebCore::imageFromRect):

  • platform/graphics/Color.cpp:

(WebCore::operator<<):

  • platform/graphics/ColorSpace.h:
  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::transformColorSpace):

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::Color::Color):
(WebCore::leakCGColor):
(WebCore::createCGColorWithDeviceRGBA): Deleted.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):
(WebCore::linearRGBColorSpaceRef):
(WebCore::extendedSRGBColorSpaceRef):
(WebCore::displayP3ColorSpaceRef):
(WebCore::deviceRGBColorSpaceRef): Deleted.

  • platform/graphics/cg/GraphicsContextCG.h:

(WebCore::cachedCGColorSpace):

  • platform/graphics/cocoa/GraphicsContextCocoa.mm:
  • platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::CGContextWithHDC):
(WebCore::GraphicsContext::releaseWindowsContext):
(WebCore::GraphicsContext::drawWindowsBitmap):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::create):
(WebCore::BitmapImage::getHBITMAPOfSize):

  • platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::pixelBufferFromCGImage const):

  • platform/win/DragImageCGWin.cpp:

(WebCore::allocImage):
(WebCore::createCgContextFromBitmap):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):

Source/WebKit:

Remove encoding of ColorSpaceDeviceRGB.

  • Shared/WebCoreArgumentCoders.h:

Source/WebKitLegacy/mac:

Use sRGBColorSpaceRef() from WebCore.

  • WebView/WebHTMLView.mm:

(imageFromRect):

12:43 PM Changeset in webkit [225796] by commit-queue@webkit.org
  • 11 edits in trunk

Navigation requests should use navigate fetch mode
https://bugs.webkit.org/show_bug.cgi?id=179808

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/navigation-redirect.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/request-end-to-end.https-expected.txt:

This is a progression since test is failing at a later point. Test might need being updated to match latest fetch spec.

  • web-platform-tests/service-workers/service-worker/resources/clients-get-worker.js:

(self.onfetch): Change upstreamed at https://github.com/w3c/web-platform-tests/pull/8289.

Source/WebCore:

Covered by existing tests.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions): Update to throw only if init.mode is Navigate.

  • Modules/fetch/FetchRequestInit.h:

(WebCore::FetchRequestInit::hasMembers const): If init is present, set default values as per spec.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::loadMainResource): Set fetch mode to navigate.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Bypass preflight in case fetch mode is navigate.

LayoutTests:

  • http/tests/workers/service/basic-fetch.https-expected.txt:
  • http/tests/workers/service/resources/basic-fetch-worker.js:
  • http/tests/workers/service/resources/basic-fetch.js:

(async.test):

11:52 AM Changeset in webkit [225795] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

REGRESSION(r216941): Plugin Process can't access AppStore Plugin Service
https://bugs.webkit.org/show_bug.cgi?id=180701
<rdar://problem/35940948>

Reviewed by Daniel Bates.

The PluginProcess needs access to the AppStore Plugin XPC service.

  • PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
11:40 AM Changeset in webkit [225794] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

Rebasing/unskipping some WPT service worker tests
https://bugs.webkit.org/show_bug.cgi?id=180705

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/service-worker-csp-default.https-expected.txt:
  • web-platform-tests/service-workers/service-worker/service-worker-csp-script.https-expected.txt:

LayoutTests:

11:20 AM Changeset in webkit [225793] by jmarcell@apple.com
  • 6 edits
    1 add in tags/Safari-605.1.17

Cherry-pick r225768. rdar://problem/34657871

11:19 AM Changeset in webkit [225792] by Joseph Pecoraro
  • 2 edits in trunk/Source/WTF

Symbol not found: ZN3WTF8LockBase10unlockSlowEv
https://bugs.webkit.org/show_bug.cgi?id=180691

Reviewed by Yusuke Suzuki.

  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm:

(WTF::LockBase::lockSlow):
(WTF::LockBase::unlockSlow):
Add back LockBase Symbols used by System Safari on 10.13.

11:15 AM Changeset in webkit [225791] by Simon Fraser
  • 6 edits
    2 adds in trunk

HTML-page with <object type="image/svg+xml" data="foo.svg"> often is blank
https://bugs.webkit.org/show_bug.cgi?id=180524
<rdar://problem/35920554>

Reviewed by Antti Koivisto.

Source/WebCore:

The test case has script that conditionalizes behavior on whether window.innerWidth/Height
are zero during the load event. We didn't force layout in innerWidth/Height, so whether
they would zero depended on whether the parent frame had laid out, which was timing-sensitive.

Fix by triggering enough layout in the parent document so that the FrameView is resized before
fetching its dimensions in innerWidth/Height. This causes our behavior to match Chrome and Firefox.

Test: fast/dom/iframe-innerWidth.html

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent): Add some logging that helped me diagnose this.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::innerHeight const):
(WebCore::DOMWindow::innerWidth const):

LayoutTests:

Adjust a test where the new layout is triggering scrollbar creation.

  • fast/dom/iframe-inner-size-scaling-expected.txt:
  • fast/dom/iframe-inner-size-scaling.html:
  • fast/dom/iframe-innerWidth-expected.txt: Added.
  • fast/dom/iframe-innerWidth.html: Added.
11:01 AM Changeset in webkit [225790] by graouts@webkit.org
  • 9 edits in trunk

[Web Animations] Enqueue and dispatch animation events
https://bugs.webkit.org/show_bug.cgi?id=180657
<rdar://problem/35970103>

Reviewed by Chris Dumez.

Source/WebCore:

Now that we have support for the AnimationPlaybackEvent interface, we need a way to enqueue
such events for dispatch at the opportune time. The Web Animations spec defines two ways
to queue and dispatch events.

If the animation has a "document for timing", it should enqueue events on this document.
In our implementation, if the animation timeline is set to a DocumentTimeline, that means
it has a document for timing, and we let the DocumentTimeline enqueue those events, which
will be dispatched through a dedicated GenericTaskQueue<Timer>. These events will be sorted
by their respective timeline time before being dispatched.

If there is no document for timing, events should be dispatched as a standalone task.

  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::~DocumentTimeline): Close the event dispatch task queue when the
document timeline is torn down.
(WebCore::DocumentTimeline::enqueueAnimationPlaybackEvent): Add the provided event to the
pending animation events queue and, if one hasn't been registered yet, enqueue a task to
dispatch events using a GenericTaskQueue<Timer>.
(WebCore::compareAnimationPlaybackEvents): Comparator used to sort events in performEventDispatchTask()
where events are sorted such that unresolved timeline times come first, and then from the
earlier resolved timeline times to the later resolved timeline times. Events with unresolved
timeline times and equal resolved timeline times are sorted in the order they were enqueued.
(WebCore::DocumentTimeline::performEventDispatchTask): Run a stable sort on a copy of the pending list
of events to dispatch and dispatch the events individually on their respective animations.

  • animation/DocumentTimeline.h:
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::create): Pass in the document to the constructor.
(WebCore::WebAnimation::WebAnimation): Use the provided document to initialize ActiveDOMObject.
(WebCore::WebAnimation::enqueueAnimationPlaybackEvent): Create an AnimationPlaybackEvent with
the provided type, timeline time and animation time and enqueue it on the document timeline,
if one is available, or dispatch on this animation as a standalone task.
(WebCore::WebAnimation::acceleratedRunningStateDidChange):
(WebCore::WebAnimation::activeDOMObjectName const):
(WebCore::WebAnimation::canSuspendForDocumentSuspension const):
(WebCore::WebAnimation::stop):

  • animation/WebAnimation.h: Define WebAnimation to be an EventTarget and an ActiveDOMObject.
  • animation/WebAnimation.idl: Define WebAnimation to be an EventTarget and an ActiveDOMObject.
  • dom/EventTargetFactory.in:

LayoutTests:

Rebase Web Platform Tests with some progressions based on the IDL changes. Progressions due
to dispatching events will become apparent when the next patch, where we dispatch actual
animation playback events, lands.

  • http/wpt/web-animations/interfaces/Animation/idlharness-expected.txt:
10:48 AM Changeset in webkit [225789] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit

Make ServiceWorkers follow the DEFAULT_EXPERIMENTAL_FEATURES_ENABLED flag on Mac.
<rdar://problem/35978311> and https://bugs.webkit.org/show_bug.cgi?id=180697

Reviewed by Chris Dumez.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
10:40 AM Changeset in webkit [225788] by guijemont@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

LLInt: reserve 16 bytes of stack on MIPS for native calls
https://bugs.webkit.org/show_bug.cgi?id=180653

Reviewed by Carlos Alberto Lopez Perez.

  • llint/LowLevelInterpreter32_64.asm:

On MIPS, substract 24 from the stack pointer (16 for calling
convention + 8 to be 16-aligned) instead of the 8 on other platforms
(for alignment).

10:08 AM Changeset in webkit [225787] by Chris Dumez
  • 18 edits in trunk/Source

Simplify IPC code between WebProcess and StorageProcess for serviceWorker.postMessage()
https://bugs.webkit.org/show_bug.cgi?id=180683

Reviewed by Brady Eidson.

Merge the 2 code paths from calling postMessage() from a ServiceWorkerClient and from
a ServiceWorker. Also, postMessage() now only IPCs an identifier from the WebContent
process to the StorageProcess. The ServiceWorkerClientData is looked up on Storage
process side from the identifier before being sent to the context process.

Source/WebCore:

  • workers/service/SWClientConnection.h:
  • workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

  • workers/service/ServiceWorkerTypes.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::clientByID const):
(WebCore::SWServer::matchAll):
(WebCore::SWServer::forEachClientForOrigin):
(WebCore::SWServer::claim):
(WebCore::SWServer::registerServiceWorkerClient):
(WebCore::SWServer::unregisterServiceWorkerClient):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::findClientByIdentifier):

  • workers/service/server/SWServerWorker.h:

Source/WebKit:

  • Scripts/webkit/messages.py:

(forward_declarations_and_headers):
(headers_for_type):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ServiceWorkerOrClientIdentifier>::encode):
(IPC::ArgumentCoder<ServiceWorkerOrClientIdentifier>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::postMessageToServiceWorker):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
  • WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::postMessageToServiceWorker):

  • WebProcess/Storage/WebSWClientConnection.h:
10:02 AM Changeset in webkit [225786] by Michael Catanzaro
  • 2 edits in trunk/Source/WebInspectorUI

Unreviewed, don't print empty error message when copying resource fails

Unsurprisingly, when system() fails, there is not any useful error to be printed, so don't.

  • Scripts/copy-user-interface-resources.pl:

(ditto):

9:26 AM Changeset in webkit [225785] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Allow AudioContext to start when getUserMedia is on
https://bugs.webkit.org/show_bug.cgi?id=180680

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-12
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/getUserMedia-webaudio-autoplay.html

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::willBeginPlayback):

LayoutTests:

  • webrtc/getUserMedia-webaudio-autoplay-expected.txt: Added.
  • webrtc/getUserMedia-webaudio-autoplay.html: Added.
8:51 AM Changeset in webkit [225784] by romain.bellessort@crf.canon.fr
  • 7 edits in trunk

[Readable Streams API] Throw RangeError if a size is provided when creating a readable byte stream
https://bugs.webkit.org/show_bug.cgi?id=180470

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

One new test imported from WPT to check that RangeError is thrown if a size is provided.

  • web-platform-tests/streams/readable-byte-streams/general-expected.txt: Updated expectations.
  • web-platform-tests/streams/readable-byte-streams/general.dedicatedworker-expected.txt: Updated expectations.
  • web-platform-tests/streams/readable-byte-streams/general.js: Imported one test case from WPT.
  • web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt: Updated expectations.

Source/WebCore:

Throw a RangeError if a ReadableStream is created with type 'bytes' and with a
non-undefined strategy size, as per latest spec:

One new test imported from WPT to check that RangeError is thrown.

  • Modules/streams/ReadableStream.js:

(initializeReadableStream): Check strategy size and throw RangeError if needed.

8:46 AM Changeset in webkit [225783] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK][WebRTC] Stop warning with so much verbosity about not implemented RealtimeMediaSourceCenter
https://bugs.webkit.org/show_bug.cgi?id=180694

Reviewed by Youenn Fablet.

No new tests -- no change in functionality.

  • platform/mediastream/RealtimeMediaSourceCenter.cpp:

(WebCore::RealtimeMediaSourceCenter::singleton):

8:12 AM Changeset in webkit [225782] by Ms2ger@igalia.com
  • 2 edits in trunk/LayoutTests

[WPE] Enable some wpt tests.
https://bugs.webkit.org/show_bug.cgi?id=180695

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
7:01 AM Changeset in webkit [225781] by Ms2ger@igalia.com
  • 9 edits
    10 adds
    1 delete in trunk/LayoutTests

[GTK] Update some test expectations.
https://bugs.webkit.org/show_bug.cgi?id=180655

Unreviewed test gardening.

LayoutTests/imported/w3c:

Update tests from upstream, and update test expectations.

  • web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub.htm:
  • web-platform-tests/common/media.js:
  • web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video-expected.txt:
  • web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video.html:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:

LayoutTests:

  • platform/gtk/TestExpectations:
    • Add bug numbers.
    • Remove failure expectations in favour of accurate baselines.
  • platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt: Added to account for the fact that libsoup is more lenient about data URLs.
  • platform/gtk/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/read-media/pageload-video-expected.txt: Added to account for video codec support depending on the platform.
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt: Added to account for whitespace differences in the dumped output.
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter-expected.txt: Added to account for whitespace differences in the dumped output.
  • platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/telephone-expected.txt: Added to account for whitespace differences in the dumped output.
  • platform/mac-wk1/imported/w3c/web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt: Removed; the platform-neutral expectation now matches.
6:58 AM Changeset in webkit [225780] by clopez@igalia.com
  • 6 edits
    1 delete in trunk/Tools

[GTK][WPE] Bump GStreamer version to 1.12 in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=171677

Reviewed by Carlos Garcia Campos.

Bump gstreamer related modules and rebase patches still needed and not merged

  • gstreamer/jhbuild.modules:
  • gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed. This was needed for OpenWebRTC. Not longer supported.
  • gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Rebased.
  • gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Rebased.
  • gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Rebased.
  • gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Added a note about merge commit not still in 1.12.4.
6:29 AM Changeset in webkit [225779] by Ms2ger@igalia.com
  • 7 edits in trunk

Implement {DOMMimeTypeArray, DOMPluginArray}::supportedPropertyNames().
https://bugs.webkit.org/show_bug.cgi?id=180471

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update test expectation. It will now work better if "WebKit built-in PDF"
is not present or not the only available plugin.

  • web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt:

Source/WebCore:

Test: imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray.html

  • plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::supportedPropertyNames):

  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::supportedPropertyNames):

LayoutTests:

Remove failure expectation for test that now matches the expectation file.

  • platform/gtk/TestExpectations:
2:35 AM Changeset in webkit [225778] by Yusuke Suzuki
  • 28 edits in trunk

[WTF] Thread::create should have Thread::tryCreate
https://bugs.webkit.org/show_bug.cgi?id=180333

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • assembler/testmasm.cpp:

(JSC::run):

  • b3/air/testair.cpp:
  • b3/testb3.cpp:

(JSC::B3::run):

  • jsc.cpp:

(functionDollarAgentStart):

Source/WebCore:

No behavior change.

  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectOnAlternateThreadForDebugging):

  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):

  • platform/audio/ReverbConvolver.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::start):

Source/WebKit:

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::open):

  • UIProcess/linux/MemoryPressureMonitor.cpp:

(WebKit::MemoryPressureMonitor::MemoryPressureMonitor):

Source/WebKitLegacy:

  • Storage/StorageThread.cpp:

(WebCore::StorageThread::start):

Source/WebKitLegacy/win:

  • WebKitQuartzCoreAdditions/CVDisplayLink.cpp:

(WKQCA::CVDisplayLink::start):

Source/WTF:

Many callers of Thread::create assume that it returns non-nullptr Thread.
But if the number of threads hits the limit in the system, creating Thread
would fail. In that case, it is really difficult to keep WebKit working.

We introduce Thread::tryCreate, and change the returned value from Thread::create
from RefPtr<Thread> to Ref<Thread>. In Thread::create, we ensure thread creation
succeeds by RELEASE_ASSERT. And we use Thread::create intentionally if the
caller assumes that thread should be created.

  • wtf/AutomaticThread.cpp:

(WTF::AutomaticThread::start):

  • wtf/ParallelJobsGeneric.cpp:

(WTF::ParallelEnvironment::ThreadPrivate::tryLockFor):

  • wtf/Threading.cpp:

(WTF::Thread::tryCreate):
(WTF::Thread::create): Deleted.

  • wtf/Threading.h:

(WTF::Thread::create):

  • wtf/WorkQueue.cpp:

(WTF::WorkQueue::concurrentApply):

Tools:

  • TestWebKitAPI/Tests/WTF/Condition.cpp:
  • TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
  • TestWebKitAPI/Tests/WTF/Signals.cpp:

(TEST):

  • TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:

(TestWebKitAPI::testThreadGroup):
(TestWebKitAPI::TEST):

Dec 11, 2017:

11:20 PM Changeset in webkit [225777] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore/PAL

Unreviewed build fix after r225766.

  • pal/spi/mac/AVFoundationSPI.h:

Conform AVStreamDataParser to the AVContentKeyRecipient protocol if available.

11:11 PM Changeset in webkit [225776] by Manuel Rego Casasnovas
  • 13 edits in trunk

[css-grid] Automatic minimum size is not clamped if min track sizing function is auto
https://bugs.webkit.org/show_bug.cgi?id=180283

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update expected result in the following WPT tests, as now everything
is passing there.

  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022-expected.txt:
  • web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023-expected.txt:

Source/WebCore:

We were not clamping the automatic minimum size when
the min track sizing function was intrinsic (e.g. minmax(auto, 0px)).
However the spec (https://drafts.csswg.org/css-grid/#min-size-auto)
is very clear regarding that.

This patch modifies
GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem(),
so in the case of a fixed max track sizing function it clamps
the automatic minimum size of the item to the stretch fit
of the grid area's size.
It needs to take into account if the item has fixed size, margin, border
and/or padding as those cannot be clamped.

Using WPT tests to verify this behavior,
and corrected a bunch of other tests that were wrong.

Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-017.html

imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-022.html
imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-minimum-size-grid-items-023.html

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem):

  • rendering/GridTrackSizingAlgorithm.h:

(WebCore::GridTrack::growthLimitIsInfinite const):

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::cacheMinMaxTrackBreadthTypes):
(WebCore::GridTrackSize::hasFixedMaxTrackBreadth const):

LayoutTests:

This patch updates a bunch of tests that were wrong
to follow the new behavior.

  • TestExpectations: Now we're passing one WPT test more.
  • fast/css-grid-layout/min-height-border-box.html:
  • fast/css-grid-layout/min-width-margin-box.html:
  • fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html:
  • fast/css-grid-layout/percent-of-indefinite-track-size.html:
11:06 PM Changeset in webkit [225775] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[Cairo] Cairo::clipToImageBuffer() should operate on a cairo_surface_t
https://bugs.webkit.org/show_bug.cgi?id=180665

Reviewed by Michael Catanzaro.

Have the Cairo::clipToImageBuffer() function in the CairoUtilities code
operate on a cairo_surface_t object, instead of an Image object.

Call site in GraphicsContext::clipToImageBuffer() is adjusted to first
ensure a non-null Image object, and then retrieve a cairo_surface_t
object from that, passing it on to Cairo::clipToImageBuffer().

No new tests -- no change in functionality.

  • platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::clipToImageBuffer):

  • platform/graphics/cairo/CairoOperations.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::clipToImageBuffer):

11:05 PM Changeset in webkit [225774] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[Cairo] Don't use a static cairo_surface_t object for CairoPath contexts
https://bugs.webkit.org/show_bug.cgi?id=180663

Reviewed by Michael Catanzaro.

Instead of using a single cairo_surface_t object and sharing it between
different cairo_t objects handled by CairoPath, create a new mock 1x1px
alpha-only surface for each cairo_t object that's allocated in the
CairoPath constructor.

This avoids potential issues in how Cairo's state handling internally
uses these surfaces, which is completely opaque to us and out of our
control. This also avoids crashes when using this one cairo_surface_t
object through different CairoPath objects across different threads.

No new tests -- no change in behavior.

  • platform/graphics/cairo/PlatformPathCairo.cpp:

(WebCore::CairoPath::CairoPath):
(WebCore::pathSurface): Deleted.

  • platform/graphics/cairo/PlatformPathCairo.h:

(WebCore::CairoPath::context):

11:04 PM Changeset in webkit [225773] by zandobersek@gmail.com
  • 7 edits
    4 adds
    4 deletes in trunk/Source

[CoordGraphics] Move UpdateAtlas, AreaAllocator into the platform layer
https://bugs.webkit.org/show_bug.cgi?id=180641

Reviewed by Michael Catanzaro.

Source/WebCore:

Move the UpdateAtlas and AreaAllocator classes and their source files
into the platform layer. This still means using the WebCore namespace,
but apart from that these two classes have no dependency on anything in
the WebKit layer, so they can be moved from there.

No new tests -- no change in functionality.

  • platform/TextureMapper.cmake:
  • platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp.

(WebCore::AreaAllocator::AreaAllocator):
(WebCore::AreaAllocator::~AreaAllocator):
(WebCore::AreaAllocator::expand):
(WebCore::AreaAllocator::expandBy):
(WebCore::AreaAllocator::release):
(WebCore::AreaAllocator::overhead const):
(WebCore::AreaAllocator::roundAllocation const):
(WebCore::GeneralAreaAllocator::GeneralAreaAllocator):
(WebCore::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebCore::GeneralAreaAllocator::freeNode):
(WebCore::GeneralAreaAllocator::expand):
(WebCore::fitsWithin):
(WebCore::GeneralAreaAllocator::allocate):
(WebCore::GeneralAreaAllocator::allocateFromNode):
(WebCore::GeneralAreaAllocator::splitNode):
(WebCore::GeneralAreaAllocator::updateLargestFree):
(WebCore::GeneralAreaAllocator::release):
(WebCore::GeneralAreaAllocator::overhead const):

  • platform/graphics/texmap/coordinated/AreaAllocator.h: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h.

(WebCore::nextPowerOfTwo):
(WebCore::AreaAllocator::size const):
(WebCore::AreaAllocator::minimumAllocation const):
(WebCore::AreaAllocator::setMinimumAllocation):
(WebCore::AreaAllocator::margin const):
(WebCore::AreaAllocator::setMargin):

  • platform/graphics/texmap/coordinated/UpdateAtlas.cpp: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp.

(WebCore::UpdateAtlas::UpdateAtlas):
(WebCore::UpdateAtlas::~UpdateAtlas):
(WebCore::UpdateAtlas::buildLayoutIfNeeded):
(WebCore::UpdateAtlas::didSwapBuffers):
(WebCore::UpdateAtlas::getCoordinatedBuffer):

  • platform/graphics/texmap/coordinated/UpdateAtlas.h: Renamed from Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h.

(WebCore::UpdateAtlas::size const):
(WebCore::UpdateAtlas::supportsAlpha const):
(WebCore::UpdateAtlas::addTimeInactive):
(WebCore::UpdateAtlas::isInactive const):
(WebCore::UpdateAtlas::isInUse const):

Source/WebKit:

Move the UpdateAtlas and AreaAllocator classes into the platform layer,
moving over build targets and adjust UpdateAtlas class references in
CompositingCoordinator.

  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • PlatformWin.cmake:
  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
10:30 PM Changeset in webkit [225772] by rniwa@webkit.org
  • 6 edits in trunk/Source/WebCore

Disable NoEventDispatchAssertion release assertion in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=180616

Reviewed by Zalan Bujtas.

Disabled the release assertion for NoEventDispatchAssertion in WebKit1 since there are many
delegate callbacks that happen at unsafe timing, and we don't have any hope of fixing them
in short term.

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::isSafeToUpdateStyleOrLayout):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeClassicScript):

  • platform/RuntimeApplicationChecks.h:

(WebCore::isInWebProcess):

  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::isInWebProcess): Extracted from IOSApplication::isWebProcess.
(WebCore::IOSApplication::isWebProcess):

9:47 PM Changeset in webkit [225771] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r225683): Chakra test failure in es6/regex-unicode.js for 32bit builds
https://bugs.webkit.org/show_bug.cgi?id=180685

Reviewed by Saam Barati.

The characterClass->m_anyCharacter check at the top of checkCharacterClass() caused
the character class check to return true without reading the character. Given that
the character could be a surrogate pair, we need to read the character even if we
don't have the check it.

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::Interpreter::testCharacterClass):
(JSC::Yarr::Interpreter::checkCharacterClass):

8:54 PM Changeset in webkit [225770] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Enable running sharded tests
https://bugs.webkit.org/show_bug.cgi?id=180660

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-12-11
Reviewed by Alex Christensen.

The sharder splits the test inputs into groups of test based on the directory,
but separation of base name and directory name was wrong because of this bug.
Once sharded correctly, the execution of layout test on native Windows environment
is in parallel and much less time to run.

  • Scripts/webkitpy/port/win.py:

(WinCairoPort):

7:50 PM Changeset in webkit [225769] by Darin Adler
  • 5 edits in trunk/Source/WebCore

Improve FontSelectionAlgorithm, including moving from IntegerHasher to Hasher
https://bugs.webkit.org/show_bug.cgi?id=180340

Reviewed by Dan Bates.

  • css/CSSFontFaceSet.h: Moved FontSelectionRequestKey and FontSelectionRequestKeyHash

here to be private members, and used a std::optional instead of a class for this.
Also use the new Hasher to compute the hash. Also added FontSelectionRequestKeyHashTraits.

  • platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::FontDescription): Updated since FontSelectionRequest
does not always have a constructor any more.

  • platform/graphics/FontSelectionAlgorithm.h: Tweaked comments. Used "using" instead

of typedef. Formatted some trivial functions as single lines. Stopped using
NeverDestroyed for simple classes like FontSelectionValue; it's not needed unless
there is a destructor. Got rid of some incorrect use of const. Replaced some member
functions with non-member functions. Moved some function bodies out of class definitions.
Used a lot of constexpr functions.
(WebCore::FontSelectionRequest::tied const): Added so we can easily write both == and the
hash function without listing the data members.
(WebCore::add): Added an overload so we can hash things that include FontSelectionRequest.
(WebCore::FontSelectionRequestKey::FontSelectionRequestKey): Changed this class to
use std::optional instead of a separate boolean for deleted values.
(WebCore::FontSelectionRequestKey::isHashTableDeletedValue const): Ditto.
(WebCore::FontSelectionRequestKey::operator== const): Ditto.
(WebCore::FontSelectionRequestKeyHash::hash): Ditto.
(WebCore::FontSelectionRequestKeyHash::equal): Ditto.
(WebCore::FontSelectionCapabilities::tied const): Added so we can easily write both ==
and the hash function without listing the data members.
(WebCore::FontSelectionSpecifiedCapabilities::tied const): Ditto.
(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm): Use make_unique instead of new.

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::findClosestFont): Move in the vector instead of copying it when creating a
FontSelectionAlgorithm object.

7:24 PM Changeset in webkit [225768] by sbarati@apple.com
  • 6 edits
    1 add in trunk

We need to disableCaching() in ErrorInstance when we materialize properties
https://bugs.webkit.org/show_bug.cgi?id=180343
<rdar://problem/35833002>

Reviewed by Mark Lam.

JSTests:

  • stress/disable-caching-when-lazy-materializing-error-property-on-put.js: Added.

(assert):
(makeError):
(storeToStack):
(storeToStackAlreadyMaterialized):

Source/JavaScriptCore:

This patch fixes a bug in ErrorInstance where we forgot to call PutPropertySlot::disableCaching
on puts() to a property that we lazily materialized. Forgetting to do this goes against the
PutPropertySlot's caching API. This lazy materialization caused the ErrorInstance to transition
from a Structure A to a Structure B. However, we were telling the IC that we were caching an
existing property only found on Structure B. This is obviously wrong as it would lead to an
OOB store if we didn't already crash when generating the IC.

  • jit/Repatch.cpp:

(JSC::tryCachePutByID):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::materializeErrorInfoIfNeeded):
(JSC::ErrorInstance::put):

  • runtime/ErrorInstance.h:
  • runtime/Structure.cpp:

(JSC::Structure::didCachePropertyReplacement):

6:45 PM Changeset in webkit [225767] by commit-queue@webkit.org
  • 4 edits in trunk

[WinCairo] DLLLauncherMain should use SetDllDirectory
https://bugs.webkit.org/show_bug.cgi?id=180642

Patch by Fujii Hironori <Fujii Hironori> on 2017-12-11
Reviewed by Alex Christensen.

Windows have icuuc.dll in the system directory. WebKit should find
one in WebKitLibraries directory, not one in the system directory.

Source/JavaScriptCore:

  • shell/DLLLauncherMain.cpp:

(modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.

Tools:

  • win/DLLLauncher/DLLLauncherMain.cpp:

(modifyPath): Use SetDllDirectory for WebKitLibraries directory instead of modifying path.
Do not add a path for GStreamer because nobody is using now.

5:17 PM Changeset in webkit [225766] by jer.noble@apple.com
  • 8 edits in trunk/Source/WebCore

[EME] support update() for FairPlayStreaming in Modern EME API
https://bugs.webkit.org/show_bug.cgi?id=180542

Reviewed by Eric Carlson.

Support the updateLicense() method in CDMInstanceFairPlayStreaming. Also, support adding a
AVStreamDataParser to the AVContentKeySession.

Drive-by fixes:

  • Sometimes, AVFoundation will give us a base64 encoded string with spaces url-disallowed

characters, so use base64Decode() rather than base64URLDecode().

  • platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::validFairPlayStreamingSchemes):
(WebCore::extractSinfData):

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstance const):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):

4:53 PM Changeset in webkit [225765] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Add a WKPageGroupRef setter in WKWebViewConfiguration
https://bugs.webkit.org/show_bug.cgi?id=180674
<rdar://problem/35920392>

Reviewed by Brady Eidson.

There is a Mac app trying to transition to WKWebView, and it uses WKPageGroupRef extensively.
To help it transition, we are temporarily giving it an ObjC way to use this organization for
its UserContentControllers to be united per PageGroup before it transitions away from SPIs like
WKBundleAddUserScript. Make it Mac-only to indicate that this should be transitioned away from,
rather than adopted on iOS.

No change in behavior for apps not using the new WKWebViewConfiguration._pageGroup SPI.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _pageGroup]):
(-[WKWebViewConfiguration _setPageGroup:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
4:41 PM Changeset in webkit [225764] by eric.carlson@apple.com
  • 31 edits in trunk

Web Inspector: Optionally log WebKit log parameters as JSON
https://bugs.webkit.org/show_bug.cgi?id=180529
<rdar://problem/35909462>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::ConsoleMessage): New constructor that takes a vector of JSON log
values. Concatenate all adjacent strings to make logging cleaner.
(Inspector::ConsoleMessage::addToFrontend): Process WebKit logging arguments.
(Inspector::ConsoleMessage::scriptState const):

  • inspector/ConsoleMessage.h:
  • inspector/InjectedScript.cpp:

(Inspector::InjectedScript::wrapJSONString const): Wrap JSON string log arguments.

  • inspector/InjectedScript.h:
  • inspector/InjectedScriptSource.js:

(let.InjectedScript.prototype.wrapJSONString):

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::didLogMessage):Update for API change. Don't check for main thread, that
is already done in addConsoleMessage.

  • dom/Document.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlayState): Cleanup logging.

  • html/track/DataCue.cpp:

(WebCore::DataCue::toJSONString const): Serialize to JSON string.
(WebCore::DataCue::toString const): Deleted.

  • html/track/DataCue.h:

(WTF::LogArgument<WebCore::DataCue>::toString):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::toJSON const): Ditto.
(WebCore::TextTrackCue::toJSONString const):
(WebCore::TextTrackCue::toString const): Deleted.

  • html/track/TextTrackCue.h:

(WTF::LogArgument<WebCore::TextTrackCue>::toString):

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::toJSONString const): Ditto.
(WebCore::TextTrackCueGeneric::toString const): Deleted.

  • html/track/TextTrackCueGeneric.h:

(WTF::LogArgument<WebCore::TextTrackCueGeneric>::toString):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::toJSONString const): Ditto.
(WebCore::VTTCue::toString const): Deleted.

  • html/track/VTTCue.h:

(WTF::LogArgument<WebCore::VTTCue>::toString):

  • platform/graphics/InbandTextTrackPrivateClient.h:

(WebCore::GenericCueData::toJSONString const): Ditto.
(WTF::LogArgument<WebCore::GenericCueData>::toString):
(WebCore::GenericCueData::toString const): Deleted.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processAttributedStrings): Cleanup logging.
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Ditto.
(WebCore::InbandTextTrackPrivateAVF::processNativeSamples): Log the entire cue.
(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer): Cleanup logging.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::maxMediaTimeSeekable const): Don't log, it isn't
interesting and happens frequently.
(WebCore::MediaPlayerPrivateAVFoundation::minMediaTimeSeekable const): Ditto.

  • platform/graphics/iso/ISOVTTCue.cpp:

(WebCore::ISOWebVTTCue::toJSONString const): Serialize to JSON string.

  • platform/graphics/iso/ISOVTTCue.h:

(WTF::LogArgument<WebCore::ISOWebVTTCue>::toString): Ditto.

Source/WTF:

  • wtf/Logger.h:

(WTF::Logger::log):
(WTF::LogArgument<Logger::LogSiteIdentifier>::toString):

  • wtf/MediaTime.cpp:

(WTF::MediaTime::toJSONString const): Serialize to JSON string.

  • wtf/MediaTime.h:

LayoutTests:

  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-webgl-expected.txt:
  • inspector/canvas/recording-webgl-snapshots-expected.txt:
4:39 PM Changeset in webkit [225763] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[iOS] Remove unused services from WebContent Process sandbox
https://bugs.webkit.org/show_bug.cgi?id=180670

Reviewed by Eric Carlson.

Pare down the set of sandbox exceptions in the iOS WebContent process sandbox to just
those services actually in use:

  1. Remove unused code.
  2. Instead of defining a 'UIKit-app' function and calling it, just declare the individual sandbox

commands inline. This will allow them to be more easily consolidated with other parts of the
sandbox in a future step.

This update should not change behavior.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
4:28 PM Changeset in webkit [225762] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove unused builtin names
https://bugs.webkit.org/show_bug.cgi?id=180673

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-12-11
Reviewed by Keith Miller.

  • builtins/BuiltinNames.h:
3:37 PM Changeset in webkit [225761] by commit-queue@webkit.org
  • 12 edits
    1 copy
    2 adds in trunk/Source

Use VCP H264 encoder for platforms supporting it
https://bugs.webkit.org/show_bug.cgi?id=179076
rdar://problem/35180773

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-11
Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

  • Configurations/libwebrtc.iOS.exp:
  • Configurations/libwebrtc.iOSsim.exp:
  • Configurations/libwebrtc.mac.exp:
  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.h: Added.

(webrtc::H264VideoToolboxEncoderVCP::SetActive):

  • Source/webrtc/sdk/objc/Framework/Classes/VideoProcessing/encoder_vcp.mm: Copied from Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm.
  • Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.mm:

(internal::CFStringToString):
(internal::SetVTSessionProperty):
(internal::CopyVideoFrameToPixelBuffer):
(internal::CreatePixelBuffer):
(internal::VTCompressionOutputCallback):
(internal::ExtractProfile):

  • Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.h:
  • Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.mm:

(webrtc::VideoToolboxVideoEncoderFactory::VideoToolboxVideoEncoderFactory):
(webrtc::VideoToolboxVideoEncoderFactory::CreateSupportedVideoEncoder):

  • libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Covered by existing test coverage.

  • platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.cpp:

(WebCore::VideoToolboxVideoEncoderFactory::setActive):
(WebCore::VideoToolboxVideoEncoderFactory::CreateSupportedVideoEncoder):
(WebCore::VideoToolboxVideoEncoderFactory::DestroyVideoEncoder):

  • platform/mediastream/libwebrtc/VideoToolBoxEncoderFactory.h:
3:24 PM Changeset in webkit [225760] by Chris Dumez
  • 35 edits
    1 delete in trunk/Source

Merge ServiceWorkerClientIdentifier into ServiceWorkerClientData
https://bugs.webkit.org/show_bug.cgi?id=180669

Reviewed by Youenn Fablet.

Merge ServiceWorkerClientIdentifier into ServiceWorkerClientData, for consistency with
ServiceWorkerIdentifier / ServiceWorkerData, and start simplifying the postMessage() code.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::setServiceWorkerConnection):

  • workers/service/SWClientConnection.h:
  • workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

  • workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::getOrCreate):
(WebCore::ServiceWorkerClient::ServiceWorkerClient):

  • workers/service/ServiceWorkerClient.h:

(WebCore::ServiceWorkerClient::identifier const):

  • workers/service/ServiceWorkerClientData.cpp:

(WebCore::ServiceWorkerClientData::isolatedCopy const):
(WebCore::ServiceWorkerClientData::from):

  • workers/service/ServiceWorkerClientData.h:

(WebCore::ServiceWorkerClientData::encode const):
(WebCore::ServiceWorkerClientData::decode):

  • workers/service/ServiceWorkerClientInformation.h: Removed.
  • workers/service/ServiceWorkerClients.cpp:

(WebCore::didFinishGetRequest):
(WebCore::ServiceWorkerClients::get):
(WebCore::matchAllCompleted):

  • workers/service/ServiceWorkerTypes.h:
  • workers/service/ServiceWorkerWindowClient.cpp:

(WebCore::ServiceWorkerWindowClient::ServiceWorkerWindowClient):

  • workers/service/ServiceWorkerWindowClient.h:
  • workers/service/context/SWContextManager.cpp:

(WebCore::SWContextManager::postMessageToServiceWorker):

  • workers/service/context/SWContextManager.h:
  • workers/service/context/ServiceWorkerThread.cpp:

(WebCore::ServiceWorkerThread::postMessageToServiceWorker):

  • workers/service/context/ServiceWorkerThread.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::findClientByIdentifier):
(WebCore::SWServer::matchAll):
(WebCore::SWServer::claim):
(WebCore::SWServer::registerServiceWorkerClient):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerToContextConnection.h:
  • workers/service/server/SWServerWorker.h:

Source/WebKit:

  • Scripts/webkit/messages.py:

(forward_declarations_and_headers):
(headers_for_type):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ServiceWorkerOrClientData>::encode):
(IPC::ArgumentCoder<ServiceWorkerOrClientData>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker):
(WebKit::WebSWServerConnection::registerServiceWorkerClient):
(WebKit::WebSWServerConnection::unregisterServiceWorkerClient):

  • StorageProcess/ServiceWorker/WebSWServerConnection.h:
  • StorageProcess/ServiceWorker/WebSWServerConnection.messages.in:
  • StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::matchAllCompleted):

  • StorageProcess/ServiceWorker/WebSWServerToContextConnection.h:
  • WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::registerServiceWorkerClient):
(WebKit::WebSWClientConnection::unregisterServiceWorkerClient):

  • WebProcess/Storage/WebSWClientConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::postMessageToServiceWorker):
(WebKit::WebSWContextManagerConnection::matchAllCompleted):

  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in:
3:23 PM Changeset in webkit [225759] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

RTCPacketOptions::packet_id should be encoded as 32 bits integer.
https://bugs.webkit.org/show_bug.cgi?id=180654

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-11
Reviewed by Eric Carlson.

packet_id is a 16 bit unsigned integer, but it can also take -1 if its value is not set.
Before the patch, it was IPC encoded as a 16 bit signed integer which is not large enough.

  • Shared/RTCPacketOptions.cpp:

(WebKit::RTCPacketOptions::encode const):
(WebKit::RTCPacketOptions::decode):

2:49 PM Changeset in webkit [225758] by Chris Dumez
  • 5 edits
    1 add in trunk

Layout Test http/tests/workers/service/postmessage-after-sw-process-crash.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=180659

Reviewed by Youenn Fablet.

Source/WebKit:

Fix flaky crash due to capturing an IPC::DataReference in a lambda, which would point to invalid
memory when the lambda is called asynchronously.

  • StorageProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerFromServiceWorker):

LayoutTests:

Rewrite test so that it is no longer flaky.

  • http/tests/workers/service/postmessage-after-sw-process-crash.https-expected.txt:
  • http/tests/workers/service/resources/postmessage-after-sw-process-crash-worker.js: Added.
  • http/tests/workers/service/resources/postmessage-after-sw-process-crash.js:
2:35 PM Changeset in webkit [225757] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the macOS Sierra build following r225179
(https://bugs.webkit.org/show_bug.cgi?id=180011)

Substitute TARGET_MAC_OS_X_VERSION_LESS_THAN_101300 for TARGET_MAC_OS_X_VERSION_LESS_THAN_1013000.

  • Configurations/WebCore.xcconfig:
2:27 PM Changeset in webkit [225756] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Make FrameView objects IsoHeap allocated
https://bugs.webkit.org/show_bug.cgi?id=180668
<rdar://problem/35976738>

Reviewed by Simon Fraser.

Related to <https://trac.webkit.org/changeset/225719/webkit>

  • page/FrameView.cpp:
  • page/FrameView.h:
1:29 PM Changeset in webkit [225755] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.17

Tag Safari-605.1.17.

1:25 PM Changeset in webkit [225754] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[iOS] Don't import 'UIKit-apps.sb' to the WebContent process sandbox
https://bugs.webkit.org/show_bug.cgi?id=180610
<rdar://problem/18899506>

Reviewed by Dean Jackson.

Stop including 'system.sb', and just include the portions of that sandbox that we
actually use in WebContent Process. This is the first step in some further sandbox
tightening.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
12:10 PM Changeset in webkit [225753] by timothy_horton@apple.com
  • 14 edits in trunk

Stop using deprecated target conditional for simulator builds
https://bugs.webkit.org/show_bug.cgi?id=180662
<rdar://problem/35136156>

Reviewed by Simon Fraser.

PerformanceTests:

  • StitchMarker/wtf/Platform.h:
  • StitchMarker/wtf/dependencies/bmalloc/BPlatform.h:

Source/bmalloc:

  • bmalloc/BPlatform.h:

Source/ThirdParty/libwebrtc:

  • Source/third_party/libyuv/source/mjpeg_decoder.cc:
  • Source/webrtc/examples/objc/AppRTCMobile/ARDAppClient.m:

(-[ARDAppClient createLocalVideoTrack]):

  • Source/webrtc/examples/objc/AppRTCMobile/tests/ARDAppClient_xctest.mm:
  • Source/webrtc/modules/audio_device/ios/audio_device_ios.mm:

(webrtc::LogDeviceInfo):

Source/WebKitLegacy/mac:

  • postprocess-headers.sh:

Source/WTF:

  • wtf/Platform.h:
11:41 AM Changeset in webkit [225752] by Antti Koivisto
  • 3 edits in trunk/PerformanceTests

StyleBench improvements
https://bugs.webkit.org/show_bug.cgi?id=180646

Reviewed by Geoffrey Garen.

  • Remove :empty rule from global stylesheet. It caused all tests to hit positional pseudo-class code paths.
  • Instead use min-width to create easy flexible layout. Use it for ::before/::after too.
  • Add :empty to positional pseudo-class test.
  • Include some id attributes and id selectors
  • Chance to have more than 1 classes per compound selector
  • Change distribution of elements and classes to be non-uniform
  • Other bug fixes
  • StyleBench/resources/style-bench.js:

(Random.prototype.numberSquareWeightedToLow):
(Random):
(defaultConfiguration):
(prototype.randomElementName):
(prototype.randomId):
(prototype.makeCompoundSelector):
(prototype.makeSelector):
(prototype.makeElement):

11:22 AM Changeset in webkit [225751] by Yusuke Suzuki
  • 5 edits in trunk/Source

[WTF] Add Converter traits to StringHasher instead of function pointer
https://bugs.webkit.org/show_bug.cgi?id=180656

Reviewed by JF Bastien.

Source/WebKit:

  • WebProcess/WebProcess.cpp:

(WebKit::addCaseFoldedCharacters):

Source/WTF:

In the latest ICU, UChar is char16_t. So defining defaultConverter(UChar)
and defaultConverter(char16_t) causes duplicate definitions.
Instead of passing a funtion pointer, we pass a trait class DefaultConveter
which has convert static function. And we make this convert function
generic. This avoids defining convert function for UChar and char16_t.

  • wtf/text/StringHash.h:

(WTF::ASCIICaseInsensitiveHash::FoldCase::convert):
(WTF::ASCIICaseInsensitiveHash::hash):
(WTF::ASCIICaseInsensitiveHash::foldCase): Deleted.

  • wtf/text/StringHasher.h:

(WTF::StringHasher::DefaultConverter::convert):
(WTF::StringHasher::addCharactersAssumingAligned):
(WTF::StringHasher::addCharacters):
(WTF::StringHasher::computeHashAndMaskTop8Bits):
(WTF::StringHasher::computeHash):
(WTF::StringHasher::computeLiteralHash):
(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
(WTF::StringHasher::computeHashImpl):
(WTF::StringHasher::Converter): Deleted.
(WTF::StringHasher::defaultConverter): Deleted.

11:19 AM Changeset in webkit [225750] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
https://bugs.webkit.org/show_bug.cgi?id=180647

Reviewed by Dean Jackson.

Actually fix Windows build this time.

  • animation/AnimationPlaybackEventInit.h:
10:56 AM Changeset in webkit [225749] by graouts@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
https://bugs.webkit.org/show_bug.cgi?id=180647
<rdar://problem/35966325>

Reviewed by Dean Jackson.

Unreviewed, fix Windows build.

  • animation/AnimationPlaybackEventInit.h:
10:23 AM Changeset in webkit [225748] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

FloatingObjects/FloatingObject classes should hold weak references to renderers
https://bugs.webkit.org/show_bug.cgi?id=180627
<rdar://problem/35954069>

Reviewed by Antti Koivisto.

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::FloatingObject):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatTypeValue>::heightRemaining const):
(WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::collectIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

  • rendering/FloatingObjects.h:

(WebCore::FloatingObject::renderer const):
(WebCore::FloatingObjects::renderer const):

10:09 AM Changeset in webkit [225747] by commit-queue@webkit.org
  • 17 edits in trunk

Turn on ENABLE_APPLICATION_MANIFEST
https://bugs.webkit.org/show_bug.cgi?id=180562
rdar://problem/35924737

Patch by David Quesada <david_quesada@apple.com> on 2017-12-11
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • loader/LinkLoader.cpp:

(WebCore::createLinkPreloadResourceClient):

  • loader/cached/CachedResourceRequest.cpp:

Add a missing #include that was implicitly added in the unified source when
the feature is disabled.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
10:07 AM Changeset in webkit [225746] by dino@apple.com
  • 11 edits
    2 adds in trunk

Add a runtime feature flag for ImageBitmap and OffscreenCanvas
https://bugs.webkit.org/show_bug.cgi?id=180652
<rdar://problem/35969611>

Reviewed by Antoine Quint.

Source/WebCore:

Add a RuntimeEnabledFeature for these interfaces, and link the bindings
to the feature.

Test: fast/canvas/offscreen-enabled.html

  • bindings/js/WebCoreBuiltinNames.h:
  • html/ImageBitmap.idl:
  • html/OffscreenCanvas.idl:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setImageBitmapOffscreenCanvasEnabled):
(WebCore::RuntimeEnabledFeatures::imageBitmapOffscreenCanvasEnabled const):

  • page/WindowOrWorkerGlobalScope.idl:

Source/WebKit:

Add an experimental feature flag for these interfaces.

  • Shared/WebPreferences.yaml:

Websites/webkit.org:

Simple test to validate if these interfaces are enabled.

  • experimental-features.html:

LayoutTests:

  • fast/canvas/offscreen-enabled-expected.txt: Added.
  • fast/canvas/offscreen-enabled.html: Added.
10:02 AM Changeset in webkit [225745] by graouts@webkit.org
  • 7 edits
    5 adds in trunk/Source/WebCore

[Web Animations] Implement AnimationPlaybackEvent and AnimationPlaybackEventInit
https://bugs.webkit.org/show_bug.cgi?id=180647
<rdar://problem/35966325>

Reviewed by Dean Jackson.

We implement the AnimationPlaybackEvent interface and AnimationPlaybackEventInit dictionary
as the first step towards dispatching animation "finish" and "cancel" events.

Animation playback events will be dispatched on Animation objects and expose the timeline time
and animation current time at the time they were constructed. Dispatch itself, which will be
the focus of the next patch, is not synchronous, so it's important to track those values
at creation time.

No new tests yet, followup patches will enable event dispatch and existing Web Platform Tests
will show progressions.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/AnimationPlaybackEvent.cpp: Added.

(WebCore::AnimationPlaybackEvent::AnimationPlaybackEvent):
(WebCore::AnimationPlaybackEvent::bindingsCurrentTime const):
(WebCore::AnimationPlaybackEvent::bindingsTimelineTime const):

  • animation/AnimationPlaybackEvent.h: Added.
  • animation/AnimationPlaybackEvent.idl: Added.
  • animation/AnimationPlaybackEventInit.h: Added.
  • animation/AnimationPlaybackEventInit.idl: Added.
  • bindings/js/WebCoreBuiltinNames.h:
  • dom/EventNames.in:
9:46 AM Changeset in webkit [225744] by Ms2ger@igalia.com
  • 2 edits
    12 adds in trunk/LayoutTests

[WPE] Enable most wpt html tests.
https://bugs.webkit.org/show_bug.cgi?id=180650

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt: Added: same as GTK; whitespace-only difference with the generic expectation file.
  • platform/wpe/imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt: Added: whitespace-only difference with the generic expectation file.
  • platform/wpe/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Added: some subtests pass because the plugin array does not contain any plugins on WPE, and issues with the actual elements of the array can not be detected.
9:38 AM Changeset in webkit [225743] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[WinCairo] DumpRenderTree times out for all non-http tests
https://bugs.webkit.org/show_bug.cgi?id=180571

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-12-11
Reviewed by Alex Christensen.

Bug fix on processing the curl event for file protocol.

No new tests. This fix is to run existing tests.

  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::completeDidReceiveResponse):

  • platform/network/curl/CurlRequest.h:

(WebCore::CurlRequest::isCompleted const):
(WebCore::CurlRequest::isCancelled const):
(WebCore::CurlRequest::isCompletedOrCancelled const):

2:16 AM Changeset in webkit [225742] by zandobersek@gmail.com
  • 5 edits
    7 deletes in trunk

Unreviewed, rolling out r225737.

Breaks Git clones of the repository, including EWSs and webkitbot.

Reverted changeset:

"Add a script to automate W3c web-platform-tests pull request
creations from WebKit commits"
https://bugs.webkit.org/show_bug.cgi?id=169462
https://trac.webkit.org/changeset/225737

1:11 AM Changeset in webkit [225741] by Manuel Rego Casasnovas
  • 7 edits in trunk

REGRESSION(r221931): Row stretch doesn't work for grid container with min-height
https://bugs.webkit.org/show_bug.cgi?id=180287

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-grid/grid-model/grid-box-sizing-001-expected.txt:

Update expectations as the test is now passing.

Source/WebCore:

In r221931 we moved the stretch phase as the last step of
the track sizing algorithm.
However this introduced a regression as we were no longer
taking into account the grid container min-width|height constraints
during this step.

The CSS WG modified the spec so it now defines what to do
in these situations (https://drafts.csswg.org/css-grid/#algo-stretch):

"If the free space is indefinite, but the grid container

has a definite min-width/height, use that size to calculate
the free space for this step instead."

This patch adds a new method
GridTrackSizingAlgorithmStrategy::freeSpaceForStretchAutoTracksStep().
When we're in the DefiniteSizeStrategy it just returns the current
free space.
For the IndefiniteSizeStrategy in the columns case we don't need
any special computation (the same that happens in
recomputeUsedFlexFractionIfNeeded()); for rows it uses the min size
of the grid container (respecting min-width|height properties)
to calculate the free space.

Test: imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/grid-stretch-respects-min-size-001.html

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::IndefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const):
(WebCore::DefiniteSizeStrategy::freeSpaceForStretchAutoTracksStep const):
(WebCore::GridTrackSizingAlgorithm::stretchAutoTracks):

  • rendering/GridTrackSizingAlgorithm.h:

LayoutTests:

from WPT is passing, so this patch removes it from TestExpectations file.

12:31 AM Changeset in webkit [225740] by Carlos Garcia Campos
  • 7 edits in trunk/Tools

[GTK] WebDriver: run-webdriver-tests is leaking a DumpRenderTree directory in tmp
https://bugs.webkit.org/show_bug.cgi?id=180426

Reviewed by Michael Catanzaro.

This happens when running the tests with Xvfb driver, because _setup_environ_for_test() is called twice and the
DTR temp directory is created there every time. Only the last directory created is cleaned up by the driver
destructor. The DRT temp directory is only needed for layout tests, so we could even avoid its creation by
moving it to the start() method like other drivers do (included the base driver implementation). Since API and
WebDriver tests don't call start(), the directory is not even created, and the required env vars are not set
either in that case. Weston driver was behaving differently for some reason, it's now consistent with all other
drivers.

  • Scripts/webkitpy/port/headlessdriver.py:

(HeadlessDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
(HeadlessDriver._start): Use Port._driver_tempdir() to create the driver temp directory.

  • Scripts/webkitpy/port/waylanddriver.py:

(WaylandDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
(WaylandDriver._start): Use Port._driver_tempdir() to create the driver temp directory.

  • Scripts/webkitpy/port/westondriver.py:

(WestonDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
(WestonDriver._start): Use Port._driver_tempdir() to create the driver temp directory.
(WestonDriver.stop): Do not delete the temp directory, it's done by the parent class.
(WestonDriver._ensure_driver_tmpdir_subdirectory): Deleted.

  • Scripts/webkitpy/port/westondriver_unittest.py:

(WestonDriverTest.make_driver):
(WestonDriverTest.test_stop):

  • Scripts/webkitpy/port/xorgdriver.py:

(XorgDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
(XorgDriver._start): Use Port._driver_tempdir() to create the driver temp directory.

  • Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._setup_environ_for_test): Do not set DUMPRENDERTREE_TEMP and XDG_CACHE_HOME if _driver_tempdir is None.
(XvfbDriver._start): Use Port._driver_tempdir() to create the driver temp directory.

12:30 AM Changeset in webkit [225739] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

WebDriver: get active element should return no such element error when there isn't an active element
https://bugs.webkit.org/show_bug.cgi?id=180421

Reviewed by Brian Burg.

We currently return unknown error.

Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element

  • Session.cpp:

(WebDriver::Session::getActiveElement):

Dec 10, 2017:

11:55 PM Changeset in webkit [225738] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed webkitpy fix on Linux platforms after r225721.

Add an empty 'linux' entry to the PUBLIC_TABLE mapping in the
VersionNameMap class. This avoids asserting in this class's
mapping_for_platform() method when the code is evaluated on a Linux
system, which happens when the static VERSION_FALLBACK_ORDER member in
the WinCairoPort class is constructed. This can occur during a
test-webkitpy run or when trying to construct a WPEPort instance in
PortFactory, which isn't possible because again the WinCairoPort
instance is constructed first, leading to the same assert in both cases.

  • Scripts/webkitpy/common/version_name_map.py:

(VersionNameMap.init):

9:04 PM Changeset in webkit [225737] by commit-queue@webkit.org
  • 4 edits
    1 copy
    6 adds in trunk/Tools

Add a script to automate W3c web-platform-tests pull request creations from WebKit commits
https://bugs.webkit.org/show_bug.cgi?id=169462

Patch by Youenn Fablet <youenn@apple.com> on 2017-12-10
Reviewed by Darin Adler.

Adding some git helper routines used by WPT exporter.
Copying WPT github utility files from Chromium.
Updating web.py/web_mock.py to cope with these new files.

Implementing test exporter in test_exporter.py.
This script takes a WebKit commit as input and will create a WPT commit in a local WPT clone.
It will then push the commit to a public GitHub repository identified by a username parameter.
This parameter is passed through the command line or searched through git config/environment variables.

The script can optionally create a pull request to the official WPT GitHub repository.
User must provide a GitHub token to allow the script to make the PR on behalf of the user.
In that case, a comment is added to the corresponding bugzilla if a bug ID is given or can be found from the change log,
to easily link the pull request with the bugzilla bug.

  • Scripts/export-w3c-test-changes: Added.
  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.reset_hard):
(Git):
(Git.am):
(Git.commit):
(Git.format_patch):
(Git.request_pull):
(Git.remote):
(Git.push):
(Git.checkout_new_branch):

  • Scripts/webkitpy/common/net/web.py:

(Web.request): Copied from Chromium.

  • Scripts/webkitpy/common/net/web_mock.py: Copied needed code from Chromium.
  • Scripts/webkitpy/w3c/test_exporter.py: Added.

(TestExporter):
(TestExporter.init):
(TestExporter._init_repository):
(TestExporter.download_and_commit_patch):
(TestExporter.clean):
(TestExporter.create_branch_with_patch):
(TestExporter.push_to_public_repository):
(TestExporter.make_pull_request):
(TestExporter.delete_local_branch):
(TestExporter.create_git_patch):
(TestExporter.create_upload_remote_if_needed):
(TestExporter.do_export):
(parse_args):
(configure_logging):
(configure_logging.LogHandler):
(configure_logging.LogHandler.format):
(main):

  • Scripts/webkitpy/w3c/test_exporter_unittest.py: Added.

(TestExporterTest):
(TestExporterTest.MockBugzilla):
(TestExporterTest.MockBugzilla.init):
(TestExporterTest.MockBugzilla.fetch_bug_dictionary):
(TestExporterTest.MockBugzilla.post_comment_to_bug):
(TestExporterTest.MockGit):
(TestExporterTest.MockGit.clone):
(TestExporterTest.MockGit.init):
(TestExporterTest.MockGit.fetch):
(TestExporterTest.MockGit.checkout):
(TestExporterTest.MockGit.reset_hard):
(TestExporterTest.MockGit.push):
(TestExporterTest.MockGit.format_patch):
(TestExporterTest.MockGit.delete_branch):
(TestExporterTest.MockGit.checkout_new_branch):
(TestExporterTest.MockGit.am):
(TestExporterTest.MockGit.commit):
(TestExporterTest.MockGit.remote):
(TestExporterTest.test_export):

  • Scripts/webkitpy/w3c/common.py: Copied from chromium.
  • Scripts/webkitpy/w3c/wpt_github.py: Copied from chromium.
  • Scripts/webkitpy/w3c/wpt_github_mock.py: Copied from chromium.
  • Scripts/webkitpy/w3c/wpt_github_unittest.py: Copied from chromium.
7:10 PM Changeset in webkit [225736] by commit-queue@webkit.org
  • 10 edits
    2 adds
    2 deletes in trunk

Incorrect bounds inside <mover>/<munder> when a stretchy operator is present
https://bugs.webkit.org/show_bug.cgi?id=179682

Patch by Minsheng Liu <lambda@liu.ms> on 2017-12-10
Reviewed by Frédéric Wang.

Source/WebCore:

Currently a stretchy operator inside <mover>/<munder>/<munderover> is stretched
during paint() rather than layout(), which leads to both end user confusion
and many unexpected behaviors. This patch rewrites
RenderMathMLUnderOver::stretchHorizontalOperatorsAndLayoutChildren()
to both eliminate the issue and make operator stretching more standard
conforming.

A test is added to check the stretch width of stretchy operators in various
scenarios:
mathml/opentype/munderover-stretch-width.html

A previous test is updated:
mathml/opentype/opentype-stretchy-horizontal.html

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchTo):
(WebCore::RenderMathMLOperator::resetStretchSize):
(WebCore::RenderMathMLOperator::paint):

  • rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::setStretchWidthLocked):
(WebCore::RenderMathMLOperator::isStretchWidthLocked const):

  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::toHorizontalStretchyOperator):
(WebCore::fixLayoutAfterStretch):
(WebCore::RenderMathMLUnderOver::stretchHorizontalOperatorsAndLayoutChildren):

LayoutTests:

Added test case: mathml/opentype/munderover-stretch-width.html

Updated test case: mathml/opentype/opentype-stretchy-horizontal
We update the test file to make sure the stretchy <mo> has zero lspace/rspace.
Expected results for macOS and iOS are included.

  • mathml/opentype/munderover-stretch-width-expected.txt: Added.
  • mathml/opentype/munderover-stretch-width.html: Added.
  • mathml/opentype/opentype-stretchy-horizontal.html:
  • platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Removed.
  • platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.png:
  • platform/ios/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.png:
  • platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Removed.
5:32 PM Changeset in webkit [225735] by Yusuke Suzuki
  • 2 edits in trunk/Source/WTF

[WTF] Reduce sizeof(Thread) by adjusting alignment
https://bugs.webkit.org/show_bug.cgi?id=180630

Reviewed by Saam Barati.

Reduce sizeof(Thread) slightly by adjusting alignment.

  • wtf/Threading.h:
5:10 PM Changeset in webkit [225734] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Harden a few assertions in GC sweep
https://bugs.webkit.org/show_bug.cgi?id=180634

Reviewed by Saam Barati.

This turns one dynamic check into a release assertion and upgrades another assertion to a release
assertion.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::sweep):

1:11 PM Changeset in webkit [225733] by Konstantin Tokarev
  • 84 edits in trunk

[python] Modernize "except" usage for python3 compatibility
https://bugs.webkit.org/show_bug.cgi?id=180612

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

  • inspector/scripts/generate-inspector-protocol-bindings.py:

Tools:

  • BuildSlaveSupport/build.webkit.org-config/committer_auth.py:

(CommitterAuth.auth_json):
(CommitterAuth.authenticate):
(CommitterAuth.is_webkit_committer):
(CommitterAuth.is_webkit_trac_user):

  • BuildSlaveSupport/wait-for-SVN-server.py:

(getLatestSVNRevision):

  • QueueStatusServer/handlers/updatebase.py:

(UpdateBase._int_from_request):

  • Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_from_idl):
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.detect_changes):

  • Scripts/webkitpy/codegen/main.py:

(BuiltinsGeneratorTests.generate_from_js_builtins):
(BuiltinsGeneratorTests.detect_changes):

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLog.parse_latest_entry_from_file):

  • Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.bug_id_for_this_commit):

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.in_working_directory):
(Git.clone):
(Git._string_to_int_or_none):
(Git._commit_on_branch):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.revisions_changing_file):

  • Scripts/webkitpy/common/config/committers.py:

(CommitterList.load_json):

  • Scripts/webkitpy/common/message_pool.py:

(_Worker.run):

  • Scripts/webkitpy/common/net/buildbot/buildbot.py:

(Builder.force_build.predicate):
(Builder._fetch_revision_to_build_map):
(BuildBot._fetch_build_dictionary):

  • Scripts/webkitpy/common/net/credentials.py:

(Credentials._credentials_from_git):

  • Scripts/webkitpy/common/net/networktransaction.py:

(NetworkTransaction.run):

  • Scripts/webkitpy/common/net/networktransaction_unittest.py:

(NetworkTransactionTest.test_exception):
(NetworkTransactionTest.test_timeout):

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._fetch_url):

  • Scripts/webkitpy/common/net/unittestresults.py:

(UnitTestResults.results_from_string):

  • Scripts/webkitpy/common/prettypatch.py:

(PrettyPatch.check_pretty_patch):
(PrettyPatch.pretty_patch_text):

  • Scripts/webkitpy/common/prettypatch_unittest.py:

(PrettyPatchTest.check_ruby):

  • Scripts/webkitpy/common/system/autoinstall.py:

(AutoInstaller._extract_tar):
(AutoInstaller._unzip):
(AutoInstaller._replace_domain_with_next_mirror):
(AutoInstaller._download_to_stream):
(AutoInstaller.install):

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs._find_newest_log_darwin):
(CrashLogs._find_newest_log_win):
(CrashLogs._find_all_logs_darwin):

  • Scripts/webkitpy/common/system/executive.py:

(Executive.kill_process):
(Executive.running_pids):

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.maybe_make_directory):
(FileSystem.remove):

  • Scripts/webkitpy/common/system/user.py:

(User._wait_on_list_response):
(User.edit):
(User.page):
(User.can_open_url):

  • Scripts/webkitpy/common/system/workspace.py:

(Workspace.create_zip):

  • Scripts/webkitpy/common/watchlist/watchlistparser.py:

(WatchListParser._parse_definition_section):

  • Scripts/webkitpy/common/webkitunittest.py:

(TestCase._assertRaisesRegexp):

  • Scripts/webkitpy/inspector/main.py:

(InspectorGeneratorTests.generate_from_json):
(InspectorGeneratorTests.detect_changes):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder._read_test_names_from_file):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.upload_results):

  • Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:

(JSONResultsGenerator.upload_json_files):
(JSONResultsGenerator._get_archived_json_results):

  • Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:

(MiscTests.test_parse_warning):
(SemanticTests.test_bad_bugid):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

  • Scripts/webkitpy/layout_tests/servers/http_server.py:

(Lighttpd._remove_stale_logs):

  • Scripts/webkitpy/layout_tests/servers/http_server_base.py:

(HttpServerBase._is_running_on_port):
(HttpServerBase._check_that_all_ports_are_available):

  • Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:

(BaseTest.assert_servers_are_down):
(BaseTest.assert_servers_are_up):
(BaseTest.integration_test_serverfails):
(BaseTest.maybe_make_dir):

  • Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:

(run_server):

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
  • Scripts/webkitpy/layout_tests/servers/websocket_server.py:

(PyWebSocket.is_running):
(PyWebSocket._remove_stale_logs):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_merge_slave_config_json):
(_merge_outputs_if_needed):
(_upload_json):

  • Scripts/webkitpy/port/base.py:

(Port._build_driver):
(Port._build_image_diff):
(Port._symbols_string):

  • Scripts/webkitpy/port/leakdetector.py:

(LeakDetector.count_total_bytes_and_unique_leaks):
(LeakDetector.check_for_leaks):

  • Scripts/webkitpy/port/leakdetector_valgrind.py:

(LeakDetectorValgrind._parse_leaks_output):

  • Scripts/webkitpy/port/mac.py:

(MacPort.reset_preferences):
(MacPort.stop_helper):

  • Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.assert_servers_are_down):
(PortTestCase.assert_servers_are_up):
(PortTestCase.integration_test_http_serverfails):
(PortTestCase.integration_test_websocket_server
fails):

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess.write):
(ServerProcess._wait_for_data_and_update_buffers_using_select):
(ServerProcess._non_blocking_read_win32):

  • Scripts/webkitpy/port/win.py:

(WinPort._runtime_feature_list):

  • Scripts/webkitpy/port/xvfbdriver.py:

(XvfbDriver._xvfb_read_display_id):

  • Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONChecker.check):

  • Scripts/webkitpy/style/checkers/xml.py:

(XMLChecker.check):

  • Scripts/webkitpy/style/filereader.py:

(TextFileReader.process_file):

  • Scripts/webkitpy/style/filereader_unittest.py:

(TextFileReaderTest.test_process_filedoes_not_exist):

  • Scripts/webkitpy/style/optparser.py:

(ArgumentParser.parse):

  • Scripts/webkitpy/tool/bot/irc_command.py:

(CreateBug.execute):
(Rollout.execute):

  • Scripts/webkitpy/tool/bot/ircbot.py:

(IRCBot.process_message):

  • Scripts/webkitpy/tool/bot/layouttestresultsreader.py:

(LayoutTestResultsReader._read_file_contents):

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._run_command):

  • Scripts/webkitpy/tool/bot/queueengine.py:

(QueueEngine.run):

  • Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:

(AbstractSequencedCommand.execute):

  • Scripts/webkitpy/tool/commands/download.py:

(AbstractPatchSequencingCommand._prepare_to_process):

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.review_patch):

  • Scripts/webkitpy/tool/commands/queries.py:

(FailureReason._blame_line_for_revision):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue._cc_watchers):
(AbstractQueue.run_webkit_patch):
(CommitQueue.process_work_item):
(StyleQueue.review_patch):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractParallelRebaselineCommand._run_webkit_patch):

  • Scripts/webkitpy/tool/commands/stepsequence.py:

(StepSequence.run_and_handle_errors):

  • Scripts/webkitpy/tool/commands/suggestnominations.py:

(SuggestNominations._count_recent_patches):

  • Scripts/webkitpy/tool/multicommandtool.py:

(MultiCommandTool.main):

  • Scripts/webkitpy/tool/servers/rebaselineserver.py:

(_rebaseline_test):
(_move_test_baselines):

  • Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:

(AddSvnMimetypeForPngTest.test_run):

  • Scripts/webkitpy/tool/steps/checkstyle.py:

(CheckStyle.run):

  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._check_test_expectations):
(Commit.run):

  • Scripts/webkitpy/tool/steps/confirmdiff.py:

(ConfirmDiff._show_pretty_diff):

  • Scripts/webkitpy/tool/steps/haslanded.py:

(HasLanded.diff_diff):

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.run):

  • Scripts/webkitpy/tool/steps/promptforbugortitle.py:

(PromptForBugOrTitle.run):

  • Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py:

(SortXcodeProjectFiles.run):

  • Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:

(WebDriverW3CWebServer._wait_for_server.check_port):

  • TestResultServer/model/datastorefile.py:

(DataStoreFile.save_data):

  • jhbuild/jhbuildutils.py:

(enter_jhbuild_environment_if_available):

8:47 AM Changeset in webkit [225732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

APIClient.h uses things from <tuple> without including it explicitly
https://bugs.webkit.org/show_bug.cgi?id=180609

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-12-10
Reviewed by Darin Adler.

  • Shared/API/APIClient.h:
5:14 AM Changeset in webkit [225731] by Yusuke Suzuki
  • 4 edits in trunk/Source/WebCore

Unreviewed, follow-up patch after r225470
https://bugs.webkit.org/show_bug.cgi?id=180308

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::checkAndHandleClosedDatabase):
Use consistent operands.

  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::JSCallbackData):
Use class field initializer.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::openFunc):
Use consistent operands.

5:00 AM Changeset in webkit [225730] by Yusuke Suzuki
  • 2 edits in trunk/Source/WTF

Unreviewed, follow-up patch after r225726
https://bugs.webkit.org/show_bug.cgi?id=180622

Suggested by Darin. We should take care of signed-extension of char.

  • wtf/text/StringHasher.h:

(WTF::StringHasher::defaultConverter):

Dec 9, 2017:

6:53 PM Changeset in webkit [225729] by Darin Adler
  • 1 edit
    2 adds in trunk/LayoutTests

Add test demonstrating leaks that happen when we create reference cycles with DOM objects
https://bugs.webkit.org/show_bug.cgi?id=180323

Reviewed by Filip Pizlo.

  • fast/dom/reference-cycle-leaks-expected.txt: Added.
  • fast/dom/reference-cycle-leaks.html: Added.
1:42 PM Changeset in webkit [225728] by Yusuke Suzuki
  • 4 edits in trunk/Source/WTF

[WTF] Remove RELAXED_CONSTEXPR
https://bugs.webkit.org/show_bug.cgi?id=180624

Reviewed by JF Bastien.

All of our required compilers support relaxed constexpr in C++14.
We can drop RELAXED_CONSTEXPR macro in our tree.

  • wtf/Compiler.h:
  • wtf/Expected.h:

(std::experimental::fundamentals_v3::expected::operator*):
(std::experimental::fundamentals_v3::expected::value):
(std::experimental::fundamentals_v3::expected::error):

  • wtf/Unexpected.h:

(std::experimental::fundamentals_v3::unexpected::value):
(std::experimental::fundamentals_v3::unexpected::value const):

12:34 PM Changeset in webkit [225727] by Yusuke Suzuki
  • 4 edits in trunk

Fix WTF::Hasher tuple expansion with variadic args
https://bugs.webkit.org/show_bug.cgi?id=180623

Reviewed by JF Bastien.

Source/WTF:

We expand a tuple with ..., and use this in a function's argument list.
And in this argument list, we call add() for each value. This will be
expanded as follows.

[] (...) { }((add(hasher, std::get<i>(values)), 0)...);

will become,

[] (...) { }((add(hasher, std::get<0>(values)), 0), (add(hasher, std::get<1>(values)), 0), ...);

However, the evaluation order of the C++ argument is unspecified. Actually,
in GCC environment, this add() is not called in our expected order. As a
result, currently we have test failures in TestWTF.

This patch just uses variadic templates to expand tuples, and call add() in
our expected order. This patch fixes an existing failure of TestWTF in GCC environment.

  • wtf/Hasher.h:

(WTF::Hasher::computeHash):
(WTF::addArgs):
(WTF::addTupleHelper):
(WTF::add):

Tools:

  • TestWebKitAPI/Tests/WTF/Hasher.cpp:

(TestWebKitAPI::TEST):

12:11 PM Changeset in webkit [225726] by Yusuke Suzuki
  • 2 edits in trunk/Source/WTF

Use relaxed constexpr for StringHasher
https://bugs.webkit.org/show_bug.cgi?id=180622

Reviewed by JF Bastien.

Now VC++ is updated and all the WebKit compilers support C++14 relaxed constexpr.
This patch uses relaxed constexpr for StringHasher constexpr implementation

  • wtf/text/StringHasher.h:

(WTF::StringHasher::addCharactersAssumingAligned):
(WTF::StringHasher::Converter):
(WTF::StringHasher::computeHashAndMaskTop8Bits):
(WTF::StringHasher::computeHash):
(WTF::StringHasher::computeLiteralHash):
(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
(WTF::StringHasher::defaultConverter):
(WTF::StringHasher::avalancheBits):
(WTF::StringHasher::finalize):
(WTF::StringHasher::finalizeAndMaskTop8Bits):
(WTF::StringHasher::avoidZero):
(WTF::StringHasher::calculateWithRemainingLastCharacter):
(WTF::StringHasher::calculateWithTwoCharacters):
(WTF::StringHasher::processPendingCharacter const):
(WTF::StringHasher::StringHasher): Deleted.
(WTF::StringHasher::avalancheBits3): Deleted.
(WTF::StringHasher::avalancheBits2): Deleted.
(WTF::StringHasher::avalancheBits1): Deleted.
(WTF::StringHasher::avalancheBits0): Deleted.
(WTF::StringHasher::calculateWithRemainingLastCharacter1): Deleted.
(WTF::StringHasher::calculateWithRemainingLastCharacter0): Deleted.
(WTF::StringHasher::calculate1): Deleted.
(WTF::StringHasher::calculate0): Deleted.
(WTF::StringHasher::calculate): Deleted.
(WTF::StringHasher::computeLiteralHashImpl): Deleted.

11:48 AM Changeset in webkit [225725] by fpizlo@apple.com
  • 11 edits
    4 adds in trunk/Source/JavaScriptCore

InferredType should not use UnconditionalFinalizer
https://bugs.webkit.org/show_bug.cgi?id=180456

Reviewed by Saam Barati.

This turns InferredStructure into a cell so that we can unconditionally finalize them without
having to add things to the UnconditionalFinalizer list. I'm removing all uses of
UnconditionalFinalizers and WeakReferenceHarvesters because the data structures used to manage
them are a top cause of lock contention in the parallel GC. Also, we don't need those data
structures if we use IsoSubspaces, subspace iteration, and marking constraints.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • heap/Heap.cpp:

(JSC::Heap::finalizeUnconditionalFinalizers):

  • heap/Heap.h:
  • runtime/InferredStructure.cpp: Added.

(JSC::InferredStructure::create):
(JSC::InferredStructure::destroy):
(JSC::InferredStructure::createStructure):
(JSC::InferredStructure::visitChildren):
(JSC::InferredStructure::finalizeUnconditionally):
(JSC::InferredStructure::InferredStructure):
(JSC::InferredStructure::finishCreation):

  • runtime/InferredStructure.h: Added.
  • runtime/InferredStructureWatchpoint.cpp: Added.

(JSC::InferredStructureWatchpoint::fireInternal):

  • runtime/InferredStructureWatchpoint.h: Added.
  • runtime/InferredType.cpp:

(JSC::InferredType::visitChildren):
(JSC::InferredType::willStoreValueSlow):
(JSC::InferredType::makeTopSlow):
(JSC::InferredType::set):
(JSC::InferredType::removeStructure):
(JSC::InferredType::InferredStructureWatchpoint::fireInternal): Deleted.
(JSC::InferredType::InferredStructureFinalizer::finalizeUnconditionally): Deleted.
(JSC::InferredType::InferredStructure::InferredStructure): Deleted.

  • runtime/InferredType.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
8:58 AM Changeset in webkit [225724] by Konstantin Tokarev
  • 14 edits in trunk

[python] Replace print >> operator with print() function for python3 compatibility
https://bugs.webkit.org/show_bug.cgi?id=180611

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

  • Scripts/make-js-file-arrays.py:

(main):

Tools:

  • CygwinDownloader/cygwin-downloader.py:

(download_url_to_file):

  • Scripts/webkitpy/common/system/profiler.py:

(Perf.profile_after_exit):

  • Scripts/webkitpy/common/version_check.py:
  • Scripts/webkitpy/layout_tests/lint_test_expectations.py:

(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

  • Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:

(run_server):

  • Scripts/webkitpy/tool/commands/analyzechangelog.py:

(ChangeLogAnalyzer._print_status):

  • Scripts/webkitpy/tool/commands/queries.py:

(BugsToCommit.execute):
(PatchesInCommitQueue.execute):
(PatchesToCommitQueue.execute):
(PatchesToReview._print_report):
(WhatBroke._print_builder_line):
(WhatBroke._print_blame_information_for_builder):
(WhatBroke.execute):
(ResultsFor._print_layout_test_results):
(ResultsFor.execute):
(FailureReason._print_blame_information_for_transition):
(FailureReason._explain_failures_for_builder):
(FailureReason._builder_to_explain):
(FailureReason.execute):
(FindFlakyTests._find_failures):
(FindFlakyTests._print_statistics):
(FindFlakyTests._walk_backwards_from):
(execute):
(PrintExpectations.execute):
(PrintBaselines.execute):
(PrintBaselines._print_baselines):
(FindResolvedBugs.execute):

  • Scripts/webkitpy/tool/commands/rebaseline.py:

(AbstractParallelRebaselineCommand._run_webkit_patch):
(AbstractParallelRebaselineCommand._rebaseline):

  • Scripts/webkitpy/tool/servers/gardeningserver.py:

(GardeningHTTPRequestHandler.rebaselineall):

  • Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:

(GardeningServerTest.disabled_test_rebaselineall.run_command):
(GardeningServerTest):

2:41 AM Changeset in webkit [225723] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

iOS: Crash in Document::updateLayout() via Document::processViewport
https://bugs.webkit.org/show_bug.cgi?id=180619
<rdar://problem/35717575>

Reviewed by Zalan Bujtas.

Source/WebCore:

The crash is caused by modern media controls updating the layout in the middle of insertedIntoAncestor
via HTMLMediaElement::setControllerJSProperty inside Document::pageScaleFactorChangedAndStable.

Fixed the crash by delaying the work to update the viewport configuration until didFinishInsertingNode
since updating the viewport configuration results in a lot of related code running in response,
and making sure all that code never tries to execute an author script is not attainable in the short term,
and a maintenance nightmare in the long term.

Test: media/ios/viewport-change-with-video.html

  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::insertedIntoAncestor):
(WebCore::HTMLMetaElement::didFinishInsertingNode): Added.

  • html/HTMLMetaElement.h:

LayoutTests:

Added a regression test for the crash.

  • media/ios/viewport-change-with-video-expected.txt: Added.
  • media/ios/viewport-change-with-video.html: Added.
Note: See TracTimeline for information about the timeline view.