Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Dec 23, 2019:

6:34 PM Changeset in webkit [253897] by Simon Fraser

• 2 edits in trunk/Source/WebCore

REGRESSION (r253634): Reproducible crash going back and forward on goodreads.com in Page::setPageScaleFactor
​https://bugs.webkit.org/show_bug.cgi?id=205569

Reviewed by Wenson Hsieh.

When going quickly back and forward, WebPage::didCommitLoad/WebPage::viewportConfigurationChanged/WebPage::scalePage
can be called for a page in the page cache, so the FrameView can be null.

Null-check the view here like the surrounding code does.

• page/Page.cpp:

(WebCore::Page::setPageScaleFactor):

5:49 PM Changeset in webkit [253896] by keith_miller@apple.com

• 183 edits
  2 copies
  5 adds in trunk

DFG/FTL should be able to exit to the middle of a bytecode
​https://bugs.webkit.org/show_bug.cgi?id=205232

Reviewed by Saam Barati.

JSTests:

• stress/apply-osr-exit-should-get-length-once-exceptions-occasionally.js: Added.

(expectedArgCount):
(callee):
(test):
(let.array.get length):

• stress/apply-osr-exit-should-get-length-once.js: Added.

(expectedArgCount):
(callee):
(test):
(let.array.get length):

• stress/load-varargs-then-inlined-call-and-exit-strict.js:

(checkEqual):

• stress/recursive-tail-call-with-different-argument-count.js:
• stress/rest-varargs-osr-exit-to-checkpoint.js: Added.

(foo):
(bar):

Source/JavaScriptCore:

It can be valuable to exit to the middle of a bytecode for a couple of reasons.
1) It can be used to combine bytecodes that share a majority of their operands, reducing bytecode steam size.
2) It enables creating bytecodes that are easier to reconstruct useful optimization information from.

To make exiting to the middle of a bytecode possible this patch
introduces the concept of a temporary operand. A temporary operand
is one that contains the result of effectful operations during the
process of executing a bytecode. tmp operands have no meaning when
executing in the LLInt or Baseline and are only used in the DFG to
preserve information for OSR exit. We use the term checkpoint to
refer to any point where an effectful component of a bytecode executes.
For example, in op_call_varargs there are two checkpoints the first is
before we have determined the number of variable arguments and the second
is the actual call.

When the DFG OSR exits if there are any active checkpoints inline
call stack we will emit a jit probe that allocates a side state
object keyed off the frame pointer of the bytecode whose
checkpoint needs to be finished. We need side state because we may
recursively inline several copies of the same
function. Alternatively, we could call back into ourselves after
OSR and exit again from optimized code before finishing the
checkpoint of our caller.

Another thing we need to be careful of is making sure we remove
side state as we unwind for an exception. To make sure we do this
correctly I've added an assertion to JSLock that there are no
pending checkpoint side states on the vm when releasing the lock.

A large amount of this patch is trying to remove as much code that
refers to virtual registers as an int as possible. Instead, this
patch replaces them with the VirtualRegister class. There are also
a couple of new classes/enums added to JSC:

1) There is now a class, Operand, that represents the combination
of a VirtualRegister and a temporary. This is handy in the DFG to
model OSR exit values all together. Additionally, Operands<T> has
been updated to work with respect to Operand values.

2) CallFrameSlot is now an enum class instead of a struct of
constexpr values. This lets us implicitly convert CallFrameSlots
to VirtualRegisters without allowing all ints to implicity
convert.

3) FTL::SelectPredictability is a new enum that describes to the
FTL whether or not we think a select is going to be
predictable. SelectPredictability has four options: Unpredictable,
Predictable, LeftLikely, and RightLikely. Unpredictable means we
think a branch predictor won't do a good job guessing this value
so we should compile the select to a cmov. The other options mean
we either think we are going to pick the same value every time or
there's a reasonable chance the branch predictor will be able to
guess the value.

In order to validate the correctness of this patch the various
varargs call opcodes have been reworked to use checkpoints. This
also fixed a long-standing issue where we could call length
getters twice if we OSR exit during LoadVarargs but before the
actually call.

Lastly, we have not enabled the probe-based OSR exit for a long
time in production, thus this patch removes that code since it
would be a non-trivial amount of work to get checkpoints working
with probe OSR.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• JavaScriptCore.xcodeproj/project.pbxproj:
• assembler/MacroAssemblerCodeRef.h:
• assembler/ProbeFrame.h:

(JSC::Probe::Frame::operand):
(JSC::Probe::Frame::setOperand):

• b3/testb3.h:

(populateWithInterestingValues):
(floatingPointOperands):

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/AccessCaseSnippetParams.cpp:

(JSC::SlowPathCallGeneratorWithArguments::generateImpl):

• bytecode/BytecodeDumper.cpp:

(JSC::BytecodeDumperBase::dumpValue):
(JSC::BytecodeDumper<Block>::registerName const):
(JSC::BytecodeDumper<Block>::constantName const):
(JSC::Wasm::BytecodeDumper::constantName const):

• bytecode/BytecodeDumper.h:
• bytecode/BytecodeIndex.cpp:

(JSC::BytecodeIndex::dump const):

• bytecode/BytecodeIndex.h:

(JSC::BytecodeIndex::BytecodeIndex):
(JSC::BytecodeIndex::offset const):
(JSC::BytecodeIndex::checkpoint const):
(JSC::BytecodeIndex::asBits const):
(JSC::BytecodeIndex::hash const):
(JSC::BytecodeIndex::operator bool const):
(JSC::BytecodeIndex::pack):
(JSC::BytecodeIndex::fromBits):

• bytecode/BytecodeList.rb:
• bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::enumValuesEqualAsIntegral):
(JSC::tmpLivenessForCheckpoint):

• bytecode/BytecodeLivenessAnalysis.h:
• bytecode/BytecodeLivenessAnalysisInlines.h:

(JSC::virtualRegisterIsAlwaysLive):
(JSC::virtualRegisterThatIsNotAlwaysLiveIsLive):
(JSC::virtualRegisterIsLive):
(JSC::operandIsAlwaysLive): Deleted.
(JSC::operandThatIsNotAlwaysLiveIsLive): Deleted.
(JSC::operandIsLive): Deleted.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::bytecodeIndexForExit const):
(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeIndexSlow):
(JSC::CodeBlock::updateAllValueProfilePredictionsAndCountLiveness):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::numTmps const):
(JSC::CodeBlock::isKnownNotImmediate):
(JSC::CodeBlock::isTemporaryRegister):
(JSC::CodeBlock::constantRegister):
(JSC::CodeBlock::getConstant const):
(JSC::CodeBlock::constantSourceCodeRepresentation const):
(JSC::CodeBlock::replaceConstant):
(JSC::CodeBlock::isTemporaryRegisterIndex): Deleted.
(JSC::CodeBlock::isConstantRegisterIndex): Deleted.

• bytecode/CodeOrigin.h:
• bytecode/FullBytecodeLiveness.h:

(JSC::FullBytecodeLiveness::virtualRegisterIsLive const):
(JSC::FullBytecodeLiveness::operandIsLive const): Deleted.

• bytecode/InlineCallFrame.h:

(JSC::InlineCallFrame::InlineCallFrame):
(JSC::InlineCallFrame::setTmpOffset):
(JSC::CodeOrigin::walkUpInlineStack const):
(JSC::CodeOrigin::inlineStackContainsActiveCheckpoint const):
(JSC::remapOperand):
(JSC::unmapOperand):
(JSC::CodeOrigin::walkUpInlineStack): Deleted.

• bytecode/LazyOperandValueProfile.h:

(JSC::LazyOperandValueProfileKey::LazyOperandValueProfileKey):
(JSC::LazyOperandValueProfileKey::hash const):
(JSC::LazyOperandValueProfileKey::operand const):

• bytecode/MethodOfGettingAValueProfile.cpp:

(JSC::MethodOfGettingAValueProfile::fromLazyOperand):
(JSC::MethodOfGettingAValueProfile::emitReportValue const):
(JSC::MethodOfGettingAValueProfile::reportValue):

• bytecode/MethodOfGettingAValueProfile.h:
• bytecode/Operands.h:

(JSC::Operand::Operand):
(JSC::Operand::tmp):
(JSC::Operand::kind const):
(JSC::Operand::value const):
(JSC::Operand::virtualRegister const):
(JSC::Operand::asBits const):
(JSC::Operand::isTmp const):
(JSC::Operand::isArgument const):
(JSC::Operand::isLocal const):
(JSC::Operand::isHeader const):
(JSC::Operand::isConstant const):
(JSC::Operand::toArgument const):
(JSC::Operand::toLocal const):
(JSC::Operand::operator== const):
(JSC::Operand::isValid const):
(JSC::Operand::fromBits):
(JSC::Operands::Operands):
(JSC::Operands::numberOfLocals const):
(JSC::Operands::numberOfTmps const):
(JSC::Operands::tmpIndex const):
(JSC::Operands::argumentIndex const):
(JSC::Operands::localIndex const):
(JSC::Operands::tmp):
(JSC::Operands::tmp const):
(JSC::Operands::argument):
(JSC::Operands::argument const):
(JSC::Operands::local):
(JSC::Operands::local const):
(JSC::Operands::sizeFor const):
(JSC::Operands::atFor):
(JSC::Operands::atFor const):
(JSC::Operands::ensureLocals):
(JSC::Operands::ensureTmps):
(JSC::Operands::getForOperandIndex):
(JSC::Operands::getForOperandIndex const):
(JSC::Operands::operandIndex const):
(JSC::Operands::operand):
(JSC::Operands::operand const):
(JSC::Operands::hasOperand const):
(JSC::Operands::setOperand):
(JSC::Operands::at const):
(JSC::Operands::at):
(JSC::Operands::operator[] const):
(JSC::Operands::operator[]):
(JSC::Operands::operandForIndex const):
(JSC::Operands::operator== const):
(JSC::Operands::isArgument const): Deleted.
(JSC::Operands::isLocal const): Deleted.
(JSC::Operands::virtualRegisterForIndex const): Deleted.
(JSC::Operands::setOperandFirstTime): Deleted.

• bytecode/OperandsInlines.h:

(JSC::Operand::dump const):
(JSC::Operands<T>::dumpInContext const):
(JSC::Operands<T>::dump const):

• bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::hasCheckpoints const):
(JSC::UnlinkedCodeBlock::setHasCheckpoints):
(JSC::UnlinkedCodeBlock::constantRegister const):
(JSC::UnlinkedCodeBlock::getConstant const):
(JSC::UnlinkedCodeBlock::isConstantRegisterIndex const): Deleted.

• bytecode/ValueProfile.h:

(JSC::ValueProfileAndVirtualRegisterBuffer::ValueProfileAndVirtualRegisterBuffer):
(JSC::ValueProfileAndVirtualRegisterBuffer::~ValueProfileAndVirtualRegisterBuffer):
(JSC::ValueProfileAndOperandBuffer::ValueProfileAndOperandBuffer): Deleted.
(JSC::ValueProfileAndOperandBuffer::~ValueProfileAndOperandBuffer): Deleted.
(JSC::ValueProfileAndOperandBuffer::forEach): Deleted.

• bytecode/ValueRecovery.cpp:

(JSC::ValueRecovery::recover const):

• bytecode/ValueRecovery.h:
• bytecode/VirtualRegister.h:

(JSC::virtualRegisterIsLocal):
(JSC::virtualRegisterIsArgument):
(JSC::VirtualRegister::VirtualRegister):
(JSC::VirtualRegister::isValid const):
(JSC::VirtualRegister::isLocal const):
(JSC::VirtualRegister::isArgument const):
(JSC::VirtualRegister::isConstant const):
(JSC::VirtualRegister::toConstantIndex const):
(JSC::operandIsLocal): Deleted.
(JSC::operandIsArgument): Deleted.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::initializeParameters):
(JSC::BytecodeGenerator::emitEqualityOpImpl):
(JSC::BytecodeGenerator::emitCallVarargs):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::setUsesCheckpoints):

• bytecompiler/RegisterID.h:

(JSC::RegisterID::setIndex):

• dfg/DFGAbstractHeap.cpp:

(JSC::DFG::AbstractHeap::Payload::dumpAsOperand const):
(JSC::DFG::AbstractHeap::dump const):

• dfg/DFGAbstractHeap.h:

(JSC::DFG::AbstractHeap::Payload::Payload):
(JSC::DFG::AbstractHeap::AbstractHeap):
(JSC::DFG::AbstractHeap::operand const):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGArgumentPosition.h:

(JSC::DFG::ArgumentPosition::dump):

• dfg/DFGArgumentsEliminationPhase.cpp:
• dfg/DFGArgumentsUtilities.cpp:

(JSC::DFG::argumentsInvolveStackSlot):
(JSC::DFG::emitCodeToGetArgumentsArrayLength):

• dfg/DFGArgumentsUtilities.h:
• dfg/DFGAtTailAbstractState.h:

(JSC::DFG::AtTailAbstractState::operand):

• dfg/DFGAvailabilityMap.cpp:

(JSC::DFG::AvailabilityMap::pruneByLiveness):

• dfg/DFGAvailabilityMap.h:

(JSC::DFG::AvailabilityMap::closeStartingWithLocal):

• dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureTmps):

• dfg/DFGBasicBlock.h:
• dfg/DFGBlockInsertionSet.cpp:

(JSC::DFG::BlockInsertionSet::insert):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::ensureTmps):
(JSC::DFG::ByteCodeParser::progressToNextCheckpoint):
(JSC::DFG::ByteCodeParser::newVariableAccessData):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::injectLazyOperandSpeculation):
(JSC::DFG::ByteCodeParser::getLocalOrTmp):
(JSC::DFG::ByteCodeParser::setLocalOrTmp):
(JSC::DFG::ByteCodeParser::setArgument):
(JSC::DFG::ByteCodeParser::findArgumentPositionForLocal):
(JSC::DFG::ByteCodeParser::findArgumentPosition):
(JSC::DFG::ByteCodeParser::flushImpl):
(JSC::DFG::ByteCodeParser::flushForTerminalImpl):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::addFlushOrPhantomLocal):
(JSC::DFG::ByteCodeParser::phantomLocalDirect):
(JSC::DFG::ByteCodeParser::flushForTerminal):
(JSC::DFG::ByteCodeParser::addToGraph):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand const):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::DelayedSetLocal):
(JSC::DFG::ByteCodeParser::DelayedSetLocal::execute):
(JSC::DFG::ByteCodeParser::allocateTargetableBlock):
(JSC::DFG::ByteCodeParser::allocateUntargetableBlock):
(JSC::DFG::ByteCodeParser::handleRecursiveTailCall):
(JSC::DFG::ByteCodeParser::inlineCall):
(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::ByteCodeParser::getLocal): Deleted.
(JSC::DFG::ByteCodeParser::setLocal): Deleted.

• dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::injectOSR):

• dfg/DFGCPSRethreadingPhase.cpp:

(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSet):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):

• dfg/DFGCSEPhase.cpp:
• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGCombinedLiveness.cpp:

(JSC::DFG::addBytecodeLiveness):

• dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::addUniqueCallSiteIndex):
(JSC::DFG::CommonData::lastCallSite const):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGForAllKills.h:

(JSC::DFG::forAllKilledOperands):
(JSC::DFG::forAllKilledNodesAtNodeIndex):
(JSC::DFG::forAllKillsInBlock):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::substituteGetLocal):
(JSC::DFG::Graph::isLiveInBytecode):
(JSC::DFG::Graph::localsAndTmpsLiveInBytecode):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
(JSC::DFG::Graph::localsLiveInBytecode): Deleted.

• dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsAndTmpsLiveInBytecode):
(JSC::DFG::Graph::forAllLiveInBytecode):
(JSC::DFG::Graph::forAllLocalsLiveInBytecode): Deleted.

• dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::InPlaceAbstractState):

• dfg/DFGInPlaceAbstractState.h:

(JSC::DFG::InPlaceAbstractState::operand):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::noticeOSREntry):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitStoreCallSiteIndex):

• dfg/DFGLiveCatchVariablePreservationPhase.cpp:

(JSC::DFG::LiveCatchVariablePreservationPhase::isValidFlushLocation):
(JSC::DFG::LiveCatchVariablePreservationPhase::handleBlockForTryCatch):
(JSC::DFG::LiveCatchVariablePreservationPhase::newVariableAccessData):

• dfg/DFGMovHintRemovalPhase.cpp:
• dfg/DFGNode.h:

(JSC::DFG::StackAccessData::StackAccessData):
(JSC::DFG::Node::hasArgumentsChild):
(JSC::DFG::Node::argumentsChild):
(JSC::DFG::Node::operand):
(JSC::DFG::Node::hasUnlinkedOperand):
(JSC::DFG::Node::unlinkedOperand):
(JSC::DFG::Node::hasLoadVarargsData):
(JSC::DFG::Node::local): Deleted.
(JSC::DFG::Node::hasUnlinkedLocal): Deleted.
(JSC::DFG::Node::unlinkedLocal): Deleted.

• dfg/DFGNodeType.h:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

• dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):
(JSC::DFG::prepareCatchOSREntry):

• dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::emitRestoreArguments):
(JSC::DFG::OSRExit::compileExit):
(JSC::DFG::jsValueFor): Deleted.
(JSC::DFG::restoreCalleeSavesFor): Deleted.
(JSC::DFG::saveCalleeSavesFor): Deleted.
(JSC::DFG::restoreCalleeSavesFromVMEntryFrameCalleeSavesBuffer): Deleted.
(JSC::DFG::copyCalleeSavesToVMEntryFrameCalleeSavesBuffer): Deleted.
(JSC::DFG::saveOrCopyCalleeSavesFor): Deleted.
(JSC::DFG::createDirectArgumentsDuringExit): Deleted.
(JSC::DFG::createClonedArgumentsDuringExit): Deleted.
(JSC::DFG::emitRestoreArguments): Deleted.
(JSC::DFG::OSRExit::executeOSRExit): Deleted.
(JSC::DFG::reifyInlinedCallFrames): Deleted.
(JSC::DFG::adjustAndJumpToTarget): Deleted.
(JSC::DFG::printOSRExit): Deleted.

• dfg/DFGOSRExit.h:
• dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::isExitingToCheckpointHandler const):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::callerReturnPC):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::adjustAndJumpToTarget):

• dfg/DFGObjectAllocationSinkingPhase.cpp:
• dfg/DFGOpInfo.h:

(JSC::DFG::OpInfo::OpInfo):

• dfg/DFGOperations.cpp:
• dfg/DFGPhantomInsertionPhase.cpp:
• dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::read):
(JSC::DFG::PreciseLocalClobberizeAdaptor::write):
(JSC::DFG::PreciseLocalClobberizeAdaptor::def):
(JSC::DFG::PreciseLocalClobberizeAdaptor::callIfAppropriate):

• dfg/DFGPredictionInjectionPhase.cpp:

(JSC::DFG::PredictionInjectionPhase::run):

• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGPutStackSinkingPhase.cpp:
• dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::compileVarargsLength):
(JSC::DFG::SpeculativeJIT::compileLoadVarargs):
(JSC::DFG::SpeculativeJIT::compileForwardVarargs):
(JSC::DFG::SpeculativeJIT::compileCreateDirectArguments):
(JSC::DFG::SpeculativeJIT::compileGetArgumentCountIncludingThis):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::recordSetLocal):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):
(JSC::DFG::StackLayoutPhase::assign):

• dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

• dfg/DFGThunks.cpp:

(JSC::DFG::osrExitThunkGenerator): Deleted.

• dfg/DFGThunks.h:
• dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):

• dfg/DFGValidate.cpp:
• dfg/DFGVarargsForwardingPhase.cpp:
• dfg/DFGVariableAccessData.cpp:

(JSC::DFG::VariableAccessData::VariableAccessData):
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
(JSC::DFG::VariableAccessData::tallyVotesForShouldUseDoubleFormat):
(JSC::DFG::VariableAccessData::couldRepresentInt52Impl):

• dfg/DFGVariableAccessData.h:

(JSC::DFG::VariableAccessData::operand):
(JSC::DFG::VariableAccessData::local): Deleted.

• dfg/DFGVariableEvent.cpp:

(JSC::DFG::VariableEvent::dump const):

• dfg/DFGVariableEvent.h:

(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::spillRegister const):
(JSC::DFG::VariableEvent::operand const):
(JSC::DFG::VariableEvent::bytecodeRegister const): Deleted.

• dfg/DFGVariableEventStream.cpp:

(JSC::DFG::VariableEventStream::logEvent):
(JSC::DFG::VariableEventStream::reconstruct const):

• dfg/DFGVariableEventStream.h:

(JSC::DFG::VariableEventStream::appendAndLog):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLForOSREntryJITCode.cpp:

(JSC::FTL::ForOSREntryJITCode::ForOSREntryJITCode):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileExtractOSREntryLocal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetStack):
(JSC::FTL::DFG::LowerDFGToB3::compileGetCallee):
(JSC::FTL::DFG::LowerDFGToB3::compileSetCallee):
(JSC::FTL::DFG::LowerDFGToB3::compileSetArgumentCountIncludingThis):
(JSC::FTL::DFG::LowerDFGToB3::compileVarargsLength):
(JSC::FTL::DFG::LowerDFGToB3::compileLoadVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):
(JSC::FTL::DFG::LowerDFGToB3::getSpreadLengthFromInlineCallFrame):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargsWithSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileLogShadowChickenPrologue):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):
(JSC::FTL::DFG::LowerDFGToB3::getCurrentCallee):
(JSC::FTL::DFG::LowerDFGToB3::callPreflight):
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToB3::buildExitArguments):
(JSC::FTL::DFG::LowerDFGToB3::addressFor):
(JSC::FTL::DFG::LowerDFGToB3::payloadFor):
(JSC::FTL::DFG::LowerDFGToB3::tagFor):

• ftl/FTLOSREntry.cpp:

(JSC::FTL::prepareOSREntry):

• ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):

• ftl/FTLOSRExit.h:
• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

• ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

• ftl/FTLOutput.cpp:

(JSC::FTL::Output::select):

• ftl/FTLOutput.h:
• ftl/FTLSelectPredictability.h: Copied from Source/JavaScriptCore/ftl/FTLForOSREntryJITCode.cpp.
• ftl/FTLSlowPathCall.h:

(JSC::FTL::callOperation):

• generator/Checkpoints.rb: Added.
• generator/Opcode.rb:
• generator/Section.rb:
• heap/Heap.cpp:

(JSC::Heap::gatherStackRoots):

• interpreter/CallFrame.cpp:

(JSC::CallFrame::callSiteAsRawBits const):
(JSC::CallFrame::unsafeCallSiteAsRawBits const):
(JSC::CallFrame::callSiteIndex const):
(JSC::CallFrame::unsafeCallSiteIndex const):
(JSC::CallFrame::setCurrentVPC):
(JSC::CallFrame::bytecodeIndex):
(JSC::CallFrame::codeOrigin):

• interpreter/CallFrame.h:

(JSC::CallSiteIndex::CallSiteIndex):
(JSC::CallSiteIndex::operator bool const):
(JSC::CallSiteIndex::operator== const):
(JSC::CallSiteIndex::bits const):
(JSC::CallSiteIndex::fromBits):
(JSC::CallSiteIndex::bytecodeIndex const):
(JSC::DisposableCallSiteIndex::DisposableCallSiteIndex):
(JSC::CallFrame::callee const):
(JSC::CallFrame::unsafeCallee const):
(JSC::CallFrame::addressOfCodeBlock const):
(JSC::CallFrame::argumentCountIncludingThis const):
(JSC::CallFrame::offsetFor):
(JSC::CallFrame::setArgumentCountIncludingThis):
(JSC::CallFrame::setReturnPC):

• interpreter/CallFrameInlines.h:

(JSC::CallFrame::r):
(JSC::CallFrame::uncheckedR):
(JSC::CallFrame::guaranteedJSValueCallee const):
(JSC::CallFrame::jsCallee const):
(JSC::CallFrame::codeBlock const):
(JSC::CallFrame::unsafeCodeBlock const):
(JSC::CallFrame::setCallee):
(JSC::CallFrame::setCodeBlock):

• interpreter/CheckpointOSRExitSideState.h: Copied from Source/JavaScriptCore/dfg/DFGThunks.h.
• interpreter/Interpreter.cpp:

(JSC::eval):
(JSC::sizeOfVarargs):
(JSC::loadVarargs):
(JSC::setupVarargsFrame):
(JSC::UnwindFunctor::operator() const):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

• interpreter/Interpreter.h:
• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readInlinedFrame):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitGetFromCallFrameHeaderPtr):
(JSC::AssemblyHelpers::emitGetFromCallFrameHeader32):
(JSC::AssemblyHelpers::emitGetFromCallFrameHeader64):
(JSC::AssemblyHelpers::emitPutToCallFrameHeader):
(JSC::AssemblyHelpers::emitPutToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::emitPutPayloadToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::emitPutTagToCallFrameHeaderBeforePrologue):
(JSC::AssemblyHelpers::addressFor):
(JSC::AssemblyHelpers::tagFor):
(JSC::AssemblyHelpers::payloadFor):
(JSC::AssemblyHelpers::calleeFrameSlot):
(JSC::AssemblyHelpers::calleeArgumentSlot):
(JSC::AssemblyHelpers::calleeFrameTagSlot):
(JSC::AssemblyHelpers::calleeFramePayloadSlot):
(JSC::AssemblyHelpers::calleeFrameCallerFrame):
(JSC::AssemblyHelpers::argumentCount):

• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::CallFrameShuffler):

• jit/CallFrameShuffler.h:

(JSC::CallFrameShuffler::setCalleeJSValueRegs):
(JSC::CallFrameShuffler::assumeCalleeIsCell):

• jit/JIT.h:
• jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_unsigned):
(JSC::JIT::emit_compareAndJump):
(JSC::JIT::emit_compareAndJumpImpl):
(JSC::JIT::emit_compareUnsignedAndJump):
(JSC::JIT::emit_compareUnsignedAndJumpImpl):
(JSC::JIT::emit_compareUnsigned):
(JSC::JIT::emit_compareUnsignedImpl):
(JSC::JIT::emit_compareAndJumpSlow):
(JSC::JIT::emit_compareAndJumpSlowImpl):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitBitBinaryOpFastPath):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emitRightShiftFastPath):
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
(JSC::JIT::emit_op_div):

• jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileOpCall):

• jit/JITExceptions.cpp:

(JSC::genericUnwind):

• jit/JITInlines.h:

(JSC::JIT::isOperandConstantDouble):
(JSC::JIT::getConstantOperand):
(JSC::JIT::emitPutIntToCallFrameHeader):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):
(JSC::JIT::linkSlowCaseIfNotJSCell):
(JSC::JIT::isOperandConstantChar):
(JSC::JIT::getOperandConstantInt):
(JSC::JIT::getOperandConstantDouble):
(JSC::JIT::emitInitRegister):
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitGet):
(JSC::JIT::emitPutVirtualRegister):
(JSC::JIT::emitLoad):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitLoadDouble):
(JSC::JIT::emitLoadInt32ToDouble):
(JSC::JIT::emitStore):
(JSC::JIT::emitStoreInt32):
(JSC::JIT::emitStoreCell):
(JSC::JIT::emitStoreBool):
(JSC::JIT::emitStoreDouble):
(JSC::JIT::emitJumpSlowCaseIfNotJSCell):
(JSC::JIT::isOperandConstantInt):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitGetVirtualRegisters):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_end):
(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emit_op_is_empty):
(JSC::JIT::emit_op_is_undefined):
(JSC::JIT::emit_op_is_undefined_or_null):
(JSC::JIT::emit_op_is_boolean):
(JSC::JIT::emit_op_is_number):
(JSC::JIT::emit_op_is_cell_with_type):
(JSC::JIT::emit_op_is_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_set_function_name):
(JSC::JIT::emit_op_not):
(JSC::JIT::emit_op_jfalse):
(JSC::JIT::emit_op_jeq_null):
(JSC::JIT::emit_op_jneq_null):
(JSC::JIT::emit_op_jundefined_or_null):
(JSC::JIT::emit_op_jnundefined_or_null):
(JSC::JIT::emit_op_jneq_ptr):
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_jeq):
(JSC::JIT::emit_op_jtrue):
(JSC::JIT::emit_op_neq):
(JSC::JIT::emit_op_jneq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::compileOpStrictEqJump):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_to_numeric):
(JSC::JIT::emit_op_to_string):
(JSC::JIT::emit_op_to_object):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_get_parent_scope):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
(JSC::JIT::emit_op_enter):
(JSC::JIT::emit_op_get_scope):
(JSC::JIT::emit_op_to_this):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emit_op_check_tdz):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_instanceof_custom):
(JSC::JIT::emit_op_new_regexp):
(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_array):
(JSC::JIT::emit_op_new_array_with_size):
(JSC::JIT::emit_op_has_structure_property):
(JSC::JIT::emit_op_has_indexed_property):
(JSC::JIT::emitSlow_op_has_indexed_property):
(JSC::JIT::emit_op_get_direct_pname):
(JSC::JIT::emit_op_enumerator_structure_pname):
(JSC::JIT::emit_op_enumerator_generic_pname):
(JSC::JIT::emit_op_profile_type):
(JSC::JIT::emit_op_log_shadow_chicken_prologue):
(JSC::JIT::emit_op_log_shadow_chicken_tail):
(JSC::JIT::emit_op_argument_count):
(JSC::JIT::emit_op_get_rest_length):
(JSC::JIT::emit_op_get_argument):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_catch):

• jit/JITOperations.cpp:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emitSlow_op_put_by_val):
(JSC::JIT::emit_op_put_getter_by_id):
(JSC::JIT::emit_op_put_setter_by_id):
(JSC::JIT::emit_op_put_getter_setter_by_id):
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_try_get_by_id):
(JSC::JIT::emitSlow_op_try_get_by_id):
(JSC::JIT::emit_op_get_by_id_direct):
(JSC::JIT::emitSlow_op_get_by_id_direct):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_id_with_this):
(JSC::JIT::emitSlow_op_get_by_id):
(JSC::JIT::emitSlow_op_get_by_id_with_this):
(JSC::JIT::emit_op_put_by_id):
(JSC::JIT::emit_op_in_by_id):
(JSC::JIT::emitSlow_op_in_by_id):
(JSC::JIT::emitResolveClosure):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emitLoadWithStructureCheck):
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emitPutGlobalVariableIndirect):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emit_op_get_from_arguments):
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emitWriteBarrier):
(JSC::JIT::emit_op_get_internal_field):
(JSC::JIT::emit_op_put_internal_field):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

• jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::emitLoadJSCell):
(JSC::JSInterfaceJIT::emitJumpIfNotJSCell):
(JSC::JSInterfaceJIT::emitLoadInt32):
(JSC::JSInterfaceJIT::emitLoadDouble):
(JSC::JSInterfaceJIT::emitGetFromCallFrameHeaderPtr):
(JSC::JSInterfaceJIT::emitPutToCallFrameHeader):
(JSC::JSInterfaceJIT::emitPutCellToCallFrameHeader):

• jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::loadDoubleArgument):
(JSC::SpecializedThunkJIT::loadCellArgument):
(JSC::SpecializedThunkJIT::loadInt32Argument):

• jit/ThunkGenerators.cpp:

(JSC::absThunkGenerator):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::getNonConstantOperand):
(JSC::LLInt::getOperand):
(JSC::LLInt::genericCall):
(JSC::LLInt::varargsSetup):
(JSC::LLInt::commonCallEval):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleVarargsCheckpoint):
(JSC::LLInt::dispatchToNextInstruction):
(JSC::LLInt::slow_path_checkpoint_osr_exit_from_inlined_call):
(JSC::LLInt::slow_path_checkpoint_osr_exit):
(JSC::LLInt::llint_throw_stack_overflow_error):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::fill):

• runtime/CachedTypes.cpp:

(JSC::CachedCodeBlock::hasCheckpoints const):
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::CachedCodeBlock<CodeBlockType>::encode):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/ConstructData.cpp:

(JSC::construct):

• runtime/ConstructData.h:
• runtime/DirectArguments.cpp:

(JSC::DirectArguments::copyToArguments):

• runtime/DirectArguments.h:
• runtime/GenericArguments.h:
• runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::copyToArguments):

• runtime/JSArray.cpp:

(JSC::JSArray::copyToArguments):

• runtime/JSArray.h:
• runtime/JSImmutableButterfly.cpp:

(JSC::JSImmutableButterfly::copyToArguments):

• runtime/JSImmutableButterfly.h:
• runtime/JSLock.cpp:

(JSC::JSLock::willReleaseLock):

• runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::create):

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):

• runtime/ScopedArguments.cpp:

(JSC::ScopedArguments::copyToArguments):

• runtime/ScopedArguments.h:
• runtime/VM.cpp:

(JSC::VM::addCheckpointOSRSideState):
(JSC::VM::findCheckpointOSRSideState):
(JSC::VM::scanSideState const):

• runtime/VM.h:

(JSC::VM::hasCheckpointOSRSideState const):

• tools/VMInspector.cpp:

(JSC::VMInspector::dumpRegisters):

• wasm/WasmFunctionCodeBlock.h:

(JSC::Wasm::FunctionCodeBlock::getConstant const):
(JSC::Wasm::FunctionCodeBlock::getConstantType const):

• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::setUsesCheckpoints const):

• wasm/WasmOperations.cpp:

(JSC::Wasm::operationWasmToJSException):

• wasm/WasmSlowPaths.cpp:

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/Bitmap.h:

(WTF::WordType>::invert):
(WTF::WordType>::operator):
(WTF::WordType>::operator const const):

• wtf/CMakeLists.txt:
• wtf/EnumClassOperatorOverloads.h: Added.
• wtf/FastBitVector.h:

(WTF::FastBitReference::operator bool const):
(WTF::FastBitReference::operator|=):
(WTF::FastBitReference::operator&=):
(WTF::FastBitVector::fill):
(WTF::FastBitVector::grow):

• wtf/UnalignedAccess.h:

(WTF::unalignedLoad):
(WTF::unalignedStore):

Tools:

• Scripts/run-jsc-stress-tests:

5:11 PM Changeset in webkit [253895] by ysuzuki@apple.com

• 5 edits
  1 add in trunk

[JSC] Wasm OSR entry should capture top-most enclosing-stack
​https://bugs.webkit.org/show_bug.cgi?id=205571

Reviewed by Keith Miller.

JSTests:

• wasm/stress/top-most-enclosing-stack.js: Added.

Source/JavaScriptCore:

OSR entry should capture the top-most enclosing-stack too.
Otherwise the def-node can be unreachable (since it is defined in BB which is unreachable from OSR entry point),
and eliminated.

• wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::AirIRGenerator::addLoop):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::emitLoopTierUpCheck):
(JSC::Wasm::B3IRGenerator::addLoop):

• wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::addLoop):

5:03 PM Changeset in webkit [253894] by Andres Gonzalez

• 3 edits in trunk/Source/WebCore

IsolatedObject implementation of property setters.
​https://bugs.webkit.org/show_bug.cgi?id=205566

Reviewed by Chris Fleizach.

• Implementation of setters that need to be executed in the main

thread.

• Sanity check of the associatedAXObject() before calling corresponding

method on main thread.

• accessibility/isolatedtree/AXIsolatedTreeNode.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::performFunctionOnMainThread):
(WebCore::AXIsolatedObject::setARIAGrabbed):
(WebCore::AXIsolatedObject::setIsExpanded):
(WebCore::AXIsolatedObject::setValue):
(WebCore::AXIsolatedObject::setSelected):
(WebCore::AXIsolatedObject::setSelectedRows):
(WebCore::AXIsolatedObject::setFocused):
(WebCore::AXIsolatedObject::setSelectedText):
(WebCore::AXIsolatedObject::setSelectedTextRange):
(WebCore::AXIsolatedObject::setCaretBrowsingEnabled):
(WebCore::AXIsolatedObject::setPreventKeyboardDOMEventDispatch):
(WebCore::AXIsolatedObject::findTextRanges const):
(WebCore::AXIsolatedObject::performTextOperation):
(WebCore::AXIsolatedObject::widget const):
(WebCore::AXIsolatedObject::document const):
(WebCore::AXIsolatedObject::documentFrameView const):

• accessibility/isolatedtree/AXIsolatedTreeNode.h:

4:32 PM Changeset in webkit [253893] by dbates@webkit.org

• 5 edits
  3 adds in trunk

REGRESSION (r212693): getClientRects(), getBoundingClientRect() for range that spans multi-lines differs depending on whether text is selected
​https://bugs.webkit.org/show_bug.cgi?id=205527
<rdar://problem/58128278>

Reviewed by Zalan Bujtas.

Source/WebCore:

Include empty rect when range start position coincides with the end of a simple line layout run.
This makes it match the behavior of line box layout, Firefox's behavior, as well as my understanding
of Extensions to the Range Interface: <​https://drafts.csswg.org/cssom-view/#extensions-to-the-range-interface>
(Editor's Draft, 10 October 2019).

At the time of writing, there are two code paths for laying out lines: simple line layout and
line box layout. Simple line layout is not enabled when there is a selection at the time of
writing. As a result, we use line box layout to answer getClientRects(), getBoundingClientRect()
queries.

Test: fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection.html

• rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::rangeForRendererWithOffsets const): Do not skip over a run
if its end position coincides with the range's start offset. This ensures that we emit an empty rect
for this part of the box selection, which matches what we do using the analagous line box layout
code path.

LayoutTests:

For now, add a Mac-specific test. This test is specific to Mac because it depends on text metrics for the
Times font. I specifically did not use Ahem so that this test could also be used as the test for
<​https://bugs.webkit.org/show_bug.cgi?id=205563>. Currently the test includes expected failure results
since that bug is not fixed.

• TestExpectations: Skip
• fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection-expected.txt: Added.
• fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection.html: Added.
• platform/mac/TestExpectations: Unskip the test on Mac.

3:27 PM Changeset in webkit [253892] by ap@apple.com

• 2 edits in trunk/LayoutTests

Remove TestExpectations for scrollingcoordinator/ios/fixed-scrolling-with-keyboard.html
​https://bugs.webkit.org/show_bug.cgi?id=202283

This test has been passing lately.

• platform/ios/TestExpectations:

3:22 PM Changeset in webkit [253891] by ap@apple.com

• 2 edits in trunk/LayoutTests

Add TestExpectations for http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
​https://bugs.webkit.org/show_bug.cgi?id=197673

• TestExpectations:

2:40 PM Changeset in webkit [253890] by Kocsen Chung

• 1 copy in tags/Safari-609.1.13.2

Tag Safari-609.1.13.2.

12:21 PM Changeset in webkit [253889] by ap@apple.com

• 2 edits in trunk/Source/WebKit

watchOS build fix attempt

Not sure what broke the build, seems like UserInterfaceIdiom.h used to be included
via unified build, and no longer is. Added the include.

While at it, removed an ancient IPHONE_OS_VERSION_MIN_REQUIRED version check.

• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

12:14 PM Changeset in webkit [253888] by commit-queue@webkit.org

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Unreviewed, rolling out r253884.
​https://bugs.webkit.org/show_bug.cgi?id=205565

Broke production builds (Requested by ap on #webkit).

Reverted changeset:

"Do not build yasm for iOS and iOS simulator"
​https://bugs.webkit.org/show_bug.cgi?id=205556
​https://trac.webkit.org/changeset/253884

12:01 PM Changeset in webkit [253887] by Kocsen Chung

• 8 edits in branches/safari-609.1.13-branch/Source

Versioning.

10:49 AM Changeset in webkit [253886] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit

Unreviewed, fix the macCatalyst build after r253866

• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):

MediaPlayer::mediaKeysStorageDirectory() is guarded by ENABLE(LEGACY_ENCRYPTED_MEDIA).

9:50 AM Changeset in webkit [253885] by Alan Coon

• 1 copy in tags/Safari-609.1.13.1

Tag Safari-609.1.13.1.

8:07 AM Changeset in webkit [253884] by youenn@apple.com

• 3 edits in trunk/Source/ThirdParty/libwebrtc

Do not build yasm for iOS and iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=205556
<rdar://problem/58159497>

Reviewed by Eric Carlson.

Now that we no longer need yasm for iOS simulator, we can stop building it for iOS and iOS simulator.
We can also remove the hack to run yasm.

• Configurations/yasm.xcconfig:
• libwebrtc.xcodeproj/project.pbxproj:

2:42 AM Changeset in webkit [253883] by Carlos Garcia Campos

• 16 edits in trunk/Source

WebDriver: fix handling of session timeouts for values higher than MAX_INT
​https://bugs.webkit.org/show_bug.cgi?id=204114

Reviewed by Brian Burg.

Source/JavaScriptCore:

Fix generation of code with optional number in stack variable.

• inspector/scripts/codegen/cpp_generator.py:

(CppGenerator.cpp_type_for_stack_in_parameter): Do not use Optional for numbers either.

• inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:

Source/WebDriver:

Use double instead of Seconds for handling timeouts.

• Capabilities.h:
• Session.cpp:

(WebDriver::Session::getTimeouts): Handle the case of script timeout being null.
(WebDriver::Session::go):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::findElements):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::executeScript): Do not pass a timeout when it's null.

• Session.h:

(WebDriver::Session::scriptTimeout const):
(WebDriver::Session::pageLoadTimeout const):
(WebDriver::Session::implicitWaitTimeout const):

• WebDriverService.cpp:

(WebDriver::deserializeTimeouts): Add IgnoreUnknownTimeout, since we should only fail when processing
capabilities, but not when setting new timeouts. Also handle the case of script timeout being null.
(WebDriver::WebDriverService::parseCapabilities const): Pass IgnoreUnknownTimeout::No to deserializeTimeouts.
(WebDriver::WebDriverService::validatedCapabilities const): Ditto.
(WebDriver::WebDriverService::createSession): Handle the case of script timeout being null.
(WebDriver::WebDriverService::setTimeouts): Pass IgnoreUnknownTimeout::Yes to deserializeTimeouts.

Source/WebKit:

Use number instead of integer for all optional timeout parameters. In the case of script timeout, not passing a
value means a timeout should not be used, so use Optional<double> also for the IPC message and handle the
optional value in the web process to not set any timeout in that case.

• UIProcess/Automation/Automation.json:
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::waitForNavigationToComplete):
(WebKit::WebAutomationSession::navigateBrowsingContext):
(WebKit::WebAutomationSession::goBackInBrowsingContext):
(WebKit::WebAutomationSession::goForwardInBrowsingContext):
(WebKit::WebAutomationSession::reloadBrowsingContext):
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):

• UIProcess/Automation/WebAutomationSession.h:
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.js:

(let.AutomationSessionProxy.prototype.evaluateJavaScriptFunction):

• WebProcess/Automation/WebAutomationSessionProxy.messages.in:

2:06 AM Changeset in webkit [253882] by Carlos Garcia Campos

• 4 edits in trunk

[GTK] InputMethod API unit tests don't work under X11
​https://bugs.webkit.org/show_bug.cgi?id=205497

Reviewed by Žan Doberšek.

Source/WebKit:

Assume the web view is always focused when running tests under Xvfb, since there isn't a window manager to focus
the toplevel window in that case.

• UIProcess/API/glib/InputMethodFilter.cpp:

(WebKit::InputMethodFilter::isViewFocused const):

Tools:

Use a toplevel window instead of a popup for the input method tests, since that's required in X11 to get the web
view focused.

• TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:

(testWebKitInputMethodContextSimple):
(testWebKitInputMethodContextSequence):
(testWebKitInputMethodContextInvalidSequence):
(testWebKitInputMethodContextCancelSequence):
(testWebKitInputMethodContextReset):

1:19 AM Changeset in webkit [253881] by Carlos Garcia Campos

• 35 edits in trunk

[GTK][WPE] Special combination characters doesn't respect the keystroke order when high CPU load
​https://bugs.webkit.org/show_bug.cgi?id=185248

Reviewed by Žan Doberšek.

Source/WebCore:

Notify the editor when a key event handled by input method has been dispatched. This way we can handle the
composition results right after the event is dispatched.

• editing/Editor.cpp:

(WebCore::Editor::didDispatchInputMethodKeydown): Notify the client.

• editing/Editor.h:
• page/EditorClient.h:

(WebCore::EditorClient::didDispatchInputMethodKeydown): Added.

• page/EventHandler.cpp:

(WebCore::EventHandler::internalKeyEvent): Call Editor::didDispatchInputMethodKeydown() for events handled by
input method right after the event is dispatched.

• platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::preeditUnderlines const):
(WebCore::PlatformKeyboardEvent::preeditSelectionRangeStart const):
(WebCore::PlatformKeyboardEvent::preeditSelectionRangeLength const):

• platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Return early if the event was handled by input
method and remove the special case for Char events handled by input method because this is never called with
Char type for events handled by input method.

• platform/libwpe/PlatformKeyboardEventLibWPE.cpp:

(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): Return early if the event was handled by input
method.

Source/WebKit:

Key events are queued by the WebPageProxy so that the next event is not sent to the web process until the
previous one has been handled by the web process already. However, the composition results generated by key
events are sent to the web process using IPC messages when they happen. In case of high CPU load it can happen
that the composition results are sent to the web process even before the associated keys, that are still in the
queue waiting to be sent. We need to ensure that composition results are always processed right after its
associated key press event. So, instead of sending the results independently, we now include them as part of the
key event.

• Shared/NativeWebKeyboardEvent.h: Add optional preeditUnderlines and preeditSelectionRange parameters to constructor.
• Shared/WebEvent.h:

(WebKit::WebKeyboardEvent::preeditUnderlines const): Return the optional preeditUnderlines.
(WebKit::WebKeyboardEvent::preeditSelectionRange const): Return the optional preeditSelectionRange.

• Shared/WebEventConversion.cpp:

(WebKit::WebKit2PlatformKeyboardEvent::WebKit2PlatformKeyboardEvent): Copy preeditUnderlines and
preeditSelectionRange too.

• Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent): Add optional preeditUnderlines and preeditSelectionRange
parameters and initialize them.
(WebKit::WebKeyboardEvent::encode const): Encode preeditUnderlines and preeditSelectionRange.
(WebKit::WebKeyboardEvent::decode): Decode preeditUnderlines and preeditSelectionRange.

• Shared/gtk/NativeWebKeyboardEventGtk.cpp:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): Add optional preeditUnderlines and
preeditSelectionRange parameters and initialize them.

• Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent): Add optional preeditUnderlines and preeditSelectionRange
parameters and pass them to WebKeyboardEvent constructor.

• Shared/gtk/WebEventFactory.h:
• Shared/libwpe/NativeWebKeyboardEventLibWPE.cpp:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): Add optional preeditUnderlines and
preeditSelectionRange parameters and initialize them.

• Shared/libwpe/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent): Add optional preeditUnderlines and preeditSelectionRang
parameters and pass them to WebKeyboardEvent constructor.

• Shared/libwpe/WebEventFactory.h: Add optional preeditUnderlines and preeditSelectionRange parameters to constructor.
• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewSynthesizeCompositionKeyPress): Pass the preeditUnderlines and preeditSelectionRange to platform
implementation.
(webkitWebViewSetComposition): Remove the call to WebPageProxy::setComposition().
(webkitWebViewConfirmComposition): Remove the call to WebPageProxy::confirmComposition().
(webkitWebViewCancelComposition): Call WebPageProxy::cancelComposition();

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseKeyPressEvent): Pass the preeditUnderlines and preeditSelectionRange to NativeWebKeyboardEvent constructor.
(webkitWebViewBaseKeyReleaseEvent): Ditto.
(webkitWebViewBaseSynthesizeCompositionKeyPress): Ditto.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::handleKeyboardEvent): Ditto.
(WKWPE::View::synthesizeCompositionKeyPress): Ditto.

• UIProcess/API/wpe/WPEView.h:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• WebProcess/WebCoreSupport/WebEditorClient.h:
• WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:

(WebKit::WebEditorClient::didDispatchInputMethodKeydown): Handle the composition results here, right after the
associated key events has been dispatched.

• WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:

(WebKit::WebEditorClient::didDispatchInputMethodKeydown): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::cancelComposition): Confirm the given string to cancel the composition.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in: Remove SetComposition message and rename ConfirmComposition as

CancelComposition since it's now only used for canceling.

Tools:

Remove the waits() that were added to work around this bug.

• TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:

(testWebKitInputMethodContextSequence):
(testWebKitInputMethodContextInvalidSequence):
(testWebKitInputMethodContextCancelSequence):
(testWebKitInputMethodContextReset):

Dec 22, 2019:

7:51 PM Changeset in webkit [253880] by Simon Fraser

• 37 edits
  1 add
  2 deletes in trunk

LayoutTests/imported/w3c:
Very basic <dialog> show/close support
​https://bugs.webkit.org/show_bug.cgi?id=205543

Reviewed by Antti Koivisto.

New results, some new passes.

• web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/dialog-display-expected.txt:
• web-platform-tests/html/rendering/non-replaced-elements/flow-content-0/dialog-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/abspos-dialog-layout-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-just-once-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-autofocus-multiple-times-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-return-value-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-remove-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/inert-node-is-unfocusable-expected.txt:
• web-platform-tests/html/semantics/interactive-elements/the-dialog-element/show-modal-focusing-steps-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:

Source/WebCore:
Very basic <dialog> show/close support
​https://bugs.webkit.org/show_bug.cgi?id=205543

Reviewed by Antti Koivisto.

Fix HTMLDialogElement.idl for attribute reflection, and showModal() possibly throwing.

Have show/showModal() and close() toggle the "open" attribute. Implement parseAttribute()
to initialize m_isOpen from the attribute value.

Add dialog.css, which is appended to the UA stylesheets if the feature is enabled. Have
it set the display value.

Tested by web-platform-tests.

• CMakeLists.txt:
• DerivedSources-input.xcfilelist:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• css/dialog.css: Added.

(dialog):
(dialog[open]):

• html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::isOpen const):
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::parseAttribute):
(WebCore::HTMLDialogElement::toggleOpen):
(WebCore::HTMLDialogElement::open): Deleted.
(WebCore::HTMLDialogElement::setOpen): Deleted.

• html/HTMLDialogElement.h:
• html/HTMLDialogElement.idl:
• style/InspectorCSSOMWrappers.cpp:

(WebCore::Style::InspectorCSSOMWrappers::collectDocumentWrappers):

• style/UserAgentStyle.cpp:

(WebCore::Style::UserAgentStyle::ensureDefaultStyleSheetsForElement):

• style/UserAgentStyle.h:

Source/WebKit:
Make support for <dialog> an internal feature, off by default
​https://bugs.webkit.org/show_bug.cgi?id=205542

Reviewed by Antti Koivisto.

Make DialogElementEnabled an internal feature so it shows up in the menus and
can be toggled on for experimentation.

• Shared/WebPreferences.yaml:

LayoutTests:
Very basic <dialog> show/close support
​https://bugs.webkit.org/show_bug.cgi?id=205543

Reviewed by Antti Koivisto.

• imported/blink/dialog/element-removed-from-top-layer-has-original-position-expected.html: Removed.
• imported/blink/dialog/element-removed-from-top-layer-has-original-position.html: Removed. The changes tested by this patch (added in r140075) were later removed,

then this test got re-imported from blink.

• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt:

7:51 PM Changeset in webkit [253879] by Simon Fraser

• 2 edits in trunk/Source/WebKit

Make support for <dialog> an experimental feature, off by default
​https://bugs.webkit.org/show_bug.cgi?id=205542

Reviewed by Dean Jackson.

Make DialogElementEnabled an experimental feature (off by default).

• Shared/WebPreferences.yaml:

5:15 PM Changeset in webkit [253878] by Wenson Hsieh

• 4 edits
  2 adds in trunk

[macCatalyst] Mouse clicks dispatch duplicate pointerup and pointerdown events
​https://bugs.webkit.org/show_bug.cgi?id=205551
<rdar://problem/58058268>

Reviewed by Tim Horton.

Source/WebCore:

This began occuring after r251320, wherein some mouse event handling codepaths were enabled in macCatalyst.
For compatibility, gesture recognizers still fire in the macCatalyst platform. This includes the synthetic click
gesture, which will still synthesize and send mouseup and mousedown events to the page. After the change, this
results in pointer events being dispatched under the call to shouldIgnoreMouseEvent(). However, at the same
time, touch event handling codepaths have already dispatched "pointerup" and "pointerdown", so we end up with
redundant events.

To fix this macCatalyst-specific bug, simply avoid dispatching pointer events in the case where the synthetic
click type is some kind of tap gesture; in this case, pointer events have already been dispatched, so we don't
need to dispatch them again via mouse event handling code.

Test: pointerevents/ios/pointer-events-with-click-handler.html

• dom/Element.cpp:

(WebCore::dispatchPointerEventIfNeeded):

Also rename shouldIgnoreMouseEvent to dispatchPointerEventIfNeeded to better reflect that this function's
primary purposee is to dispatch pointer events in response to platform mouse events; then, change the return
value to an explicit enum class indicating whether the mouse event should be subsequently ignored (as a result
of the page preventing the dispatched pointer event).

(WebCore::Element::dispatchMouseEvent):
(WebCore::shouldIgnoreMouseEvent): Deleted.

LayoutTests:

• pointerevents/ios/pointer-events-with-click-handler-expected.txt: Added.
• pointerevents/ios/pointer-events-with-click-handler.html: Added.

Add a layout test to verify that the bug does not occur. While this is a macCatalyst fix, this test needs to be
in the ios directory for now because macCatalyst is still considered "iOS family". This test is also still
relevant to both platforms (on iOS, synthesizing a tap behaves as expected, and in macCatalyst, it simulates a
click at the same location).

• pointerevents/utils.js:

(EventTracker.prototype.assertMatchesEvents):
(EventTracker):

Drive-by fix: flip the order of arguments to assert_equals, so that when tests fail, the failure output
correctly shows how many events were expected, and how many were observed.

12:26 PM Changeset in webkit [253877] by Alan Coon

• 8 edits in branches/safari-609.1.13-branch/Source

Versioning.

12:24 PM Changeset in webkit [253876] by ap@apple.com

• 2 edits in trunk/LayoutTests

Add TextExpectations for flaky whlsl tests.

• platform/mac/TestExpectations:

10:06 AM Changeset in webkit [253875] by Antti Koivisto

• 8 edits in trunk/Source/WebCore

Invalidate only affected elements after media query evaluation changes
​https://bugs.webkit.org/show_bug.cgi?id=205392

Reviewed by Zalan Bujtas.

We currently invalidate style of the whole tree when a media query evaluation changes.
We can do better by constructing an invalidation RuleSet and invalidating only those
elements that are potentially affected.

• style/RuleSet.cpp:

(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules):

Construct and cache an invalidation RuleSet and associate with a set of media query changes.

(WebCore::Style::RuleSet::MediaQueryCollector::pushAndEvaluate):
(WebCore::Style::RuleSet::MediaQueryCollector::pop):
(WebCore::Style::RuleSet::MediaQueryCollector::addRuleIfNeeded):

Collect RuleFeatures which we later use to build invalidation RuleSet.

(WebCore::Style::RuleSet::MediaQueryCollector::addRulePositionIfNeeded): Deleted.

• style/RuleSet.h:

(WebCore::Style::DynamicMediaQueryEvaluationChanges::append):

• style/StyleResolver.cpp:

(WebCore::Style::Resolver::evaluateDynamicMediaQueries):

• style/StyleResolver.h:
• style/StyleScope.cpp:

(WebCore::Style::Scope::evaluateMediaQueries):

Use the invalidation RuleSet for accurate style invalidation.

• style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::evaluteDynamicMediaQueryRules):

Collect invalidation RuleSets for author/user/user agent style.

• style/StyleScopeRuleSets.h:

7:21 AM Changeset in webkit [253874] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Do not remove trailing whitespace when it is followed by a line break
​https://bugs.webkit.org/show_bug.cgi?id=205549
<rdar://problem/58139893>

Reviewed by Antti Koivisto.

Complex line layout quirk: keep the trailing whitespace aroun
when it is followed by a line break, unless the content overflows the line.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::removeTrailingCollapsibleContent):

7:12 AM Changeset in webkit [253873] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

[LFC][Integration] Do not collapse trailing letter spacing
​https://bugs.webkit.org/show_bug.cgi?id=205548
<rdar://problem/58139872>

Reviewed by Antti Koivisto.

Turn off trailing letter-spacing trimming for now.

• layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::InlineItemRun::hasTrailingLetterSpacing const):

6:42 AM Changeset in webkit [253872] by youenn@apple.com

• 7 edits
  2 copies in trunk/Source/ThirdParty/libwebrtc

Compile libwebrtc without hardware acceleration for iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=205491

Reviewed by Alex Christensen.

Use c routines instead of optimized versions for iOS simulator.

• Configurations/libvpx.xcconfig:
• Source/third_party/libvpx/source/config/mac/x64/vp8_rtcd.h:
• Source/third_party/libvpx/source/config/mac/x64/vp8_rtcd_no_acceleration.h: Copied from Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vp8_rtcd.h.
• Source/third_party/libvpx/source/config/mac/x64/vpx_config.h:
• Source/third_party/libvpx/source/config/mac/x64/vpx_dsp_rtcd.h:
• Source/third_party/libvpx/source/config/mac/x64/vpx_dsp_rtcd_no_acceleration.h: Copied from Source/ThirdParty/libwebrtc/Source/third_party/libvpx/source/config/mac/x64/vpx_dsp_rtcd.h.
• Source/third_party/libvpx/source/libvpx/vpx_ports/system_state.h:
• libwebrtc.xcodeproj/project.pbxproj:

4:59 AM Changeset in webkit [253871] by eric.carlson@apple.com

• 10 edits
  1 add in trunk/Source/WebKit

[Media in GPU process] Add remote media player proxy configuration
​https://bugs.webkit.org/show_bug.cgi?id=205547
<rdar://problem/58139762>

Reviewed by Tim Horton.

• GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer):

• GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
• GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy):
(WebKit::RemoteMediaPlayerProxy::getConfiguration):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaKeysStorageDirectory const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReferrer const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerUserAgent const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSourceApplicationIdentifier const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerNetworkInterfaceName const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaCacheDirectory const):
(WebKit::RemoteMediaPlayerProxy::mediaContentTypesRequiringHardwareSupport const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerPreferredAudioCharacteristics const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerShouldUsePersistentCache const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerIsVideo const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerKeyNeeded):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerGetRawCookies const):

• GPUProcess/media/RemoteMediaPlayerProxy.h:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerLogIdentifier):

• GPUProcess/media/RemoteMediaPlayerProxyConfiguration.h: Added.

(WebKit::RemoteMediaPlayerProxyConfiguration::encode const):
(WebKit::RemoteMediaPlayerProxyConfiguration::decode):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote):
(WebKit::MediaPlayerPrivateRemote::engineDescription const):
(WebKit::MediaPlayerPrivateRemote::supportsScanning const):
(WebKit::MediaPlayerPrivateRemote::supportsPictureInPicture const):
(WebKit::MediaPlayerPrivateRemote::supportsAcceleratedRendering const):
(WebKit::MediaPlayerPrivateRemote::canPlayToWirelessPlaybackTarget const):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h: Added.

(WebKit::RemoteMediaPlayerConfiguration::encode const):
(WebKit::RemoteMediaPlayerConfiguration::decode):

• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):

4:10 AM Changeset in webkit [253870] by ysuzuki@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix incorrect merging
​https://bugs.webkit.org/show_bug.cgi?id=205327

r253862 and r253867 cause incorrect merging. This patch fixes it.

• jit/ThunkGenerators.cpp:

(JSC::boundFunctionCallGenerator):

1:57 AM Changeset in webkit [253869] by ysuzuki@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, fix debug failures due to missing exception checks
​https://bugs.webkit.org/show_bug.cgi?id=205327

• runtime/JSFunction.cpp:

(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

• runtime/JSObject.cpp:

(JSC::JSObject::defineOwnNonIndexProperty):

Dec 21, 2019:

8:19 PM Changeset in webkit [253868] by BJ Burg

• 44 edits
  4 copies
  5 adds in trunk/Source

Web Inspector: add InspectedTargetTypes diagnostic event and related hooks
​https://bugs.webkit.org/show_bug.cgi?id=205174
<rdar://problem/57887953>

Reviewed by Devin Rousso.

Source/WebCore:

Expose debuggable information via InspectorFrontendHost.

• WebCore.xcodeproj/project.pbxproj: Add new files.

• inspector/InspectorFrontendClient.h: Add new methods.
• testing/Internals.cpp: Implement new methods.

• inspector/InspectorFrontendHost.idl:
• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.cpp:

(WebCore::debuggableTypeToString):
(WebCore::InspectorFrontendHost::debuggableInfo const):
(WebCore::InspectorFrontendHost::debuggableType): Deleted.
Expose a DebuggableInfo dictionary via the .debuggableInfo getter.

Source/WebInspectorUI:

This change adds a new diagnostic recorder that reports information about
inspected targets and their type / version information.

• UserInterface/Base/DebuggableType.js:

(WI.DebuggableType.fromString):
Move the static parsing factory method to DebuggableType class.

• UserInterface/Main.html: Add new files.
• UserInterface/Base/Main.js:

(WI.contentLoaded): Add new diagnostic recorder.

• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.activateDomain):
Adapt to InspectorFrontendHost changes.

• UserInterface/Test/TestAppController.js:

(WI.TestAppController):

• UserInterface/Controllers/AppController.js:

(WI.AppController):
Adapt to InspectorFrontendHost changes.

Source/WebKit:

This change supplies Web Inspector with information about the debuggable that
it is connected to. This is used for diagnostics and to customize the UI based
on the target type being inspected.

For remote Web Inspector, WebKit clients can populate an instance of
_WKInspectorDebuggableInfo and use it when calling into
-[_WKRemoteWebInspectorViewController loadForDebuggable:backendCommandsURL:].

For local Web Inspector, WebInspectorProxy fills in information for the local
debuggable by consulting SystemVersion.plist (on Mac port).

The new enum _WKInspectorDebuggableType replaces _WKRemoteWebInspectorDebuggableType.
Its WebCore equivalent is Inspector::DebuggableType. The type and other information
are carried around in a _WKInspectorDebuggableInfo class. The equivalents for this
class are API::DebuggableInfo and DebuggableInfoData (for sending over IPC).

The DebuggableInfoData is sent as part of the initial message from UIProcess
to an Inspector WebProcess, similar to how a debuggableType string was sent before.

• Sources.txt:
• SourcesCocoa.txt:
• WebKit.xcodeproj/project.pbxproj:

Add new files.

• Shared/API/APIObject.h:
• Shared/Cocoa/APIObject.mm:

(API::Object::newObject): Add new object type.

• Shared/WebCoreArgumentCoders.h: Add EnumTraits for Inspector::DebuggableType.

• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewControllerPrivate.h:
• UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(legacyDebuggableTypeToModernDebuggableType):
(-[_WKRemoteWebInspectorViewController loadForDebuggableType:backendCommandsURL:]):
(-[_WKRemoteWebInspectorViewController loadForDebuggable:backendCommandsURL:]):
(debuggableTypeString): Deleted.
Use the new enum in a new method that clients can switch over to. The old method
can be removed when it is no longer being used.

• UIProcess/RemoteWebInspectorProxy.h:
• UIProcess/RemoteWebInspectorProxy.cpp:

(WebKit::RemoteWebInspectorProxy::RemoteWebInspectorProxy):
(WebKit::RemoteWebInspectorProxy::load):
(WebKit::RemoteWebInspectorProxy::reopen):
Send DebuggableInfoData struct to RemoteWebInspectorUI.

• UIProcess/WebInspectorProxy.h:
• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::openLocalInspectorFrontend):
(WebKit::WebInspectorProxy::infoForLocalDebuggable):
Send DebuggableInfoData struct to WebInspectorUI.

• UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::systemVersionPlist):
(WebKit::WebInspectorProxy::infoForLocalDebuggable):
Add Mac implementation for local debuggables.

• UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::infoForLocalDebuggable):

• UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::infoForLocalDebuggable):

• UIProcess/wpe/WebInspectorProxyWPE.cpp:

(WebKit::WebInspectorProxy::infoForLocalDebuggable):
Add stubs for other platforms.

• UIProcess/glib/RemoteInspectorClient.cpp:
• UIProcess/socket/RemoteInspectorClient.h:
• UIProcess/socket/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::inspect):
(WebKit::debuggableTypeToString):
(WebKit::RemoteInspectorClient::setTargetList):
Use Inspector::DebuggableType instead of String for debuggable type.

• WebProcess/WebPage/RemoteWebInspectorUI.messages.in:
• WebProcess/WebPage/RemoteWebInspectorUI.h:
• WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::initialize):
(WebKit::RemoteWebInspectorUI::debuggableType const):
(WebKit::RemoteWebInspectorUI::targetPlatformName const):
(WebKit::RemoteWebInspectorUI::targetBuildVersion const):
(WebKit::RemoteWebInspectorUI::targetProductVersion const):
(WebKit::RemoteWebInspectorUI::targetIsSimulator const):
Implement new methods needed by InspectorFrontendClient / InspectorFrontendHost.

• WebProcess/WebPage/WebInspectorUI.messages.in:
• WebProcess/WebPage/WebInspectorUI.h:
• WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::targetPlatformName const):
(WebKit::WebInspectorUI::targetBuildVersion const):
(WebKit::WebInspectorUI::targetProductVersion const):
Implement new methods needed by InspectorFrontendClient / InspectorFrontendHost.

Source/WebKitLegacy/win:

• WebCoreSupport/WebInspectorClient.h:

7:12 PM Changeset in webkit [253867] by ysuzuki@apple.com

• 93 edits
  2 adds in trunk

[JSC] Improve our bound function implementation
​https://bugs.webkit.org/show_bug.cgi?id=205327

Reviewed by Keith Miller.

JSTests:

• microbenchmarks/function-bind-no-inlining-repeat-call.js: Added.

(assert):
(test):
(test2):
(foo):
(let.start.Date.now):

• stress/bind-args.js: Added.

(shouldBe):
(test):
(test2):

Source/JavaScriptCore:

This patch improves Function#bind, and calling bound function with bound arguments.

1. Rename CallFrameSlot::argumentCount to CallFrameSlot::argumentCountIncludingThis.
2. Do not include name in NativeExecutable for JSBoundFunction. Putting name in NativeExecutable is assuming that function + name pair is almost identical. This is true in host functions except for JSBoundFunction. JSBoundFunction should hold its name in JSBoundFunction.
3. Cache NativeExecutable for JSBoundFunction in the VM. We use a hash-map in JITThunk for NativeExecutables because we assume that host-function creation cannot be done by the user program: each executable is pre-defined to exactly one object by the environment, and there is no way to create host-functions repeatedly from the user-program. The only exception to this is JSBoundFunction so caching it on the VM avoids the hash-map lookup. This is not true for JSBoundFunction.
4. ThunkGenerator should support JSBoundFunction call with bound arguments. It turns out that Speedometer2/React-Redux-TodoMVC is using bound function with bound arguments. Additionally, it is used. This is really bad: when dispatching an event, we first call this function from C++, entering JS world, going back to C++ world again, and entering JS world to call bound function again. By using ThunkGenerator, we can eliminate this back and forth by directly calling the bound JS Executable from the thunk. Previously, bound arguments are stored in JSArray. But it is difficult to access them from thunk since we need to consider have-a-bad-time case. Instead, we use JSImmutableButterfly to save bound arguments so that JIT thunk can quickly access arguments. To capture arguments as JSImmutableButterfly in JS world, we introduce op_create_arguments_butterfly, and handle it in all tiers.
5. It turns out that eager materialization of "length" in JSBoundFunction takes long time while it is rarely used. This patch makes length lazily reified for JSBoundFunction.
6. To make Function.prototype.bind faster, we track whether "name" and "length" properties of JSFunction is modified or not. This skips has-own-length-property check, which makes Function.prototype.bind 11~% faster.

Combining things above, creation of JSBoundFunction is 80~% faster. And calling bound function with bound arguments is 3~x faster.
This improves Speedometer2/React-TodoMVC by ~3%.

• builtins/FunctionPrototype.js:

(bind):

• bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

• bytecode/AccessCaseSnippetParams.cpp:

(JSC::SlowPathCallGeneratorWithArguments::generateImpl):

• bytecode/BytecodeIntrinsicRegistry.h:
• bytecode/BytecodeList.rb:
• bytecode/BytecodeUseDef.cpp:

(JSC::computeUsesForBytecodeIndexImpl):
(JSC::computeDefsForBytecodeIndexImpl):

• bytecode/VirtualRegister.cpp:

(JSC::VirtualRegister::dump const):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCreateArgumentsButterfly):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_createArgumentsButterfly):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGArgumentsEliminationPhase.cpp:
• dfg/DFGArgumentsUtilities.cpp:

(JSC::DFG::argumentsInvolveStackSlot):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::flushImpl):
(JSC::DFG::ByteCodeParser::handleVarargsInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::isLiveInBytecode):

• dfg/DFGGraph.h:

(JSC::DFG::Graph::forAllLocalsLiveInBytecode):

• dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileFunction):

• dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::emitStoreCallSiteIndex):

• dfg/DFGNodeType.h:
• dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

• dfg/DFGOSRExit.cpp:

(JSC::DFG::emitRestoreArguments):
(JSC::DFG::reifyInlinedCallFrames):
(JSC::DFG::OSRExit::emitRestoreArguments):

• dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateArgumentsButterfly):
(JSC::DFG::SpeculativeJIT::compileGetArgumentCountIncludingThis):
(JSC::DFG::SpeculativeJIT::compileSetArgumentCountIncludingThis):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

• dfg/DFGStoreBarrierInsertionPhase.cpp:
• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLink.cpp:

(JSC::FTL::link):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateArgumentsButterfly):
(JSC::FTL::DFG::LowerDFGToB3::compileGetArgumentCountIncludingThis):
(JSC::FTL::DFG::LowerDFGToB3::compileSetArgumentCountIncludingThis):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargsSpread):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
(JSC::FTL::DFG::LowerDFGToB3::getArgumentsLength):
(JSC::FTL::DFG::LowerDFGToB3::callPreflight):

• ftl/FTLSlowPathCall.h:

(JSC::FTL::callOperation):

• interpreter/CallFrame.cpp:

(JSC::CallFrame::callSiteAsRawBits const):
(JSC::CallFrame::unsafeCallSiteAsRawBits const):
(JSC::CallFrame::setCurrentVPC):

• interpreter/CallFrame.h:

(JSC::CallFrame::argumentCountIncludingThis const):
(JSC::CallFrame::setArgumentCountIncludingThis):

• jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::jitAssertArgumentCountSane):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::argumentCount):

• jit/CCallHelpers.h:

(JSC::CCallHelpers::prepareForTailCallSlow):

• jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::dump const):
(JSC::CallFrameShuffler::prepareForTailCall):
(JSC::CallFrameShuffler::prepareAny):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):

• jit/JITCall.cpp:

(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileOpCall):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileSetupFrame):
(JSC::JIT::compileOpCall):

• jit/JITInlines.h:

(JSC::JIT::updateTopCallFrame):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_argument_count):
(JSC::JIT::emit_op_get_rest_length):
(JSC::JIT::emit_op_get_argument):

• jit/SetupVarargsFrame.cpp:

(JSC::emitSetupVarargsFrameFastCase):

• jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::SpecializedThunkJIT):

• jit/ThunkGenerators.cpp:

(JSC::arityFixupGenerator):
(JSC::boundFunctionCallGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator): Deleted.

• jit/ThunkGenerators.h:
• jsc.cpp:
• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• llint/WebAssembly.asm:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/CommonSlowPaths.h:
• runtime/ExecutableBase.h:
• runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::FunctionRareData):

• runtime/FunctionRareData.h:
• runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototypeGetterCompare):

• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):

• runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):

• runtime/Intrinsic.cpp:

(JSC::intrinsicName):

• runtime/Intrinsic.h:
• runtime/JSBoundFunction.cpp:

(JSC::boundThisNoArgsFunctionCall):
(JSC::boundFunctionCall):
(JSC::boundThisNoArgsFunctionConstruct):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::boundArgsCopy):
(JSC::JSBoundFunction::visitChildren):

• runtime/JSBoundFunction.h:
• runtime/JSFunction.cpp:

(JSC::JSFunction::finishCreation):
(JSC::JSFunction::name):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::getOwnNonIndexPropertyNames):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::reifyLength):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyLazyPropertyForHostOrBuiltinIfNeeded):
(JSC::JSFunction::reifyLazyBoundNameIfNeeded):

• runtime/JSFunction.h:
• runtime/JSFunctionInlines.h:

(JSC::JSFunction::areNameAndLengthOriginal):

• runtime/JSGlobalObject.cpp:

(JSC::makeBoundFunction):
(JSC::hasOwnLengthProperty):

• runtime/JSObject.h:

(JSC::getJSFunction):
(JSC::getCallData): Deleted.
(JSC::getConstructData): Deleted.

• runtime/JSObjectInlines.h:

(JSC::getCallData):
(JSC::getConstructData):

• runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):
(JSC::VM::getBoundFunction):

• runtime/VM.h:
• wasm/js/WasmToJS.cpp:

(JSC::Wasm::wasmToJS):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::jsCallEntrypointSlow):

Tools:

Support running slow-microbenchmarks.

• Scripts/run-jsc-benchmarks:

LayoutTests:

• inspector/model/remote-object-get-properties-expected.txt:
• inspector/runtime/getDisplayableProperties-expected.txt:
• inspector/runtime/getProperties-expected.txt:

7:09 PM Changeset in webkit [253866] by eric.carlson@apple.com

• 8 edits
  1 add in trunk/Source/WebKit

[Media in GPU process] Add remote media player configuration
​https://bugs.webkit.org/show_bug.cgi?id=205541
<rdar://problem/58137418>

Reviewed by Simon Fraser.

• GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer):

• GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
• GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
• GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::RemoteMediaPlayerProxy):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaKeysStorageDirectory const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReferrer const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerUserAgent const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerSourceApplicationIdentifier const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerNetworkInterfaceName const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerMediaCacheDirectory const):
(WebKit::RemoteMediaPlayerProxy::mediaContentTypesRequiringHardwareSupport const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerPreferredAudioCharacteristics const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerShouldUsePersistentCache const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerIsVideo const):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerKeyNeeded):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerGetRawCookies const):

• GPUProcess/media/RemoteMediaPlayerProxy.h:

(WebKit::RemoteMediaPlayerProxy::mediaPlayerLogIdentifier):

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::createRemoteMediaPlayer):

4:43 PM Changeset in webkit [253865] by Darin Adler

• 31 edits in trunk/Source/JavaScriptCore

Make JSString values from literals in a single consistent style
​https://bugs.webkit.org/show_bug.cgi?id=205517

Reviewed by Saam Barati.

Some call sites did it like this:

jsNontrivialString(vm, "literal"_s)

Others did it one of these:

jsString(vm, "literal")
jsNontrivialString(vm, "literal")

Changed all the call sites to do it the first, *slightly* more efficient, way.

• runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

• runtime/AsyncFunctionPrototype.cpp:

(JSC::AsyncFunctionPrototype::finishCreation):

• runtime/AsyncGeneratorFunctionPrototype.cpp:

(JSC::AsyncGeneratorFunctionPrototype::finishCreation):

• runtime/AsyncGeneratorPrototype.cpp:

(JSC::AsyncGeneratorPrototype::finishCreation):

• runtime/BigIntPrototype.cpp:

(JSC::BigIntPrototype::finishCreation):

• runtime/GeneratorFunctionPrototype.cpp:

(JSC::GeneratorFunctionPrototype::finishCreation):

• runtime/GeneratorPrototype.cpp:

(JSC::GeneratorPrototype::finishCreation):

• runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototype::finishCreation):

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::formatToParts):

• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::finishCreation):

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::formatToParts):

• runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::finishCreation):

• runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototype::finishCreation):

• runtime/JSDataViewPrototype.cpp:

(JSC::JSDataViewPrototype::finishCreation):

• runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::finishCreation):

• runtime/JSONObject.cpp:

(JSC::JSONObject::finishCreation):

• runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::finishCreation):

• runtime/JSTypedArrayViewPrototype.cpp:

(JSC::typedArrayViewProtoGetterFuncToStringTag):

• runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototype::finishCreation):

• runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

• runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):

• runtime/RegExpPrototype.cpp:

(JSC::regExpProtoGetterSource):

• runtime/RegExpStringIteratorPrototype.cpp:

(JSC::RegExpStringIteratorPrototype::finishCreation):

• runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototype::finishCreation):

• runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

• runtime/StringIteratorPrototype.cpp:

(JSC::StringIteratorPrototype::finishCreation):

• runtime/SymbolPrototype.cpp:

(JSC::SymbolPrototype::finishCreation):

• runtime/WeakMapPrototype.cpp:

(JSC::WeakMapPrototype::finishCreation):

• runtime/WeakObjectRefPrototype.cpp:

(JSC::WeakObjectRefPrototype::finishCreation):

• runtime/WeakSetPrototype.cpp:

(JSC::WeakSetPrototype::finishCreation):
Call jsNontrivialString instead of jsString and use the _s suffix.

9:18 AM Changeset in webkit [253864] by Antti Koivisto

• 5 edits in trunk/Source

Move Vector HashTraits to HashTraits.h to fix GCC build
​https://bugs.webkit.org/show_bug.cgi?id=205540

Reviewed by Zalan Bujtas.

Source/WebCore:

• contentextensions/DFAMinimizer.cpp:

ActionKey HashTrait claims that emptyValueIsZero. Now with Vector HashTrait having emptyValueIsZero too
HashMap<ActionKey, Vector<>> started taking the optimized path.

However ActionKey empty value wasn't actually zero because Empty enum value wasn't 0.

Source/WTF:

GCC is stricter than LLVM with partial specializations

Error: partial specialization of struct WTF::HashTraits<WTF::Vector<U, otherCapacity, WTF::CrashOnOverflow, 16> >
after instantiation of struct WTF::HashTraits<WTF::Vector<WTF::String> >

• wtf/HashTraits.h:
• wtf/VectorHash.h:

6:58 AM Changeset in webkit [253863] by Kate Cheney

• 19 edits in trunk

Add timeStamp to ITP database
​https://bugs.webkit.org/show_bug.cgi?id=205121
<rdar://problem/57633021>

Reviewed by John Wilander.

Source/WebCore:

• loader/ResourceLoadStatistics.h:

Source/WebKit:

This patch adds support for collecting most-recently-updated
timestamps for third-party/first-party domain pairs in the ITP database.
It updates the timestamp when new statistics are merged into the
database. It then exposes the timestamp via the
_getResourceLoadStatisticsDataSummary API.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::ResourceLoadStatisticsDatabaseStore):
(WebKit::ResourceLoadStatisticsDatabaseStore::prepareStatements):
(WebKit::ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList):
Changed INSERT OR IGNORE queries to be INSERT OR REPLACE so the timestamp
will be replaced upon a new attempted insert into one of the
third-party/first-party relationship tables.
ResourceLoadStatisticsDatabaseStore::insertDomainRelationshipList now
checks for the keyword "REPLACE" to know if another bind is needed
to update the timestamp.

(WebKit::ResourceLoadStatisticsDatabaseStore::getMostRecentlyUpdatedTimestamp):
Queries the most recent time that the third party has appeared as a
subframe or subresource under the first party or redirected to the first party.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
• NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
• NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:

(WebKit::ThirdPartyDataForSpecificFirstParty::toString const):
Updated the toString to check if the timestamp occured in the last
24 hours for testing purposes. It doesn't print the specific time
because it would change for every run and could not be tested.

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _setUseITPDatabase:completionHandler:]):
Added new function that enables the ITP Database backend so the
timestamp parameter can be tested in in TestWebKitAPI.

• UIProcess/API/APIResourceLoadStatisticsFirstParty.h:
• UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.h:
• UIProcess/API/Cocoa/_WKResourceLoadStatisticsFirstParty.mm:

(-[_WKResourceLoadStatisticsFirstParty timeLastUpdated]):
Added the new timestamp parameter to the _WKResourceLoadStatisticsFirstParty.mm
class and its wrapper to be sent via API call.

Tools:

Added checks to test that the timestamp is properly exposed via API
in the ITP database backend. This also adds an API test case using the
ITP database store. It was previously only testing the ITP memory store.

• TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:

(TEST):

LayoutTests:

This patch updates test expectations which call
dumpResourceLoadStatistics to reflect the new timestamp parameter that
is now printed with the ITP data summary.

• http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-database-expected.txt:
• http/tests/resourceLoadStatistics/aggregate-sorted-data-no-storage-access-expected.txt:
• http/tests/storageAccess/aggregate-sorted-data-with-storage-access-database-expected.txt:
• http/tests/storageAccess/aggregate-sorted-data-with-storage-access-expected.txt:

1:49 AM Changeset in webkit [253862] by ysuzuki@apple.com

• 10 edits in trunk/Source/JavaScriptCore

[JSC] Remove m_globalObject field from JSFunction
​https://bugs.webkit.org/show_bug.cgi?id=205533

Reviewed by Mark Lam.

JSFunction::m_globalObject is used only when it is using NativeExecutable.
And when using NativeExecutable, JSCallee::m_scope is always pointing JSGlobalObject.
This patch removes JSFunction::m_globalObject field.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileNewFunctionCommon):

• ftl/FTLAbstractHeapRepository.h:
• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewFunction):

• jit/ThunkGenerators.cpp:

(JSC::nativeForGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• runtime/JSFunction.cpp:

(JSC::JSFunction::JSFunction):

• runtime/JSFunction.h:

(JSC::JSFunction::offsetOfGlobalObject): Deleted.
(JSC::JSFunction::globalObject const): Deleted.

• runtime/JSFunctionInlines.h:

(JSC::JSFunction::JSFunction):

Dec 20, 2019:

11:35 PM Changeset in webkit [253861] by eric.carlson@apple.com

• 20 edits
  1 add in trunk/Source

[Media in GPU process] Get audio playing
​https://bugs.webkit.org/show_bug.cgi?id=205511
<rdar://problem/58120354>

Reviewed by Jer Noble.

Source/WebCore:

Tested manually with a modified sandbox because it isn't possible to load media
in the GPU process yet.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::bufferedTimeRangesChanged):
(WebCore::MediaPlayer::seekableTimeRangesChanged):

• platform/graphics/MediaPlayer.h:
• platform/graphics/PlatformTimeRanges.cpp:

(WebCore::PlatformTimeRanges::PlatformTimeRanges):
(WebCore::PlatformTimeRanges::clear):

• platform/graphics/PlatformTimeRanges.h:

Source/WebKit:

• GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
• GPUProcess/media/RemoteMediaPlayerProxy.h:
• WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::updateCachedState):
(WebKit::MediaPlayerPrivateRemote::maximumDurationToCacheMediaTime const):

• WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
• WebProcess/GPU/media/RemoteMediaPlayerManager.h:

6:09 PM Changeset in webkit [253860] by rniwa@webkit.org

• 4 edits in trunk

TextManipulationController should respect new token orders
​https://bugs.webkit.org/show_bug.cgi?id=205378

Reviewed by Wenson Hsieh.

Source/WebCore:

Updated TextManipulationController::replace to remove all existing content and insert new tokens in the order they appear.

To do this, we first find the common ancestor of all nodes in the paragraph and then remove all nodes in between.

Then we'd insert the node identified by the token identifier and all its ancestors at where they appear. In the case
the same token is used for the second time, we clone its node. For each leaf node, we find the closest ancestor which
had already been inserted by the previous token, and append the leaf node along with its ancestors to it.

I'm expecting to make a lot of refinements & followups to this algorithm in the future but this seems to get basics done.

Tests: TextManipulation.CompleteTextManipulationReplaceSimpleSingleParagraph

TextManipulation.CompleteTextManipulationDisgardsTokens
TextManipulation.CompleteTextManipulationReordersContent
TextManipulation.CompleteTextManipulationCanSplitContent
TextManipulation.CompleteTextManipulationCanMergeContent
TextManipulation.CompleteTextManipulationFailWhenContentIsRemoved
TextManipulation.CompleteTextManipulationFailWhenExcludedContentAppearsMoreThanOnce
TextManipulation.CompleteTextManipulationPreservesExcludedContent

• editing/TextManipulationController.cpp:

(WebCore::TextManipulationController::didCreateRendererForElement):
(WebCore::TextManipulationController::completeManipulation):
(WebCore::TextManipulationController::replace):

Tools:

Added a bunch of tests for WKTextManipulation.

• TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:

(TextManipulation.CompleteTextManipulationReplaceSimpleSingleParagraph):
(TextManipulation.CompleteTextManipulationDisgardsTokens):
(TextManipulation.CompleteTextManipulationReordersContent):
(TextManipulation.CompleteTextManipulationCanSplitContent):
(TextManipulation.CompleteTextManipulationCanMergeContent):
(TextManipulation.CompleteTextManipulationFailWhenContentIsRemoved):
(TextManipulation.CompleteTextManipulationFailWhenExcludedContentAppearsMoreThanOnce):
(TextManipulation.CompleteTextManipulationPreservesExcludedContent):

5:52 PM Changeset in webkit [253859] by Nikita Vasilyev

• 8 edits in trunk/Source/WebInspectorUI

Web Inspector: Gradient editor: opacity slider is too close to the right edge of the popover
​https://bugs.webkit.org/show_bug.cgi?id=203643
<rdar://problem/56762879>

Reviewed by Devin Rousso.

Replace absolute positioning in the color picker with static layout.

• UserInterface/Views/ColorPicker.css:

(.color-picker .wrapper):
(.color-picker :matches(.color-square, .slider)):
(.color-picker .slider):
(.color-picker .hue):
(@media (color-gamut: p3) .color-picker.gamut-p3 > .hue):
(.color-picker > .color-inputs):
(.color-picker > .color-inputs > div):
(.color-picker > .color-inputs > div:not([hidden]) + div):
The 1st visible div should have no left margin even if it's preceded by a hidden div.

• UserInterface/Views/ColorPicker.js:

(WI.ColorPicker):
(WI.ColorPicker.prototype._updateOpacitySlider):

• UserInterface/Views/GradientEditor.css:

(.gradient-editor.editing-color):
(.gradient-editor > .color-picker .slider):

• UserInterface/Views/GradientEditor.js:

(WI.GradientEditor):

• UserInterface/Views/Slider.css:

(.slider):
(.slider > img):
(body[dir=ltr] .slider > img):
(body[dir=rtl] .slider > img):

• UserInterface/Views/Slider.js:

(WI.Slider):
(WI.Slider.prototype.set value):
(WI.Slider.prototype.set knobY):
(WI.Slider.prototype.get maxY):
(WI.Slider.prototype.recalculateKnobY):
(WI.Slider.prototype._handleMousedown):
(WI.Slider.prototype._handleMousemove):

• UserInterface/Views/Variables.css:

(:root):
Convert WI.Slider to be vertical by default. WI.Slider used to define a hozirontal slider.
It is only used by the color picker, where it's vertical. The slider was rotated with CSS
transformation. This made it problematic to use in the static layout.

5:49 PM Changeset in webkit [253858] by sihui_liu@apple.com

• 3 edits in trunk/Source/WebCore

REGRESSION (r253807): crash in storage/indexeddb/modern/opendatabase-request-private.html
​https://bugs.webkit.org/show_bug.cgi?id=205515

Reviewed by Alex Christensen.

When m_openRequests of IDBTransaction is empty, we expect all requests associated with the transactions should
be completed, but in IDBOpenDBRequest, we removed the request from m_openRequests before
m_currentlyCompletingRequest finished. This is because the order of calling ActiveDOMObject::stop() is random.

• Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::cancelForStop):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::abortOnServerAndCancelRequests):
(WebCore::IDBTransaction::connectionClosedFromServer):

5:33 PM Changeset in webkit [253857] by Megan Gardner

• 12 edits
  13 adds in trunk

Paint highlights specified in CSS Highlight API
​https://bugs.webkit.org/show_bug.cgi?id=205318

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-highlight-api/highlight-text-across-elements-expected.html: Added.
• web-platform-tests/css/css-highlight-api/highlight-text-across-elements.html: Added.
• web-platform-tests/css/css-highlight-api/highlight-text-expected.html: Added.
• web-platform-tests/css/css-highlight-api/highlight-text.html: Added.

Source/WebCore:

Render highlights when present, similar to the way we render selection.

Tests: imported/w3c/web-platform-tests/css/css-highlight-api/highlight-text-across-elements.html

imported/w3c/web-platform-tests/css/css-highlight-api/highlight-text.html

• Modules/highlight/HighlightMap.h:

(WebCore::HighlightMap::map const):

Add a getter for the internal HashMap.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::verifySelectionState const):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::clampedStartEndForState const):
(WebCore::InlineTextBox::selectionStartEnd const):
(WebCore::InlineTextBox::highlightStartEnd const):
(WebCore::InlineTextBox::resolveStyleForMarkedText):

Use the highlight name from the HighlightRangeGroup to obtain the style from the renderer.

(WebCore::InlineTextBox::collectMarkedTextsForHighlights const):

Render the highlights when painting text. Determine if a highlight is present in the current RenderObject, and
add additional MarkedText to be rendered when painting

• rendering/InlineTextBox.h:
• rendering/MarkedText.cpp:

(WebCore::subdivide):

• rendering/MarkedText.h:

(WebCore::MarkedText::operator== const):

Expand MarkedText to take a style name.

• rendering/SelectionRangeData.cpp:

(WebCore::SelectionRangeData::setContext):
(WebCore::SelectionRangeData::selectionStateForRenderer):
(WebCore::SelectionRangeData::set):

• rendering/SelectionRangeData.h:

Leverage SelectionRangeData for highlights.

Tools:

Expand MarkedText to take a style name.

• TestWebKitAPI/Tests/WebCore/MarkedText.cpp:

(WebCore::operator<<):

5:13 PM Changeset in webkit [253856] by Chris Dumez

• 4 edits
  1 delete in trunk

[iOS Debug] imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=205506
<rdar://problem/58118091>

Reviewed by Darin Adler.

Source/WebCore:

Drop iOS specific hack in FrameLoader::checkCompleted() that was causing this crash in iOS Debug.
This hack was added a long time ago to fix back/forward navigation after clicking an intra PDF
document hyperlink. I have verified on iOS 13 that the behavior is unchanged without this code:

• Back/forward navigation within a PDF work in UIWebView and do not work in WKWebView

No new tests, unskipped existing test.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkCompleted):

LayoutTests:

• platform/ios-wk2/TestExpectations:

Remove Crash expectation for this test in iOS Debug.

• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https-expected.txt: Removed.

Drop iOS-specific baseline now that the behavior is consistent across platforms.

5:04 PM Changeset in webkit [253855] by Chris Dumez

• 5 edits in trunk

[Bindings] Add @@toStringTag to our iterator prototype object
​https://bugs.webkit.org/show_bug.cgi?id=205516

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

• web-platform-tests/WebIDL/ecmascript-binding/default-iterator-object-expected.txt:
• web-platform-tests/WebIDL/ecmascript-binding/iterator-prototype-object-expected.txt:

Source/WebCore:

Add @@ toStringTag to our iterator prototype object, as per:

• ​https://heycam.github.io/webidl/#es-iterator-prototype-object

No new tests, rebaselined existing tests.

• bindings/js/JSDOMIterator.h:

(WebCore::IteratorTraits>::finishCreation):

4:05 PM Changeset in webkit [253854] by Ross Kirsling

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Memory usage statistics should be attainable without WebCore
​https://bugs.webkit.org/show_bug.cgi?id=205366

Reviewed by Keith Miller.

• API/JSBase.cpp:

(JSGetMemoryUsageStatistics):

• API/JSBasePrivate.h:

Add a private JSC API exposing the same Heap stats as WebCore's PerformanceLogging::memoryUsageStatistics.

3:51 PM Changeset in webkit [253853] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit

Enable HDR Media Capabilities by default
​https://bugs.webkit.org/show_bug.cgi?id=205518
<rdar://problem/57674289>

Reviewed by Eric Carlson.

• Shared/WebPreferences.yaml:

3:43 PM Changeset in webkit [253852] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

MediaKeySession.load() fails
​https://bugs.webkit.org/show_bug.cgi?id=205467

Reviewed by Eric Carlson.

Invert the storageURL condition in load().

Drive-by fix: ask the group for it's sessionID, not the session, if it exists.

• platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):

3:30 PM Changeset in webkit [253851] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

Add some missing skips in LayoutTests/gpu-process/TestExpectations
​https://bugs.webkit.org/show_bug.cgi?id=205523

Patch by Peng Liu <Peng Liu> on 2019-12-20
Reviewed by Eric Carlson.

• gpu-process/TestExpectations:

3:24 PM Changeset in webkit [253850] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

Clean up and generalize some interaction additions
​https://bugs.webkit.org/show_bug.cgi?id=205430

Reviewed by Wenson Hsieh.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):

3:21 PM Changeset in webkit [253849] by timothy_horton@apple.com

• 6 edits in trunk/Source/WebKit

Expose approximate caret extents for the hit line via InteractionInformationAtPosition
​https://bugs.webkit.org/show_bug.cgi?id=205526
<rdar://problem/57983076>

Reviewed by Dean Jackson.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::positionInformation):
Compute and expose the union of first and last caret rects on the line.

• Shared/ios/InteractionInformationAtPosition.h:
• Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

• Shared/ios/InteractionInformationRequest.cpp:

(WebKit::InteractionInformationRequest::encode const):
(WebKit::InteractionInformationRequest::decode):
(WebKit::InteractionInformationRequest::isValidForRequest):

• Shared/ios/InteractionInformationRequest.h:

Also, add a bit so that we can only fetch this data when needed.

3:15 PM Changeset in webkit [253848] by Brent Fulgham

• 5 edits in trunk

Remove access to 'com.apple.cfprefsd.agent' from the macOS sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205478
<rdar://problem/57915066>

Reviewed by Darin Adler.

Source/WebKit:

Telemetry and thorough testing has confirmed that we do not need access to this
mach service, and so should remove it.

Tested by fast/sandboxing/mac

• WebProcess/com.apple.WebProcess.sb.in:

LayoutTests:

• fast/sandbox/mac/sandbox-mach-lookup-expected.txt:
• fast/sandbox/mac/sandbox-mach-lookup.html:

2:59 PM Changeset in webkit [253847] by Chris Dumez

• 3 edits in trunk/Source/WebCore

sendBeacon on Safari 13 seeing high failure rates
​https://bugs.webkit.org/show_bug.cgi?id=204665
<rdar://problem/57522622>

Reviewed by Darin Adler.

Revert r245344 to try and reduce our failure rate for Beacon. This is the only change
to our Beacon implementation that I am aware we made in Safari 13. Using a lower priority
for Beacon makes it more likely that the Beacon load is still pending when the network
process exits, which would interrupt the Beacon.

Since we're trying to convince developers to move away from synchronous XHR and to using
the Beacon API intead, it is important that our Beacon API be as reliable as possible.

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• loader/PingLoader.cpp:

(WebCore::PingLoader::sendPing):

2:52 PM Changeset in webkit [253846] by ap@apple.com

• 3 edits in trunk/LayoutTests

Update TestExpectatipons for media/track/track-in-band-cues-added-once.html
​https://bugs.webkit.org/show_bug.cgi?id=142152

The test no longer times out on bots or in local testing. It is still a flaky failure.

• platform/ios-wk2/TestExpectations:
• platform/mac/TestExpectations:

2:30 PM Changeset in webkit [253845] by Jonathan Bedard

• 2 edits in trunk/Tools

lldbwebkittester: Strip CLANG_DEBUG_INFORMATION_LEVEL option while building
​https://bugs.webkit.org/show_bug.cgi?id=205513

Reviewed by Alexey Proskuryakov.

• Scripts/webkitdirs.pm:

(buildXCodeProject): Strip CLANG_DEBUG_INFORMATION_LEVEL from lldbWebKitTester.

1:51 PM Changeset in webkit [253844] by Truitt Savell

• 11 edits in trunk/Source

Unreviewed, rolling out r253820.

Broke Mac testing

Reverted changeset:

"Invalidate only affected elements after media query
evaluation changes"
​https://bugs.webkit.org/show_bug.cgi?id=205392
​https://trac.webkit.org/changeset/253820

1:44 PM Changeset in webkit [253843] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: fast/shadow-dom/link-element-in-shadow-tree.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=171784

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:40 PM Changeset in webkit [253842] by Alan Coon

• 1 copy in tags/Safari-609.1.13

Tag Safari-609.1.13.

1:36 PM Changeset in webkit [253841] by BJ Burg

• 2 edits in trunk/Source/WebKit

Unreviewed, try to fix the non-unified sources build.

• UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:

(WebKit::MockAuthenticatorManager::filterTransports const):
The current chunking of unified source files seems to provide a
'using namespace WebCore' for these references to AuthenticatorTransport.
Add a namespace qualification so that this file compiles by itself.

1:03 PM Changeset in webkit [253840] by Simon Fraser

• 9 edits in trunk/Tools

Add a Custom User Agent menu to MiniBrowser, and related cleanup
​https://bugs.webkit.org/show_bug.cgi?id=205507

Reviewed by Wenson Hsieh.

Add a User Agent" submenu to the Settings menu, and construct it with some built-in
UA strings. When changed, it sets the customUserAgent on the WKWebView/WebView and
triggers a reload.

I also rearranged the menus so that "Settings" and "Debug" are no longer to the right
of the "Help" menu, which means getting the Settings menu from the xib. It was then
easier if SettingsController was no longer a singleton, but owned by AppDelegate.
Added a category on NSApplication to make it easier to get to BrowserAppDelegate
and thence to the SettingsController.

• MiniBrowser/mac/AppDelegate.h:
• MiniBrowser/mac/AppDelegate.m:

(-[NSApplication browserAppDelegate]):
(-[BrowserAppDelegate awakeFromNib]):
(-[BrowserAppDelegate defaultConfiguration]):
(-[BrowserAppDelegate defaultPreferences]):
(-[BrowserAppDelegate createBrowserWindowController:]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate newPrivateWindow:]):
(-[BrowserAppDelegate applicationDidFinishLaunching:]):
(-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
(-[BrowserAppDelegate userContentContoller]):
(defaultConfiguration): Deleted.
(defaultPreferences): Deleted.

• MiniBrowser/mac/ExtensionManagerWindowController.m:

(-[ExtensionManagerWindowController init]):
(-[ExtensionManagerWindowController add:]):
(-[ExtensionManagerWindowController remove:]):

• MiniBrowser/mac/MainMenu.xib:
• MiniBrowser/mac/SettingsController.h:
• MiniBrowser/mac/SettingsController.m:

(-[SettingsController initWithMenu:]):
(-[SettingsController dealloc]):
(-[SettingsController _populateMenu]):
(+[SettingsController userAgentData]):
(-[SettingsController buildUserAgentsMenu:]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController _toggleBooleanDefault:]):
(-[SettingsController toggleExperimentalFeature:]):
(-[SettingsController toggleInternalDebugFeature:]):
(-[SettingsController customUserAgent]):
(-[SettingsController changeCutomUserAgent:]):
(+[SettingsController shared]): Deleted.
(-[SettingsController init]): Deleted.
(-[SettingsController menu]): Deleted.

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController awakeFromNib]):
(-[WK1BrowserWindowController userAgentDidChange:]):
(-[WK1BrowserWindowController windowWillClose:]):
(-[WK1BrowserWindowController didChangeSettings]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):
(-[WK2BrowserWindowController initWithConfiguration:]):
(-[WK2BrowserWindowController userAgentDidChange:]):
(-[WK2BrowserWindowController windowWillClose:]):
(-[WK2BrowserWindowController didChangeSettings]):

12:51 PM Changeset in webkit [253839] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Include WKPDFConfiguration, WKFindConfiguration, and WKFindResult in umbrella header
​https://bugs.webkit.org/show_bug.cgi?id=205432
<rdar://problem/58067946>

Patch by James Savage <James Savage> on 2019-12-20
Reviewed by Wenson Hsieh.

• Shared/API/Cocoa/WebKit.h: Include new headers.

12:43 PM Changeset in webkit [253838] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

SWServer can be created without any path to store registrations in non ephemeral sessions
​https://bugs.webkit.org/show_bug.cgi?id=205500

Reviewed by Simon Fraser.

No change of behavior in release.
Remove debug assert and log the case of a non ephemeral session without a path.

• workers/service/server/SWServer.cpp:

(WebCore::SWServer::SWServer):

12:42 PM Changeset in webkit [253837] by BJ Burg

• 29 edits in trunk/Source

Web Inspector: convert some InspectorFrontendHost methods to getters
​https://bugs.webkit.org/show_bug.cgi?id=205475

Reviewed by Devin Rousso.

Source/WebCore:

No reason for these to be method calls, so expose as getters / attributes instead.

• inspector/InspectorFrontendClient.h:
• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::isRemote const):
(WebCore::debuggableTypeToString):
(WebCore::InspectorFrontendHost::localizedStringsURL): Deleted.
(WebCore::InspectorFrontendHost::backendCommandsURL): Deleted.
(WebCore::InspectorFrontendHost::debuggableType): Deleted.
(WebCore::InspectorFrontendHost::inspectionLevel): Deleted.
(WebCore::InspectorFrontendHost::platform): Deleted.
(WebCore::InspectorFrontendHost::port): Deleted.

• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:
• testing/Internals.cpp:

Source/WebInspectorUI:

No reason for these to be method calls, so expose as getters / attributes instead.

• UserInterface/Base/LoadLocalizedStrings.js:
• UserInterface/Base/Main.js:
• UserInterface/Base/ObjectStore.js:

(WI.ObjectStore.get _databaseName):

• UserInterface/Base/Platform.js:
• UserInterface/Base/Setting.js:

(WI.Setting._localStorageKey):

• UserInterface/Debug/Bootstrap.js:

(WI.runBootstrapOperations):

• UserInterface/Protocol/LoadInspectorBackendCommands.js:

Source/WebKit:

No reason for these to be method calls, so expose as getters / attributes instead.

• WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp:

(WebKit::WebInspectorUI::localizedStringsURL const):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):
(WebKit::WebInspectorUI::localizedStringsURL): Deleted.
(WebKit::RemoteWebInspectorUI::localizedStringsURL): Deleted.

• WebProcess/WebPage/mac/WebInspectorUIMac.mm:

(WebKit::WebInspectorUI::localizedStringsURL const):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):
(WebKit::WebInspectorUI::localizedStringsURL): Deleted.
(WebKit::RemoteWebInspectorUI::localizedStringsURL): Deleted.

• WebProcess/WebPage/win/WebInspectorUIWin.cpp:

(WebKit::WebInspectorUI::localizedStringsURL const):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):
(WebKit::WebInspectorUI::localizedStringsURL): Deleted.
(WebKit::RemoteWebInspectorUI::localizedStringsURL): Deleted.

• WebProcess/WebPage/wpe/WebInspectorUIWPE.cpp:

(WebKit::WebInspectorUI::localizedStringsURL const):
(WebKit::RemoteWebInspectorUI::localizedStringsURL const):
(WebKit::WebInspectorUI::localizedStringsURL): Deleted.
(WebKit::RemoteWebInspectorUI::localizedStringsURL): Deleted.

Source/WebKitLegacy/ios:

• WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorFrontendClient::localizedStringsURL const):
(WebInspectorFrontendClient::localizedStringsURL): Deleted.

Source/WebKitLegacy/mac:

• WebCoreSupport/WebInspectorClient.h:
• WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::localizedStringsURL const):
(WebInspectorFrontendClient::localizedStringsURL): Deleted.

Source/WebKitLegacy/win:

• WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorFrontendClient::localizedStringsURL const):
(WebInspectorFrontendClient::localizedStringsURL): Deleted.

• WebCoreSupport/WebInspectorClient.h:

12:40 PM Changeset in webkit [253836] by Truitt Savell

• 2 edits in trunk/LayoutTests

Flaky crash in AudioSourceProviderAVFObjC::~AudioSourceProviderAVFObjC on webaudio/silent-audio-interrupted-in-background.html
​https://bugs.webkit.org/show_bug.cgi?id=202064

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:33 PM Changeset in webkit [253835] by Andres Gonzalez

• 9 edits in trunk/Source/WebCore

IsolatedObject support for multiple parameterized attributes.
​https://bugs.webkit.org/show_bug.cgi?id=205508

Reviewed by Chris Fleizach.

• AXObjectCache now keeps the PageIdentifier so that it is possible to

retrieve it on the secondary thread without querying the Document.

• isIncrementor is exposed on AXCoreObject for spin button support.
• Several parameterized attributes implementation related to

TextMarkers are now dispatch to the main thread.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::setIsolatedTreeFocusedObject):
(WebCore::AXObjectCache::isolatedTreeRootObject):
(WebCore::AXObjectCache::remove):

• accessibility/AXObjectCache.h:
• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/AccessibilitySpinButton.h:
• accessibility/isolatedtree/AXIsolatedTreeNode.cpp:

(WebCore::AXIsolatedObject::AXIsolatedObject):
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::updateBackingStore):
(WebCore::AXIsolatedObject::findTextRanges const):
(WebCore::AXIsolatedObject::performTextOperation):
(WebCore::AXIsolatedObject::axObjectCache const):
(WebCore::AXIsolatedObject::widget const):
(WebCore::AXIsolatedObject::document const):
(WebCore::AXIsolatedObject::documentFrameView const):
(WebCore::AXIsolatedObject::isLoaded const): Implemented in header.
(WebCore::AXIsolatedObject::supportsPath const): Implemented in header.

• accessibility/isolatedtree/AXIsolatedTreeNode.h:
• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

12:27 PM Changeset in webkit [253834] by commit-queue@webkit.org

• 9 edits
  2 copies
  1 move in trunk/Source

Allow a managed configuration to re-enable TLS 1.0 and 1.1
​https://bugs.webkit.org/show_bug.cgi?id=205479
<rdar://problem/54493516>

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-12-20
Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

Manually verified using the managed configuration attached to rdar://problem/56727605

• PAL.xcodeproj/project.pbxproj:
• pal/ios/ManagedConfigurationSoftLink.h: Added.
• pal/ios/ManagedConfigurationSoftLink.mm: Added.
• pal/spi/ios/ManagedConfigurationSPI.h: Copied from Source/WebKit/Platform/spi/ios/ManagedConfigurationSPI.h.

Source/WebKit:

• Platform/spi/ios/ManagedConfigurationSPI.h: Removed.
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

• UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:

(WebKit::WebsiteDataStore::parameters):

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _defineForWebView:]):

• WebKit.xcodeproj/project.pbxproj:

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

11:40 AM Changeset in webkit [253833] by dbates@webkit.org

• 3 edits in trunk/Source/WebCore

Share code for computing the absolute positioned line boxes for a range
​https://bugs.webkit.org/show_bug.cgi?id=205510

Reviewed by Wenson Hsieh.

Implement RenderTextLineBoxes::absoluteRectsForRange() in terms of absoluteQuadsForRange()
to remove almost identical code. This makes absoluteRectsForRange() a tiny bit slower. If
it turns out this slowness isn't so tiny then we should use revert this change and implement
again using templates to avoid duplication.

Also moved absoluteQuadsForRange() to be above absoluteRectsForRange() to group these
related functions closer together.

• rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::absoluteQuadsForRange const): No change, though I moved it
to be above absoluteRectsForRange().
(WebCore::RenderTextLineBoxes::absoluteRectsForRange const): Implement in terms of absoluteQuadsForRange().

• rendering/RenderTextLineBoxes.h: Group absolute*ForRange() declarations.

11:18 AM Changeset in webkit [253832] by Truitt Savell

• 4 edits
  50 adds in trunk/LayoutTests

Unreviewed, rolling out r253831.

Inadvertent rollout of r253829

Reverted changeset:

"Unreviewed, rolling out r253829."
​https://bugs.webkit.org/show_bug.cgi?id=205502
​https://trac.webkit.org/changeset/253831

11:17 AM Changeset in webkit [253831] by Truitt Savell

• 4 edits
  1 delete in trunk/LayoutTests

Unreviewed, rolling out r253829.

This is blocking the rollout of r253705

Reverted changeset:

"Import web-platform-tests/subresource-integrity tests from
usptream"
​https://bugs.webkit.org/show_bug.cgi?id=205502
​https://trac.webkit.org/changeset/253829

11:11 AM Changeset in webkit [253830] by Chris Dumez

• 2 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/beacon/beacon-redirect.window.html has been flaky since it was imported in r253760
​https://bugs.webkit.org/show_bug.cgi?id=205504
<rdar://problem/58115444>

Unreviewed, mark test as flaky.

• TestExpectations:

11:03 AM Changeset in webkit [253829] by Chris Dumez

• 4 edits
  50 adds in trunk/LayoutTests

Import web-platform-tests/subresource-integrity tests from usptream
​https://bugs.webkit.org/show_bug.cgi?id=205502

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import web-platform-tests/subresource-integrity tests from usptream 5f8d15ebdcf0495c271c.

• web-platform-tests/subresource-integrity/*: Added.

LayoutTests:

• TestExpectations:

10:13 AM Changeset in webkit [253828] by Chris Dumez

• 2 edits in trunk/LayoutTests

[iOS Debug] imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html is crashing
​https://bugs.webkit.org/show_bug.cgi?id=205506

Unreviewed, mark imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https.html as crashing
on iOS Debug. The test has been crashing on this platform since it was imported in r253791.

• platform/ios-wk2/TestExpectations:

9:57 AM Changeset in webkit [253827] by youenn@apple.com

• 3 edits in trunk/Source/WebCore

Remove the certificate info checks related to getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=205493

Reviewed by Eric Carlson.

Now that navigator.mediaDevices is SecureContext, we do not need to do the same checks in UserMediaController.
UserMediaController was also checking the certificate info which is not necessary for MediaDevices.
Covered by manual tests.

• Modules/mediastream/UserMediaController.cpp:

(WebCore::isSecure):
(WebCore::isAllowedByFeaturePolicy): Deleted.
(WebCore::isAllowedToUse): Deleted.
(WebCore::UserMediaController::canCallGetUserMedia const): Deleted.
(WebCore::UserMediaController::logGetUserMediaDenial): Deleted.

9:40 AM Changeset in webkit [253826] by youenn@apple.com

• 6 edits in trunk/Source/WebKit

Set whether to use mock capture devices at GPUProcess creation time.
​https://bugs.webkit.org/show_bug.cgi?id=205492

Reviewed by Eric Carlson.

This ensures UIProcess remains always in sync with GPUProcess.
Covered by fast/mediastream/captureAudioInGPUProcess.html.

• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::initializeGPUProcess):
(WebKit::GPUProcess::setMockCaptureDevicesEnabled):

• GPUProcess/GPUProcess.h:
• GPUProcess/GPUProcessCreationParameters.cpp:

(WebKit::GPUProcessCreationParameters::encode const):
(WebKit::GPUProcessCreationParameters::decode):

• GPUProcess/GPUProcessCreationParameters.h:
• UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::singleton):

9:37 AM Changeset in webkit [253825] by youenn@apple.com

• 3 edits in trunk/LayoutTests

webrtc/video-autoplay.html is flaky on iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=205495

Reviewed by Eric Carlson.

• webrtc/video-autoplay-expected.txt:
• webrtc/video-autoplay.html:

Do test one video at a time so that one video does not interrupt the other.

9:34 AM Changeset in webkit [253824] by dino@apple.com

• 19 edits in trunk/Source

Build ANGLE as a dynamic library
​https://bugs.webkit.org/show_bug.cgi?id=204708
Source/ThirdParty/ANGLE:

rdar://57349384

Reviewed by Tim Horton.

Take 2 at attempting this. The first time was rolled out
due to failures in Apple's upstream build system.

Modify ANGLE to build as a dynamic library. My (not thorough) testing suggests
this will reduce the in-flight binary size on Apple's build systems by at least
a factor of 10 (it was over 1G). Building release for x86_64-only:

• Previously: libANGLE.a -- 306 MB
• Now: libANGLE-shared.dylib -- 6.7 MB

In order to do this, some symbols needed to be exported from the
"sh" namespace (which are used in ANGLEWebKitBridge, but not when
ANGLE's rendering backend is active).

While here, I turned on some more build options, like ARC.

Lastly, I added a build phase that creates a fake libANGLE.a
because Apple's build system thinks that WebCore still needs it.

• ANGLE.xcodeproj/project.pbxproj: Link with IOKit and IOSurface frameworks, and

product a dylib product.

• Configurations/ANGLE.xcconfig: Update the configuration for a dynamic library.
• Configurations/Base.xcconfig:
• Configurations/DebugRelease.xcconfig:
• include/GLSLANG/ShaderLang.h: Add ANGLE_EXPORT to some functions to make

sure they will be visible in the exported library.

• include/GLSLANG/ShaderVars.h:
• src/libANGLE/renderer/gl/cgl/DisplayCGL.mm: Change reinterpret_cast to a normal

C cast so it can be annotated with bridge.
(rx::DisplayCGL::isValidNativeWindow const):

• src/libANGLE/renderer/gl/cgl/WindowSurfaceCGL.mm: Ditto.

(rx::WindowSurfaceCGL::WindowSurfaceCGL):
(rx::WindowSurfaceCGL::~WindowSurfaceCGL):

• src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm: Ditto.
• src/libANGLE/renderer/gl/eagl/WindowSurfaceEAGL.mm: Ditto.

Source/WebCore:

Reviewed by Tim Horton.

Weak link against libANGLE-shared.dylib rather than strong link to libANGLE.a.

• Configurations/WebCore.xcconfig:
• Configurations/WebCoreTestSupport.xcconfig:
• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::cleanupCompilers):
(WebCore::ANGLEWebKitBridge::compileShaderSource):
(WebCore::ANGLEWebKitBridge::angleAvailable):

• platform/graphics/ANGLEWebKitBridge.h:
• platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

8:46 AM Changeset in webkit [253823] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, mark imported/w3c/web-platform-tests/2dcontext/wide-gamut-canvas as flaky.

Those were recently imported from upstream.

• TestExpectations:

8:39 AM Changeset in webkit [253822] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, skip imported/w3c/web-platform-tests/2dcontext/wide-gamut-canvas/canvas-createImageBitmap-e_srgb.html

This test has been timing out since it was imported and slows down our test runs for no reason.

• TestExpectations:

8:34 AM Changeset in webkit [253821] by Chris Dumez

• 2 edits in trunk/LayoutTests

Re-skip imported/w3c/web-platform-tests/service-workers/service-worker/client-navigate.https.html

I had unskipped this test in r253704 because it no longer appeared to time out on my machine. However,
it sill appears to time out on the bots (at least flakily).

• TestExpectations:

8:34 AM Changeset in webkit [253820] by Antti Koivisto

• 11 edits in trunk/Source

Invalidate only affected elements after media query evaluation changes
​https://bugs.webkit.org/show_bug.cgi?id=205392

Reviewed by Zalan Bujtas.

Source/WebCore:

We currently invalidate style of the whole tree when a media query evaluation changes.
We can do better by constructing an invalidation RuleSet and invalidating only those
elements that are potentially affected.

• style/RuleSet.cpp:

(WebCore::Style::RuleSet::addRule):
(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules):

Construct and cache an invalidation RuleSet and associate with a set of media query changes.

(WebCore::Style::RuleSet::MediaQueryCollector::pushAndEvaluate):
(WebCore::Style::RuleSet::MediaQueryCollector::pop):
(WebCore::Style::RuleSet::MediaQueryCollector::addRuleIfNeeded):

Collect RuleFeatures which we later use to build invalidation RuleSet.

(WebCore::Style::RuleSet::MediaQueryCollector::addRulePositionIfNeeded): Deleted.

• style/RuleSet.h:

(WebCore::Style::DynamicMediaQueryEvaluationChanges::append):

• style/StyleResolver.cpp:

(WebCore::Style::Resolver::evaluateDynamicMediaQueries):

• style/StyleResolver.h:
• style/StyleScope.cpp:

(WebCore::Style::Scope::evaluateMediaQueries):

Use the invalidation RuleSet for accurate style invalidation.

• style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::evaluteDynamicMediaQueryRules):

Collect invalidation RuleSets for author/user/user agent style.

• style/StyleScopeRuleSets.h:

Source/WTF:

Fix GCC build error

Error: partial specialization of ‘struct WTF::HashTraits<WTF::Vector<U, otherCapacity, WTF::CrashOnOverflow, 16> >’

after instantiation of ‘struct WTF::HashTraits<WTF::Vector<WTF::String> >’

• wtf/HashTraits.h:
• wtf/VectorHash.h:

Move to HashTraits to HashTraits.h so it gets specialized before any instantiation.

8:31 AM Changeset in webkit [253819] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, address flakiness of imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/css-module-worker-test.html

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/scripting-1/the-script-element/css-module/css-module-worker-test-expected.txt:

LayoutTests:

• TestExpectations:

8:29 AM Changeset in webkit [253818] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, skip http/wpt/html/semantics/text-level-semantics/the-a-element/a-download-click-404.html on macOS wk1

We do not support the download attribute on this platform.

• platform/mac-wk1/TestExpectations:

8:10 AM Changeset in webkit [253817] by Diego Pino Garcia

• 2 edits in trunk/Source/WebCore

[GTK][WPE] Wrong visualization of Conic gradients in high resolution displays
​https://bugs.webkit.org/show_bug.cgi?id=205444

Reviewed by Carlos Alberto Lopez Perez.

Reduce the size of the separation between sections since a separation of
1 pixel is too wide in high resolution displays.

• platform/graphics/cairo/GradientCairo.cpp:

(WebCore::addConicSector):

5:50 AM Changeset in webkit [253816] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Unreviewed, address review comment missed in the initial commit.

• layout/inlineformatting/InlineLineBreaker.h:
• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::LineLayoutContext::placeInlineContentOnCurrentLine):
(WebCore::Layout::LineLayoutContext::commitContent):

5:44 AM Changeset in webkit [253815] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

[LFC][IFC] Refactor LineLayoutContext class
​https://bugs.webkit.org/show_bug.cgi?id=205494
<rdar://problem/58109493>

Reviewed by Antti Koivisto.

This patch is in preparation for being able to pre-scan the inline content for soft wrap opportunities.

Currently processing the inline content means pushing the inline items to an uncommitted queue until after
we find a soft wrap opportunity and then we ask the LineBreaker whether this uncommitted, "continuous content" can be placed
on the current line.
while (has unprocessed inline item) {

get next inline item
if (inline item is at a soft wrap opportunity)

sumbit uncommitted queue to line breaking

else

add to uncommitted queue

}
This patch omits the uncommitted queue by collecting the inline items first. This removes some code complexity and it also
helps to be able to pre-scan the content for soft wrap opportunities.
while (has unprocessed inline item) {

get next continuous content
submit content to line breaking

}

• layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::endsWithSoftWrapOpportunity):
(WebCore::Layout::LineBreaker::ContinousContent::ContinousContent):

• layout/inlineformatting/InlineLineBreaker.h:

(WebCore::Layout::LineBreaker::Run::Run):

• layout/inlineformatting/LineLayoutContext.cpp:

(WebCore::Layout::ContinousContent::hasIntrusiveFloats const):
(WebCore::Layout::ContinousContent::runs const):
(WebCore::Layout::ContinousContent::floats const):
(WebCore::Layout::ContinousContent::endsWithLineBreak const):
(WebCore::Layout::ContinousContent::setEndsWithLineBreak):
(WebCore::Layout::ContinousContent::append):
(WebCore::Layout::LineLayoutContext::layoutLine):
(WebCore::Layout::LineLayoutContext::close):
(WebCore::Layout::LineLayoutContext::nextContinousContentForLine):
(WebCore::Layout::LineLayoutContext::addFloatItems):
(WebCore::Layout::LineLayoutContext::placeInlineContentOnCurrentLine):
(WebCore::Layout::LineLayoutContext::commitContent):
(WebCore::Layout::LineLayoutContext::commitPendingContent): Deleted.
(WebCore::Layout::LineLayoutContext::placeInlineItem): Deleted.
(WebCore::Layout::LineLayoutContext::processUncommittedContent): Deleted.
(WebCore::Layout::LineLayoutContext::UncommittedContent::append): Deleted.
(WebCore::Layout::LineLayoutContext::UncommittedContent::reset): Deleted.
(WebCore::Layout::LineLayoutContext::UncommittedContent::shrink): Deleted.

• layout/inlineformatting/LineLayoutContext.h:

(WebCore::Layout::LineLayoutContext::formattingContext const):
(WebCore::Layout::LineLayoutContext::root const):
(WebCore::Layout::LineLayoutContext::UncommittedContent::width const): Deleted.
(WebCore::Layout::LineLayoutContext::UncommittedContent::size): Deleted.
(WebCore::Layout::LineLayoutContext::UncommittedContent::isEmpty): Deleted.
(WebCore::Layout::LineLayoutContext::UncommittedContent::runs const): Deleted.

5:35 AM Changeset in webkit [253814] by commit-queue@webkit.org

• 5 edits in trunk

Fetch: handle emtpy Location value
​https://bugs.webkit.org/show_bug.cgi?id=205462

Patch by Rob Buis <​rbuis@igalia.com> on 2019-12-20
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Update improved test results.

• web-platform-tests/fetch/api/redirect/redirect-empty-location.any-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-empty-location.any.worker-expected.txt:

Source/WebCore:

Handle empty Location value on redirect as specified here:
​https://fetch.spec.whatwg.org/#concept-http-redirect-fetch step 3

Tests: web-platform-tests/fetch/api/redirect/redirect-empty-location.any.html

web-platform-tests/fetch/api/redirect/redirect-empty-location.any.worker.html

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse):

5:15 AM Changeset in webkit [253813] by youenn@apple.com

• 2 edits in trunk/Source/WebCore

DOMPromise::whenPromiseIsSettled is asserting in service worker
​https://bugs.webkit.org/show_bug.cgi?id=205440

Reviewed by Chris Dumez.

The promise.get(@then) is sometimes throwing an exception probably due to service worker being stopped.
We need to catch the JS exception and exit early if the getter fails.
Covered by existing service worker tests in debug mode.

• bindings/js/JSDOMPromise.cpp:

(WebCore::DOMPromise::whenPromiseIsSettled):

3:52 AM Changeset in webkit [253812] by youenn@apple.com

• 7 edits in trunk/Source/WebCore

Make ServiceWorker::postMessage use the exec state from the JS binding layer
​https://bugs.webkit.org/show_bug.cgi?id=205395

Reviewed by Chris Dumez.

Instead of using ScriptExecutionContext::execState, we can ask the JS binding layer to pass the exec state and use it.
Since ServiceWorker is an ActiveDOMObject, we use its scriptExecutionContext() to compute the ServiceWorker source identifier.
We do the same for ServiceWorkerClient which is a context destruction observer and which only lives in Service Worker scope so calling ScriptExecutionContext::execState is suboptimal.

No change of behavior.

• workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

• workers/service/ServiceWorker.h:
• workers/service/ServiceWorker.idl:
• workers/service/ServiceWorkerClient.cpp:

(WebCore::ServiceWorkerClient::postMessage):

• workers/service/ServiceWorkerClient.h:
• workers/service/ServiceWorkerClient.idl:

2:31 AM Changeset in webkit [253811] by jiewen_tan@apple.com

• 19 edits
  3 adds in trunk

[WebAuthn] Implement coders for CTAP ClientPIN requests and responses
​https://bugs.webkit.org/show_bug.cgi?id=205376
<rdar://problem/58034395>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch implements coders for authenticatorClientPIN requests and responses
following the spec:
​https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#authenticatorClientPIN

Specifically, it
i) implements authenticatorClientPIN subCommand: getRetries, getKeyAgreement and getPINToken;
ii) adds pinAuth/pinProtocol to authenticatorMakeCredential/authenticatorGetAssertion.

The authenticatorClientPIN subCommands are based on a Chromium patch:
​https://chromium-review.googlesource.com/c/chromium/src/+/1457004 Specifically, it adopts the
interfaces from that patch, but rewrites the BoringSSL-based crypto features using WebCore's
WebCrypto implementation. This allows us to focus on high level crypto interfaces, and lets
WebCrypto handle the underlying crypto library. Also, the original Chromium patch lacks tests.
We introduce a large set of API tests to confirm proper function.

This patch also makes the AES CBC, EDCH, and HMAC platform* implementations public, so that
these implementations can be shared by WebAuthentication and test infrastructure.

Covered by API tests.

• Modules/webauthn/WebAuthenticationConstants.h:
• Modules/webauthn/cbor/CBORReader.cpp:

(cbor::CBORReader::readCBORMap):
Let CBORReader recognize negative map keys.

• Modules/webauthn/fido/DeviceRequestConverter.cpp:

(fido::encodeMakeCredenitalRequestAsCBOR):
(fido::encodeGetAssertionRequestAsCBOR):

• Modules/webauthn/fido/DeviceRequestConverter.h:
• Modules/webauthn/fido/Pin.cpp: Added.

(fido::pin::hasAtLeastFourCodepoints):
(fido::pin::makePinAuth):
(fido::pin::encodeRawPublicKey):
(fido::pin::validateAndConvertToUTF8):
(fido::pin::encodePinCommand):
(fido::pin::RetriesResponse::parse):
(fido::pin::KeyAgreementResponse::KeyAgreementResponse):
(fido::pin::KeyAgreementResponse::parse):
(fido::pin::KeyAgreementResponse::parseFromCOSE):
(fido::pin::encodeCOSEPublicKey):
(fido::pin::TokenResponse::TokenResponse):
(fido::pin::TokenResponse::parse):
(fido::pin::TokenResponse::pinAuth const):
(fido::pin::TokenResponse::token const):
(fido::pin::encodeAsCBOR):
(fido::pin::TokenRequest::tryCreate):
(fido::pin::TokenRequest::TokenRequest):
(fido::pin::TokenRequest::sharedKey const):

• Modules/webauthn/fido/Pin.h: Added.
• Sources.txt:
• WebCore.xcodeproj/project.pbxproj:
• crypto/CryptoAlgorithm.h:
• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/keys/CryptoKeyAES.cpp:
• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyEC.h:
• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::algorithm const):

Tools:

Adds API tests.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/CtapPinTest.cpp: Added.

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/FidoTestData.h:

Dec 19, 2019:

7:32 PM Changeset in webkit [253810] by sbarati@apple.com

• 7 edits
  2 adds in trunk

Don't cache self customs on dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=205466
<rdar://problem/58075545>

Reviewed by Mark Lam.

Source/JavaScriptCore:

We had a bug where we would cache a custom value/accessor on a self property
of a cacheable dictionary object. This turns out to be wrong because the
inline cache won't fail (because we won't transition structures) if that
property is replaced with something else. We would do the right thing when
the custom was on the prototype chain, but when it was a self property, we
didn't. The reason customs are different from values/normal accessors is that
we dynamically load values/getters/setters from the object itself. For
customs, we cache the actual pointer value of the C function. This patch makes
it so we don't cache customs on dictionaries.

• bytecode/ObjectPropertyConditionSet.cpp:

(JSC::prepareChainForCaching):
(JSC::preparePrototypeChainForCaching): Deleted.

• bytecode/ObjectPropertyConditionSet.h:
• jit/Repatch.cpp:

(JSC::tryCacheGetBy):
(JSC::tryCachePutByID):
(JSC::tryCacheInByID):
(JSC::tryCacheInstanceOf):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setupGetByIdPrototypeCache):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::setObjectToStringValue):

LayoutTests:

• js/dom/custom-function-should-not-cache-as-dictionary-expected.txt: Added.
• js/dom/custom-function-should-not-cache-as-dictionary.html: Added.

6:24 PM Changeset in webkit [253809] by rniwa@webkit.org

• 19 edits in trunk/Source/WebCore

Update TrackBase to store m_mediaElement as a WeakPtr
​https://bugs.webkit.org/show_bug.cgi?id=205460

Patch by Doug Kelly <Doug Kelly> on 2019-12-19
Reviewed by Eric Carlson.

Store the HTMLMediaElement in TrackBase and related classes as a WeakPtr to give some proper idea of pointer lifetime, since while the
HTMLMediaElement is optional, if set, it should be a valid HTMLMediaElement.

No new tests since no functionality changed.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::videoTracks):
(WebCore::SourceBuffer::audioTracks):
(WebCore::SourceBuffer::textTracks):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackModeChanged):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::ensureAudioTracks):
(WebCore::HTMLMediaElement::ensureTextTracks):
(WebCore::HTMLMediaElement::ensureVideoTracks):

• html/track/AudioTrack.cpp:

(WebCore::AudioTrack::willRemove):
(WebCore::AudioTrack::setMediaElement):

• html/track/AudioTrack.h:
• html/track/AudioTrackList.cpp:

(WebCore::AudioTrackList::AudioTrackList):

• html/track/AudioTrackList.h:
• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::willRemove):
(WebCore::InbandTextTrack::setMediaElement):

• html/track/InbandTextTrack.h:
• html/track/TextTrackList.cpp:

(WebCore::TextTrackList::TextTrackList):

• html/track/TextTrackList.h:
• html/track/TrackBase.cpp:

(WebCore::TrackBase::element):
(WebCore::TrackBase::setMediaElement):

• html/track/TrackBase.h:

(WebCore::TrackBase::mediaElement):

• html/track/TrackListBase.cpp:

(WebCore::TrackListBase::TrackListBase):
(WebCore::TrackListBase::element const):

• html/track/TrackListBase.h:

(WebCore::TrackListBase::mediaElement const):

• html/track/VideoTrack.cpp:

(WebCore::VideoTrack::willRemove):
(WebCore::VideoTrack::setMediaElement):

• html/track/VideoTrack.h:
• html/track/VideoTrackList.cpp:

(WebCore::VideoTrackList::VideoTrackList):

• html/track/VideoTrackList.h:

6:11 PM Changeset in webkit [253808] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

Invalid assert with tracks not associated to media element
​https://bugs.webkit.org/show_bug.cgi?id=205360

Patch by Doug Kelly <Doug Kelly> on 2019-12-19
Reviewed by Eric Carlson.

Remove asserts around TextTrack when not attached to a media element and instead return a zero index.

• html/track/TextTrack.cpp:

(WebCore::TextTrack::trackIndex):
(WebCore::TextTrack::trackIndexRelativeToRenderedTracks):

6:04 PM Changeset in webkit [253807] by sihui_liu@apple.com

• 5 edits in trunk

IndexedDB: remove timer for pending operations in IDBTransaction
​https://bugs.webkit.org/show_bug.cgi?id=205312

Reviewed by Brady Eidson.

When pendingOperationTimer fired, IDBTransasction would try processing pending operations or commiting
automatically.
pendingOperationTimer was scheduled when some conditions changed and IDBTransaction could start processing
pending operations or start commiting, for example, when new pending operations was created.

For better performance, we may start processing right away after the condition change, without using a Timer.
This patch gives us about 10% speed up on test: PerformanceTests/IndexedDB/basic/objectstore-cursor.html.

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abortInProgressOperations):
(WebCore::IDBTransaction::removeRequest):
(WebCore::IDBTransaction::scheduleOperation):
(WebCore::IDBTransaction::finishedDispatchEventForRequest):
(WebCore::IDBTransaction::didStart):
(WebCore::IDBTransaction::operationCompletedOnClient):
(WebCore::IDBTransaction::deactivate):
(WebCore::IDBTransaction::connectionClosedFromServer):
(WebCore::IDBTransaction::handlePendingOperations):
(WebCore::IDBTransaction::autoCommit):
(WebCore::IDBTransaction::trySchedulePendingOperationTimer): Deleted.
(WebCore::IDBTransaction::pendingOperationTimerFired): Deleted.

• Modules/indexeddb/IDBTransaction.h:

6:03 PM Changeset in webkit [253806] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Nullptr crash in WebCore::RenderTreeBuilder::attach
​https://bugs.webkit.org/show_bug.cgi?id=205476

Patch by Jack Lee <Jack Lee> on 2019-12-19
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/ruby/crash-insert-duplicate-rt-element.html

• rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::RenderTreeBuilder::Ruby::attach):

LayoutTests:

• fast/ruby/crash-insert-duplicate-rt-element-expected.txt: Added.
• fast/ruby/crash-insert-duplicate-rt-element.html: Added.

6:00 PM Changeset in webkit [253805] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Nullptr crash in WebCore::findPlaceForCounter with display: contents parent
​https://bugs.webkit.org/show_bug.cgi?id=205290

Patch by Jack Lee <Jack Lee> on 2019-12-19
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/css/counters/findPlaceForCounter-crash.html

• rendering/RenderCounter.cpp:

(WebCore::parentOrPseudoHostElement):

LayoutTests:

• fast/css/counters/findPlaceForCounter-crash-expected.txt: Added.
• fast/css/counters/findPlaceForCounter-crash.html: Added.

5:06 PM Changeset in webkit [253804] by Jonathan Bedard

• 23 edits in trunk/Tools

Python 3: Add support to run-webkit-tests
​https://bugs.webkit.org/show_bug.cgi?id=205291

Reviewed by Stephanie Lewis.

• Scripts/test-webkitpy-python3: Add webkitpy.layout_tests.
• Scripts/webkitpy/common/message_pool.py:

(_MessagePool._loop): Move exception inside of loop.
(_Message.repr): Use .format strings.
(_Worker.init): Ditto.

• Scripts/webkitpy/common/wavediff.py:

(WaveDiff.init): Use Python 3 compatible BytesIO and StringIO.

• Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:

(LayoutTestFinder._read_test_names_from_file): Use .format string.
(LayoutTestFinder.split_into_chunks): Explicitly use integer division.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._get_test_inputs): Use range over xrange.

• Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._handle_error): Use .format strings.

• Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator._insert_failure_summaries): Use Python 3 compatible itervalues.

• Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init): Sort type list.

• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.setUp): Multiple processes are buggy in test-webkitpy.
(RunTest.test_basic): replace buflist with getvalue().
(RunTest.test_child_processes_2): Ditto.
(RunTest.test_child_processes_min): Ditto.
(RunTest.test_keyboard_interrupt): Ditto.
(RunTest.test_missing_and_unexpected_results): Compare dictionaries instead of json strings.
(RunTest.test_crash_with_stderr): Ditto.
(RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist): Ditto.
(EndToEndTest.test_reftest_with_two_notrefs): Ditto.

• Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.write): Flush stream after writing.
(MeteredStream._erase_last_partial_line): Ditto.

• Scripts/webkitpy/layout_tests/views/printing.py:

(Printer._print_directory_timings): Can't compare string to integer.
(Printer._print_statistics_for_test_timings): Use integer division.

• Scripts/webkitpy/port/darwin.py:

(DarwinPort._merge_crash_logs): Use items over iteritems.

• Scripts/webkitpy/port/device.py:

(Device.hash): Allow hashing of devices.

• Scripts/webkitpy/port/device_port.py:

(DevicePort._install): Use range over xrange.
(DevicePort.setup_test_run): Ditto.
(DevicePort.clean_up_test_run): Ditto.

• Scripts/webkitpy/port/driver.py:

(DriverOutput.init): Text should be decoded, audio encoded.
(Driver.init):
(Driver.run_test):
(Driver._parse_child_processes_output): Output is byte array.
(Driver._check_for_driver_timeout): Ditto.
(Driver._check_for_address_sanitizer_violation): Error lines are byte arrays.
(Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
(Driver._read_optional_image_block): If a block is base64 encoded, we want the decoded
content, otherwise, we want the encoded content.
(Driver._read_header): Lines are byte arrays, decode them before processing.
(Driver._process_stdout_line): Blocks are byte arrays.
(Driver._strip_eof): Lines should be byte arrays, not strings.
(Driver._read_block): Standardize encoding in blocks.
(ContentBlock.init): Content should be a byte array.
(ContentBlock.decode_content): Attempt to decode content.

• Scripts/webkitpy/port/driver_unittest.py:

(DriverTest.test_read_binary_block): Content should be encoded.
(DriverTest.test_read_base64_block): Ditto.
(DriverTest.test_check_for_driver_crash): ServerProcess output should be a byte array.

• Scripts/webkitpy/port/image_diff.py:

(ImageDiffer.diff_image): ImageDiff output is in byte arrays.
(ImageDiffer._read): Ditto.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess.write): Encode data before writing it.

• Scripts/webkitpy/port/server_process_mock.py:

(MockServerProcess.init): Convert string mock output to bytes.
(MockServerProcess.read_stdout_line): Stdout lines are byte arrays.
(MockServerProcess.read_stdout): Ditto.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.NonBlockingFileFromSocket.close): Don't double close socket in Python 3.
(SimulatorProcess._start): Stdin should be a binary stream.

• Scripts/webkitpy/port/test.py:

(unit_test_list): Convert audio streams to byte arrays.

• Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.is_usable): Decode xcrun output.
(SimulatedDevice.install_app): Use xrange over range.

5:02 PM Changeset in webkit [253803] by cturner@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] http/tests/media/clearkey/collect-webkit-media-session.html is timing out since added in r235429 "WebKitMediaSession should be GC collectable when its document is being stopped"
​https://bugs.webkit.org/show_bug.cgi?id=189345

Unreviewed gardening.

• platform/gtk/TestExpectations: This test is for legacy encrypted media, which we have deprecated, and further uses an EXT-X-KEY URI scheme that will be unsupported by GStreamer (the "clearkey" scheme is not spec'd anywhere I could find).

4:50 PM Changeset in webkit [253802] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Enable p3 color picker by default
​https://bugs.webkit.org/show_bug.cgi?id=203931
<rdar://problem/56965236>

Reviewed by Devin Rousso.

• UserInterface/Base/Setting.js:
• UserInterface/Views/InlineSwatch.js:

4:46 PM Changeset in webkit [253801] by Devin Rousso

• 2 edits in trunk/Source/JavaScriptCore

Web Inspector: TypeError: InjectedScriptHost.isPromiseRejectedWithNativeGetterTypeError first argument must be a Promise
​https://bugs.webkit.org/show_bug.cgi?id=205439

Reviewed by Brian Burg.

Before r244312, we noticed that when Web Inspector would preview native getters that return
a Promise, Web Inspector would prevent rejectionhandled events from being fired since it
would always add a .catch(() => {} to any Promise that it was about to instrument in the
Console to avoid errors being added to the Console while expanding/collapsing value previews.
In order to prevent this, logic was added so that the .catch(() => {}) was only added if
the Promise was returned from a native getter, such as from a PromiseRejectionEvent.

In r244312, we made it such that this logic _required_ the Promise to already be rejected,
which is unnecessarily restrictive and not always the case nowadays. Instead, just check to
see if the result of the Promise is a native getter type error.

• inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::isPromiseRejectedWithNativeGetterTypeError):

4:32 PM Changeset in webkit [253800] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Console: the clear console button is hidden at smaller widths
​https://bugs.webkit.org/show_bug.cgi?id=205438

Reviewed by Brian Burg.

Ever since r242604, we no longer "need" to show the text filter bar or message type scope
bar since new messages will show a warning banner that there's an active filter. Instead, we
should prefer showing the navigation items that control functionality that cannot be reached
anywhere else (visually), such as clearing the console or evaluating as a user gesture.

• UserInterface/Views/LogContentView.js:

(WI.LogContentView):
Make the text find banner and type scope bar both low priority, the preserve log and
evaluate as user gesture toggles normal priority, and the clear log high priority.

4:28 PM Changeset in webkit [253799] by Chris Dumez

• 12 edits
  3 adds in trunk

REGRESSION: (r251677) imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205164
<rdar://problem/57879042>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline tests that are now passing.

• web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-3-expected.txt:
• web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit-expected.txt:

Source/WebCore:

Submitting a form should cancel any pending navigation scheduled by a previous submission of this form:

• ​https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm (step 22.3)

No new tests, rebaselined existing tests.

Test: fast/forms/form-double-submission.html

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submit):

• html/HTMLFormElement.h:
• loader/FormSubmission.h:

(WebCore::FormSubmission::cancel):
(WebCore::FormSubmission::wasCancelled const):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
Drop previous non-standard compliant logic to avoid double-form submission.

• loader/NavigationScheduler.cpp:

LayoutTests:

• fast/forms/form-double-submission-expected.txt: Added.
• fast/forms/form-double-submission.html: Added.
• fast/forms/resources/form-double-submission-frame.html: Added.

Add layout test for the regression that was introduced the first time this patch landed.

• http/tests/misc/multiple-submit-expected.txt:

Rebaseline test due to behavior change. I have verified that our new behavior on this test is
aligned with Firefox 71 and Chrome 79.

• platform/mac/TestExpectations:

Unskip tests that are no longer flaky.

4:03 PM Changeset in webkit [253798] by Brent Fulgham

• 5 edits in trunk/Source/WebKit

Log telemetry for IOUserClient lookups
​https://bugs.webkit.org/show_bug.cgi?id=205463
<rdar://problem/57987372>

Reviewed by Per Arne Vollan.

This patch adds some telemetry for IOKit classes.

No new tests. No change in behavior.

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

3:54 PM Changeset in webkit [253797] by Jonathan Bedard

• 1 edit
  1 add in trunk/LayoutTests/imported/w3c

2019-12-19 Jonathan Bedard <Jonathan Bedard>

Resync web-platform-tests/WebIDL tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205418 (Follow-up fix)

Unreviewed follow-up fix.

• web-platform-tests/interfaces/WebIDL.idl: Added.

3:52 PM Changeset in webkit [253796] by Alan Coon

• 1 copy in tags/Safari-608.5.6

Tag Safari-608.5.6.

3:51 PM Changeset in webkit [253795] by Chris Dumez

• 1 edit
  3 adds in trunk/LayoutTests

Unreviewed, land missing iOS baselines from r253791.

• platform/ios-wk2/imported/w3c/web-platform-tests/html/browsers/sandboxing/sandbox-parse-noscript-expected.txt: Added.
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/usvstring-reflection.https-expected.txt: Added.

3:49 PM Changeset in webkit [253794] by Chris Dumez

• 2 edits in trunk/Source/WebKit

Use a WeakHashSet for WKProcessAssertionBackgroundTaskManager._assertionsNeedingBackgroundTask
​https://bugs.webkit.org/show_bug.cgi?id=205471

Reviewed by Ryosuke Niwa.

Use a WeakHashSet for WKProcessAssertionBackgroundTaskManager._assertionsNeedingBackgroundTask, instead
of a HashSet of raw pointers, for extra safety.

• UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager removeAssertionNeedingBackgroundTask:]):
(-[WKProcessAssertionBackgroundTaskManager _notifyAssertionsOfImminentSuspension]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):

3:47 PM Changeset in webkit [253793] by Chris Dumez

• 12 edits in trunk/LayoutTests

Unreviewed, land iOS baselines missing from r253791.

• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-metadata-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
• platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/abspos-dialog-layout-expected.txt:

3:38 PM Changeset in webkit [253792] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Unblock iokit-get-property needed for frame buffer initialization
​https://bugs.webkit.org/show_bug.cgi?id=205468
<rdar://problem/57897684>

Reviewed by Per Arne Vollan.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:54 PM Changeset in webkit [253791] by Chris Dumez

• 210 edits
  20 copies
  18 moves
  233 adds
  5 deletes in trunk

Resync web-platform-tests/html tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205424

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Resync web-platform-tests/html tests from upstream b5b7813e9ce247495b0df.

• resources/resource-files.json:
• web-platform-tests/html/*: Updated.

LayoutTests:

• TestExpectations:
• platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt:
• platform/mac/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
• tests-options.json:

2:48 PM Changeset in webkit [253790] by rniwa@webkit.org

• 3 edits
  2 adds in trunk

Make ShadowRoot.delegateFocus work in iOS
​https://bugs.webkit.org/show_bug.cgi?id=202875

Reviewed by Wenson Hsieh.

Source/WebCore:

This patch fixes the bug that a shadow tree doesn't recieve focus delegation even if the shadow host
had delegateFocus flag set unless the shadow host itself is focusable beacuse Frame's
nodeRespondingToClickEvents and friends would return false on the shadow host.

Test: fast/shadow-dom/delegates-focus-by-activation.html

• page/ios/FrameIOS.mm:

(WebCore::nodeIsMouseFocusable): Added the logic to handle shadow hosts whose shadow root has
delegates focus flag set.
(WebCore::nodeWillRespondToMouseEvents): Extracted out of approximateNodeAtViewportLocationLegacy.
(WebCore::Frame::approximateNodeAtViewportLocationLegacy):
(WebCore::ancestorRespondingToClickEventsNodeQualifier):

LayoutTests:

Added a regression test.

• fast/shadow-dom/delegates-focus-by-activation-expected.txt: Added.
• fast/shadow-dom/delegates-focus-by-activation.html: Added.

2:17 PM Changeset in webkit [253789] by Alan Coon

• 3 edits in branches/safari-609.1.13-branch/Source/WebKit

Cherry-pick r253761. rdar://problem/58080834

Remove syscall filtering from GPU Process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205456
<rdar://problem/58080834>

Reviewed by Tim Horton.

We don't have a fully built-out GPU Process yet. Let's not lock down the syscall filter set until
we know which are actually needed by the process. The current set is just copied over from the
WebContent process, and are not likely to be the correct set.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@253761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:10 PM Changeset in webkit [253788] by Kate Cheney

• 2 edits in trunk/Source/WebCore

Activate the SQLite database as an on-by-default feature
​https://bugs.webkit.org/show_bug.cgi?id=204774
<rdar://problem/57592141>

Reviewed by Brent Fulgham.

The ITP SQLite database should be on by default.

• page/RuntimeEnabledFeatures.h:

1:48 PM Changeset in webkit [253787] by Alan Coon

• 8 edits in tags/Safari-609.1.12.4/Source

Versioning.

1:45 PM Changeset in webkit [253786] by Matt Lewis

• 2 edits in trunk/Tools

Fixing Host name of gpu process bot
​https://bugs.webkit.org/show_bug.cgi?id=205469

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/build.webkit.org-config/config.json:

1:27 PM Changeset in webkit [253785] by Brent Fulgham

• 2 edits in trunk/Source/WebKit

Add telemetry to macOS WebContent sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205464
<rdar://problem/58087833>

Reviewed by Per Arne Vollan.

Add telemetry to various mach lookups, like we did for iOS.

No new tests. No change in behavior.

• WebProcess/com.apple.WebProcess.sb.in:

1:20 PM Changeset in webkit [253784] by pvollan@apple.com

• 9 edits
  1 delete in trunk/Source

REGRESSION (r253530): Incorrect colors in Dark Mode
​https://bugs.webkit.org/show_bug.cgi?id=205457

Unreviewed rollout of r253530.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:
• rendering/CSSValueKey.h: Removed.
• rendering/RenderThemeIOS.h:
• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::systemColor const):
(WebCore::cssValueIDSelectorList): Deleted.
(WebCore::systemColorFromCSSValueID): Deleted.
(WebCore::globalCSSValueToSystemColorMap): Deleted.
(WebCore::RenderThemeIOS::getOrCreateCSSValueToSystemColorMap): Deleted.
(WebCore::RenderThemeIOS::setCSSValueToSystemColorMap): Deleted.

Source/WebKit:

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

1:18 PM Changeset in webkit [253783] by Chris Dumez

• 12 edits
  2 copies
  136 adds
  2 deletes in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/WebIDL tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205418

Reviewed by Frédéric Wang.

Resync web-platform-tests/WebIDL tests from upstream 33de70caf7f076e.

• web-platform-tests/WebIDL/*: Updated.

12:32 PM Changeset in webkit [253782] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, unskip fast/workers/worker-cloneport.html on iOS.

This test appears to run fine on iOS now.

• platform/ios-wk2/TestExpectations:

12:23 PM Changeset in webkit [253781] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Deprecate _WKRemoteObjectInterface methods without ofReply:
​https://bugs.webkit.org/show_bug.cgi?id=205073

Patch by Alex Christensen <​achristensen@webkit.org> on 2019-12-19
Reviewed by Timothy Hatcher.

Using them makes it hard to figure out how to add classes allowed for the reply,
and there's a comment saying to deprecate them, so let's do it.

• Shared/API/Cocoa/_WKRemoteObjectInterface.h:

12:06 PM Changeset in webkit [253780] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed, rebaseline imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html on iOS.

• platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt:

12:04 PM Changeset in webkit [253779] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

ANGLE: Fix last WebGL conformance regressions
​https://bugs.webkit.org/show_bug.cgi?id=205306

Fixes the last few WebGL conformance regressions when enabling ANGLE on AMD GPUs on Mac.
The combination of alpha:false and antialias:true was broken, and validation of
non-ascii characters in comments was broken by a recent change to the test.

Patch by James Darpinian <James Darpinian> on 2019-12-19
Reviewed by Dean Jackson.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::shaderSource):

• platform/graphics/angle/GraphicsContext3DANGLE.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

12:00 PM Changeset in webkit [253778] by Brent Fulgham

• 8 edits
  3 adds in trunk

WebContent process does not need access to 'com.apple.system.logger'
​https://bugs.webkit.org/show_bug.cgi?id=205411
<rdar://problem/56966080>

Reviewed by Per Arne Vollan.

Source/WebKit:

Telemetry and thorough testing has confirmed that we do not need access to this
mach service, and so should remove it.

Tested by fast/sandbox.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• WebProcess/com.apple.WebProcess.sb.in:

LayoutTests:

• TestExpectations:
• fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
• fast/sandbox/ios/sandbox-mach-lookup.html:
• fast/sandbox/mac/sandbox-mach-lookup-expected.txt: Added.
• fast/sandbox/mac/sandbox-mach-lookup.html: Added.
• platform/mac-wk2/TestExpectations:

11:48 AM Changeset in webkit [253777] by Brent Fulgham

• 5 edits in trunk

Deny mach lookup access to "com.apple.TextInput" in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=205423
<rdar://problem/56990842>

Reviewed by Per Arne Vollan.

Source/WebKit:

Telemetry and thorough testing has confirmed that we do not need access to this
mach service, and so should remove it.

Tested by fast/sandbox/ios/sandbox-mach-lookup.html.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

• fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
• fast/sandbox/ios/sandbox-mach-lookup.html:

11:33 AM Changeset in webkit [253776] by Alan Coon

• 1 copy in tags/Safari-609.1.12.4

New tag.

11:29 AM Changeset in webkit [253775] by Antti Koivisto

• 6 edits
  1 add in trunk

Allow Vectors as hash keys
​https://bugs.webkit.org/show_bug.cgi?id=205449

Reviewed by Geoff Garen.

Source/WTF:

Add traits to allow Vectors of hashable types to act as hash keys.

• WTF.xcodeproj/project.pbxproj:
• wtf/Vector.h:

(WTF::Vector::Vector):
(WTF::Vector::~Vector):
(WTF::Vector::isHashTableDeletedValue const):

Use m_size = numeric_limits::max() as the deleted value.

• wtf/VectorHash.h: Added.

(WTF::VectorHash::hash):
(WTF::VectorHash::equal):

Add traits. Empty Vector is the empty value.

Tools:

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

11:27 AM Changeset in webkit [253774] by Alan Coon

• 2 edits in branches/safari-609.1.13-branch/Source/WebKit

Cherry-pick r253696. rdar://problem/58046272

Add syscall to GPU Process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205400
<rdar://problem/58046272>

Reviewed by Simon Fraser.

This patch temporarily adds a syscall to the sandbox to work around a bug in the
system Sandbox framework. We will remove this in Bug 205400 once that issue is
resolved.

• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@253696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:27 AM Changeset in webkit [253773] by Alan Coon

• 9 edits
  1 delete in branches/safari-609.1.13-branch/Source

Revert r253530. rdar://problem/58070303

11:24 AM Changeset in webkit [253772] by Alan Coon

• 10 edits in branches/safari-609.1.13-branch

Revert "Revert "Revert r253493. rdar://problem/58028534""

This reverts fixes a ChangeLog Unicode issue and re-applies the revert of r253493.

11:23 AM Changeset in webkit [253771] by Alan Coon

• 10 edits in branches/safari-609.1.13-branch

Revert "Revert r253493. rdar://problem/58028534"

This reverts revision r253726.

11:20 AM Changeset in webkit [253770] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r253711.

Broke two tests on Mac and iOS

Reverted changeset:

"[LFC][IFC] LineLayoutContext::m_uncommittedList is not always
a continuous list of runs"
​https://bugs.webkit.org/show_bug.cgi?id=205404
​https://trac.webkit.org/changeset/253711

10:51 AM Changeset in webkit [253769] by Andres Gonzalez

• 6 edits in trunk/Source/WebCore

AXIsolatedObject::findMatchingObjects implementation.
​https://bugs.webkit.org/show_bug.cgi?id=205428

Reviewed by Chris Fleizach.

This method is exercised by several layout tests such as
accessibility/mac/search-predicate.html.

• Moved the search algorithm in the implementation of

AccessibilityObject::findMatchingObjects to the Accessibility namespace,
so that it can be used in AXIsolatedObject as well.

• Static helper functions are also moved into the Accessibility

namespace.

• Changed the signature of containsText to be more appropriate and in

line with other methods.

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::containsText const):
(WebCore::AccessibilityObject::findMatchingObjects):
(WebCore::Accessibility::isAccessibilityObjectSearchMatchAtIndex): Moved from AccessibilityObject.
(WebCore::Accessibility::isAccessibilityObjectSearchMatch): Moved from AccessibilityObject.
(WebCore::Accessibility::isAccessibilityTextSearchMatch): Moved from AccessibilityObject.
(WebCore::Accessibility::objectMatchesSearchCriteriaWithResultLimit): Moved from AccessibilityObject.
(WebCore::Accessibility::findMatchingObjects): Search algorithm to be reused by AccessibilityObject and AXIsolatedObject.
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatchAtIndex): Moved.
(WebCore::AccessibilityObject::isAccessibilityObjectSearchMatch): Moved.
(WebCore::AccessibilityObject::isAccessibilityTextSearchMatch): Moved.
(WebCore::AccessibilityObject::objectMatchesSearchCriteriaWithResultLimit): Moved.

• accessibility/AccessibilityObject.h:
• accessibility/AccessibilityObjectInterface.h:
• accessibility/isolatedtree/AXIsolatedTreeNode.cpp:

(WebCore::AXIsolatedObject::findMatchingObjects):
(WebCore::AXIsolatedObject::containsText const):

• accessibility/isolatedtree/AXIsolatedTreeNode.h:

10:48 AM Changeset in webkit [253768] by Chris Dumez

• 2 edits in trunk/LayoutTests

Unreviewed tests gardening

Mark imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-double-submit.html as flaky.

• platform/mac/TestExpectations:

10:36 AM Changeset in webkit [253767] by youenn@apple.com

• 4 edits in trunk

CacheStorageEngine should not clear caches memory representation for ephemeral sessions
​https://bugs.webkit.org/show_bug.cgi?id=205332

Reviewed by Chris Dumez.

Source/WebKit:

• NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::dispose):
We cannot dispose an ephemeral cache memory representation
since it can be reopened by a page with the same session.

LayoutTests:

• TestExpectations:

10:33 AM Changeset in webkit [253766] by Brent Fulgham

• 5 edits in trunk

Deny mach lookup access to "com.apple.pluginkit.pkd" in the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=205421
<rdar://problem/56995585>

Reviewed by Per Arne Vollan.

Source/WebKit:

Telemetry and thorough testing has confirmed that we do not need access to this
mach service, and so should remove it.

Tested by fast/sandbox/ios/sandbox-mach-lookup.html.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

LayoutTests:

• fast/sandbox/ios/sandbox-mach-lookup-expected.txt:
• fast/sandbox/ios/sandbox-mach-lookup.html:

10:31 AM Changeset in webkit [253765] by Alan Coon

• 3 edits in tags/Safari-609.1.12.3/Source/WebKit

Cherry-pick r253761. rdar://problem/58080834

Remove syscall filtering from GPU Process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205456
<rdar://problem/58080834>

Reviewed by Tim Horton.

We don't have a fully built-out GPU Process yet. Let's not lock down the syscall filter set until
we know which are actually needed by the process. The current set is just copied over from the
WebContent process, and are not likely to be the correct set.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@253761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:20 AM Changeset in webkit [253764] by jer.noble@apple.com

• 2 edits in trunk/Source/WTF

Safely iterate observers in languageDidChange()
​https://bugs.webkit.org/show_bug.cgi?id=205452
<rdar://problem/57937765>

Reviewed by Eric Carlson.

Use the "copyToVector() then verify each item is still in the original
map" pattern to safely iterate over the observerMap().

• wtf/Language.cpp:

(WTF::languageDidChange):

10:13 AM Changeset in webkit [253763] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, address imported/w3c/web-platform-tests/css/css-properties-values-api/url-resolution.html flakiness

LayoutTests/imported/w3c:

• web-platform-tests/css/css-properties-values-api/url-resolution-expected.txt:

LayoutTests:

• TestExpectations:

10:04 AM Changeset in webkit [253762] by Wenson Hsieh

• 6 edits in trunk/Source/WebCore

pal/FileSizeFormatter.h declares fileSizeDescription in the top-level namespace
​https://bugs.webkit.org/show_bug.cgi?id=205453

Reviewed by Tim Horton.

Source/WebCore:

Change fileSizeDescription to PAL::fileSizeDescription. No change in behavior.

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::setFile):
(WebCore::HTMLAttachmentElement::updateAttributes):

Source/WebCore/PAL:

Move fileSizeDescription to the PAL namespace.

• pal/FileSizeFormatter.cpp:

(fileSizeDescription): Deleted.

• pal/FileSizeFormatter.h:
• pal/cocoa/FileSizeFormatterCocoa.mm:

(fileSizeDescription): Deleted.

9:59 AM Changeset in webkit [253761] by Brent Fulgham

• 3 edits in trunk/Source/WebKit

Remove syscall filtering from GPU Process sandbox
​https://bugs.webkit.org/show_bug.cgi?id=205456
<rdar://problem/58080834>

Reviewed by Tim Horton.

We don't have a fully built-out GPU Process yet. Let's not lock down the syscall filter set until
we know which are actually needed by the process. The current set is just copied over from the
WebContent process, and are not likely to be the correct set.

• GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
• Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:

9:55 AM Changeset in webkit [253760] by Chris Dumez

• 16 edits
  1 move
  15 adds
  2 deletes in trunk

Resync web-platform-tests/beacon tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205417

Reviewed by Youenn Fablet.

Resync web-platform-tests/beacon tests from upstream 33de70caf7f076e.

• web-platform-tests/beacon/*: Updated.

9:48 AM Changeset in webkit [253759] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: exiting edit mode with the same selection as before entering edit mode doesn't reselect
​https://bugs.webkit.org/show_bug.cgi?id=205435

Reviewed by Brian Burg.

• UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
Set allowsRepeatSelection so that selecting the previously selected tree element after
leaving edit mode will actually work.

9:48 AM Changeset in webkit [253758] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements: Styles: bezier keywords don't show a swatch
​https://bugs.webkit.org/show_bug.cgi?id=205436

Reviewed by Brian Burg.

• UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._addTimingFunctionTokens):
Check if the current token is a direct match with one of the timing function keywords.

9:33 AM Changeset in webkit [253757] by Devin Rousso

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: importing a result with DOM nodes that don't match the inspected page appear as empty lines
​https://bugs.webkit.org/show_bug.cgi?id=205437

Reviewed by Brian Burg.

• UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView.prototype.layout):
Call refresh on the CodeMirror instance after a timeout to give it a chance to be added
to the DOM tree.

9:15 AM Changeset in webkit [253756] by Chris Dumez

• 1 edit
  2 adds in trunk/LayoutTests

Unreviewed, land iOS specific baseline missing from r253738.

• platform/ios-wk2/imported/w3c/web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt: Added.

9:07 AM Changeset in webkit [253755] by Truitt Savell

• 3 edits in trunk/LayoutTests

Folloup test expectations cleanup for r253594
​https://bugs.webkit.org/show_bug.cgi?id=205308

Unreviewed test gardening.

• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:

8:40 AM Changeset in webkit [253754] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: [ Mac Debug wk1 ] accessibility/mac/expanded-notification.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205410

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

8:36 AM Changeset in webkit [253753] by Truitt Savell

• 2 edits in trunk/LayoutTests

REGRESSION: [ Mojave Debug wk1 ] webgl/1.0.3/conformance/rendering/many-draw-calls.html is Timing out
​https://bugs.webkit.org/show_bug.cgi?id=205412

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

7:59 AM Changeset in webkit [253752] by Chris Dumez

• 16 edits in trunk

imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=205408

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline test now that it is consistently passing.

• web-platform-tests/service-workers/service-worker/skip-waiting-installed.https-expected.txt:

Source/WebCore:

imported/w3c/web-platform-tests/service-workers/service-worker/skip-waiting-installed.https.html has been
flaky since it was imported. We now queue a task on the HTML event loop to resolve the skipWaiting promise
so that its ordering is correct, between the active event being fired and the service worker state becoming
"activated".

No new tests, upskipped existing test.

• workers/service/ServiceWorkerGlobalScope.cpp:

(WebCore::ServiceWorkerGlobalScope::skipWaiting):

• workers/service/context/SWContextManager.h:
• workers/service/server/SWServerToContextConnection.cpp:

(WebCore::SWServerToContextConnection::skipWaiting):

• workers/service/server/SWServerToContextConnection.h:

Source/WebKit:

• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::didFinishSkipWaiting): Deleted.

• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
• NetworkProcess/ServiceWorker/WebSWServerToContextConnection.messages.in:
• WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::skipWaiting):
(WebKit::WebSWContextManagerConnection::didFinishSkipWaiting): Deleted.

• WebProcess/Storage/WebSWContextManagerConnection.h:
• WebProcess/Storage/WebSWContextManagerConnection.messages.in:

LayoutTests:

Unskip test.

• TestExpectations:

7:48 AM Changeset in webkit [253751] by Chris Dumez

• 10 edits in trunk/Source

Stop blocking the worker thread in WorkerMessagePortChannelProvider::postMessageToRemote()
​https://bugs.webkit.org/show_bug.cgi?id=205414

Reviewed by Youenn Fablet.

Source/WebCore:

Stop blocking the worker thread in WorkerMessagePortChannelProvider::postMessageToRemote() as it does not appear
to be needed and it badly impacts performance. This basically replaces a callOnMainThreadAndWait
call (which was added in r249378 as part of a refactoring) with a callOnMainThread call.

This makes fast/workers/worker-cloneport.html runs twice as fast on my machine, which is important
because this test is so slow it is timing out in some configurations.

• dom/MessagePort.cpp:

(WebCore::MessagePort::postMessage):

• dom/messageports/MessagePortChannelProvider.h:
• dom/messageports/MessagePortChannelProviderImpl.cpp:

(WebCore::MessagePortChannelProviderImpl::postMessageToRemote):

• dom/messageports/MessagePortChannelProviderImpl.h:
• dom/messageports/WorkerMessagePortChannelProvider.cpp:

(WebCore::WorkerMessagePortChannelProvider::postMessageToRemote):

• dom/messageports/WorkerMessagePortChannelProvider.h:

Source/WebKit:

• WebProcess/WebCoreSupport/WebMessagePortChannelProvider.cpp:

(WebKit::WebMessagePortChannelProvider::postMessageToRemote):

• WebProcess/WebCoreSupport/WebMessagePortChannelProvider.h:

7:15 AM Changeset in webkit [253750] by Wenson Hsieh

• 3 edits
  2 adds in trunk

REGRESSION (r251015): Hitting return before a space deletes text after the insertion position
​https://bugs.webkit.org/show_bug.cgi?id=205425
<rdar://problem/57575960>

Reviewed by Tim Horton.

Source/WebCore:

After r251015, we (rightfully) no longer call ensureLineBoxes() when computing upstream or downstream positions.
However, logic in deleteInsignificantTextDownstream (which is invoked after hitting return before a space in a
text node) assumes that line boxes must be generated for the RenderText of the text node containing the
downstream position. The lack of inline text boxes then causes deleteInsignificantText to always remove the
entire text node.

To fix this, have deleteInsignificantText ensure that line boxes exist for the text node's renderer, right
before asking for the renderer's line boxes.

Test: editing/inserting/insert-paragraph-before-space.html

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::deleteInsignificantText):

LayoutTests:

Add a layout test to exercise this bug, by executing "insertParagraph" in a text node before a space.

• editing/inserting/insert-paragraph-before-space-expected.txt: Added.
• editing/inserting/insert-paragraph-before-space.html: Added.

5:54 AM Changeset in webkit [253749] by Carlos Garcia Campos

• 49 edits
  13 adds
  3 deletes in trunk

[GTK][WPE] Add initial API for input method
​https://bugs.webkit.org/show_bug.cgi?id=204679

Reviewed by Žan Doberšek.

Source/WebCore:

• platform/PlatformKeyboardEvent.h: Also define handledByInputMethod() for WPE port.

Source/WebKit:

In the case of GTK port, it allows to use a custom IM instead of GtkIMContext that it's still used by
default. In the case of WPE it brings IM support, but there's no default implementation so applications need to
provide their own.

• PlatformGTK.cmake: Add new public header WebKitInputMethodContext.h.
• PlatformWPE.cmake: Ditto.
• Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const): Encode caretRectAtStart for WPE too.
(WebKit::EditorState::PostLayoutData::decode): Decode caretRectAtStart for WPE too.
(WebKit::operator<<): Dump caretRectAtStart for WPE too.

• Shared/EditorState.h: Define caretRectAtStart for WPE too.
• Shared/NativeWebKeyboardEvent.h:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): Remove FakedForComposition parameter for GTK and add
HandledByInputMethod to WPE.

• Shared/WebEvent.h:
• Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent): Add handledByInputMethod parameter for WPE.
(WebKit::WebKeyboardEvent::encode const): Encode m_handledByInputMethod in WPE too.
(WebKit::WebKeyboardEvent::decode): Decode m_handledByInputMethod in WPE too.

• Shared/gtk/NativeWebKeyboardEventGtk.cpp:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): Remove FakedForComposition and the redundant members
that are already in the bcase class or no longer needed.

• Shared/libwpe/NativeWebKeyboardEventLibWPE.cpp:

(WebKit::NativeWebKeyboardEvent::NativeWebKeyboardEvent): Add text and handledByInputMethod parameters

• Shared/libwpe/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent): Use the given text if not null and pass handledByInputMethod,
to WebKeyboardEvent.

• Shared/libwpe/WebEventFactory.h:
• SourcesGTK.txt: Add new files to compilation.
• SourcesWPE.txt: Ditto.
• UIProcess/API/glib/InputMethodFilter.cpp: Added.

(WebKit::InputMethodFilter::~InputMethodFilter):
(WebKit::InputMethodFilter::preeditStartedCallback):
(WebKit::InputMethodFilter::preeditChangedCallback):
(WebKit::InputMethodFilter::preeditFinishedCallback):
(WebKit::InputMethodFilter::committedCallback):
(WebKit::InputMethodFilter::setContext):
(WebKit::InputMethodFilter::setEnabled):
(WebKit::InputMethodFilter::filterKeyEvent):
(WebKit::InputMethodFilter::isViewFocused const):
(WebKit::InputMethodFilter::notifyFocusedIn):
(WebKit::InputMethodFilter::notifyFocusedOut):
(WebKit::InputMethodFilter::notifyCursorRect):
(WebKit::InputMethodFilter::preeditStarted):
(WebKit::InputMethodFilter::preeditChanged):
(WebKit::InputMethodFilter::preeditFinished):
(WebKit::InputMethodFilter::committed):
(WebKit::InputMethodFilter::cancelComposition):

• UIProcess/API/glib/InputMethodFilter.h: Added.

(WebKit::InputMethodFilter::context const):

• UIProcess/API/glib/WebKitInputMethodContext.cpp: Added.

(webkitInputMethodUnderlineGetCompositionUnderline):
(webkit_input_method_underline_new):
(webkit_input_method_underline_copy):
(webkit_input_method_underline_free):
(webkitInputMethodContextSetWebView):
(webkitInputMethodContextGetWebView):
(webkit_input_method_context_set_enable_preedit):
(webkit_input_method_context_get_preedit):
(webkit_input_method_context_notify_focus_in):
(webkit_input_method_context_notify_focus_out):
(webkit_input_method_context_notify_cursor_area):
(webkit_input_method_context_reset):

• UIProcess/API/glib/WebKitInputMethodContextPrivate.h: Added.

(_WebKitInputMethodUnderline::_WebKitInputMethodUnderline):

• UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewConstructed):
(webkitWebViewSynthesizeCompositionKeyPress):
(webkitWebViewSetComposition):
(webkitWebViewConfirmComposition):
(webkitWebViewCancelComposition):
(webkit_web_view_set_input_method_context):
(webkit_web_view_get_input_method_context):

• UIProcess/API/glib/WebKitWebViewPrivate.h:
• UIProcess/API/gtk/InputMethodFilterGtk.cpp: Added.

(WebKit::InputMethodFilter::platformTransformCursorRectToViewCoordinates):
(WebKit::InputMethodFilter::platformEventKeyIsKeyPress const):

• UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithKeyEvent): Remove the early return in case of fake event, composition events
are always handled by the web process.

• UIProcess/API/gtk/WebKitInputMethodContext.h: Added.
• UIProcess/API/gtk/WebKitInputMethodContextGtk.cpp: Added.

(webkit_input_method_underline_set_color):
(webkit_input_method_context_filter_key_event):

• UIProcess/API/gtk/WebKitInputMethodContextImplGtk.cpp: Added.

(contextPreeditStartCallback):
(contextPreeditChangedCallback):
(contextPreeditEndCallback):
(contextCommitCallback):
(webkitInputMethodContextImplGtkConstructed):
(webkitInputMethodContextImplGtkSetEnablePreedit):
(webkitInputMethodContextImplGtkGetPreedit):
(webkitInputMethodContextImplGtkFilterKeyEvent):
(webkitInputMethodContextImplGtkNotifyFocusIn):
(webkitInputMethodContextImplGtkNotifyFocusOut):
(webkitInputMethodContextImplGtkNotifyCursorArea):
(webkitInputMethodContextImplGtkReset):
(webkit_input_method_context_impl_gtk_class_init):
(webkitInputMethodContextImplGtkNew):
(webkitInputMethodContextImplGtkSetClientWindow):

• UIProcess/API/gtk/WebKitInputMethodContextImplGtk.h: Added.
• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize): If current IM filter is the default one, call webkitInputMethodContextImplGtkSetClientWindow().
(webkitWebViewBaseUnrealize): Ditto.
(webkitWebViewBaseDispose): Set a nullptr context on IM filter.
(webkitWebViewBaseKeyPressEvent): Use the new IM filter that simplifies the code.
(webkitWebViewBaseKeyReleaseEvent): Ditto.
(webkitWebViewBaseHandleMouseEvent): Cancel composition in case of click.
(webkitWebViewBaseCreateWebPage): The new IM filter doesn't need to know the page.
(webkitWebViewBaseUpdateTextInputState): Use new IM filter API.
(webkitWebViewBaseSetInputMethodContext): Set the IM filter context.
(webkitWebViewBaseGetInputMethodContext): Get the IM filter context.
(webkitWebViewBaseSynthesizeCompositionKeyPress): Synthesize a key event for composition.

• UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
• UIProcess/API/gtk/webkit2.h:
• UIProcess/API/wpe/InputMethodFilterWPE.cpp: Added.

(WebKit::InputMethodFilter::platformTransformCursorRectToViewCoordinates):
(WebKit::InputMethodFilter::platformEventKeyIsKeyPress const):

• UIProcess/API/wpe/PageClientImpl.cpp:

(WebKit::PageClientImpl::setInputMethodState):
(WebKit::PageClientImpl::selectionDidChange):

• UIProcess/API/wpe/PageClientImpl.h:
• UIProcess/API/wpe/WPEView.cpp:

(WKWPE::View::setInputMethodContext): Set the IM filter context.
(WKWPE::View::inputMethodContext const): Get the IM filter context.
(WKWPE::View::setInputMethodState): Enable or disable input methods.
(WKWPE::View::selectionDidChange): Notify the IM filter about the cursor position change.
(WKWPE::View::setViewState): Notify the IM filter about the focus change.
(WKWPE::View::handleKeyboardEvent): Allow the IM filter to handle the key event.
(WKWPE::View::synthesizeCompositionKeyPress): Synthesize a key event for composition.

• UIProcess/API/wpe/WPEView.h:
• UIProcess/API/wpe/WebKitInputMethodContext.h: Added.
• UIProcess/API/wpe/WebKitInputMethodContextWPE.cpp: Added.

(webkit_input_method_underline_set_color):
(webkit_input_method_context_filter_key_event):

• UIProcess/API/wpe/WebKitWebView.h:
• UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
• UIProcess/API/wpe/docs/wpe-docs.sgml:
• UIProcess/API/wpe/webkit.h:
• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:
• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/gtk/InputMethodFilter.cpp: Removed.
• UIProcess/gtk/InputMethodFilter.h: Removed.
• UIProcess/wpe/WebPageProxyWPE.cpp:

(WebKit::WebPageProxy::updateEditorState): Save the editor state and notify about selection change.
(WebKit::WebPageProxy::setInputMethodState): Notify the page client about the input method state.

• WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::setInputMethodState): Implement this for WPE too.

• WebProcess/WebCoreSupport/wpe/WebEditorClientWPE.cpp:

(WebKit::WebEditorClient::handleInputMethodKeydown): Use handledByInputMethod() now.

• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/wpe/WebPageWPE.cpp:

(WebKit::WebPage::platformEditorState const): Save the current caret cursor rectangle in post layout data struct.
(WebKit::WebPage::setInputMethodState): Send SetInputMethodState message to the UI process if state changed.

Tools:

Remove the old unit tests for InputMethodFilter and add new tests using the new API.

• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp: Removed.
• TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp: Added.

(webkitInputMethodContextMockFinalize):
(webkitInputMethodContextMockGetPreedit):
(webkitInputMethodContextMockFilterKeyEvent):
(webkitInputMethodContextMockNotifyFocusIn):
(webkitInputMethodContextMockNotifyFocusOut):
(webkitInputMethodContextMockReset):
(webkit_input_method_context_mock_class_init):
(webkit_input_method_context_mock_init):
(testWebKitInputMethodContextSimple):
(testWebKitInputMethodContextSequence):
(testWebKitInputMethodContextInvalidSequence):
(testWebKitInputMethodContextCancelSequence):
(testWebKitInputMethodContextReset):
(beforeAll):
(afterAll):

• TestWebKitAPI/glib/CMakeLists.txt:
• TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
• TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:

(WebViewTest::clickMouseButton):
(WebViewTest::keyStroke):

5:24 AM Changeset in webkit [253748] by cturner@igalia.com

• 3 edits in trunk/Source/WebCore

[GStreamer][EME] Notify all elements waiting for CDM attachment
​https://bugs.webkit.org/show_bug.cgi?id=205382

Reviewed by Xabier Rodriguez-Calvar.

When multiple demuxers are in flight asking for a CDM instance,
only one of them was getting woken up when a CDM was attached,
leaving the other(s) blocking their respective streaming threads
and locking the pipeline. Switch back to a condition variable from
a semaphore to fix this issue.

Covered by existing tests.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
Initialize the new isPlayerShuttingDown predicate to false.
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
Set the new predicate for player shutdown at the start of
destruction, so that background threads can known when the should
abort their operations as a result of being unblocked by the
destructor.
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage): Go back
to using condition variables, so we can unblock more than one
waiter.
(WebCore::MediaPlayerPrivateGStreamer::cdmInstanceAttached):
Helper predicate to make clear that the presence of a valid
CDMInstance pointer is a sign that it has been attached.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Add

an isPlayerShuttingDown method using an Atomic<bool>. We need this
to avoid racing set_context() on a decryptor element with the
pipeline being set to NULL. Before we were using the notifier as a
proxy for player shutdown, since it is invalidated during player
destruction. This is not a maintainable solution, since other
programmers would feel free to reorder the position at which the
notifier is invalidated, and then introduce a very hard to find
bug. By introducing this flag at the start of destruction, we will
always have a known way to check, after a streaming thread has
woken up again, whether we should call any player methods, or
return early due to shutdown in progress.
(WebCore::MediaPlayerPrivateGStreamer::isPlayerShuttingDown
const): Predicate for player in the process of shutdown. This
should be used by background threads, which upon wakeup, may need
to be aware of whether they will be in a race with the pipeline
going to NULL.
(WebCore::MediaPlayerPrivateGStreamer::isCDMAttached const):

4:54 AM Changeset in webkit [253747] by clopez@igalia.com

• 3 edits in trunk/LayoutTests

REGRESSION(r253683): [GTK][WPE] Lots of offscreen-canvas WPT tests failing

Unreviewed gardening. Skip the tests meanwhile the issue is not fixed.
See webkit.org/b/205445

• platform/gtk/TestExpectations:
• platform/wpe/TestExpectations:

3:31 AM Changeset in webkit [253746] by graouts@webkit.org

• 1 add in trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt

Animations stop if new tab opened (and closed)
​​https://bugs.webkit.org/show_bug.cgi?id=202360
<rdar://problem/55923261>

Unreviewed test gardening. Rolling back this platform-specific expectation which it looks like the bots are unhappy about.

• platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt: Added.

1:53 AM Changeset in webkit [253745] by ChangSeok Oh

• 2 edits in trunk/Source/ThirdParty/ANGLE

[GTK] Build fix for ANGLE_WEBGL after r253650
​https://bugs.webkit.org/show_bug.cgi?id=205426

Reviewed by Carlos Alberto Lopez Perez.

libglesv2_entry_points_headers was removed in r253650 that updated CMake for ANGLE.
GLESv2.cmake seems to be susceptible to ANGLE changes, so it might not be
a good place where any platform specific configuration is located.
Let's move the entry points header set to CMakeLists.txt.

• CMakeLists.txt:

1:44 AM Changeset in webkit [253744] by Carlos Garcia Campos

• 7 edits in trunk/Source

[CoordinatedGraphics] ThreadedDisplayRefreshMonitor is never released
​https://bugs.webkit.org/show_bug.cgi?id=205387

Reviewed by Žan Doberšek.

Source/WebCore:

The problem is that DisplayRefreshMonitorManager::createMonitorForClient() always creates a new one for
RenderingUpdateScheduler because it's not notified of the window screen change. So,
createDisplayRefreshMonitor() is called every time, which returns a reference of the same object, but it's added
to the monitors vector of DisplayRefreshMonitorManager and never removed from there.

• page/Chrome.cpp:

(WebCore::Chrome::windowScreenDidChange): Notify the RenderingUpdateScheduler about the screen change.

• page/RenderingUpdateScheduler.h: Make windowScreenDidChange public.

Source/WebKit:

Update the window screen ID after creating the layer tree host to ensure that the call to
createDisplayRefreshMonitor will create the ThreadedDisplayRefrershMonitor instead of the default one.

• WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Use the dispalyID of the layer tree host.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.cpp:

(WebKit::LayerTreeHost::LayerTreeHost): Initialize the display ID.

• WebProcess/WebPage/CoordinatedGraphics/LayerTreeHost.h:

1:34 AM Changeset in webkit [253743] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

[WPE] Missing UIScriptController implementation
​https://bugs.webkit.org/show_bug.cgi?id=200295

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2019-12-19
Reviewed by Žan Doberšek.

Tools:

Add initial implementation of UIScriptController for WPE.

• TestRunnerShared/UIScriptContext/UIScriptController.cpp:
• WebKitTestRunner/PlatformWPE.cmake:
• WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:

(WTR::PlatformWebView::addToWindow):
(WTR::PlatformWebView::removeFromWindow):

• WebKitTestRunner/wpe/UIScriptControllerWPE.cpp: Added.

(WTR::UIScriptController::create):
(WTR::UIScriptControllerWPE::doAsyncTask):
(WTR::UIScriptControllerWPE::setContinuousSpellCheckingEnabled):
(WTR::UIScriptControllerWPE::copyText):
(WTR::UIScriptControllerWPE::dismissMenu):
(WTR::UIScriptControllerWPE::isShowingMenu const):
(WTR::UIScriptControllerWPE::activateAtPoint):
(WTR::UIScriptControllerWPE::simulateAccessibilitySettingsChangeNotification):
(WTR::UIScriptControllerWPE::removeViewFromWindow):
(WTR::UIScriptControllerWPE::addViewToWindow):

• WebKitTestRunner/wpe/UIScriptControllerWPE.h: Added.
• wpe/backends/ViewBackend.h:

LayoutTests:

Remove expectation of a test that is now passing.

• platform/wpe/TestExpectations:

1:03 AM Changeset in webkit [253742] by youenn@apple.com

• 6 edits in trunk

Safari resumes autoplay audio elements after getUserMedia
​https://bugs.webkit.org/show_bug.cgi?id=197688
<rdar://problem/57674395>

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaStreamCaptureStarted):
Previously, we were piggybacking on resuming autoplay, which happens after interuption.
This is incorrect as it tries to play paused elements.
Instead we just try to play a media element if it can autoplay without changing the m_autoplaying value.

• html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::mediaStreamCaptureStarted): Deleted.

LayoutTests:

• webrtc/video-autoplay-expected.txt:
• webrtc/video-autoplay.html:

12:35 AM Changeset in webkit [253741] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed GTK gardening. Mark /webkit/WebKitWebsiteData/configuration as flaky

• TestWebKitAPI/glib/TestExpectations.json: