Timeline



Jan 6, 2020:

11:49 PM Changeset in webkit [254114] by Fujii Hironori
  • 4 edits
    2 adds in trunk

ComplexTextController::offsetForPosition returns a wrong offset for a glyph boundary in a RTL text
​https://bugs.webkit.org/show_bug.cgi?id=205486

Reviewed by Ross Kirsling.

Source/WebCore:

ComplexTextController::offsetForPosition had the following code:

unsigned hitIndex = hitGlyphStart + (hitGlyphEnd - hitGlyphStart) * (m_run.ltr() ? x / adjustedAdvance : 1 - x / adjustedAdvance);

If m_run.ltr() was false and x == 0, hitIndex would become hitGlyphEnd.
This is not expected. It expects hitIndex < hitGlyphEnd if hitGlyphStart ≠ hitGlyphEnd.
Let hitIndex be hitGlyphStart-1 in the such condition.

Above change makes fast/text/ellipsis-text-rtl.html starting to
fail because offsetForPosition returns the character offset of the
next glyph if the argument 'h' is in a glyph boundary. In RTL
text, offsetForPosition should return a character offset of the
previous glyph in case of a glyph boundary. Use '<=' instead of '<'
for RTL text in order to select previous glyphs for glyph
boundaries.

Test: fast/dom/Document/CaretRangeFromPoint/rtl.html

  • platform/graphics/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition): Compute correct hitGlyphEnd for RTL.

LayoutTests:

  • fast/dom/Document/CaretRangeFromPoint/rtl-expected.txt: Added.
  • fast/dom/Document/CaretRangeFromPoint/rtl.html: Added.
  • platform/gtk/TestExpectations: Unmarked imported/blink/editing/selection/offset-from-point-complex-scripts.html.
9:48 PM Changeset in webkit [254113] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Start using the UsedHorizontalValues::Constraints values in ::layoutInFlowContent
​https://bugs.webkit.org/show_bug.cgi?id=205831
<rdar://problem/58353565>

Reviewed by Antti Koivisto.

Use the incoming horizontal constraint value instead of querying the root's geometry (which is technically outside of the current formatting context).

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

8:51 PM Changeset in webkit [254112] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC] computeBorderAndPadding/computeWidthAndMargin/computeStaticPosition functions should take UsedHorizontalValues::Constraints
​https://bugs.webkit.org/show_bug.cgi?id=205825
<rdar://problem/58351397>

Reviewed by Antti Koivisto.

Let's pass in the horizontal constraints so that the compute* functions don't need to
access containing block's geometry.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeBorderAndPadding):
(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):

  • layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin): Deleted.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):
(WebCore::Layout::InlineFormattingContext::computeHorizontalAndVerticalGeometry):
(WebCore::Layout::InlineFormattingContext::computedIntrinsicWidthConstraints):
(WebCore::Layout::InlineFormattingContext::computeIntrinsicWidthForFormattingRoot):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox):

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutTableCellBox):

8:42 PM Changeset in webkit [254111] by yurys@chromium.org
  • 5 edits in trunk

REGRESSION: [ Mac wk2 ] http/tests/inspector/target/provisional-load-cancels-previous-load.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205473
<rdar://problem/58093690>

Source/WebInspectorUI:

The failure was due to attempts to add output to the test page which could be not fully
loaded after navigation. To make it deterministic it is now possible to keep provisional
navigation paused and to defer output until the test page is ready.

Reviewed by Brian Burg.

  • UserInterface/Protocol/Target.js:

(WI.Target.prototype.initialize):
(WI.Target.prototype._resumeIfPaused): extracted resume logic in a method that
can be overridden in the tests.

  • UserInterface/Test/FrontendTestHarness.js:

(FrontendTestHarness.prototype.deferOutputUntilTestPageIsReloaded): allow to pause
output when navigation is started via protocol commands rather than the test harness.

LayoutTests:

Reviewed by Brian Burg.

Keep provisional page paused until second navigation replaces it and also
defer output until test page is fully initialized after navigation.

  • http/tests/inspector/target/provisional-load-cancels-previous-load.html:
8:40 PM Changeset in webkit [254110] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix since r254064.

  • CMakeLists.txt: GraphicsContext3D was renamed GraphicsContextGLOpenGL, not GraphicsContextGLOpenGLBase.
8:36 PM Changeset in webkit [254109] by Fujii Hironori
  • 4 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port after r253326 and r250849.

  • platform/wincairo/fast/css/invalidation-errors-2-expected.txt:
  • platform/wincairo/fast/css/invalidation-errors-expected.txt:
  • platform/wincairo/fast/text/international/bidi-layout-across-linebreak-expected.txt:
8:36 PM Changeset in webkit [254108] by yoshiaki.jitsukawa@sony.com
  • 4 edits in trunk

[PlayStation] Update port cmake
​https://bugs.webkit.org/show_bug.cgi?id=205846

Reviewed by Don Olmstead.

.:

Define C/CXX macro BPLATFORM_PLAYSTATION.

Find HarfBuzz::ICU component to fix cmake errors.

Make the WebCore and WebKit builds optional.

  • Source/cmake/OptionsPlayStation.cmake:

Source/JavaScriptCore:

  • PlatformPlayStation.cmake:

Workaround of compilation errors with VisualStudio generator, which gives -std=c++* options to C sources.

8:18 PM Changeset in webkit [254107] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC] Remove redundant UsedVerticalValues::Constraints(Display::Box)
​https://bugs.webkit.org/show_bug.cgi?id=205813
<rdar://problem/58346993>

Reviewed by Antti Koivisto.

Let's call the other c'tor instead.

  • layout/LayoutUnits.cpp:

(WebCore::Layout::UsedVerticalValues::Constraints::Constraints): Deleted.

  • layout/LayoutUnits.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeStaticVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

7:58 PM Changeset in webkit [254106] by Fujii Hironori
  • 7 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port after r252598.

  • platform/wincairo/fast/box-shadow/inset-box-shadow-radius-expected.txt:
  • platform/wincairo/fast/css/hsl-color-expected.txt:
  • platform/wincairo/fast/css/hsla-color-expected.txt:
  • platform/wincairo/fast/css/percentage-non-integer-expected.txt:
  • platform/wincairo/fast/css/shadow-multiple-expected.txt:
  • platform/wincairo/fast/css/viewport-units-dynamic-expected.txt:
7:44 PM Changeset in webkit [254105] by Fujii Hironori
  • 112 edits in trunk/LayoutTests

Unreviewed test gardening for WinCairo port after r254044.

  • platform/wincairo/css1/basic/containment-expected.txt:
  • platform/wincairo/css1/basic/contextual_selectors-expected.txt:
  • platform/wincairo/css1/basic/grouping-expected.txt:
  • platform/wincairo/css1/basic/id_as_selector-expected.txt:
  • platform/wincairo/css1/basic/inheritance-expected.txt:
  • platform/wincairo/css1/box_properties/border-expected.txt:
  • platform/wincairo/css1/box_properties/border_bottom-expected.txt:
  • platform/wincairo/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_bottom_width-expected.txt:
  • platform/wincairo/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_color-expected.txt:
  • platform/wincairo/css1/box_properties/border_color_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_left-expected.txt:
  • platform/wincairo/css1/box_properties/border_left_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_left_width-expected.txt:
  • platform/wincairo/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_right-expected.txt:
  • platform/wincairo/css1/box_properties/border_right_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_right_width-expected.txt:
  • platform/wincairo/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_style-expected.txt:
  • platform/wincairo/css1/box_properties/border_style_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_top-expected.txt:
  • platform/wincairo/css1/box_properties/border_top_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_top_width-expected.txt:
  • platform/wincairo/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/wincairo/css1/box_properties/border_width-expected.txt:
  • platform/wincairo/css1/box_properties/border_width_inline-expected.txt:
  • platform/wincairo/css1/box_properties/clear-expected.txt:
  • platform/wincairo/css1/box_properties/clear_float-expected.txt:
  • platform/wincairo/css1/box_properties/float-expected.txt:
  • platform/wincairo/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/wincairo/css1/box_properties/float_margin-expected.txt:
  • platform/wincairo/css1/box_properties/height-expected.txt:
  • platform/wincairo/css1/box_properties/margin-expected.txt:
  • platform/wincairo/css1/box_properties/margin_bottom-expected.txt:
  • platform/wincairo/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/wincairo/css1/box_properties/margin_inline-expected.txt:
  • platform/wincairo/css1/box_properties/margin_left-expected.txt:
  • platform/wincairo/css1/box_properties/margin_left_inline-expected.txt:
  • platform/wincairo/css1/box_properties/margin_right-expected.txt:
  • platform/wincairo/css1/box_properties/margin_right_inline-expected.txt:
  • platform/wincairo/css1/box_properties/margin_top-expected.txt:
  • platform/wincairo/css1/box_properties/margin_top_inline-expected.txt:
  • platform/wincairo/css1/box_properties/padding-expected.txt:
  • platform/wincairo/css1/box_properties/padding_bottom-expected.txt:
  • platform/wincairo/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/wincairo/css1/box_properties/padding_inline-expected.txt:
  • platform/wincairo/css1/box_properties/padding_left-expected.txt:
  • platform/wincairo/css1/box_properties/padding_left_inline-expected.txt:
  • platform/wincairo/css1/box_properties/padding_right-expected.txt:
  • platform/wincairo/css1/box_properties/padding_right_inline-expected.txt:
  • platform/wincairo/css1/box_properties/padding_top-expected.txt:
  • platform/wincairo/css1/box_properties/padding_top_inline-expected.txt:
  • platform/wincairo/css1/box_properties/width-expected.txt:
  • platform/wincairo/css1/cascade/cascade_order-expected.txt:
  • platform/wincairo/css1/cascade/important-expected.txt:
  • platform/wincairo/css1/classification/display-expected.txt:
  • platform/wincairo/css1/classification/list_style-expected.txt:
  • platform/wincairo/css1/classification/list_style_image-expected.txt:
  • platform/wincairo/css1/classification/list_style_position-expected.txt:
  • platform/wincairo/css1/classification/list_style_type-expected.txt:
  • platform/wincairo/css1/classification/white_space-expected.txt:
  • platform/wincairo/css1/color_and_background/background-expected.txt:
  • platform/wincairo/css1/color_and_background/background_attachment-expected.txt:
  • platform/wincairo/css1/color_and_background/background_color-expected.txt:
  • platform/wincairo/css1/color_and_background/background_image-expected.txt:
  • platform/wincairo/css1/color_and_background/background_position-expected.txt:
  • platform/wincairo/css1/color_and_background/background_repeat-expected.txt:
  • platform/wincairo/css1/color_and_background/color-expected.txt:
  • platform/wincairo/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/wincairo/css1/font_properties/font-expected.txt:
  • platform/wincairo/css1/font_properties/font_size-expected.txt:
  • platform/wincairo/css1/font_properties/font_style-expected.txt:
  • platform/wincairo/css1/font_properties/font_variant-expected.txt:
  • platform/wincairo/css1/font_properties/font_weight-expected.txt:
  • platform/wincairo/css1/formatting_model/canvas-expected.txt:
  • platform/wincairo/css1/formatting_model/floating_elements-expected.txt:
  • platform/wincairo/css1/formatting_model/height_of_lines-expected.txt:
  • platform/wincairo/css1/formatting_model/inline_elements-expected.txt:
  • platform/wincairo/css1/formatting_model/replaced_elements-expected.txt:
  • platform/wincairo/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/wincairo/css1/pseudo/anchor-expected.txt:
  • platform/wincairo/css1/pseudo/firstletter-expected.txt:
  • platform/wincairo/css1/pseudo/firstline-expected.txt:
  • platform/wincairo/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/wincairo/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/wincairo/css1/text_properties/letter_spacing-expected.txt:
  • platform/wincairo/css1/text_properties/line_height-expected.txt:
  • platform/wincairo/css1/text_properties/text_align-expected.txt:
  • platform/wincairo/css1/text_properties/text_decoration-expected.txt:
  • platform/wincairo/css1/text_properties/text_indent-expected.txt:
  • platform/wincairo/css1/text_properties/text_transform-expected.txt:
  • platform/wincairo/css1/text_properties/vertical_align-expected.txt:
  • platform/wincairo/css1/text_properties/word_spacing-expected.txt:
  • platform/wincairo/css1/units/color_units-expected.txt:
  • platform/wincairo/css1/units/length_units-expected.txt:
  • platform/wincairo/css1/units/percentage_units-expected.txt:
  • platform/wincairo/css1/units/urls-expected.txt:
  • platform/wincairo/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
  • platform/wincairo/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
  • platform/wincairo/editing/selection/designmode-no-caret-expected.txt:
  • platform/wincairo/fast/css/empty-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/first-child-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/last-child-pseudo-class-expected.txt:
  • platform/wincairo/fast/css/only-child-pseudo-class-expected.txt:
  • platform/wincairo/fast/html/listing-expected.txt:
  • platform/wincairo/fast/text/whitespace/024-expected.txt:
  • platform/wincairo/fast/text/whitespace/030-expected.txt:
  • platform/wincairo/fast/text/word-break-expected.txt:
7:15 PM Changeset in webkit [254104] by Alan Bujtas
  • 10 edits in trunk/Source/WebCore

[LFC] FormattingContext::layoutInFlowContent should take UsedHorizontalValues::Constraints
​https://bugs.webkit.org/show_bug.cgi?id=205809
<rdar://problem/58345856>

Reviewed by Antti Koivisto.

This patch is in preparation for using the incoming horizontal constraint instead of
accessing the formatting context root's geometry.
(e.g. <div style="width: 100px;">text content</div>. The IFC should not need to query the div's display box
for the horizontal available space (100px))

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowContent):

  • layout/FormattingContext.h:
  • layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot):

  • layout/inlineformatting/InlineFormattingContext.h:
  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::layoutInFlowContent):
(WebCore::Layout::TableFormattingContext::layoutTableCellBox):

  • layout/tableformatting/TableFormattingContext.h:
6:52 PM Changeset in webkit [254103] by don.olmstead@sony.com
  • 15 edits in trunk

Rename GraphicsContext3D to GraphicsContextGL
​https://bugs.webkit.org/show_bug.cgi?id=205778
<rdar://problem/58327597>

Reviewed by Ross Kirsling.

.:

Fix the build after r254064 on Windows and PlayStation.

Add USE_OPENGL_ES_3 to Windows and WPE builds to simplify the Platform checks
for GL functions available in OpenGL ES 3.0+. Expose additional USE macros for
Windows builds to remove Platform.h entries around ENABLE(WEBGL).

  • Source/cmake/OptionsFTW.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWinCairo.cmake:

Source/WebCore:

Use ENABLE(GRAPHICS_CONTEXT_GL) instead of ENABLE(WEBGL) for relevant files.
This was causing the build breakage.

Move methods wrapping OpenGL[ES] 3.0+ functions into GraphicsContextGLOpenGLCommon.cpp
and remove them from GraphicsContextGLTextureMapper.cpp. Add a check for OpenGL[ES]
versions rather than depending on a particular platform.

  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/GraphicsContextGL.cpp:
  • platform/graphics/GraphicsContextGL.h:
  • platform/graphics/GraphicsContextGLAttributes.h:
  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:
  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
  • platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::mapBufferRange):
(WebCore::GraphicsContextGLOpenGL::unmapBuffer):
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData):
(WebCore::GraphicsContextGLOpenGL::getInternalformativ):
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample):
(WebCore::GraphicsContextGLOpenGL::texStorage2D):
(WebCore::GraphicsContextGLOpenGL::texStorage3D):
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms):

  • platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLOpenGL::mapBufferRange): Deleted.
(WebCore::GraphicsContextGLOpenGL::unmapBuffer): Deleted.
(WebCore::GraphicsContextGLOpenGL::copyBufferSubData): Deleted.
(WebCore::GraphicsContextGLOpenGL::getInternalformativ): Deleted.
(WebCore::GraphicsContextGLOpenGL::renderbufferStorageMultisample): Deleted.
(WebCore::GraphicsContextGLOpenGL::texStorage2D): Deleted.
(WebCore::GraphicsContextGLOpenGL::texStorage3D): Deleted.
(WebCore::GraphicsContextGLOpenGL::getActiveUniforms): Deleted.

Source/WTF:

Define USE_OPENGL_3 for Mac and USE_OPENGL_ES_3 for iOS. Use CMake config for
Windows and WebGL.

  • wtf/Platform.h:
5:10 PM Changeset in webkit [254102] by Alan Bujtas
  • 11 edits in trunk/Source/WebCore

[LFC] UsedHorizontalValues::Constraints should not take Display::Box
​https://bugs.webkit.org/show_bug.cgi?id=205811
<rdar://problem/58346356>

Reviewed by Antti Koivisto.

Passing in only the actual rect values (content/padding box left/width) to UsedHorizontalValues::Constraints makes the
constraint logic look clear.

  • layout/FormattingContext.cpp:

(WebCore::Layout::outOfFlowHorizontalConstraints):
(WebCore::Layout::FormattingContext::computeBorderAndPadding):

  • layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

  • layout/LayoutUnits.cpp:

(WebCore::Layout::UsedHorizontalValues::Constraints::Constraints):

  • layout/LayoutUnits.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::placeInFlowPositionedChildren):
(WebCore::Layout::BlockFormattingContext::computeStaticHorizontalPosition):
(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):

  • layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutInFlowContent):

5:06 PM Changeset in webkit [254101] by pvollan@apple.com
  • 7 edits in trunk/Source/WebKit

[iOS] Get display level in the UI process for all iOS platforms
​https://bugs.webkit.org/show_bug.cgi?id=205835
<rdar://problem/58116883>

Reviewed by Brent Fulgham.

This was previously only done for iOS, but should be done for all iOS platforms.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::initializeNewWebProcess):

  • UIProcess/WebProcessPool.h:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/cocoa/WebProcessCocoa.mm:
4:52 PM Changeset in webkit [254100] by Jonathan Bedard
  • 2 edits in trunk/Tools

results.webkit.org: Tweak processing constants
​https://bugs.webkit.org/show_bug.cgi?id=205828
<rdar://problem/58146698>

Rubber-stamped by Aakash Jain.

  • resultsdbpy/resultsdbpy/model/upload_context.py:

(UploadContext):
Increase process timeout to 1 week.
Allow 5 retries instead of 3.
Retry stuck tasks after 10 minutes instead of 5.
Include more tasks so that a scan is always greater than the number of workers.

4:49 PM Changeset in webkit [254099] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Only prewarm fonts with valid font names
​https://bugs.webkit.org/show_bug.cgi?id=205822

Reviewed by Brent Fulgham.

The font names ".SF NS Text" and ".SF NS Display" are not valid on iOS, and should not be prewarmed.

No new tests, no behavior change.

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::prewarmGlobally):

4:34 PM Changeset in webkit [254098] by eric.carlson@apple.com
  • 13 edits in trunk/Source/WebKit

Add some of the remote media player messages needed for video playback
​https://bugs.webkit.org/show_bug.cgi?id=205812
<rdar://problem/58346531>

Reviewed by Jer Noble.

No new tests, it isn't possible to play video yet.

  • GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::prepareForRendering):
(WebKit::RemoteMediaPlayerManagerProxy::setSize):
(WebKit::RemoteMediaPlayerManagerProxy::setVisible):
(WebKit::RemoteMediaPlayerManagerProxy::setShouldMaintainAspectRatio):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenFrame):
(WebKit::RemoteMediaPlayerManagerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerManagerProxy::acceleratedRenderingStateChanged):
(WebKit::RemoteMediaPlayerManagerProxy::setShouldDisableSleep):
(WebKit::RemoteMediaPlayerManagerProxy::setRate):

  • GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
  • GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
  • GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::getConfiguration):
(WebKit::RemoteMediaPlayerProxy::prepareForRendering):
(WebKit::RemoteMediaPlayerProxy::setSize):
(WebKit::RemoteMediaPlayerProxy::setVisible):
(WebKit::RemoteMediaPlayerProxy::setShouldMaintainAspectRatio):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenFrame):
(WebKit::RemoteMediaPlayerProxy::setVideoFullscreenGravity):
(WebKit::RemoteMediaPlayerProxy::acceleratedRenderingStateChanged):
(WebKit::RemoteMediaPlayerProxy::setShouldDisableSleep):
(WebKit::RemoteMediaPlayerProxy::setRate):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerReadyStateChanged):
(WebKit::RemoteMediaPlayerProxy::mediaPlayerRenderingCanBeAccelerated):

  • GPUProcess/media/RemoteMediaPlayerProxy.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::sizeChanged):
(WebKit::MediaPlayerPrivateRemote::updateCachedState):
(WebKit::MediaPlayerPrivateRemote::shouldIgnoreIntrinsicSize):
(WebKit::MediaPlayerPrivateRemote::prepareForRendering):
(WebKit::MediaPlayerPrivateRemote::setSize):
(WebKit::MediaPlayerPrivateRemote::setVisible):
(WebKit::MediaPlayerPrivateRemote::setShouldMaintainAspectRatio):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenFrame):
(WebKit::MediaPlayerPrivateRemote::setVideoFullscreenGravity):
(WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged):
(WebKit::MediaPlayerPrivateRemote::setShouldDisableSleep):
(WebKit::MediaPlayerPrivateRemote::naturalSize const):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/GPU/media/RemoteMediaPlayerConfiguration.h:

(WebKit::RemoteMediaPlayerConfiguration::encode const):
(WebKit::RemoteMediaPlayerConfiguration::decode):

  • WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::RemoteMediaPlayerManager::sizeChanged):

  • WebProcess/GPU/media/RemoteMediaPlayerManager.h:
  • WebProcess/GPU/media/RemoteMediaPlayerManager.messages.in:
  • WebProcess/GPU/media/RemoteMediaPlayerState.h:

(WebKit::RemoteMediaPlayerState::encode const):
(WebKit::RemoteMediaPlayerState::decode):

4:31 PM Changeset in webkit [254097] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Improve logging for when a synchronous IPC times out
​https://bugs.webkit.org/show_bug.cgi?id=205829

Reviewed by Tim Horton.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::sendSyncMessage):
(IPC::Connection::waitForSyncReply):

  • Platform/IPC/Connection.h:
4:15 PM Changeset in webkit [254096] by Alan Coon
  • 7 edits in branches/safari-608-branch/Source

Versioning.

4:13 PM Changeset in webkit [254095] by Jonathan Bedard
  • 2 edits in trunk/Tools

test-lldb-webkit: Use logging module
​https://bugs.webkit.org/show_bug.cgi?id=205832

Reviewed by Stephanie Lewis.

  • Scripts/test-lldb-webkit:

(LldbTester.run): Configure logger.

3:55 PM Changeset in webkit [254094] by Nikita Vasilyev
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Color picker: make it keyboard accessible
​https://bugs.webkit.org/show_bug.cgi?id=205572
<rdar://problem/58169943>

Reviewed by Brian Burg.

For the color square, make up, down, left, and right keys move the crosshair.

For the hue and opacity sliders:

  • Pressing up and down keys should adjust the value by 1%.
  • When holding Shift, up and down keys adjust the value by 10%.
  • UserInterface/Views/ColorPicker.js:

(WI.ColorPicker.prototype.focus):

  • UserInterface/Views/ColorSquare.css:

(.color-square):
Match the border of the hue and opacity sliders.

  • UserInterface/Views/ColorSquare.js:

(WI.ColorSquare):
Make the color square focusable.

(WI.ColorSquare.prototype._handleMousedown):
(WI.ColorSquare.prototype._handleKeyDown):

  • UserInterface/Views/InlineSwatch.js:
  • UserInterface/Views/Slider.css:

(.slider:focus):

  • UserInterface/Views/Slider.js:

(WI.Slider):
(WI.Slider.prototype._handleMousedown):
Drive-by: right clicking the slider shouldn't move the thumb.

(WI.Slider.prototype._handleKeyDown):

3:49 PM Changeset in webkit [254093] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Build (unified) failure after adding source files to support media in GPU process
​https://bugs.webkit.org/show_bug.cgi?id=205616

Patch by Peng Liu <Peng Liu> on 2020-01-06
Reviewed by Darin Adler.

No new tests, no functional change.

Source/WebCore:

  • Modules/mediastream/UserMediaClient.h:

Source/WebKit:

  • Sources.txt:
  • SourcesGTK.txt:
  • WebKit.xcodeproj/project.pbxproj:
3:32 PM Changeset in webkit [254092] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

NetworkSessionCocoa::isolatedSession should not use iterator after mutating m_isolatedSessions
​https://bugs.webkit.org/show_bug.cgi?id=205824
<rdar://problem/55107625>

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-06
Reviewed by Chris Dumez.

Classic iterator use after mutating iterated container was causing crashes by returning a null SessionWrapper&
This was introduced in r252185 or r248640.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::isolatedSession):

3:08 PM Changeset in webkit [254091] by dbates@webkit.org
  • 13 edits in trunk

Precision of getClientRects(), getBoundingClientRect() differs depending whether simple line layout or line box layout is used
​https://bugs.webkit.org/show_bug.cgi?id=205563
<rdar://problem/58165528>

Reviewed by Zalan Bujtas.

Source/WebCore:

Fix up simple line layout run rect to match the rect returned by the line layout code path.

  • rendering/InlineTextBox.cpp:

(WebCore::snappedSelectionRect): Added; extracted from localSelectionRect().
(WebCore::InlineTextBox::localSelectionRect const): Moved some logic into snappedSelectionRect()
and modified code to use it.

  • rendering/InlineTextBox.h:
  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::collectAbsoluteQuadsForRange): Fix up run rect.

Tools:

Update test results.

  • TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:

(TEST):

  • TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:

(TEST):

LayoutTests:

Update expected result now that simple line layout computes a client rect that matches
the rect the line layout code computes.

  • fast/dom/Range/getClientRects-expected.txt:
  • fast/dom/Range/getClientRects.html:
  • fast/dom/Range/mac/getClientRects-and-getBoundingClientRect-before-and-after-selection-expected.txt:
  • fast/repaint/text-selection-overflow-hidden-expected.txt:
3:05 PM Changeset in webkit [254090] by Alan Coon
  • 1 copy in tags/Safari-608.5.7

Tag Safari-608.5.7.

2:57 PM Changeset in webkit [254089] by youenn@apple.com
  • 6 edits in trunk

XMLHTTPRequest POSTs blob data to a custom WKURLSchemeHandler protocol crash
​https://bugs.webkit.org/show_bug.cgi?id=205685

Reviewed by Alex Christensen.

Source/WebCore:

There is no blob registry in the UIProcess.
This should not matter since we do not yet support blobs in custom scheme handlers.
But we are calling the blob registry when creating a request body, which does not work in UIProcess.
Instead, pass a lambda that will be called in case of blobs.
Covered by API test.

  • platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::resolveBlobReferences):

  • platform/network/FormData.h:
  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::createHTTPBodyCFReadStream):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2:47 PM Changeset in webkit [254088] by Alexey Shvayka
  • 4 edits in trunk

String.prototype.replace() incorrectly handles named references on RegExp w/o named groups
​https://bugs.webkit.org/show_bug.cgi?id=205785

Reviewed by Ross Kirsling.

JSTests:

  • test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This patch fixes substitution of named references by ignoring "$<" sequences
for a RegExp without named capture groups, removing some index tweaking.
(step 11 of ​https://tc39.es/ecma262/#sec-getsubstitution)

Also this change removes 2 obsolete FIXMEs regarding possible spec changes.

  • runtime/StringPrototype.cpp:

(JSC::substituteBackreferencesSlow):

2:24 PM Changeset in webkit [254087] by mark.lam@apple.com
  • 382 edits in trunk

PerformanceTests:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • JetStream2/wasm/HashSet.cpp:
  • StitchMarker/wtf/Assertions.h:
  • StitchMarker/wtf/DateMath.cpp:

(WTF::initializeDates):

  • StitchMarker/wtf/HashTable.h:
  • StitchMarker/wtf/Hasher.h:

(WTF::StringHasher::addCharacters):

  • StitchMarker/wtf/NeverDestroyed.h:

(WTF::LazyNeverDestroyed::construct):

  • StitchMarker/wtf/StackBounds.h:

(WTF::StackBounds::checkConsistency const):

  • StitchMarker/wtf/ValueCheck.h:
  • StitchMarker/wtf/Vector.h:

(WTF::minCapacity>::checkConsistency):

  • StitchMarker/wtf/text/AtomicStringImpl.cpp:
  • StitchMarker/wtf/text/AtomicStringImpl.h:
  • StitchMarker/wtf/text/StringCommon.h:

(WTF::hasPrefixWithLettersIgnoringASCIICaseCommon):

  • StitchMarker/wtf/text/StringImpl.h:
  • StitchMarker/wtf/text/SymbolImpl.h:
  • StitchMarker/wtf/text/UniquedStringImpl.h:

Source/JavaScriptCore:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • API/tests/testapi.c:
  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::replaceWithLoad):
(JSC::ARM64Assembler::replaceWithAddressComputation):

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::LocalWriter::LocalWriter):

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::copyCompactAndLinkCode):

  • assembler/ProbeStack.cpp:

(JSC::Probe::Stack::Stack):

  • assembler/ProbeStack.h:
  • b3/B3FoldPathConstants.cpp:
  • b3/B3LowerToAir.cpp:
  • b3/B3MemoryValue.cpp:

(JSC::B3::MemoryValue::MemoryValue):

  • b3/B3Opcode.cpp:
  • b3/B3Type.h:
  • b3/B3TypeMap.h:
  • b3/B3Width.h:
  • b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp:

(JSC::B3::Air::GenerateAndAllocateRegisters::prepareForGeneration):
(JSC::B3::Air::GenerateAndAllocateRegisters::generate):

  • b3/air/AirAllocateRegistersAndStackAndGenerateCode.h:
  • b3/air/AirAllocateRegistersByGraphColoring.cpp:
  • b3/air/AirArg.cpp:
  • b3/air/AirArg.h:
  • b3/air/AirCode.h:
  • b3/air/AirEmitShuffle.cpp:

(JSC::B3::Air::emitShuffle):

  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutable):

  • bytecode/AccessCase.cpp:
  • bytecode/AccessCase.h:
  • bytecode/CallVariant.cpp:

(JSC::variantListWithVariant):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::ensureCatchLivenessIsComputedForBytecodeIndex):

  • bytecode/CodeBlockHash.cpp:

(JSC::CodeBlockHash::dump const):

  • bytecode/StructureStubInfo.cpp:
  • bytecode/StructureStubInfo.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallResolveNode::emitBytecode):

  • bytecompiler/RegisterID.h:

(JSC::RegisterID::RegisterID):
(JSC::RegisterID::setIndex):

  • debugger/Debugger.cpp:

(JSC::Debugger::removeBreakpoint):

  • debugger/DebuggerEvalEnabler.h:

(JSC::DebuggerEvalEnabler::DebuggerEvalEnabler):
(JSC::DebuggerEvalEnabler::~DebuggerEvalEnabler):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransitions):

  • dfg/DFGAbstractValue.cpp:
  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::checkConsistency const):
(JSC::DFG::AbstractValue::assertIsRegistered const):

  • dfg/DFGArithMode.h:

(JSC::DFG::doesOverflow):

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::BasicBlock):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::didLink):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performBlockCFA):

  • dfg/DFGCommon.h:

(JSC::DFG::validationEnabled):

  • dfg/DFGCommonData.cpp:

(JSC::DFG::CommonData::finalizeCatchEntrypoints):

  • dfg/DFGDesiredWatchpoints.h:
  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGEdge.h:

(JSC::DFG::Edge::makeWord):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::finalizeOSREntrypoints):

  • dfg/DFGObjectAllocationSinkingPhase.cpp:
  • dfg/DFGSSAConversionPhase.cpp:

(JSC::DFG::SSAConversionPhase::run):

  • dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::assertClear):

  • dfg/DFGSlowPathGenerator.h:

(JSC::DFG::SlowPathGenerator::generate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::emitBinarySwitchStringRecurse):
(JSC::DFG::SpeculativeJIT::emitAllocateButterfly):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):
(JSC::DFG::SpeculativeJIT::compileMakeRope):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::fillSpeculateCell):

  • dfg/DFGStructureAbstractValue.cpp:
  • dfg/DFGStructureAbstractValue.h:

(JSC::DFG::StructureAbstractValue::assertIsRegistered const):

  • dfg/DFGVarargsForwardingPhase.cpp:
  • dfg/DFGVirtualRegisterAllocationPhase.cpp:

(JSC::DFG::VirtualRegisterAllocationPhase::run):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::callPreflight):
(JSC::FTL::DFG::LowerDFGToB3::callCheck):
(JSC::FTL::DFG::LowerDFGToB3::crash):

  • ftl/FTLOperations.cpp:

(JSC::FTL::operationMaterializeObjectInOSR):

  • heap/BlockDirectory.cpp:

(JSC::BlockDirectory::assertNoUnswept):

  • heap/GCSegmentedArray.h:

(JSC::GCArraySegment::GCArraySegment):

  • heap/GCSegmentedArrayInlines.h:

(JSC::GCSegmentedArray<T>::clear):
(JSC::GCSegmentedArray<T>::expand):
(JSC::GCSegmentedArray<T>::validatePrevious):

  • heap/HandleSet.cpp:
  • heap/HandleSet.h:
  • heap/Heap.cpp:

(JSC::Heap::updateAllocationLimits):

  • heap/Heap.h:
  • heap/MarkedBlock.cpp:
  • heap/MarkedBlock.h:

(JSC::MarkedBlock::assertValidCell const):
(JSC::MarkedBlock::assertMarksNotStale):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::beginMarking):
(JSC::MarkedSpace::endMarking):
(JSC::MarkedSpace::assertNoUnswept):

  • heap/PreciseAllocation.cpp:
  • heap/PreciseAllocation.h:

(JSC::PreciseAllocation::assertValidCell const):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::SlotVisitor):
(JSC::SlotVisitor::appendJSCellOrAuxiliary):

  • heap/SlotVisitor.h:
  • inspector/InspectorProtocolTypes.h:

(Inspector::Protocol::BindingTraits<JSON::ArrayOf<T>>::assertValueHasExpectedType):

  • inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator._generate_assertion_for_object_declaration):
(CppProtocolTypesImplementationGenerator):
(CppProtocolTypesImplementationGenerator._generate_assertion_for_enum):

  • inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
  • interpreter/FrameTracers.h:

(JSC::JITOperationPrologueCallFrameTracer::JITOperationPrologueCallFrameTracer):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

  • interpreter/Interpreter.h:
  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::emitStoreStructureWithTypeInfo):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::prepareCallOperation):

  • jit/BinarySwitch.cpp:

(JSC::BinarySwitch::BinarySwitch):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupStubArgs):

  • jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::emitDeltaCheck):
(JSC::CallFrameShuffler::prepareAny):

  • jit/JIT.cpp:

(JSC::JIT::assertStackPointerOffset):
(JSC::JIT::compileWithoutLinking):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_from_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_from_scope):

  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • jit/ThunkGenerators.cpp:

(JSC::emitPointerValidation):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntOfflineAsmConfig.h:
  • parser/Lexer.cpp:
  • parser/Lexer.h:

(JSC::isSafeBuiltinIdentifier):
(JSC::Lexer<T>::lexExpectIdentifier):

  • runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::setNeedsOverflowCheck):
(JSC::MarkedArgumentBuffer::clearNeedsOverflowCheck):

  • runtime/Butterfly.h:

(JSC::ContiguousData::ContiguousData):
(JSC::ContiguousData::Data::Data):

  • runtime/HashMapImpl.h:

(JSC::HashMapImpl::checkConsistency const):
(JSC::HashMapImpl::assertBufferIsEmpty const):

  • runtime/JSCellInlines.h:

(JSC::JSCell::methodTable const):

  • runtime/JSFunction.cpp:
  • runtime/JSFunction.h:

(JSC::JSFunction::assertTypeInfoFlagInvariants):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObject.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):

  • runtime/JSObjectInlines.h:

(JSC::JSObject::validatePutOwnDataProperty):

  • runtime/JSSegmentedVariableObject.h:

(JSC::JSSegmentedVariableObject::assertVariableIsInThisObject):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):

  • runtime/LiteralParser.h:
  • runtime/Operations.h:

(JSC::scribbleFreeCells):

  • runtime/OptionsList.h:
  • runtime/VM.cpp:

(JSC::VM::computeCanUseJIT):

  • runtime/VM.h:

(JSC::VM::canUseJIT):

  • runtime/VarOffset.h:

(JSC::VarOffset::checkSanity const):

  • runtime/WeakMapImpl.h:

(JSC::WeakMapImpl::checkConsistency const):
(JSC::WeakMapImpl::assertBufferIsEmpty const):

  • wasm/WasmAirIRGenerator.cpp:

(JSC::Wasm::AirIRGenerator::validateInst):

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::parseAndCompile):

  • wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser::validationFail const):

  • wasm/WasmLLIntGenerator.cpp:

(JSC::Wasm::LLIntGenerator::checkConsistency):

  • wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::tryRemoveContextAndCancelIfLast):

  • wasm/WasmSectionParser.h:
  • wasm/WasmSections.h:
  • wasm/WasmSignatureInlines.h:

(JSC::Wasm::SignatureInformation::get):

  • wasm/WasmWorklist.cpp:

(JSC::Wasm::Worklist::enqueue):

  • wasm/js/JSToWasm.cpp:

(JSC::Wasm::createJSToWasmWrapper):

  • wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::previousInstanceOffset const):

Source/WebCore:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • Modules/fetch/FetchBodySource.cpp:

(WebCore::FetchBodySource::close):

  • Modules/fetch/FetchBodySource.h:
  • Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::operator=):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):

  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::terminationRequested const):

  • Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:

(WebCore::WHLSL::AST::TypeAnnotation::TypeAnnotation):

  • Modules/webgpu/WHLSL/WHLSLHighZombieFinder.cpp:

(WebCore::WHLSL::findHighZombies):

  • Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:

(WebCore::WHLSL::matches):

  • Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:

(WebCore::WHLSL::checkLiteralTypes):

  • Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:

(WebCore::WHLSL::FindAllTypes::appendNamedType):

  • bindings/js/JSCallbackData.h:
  • bindings/js/JSLazyEventListener.cpp:
  • bindings/js/JSLazyEventListener.h:
  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcOperationNode::primitiveType const):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/CSSPrimitiveValue.cpp:
  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText const):

  • css/CSSStyleSheet.cpp:
  • dom/ActiveDOMObject.cpp:

(WebCore::ActiveDOMObject::suspendIfNeeded):
(WebCore::ActiveDOMObject::assertSuspendIfNeededWasCalled const):

  • dom/ActiveDOMObject.h:
  • dom/ContainerNode.cpp:
  • dom/ContainerNodeAlgorithms.cpp:
  • dom/ContainerNodeAlgorithms.h:
  • dom/CustomElementReactionQueue.cpp:
  • dom/CustomElementReactionQueue.h:

(WebCore::CustomElementReactionDisallowedScope::CustomElementReactionDisallowedScope):
(WebCore::CustomElementReactionDisallowedScope::~CustomElementReactionDisallowedScope):

  • dom/Document.cpp:

(WebCore::Document::hitTest):

  • dom/Document.h:

(WebCore::Document::decrementReferencingNodeCount):

  • dom/Element.cpp:

(WebCore::Element::addShadowRoot):
(WebCore::Element::getURLAttribute const):
(WebCore::Element::getNonEmptyURLAttribute const):

  • dom/Element.h:
  • dom/ElementAndTextDescendantIterator.h:

(WebCore::ElementAndTextDescendantIterator::ElementAndTextDescendantIterator):
(WebCore::ElementAndTextDescendantIterator::dropAssertions):
(WebCore::ElementAndTextDescendantIterator::popAncestorSiblingStack):
(WebCore::ElementAndTextDescendantIterator::traverseNextSibling):
(WebCore::ElementAndTextDescendantIterator::traversePreviousSibling):

  • dom/ElementDescendantIterator.h:

(WebCore::ElementDescendantIterator::ElementDescendantIterator):
(WebCore::ElementDescendantIterator::dropAssertions):
(WebCore::ElementDescendantIterator::operator++):
(WebCore::ElementDescendantIterator::operator--):
(WebCore::ElementDescendantConstIterator::ElementDescendantConstIterator):
(WebCore::ElementDescendantConstIterator::dropAssertions):
(WebCore::ElementDescendantConstIterator::operator++):

  • dom/ElementIterator.h:

(WebCore::ElementIterator<ElementType>::ElementIterator):
(WebCore::ElementIterator<ElementType>::traverseNext):
(WebCore::ElementIterator<ElementType>::traversePrevious):
(WebCore::ElementIterator<ElementType>::traverseNextSibling):
(WebCore::ElementIterator<ElementType>::traversePreviousSibling):
(WebCore::ElementIterator<ElementType>::traverseNextSkippingChildren):
(WebCore::ElementIterator<ElementType>::dropAssertions):
(WebCore::ElementIterator<ElementType>::traverseAncestor):
(WebCore::ElementConstIterator<ElementType>::ElementConstIterator):
(WebCore::ElementConstIterator<ElementType>::traverseNext):
(WebCore::ElementConstIterator<ElementType>::traversePrevious):
(WebCore::ElementConstIterator<ElementType>::traverseNextSibling):
(WebCore::ElementConstIterator<ElementType>::traversePreviousSibling):
(WebCore::ElementConstIterator<ElementType>::traverseNextSkippingChildren):
(WebCore::ElementConstIterator<ElementType>::traverseAncestor):
(WebCore::ElementConstIterator<ElementType>::dropAssertions):

  • dom/EventContext.cpp:
  • dom/EventContext.h:
  • dom/EventListener.h:
  • dom/EventPath.cpp:
  • dom/EventSender.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::setAttributeEventListener):
(WebCore::EventTarget::innerInvokeEventListeners):

  • dom/Node.cpp:

(WebCore::Node::~Node):
(WebCore::Node::moveNodeToNewDocument):
(WebCore::Node::removedLastRef):

  • dom/Node.h:

(WebCore::Node::deref const):

  • dom/ScriptDisallowedScope.h:

(WebCore::ScriptDisallowedScope::InMainThread::isEventDispatchAllowedInSubtree):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::~ScriptExecutionContext):

  • dom/ScriptExecutionContext.h:
  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::execute const):

  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::addSlotElementByName):
(WebCore::SlotAssignment::removeSlotElementByName):
(WebCore::SlotAssignment::resolveSlotsAfterSlotMutation):
(WebCore::SlotAssignment::findFirstSlotElement):

  • dom/SlotAssignment.h:
  • dom/TreeScopeOrderedMap.cpp:

(WebCore::TreeScopeOrderedMap::add):
(WebCore::TreeScopeOrderedMap::get const):

  • dom/TreeScopeOrderedMap.h:
  • fileapi/Blob.cpp:
  • fileapi/Blob.h:
  • history/BackForwardCache.cpp:

(WebCore::BackForwardCache::removeAllItemsForPage):

  • history/BackForwardCache.h:
  • html/CanvasBase.cpp:

(WebCore::CanvasBase::notifyObserversCanvasDestroyed):

  • html/CanvasBase.h:
  • html/HTMLCollection.h:

(WebCore::CollectionNamedElementCache::didPopulate):

  • html/HTMLSelectElement.cpp:

(WebCore:: const):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::assertRowIsInTable):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::indexForPosition const):

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::~CanvasRenderingContext2DBase):

  • html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::HTMLParserScheduler):
(WebCore::HTMLParserScheduler::suspend):
(WebCore::HTMLParserScheduler::resume):

  • html/parser/HTMLParserScheduler.h:
  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::beginStartTag):
(WebCore::HTMLToken::beginEndTag):
(WebCore::HTMLToken::endAttribute):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::constructTree):

  • html/parser/HTMLTreeBuilder.h:

(WebCore::HTMLTreeBuilder::~HTMLTreeBuilder):

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::geometryForBox const):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeEstimatedVerticalPosition):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::Box):

  • layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::setTopLeft):
(WebCore::Display::Box::setTop):
(WebCore::Display::Box::setLeft):
(WebCore::Display::Box::setContentBoxHeight):
(WebCore::Display::Box::setContentBoxWidth):
(WebCore::Display::Box::setHorizontalMargin):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::setHorizontalComputedMargin):
(WebCore::Display::Box::setBorder):
(WebCore::Display::Box::setPadding):

  • layout/displaytree/DisplayInlineRect.h:

(WebCore::Display::InlineRect::InlineRect):
(WebCore::Display::InlineRect::setTopLeft):
(WebCore::Display::InlineRect::setTop):
(WebCore::Display::InlineRect::setBottom):
(WebCore::Display::InlineRect::setLeft):
(WebCore::Display::InlineRect::setWidth):
(WebCore::Display::InlineRect::setHeight):

  • layout/displaytree/DisplayLineBox.h:

(WebCore::Display::LineBox::LineBox):
(WebCore::Display::LineBox::setBaselineOffsetIfGreater):
(WebCore::Display::LineBox::resetBaseline):
(WebCore::Display::LineBox::Baseline::Baseline):
(WebCore::Display::LineBox::Baseline::setAscent):
(WebCore::Display::LineBox::Baseline::setDescent):
(WebCore::Display::LineBox::Baseline::reset):

  • layout/displaytree/DisplayRect.h:

(WebCore::Display::Rect::Rect):
(WebCore::Display::Rect::setTopLeft):
(WebCore::Display::Rect::setTop):
(WebCore::Display::Rect::setLeft):
(WebCore::Display::Rect::setWidth):
(WebCore::Display::Rect::setHeight):
(WebCore::Display::Rect::setSize):
(WebCore::Display::Rect::clone const):

  • layout/floats/FloatingContext.cpp:
  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::CollapsibleContent::collapse):

  • layout/tableformatting/TableGrid.cpp:

(WebCore::Layout::TableGrid::Column::setWidthConstraints):
(WebCore::Layout::TableGrid::Column::setLogicalWidth):
(WebCore::Layout::TableGrid::Column::setLogicalLeft):

  • layout/tableformatting/TableGrid.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::attachToFrame):
(WebCore::DocumentLoader::detachFromFrame):
(WebCore::DocumentLoader::addSubresourceLoader):

  • loader/DocumentLoader.h:
  • loader/ImageLoader.cpp:
  • loader/cache/CachedResource.h:
  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::lruListFor):
(WebCore::MemoryCache::removeFromLRUList):

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):

  • page/FrameViewLayoutContext.cpp:
  • page/FrameViewLayoutContext.h:
  • page/Page.cpp:
  • page/Page.h:
  • page/ViewportConfiguration.cpp:
  • page/ViewportConfiguration.h:
  • page/mac/EventHandlerMac.mm:

(WebCore::CurrentEventScope::CurrentEventScope):

  • platform/DateComponents.cpp:

(WebCore::DateComponents::toStringForTime const):

  • platform/ScrollableArea.cpp:
  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::combineIntoOneSegment const):

  • platform/SharedBuffer.h:
  • platform/Supplementable.h:
  • platform/Timer.cpp:

(WebCore::TimerBase::checkHeapIndex const):
(WebCore::TimerBase::updateHeapIfNeeded):

  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Image.h:
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::ScratchBuffer):
(WebCore::ScratchBuffer::getScratchBuffer):
(WebCore::ScratchBuffer::scheduleScratchBufferPurge):

  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::setWindow):

  • platform/graphics/ca/win/CACFLayerTreeHost.h:
  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::putData):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:
  • platform/graphics/gstreamer/GstAllocatorFastMalloc.cpp:

(gstAllocatorFastMallocFree):

  • platform/graphics/nicosia/cairo/NicosiaPaintingContextCairo.cpp:

(Nicosia::PaintingContextCairo::ForPainting::ForPainting):

  • platform/graphics/nicosia/texmap/NicosiaBackingStoreTextureMapperImpl.cpp:

(Nicosia::BackingStoreTextureMapperImpl::createTile):

  • platform/graphics/nicosia/texmap/NicosiaContentLayerTextureMapperImpl.cpp:

(Nicosia::ContentLayerTextureMapperImpl::~ContentLayerTextureMapperImpl):

  • platform/graphics/win/GradientDirect2D.cpp:

(WebCore::Gradient::fill):

  • platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::putData):

  • platform/graphics/win/PathDirect2D.cpp:

(WebCore::Path::appendGeometry):
(WebCore::Path::Path):
(WebCore::Path::operator=):
(WebCore::Path::strokeContains const):
(WebCore::Path::transform):

  • platform/graphics/win/PlatformContextDirect2D.cpp:

(WebCore::PlatformContextDirect2D::setTags):

  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::~RealtimeOutgoingAudioSource):

  • platform/mediastream/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::~RealtimeOutgoingVideoSource):

  • platform/network/HTTPParsers.cpp:

(WebCore::isCrossOriginSafeHeader):

  • platform/sql/SQLiteDatabase.cpp:
  • platform/sql/SQLiteDatabase.h:
  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::SQLiteStatement):
(WebCore::SQLiteStatement::prepare):
(WebCore::SQLiteStatement::finalize):

  • platform/sql/SQLiteStatement.h:
  • platform/win/COMPtr.h:
  • rendering/ComplexLineLayout.cpp:

(WebCore::ComplexLineLayout::removeInlineBox const):

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::FloatingObject):
(WebCore::FloatingObjects::addPlacedObject):
(WebCore::FloatingObjects::removePlacedObject):

  • rendering/FloatingObjects.h:
  • rendering/GridTrackSizingAlgorithm.cpp:
  • rendering/GridTrackSizingAlgorithm.h:
  • rendering/LayoutDisallowedScope.cpp:
  • rendering/LayoutDisallowedScope.h:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::ensureLineBoxes):

  • rendering/RenderBoxModelObject.cpp:
  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):

  • rendering/RenderElement.cpp:
  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer const):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::baselinePosition const):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::willBeDestroyed):

  • rendering/RenderLayer.cpp:

(WebCore::ClipRectsCache::ClipRectsCache):
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::paintList):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::updateClipRects):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::traverseVisibleNonCompositedDescendantLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::traverseUnchangedSubtree):
(WebCore::RenderLayerCompositor::updateBackingAndHierarchy):
(WebCore::RenderLayerCompositor::addDescendantsToOverlapMapRecursive const):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
(WebCore::RenderLayerCompositor::layerHas3DContent const):

  • rendering/RenderLayoutState.cpp:

(WebCore::RenderLayoutState::RenderLayoutState):
(WebCore::RenderLayoutState::computeOffsets):
(WebCore::RenderLayoutState::addLayoutDelta):

  • rendering/RenderLayoutState.h:

(WebCore::RenderLayoutState::RenderLayoutState):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::~RenderObject):
(WebCore::RenderObject::clearNeedsLayout):

  • rendering/RenderObject.h:
  • rendering/RenderQuote.cpp:

(WebCore::quotesForLanguage):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::computeOverflowFromCells):

  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::checkConsistency const):

  • rendering/RenderTextLineBoxes.h:
  • rendering/line/BreakingContext.h:

(WebCore::tryHyphenating):

  • rendering/style/GridArea.h:

(WebCore::GridSpan::GridSpan):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::~RenderStyle):

  • rendering/style/RenderStyle.h:
  • rendering/updating/RenderTreeBuilderRuby.cpp:

(WebCore::RenderTreeBuilder::Ruby::detach):

  • rendering/updating/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::computeNextSibling):

  • rendering/updating/RenderTreePosition.h:
  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::Placeholder::Placeholder):
(WebCore::SVGToOTFFontConverter::Placeholder::populate):
(WebCore::SVGToOTFFontConverter::appendCFFTable):
(WebCore::SVGToOTFFontConverter::firstGlyph const):
(WebCore::SVGToOTFFontConverter::appendKERNTable):

  • svg/SVGTransformDistance.cpp:

(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::scaledDistance const):
(WebCore::SVGTransformDistance::addSVGTransforms):
(WebCore::SVGTransformDistance::addToSVGTransform const):
(WebCore::SVGTransformDistance::distance const):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImage):

  • testing/InternalSettings.cpp:
  • workers/service/ServiceWorkerJob.h:
  • worklets/PaintWorkletGlobalScope.h:

(WebCore::PaintWorkletGlobalScope::~PaintWorkletGlobalScope):

  • xml/XPathStep.cpp:

Source/WebKit:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::invalidateAndCancel):

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::setCapacity):

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(toNSURLSessionResponseDisposition):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForMessage):

  • Platform/IPC/MessageReceiver.h:

(IPC::MessageReceiver::willBeAddedToMessageReceiverMap):
(IPC::MessageReceiver::willBeRemovedFromMessageReceiverMap):

  • Platform/IPC/cocoa/ConnectionCocoa.mm:

(IPC::readFromMachPort):

  • Platform/mac/MachUtilities.cpp:

(setMachExceptionPort):

  • Shared/API/APIClient.h:

(API::Client::Client):

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:
  • Shared/Cocoa/ArgumentCodersCocoa.h:
  • Shared/SharedStringHashTableReadOnly.cpp:
  • UIProcess/BackingStore.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • UIProcess/GenericCallback.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/PageLoadState.h:

(WebKit::PageLoadState::Transaction::Token::Token):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::~WebPageProxy):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponse):

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:

(WebKit::NetscapePluginStream::NetscapePluginStream):
(WebKit::NetscapePluginStream::notifyAndDestroyStream):

  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::runModal):

  • WebProcess/WebProcess.cpp:

(WebKit::checkDocumentsCaptureStateConsistency):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateProcessName):

Source/WebKitLegacy:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • Storage/StorageAreaImpl.cpp:

(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::close):

  • Storage/StorageAreaImpl.h:

Source/WebKitLegacy/mac:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • History/WebHistory.mm:

(-[WebHistoryPrivate removeItemForURLString:]):

  • WebView/WebFrame.mm:

Source/WebKitLegacy/win:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

  • WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:

(WKQCA::CAD3DRenderer::swapChain):
(WKQCA::CAD3DRenderer::initialize):

  • WebKitQuartzCoreAdditions/CAD3DRenderer.h:
  • WebView.cpp:

(WebView::Release):

  • WebView.h:

Source/WTF:
Convert ASSERT_DISABLED to ASSERT_ENABLED, and fix some tests of NDEBUG that should actually test for ASSERT_ENABLED.
​https://bugs.webkit.org/show_bug.cgi?id=205776

Reviewed by Saam Barati.

This patch did the following changes:

  1. Replaced ASSERT_DISABLED with ASSERT_ENABLED. This change does away with the need for the double negative !ASSERT_DISABLED test that is commonly used all over the code, thereby improving code readability.

In Assertions.h, there is also BACKTRACE_DISABLED, ASSERT_MSG_DISABLED,
ASSERT_ARG_DISABLED, FATAL_DISABLED, ERROR_DISABLED, LOG_DISABLED, and
RELEASE_LOG_DISABLED. We should replace those with ..._ENABLED equivalents
as well. We'll do that in another patch. For now, they are left as is to
minimize the size of this patch.
See ​https://bugs.webkit.org/show_bug.cgi?id=205780.

  1. Fixed some code was guarded with "#ifndef NDEBUG" that should actually be guarded by "#if ASSERT_ENABLED" instead.
  1. In cases where the change is minimal, we move some code around so that we can test for "#if ASSERT_ENABLED" instead of "#if !ASSERT_ENABLED".
  • wtf/Assertions.h:
  • wtf/AutomaticThread.cpp:

(WTF::AutomaticThread::start):

  • wtf/BitVector.h:
  • wtf/BlockObjCExceptions.mm:

(ReportBlockedObjCException):

  • wtf/BloomFilter.h:
  • wtf/CallbackAggregator.h:

(WTF::CallbackAggregator::CallbackAggregator):

  • wtf/CheckedArithmetic.h:

(WTF::observesOverflow<AssertNoOverflow>):

  • wtf/CheckedBoolean.h:

(CheckedBoolean::CheckedBoolean):
(CheckedBoolean::operator bool):

  • wtf/CompletionHandler.h:

(WTF::CompletionHandler<Out):

  • wtf/DateMath.cpp:

(WTF::initializeDates):

  • wtf/Gigacage.cpp:

(Gigacage::tryAllocateZeroedVirtualPages):

  • wtf/HashTable.h:

(WTF::KeyTraits>::checkKey):
(WTF::KeyTraits>::checkTableConsistencyExceptSize const):

  • wtf/LoggerHelper.h:
  • wtf/NaturalLoops.h:

(WTF::NaturalLoops::headerOf const):

  • wtf/NeverDestroyed.h:

(WTF::LazyNeverDestroyed::construct):

  • wtf/OptionSet.h:

(WTF::OptionSet::OptionSet):

  • wtf/Platform.h:
  • wtf/PtrTag.h:
  • wtf/RefCounted.h:

(WTF::RefCountedBase::disableThreadingChecks):
(WTF::RefCountedBase::enableThreadingChecksGlobally):
(WTF::RefCountedBase::RefCountedBase):
(WTF::RefCountedBase::applyRefDerefThreadingCheck const):

  • wtf/SingleRootGraph.h:

(WTF::SingleRootGraph::assertIsConsistent const):

  • wtf/SizeLimits.cpp:
  • wtf/StackBounds.h:

(WTF::StackBounds::checkConsistency const):

  • wtf/URLParser.cpp:

(WTF::URLParser::URLParser):
(WTF::URLParser::domainToASCII):

  • wtf/ValueCheck.h:
  • wtf/Vector.h:

(WTF::Malloc>::checkConsistency):

  • wtf/WeakHashSet.h:
  • wtf/WeakPtr.h:

(WTF::WeakPtrImpl::WeakPtrImpl):
(WTF::WeakPtrFactory::WeakPtrFactory):

  • wtf/text/AtomStringImpl.cpp:
  • wtf/text/AtomStringImpl.h:
  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::reifyString const):

  • wtf/text/StringBuilder.h:
  • wtf/text/StringCommon.h:

(WTF::hasPrefixWithLettersIgnoringASCIICaseCommon):

  • wtf/text/StringHasher.h:

(WTF::StringHasher::addCharacters):

  • wtf/text/StringImpl.h:
  • wtf/text/SymbolImpl.h:
  • wtf/text/UniquedStringImpl.h:

Tools:
Remove WebsiteDataStore::setServiceWorkerRegistrationDirectory
​https://bugs.webkit.org/show_bug.cgi?id=205754

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-06
Reviewed by Youenn Fablet.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::websiteDataStore):
(WTR::TestController::platformAdjustContext):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

2:20 PM Changeset in webkit [254086] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: hasLayer() in RenderLayer::enclosingOverflowClipLayer
​https://bugs.webkit.org/show_bug.cgi?id=205474

Patch by Jack Lee <Jack Lee> on 2020-01-06
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/sticky/sticky-tablecol-crash.html

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::enclosingClippingBoxForStickyPosition const):
(WebCore::RenderBoxModelObject::constrainingRectForStickyPosition const):
(WebCore::RenderBoxModelObject::stickyPositionOffset const):

LayoutTests:

  • fast/css/sticky/sticky-tablecol-crash-expected.txt: Added.
  • fast/css/sticky/sticky-tablecol-crash.html: Added.
2:17 PM Changeset in webkit [254085] by commit-queue@webkit.org
  • 12 edits in trunk

Remove WebsiteDataStore::setServiceWorkerRegistrationDirectory
​https://bugs.webkit.org/show_bug.cgi?id=205754

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-06
Reviewed by Youenn Fablet.

Source/WebKit:

The directory is now only set in the configuration, which will prevent misuse of the misplaced SPI.
Updated API tests, which still work.

  • UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.cpp:

(WKWebsiteDataStoreConfigurationCopyServiceWorkerRegistrationDirectory):
(WKWebsiteDataStoreConfigurationSetServiceWorkerRegistrationDirectory):

  • UIProcess/API/C/WKWebsiteDataStoreConfigurationRef.h:
  • UIProcess/API/C/WKWebsiteDataStoreRef.cpp:

(WKWebsiteDataStoreCopyServiceWorkerRegistrationDirectory): Deleted.
(WKWebsiteDataStoreSetServiceWorkerRegistrationDirectory): Deleted.

  • UIProcess/API/C/WKWebsiteDataStoreRef.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _hasRegisteredServiceWorker]):
(-[WKWebsiteDataStore _serviceWorkerRegistrationDirectory]): Deleted.
(-[WKWebsiteDataStore _setServiceWorkerRegistrationDirectory:]): Deleted.

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
  • UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::setCacheStorageDirectory):
(WebKit::WebsiteDataStore::serviceWorkerRegistrationDirectory const): Deleted.
(WebKit::WebsiteDataStore::setServiceWorkerRegistrationDirectory): Deleted.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::websiteDataStore):
(WTR::TestController::platformAdjustContext):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):

1:59 PM Changeset in webkit [254084] by commit-queue@webkit.org
  • 4 edits in trunk

Allow wildcard scheme in UserContentURLPattern
​https://bugs.webkit.org/show_bug.cgi?id=205695

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-06
Reviewed by Darin Adler.

Source/WebCore:

This is needed for <rdar://problem/58011337> and covered by an API test.

  • page/UserContentURLPattern.cpp:

(WebCore::UserContentURLPattern::matches const):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1:57 PM Changeset in webkit [254083] by Alan Coon
  • 1 copy in tags/Safari-609.1.13.3

Tag Safari-609.1.13.3.

1:53 PM Changeset in webkit [254082] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk

REGRESSION: [ iOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205458
<rdar://problem/58081704>

Patch by Antoine Quint <Antoine Quint> on 2020-01-06
Reviewed by Wenson Hsieh.

Tools:

The last sub-test in imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html checks on the
ability to activate various form controls after disabling and re-enabling them. Two of those form controls, <select>
and <textarea>, would trigger animations of the web view's UIScrollView causing touches to be consumed by UIKit and
never seen by the WKContentView, and as such the expected "click" events would not be received. It would have been
possible to modify the test to wait on any potential page scroll to complete before dispatching taps, but since this
is a WPT test, we cannot modify it. Instead, we make a change to the function called by uiScriptController.singleTapAtPoint()
to interrupt any pending UIScrollView animation when a tap is being triggered on the web view. Credit to Wenson Hsieh
for suggesting this simple and effective approach.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):

LayoutTests:

Remove the platform-specific expectation since this test now passes reliably on iOS as well.

  • platform/ios/imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements-expected.txt: Removed.
1:23 PM Changeset in webkit [254081] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebKit

Remove _WKProcessPoolConfiguration.CTDataConnectionServiceType and suppressesConnectionTerminationOnSystemChange
​https://bugs.webkit.org/show_bug.cgi?id=205751

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-06
Reviewed by Darin Adler.

Their replacements on _WKWebViewConfiguration have been adopted.

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::suppressesConnectionTerminationOnSystemChange const): Deleted.

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::dataConnectionServiceType const):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCTDataConnectionServiceType): Deleted.
(WebKit::NetworkSessionCocoa::setCTDataConnectionServiceType): Deleted.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration suppressesConnectionTerminationOnSystemChange]): Deleted.
(-[_WKProcessPoolConfiguration setSuppressesConnectionTerminationOnSystemChange:]): Deleted.
(-[_WKProcessPoolConfiguration CTDataConnectionServiceType]): Deleted.
(-[_WKProcessPoolConfiguration setCTDataConnectionServiceType:]): Deleted.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::paymentCoordinatorCTDataConnectionServiceType):

12:58 PM Changeset in webkit [254080] by mark.lam@apple.com
  • 3 edits in trunk/Tools

Add --force-optimization-level option to Tools/Scripts/set-webkit-configuration.
​https://bugs.webkit.org/show_bug.cgi?id=205787

Reviewed by Saam Barati.

Usage:

--force-optimization-level=<opt> Force optimization: O3, O2, O1, O0, Os, Ofast, Og, or none

This can be used to force debug builds to be built with a higher level optimization
so that tests can run to completion faster.

It can also be useful as a simple way to force release builds to be built with
different optimization levels for performance comparison.

Setting --force-optimization-level=none restores the default optimization levels.
Of course, the build targets need to be rebuilt for this to take effect.

  • Scripts/set-webkit-configuration:
  • Scripts/webkitdirs.pm:

(determineForceOptimizationLevel):
(forceOptimizationLevel):
(XcodeOptions):

12:56 PM Changeset in webkit [254079] by youenn@apple.com
  • 4 edits in trunk/Source/WebCore

Fix non unified build in FIDO Pin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=205794

Reviewed by Jiewen Tan.

No change of behavior, this is a build fix.

  • Modules/webauthn/fido/Pin.cpp:
12:46 PM Changeset in webkit [254078] by Keith Rollin
  • 3 edits in trunk/Source/WebKit

Reformat WebPage logging
​https://bugs.webkit.org/show_bug.cgi?id=205709
<rdar://problem/58290285>

Reviewed by Brent Fulgham.

Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x4a1df5000 - WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (frame=0x4a1db0220, priority=0, webPageID=15, frameID=3, resourceID=32)',

becomes:

0x4a1df5000 - [resourceLoader=0x1418b7200, frameLoader=0x1326d7340, frame=0x4a1db0220, webPageID=15, frameID=3, resourceID=32] WebLoaderStrategy::scheduleLoad: Resource is being scheduled with the NetworkProcess (priority=2)

This new form is a lot more verbose, but it really helps in tracing
activity from the top of our page/frame/resource load stack to the
bottom.

No new tests - no added or changed functionality.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::tryLoadingUsingURLSchemeHandler):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):

  • WebProcess/Network/WebLoaderStrategy.h:
12:42 PM Changeset in webkit [254077] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Regression r254029: imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205819

Unreviewed, rebaseline test on iOS after r254029 now that one more check is passing.

  • platform/ios/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
12:38 PM Changeset in webkit [254076] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Regression r254029: imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205817

Unreviewed, rebaseline test on iOS after r254029 now that more checks are passing.

  • platform/ios-wk2/imported/w3c/web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt:
12:29 PM Changeset in webkit [254075] by commit-queue@webkit.org
  • 7 edits
    2 moves in trunk/Source/WebKit

Add WKWebView SPI to query _WKMediaMutedState
​https://bugs.webkit.org/show_bug.cgi?id=205789
<rdar://problem/58335241>

Patch by Luming Yin <​luming_yin@apple.com> on 2020-01-06
Reviewed by Eric Carlson.

Add plumbing for clients to query the media muted state on WKWebView.

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _mediaMutedState]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/Cocoa/MediaUtilities.h: Renamed from Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.h.
  • UIProcess/Cocoa/MediaUtilities.mm: Renamed from Source/WebKit/UIProcess/Cocoa/MediaCaptureUtilities.mm.

(WebKit::toWKMediaCaptureState):
(WebKit::toWKMediaMutedState):

  • UIProcess/Cocoa/UIDelegate.mm:
  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::mutedStateFlags const):

  • WebKit.xcodeproj/project.pbxproj:
12:11 PM Changeset in webkit [254074] by Simon Fraser
  • 6 edits in trunk/LayoutTests

REGRESSION: [r254042] pageoverlay/overlay- tests are failing in WK1
​https://bugs.webkit.org/show_bug.cgi?id=205810

Unreviewed test gardening. Page Overlay test in WK1 now dump one or more repaint rects after r254042.

  • platform/mac-wk1/pageoverlay/overlay-installation-expected.txt:
  • platform/mac-wk1/pageoverlay/overlay-large-document-expected.txt:
  • platform/mac-wk1/pageoverlay/overlay-large-document-scrolled-expected.txt:
  • platform/mac-wk1/pageoverlay/overlay-small-frame-mouse-events-expected.txt:
  • platform/mac-wk1/pageoverlay/overlay-small-frame-paints-expected.txt:
11:54 AM Changeset in webkit [254073] by Alan Coon
  • 2 edits in branches/safari-608-branch/Source/WebCore

Protect ServiceWorker::postMessage from a null execState
​https://bugs.webkit.org/show_bug.cgi?id=205394
<rdar://problem/57392221>

Reviewed by Chris Dumez.

Crash logs indicate null pointer crashes.
We should return early in that case.

  • workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

11:47 AM Changeset in webkit [254072] by Alan Coon
  • 7 edits in branches/safari-608-branch/Source

Versioning.

11:32 AM Changeset in webkit [254071] by Alan Coon
  • 1 copy in branches/safari-609.1.14-branch

New branch.

11:31 AM Changeset in webkit [254070] by Alexey Shvayka
  • 6 edits in trunk

Proxy's OwnPropertyKeys? is incorrect in DontEnumPropertiesMode::Exclude
​https://bugs.webkit.org/show_bug.cgi?id=203818

Reviewed by Keith Miller.

JSTests:

Stress test was failing because "ownKeys" trap didn't return non-configurable
"prototype" property of Proxy's target, violating an invariant.

  • stress/proxy-get-own-property-names-should-not-clear-previous-results.js:
  • test262/expectations.yaml: Mark 8 test cases as passing.

Source/JavaScriptCore:

This change fixes two spec compatibility issues:

  1. If Object.keys is called on Proxy w/o "ownKeys" trap, filtering non-enumerable

properties are not observed by "getOwnPropertyDescriptor" trap.
(step 4 of ​https://tc39.es/ecma262/#sec-enumerableownpropertynames)

  1. If Object.keys is called on Proxy with "ownKeys" trap, non-enumerable

properties of Proxy's target are ignored during invariants validation.
(step 11 of ​https://tc39.es/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-ownpropertykeys)

Instead of extracting DontEnum filtering to lambda function, a wrapper method for
ProxyObject::performGetOwnPropertyNames was introduced to avoid creating &
filling intermediate PropertyNameArray instance (in case of DontEnumPropertiesMode::Include)
and avoid having inner EnumerationMode in ProxyObject::performGetOwnPropertyNames.

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performGetOwnEnumerablePropertyNames):
(JSC::ProxyObject::getOwnPropertyNames):

  • runtime/ProxyObject.h:
11:27 AM Changeset in webkit [254069] by Alan Coon
  • 1 copy in branches/safari-609-branch

New branch.

11:18 AM Changeset in webkit [254068] by Alan Coon
  • 8 edits in trunk/Source

Versioning.

11:16 AM Changeset in webkit [254067] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r247626): Introduced memory regression
​https://bugs.webkit.org/show_bug.cgi?id=205815

Unreviewed rollout of ​https://trac.webkit.org/changeset/247626/webkit.

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::prewarmGlobally):
(WebCore::fontFamiliesForPrewarming): Deleted.

11:00 AM Changeset in webkit [254066] by Truitt Savell
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Catalina wk1 ] editing/mac/attributed-string/attributed-string-across-shadow-boundaries-with-style-2.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205814

unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
10:59 AM Changeset in webkit [254065] by ysuzuki@apple.com
  • 5 edits in trunk/Source/WebCore

[WebCore] Shrink sizeof(RuleFeature)
​https://bugs.webkit.org/show_bug.cgi?id=205774

Reviewed by Dean Jackson.

We noticed that Vector<RuleFeature> is frequently allocated and kept. While sizeof(RuleFeature) is 32,

  1. RuleFeature::invalidationSelector is nullptr basically. It is used only for some specific cases.
  2. RuleFeature::selectorIndex and RuleFeature::selectorListIndex is unsigned. But they never exceed uint16_t since both values are derived from RuleData::m_selectorIndex and RuleData::m_selectorListIndex and both are uint16_t size.
  3. Optional<MatchElement> takes 8 bytes since sizeof(MatchElement) is 4. But we can make it 1 byte.

Given the above observations, this patch introduced RuleFeatureWithInvalidationSelector, which is RuleFeature + invalidationSelector.
And keep using RuleFeature if invalidationSelector is unnecessary. By applying (2) and (3)'s optimizations, we can now make
sizeof(RuleFeature) 16, 50% reduction.

No behavior change.

  • style/RuleData.h:
  • style/RuleFeature.cpp:

(WebCore::Style::RuleFeature::RuleFeature):
(WebCore::Style::RuleFeatureSet::collectFeatures):
(WebCore::Style::RuleFeatureSet::add):

  • style/RuleFeature.h:

(WebCore::Style::RuleFeatureWithInvalidationSelector::RuleFeatureWithInvalidationSelector):

  • style/StyleScopeRuleSets.cpp:

(WebCore::Style::ensureInvalidationRuleSets):

10:52 AM Changeset in webkit [254064] by dino@apple.com
  • 149 edits
    27 moves
    2 adds
    2 deletes in trunk

Rename GraphicsContext3D to GraphicsContextGL
​https://bugs.webkit.org/show_bug.cgi?id=205778
<rdar://problem/58327597>

Reviewed by Sam Weinig.

Rename all the GraphicsContext3D things to GraphicsContextGL
(includes Extensions3D and GRAPHICS_CONTEXT_3D).

GraphicsContext3DBase now becomes GraphicsContextGL.
GraphicsContext3D is now GraphicsContextGLOpenGL (since it represents
the OpenGL implementation of the API).

.:

  • Source/CMakeLists.txt:
  • Source/cmake/OptionsFTW.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsPlayStation.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWinCairo.cmake:

PerformanceTests:

  • StitchMarker/wtf/FeatureDefines.h:
  • StitchMarker/wtf/Platform.h:

Source/WebCore:

  • CMakeLists.txt:
  • Headers.cmake:
  • PlatformAppleWin.cmake:
  • PlatformFTW.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformPlayStation.cmake:
  • PlatformWin.cmake:
  • Sources.txt:
  • SourcesCocoa.txt:
  • SourcesGTK.txt:
  • SourcesWPE.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLVideoElement.cpp:
  • html/HTMLVideoElement.h:
  • html/OffscreenCanvas.cpp:
  • html/canvas/ANGLEInstancedArrays.cpp:
  • html/canvas/OESVertexArrayObject.cpp:
  • html/canvas/WebGL2RenderingContext.cpp:
  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGLActiveInfo.h:
  • html/canvas/WebGLBuffer.cpp:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLCompressedTextureASTC.cpp:
  • html/canvas/WebGLCompressedTextureATC.cpp:
  • html/canvas/WebGLCompressedTextureETC.cpp:
  • html/canvas/WebGLCompressedTextureETC1.cpp:
  • html/canvas/WebGLCompressedTexturePVRTC.cpp:
  • html/canvas/WebGLCompressedTextureS3TC.cpp:
  • html/canvas/WebGLContextAttributes.h:
  • html/canvas/WebGLContextGroup.cpp:
  • html/canvas/WebGLContextGroup.h:
  • html/canvas/WebGLContextObject.cpp:
  • html/canvas/WebGLContextObject.h:
  • html/canvas/WebGLDebugShaders.cpp:
  • html/canvas/WebGLDepthTexture.cpp:
  • html/canvas/WebGLDepthTexture.h:
  • html/canvas/WebGLDrawBuffers.cpp:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLObject.cpp:
  • html/canvas/WebGLObject.h:
  • html/canvas/WebGLProgram.cpp:
  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLQuery.cpp:
  • html/canvas/WebGLQuery.h:
  • html/canvas/WebGLRenderbuffer.cpp:
  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLRenderingContextBase.cpp:
  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGLSampler.cpp:
  • html/canvas/WebGLSampler.h:
  • html/canvas/WebGLShader.cpp:
  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLShaderPrecisionFormat.h:
  • html/canvas/WebGLSharedObject.cpp:
  • html/canvas/WebGLSharedObject.h:
  • html/canvas/WebGLSync.cpp:
  • html/canvas/WebGLSync.h:
  • html/canvas/WebGLTexture.cpp:
  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLTransformFeedback.cpp:
  • html/canvas/WebGLTransformFeedback.h:
  • html/canvas/WebGLVertexArrayObject.cpp:
  • html/canvas/WebGLVertexArrayObject.h:
  • html/canvas/WebGLVertexArrayObjectBase.cpp:
  • html/canvas/WebGLVertexArrayObjectBase.h:
  • html/canvas/WebGLVertexArrayObjectOES.cpp:
  • html/canvas/WebGLVertexArrayObjectOES.h:
  • inspector/InspectorShaderProgram.cpp:
  • loader/FrameLoaderClient.h:
  • page/Chrome.cpp:
  • platform/SourcesCairo.txt:
  • platform/TextureMapper.cmake:
  • platform/WebGLStateTracker.cpp:
  • platform/WebGLStateTracker.h:
  • platform/graphics/ANGLEWebKitBridge.cpp:
  • platform/graphics/ExtensionsGL.h: Renamed from Source/WebCore/platform/graphics/Extensions3D.h.
  • platform/graphics/FormatConverter.cpp:
  • platform/graphics/FormatConverter.h:
  • platform/graphics/GLContext.cpp:
  • platform/graphics/GLContext.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.cpp: Removed.
  • platform/graphics/GraphicsContext3DBase.cpp: Removed.
  • platform/graphics/GraphicsContextGL.cpp: Added.
  • platform/graphics/GraphicsContextGL.h: Renamed from Source/WebCore/platform/graphics/GraphicsContext3DBase.h.
  • platform/graphics/GraphicsContextGLAttributes.h: Renamed from Source/WebCore/platform/graphics/GraphicsContext3DAttributes.h.
  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:
  • platform/graphics/OpenGLShims.cpp:
  • platform/graphics/angle/ExtensionsGLANGLE.cpp: Renamed from Source/WebCore/platform/graphics/angle/Extensions3DANGLE.cpp.
  • platform/graphics/angle/ExtensionsGLANGLE.h: Renamed from Source/WebCore/platform/graphics/angle/Extensions3DANGLE.h.
  • platform/graphics/angle/GraphicsContextGLANGLE.cpp: Renamed from Source/WebCore/platform/graphics/angle/GraphicsContext3DANGLE.cpp.
  • platform/graphics/angle/TemporaryANGLESetting.cpp:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
  • platform/graphics/cairo/GraphicsContextGLCairo.cpp: Renamed from Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp.
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/cg/GraphicsContextGLCG.cpp: Renamed from Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp.
  • platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm: Renamed from Source/WebCore/platform/graphics/cocoa/GraphicsContext3DCocoa.mm.
  • platform/graphics/cocoa/IOSurface.mm:
  • platform/graphics/cocoa/WebGLLayer.h:
  • platform/graphics/cocoa/WebGLLayer.mm:
  • platform/graphics/cpu/arm/GraphicsContextGLNEON.h: Renamed from Source/WebCore/platform/graphics/cpu/arm/GraphicsContext3DNEON.h.
  • platform/graphics/cv/TextureCacheCV.h:
  • platform/graphics/cv/TextureCacheCV.mm:
  • platform/graphics/cv/VideoTextureCopierCV.cpp:
  • platform/graphics/cv/VideoTextureCopierCV.h:
  • platform/graphics/egl/GLContextEGL.cpp:
  • platform/graphics/egl/GLContextEGL.h:
  • platform/graphics/glx/GLContextGLX.cpp:
  • platform/graphics/glx/GLContextGLX.h:
  • platform/graphics/gpu/Texture.cpp:
  • platform/graphics/gpu/Texture.h:
  • platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/ios/GraphicsContextGLOpenGLESIOS.h: Renamed from Source/WebCore/platform/graphics/ios/GraphicsContext3DIOS.h.
  • platform/graphics/nicosia/texmap/NicosiaGC3DANGLELayer.cpp:
  • platform/graphics/nicosia/texmap/NicosiaGC3DANGLELayer.h:
  • platform/graphics/nicosia/texmap/NicosiaGC3DLayer.cpp:
  • platform/graphics/nicosia/texmap/NicosiaGC3DLayer.h:
  • platform/graphics/opengl/ExtensionsGLOpenGL.cpp: Renamed from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp.
  • platform/graphics/opengl/ExtensionsGLOpenGL.h: Renamed from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h.
  • platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp: Renamed from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.cpp.
  • platform/graphics/opengl/ExtensionsGLOpenGLCommon.h: Renamed from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h.
  • platform/graphics/opengl/ExtensionsGLOpenGLES.cpp: Renamed from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp.
  • platform/graphics/opengl/ExtensionsGLOpenGLES.h: Renamed from Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.h.
  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp: Added.
  • platform/graphics/opengl/GraphicsContextGLOpenGL.h: Renamed from Source/WebCore/platform/graphics/GraphicsContext3D.h.
  • platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp: Renamed from Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp.
  • platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp: Renamed from Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp.
  • platform/graphics/opengl/GraphicsContextGLOpenGLES.cpp: Renamed from Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp.
  • platform/graphics/opengl/GraphicsContextGLOpenGLManager.cpp: Renamed from Source/WebCore/platform/graphics/GraphicsContext3DManager.cpp.
  • platform/graphics/opengl/GraphicsContextGLOpenGLManager.h: Renamed from Source/WebCore/platform/graphics/GraphicsContext3DManager.h.
  • platform/graphics/opengl/GraphicsContextGLOpenGLPrivate.cpp: Renamed from Source/WebCore/platform/graphics/GraphicsContext3DPrivate.cpp.
  • platform/graphics/opengl/GraphicsContextGLOpenGLPrivate.h: Renamed from Source/WebCore/platform/graphics/GraphicsContext3DPrivate.h.
  • platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
  • platform/graphics/opengl/TemporaryOpenGLSetting.h:
  • platform/graphics/texmap/BitmapTextureGL.cpp:
  • platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp: Renamed from Source/WebCore/platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp.
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/win/GraphicsContextGLDirect2D.cpp: Renamed from Source/WebCore/platform/graphics/win/GraphicsContext3DDirect2D.cpp.
  • testing/Internals.cpp:

Source/WebKit:

  • CMakeLists.txt:
  • UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::initializeEGL):

  • UIProcess/mac/HighPerformanceGPUManager.cpp:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::copyVideoTextureToPlatformTexture):

  • WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/WebPageMac.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::displayConfigurationChanged):

Source/WTF:

  • wtf/FeatureDefines.h:
  • wtf/Platform.h:

Tools:

  • Scripts/webkitpy/common/config/watchlist:
10:39 AM Changeset in webkit [254063] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy/mac

[Web Animations] Enable CSS Animations via Web Animations for WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=205791

Patch by Antoine Quint <Antoine Quint> on 2020-01-06
Reviewed by Dean Jackson.

It was an oversight that it had not been done along with the WebKit change.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

10:33 AM Changeset in webkit [254062] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove unused variable jsDriverArgs from script
​https://bugs.webkit.org/show_bug.cgi?id=205797

Patch by Paulo Matos <Paulo Matos> on 2020-01-06
Reviewed by Žan Doberšek.

  • Scripts/run-javascriptcore-tests:
10:24 AM Changeset in webkit [254061] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r218839): Web Inspector: Color picker: pressing Esc should hide color picker
​https://bugs.webkit.org/show_bug.cgi?id=205570
<rdar://problem/58169820>

Reviewed by Brian Burg.

  • UserInterface/Views/QuickConsole.js:

(WI.QuickConsole.prototype.set keyboardShortcutDisabled):
(WI.QuickConsole.prototype._toggleOrFocus):
Restore keyboardShortcutDisabled setter, which was removed in r218839 without any explanation.

10:08 AM Changeset in webkit [254060] by Truitt Savell
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac WK2 ] fast/text/international/unicode-bidi-other-neutrals.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205808

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:56 AM Changeset in webkit [254059] by Truitt Savell
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac Debug ] inspector/page/setBootstrapScript-main-frame.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=205807

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:48 AM Changeset in webkit [254058] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: unable to see recording actions for WebGL canvases that have lots of shader programs
​https://bugs.webkit.org/show_bug.cgi?id=205659

Reviewed by Brian Burg.

Limit the height of the canvas and shader program tree a recording is selected.

  • UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):

  • UserInterface/Views/CanvasSidebarPanel.css:

(.sidebar > .panel.navigation.canvas.showing-recording > .content > .tree-outline.canvas): Added.

9:39 AM Changeset in webkit [254057] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add support for passing test arguments in envvar TEST_JSC_ARGS
​https://bugs.webkit.org/show_bug.cgi?id=205800

Patch by Paulo Matos <Paulo Matos> on 2020-01-06
Reviewed by Žan Doberšek.

Similarly to what is done in build-jsc, we add support to pass
extra command line arguments in environment variable TEST_JSC_ARGS.

  • Scripts/run-javascriptcore-tests:
9:33 AM Changeset in webkit [254056] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mojave ] tables/mozilla_expected_failures/bugs/bug2479-5.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205805
<rdar://problem/58342884>

Unreviewed.

Rebaseline after r254044.

  • platform/mac-mojave/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
9:09 AM Changeset in webkit [254055] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit

Remove unused GlobalFrameID from NetworkCacheSpeculativeLoad
​https://bugs.webkit.org/show_bug.cgi?id=205796

Patch by Rob Buis <​rbuis@igalia.com> on 2020-01-06
Reviewed by Chris Dumez.

Remove unused GlobalFrameID from NetworkCacheSpeculativeLoad
and NetworkCache::update.

No change in behavior.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::update):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveResponse):

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
8:44 AM Changeset in webkit [254054] by Simon Fraser
  • 12 edits
    2 adds in trunk

REGRESSION (r252724): Unable to tap on play button on google video 'See the top search trends of 2019'
​https://bugs.webkit.org/show_bug.cgi?id=205694
<rdar://problem/58062987>

Reviewed by Zalan Bujtas.

Source/WebCore:

After r252724, which separated 'used' from 'specified' z-index in style, we need to copy
the specified to the used z-index in animated styles, while preserving the existing 'forceStackingContext'
behavior which set the used z-index to 0.

Do so by creating Adjuster::adjustAnimatedStyle(), which is called from TreeResolver::createAnimatedElementUpdate()
if any animations could have affected the style. We need to pass back information about whether the animation should
force stacking context.

Test: animations/z-index-in-keyframe.html

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::apply):

  • animation/KeyframeEffect.h:

(WebCore::KeyframeEffect::triggersStackingContext const):

  • dom/Element.cpp:

(WebCore::Element::applyKeyframeEffects):

  • dom/Element.h:
  • page/animation/CSSAnimationController.h:

(): Deleted.

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::animate):

  • style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjustAnimatedStyle):

  • style/StyleAdjuster.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

LayoutTests:

  • animations/z-index-in-keyframe-expected.html: Added.
  • animations/z-index-in-keyframe.html: Added.
8:36 AM Changeset in webkit [254053] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Regression r254029: imported/w3c/web-platform-tests/html/dom/idlharness.https.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205803

Unreviewed, rebaseline WPT test on iOS after r254029, now that more checks are passing.

  • platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
8:03 AM Changeset in webkit [254052] by pvollan@apple.com
  • 16 edits
    2 adds in trunk

[iOS] Issue mach lookup extension to launch services daemon for Mail
​https://bugs.webkit.org/show_bug.cgi?id=205316

Reviewed by Brent Fulgham.

Source/WebCore:

Export function getting bundle identifier.

Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html

  • platform/RuntimeApplicationChecks.h:

Source/WebKit:

Issue mach lookup extension to "com.apple.lsd.open" for Mail, since this service will be removed from the WebContent sandbox.

Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
  • UIProcess/API/Cocoa/WKWebViewTesting.mm:

(+[WKWebView _setApplicationBundleIdentifier:]):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Tools:

Add test option to set bundle identifier. Using this, WebKitTestRunner can pretend to be any client, e.g. Mail.

Test: fast/sandbox/ios/sandbox-mach-lookup-mail.html

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::setApplicationBundleIdentifier):

LayoutTests:

  • fast/sandbox/ios/sandbox-mach-lookup-mail-expected.txt: Added.
  • fast/sandbox/ios/sandbox-mach-lookup-mail.html: Added.
7:02 AM Changeset in webkit [254051] by youenn@apple.com
  • 5 edits in trunk/Source

RemoteVideoSample::create does not need to take a MediaSample r value
​https://bugs.webkit.org/show_bug.cgi?id=205793

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

  • platform/graphics/RemoteVideoSample.cpp:

(WebCore::RemoteVideoSample::create):

  • platform/graphics/RemoteVideoSample.h:

Source/WebKit:

  • UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
1:47 AM Changeset in webkit [254050] by youenn@apple.com
  • 26 edits
    1 copy
    3 adds in trunk/Source

Implement RTC VTB encoders in GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=205713

Reviewed by Eric Carlson.

Source/ThirdParty/libwebrtc:

Add support for remote video encoders created and used through simple routines.
Add factory to create video encoders implemented elsewhere than in WebRTC backend.
This is used for H264 encoders.

  • Configurations/libwebrtc.iOS.exp:
  • Configurations/libwebrtc.iOSsim.exp:
  • Configurations/libwebrtc.mac.exp:
  • Source/webrtc/sdk/WebKit/WebKitEncoder.h: Added.

(webrtc::WebKitRTPFragmentationHeader::value):
(webrtc::WebKitEncodedFrameInfo::decode):
(webrtc::WebKitEncodedFrameInfo::encode const):
(webrtc::WebKitRTPFragmentationHeader::WebKitRTPFragmentationHeader):
(webrtc::WebKitRTPFragmentationHeader::encode const):
(webrtc::WebKitRTPFragmentationHeader::decode):

  • Source/webrtc/sdk/WebKit/WebKitEncoder.mm: Added.

(webrtc::VideoEncoderFactoryWithSimulcast::CreateVideoEncoder):
(webrtc::videoEncoderCallbacks):
(webrtc::setVideoEncoderCallbacks):
(webrtc::RemoteVideoEncoder::RemoteVideoEncoder):
(webrtc::RemoteVideoEncoder::InitEncode):
(webrtc::RemoteVideoEncoder::Release):
(webrtc::RemoteVideoEncoder::Encode):
(webrtc::RemoteVideoEncoder::SetRates):
(webrtc::RemoteVideoEncoder::GetEncoderInfo const):
(webrtc::RemoteVideoEncoder::RegisterEncodeCompleteCallback):
(webrtc::RemoteVideoEncoder::encodeComplete):
(webrtc::createLocalEncoder):
(webrtc::releaseLocalEncoder):
(webrtc::initializeLocalEncoder):
(webrtc::encodeLocalEncoderFrame):
(webrtc::setLocalEncoderRates):

  • Source/webrtc/sdk/WebKit/WebKitUtilities.h:
  • Source/webrtc/sdk/WebKit/WebKitUtilities.mm:
  • libwebrtc.xcodeproj/project.pbxproj:

Source/WebCore:

Refactoring to expose a createPixelBuffer routine, to set/get RemoteVideoSample and to create a CVPixelBuffer from an IOSurfaceRef.

Covered by existing tests, in particular webrtc/video-gpuProcess.html.

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/RemoteVideoSample.cpp:

(WebCore::RemoteVideoSample::create):

  • platform/graphics/RemoteVideoSample.h:

(WebCore::RemoteVideoSample::rotation const):

  • platform/graphics/cv/ImageTransferSessionVT.h:
  • platform/graphics/cv/ImageTransferSessionVT.mm:

(WebCore::ImageTransferSessionVT::createPixelBuffer):

  • platform/mediastream/mac/RealtimeIncomingVideoSourceCocoa.mm:

(WebCore::RealtimeIncomingVideoSourceCocoa::pixelBufferPool):

  • platform/mediastream/mac/RealtimeVideoUtilities.h:
  • platform/mediastream/mac/RealtimeVideoUtilities.mm: Added.

(WebCore::createPixelBufferPool):

Source/WebKit:

Add support for remote video encoders in GPUProcess based on libwebrtc exposed routines.
WebProcess sets callbacks in the webrtc backend to implement H264 encoding as a remote video encoder.
In addition to video frames, we also need to send rate setting orders.

  • Configurations/WebKit.xcconfig:
  • GPUProcess/webrtc/LibWebRTCCodecsProxy.h:
  • GPUProcess/webrtc/LibWebRTCCodecsProxy.messages.in:
  • GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

(WebKit::LibWebRTCCodecsProxy::~LibWebRTCCodecsProxy):
(WebKit::LibWebRTCCodecsProxy::createEncoder):
(WebKit::LibWebRTCCodecsProxy::releaseEncoder):
(WebKit::LibWebRTCCodecsProxy::initializeEncoder):
(WebKit::toWebRTCVideoRotation):
(WebKit::LibWebRTCCodecsProxy::encodeFrame):
(WebKit::LibWebRTCCodecsProxy::setEncodeRates):

  • Scripts/webkit/messages.py:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::createVideoEncoder):
(WebKit::releaseVideoEncoder):
(WebKit::initializeVideoEncoder):
(WebKit::toMediaSampleVideoRotation):
(WebKit::encodeVideoFrame):
(WebKit::registerEncodeCompleteCallback):
(WebKit::setEncodeRatesCallback):
(WebKit::LibWebRTCCodecs::setCallbacks):
(WebKit::LibWebRTCCodecs::createDecoder):
(WebKit::LibWebRTCCodecs::releaseDecoder):
(WebKit::LibWebRTCCodecs::failedDecoding):
(WebKit::LibWebRTCCodecs::completedDecoding):
(WebKit::LibWebRTCCodecs::createEncoder):
(WebKit::LibWebRTCCodecs::releaseEncoder):
(WebKit::LibWebRTCCodecs::initializeEncoder):
(WebKit::LibWebRTCCodecs::encodeFrame):
(WebKit::LibWebRTCCodecs::registerEncodeFrameCallback):
(WebKit::LibWebRTCCodecs::setEncodeRates):
(WebKit::LibWebRTCCodecs::completedEncoding):
(WebKit::LibWebRTCCodecs::pixelBufferPool):

  • WebProcess/GPU/webrtc/LibWebRTCCodecs.h:
  • WebProcess/GPU/webrtc/LibWebRTCCodecs.messages.in:
  • WebProcess/GPU/webrtc/RTCEncoderIdentifier.h: Added.
  • WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

(WebKit::LibWebRTCProvider::createDecoderFactory):

1:12 AM Changeset in webkit [254049] by Philippe Normand
  • 2 edits in trunk/Tools

[WPE][Qt] TestRunJavaScript failure
​https://bugs.webkit.org/show_bug.cgi?id=205766

Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp:

(TestRunJavaScript::main): Surround JS function with parentheses
to comply with the ECMAScript specification.

Jan 5, 2020:

9:47 PM Changeset in webkit [254048] by eric.carlson@apple.com
  • 19 edits
    1 copy
    1 add in trunk/Source

[Media in GPU process] Add remote MIME type cache
​https://bugs.webkit.org/show_bug.cgi?id=205763
<rdar://problem/58312152>

Reviewed by Dean Jackson.
Source/WebCore:

Create a MIME type cache for RemoteMediaPlayerManager so types without a
'codecs' parameter don't typically require IPC, and when it is required the
result is cached so it is only required once.

  • platform/graphics/MIMETypeCache.cpp:

(WebCore::MIMETypeCache::supportsContainerType):
(WebCore::MIMETypeCache::canDecodeType):
(WebCore::MIMETypeCache::setSupportedTypes):
(WebCore::MIMETypeCache::staticContainerTypeList):
(WebCore::MIMETypeCache::isUnsupportedContainerType):
(WebCore::MIMETypeCache::isAvailable const):
(WebCore::MIMETypeCache::isEmpty const):
(WebCore::MIMETypeCache::initializeCache):
(WebCore::MIMETypeCache::canDecodeExtendedType):
(WebCore::MIMETypeCache::canDecodeTypePrivate): Deleted.
(WebCore::MIMETypeCache::addSupportedTypes): Deleted.
(WebCore::MIMETypeCache::addSupportedType): Deleted.

  • platform/graphics/MIMETypeCache.h:

(WebCore::MIMETypeCache::isUnsupportedContainerType): Deleted.
(WebCore::MIMETypeCache::isAvailable const): Deleted.
(WebCore::MIMETypeCache::isEmpty const): Deleted.
(WebCore::MIMETypeCache::canDecodeTypeInternal): Deleted.
(WebCore::MIMETypeCache::initializeCache): Deleted.

  • platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.h:
  • platform/graphics/avfoundation/objc/AVAssetMIMETypeCache.mm:

(WebCore::AVAssetMIMETypeCache::canDecodeExtendedType):
(WebCore::AVAssetMIMETypeCache::setSupportedTypes):
(WebCore::AVAssetMIMETypeCache::canDecodeTypeInternal): Deleted.

  • platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.h:
  • platform/graphics/avfoundation/objc/AVStreamDataParserMIMETypeCache.mm:

(WebCore::AVStreamDataParserMIMETypeCache::canDecodeExtendedType):
(WebCore::AVStreamDataParserMIMETypeCache::canDecodeTypeInternal): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsTypeAndCodecs):
(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType): Deleted.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::supportsType):

Source/WebKit:

  • GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::supportsTypeAndCodecs):
(WebKit::RemoteMediaPlayerManagerProxy::canDecodeExtendedType):
(WebKit::RemoteMediaPlayerManagerProxy::supportsType): Deleted.

  • GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
  • GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.cpp: Added.

(WebKit::RemoteMediaPlayerMIMETypeCache::RemoteMediaPlayerMIMETypeCache):
(WebKit::RemoteMediaPlayerMIMETypeCache::mimeCache const):
(WebKit::RemoteMediaPlayerMIMETypeCache::isAvailable const):
(WebKit::RemoteMediaPlayerMIMETypeCache::staticContainerTypeList):
(WebKit::RemoteMediaPlayerMIMETypeCache::isUnsupportedContainerType):
(WebKit::RemoteMediaPlayerMIMETypeCache::canDecodeExtendedType):
(WebKit::RemoteMediaPlayerMIMETypeCache::supportsTypeAndCodecs):
(WebKit::RemoteMediaPlayerMIMETypeCache::initializeCache):

  • WebProcess/GPU/media/RemoteMediaPlayerMIMETypeCache.h: Added.
  • WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:

(WebKit::mimeCaches):
(WebKit::RemoteMediaPlayerManager::typeCache):
(WebKit::RemoteMediaPlayerManager::initialize):
(WebKit::RemoteMediaPlayerManager::getSupportedTypes):
(WebKit::RemoteMediaPlayerManager::supportsTypeAndCodecs):

  • WebProcess/GPU/media/RemoteMediaPlayerManager.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::setMediaMIMETypes):

5:36 PM Changeset in webkit [254047] by Wenson Hsieh
  • 5 edits in trunk/Source/WebCore

Work towards implementing DisplayList::DrawGlyphs
​https://bugs.webkit.org/show_bug.cgi?id=205782

Reviewed by Sam Weinig.

Encode DrawGlyphs when serializing the drawing item over IPC, with the exception of data in WebCore::Font.
No change in behavior.

  • platform/graphics/GlyphBuffer.h:

Make GlyphBufferAdvance codable.

(WebCore::GlyphBufferAdvance::encode const):
(WebCore::GlyphBufferAdvance::decode):

  • platform/graphics/displaylists/DisplayListItems.cpp:
  • platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawGlyphs::encode const):
(WebCore::DisplayList::DrawGlyphs::decode):
(WebCore::DisplayList::Item::encode const):
(WebCore::DisplayList::Item::decode):

  • platform/text/TextFlags.h:

Add EnumTraits for FontSmoothingMode, so that it is encodable using <<.

4:20 PM Changeset in webkit [254046] by weinig@apple.com
  • 25 edits
    1 add in trunk

Further simplify StringBuilder usage by standardizing hex formating to a single hex() function
​https://bugs.webkit.org/show_bug.cgi?id=205759

Reviewed by Dean Jackson.

Source/JavaScriptCore:

  • heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::json):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::globalFuncEscape):
Replace appendUnsignedAsHex() and appendByteAsHex() with append(hex()).

Source/WebCore:

  • Modules/websockets/WebSocket.cpp:

(WebCore::encodeProtocolString):

  • css/CSSMarkup.cpp:

(WebCore::serializeCharacterAsCodePoint):

  • css/parser/CSSParserToken.cpp:

(WebCore::CSSParserToken::serialize const):

  • platform/graphics/Color.cpp:

(WebCore::Color::serialized const):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::processMpegTsSection):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::generateHashedName):

  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::generateBaseFilename):

  • rendering/RenderTreeAsText.cpp:

(WebCore::quoteAndEscapeNonPrintables):
Replace appendByteAsHex()/appendUnsignedAsHex()/appendUnsignedAsHexFixedSize() with append(hex()).

  • platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::appendFormURLEncoded):
This was the last non-StringBuilder/makeString use of appendByteAsHex. Rather than keep appendByteAsHex
around, it is replaced with direct appends of the character buffer hex() produces.

Source/WebKit:

  • UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::completeDeviceIdHashSaltForOriginCall):

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::loggingString):
Replace appendUnsignedAsHex() with append(hex()).

Source/WTF:

Removes appendByteAsHex, appendUnsignedAsHex and appendUnsignedAsHexFixedSize with the
following mappings:

appendByteAsHex(value, builder, case)

-> builder.append(hex(static_cast<unsigned char>(value), 2, case))

appendUnsignedAsHex(value, builder, case)

-> builder.append(hex(value, case))

appendUnsignedAsHexFixedSize(value, builder, size, case)

-> builder.append(hex(value, size, case))

Adds new API test for HexNumber.cpp

  • wtf/HexNumber.h:

(WTF::appendByteAsHex): Deleted.
(WTF::appendUnsignedAsHex): Deleted.
(WTF::appendUnsignedAsHexFixedSize): Deleted.
Remove now unused helper functions.

  • wtf/FileSystem.cpp:

(WTF::FileSystemImpl::encodeForFileName):
Replace appendByteAsHex with direct use of hex(x, 2). The static_cast is needed
since there was an implicit down cast when appendByteAsHex was used.

  • wtf/Logger.cpp:

(WTF::Logger::LogSiteIdentifier::toString const):
(WTF::>::toString):

  • wtf/UUID.cpp:

(WTF::createCanonicalUUIDString):
Replace appendUnsignedAsHex/appendUnsignedAsHexFixedSize with hex(). Use makeString()
rather StringBuilder to simplify things further.

  • wtf/text/WTFString.cpp:

(asciiDebug):
Replace appendUnsignedAsHexFixedSize with append(hex()).

Tools:

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/HexNumber.cpp: Added.

Add testing for hex formatting of integers.

3:22 PM Changeset in webkit [254045] by commit-queue@webkit.org
  • 4 edits in trunk/Source/ThirdParty/ANGLE

REGRESSION (r253926): Flaky crashes on webgl/1.0.3/conformance/textures/texture-copying-feedback-loops.html and webgl/2.0.0/conformance/textures/misc/texture-copying-feedback-loops.html
​https://bugs.webkit.org/show_bug.cgi?id=205707

Work around bugs in Intel's graphics driver where operations can
be incorrectly reordered across glBindFramebuffer calls by
flushing before/after these calls. Conclusively addresses this
crash; may also address other layout test flakiness seen when
switching to ANGLE backend for WebGL.

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-01-05
Reviewed by Dean Jackson.

  • include/platform/FeaturesGL.h:
  • src/libANGLE/renderer/gl/StateManagerGL.cpp:

(rx::StateManagerGL::bindFramebuffer):

  • src/libANGLE/renderer/gl/renderergl_utils.cpp:

(rx::nativegl_gl::InitializeFeatures):

11:23 AM Changeset in webkit [254044] by Alan Bujtas
  • 397 edits
    1 add in trunk

[SLL] Generate runs for preserved new lines
​https://bugs.webkit.org/show_bug.cgi?id=205762
<rdar://problem/58311927>

Reviewed by Antti Koivisto.

Source/WebCore:

It matches CLL (and IFC) behavior.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createLineRuns):

LayoutTests:

  • platform/mac/css1/basic/containment-expected.txt:
  • platform/mac/css1/basic/contextual_selectors-expected.txt:
  • platform/mac/css1/basic/grouping-expected.txt:
  • platform/mac/css1/basic/id_as_selector-expected.txt:
  • platform/mac/css1/basic/inheritance-expected.txt:
  • platform/mac/css1/box_properties/border-expected.txt:
  • platform/mac/css1/box_properties/border_bottom-expected.txt:
  • platform/mac/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/mac/css1/box_properties/border_bottom_width-expected.txt:
  • platform/mac/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/mac/css1/box_properties/border_color-expected.txt:
  • platform/mac/css1/box_properties/border_color_inline-expected.txt:
  • platform/mac/css1/box_properties/border_inline-expected.txt:
  • platform/mac/css1/box_properties/border_left-expected.txt:
  • platform/mac/css1/box_properties/border_left_inline-expected.txt:
  • platform/mac/css1/box_properties/border_left_width-expected.txt:
  • platform/mac/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/mac/css1/box_properties/border_right-expected.txt:
  • platform/mac/css1/box_properties/border_right_inline-expected.txt:
  • platform/mac/css1/box_properties/border_right_width-expected.txt:
  • platform/mac/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/mac/css1/box_properties/border_style-expected.txt:
  • platform/mac/css1/box_properties/border_style_inline-expected.txt:
  • platform/mac/css1/box_properties/border_top-expected.txt:
  • platform/mac/css1/box_properties/border_top_inline-expected.txt:
  • platform/mac/css1/box_properties/border_top_width-expected.txt:
  • platform/mac/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/mac/css1/box_properties/border_width-expected.txt:
  • platform/mac/css1/box_properties/border_width_inline-expected.txt:
  • platform/mac/css1/box_properties/clear-expected.txt:
  • platform/mac/css1/box_properties/clear_float-expected.txt:
  • platform/mac/css1/box_properties/float-expected.txt:
  • platform/mac/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/mac/css1/box_properties/float_margin-expected.txt:
  • platform/mac/css1/box_properties/height-expected.txt:
  • platform/mac/css1/box_properties/margin-expected.txt:
  • platform/mac/css1/box_properties/margin_bottom-expected.txt:
  • platform/mac/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/mac/css1/box_properties/margin_inline-expected.txt:
  • platform/mac/css1/box_properties/margin_left-expected.txt:
  • platform/mac/css1/box_properties/margin_left_inline-expected.txt:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/box_properties/margin_right_inline-expected.txt:
  • platform/mac/css1/box_properties/margin_top-expected.txt:
  • platform/mac/css1/box_properties/margin_top_inline-expected.txt:
  • platform/mac/css1/box_properties/padding-expected.txt:
  • platform/mac/css1/box_properties/padding_bottom-expected.txt:
  • platform/mac/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/mac/css1/box_properties/padding_inline-expected.txt:
  • platform/mac/css1/box_properties/padding_left-expected.txt:
  • platform/mac/css1/box_properties/padding_left_inline-expected.txt:
  • platform/mac/css1/box_properties/padding_right-expected.txt:
  • platform/mac/css1/box_properties/padding_right_inline-expected.txt:
  • platform/mac/css1/box_properties/padding_top-expected.txt:
  • platform/mac/css1/box_properties/padding_top_inline-expected.txt:
  • platform/mac/css1/box_properties/width-expected.txt:
  • platform/mac/css1/cascade/cascade_order-expected.txt:
  • platform/mac/css1/cascade/important-expected.txt:
  • platform/mac/css1/classification/display-expected.txt:
  • platform/mac/css1/classification/list_style-expected.txt:
  • platform/mac/css1/classification/list_style_image-expected.txt:
  • platform/mac/css1/classification/list_style_position-expected.txt:
  • platform/mac/css1/classification/list_style_type-expected.txt:
  • platform/mac/css1/classification/white_space-expected.txt:
  • platform/mac/css1/color_and_background/background-expected.txt:
  • platform/mac/css1/color_and_background/background_attachment-expected.txt:
  • platform/mac/css1/color_and_background/background_color-expected.txt:
  • platform/mac/css1/color_and_background/background_image-expected.txt:
  • platform/mac/css1/color_and_background/background_position-expected.txt:
  • platform/mac/css1/color_and_background/background_repeat-expected.txt:
  • platform/mac/css1/color_and_background/color-expected.txt:
  • platform/mac/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/mac/css1/font_properties/font-expected.txt:
  • platform/mac/css1/font_properties/font_family-expected.txt:
  • platform/mac/css1/font_properties/font_size-expected.txt:
  • platform/mac/css1/font_properties/font_style-expected.txt:
  • platform/mac/css1/font_properties/font_variant-expected.txt:
  • platform/mac/css1/font_properties/font_weight-expected.txt:
  • platform/mac/css1/formatting_model/canvas-expected.txt:
  • platform/mac/css1/formatting_model/floating_elements-expected.txt:
  • platform/mac/css1/formatting_model/height_of_lines-expected.txt:
  • platform/mac/css1/formatting_model/inline_elements-expected.txt:
  • platform/mac/css1/formatting_model/replaced_elements-expected.txt:
  • platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/mac/css1/pseudo/anchor-expected.txt:
  • platform/mac/css1/pseudo/firstletter-expected.txt:
  • platform/mac/css1/pseudo/firstline-expected.txt:
  • platform/mac/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/mac/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/mac/css1/text_properties/letter_spacing-expected.txt:
  • platform/mac/css1/text_properties/line_height-expected.txt:
  • platform/mac/css1/text_properties/text_align-expected.txt:
  • platform/mac/css1/text_properties/text_decoration-expected.txt:
  • platform/mac/css1/text_properties/text_indent-expected.txt:
  • platform/mac/css1/text_properties/text_transform-expected.txt:
  • platform/mac/css1/text_properties/vertical_align-expected.txt:
  • platform/mac/css1/text_properties/word_spacing-expected.txt:
  • platform/mac/css1/units/color_units-expected.txt:
  • platform/mac/css1/units/length_units-expected.txt:
  • platform/mac/css1/units/percentage_units-expected.txt:
  • platform/mac/css1/units/urls-expected.txt:
  • platform/mac/css2.1/t100801-c548-ln-ht-00-c-a-expected.txt:
  • platform/mac/css2.1/t1606-c562-white-sp-00-b-ag-expected.txt:
  • platform/mac/fast/css/empty-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt:
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/mac/fast/html/listing-expected.txt:
  • platform/mac/fast/invalid/junk-data-expected.txt:
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/mac/fast/text/whitespace/001-expected.txt:
  • platform/mac/fast/text/whitespace/013-expected.txt:
  • platform/mac/fast/text/whitespace/014-expected.txt:
  • platform/mac/fast/text/whitespace/022-expected.txt:
  • platform/mac/fast/text/whitespace/023-expected.txt: Added.
  • platform/mac/fast/text/whitespace/024-expected.txt:
  • platform/mac/fast/text/whitespace/030-expected.txt:
  • platform/mac/fast/text/word-break-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/mac/svg/custom/bug45331-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/use-font-face-crash-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.txt:
  • platform/mac/tables/mozilla/bugs/45621-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug157890-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
11:18 AM Changeset in webkit [254043] by commit-queue@webkit.org
  • 9 edits in trunk

Tighten up stylesheet loading
​https://bugs.webkit.org/show_bug.cgi?id=189913

Patch by Rob Buis <​rbuis@igalia.com> on 2020-01-05
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Update improved test result.

  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-error-events.https-expected.txt:

Source/WebCore:

When fetching and processing a linked resource [1], step 11.3 states
that fetch failure should result in a network error. This patch
implements that for stylesheets.

The behavior matches Chrome and Firefox.

[1] ​https://html.spec.whatwg.org/multipage/semantics.html#default-fetch-and-process-the-linked-resource

Test: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-error-events.https.html

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

  • css/StyleSheetContents.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

LayoutTests:

Adjust test to new behavior.

  • http/tests/security/mixedContent/insecure-stylesheet-redirects-to-basic-auth-secure-stylesheet-expected.txt:
  • http/tests/security/mixedContent/resources/frame-with-insecure-stylesheet-redirects-to-basic-auth-secure-stylesheet.html:
9:58 AM Changeset in webkit [254042] by Simon Fraser
  • 11 edits in trunk

Source/WebCore/PAL:
DumpRenderTree doesn't always call updateRendering() when a test completes
​https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Add -[CATransaction synchronize].

  • pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:
DumpRenderTree doesn't always call updateRendering() when a test completes
​https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Use the QuartzCore SPI header.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

Source/WebKitLegacy/mac:
Fix a souce of WebKit1 test flakiness
​https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Some animation tests (and possibly many others) are flakey or broken in WK1 because
there was no code to guarantee that Page::updateRendering() was called at notifyDone()
time.

WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers,
and flushes a CATransaction.

In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView,
and just called [webView display] to make this happen. However, with layer backing, AppKit behavior
changes, and WebCore changes that make more things happen with HTML event loop timing, this
approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what
WK2 is doing.

  • WebView/WebView.mm:

(-[WebView _forceRepaintForTesting]):

  • WebView/WebViewPrivate.h:

Tools:
DumpRenderTree doesn't always call updateRendering() when a test completes
​https://bugs.webkit.org/show_bug.cgi?id=205761

Reviewed by Darin Adler.

Some animation tests (and possibly many others) are flakey or broken in WK1 because
there was no code to guarantee that Page::updateRendering() was called at notifyDone()
time.

WK2 calls DrawingArea::forceRepaint(), which does updateRendering(), flushes layers,
and flushes a CATransaction.

In WK1, we historically relied in AppKit to call -viewWillDraw on WebView and/or WebHTMLView,
and just called [webView display] to make this happen. However, with layer backing, AppKit behavior
changes, and WebCore changes that make more things happen with HTML event loop timing, this
approach no longer works. The fix is to add WebView SPI, _forceRepaintForTesting, which emulates what
WK2 is doing.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(updateDisplay):

  • DumpRenderTree/mac/PixelDumpSupportMac.mm:
7:13 AM Changeset in webkit [254041] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][Integration] Fix compositing/masks/compositing-clip-path-change-no-repaint.html
​https://bugs.webkit.org/show_bug.cgi?id=205771
<rdar://problem/58319828>

Reviewed by Antti Koivisto.

Add LFC line layout check when deciding whether the current layout path needs
invalidation after style change.

Original patch by Antti.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::styleDidChange):

6:50 AM Changeset in webkit [254040] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][Integration] Fix fast/repaint/simple-line-layout-shrinking-content.html
​https://bugs.webkit.org/show_bug.cgi?id=205773
<rdar://problem/58319960>

Reviewed by Antti Koivisto.

Let's add padding and border to the repaint rect (which is not quite right since at this level reapint rect should
be about the content change, but that's what SLL does and it fixes some repaint issues when
the box with padding/border shrinks).

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutLFCLines):

3:06 AM Changeset in webkit [254039] by youenn@apple.com
  • 10 edits in trunk/Source/WebCore

Make MediaRecorderPrivate use CompletionHandler for retrieving encoded data
​https://bugs.webkit.org/show_bug.cgi?id=205726

Reviewed by Eric Carlson.

Refactoring to allow asynchronous fetching of data.
No change of behavior.

  • Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::createRecordingDataBlob): Deleted.

  • Modules/mediarecorder/MediaRecorder.h:
  • platform/mediarecorder/MediaRecorderPrivate.h:
  • platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:

(WebCore::MediaRecorderPrivateAVFImpl::fetchData):

  • platform/mediarecorder/MediaRecorderPrivateAVFImpl.h:
  • platform/mediarecorder/MediaRecorderPrivateMock.cpp:

(WebCore::MediaRecorderPrivateMock::fetchData):

  • platform/mediarecorder/MediaRecorderPrivateMock.h:
  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
  • platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::fetchData):

12:55 AM Changeset in webkit [254038] by Ross Kirsling
  • 12 edits in trunk

JavaScript: Invalid date parse for ISO 8601 strings when no timezone given
​https://bugs.webkit.org/show_bug.cgi?id=89071

Reviewed by Darin Adler.

Source/JavaScriptCore:

Since ES2016, the specification for Date.parse has included the following statement:

When the UTC offset representation is absent, date-only forms are interpreted as a UTC time
and date-time forms are interpreted as a local time.

This patch updates us from the old ES5 behavior, which treated offsetless date-time forms as UTC.

  • runtime/JSDateMath.cpp:

(JSC::parseDateFromNullTerminatedCharacters):
(JSC::parseES5DateFromNullTerminatedCharacters): Added.
(JSC::parseDate):

  • runtime/JSDateMath.h:

Make a local time adjustment if necessary after calling WTF::parseES5DateFromNullTerminatedCharacters.

Source/WTF:

  • wtf/DateMath.cpp:

(WTF::parseES5TimePortion):
(WTF::parseES5DateFromNullTerminatedCharacters):

  • wtf/DateMath.h:

Add an out param to tell JSC whether we still need to do a local time adjustment.

LayoutTests:

  • js/date-parse-test-expected.txt:
  • js/script-tests/date-parse-test.js:

Update test to match new behavior.

  • storage/indexeddb/modern/resources/date-basic.js:
  • storage/indexeddb/modern/resources/get-keyrange.js:
  • storage/indexeddb/modern/resources/idbobjectstore-delete-1.js:

Fix tests relying on obsolete behavior.

Jan 4, 2020:

9:09 PM Changeset in webkit [254037] by Alexey Shvayka
  • 4 edits in trunk

JSON.parse should initialize wrapper object with DefineOwnProperty?
​https://bugs.webkit.org/show_bug.cgi?id=205767

Reviewed by Darin Adler.

JSTests:

  • test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This patch makes JSON.parse use DefineOwnProperty? instead of Set? to initialize wrapper object,
aligning JSC with the spec (step 7.c of ​https://tc39.es/ecma262/#sec-json.parse) and other engines.
Performing Set? was observable by a setter on Object.prototype (with empty String key).
Also removes two extra exceptions checks.

  • runtime/JSONObject.cpp:

(JSC::Stringifier::stringify):
(JSC::Walker::walk):

2:35 PM Changeset in webkit [254036] by dino@apple.com
  • 13 edits in trunk/Source

Add support for iOS Simulator to ANGLE backend for WebGL
​https://bugs.webkit.org/show_bug.cgi?id=205618

Source/ThirdParty/ANGLE:

Extend EGL_ANGLE_iosurface_client_buffer extension to require use
of TEXTURE_2D target on iOS, and to provide read/write usage hints
for the pbuffer created from the IOSurface.

Emulate missing [EAGLContext texImageIOSurface:...] via texture
upload in eglBindTexImage and readback in eglReleaseTexImage.

These changes will be upstreamed in
​https://bugs.chromium.org/p/angleproject/issues/detail?id=4256 .

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-01-04
Reviewed by Dean Jackson.

  • extensions/EGL_ANGLE_iosurface_client_buffer.txt:
  • include/EGL/eglext_angle.h:
  • src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm:

(rx::DisplayEAGL::initialize):

  • src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.h:
  • src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm:

(rx::IOSurfaceSurfaceEAGL::IOSurfaceSurfaceEAGL):
(rx::IOSurfaceSurfaceEAGL::bindTexImage):
(rx::IOSurfaceSurfaceEAGL::releaseTexImage):
(rx::IOSurfaceSurfaceEAGL::validateAttributes):
(rx::IOSurfaceSurfaceEAGL::createDefaultFramebuffer):
(rx::IOSurfaceSurfaceEAGL::getIOSurfaceLockOptions const):

  • src/libANGLE/validationEGL.cpp:

(egl::ValidateCreatePbufferFromClientBuffer):

Source/WebCore:

Refactor use of EGL_ANGLE_iosurface_client_buffer extension to
uniformly use rectangular textures on macOS, and 2D textures on
iOS, including the simulator. This should make the on-device iOS
code paths more correct as well.

Pass usage hints, only affecting the iOS Simulator, when creating
all pbuffers from IOSurfaces.

This patch does not turn on ANGLE for the iOS Simulator yet; that
will be done in a follow-on patch after more testing.

Covered by the preexisting WebGL conformance suite in the layout
tests.

Patch by Kenneth Russell <​kbr@chromium.org> on 2020-01-04
Reviewed by Dean Jackson.

  • platform/graphics/GraphicsContext3DBase.h:
  • platform/graphics/angle/GraphicsContext3DANGLE.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs):

  • platform/graphics/cocoa/GraphicsContext3DCocoa.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer display]):
(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]):
(-[WebGLLayer bindFramebufferToNextAvailableSurface]):

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::attachIOSurfaceToTexture):
(WebCore::VideoTextureCopierCV::copyImageToPlatformTexture):

2:31 PM Changeset in webkit [254035] by dino@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=205756
<rdar://problem/58309241>

Marking this as Pass Failure.

  • platform/mac/TestExpectations:
11:07 AM Changeset in webkit [254034] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Adopt updated MouseEvent initializer
​https://bugs.webkit.org/show_bug.cgi?id=205765

Patch by Luming Yin <​luming_yin@apple.com> on 2020-01-04
Reviewed by Wenson Hsieh.

Adopt updated MouseEvent initializer to fix the iOS build.

  • dom/ios/MouseEventIOS.cpp:

(WebCore::MouseEvent::create):

  • dom/ios/PointerEventIOS.cpp:

(WebCore::PointerEvent::PointerEvent):

10:23 AM Changeset in webkit [254033] by Keith Rollin
  • 2 edits in trunk/Source/WebKit

Reformat WebPage logging
​https://bugs.webkit.org/show_bug.cgi?id=205705
<rdar://problem/58288704>

Reviewed by Alex Christensen.

Update the format used by WebPage in its RELEASE_LOG logging. Use the
format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x7f83ba009208 - WebPage (webPageID=15) - Adding a reason 1 to freeze layer tree (now 1); old reasons were 0

becomes:

0x7f83ba009208 - [webPageID=15] WebPage::freezeLayerTree: Adding a reason to freeze layer tree (reason=1, new=1, old=0)

No new tests - no added or changed functionality.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_overriddenMediaType):
(WebKit::WebPage::createPlugin):
(WebKit::WebPage::freezeLayerTree):
(WebKit::WebPage::unfreezeLayerTree):
(WebKit::WebPage::markLayersVolatile):
(WebKit::WebPage::cancelMarkLayersVolatile):
(WebKit::WebPage::touchEventSync):

6:54 AM Changeset in webkit [254032] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC][IFC] LineBuilder::ContinuousContent::append should return void
​https://bugs.webkit.org/show_bug.cgi?id=205760
<rdar://problem/58309948>

Reviewed by Antti Koivisto.

Introduce ContinuousContent::isEligible to make merging logic more clear.

  • layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::LineBreaker::isContentWrappingAllowed const):
(WebCore::Layout::LineBreaker::shouldKeepEndOfLineWhitespace const):
(WebCore::Layout::LineBreaker::shouldWrapInlineContent):
(WebCore::Layout::LineBreaker::tryWrappingInlineContent const):
(WebCore::Layout::ContinuousContent::ContinuousContent):
(WebCore::Layout::ContinuousContent::hasTextContentOnly const):
(WebCore::Layout::ContinuousContent::isVisuallyEmptyWhitespaceContentOnly const):
(WebCore::Layout::ContinuousContent::firstTextRunIndex const):
(WebCore::Layout::ContinuousContent::lastContentRunIndex const):
(WebCore::Layout::ContinuousContent::hasNonContentRunsOnly const):
(WebCore::Layout::ContinuousContent::lastWrapOpportunityIndex const):
(WebCore::Layout::ContinuousContent::TrailingCollapsibleContent::reset):
(WebCore::Layout::ContinousContent::runs const): Deleted.
(WebCore::Layout::ContinousContent::isEmpty const): Deleted.
(WebCore::Layout::ContinousContent::size const): Deleted.
(WebCore::Layout::ContinousContent::width const): Deleted.
(WebCore::Layout::ContinousContent::nonCollapsibleWidth const): Deleted.
(WebCore::Layout::ContinousContent::hasTrailingCollapsibleContent const): Deleted.
(WebCore::Layout::ContinousContent::isTrailingContentFullyCollapsible const): Deleted.
(WebCore::Layout::ContinousContent::ContinousContent): Deleted.
(WebCore::Layout::ContinousContent::hasTextContentOnly const): Deleted.
(WebCore::Layout::ContinousContent::isVisuallyEmptyWhitespaceContentOnly const): Deleted.
(WebCore::Layout::ContinousContent::firstTextRunIndex const): Deleted.
(WebCore::Layout::ContinousContent::lastContentRunIndex const): Deleted.
(WebCore::Layout::ContinousContent::hasNonContentRunsOnly const): Deleted.
(WebCore::Layout::ContinousContent::lastWrapOpportunityIndex const): Deleted.
(WebCore::Layout::ContinousContent::TrailingCollapsibleContent::reset): Deleted.

  • layout/inlineformatting/InlineLineBreaker.h:
  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::ContinuousContent::isContinuous):
(WebCore::Layout::LineBuilder::ContinuousContent::canBeExpanded):
(WebCore::Layout::LineBuilder::ContinuousContent::ContinuousContent):
(WebCore::Layout::LineBuilder::ContinuousContent::append):
(WebCore::Layout::LineBuilder::ContinuousContent::close):
(WebCore::Layout::LineBuilder::close):
(WebCore::Layout::LineBuilder::ContinousContent::canBeExpanded): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::canBeMerged const): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::ContinousContent): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::append): Deleted.
(WebCore::Layout::LineBuilder::ContinousContent::close): Deleted.

  • layout/inlineformatting/InlineLineBuilder.h:

Jan 3, 2020:

11:57 PM Changeset in webkit [254031] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

Make text track loading set same-origin fallback flag
​https://bugs.webkit.org/show_bug.cgi?id=205744

Patch by Rob Buis <​rbuis@igalia.com> on 2020-01-03
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Adjust test result to new behavior for text track loading.

  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
  • web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:

Source/WebCore:

Make text track loading set same-origin fallback flag,
which changes text track loading to be same-origin
when the crossorigin attribute is not specified.

The new behavior matches that of Chrome and Firefox.

[1] ​https://html.spec.whatwg.org/multipage/media.html#sourcing-out-of-band-text-tracks:create-a-potential-cors-request

Tests: http/tests/security/text-track-crossorigin.html

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

LayoutTests:

Adjusts test to same-origin fallback behavior for text track
loading by using CORS.

  • http/tests/security/contentSecurityPolicy/resources/track.php: Added.
  • http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
  • http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
  • http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • http/tests/security/text-track-crossorigin.html:
11:28 PM Changeset in webkit [254030] by sihui_liu@apple.com
  • 4 edits in trunk/Source/WebCore

IndexedDB: delete index records with ID and IndexKey instead of value in SQLiteIDBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=205413

Reviewed by Alex Christensen.

Since we have created an index on key in the IndexRecords table, we should do the deletion by its key, because
looking up a record by index column(s) should be faster than non-index column(s).

This change makes PerformanceTests/IndexedDB/basic/index-cursor-delete.html about 100% faster.

No behavior change.

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteOneIndexRecord):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h:
  • Modules/indexeddb/shared/IDBDatabaseInfo.h:

(WebCore::IDBDatabaseInfo::objectStoreMap const):

11:05 PM Changeset in webkit [254029] by Chris Dumez
  • 35 edits
    3 adds in trunk

Add support for DragEvent
​https://bugs.webkit.org/show_bug.cgi?id=205758

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT tests now that more checks are passing.

  • web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
  • web-platform-tests/dom/nodes/Document-createEvent.https-expected.txt:

Source/WebCore:

Add support for DragEvent:

Both Blink and Gecko support it. In WebKit, we had no DragEvent and we had added the
dataTransfer attribute to MouseEvent instead.

No new tests, updated / rebaselined existing tests.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::createEvent):

  • dom/DragEvent.cpp: Added.

(WebCore::DragEvent::create):
(WebCore::DragEvent::createForBindings):
(WebCore::DragEvent::DragEvent):
(WebCore::DragEvent::eventInterface const):

  • dom/DragEvent.h: Added.

(WebCore::DragEvent::dataTransfer const):

  • dom/DragEvent.idl: Added.
  • dom/EventNames.in:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::initMouseEvent):

  • dom/MouseEvent.h:
  • dom/MouseEvent.idl:
  • dom/SimulatedClick.cpp:
  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):

Source/WebKitLegacy/ios:

  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

LayoutTests:

Extend test coverage.

  • editing/pasteboard/can-read-in-dragstart-event-expected.txt:
  • editing/pasteboard/can-read-in-dragstart-event.html:
  • editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave-expected.txt:
  • editing/pasteboard/data-transfer-is-unique-for-dragenter-and-dragleave.html:
  • fast/events/constructors/mouse-event-constructor-expected.txt:
  • fast/events/constructors/mouse-event-constructor.html:
  • fast/events/init-events-expected.txt:
  • fast/events/init-events.html:
  • platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
  • platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
7:01 PM Changeset in webkit [254028] by sihui_liu@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in com.apple.WebKit.Networking at UniqueIDBDatabase::performCurrentOpenOperation
​https://bugs.webkit.org/show_bug.cgi?id=205742

Reviewed by Maciej Stachowiak.

m_databaseInfo may not be set in performCurrentOpenOperation if there is an error in opening backing store, so
we should make an early return to avoid access to m_databaseInfo in this case.

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):

6:44 PM Changeset in webkit [254027] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

IconLoadingClient::getLoadDecisionForIcon() leaks an Objective-C block
​https://bugs.webkit.org/show_bug.cgi?id=205750
<rdar://problem/57981723>

Patch by Garrett Davidson <​garrett_davidson@apple.com> on 2020-01-03
Reviewed by Wenson Hsieh.

Replace a Block_copy with makeBlockPtr to prevent leaking the ObjC block.

  • UIProcess/Cocoa/IconLoadingDelegate.mm:

(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):

6:15 PM Changeset in webkit [254026] by stephan.szabo@sony.com
  • 4 edits in trunk/Source/WebCore

[WinCairo] Fixing build after "Add a pure virtual base class for GraphicsContext3D"
​https://bugs.webkit.org/show_bug.cgi?id=205743

Reviewed by Don Olmstead.

No new tests, build fix.

  • platform/graphics/GraphicsContext3DBase.h: Undefine NO_ERROR on win
  • platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:

Move functions showing up as undefined out of #ifdef block

  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:

Fix some accesses to m_attrs to use contextAttributes()

5:58 PM Changeset in webkit [254025] by timothy_horton@apple.com
  • 9 edits in trunk/Source/WebKit

Crashes under -[WKWebView _addUpdateVisibleContentRectPreCommitHandler]_block_invoke
​https://bugs.webkit.org/show_bug.cgi?id=205749
<rdar://problem/56433624>

Reviewed by Simon Fraser.

Implement a speculative fix for a common crash. We believe that this is due to
a mechanism UIKit uses to bounce -dealloc (in our case, of WKWebView and/or WKContentView)
to the main thread when the last reference is dropped on a background thread.
At that point, deallocation has already begun, -retain cannot revive the object,
but -dealloc has not yet been called (because of the nature of this mechanism).

To avoid this, make PageClientImpl -> WKContentView and WKContentView -> WKWebView
weak instead of raw references. This way, we won't even get to _addUpdateVisibleContentRectPreCommitHandler
with a deallocating WKWebView, nor try (and fail) to retain it for later use in the block.

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::viewSize):
(WebKit::PageClientImpl::didPerformDictionaryLookup):
(WebKit::PageClientImpl::createValidationBubble):
(WebKit::PageClientImpl::createDataListSuggestionsDropdown):
(WebKit::PageClientImpl::createDrawingView):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView _commonInitializationWithProcessPool:configuration:]):
(-[WKContentView webView]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:contentInsets:unobscuredRectInScrollViewCoordinates:obscuredInsets:unobscuredSafeAreaInsets:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
(-[WKContentView _didCommitLayerTree:]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _updateLongPressAndHighlightLongPressGestures]):
(-[WKContentView endEditingAndUpdateFocusAppearanceWithReason:]):
(-[WKContentView gestureRecognizerMayPinchToZoomWebView:]):
(-[WKContentView _showAttachmentSheet]):
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView hasSelectablePositionAtPoint:]):
(-[WKContentView pointIsNearMarkedText:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView _stylusSingleTapRecognized:]):
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
(-[WKContentView _updateInteractionTintColor]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView accessibilityRetrieveSpeakSelectionContent]):
(-[WKContentView requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]):
(-[WKContentView accessoryAutoFill]):
(-[WKContentView _updateAccessory]):
(-[WKContentView _didChangeWebViewEditability]):
(-[WKContentView insertTextSuggestion:]):
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
(-[WKContentView keyboardScrollViewAnimator:distanceForIncrement:inDirection:]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:activityStateChanges:userObject:]):
(-[WKContentView addFocusedFormControlOverlay]):
(-[WKContentView presentViewControllerForCurrentFocusedElement]):
(-[WKContentView dismissAllInputViewControllers:]):
(-[WKContentView _showShareSheet:inRect:completionHandler:]):
(-[WKContentView actionSheetAssistant:shareElementWithURL:rect:]):
(-[WKContentView actionSheetAssistant:showCustomSheetForElement:]):
(-[WKContentView dataDetectionContextForPositionInformation:]):
(-[WKContentView actionSheetAssistant:getAlternateURLForImage:completion:]):
(-[WKContentView _didChangeDragInteractionPolicy]):
(-[WKContentView dragLiftDelay]):
(-[WKContentView setupDragAndDropInteractions]):
(-[WKContentView _didPerformDragOperation:]):
(-[WKContentView _dragDestinationActionForDropSession:]):
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationLists:stagedDragSource:]):
(-[WKContentView _handleDropByInsertingImagePlaceholders:session:]):
(-[WKContentView _dragInteraction:dataOwnerForSession:]):
(-[WKContentView dragInteraction:previewForLiftingItem:session:]):
(-[WKContentView dragInteraction:sessionWillBegin:]):
(-[WKContentView dragInteraction:session:didEndWithOperation:]):
(-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
(-[WKContentView _dropInteraction:dataOwnerForSession:]):
(-[WKContentView dropInteraction:sessionDidUpdate:]):
(-[WKContentView dropInteraction:performDrop:]):
(-[WKContentView dismissQuickboardViewControllerAndRevealFocusedFormOverlayIfNecessary:]):
(-[WKContentView viewController:inputContextViewHeightForSize:]):
(-[WKContentView inputContextViewForViewController:]):
(-[WKContentView _registerPreview]):
(-[WKContentView assignLegacyDataForContextMenuInteraction]):
(-[WKContentView _contextMenuInteraction:configurationForMenuAtLocation:completion:]):
(-[WKContentView continueContextMenuInteraction:]):
(-[WKContentView _createTargetedPreviewIfPossible]):
(-[WKContentView contextMenuInteraction:willDisplayMenuForConfiguration:animator:]):
(-[WKContentView contextMenuInteraction:willPerformPreviewActionForMenuWithConfiguration:animator:]):
(-[WKContentView contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):
(-[WKContentView _presentedViewControllerForPreviewItemController:]):
(-[WKContentView _previewItemController:commitPreview:]):
(-[WKContentView _previewItemController:didDismissPreview:committing:]):

5:03 PM Changeset in webkit [254024] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

REGRESSION: 150+ flaky failures on some bots (color mismatches)
​https://bugs.webkit.org/show_bug.cgi?id=205755
<rdar://problem/58248136>

Reviewed by Simon Fraser.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(colorProfileURLForDisplay):
(displayUUIDStrings):
Use CGGetOnlineDisplayList instead of CGGetActiveDisplayList; we want
all attached displays, even if they are sleeping.

4:34 PM Changeset in webkit [254023] by ysuzuki@apple.com
  • 15 edits in trunk/Source/JavaScriptCore

[JSC] MarkedBlock::Handle and BlockDirectory should be shrunk
​https://bugs.webkit.org/show_bug.cgi?id=205712

Reviewed by Mark Lam.

This patch shrinks MarkedBlock::Handle and BlockDirectory by leveraging the fact that Vector's size and capacity is unsigned.
In these data structures, we use size_t to hold a index, but this can be converted to unsigned since we guarantee that this
never exceeds unsigned since these numbers are derived from Vector's size / capacity, or index inside MarkedBlock (which is up
to 64KB in some architectures). MarkedBlock::Handle is allocated per MarkedBlock, and in Gmail, it takes 1MB. We can save
some bytes just using unsigned. In addition, this patch removes m_prev and m_next fields in MarkedBlock::Handle since
it is never used.

  • heap/AtomIndices.h:
  • heap/BlockDirectory.cpp:

(JSC::BlockDirectory::findBlockForAllocation):
(JSC::BlockDirectory::addBlock):

  • heap/IsoCellSet.cpp:

(JSC::IsoCellSet::addSlow):
(JSC::IsoCellSet::didResizeBits):
(JSC::IsoCellSet::didRemoveBlock):

  • heap/IsoCellSet.h:
  • heap/IsoCellSetInlines.h:

(JSC::IsoCellSet::forEachMarkedCell):
(JSC::IsoCellSet::forEachMarkedCellInParallel):
(JSC::IsoCellSet::forEachLiveCell):

  • heap/IsoSubspace.cpp:

(JSC::IsoSubspace::didResizeBits):
(JSC::IsoSubspace::didRemoveBlock):

  • heap/IsoSubspace.h:
  • heap/LocalAllocator.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::didAddToDirectory):
(JSC::MarkedBlock::Handle::didRemoveFromDirectory):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::index const):

  • heap/Subspace.cpp:

(JSC::Subspace::didResizeBits):
(JSC::Subspace::didRemoveBlock):

  • heap/Subspace.h:
4:29 PM Changeset in webkit [254022] by Chris Dumez
  • 7 edits in trunk

dom/nodes/Document-createElement-namespace.html WPT test is failing
​https://bugs.webkit.org/show_bug.cgi?id=205748

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test that is now passing.

  • web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:

Source/WebCore:

dom/nodes/Document-createElement-namespace.html WPT test was failing in WebKit but passing in Blink
and Gecko. The issue was that the MIME type passed to DOMParser.parseFromString() would always be
resolved to "application/xml", no matter which XML MIME type was provided as input (e.g. "text/xml").

No new tests, rebaselined existing test.

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

LayoutTests:

Unskip test as it does not appear to be flaky locally.

4:28 PM Changeset in webkit [254021] by Chris Dumez
  • 4 edits in trunk

Document.createAttribute() should take in a localName, not a qualifiedName
​https://bugs.webkit.org/show_bug.cgi?id=205752

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing. This test was failing in WebKit but passing
in Blink & Gecko.

  • web-platform-tests/dom/nodes/Document-createAttribute-expected.txt:

Source/WebCore:

Document.createAttribute() should take in a localName, not a qualifiedName:

Our behavior does not match the DOM specification or other browser engines.

No new tests, rebaselined existing test.

  • dom/Document.cpp:

(WebCore::Document::createAttribute):

4:13 PM Changeset in webkit [254020] by Truitt Savell
  • 2 edits in trunk/LayoutTests

REGRESSION: [ Mac ] webgl/1.0.3/conformance/textures/texture-upload-size.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=205757

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:25 PM Changeset in webkit [254019] by commit-queue@webkit.org
  • 11 edits in trunk

Update the RemoteMediaPlayerManagerProxy::Load XPC message to provide the updated RemoteMediaPlayerConfiguration to the web process
​https://bugs.webkit.org/show_bug.cgi?id=205740

Patch by Peng Liu <Peng Liu> on 2020-01-03
Reviewed by Eric Carlson.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/MediaPlayer.cpp:

Source/WebKit:

  • GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::load):

  • GPUProcess/media/RemoteMediaPlayerManagerProxy.h:
  • GPUProcess/media/RemoteMediaPlayerManagerProxy.messages.in:
  • GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::load):

  • GPUProcess/media/RemoteMediaPlayerProxy.h:
  • WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote::load):

LayoutTests:

  • gpu-process/TestExpectations:
3:22 PM Changeset in webkit [254018] by Chris Dumez
  • 4 edits in trunk

Align Range.intersectsNode() with the DOM specification
​https://bugs.webkit.org/show_bug.cgi?id=205745

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline WPT test now that it is passing.

  • web-platform-tests/dom/ranges/Range-intersectsNode-2-expected.txt:

Source/WebCore:

Align Range.intersectsNode() with the DOM specification:

This also aligns our behavior with Chrome 79 and Firefox 71.

No new tests, rebaselined existing test.

  • dom/Range.cpp:

(WebCore::Range::intersectsNode const):

3:21 PM Changeset in webkit [254017] by keith_miller@apple.com
  • 242 edits
    209 adds in trunk

Update test262 tests to commit 157b18d
​https://bugs.webkit.org/show_bug.cgi?id=205741

Reviewed by Yusuke Suzuki.

JSTests:

  • test262/expectations.yaml:
  • test262/harness/deepEqual.js:

(assert.deepEqual):
(assert.deepEqual.format):
(deepEqual):
(compareEquality):
(compareIf):
(tryCompareStrictEquality):
(tryCompareTypeOfEquality):
(tryCompareToStringTagEquality):
(isOptional):
(compareOptionality):
(isPrimitiveEquatable):
(comparePrimitiveEquality):
(isNaNEquatable):
(compareNaNEquality):
(isObjectEquatable):
(compareObjectEquality):
(isBoxed):
(isValueOfEquatable):
(compareValueOfEquality):
(isToStringEquatable):
(compareToStringEquality):
(isArrayLikeEquatable):
(isStructurallyEquatable):
(isIterableEquatable):
(compareIteratorEquality):
(compareIterableEquality):
(cacheComparison):
(fail):
(setCache):
(getCache):
(assert.deepEqual._compare):

  • test262/latest-changes-summary.txt:
  • test262/test/built-ins/AggregateError: Added.
  • test262/test/built-ins/AggregateError/errors-iterabletolist-failures.js: Added.

(case1.get Symbol):
(case2.get Symbol):
(case3.Symbol.iterator):
(case4.Symbol.iterator):
(case5.Symbol.iterator):
(case6.Symbol.iterator.return.get next):
(case6.Symbol.iterator):
(case7.Symbol.iterator.return.get next):
(case7.Symbol.iterator):
(case8.Symbol.iterator):
(case9.Symbol.iterator):
(case10.Symbol.iterator):
(case11.Symbol.iterator.return.next.return.get done):
(case11.Symbol.iterator):

  • test262/test/built-ins/AggregateError/errors-iterabletolist.js: Added.

(case1.Symbol.iterator.return.next.return.get value):
(case1.Symbol.iterator):

  • test262/test/built-ins/AggregateError/length.js: Added.
  • test262/test/built-ins/AggregateError/message-method-prop-cast.js: Added.

(toString):

  • test262/test/built-ins/AggregateError/message-method-prop.js: Added.
  • test262/test/built-ins/AggregateError/message-tostring-abrupt-symbol.js: Added.

(case2.Symbol.toPrimitive):
(case2.toString):
(case2.valueOf):

  • test262/test/built-ins/AggregateError/message-tostring-abrupt.js: Added.

(case1.Symbol.toPrimitive):
(case1.toString):
(case1.valueOf):
(case2.toString):
(case2.valueOf):
(case3.valueOf):

  • test262/test/built-ins/AggregateError/message-undefined-no-prop.js: Added.
  • test262/test/built-ins/AggregateError/name.js: Added.
  • test262/test/built-ins/AggregateError/newtarget-proto-custom.js: Added.

(newt.new.Proxy):
(newt.new.Proxy.get if):

  • test262/test/built-ins/AggregateError/newtarget-proto-fallback.js: Added.

(ctor):
(const.value.of.values.get t):

  • test262/test/built-ins/AggregateError/newtarget-proto.js: Added.
  • test262/test/built-ins/AggregateError/prop-desc.js: Added.
  • test262/test/built-ins/AggregateError/proto.js: Added.
  • test262/test/built-ins/AggregateError/prototype: Added.
  • test262/test/built-ins/AggregateError/prototype/constructor.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/invoked-as-accessor.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/invoked-as-func.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/length.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/name.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/prop-desc.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/return-from-iterable-errors.js: Added.

(errors.Symbol.iterator.return.next.return.get value):
(errors.Symbol.iterator):

  • test262/test/built-ins/AggregateError/prototype/errors/return-new-array-from-list.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/this-has-no-typedarrayname-internal.js: Added.
  • test262/test/built-ins/AggregateError/prototype/errors/this-is-not-object.js: Added.
  • test262/test/built-ins/AggregateError/prototype/message.js: Added.
  • test262/test/built-ins/AggregateError/prototype/name.js: Added.
  • test262/test/built-ins/AggregateError/prototype/prop-desc.js: Added.
  • test262/test/built-ins/AggregateError/prototype/proto.js: Added.
  • test262/test/built-ins/Array/prototype/copyWithin/coerced-values-start-change-start.js: Added.

(longDenseArray):
(shorten):

  • test262/test/built-ins/Array/prototype/copyWithin/coerced-values-start-change-target.js: Added.

(longDenseArray):
(shorten):

  • test262/test/built-ins/Array/prototype/flatMap/this-value-ctor-object-species-bad-throws.js:
  • test262/test/built-ins/Atomics/add/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Atomics/and/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Atomics/compareExchange/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Atomics/exchange/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Atomics/or/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Atomics/store/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Atomics/sub/bigint/nonshared-int-views.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/Error/prototype/toString/invalid-receiver.js: Added.

(Symbol.forEach):

  • test262/test/built-ins/Error/prototype/toString/undefined-props.js: Added.
  • test262/test/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-prevented-with-unregister.js:

(emptyCells):
(emptyCells.then):

  • test262/test/built-ins/FinalizationGroup/prototype/cleanupSome/cleanup-throws-in-callback.js: Added.

(fg.new.FinalizationGroup):
(callback):
(emptyCells):
(emptyCells.then):

  • test262/test/built-ins/FinalizationGroup/prototype/register/holdings-same-as-target.js:
  • test262/test/built-ins/FinalizationGroup/prototype/register/return-undefined-register-itself.js:
  • test262/test/built-ins/FinalizationGroup/prototype/register/unregisterToken-same-as-holdings-and-target.js:
  • test262/test/built-ins/FinalizationGroup/prototype/unregister/unregister-cleaned-up-cell.js: Added.

(fg.new.FinalizationGroup):
(emptyCells):
(emptyCells.then):

  • test262/test/built-ins/FinalizationGroup/target-not-callable-throws.js:
  • test262/test/built-ins/JSON/parse/reviver-array-get-prop-from-prototype.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-array-non-configurable-prop-create.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-array-non-configurable-prop-delete.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-call-order.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-object-get-prop-from-prototype.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-object-non-configurable-prop-create.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-object-non-configurable-prop-delete.js: Added.
  • test262/test/built-ins/JSON/parse/reviver-wrapper.js: Added.
  • test262/test/built-ins/JSON/stringify/property-order.js: Added.
  • test262/test/built-ins/Object/entries/return-order.js: Added.
  • test262/test/built-ins/Object/freeze/throws-when-false.js: Added.

(preventExtensions):

  • test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-absent-not-configurable-symbol-key.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-duplicate-symbol-entry.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-absent-symbol-key.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertyNames/proxy-invariant-not-extensible-extra-symbol-key.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertySymbols/length.js:
  • test262/test/built-ins/Object/getOwnPropertySymbols/name.js:
  • test262/test/built-ins/Object/getOwnPropertySymbols/object-contains-symbol-property-with-description.js:
  • test262/test/built-ins/Object/getOwnPropertySymbols/object-contains-symbol-property-without-description.js:
  • test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-absent-not-configurable-string-key.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-duplicate-string-entry.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-absent-string-key.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/getOwnPropertySymbols/proxy-invariant-not-extensible-extra-string-key.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-2.js:
  • test262/test/built-ins/Object/keys/proxy-non-enumerable-prop-invariant-3.js: Added.

(ownKeys):

  • test262/test/built-ins/Object/keys/return-order.js: Added.
  • test262/test/built-ins/Object/preventExtensions/throws-when-false.js: Added.

(preventExtensions):

  • test262/test/built-ins/Object/prototype/isPrototypeOf/arg-is-proxy.js: Added.

(handler.allowProxyTraps.getPrototypeOf):

  • test262/test/built-ins/Object/prototype/isPrototypeOf/builtin.js: Added.
  • test262/test/built-ins/Object/prototype/isPrototypeOf/length.js: Added.
  • test262/test/built-ins/Object/prototype/isPrototypeOf/name.js:
  • test262/test/built-ins/Object/prototype/isPrototypeOf/null-this-and-object-arg-throws.js: Added.
  • test262/test/built-ins/Object/prototype/isPrototypeOf/null-this-and-primitive-arg-returns-false.js: Added.
  • test262/test/built-ins/Object/prototype/isPrototypeOf/this-value-is-in-prototype-chain-of-arg.js: Added.

(USER_FACTORY.this.getName):
(USER_FACTORY):
(this.getGrade):
(FORCEDUSER_FACTORY):

  • test262/test/built-ins/Object/prototype/isPrototypeOf/undefined-this-and-object-arg-throws.js: Added.
  • test262/test/built-ins/Object/prototype/isPrototypeOf/undefined-this-and-primitive-arg-returns-false.js: Added.
  • test262/test/built-ins/Object/seal/throws-when-false.js: Added.

(preventExtensions):

  • test262/test/built-ins/Object/values/return-order.js: Added.
  • test262/test/built-ins/Proxy/has/call-in-prototype-index.js: Added.

(handler.allowProxyTraps.has):

  • test262/test/built-ins/Proxy/has/call-in-prototype.js:
  • test262/test/built-ins/Proxy/ownKeys/call-parameters-object-keys.js:

(handler.ownKeys):

  • test262/test/built-ins/Proxy/set/call-parameters-prototype-index.js: Added.
  • test262/test/built-ins/Reflect/preventExtensions/target-is-not-object-throws.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-element.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-matched.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-non-unicode-match.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-properties.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-unicode-match.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-unicode-property-names.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array-unmatched.js:
  • test262/test/built-ins/RegExp/match-indices/indices-array.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-object-unmatched.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-object.js:
  • test262/test/built-ins/RegExp/match-indices/indices-groups-properties.js:
  • test262/test/built-ins/RegExp/match-indices/indices-property.js:
  • test262/test/built-ins/String/prototype/replaceAll: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0024.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0026.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0027.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x003C.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024-0x0060.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024N.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/getSubstitution-0x0024NN.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/length.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/name.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/replaceAll.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-abrupt.js: Added.

(custom):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-each-match-position.js: Added.

(t):
(replaceValue):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-matching-empty.js: Added.

(t):
(replaceValue):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-skip-no-match.js: Added.

(replaceValue):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-call-tostring-abrupt.js: Added.

(custom):
(symbol):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-fn-skip-toString.js: Added.

(replaceValue):
(value):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-tostring-abrupt.js: Added.

(thisValue.toString):
(searchValue.toString):
(replaceValue.toString):

  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-value-replaces-string.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/replaceValue-value-tostring.js: Added.

(replaceValue.Symbol.toPrimitive):
(replaceValue.toString):
(replaceValue.valueOf):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-empty-string-this-empty-string.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/searchValue-empty-string.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/searchValue-flags-no-g-throws.js: Added.

(poison.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-flags-null-undefined-throws.js: Added.

(poison.toString):
(searchValue.get flags):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-flags-toString-abrupt.js: Added.

(poison.toString):
(searchValue.toString):
(searchValue.flags.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-get-flags-abrupt.js: Added.

(searchValue.get flags):
(poison.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-isRegExp-abrupt.js: Added.

(searchValue.get Symbol):
(searchValue.toString):
(poison.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-replace-method-abrupt.js: Added.

(poison.toString):
(searchValue.get Symbol):
(searchValue.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-RegExp-call-fn.js: Added.

(RE.prototype.Symbol.replace):
(RE.prototype.toString):
(RE):
(const.t):
(getFn.return.replaceValueFn):
(getFn):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-RegExp-call.js: Added.

(RE.prototype.Symbol.replace):
(RE.prototype.toString):
(RE):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-before-tostring.js: Added.

(value):
(poison.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-call-abrupt.js: Added.

(poison.toString):
(searchValue.Symbol.replace):
(searchValue.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-replacer-call.js: Added.

(value):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-tostring-abrupt.js: Added.

(poison.toString):
(thisValue.toString):
(searchValue.toString):

  • test262/test/built-ins/String/prototype/replaceAll/searchValue-tostring-regexp.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/this-is-null-throws.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/this-is-undefined-throws.js: Added.
  • test262/test/built-ins/String/prototype/replaceAll/this-tostring-abrupt.js: Added.

(poison.toString):
(thisValue.toString):
(searchValue.toString):

  • test262/test/built-ins/String/prototype/replaceAll/this-tostring.js: Added.

(thisValue.Symbol.toPrimitive):
(thisValue.toString):
(thisValue.valueOf):

  • test262/test/built-ins/TypedArray/from/mapfn-is-not-callable.js:
  • test262/test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-get-species-custom-ctor-length-throws.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/TypedArray/prototype/slice/BigInt/speciesctor-get-species-custom-ctor-length.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/TypedArray/prototype/slice/speciesctor-get-species-custom-ctor-length-throws.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/TypedArray/prototype/slice/speciesctor-get-species-custom-ctor-length.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/TypedArrayConstructors/from/nan-conversion.js:
  • test262/test/built-ins/TypedArrayConstructors/from/new-instance-from-zero.js:
  • test262/test/built-ins/TypedArrayConstructors/of/BigInt/inherited.js:

(testWithBigIntTypedArrayConstructors):

  • test262/test/built-ins/TypedArrayConstructors/of/inherited.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/WeakRef/prototype-from-newtarget-abrupt.js:
  • test262/test/harness/deepEqual-array.js:
  • test262/test/harness/deepEqual-circular.js:
  • test262/test/harness/deepEqual-deep.js:
  • test262/test/harness/deepEqual-mapset.js:
  • test262/test/harness/deepEqual-object.js:
  • test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-dateStyle.js: Added.
  • test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-default.js: Added.

(locales.forEach):

  • test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle-timeStyle.js: Added.
  • test262/test/intl402/DateTimeFormat/prototype/resolvedOptions/hourCycle.js:
  • test262/test/intl402/DisplayNames: Added.
  • test262/test/intl402/DisplayNames/ctor-custom-get-prototype-poison-throws.js: Added.

(custom.new.Proxy.new.Function.get if):
(custom.new.Proxy.new.Function):

  • test262/test/intl402/DisplayNames/ctor-custom-prototype.js: Added.
  • test262/test/intl402/DisplayNames/ctor-default-prototype.js: Added.
  • test262/test/intl402/DisplayNames/instance-extensible.js: Added.
  • test262/test/intl402/DisplayNames/length.js: Added.
  • test262/test/intl402/DisplayNames/locales-invalid-throws.js: Added.
  • test262/test/intl402/DisplayNames/locales-length-poison-throws.js: Added.
  • test262/test/intl402/DisplayNames/locales-length-tolength-throws.js: Added.

(locales.length.valueOf):
(locales.length.Symbol.toPrimitive):
(locales.length.toString):

  • test262/test/intl402/DisplayNames/locales-symbol-length.js: Added.
  • test262/test/intl402/DisplayNames/name.js: Added.
  • test262/test/intl402/DisplayNames/options-fallback-abrupt-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-fallback-invalid-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-fallback-toString-abrupt-throws.js: Added.

(options.fallback.toString):
(options.fallback.valueOf):
(options.fallback.Symbol.toPrimitive):

  • test262/test/intl402/DisplayNames/options-fallback-valid.js: Added.
  • test262/test/intl402/DisplayNames/options-localeMatcher-abrupt-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-localeMatcher-invalid-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-localeMatcher-toString-abrupt-throws.js: Added.

(options.localeMatcher.toString):
(options.localeMatcher.valueOf):
(options.localeMatcher.Symbol.toPrimitive):

  • test262/test/intl402/DisplayNames/options-localeMatcher-valid.js: Added.
  • test262/test/intl402/DisplayNames/options-null-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-random-properties-unchecked.js: Added.
  • test262/test/intl402/DisplayNames/options-style-abrupt-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-style-invalid-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-style-toString-abrupt-throws.js: Added.

(options.style.toString):
(options.style.valueOf):
(options.style.Symbol.toPrimitive):

  • test262/test/intl402/DisplayNames/options-style-valid.js: Added.
  • test262/test/intl402/DisplayNames/options-type-abrupt-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-type-invalid-throws.js: Added.
  • test262/test/intl402/DisplayNames/options-type-toString-abrupt-throws.js: Added.

(options.type.toString):
(options.type.valueOf):
(options.type.Symbol.toPrimitive):

  • test262/test/intl402/DisplayNames/options-type-valid.js: Added.
  • test262/test/intl402/DisplayNames/prop-desc.js: Added.
  • test262/test/intl402/DisplayNames/proto-from-ctor-realm.js: Added.
  • test262/test/intl402/DisplayNames/proto.js: Added.
  • test262/test/intl402/DisplayNames/prototype: Added.
  • test262/test/intl402/DisplayNames/prototype/Symbol.toStringTag.js: Added.
  • test262/test/intl402/DisplayNames/prototype/prop-desc.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/default-option-values.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/length.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/name.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/option-fallback.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/option-style.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/option-type.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/prop-desc.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/return-object.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/this-not-object-throws.js: Added.
  • test262/test/intl402/DisplayNames/prototype/resolvedOptions/this-object-lacks-internal-throws.js: Added.
  • test262/test/intl402/DisplayNames/undefined-newtarget-throws.js: Added.
  • test262/test/language/destructuring/binding/syntax/property-list-single-name-bindings.js:
  • test262/test/language/expressions/addition/bigint-and-number.js:
  • test262/test/language/expressions/addition/bigint-arithmetic.js:
  • test262/test/language/expressions/addition/bigint-errors.js:
  • test262/test/language/expressions/addition/bigint-toprimitive.js:
  • test262/test/language/expressions/addition/bigint-wrapped-values.js:
  • test262/test/language/expressions/arrow-function/eval-var-scope-syntax-err.js: Added.

(f.a.eval):

  • test262/test/language/expressions/arrow-function/scope-param-elem-var-close.js:
  • test262/test/language/expressions/arrow-function/scope-param-elem-var-open.js:
  • test262/test/language/expressions/arrow-function/scope-param-rest-elem-var-close.js:
  • test262/test/language/expressions/arrow-function/scope-param-rest-elem-var-open.js:
  • test262/test/language/expressions/async-arrow-function/eval-var-scope-syntax-err.js: Added.

(f.async a):
(SyntaxError.then):

  • test262/test/language/expressions/async-function/named-eval-var-scope-syntax-err.js: Added.

(f.async f):
(f):

  • test262/test/language/expressions/async-function/nameless-eval-var-scope-syntax-err.js: Added.
  • test262/test/language/expressions/async-generator/eval-var-scope-syntax-err.js: Added.
  • test262/test/language/expressions/async-generator/named-eval-var-scope-syntax-err.js: Added.

(f.async g):
(f):

  • test262/test/language/expressions/bitwise-and/bigint-and-number.js:
  • test262/test/language/expressions/bitwise-and/bigint-errors.js:
  • test262/test/language/expressions/bitwise-and/bigint-non-primitive.js:
  • test262/test/language/expressions/bitwise-and/bigint-toprimitive.js:
  • test262/test/language/expressions/bitwise-and/bigint-wrapped-values.js:
  • test262/test/language/expressions/bitwise-not/bigint-non-primitive.js:
  • test262/test/language/expressions/bitwise-or/bigint-and-number.js:
  • test262/test/language/expressions/bitwise-or/bigint-errors.js:
  • test262/test/language/expressions/bitwise-or/bigint-non-primitive.js:
  • test262/test/language/expressions/bitwise-or/bigint-toprimitive.js:
  • test262/test/language/expressions/bitwise-or/bigint-wrapped-values.js:
  • test262/test/language/expressions/bitwise-xor/bigint-and-number.js:
  • test262/test/language/expressions/bitwise-xor/bigint-errors.js:
  • test262/test/language/expressions/bitwise-xor/bigint-non-primitive.js:
  • test262/test/language/expressions/bitwise-xor/bigint-toprimitive.js:
  • test262/test/language/expressions/bitwise-xor/bigint-wrapped-values.js:
  • test262/test/language/expressions/class/async-gen-method-static/eval-var-scope-syntax-err.js: Added.

(C):

  • test262/test/language/expressions/class/async-gen-method/eval-var-scope-syntax-err.js: Added.

(C):

  • test262/test/language/expressions/class/async-method-static/eval-var-scope-syntax-err.js: Added.

(C):
(then):

  • test262/test/language/expressions/class/async-method/eval-var-scope-syntax-err.js: Added.

(C):
(SyntaxError.then):

  • test262/test/language/expressions/class/elements/syntax/early-errors/grammar-private-field-optional-chaining.js: Added.

(C.prototype.access):

  • test262/test/language/expressions/class/gen-method-static/eval-var-scope-syntax-err.js: Added.

(C):

  • test262/test/language/expressions/class/gen-method/eval-var-scope-syntax-err.js: Added.

(C):

  • test262/test/language/expressions/class/method-static/eval-var-scope-syntax-err.js: Added.

(C):

  • test262/test/language/expressions/class/method/eval-var-scope-syntax-err.js: Added.

(C):

  • test262/test/language/expressions/coalesce/cannot-chain-head-with-logical-and.js:
  • test262/test/language/expressions/coalesce/cannot-chain-head-with-logical-or.js:
  • test262/test/language/expressions/coalesce/cannot-chain-tail-with-logical-and.js:
  • test262/test/language/expressions/coalesce/cannot-chain-tail-with-logical-or.js:
  • test262/test/language/expressions/delete/super-property.js:

(C):

  • test262/test/language/expressions/division/bigint-and-number.js:
  • test262/test/language/expressions/division/bigint-arithmetic.js:
  • test262/test/language/expressions/division/bigint-complex-infinity.js:
  • test262/test/language/expressions/division/bigint-errors.js:
  • test262/test/language/expressions/division/bigint-toprimitive.js:
  • test262/test/language/expressions/division/bigint-wrapped-values.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-bigint.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-boolean.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-incomparable-primitive.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-non-finite.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-number-extremes.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-number.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-object.js:
  • test262/test/language/expressions/does-not-equals/bigint-and-string.js:
  • test262/test/language/expressions/equals/bigint-and-bigint.js:
  • test262/test/language/expressions/equals/bigint-and-boolean.js:
  • test262/test/language/expressions/equals/bigint-and-incomparable-primitive.js:
  • test262/test/language/expressions/equals/bigint-and-non-finite.js:
  • test262/test/language/expressions/equals/bigint-and-number-extremes.js:
  • test262/test/language/expressions/equals/bigint-and-number.js:
  • test262/test/language/expressions/equals/bigint-and-object.js:
  • test262/test/language/expressions/equals/bigint-and-string.js:
  • test262/test/language/expressions/exponentiation/bigint-and-number.js:
  • test262/test/language/expressions/exponentiation/bigint-arithmetic.js:
  • test262/test/language/expressions/exponentiation/bigint-errors.js:
  • test262/test/language/expressions/exponentiation/bigint-negative-exponent-throws.js:
  • test262/test/language/expressions/exponentiation/bigint-toprimitive.js:
  • test262/test/language/expressions/exponentiation/bigint-wrapped-values.js:
  • test262/test/language/expressions/exponentiation/bigint-zero-base-zero-exponent.js:
  • test262/test/language/expressions/function/eval-var-scope-syntax-err.js: Added.

(f):

  • test262/test/language/expressions/function/scope-param-elem-var-close.js:
  • test262/test/language/expressions/function/scope-param-elem-var-open.js:
  • test262/test/language/expressions/function/scope-param-rest-elem-var-close.js:
  • test262/test/language/expressions/function/scope-param-rest-elem-var-open.js:
  • test262/test/language/expressions/generators/eval-var-scope-syntax-err.js: Added.

(f):

  • test262/test/language/expressions/generators/scope-param-elem-var-close.js:
  • test262/test/language/expressions/generators/scope-param-elem-var-open.js:
  • test262/test/language/expressions/generators/scope-param-rest-elem-var-close.js:
  • test262/test/language/expressions/generators/scope-param-rest-elem-var-open.js:
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-bigint.js:
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-incomparable-string.js:
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-non-finite.js:
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-number-extremes.js:
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-number.js:
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-string.js:
  • test262/test/language/expressions/greater-than/bigint-and-bigint.js:
  • test262/test/language/expressions/greater-than/bigint-and-boolean.js:
  • test262/test/language/expressions/greater-than/bigint-and-incomparable-string.js:
  • test262/test/language/expressions/greater-than/bigint-and-non-finite.js:
  • test262/test/language/expressions/greater-than/bigint-and-number-extremes.js:
  • test262/test/language/expressions/greater-than/bigint-and-number.js:
  • test262/test/language/expressions/greater-than/bigint-and-symbol.js:
  • test262/test/language/expressions/left-shift/bigint-and-number.js:
  • test262/test/language/expressions/left-shift/bigint-errors.js:
  • test262/test/language/expressions/left-shift/bigint-non-primitive.js:
  • test262/test/language/expressions/left-shift/bigint-toprimitive.js:
  • test262/test/language/expressions/left-shift/bigint-wrapped-values.js:
  • test262/test/language/expressions/less-than-or-equal/bigint-and-bigint.js:
  • test262/test/language/expressions/less-than-or-equal/bigint-and-incomparable-string.js:
  • test262/test/language/expressions/less-than-or-equal/bigint-and-non-finite.js:
  • test262/test/language/expressions/less-than-or-equal/bigint-and-number-extremes.js:
  • test262/test/language/expressions/less-than-or-equal/bigint-and-number.js:
  • test262/test/language/expressions/less-than-or-equal/bigint-and-string.js:
  • test262/test/language/expressions/less-than/bigint-and-bigint.js:
  • test262/test/language/expressions/less-than/bigint-and-boolean.js:
  • test262/test/language/expressions/less-than/bigint-and-incomparable-string.js:
  • test262/test/language/expressions/less-than/bigint-and-non-finite.js:
  • test262/test/language/expressions/less-than/bigint-and-number-extremes.js:
  • test262/test/language/expressions/less-than/bigint-and-number.js:
  • test262/test/language/expressions/modulus/bigint-and-number.js:
  • test262/test/language/expressions/modulus/bigint-arithmetic.js:
  • test262/test/language/expressions/modulus/bigint-errors.js:
  • test262/test/language/expressions/modulus/bigint-modulo-zero.js:
  • test262/test/language/expressions/modulus/bigint-toprimitive.js:
  • test262/test/language/expressions/modulus/bigint-wrapped-values.js:
  • test262/test/language/expressions/multiplication/bigint-and-number.js:
  • test262/test/language/expressions/multiplication/bigint-arithmetic.js:
  • test262/test/language/expressions/multiplication/bigint-errors.js:
  • test262/test/language/expressions/multiplication/bigint-toprimitive.js:
  • test262/test/language/expressions/multiplication/bigint-wrapped-values.js:
  • test262/test/language/expressions/object/method-definition/async-gen-meth-eval-var-scope-syntax-err.js: Added.

(obj.async method):

  • test262/test/language/expressions/object/method-definition/async-meth-eval-var-scope-syntax-err.js: Added.

(obj.async method):
(SyntaxError.then):

  • test262/test/language/expressions/object/method-definition/gen-meth-eval-var-scope-syntax-err.js: Added.

(obj.method.a.eval):

  • test262/test/language/expressions/object/method-definition/meth-eval-var-scope-syntax-err.js: Added.

(obj.method.a.eval):

  • test262/test/language/expressions/object/scope-gen-meth-param-elem-var-close.js:
  • test262/test/language/expressions/object/scope-gen-meth-param-elem-var-open.js:
  • test262/test/language/expressions/object/scope-gen-meth-param-rest-elem-var-close.js:
  • test262/test/language/expressions/object/scope-gen-meth-param-rest-elem-var-open.js:
  • test262/test/language/expressions/object/scope-meth-param-elem-var-close.js:
  • test262/test/language/expressions/object/scope-meth-param-elem-var-open.js:
  • test262/test/language/expressions/object/scope-meth-param-rest-elem-var-close.js:
  • test262/test/language/expressions/object/scope-meth-param-rest-elem-var-open.js:
  • test262/test/language/expressions/optional-chaining/iteration-statement-do.js: Added.
  • test262/test/language/expressions/optional-chaining/iteration-statement-for-await-of.js: Added.

(const.obj.iterable.Symbol.asyncIterator):
(async checkAssertions):

  • test262/test/language/expressions/optional-chaining/iteration-statement-for-in.js: Added.
  • test262/test/language/expressions/optional-chaining/iteration-statement-for-of-type-error.js: Added.
  • test262/test/language/expressions/optional-chaining/iteration-statement-for.js: Added.

(const.obj3.get a):

  • test262/test/language/expressions/optional-chaining/iteration-statement-while.js: Added.
  • test262/test/language/expressions/optional-chaining/new-target-optional-call.js: Added.

(const.newTargetContext):
(Base):
(Foo):

  • test262/test/language/expressions/optional-chaining/optional-call-preserves-this.js: Added.

(const.a.b):

  • test262/test/language/expressions/optional-chaining/super-property-optional-call.js: Added.

(Base.prototype.method):
(Base):
(Foo.prototype.method):
(Foo):

  • test262/test/language/expressions/right-shift/bigint-and-number.js:
  • test262/test/language/expressions/right-shift/bigint-errors.js:
  • test262/test/language/expressions/right-shift/bigint-non-primitive.js:
  • test262/test/language/expressions/right-shift/bigint-toprimitive.js:
  • test262/test/language/expressions/right-shift/bigint-wrapped-values.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-bigint.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-boolean.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-incomparable-primitive.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-non-finite.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-number-extremes.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-number.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-object.js:
  • test262/test/language/expressions/strict-does-not-equals/bigint-and-string.js:
  • test262/test/language/expressions/strict-equals/bigint-and-bigint.js:
  • test262/test/language/expressions/strict-equals/bigint-and-boolean.js:
  • test262/test/language/expressions/strict-equals/bigint-and-incomparable-primitive.js:
  • test262/test/language/expressions/strict-equals/bigint-and-non-finite.js:
  • test262/test/language/expressions/strict-equals/bigint-and-number-extremes.js:
  • test262/test/language/expressions/strict-equals/bigint-and-number.js:
  • test262/test/language/expressions/strict-equals/bigint-and-object.js:
  • test262/test/language/expressions/strict-equals/bigint-and-string.js:
  • test262/test/language/expressions/subtraction/bigint-and-number.js:
  • test262/test/language/expressions/subtraction/bigint-arithmetic.js:
  • test262/test/language/expressions/subtraction/bigint-errors.js:
  • test262/test/language/expressions/subtraction/bigint-toprimitive.js:
  • test262/test/language/expressions/subtraction/bigint-wrapped-values.js:
  • test262/test/language/expressions/typeof/proxy.js: Added.

(assert.sameValue.typeof.new.Proxy):
(const.rp2.Proxy.revocable):

  • test262/test/language/expressions/unary-minus/bigint-non-primitive.js:
  • test262/test/language/expressions/unary-plus/bigint-throws.js:
  • test262/test/language/expressions/unsigned-right-shift/bigint-and-number.js:
  • test262/test/language/expressions/unsigned-right-shift/bigint-errors.js:
  • test262/test/language/expressions/unsigned-right-shift/bigint-non-primitive.js:
  • test262/test/language/expressions/unsigned-right-shift/bigint-toprimitive.js:
  • test262/test/language/expressions/unsigned-right-shift/bigint-wrapped-values.js:
  • test262/test/language/function-code/eval-param-env-with-computed-key.js:
  • test262/test/language/function-code/eval-param-env-with-prop-initializer.js:
  • test262/test/language/statements/async-function/eval-var-scope-syntax-err.js: Added.

(async f):
(SyntaxError.then):

  • test262/test/language/statements/async-generator/eval-var-scope-syntax-err.js: Added.

(async f):

  • test262/test/language/statements/class/async-gen-method-static/eval-var-scope-syntax-err.js: Added.

(C.async method):
(C):

  • test262/test/language/statements/class/async-gen-method/eval-var-scope-syntax-err.js: Added.

(C.prototype.async method):
(C):

  • test262/test/language/statements/class/async-method-static/eval-var-scope-syntax-err.js: Added.

(C.async method):
(C):
(SyntaxError.then):

  • test262/test/language/statements/class/async-method/eval-var-scope-syntax-err.js: Added.

(C.prototype.async method):
(C):
(SyntaxError.then):

  • test262/test/language/statements/class/definition/constructable-but-no-prototype.js:
  • test262/test/language/statements/class/definition/constructor-strict-by-default.js:
  • test262/test/language/statements/class/definition/getters-restricted-ids.js:
  • test262/test/language/statements/class/definition/implicit-constructor.js:
  • test262/test/language/statements/class/definition/invalid-extends.js:
  • test262/test/language/statements/class/definition/methods-named-eval-arguments.js:
  • test262/test/language/statements/class/definition/prototype-getter.js:
  • test262/test/language/statements/class/definition/prototype-property.js:
  • test262/test/language/statements/class/definition/setters-restricted-ids.js:
  • test262/test/language/statements/class/definition/side-effects-in-extends.js:
  • test262/test/language/statements/class/definition/side-effects-in-property-define.js:
  • test262/test/language/statements/class/definition/this-access-restriction-2.js:
  • test262/test/language/statements/class/definition/this-access-restriction.js:
  • test262/test/language/statements/class/definition/this-check-ordering.js:
  • test262/test/language/statements/class/elements/syntax/early-errors/grammar-private-field-optional-chaining.js: Added.

(C.prototype.access):
(C):

  • test262/test/language/statements/class/gen-method-static/eval-var-scope-syntax-err.js: Added.

(C.method):
(C):

  • test262/test/language/statements/class/gen-method/eval-var-scope-syntax-err.js: Added.

(C.prototype.method):
(C):

  • test262/test/language/statements/class/method-static/eval-var-scope-syntax-err.js: Added.

(C.method):
(C):

  • test262/test/language/statements/class/method/eval-var-scope-syntax-err.js: Added.

(C.prototype.method):
(C):

  • test262/test/language/statements/class/name-binding/basic.js:
  • test262/test/language/statements/class/subclass/binding.js:
  • test262/test/language/statements/class/subclass/builtin-objects/RegExp/lastIndex.js:
  • test262/test/language/statements/class/subclass/builtin-objects/String/length.js:
  • test262/test/language/statements/class/subclass/builtin-objects/WeakMap/regular-subclassing.js:
  • test262/test/language/statements/class/subclass/builtin-objects/WeakMap/super-must-be-called.js:
  • test262/test/language/statements/class/subclass/builtin-objects/WeakSet/regular-subclassing.js:
  • test262/test/language/statements/class/subclass/builtin-objects/WeakSet/super-must-be-called.js:
  • test262/test/language/statements/class/subclass/builtins.js:
  • test262/test/language/statements/class/subclass/default-constructor-spread-override.js:
  • test262/test/language/statements/for-in/identifier-let-allowed-as-lefthandside-expression-not-strict.js:
  • test262/test/language/statements/for-in/order-enumerable-shadowed.js: Added.
  • test262/test/language/statements/for-in/order-property-added.js: Added.
  • test262/test/language/statements/for-in/order-property-on-prototype.js: Added.
  • test262/test/language/statements/for-in/order-simple-object.js: Added.
  • test262/test/language/statements/function/eval-var-scope-syntax-err.js: Added.

(f):

  • test262/test/language/statements/function/scope-param-elem-var-close.js:
  • test262/test/language/statements/function/scope-param-elem-var-open.js:
  • test262/test/language/statements/function/scope-param-rest-elem-var-close.js:
  • test262/test/language/statements/function/scope-param-rest-elem-var-open.js:
  • test262/test/language/statements/generators/eval-var-scope-syntax-err.js: Added.

(f):

  • test262/test/language/statements/generators/scope-param-elem-var-close.js:
  • test262/test/language/statements/generators/scope-param-elem-var-open.js:
  • test262/test/language/statements/generators/scope-param-rest-elem-var-close.js:
  • test262/test/language/statements/generators/scope-param-rest-elem-var-open.js:
  • test262/test262-Revision.txt:

Tools:

Using --save and --latest-import should update expectations rather than overwrite.

  • Scripts/test262/Runner.pm:

(main):

3:05 PM Changeset in webkit [254016] by Chris Dumez
  • 5 edits in trunk

dispatchEvent() should not clear the event's isTrusted flag when it returns early
​https://bugs.webkit.org/show_bug.cgi?id=205731

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/dom/events/Event-dispatch-redispatch-expected.txt:

Source/WebCore:

dispatchEvent() should not clear the event's isTrusted flag when it returns early:

No new tests, rebaselined existing test.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::dispatchEventForBindings):

2:30 PM Changeset in webkit [254015] by aestes@apple.com
  • 9 edits in trunk/Source

[Apple Pay] Provide a better error message when Apple Pay blocks user agent script evaluation
​https://bugs.webkit.org/show_bug.cgi?id=205730
<rdar://problem/55573484>

Reviewed by Brady Eidson.

Source/WebCore:

Covered by existing API tests.

  • Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::shouldAllowUserAgentScripts const):

  • Modules/applepay/PaymentCoordinator.h:
  • Modules/applepay/PaymentCoordinatorClient.h:

(WebCore::PaymentCoordinatorClient::userAgentScriptsBlockedErrorMessage const):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::executeUserAgentScriptInWorldInternal):
(WebCore::ScriptController::shouldAllowUserAgentScripts const):

  • bindings/js/ScriptController.h:

Source/WebKit:

  • WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::userAgentScriptsBlockedErrorMessage const):

  • WebProcess/ApplePay/WebPaymentCoordinator.h:
2:18 PM Changeset in webkit [254014] by dino@apple.com
  • 77 edits in trunk

[WebGL] Enable ANGLE by default for Cocoa platforms (except simulator)
​https://bugs.webkit.org/show_bug.cgi?id=205483
<rdar://problem/58097701>

Reverting this from trunk (was r253926) due to the number of
flakey tests and failures.

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • fast/canvas/webgl/array-bounds-clamping-expected.txt:
  • fast/canvas/webgl/array-bounds-clamping.html:
  • fast/canvas/webgl/copy-tex-image-and-sub-image-2d-bad-input-expected.txt:
  • fast/canvas/webgl/draw-elements-out-of-bounds-uint-index-expected.txt:
  • fast/canvas/webgl/drawElements-empty-vertex-data-expected.txt:
  • fast/canvas/webgl/oes-texture-half-float-uint16-expected.txt: Removed.
  • fast/canvas/webgl/oes-texture-half-float-uint16.html: Removed.
  • fast/canvas/webgl/readPixels-float-expected.txt:
  • fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies-expected.txt:
  • fast/canvas/webgl/simulated-vertexAttrib0-invalid-indicies.html:
  • fast/canvas/webgl/vertexAttribPointer-with-bad-offset-expected.txt:
  • fast/canvas/webgl/webgl-drawarrays-crash-2-expected.txt:
  • fast/canvas/webgl/webgl-drawarrays-crash-expected.txt:
  • fast/canvas/webgl/webgl2-texture-upload-enums-expected.txt:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
  • webgl/1.0.3/conformance/context/context-lost-restored-expected.txt:
  • webgl/1.0.3/conformance/extensions/oes-texture-float-expected.txt:
  • webgl/1.0.3/conformance/extensions/oes-texture-half-float-expected.txt:
  • webgl/1.0.3/conformance/glsl/misc/shader-struct-scope-expected.txt:
  • webgl/1.0.3/conformance/glsl/misc/shader-with-reserved-words-expected.txt:
  • webgl/1.0.3/conformance/glsl/misc/shaders-with-invariance-expected.txt:
  • webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
  • webgl/1.0.3/conformance/misc/webgl-specific-expected.txt:
  • webgl/1.0.3/conformance/rendering/point-no-attributes-expected.txt:
  • webgl/1.0.3/conformance/textures/texture-copying-feedback-loops-expected.txt:
  • webgl/2.0.0/conformance/context/context-lost-restored-expected.txt:
  • webgl/2.0.0/conformance/extensions/ext-sRGB-expected.txt:
  • webgl/2.0.0/conformance/extensions/oes-texture-float-expected.txt:
  • webgl/2.0.0/conformance/extensions/oes-texture-half-float-expected.txt:
  • webgl/2.0.0/conformance/extensions/oes-vertex-array-object-expected.txt:
  • webgl/2.0.0/conformance/extensions/webgl-depth-texture-expected.txt:
  • webgl/2.0.0/conformance/extensions/webgl-draw-buffers-framebuffer-unsupported-expected.txt:
  • webgl/2.0.0/conformance/glsl/misc/shader-struct-scope-expected.txt:
  • webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
  • webgl/2.0.0/conformance/glsl/misc/shaders-with-name-conflicts-expected.txt:
  • webgl/2.0.0/conformance/limits/gl-line-width-expected.txt:
  • webgl/2.0.0/conformance/misc/webgl-specific-expected.txt:
  • webgl/2.0.0/conformance/ogles/GL/biuDepthRange/biuDepthRange_001_to_002-expected.txt:
  • webgl/2.0.0/conformance/ogles/GL/gl_FragCoord/gl_FragCoord_001_to_003-expected.txt:
  • webgl/2.0.0/conformance/reading/read-pixels-test-expected.txt:
  • webgl/2.0.0/conformance/rendering/point-no-attributes-expected.txt:
  • webgl/2.0.0/conformance/textures/misc/cube-incomplete-fbo-expected.txt:
  • webgl/2.0.0/conformance/textures/misc/texture-copying-feedback-loops-expected.txt:
  • webgl/2.0.0/conformance2/buffers/get-buffer-sub-data-expected.txt:
  • webgl/2.0.0/conformance2/buffers/one-large-uniform-buffer-expected.txt:
  • webgl/2.0.0/conformance2/context/context-attributes-depth-stencil-antialias-obeyed-expected.txt:
  • webgl/2.0.0/conformance2/extensions/ext-color-buffer-float-expected.txt:
  • webgl/2.0.0/conformance2/extensions/promoted-extensions-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/shader-linking-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/shader-with-invalid-characters-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/shader-with-mis-matching-uniform-block-expected.txt:
  • webgl/2.0.0/conformance2/glsl3/valid-invariant-expected.txt:
  • webgl/2.0.0/conformance2/rendering/attrib-type-match-expected.txt:
  • webgl/2.0.0/conformance2/rendering/blitframebuffer-stencil-only-expected.txt:
  • webgl/2.0.0/conformance2/rendering/blitframebuffer-test-expected.txt:
  • webgl/2.0.0/conformance2/rendering/clear-func-buffer-type-match-expected.txt:
  • webgl/2.0.0/conformance2/rendering/clear-srgb-color-buffer-expected.txt:
  • webgl/2.0.0/conformance2/rendering/clipping-wide-points-expected.txt:
  • webgl/2.0.0/conformance2/rendering/framebuffer-unsupported-expected.txt:
  • webgl/2.0.0/conformance2/rendering/fs-color-type-mismatch-color-buffer-type-expected.txt:
  • webgl/2.0.0/conformance2/rendering/instanced-arrays-expected.txt:
  • webgl/2.0.0/conformance2/rendering/instanced-rendering-bug-expected.txt:
  • webgl/2.0.0/conformance2/rendering/rendering-sampling-feedback-loop-expected.txt:
  • webgl/2.0.0/conformance2/state/gl-get-calls-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/copy-texture-image-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-image-with-bad-args-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-mipmap-levels-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-new-formats-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/tex-storage-2d-expected.txt:
  • webgl/2.0.0/conformance2/textures/misc/texture-npot-expected.txt:
  • webgl/2.0.0/conformance2/vertex_arrays/vertex-array-object-expected.txt:
2:16 PM Changeset in webkit [254013] by aboya@igalia.com
  • 1 edit
    1 add in trunk/LayoutTests/imported/w3c

Unreviewed, add missing expectation file.
​https://bugs.webkit.org/show_bug.cgi?id=205728

  • web-platform-tests/media-source/mediasource-h264-play-starved-expected.txt: Added.
1:54 PM Changeset in webkit [254012] by dino@apple.com
  • 2 edits in trunk/Source/WebKit

Provide pid to crashing service worker process and GPU process
​https://bugs.webkit.org/show_bug.cgi?id=205564
<rdar://problem/58300321>

Build fix for TestWebKitAPI.

  • UIProcess/API/C/WKContext.h:
12:52 PM Changeset in webkit [254011] by Kocsen Chung
  • 8 edits in branches/safari-609.1.13-branch/Source

Versioning.

12:04 PM Changeset in webkit [254010] by ysuzuki@apple.com
  • 34 edits in trunk/Source

Put more WebCore/WebKit JS objects into IsoSubspace
​https://bugs.webkit.org/show_bug.cgi?id=205711

Reviewed by Keith Miller.

Source/WebCore:

This patch puts more JS objects into IsoSubspace, mainly focusing on JS objects defined manually (not using CodeGeneratorJS.pm).

No behavior change.

  • bindings/js/JSDOMBuiltinConstructor.h:

(WebCore::JSDOMBuiltinConstructor::JSDOMBuiltinConstructor): Deleted.
(WebCore::JSDOMBuiltinConstructor::initializeProperties): Deleted.

  • bindings/js/JSDOMBuiltinConstructorBase.cpp:

(WebCore::JSDOMBuiltinConstructorBase::subspaceForImpl):

  • bindings/js/JSDOMBuiltinConstructorBase.h:

(WebCore::JSDOMBuiltinConstructorBase::subspaceFor):

  • bindings/js/JSDOMConstructor.h:

(WebCore::JSDOMConstructor::JSDOMConstructor): Deleted.
(WebCore::JSDOMConstructor::initializeProperties): Deleted.

  • bindings/js/JSDOMConstructorBase.cpp:

(WebCore::JSDOMConstructorBase::subspaceForImpl):

  • bindings/js/JSDOMConstructorBase.h:

(WebCore::JSDOMConstructorBase::subspaceFor):

  • bindings/js/JSDOMConstructorNotConstructable.h:

(WebCore::JSDOMConstructorNotConstructable::JSDOMConstructorNotConstructable): Deleted.
(WebCore::JSDOMConstructorNotConstructable::initializeProperties): Deleted.
(WebCore::JSDOMConstructorNotConstructable::callThrowTypeError): Deleted.
(WebCore::JSDOMConstructorNotConstructable::getCallData): Deleted.

  • bindings/js/JSDOMIterator.h:

(WebCore::JSDOMIteratorPrototype::create): Deleted.
(WebCore::JSDOMIteratorPrototype::createStructure): Deleted.
(WebCore::JSDOMIteratorPrototype::JSDOMIteratorPrototype): Deleted.

  • bindings/js/JSDOMNamedConstructor.h:

(WebCore::JSDOMNamedConstructor::JSDOMNamedConstructor): Deleted.
(WebCore::JSDOMNamedConstructor::initializeProperties): Deleted.

  • bindings/js/JSDOMWindowProperties.cpp:

(WebCore::JSDOMWindowProperties::subspaceForImpl):

  • bindings/js/JSDOMWindowProperties.h:

(WebCore::JSDOMWindowProperties::create): Deleted.
(WebCore::JSDOMWindowProperties::createStructure): Deleted.
(WebCore::JSDOMWindowProperties::JSDOMWindowProperties): Deleted.

  • bindings/js/JSWindowProxy.cpp:

(WebCore::JSWindowProxy::subspaceForImpl):

  • bindings/js/JSWindowProxy.h:
  • bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

  • bindings/js/WebCoreJSClientData.h:

(WebCore::JSVMClientData::domBuiltinConstructorSpace):
(WebCore::JSVMClientData::domConstructorSpace):
(WebCore::JSVMClientData::domWindowPropertiesSpace):
(WebCore::JSVMClientData::runtimeArraySpace):
(WebCore::JSVMClientData::runtimeObjectSpace):
(WebCore::JSVMClientData::windowProxySpace):

  • bridge/c/CRuntimeObject.h:

(JSC::Bindings::CRuntimeObject::create): Deleted.
(JSC::Bindings::CRuntimeObject::createStructure): Deleted.

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::getMethod):
(JSC::Bindings::CRuntimeMethod::create): Deleted.
(JSC::Bindings::CRuntimeMethod::createStructure): Deleted.
(JSC::Bindings::CRuntimeMethod::CRuntimeMethod): Deleted.
(JSC::Bindings::CRuntimeMethod::finishCreation): Deleted.

  • bridge/objc/ObjCRuntimeObject.h:

(JSC::Bindings::ObjCRuntimeObject::create): Deleted.
(JSC::Bindings::ObjCRuntimeObject::createStructure): Deleted.

  • bridge/objc/objc_instance.mm:

(ObjCRuntimeMethod::create): Deleted.
(ObjCRuntimeMethod::createStructure): Deleted.
(ObjCRuntimeMethod::ObjCRuntimeMethod): Deleted.
(ObjCRuntimeMethod::finishCreation): Deleted.

  • bridge/objc/objc_runtime.h:

(JSC::Bindings::ObjcFallbackObjectImp::create): Deleted.
(JSC::Bindings::ObjcFallbackObjectImp::propertyName const): Deleted.
(JSC::Bindings::ObjcFallbackObjectImp::createPrototype): Deleted.
(JSC::Bindings::ObjcFallbackObjectImp::createStructure): Deleted.

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::subspaceForImpl):

  • bridge/runtime_array.cpp:

(JSC::RuntimeArray::RuntimeArray):
(JSC::RuntimeArray::subspaceForImpl):

  • bridge/runtime_array.h:

(JSC::RuntimeArray::create): Deleted.
(JSC::RuntimeArray::getLength const): Deleted.
(JSC::RuntimeArray::getConcreteArray const): Deleted.
(JSC::RuntimeArray::createPrototype): Deleted.
(JSC::RuntimeArray::createStructure): Deleted.

  • bridge/runtime_method.cpp:

(JSC::RuntimeMethod::RuntimeMethod):

  • bridge/runtime_method.h:
  • bridge/runtime_object.cpp:

(JSC::Bindings::RuntimeObject::RuntimeObject):
(JSC::Bindings::RuntimeObject::subspaceForImpl):

  • bridge/runtime_object.h:

Source/WebKit:

  • WebProcess/Plugins/Netscape/JSNPMethod.h:
  • WebProcess/Plugins/Netscape/JSNPObject.h:

Source/WebKitLegacy/mac:

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getMethod):
(WebKit::ProxyRuntimeMethod::create): Deleted.
(WebKit::ProxyRuntimeMethod::createStructure): Deleted.
(WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod): Deleted.
(WebKit::ProxyRuntimeMethod::finishCreation): Deleted.

  • Plugins/Hosted/ProxyRuntimeObject.h:

(WebKit::ProxyRuntimeObject::create): Deleted.
(WebKit::ProxyRuntimeObject::createStructure): Deleted.

11:49 AM WebKitGTK/2.26.x edited by Michael Catanzaro
Propose r250743 (diff)
11:04 AM Changeset in webkit [254009] by Simon Fraser
  • 9 edits
    9 copies
    1 move
    18 adds in trunk

Add some shared schemes to the WebKit.xcworkspace
​https://bugs.webkit.org/show_bug.cgi?id=205698

Reviewed by Tim Horton.
.:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

Source/JavaScriptCore:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • JavaScriptCore.xcodeproj/xcshareddata/xcschemes/JavaScriptCore.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WebCore:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • WebCore.xcodeproj/xcshareddata/xcschemes/WebCore.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WebKit:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • WebKit.xcodeproj/xcshareddata/xcschemes/WebKit.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WebKitLegacy:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • WebKitLegacy.xcodeproj/xcshareddata/xcschemes/WebKitLegacy.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Source/WTF:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • WTF.xcodeproj/xcshareddata/xcschemes/WTF.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.

Tools:

Make WebKit.xcworkspace show the following schemes by default:

All Source
All Tools
WTF
JavaScriptCore
WebCore
WebKit
WebKitLegacy
DumpRenderTree
WebKitTestRunner
TestWebKitAPI
MiniBrowser
MobileMiniBrowser.

Also remove the MobileMiniBrowserUITests scheme.

  • DumpRenderTree/DumpRenderTree.xcodeproj/xcshareddata/xcschemes/DumpRenderTree.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
  • MiniBrowser/MiniBrowser.xcodeproj/xcshareddata/xcschemes/MiniBrowser.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowser.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme: Copied from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/xcshareddata/xcschemes/WebKitTestRunner.xcscheme: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme.
10:35 AM Changeset in webkit [254008] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

highlight/highlight-world-leak.html frequently times out
​https://bugs.webkit.org/show_bug.cgi?id=205643
<rdar://problem/58263350>

Reviewed by Megan Gardner.

The main logic in this test is executed inside a load event handler to a subframe, which is set in a script
element. However, in the case where the subframe finishes loading before we execute the inline script, the test
will never run, since the load event handler won't be called again.

Fix this by waiting for the load event of the page instead.

  • highlight/highlight-world-leak.html:
10:22 AM Changeset in webkit [254007] by youenn@apple.com
  • 4 edits in trunk

REGRESSION: [iOS 13] webrtc/datachannel/mdns-ice-candidates.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=201900
<rdar://problem/55466061>

Reviewed by Eric Carlson.

Source/WebCore:

No change of behavior.

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::registerMDNSName):
Fix message typo (missing space).

LayoutTests:

  • platform/ios/TestExpectations:

Reenable test.

10:04 AM Changeset in webkit [254006] by youenn@apple.com
  • 11 edits in trunk

Provide pid to crashing service worker process and GPU process
​https://bugs.webkit.org/show_bug.cgi?id=205564

Reviewed by Alex Christensen.

Source/WebKit:

No change of behavior, we provide pids to the WKContext callbacks.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/GPU/GPUProcessProxy.cpp:

(WebKit::GPUProcessProxy::gpuProcessCrashed):

  • UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::serviceWorkerProcessDidCrash):
(WebKit::WebContextClient::gpuProcessDidCrash):

  • UIProcess/WebContextClient.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::serviceWorkerProcessCrashed):
(WebKit::WebProcessPool::gpuProcessCrashed):

  • UIProcess/WebProcessPool.h:

Tools:

Exposing the pid allows WebKitTestRunner to provide better information.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::serviceWorkerProcessDidCrash):
(WTR::TestController::gpuProcessDidCrash):

  • WebKitTestRunner/TestController.h:
9:50 AM Changeset in webkit [254005] by commit-queue@webkit.org
  • 10 edits in trunk

Deprecate _WKWebsitePolicies
​https://bugs.webkit.org/show_bug.cgi?id=205539

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-01-03
Reviewed by Wenson Hsieh.

Source/WebKit:

Its last use was removed in rdar://problem/58064847
but we need to keep it in WebKit until the next Safari release
to keep Safari working with built versions of open source WebKit with run-safari.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateWebsitePolicies:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[ContentBlockingWebsitePoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(TEST):
(-[AutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[AsyncAutoplayPoliciesDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[CustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
(-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[WebsitePoliciesWebsiteDataStoreDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
(-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
(-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]): Deleted.
(-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.

9:40 AM Changeset in webkit [254004] by youenn@apple.com
  • 4 edits in trunk

NetworkResourceLoader::didFinishWithRedirectResponse should not assume the load is coming from network
​https://bugs.webkit.org/show_bug.cgi?id=205715

Reviewed by Alex Christensen.

Source/WebKit:

Covered by updated test.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
If redirection is coming from cache, the load is not null.
We just need to use the request URL since the redirection mode is manual.

LayoutTests:

  • http/wpt/prefetch/link-prefetch-main-resource-redirect.html:
9:29 AM Changeset in webkit [254003] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Unreviewed, drop new assertion added in r253984 which hits on OpenSource bots

  • Shared/ios/DependencyProcessAssertionIOS.mm:

(WebKit::DependencyProcessAssertion::DependencyProcessAssertion):

9:24 AM Changeset in webkit [254002] by Chris Dumez
  • 3 edits in trunk/Source

Improve release logging in ServiceWorkerFetchTask
​https://bugs.webkit.org/show_bug.cgi?id=205692

Reviewed by Youenn Fablet.

Improve release logging in ServiceWorkerFetchTask to facilitate debugging.

  • NetworkProcess/ServiceWorker/ServiceWorkerFetchTask.cpp:

(WebKit::ServiceWorkerFetchTask::ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::~ServiceWorkerFetchTask):
(WebKit::ServiceWorkerFetchTask::start):
(WebKit::ServiceWorkerFetchTask::contextClosed):
(WebKit::ServiceWorkerFetchTask::startFetch):
(WebKit::ServiceWorkerFetchTask::didReceiveRedirectResponse):
(WebKit::ServiceWorkerFetchTask::didReceiveResponse):
(WebKit::ServiceWorkerFetchTask::didFinish):
(WebKit::ServiceWorkerFetchTask::didFail):
(WebKit::ServiceWorkerFetchTask::didNotHandle):
(WebKit::ServiceWorkerFetchTask::cannotHandle):
(WebKit::ServiceWorkerFetchTask::cancelFromClient):
(WebKit::ServiceWorkerFetchTask::continueDidReceiveFetchResponse):
(WebKit::ServiceWorkerFetchTask::continueFetchTaskWith):
(WebKit::ServiceWorkerFetchTask::timeoutTimerFired):
(WebKit::ServiceWorkerFetchTask::softUpdateIfNeeded):

8:58 AM Changeset in webkit [254001] by Chris Dumez
  • 15 edits in trunk

Align XPathEvaluator.createNSResolver() / XPathResult.snapshotItem() with the specification
​https://bugs.webkit.org/show_bug.cgi?id=205699

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaselined existing test now that more checks are passing.

  • web-platform-tests/dom/idlharness.window-expected.txt:

Source/WebCore:

Align XPathEvaluator.createNSResolver() / XPathResult.snapshotItem() with the specification and
other browsers (tested Chrome 79 and Firefox 71). In particular, their parameter should not be
optional (or nullable).

No new tests, rebaselined existing test.

  • dom/Document.cpp:

(WebCore::Document::createNSResolver):

  • dom/Document.h:
  • dom/Document.idl:
  • xml/NativeXPathNSResolver.cpp:

(WebCore::NativeXPathNSResolver::NativeXPathNSResolver):
(WebCore::NativeXPathNSResolver::lookupNamespaceURI):

  • xml/NativeXPathNSResolver.h:

(WebCore::NativeXPathNSResolver::create):

  • xml/XPathEvaluator.cpp:

(WebCore::XPathEvaluator::createNSResolver):

  • xml/XPathEvaluator.h:
  • xml/XPathEvaluator.idl:
  • xml/XPathResult.idl:

Source/WebKitLegacy/mac:

  • DOM/DOMDocument.mm:

(-[DOMDocument createNSResolver:]):

8:19 AM Changeset in webkit [254000] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

Implement "create a potential-CORS request"
​https://bugs.webkit.org/show_bug.cgi?id=205326

Patch by Rob Buis <​rbuis@igalia.com> on 2020-01-03
Reviewed by Youenn Fablet.

Implement "create a potential-CORS request" [1] and
remove deprecatedSetAsPotentiallyCrossOrigin. Add a
same-origin fallback flag that can be used by clients
of createPotentialAccessControlRequest in the future.

No new tests, no functional change.

  • bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::createPotentialAccessControlRequest):

  • loader/CrossOriginAccessControl.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

  • loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::deprecatedSetAsPotentiallyCrossOrigin): Deleted.

  • loader/cache/CachedResourceRequest.h:
8:03 AM Changeset in webkit [253999] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

[LFC][Integration] Enable text-transform:capitalize
​https://bugs.webkit.org/show_bug.cgi?id=205721

Reviewed by Zalan Bujtas.

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::canUseFor):

Enable.

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createLayoutBox):
(WebCore::Layout::applyTextTransform): Deleted.

No need to do anything, RenderText::text() has already applied text transform.

7:58 AM Changeset in webkit [253998] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/ruby/ruby-justification.html
​https://bugs.webkit.org/show_bug.cgi?id=205708
<rdar://problem/58290264>

Reviewed by Antti Koivisto.

  1. Fix last (content) run's trailing expansion behavior.
  2. Pass in float to TextRun instead of LayoutUnit to avoid losing precision.
  • layout/inlineformatting/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::justifyRuns const):

  • layout/integration/LayoutIntegrationLineLayout.cpp:

(WebCore::LayoutIntegration::LineLayout::paint):

7:42 AM Changeset in webkit [253997] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Fix fast/parser/entities-in-html.html
​https://bugs.webkit.org/show_bug.cgi?id=205710
<rdar://problem/58290731>

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineTextItem.cpp:

(WebCore::Layout::isWhitespaceCharacter):

6:17 AM Changeset in webkit [253996] by cathiechen
  • 18 edits
    16 adds
    1 delete in trunk/LayoutTests

Import WPT test cases for apect-ratio generated from attribute width and height
​https://bugs.webkit.org/show_bug.cgi?id=205678

Reviewed by Manuel Rego Casasnovas

LayoutTests/imported/w3c:

Import web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/ from WPT.
Also import web-platform-tests/media/ which is needed by video-aspect-ratio.html.
Update video_loop_base-expected.txt, resize-during-playback-expected.txt and wpt-server-http.sub-expected.txt
which include resources in web-platform-tests/media/.

  • resources/import-expectations.json:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/align.html:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio-expected.txt:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/canvas-aspect-ratio.html:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/content-aspect-ratio-expected.txt: Added.
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/content-aspect-ratio.html: Added.
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-expected.txt:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-no-alt-replaced.html:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-replaced-box-while-loading.html:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio-expected.txt:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/video-aspect-ratio.html:
  • web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/video_loop_base-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-video-element/resize-during-playback-expected.txt:
  • web-platform-tests/infrastructure/server/wpt-server-http.sub-expected.txt:
  • web-platform-tests/media/1x1-green.png: Added.
  • web-platform-tests/media/2x2-green.mp4: Added.
  • web-platform-tests/media/2x2-green.ogv: Added.
  • web-platform-tests/media/400x300-red-resize-200x150-green.mp4: Added.
  • web-platform-tests/media/400x300-red-resize-200x150-green.webm: Added.
  • web-platform-tests/media/META.yml: Added.
  • web-platform-tests/media/OWNERS: Removed.
  • web-platform-tests/media/counting.mp4: Added.
  • web-platform-tests/media/counting.ogv: Added.
  • web-platform-tests/media/foo-no-cors.vtt: Added.
  • web-platform-tests/media/sound_0.mp3: Added.
  • web-platform-tests/media/sound_0.oga: Added.
  • web-platform-tests/media/test.mp4: Added.
  • web-platform-tests/media/test.ogv: Added.
  • web-platform-tests/media/video.ogv: Added.
  • web-platform-tests/media/w3c-import.log:

LayoutTests:

video-aspect-ratio.html passes the test after importing web-platform-tests/media/

5:56 AM Changeset in webkit [253995] by aboya@igalia.com
  • 3 edits
    4 adds in trunk

[GStreamer][MSE] Player stalling too soon
​https://bugs.webkit.org/show_bug.cgi?id=205117

Reviewed by Xabier Rodriguez-Calvar.

LayoutTests/imported/w3c:

Added the testcase used to report the bug, cleaned and adapted for
WPT.

  • web-platform-tests/media-source/mediasource-h264-play-starved.html: Added.
  • web-platform-tests/media-source/mp4/h264-starvation-init.mp4: Added.
  • web-platform-tests/media-source/mp4/h264-starvation-media.mp4: Added.

Tools:

Backported patch to jhbuild.

Small modifications were necessary to make it apply on 1.16.1.

  • gstreamer/jhbuild.modules:
  • gstreamer/patches/libav-0001-gstavviddec-Limit-default-number-of-decoder-threads.patch: Added.
2:06 AM Changeset in webkit [253994] by sbarati@apple.com
  • 3 edits
    1 add in trunk

B3::ReduceLoopStrength should not do range based iteration on a vector it's mutating
​https://bugs.webkit.org/show_bug.cgi?id=205703
<rdar://problem/56459483>

Reviewed by Mark Lam.

JSTests:

  • stress/dont-range-based-iterate-vector-that-is-mutated.js: Added.

(foo):

Source/JavaScriptCore:

B3::ReduceLoopStrength had code that did:
`
for (BasicBlock* pred : loopPostfooter->predecessors())

loopPostfooter->removePredecessor(pred);

`

This is wrong, since it's doing a range based iteration over the vector it is
mutating. The fix is to just do:
`
while (loopPostfooter->predecessors().size())

loopPostfooter->removePredecessor(loopPostfooter->predecessors()[0]);

`

  • b3/B3ReduceLoopStrength.cpp:

(JSC::B3::ReduceLoopStrength::reduceByteCopyLoopsToMemcpy):

1:57 AM Changeset in webkit [253993] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

Fix non-libwebrtc builds after r253957
​https://bugs.webkit.org/show_bug.cgi?id=205714

Unreviewed.

  • GPUProcess/webrtc/LibWebRTCCodecsProxy.mm:

Move the includes inside the compilation guard.

1:41 AM Changeset in webkit [253992] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

<link> with non-CSS type should not be retrieved
​https://bugs.webkit.org/show_bug.cgi?id=88157

Patch by Rob Buis <​rbuis@igalia.com> on 2020-01-03
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Import test for various type attribute values for rel=stylesheet link elements.

  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-type-attribute-expected.html: Added.
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-type-attribute.html: Added.
  • web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:

Source/WebCore:

If the UA does not support the given MIME type for the given link
relationship, then the UA should not fetch and process the linked
resource [1].

The behavior matches Chrome and Firefox.

[1] ​https://html.spec.whatwg.org/multipage/semantics.html#processing-the-type-attribute

Test: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-type-attribute.html

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

1:20 AM Changeset in webkit [253991] by sbarati@apple.com
  • 5 edits
    1 add in trunk

AI rule for PutById can only observe transitions when it watches the condition
​https://bugs.webkit.org/show_bug.cgi?id=205697
<rdar://problem/56814254>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/only-transition-structures-for-put-by-id-in-AI-if-watchable.js: Added.

Source/JavaScriptCore:

There was a bug in AI where we were capturing a PutByIdStatus and
emitting a structure transition in AI state based on the variants inside this
PutByIdStatus. This, in principal, is a valid static analysis to perform.
However, we can only do this if we ensure that the snapshot we have in the
PutByIdStatus holds at runtime. We can do this by watching the property conditions
for the various variants. AI forgot to watch these conditions. This patch fixes that.
In practice, this also means we need to be slightly more strict about stating to
AI when we transition since some object property conditions aren't watchable, and need
to be verified at runtime via structure checks. This is ok in practice, since
we'll emit the code to do that inside constant folding (constant folding was
already doing this), which will continue to report the precise transition in
the abstract state.

  • dfg/DFGAbstractInterpreter.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

Jan 2, 2020:

7:52 PM Changeset in webkit [253990] by Keith Rollin
  • 4 edits in trunk/Source/WebKit

Reformat WebProcess logging
​https://bugs.webkit.org/show_bug.cgi?id=205691
<rdar://problem/58283294>

Reviewed by Chris Dumez.

Update the format used by WebProcess in its RELEASE_LOG logging. Use
the format used by WebPageProxy and NetworkResourceLoader, which is
generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x6f1df7000 - WebProcess::destroyRenderingResources() took 0.02ms

becomes:

0x6f1df7000 - [sessionID=2] WebProcess::destroyRenderingResources: took 0.02ms

While we're at it, also convert over to the RELEASE_LOG_IF_ALLOWED
style of logging macro. We didn't used to be able to do this since the
decision on whether or not to allow logging is typically based on
SessionID, which didn't used to be an attribute of WebProcess. Now
WebProcesses do (or can) have a SessionID, so use that to support the
hiding of logging in private sessions.

No new tests - no added or changed functionality.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::prepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::freezeAllLayerTrees):
(WebKit::WebProcess::unfreezeAllLayerTrees):
(WebKit::WebProcess::processDidResume):
(WebKit::WebProcess::grantUserMediaDeviceSandboxExtensions):
(WebKit::WebProcess::revokeUserMediaDeviceSandboxExtensions):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::isAlwaysOnLoggingAllowed):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::updateProcessName):
(WebKit::WebProcess::updateCPUMonitorState):
(WebKit::WebProcess::destroyRenderingResources):
(WebKit::WebProcess::updateFreezerStatus):

7:31 PM Changeset in webkit [253989] by Chris Dumez
  • 6 edits
    3 moves
    2 deletes in trunk/LayoutTests/imported/w3c

Re-sync web-platform-tests/domparsing from upstream
​https://bugs.webkit.org/show_bug.cgi?id=205696

Reviewed by Alex Christensen.

Re-sync web-platform-tests/domparsing from upstream cb0d9cacbbf30a4cae79faa2.

  • web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
  • web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
  • web-platform-tests/domparsing/XMLSerializer-serializeToString-expected.txt:
  • web-platform-tests/domparsing/XMLSerializer-serializeToString.html:
  • web-platform-tests/domparsing/idlharness.window-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/domparsing/interfaces.any-expected.txt.
  • web-platform-tests/domparsing/idlharness.window.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/domparsing/interfaces.any.html.
  • web-platform-tests/domparsing/idlharness.window.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/domparsing/interfaces.any.js.
  • web-platform-tests/domparsing/interfaces.any.worker-expected.txt: Removed.
  • web-platform-tests/domparsing/interfaces.any.worker.html: Removed.
  • web-platform-tests/domparsing/w3c-import.log:
6:52 PM Changeset in webkit [253988] by Chris Dumez
  • 3 edits
    2 adds in trunk

XMLSerializer doesn't correctly encode entities in <style> element
​https://bugs.webkit.org/show_bug.cgi?id=205635

Reviewed by Alex Christensen.

Source/WebCore:

As per [1], when doing an XML serialization of text, we should escape '<', '>' and '&', even
if the text is inside a <style> element. The <style> element exception is for HTML serialization [2].

[1] ​https://w3c.github.io/DOM-Parsing/#xml-serializing-a-text-node
[2] ​https://html.spec.whatwg.org/#serialising-html-fragments

Test: fast/dom/xmlserializer-ampersand-in-style.html

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::entityMaskForText const):

LayoutTests:

Add layout test coverage.

  • fast/dom/xmlserializer-ampersand-in-style-expected.txt: Added.
  • fast/dom/xmlserializer-ampersand-in-style.html: Added.
6:36 PM Changeset in webkit [253987] by ysuzuki@apple.com
  • 174 edits
    12 copies
    1 add in trunk/Source

Experiment: create lots of different malloc zones for easier accounting of memory use
​https://bugs.webkit.org/show_bug.cgi?id=186422

Patch by Yusuke Suzuki <​ysuzuki@apple.com> and Simon Fraser <Simon Fraser> on 2020-01-02
Reviewed by Saam Barati.

Source/bmalloc:

  • bmalloc/BPlatform.h:
  • bmalloc/Environment.cpp:

(bmalloc::Environment::computeIsDebugHeapEnabled):

  • bmalloc/IsoHeap.h:

(bmalloc::api::IsoHeap::IsoHeap):

  • bmalloc/IsoHeapInlines.h:

(bmalloc::api::IsoHeap<Type>::IsoHeap):

  • bmalloc/IsoTLSInlines.h:

(bmalloc::IsoTLS::allocateSlow):
(bmalloc::IsoTLS::deallocateSlow):

Source/JavaScriptCore:

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt:
  • assembler/AssemblerBuffer.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • assembler/AssemblerBuffer.h:

(JSC::AssemblerData::AssemblerData):
(JSC::AssemblerData::operator=):
(JSC::AssemblerData::~AssemblerData):
(JSC::AssemblerData::grow):

  • bytecode/AccessCase.cpp:
  • bytecode/AccessCase.h:
  • bytecode/BytecodeBasicBlock.cpp:
  • bytecode/BytecodeBasicBlock.h:
  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
  • bytecode/InstructionStream.cpp:
  • bytecode/InstructionStream.h:
  • bytecode/PolymorphicAccess.cpp:
  • bytecode/PolymorphicAccess.h:
  • bytecode/UnlinkedMetadataTable.cpp:

(JSC::UnlinkedMetadataTable::finalize):

  • bytecode/UnlinkedMetadataTable.h:
  • bytecode/UnlinkedMetadataTableInlines.h:

(JSC::UnlinkedMetadataTable::UnlinkedMetadataTable):
(JSC::UnlinkedMetadataTable::~UnlinkedMetadataTable):
(JSC::UnlinkedMetadataTable::link):
(JSC::UnlinkedMetadataTable::unlink):

  • bytecode/ValueProfile.h:

(JSC::ValueProfileAndVirtualRegisterBuffer::ValueProfileAndVirtualRegisterBuffer):

  • bytecode/Watchpoint.cpp:
  • bytecode/Watchpoint.h:
  • dfg/DFGBasicBlock.cpp:
  • dfg/DFGBasicBlock.h:
  • dfg/DFGNode.cpp:
  • dfg/DFGNode.h:
  • dfg/DFGSpeculativeJIT.cpp:
  • dfg/DFGSpeculativeJIT.h:
  • heap/BlockDirectory.cpp:
  • heap/BlockDirectory.h:
  • heap/FastMallocAlignedMemoryAllocator.cpp:

(JSC::FastMallocAlignedMemoryAllocator::FastMallocAlignedMemoryAllocator):
(JSC::FastMallocAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::FastMallocAlignedMemoryAllocator::freeAlignedMemory):
(JSC::FastMallocAlignedMemoryAllocator::tryAllocateMemory):
(JSC::FastMallocAlignedMemoryAllocator::freeMemory):
(JSC::FastMallocAlignedMemoryAllocator::tryReallocateMemory):

  • heap/FastMallocAlignedMemoryAllocator.h:
  • heap/GCSegmentedArray.cpp: Copied from Source/JavaScriptCore/parser/SourceProviderCache.cpp.
  • heap/GCSegmentedArray.h:
  • heap/GCSegmentedArrayInlines.h:

(JSC::GCArraySegment<T>::create):
(JSC::GCArraySegment<T>::destroy):

  • heap/GigacageAlignedMemoryAllocator.cpp:

(JSC::GigacageAlignedMemoryAllocator::GigacageAlignedMemoryAllocator):
(JSC::GigacageAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::freeAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::tryAllocateMemory):
(JSC::GigacageAlignedMemoryAllocator::freeMemory):
(JSC::GigacageAlignedMemoryAllocator::tryReallocateMemory):

  • heap/GigacageAlignedMemoryAllocator.h:
  • heap/IsoAlignedMemoryAllocator.cpp:

(JSC::IsoAlignedMemoryAllocator::IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::~IsoAlignedMemoryAllocator):
(JSC::IsoAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::IsoAlignedMemoryAllocator::freeAlignedMemory):
(JSC::IsoAlignedMemoryAllocator::tryAllocateMemory):
(JSC::IsoAlignedMemoryAllocator::freeMemory):

  • heap/IsoAlignedMemoryAllocator.h:
  • heap/IsoSubspace.cpp:

(JSC::IsoSubspace::IsoSubspace):

  • heap/MarkedBlock.cpp:
  • heap/MarkedBlock.h:
  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create):
(JSC::WeakBlock::destroy):

  • heap/WeakBlock.h:
  • jit/JITCode.cpp:
  • jit/JITCode.h:
  • jit/RegisterAtOffsetList.cpp:
  • jit/RegisterAtOffsetList.h:
  • parser/Nodes.cpp:
  • parser/Nodes.h:
  • parser/ParserArena.cpp:

(JSC::ParserArena::deallocateObjects):
(JSC::ParserArena::allocateFreeablePool):

  • parser/ParserArena.h:
  • parser/SourceProvider.cpp:
  • parser/SourceProvider.h:
  • parser/SourceProviderCache.cpp:
  • parser/SourceProviderCache.h:
  • parser/SourceProviderCacheItem.h:

(JSC::SourceProviderCacheItem::create):

  • runtime/CachePayload.cpp:

(JSC::CachePayload::makeMallocPayload):

  • runtime/CachePayload.h:
  • runtime/CachedBytecode.h:

(JSC::CachedBytecode::create):

  • runtime/CachedTypes.cpp:

(JSC::Encoder::release):
(JSC::Encoder::Page::Page):
(JSC::CachedVector::encode):
(JSC::CachedVector::decode const):
(JSC::CachedInstructionStream::decode const):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::rehash):

  • runtime/PropertyTable.cpp:

(JSC::PropertyTable::PropertyTable):
(JSC::PropertyTable::~PropertyTable):

  • runtime/SymbolTable.cpp:
  • runtime/SymbolTable.h:
  • runtime/VM.cpp:

(JSC::VM::~VM):

  • runtime/VM.h:

(JSC::ScratchBuffer::create):
(JSC::VM::exceptionFuzzingBuffer):

  • wasm/WasmInstance.cpp:

(JSC::Wasm::Instance::Instance):

  • wasm/WasmInstance.h:
  • wasm/WasmTable.cpp:

(JSC::Wasm::Table::Table):
(JSC::Wasm::FuncRefTable::FuncRefTable):

  • wasm/WasmTable.h:

Source/WebCore:

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/SerializedScriptValue.cpp:
  • bindings/js/SerializedScriptValue.h:
  • css/CSSFontFace.cpp:
  • css/CSSFontFace.h:
  • css/CSSSelector.cpp:
  • css/CSSSelector.h:
  • css/CSSValue.cpp:
  • css/CSSValue.h:
  • css/StyleProperties.cpp:

(WebCore::ImmutableStyleProperties::create):

  • css/StyleProperties.h:
  • css/StyleRule.cpp:
  • css/StyleRule.h:
  • dom/ElementData.cpp:

(WebCore::ShareableElementData::createWithAttributes):
(WebCore::UniqueElementData::makeShareableCopy const):

  • dom/ElementData.h:
  • dom/NodeRareData.cpp:
  • dom/NodeRareData.h:
  • dom/QualifiedName.cpp:
  • dom/QualifiedName.h:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/cache/CachedResource.cpp:
  • loader/cache/CachedResource.h:
  • page/PerformanceEntry.cpp:
  • page/PerformanceEntry.h:
  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/FontCascadeFonts.cpp:
  • platform/graphics/FontCascadeFonts.h:
  • platform/graphics/Region.cpp:
  • platform/graphics/Region.h:
  • platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::releaseUint8Vector):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/nicosia/NicosiaBuffer.cpp:

(Nicosia::Buffer::Buffer):

  • platform/network/ResourceHandle.cpp:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):

  • rendering/RenderLayer.cpp:
  • rendering/RenderLayer.h:
  • rendering/TableLayout.cpp: Copied from Source/JavaScriptCore/parser/SourceProviderCache.cpp.
  • rendering/TableLayout.h:
  • rendering/style/RenderStyle.cpp:
  • rendering/style/RenderStyle.h:
  • rendering/style/SVGRenderStyle.cpp:
  • rendering/style/SVGRenderStyle.h:
  • rendering/style/SVGRenderStyleDefs.cpp:
  • rendering/style/SVGRenderStyleDefs.h:
  • rendering/style/StyleBoxData.cpp:
  • rendering/style/StyleBoxData.h:
  • rendering/style/StyleInheritedData.cpp:
  • rendering/style/StyleInheritedData.h:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:
  • rendering/style/StyleRareNonInheritedData.h:
  • rendering/style/StyleSurroundData.cpp:
  • rendering/style/StyleSurroundData.h:
  • rendering/style/StyleTransformData.cpp:
  • rendering/style/StyleTransformData.h:
  • style/StyleTreeResolver.cpp:
  • style/StyleTreeResolver.h:
  • svg/animation/SMILTimeContainer.cpp:
  • svg/animation/SMILTimeContainer.h:

Source/WebKit:

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::create):
(WebKit::ShareableBitmap::~ShareableBitmap):

  • UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::HistoryEntryDataEncoder::HistoryEntryDataEncoder):
(WebKit::HistoryEntryDataEncoder::finishEncoding):
(WebKit::encodeSessionHistoryEntryData):
(WebKit::encodeLegacySessionState):

Source/WTF:

This patch introduces ENABLE(MALLOC_HEAP_BREAKDOWN). If this is enabled, we allocate malloc_zone per malloc kind.
This offers the way to investigate the usage of memory per kind by using vmmap, like the following.

VIRTUAL RESIDENT DIRTY SWAPPED ALLOCATION BYTES DIRTY+SWAP REGION
MALLOC ZONE SIZE SIZE SIZE SIZE COUNT ALLOCATED FRAG SIZE % FRAG COUNT
=========== ======= ========= ========= ========= ========= ========= ========= ====== ======
StringImpl_0x116efd000 188.0M 69.3M 30.9M 0K 139456 18.0M 12.9M 42% 34
DefaultMallocZone_0x10f487000 176.0M 53.9M 14.1M 0K 115956 9955K 4497K 32% 22
Vector_0x116eff000 162.0M 56.3M 55.3M 0K 140715 17.3M 37.9M 69% 36
MetadataTable_0x11843b000 152.0M 17.5M 17.5M 0K 14200 2353K 15.2M 87% 26
WebKit Using System Malloc_0x114cbe000 150.0M 31.6M 21.8M 0K 87422 16.7M 5278K 24% 23
InstructionStream_0x118469000 150.0M 5764K 5764K 0K 14470 4688K 1076K 19% 24
AssemblerData_0x117ee6000 150.0M 1928K 1928K 0K 1 16 1928K 100% 24

To achieve this goal without making very large change, we put a template type in various containers.
For example, Vector will take Malloc parameter (the default one is FastMalloc allocator). If ENABLE(MALLOC_HEAP_BREAKDOWN) is enabled, we change this to
specific VectorMalloc allocator, and vmmap can show memory usage of this allocator. This patch also supports malloc_zone per IsoHeap. So we can see memory
allocation per IsoHeap in vmmap.

To use this feature, we need to flip two compile time flags, ENABLE(MALLOC_HEAP_BREAKDOWN) in WTF and BENABLE_MALLOC_HEAP_BREAKDOWN in bmalloc.
And use vmmap $PID to dump malloc zones. To allocate objects of a class with a specific malloc-zone, use WTF_MAKE_FAST_ALLOCATED_WITH_HEAP_IDENTIFIER(HeapIdentifier) for the class,
and define allocator by DECLARE_ALLOCATOR_WITH_HEAP_IDENTIFIER(HeapIdentifier) in a header and DEFINE_ALLOCATOR_WITH_HEAP_IDENTIFIER(HeapIdentifier) in a cpp file.

This patch also introduce callstack collector for malloc. Vector, HashMap etc. are used to allocate various things, but the above malloc_zone feature only tells thing like "Vector
takes XXX MB memory". But what we want to know in this case is what Vector is consuming memory. We collect StackShot for each malloc call, and combine these information to tell
which callsite is consuming much memory, which tell us that what Vector is consuming memory.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Bag.cpp: Copied from Source/JavaScriptCore/parser/SourceProviderCache.cpp.
  • wtf/Bag.h:

(WTF::Private::BagNode::BagNode): Deleted.

  • wtf/BitVector.cpp:

(WTF::BitVector::OutOfLineBits::create):
(WTF::BitVector::OutOfLineBits::destroy):

  • wtf/CMakeLists.txt:
  • wtf/ConcurrentBuffer.cpp: Copied from Source/JavaScriptCore/parser/SourceProviderCache.cpp.
  • wtf/ConcurrentBuffer.h:
  • wtf/DebugHeap.cpp: Copied from Source/JavaScriptCore/runtime/CachePayload.cpp.

(WTF::DebugHeap::DebugHeap):
(WTF::DebugHeap::malloc):
(WTF::DebugHeap::calloc):
(WTF::DebugHeap::memalign):
(WTF::DebugHeap::realloc):
(WTF::DebugHeap::free):

  • wtf/DebugHeap.h: Added.
  • wtf/FastBitVector.cpp:

(WTF::FastBitVectorWordOwner::setEqualsSlow):
(WTF::FastBitVectorWordOwner::resizeSlow):

  • wtf/FastBitVector.h:

(WTF::FastBitVectorWordOwner::~FastBitVectorWordOwner):

  • wtf/FastMalloc.cpp:

(WTF::fastMallocDumpMallocStats):
(WTF::AvoidRecordingScope::AvoidRecordingScope):
(WTF::AvoidRecordingScope::~AvoidRecordingScope):
(WTF::MallocCallTracker::MallocSiteData::MallocSiteData):
(WTF::MallocCallTracker::singleton):
(WTF::MallocCallTracker::MallocCallTracker):
(WTF::MallocCallTracker::recordMalloc):
(WTF::MallocCallTracker::recordRealloc):
(WTF::MallocCallTracker::recordFree):
(WTF::MallocCallTracker::dumpStats):
(WTF::fastMalloc):
(WTF::fastRealloc):
(WTF::fastFree):
(WTF::fastAlignedMalloc):
(WTF::tryFastAlignedMalloc):
(WTF::fastAlignedFree):

  • wtf/FastMalloc.h:

(WTF::FastMalloc::zeroedMalloc):
(WTF::FastMalloc::tryZeroedMalloc):

  • wtf/Forward.h:
  • wtf/HashTable.cpp:
  • wtf/HashTable.h:

(WTF::KeyTraits>::allocateTable):
(WTF::KeyTraits>::deallocateTable):
(WTF::KeyTraits>::rehash):

  • wtf/MallocPtr.h:

(WTF::MallocPtr::MallocPtr):
(WTF::MallocPtr::malloc):
(WTF::MallocPtr::zeroedMalloc):
(WTF::MallocPtr::tryMalloc):
(WTF::MallocPtr::tryZeroedMalloc):
(WTF::adoptMallocPtr):

  • wtf/MetaAllocator.cpp:

(WTF::MetaAllocator::allocFreeSpaceNode):
(WTF::MetaAllocator::freeFreeSpaceNode):

  • wtf/MetaAllocatorHandle.h:
  • wtf/Platform.h:
  • wtf/RefCountedArray.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::RefCountedArray):
(WTF::RefCountedArray::~RefCountedArray):
(WTF::RefCountedArray::assign):

  • wtf/SegmentedVector.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • wtf/SegmentedVector.h:
  • wtf/SmallPtrSet.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • wtf/SmallPtrSet.h:

(WTF::SmallPtrSet::~SmallPtrSet):
(WTF::SmallPtrSet::grow):

  • wtf/UniqueArray.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • wtf/UniqueArray.h:

(WTF::UniqueArrayFree::operator() const):
(WTF::UniqueArrayFree<T::operator() const):

  • wtf/Vector.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):
(WTF::VectorBufferBase::deallocateBuffer):
(WTF::VectorBufferBase::releaseBuffer):
(WTF::VectorBuffer::releaseBuffer):
(WTF::Vector::swap):
(WTF::Malloc>::Vector):
(WTF::=):
(WTF::Malloc>::contains const):
(WTF::Malloc>::findMatching const):
(WTF::Malloc>::find const):
(WTF::Malloc>::reverseFind const):
(WTF::Malloc>::appendIfNotContains):
(WTF::Malloc>::fill):
(WTF::Malloc>::appendRange):
(WTF::Malloc>::expandCapacity):
(WTF::Malloc>::tryExpandCapacity):
(WTF::Malloc>::resize):
(WTF::Malloc>::resizeToFit):
(WTF::Malloc>::shrink):
(WTF::Malloc>::grow):
(WTF::Malloc>::asanSetInitialBufferSizeTo):
(WTF::Malloc>::asanSetBufferSizeToFullCapacity):
(WTF::Malloc>::asanBufferSizeWillChangeTo):
(WTF::Malloc>::reserveCapacity):
(WTF::Malloc>::tryReserveCapacity):
(WTF::Malloc>::reserveInitialCapacity):
(WTF::Malloc>::shrinkCapacity):
(WTF::Malloc>::append):
(WTF::Malloc>::tryAppend):
(WTF::Malloc>::constructAndAppend):
(WTF::Malloc>::tryConstructAndAppend):
(WTF::Malloc>::appendSlowCase):
(WTF::Malloc>::constructAndAppendSlowCase):
(WTF::Malloc>::tryConstructAndAppendSlowCase):
(WTF::Malloc>::uncheckedAppend):
(WTF::Malloc>::uncheckedConstructAndAppend):
(WTF::Malloc>::appendVector):
(WTF::Malloc>::insert):
(WTF::Malloc>::insertVector):
(WTF::Malloc>::remove):
(WTF::Malloc>::removeFirst):
(WTF::Malloc>::removeFirstMatching):
(WTF::Malloc>::removeAll):
(WTF::Malloc>::removeAllMatching):
(WTF::Malloc>::reverse):
(WTF::Malloc>::map const):
(WTF::Malloc>::releaseBuffer):
(WTF::Malloc>::checkConsistency):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::Malloc>::isolatedCopy const):
(WTF::removeRepeatedElements):
(WTF::minCapacity>::Vector): Deleted.
(WTF::minCapacity>::contains const): Deleted.
(WTF::minCapacity>::findMatching const): Deleted.
(WTF::minCapacity>::find const): Deleted.
(WTF::minCapacity>::reverseFind const): Deleted.
(WTF::minCapacity>::appendIfNotContains): Deleted.
(WTF::minCapacity>::fill): Deleted.
(WTF::minCapacity>::appendRange): Deleted.
(WTF::minCapacity>::expandCapacity): Deleted.
(WTF::minCapacity>::tryExpandCapacity): Deleted.
(WTF::minCapacity>::resize): Deleted.
(WTF::minCapacity>::resizeToFit): Deleted.
(WTF::minCapacity>::shrink): Deleted.
(WTF::minCapacity>::grow): Deleted.
(WTF::minCapacity>::asanSetInitialBufferSizeTo): Deleted.
(WTF::minCapacity>::asanSetBufferSizeToFullCapacity): Deleted.
(WTF::minCapacity>::asanBufferSizeWillChangeTo): Deleted.
(WTF::minCapacity>::reserveCapacity): Deleted.
(WTF::minCapacity>::tryReserveCapacity): Deleted.
(WTF::minCapacity>::reserveInitialCapacity): Deleted.
(WTF::minCapacity>::shrinkCapacity): Deleted.
(WTF::minCapacity>::append): Deleted.
(WTF::minCapacity>::tryAppend): Deleted.
(WTF::minCapacity>::constructAndAppend): Deleted.
(WTF::minCapacity>::tryConstructAndAppend): Deleted.
(WTF::minCapacity>::appendSlowCase): Deleted.
(WTF::minCapacity>::constructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::tryConstructAndAppendSlowCase): Deleted.
(WTF::minCapacity>::uncheckedAppend): Deleted.
(WTF::minCapacity>::uncheckedConstructAndAppend): Deleted.
(WTF::minCapacity>::appendVector): Deleted.
(WTF::minCapacity>::insert): Deleted.
(WTF::minCapacity>::insertVector): Deleted.
(WTF::minCapacity>::remove): Deleted.
(WTF::minCapacity>::removeFirst): Deleted.
(WTF::minCapacity>::removeFirstMatching): Deleted.
(WTF::minCapacity>::removeAll): Deleted.
(WTF::minCapacity>::removeAllMatching): Deleted.
(WTF::minCapacity>::reverse): Deleted.
(WTF::minCapacity>::map const): Deleted.
(WTF::minCapacity>::releaseBuffer): Deleted.
(WTF::minCapacity>::checkConsistency): Deleted.
(WTF::minCapacity>::isolatedCopy const): Deleted.

  • wtf/text/CString.cpp:

(WTF::CStringBuffer::createUninitialized):

  • wtf/text/CString.h:
  • wtf/text/StringBuffer.cpp: Copied from Source/JavaScriptCore/bytecode/InstructionStream.cpp.
  • wtf/text/StringBuffer.h:

(WTF::StringBuffer::StringBuffer):
(WTF::StringBuffer::~StringBuffer):
(WTF::StringBuffer::resize):
(WTF::StringBuffer::release):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::destroy):
(WTF::StringImpl::createUninitializedInternalNonEmpty):
(WTF::StringImpl::reallocateInternal):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createSubstringSharingImpl):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):

  • wtf/text/cf/StringImplCF.cpp:

(WTF::StringWrapperCFAllocator::allocate):
(WTF::StringWrapperCFAllocator::reallocate):
(WTF::StringWrapperCFAllocator::deallocate):

5:05 PM Changeset in webkit [253986] by aestes@apple.com
  • 11 edits
    2 adds in trunk

[Payment Request] Perform payment method data IDL conversion in the PaymentRequest constructor
​https://bugs.webkit.org/show_bug.cgi?id=199225
<rdar://problem/52217847>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Imported test web-platform-tests/payment-request/constructor_convert_method_data.https.html
using Tools/Scripts/import-w3c-tests.

  • web-platform-tests/payment-request/constructor_convert_method_data.https-expected.txt: Added.
  • web-platform-tests/payment-request/constructor_convert_method_data.https.html: Added.
  • web-platform-tests/payment-request/w3c-import.log:

Source/WebCore:

Implemented support for validating payment method data during Payment Request construction.
IDL conversion errors for payment method data will now trigger an exception in the
PaymentRequest constructor rather than being deferred to the show() method.

Payment Request specified this change in <​https://github.com/w3c/payment-request/pull/829>.

Test: imported/w3c/web-platform-tests/payment-request/constructor_convert_method_data.https.html

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::convertAndValidate): Moved the logic for converting a JSValue to an
ApplePayRequest IDL type from ApplePayPaymentHandler::convertData to here.
(WebCore::ApplePayPaymentHandler::validateData): Added. Checks that the specified JSValue is
a valid ApplePayRequest, throwing an exception if not.
(WebCore::ApplePayPaymentHandler::convertData): Changed to use convertAndValidate to convert
from a JSValue to an ApplePayRequest.

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
  • Modules/paymentrequest/PaymentHandler.cpp:

(WebCore::PaymentHandler::validateData): Added. Calls ApplePayPaymentHandler::validateData
if Apple Pay handles the specified identifier.

  • Modules/paymentrequest/PaymentHandler.h:
  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::parse): Moved up to be callable by PaymentRequest::create.
(WebCore::PaymentRequest::create): Validated that serializedData can be converted to a valid
ApplePayRequest, throwing an exception if not.

LayoutTests:

  • http/tests/ssl/applepay/PaymentRequest.https-expected.txt:
  • http/tests/ssl/applepay/PaymentRequest.https.html: Changed some tests to expect exceptions

from the constructor rather than promise rejections after calling show(). Removed a bogus
test for applicationData. Cleaned up numerous tests by moving setup code to the correct
location.

4:15 PM Changeset in webkit [253985] by Alan Bujtas
  • 6 edits in trunk/Source/WebCore

[LFC][Integration] Fix failing text-indent cases when the IFC root is an anonymous box
​https://bugs.webkit.org/show_bug.cgi?id=205693
<rdar://problem/58284277>

Reviewed by Antti Koivisto.

During text-indent computation we would normally check if the IFC root is anonymous and if so,
whether it's the first child of its parent element.
e.g. <div><div>text</div>this text is wrapped inside an anonymous renderer</div>
The IFC root of the "this text.." content is an anonymous container and it is not
the first child of its parent renderer.
However in the LFC integration case, we can't go beyond the IFC root and check for parent-child status.

  • layout/LayoutState.h:

(WebCore::Layout::LayoutState::isIntegratedRootBoxFirstChild const):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::constraintsForLine):

  • layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isAnonymous const):

  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::buildLayoutTreeForIntegration):
(WebCore::Layout::LayoutTreeContent::setRootIsFirstChild):
(WebCore::Layout::LayoutTreeContent::isRootFirstChild const):
(WebCore::Layout::TreeBuilder::createLayoutBox):

  • layout/layouttree/LayoutTreeBuilder.h:
3:28 PM Changeset in webkit [253984] by Chris Dumez
  • 13 edits
    1 copy
    5 adds in trunk

[iOS] Replace "unexpectedly resumed" observer with RunningBoard suspendible assertions
​https://bugs.webkit.org/show_bug.cgi?id=205687
<rdar://problem/57890246>

Reviewed by Tim Horton.

Adopt new RunningBoard process assertion to indicate that WebContent processes depend on their
UIProcess (and therefore, the UIProcess must be running if the WebContent process is). This
replaces our "Unexpectedly resumed" assertion which was causing unexpected terminations in some
cases.

  • Configurations/WebKit.xcconfig:
  • Platform/spi/ios/RunningBoardServicesSPI.h: Added.
  • Scripts/process-entitlements.sh:
  • Shared/DependencyProcessAssertion.cpp: Added.

(WebKit::DependencyProcessAssertion::DependencyProcessAssertion):
(WebKit::DependencyProcessAssertion::~DependencyProcessAssertion):

  • Shared/DependencyProcessAssertion.h: Added.
  • Shared/ios/DependencyProcessAssertionIOS.mm: Added.

(WebKit::DependencyProcessAssertion::DependencyProcessAssertion):
(WebKit::DependencyProcessAssertion::~DependencyProcessAssertion):

  • Sources.txt:
  • SourcesCocoa.txt:
  • UIProcess/Cocoa/WebProcessProxyCocoa.mm:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebProcessProxy.messages.in:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection):

  • WebProcess/WebProcess.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:
2:35 PM Changeset in webkit [253983] by dino@apple.com
  • 2 edits in trunk/Source/WTF

REGRESSION(r253926): Crash at libANGLE-shared.dylib: gl::LogMessage::~LogMessage
​https://bugs.webkit.org/show_bug.cgi?id=205690
rdar://58279401

Reviewed by Eric Carlson.

Only enable ANGLE for iOS hardware while we investigate this fatal error.

  • wtf/Platform.h:
1:58 PM Changeset in webkit [253982] by ysuzuki@apple.com
  • 10 edits
    1 add in trunk

REGRESSION (r253867): Six test262 tests broken
​https://bugs.webkit.org/show_bug.cgi?id=205583

Reviewed by Mark Lam.

JSTests:

  • stress/bound-function-empty-name.js: Added.

(shouldBe):

Source/JavaScriptCore:

If a function has empty name, a bound function should have "bound " name.
But Intl prototypes' bound functions are exceptions: these JSBoundFunctions have empty name.
In this patch, we pass nullptr for the JSBoundFunction::create's nameMayBeNull parameter of Intl prototypes' bound functions,
to generate empty string name for these bound functions instead of "bound "[1].
This fixes test262 failures.

[1]: ​https://tc39.es/ecma402/#sec-collator-compare-functions

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototypeGetterCompare):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::visitChildren):

  • runtime/JSBoundFunction.h:
  • runtime/JSFunction.cpp:

(JSC::JSFunction::reifyLazyBoundNameIfNeeded):

  • runtime/SmallStrings.cpp:

(JSC::SmallStrings::initializeCommonStrings):

  • runtime/SmallStrings.h:

(JSC::SmallStrings::boundPrefixString const):

1:43 PM Changeset in webkit [253981] by Keith Rollin
  • 2 edits in trunk/Source/WebKit

Reformat WebProcessCache logging
​https://bugs.webkit.org/show_bug.cgi?id=205683
<rdar://problem/58269352>

Reviewed by Alex Christensen.

Update the format used by WebProcessCache in its RELEASE_LOG logging.
Use the format used by WebPageProxy and NetworkResourceLoader, which
is generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x1145ed208 - WebProcessCache::canCacheProcess(): Not caching process 83671 because it does not have an associated registrable domain

becomes:

0x1145ed208 - [PID=83671] WebProcessCache::canCacheProcess: Not caching process because it does not have an associated registrable domain

No new tests - no added or changed functionality.

  • UIProcess/WebProcessCache.cpp:

(WebKit::WebProcessCache::canCacheProcess const):
(WebKit::WebProcessCache::addProcessIfPossible):
(WebKit::WebProcessCache::addProcess):
(WebKit::WebProcessCache::takeProcess):
(WebKit::WebProcessCache::updateCapacity):
(WebKit::WebProcessCache::clear):
(WebKit::WebProcessCache::clearAllProcessesForSession):
(WebKit::WebProcessCache::setApplicationIsActive):
(WebKit::WebProcessCache::removeProcess):

1:24 PM Changeset in webkit [253980] by Keith Rollin
  • 3 edits in trunk/Source/WebKit

Reformat ProcessThrottler logging
​https://bugs.webkit.org/show_bug.cgi?id=205679
<rdar://problem/58265958>

Reviewed by Alex Christensen.

Update the format used by ProcessThrottler in its RELEASE_LOG logging.
Use the format used by WebPageProxy and NetworkResourceLoader, which
is generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

[PID: 0] 0x1145ce5e8 - ProcessThrottler::invalidateAllActivities() BEGIN

becomes:

0x1145ce5e8 - [PID: 0] ProcessThrottler::invalidateAllActivities: BEGIN

No new tests - no added or changed functionality.

  • UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::invalidateAllActivities):
(WebKit::ProcessThrottler::setAssertionState):
(WebKit::ProcessThrottler::updateAssertionIfNeeded):
(WebKit::ProcessThrottler::didConnectToProcess):
(WebKit::ProcessThrottler::prepareToSuspendTimeoutTimerFired):
(WebKit::ProcessThrottler::processReadyToSuspend):
(WebKit::ProcessThrottler::sendPrepareToSuspendIPC):
(WebKit::ProcessThrottler::uiAssertionWillExpireImminently):

  • UIProcess/ProcessThrottler.h:

(WebKit::ProcessThrottler::Activity::Activity):
(WebKit::ProcessThrottler::Activity::invalidate):

1:21 PM Changeset in webkit [253979] by Keith Rollin
  • 2 edits in trunk/Source/WebKit

Reformat WebResourceLoader logging
​https://bugs.webkit.org/show_bug.cgi?id=205680
<rdar://problem/58266105>

Reviewed by Alex Christensen.

Update the format used by WebResourceLoader in its RELEASE_LOG
logging. Use the format used by WebPageProxy and
NetworkResourceLoader, which is generally of the form:

<object-address> - [<values that help thread together operations>] <class>::<method>: <message and other useful values>

So, for example:

0x4a1dbcb58 - WebResourceLoader::didFinishResourceLoad: (webPageID=15, frameID=3, resourceID=1, length=212132)

becomes:

0x4a1dbcb58 - [webPageID=15, frameID=3, resourceID=1] WebResourceLoader::didFinishResourceLoad: (length=212132)

No new tests - no added or changed functionality.

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::serviceWorkerDidNotHandle):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didBlockAuthenticationChallenge):
(WebKit::WebResourceLoader::stopLoadingAfterXFrameOptionsOrContentSecurityPolicyDenied):
(WebKit::WebResourceLoader::didReceiveResource):

1:14 PM Changeset in webkit [253978] by achristensen@apple.com
  • 17 edits in trunk

Add SPI to disable CORS on requests to URLs matching a pattern
​https://bugs.webkit.org/show_bug.cgi?id=205534
<rdar://problem/58011337>

Reviewed by Chris Dumez.

Source/WebCore:

This should allow us to remove the layering violation in LegacySchemeRegistry::isUserExtensionScheme
and fix the bug in the radar. The SPI is exercised by a new API test.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

  • page/Page.cpp:

(WebCore::m_deviceOrientationUpdateProvider):
(WebCore::Page::shouldDisableCorsForRequestTo const):

  • page/Page.h:
  • page/PageConfiguration.h:
  • platform/LegacySchemeRegistry.cpp:

(WebCore::LegacySchemeRegistry::isUserExtensionScheme):

Source/WebKit:

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::copy const):
(API::PageConfiguration::PageConfiguration): Deleted.
(API::PageConfiguration::~PageConfiguration): Deleted.

  • UIProcess/API/APIPageConfiguration.h:

(API::PageConfiguration::corsDisablingPatterns const):
(API::PageConfiguration::setCORSDisablingPatterns):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _corsDisablingPatterns]):
(-[WKWebViewConfiguration _setCORSDisablingPatterns:]):

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
  • UIProcess/WebPageProxy.cpp:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_overriddenMediaType):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
12:53 PM Changeset in webkit [253977] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC][IFC] Text-indent shrinks the available horizontal space
​https://bugs.webkit.org/show_bug.cgi?id=205688
<rdar://problem/58279938>

Reviewed by Antti Koivisto.

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::constraintsForLine):

12:50 PM Changeset in webkit [253976] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening for iPad

  • platform/ipad/TestExpectations:

Skip this layout test on iPad, where the zoom scale is not expected to change after focusing a text field.

11:31 AM Changeset in webkit [253975] by weinig@apple.com
  • 31 edits in trunk

Simplify StringBuilder API/align with makeString by removing appendFixed* functions and using FormatNumber struct instead
​https://bugs.webkit.org/show_bug.cgi?id=205671

Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

  • runtime/Options.cpp:

(JSC::OptionReader::Option::dump const):
Replace all uses of builder.appendFixedPrecisionNumber(...) with builder.append(FormattedNumber::fixedPrecision(...)).

Source/WebCore:

  • css/CSSFontVariationValue.cpp:
  • css/CSSKeyframeRule.cpp:
  • css/CSSTimingFunctionValue.cpp:
  • css/parser/CSSParserToken.cpp:
  • html/HTMLImageElement.cpp:
  • page/scrolling/AxisScrollSnapOffsets.cpp:
  • platform/graphics/Color.cpp:
  • platform/graphics/ExtendedColor.cpp:
  • platform/graphics/ca/win/PlatformCALayerWin.cpp:
  • platform/graphics/freetype/FontCacheFreeType.cpp:
  • svg/SVGNumberList.h:
  • svg/SVGPathStringBuilder.cpp:
  • svg/SVGPointList.h:
  • svg/SVGTransformValue.h:
  • svg/properties/SVGPropertyTraits.h:
  • testing/Internals.cpp:

Replace all uses of builder.appendFixedPrecisionNumber(...) with builder.append(FormattedNumber::fixedPrecision(...))
and builder.appendFixedWidthNumber(...) with with builder.append(FormattedNumber::fixedWidth(...))

Source/WebKit:

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::dumpContentsToFile):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::asJSON const):

  • Shared/Gamepad/GamepadData.cpp:

(WebKit::GamepadData::loggingString const):
Replace all uses of builder.appendFixedPrecisionNumber(...) with builder.append(FormattedNumber::fixedPrecision(...)).

Source/WTF:

In an ongoing attempt to simplify the StringBuilder interface and unify it's functionality with makeString,
this change removes appendFixedPrecisionNumber() and appendFixedWidthNumber(), replacing their uses
with direct calls to append(), using a FormattedNumber object to direct it to the appropriate StringTypeAdapter.

  • wtf/text/StringBuilder.h:
  • wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::appendFixedPrecisionNumber): Deleted.
(WTF::StringBuilder::appendFixedWidthNumber): Deleted.
Remove StringBuilder::appendFixedPrecisionNumber() and StringBuilder::appendFixedWidthNumber(). The same functionality
is available and more flexible by passing FormattedNumbers to the variadic append() function.

  • wtf/text/TextStream.cpp:

(WTF::TextStream::operator<<):

  • wtf/MediaTime.cpp:

(WTF::MediaTime::toString const):
Replace all uses of builder.appendFixedPrecisionNumber(...) with builder.append(FormattedNumber::fixedPrecision(...))
and builder.appendFixedWidthNumber(...) with with builder.append(FormattedNumber::fixedWidth(...))

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

Replace all uses of builder.appendFixedPrecisionNumber(...) with builder.append(FormattedNumber::fixedPrecision(...)).

1:04 AM Changeset in webkit [253974] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit

[GTK] Make ondemand hardware acceleration policy never leave AC mode
​https://bugs.webkit.org/show_bug.cgi?id=205558

Reviewed by Sergio Villar Senin.

We still enter AC mode on demand but we never leave it for the same drawing area. This avoids scrolling
performance problems with some websites that start small accelerated animation while scrolling (like WebKit
bugzilla review tool), due to constant enter/leave AC mode.

  • UIProcess/API/glib/WebKitSettings.cpp:

(webkit_settings_class_init): Update API documentation.

  • WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:

(WebKit::DrawingAreaCoordinatedGraphics::enterAcceleratedCompositingMode): Force AC mode the first time we enter it.

12:08 AM Changeset in webkit [253973] by jh718.park@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Remove the build warning below since r253939.
warning: no return statement in function returning non-void [-Wreturn-type]

No new tests, no behavioral changes.

Patch by Joonghun Park <​jh718.park@samsung.com> on 2020-01-01

  • platform/graphics/texmap/GraphicsContext3DTextureMapper.cpp:

(WebCore::GraphicsContext3D::mapBufferRange):

Note: See TracTimeline for information about the timeline view.