Context Navigation

← Previous Period
Next Period →

Timeline

Apr 9, 2020:

11:55 PM Changeset in webkit [259850] by Peng Liu

4 edits in trunk

REGRESSION: (r258434) [ Mac WK1 ] media/track/track-css-user-override.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=210134

Reviewed by Eric Carlson.

Source/WebCore:

Call captionPreferencesChanged() directly in CaptionUserPreferences::setCaptionsStyleSheetOverride().

page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::setCaptionsStyleSheetOverride):

LayoutTests:

Make the test reliable by replacing the timer and testExpected based approach
with the approach based on testExpectedEventually. Also remove unnecessary code.

media/track/track-css-user-override.html:

11:48 PM Changeset in webkit [259849] by ysuzuki@apple.com

3 edits in trunk/Source/JavaScriptCore

[JSC] Use UnconditionalWriteBarrier in Baseline effectively to reduce code size
https://bugs.webkit.org/show_bug.cgi?id=209395

Reviewed by Tadeu Zagallo.

In put/delete we always need to emit write-barrier if the base is a cell since IC can write things (writing new StructureID etc.).
We should use emitWriteBarrier with UnconditionalWriteBarrier to remove unnecessary branch.

jit/JITPropertyAccess.cpp:

(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_del_by_id):
(JSC::JIT::emit_op_del_by_val):
(JSC::JIT::emit_op_put_by_id):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitPutByValWithCachedId):
(JSC::JIT::emit_op_put_by_id):

11:25 PM Changeset in webkit [259848] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Fix bad tests in testmasm's testCagePreservesPACFailureBit().
https://bugs.webkit.org/show_bug.cgi?id=210314
<rdar://problem/61556785>

Reviewed by Yusuke Suzuki.

Some of these tests will crash when validated untagging is enabled.

assembler/testmasm.cpp:

(JSC::testCagePreservesPACFailureBit):

10:48 PM Changeset in webkit [259847] by ddkilzer@apple.com

12 edits in trunk/Source/WebKit

Add WARN_UNUSED_RETURN to decode methods in Source/WebKit/Platform/IPC
<https://webkit.org/b/210316>

Reviewed by Alex Christensen.

Platform/IPC/ArgumentCoder.h:
Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<WallTime>::decode):
(IPC::ArgumentCoder<AtomString>::decode):
(IPC::ArgumentCoder<CString>::decode):
(IPC::ArgumentCoder<String>::decode):
(IPC::ArgumentCoder<SHA1::Digest>::decode):
(IPC::ArgumentCoder<audit_token_t>::decode):
(IPC::ArgumentCoder<Monostate>::decode):

Platform/IPC/ArgumentCoders.h:

(IPC::SimpleArgumentCoder::decode):
(IPC::ArgumentCoder<OptionSet<T>>::decode):
(IPC::ArgumentCoder<Optional<T>>::decode):
(IPC::ArgumentCoder<Box<T>>::decode):
(IPC::TupleDecoderImpl::decode):
(IPC::TupleDecoderImpl<Type>::decode):
(IPC::TupleDecoder::decode):
(IPC::TupleDecoder<0>::decode):
(IPC::VariantCoder::decode):

Platform/IPC/Attachment.h:
Platform/IPC/DataReference.h:
Platform/IPC/Decoder.h:

(IPC::Decoder::decodeEnum):

Platform/IPC/FormDataReference.h:

(IPC::FormDataReference::decode):

Platform/IPC/ImageDataReference.h:

(IPC::ImageDataReference::decode):

Platform/IPC/SharedBufferDataReference.h:

(IPC::SharedBufferDataReference::decode):

Platform/IPC/StringReference.h:
Platform/IPC/cocoa/MachPort.h:

(IPC::MachPort::decode):

10:22 PM Changeset in webkit [259846] by cathiechen

16 edits in trunk/Source/WebCore

Fix up code style for scroll animation
https://bugs.webkit.org/show_bug.cgi?id=210171

Reviewed by Simon Fraser.

Use AnimatedScroll instead of bool to indicate animated or not.
Remove parameter ScrollRectToVisibleOptions, the autoscroll status is available from EventHandler.
In order to keep consistent, use RenderLayer::setScrollPosition instead of RenderLayer::scrollToPosition.
Add AnimatedScroll parameter to ScrollView::setContentsScrollPosition, then the scroll animation

can be dealt in FrameView::setScrollPosition.

In ScrollView::setScrollPosition, the scroll animation should be cancled before return.

dom/Element.cpp: Use AnimatedScroll instead of bool.

(WebCore::Element::scrollTo):
(WebCore::Element::setScrollLeft):
(WebCore::Element::setScrollTop):

page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollTo const): No need to call scrollToOffsetWithAnimation here.

page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):

page/FrameView.h:
platform/ScrollTypes.h: Add AnimatedScroll.
platform/ScrollView.cpp:

(WebCore::ScrollView::setContentsScrollPosition): Add parameter AnimatedScroll.
(WebCore::ScrollView::setScrollPosition): Cancel the scroll animation before return.

platform/ScrollView.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
(WebCore::RenderBox::setScrollPosition):

rendering/RenderBox.h:
rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollToXPosition):
(WebCore::RenderLayer::scrollToYPosition):
(WebCore::RenderLayer::setScrollPosition):
(WebCore::RenderLayer::scrollRectToVisible): Remove AutoscrollStatus.
(WebCore::RenderLayer::autoscroll):
(WebCore::RenderLayer::scrollToPosition): Deleted. Use setScrollPosition instead.

rendering/RenderLayer.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setScrollLeft):
(WebCore::RenderListBox::setScrollTop):

rendering/RenderListBox.h:
rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::setScrollLeft):
(WebCore::RenderTextControlSingleLine::setScrollTop):

rendering/RenderTextControlSingleLine.h:

9:53 PM Changeset in webkit [259845] by commit-queue@webkit.org

23 edits in trunk/Source

IPC serialization of enums should serialize std::underlying_type instead of uint64_t
https://bugs.webkit.org/show_bug.cgi?id=210228

Patch by Alex Christensen <achristensen@webkit.org> on 2020-04-09
Reviewed by Chris Dumez and Darin Adler.

Source/WebCore:

No change in behavior, other than less memory and time spent in IPC code.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContextStateChange::dump const):

platform/graphics/GraphicsContext.h:
platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::PlatformCALayer::drawRepaintIndicator):

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformTextDrawingMode):

platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::shouldUseLetterpressEffect):
(WebCore::FontCascade::drawGlyphs):

platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::drawText):

rendering/TextPaintStyle.cpp:

(WebCore::updateGraphicsContext):

rendering/TextPainter.cpp:

(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):

rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::applyResource):

rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::applyResource):

rendering/svg/RenderSVGResourceSolidColor.cpp:

(WebCore::RenderSVGResourceSolidColor::applyResource):

Source/WebKit:

Platform/IPC/Decoder.h:

(IPC::Decoder::decode):
(IPC::Decoder::operator>>):
(IPC::Decoder::decodeEnum):

Platform/IPC/Encoder.h:
Shared/cf/ArgumentCodersCF.cpp:

(IPC::encode):
(IPC::decode):

8:39 PM Changeset in webkit [259844] by cathiechen

4 edits
4 adds in trunk/LayoutTests

Import test for programmatic scrolling scrollend event
https://bugs.webkit.org/show_bug.cgi?id=210281

Reviewed by Frédéric Wang.

LayoutTests/imported/w3c:

Import test cases.

web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll-expected.txt: Added.
web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-programmatic-scroll.html: Added.
web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView-expected.txt: Added.
web-platform-tests/dom/events/scrolling/scrollend-event-fired-for-scrollIntoView.html: Added.
web-platform-tests/dom/events/scrolling/w3c-import.log:

LayoutTests:

tests-options.json:

7:11 PM Changeset in webkit [259843] by Darin Adler

186 edits
2 moves
1 add in trunk

[Cocoa] Simplify NSArray, NSDictionary, and NSNumber idioms throughout WebKit
https://bugs.webkit.org/show_bug.cgi?id=210138

Reviewed by Alex Christensen.

Source/JavaScriptCore:

API/JSValue.mm:

(valueToObjectWithoutCopy): Use @().
(valueToNumber): Ditto.

API/tests/testapi.mm:

(-[TestObject callback:]): Use @[], @(), and @{}.
(-[TextXYZ click]): Ditto.
(testObjectiveCAPIMain): Ditto.

Source/WebCore:

Added createNSArray and makeVector.
Use createNSArray and makeVector<String> in many places where we convert between NSArray and Vector, replacing multiple existing functions that were doing the same job before; later can use them even more.
Use @[] many places where we create an autoreleased NSArray.
Use @{} many places where we create an autoreleased NSDictionary.
Use @() many places where we create an autoreleased NSNumber.

PlatformMac.cmake: Moved Float/IntRectMac.mm to Float/IntRectCocoa.mm.
SourcesCocoa.txt: Ditto.
WebCore.xcodeproj/project.pbxproj: Ditto.

accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(AXAttributeStringSetBlockquoteLevel): Use @().
(AXAttributeStringSetHeadingLevel): Use @().
(-[WebAccessibilityObjectWrapper textMarkerRangeForSelection]): Use @[].
(-[WebAccessibilityObjectWrapper _stringFromStartMarker:toEndMarker:attributed:]): Use @[].
(-[WebAccessibilityObjectWrapper elementsForRange:]): Use @[].
(-[WebAccessibilityObjectWrapper textMarkersForRange:]): Use @[].

accessibility/mac/AXObjectCacheMac.mm:

(WebCore::textReplacementChangeDictionary): Use @().

accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(makeVectorElement): Aded overload for AccessibilitySearchKey.
(accessibilitySearchCriteriaForSearchPredicateParameterizedAttribute):
Use makeVector<AccessibilitySearchKey>.

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(accessibilityTextCriteriaForParameterizedAttribute): Use makeVector<String>.
(accessibilitySearchTextCriteriaForParameterizedAttribute): Use makeVector<String>.
(AXAttributeStringSetStyle): Use @().
(AXAttributeStringSetBlockquoteLevel): Use @().
(AXAttributeStringSetHeadingLevel): Use @().
(-[WebAccessibilityObjectWrapper accessibilityActionNames]): Use @[].
(convertStringsToNSArray): Deleted.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
Use @(), @[], and createNSArray.
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
Ditto.

bridge/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
Use @().

editing/cocoa/AlternativeTextUIController.mm:

(WebCore::AlternativeTextUIController::alternativesForContext):
Use makeVector<String>.

editing/cocoa/HTMLConverter.mm:

(defaultParagraphStyle): Use @[].
(HTMLConverter::computedAttributesForElement): Use @().
(HTMLConverter::_processMetaElementWithName): Use @().
(HTMLConverter::_addTableForElement): Use @().

page/ios/FrameIOS.mm:

(WebCore::Frame::interpretationsForCurrentRoot const): Use @[].

platform/cocoa/MIMETypeRegistryCocoa.mm:

(WebCore::MIMETypeRegistry::getExtensionsForMIMEType): Use makeVector<String>.

platform/graphics/FloatRect.h: Added makeNSArrayElement overload so we can

convert Vector<FloatRect> into NSArray<NSValue>.

platform/graphics/IntRect.h: Similarly for IntRect.

platform/graphics/avfoundation/MediaSelectionGroupAVFObjC.mm:

(WebCore::MediaSelectionGroupAVFObjC::updateOptions): Use createNSArray.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::mediaDescriptionForKind): Use @[].
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Use @().
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Use @().
(WebCore::MediaPlayerPrivateAVFoundationObjC::checkPlayability): Use @[].
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Use @{} and @().

platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:

(WebCore::PlatformCAAnimationCocoa::valueFunction const):
(WebCore::PlatformCAAnimationCocoa::setFromValue):
(WebCore::PlatformCAAnimationCocoa::copyFromValueFrom):
(WebCore::PlatformCAAnimationCocoa::setToValue):
(WebCore::PlatformCAAnimationCocoa::copyToValueFrom):
(WebCore::PlatformCAAnimationCocoa::setValues):
(WebCore::PlatformCAAnimationCocoa::copyValuesFrom):
(WebCore::PlatformCAAnimationCocoa::setKeyTimes):
(WebCore::PlatformCAAnimationCocoa::copyKeyTimesFrom):
(WebCore::PlatformCAAnimationCocoa::setTimingFunctions):
(WebCore::PlatformCAAnimationCocoa::copyTimingFunctionsFrom):
Use @(), @[], modern for loops, auto, and allocate with capacity.

platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:

(WebCore::PlatformCAFilters::filterValueForOperation): Use @().

platform/graphics/cocoa/FloatRectCocoa.mm: Moved from mac/FloatRectMac.mm.

(WebCore::makeNSArrayElement): Added so we can convert Vector<FloatRect>
into NSArray<NSValue>.

platform/graphics/cocoa/IntRectCocoa.mm: Moved from mac/IntRectMac.mm.

(WebCore::makeNSArrayElement): Similarly for IntRect.
(WebCore::enclosingIntRect): Use clampTo to be consistent with what
enclosingIntRect(FloatRect) does (while fixing check-webkit-style complaint).

platform/graphics/cocoa/WebGLLayer.mm:

(-[WebGLLayer display]): Add WebCore namespace prefix; needed depending on
how sources get unified (and was affecting my local build when it temporarily
had an additional source file).
(-[WebGLLayer allocateIOSurfaceBackingStoreWithSize:usingAlpha:]): Ditto.
(-[WebGLLayer bindFramebufferToNextAvailableSurface]): Ditto.

platform/graphics/ios/FontCacheIOS.mm:

(WebCore::systemFontModificationAttributes): Use @().

platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::getTypes): Use makeVector<String>.
(WebCore::createItemProviderRegistrationList): Use createNSArray.
(WebCore::PlatformPasteboard::updateSupportedTypeIdentifiers): Use createNSArray.

platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderPasteboard setItemProviders:]): Use @[].

platform/ios/wak/WAKView.mm:

(-[WAKView subviews]): Dittto.

platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::getTypes): Use makeVector<String>.
(WebCore::PlatformPasteboard::getPathnamesForType const): Use makeVector<String>.
(WebCore::PlatformPasteboard::addTypes): Use makeVector<String>.
(WebCore::PlatformPasteboard::setTypes): Use makeVector<String>.

platform/mac/StringUtilities.h: Removed

webCoreStringVectorFromNSStringArray, replaced by makeVector<String>

platform/mac/StringUtilities.mm:

(WebCore::webCoreStringVectorFromNSStringArray): Deleted.

platform/mac/WebCoreNSURLExtras.mm: Removed unneeded include.

platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:

(WebCore::MediaRecorderPrivateWriter::setVideoInput): Use @().

platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setupCaptureSession): Use @().

platform/network/cocoa/CookieCocoa.mm:

(WebCore::Cookie::operator NSHTTPCookie * _Nullable const): Use @().

platform/network/cocoa/NetworkStorageSessionCocoa.mm:

(WebCore::NetworkStorageSession::setCookiesFromDOM const): Use @{}.

platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): Use @YES/@NO.

Source/WebKit:

NetworkProcess/cocoa/NetworkSessionCocoa.mm: Remove uneeded include.
Platform/mac/StringUtilities.mm: Ditto.

PluginProcess/mac/PluginProcessMac.mm:

(WebKit::replacedNSConcreteTask_launch): Use makeVector<String>.
(WebKit::replacedNSWorkspace_launchApplicationAtURL_options_configuration_error):
Ditto.

Shared/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toSupportedNetworks): Deleted.
(WebKit::WebPaymentCoordinatorProxy::platformPaymentRequest): Use createNSArray.

Shared/mac/PasteboardTypes.mm:

(WebKit::PasteboardTypes::forEditing): Use @[].
(WebKit::PasteboardTypes::forURL): Ditto.
(WebKit::PasteboardTypes::forImages): Ditto.
(WebKit::PasteboardTypes::forImagesWithArchive): Ditto.
(WebKit::PasteboardTypes::forSelection): Ditto.

UIProcess/API/Cocoa/WKContentRuleListStore.mm:

(-[WKContentRuleListStore getAvailableContentRuleListIdentifiers:]): Use createNSArray.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _getActivePagesOriginsInWebProcessForTesting:completionHandler:]): Ditto.

UIProcess/API/Cocoa/WKUserScript.mm:

(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:userContentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:contentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:contentWorld:]):
(-[WKUserScript _initWithSource:injectionTime:forMainFrameOnly:legacyWhitelist:legacyBlacklist:associatedURL:contentWorld:deferRunningUntilNotification:]):
Use makeVector<String>.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setupPageConfiguration:]): Use makeVector<String>.

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _corsDisablingPatterns]): Use createNSArray.
(-[WKWebViewConfiguration _setCORSDisablingPatterns:]): Use makeVector<String>.

UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _contentsOfUserInterfaceItem:]): Use @().

UIProcess/API/Cocoa/_WKContentRuleListAction.mm:

(-[_WKContentRuleListAction notifications]): Use createNSArray.

UIProcess/API/Cocoa/_WKCustomHeaderFields.mm:

(-[_WKCustomHeaderFields thirdPartyDomains]): Use createNSArray.
(-[_WKCustomHeaderFields setThirdPartyDomains:]): Use makeVector<String>.

UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration cachePartitionedURLSchemes]): Use createNSArray.
(-[_WKProcessPoolConfiguration setCachePartitionedURLSchemes:]): Use makeVector<String>.
(-[_WKProcessPoolConfiguration alwaysRevalidatedURLSchemes]): Use createNSArray.
(-[_WKProcessPoolConfiguration setAlwaysRevalidatedURLSchemes:]): Use makeVector<String>.

UIProcess/API/Cocoa/_WKUserContentWorldInternal.h:

(API::toStringVector): Deleted.

UIProcess/API/Cocoa/_WKUserStyleSheet.mm:

(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):
Use makeVector<String>.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::accessibilityAttributeValue): Use @[].
(WebKit::WebViewImpl::performDragOperation): Use makeVector<String>.
(WebKit::WebViewImpl::namesOfPromisedFilesDroppedAtDestination): Use @[].
(WebKit::WebViewImpl::collectKeyboardLayoutCommandsForEvent): Use @[].

UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::launchProcess): Use createNSArray.
(WebKit::isJavaUpdaterURL): Use @[].
(WebKit::PluginProcessProxy::launchApplicationAtURL): Use @{} and createNSArray.
(WebKit::isSilverlightPreferencesURL): Use @[].

UIProcess/WebAuthentication/Cocoa/HidService.mm:

(WebKit::HidService::HidService): Use @() and fixed an over-release mistake.
This code was doing adoptNS on the result of +[NSNumberWithInt:], which is incorrect.

UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::getAttestation const): Use @[].

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textStylingAtPosition:inDirection:]): Use @().
(-[WKContentView requestRectsToEvadeForSelectionCommandsWithCompletionHandler:]): Use createNSArray.
(-[WKContentView _itemsForBeginningOrAddingToSessionWithRegistrationLists:stagedDragSource:]):
Fixed a wasteful call to autorelease where we are adding an item to a dictionary. Calling get
is more efficient and still correct.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel imagePickerController:didFinishPickingMediaWithInfo:]): Use @[].

UIProcess/ios/forms/WKFormColorPicker.mm:

(-[WKColorMatrixView initWithFrame:colorMatrix:]): Removed uneeded RetainPtr
local variable.

UIProcess/mac/CorrectionPanel.mm:

(WebKit::CorrectionPanel::show): Use createNSArray.

UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::updateSpellingUIWithGrammarString): Use createNSArray.
(WebKit::TextChecker::getGuessesForWord): Use makeVector<String>.

UIProcess/mac/WKPrintingView.mm:

(-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]): Use @().

UIProcess/mac/WKTextFinderClient.mm:

(arrayFromRects): Deleted.
(-[WKTextFinderClient didFindStringMatchesWithRects:didWrapAround:]): Use createNSArray.

UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:

(-[WKDataListSuggestionsController notifyAccessibilityClients:]): Use @{}
and fix a bug where this was creating a backwards dictionary. So this never
could have been working before, making me wonder how we test it.

UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::searchTheWeb): Use @[].

WebProcess/InjectedBundle/API/mac/WKDOMInternals.h: Removed toNSArray.
WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::toNSArray): Deleted.

WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:

(-[WKDOMNode textRects]): Use createNSArray.

WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange textRects]): Ditto.

WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::setBundleParameter): Use @{}.

WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::makeRenderLayer): Use @[].

WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::writeItemsToPasteboard): Use makeVector<String>.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationDidEnterBackground): Use @().

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::suspendPainting): Use @{}.
(WebKit::TiledCoreAnimationDrawingArea::resumePainting): Use @{}.

WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:

Removed an unneeded include.

WebProcess/WebPage/mac/WKAccessibilityWebPageObjectMac.mm: Ditto.

(-[WKAccessibilityWebPageObject accessibilityActionNames]): Use @[].
(-[WKAccessibilityWebPageObject accessibilityChildren]): Use @[].

WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::getActivePagesOriginsForTesting): Use makeVector<String>.

Source/WebKitLegacy/ios:

WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::runOpenPanel): Use createNSArray.

WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
Use createNSArray.

WebCoreSupport/WebVisiblePositionInternal.h:

Added #if so that this correctly doesn't compile anything on Mac.

WebView/WebPDFViewIOS.mm:

(+[WebPDFView supportedMIMETypes]): Use @[].

Source/WebKitLegacy/mac:

DOM/DOM.mm:

(kit): Deleted overload that takes Vector<IntRect>.
(-[DOMNode textRects]): Use createNSArray.
(-[DOMRange textRects]): Ditto.

DOM/ExceptionHandlers.mm:

(raiseDOMErrorException): Use @().

History/WebBackForwardList.mm:

(-[WebBackForwardList dictionaryRepresentation]): Use @{}.

History/WebHistory.mm:

(+[WebHistoryPrivate initialize]): Use @{}.
(-[WebHistory _sendNotification:entries:]): Use @{}.

History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]): Use makeVector<String>.
(-[WebHistoryItem dictionaryRepresentation:]): Use createNSArray and @().

History/WebURLsWithTitles.m:

(+[WebURLsWithTitles arrayWithIFURLsWithTitlesPboardType]): Use @[].
(+[WebURLsWithTitles writeURLs:andTitles:toPasteboard:]): Use @[].

Misc/WebCache.mm:

(+[WebCache statistics]): Use @[], @{}, and @().

Misc/WebCoreStatistics.mm:

(+[WebCoreStatistics memoryStatistics]): Ditto.

Misc/WebKitErrors.m:

(-[NSError _webkit_initWithDomain:code:URL:]): Use @().
(+[NSError _registerWebKitErrors]): Use @().
(-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]): Use @().

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:]): Use @{}.
(-[NSString _web_widthWithFont:]): Use @{}.

Misc/WebNSFileManagerExtras.mm: Removed unneeded include.

Misc/WebNSPasteboardExtras.mm:

(+[NSPasteboard _web_dragTypesForURL]): Use @[].
(-[NSPasteboard _web_writeURL:andTitle:types:]): Use @[].
(+[NSPasteboard _web_setFindPasteboardString:withOwner:]): Use @[].

Misc/WebNSURLExtras.mm: Removed unneeded include.

Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost): Use @{}.

Plugins/Hosted/NetscapePluginHostProxy.mm:

(WKPCIdentifierInfo): Use @().

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray): Use @().

Plugins/Hosted/WebHostedNetscapePluginView.mm: Removed unneeded include.
Plugins/WebBasePluginPackage.mm: Ditto.

Plugins/WebPluginContainerCheck.mm:

(-[WebPluginContainerCheck _actionInformationWithURL:]): Use @{}.

Plugins/WebPluginDatabase.mm:

(+[WebPluginDatabase _defaultPlugInPaths]): Use @[].

Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager databasesWithOrigin:]): Use createNSArray.

WebCoreSupport/CorrectionPanel.mm:

(CorrectionPanel::show): Use createNSArray.

WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::addMessageToConsole): Use @().

WebCoreSupport/WebEditorClient.mm:

(attributesForAttributedStringConversion): Use @().
(WebEditorClient::getGuessesForWord): Use makeVector<String>.

WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::actionDictionary const): Use @().
(kit): Deleted overload that takes Vector<String>.
(pluginView): Use @{}.
(WebFrameLoaderClient::createPlugin): Use createNSArray, @{}, and @().
(WebFrameLoaderClient::createJavaAppletWidget): Use createNSArray.

WebCoreSupport/WebOpenPanelResultListener.mm:

(-[WebOpenPanelResultListener chooseFilenames:]): Use makeVector<String>.
(-[WebOpenPanelResultListener chooseFilename:displayString:iconImage:]): Use @[].
(-[WebOpenPanelResultListener chooseFilenames:displayString:iconImage:]): Use makeVector<String>.

WebCoreSupport/WebSelectionServiceController.mm:

(WebSelectionServiceController::handleSelectionServiceClick):
Comment out an unused argument.

WebView/WebFrame.mm:

(-[WebFrame _rectsForRange:]): Use createNSArrray.
(-[WebFrame _computePageRectsWithPrintScaleFactor:pageSize:]): Use createNSArray and @[].
(-[WebFrame childFrames]): Use @[].

WebView/WebHTMLView.mm:

(+[WebHTMLView _selectionPasteboardTypes]): Use @[].
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Use @[].
(-[WebHTMLView knowsPageRange:]): Use @[].
(-[WebHTMLView accessibilityAttributeValue:]): Use @[].
(-[WebHTMLView copyFont:]): Use @[].
(-[WebHTMLView _interpretKeyEvent:savingCommands:]): Use @[].
(-[WebHTMLView selectionTextRects]): Use createNSArray.
(-[WebHTMLView rectsForTextMatches]): Use createNSArray and @[].

WebView/WebPDFRepresentation.mm: Removed unneeded include.

(+[WebPDFRepresentation postScriptMIMETypes]): Use @[].
(+[WebPDFRepresentation supportedMIMETypes]): Use @[].

WebView/WebPDFView.mm:

(-[WebPDFView elementAtPoint:]): Use @{} and @().
(-[WebPDFView viewState]): Use @().
(-[WebPDFView selectionTextRects]): Use @[].
(-[WebPDFView pasteboardTypesForSelection]): Use @[].
(-[WebPDFView _menuItemsFromPDFKitForEvent:]): Use @().
(-[WebPDFView _openWithFinder:]): Use @{} and @().

WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Use @().
(-[WebPreferences _setUnsignedIntValue:forKey:]): Use @().
(+[WebPreferences _setInitialDefaultTextEncodingToSystemEncoding]): Use @().
(-[WebPreferences setStorageBlockingPolicy:]): Use @{} and @().

WebView/WebScriptDebugger.mm:

(WebScriptDebugger::sourceParsed): Use @().

WebView/WebTextCompletionController.mm:

(-[WebTextCompletionController _placePopupWindow:]): Use @{}.

WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Use makeVector<String>.
(-[WebView _contentsOfUserInterfaceItem:]): Use @().
(toStringVector): Deleted.
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
Use makeVector<String>.
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
Use makeVector<String>.
(-[WebView _elementAtWindowPoint:]): Use @{}.
(-[WebView pasteboardTypesForSelection]): Use @[].
(-[WebView pasteboardTypesForElement:]): Use @[].
(-[WebView rectsForTextMatches]): Use @[].
(-[WebView _searchWithGoogleFromMenu:]): Use @[].
(-[WebView _setFontWhitelist:]): Use makeVector<String>.

Source/WTF:

WTF.xcodeproj/project.pbxproj: Added VectorCocoa.h.
wtf/PlatformMac.cmake: Ditto.

wtf/cocoa/NSURLExtras.mm: Removed unneeded include.
wtf/cocoa/URLCocoa.mm: Ditto.

wtf/cocoa/VectorCocoa.h: Added. Contains createNSArray and makeVector

function templates for converting NSArray to and from Vector.

wtf/text/WTFString.h: Added makeNSArrayElement and makeVectorElement

functions, making createNSArray and makeVector compatible with String.

wtf/text/cocoa/StringCocoa.mm:

(WTF::makeNSArrayElement): Added.
(WTF::makeVectorElement): Added.

Tools:

DumpRenderTree/AccessibilityController.h: Remove use of NotificationHandler

type; it's just "id".

DumpRenderTree/AccessibilityUIElement.cpp:

(convertElementsToObjectArray): Moved this up in the file, removed unneeded
use of JSValueToObject and unused exception argument.
(elementsForRangeCallback): Use convertElementsToObjectArray.
(columnHeadersCallback): Updated for removed exception argument.
(rowHeadersCallback): Ditto.
(uiElementArrayAttributeValueCallback): Ditto.

DumpRenderTree/AccessibilityUIElement.h: Changed to use RetainPtr.

DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:

(createCoreAnimationLayer): Use @{}.

DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::AccessibilityUIElement): Removed some unneeded
code now that we use RetainPtr.
(AccessibilityUIElement::~AccessibilityUIElement): Deleted.
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Use @[].
(AccessibilityUIElement::textMarkerRangeForMarkers): Use @[].
(AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers): Use @[].

DumpRenderTree/ios/TextInputControllerIOS.m:

(-[TextInputController markedRange]): Use @[].

DumpRenderTree/mac/AccessibilityCommonMac.mm:

(searchPredicateParameterizedAttributeForSearchCriteria): Tweak a little.

DumpRenderTree/mac/AccessibilityNotificationHandler.mm:

(-[NSString createJSStringRef]): Deleted. Duplicate of a method already
implemented in anothe file.

DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(makeVectorElement): Added overloads to make both
makeVector<AccessibilityTextMarkerRange> and
makeVector<AccessibilityUIElement> work.
(AccessibilityUIElement::AccessibilityUIElement): Removed some unneeded
code now that we use RetainPtr.
(convertVectorToObjectArray): Removed unneeded use of JSValueToObject
and unneeded exception argument.
(convertNSArrayToVector): Deleted.
(AccessibilityUIElement::getLinkedUIElements): Use
makeVector<AccessibilityUIElement>.
(AccessibilityUIElement::getDocumentLinks): Ditto.
(AccessibilityUIElement::getChildren): Ditto.
(AccessibilityUIElement::getChildrenWithRange): Ditto.
(AccessibilityUIElement::rowHeaders const): Ditto.
(AccessibilityUIElement::columnHeaders const): Ditto.
(AccessibilityUIElement::uiElementArrayAttributeValue const): Ditto.
(AccessibilityUIElement::role): Updated since m_element is a RetainPtr.
(AccessibilityUIElement::subrole): Ditto.
(AccessibilityUIElement::roleDescription): Ditto.
(AccessibilityUIElement::computedRoleString): Ditto.
(AccessibilityUIElement::title): Ditto.
(AccessibilityUIElement::description): Ditto.
(AccessibilityUIElement::orientation const): Ditto.
(AccessibilityUIElement::stringValue): Ditto.
(AccessibilityUIElement::language): Ditto.
(AccessibilityUIElement::helpText const): Ditto.
(AccessibilityUIElement::lineForIndex): Use @().
(AccessibilityUIElement::rangeForLine): Use @().
(AccessibilityUIElement::searchTextWithCriteria): Use
makeVector<AccessibilityTextMarkerRange>.
(AccessibilityUIElement::attributesOfColumnHeaders): Use
makeVector<AccessibilityUIElement>.
(AccessibilityUIElement::attributesOfRowHeaders): Ditto.
(AccessibilityUIElement::attributesOfColumns): Ditto.
(AccessibilityUIElement::attributesOfRows): Ditto.
(AccessibilityUIElement::attributesOfVisibleCells): Ditto.
(AccessibilityUIElement::cellForColumnAndRow): Use @[] and @().
(AccessibilityUIElement::setSelectedChild const): Use @[].
(AccessibilityUIElement::setSelectedChildAtIndex const): Use @[].
(AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions):
Use @{}, @YES, and @NO.
(AccessibilityUIElement::textMarkerRangeForMarkers): Use @[].

DumpRenderTree/mac/DumpRenderTree.mm:

(addTestPluginsToPluginSearchPath): Use @[].
(resetWebViewToConsistentStateBeforeTesting): Use @[].

DumpRenderTree/mac/DumpRenderTreePasteboard.mm:

(-[DumpRenderTreePasteboard declareType:owner:]): Use @[].

DumpRenderTree/mac/EventSendingController.mm:

(-[EventSendingController beginDragWithFiles:]): Use @().
(-[EventSendingController sentTouchEventOfType:]): Use @().

DumpRenderTree/mac/MockWebNotificationProvider.mm:

(-[MockWebNotificationProvider cancelNotification:]): Use @[].

DumpRenderTree/mac/ObjCController.m:

(-[ObjCController objectOfClass:]): Use @().
(-[ObjCController arrayOfString]): Use @[].
(-[ObjCController testWrapperRoundTripping:]): Use @().
(-[ObjCController testArray]): Use @[].

DumpRenderTree/mac/TestRunnerMac.mm:

(originsArrayToJS): Removed unneeded use of JSValueToObject.

DumpRenderTree/mac/TextInputControllerMac.m:

(-[TextInputController markedRange]): Use @[] and @().
(-[TextInputController selectedRange]): Use @[] and @().
(-[TextInputController firstRectForCharactersFrom:length:]):
Use @[] and @().
(-[TextInputController dictatedStringWithPrimaryString:alternative:alternativeOffset:alternativeLength:]):
Use @[].
(-[TextInputController interpretKeyEvents:withSender:]): Use @[].

DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::copyText): Use [].

DumpRenderTree/win/AccessibilityUIElementWin.cpp: Deleted an

unneeded copy constructor and destructor.

TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:

(-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Use @{}.

TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:

(toVector): Deleted.
(-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedAction:forURL:]):
Use makeVector<String>.

TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: