Timeline
Jun 21, 2020:
- 11:51 PM Changeset in webkit [263341] by
-
- 3 edits in trunk/Source/WTF
[WTF] Ensure ASCIILiteral is ASCII characters at compile time
https://bugs.webkit.org/show_bug.cgi?id=213449
Reviewed by Ross Kirsling.
The purpose of ASCIILiteral is ensure that this is compile-time (do not need to consider about ownership) ASCII characters.
By usingisASCIIandASSERT_UNDER_CONSTEXPR_CONTEXT, we can make sure that this C string does not include non ASCII characters.
For example,
auto globalVariable = "ラーメン (Ramen in Japanese)"_s;
becomes compile error.
- wtf/ASCIICType.h:
(WTF::isASCII):
- wtf/text/ASCIILiteral.h:
(WTF::StringLiterals::operator _s):
- 11:50 PM Changeset in webkit [263340] by
-
- 5 edits in trunk
[WTF] URL should support dataLog
https://bugs.webkit.org/show_bug.cgi?id=213450
Reviewed by Mark Lam.
Source/WTF:
Add URL::dump(PrintStream&) to support
dataLog(url)which is extremely useful for WTF / JSC developers.
- wtf/URL.cpp:
(WTF::URL::dump const):
- wtf/URL.h:
Tools:
Add test for URL::dump.
- TestWebKitAPI/Tests/WTF/URL.cpp:
(TestWebKitAPI::TEST_F):
- 9:43 PM Changeset in webkit [263339] by
-
- 2 edits in trunk/WebDriverTests
[WebDriver][GTK] Some executing_async_javascript_tests.py tests are failing with TimeoutExceptions
https://bugs.webkit.org/show_bug.cgi?id=211496
Unreviewed test gardening.
The two tests started passing with the updated selenium imported
tests from r263264;
- TestExpectations.json:
- 9:41 PM Changeset in webkit [263338] by
-
- 2 edits in trunk/WebDriverTests
WebDriver: several tests in imported/selenium/py/test/selenium/webdriver/common/visibility_tests.py fail
https://bugs.webkit.org/show_bug.cgi?id=182334
Unreviewed test gardening.
The last two remaining tests from this bug started passing after the
imported selenium tests were updated in r263264.
- TestExpectations.json:
- 9:39 PM Changeset in webkit [263337] by
-
- 2 edits in trunk/WebDriverTests
WebDriver: two selenium alert tests are failing
https://bugs.webkit.org/show_bug.cgi?id=181727
Unreviewed test gardening.
These tests also have been passing since r262861.
- TestExpectations.json:
- 9:38 PM Changeset in webkit [263336] by
-
- 2 edits in trunk/WebDriverTests
[WebDriver][GTK] Gardening failures related to missing selenium files
Unreviewed test gardening.
The relative_by_tests require some JS fragments built by Bazel,
Selenium's build tool.
- TestExpectations.json:
- 3:58 PM Changeset in webkit [263335] by
-
- 2 edits in trunk/JSTests
Attempt to unskip stress test array-buffer-view-watchpoint-can-be-fired-really-add-in-dfg.js on most architectures
https://bugs.webkit.org/show_bug.cgi?id=213433
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-21
Reviewed by Darin Adler.
- stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js:
- 3:47 PM Changeset in webkit [263334] by
-
- 43 edits in trunk/Source/WebCore
Convert much of the SVG string parsing code to use Optional based return values rather than out-parameters
https://bugs.webkit.org/show_bug.cgi?id=213416
Reviewed by Darin Adler.
Update SVG parsers to use Optional style return programming rather than out parameters.
To make things even nicer, SVGPathSource based parsers now have a type per-parse function,
which makes working with them much easier. In the future, we should consider exanding these
new types to be used by SVGPathConsumer family of classes as well.
- WebCore.xcodeproj/project.pbxproj:
Add SVGPathSegValue.h, which was missing from the Xcode project.
- svg/SVGAngleValue.cpp:
(WebCore::parseAngleType):
(WebCore::SVGAngleValue::setValueAsString):
Adopt updated parseNumber() function, and do a drive by removal of an easy to remove
upconvertedCharacters.
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateMotionElement::calculateFromAndToValues):
(WebCore::SVGAnimateMotionElement::calculateFromAndByValues):
(WebCore::SVGAnimateMotionElement::calculateDistance):
Now uses new parsePoint() function. Using Optional.valueOr() where
the old code would have had parsePoint() doing the clearing.
- svg/SVGAnimationElement.cpp:
(WebCore::parseKeySplines):
Now returns an Optional<Vector<UnitBezier>>.
(WebCore::SVGAnimationElement::parseAttribute):
Now uses new parseKeySplines, and does an explicit clear on parse failure (old code
did it implicitly in the parse function).
- svg/SVGFEConvolveMatrixElement.cpp:
(WebCore::SVGFEConvolveMatrixElement::parseAttribute):
- svg/SVGFEDiffuseLightingElement.cpp:
(WebCore::SVGFEDiffuseLightingElement::parseAttribute):
- svg/SVGFEDropShadowElement.cpp:
(WebCore::SVGFEDropShadowElement::parseAttribute):
- svg/SVGFEGaussianBlurElement.cpp:
(WebCore::SVGFEGaussianBlurElement::parseAttribute):
- svg/SVGFEMorphologyElement.cpp:
(WebCore::SVGFEMorphologyElement::parseAttribute):
- svg/SVGFESpecularLightingElement.cpp:
(WebCore::SVGFESpecularLightingElement::parseAttribute):
- svg/SVGFETurbulenceElement.cpp:
(WebCore::SVGFETurbulenceElement::parseAttribute):
Adopt Optional based parseNumberOptionalNumber.
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::parseAttribute):
- svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseAttribute):
Simplify by using the SVGPreserveAspectRatioValue constructor
which calls parse. No need for three lines.
- svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::parseAttribute):
Adopt new Optional based parseViewBox.
Simplify by using the SVGPreserveAspectRatioValue constructor
which calls parse. No need for three lines.
(WebCore::SVGFitToViewBox::parseViewBox):
Convert to be Optional based, and adopt new parseNumber functions.
- svg/SVGFitToViewBox.h:
Updated signatures for new Optional based functions.
- svg/SVGGlyphRefElement.cpp:
(WebCore::parseFloat):
Adopt Optional based parseNumber.
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair const):
- svg/SVGHKernElement.h:
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::buildVerticalKerningPair const):
- svg/SVGVKernElement.h:
Convert to be Optional based. Update a few callers to use makeString.
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::addKerningPair const):
(WebCore::SVGToOTFFontConverter::appendKERNSubtable):
Adopt new Optional based kerning pair builders. Add some moves
to avoid some copies.
- svg/SVGLengthValue.cpp:
(WebCore::SVGLengthValue::setValueAsString):
Adopt Optional based parseNumber.
- svg/SVGNumberList.h:
(WebCore::SVGNumberList::parse):
Adopt Optional based parseNumber.
- svg/SVGParserUtilities.cpp:
(WebCore::genericParseNumber):
(WebCore::parseNumber):
(WebCore::genericParseArcFlag):
(WebCore::parseArcFlag):
(WebCore::parseNumberOptionalNumber):
(WebCore::parsePoint):
(WebCore::parseRect):
(WebCore::parseGlyphName):
(WebCore::parseUnicodeRange):
(WebCore::parseKerningUnicodeString):
(WebCore::genericParseFloatPoint):
(WebCore::parseFloatPoint):
(WebCore::parseSVGNumber): Deleted.
(WebCore::parseNumberFromString): Deleted.
(WebCore::parseDelimitedString): Deleted.
(WebCore::parseFloatPoint2): Deleted.
(WebCore::parseFloatPoint3): Deleted.
- svg/SVGParserUtilities.h:
(WebCore::isSVGSpace):
(WebCore::skipOptionalSVGSpaces):
(WebCore::skipOptionalSVGSpacesOrDelimiter):
- Converts parse* functions to return Optional values rather than using outparameters.
- Removes unused parseSVGNumber and parseDelimitedString.
- Removes parseFloatPoint2 and parseFloatPoint3. They weren't useful enough to keep around.
- Renames parseNumberFromString to parseNumber. The argument is a String, it's clear enough.
- Replace boolean skip parameters with new enum SuffixSkippingPolicy.
- Make parseFloatPoint have two overloads rather than being templatized to be consistent.
- svg/SVGPathBlender.cpp:
(WebCore::pullFromSources):
(WebCore::SVGPathBlender::blendMoveToSegment):
(WebCore::SVGPathBlender::blendLineToSegment):
(WebCore::SVGPathBlender::blendLineToHorizontalSegment):
(WebCore::SVGPathBlender::blendLineToVerticalSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSegment):
(WebCore::SVGPathBlender::blendCurveToCubicSmoothSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSegment):
(WebCore::SVGPathBlender::blendCurveToQuadraticSmoothSegment):
(WebCore::SVGPathBlender::blendArcToSegment):
(WebCore::SVGPathBlender::canBlendPaths):
(WebCore::SVGPathBlender::blendAnimatedPath):
Update to adopt new SVGPathSource interface. Added pullFromSources helper
which substantially simplifies pulling from both the from and to source at
the same time and is now possible due to all the SVGPathSource functions
returning the segment types rather than taking them as out parameters.
- svg/SVGPathByteStreamSource.cpp:
(WebCore::SVGPathByteStreamSource::nextCommand):
(WebCore::SVGPathByteStreamSource::parseSVGSegmentType):
(WebCore::SVGPathByteStreamSource::parseMoveToSegment):
(WebCore::SVGPathByteStreamSource::parseLineToSegment):
(WebCore::SVGPathByteStreamSource::parseLineToHorizontalSegment):
(WebCore::SVGPathByteStreamSource::parseLineToVerticalSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToCubicSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathByteStreamSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathByteStreamSource::parseArcToSegment):
- svg/SVGPathByteStreamSource.h:
Adopt new SVGPathSource interface.
- svg/SVGPathParser.cpp:
(WebCore::SVGPathParser::parseMoveToSegment):
(WebCore::SVGPathParser::parseLineToSegment):
(WebCore::SVGPathParser::parseLineToHorizontalSegment):
(WebCore::SVGPathParser::parseLineToVerticalSegment):
(WebCore::SVGPathParser::parseCurveToCubicSegment):
(WebCore::SVGPathParser::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSegment):
(WebCore::SVGPathParser::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathParser::parseArcToSegment):
(WebCore::SVGPathParser::parsePathData):
Adapt to new SVGPathSource interface. Code reads a bit nicer now
that we don't have a ton of local variables in each method. Could
be made nicer in the future by adopting Segment types in the path
consumer code.
- svg/SVGPathSegListSource.cpp:
(WebCore::SVGPathSegListSource::nextCommand):
(WebCore::SVGPathSegListSource::parseSVGSegmentType):
(WebCore::SVGPathSegListSource::parseMoveToSegment):
(WebCore::SVGPathSegListSource::parseLineToSegment):
(WebCore::SVGPathSegListSource::parseLineToHorizontalSegment):
(WebCore::SVGPathSegListSource::parseLineToVerticalSegment):
(WebCore::SVGPathSegListSource::parseCurveToCubicSegment):
(WebCore::SVGPathSegListSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathSegListSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathSegListSource::parseArcToSegment):
- svg/SVGPathSegListSource.h:
Adopt new SVGPathSource interface.
- svg/SVGPathSource.h:
Update interface to return Optionals, with a specific type for
segment kind that be parsed.
- svg/SVGPathStringSource.cpp:
(WebCore::nextCommandHelper):
(WebCore::SVGPathStringSource::nextCommand):
(WebCore::parseSVGSegmentTypeHelper):
(WebCore::SVGPathStringSource::parseSVGSegmentType):
(WebCore::SVGPathStringSource::parseMoveToSegment):
(WebCore::SVGPathStringSource::parseLineToSegment):
(WebCore::SVGPathStringSource::parseLineToHorizontalSegment):
(WebCore::SVGPathStringSource::parseLineToVerticalSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSegment):
(WebCore::SVGPathStringSource::parseCurveToCubicSmoothSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSegment):
(WebCore::SVGPathStringSource::parseCurveToQuadraticSmoothSegment):
(WebCore::SVGPathStringSource::parseArcToSegment):
(WebCore::parseArcToSegmentHelper): Deleted.
- svg/SVGPathStringSource.h:
Adopt new SVGPathSource interface. Replace out of line helpers (or use of things
like parseFloatPoint2) with generic lambda helpers, helping to keep the code more
localized.
- svg/SVGPointList.h:
(WebCore::SVGPointList::parse):
Adopt Optional based parseNumber.
- svg/SVGTransformList.h:
- svg/SVGTransformable.cpp:
(WebCore::parseTransformParamList):
(WebCore::SVGTransformable::parseTransformValue):
(WebCore::SVGTransformable::parseAndSkipType):
(WebCore::SVGTransformable::parseTransformType):
- svg/SVGTransformable.h:
Convert parseTransformValue/parseAndSkipType to be Optional based.
- svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::parseViewSpec):
Adopt Optional based parseViewBox.
- svg/properties/SVGAnimationAdditiveValueFunctionImpl.h:
Adopt Optional based parseNumber.
- svg/properties/SVGPropertyTraits.h:
(WebCore::SVGPropertyTraits<float>::fromString):
(WebCore::SVGPropertyTraits<float>::parse):
(WebCore::SVGPropertyTraits<FloatPoint>::fromString):
(WebCore::SVGPropertyTraits<FloatPoint>::parse):
(WebCore::SVGPropertyTraits<FloatRect>::fromString):
(WebCore::SVGPropertyTraits<FloatRect>::parse):
Adopt Optional based parsers.
- 1:33 PM Changeset in webkit [263333] by
-
- 2 edits in trunk/Tools
[Flatpak] Nightly runner fails to extract zip files
https://bugs.webkit.org/show_bug.cgi?id=213445
Patch by Philippe Normand <pnormand@igalia.com> on 2020-06-21
Reviewed by Darin Adler.
- Scripts/webkit-flatpak-run-nightly: Ensure the buffered zip data is written to disk before
extraction.
- 1:20 PM Changeset in webkit [263332] by
-
- 3 edits in trunk/LayoutTests
compositing/video/video-border-radius-clipping.html was a flaky failure after r263223
https://bugs.webkit.org/show_bug.cgi?id=213424
Reviewed by Darin Adler.
The last attempt to unflake this test was r253310. Let's try again.
I took a screen recording of a few hundred loads of this test @ r263222,
and it looks like it was always possible for canplaythrough and seeked
to fire before the video had rendered its first frame. So, this is a
test issue.
The screen recording seems to show that waiting for
requestAnimationFrame ensures that the video renders its first frame.
This might be for a principled system vsync reason, or just a lucky
delay. Either way, the test seems less flaky now.
This might mean that we can remove the previous seeked event workaround,
but I chose not to tempt fate, and left it in place.
- compositing/video/video-border-radius-clipping-expected.html:
- compositing/video/video-border-radius-clipping.html:
- media/video-test.js:
(_eventCallback):
(waitForEvent):
- 12:58 PM Changeset in webkit [263331] by
-
- 21 edits in trunk/Source/WebCore
Convert DateComponents parsing code to use Optional based return values rather than out-parameters
https://bugs.webkit.org/show_bug.cgi?id=213440
Reviewed by Darin Adler.
Rework DateComponents and Date/Time related InputTypes to use Optional based programming
for parsing results. Also take the opportunity to remove unicode upconversion from
DateComponent parsing and instead separate UChar and LChar variants via templates.
- html/BaseDateAndTimeInputType.cpp:
- html/BaseDateAndTimeInputType.h:
- html/DateInputType.cpp:
- html/DateInputType.h:
- html/DateTimeInputType.cpp:
- html/DateTimeInputType.h:
- html/DateTimeLocalInputType.cpp:
- html/DateTimeLocalInputType.h:
- html/HTMLInputElement.cpp:
- html/HTMLInputElement.h:
- html/InputType.cpp:
- html/InputType.h:
- html/MonthInputType.cpp:
- html/MonthInputType.h:
- html/TimeInputType.cpp:
- html/TimeInputType.h:
- html/WeekInputType.cpp:
- html/WeekInputType.h:
- Removes parseToDateComponentsInternal. No need it and parseToDateComponents.
- Makes parseToDateComponents pure virtual. The old code had a default implementations down in InputType, but it had no callers.
- Remove iOS vs. non-iOS difference for dateType(). It is now available on InputType on all platforms.
- Make setMillisecondToDateComponents and parseToDateComponents return an Optional.
- platform/DateComponents.cpp:
- platform/DateComponents.h:
- Replace member function based interfaces for parsing/setting explicit time offsets with new factory functions that return Optional<DateComponents>.
- These factories are implemented using the existing member functions, which are now private.
- Make max/min constants constexpr.
- Make parse* member functions templates to allow factory parse functions to call them without upconverting.
- Replace header guard with #pragma once.
- 11:43 AM Changeset in webkit [263330] by
-
- 1 edit3 adds in trunk/LayoutTests
fast/text/international/system-language/navigator-language/navigator-language tests are failing on Mojave
<rdar://problem/64468227>
Unreviewed test gardening.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt: Added.
- 10:13 AM Changeset in webkit [263329] by
-
- 3 edits2 adds in trunk
[LFC] Add basic support for width: fit-content
https://bugs.webkit.org/show_bug.cgi?id=213444
Reviewed by Antti Koivisto.
Source/WebCore:
At this point this is just a shrink-to-fit sizing (missing the case when the available horizontal space is not specified).
Test: fast/layoutformattingcontext/fit-content-width-simple.html
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedWidthValue):
LayoutTests:
- fast/layoutformattingcontext/fit-content-width-simple-expected.html: Added.
- fast/layoutformattingcontext/fit-content-width-simple.html: Added.
- 8:34 AM Changeset in webkit [263328] by
-
- 14 edits1 add in trunk
WebKit fails to leave audio routing arbitration during navigation, closing.
https://bugs.webkit.org/show_bug.cgi?id=213426
<rdar://problem/64395051>
Reviewed by Eric Carlson.
Source/WebCore:
When setting the AudioSession category, make sure to leave routing arbitration before bailing out early. Also,
HTMLMediaElement::canProduceAudio() should returnfalsewhen the element's document is suspended or stopped.
Otherwise, the AudioSession will continue in theMediaPlaybackcategory indefinitely, and routing arbitration
will remain active.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::canProduceAudio const):
- platform/audio/mac/AudioSessionMac.mm:
(WebCore::AudioSession::setCategory):
Source/WebKit:
Add testing SPIs to verify whether a WebPage successfully entered or left audio routing
arbitration. Notify the Arbitration proxy when the page is shut down, which ensures arbitration
will end if the client closes the WKWebView.
- UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
- UIProcess/API/Cocoa/WKWebViewTesting.mm:
(-[WKWebView _audioRoutingArbitrationStatus]):
- UIProcess/API/mac/WKWebViewTestingMac.mm:
- UIProcess/Media/AudioSessionRoutingArbitratorProxy.h:
(WebKit::AudioSessionRoutingArbitratorProxy::arbitrationStatus const):
- UIProcess/Media/cocoa/AudioSessionRoutingArbitratorProxyCocoa.mm:
(WebKit::AudioSessionRoutingArbitratorProxy::processDidTerminate):
(WebKit::AudioSessionRoutingArbitratorProxy::beginRoutingArbitrationWithCategory):
(WebKit::AudioSessionRoutingArbitratorProxy::endRoutingArbitration):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shutDown):
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::audioSessionRoutingArbitrator):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: Added.
(AudioRoutingArbitration::statusShouldBecomeEqualTo):
(TEST_F):
- 6:51 AM Changeset in webkit [263327] by
-
- 6 edits2 adds in trunk
[LFC][TFC] Add support for percentage min/max-width
https://bugs.webkit.org/show_bug.cgi?id=213436
Reviewed by Antti Koivisto.
Source/WebCore:
- The table generates a principal block container box called the table wrapper box that contains the table box itself and any caption boxes.
- The table wrapper box establishes a block formatting context, and the table box establishes a table formatting context.
- The computed values of properties 'position', 'float', 'margin-*', 'top', 'right', 'bottom', and 'left' on the table element are used on the table wrapper box and not the table box; all other values of non-inheritable properties are used on the table box and not the table wrapper box.
- In a block formatting context, each box's left outer edge touches the left edge of the containing block. This is true even in the presence of floats, unless the box establishes a new block formatting context (in which case the box itself may become narrower due to the floats)
Now consider the following case:
<div style="display: block; width: 500px;">
<div style="float: left; width: 100px;"></div>
<div style="display: table; width: 10%;"></div>
</div>
- We create a table wrapper box to wrap the "display: table" block level box (#1).
- The table wrapper box's width property is set to auto (#3).
- Since it establishes a new block formatting context, the available horizontal space gets shrunk by the float (#4)
- The table wrapper box's used width computes to 500px - 100px -> 400px;
Now we are inside the BFC established by the table wrapper box and try to resolve the table's width -> %10.
According to the normal BFC rules, it should compute to 10% of the containing block's logical width: 400px -> 40px.
However in practice it computes to 50px (10% of 500px).
Similar setup with non-table content would resolve the inner block level box's width to 40px;
<div style="display: block; width: 500px">
<div style="float: left; width: 100px;"></div>
<div style="display: block; overflow: hidden;">
<div style="display: block; width: 10%"></div>
</div>
</div>
This needs clarification.
Test: fast/layoutformattingcontext/float-avoider-available-horizontal-space3.html
- layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::isTableWrapperBlockFormattingContext const):
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.h:
LayoutTests:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space3-expected.html: Added.
- fast/layoutformattingcontext/float-avoider-available-horizontal-space3.html: Added.
- 2:13 AM Changeset in webkit [263326] by
-
- 2 edits in trunk/Source/WebKit
[WPE][GTK] Specify underlying storage type for InputMethodState::Hint
https://bugs.webkit.org/show_bug.cgi?id=213401
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-21
Reviewed by Carlos Garcia Campos.
Using unsigned types for flags enums seems nice to do.
- Shared/glib/InputMethodState.h:
- 2:11 AM Changeset in webkit [263325] by
-
- 3 edits in trunk/Source/WebKit
[WPE][GTK] Add autocleanup for WebKitWebsitePolicies
https://bugs.webkit.org/show_bug.cgi?id=213399
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-21
Reviewed by Carlos Garcia Campos.
Add missing autocleanups.
- UIProcess/API/gtk/WebKitAutocleanups.h:
- UIProcess/API/wpe/WebKitAutocleanups.h:
Jun 20, 2020:
- 11:10 PM Changeset in webkit [263324] by
-
- 2 edits in trunk/Source/WebKit
[AppSSO] Should do null check on m_page in dismissViewController()
https://bugs.webkit.org/show_bug.cgi?id=213415
<rdar://problem/59672418>
Reviewed by Alexey Proskuryakov.
- UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::dismissViewController):
- 7:49 PM Changeset in webkit [263323] by
-
- 5 edits in trunk/Source
RecoveryOS: PAL::getAVPlayerLayerClass() will crash when AVFoundation is missing
https://bugs.webkit.org/show_bug.cgi?id=213437
<rdar://problem/64563064>
Reviewed by Eric Carlson.
Check PAL::isAVFoundationAvailable() before calling PAL::getAVPlayerLayerClass();
Source/WebCore:
- platform/graphics/avfoundation/objc/VideoLayerManagerObjC.mm:
(WebCore::VideoLayerManagerObjC::setVideoLayer):
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(WebCore::PlatformCALayerCocoa::layerTypeForPlatformLayer):
(WebCore::PlatformCALayerCocoa::PlatformCALayerCocoa):
(WebCore::PlatformCALayerCocoa::clone const):
(WebCore::PlatformCALayerCocoa::avPlayerLayer const):
Source/WebKit:
- WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone const):
- 7:13 PM Changeset in webkit [263322] by
-
- 6 edits in trunk/Source/WebCore
Crash under ScrollController::startSnapRubberbandTimer() firing
https://bugs.webkit.org/show_bug.cgi?id=213439
<rdar://problem/63986013>
Reviewed by Tim Horton.
A wholesale destruction of the ScrollingTree (e.g. via ScrollingCoordinatorMac::pageDestroyed()) never
ran the code to stop CFRunLoopTimers in ScrollController, which could lead to this crash.
Fix by calling removeAllNodes() in ThreadedScrollingTree::invalidate().
Add an assertion in ScrollController's destructor that stopAllTimers() has been called, and have
ScrollAnimator's destructor call stopAllTimers() too.
- page/scrolling/ScrollingTree.h:
- page/scrolling/ThreadedScrollingTree.cpp:
(WebCore::ThreadedScrollingTree::invalidate):
- platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::~ScrollAnimator):
- platform/cocoa/ScrollController.h:
- platform/cocoa/ScrollController.mm:
(WebCore::ScrollController::~ScrollController):
(WebCore::ScrollController::stopAllTimers):
- 6:13 PM Changeset in webkit [263321] by
-
- 4 edits in trunk
REGRESSION(r259219): Sleep assertion remains active if WKWebView is closed or WebContent process crashes
https://bugs.webkit.org/show_bug.cgi?id=213434
<rdar://problem/57541662>
Reviewed by Eric Carlson.
Source/WebKit:
Tests: TestWebKitAPI tests:
SleepDisabler.Basic
SleepDisabler.Pause
SleepDisabler.Mute
SleepDisabler.Unmute
SleepDisabler.DisableAudioTrack
SleepDisabler.Loop
SleepDisabler.ChangeSrc
SleepDisabler.Load
SleepDisabler.Unload
SleepDisabler.Navigate
SleepDisabler.NavigateBack
SleepDisabler.Reload
SleepDisabler.Close
SleepDisabler.Crash
Ensure the SleepDisablers are cleared when the WebProcess closes or crashes.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::shutDown):
(WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch):
Tools:
- TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
(SleepDisabler::loadPlayingPage):
(SleepDisabler::hasSleepDisablerShouldBecomeEqualTo):
(TEST_F):
- 4:35 PM Changeset in webkit [263320] by
-
- 7 edits in trunk/Source/WebKit
[iOS, macOS] Allow access to the container manager to support Mail InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=213357
<rdar://problem/63837247>
Reviewed by Darin Adler.
The Mail Injected Bundle requires access to the container manager to support certain OS operations. We do not need
this access for web browsing, and should limit this access to this one case.
This patch creates a dynamic mach extension to the container manager for this single use case. It also denies the
non-extension access case with a backtrace so we can see if any other clients are hitting this.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/com.apple.WebProcess.sb.in:
- 4:16 PM Changeset in webkit [263319] by
-
- 2 edits in trunk/Tools
Bring up watchOS/tvOS on build.webkit.org (Follow-up fix x2)
https://bugs.webkit.org/show_bug.cgi?id=213402
<rdar://problem/64542588>
Unreviewed test fix.
- Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl: Native Macs never
use 32 bit tool binaries.
- 8:24 AM Changeset in webkit [263318] by
-
- 9 edits1 copy4 adds in trunk
[LFC][TFC][Quirk] Table height needs quirk handling
https://bugs.webkit.org/show_bug.cgi?id=213430
Reviewed by Antti Koivisto.
Source/WebCore:
In quirks mode the used table height of an empty table is 0, while in standards mode
we take the specified value into account and size the table accordingly.
Tests: fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple.html
fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContext.h:
- layout/blockformatting/BlockFormattingContext.h:
(WebCore::Layout::BlockFormattingContext::Quirks::geometry const):
- layout/blockformatting/BlockFormattingContextQuirks.cpp:
(WebCore::Layout::BlockFormattingContext::Quirks::stretchedInFlowHeight):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeHeightAndMarginForTableBox):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.h:
(WebCore::Layout::TableWrapperBlockFormattingContext::Quirks::Quirks):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContextQuirks.cpp: Copied from Source/WebCore/layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.h.
(WebCore::Layout::TableWrapperBlockFormattingContext::Quirks::usedTableHeight const):
LayoutTests:
- fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple-expected.html: Added.
- fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple.html: Added.
- fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple-expected.html: Added.
- fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple.html: Added.
- 12:08 AM Changeset in webkit [263317] by
-
- 4 edits in trunk/LayoutTests
[Windows] fast/forms/search-field-buttons-do-not-have-focus-rings.html is failing
https://bugs.webkit.org/show_bug.cgi?id=213422
Reviewed by Tim Horton.
Refactor this test so that it doesn't attempt to hard-code the position and sizes of the search field buttons.
To do this, we use an internal helper to grab thedivelements that correspond to the results and cancel
buttons, and then use their bounding rects to place the opaquedivs to cover these buttons.
- fast/forms/search-field-buttons-do-not-have-focus-rings-expected.html:
- fast/forms/search-field-buttons-do-not-have-focus-rings.html:
- platform/win/TestExpectations:
Jun 19, 2020:
- 9:20 PM Changeset in webkit [263316] by
-
- 11 edits1 add in trunk
[JSC] Check Gigacage usage before launching VM
https://bugs.webkit.org/show_bug.cgi?id=213410
Reviewed by Mark Lam.
JSTests:
- stress/exhaust-gigacage-and-allocate-vm.js: Added.
(foo):
Source/bmalloc:
Add Gigacage::footprint and Gigacage::size functions to expose usage to API users.
Rename Gigacage::size to Gigacage::maxSize.
- bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::size):
(Gigacage::footprint):
- bmalloc/Gigacage.h:
(Gigacage::maxSize):
(Gigacage::alignment):
(Gigacage::mask):
(Gigacage::size):
(Gigacage::footprint):
- bmalloc/Heap.cpp:
(bmalloc::Heap::gigacageSize):
- bmalloc/Heap.h:
Source/JavaScriptCore:
Since VM allocates JSBigInt from Gigacage, it is possible that VM creation fails when Gigacage is exhausted.
As a work-around for internal testing, we insert ad-hoc Gigacage usage check before launching a new agent.
If 80% of Gigacage is used, we fail to launch a new VM gracefully.
- assembler/testmasm.cpp:
(JSC::testCagePreservesPACFailureBit):
- jsc.cpp:
(functionDollarAgentStart):
Source/WTF:
- wtf/Gigacage.h:
(Gigacage::footprint):
(Gigacage::maxSize):
(Gigacage::size):
- 9:06 PM Changeset in webkit [263315] by
-
- 2 edits1 add in trunk
Typed array constructor behaves differently when length is not passed or when undefined is passed
https://bugs.webkit.org/show_bug.cgi?id=184232
Patch by James Darpinian <James Darpinian> on 2020-06-19
Reviewed by Yusuke Suzuki.
Passing undefined for length should have the same effect as omitting the argument. It was being
treated as 0 instead.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayView):
- 9:02 PM Changeset in webkit [263314] by
-
- 8 edits12 adds in trunk/LayoutTests
fast/text/international/system-language/navigator-language/navigator-language tests are failing on Catalina and iOS
<rdar://problem/64468227>
Unreviewed test gardening.
Rather than marking the tests as flakey, we can just commit -expected results for every OS.
- fast/text/international/system-language/navigator-language/navigator-language-en-US-expected.txt:
- fast/text/international/system-language/navigator-language/navigator-language-es-ES-expected.txt:
- fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt:
- fast/text/international/system-language/navigator-language/navigator-language-pt-BR-expected.txt:
- fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt:
- platform/ios/TestExpectations:
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-en-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-419-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-MX-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-es-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-fr-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-hi-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ja-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-ru-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-HK-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK-expected.txt: Added.
- platform/mac-mojave/fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-expected.txt: Added.
- platform/mac/TestExpectations:
- 8:50 PM Changeset in webkit [263313] by
-
- 15 edits in trunk/Source
[Cocoa] Delay issuing ManagedSession & Network Extension sandbox extensions until a load is actually issued
https://bugs.webkit.org/show_bug.cgi?id=213414
<rdar://problem/64548684>
Reviewed by Per Arne Vollan.
Source/WebCore:
setHasConsumedSandboxExtensions() can now get called several times, every time a WebPage is created.
Once a sandbox extension has been consumed, there is no going back so return early if the state is
already "Consumed".
- platform/cocoa/NetworkExtensionContentFilter.mm:
(WebCore::NetworkExtensionContentFilter::setHasConsumedSandboxExtensions):
- platform/cocoa/ParentalControlsContentFilter.mm:
(WebCore::ParentalControlsContentFilter::setHasConsumedSandboxExtension):
Source/WebKit:
Delay issuing ManagedSession & Network Extension sandbox extensions until a load is actually issued.
This is a Safari launch time optimization since the checks needed to decide whether or not to issue
the extensions are expensive and there is no reason to issue them as soon as the process launches
(especially in the case of a prewarmed process).
- Shared/Cocoa/LoadParametersCocoa.mm:
(WebKit::LoadParameters::platformEncode const):
(WebKit::LoadParameters::platformDecode):
- Shared/LoadParameters.h:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
(WebKit::WebPageProxy::addPlatformLoadParameters):
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::addPlatformLoadParameters):
(WebKit::WebPageProxy::loadRequestWithNavigationShared):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadDataWithNavigationShared):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadWebArchiveData):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::hasNetworkExtensionSandboxAccess const):
(WebKit::WebProcessProxy::markHasNetworkExtensionSandboxAccess):
(WebKit::WebProcessProxy::hasManagedSessionSandboxAccess const):
(WebKit::WebProcessProxy::markHasManagedSessionSandboxAccess):
- WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::platformDidReceiveLoadParameters):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- 8:17 PM Changeset in webkit [263312] by
-
- 15 edits in trunk
[JSC] Attempt to reduce timeout failures on Apple Watch Series 3
https://bugs.webkit.org/show_bug.cgi?id=213419
Reviewed by Mark Lam.
JSTests:
Look into timeout tests, and
- If the test is using too many iterations, decrease the count.
- If the test is still useful while iteration count is not so much, try attaching
slow!to see the effect on the bot.
- stress/memcpy-typed-loops.js:
- stress/op_bitand.js:
- stress/op_bitor.js:
- stress/op_bitxor.js:
- stress/op_mul-ConstVar.js:
- stress/op_mul-VarConst.js:
- stress/op_mul-VarVar.js:
- stress/op_sub-ConstVar.js:
- stress/op_sub-VarConst.js:
- stress/op_sub-VarVar.js:
- stress/set-iteration-oas.js:
- stress/value-to-boolean.js:
Source/JavaScriptCore:
- tools/JSDollarVM.cpp:
(JSC::functionUseJIT):
(JSC::JSDollarVM::finishCreation):
- 7:44 PM Changeset in webkit [263311] by
-
- 8 edits2 adds in trunk
[AutoSizing] Resolve viewport units against the preferred content size
https://bugs.webkit.org/show_bug.cgi?id=213408
<rdar://problem/64267539>
Reviewed by Tim Horton.
Source/WebCore:
Instead of resolving the viewport units against the maximum content size constraints, let's use the preferred content size.
It ensures that content with vw, vh units does not grow beyond the preferred content size.
Test: fast/dynamic/size-to-content-autosize-with-viewport-units.html
- page/FrameView.cpp:
(WebCore::FrameView::performSizeToContentAutoSize):
(WebCore::FrameView::enableAutoSizeMode): Let's "ignore" viewport units during the initial
pass and use the preferred width to finalize the vw vh unit values (we don't really ignore them, but they are resolved against a [ 1, 1 ] viewport).
This approach fails if the main content has 100vw with overflow hidden. Such content would end up with a [ 1, 1 ] size (we might want to detect it
and resolved the values against the horizontal constraint).
(WebCore::FrameView::overrideViewportWidthForCSSViewportUnits):
(WebCore::FrameView::resetOverriddenViewportWidthForCSSViewportUnits):
- page/FrameView.h:
- testing/Internals.cpp:
(WebCore::Internals::enableSizeToContentAutoSizeMode):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/dynamic/size-to-content-autosize-with-viewport-units-expected.txt: Added.
- fast/dynamic/size-to-content-autosize-with-viewport-units.html: Added.
- 7:37 PM Changeset in webkit [263310] by
-
- 5 edits in trunk/Tools
Bring up watchOS/tvOS on build.webkit.org (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=213402
<rdar://problem/64542588>
Unreviewed build-fix.
- BuildSlaveSupport/build.webkit.org-config/config.json: Use arm64_32 to build watchOS device.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot): watchOS device should be considered 32 bit.
- Scripts/configure-xcode-for-embedded-development: Force-copy MediaAccessibility.framework.
- Scripts/webkitdirs.pm:
(extractNonMacOSHostConfiguration): Native Macs never use 32 bit tool binaries.
- 7:26 PM Changeset in webkit [263309] by
-
- 4 edits in trunk/Source/WebCore
[macOS] Move progress bar painting code off of Carbon API
https://bugs.webkit.org/show_bug.cgi?id=213405
<rdar://problem/63958537>
Reviewed by Tim Horton.
Source/WebCore:
Adopts CoreUI constants and AppKit SPI (
-[NSAppearance _drawInRect:context:options:]) when painting progress
elements. This is being done in light of recent changes around howHIThemeDrawTrackdraws progress bars on
recent versions of macOS; it has been recommended to us that we move away from using Carbon, and instead use
AppKit.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
The
NSControlSizetoCUISizemapping here looks counterintuitive, but matches our current behavior. This is
becausekThemeLargeProgressBarandkThemeLargeIndeterminateBarboth map tokCUISizeRegular, while
kThemeMediumIndeterminateBarandkThemeMediumProgressBarmap tokCUISizeSmall.
Source/WebCore/PAL:
Add forward declarations for CoreUI SPI on non-internal SDKs.
- pal/spi/mac/CoreUISPI.h:
- 6:22 PM Changeset in webkit [263308] by
-
- 5 edits3 deletes in trunk/Tools
Delete dead code for old ews api tests
https://bugs.webkit.org/show_bug.cgi?id=213421
Rubber-stamped by Alexey Proskuryakov.
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_api_tests_command): Deleted.
- Scripts/webkitpy/common/net/apitestresults.py: Removed.
- Scripts/webkitpy/common/net/apitestresults_unittest.py: Removed.
- Scripts/webkitpy/port/base.py:
(Port.bindings_results_directory):
(Port.api_results_directory): Deleted.
- Scripts/webkitpy/tool/bot/apitestresultsreader.py: Removed.
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests._run_api_tests): Deleted.
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(test_runtests_api_debug): Deleted.
- 6:07 PM Changeset in webkit [263307] by
-
- 7 edits in trunk/Source/WebKit
Unreviewed, reverting r263287.
Caused tests to exit early with crashes on Catalina.
Reverted changeset:
"[iOS, macOS] Allow access to the container manager to support Mail InjectedBundle"
https://bugs.webkit.org/show_bug.cgi?id=213357
https://trac.webkit.org/changeset/263287
- 6:04 PM Changeset in webkit [263306] by
-
- 2 edits in trunk/Source/WebKit
Crash under WebKit::ProcessAndUIAssertion::updateRunInBackgroundCount()
https://bugs.webkit.org/show_bug.cgi?id=213417
<rdar://problem/63477676>
Reviewed by Darin Adler.
Make sure |this| is still alive in ProcessAndUIAssertion::processAssertionWasInvalidated()
after calling ProcessAssertion::processAssertionWasInvalidated() and before calling
updateRunInBackgroundCount(). Calling ProcessAssertion::processAssertionWasInvalidated()
notifies the client and the client may destroy the assertion as a result.
- UIProcess/ios/ProcessAssertionIOS.mm:
(WebKit::ProcessAndUIAssertion::processAssertionWasInvalidated):
- 5:57 PM Changeset in webkit [263305] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening on Windows
Mark a test as failing while it's being investigated.
- platform/win/TestExpectations:
- 5:53 PM Changeset in webkit [263304] by
-
- 6 edits in trunk
Remove setVelocity() from PannerNode
https://bugs.webkit.org/show_bug.cgi?id=213360
Patch by Clark Wang <clark_wang@apple.com> on 2020-06-19
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Re-baselined previous test that now passes with velocity removed.
- web-platform-tests/webaudio/historical-expected.txt:
Source/WebCore:
Removed setVelocity() and other velocity dependencies, as per spec: https://www.w3.org/TR/webaudio/#pannernode.
Simplified dopplerRate, since sourceVelocity is always zero.
Re-baselined previous test that now passes with velocity removed.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::dopplerRate):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/PannerNode.idl:
- 5:43 PM Changeset in webkit [263303] by
-
- 3 edits2 adds in trunk
REGRESSION (r263253): Search field results and cancel buttons have their own focus rings
https://bugs.webkit.org/show_bug.cgi?id=213413
<rdar://problem/64548419>
Reviewed by Tim Horton.
Source/WebCore:
After r263253,
paintCellAndSetFocusedElementNeedsRepaintIfNecessaryis used when painting the buttons in a
search field's shadow root. However, the renderer that is passed in (which is used to determine whether we
should additionally draw focus rings) is the input element's renderer rather than the renderers of the results
and cancel buttons themselves. This means that when the search field is focused, we will draw focus rings around
each of the buttons in the shadow root as well.
Address this by using
box(the buttons' RenderBoxes) instead.
Test: fast/forms/search-field-buttons-do-not-have-focus-rings.html
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
LayoutTests:
Add a ref test to verify that the search and cancel buttons don't draw individual focus rings. This test works
by verifying that no focus ring around either the cancel or results button bleeds outside of the bounds of a div
that obscures the buttons.
- fast/forms/search-field-buttons-do-not-have-focus-rings-expected.html: Added.
- fast/forms/search-field-buttons-do-not-have-focus-rings.html: Added.
- 5:16 PM Changeset in webkit [263302] by
-
- 7 edits in trunk
Crash in WebCore::Range::borderAndTextRects
https://bugs.webkit.org/show_bug.cgi?id=209379
Patch by Pinki Gyanchandani <pgyanchandani@apple.com> on 2020-06-19
Reviewed by Darin Adler.
When a parentless node is moved to a new document, then all ranges associated with this node and its children also should
be updated with new document information.
Test woould be submitted later.
- dom/Document.cpp:
(WebCore::Document::parentlessNodeMoveToNewDocument):
- dom/Document.h:
- dom/Node.cpp:
(WebCore::Node::moveNodeToNewDocument):
- dom/Range.cpp:
(WebCore::Range::parentlessNodeMoveToNewDocumentAffectsRange):
(WebCore::Range::updateRangeForParentlessNodeMoveToNewDocument):
- dom/Range.h:
- 5:11 PM Changeset in webkit [263301] by
-
- 7 edits2 deletes in trunk
Unreviewed, reverting r263121.
Broke media/video-fullscreen-only-playback.html on Catalina
Debug
Reverted changeset:
"Don't claim to support fullscreen mode unless
fullScreenEnabled setting is enabled"
https://bugs.webkit.org/show_bug.cgi?id=213142
https://trac.webkit.org/changeset/263121
- 5:07 PM Changeset in webkit [263300] by
-
- 3 edits in trunk/Tools
Bring up watchOS/tvOS on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=213402
<rdar://problem/64542588>
Unreviewed infrastructure fix.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build): Add tvOS and watchOS.
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
(ShouldBuildTest.test_should_build):
- 5:07 PM Changeset in webkit [263299] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, reverting r263223.
Broke compositing/video/video-border-radius-clipping.html on
Mac release wk1
Reverted changeset:
"Unreviewed, re-landing r262904."
https://bugs.webkit.org/show_bug.cgi?id=213063
https://trac.webkit.org/changeset/263223
- 5:02 PM Changeset in webkit [263298] by
-
- 6 edits in trunk/Source/WebKit
com.apple.WebKit.Networking crash: suspended with locked system files (observations.db)
https://bugs.webkit.org/show_bug.cgi?id=213391
<rdar://problem/64494167>
Reviewed by Chris Dumez.
ITP is the only database that attempts to close when
NetworkProcess::didClose() is called. This causes the network process
to sometimes crash if the database is still closing when checking for
locked system files. Instead, we should only flush the
memory store to disk when calling NetworkProcess::didClose (in the
memory store case), and only close the database when the network session is destroyed.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::didDestroyNetworkSession):
(WebKit::WebResourceLoadStatisticsStore::destroyResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::flushAndDestroyPersistentStore):
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
Split into two functions, one to flush and destroy the persistent
store, and one to destroy the memory or database store.
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
Only flush the persistent store here, as described above.
- NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::flushAndDestroyPersistentStore):
- NetworkProcess/NetworkSession.h:
- 5:00 PM Changeset in webkit [263297] by
-
- 3 edits2 adds in trunk
[CG] REGRESSION (r256892): Luminance SVG mask is not applied when accelerated drawing is enabled
https://bugs.webkit.org/show_bug.cgi?id=213403
<rdar://problem/64489419>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-06-19
Reviewed by Simon Fraser.
Source/WebCore:
Test: svg/masking/mask-css-luminance.html
If the ImageBuffer is backed by an IOSurface, its context has to be flushed
out before convertToLuminanceMask() can access its data.
- platform/graphics/ConcreteImageBuffer.h:
LayoutTests:
- svg/masking/mask-css-luminance-expected.html: Added.
- svg/masking/mask-css-luminance.html: Added.
- 4:40 PM Changeset in webkit [263296] by
-
- 7 edits1 add in trunk
[WebAuthn] Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid
https://bugs.webkit.org/show_bug.cgi?id=213404
<rdar://problem/64543894>
Reviewed by Brent Fulgham.
Source/WebKit:
Provide a _WKWebAuthenticationPanelUpdatePINInvalid update to UI clients if the returned PIN from the client is not valid such that clients can
reuse the same logic to handle invalid pin from the authenticator. This change makes their life easier.
Covered by API tests.
- UIProcess/API/APIWebAuthenticationPanelClient.h:
(API::WebAuthenticationPanelClient::requestPin const):
- UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:
(WebKit::WebAuthenticationPanelClient::requestPin const):
Now, only null strings are intepreted as cancels.
- UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:
(WebKit::CtapAuthenticator::continueMakeCredentialAfterResponseReceived):
(WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived):
(WebKit::CtapAuthenticator::continueGetPinTokenAfterRequestPin):
(WebKit::CtapAuthenticator::continueRequestAfterGetPinToken):
This patch also removes potential null pointer dereferences.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-fake-pin-invalid-error-retry.html: Added.
- 4:37 PM Changeset in webkit [263295] by
-
- 10 edits in trunk/Source
[macOS] Connections to the preference daemon are established before entering the sandbox
https://bugs.webkit.org/show_bug.cgi?id=213379
Reviewed by Darin Adler.
Source/WebCore/PAL:
Use correct parameter types in _CFPrefsSetDirectModeEnabled and _CFPrefsSetReadOnly, and move
_CFPrefsSetDirectModeEnabled inside an Objective-C guard, since BOOL only seems to be a builtin
type in Objective-C.
- pal/spi/cf/CFUtilitiesSPI.h:
Source/WebKit:
On macOS, connections to the preference daemon are established before entering the sandbox. These connections also persist
after entering the sandbox and denying access to the preference daemon. There should not be attempts to connect to the
preference daemon before entering the sandbox, since these attempts will not be stopped by the sandbox. This patch moves
code that connects to the preference daemon to be executed after the sandbox has been entered. That includes code to
prevent connections to the Dock and code to initialize WebKit logging. Also, instead of calling [NSBundle bundleForClass:],
call [NSBundle bundleWithIdentifier:], since calling [NSBundle bundleForClass:] will connect to the preference daemon.
Finally, allow the syscall SYS_gethostuuid, since that is needed by CoreFoundation when there is no access to the
preference daemon.
No new tests. This should be covered by existing tests. It would be nice to have a test to make sure that there are no
connections to the preference daemon just before entering the sandbox, but I am not aware of how to implement this.
- NetworkProcess/mac/NetworkProcessMac.mm:
(WebKit::NetworkProcess::initializeSandbox):
- Shared/AuxiliaryProcess.cpp:
(WebKit::AuxiliaryProcess::initialize):
- Shared/Cocoa/WebKit2InitializeCocoa.mm:
(WebKit::runInitializationCode):
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceMain):
- Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::webKit2Bundle):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::initializeSandbox):
- WebProcess/com.apple.WebProcess.sb.in:
- 4:12 PM Changeset in webkit [263294] by
-
- 1 copy in tags/Safari-610.1.17.1
Tag Safari-610.1.17.1.
- 3:50 PM Changeset in webkit [263293] by
-
- 5 edits in trunk/Source
Avoid initializing RenderTheme singleton unnecessarily in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=213406
Reviewed by Per Arne Vollan.
Avoid initializing RenderTheme singleton unnecessarily in the UIProcess. Instead, introduce
a static function to get the focus ring color on iOS.
Source/WebCore:
- rendering/RenderThemeIOS.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::systemFocusRingColor):
(WebCore::RenderThemeIOS::platformFocusRingColor const):
Source/WebKit:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- 3:40 PM Changeset in webkit [263292] by
-
- 2 edits in trunk/Source/JavaScriptCore
toString of String doesn't check integrity of structureID in one path.
https://bugs.webkit.org/show_bug.cgi?id=213338
Reviewed by Saam Barati.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncToString):
- 3:22 PM Changeset in webkit [263291] by
-
- 8 edits8 adds in trunk/Tools
Bring up watchOS/tvOS on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=213402
<rdar://problem/64542588>
Reviewed by Aakash Jain.
- BuildSlaveSupport/build.webkit.org-config/config.json: Add AppleTV and watchOS builders.
- BuildSlaveSupport/build.webkit.org-config/factories.py:
(BuildFactory.init): Support AppleTV and watchOS.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/TvOS13Simulator@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOS6@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WatchOSSimulator6@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
- BuildSlaveSupport/build.webkit.org-config/steps.py:
- BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
- 3:13 PM Changeset in webkit [263290] by
-
- 6 edits in trunk
Have a memory monitor thread in jsc shell when running tests using --memory-limited
https://bugs.webkit.org/show_bug.cgi?id=213389
Reviewed by Mark Lam.
Source/JavaScriptCore:
When testing on iOS, there are times high memory usage from a JSC test
will jetsam our entire test runner. This makes it so we don't get any test
results from that test run, which can make it difficult to track testing
results.
This patch introduces an optional memory monitoring thread to the JSC
shell. It's a best effort approach. If memory usage exceeds the passed
in threshold, we crash the process. Similar to how the timeout mechanism
works. On Cocoa platforms, we also perform this check in the low memory
warning handler.
Currently, we use this feature when running JSC stress tests in
"--memory-limited" mode.
- jsc.cpp:
(crashIfExceedingMemoryLimit):
(startMemoryMonitoringThreadIfNeeded):
(jscmain):
Tools:
- Scripts/run-jsc-stress-tests:
- Scripts/webkitruby/jsc-stress-test-writer-default.rb:
- Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
- 2:43 PM Changeset in webkit [263289] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed build fix after r263288.
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- 2:31 PM Changeset in webkit [263288] by
-
- 9 edits in trunk/Source/WebKit
Use ASCIILiteral more for SandboxExtension functions
https://bugs.webkit.org/show_bug.cgi?id=213400
Reviewed by Per Arne Vollan.
Use ASCIILiteral more for SandboxExtension functions. Functions like createHandleForMachLookup() / createHandleForIOKitClassExtension()
don't need to take in Strings, ASCIILiteral is enough.
- Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::createHandlesForResources):
(WebKit::SandboxExtension::createReadOnlyHandlesForFiles):
(WebKit::SandboxExtension::createHandleForGenericExtension):
(WebKit::SandboxExtension::createHandleForMachLookup):
(WebKit::SandboxExtension::createHandlesForMachLookup):
(WebKit::SandboxExtension::createHandleForIOKitClassExtension):
(WebKit::SandboxExtension::createHandlesForIOKitClassExtensions):
- Shared/SandboxExtension.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::mediaRelatedMachServices):
(WebKit::nonBrowserServices):
(WebKit::diagnosticServices):
(WebKit::agxCompilerClasses):
(WebKit::WebProcessPool::platformInitializeWebProcess):
- UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::enableRemoteInspectorIfNeeded):
- UIProcess/GPU/GPUProcessProxy.cpp:
(WebKit::GPUProcessProxy::singleton):
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::finishGrantingRequest):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::grantAccessToAssetServices):
- 2:12 PM Changeset in webkit [263287] by
-
- 7 edits in trunk/Source/WebKit
[iOS, macOS] Allow access to the container manager to support Mail InjectedBundle
https://bugs.webkit.org/show_bug.cgi?id=213357
<rdar://problem/63837247>
Reviewed by Darin Adler.
The Mail Injected Bundle requires access to the container manager to support certain OS operations. We do not need
this access for web browsing, and should limit this access to this one case.
This patch creates a dynamic mach extension to the container manager for this single use case. It also denies the
non-extension access case with a backtrace so we can see if any other clients are hitting this.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):
- WebProcess/com.apple.WebProcess.sb.in:
- 2:08 PM Changeset in webkit [263286] by
-
- 1 copy in tags/Safari-609.3.5.0.1
Tag Safari-609.3.5.0.1.
- 2:03 PM Changeset in webkit [263285] by
-
- 4 edits in trunk/Source
AX: web process crash in AXObjectCache::postNotification.
https://bugs.webkit.org/show_bug.cgi?id=213398
Reviewed by Chris Fleizach.
AXObjectCache was being instantiated on the AX secondary thread.
Therefore the timers for the different delayed notifications where
initialized with the secondary thread. When postNotification was triggered
on the main thread as it should, and the timer was accessed, the timer
would assert/crash for being accessed in a thread different than where
it was created. This change guaranties that AXObjectCache is always
created on the main thread.
Source/WebCore:
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::enableAccessibility):
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::postNotification):
Source/WebKit:
- WebProcess/WebPage/mac/WKAccessibilityWebPageObjectBase.mm:
(-[WKAccessibilityWebPageObjectBase axObjectCache]):
(-[WKAccessibilityWebPageObjectBase accessibilityPluginObject]):
(-[WKAccessibilityWebPageObjectBase accessibilityRootObjectWrapper]):
(-[WKAccessibilityWebPageObjectBase setWebPage:]):
(-[WKAccessibilityWebPageObjectBase setHasMainFramePlugin:]):
(-[WKAccessibilityWebPageObjectBase setRemoteParent:]):
- 2:03 PM Changeset in webkit [263284] by
-
- 5 edits in trunk/Source/ThirdParty/ANGLE
[ANGLE] Correct Catalyst guards
https://bugs.webkit.org/show_bug.cgi?id=211410
<rdar://problem/62891185>
Reviewed by Dean Jackson.
- src/libANGLE/renderer/gl/eagl/DeviceEAGL.cpp: Do not compile on Mac.
- src/libANGLE/renderer/gl/eagl/DeviceEAGL.h: Definitions should not be available on Mac.
- src/libANGLE/renderer/gl/eagl/DisplayEAGL.h: Definitions should not be available on Mac.
- src/libANGLE/renderer/gl/eagl/DisplayEAGL.mm: Do not compile on Mac.
- 2:00 PM Changeset in webkit [263283] by
-
- 3 edits1 add in trunk
Make $vm properties non-configurable, non-enumerable, and non-writable.
https://bugs.webkit.org/show_bug.cgi?id=213395
Reviewed by Saam Barati and Yusuke Suzuki.
JSTests:
- stress/dollarVM-properties-should-not-be-enumerable.js: Added.
Source/JavaScriptCore:
$vm provides functions for test development and VM debugging. There's no reason
for them to be configurable, enumerable, and writable.
We particularly don't want them to be enumerable as this can trip up some fuzzers.
Fuzzers should not be fuzzing the $vm object which doesn't exist in real world
uses of JavaScriptCore.
- tools/JSDollarVM.cpp:
(JSC::JSDollarVM::finishCreation):
(JSC::JSDollarVM::addFunction):
(JSC::JSDollarVM::addConstructibleFunction):
- 1:13 PM Changeset in webkit [263282] by
-
- 2 edits in trunk/Source/WebCore
[iOS] RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID()
https://bugs.webkit.org/show_bug.cgi?id=213396
Reviewed by Timothy Hatcher.
RenderThemeIOS::cssValueToSystemColorMap() does an unnecessary linear search under systemColorFromCSSValueID().
cssValueToSystemColorMap() already has the selector, yet it passes a CSSValueID to systemColorFromCSSValueID() which
then does a linear search to match the CSSValueID to a selector. This was very inefficient / unfortunate.
This patch introduces a systemColorFromCSSValueIDSelector() which takes in a selector instead of a CSSValueID. I have
also moved the constructor of the LocalCurrentTraitCollection variable to the call site so that we don't keep
constructing / destroying it for each loop iteration. The traces show us spending a lot of time in its constructor /
destructor.
- rendering/RenderThemeIOS.mm:
(WebCore::systemColorFromCSSValueIDSelector):
(WebCore::RenderThemeIOS::cssValueToSystemColorMap):
- 12:59 PM Changeset in webkit [263281] by
-
- 33 edits in trunk
[WebGL2] Uniform Buffer Objects
https://bugs.webkit.org/show_bug.cgi?id=209518
Patch by James Darpinian <James Darpinian> on 2020-06-19
Reviewed by Dean Jackson.
All uniform buffer object conformance tests pass.
Implemented Uniform Buffer Object related functions:
bindBufferBase, bindBufferRange, getUniformIndices, getActiveUniforms, getUniformBlockIndex,
getActiveUniformBlockParameter, getActiveUniformBlockName, uniformBlockBinding
Additionally, fixed many tangentially related issues:
getIntegeri_v and getInteger64i_v were not present.
drawArraysInstances and drawElementsInstanced did not work for WebGL 2.
drawRangeElements was not implemented.
WebGLAny did not support Vector<unsigned>, so Uint32Arrays could not be returned from WebGL functions.
The maximum uniform location length was wrong for WebGL 2.
Transform feedback indexed binding points weren't being tracked.
Some functions in ExtensionsGLANGLE didn't call makeContextCurrent.
New WebGL 2 buffer usage types COPY and READ weren't supported in bufferData.
pause/resumeTransformFeedback were unimplemented.
getParameter(READ_BUFFER) was unimplemented.
readBuffer conformance test was incorrect.
- bindings/js/JSDOMConvertWebGL.cpp:
(WebCore::convertToJSValue):
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::~WebGL2RenderingContext):
(WebCore::WebGL2RenderingContext::initializeNewContext):
(WebCore::WebGL2RenderingContext::drawRangeElements):
(WebCore::WebGL2RenderingContext::setIndexedBufferBinding):
(WebCore::WebGL2RenderingContext::bindBufferBase):
(WebCore::WebGL2RenderingContext::bindBufferRange):
(WebCore::WebGL2RenderingContext::getIndexedParameter):
(WebCore::WebGL2RenderingContext::getUniformIndices):
(WebCore::WebGL2RenderingContext::getActiveUniforms):
(WebCore::WebGL2RenderingContext::getUniformBlockIndex):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockParameter):
(WebCore::WebGL2RenderingContext::getActiveUniformBlockName):
(WebCore::WebGL2RenderingContext::uniformBlockBinding):
- html/canvas/WebGL2RenderingContext.h:
- html/canvas/WebGLAny.h:
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::validateLocationLength):
(WebCore::WebGLRenderingContextBase::validateBufferDataParameters):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
- platform/graphics/GraphicsContextGL.h:
- platform/graphics/angle/ExtensionsGLANGLE.cpp:
(WebCore::ExtensionsGLANGLE::getTranslatedShaderSourceANGLE):
(WebCore::ExtensionsGLANGLE::blitFramebuffer):
(WebCore::ExtensionsGLANGLE::renderbufferStorageMultisample):
(WebCore::ExtensionsGLANGLE::drawBuffersEXT):
(WebCore::ExtensionsGLANGLE::getBooleanvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFloatvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFramebufferAttachmentParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getIntegervRobustANGLE):
(WebCore::ExtensionsGLANGLE::getProgramivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getRenderbufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getShaderivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribPointervRobustANGLE):
(WebCore::ExtensionsGLANGLE::readPixelsRobustANGLE):
(WebCore::ExtensionsGLANGLE::texImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texSubImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage2DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::compressedTexSubImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::texSubImage3DRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferPointervRobustANGLE):
(WebCore::ExtensionsGLANGLE::getIntegeri_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInternalformativRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getVertexAttribIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getUniformuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getActiveUniformBlockivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getInteger64i_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBufferParameteri64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getFramebufferParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getProgramInterfaceivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getBooleani_vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getMultisamplefvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexLevelParameterivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexLevelParameterfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getPointervRobustANGLERobustANGLE):
(WebCore::ExtensionsGLANGLE::readnPixelsRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformfvRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getnUniformuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::texParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getTexParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::samplerParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterIivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getSamplerParameterIuivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectivRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjecti64vRobustANGLE):
(WebCore::ExtensionsGLANGLE::getQueryObjectui64vRobustANGLE):
- platform/graphics/angle/GraphicsContextGLANGLE.cpp:
(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
(WebCore::GraphicsContextGLOpenGL::getInteger64v):
(WebCore::GraphicsContextGLOpenGL::getInteger64i_v):
(WebCore::GraphicsContextGLOpenGL::drawArraysInstanced):
(WebCore::GraphicsContextGLOpenGL::drawElementsInstanced):
(WebCore::GraphicsContextGLOpenGL::getUniformBlockIndex):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockiv):
(WebCore::GraphicsContextGLOpenGL::getActiveUniformBlockName):
(WebCore::GraphicsContextGLOpenGL::uniformBlockBinding):
(WebCore::GraphicsContextGLOpenGL::drawRangeElements):
(WebCore::GraphicsContextGLOpenGL::pauseTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::resumeTransformFeedback):
(WebCore::GraphicsContextGLOpenGL::bindBufferRange):
(WebCore::GraphicsContextGLOpenGL::getUniformIndices):
- platform/graphics/opengl/GraphicsContextGLOpenGL.h:
- platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:
(WebCore::GraphicsContextGLOpenGL::getIntegeri_v):
- platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:
(WebCore::GraphicsContextGLOpenGL::getInteger64v):
(WebCore::GraphicsContextGLOpenGL::getInteger64i_v):
- 12:52 PM Changeset in webkit [263280] by
-
- 2 edits in trunk/Source/WTF
-Wsign-compare in isValidOptionSet
https://bugs.webkit.org/show_bug.cgi?id=213383
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-19
Reviewed by Darin Adler.
The OptionSet's StorageType is always unsigned, even if the enum's underlying value is not.
Match this in isValidOptionSet to avoid -Wsign-compare during validity checking.
- wtf/OptionSet.h:
(WTF::isValidOptionSet):
- 12:39 PM Changeset in webkit [263279] by
-
- 15 edits2 moves2 adds in branches/safari-610.1.17-branch
Reintroduce content to branch.
This reverts r263238.
- 11:43 AM Changeset in webkit [263278] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Drop std::call_once() from RenderThemeIOS::cssValueToSystemColorMap()
https://bugs.webkit.org/show_bug.cgi?id=213392
Reviewed by Geoffrey Garen.
Drop std::call_once() from RenderThemeIOS::cssValueToSystemColorMap() since this function
is always called from the main thread.
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::cssValueToSystemColorMap):
- 11:07 AM Changeset in webkit [263277] by
-
- 2 edits in trunk/Source/JavaScriptCore
functionCpuClflush checks that the second argument is Int32 but it actually expects it to be UInt32
https://bugs.webkit.org/show_bug.cgi?id=213388
Patch by Tuomas Karkkainen <tuomas.webkit@apple.com> on 2020-06-19
Reviewed by Saam Barati.
This changes the check from isInt32() to isUInt32() so that the logic is consistent.
- tools/JSDollarVM.cpp:
- 10:15 AM Changeset in webkit [263276] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Update test expectations after r263268.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 10:11 AM Changeset in webkit [263275] by
-
- 8 edits in trunk
AX: Make isolated tree enablement status dependent on client preference
https://bugs.webkit.org/show_bug.cgi?id=213355
<rdar://problem/64506577>
Reviewed by Zalan Bujtas.
Source/WebKit:
We don't want the isolated tree mode in all clients (like Mail or Dictionary).
As a result, we can set this setting to off and allow safari and mini browser turn on more directly.
- Shared/WebPreferences.yaml:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setAccessibilityIsolatedTreeEnabled:]):
(-[WKPreferences _accessibilityIsolatedTreeEnabled]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setAccessibilityIsolatedTreeEnabled):
- WebProcess/InjectedBundle/InjectedBundle.h:
Tools:
- MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate defaultConfiguration]):
- 10:07 AM Changeset in webkit [263274] by
-
- 4 edits in trunk/Source
Enable referrer policy attribute support by default
https://bugs.webkit.org/show_bug.cgi?id=213285
Patch by Rob Buis <rbuis@igalia.com> on 2020-06-19
Reviewed by Youenn Fablet.
Enable referrer policy attribute support by default by flipping the switch.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
Source/WebKit:
- Shared/WebPreferences.yaml:
- 9:45 AM Changeset in webkit [263273] by
-
- 2 edits in trunk/WebDriverTests
[WebDriver][GTK] Some tests fails to click elements because element is outside visible rect
https://bugs.webkit.org/show_bug.cgi?id=211330
Unreviewed test gardening.
These tests have been passing since r262861 landed.
- TestExpectations.json:
- 9:34 AM Changeset in webkit [263272] by
-
- 3 edits in trunk/Source/WebKit
LibWebRTCSocketClient::sendTo is too verbose in case of error
https://bugs.webkit.org/show_bug.cgi?id=213380
Reviewed by Eric Carlson.
Only log error message if the error code is different from the previous one.
- NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:
(WebKit::LibWebRTCSocketClient::sendTo):
- NetworkProcess/webrtc/LibWebRTCSocketClient.h:
- 9:30 AM Changeset in webkit [263271] by
-
- 3 edits in trunk/Source/WebKit
Web Inspector: RemoteInspector::singleton() slows down MobileSafari launch
https://bugs.webkit.org/show_bug.cgi?id=213381
<rdar://problem/64533003>
Reviewed by Darin Adler.
RemoteInspector::singleton() is expensive according to traces. It was called in WebProcessPool::initializeNewWebProcess()
which happens on MobileSafari launch because we prewarm a WebProcess. However, there is no reason to initialize remote
Web Inspector at this point. Per associated comment, Remote Web Inspector needs to be initialized once there is a
sub process hosting one of our Web View. As a result, I moved the initialization call to WebPageProxy::initializeWebPage()
which is when we actually send the IPC to the WebProcess to create the WebPage that is backing the UI-side WebView.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
- 9:21 AM Changeset in webkit [263270] by
-
- 13 edits in trunk/Source
Move Prefixed WebAudio interfaces behind their own feature flag
https://bugs.webkit.org/show_bug.cgi?id=213356
Reviewed by Darin Adler.
Source/WebCore:
Move Prefixed WebAudio interfaces behind their own feature flag, on by default. This will
allow us to easily disable the prefixed API and will also allow it to live independently
from the unprefixed API.
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/WebKitAudioContext.idl:
- Modules/webaudio/WebKitAudioPannerNode.idl:
- Modules/webaudio/WebKitOfflineAudioContext.idl:
- bindings/js/WebCoreBuiltinNames.h:
- page/Settings.yaml:
Source/WebKit:
- Shared/WebPreferences.yaml:
Source/WebKitLegacy/mac:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
- 9:18 AM Changeset in webkit [263269] by
-
- 2 edits in trunk/Source/WebKit
Enable stale-while-revalidate support by default
https://bugs.webkit.org/show_bug.cgi?id=213286
Patch by Rob Buis <rbuis@igalia.com> on 2020-06-19
Reviewed by Youenn Fablet.
Enable stale-while-revalidate support for Mac/GTK/WPE by changing the default
to true. Note that platforms that do not support speculative loads, which s-w-r
relies on, will not see any change in bahavior.
- UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h:
- 8:39 AM Changeset in webkit [263268] by
-
- 3 edits2 adds in trunk
[LFC][TFC] Do not special-case empty tables
https://bugs.webkit.org/show_bug.cgi?id=213378
Reviewed by Antti Koivisto.
Source/WebCore:
Now that min/max-width support is added, empty tables can just go through the normal width computation path.
Test: fast/layoutformattingcontext/table-min-max-width-empty-content-simple.html
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):
LayoutTests:
- fast/layoutformattingcontext/table-min-max-width-empty-content-simple-expected.html: Added.
- fast/layoutformattingcontext/table-min-max-width-empty-content-simple.html: Added.
- 8:31 AM Changeset in webkit [263267] by
-
- 3 edits in trunk/Tools
Improve handling of trac downtime by commit-queue
https://bugs.webkit.org/show_bug.cgi?id=213377
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-build/steps.py: Load contributors.json from disk when loading from trac fails.
(ValidateCommiterAndReviewer.load_contributors_from_disk):
(ValidateCommiterAndReviewer.load_contributors_from_trac):
(ValidateCommiterAndReviewer.load_contributors):
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test
- 8:28 AM Changeset in webkit [263266] by
-
- 2 edits in trunk/LayoutTests
Mac wk2 Debug] webaudio/biquad-bandpass.html is flaky crashing with alert WTFCrash - WebCore::WebKitAudioContext::~WebKitAudioContext() + 654 (WebKitAudioContext.cpp:209).
https://bugs.webkit.org/show_bug.cgi?id=213375
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:35 AM Changeset in webkit [263265] by
-
- 7 edits in trunk
REGRESSION(r262254?): [WPE] imported/w3c/web-platform-tests/webxr/idlharness.https.window.html is failing
https://bugs.webkit.org/show_bug.cgi?id=212897
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
- web-platform-tests/webxr/idlharness.https.window-expected.txt: Updated expectations.
Source/WebCore:
WPT tests were updated in r262254 and they already include the latest changes in the specs. Among others the
XR interface was renamed to XRSystem. We were already using that name in the C++ code but not in the JS interface.
The WPT update brings in another set of changes like the new XRLayer which is already not supported (I am
adding it soon in another patch). Last but not least, the new tests include checks for the XRPermissionStatus interface
which is not going to be implemented soon as it requires the Permission API which is not supported in WebKit yet. All in
all, this patch renames XR to XRSystem and marks as failing the XRLayer (temporarily) and XRPermissionStatus checks.
No new tests as there is no change in functionality.
- Modules/webxr/WebXRSystem.idl: Rename XR to XRSystem.
- bindings/js/WebCoreBuiltinNames.h: Ditto.
LayoutTests:
- platform/wpe/TestExpectations: Re-enable the idlharness.https.window.html test.
- 6:52 AM Changeset in webkit [263264] by
-
- 71 edits7 copies9 adds in trunk/WebDriverTests
[WebDriver][WPE] Update imported selenium to a version with the WPE WebDriver
https://bugs.webkit.org/show_bug.cgi?id=213263
Reviewed by Carlos Garcia Campos.
Updated Selenium tests to 0d7e57a7079c, which added the WPE WebDriver.
- imported/selenium/common/src/web/button.png: Added.
- imported/selenium/common/src/web/formPage.html:
- imported/selenium/common/src/web/inputs.html:
- imported/selenium/common/src/web/relative_locators.html: Added.
- imported/selenium/common/src/web/screen/screen.css:
- imported/selenium/common/src/web/selectableItems.html:
- imported/selenium/common/src/web/simpleTest.html:
- imported/selenium/common/src/web/upload.html:
- imported/selenium/common/src/web/upload_invisible.html:
- imported/selenium/common/src/web/xhtmlTest.html:
- imported/selenium/importer.json: Modified hash and skipped folders
- imported/selenium/py/conftest.py:
- imported/selenium/py/selenium/init.py:
- imported/selenium/py/selenium/common/exceptions.py:
- imported/selenium/py/selenium/webdriver/init.py:
- imported/selenium/py/selenium/webdriver/common/action_chains.py:
- imported/selenium/py/selenium/webdriver/common/actions/action_builder.py:
- imported/selenium/py/selenium/webdriver/common/actions/input_device.py:
- imported/selenium/py/selenium/webdriver/common/actions/interaction.py:
- imported/selenium/py/selenium/webdriver/common/actions/key_actions.py:
- imported/selenium/py/selenium/webdriver/common/actions/mouse_button.py:
- imported/selenium/py/selenium/webdriver/common/actions/pointer_actions.py:
- imported/selenium/py/selenium/webdriver/common/actions/pointer_input.py:
- imported/selenium/py/selenium/webdriver/common/alert.py:
- imported/selenium/py/selenium/webdriver/common/desired_capabilities.py:
- imported/selenium/py/selenium/webdriver/common/html5/application_cache.py:
- imported/selenium/py/selenium/webdriver/common/options.py: Added.
- imported/selenium/py/selenium/webdriver/common/proxy.py:
- imported/selenium/py/selenium/webdriver/common/timeouts.py: Added.
- imported/selenium/py/selenium/webdriver/common/utils.py:
- imported/selenium/py/selenium/webdriver/common/window.py: Copied from WebDriverTests/imported/selenium/py/selenium/init.py.
- imported/selenium/py/selenium/webdriver/remote/command.py:
- imported/selenium/py/selenium/webdriver/remote/errorhandler.py:
- imported/selenium/py/selenium/webdriver/remote/remote_connection.py:
- imported/selenium/py/selenium/webdriver/remote/switch_to.py:
- imported/selenium/py/selenium/webdriver/remote/utils.py:
- imported/selenium/py/selenium/webdriver/remote/webdriver.py:
- imported/selenium/py/selenium/webdriver/remote/webelement.py:
- imported/selenium/py/selenium/webdriver/safari/permissions.py: Copied from WebDriverTests/imported/selenium/py/selenium/init.py.
- imported/selenium/py/selenium/webdriver/safari/remote_connection.py: Copied from WebDriverTests/imported/selenium/py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py.
- imported/selenium/py/selenium/webdriver/safari/service.py:
- imported/selenium/py/selenium/webdriver/safari/webdriver.py:
- imported/selenium/py/selenium/webdriver/support/color.py:
- imported/selenium/py/selenium/webdriver/support/event_firing_webdriver.py:
- imported/selenium/py/selenium/webdriver/support/expected_conditions.py:
- imported/selenium/py/selenium/webdriver/support/relative_locator.py: Added.
- imported/selenium/py/selenium/webdriver/support/select.py:
- imported/selenium/py/selenium/webdriver/support/wait.py:
- imported/selenium/py/selenium/webdriver/webkitgtk/options.py:
- imported/selenium/py/selenium/webdriver/webkitgtk/webdriver.py:
- imported/selenium/py/selenium/webdriver/wpewebkit/init.py: Copied from WebDriverTests/imported/selenium/py/selenium/init.py.
- imported/selenium/py/selenium/webdriver/wpewebkit/options.py: Copied from WebDriverTests/imported/selenium/py/selenium/webdriver/webkitgtk/options.py.
- imported/selenium/py/selenium/webdriver/wpewebkit/service.py: Copied from WebDriverTests/imported/selenium/py/selenium/webdriver/safari/service.py.
- imported/selenium/py/selenium/webdriver/wpewebkit/webdriver.py: Copied from WebDriverTests/imported/selenium/py/selenium/webdriver/webkitgtk/webdriver.py.
- imported/selenium/py/test/selenium/webdriver/common/alerts_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/api_example_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/appcache_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/click_scrolling_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/cookie_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/correct_event_firing_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/driver_element_finding_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/element_attribute_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/executing_async_javascript_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/form_handling_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/frame_switching_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/interactions_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/page_load_timeout_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/page_loading_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/position_and_size_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/proxy_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/rendered_webelement_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/select_class_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/select_element_handling_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/takes_screenshots_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/timeout_tests.py: Added.
- imported/selenium/py/test/selenium/webdriver/common/typing_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/w3c_interaction_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/webdriverwait_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/window_switching_tests.py:
- imported/selenium/py/test/selenium/webdriver/common/window_tests.py:
- imported/selenium/py/test/selenium/webdriver/remote/remote_firefox_profile_tests.py:
- imported/selenium/py/test/selenium/webdriver/safari/launcher_tests.py:
- imported/selenium/py/test/selenium/webdriver/support/event_firing_webdriver_tests.py:
- imported/selenium/py/test/selenium/webdriver/support/expected_conditions_tests.py: Added.
- imported/selenium/py/test/selenium/webdriver/support/relative_by_tests.py: Added.
- 6:40 AM Changeset in webkit [263263] by
-
- 2 edits in trunk/Tools
[WPE] Warn potential issues when creating WindowViewBackend
https://bugs.webkit.org/show_bug.cgi?id=213326
Reviewed by Philippe Normand.
Make it easier to debug eventual GL issues when starting up MiniBrowser in
windowed mode.
- wpe/backends/WindowViewBackend.cpp:
(WPEToolingBackends::WaylandEGLConnection::singleton):
(WPEToolingBackends::WindowViewBackend::WindowViewBackend):
- 6:34 AM Changeset in webkit [263262] by
-
- 4 edits in trunk/LayoutTests
[GTK] Garden some flaky crashes and start expect reorg
Unreviewed test gardening.
Also start new section in the top of the file to follow the glib
expectation grouping.
- platform/gtk-wayland/TestExpectations:
- platform/gtk/TestExpectations:
- platform/glib/TestExpectations:
- 6:18 AM Changeset in webkit [263261] by
-
- 5 edits in trunk/Tools
[webkitpy][WPE] Default to headless if _display_server is xfvb
https://bugs.webkit.org/show_bug.cgi?id=213327
Reviewed by Philippe Normand.
Xvfb is used as the default display server for some scripts, and the
equivalent for WPE is the headless one.
WTR and the API tests already create only HeadlessViewBackends, but the
WebDriver tests create them through MiniBrowser, which requires the
'--headless' parameter.
- Scripts/run-webdriver-tests: Do not override _display_server
- Scripts/webkitpy/port/base.py:
(Port.init): Define _display_server for all ports to avoid
eventually needing to override it.
- Scripts/webkitpy/port/wpe.py:
(WPEPort.init): Default to 'headless' if _display_server is 'xvfb'
- Scripts/webkitpy/w3c/wpt_runner.py:
(main): Dot not override _display_server
- 5:43 AM Changeset in webkit [263260] by
-
- 6 edits2 adds in trunk
[LFC][BFC] Min/max-width should always be resolved against the containing block width
https://bugs.webkit.org/show_bug.cgi?id=213365
Reviewed by Antti Koivisto.
Source/WebCore:
Even when neighboring floats shrink the available horizontal space, the min/max(normal) widths should
be resolved against the containing block's logical width.
Test: fast/layoutformattingcontext/float-avoider-available-horizontal-space2.html
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::computedWidthAndMargin):
- layout/blockformatting/tablewrapper/TableWrapperBlockFormattingContext.cpp:
(WebCore::Layout::TableWrapperBlockFormattingContext::computeWidthAndMarginForTableBox):
LayoutTests:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space2-expected.html: Added.
- fast/layoutformattingcontext/float-avoider-available-horizontal-space2.html: Added.
- 5:27 AM Changeset in webkit [263259] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r253360): [GTK] Page starts loading during animation in back/forward gesture
https://bugs.webkit.org/show_bug.cgi?id=205650
Patch by Alexander Mikhaylenko <Alexander Mikhaylenko> on 2020-06-19
Reviewed by Carlos Garcia Campos.
r253360 changed the swipe gesture to start loading the page during the gesture, relying on
freezing the layer tree state to prevent unwanted redraws. However, it was implemented for
AC mode, but didn't prevent redraws in non-accelerated mode. Add a simple check to skip
redraws in this case.
- WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:
(WebKit::DrawingAreaCoordinatedGraphics::display): Skip drawing if layer tree state is frozen.
- 12:49 AM Changeset in webkit [263258] by
-
- 17 edits in trunk
Add support for fetching registrable domains with resource load statistics
https://bugs.webkit.org/show_bug.cgi?id=213291
Source/WebKit:
Reviewed by Adrian Perez de Castro and Youenn Fablet.
WebsiteDataStore::fetchData() doesn't return anything for resource load statistics because
NetworkProcess::fetchWebsiteData() doesn't handle WebsiteDataType::ResourceLoadStatistics.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
(WebKit::ResourceLoadStatisticsDatabaseStore::allDomains const): Query all registrable domains from database.
- NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::allDomains const): Return all registrable domains in memory map.
- NetworkProcess/Classifier/ResourceLoadStatisticsMemoryStore.h:
- NetworkProcess/Classifier/ResourceLoadStatisticsStore.h:
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::registrableDomains): Get the list of registrable domains.
- NetworkProcess/Classifier/WebResourceLoadStatisticsStore.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::fetchWebsiteData): Handle WebsiteDataType::ResourceLoadStatistics.
- Shared/WebsiteData/WebsiteData.cpp:
(WebKit::WebsiteData::encode const): Encode registrableDomainsWithResourceLoadStatistics.
(WebKit::WebsiteData::decode): Decode registrableDomainsWithResourceLoadStatistics.
- Shared/WebsiteData/WebsiteData.h:
- UIProcess/API/C/WKWebsiteDataStoreRef.cpp:
(WKWebsiteDataStoreRemoveITPDataForDomain): Use WebsiteDataRecord::addResourceLoadStatisticsRegistrableDomain()
instead of the display name.
- UIProcess/WebsiteData/WebsiteDataRecord.cpp:
(WebKit::WebsiteDataRecord::addResourceLoadStatisticsRegistrableDomain): Add the given registrable domain to the list.
- UIProcess/WebsiteData/WebsiteDataRecord.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply): Handle registrable domains with resource load statistics.
(WebKit::WebsiteDataStore::removeData): Use resourceLoadStatisticsRegistrableDomains instead of the display name.
Tools:
Reviewed by Adrian Perez de Castro.
Update GLib ITP unit test to check also fetch and remove.
- TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(testWebsiteDataITP):
- 12:43 AM Changeset in webkit [263257] by
-
- 2 edits in trunk/Tools
Change my (Tomoki Imai's) status to committer
Unreviewed, just updating contributors.json for myself.
- Scripts/webkitpy/common/config/contributors.json:
- 12:32 AM Changeset in webkit [263256] by
-
- 4 edits in trunk/Source/WebCore
[WebXR] unsigned long in IDL should be translated as unsigned in C++ code
https://bugs.webkit.org/show_bug.cgi?id=213020
Reviewed by Darin Adler.
The "unsigned long" type definition in IDL must be translated to unsigned in C++ code.
I'm also replacing the very long XRFrameRequestCallback::Identifier by simply unsigned as it
isn't adding anything.
No new test required as there is no change in functionality, just removing an alias.
- Modules/webxr/WebXRSession.cpp:
(WebCore::WebXRSession::requestAnimationFrame):
(WebCore::WebXRSession::cancelAnimationFrame):
- Modules/webxr/WebXRSession.h:
- Modules/webxr/XRFrameRequestCallback.h:
(WebCore::XRFrameRequestCallback::callbackId):
(WebCore::XRFrameRequestCallback::setCallbackId):
- 12:04 AM Changeset in webkit [263255] by
-
- 25 edits1 copy57 adds in trunk
[Cocoa] Unify "font:" CSS shorthand values between macOS and iOS family
https://bugs.webkit.org/show_bug.cgi?id=213332
<rdar://problem/64479189>
Reviewed by Tim Horton and Darin Adler.
Source/WebCore:
They exist on all Cocoa platforms, so we might as well hook them up.
This unifies the shorthand CSS value handling from RenderThemeMac and
RenderThemeIOS into RenderThemeCocoa. This has two effects:
- It hooks up the -apple-system keywords on macOS (they previously were only implemented for the iOS family).
- It hooks up the CSS2 keywords (caption, menu, etc.) on the iOS family (they previously were only implemented on Mac).
All these fonts have been around since Mojave, so there is no need to
introduce any new platform guards.
Tests: fast/text/text-styles/-apple-system/-apple-system-body.html
fast/text/text-styles/-apple-system/-apple-system-caption1.html
fast/text/text-styles/-apple-system/-apple-system-caption2.html
fast/text/text-styles/-apple-system/-apple-system-footnote.html
fast/text/text-styles/-apple-system/-apple-system-headline.html
fast/text/text-styles/-apple-system/-apple-system-short-body.html
fast/text/text-styles/-apple-system/-apple-system-short-caption1.html
fast/text/text-styles/-apple-system/-apple-system-short-footnote.html
fast/text/text-styles/-apple-system/-apple-system-short-headline.html
fast/text/text-styles/-apple-system/-apple-system-short-subheadline.html
fast/text/text-styles/-apple-system/-apple-system-subheadline.html
fast/text/text-styles/-apple-system/-apple-system-tall-body.html
fast/text/text-styles/-apple-system/-apple-system-title0.html
fast/text/text-styles/-apple-system/-apple-system-title1.html
fast/text/text-styles/-apple-system/-apple-system-title2.html
fast/text/text-styles/-apple-system/-apple-system-title3.html
fast/text/text-styles/-apple-system/-apple-system-title4.html
fast/text/text-styles/-webkit-control.html
fast/text/text-styles/-webkit-mini-control.html
fast/text/text-styles/-webkit-small-control.html
fast/text/text-styles/bogus.html
fast/text/text-styles/caption.html
fast/text/text-styles/icon.html
fast/text/text-styles/menu.html
fast/text/text-styles/message-box.html
fast/text/text-styles/small-caption.html
fast/text/text-styles/status-bar.html
- css/CSSValueKeywords.in: All Cocoa ports should be able to parse these values
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::fontWithFamilySpecialCase): Move code that used to be in the Mac and
iOS implementations of platformFontWithFamilySpecialCase() (inside FontCacheMac.mm
and FontCacheIOS.mm) to be shared to be shared inside fontWithFamilySpecialCase().
- platform/graphics/cocoa/FontDescriptionCocoa.cpp: Remove platform guards.
(WebCore::convertArray):
(WebCore::matchSystemFontUse):
- platform/graphics/cocoa/SystemFontDatabaseCoreText.cpp: Ditto.
(WebCore::SystemFontDatabaseCoreText::createTextStyleFont):
- platform/graphics/ios/FontCacheIOS.mm: Move code from here into FontCacheCoreText.
(WebCore::platformFontWithFamilySpecialCase):
- platform/graphics/mac/FontCacheMac.mm: Ditto.
(WebCore::platformFontWithFamilySpecialCase):
- platform/mac/ThemeMac.h: Delete systemFontSizeFor(NSControlSize) because
<rdar://problem/60350699> is fixed.
- platform/mac/ThemeMac.mm: Ditto.
(WebCore::ThemeMac::controlFont const):
(WebCore::ThemeMac::systemFontSizeFor): Deleted.
- rendering/RenderThemeCocoa.h: Previously, code was calling
RenderThemeIOS::contentSizeCategory(), which was a static function. Now, both Mac
and iOS need to be able to call this. However, the implementation of this function
is different between Mac and iOS. So, turn it from a static function in RenderThemeIOS
into a method in RenderThemeCocoa, and give RenderThemeCocoa a singleton() function
that downcasts the return of RenderTheme::singleton(). This way, instead of calling
RenderThemeIOS::contentSizeCategory(), code can call
RenderThemeCocoa::singleton().contentSizeCategory().
- rendering/RenderThemeCocoa.mm: Move code from RenderThemeIOS and RenderThemeMac
into RenderThemeCocoa.
(WebCore::RenderThemeCocoa::singleton):
(WebCore::RenderThemeCocoa::cachedSystemFontDescription const):
(WebCore::cssWeightOfSystemFont):
(WebCore::RenderThemeCocoa::updateCachedSystemFontDescription const):
- rendering/RenderThemeIOS.h: Ditto.
- rendering/RenderThemeIOS.mm: Ditto.
(WebCore::RenderThemeIOS::contentSizeCategory const):
(WebCore::attachmentActionFont):
(WebCore::attachmentTitleFont):
(WebCore::RenderThemeIOS::contentSizeCategory): Deleted.
(WebCore::RenderThemeIOS::cachedSystemFontDescription const): Deleted.
(WebCore::cssWeightOfSystemFont): Deleted.
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription const): Deleted.
- rendering/RenderThemeMac.h: Ditto.
- rendering/RenderThemeMac.mm: Ditto.
(WebCore::RenderThemeMac::contentSizeCategory const):
(WebCore::RenderThemeMac::setFontFromControlSize const):
(WebCore::RenderThemeMac::controlSizeForSystemFont const):
(WebCore::toFontWeight): Deleted.
(WebCore::RenderThemeMac::updateCachedSystemFontDescription const): Deleted.
Source/WebCore/PAL:
- pal/spi/cocoa/CoreTextSPI.h:
The implementation of RenderThemeMac::contentSizeCategory() needs to use
kCTFontContentSizeCategoryL.
Source/WTF:
All Cocoa platforms support kCTUIFontTextStyleTitle0 and kCTUIFontTextStyleTitle4.
- wtf/PlatformHave.h:
LayoutTests:
- TestExpectations:
- fast/text/text-styles/-apple-system/-apple-system-body-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-body.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-caption1-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-caption1.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-caption2-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-caption2.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-footnote-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-footnote.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-headline-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-headline.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-body-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-body.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-caption1-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-caption1.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-footnote-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-footnote.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-headline-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-headline.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-subheadline-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-short-subheadline.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-subheadline-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-subheadline.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-tall-body-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-tall-body.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title0-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title0.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title1-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title1.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title2-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title2.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title3-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title3.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title4-expected-mismatch.html: Added.
- fast/text/text-styles/-apple-system/-apple-system-title4.html: Added.
- fast/text/text-styles/-webkit-control-expected-mismatch.html: Added.
- fast/text/text-styles/-webkit-control.html: Added.
- fast/text/text-styles/-webkit-mini-control-expected-mismatch.html: Added.
- fast/text/text-styles/-webkit-mini-control.html: Added.
- fast/text/text-styles/-webkit-small-control-expected-mismatch.html: Added.
- fast/text/text-styles/-webkit-small-control.html: Added.
- fast/text/text-styles/bogus-expected.html: Added.
- fast/text/text-styles/bogus.html: Added.
- fast/text/text-styles/caption-expected-mismatch.html: Added.
- fast/text/text-styles/caption.html: Added.
- fast/text/text-styles/icon-expected-mismatch.html: Added.
- fast/text/text-styles/icon.html: Added.
- fast/text/text-styles/menu-expected-mismatch.html: Added.
- fast/text/text-styles/menu.html: Added.
- fast/text/text-styles/message-box-expected-mismatch.html: Added.
- fast/text/text-styles/message-box.html: Added.
- fast/text/text-styles/small-caption-expected-mismatch.html: Added.
- fast/text/text-styles/small-caption.html: Added.
- fast/text/text-styles/status-bar-expected-mismatch.html: Added.
- fast/text/text-styles/status-bar.html: Added.
- platform/ios/TestExpectations:
- platform/ios/fast/css/css2-system-fonts-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/fast/text/international/system-language/system-font-punctuation-expected.txt:
- platform/mac-mojave/fast/text/international/system-language/system-font-punctuation-expected.txt: Added.
Jun 18, 2020:
- 8:59 PM Changeset in webkit [263254] by
-
- 3 edits3 adds in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update test expectations after r263222.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-audio-tainting.https-expected.txt: Added.
- 8:42 PM Changeset in webkit [263253] by
-
- 4 edits in trunk/Source/WebCore
Use paintCellAndSetFocusedElementNeedsRepaintIfNecessary() for search field buttons
https://bugs.webkit.org/show_bug.cgi?id=213352
<rdar://problem/57129008>
Reviewed by Simon Fraser.
The search fields cancel and results buttons should use the common
paintCellAndSetFocusedElementNeedsRepaintIfNecessary() function instead of directly painting the cell.
This allows for an image buffer to be used for drawing specifically in cases when it becomes needed,
when a scale (either via zoom or CSS transform) is applied.
This also moves the logic for determining if an image buffer should be used into
ThemeMac::drawCellOrFocusRingWithViewIntoContext(), which uses the current user-defined CTM
(inverting the base CTM to negate the effect of a device-specific scale factor). This also negates
the need for the page scale factor and the effective zoom applied to the renderer style, since it is
computed into the CTM already.
- platform/mac/ThemeMac.h:
- platform/mac/ThemeMac.mm:
(WebCore::paintToggleButton):
(WebCore::paintButton):
(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext):
(WebCore::paintColorWell):
(WebCore::ThemeMac::paint):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintCellAndSetFocusedElementNeedsRepaintIfNecessary):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
- 8:30 PM Changeset in webkit [263252] by
-
- 7 edits in trunk/Source
Unify Bitmap math loops in MarkedBlock::Handle::specializedSweep().
https://bugs.webkit.org/show_bug.cgi?id=213345
Reviewed by Robin Morisset and Saam Barati.
Source/JavaScriptCore:
This change appears to be performance neutral. However, we'll take the change
because we know that it does less work, and the new way of expressing the Bitmap
math in MarkedBlock::Handle::specializedSweep() does appear to be easier to
understand than the old code.
Also addressed feedback from Robin and Saam in https://bugs.webkit.org/show_bug.cgi?id=213071.
Changes made:
- Use the new Bitmap::words() API to get direct access to the underlying bits storage. With this, we can do the merging of the marked and newlyAllocated bits with a single pass looping thru the bitmap words.
- In MarkedBlock::Handle::specializedSweep()'s Bitmap free list code, moved the implementation of handleDeadCells lambda down to the call to freeAtoms.forEachSetBit() because this is the only place it is used.
- Fixed MarkedBlock::Handle::specializedSweep()'s Bitmap free list code to handle the dead cells unconditionally. This condition check was wrongly adapted from the linked list implementation where handleDeadCell() was called in 2 places depending on the destruction mode. With the Bitmap free list, there is only once place to handle the dead cells, and it should be executed unconditionally.
This fixes a bug where the FreeList::originalSize() never gets computed if the
cells in the block does not need destruction.
- Renamed FreeList::bitmapRows() to FreeList::bitmapRowsMinusOne(). Renamed FreeList::offsetOfBitmapRows() to FreeList::offsetOfBitmapRowsMinusOne().
- Also fixed some typos in comments.
- heap/FreeList.h:
(JSC::FreeList::bitmapIsEmpty const):
(JSC::FreeList::offsetOfBitmapRowsMinusOne):
(JSC::FreeList::bitmapRowsMinusOne const):
(JSC::FreeList::offsetOfBitmapRows): Deleted.
(JSC::FreeList::bitmapRows const): Deleted.
- heap/FreeListInlines.h:
(JSC::FreeList::allocate):
(JSC::FreeList::forEach const):
- heap/MarkedBlockInlines.h:
(JSC::MarkedBlock::Handle::specializedSweep):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):
Source/WTF:
- Removed Bitmap::words. Use Bitmap::numberOfWords instead.
- Removed Bitmap::wordSize. Use Bitmap::bitsInWord instead.
- Added a new Bitmap::words() method which returns the address of the underlying bitmap storage as a Bitmap::Word*. This enables clients to do direct bit manipulation on the Bitmap words if needed.
- wtf/Bitmap.h:
(WTF::WordType>::get const):
(WTF::WordType>::set):
(WTF::WordType>::testAndSet):
(WTF::WordType>::testAndClear):
(WTF::WordType>::concurrentTestAndSet):
(WTF::WordType>::concurrentTestAndClear):
(WTF::WordType>::clear):
(WTF::WordType>::invert):
(WTF::WordType>::nextPossiblyUnset const):
(WTF::WordType>::count const):
(WTF::WordType>::isEmpty const):
(WTF::WordType>::isFull const):
(WTF::WordType>::merge):
(WTF::WordType>::filter):
(WTF::WordType>::exclude):
(WTF::WordType>::concurrentFilter):
(WTF::WordType>::subsumes const):
(WTF::WordType>::forEachSetBit const):
(WTF::WordType>::findBit const):
(WTF::WordType>::mergeAndClear):
(WTF::WordType>::setAndClear):
(WTF::WordType>::setEachNthBit):
(WTF::= const):
(WTF::=):
(WTF::WordType>::hash const):
- 6:45 PM Changeset in webkit [263251] by
-
- 2 edits in trunk/Source/WebKit
Use fastMalloc/fastFree in WebCoreArgumentCodersMac.mm
<https://webkit.org/b/213325>
Reviewed by Darin Adler.
- Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::createArchiveList):
(IPC::createCFURLRequestFromSerializableRepresentation):
- 6:43 PM Changeset in webkit [263250] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove dead non-ICU locale Date code since we are always using ICU version
https://bugs.webkit.org/show_bug.cgi?id=213362
Reviewed by Ross Kirsling.
There are old non-ICU version of Date locale code. But this is now dead code since we are always using ICU version,
which is invoked from builtin JS DatePrototype.js. We should remove these dead code.
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
(): Deleted.
(JSC::styleFromArgString): Deleted.
(JSC::formatLocaleDate): Deleted.
(JSC::dateProtoFuncToLocaleString): Deleted.
(JSC::dateProtoFuncToLocaleDateString): Deleted.
(JSC::dateProtoFuncToLocaleTimeString): Deleted.
- 6:04 PM Changeset in webkit [263249] by
-
- 1 edit2 adds in trunk/LayoutTests
Unreviewed, fix test failure in Windows part 2
https://bugs.webkit.org/show_bug.cgi?id=213269
Looks like Windows TWR and DRT have different implementation.
- platform/win/fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt: Added.
- platform/wincairo/fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt: Added.
- 5:37 PM Changeset in webkit [263248] by
-
- 11 edits2 moves in trunk
Remove some vestiges of the 32-bit Plugin Process
https://bugs.webkit.org/show_bug.cgi?id=213361
Reviewed by Dan Bernstein.
.:
- Makefile.shared:
This hack from r203348 is no longer needed, because WebKit cannot be built for 32-bit anymore.
Source/WebKit:
We haven't launched 32-bit plugins for a while, but there are some
build system complications and random references in the code that we can get rid of.
- WebKit.xcodeproj/project.pbxproj:
- Configurations/PluginService.xcconfig: Renamed from Source/WebKit/Configurations/PluginService.64.xcconfig.
No need for .64 in the name anymore, since it's the only one.
We do have to leave the .64 in the product name because there are other things in the system that depend on this.
- PluginProcess/EntryPoint/Cocoa/XPCService/PluginService.Info.plist: Renamed from Source/WebKit/PluginProcess/EntryPoint/Cocoa/XPCService/PluginService.64.Info.plist.
No need for .64 in the name anymore.
- UIProcess/AuxiliaryProcessProxy.cpp:
(WebKit::AuxiliaryProcessProxy::getLaunchOptions):
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
- UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
(WebKit::PluginProcessProxy::platformGetLaunchOptionsWithAttributes):
There need only be one ProcessType for the plugin process now!
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformGetLaunchOptionsWithAttributes):
- UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::bubblewrapSpawn):
- UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
GTK WebKit appears to also only launch 64-bit plugin processes.
- 4:42 PM Changeset in webkit [263247] by
-
- 1 copy in tags/Safari-609.3.5.1.2
Tag Safari-609.3.5.1.2.
- 4:38 PM Changeset in webkit [263246] by
-
- 8 edits in branches/safari-609.3.5.1-branch/Source
Versioning.
WebKit-609.3.5.1.2
- 4:34 PM Changeset in webkit [263245] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, fix test failure in Windows
https://bugs.webkit.org/show_bug.cgi?id=213269
- fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt:
- fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html:
- 4:28 PM Changeset in webkit [263244] by
-
- 2 edits in trunk/LayoutTests
[ Catalina Debug WK2 ] fast/events/platform-wheelevent-in-scrolling-div.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213351
Unreviewed test gardening.
Patch by Karl Rackler <Karl Rackler> on 2020-06-18
- platform/mac-wk2/TestExpectations:
- 4:13 PM Changeset in webkit [263243] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, address Darin's feedback on r263227.
- runtime/IntlRelativeTimeFormat.cpp:
(JSC::IntlRelativeTimeFormat::UNumberFormatDeleter::operator() const):
(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):
(JSC::IntlRelativeTimeFormat::formatToParts const):
- runtime/IntlRelativeTimeFormat.h:
Keep ownership over our UNumberFormat instance after all,
to avoid relying on behavior ICU isn't explicitly guaranteeing.
- 4:11 PM Changeset in webkit [263242] by
-
- 2 edits in trunk/Tools
Add SPI to preconnect to a server (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=213109
<rdar://problem/64184412>
Unreviewed build-fix.
- TestWebKitAPI/Tests/WebKitCocoa/Preconnect.mm: HTTPServer does not exist if HAVE(NETWORK_FRAMEWORK) is false.
- 4:04 PM Changeset in webkit [263241] by
-
- 2 edits in trunk/Tools
[iOS] Two KeyboardInputTests are failing on recent iOS SDK versions (build-fix)
https://bugs.webkit.org/show_bug.cgi?id=213183
<rdar://problem/64273483>
Unreviewed build fix.
- TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
(webViewWithAutofocusedInput): bool may not be the same type as BOOL.
- 3:58 PM Changeset in webkit [263240] by
-
- 2 edits in trunk/JSTests
sampling-profiler-wasm-name-section should run for more iterations
https://bugs.webkit.org/show_bug.cgi?id=207576
<rdar://problem/59431250>
Reviewed by Mark Lam.
This test was flaky because the sampling profiler is inherently probabilistic.
We need to run it for more iterations to ensure it's not flaky.
- stress/sampling-profiler-wasm-name-section.js:
- 3:53 PM Changeset in webkit [263239] by
-
- 8 edits in branches/safari-610.1.17-branch/Source
Versioning.
WebKit-610.1.17.1
- 3:53 PM Changeset in webkit [263238] by
-
- 15 edits2 moves2 deletes in branches/safari-610.1.17-branch
Temporarily revert non-Hunter tested content.
- 3:47 PM Changeset in webkit [263237] by
-
- 1 copy in tags/Safari-609.3.5.1.1
Tag Safari-609.3.5.1.1.
- 3:47 PM Changeset in webkit [263236] by
-
- 12 edits2 adds in branches/safari-609.3.5.0-branch
Apply patch. rdar://problem/64178850
- 3:41 PM Changeset in webkit [263235] by
-
- 2 edits in trunk/Tools
call skip when skipping JetStream2 wasm test
https://bugs.webkit.org/show_bug.cgi?id=213354
Reviewed by Yusuke Suzuki.
So we can see the logging that we're skipping.
- Scripts/run-jsc-stress-tests:
- 3:37 PM Changeset in webkit [263234] by
-
- 8 edits in branches/safari-609.3.5.1-branch/Source
Versioning.
WebKit-609.3.5.1.1
- 3:18 PM Changeset in webkit [263233] by
-
- 1 copy in tags/Safari-610.1.17
Tag Safari-610.1.17.
- 3:16 PM Changeset in webkit [263232] by
-
- 2 edits in trunk/Source/WebKit
Workaround for UIKit layout bug in time picker.
https://bugs.webkit.org/show_bug.cgi?id=213346
<rdar://problem/64042277>
Reviewed by Tim Horton.
There is a bug in the layout of UIKit that needs to be fixed.
Until then, this workaround should give us a view that is viable.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView resignFirstResponderForWebView]):
- UIProcess/ios/forms/WKDateTimeInputControl.mm:
(-[WKDateTimeContextMenuViewController preferredContentSize]):
- 3:11 PM Changeset in webkit [263231] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: ASSERTION FAILED: decodedLength >= dataLength at WebCore::NetworkResourcesData::ResourceData::decodeDataToContent()
https://bugs.webkit.org/show_bug.cgi?id=213271
<rdar://problem/64168350>
Reviewed by Brian Burg.
Remove the invalid
ASSERT(decodedLength >= dataLength)as it's very possible for decoded
content to be smaller than encoded content (e.g. something gzipped).
Use
String::sizeInBytesinstead ofStringImpl::sizeInBytesas the latter also includes
sizeof(*this), which is not really part of the resource's size, as it's really more of an
implementation detail.
- inspector/NetworkResourcesData.h:
- inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::removeContent):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::contentSizeInBytes): Deleted.
- 2:54 PM Changeset in webkit [263230] by
-
- 2 edits in trunk/Source/WebCore
[Apple Pay] Fix a log message typo in PaymentCoordinator::didAuthorizePayment
Rubber-stamped by Beth Dakin.
- Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::didAuthorizePayment): Logged the correct function name.
- 2:12 PM Changeset in webkit [263229] by
-
- 8 edits in branches/safari-609.3.5.0-branch/Source
Versioning.
WebKit-609.3.5.0.1
- 1:54 PM Changeset in webkit [263228] by
-
- 2 edits in trunk/Tools
Unreviewed. Remove the build warning below since r262971.
warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
- WebKitTestRunner/TestController.cpp:
(WTR::getAllStorageAccessEntriesCallback):
- 1:48 PM Changeset in webkit [263227] by
-
- 12 edits in trunk
[Intl] Enable RelativeTimeFormat and Locale by default
https://bugs.webkit.org/show_bug.cgi?id=213324
Reviewed by Yusuke Suzuki.
JSTests:
- stress/intl-locale-as-intl-param.js:
- stress/intl-locale.js:
- stress/intl-relativetimeformat.js:
- test262/config.yaml:
Remove feature flags.
Source/JavaScriptCore:
- runtime/IntlObject.cpp:
(JSC::createDateTimeFormatConstructor):
(JSC::createLocaleConstructor):
(JSC::createNumberFormatConstructor):
(JSC::createRelativeTimeFormatConstructor):
(JSC::IntlObject::finishCreation):
Unconditionalize creation of RelativeTimeFormat and Locale constructors.
- runtime/IntlRelativeTimeFormat.cpp:
(JSC::IntlRelativeTimeFormat::initializeRelativeTimeFormat):
(JSC::IntlRelativeTimeFormat::formatToParts const):
(JSC::IntlRelativeTimeFormat::UNumberFormatDeleter::operator() const): Deleted.
- runtime/IntlRelativeTimeFormat.h:
Fix an actual bug -- URelativeDateTimeFormatter *adopts* the UNumberFormat it's instantiated with,
so we can't keep a unique_ptr to it.
- runtime/OptionsList.h:
Remove feature flags.
Tools:
- Scripts/run-jsc-stress-tests:
Remove feature flags.
- 1:34 PM WebInspectorCodingStyleGuide edited by
- (diff)
- 1:34 PM WebInspectorCodingStyleGuide edited by
- (diff)
- 1:33 PM WebInspectorCodingStyleGuide edited by
- (diff)
- 1:29 PM WebInspectorCodingStyleGuide edited by
- (diff)
- 1:25 PM WebInspectorCodingStyleGuide edited by
- (diff)
- 1:22 PM Changeset in webkit [263226] by
-
- 8 edits in branches/safari-610.1.15.51-branch/Source
Versioning.
WebKit-610.1.15.51.5
- 1:12 PM Changeset in webkit [263225] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Console: add comments for localized strings in execution context picker
https://bugs.webkit.org/show_bug.cgi?id=213280
Reviewed by Joseph Pecoraro.
- UserInterface/Views/QuickConsole.js:
(WI.QuickConsole.prototype._populateActiveExecutionContextNavigationItemContextMenu):
- Localizations/en.lproj/localizedStrings.js:
- 1:09 PM WebInspectorTests edited by
- (diff)
- 1:07 PM Changeset in webkit [263224] by
-
- 2 edits in trunk/Tools
Unreviewed build fix after r263194
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformResetStateToConsistentValues): Guarded code that mentions
UIContextMenuInteraction with USE(UICONTEXTMENU).
- 1:06 PM Changeset in webkit [263223] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, re-landing r262904.
r263219 and r263175 should fix the test flakiness we saw.
Re-landed changeset:
"[Cocoa] Build callOnMainThread on WTF::RunLoop rather than on
a timer"
https://bugs.webkit.org/show_bug.cgi?id=213063
https://trac.webkit.org/changeset/262904
- 11:22 AM Changeset in webkit [263222] by
-
- 6 edits in trunk
Promise built-in functions should be anonymous non-constructors
https://bugs.webkit.org/show_bug.cgi?id=213317
Reviewed by Darin Adler.
JSTests:
- test262/expectations.yaml: Mark 20 test cases as passing.
Source/JavaScriptCore:
This patch makes userland-exposed Promise built-in functions
non-constructors and sets their "name" properties to empty strings
as per spec [1], aligning JSC with V8 and SpiderMonkey.
@createResolvingFunctionsWithoutPromise change is covered by test262's
async-generator/yield-thenable-create-resolving-functions-*.js cases.
Promise microbenchmarks are neutral. Promise constructors bytecode is
unchanged, while @createResolvingFunctions* bytecode is reduced by 2
instructions.
[1]: https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects
- builtins/PromiseConstructor.js:
(nakedConstructor.Promise):
(nakedConstructor.InternalPromise):
- builtins/PromiseOperations.js:
(globalPrivate.newPromiseCapabilitySlow):
(globalPrivate.createResolvingFunctions):
(globalPrivate.createResolvingFunctionsWithoutPromise):
(globalPrivate.createResolvingFunctions.resolve): Deleted.
(globalPrivate.createResolvingFunctions.reject): Deleted.
(resolve): Deleted.
(reject): Deleted.
- builtins/PromisePrototype.js:
(globalPrivate.getThenFinally):
(globalPrivate.getCatchFinally):
(valueThunk): Deleted.
(thrower): Deleted.
- 10:47 AM Changeset in webkit [263221] by
-
- 3 edits2 adds in trunk
[LFC][BFC] Available space computation for the float avoider needs coordinate mapping
https://bugs.webkit.org/show_bug.cgi?id=213339
Reviewed by Antti Koivisto.
Source/WebCore:
The FloatConstraints position values are in formatting root coordinates but the available space
requires containing block coordinates.
Test: fast/layoutformattingcontext/float-avoider-available-horizontal-space.html
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::usedAvailableWidthForFloatAvoider):
LayoutTests:
- fast/layoutformattingcontext/float-avoider-available-horizontal-space-expected.html: Added.
- fast/layoutformattingcontext/float-avoider-available-horizontal-space.html: Added.
- 10:45 AM Changeset in webkit [263220] by
-
- 2 edits in trunk/Source/WebCore
[PlayStation] Build fix for errors with structured bindings to const structure
https://bugs.webkit.org/show_bug.cgi?id=213323
Reviewed by Fujii Hironori.
Our system seems to have trouble with these structured bindings,
similar to what was previously seen for clang-cl.
No new tests, build fix.
- inspector/agents/InspectorNetworkAgent.cpp:
- 10:42 AM Changeset in webkit [263219] by
-
- 2 edits in trunk/LayoutTests
inspector/canvas/create-context-webgpu.html was a flaky failure after r262904
https://bugs.webkit.org/show_bug.cgi?id=213343
Reviewed by Darin Adler.
This test races a zero-delay GC timer against WebCore releasing its last
reference to a WebGPU canvas. Flaky!
Make GC deterministic by continually retrying GC until the Web
Inspector is notified that the canvas has been collected.
Also make sure to stop GC'ing afterwards. I'm not sure if this matters
or not, but it is good to prevent one test from changing behavior in
another.
- inspector/canvas/resources/create-context-utilities.js:
(destroyCanvases):
- 10:28 AM Changeset in webkit [263218] by
-
- 4 edits in trunk
REGRESSION (r263098): [Win10] http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are failing
https://bugs.webkit.org/show_bug.cgi?id=213303
<rdar://problem/64452203>
Reviewed by Alex Christensen.
Source/WebCore:
Covered by existing tests.
- loader/ResourceLoaderOptions.h:
Reverting part of https://trac.webkit.org/changeset/263098/webkit that might have broken win10 bots.
LayoutTests:
- platform/win/TestExpectations:
- 10:25 AM Changeset in webkit [263217] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Avoid setting GstContext twice in GLVideoSinkGStreamer
https://bugs.webkit.org/show_bug.cgi?id=213029
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-06-18
Reviewed by Xabier Rodriguez-Calvar.
There is a reported issued in GStrearGL < 1.17 for GLBaseFilter
can't handle its GLContext and Display reassignation. This patch
aims to to avoid setting Display or GL Context in GL video sink
multiple times by checking if the video sink bin already has those
contexts.
Also, instead of relying on an assert if something goes wrong at
fetching the GL parameters, it returns an error at state change.
No new tests required.
- platform/graphics/gstreamer/GLVideoSinkGStreamer.cpp:
(requestGLContext):
(setGLContext): new function.
(webKitGLVideoSinkChangeState):
- 10:10 AM Changeset in webkit [263216] by
-
- 8 edits in trunk
TypedArray.prototype.set is incorrect with primitives
https://bugs.webkit.org/show_bug.cgi?id=212730
Reviewed by Yusuke Suzuki.
JSTests:
- test262/expectations.yaml: Mark 2 test cases as passing.
Source/JavaScriptCore:
This change implements step 14 of %TypedArray%.prototype.set [1],
which coerces primitives to objects instead of throwing an error,
aligning JSC with V8 and SpiderMonkey.
[1]: https://tc39.es/ecma262/#sec-%typedarray%.prototype.set-array-offset
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSet):
LayoutTests:
- fast/canvas/webgl/array-get-and-set-method-removal-expected.txt:
- fast/canvas/webgl/array-get-and-set-method-removal.html:
- fast/canvas/webgl/array-set-invalid-arguments-expected.txt:
- 10:03 AM Changeset in webkit [263215] by
-
- 3 edits4 adds in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update test expectations after r263207.
- platform/glib/js/dom/constructor-length-expected.txt: Updated.
- platform/gtk/TestExpectations:
- platform/gtk/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-serializable-expected.txt: Added.
- 9:52 AM Changeset in webkit [263214] by
-
- 5 edits2 moves in branches/safari-610.1.17-branch/Source/WebCore
Cherry-pick r263129. rdar://problem/64492826
FileListCreator should only be used for resolving directories
https://bugs.webkit.org/show_bug.cgi?id=213259
<rdar://problem/64375709>
Reviewed by David Kilzer.
Depending on whether directories should be resolved, FileListCreator::create would either
synchronously execute its completion handler then return nullptr or asynchronously dispatch
its completion handler then return a non-null RefPtr. Interfaces with sometimes-synchronous
callbacks can be hard to use correctly; e.g., r262962 fixes a problem where
FileInputType::m_fileListCreator was being modified in an unexpected order.
This patch makes the interface between FileInputType and FileListCreator less error-prone
and more explicit by renaming FileListCreator to DirectoryFileListCreator, making its job
solely to create directory FileLists on a background queue, and giving it an explicit start
member function. For non-directories, FileInputType::filesChosen now bypasses
DirectoryFileListCreator and directly converts from Vector<FileChooserFileInfo> to FileList.
Covered by existing tests.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- html/DirectoryFileListCreator.cpp: Renamed from html/FileListCreator.cpp. (WebCore::createFileList): Removed the template and ShouldResolveDirectories parameter. (WebCore::DirectoryFileListCreator::DirectoryFileListCreator): Moved the work queue dispatching to DirectoryFileListCreator::start. (WebCore::DirectoryFileListCreator::start): Added; moved the work queue dispatching here from the ctor.
- html/DirectoryFileListCreator.h: Renamed from html/FileListCreator.h. (WebCore::DirectoryFileListCreator::create): Stopped performing non-directory creation and changed the return value back to Ref<>.
- html/FileInputType.cpp: (WebCore::FileInputType::filesChosen): Moved most of the work done in the FileListCreator completion handler to didCreateFileList. When !FileInputType::allowsDirectories, used Vector::map to convert paths to a Vector<Ref<File>>, used that to create a FileList, then called didCreateFileList. Otherwise, created and started a DirectoryFileListCreator that calls didCreateFileList in its completion handler. (WebCore::FileInputType::didCreateFileList): Added; sets the new file list and icon and clears m_directoryFileListCreator.
- html/FileInputType.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263129 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:52 AM Changeset in webkit [263213] by
-
- 5 edits2 adds in branches/safari-610.1.17-branch
Cherry-pick r263128. rdar://problem/64492837
REGRESSION (r262643): DumpRenderTree at com.apple.WebCore: WebCore::Document::prepareCanvasesForDisplayIfNeeded
https://bugs.webkit.org/show_bug.cgi?id=213221
rdar://64260400
Reviewed by Simon Fraser.
Source/WebCore:
A Document could still be holding a pointer to an HTMLCanvasElement after the
canvas had been deleted because the CanvasObserver protocol was disconnected
too early. The fix is to explicitly clear the canvas from the Document as it
stops observing.
Test: webgl/preparation-removed-from-document.html
- dom/Document.cpp: (WebCore::Document::prepareCanvasesForDisplayIfNeeded): Copy the HashSet to a Vector just in case something weird happens to the set during iteration. (WebCore::Document::clearCanvasPreparation): Remove the canvas from the list of of elements that need preparation.
- dom/Document.h: Add the new clearCanvasPreparation method.
- html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::~HTMLCanvasElement): Clear the document. (WebCore::HTMLCanvasElement::didMoveToNewDocument): Ditto. (WebCore::HTMLCanvasElement::removedFromAncestor): Ditto.
LayoutTests:
Test that triggers a rendering on a canvas, then rips it out of
the document before drawing.
- webgl/preparation-removed-from-document-expected.txt: Added.
- webgl/preparation-removed-from-document.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:52 AM Changeset in webkit [263212] by
-
- 7 edits in branches/safari-610.1.17-branch/Source/WebCore
Cherry-pick r263119. rdar://problem/64492834
Web Inspector: replace completion handler with a function in interception.
https://bugs.webkit.org/show_bug.cgi?id=213252
Patch by Pavel Feldman <pavel.feldman@gmail.com> on 2020-06-16
Reviewed by Devin Rousso.
Don't use a
CompletionHandleras it asserts that it's been called when it's destroyed.
BothNetwork.interceptRequestWithResponseandNetwork.interceptRequestWithErroressentially
"skip" the network pipeline, so theCompletionHandleris not invoked for those commands.
- inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::interceptRequestImpl):
- inspector/InspectorInstrumentation.h: (WebCore::InspectorInstrumentation::interceptRequest):
- inspector/InspectorInstrumentationWebKit.cpp: (WebCore::InspectorInstrumentationWebKit::interceptRequestInternal):
- inspector/InspectorInstrumentationWebKit.h: (WebCore::InspectorInstrumentationWebKit::interceptRequest):
- inspector/agents/InspectorNetworkAgent.cpp: (WebCore::InspectorNetworkAgent::interceptRequest): (WebCore::InspectorNetworkAgent::interceptRequestWithResponse): (WebCore::InspectorNetworkAgent::interceptRequestWithError):
- inspector/agents/InspectorNetworkAgent.h: (WebCore::InspectorNetworkAgent::PendingInterceptRequest::PendingInterceptRequest): (WebCore::InspectorNetworkAgent::PendingInterceptRequest::continueAsHandled):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:32 AM Changeset in webkit [263211] by
-
- 4 edits in trunk/Source/WebCore
Clamp text run width to zero
https://bugs.webkit.org/show_bug.cgi?id=212655
<rdar://problem/61462335>
Reviewed by Said Abou-Hallawa.
It's possible to end up with a text run with negative width, if the text run is relatively short
and the character spacing is relatively large (but negative). If this occurs, clamp the value to
zero. This also adds additional asserts and checks to ensure the value remains non-negative.
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLinesForText):
- rendering/ComplexLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
- rendering/RenderText.cpp:
(WebCore::RenderText::width const):
- 9:30 AM Changeset in webkit [263210] by
-
- 2 edits in trunk/Tools
Unreviewed infrastructure fix, temporarily remove ews116 due to hardware failure tracked with rdar://64424245
- BuildSlaveSupport/ews-build/config.json:
- 9:28 AM Changeset in webkit [263209] by
-
- 3 edits in trunk/Source/WebCore
Fix misspellings of "namespace" in comments
- page/SpatialNavigation.h:
- platform/gtk/RenderThemeScrollbar.cpp:
- 8:53 AM Changeset in webkit [263208] by
-
- 31 edits in trunk/Source
[IPC hardening] OptionSet<> values should be validated
<https://webkit.org/b/213199>
<rdar://problem/64369963>
Reviewed by Anders Carlsson.
Source/WebCore:
Summary:
- Add WTF::EnumTraits<> for all OptionSet<> enums.
- Specify unsigned backing types for enum classes.
- loader/CrossOriginAccessControl.h:
- page/ActivityState.h:
- page/AutoplayEvent.h:
- page/CrossSiteNavigationDataTransfer.h:
- page/LayoutMilestone.h:
- page/TextIndicator.h:
- platform/PlatformEvent.h:
- platform/graphics/GraphicsContext.h:
Source/WebKit:
Summary:
- Add WTF::EnumTraits<> for all OptionSet<> enums.
- Specify unsigned backing types for enum classes.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkSession.h:
- Platform/IPC/ArgumentCoders.h:
(IPC::ArgumentCoder<OptionSet<T>>::encode):
(IPC::ArgumentCoder<OptionSet<T>>::decode):
- Add WTF::isValidOptionSet() checks.
- Platform/IPC/Decoder.h:
- Platform/IPC/Encoder.h:
- Replace <wtf/EnumTraits.h> with <wtf/OptionSet.h> since the latter now includes the former.
- Platform/IPC/MessageFlags.h:
- Shared/DocumentEditingContext.h:
- Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
- Shared/WebEvent.h:
- Shared/WebsiteAutoplayQuirk.h:
- Shared/WebsiteData/WebsiteData.h:
- Shared/WebsiteData/WebsiteDataFetchOption.h:
- Shared/WebsiteData/WebsiteDataType.h:
- Shared/ios/GestureTypes.h:
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/WebProcessProxy.h:
- UIProcess/WebsiteData/WebsiteDataStore.h:
- WebProcess/WebProcess.h:
Source/WTF:
- wtf/OptionSet.h:
(WTF::isValidOptionSet): Add.
- 7:25 AM Changeset in webkit [263207] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update status of flaky timeout failures after r263206.
- platform/gtk/TestExpectations:
- 4:41 AM Changeset in webkit [263206] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Remove stale flaky failures after r263205.
- platform/gtk/TestExpectations:
- 2:45 AM Changeset in webkit [263205] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening. Remove stake flaky crash failures after r263204.
- platform/gtk/TestExpectations:
- 1:17 AM Changeset in webkit [263204] by
-
- 13 edits in trunk
[GTK][WPE] Add API to configure and handle service worker registrations to WebKitWebsiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=213290
Reviewed by Michael Catanzaro.
Source/WebKit:
The default path is always used even for apps setting a base data directory. We should handle
WebsiteDataType::ServiceWorkerRegistrations to configure the directory and allow to fetch and clear them.
- UIProcess/API/glib/WebKitWebsiteData.cpp:
(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):
- UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkitWebsiteDataManagerGetProperty):
(webkitWebsiteDataManagerSetProperty):
(webkitWebsiteDataManagerConstructed):
(webkit_website_data_manager_class_init):
(webkitWebsiteDataManagerGetDataStore):
(webkit_website_data_manager_get_service_worker_registrations_directory):
(toWebsiteDataTypes):
- UIProcess/API/gtk/WebKitWebsiteData.h:
- UIProcess/API/gtk/WebKitWebsiteDataManager.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- UIProcess/API/wpe/WebKitWebsiteData.h:
- UIProcess/API/wpe/WebKitWebsiteDataManager.h:
- UIProcess/API/wpe/docs/wpe-1.0-sections.txt:
Tools:
Handle new website data in MiniBrowser and add a unit test.
- MiniBrowser/gtk/main.c:
(gotWebsiteDataCallback):
- TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
(serverCallback):
(testWebsiteDataConfiguration):
(testWebsiteDataEphemeral):
(testWebsiteDataITP):
(testWebsiteDataServiceWorkerRegistrations):
(beforeAll):
- TestWebKitAPI/glib/WebKitGLib/TestMain.h:
(Test::Test):
- 1:15 AM Changeset in webkit [263203] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[GTK] [l10n] Updated Ukrainian translation of WebKitGTK
https://bugs.webkit.org/show_bug.cgi?id=212844
Patch by Yuri Chornoivan <yurchor@ukr.net> on 2020-06-18
Rubber-stamped by Carlos Garcia Campos.
- uk.po:
- 1:12 AM Changeset in webkit [263202] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Fix a typo introduced in r263085
Patch by Yuri Chornoivan <yurchor@ukr.net> on 2020-06-18
- UIProcess/API/glib/WebKitWebsiteDataManager.cpp:
(webkit_website_data_manager_class_init):
- 12:36 AM Changeset in webkit [263201] by
-
- 5 edits in trunk/LayoutTests
[WPE] Unreviewed test gardening. Update test expectations after r263199.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- platform/wpe/accessibility/roles-exposed-expected.txt:
Jun 17, 2020:
- 10:54 PM Changeset in webkit [263200] by
-
- 3 edits2 adds in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update test expectations after r263197.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- platform/gtk/http/tests/plugins/plugin-javascript-access-allow-all-plugins-expected.txt: Added.
- platform/wpe/TestExpectations:
- 9:16 PM Changeset in webkit [263199] by
-
- 7 edits in trunk
Added missing orientation attributes to PannerNode
https://bugs.webkit.org/show_bug.cgi?id=213301
Patch by Clark Wang <clark_wang@apple.com> on 2020-06-17
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Re-baselined previous tests that now have passing test cases.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-pannernode-interface/pannernode-basic-expected.txt:
Source/WebCore:
Implemented orientation attributes in PannerNode interface, as per spec: https://www.w3.org/TR/webaudio/#pannernode.
Added FIXME comments for removing velocity later.
Re-baselined previous tests that now have passing test cases.
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::orientation const):
(WebCore::PannerNode::setOrientation):
(WebCore::PannerNode::distanceConeGain):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/PannerNode.idl:
- 9:14 PM Changeset in webkit [263198] by
-
- 99 edits16 copies in trunk
Add experimental feature flag for modern & unprefixed WebAudio API
https://bugs.webkit.org/show_bug.cgi?id=213268
Reviewed by Jer Noble.
LayoutTests/imported/w3c:
Rebaseline a few web-platform-tests now that they are passing or failing at a later stage.
This is due to our WebAudio getting properly unprefixed in the context of layout tests.
- web-platform-tests/webaudio/idlharness.https.window-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-detached-execution-context.tentative-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-offlineaudiocontext-interface/offlineaudiocontext-detached-execution-context.tentative-expected.txt:
Source/WebCore:
Add experimental feature flag for modern & unprefixed WebAudio API,
off by default.
This patch split the AudioContext, OfflineAudioContext and PannerNode
IDL interfaces into their prefixed and unprefixed versions. The
unprefixed versions are behind the new experimental feature flag that
is currently off by default but automatically gets turned on in the
context of layout tests.
This will give us more flexibility when working on the modern and
unprefixed WebAudio API as we will not have to worry about backward
compatibility. This also allows us to easily turn it on or off via
the experimental features menu in Safari.
No new tests, rebaselined existing tests.
- CMakeLists.txt:
- DerivedSources-input.xcfilelist:
- DerivedSources-output.xcfilelist:
- DerivedSources.make:
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::AnalyserNode):
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.cpp:
(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
- Modules/webaudio/AudioBasicInspectorNode.h:
- Modules/webaudio/AudioBasicProcessorNode.cpp:
(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
- Modules/webaudio/AudioBasicProcessorNode.h:
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::setBuffer):
(WebCore::AudioBufferSourceNode::setPannerNode):
- Modules/webaudio/AudioBufferSourceNode.h:
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContextBase::AudioContextBase):
(WebCore::AudioContext::AudioContext):
(WebCore::AudioContextBase::document const):
(WebCore::AudioContextBase::scriptExecutionContext const):
- Modules/webaudio/AudioContext.h:
(WebCore::AudioContextBase::AutoLocker::AutoLocker):
(WebCore::AudioContextBase::AutoLocker::~AutoLocker):
(WebCore::AudioContext::maxNumberOfChannels):
(isType):
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioContextState.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Modules/webaudio/AudioContextState.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Modules/webaudio/AudioDestinationNode.cpp:
(WebCore::AudioDestinationNode::AudioDestinationNode):
- Modules/webaudio/AudioDestinationNode.h:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):
(WebCore::AudioNode::deref):
(WebCore::AudioNode::contextForBindings const):
- Modules/webaudio/AudioNode.h:
(WebCore::AudioNode::context):
(WebCore::AudioNode::context const):
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioNodeOutput.h:
(WebCore::AudioNodeOutput::context):
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::AudioParam):
- Modules/webaudio/AudioParam.h:
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valueForContextTime):
- Modules/webaudio/AudioParamTimeline.h:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
- Modules/webaudio/AudioScheduledSourceNode.h:
- Modules/webaudio/AudioSummingJunction.cpp:
(WebCore::AudioSummingJunction::AudioSummingJunction):
- Modules/webaudio/AudioSummingJunction.h:
(WebCore::AudioSummingJunction::context):
- Modules/webaudio/BiquadFilterNode.cpp:
(WebCore::BiquadFilterNode::BiquadFilterNode):
- Modules/webaudio/BiquadFilterNode.h:
- Modules/webaudio/BiquadProcessor.cpp:
(WebCore::BiquadProcessor::BiquadProcessor):
- Modules/webaudio/BiquadProcessor.h:
- Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::ChannelMergerNode):
- Modules/webaudio/ChannelMergerNode.h:
- Modules/webaudio/ChannelSplitterNode.cpp:
(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::ChannelSplitterNode):
- Modules/webaudio/ChannelSplitterNode.h:
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::ConvolverNode):
- Modules/webaudio/ConvolverNode.h:
- Modules/webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
- Modules/webaudio/DefaultAudioDestinationNode.h:
- Modules/webaudio/DelayNode.cpp:
(WebCore::DelayNode::DelayNode):
(WebCore::DelayNode::create):
- Modules/webaudio/DelayNode.h:
- Modules/webaudio/DelayProcessor.cpp:
(WebCore::DelayProcessor::DelayProcessor):
- Modules/webaudio/DelayProcessor.h:
- Modules/webaudio/DistanceModelType.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Modules/webaudio/DistanceModelType.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Modules/webaudio/DynamicsCompressorNode.cpp:
(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
- Modules/webaudio/DynamicsCompressorNode.h:
- Modules/webaudio/GainNode.cpp:
(WebCore::GainNode::GainNode):
- Modules/webaudio/GainNode.h:
- Modules/webaudio/MediaElementAudioSourceNode.cpp:
(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):
- Modules/webaudio/MediaElementAudioSourceNode.h:
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::create):
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/MediaStreamAudioSourceNode.cpp:
(WebCore::MediaStreamAudioSourceNode::create):
(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
- Modules/webaudio/MediaStreamAudioSourceNode.h:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
- Modules/webaudio/OfflineAudioDestinationNode.h:
- Modules/webaudio/OscillatorNode.cpp:
(WebCore::OscillatorNode::create):
(WebCore::OscillatorNode::OscillatorNode):
- Modules/webaudio/OscillatorNode.h:
- Modules/webaudio/PannerNode.cpp:
(WebCore::PannerNodeBase::PannerNodeBase):
(WebCore::PannerNode::PannerNode):
- Modules/webaudio/PannerNode.h:
- Modules/webaudio/PannerNode.idl:
- Modules/webaudio/PanningModelType.h: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Modules/webaudio/PanningModelType.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::create):
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
- Modules/webaudio/ScriptProcessorNode.h:
- Modules/webaudio/WaveShaperNode.cpp:
(WebCore::WaveShaperNode::WaveShaperNode):
- Modules/webaudio/WaveShaperNode.h:
- Modules/webaudio/WebKitAudioContext.cpp: Copied from Source/WebCore/Modules/webaudio/AudioContext.cpp.
(WebCore::WebKitAudioContext::isSampleRateRangeGood):
(WebCore::WebKitAudioContext::create):
(WebCore::WebKitAudioContext::WebKitAudioContext):
(WebCore::WebKitAudioContext::constructCommon):
(WebCore::WebKitAudioContext::~WebKitAudioContext):
(WebCore::WebKitAudioContext::lazyInitialize):
(WebCore::WebKitAudioContext::clear):
(WebCore::WebKitAudioContext::uninitialize):
(WebCore::WebKitAudioContext::isInitialized const):
(WebCore::WebKitAudioContext::addReaction):
(WebCore::WebKitAudioContext::setState):
(WebCore::WebKitAudioContext::stop):
(WebCore::WebKitAudioContext::suspend):
(WebCore::WebKitAudioContext::resume):
(WebCore::WebKitAudioContext::activeDOMObjectName const):
(WebCore::WebKitAudioContext::hostingDocumentIdentifier const):
(WebCore::WebKitAudioContext::isSuspended const):
(WebCore::WebKitAudioContext::visibilityStateChanged):
(WebCore::WebKitAudioContext::wouldTaintOrigin const):
(WebCore::WebKitAudioContext::createBuffer):
(WebCore::WebKitAudioContext::decodeAudioData):
(WebCore::WebKitAudioContext::createBufferSource):
(WebCore::WebKitAudioContext::createMediaElementSource):
(WebCore::WebKitAudioContext::createMediaStreamSource):
(WebCore::WebKitAudioContext::createMediaStreamDestination):
(WebCore::WebKitAudioContext::createScriptProcessor):
(WebCore::WebKitAudioContext::createBiquadFilter):
(WebCore::WebKitAudioContext::createWaveShaper):
(WebCore::WebKitAudioContext::createPanner):
(WebCore::WebKitAudioContext::createConvolver):
(WebCore::WebKitAudioContext::createDynamicsCompressor):
(WebCore::WebKitAudioContext::createAnalyser):
(WebCore::WebKitAudioContext::createGain):
(WebCore::WebKitAudioContext::createDelay):
(WebCore::WebKitAudioContext::createChannelSplitter):
(WebCore::WebKitAudioContext::createChannelMerger):
(WebCore::WebKitAudioContext::createOscillator):
(WebCore::WebKitAudioContext::createPeriodicWave):
(WebCore::WebKitAudioContext::notifyNodeFinishedProcessing):
(WebCore::WebKitAudioContext::derefFinishedSourceNodes):
(WebCore::WebKitAudioContext::refNode):
(WebCore::WebKitAudioContext::derefNode):
(WebCore::WebKitAudioContext::derefUnfinishedSourceNodes):
(WebCore::WebKitAudioContext::lock):
(WebCore::WebKitAudioContext::tryLock):
(WebCore::WebKitAudioContext::unlock):
(WebCore::WebKitAudioContext::isAudioThread const):
(WebCore::WebKitAudioContext::isGraphOwner const):
(WebCore::WebKitAudioContext::addDeferredFinishDeref):
(WebCore::WebKitAudioContext::handlePreRenderTasks):
(WebCore::WebKitAudioContext::handlePostRenderTasks):
(WebCore::WebKitAudioContext::handleDeferredFinishDerefs):
(WebCore::WebKitAudioContext::markForDeletion):
(WebCore::WebKitAudioContext::scheduleNodeDeletion):
(WebCore::WebKitAudioContext::deleteMarkedNodes):
(WebCore::WebKitAudioContext::markSummingJunctionDirty):
(WebCore::WebKitAudioContext::removeMarkedSummingJunction):
(WebCore::WebKitAudioContext::markAudioNodeOutputDirty):
(WebCore::WebKitAudioContext::handleDirtyAudioSummingJunctions):
(WebCore::WebKitAudioContext::handleDirtyAudioNodeOutputs):
(WebCore::WebKitAudioContext::addAutomaticPullNode):
(WebCore::WebKitAudioContext::removeAutomaticPullNode):
(WebCore::WebKitAudioContext::updateAutomaticPullNodes):
(WebCore::WebKitAudioContext::processAutomaticPullNodes):
(WebCore::WebKitAudioContext::nodeWillBeginPlayback):
(WebCore::shouldDocumentAllowWebAudioToAutoPlay):
(WebCore::WebKitAudioContext::willBeginPlayback):
(WebCore::WebKitAudioContext::willPausePlayback):
(WebCore::WebKitAudioContext::startRendering):
(WebCore::WebKitAudioContext::mediaCanStart):
(WebCore::WebKitAudioContext::mediaState const):
(WebCore::WebKitAudioContext::pageMutedStateDidChange):
(WebCore::WebKitAudioContext::isPlayingAudioDidChange):
(WebCore::WebKitAudioContext::finishedRendering):
(WebCore::WebKitAudioContext::dispatchEvent):
(WebCore::WebKitAudioContext::incrementActiveSourceCount):
(WebCore::WebKitAudioContext::decrementActiveSourceCount):
(WebCore::WebKitAudioContext::suspendRendering):
(WebCore::WebKitAudioContext::resumeRendering):
(WebCore::WebKitAudioContext::close):
(WebCore::WebKitAudioContext::suspendPlayback):
(WebCore::WebKitAudioContext::mayResumePlayback):
(WebCore::WebKitAudioContext::postTask):
(WebCore::WebKitAudioContext::origin const):
(WebCore::WebKitAudioContext::addConsoleMessage):
(WebCore::WebKitAudioContext::clearPendingActivity):
(WebCore::WebKitAudioContext::makePendingActivity):
(WebCore::WebKitAudioContext::logChannel const):
- Modules/webaudio/WebKitAudioContext.h: Copied from Source/WebCore/Modules/webaudio/AudioContext.h.
(WebCore::WebKitAudioContext::destination):
(WebCore::WebKitAudioContext::activeSourceCount const):
(WebCore::WebKitAudioContext::listener):
(WebCore::WebKitAudioContext::isClosed const):
(WebCore::WebKitAudioContext::connectionCount const):
(WebCore::WebKitAudioContext::audioThread const):
(WebCore::WebKitAudioContext::maxNumberOfChannels):
(WebCore::WebKitAudioContext::userGestureRequiredForAudioStart const):
(WebCore::WebKitAudioContext::pageConsentRequiredForAudioStart const):
(WebCore::WebKitAudioContext::state const):
(isType):
- Modules/webaudio/WebKitAudioContext.idl: Copied from Source/WebCore/Modules/webaudio/AudioContext.idl.
- Modules/webaudio/WebKitAudioPannerNode.cpp: Copied from Source/WebCore/Modules/webaudio/PannerNode.cpp.
(WebCore::fixNANs):
(WebCore::WebKitAudioPannerNode::WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::~WebKitAudioPannerNode):
(WebCore::WebKitAudioPannerNode::pullInputs):
(WebCore::WebKitAudioPannerNode::process):
(WebCore::WebKitAudioPannerNode::reset):
(WebCore::WebKitAudioPannerNode::initialize):
(WebCore::WebKitAudioPannerNode::uninitialize):
(WebCore::WebKitAudioPannerNode::listener):
(WebCore::WebKitAudioPannerNode::setPanningModel):
(WebCore::WebKitAudioPannerNode::distanceModel const):
(WebCore::WebKitAudioPannerNode::setDistanceModel):
(WebCore::WebKitAudioPannerNode::getAzimuthElevation):
(WebCore::WebKitAudioPannerNode::dopplerRate):
(WebCore::WebKitAudioPannerNode::distanceConeGain):
(WebCore::WebKitAudioPannerNode::notifyAudioSourcesConnectedToNode):
- Modules/webaudio/WebKitAudioPannerNode.h: Copied from Source/WebCore/Modules/webaudio/PannerNode.h.
- Modules/webaudio/WebKitAudioPannerNode.idl: Copied from Source/WebCore/Modules/webaudio/PannerNode.idl.
- Modules/webaudio/WebKitOfflineAudioContext.cpp: Copied from Source/WebCore/Modules/webaudio/DelayNode.cpp.
(WebCore::WebKitOfflineAudioContext::WebKitOfflineAudioContext):
(WebCore::WebKitOfflineAudioContext::create):
- Modules/webaudio/WebKitOfflineAudioContext.h: Copied from Source/WebCore/Modules/webaudio/DelayNode.h.
- Modules/webaudio/WebKitOfflineAudioContext.idl: Copied from Source/WebCore/Modules/webaudio/OfflineAudioContext.idl.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/WebCoreBuiltinNames.h:
- dom/EventTargetFactory.in:
- page/Settings.yaml:
- testing/Internals.cpp:
(WebCore::Internals::setAudioContextRestrictions):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Add experimental feature flag for modern & unprefixed WebAudio API,
off by default.
- Shared/WebPreferences.yaml:
- 8:23 PM Changeset in webkit [263197] by
-
- 3 edits in trunk/Tools
RebaselineServer: "Rebaseline queue" button is placed behind the footer
https://bugs.webkit.org/show_bug.cgi?id=213258
Reviewed by Zalan Bujtas.
- Scripts/webkitpy/tool/servers/data/rebaselineserver/index.html: Moved 'log' and 'queue' elements after 'footer' element.
- Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
(#queue): Changed 'bottom' property from 3em to 4em.
- 7:26 PM Changeset in webkit [263196] by
-
- 10 edits in trunk
[macOS] Shift-tab in a bullet list in Mail Compose jumps back to Subject field
https://bugs.webkit.org/show_bug.cgi?id=213320
<rdar://problem/63831962>
Reviewed by Tim Horton.
Source/WebCore:
After the changes in r262051, pressing shift-tab in a bulleted list in Mail compose on macOS no longer triggers
an outdent command. This is because the default behavior of the "keydown" event will now relinquish focus to the
embedding client (i.e. the "chrome"). In this case, Mail makes the Subject field above the compose web view the
first responder.
This is necessary on iOS, where Mail does not attempt to intercept shift+tab and move focus to the subject line.
However, Mail on macOS intercepts the keypress event, and either triggers outdent (if the selection is inside a
list or blockquote) or focuses the Subject line. Since focus is relinquished during "keydown", this logic no
longer runs, and hitting shift+tab in a list always relinquishes focus.
To address this, refactor the changes made in r262051 so that we treat the default behavior of the "keypress"
event (rather than "keydown") as relinquishing focus. See WebKit/ChangeLog for more details.
Test: WebKit.ShiftTabDoesNotTakeFocusFromEditableWebViewWhenPreventingKeyPress
- page/EventHandler.cpp:
(WebCore::EventHandler::defaultTabEventHandler):
Remove a call to relinquish focus when handling tab.
- page/FocusController.h:
Source/WebKit:
See WebCore/ChangeLog for more detail.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleKeyEventByRelinquishingFocusToChrome):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::handleEditingKeyboardEvent):
Hoist logic for relinquishing focus as a result of shift+tab from EventHandler to WebPage, so that it is the
default behavior when processing a "keypress" event that corresponds to shift+tab in an editable web view on
Cocoa platforms. If we do end up relinquishing focus, then we consider the keypress event to be handled.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::handleEditingKeyboardEvent):
Tools:
Add a new API test to verify that preventing the "keypress" event for shift+tab in an SPI-editable web view
causes us to avoid relinquishing focus.
- TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
- 6:55 PM Changeset in webkit [263195] by
-
- 13 edits in trunk/Source
Replace JSC::FreeList linked list with a Bitmap.
https://bugs.webkit.org/show_bug.cgi?id=213071
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Implement an alternative to the linked list FreeList. This alternative uses
a Bitmap to record which atom in the block is available for allocation.
The intuition here is that allocation using the Bitmap implementation will do:
2 loads - m_currentRowBitmap, m_currentMarkedBlockRowAddress
1 store - m_currentRowBitmap
whereas the linked list implementation will do:
3 loads - m_scrambledHead, m_secret, result->scrambledNext
1 store - m_scrambledHead
and result->scrambledNext is from a different region of code and therefore not
in the same cache line.
The downside of the Bitmap implementation is that it uses more instructions.
This change is currently only enabled for x86_64, which shows about a 0.8%
progression on Speedometer 2.
It appears to be about a 1% regression on ARM64E. Hence, for now, we keep the
linked list implementation for ARM64 builds.
This is how the Bitmap FreeList works:
- The Bitmap implementation only replaces the linked list implementation. It does not replace the bump allocator.
- The Bitmap allocator keeps a m_bitmap that is initialized in MarkedBlock::Handle::specializedSweep() to have a bit set for each atom location that is available for allocation (i.e. is free). Note that a cell is usually allocated using more than 1 atom. Only the bit corresponding to the first atom (in that cell length range of free atoms) will be set.
This is consistent with how bits in MarkedBlock::Footer::m_marks and
MarkedBlock::Footer::m_newlyAllocated are set i.e. only the bit for the first
atom in the cell can be set.
- The allocation algorithm thinks of the MarkedBlock as consisting of rows of atoms, where the number of atoms in a row equals the number of bits in a AtomsBitmap::Word. On 64-bit CPUs, this would be 64.
We will start allocating from the last (highest numbered) row down to the
first (row 0). As we allocate, we will only update m_currentRowIndex and
m_currentRowBitmap. m_bitmap will not be updated. This is so in order to
reduce the number of instructions executed during an allocation.
When m_currentRowIndex points to N, the AtomsBitmap::Word for row N in
m_bitmap will have been copied into m_currentRowBitmap. This is the row
that we will be allocating from until the row is exhausted.
This is how we know whether an atom is available for allocation or not:
- Atoms in any rows above m_currentRowIndex are guaranteed to be allocated already (because we allocate downwards), and hence, are not available.
- For row m_currentRowIndex, m_currentRowBitmap is the source of truth
on which atoms in the row are available for allocation.
- For rows below m_currentRowIndex, m_bitmap is the source of truth on
which atoms are available for allocation.
When m_currentRowIndex reaches 0, the info in m_bitmap is completely
obsoleted, and m_currentRowBitmap holds the availability info for row 0.
When both m_currentRowIndex and m_currentRowBitmap are 0, then we have
completely exhausted the block and no more atoms are available for
allocation.
- Allocation happens in 3 paths: fast, middle, slow.
The fast path checks m_currentRowBitmap. If it's not 0, then we compute the
bit number of the lowest set bit in it. That bit number will be used together
with m_currentMarkedBlockRowAddress to compute the address of the atom
location available for allocation. m_currentRowBitmap will be updated to clear
the bit for the atom that has just ben allocated.
If m_currentRowBitmap is 0, then we'll go to the middle path.
The middle path checks m_currentRowIndex to see if we have more rows to allocate
from. For each m_currentRowIndex, we check its corresponding AtomsBitmap::Word
in m_bitmap. If the word is non-zero, we copy it to m_currentRowBitmap and
jump to the fast path to do the allocation. The middle path will update
m_currentRowIndex to point to the current row we're allocating from.
If we have decremented m_currentRowIndex down to 0 but still can't find a
non-zero AtomsBitmap::Word in m_bitmap, then the block has been exhausted, and
we'll go to the slow path.
The slow path is analogous to the old slow path i.e. we try to refill the
LocalAllocator with a new MarkedBlock.
- On the layout of fields in FreeList (see changes in FreeList.h), we try to preserve the positions of the bump allocator fields. The only change we made there is n the location of m_cellSize. It is now moved up next to m_remaining, and m_originalSize is moved down. This is because m_originalSize is only accessed in the slow path, and m_cellSize is accessed in the bump allocation path.
Next, we try to put Bitmap allocation fields where the linked list fields
would have been. The one bit of trickiness is that we'll put
m_currentMarkedBlockRowAddress in a union with m_payloadEnd. This is because
m_payloadEnd is only used in the bump allocation path. If m_remaining is 0,
then we can reuse this location for m_currentMarkedBlockRowAddress.
With this, we would have 4 bytes of padding after m_currentRowIndex. For
compactness, we put m_originalSize there in that space. For builds that use
the linked list implementation, m_originalSize will be located below after
m_cellSize.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell):
- heap/FreeList.cpp:
(JSC::FreeList::clear):
(JSC::FreeList::initializeAtomsBitmap):
(JSC::FreeList::initializeBump):
(JSC::FreeList::contains const):
(JSC::FreeList::dump const):
- heap/FreeList.h:
(JSC::FreeList::bitmapIsEmpty const):
(JSC::FreeList::allocationWillFail const):
(JSC::FreeList::offsetOfCurrentRowBitmap):
(JSC::FreeList::offsetOfBitmapRows):
(JSC::FreeList::offsetOfCurrentRowIndex):
(JSC::FreeList::offsetOfCurrentMarkedBlockRowAddress):
(JSC::FreeList::offsetOfRemaining):
(JSC::FreeList::atomsBitmap):
(JSC::FreeList::bitmapRows const):
(JSC::FreeList::offsetOfOriginalSize): Deleted.
- heap/FreeListInlines.h:
(JSC::FreeList::allocate):
(JSC::FreeList::forEach const):
- heap/LocalAllocator.cpp:
(JSC::LocalAllocator::isFreeListedCell const):
- heap/MarkedBlock.h:
(JSC::MarkedBlock::Handle::atomAt const):
- heap/MarkedBlockInlines.h:
(JSC::MarkedBlock::Handle::specializedSweep):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):
Source/WTF:
- Use countOfBits<> template to compute the number of bits.
- Introduce log2() and log2Constexpr() utility functions.
- Make Bitmap<>::forEachSetBit() a little bit more efficient: we don't need to keep iterating if the bitmap word is already empty of bits.
- wtf/Bitmap.h:
(WTF::WordType>::forEachSetBit const):
- wtf/MathExtras.h:
(WTF::clzConstexpr):
(WTF::clz):
(WTF::ctzConstexpr):
(WTF::ctz):
(WTF::getMSBSet):
(WTF::getMSBSetConstexpr):
(WTF::log2):
(WTF::log2Constexpr):
- 6:45 PM Changeset in webkit [263194] by
-
- 2 edits in trunk/Tools
REGRESSION (r258092): fast/forms/ios/file-upload-panel.html fails when HAVE(UICONTEXTMENU_LOCATION)
https://bugs.webkit.org/show_bug.cgi?id=213314
<rdar://problem/60339129>
Reviewed by Maciej Stachowiak.
fast/forms/ios/file-upload-panel.html sets the shouldHandleRunOpenPanel and
shouldPresentPopovers test options to false so that WKTR will (a) not register a
runOpenPanel UI delegate callback, causing WebKit to create a WKFileUploadPanel instead, and
(b) swizzle two UIKit view controller presentation methods to prevent the document picker
menu from being presented. The test merely wants the WKFileUploadPanel instance to exist in
order to query its available actions, not for it to show UI.
In r258092, WKFileUploadPanel now sometimes uses a UIContextMenuInteraction instance to
present the document picker menu, but -[UIContextMenuInteraction _presentMenuAtLocation:]
fails due to WKTR's above-mentioned swizzling. When this failure occurs,
UIContextMenuInteraction calls -contextMenuInteraction:willEndForConfiguration:animator: on
its delegate (the WKFileUploadPanel), which dismisses the open panel before the test has had
a chance to query the available actions.
Fixed this by swizzling -[UIContextMenuInteraction _presentMenuAtLocation:] when the
shouldPresentPopovers test option is false.
- WebKitTestRunner/ios/TestControllerIOS.mm:
(overridePresentMenuOrPopoverOrViewController): Renamed from
overridePresentViewControllerOrPopover.
(WTR::TestController::platformResetStateToConsistentValues): Swizzled
-[UIContextMenuInteraction _presentMenuAtLocation:] with
overridePresentMenuOrPopoverOrViewController when the shouldPresentPopovers test option is
false.
(overridePresentViewControllerOrPopover): Renamed to
overridePresentMenuOrPopoverOrViewController.
- 6:37 PM Changeset in webkit [263193] by
-
- 2 edits in trunk/Source/JavaScriptCore
StructureIDTable::validate() doesn't work when compiled with GCC.
https://bugs.webkit.org/show_bug.cgi?id=213302
<rdar://problem/64452172>
Reviewed by Yusuke Suzuki.
I was previously using ensureStillAliveHere() to force the validation load to
not be elided. However, this is not how ensureStillAliveHere() works. The proper
way to force the load is to use a volatile pointer instead, which is applied in
this patch.
With Clang, the ensureStillAliveHere() happened to do what I expected, but with
GCC it did not. The compiler is at liberty to elide the load because there is
no memory clobbering operation between the load and the call to
ensureStillAliveHere(). Switching to using the volatile pointer solution.
- runtime/StructureIDTable.h:
(JSC::StructureIDTable::validate):
- 4:57 PM Changeset in webkit [263192] by
-
- 4 edits in trunk/Source/WebKit
Remove references to blacklist/whitelist in the old C API
https://bugs.webkit.org/show_bug.cgi?id=213322
Reviewed by Tim Horton.
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserStyleSheet):
(WKPageGroupAddUserScript):
- UIProcess/API/C/WKPageGroup.h:
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
- 4:53 PM Changeset in webkit [263191] by
-
- 2 edits in trunk/JSTests
Skip JSTests/stress/check-is-constant-non-cell-should-not-array-profile-during-osr-exit.js on memory limited devices
https://bugs.webkit.org/show_bug.cgi?id=213321
Reviewed by Mark Lam.
It uses ~1GB of memory and jetsams on iOS devices.
- stress/check-is-constant-non-cell-should-not-array-profile-during-osr-exit.js:
- 4:03 PM Changeset in webkit [263190] by
-
- 1 copy in branches/safari-609.3.5.3-branch
New branch.
- 4:03 PM Changeset in webkit [263189] by
-
- 1 copy in branches/safari-609.3.5.2-branch
New branch.
- 4:03 PM Changeset in webkit [263188] by
-
- 1 copy in branches/safari-609.3.5.1-branch
New branch.
- 4:03 PM Changeset in webkit [263187] by
-
- 1 copy in branches/safari-609.3.5.0-branch
New branch.
- 3:46 PM Changeset in webkit [263186] by
-
- 2 edits in trunk/Tools
REGRESSION (r263044): [macOS] TestWebKitAPI.TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213311
<rdar://problem/64456413>
Reviewed by Wenson Hsieh.
TextManipulation.InsertingContentIntoAlreadyManipulatedContentCreatesTextManipulationItem does not wait long
enough to make sure TextManipulationController gets notified about the insertion and starts observing.
- TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):
- 3:45 PM Changeset in webkit [263185] by
-
- 8 edits in trunk/Source
Versioning.
WebKit-610.1.18
- 3:31 PM Changeset in webkit [263184] by
-
- 8 edits in branches/safari-609-branch/Source
Versioning.
WebKit-609.3.6
- 3:30 PM Changeset in webkit [263183] by
-
- 1 copy in tags/Safari-609.3.5
Tag Safari-609.3.5.
- 3:23 PM Changeset in webkit [263182] by
-
- 1 copy in branches/safari-610.1.17-branch
Tag Safari-610.1.17.
- 2:29 PM Changeset in webkit [263181] by
-
- 11 edits3 deletes in trunk/Tools
Delete code for old ews bindings queue
https://bugs.webkit.org/show_bug.cgi?id=213315
Rubber-stamped by Alexey Proskuryakov.
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.run_bindings_tests_command): Deleted.
(WinPort.run_bindings_tests_command): Deleted.
- Scripts/webkitpy/common/config/ports_mock.py:
(MockPort.run_bindings_tests_command): Deleted.
- Scripts/webkitpy/common/net/generictestresults.py: Removed.
- Scripts/webkitpy/common/net/generictestresults_unittest.py: Removed.
- Scripts/webkitpy/tool/bot/bindingstestresultsreader.py: Removed.
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTask._retry_bindings_tests): Deleted.
- Scripts/webkitpy/tool/bot/retrylogic_unittest.py:
(MockBindingsEarlyWarningSystem): Deleted.
(MockBindingsEarlyWarningSystem.init): Deleted.
(MockBindingsEarlyWarningSystem.test_results): Deleted.
(BindingsEarlyWarningSystemTest): Deleted.
(BindingsEarlyWarningSystemTest._results_indicate_all_passed): Deleted.
(BindingsEarlyWarningSystemTest._create_task): Deleted.
(BindingsEarlyWarningSystemTest.test_success_case): Deleted.
(BindingsEarlyWarningSystemTest.test_test_failure): Deleted.
(BindingsEarlyWarningSystemTest.test_fix): Deleted.
(BindingsEarlyWarningSystemTest.test_ineffective_patch): Deleted.
(BindingsEarlyWarningSystemTest.test_partially_effective_patch): Deleted.
(BindingsEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Deleted.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(TestBindingsEWS): Deleted.
(AbstractEarlyWarningSystemTest.test_failing_bindings_tests_message): Deleted.
- Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests._run_bindings_tests): Deleted.
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(test_patch_relevant_bindings): Deleted.
(test_runtests_api): Deleted.
- 1:23 PM Changeset in webkit [263180] by
-
- 3 edits1 add in trunk
[JSC] Freeze JSBigInt when setting it as a constant in AI
https://bugs.webkit.org/show_bug.cgi?id=213310
<rdar://problem/64450410>
Reviewed by Mark Lam.
JSTests:
- stress/bigint-constant-fold-to-numeric.js: Added.
(foo):
Source/JavaScriptCore:
JSCells should be explicitly frozen via DFG::Graph::freeze or DFG::Graph::freezeStrong. And heap JSBigInt is JSCell.
We should freeze it before setting it as a parameter of setConstant in AI. We use DFG::Graph::freeze since we know
that this is coming from somewhere in DFG graph: this ToNumeric node itself is not newly producing this JSBigInt.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- 1:09 PM Changeset in webkit [263179] by
-
- 3 edits8 adds in trunk
quikr.com: unable to select item from dropdown
https://bugs.webkit.org/show_bug.cgi?id=213260
<rdar://problem/58106011>
Reviewed by Zalan Bujtas.
Source/WebCore:
Only account for box-shadow when computing the background rect if the clipping element itself has non-zero used width and height.
Tests: fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-height-clipping-container.html
fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-width-clipping-container.html
fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container.html
fast/box-shadow/hit-test-box-shadow-on-zero-width-clipping-container.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::addVisualEffectOverflow):
LayoutTests:
Add two new tests that check that we correctly do not consider content within a clipping container that
has 0-width or 0-height and box-shadow, with or without empty margins.
- fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-height-clipping-container-expected.txt: Added.
- fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-height-clipping-container.html: Added.
- fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-width-clipping-container-expected.txt: Added.
- fast/box-shadow/hit-test-box-shadow-and-margin-on-zero-width-clipping-container.html: Added.
- fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container-expected.txt: Added.
- fast/box-shadow/hit-test-box-shadow-on-zero-height-clipping-container.html: Added.
- fast/box-shadow/hit-test-box-shadow-on-zero-width-clipping-container-expected.txt: Added.
- fast/box-shadow/hit-test-box-shadow-on-zero-width-clipping-container.html: Added.
- 12:52 PM Changeset in webkit [263178] by
-
- 4 edits in trunk/Source
Replace OptionSetTraits/OptionSetValues with EnumTraits/EnumValues
<https://webkit.org/b/213264>
Reviewed by Brent Fulgham.
Source/WebCore:
- page/DragActions.h:
(EnumTraits<WebCore::DragDestinationAction>):
- Rename from OptionSetTraits<WebCore::DragDestinationAction>.
(OptionSetTraits<WebCore::DragOperation>):
(OptionSetTraits<WebCore::DragSourceAction>):
- Remove since EnumTraits<> already exist for both.
Source/WTF:
- wtf/OptionSet.h:
(WTF::isValidOptionSetEnum):
(WTF::maskRawValue):
- Replace OptionSetTraits<>/OptionSetValues<> with EnumTraits<>/EnumValues<>.
- 12:44 PM Changeset in webkit [263177] by
-
- 28 edits17 copies66 adds10 deletes in trunk/JSTests
Update test262 to commit 8d3dd2d1a0a5
https://bugs.webkit.org/show_bug.cgi?id=213312
Reviewed by Yusuke Suzuki.
- test262/expectations.yaml:
- test262/latest-changes-summary.txt:
- test262/test/*: Updated.
- test262/test262-Revision.txt:
- 12:07 PM Changeset in webkit [263176] by
-
- 1 edit in trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
Another build fix for iOS.
This time for the new build system, which
wasn't running a custom rule for exported header files.
- ANGLE.xcodeproj/project.pbxproj:
- 11:55 AM Changeset in webkit [263175] by
-
- 3 edits in trunk/Source/WebCore
media/remoteplayback-target-availability.html was a flaky failure after r262904
https://bugs.webkit.org/show_bug.cgi?id=213294
Reviewed by Sam Weinig.
AirPlay availability is a global that depends on a timer (and/or an
external piece of hardware). Therefore, the first value RemotePlayback
sees for AirPlay availability, while usually 'unavailable', is sometimes
'available'. Flaky!
In this case, media/remoteplayback-prompt.html triggered an AirPlay
availability check, and then media/remoteplayback-target-availability.html,
if run in the same process, sometimes saw 'available' as its initial
availability state.
Make RemotePlayback's initial availability state deterministic by
recording availability state at the time we enqueue our task, rather
than at the time we dequeue our task. (By specification and
implementation, RemotePlayback's initial availability state is always
'unavailable', regardless of AirPlay state.) This is OK to do because,
if the state ever changes after we enqueue our task, we'll get an update
notification and enqueue a new task.
- Modules/remoteplayback/RemotePlayback.cpp:
(WebCore::RemotePlayback::watchAvailability): Copy the availability
state when we enqueue our task, and do not update it when we dequeue our
task. This is the heart of the bug fix.
Make sure to manually update availability state when we first register
to monitor availability, since we never got an update notification for
the current state.
(WebCore::RemotePlayback::prompt): For consistency with
watchAvailability, do not update availability state when we dequeue our
task. (This means that prompting before watching availability is always
an error, which is fine, and consistent with the spec, which says, "If
the user agent stops monitoring the list of available remote playback
devices... It SHOULD also set the availability value for all media
elements to false.")
Make sure to manually update availability state when we first register
to monitor availability, since we never got an update notification for
the current state.
(WebCore::RemotePlayback::availabilityChanged): For consistency with
watchAvailability, do not update availability state when we dequeue our
task.
(WebCore::RemotePlayback::updateAvailability): Deleted. We never
synchronously update our state anymore. All state changes are queued and
processed in order.
- Modules/remoteplayback/RemotePlayback.h:
- 11:40 AM Changeset in webkit [263174] by
-
- 3 edits2 adds in trunk
$vm.haveABadTime/isHavingABadTime should work with non-globalObject parameters
https://bugs.webkit.org/show_bug.cgi?id=213304
Reviewed by Mark Lam.
JSTests:
- stress/dollarVM-have-a-bad-time-no-params.js: Added.
- stress/dollarVM-have-a-bad-time-works-for-non-global-object-params.js: Added.
Source/JavaScriptCore:
Previously, $vm.haveABadTime would crash if passed a
non-globalObject object as the first parameter because it was
missing areturnin front the error handling case. This patch
resolves that issue but also extends the semantics of
haveABadTime/isHavingABadTime to either use the global object of
the first parameter even if it's not a JSGlobalObject. If no
argument is passed, haveABadTime/isHavingABadTime instead use the
global object of the callee.
- tools/JSDollarVM.cpp:
(JSC::functionHaveABadTime):
(JSC::functionIsHavingABadTime):
- 11:38 AM Changeset in webkit [263173] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: move some unused data inside ENABLE(JIT) to unbreak the CLoop build.
https://bugs.webkit.org/show_bug.cgi?id=213255
Not reviewed.
- assembler/testmasm.cpp:
- 11:29 AM Changeset in webkit [263172] by
-
- 1 edit in trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/gl/cgl/ContextCGL.cpp
Fix iOS build.
- src/libANGLE/renderer/gl/cgl/ContextCGL.cpp:
- 11:25 AM Changeset in webkit [263171] by
-
- 2 edits in trunk/LayoutTests
http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=213272
<rdar://problem/64427778>
Reviewed by David Kilzer.
Before a navigation occurs, an app-bound network session is created
by default. If any non-app bound navigations occur, a new session is
created. Since this test only checks for the existance of an app-bound
session, it should clear the app-bound session after the initial load
to properly test functionality.
- http/tests/in-app-browser-privacy/non-app-bound-domain-does-not-get-app-bound-session.html:
- 11:23 AM Changeset in webkit [263170] by
-
- 1 copy in tags/Safari-610.1.15.51.4
Tag Safari-610.1.15.51.4.
- 11:16 AM Changeset in webkit [263169] by
-
- 2 edits in trunk/Source/WebKit
Null check plugin.m_data before using it in PDFPlugin::ByteRangeRequest::completeUnconditionally
https://bugs.webkit.org/show_bug.cgi?id=213305
<rdar://problem/60349279>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-06-17
Reviewed by Brady Eidson.
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::ByteRangeRequest::completeUnconditionally):
- 11:07 AM Changeset in webkit [263168] by
-
- 3 edits1 delete in trunk/Tools
Delete code for old ews style queue
https://bugs.webkit.org/show_bug.cgi?id=213297
Rubber-stamped by Alexey Proskuryakov.
- Scripts/webkitpy/tool/bot/stylequeuetask.py: Removed.
- Scripts/webkitpy/tool/commands/queues.py:
(StyleQueue): Deleted.
(StyleQueue.init): Deleted.
(StyleQueue.review_patch): Deleted.
(StyleQueue.run_command): Deleted.
(StyleQueue.expected_failures): Deleted.
(StyleQueue.refetch_patch): Deleted.
- Scripts/webkitpy/tool/commands/queues_unittest.py:
(TestReviewQueue): Deleted.
- 10:56 AM Changeset in webkit [263167] by
-
- 11 edits4 adds1 delete in trunk
Image
referrerpolicymutations should be considered "relevant mutations"
https://bugs.webkit.org/show_bug.cgi?id=209970
Patch by Rob Buis <rbuis@igalia.com> on 2020-06-17
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Import latest version of relevant-mutations.html.
Because original-referrer-policy-applied.sub.html is older and assumes referrerpolicy is not a relevant
mutation, remove it and replace it by imported image-loading-lazy-referrerpolicy-change.sub.html.
- web-platform-tests/html/semantics/embedded-content/resources/common.js: Added.
(ElementLoadPromise):
(ElementLoadPromise.prototype.element):
(is_image_fully_loaded):
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/original-referrer-policy-applied.sub.html: Removed.
- web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html:
Source/WebCore:
Make referrerpolicy state changes a relevant mutation [1]. In order to indicate
that we are dealing with a relevant mutation add an enum to updateFromElement, in
order to run "update the image data" algorithm [2] in case it is a relevant mutation.
Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/relevant-mutations.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html
[1] https://html.spec.whatwg.org/#reacting-to-dom-mutations:attr-img-referrerpolicy
[2] https://html.spec.whatwg.org/#when-to-obtain-images
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::attributeChanged):
- html/HTMLImageElement.h:
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateFromElement):
(WebCore::ImageLoader::updateFromElementIgnoringPreviousError):
(WebCore::ImageLoader::loadDeferredImage):
- loader/ImageLoader.h:
LayoutTests:
Unskip relevant-mutations.html.
- TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- 10:47 AM Changeset in webkit [263166] by
-
- 9 edits1 delete in trunk/Tools
Delete code for old ews webkitpy queue
https://bugs.webkit.org/show_bug.cgi?id=213299
Reviewed by Jonathan Bedard.
- Scripts/webkitpy/common/config/ews.json:
- Scripts/webkitpy/common/net/generictestresults.py:
(WebkitpyTestResults): Deleted.
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
- Scripts/webkitpy/tool/bot/webkitpytestresultsreader.py: Removed.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
- Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(TestWebkitpyEWS): Deleted.
(AbstractEarlyWarningSystemTest.test_failing_webkitpy_tests_message): Deleted.
- Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
- Scripts/webkitpy/tool/steps/runtests.py:
(RunTests._run_webkitpy_tests): Deleted.
- Scripts/webkitpy/tool/steps/steps_unittest.py:
(test_runtests_webkitpy): Deleted.
(test_patch_not_relevant_bindings): Deleted.
(test_runtests_api_debug): Deleted.
- 10:31 AM Changeset in webkit [263165] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, avoid node access in link-task
https://bugs.webkit.org/show_bug.cgi?id=213266
<rdar://problem/64453001>
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCheckJSCast):
- 10:28 AM Changeset in webkit [263164] by
-
- 3 edits2 adds in trunk
WebKitTestRunner should not crash on alert with invalid utf16 strings
https://bugs.webkit.org/show_bug.cgi?id=213269
Reviewed by Simon Fraser.
Tools:
- WebKitTestRunner/StringFunctions.h:
(WTR::toWTFString):
LayoutTests:
- fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash-expected.txt: Added.
- fast/dom/Window/alert-with-unmatched-utf16-surrogate-should-not-crash.html: Added.
- 10:23 AM Changeset in webkit [263163] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix internal macOS build after r263157.
- rendering/RenderThemeMac.mm:
- 10:10 AM Changeset in webkit [263162] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r263098): [Win10] http/tests/security/cross-origin-clean-css-resource-timing.html and http/tests/security/cross-origin-css-resource-timing.html are failing
https://bugs.webkit.org/show_bug.cgi?id=213303
Unreviewed test gardening.
- platform/win/TestExpectations: Mark tests as failing.
- 10:06 AM Changeset in webkit [263161] by
-
- 3 edits in branches/safari-609-branch/Source/ThirdParty/libwebrtc
Cherry-pick r263154. rdar://problem/64452498
Improve SCTP cookie generation
https://bugs.webkit.org/show_bug.cgi?id=213284
<rdar://problem/64438133>
Reviewed by Eric Carlson.
- Source/webrtc/media/sctp/sctp_transport.cc:
- Source/webrtc/media/sctp/sctp_transport.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:56 AM Changeset in webkit [263160] by
-
- 172 edits in trunk/Source/WebCore
Use constructor operations in WebIDL
https://bugs.webkit.org/show_bug.cgi?id=201397
Reviewed by Eric Carlson.
Add support for constructor syntax in WebIDL (https://heycam.github.io/webidl/#idl-constructors)
- [Constructor(...)] extended attributes become constructor(...) operations
- [JSBuiltinConstructor] becomes [JSBuiltin] constructor(...)
- [CustomConstructor] becomes [Custom] constructor(...)
- [ConstructorMayThrowException] becomes [MayThrowException] constructor(...) and can now be unique per-overload
- [ConstructorCallWith=Foo] becomes [CallWith=Foo] constructor(...) and can now also be unique per-overload
This change leaves NamedConstructor as is, but a subsequent change will replace it with the
specified LegacyFactoryFunction extended attribute.
- Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl:
- Modules/applepay/ApplePayError.idl:
- Modules/applepay/ApplePaySession.idl:
- Modules/applepay/ApplePaySetup.idl:
- Modules/async-clipboard/ClipboardItem.idl:
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
- Modules/encryptedmedia/legacy/WebKitMediaKeys.idl:
- Modules/fetch/FetchHeaders.idl:
- Modules/fetch/FetchRequest.idl:
- Modules/fetch/FetchResponse.idl:
- Modules/gamepad/GamepadEvent.idl:
- Modules/highlight/HighlightMap.idl:
- Modules/highlight/HighlightRangeGroup.idl:
- Modules/indexeddb/IDBVersionChangeEvent.idl:
- Modules/mediarecorder/BlobEvent.idl:
- Modules/mediarecorder/MediaRecorder.idl:
- Modules/mediarecorder/MediaRecorderErrorEvent.idl:
- Modules/mediasession/MediaRemoteControls.idl:
- Modules/mediasession/MediaSession.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrackEvent.idl:
- Modules/mediastream/OverconstrainedError.idl:
- Modules/mediastream/OverconstrainedErrorEvent.idl:
- Modules/mediastream/RTCDTMFToneChangeEvent.idl:
- Modules/mediastream/RTCDataChannelEvent.idl:
- Modules/mediastream/RTCIceCandidate.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCPeerConnectionIceEvent.idl:
- Modules/mediastream/RTCSessionDescription.idl:
- Modules/mediastream/RTCTrackEvent.idl:
- Modules/notifications/Notification.idl:
- Modules/paymentrequest/MerchantValidationEvent.idl:
- Modules/paymentrequest/PaymentMethodChangeEvent.idl:
- Modules/paymentrequest/PaymentRequest.idl:
- Modules/paymentrequest/PaymentRequestUpdateEvent.idl:
- Modules/pictureinpicture/EnterPictureInPictureEvent.idl:
- Modules/speech/SpeechSynthesisUtterance.idl:
- Modules/streams/ByteLengthQueuingStrategy.idl:
- Modules/streams/CountQueuingStrategy.idl:
- Modules/streams/ReadableByteStreamController.idl:
- Modules/streams/ReadableStream.idl:
- Modules/streams/ReadableStreamBYOBReader.idl:
- Modules/streams/ReadableStreamBYOBRequest.idl:
- Modules/streams/ReadableStreamDefaultController.idl:
- Modules/streams/ReadableStreamDefaultReader.idl:
- Modules/streams/WritableStream.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webgpu/GPUOutOfMemoryError.idl:
- Modules/webgpu/GPUUncapturedErrorEvent.idl:
- Modules/webgpu/GPUValidationError.idl:
- Modules/websockets/CloseEvent.idl:
- Modules/websockets/WebSocket.idl:
- Modules/webxr/WebXRRigidTransform.idl:
- Modules/webxr/WebXRWebGLLayer.idl:
- Modules/webxr/XRInputSourceEvent.idl:
- Modules/webxr/XRInputSourcesChangeEvent.idl:
- Modules/webxr/XRReferenceSpaceEvent.idl:
- Modules/webxr/XRSessionEvent.idl:
- animation/AnimationPlaybackEvent.idl:
- animation/DocumentTimeline.idl:
- animation/KeyframeEffect.idl:
- animation/WebAnimation.idl:
- bindings/scripts/CodeGeneratorJS.pm:
(ShouldGenerateToJSDeclaration):
(GetFullyQualifiedImplementationCallName):
(GenerateParametersCheck):
(GetConstructorTemplateClassName):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(HasCustomConstructor):
(IsConstructable):
(HasJSBuiltinConstructor):
(AddJSBuiltinIncludesIfNeeded):
(IsJSBuiltinConstructor): Deleted.
- bindings/scripts/IDLAttributes.json:
- bindings/scripts/IDLParser.pm:
(assertExtendedAttributesValidForContext):
(copyExtendedAttributes):
(cloneOperation):
(applyTypedefs):
(parseInterfaceMember):
(parseConstructor):
(parseExtendedAttributeRest):
(applyMemberList):
(applyExtendedAttributeList):
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorConstructor::initializeProperties):
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):
- bindings/scripts/test/TestClassWithJSBuiltinConstructor.idl:
- bindings/scripts/test/TestEventConstructor.idl:
- bindings/scripts/test/TestInterface.idl:
- bindings/scripts/test/TestJSBuiltinConstructor.idl:
- bindings/scripts/test/TestNamedConstructor.idl:
- bindings/scripts/test/TestNode.idl:
- bindings/scripts/test/TestObj.idl:
- bindings/scripts/test/TestOverloadedConstructors.idl:
- bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl:
- bindings/scripts/test/TestPromiseRejectionEvent.idl:
- bindings/scripts/test/TestTypedefs.idl:
- css/DOMMatrix.idl:
- css/DOMMatrixReadOnly.idl:
- css/FontFace.idl:
- css/FontFaceSet.idl:
- css/MediaQueryListEvent.idl:
- css/WebKitCSSMatrix.idl:
- css/typedom/TypedOMCSSUnitValue.idl:
- css/typedom/TypedOMCSSUnparsedValue.idl:
- dom/AbortController.idl:
- dom/AnimationEvent.idl:
- dom/BeforeLoadEvent.idl:
- dom/ClipboardEvent.idl:
- dom/Comment.idl:
- dom/CompositionEvent.idl:
- dom/CustomEvent.idl:
- dom/DOMException.idl:
- dom/DOMPoint.idl:
- dom/DOMPointReadOnly.idl:
- dom/DOMQuad.idl:
- dom/DOMRect.idl:
- dom/DOMRectReadOnly.idl:
- dom/Document.idl:
- dom/DocumentFragment.idl:
- dom/DragEvent.idl:
- dom/ErrorEvent.idl:
- dom/Event.idl:
- dom/EventTarget.idl:
- dom/FocusEvent.idl:
- dom/HashChangeEvent.idl:
- dom/InputEvent.idl:
- dom/KeyboardEvent.idl:
- dom/MessageChannel.idl:
- dom/MessageEvent.idl:
- dom/MouseEvent.idl:
- dom/MutationObserver.idl:
- dom/OverflowEvent.idl:
- dom/PageTransitionEvent.idl:
- dom/PointerEvent.idl:
- dom/PopStateEvent.idl:
- dom/ProgressEvent.idl:
- dom/PromiseRejectionEvent.idl:
- dom/Range.idl:
- dom/SecurityPolicyViolationEvent.idl:
- dom/StaticRange.idl:
- dom/Text.idl:
- dom/TextDecoder.idl:
- dom/TextEncoder.idl:
- dom/TransitionEvent.idl:
- dom/UIEvent.idl:
- dom/WebKitAnimationEvent.idl:
- dom/WebKitTransitionEvent.idl:
- dom/WheelEvent.idl:
- fileapi/Blob.idl:
- fileapi/File.idl:
- fileapi/FileReader.idl:
- fileapi/FileReaderSync.idl:
- html/DOMFormData.idl:
- html/DOMURL.idl:
- html/HTMLElement.idl:
- html/HTMLOptionElement.idl:
- html/ImageData.idl:
- html/MediaController.idl:
- html/MediaEncryptedEvent.idl:
- html/OffscreenCanvas.idl:
- html/URLSearchParams.idl:
- html/canvas/Path2D.idl:
- html/canvas/WebGLContextEvent.idl:
- html/track/DataCue.idl:
- html/track/TextTrackCue.idl:
- html/track/TrackEvent.idl:
- html/track/VTTCue.idl:
- html/track/VTTRegion.idl:
- page/EventSource.idl:
- page/IntersectionObserver.idl:
- page/IntersectionObserverEntry.idl:
- page/PerformanceObserver.idl:
- page/ResizeObserver.idl:
- page/UndoItem.idl:
- page/WebKitPoint.idl:
- storage/StorageEvent.idl:
- workers/Worker.idl:
- workers/service/ExtendableEvent.idl:
- workers/service/ExtendableMessageEvent.idl:
- workers/service/FetchEvent.idl:
- xml/DOMParser.idl:
- xml/XMLHttpRequest.idl:
- xml/XMLSerializer.idl:
- xml/XPathEvaluator.idl:
- xml/XSLTProcessor.idl:
- 9:55 AM Changeset in webkit [263159] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed test gardening.
- platform/win/TestExpectations:
- 9:54 AM Changeset in webkit [263158] by
-
- 2 edits in trunk/Source/WebCore/PAL
Another unreviewed build fix after r263150
- pal/spi/cocoa/PassKitSPI.h:
- 9:51 AM Changeset in webkit [263157] by
-
- 42 edits2 copies1 add in trunk
IndexedDB: Support IDBFactory databases method
https://bugs.webkit.org/show_bug.cgi?id=211043
Patch by Darryl Pogue <darryl@dpogue.ca> on 2020-06-17
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Adjust test expectations for
IDBFactory.prototype.databases().
- web-platform-tests/IndexedDB/get-databases.any-expected.txt:
- web-platform-tests/IndexedDB/get-databases.any.worker-expected.txt:
- web-platform-tests/IndexedDB/idbfactory-databases-opaque-origin-expected.txt:
- web-platform-tests/IndexedDB/idbfactory-origin-isolation-expected.txt:
- web-platform-tests/IndexedDB/idlharness.any-expected.txt:
- web-platform-tests/IndexedDB/idlharness.any.worker-expected.txt:
Source/WebCore:
Add support for fetching the list of IDB database names and versions
from the IDBServer, and expose the functionality as
IDBFactory.prototype.databases().
Spec: https://w3c.github.io/IndexedDB/#dom-idbfactory-databases
- Headers.cmake:
- Modules/indexeddb/IDBActiveDOMObject.h:
(WebCore::IDBActiveDOMObject::performCallbackOnOriginThread):
- Modules/indexeddb/IDBDatabaseNameAndVersionRequest.cpp: Added.
(WebCore::IDBDatabaseNameAndVersionRequest::create):
(WebCore::IDBDatabaseNameAndVersionRequest::IDBDatabaseNameAndVersionRequest):
(WebCore::IDBDatabaseNameAndVersionRequest::~IDBDatabaseNameAndVersionRequest):
(WebCore::IDBDatabaseNameAndVersionRequest::complete):
(WebCore::IDBDatabaseNameAndVersionRequest::activeDOMObjectName const):
(WebCore::IDBDatabaseNameAndVersionRequest::virtualHasPendingActivity const):
(WebCore::IDBDatabaseNameAndVersionRequest::stop):
- Modules/indexeddb/IDBDatabaseNameAndVersionRequest.h: Added.
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::databases):
(WebCore::IDBFactory::getAllDatabaseNames):
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/IDBFactory.idl:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::connectionToServerLost):
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionProxy::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionProxy::forgetActivityForCurrentThread):
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNames): Deleted.
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionToServer::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNames): Deleted.
(WebCore::IDBClient::IDBConnectionToServer::didGetAllDatabaseNames): Deleted.
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBConnectionToClient::didGetAllDatabaseNames): Deleted.
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::getAllDatabaseNamesAndVersions):
(WebCore::IDBServer::IDBServer::getAllDatabaseNames): Deleted.
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameAndVersionFromFile):
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromFile): Deleted.
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
- Modules/indexeddb/shared/IDBDatabaseNameAndVersion.h: Added.
(WebCore::IDBDatabaseNameAndVersion::encode const):
(WebCore::IDBDatabaseNameAndVersion::decode):
(WebCore::IDBDatabaseNameAndVersion::isolatedCopy const):
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- inspector/agents/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
- loader/EmptyClients.cpp:
Source/WebKit:
Plumbing for returning a list of IDB databases and versions.
- NetworkProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::didGetAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToClient::didGetAllDatabaseNames): Deleted.
- NetworkProcess/IndexedDB/WebIDBConnectionToClient.h:
- NetworkProcess/IndexedDB/WebIDBServer.cpp:
(WebKit::WebIDBServer::getAllDatabaseNamesAndVersions):
(WebKit::WebIDBServer::getAllDatabaseNames): Deleted.
- NetworkProcess/IndexedDB/WebIDBServer.h:
- NetworkProcess/IndexedDB/WebIDBServer.messages.in:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::getAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToServer::didGetAllDatabaseNamesAndVersions):
(WebKit::WebIDBConnectionToServer::getAllDatabaseNames): Deleted.
(WebKit::WebIDBConnectionToServer::didGetAllDatabaseNames): Deleted.
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:
Source/WebKitLegacy:
Plumbing for returning a list of IDB databases and versions.
- Storage/InProcessIDBServer.cpp:
(InProcessIDBServer::getAllDatabaseNamesAndVersions):
(InProcessIDBServer::didGetAllDatabaseNamesAndVersions):
(InProcessIDBServer::getAllDatabaseNames): Deleted.
(InProcessIDBServer::didGetAllDatabaseNames): Deleted.
- Storage/InProcessIDBServer.h:
- 9:42 AM Changeset in webkit [263156] by
-
- 8 edits in trunk
[WPT] infrastructure/assumptions/html-elements.html fails due to changes in style when all: initial is used
https://bugs.webkit.org/show_bug.cgi?id=213171
Reviewed by Antti Koivisto.
LayoutTests/imported/w3c:
- web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
- web-platform-tests/infrastructure/assumptions/html-elements-expected.txt:
Update test results.
Source/WebCore:
Update existing test results that now pass.
- css/CSSProperties.json:
Use initialStrokeColor (the default) rather than hardcoding the incorrect currentColor. The spec (and initialStrokeColor)
say this should be transparent.
- style/StyleBuilderCustom.h:
(WebCore::Style::ApplyPropertyBorderImageModifier::applyInitialValue):
Match the mask image NinePieceImage constructor, and set fill to true for mask image slices.
LayoutTests:
- platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
Update test results.
- 9:24 AM Changeset in webkit [263155] by
-
- 3 edits in trunk/Source/WebCore
[LFC][Float] Move float avoiders' final position compute next to when the static position is computed
https://bugs.webkit.org/show_bug.cgi?id=213250
Reviewed by Antti Koivisto.
Now that the float avoider's final position has no dependecy on the computed height, we can
move it all the way up, next to where we computed the static position.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layoutInFlowContent):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForAncestors): Deleted.
- layout/blockformatting/BlockFormattingContext.h:
- 9:24 AM Changeset in webkit [263154] by
-
- 3 edits in trunk/Source/ThirdParty/libwebrtc
Improve SCTP cookie generation
https://bugs.webkit.org/show_bug.cgi?id=213284
<rdar://problem/64438133>
Reviewed by Eric Carlson.
- Source/webrtc/media/sctp/sctp_transport.cc:
- Source/webrtc/media/sctp/sctp_transport.h:
- 9:23 AM Changeset in webkit [263153] by
-
- 5 edits2 adds in trunk
[Modern Media Controls] CSS "cursor" property shoud be respected in media controls shadow root
https://bugs.webkit.org/show_bug.cgi?id=213295
<rdar://problem/61911638>
Reviewed by Timothy Hatcher.
Source/WebCore:
Allow the "cursor" property to be inherited in the media controls shadow root, but still overriden
for interactive objects in the media controls as well as placard text.
Test: media/modern-media-controls/css/cursor.html
- Modules/modern-media-controls/controls/controls-bar.css:
(.controls-bar):
- Modules/modern-media-controls/controls/media-controls.css:
(.media-controls-container):
(.media-controls):
- Modules/modern-media-controls/controls/placard.css:
(.placard .title,):
LayoutTests:
Add a test that checks that setting the "cursor" property on a <video> element also applies to the
media controls in the element's shadow root.
- media/modern-media-controls/css/cursor-expected.txt: Added.
- media/modern-media-controls/css/cursor.html: Added.
- 9:17 AM Changeset in webkit [263152] by
-
- 2 edits in trunk/Source/WebCore/PAL
Unreviewed build fix after r263150
- pal/spi/cocoa/PassKitSPI.h:
- 8:59 AM Changeset in webkit [263151] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add a shiftAndAdd() emitter in AssemblyHelpers.
https://bugs.webkit.org/show_bug.cgi?id=213255
Reviewed by Michael Saboff.
void shiftAndAdd(RegisterID base, RegisterID index, uint8_t shift, RegisterID dest, Optional<RegisterID> = { });
Emits code to compute: dest = base + index << shift.
- assembler/testmasm.cpp:
(doubleOperands):
(floatOperands):
(int32Operands):
(int64Operands):
(JSC::testShiftAndAdd):
(JSC::run):
(JSC::doubleOperands): Deleted.
(JSC::floatOperands): Deleted.
(JSC::int32Operands): Deleted.
(JSC::int64Operands): Deleted.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::shiftAndAdd):
- 8:55 AM Changeset in webkit [263150] by
-
- 30 edits2 copies1 add in trunk
[Apple Pay] Enable layout tests on more platforms
https://bugs.webkit.org/show_bug.cgi?id=212955
<rdar://problem/64174156>
Reviewed by Alex Christensen.
Source/WebCore:
Added runtime checks to determine the Apple Pay API version when installments are enabled.
Enabled tests in http/tests/ssl/applepay on iOS.
- Modules/applepay/ApplePayInstallmentConfiguration.idl:
- Modules/applepay/ApplePayInstallmentConfigurationWebCore.h:
- Modules/applepay/ApplePayInstallmentItem.h:
- Modules/applepay/ApplePayInstallmentItem.idl:
- Modules/applepay/ApplePayInstallmentItemType.h:
- Modules/applepay/ApplePayInstallmentItemType.idl:
- Modules/applepay/ApplePayInstallmentRetailChannel.h:
- Modules/applepay/ApplePayInstallmentRetailChannel.idl: Removed uses of
APPLE_PAY_INSTALLMENT_IDENTIFIERS and APPLE_PAY_INSTALLMENT_ITEMS (or replaced with
APPLE_PAY_INSTALLMENTS).
- Modules/applepay/PaymentAPIVersion.h:
- Modules/applepay/cocoa/PaymentAPIVersionCocoa.mm:
(WebCore::PaymentAPIVersion::current): Moved the computation of current API version from
PaymentCoordinatorClient::supportsVersion to here. Added runtime checks to determine the
level of PassKit installments support since we don't have enough information to tell at
compile time.
- Modules/applepay/PaymentCoordinatorClient.cpp:
(WebCore::PaymentCoordinatorClient::supportsVersion): Changed to call
PaymentAPIVersion::current.
- Modules/applepay/PaymentInstallmentConfiguration.mm:
(WebCore::makeNSArrayElement):
(WebCore::createPlatformConfiguration):
(WebCore::PaymentInstallmentConfiguration::create):
(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const): Removed
uses of HAVE_PASSKIT_INSTALLMENT_ITEMS and HAVE_PASSKIT_INSTALLMENT_IDENTIFIERS. Used
runtime checks to determine support for PKPaymentInstallmentConfiguration and
PKPaymentInstallmentItem.
- SourcesCocoa.txt:
- WebCore.xcodeproj/project.pbxproj: Added source files for PaymentAPIVersion.
Source/WebCore/PAL:
PassKit added SPIs for Apple Pay installments over a series of iOS 13 and macOS Catalina
minor updates. WebKit trunk is still built across a range of iOS 13 and macOS Catalina minor
update SDKs that contain none, some, or all of the installment SPIs. It's not possible to
reliably detect the SDK minor version at compile-time, so instead we now use our own SPI
declarations unless we know all minor versions of the major SDK version contain all of the
installments definitions.
- PAL.xcodeproj/project.pbxproj: Added PassKitInstallmentsSPI.h.
- pal/cocoa/PassKitSoftLink.h:
- pal/cocoa/PassKitSoftLink.mm: Used SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT on both
Mac and iOS to soft-link PKPaymentInstallmentConfiguration and PKPaymentInstallmentItem.
- pal/spi/cocoa/PassKitInstallmentSPI.h: Added. When building against an SDK that is known
to declare the PassKit installments SPIs, this file includes the SPI headers. Otherwise, it
declares the SPIs.
- pal/spi/cocoa/PassKitSPI.h: Moved PassKit installments SPI declarations to
PassKitInstallmentSPI.h.
Source/WTF:
- wtf/PlatformEnableCocoa.h: Removed ENABLE_APPLE_PAY_INSTALLMENT_IDENTIFIERS,
ENABLE_APPLE_PAY_INSTALLMENT_ITEMS, ENABLE_APPLE_PAY_SESSION_V8,
ENABLE_APPLE_PAY_SESSION_V9, and ENABLE_APPLE_PAY_SESSION_V10.
- wtf/PlatformHave.h: Removed HAVE_PASSKIT_INSTALLMENT_IDENTIFIERS and corrected iOS version
checks for HAVE_PASSKIT_INSTALLMENTS.
LayoutTests:
- http/tests/ssl/applepay/ApplePayInstallmentItems.https.html: Changed to fail instead of
time out when API version 9 isn't supported.
- http/tests/ssl/applepay/ApplePayError.html:
- http/tests/ssl/applepay/ApplePaySession.html:
- http/tests/ssl/applepay/ApplePaySessionV3.html:
- http/tests/ssl/applepay/ApplePaySessionV4.html:
- http/tests/ssl/applepay/ApplePaySessionV5.html: Removed a custom element-clicking function
and used UIHelper.activateElement instead.
- platform/ios-wk2/TestExpectations: Un-skipped http/tests/ssl/applepay.
Marked PaymentRequest.https.html as Slow. Marked ApplePayInstallmentItems.https.html as
Failure.
- platform/mac-wk2/TestExpectations: Removed a trailing '/'. Skipped
ApplePayInstallmentItems.https.html on Mojave and marked it as Failure on Catalina.
- 8:47 AM Changeset in webkit [263149] by
-
- 3 edits in trunk/Source/WebCore
[LFC][Floats] Remove redundant mapping functions
https://bugs.webkit.org/show_bug.cgi?id=213249
Reviewed by Antti Koivisto.
It's incorrect to map the entire display box when the height is no even computed yet.
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):
(WebCore::Layout::FloatingContext::append):
(WebCore::Layout::FloatingContext::absoluteDisplayBoxCoordinates const):
(WebCore::Layout::FloatingContext::mapTopLeftToFloatingStateRoot const):
(WebCore::Layout::FloatingContext::mapToFloatingStateRoot const): Deleted.
(WebCore::Layout::FloatingContext::mapTopToFloatingStateRoot const): Deleted.
- layout/floats/FloatingContext.h:
- 8:34 AM Changeset in webkit [263148] by
-
- 2 edits in trunk/LayoutTests
[ Catalina WK2 Release ] http/tests/IndexedDB/storage-limit-1.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=213292
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:55 AM Changeset in webkit [263147] by
-
- 6 edits in trunk/Source/WebCore
[LFC]Floats] Cleanup FloatAvoider interface
https://bugs.webkit.org/show_bug.cgi?id=213195
Reviewed by Antti Koivisto.
Remove redundant functions/parameters.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats):
- layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::FloatAvoider):
(WebCore::Layout::FloatAvoider::topLeftInContainingBlock const): Deleted.
- layout/floats/FloatAvoider.h:
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::findAvailablePosition):
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForNonFloatingFloatAvoider const):
(WebCore::Layout::FloatingContext::positionForFormattingContextRoot const): Deleted.
(WebCore::Layout::FloatingContext::findPositionForFloatBox const): Deleted.
- layout/floats/FloatingContext.h:
- 7:41 AM Changeset in webkit [263146] by
-
- 3 edits in trunk/Source/JavaScriptCore
[Wasm] Reduce the amount of memory used by the Air register coloring allocator
https://bugs.webkit.org/show_bug.cgi?id=212106
Reviewed by Yusuke Suzuki.
Changed InterferenceEdge to be a templated class so we can instantiate an unsigned
short version to cut memory in half for code that has less than 216 temps.
Through instrumentation, my testing showed that almost all compilations use the
16bit implementation. Although this change is for all B3/Air compilations at O2,
Wasm compilations are usally larger and therefore get the greatest benefit.
This allowed increasing the default value for the option webAssemblyBBQFallbackSize,
with a small increase in memory usage.
- b3/air/AirAllocateRegistersByGraphColoring.cpp:
- runtime/OptionsList.h:
- 7:25 AM Changeset in webkit [263145] by
-
- 10 edits1 delete in trunk/LayoutTests
[GTK] Unreviewed test gardening. Update baselines and test expectations after r263143.
- platform/glib/svg/custom/svg-fonts-in-text-controls-expected.txt:
- platform/gtk/TestExpectations:
- platform/gtk/accessibility/form-control-value-settable-expected.txt:
- platform/gtk/accessibility/roles-exposed-expected.txt:
- platform/gtk/fast/css/line-height-expected.txt:
- platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
- platform/gtk/fast/forms/searchfield-heights-expected.txt:
- platform/gtk/http/tests/plugins/plugin-javascript-access-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/css/css-color/animation/opacity-interpolation-expected.txt:
- platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
- 7:05 AM Changeset in webkit [263144] by
-
- 7 edits2 deletes in trunk/Source/WebCore
[LFC][Floats] Remove FloatBox class
https://bugs.webkit.org/show_bug.cgi?id=213184
Reviewed by Antti Koivisto.
Apparently the only difference between a non-floating float avoider (regular formatting context root)
and a float box is that while float boxes intersect their margin box, simple float avoiders use their border box.
We can do that without subclassing FloatAvoider.
This patch is also in preparation for moving "computeFloatPosition" next to the static position computation when
the height value is not computed yet. So instead of passing in the display box, let's just pass in top/left and width.
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::FloatAvoider):
(WebCore::Layout::FloatAvoider::setHorizontalPosition):
(WebCore::Layout::FloatAvoider::setVerticalPosition):
(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):
(WebCore::Layout::FloatAvoider::overflowsContainingBlock const):
(WebCore::Layout::FloatAvoider::topLeftInContainingBlock const):
(WebCore::Layout::FloatAvoider::setHorizontalConstraints): Deleted.
(WebCore::Layout::FloatAvoider::setVerticalConstraint): Deleted.
(WebCore::Layout::FloatAvoider::horizontalPositionCandidate): Deleted.
(WebCore::Layout::FloatAvoider::verticalPositionCandidate): Deleted.
(WebCore::Layout::FloatAvoider::rectInContainingBlock const): Deleted.
- layout/floats/FloatAvoider.h:
(WebCore::Layout::FloatAvoider::resetHorizontalPosition):
(WebCore::Layout::FloatAvoider::isLeftAligned const):
(WebCore::Layout::FloatAvoider::borderBoxWidth const):
(WebCore::Layout::FloatAvoider::marginBefore const):
(WebCore::Layout::FloatAvoider::marginAfter const):
(WebCore::Layout::FloatAvoider::marginStart const):
(WebCore::Layout::FloatAvoider::marginEnd const):
(WebCore::Layout::FloatAvoider::marginBoxWidth const):
(WebCore::Layout::FloatAvoider::isFloatingBox const):
(WebCore::Layout::FloatAvoider::layoutBox const):
(WebCore::Layout::FloatAvoider::top const):
(WebCore::Layout::FloatAvoider::left const):
(WebCore::Layout::FloatAvoider::right const):
(WebCore::Layout::FloatAvoider::rect const): Deleted.
(WebCore::Layout::FloatAvoider::displayBox const): Deleted.
(WebCore::Layout::FloatAvoider::displayBox): Deleted.
- layout/floats/FloatBox.cpp: Removed.
- layout/floats/FloatBox.h: Removed.
- layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFormattingContextRoot const):
(WebCore::Layout::findAvailablePosition):
(WebCore::Layout::FloatingContext::findPositionForFloatBox const):
(WebCore::Layout::FloatingContext::findPositionForFormattingContextRoot const):
(WebCore::Layout::FloatPair::intersects const):
(WebCore::Layout::FloatPair::horizontalConstraints const):
- layout/floats/FloatingContext.h:
- 4:34 AM Changeset in webkit [263143] by
-
- 7 edits in trunk/Tools
Delete old ews client side code - part 2
https://bugs.webkit.org/show_bug.cgi?id=213262
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/common/net/bugzilla/attachment.py:
- Scripts/webkitpy/tool/bot/patchanalysistask.py:
(PatchAnalysisTaskDelegate.command_passed): Deleted.
(PatchAnalysisTaskDelegate.command_failed): Deleted.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(AbstractEarlyWarningSystem.command_passed): Deleted.
(AbstractEarlyWarningSystem.command_failed): Deleted.
- Scripts/webkitpy/tool/commands/perfalizer.py:
(PerfalizerTask.command_passed): Deleted.
(PerfalizerTask.command_failed): Deleted.
- Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractPatchQueue._next_patch): Deleted.
(AbstractPatchQueue._did_error): Deleted.
(AbstractPatchQueue._did_skip): Deleted.
(AbstractPatchQueue._unlock_patch): Deleted.
(StyleQueue.command_passed): Deleted.
(StyleQueue.command_failed): Deleted.
- 2:34 AM Changeset in webkit [263142] by
-
- 2 edits in trunk/Tools
Add new Igalia EWS workers for ARM/MIPS
https://bugs.webkit.org/show_bug.cgi?id=212803
Reviewed by Aakash Jain.
- BuildSlaveSupport/ews-build/config.json:
- 1:55 AM Changeset in webkit [263141] by
-
- 9 edits in trunk
Make ReadableStream robust against user code
https://bugs.webkit.org/show_bug.cgi?id=212915
<rdar://problem/64133221>
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
We now get pull/cancel only once from the source.
- web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt:
- web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt:
- web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
Source/WebCore:
Create tee source with private slots instead of public ones.
When source has one of this private slot, we directly go to the creation of a ReadableStream.
Covered by existing tests.
- Modules/streams/ReadableStream.js:
(initializeReadableStream):
- Modules/streams/ReadableStreamInternals.js:
(setupReadableStreamDefaultController):
(readableStreamTee):
(readableStreamDefaultControllerCallPullIfNeeded):
(readableStreamDefaultControllerCancel):
- Modules/streams/StreamInternals.js:
(promiseInvokeOrNoopMethodNoCatch):
(promiseInvokeOrNoopNoCatch):
(promiseInvokeOrNoopMethod):
(promiseInvokeOrNoop):
- bindings/js/WebCoreBuiltinNames.h:
- 1:52 AM Changeset in webkit [263140] by
-
- 6 edits in trunk/Source/WebCore
Fix spelling of evaluteDynamicMediaQueryRules
https://bugs.webkit.org/show_bug.cgi?id=213287
Unreviewed.
- style/RuleSet.cpp:
(WebCore::Style::RuleSet::addRulesFromSheet):
(WebCore::Style::RuleSet::evaluateDynamicMediaQueryRules):
(WebCore::Style::RuleSet::evaluteDynamicMediaQueryRules): Deleted.
- style/RuleSet.h:
- style/StyleResolver.cpp:
(WebCore::Style::Resolver::evaluateDynamicMediaQueries):
- style/StyleScopeRuleSets.cpp:
(WebCore::Style::ScopeRuleSets::evaluateDynamicMediaQueryRules):
(WebCore::Style::ScopeRuleSets::evaluteDynamicMediaQueryRules): Deleted.
- style/StyleScopeRuleSets.h:
- 1:17 AM Changeset in webkit [263139] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r262994): [GTK] More than 100 tests are failing
https://bugs.webkit.org/show_bug.cgi?id=213173
Unreviewed gardening.
Add default initialization for WebCore::PluginInfo::clientLoadPolicy and
WebCore::PluginInfo::isApplicationPlugin.
- plugins/PluginData.h:
- 12:29 AM Changeset in webkit [263138] by
-
- 2 edits in trunk
REGRESSION(r260760): ENABLE_GRAPHICS_CONTEXT_GL should be ON, not TRUE
https://bugs.webkit.org/show_bug.cgi?id=212057
Patch by Michael Catanzaro <Michael Catanzaro> on 2020-06-17
Reviewed by Carlos Garcia Campos.
This is already set by feature policy. Don't clobber it.
- Source/cmake/OptionsGTK.cmake:
