Timeline
Sep 21, 2020:
- 11:58 PM Changeset in webkit [267400] by
-
- 2 edits in trunk/Source/WebKit
Enable MediaRecorder by default on iOS
https://bugs.webkit.org/show_bug.cgi?id=216664
Reviewed by Darin Adler.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultMediaRecorderEnabled):
- 11:52 PM Changeset in webkit [267399] by
-
- 7 edits in trunk
[CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
https://bugs.webkit.org/show_bug.cgi?id=216773
Reviewed by Don Olmstead.
.:
- Source/cmake/FindATKBridge.cmake: Rewrite to define an ATK::Bridge imported target.
- Source/cmake/OptionsWPE.cmake: Use the ATK::Bridge imported target.
Source/WebKit:
No new tests needed.
- PlatformWPE.cmake: Use the ATK::Bridge imported target.
Tools:
- wpe/backends/CMakeLists.txt: Use the ATK::Bridge imported target.
- 11:08 PM Changeset in webkit [267398] by
-
- 10 edits in trunk/Source
[GTK] Bump cairo version to support HiDPI
https://bugs.webkit.org/show_bug.cgi?id=133378
Reviewed by Carlos Garcia Campos.
Remove conditional compilation around cairo_{g,s}et_device_scale() as there is no need to
support older versions of Cairo which lack the functions. The minimum version of Cairo
being required by CMake is 1.14.0, which already includes them.
Source/WebCore:
No new tests needed.
- platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp:
(WebCore::createCairoImageSurfaceWithFastMalloc): Use cairo_surface_set_device_scale()
directly.
(WebCore::BackingStoreBackendCairoImpl::scroll): Use cairo_surface_get_device_scale()
directly.
- platform/graphics/cairo/BackingStoreBackendCairoX11.cpp:
(WebCore::BackingStoreBackendCairoX11::BackingStoreBackendCairoX11): Use
cairo_surface_set_device_scale() directly.
(WebCore::BackingStoreBackendCairoX11::scroll): Use cairo_surface_get_device_scale()
directly.
- platform/graphics/cairo/CairoUtilities.cpp: Remove helper functions
cairoSurfaceSetDeviceScale() and cairoSurfaceGetDeviceScale().
- platform/graphics/cairo/CairoUtilities.h: Ditto.
Source/WebKit:
- Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::paint): use cairo_surface_set_device_scale() directly.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseTakeViewSnapshot): Ditto.
- UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::displayBuffer): Ditto.
(WebKit::AcceleratedBackingStoreWayland::downloadTexture): Ditto.
- UIProcess/gtk/AcceleratedBackingStoreX11.cpp:
(WebKit::AcceleratedBackingStoreX11::update): Ditto.
- 10:07 PM Changeset in webkit [267397] by
-
- 3 edits in trunk/Source/WebKitLegacy/mac
Remove deprecated script and stylesheet injection SPI, replaced with more inclusively-named SPI
https://bugs.webkit.org/show_bug.cgi?id=214936
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-21
Reviewed by Youenn Fablet.
rdar://64376341 tracks the adoption of the replacement. Once that is done, we can remove the old SPI.
- WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]): Deleted.
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]): Deleted.
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]): Deleted.
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]): Deleted.
- WebView/WebViewPrivate.h:
- 10:03 PM Changeset in webkit [267396] by
-
- 3 edits1 delete in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Update baselines after r267389.
- platform/glib/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt: Update after r267357.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt: Removed.
- 9:56 PM Changeset in webkit [267395] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix MIPS leai,leap when offset is nonzero
https://bugs.webkit.org/show_bug.cgi?id=216772
Reviewed by Mark Lam.
Fix required by change from webkit#216685
- offlineasm/mips.rb:
- 9:44 PM Changeset in webkit [267394] by
-
- 5 edits in trunk/Source
paper.io ad close buttons cannot be iteracted with via trackpad on iPad
https://bugs.webkit.org/show_bug.cgi?id=216812
<rdar://problem/68738585>
Reviewed by Wenson Hsieh.
Source/WebCore:
- platform/RuntimeApplicationChecks.h:
- platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isPaperIO):
Source/WebKit:
- UIProcess/ios/WKContentViewInteraction.mm:
(applicationIsKnownToIgnoreMouseEvents):
- 8:51 PM Changeset in webkit [267393] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266058. rdar://problem/69343370
[ macOS wk1 Debug ] inspector/animation/nameChanged.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=215767
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:50 PM Changeset in webkit [267392] by
-
- 3 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266041. rdar://problem/69341725
Make fast/text/letter-spacing-shaping.html more robust
https://bugs.webkit.org/show_bug.cgi?id=215711
Unreviewed test gardening.
- fast/text/letter-spacing-shaping-expected.html:
- fast/text/letter-spacing-shaping.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:48 PM Changeset in webkit [267391] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266494. rdar://problem/69341549
Rebaseline after macOS build progression.
Rebaseline fast/block/margin-collapse/103 for Mojave
Unreviewed test gardening.
- platform/mac-mojave/fast/block/margin-collapse/103-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266494 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:48 PM Changeset in webkit [267390] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266490. rdar://problem/69341549
Rebaseline after macOS build progression.
Rebaseline fast/block/margin-collapse/103 for Catalina
Unreviewed test gardening.
- platform/mac-catalina/fast/block/margin-collapse/103-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 8:48 PM Changeset in webkit [267389] by
-
- 2 edits in trunk/LayoutTests
[GLIB] fast/mediastream/getUserMedia-webaudio.html is failing since 267383
Unreviewed test gardening.
- platform/glib/TestExpectations:
- 6:30 PM Changeset in webkit [267388] by
-
- 4 edits in trunk
Value returned by AudioParamTimeline::valuesForTimeRange() is sometimes incorrect for exponential ramps
https://bugs.webkit.org/show_bug.cgi?id=216811
Reviewed by Darin Adler.
Source/WebCore:
AudioParamTimeline::valuesForTimeRangeImpl() always need to return the *last* value since this is
what will be used to update AudioParam::m_value to its latest value. We had a bug in our exponential
ramp processing causing value to be multiplied one extra time.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
LayoutTests:
Rebaseline test that is now passing.
- webaudio/AudioParam/audioparam-update-value-attribute-expected.txt:
- 5:37 PM Changeset in webkit [267387] by
-
- 3 edits in trunk/Source/WebKit
Add some WKWebProcessPlugInFrame SPI needed by Safari.
https://bugs.webkit.org/show_bug.cgi?id=216809
rdar://problem/69336928
Reviewed by Brian Weinstein.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:
(+[WKWebProcessPlugInFrame lookUpFrameFromJSContext:]): Added.
(-[WKWebProcessPlugInFrame _securityOrigin]): Added.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
- 5:17 PM Changeset in webkit [267386] by
-
- 5 edits in trunk
AudioBufferSourceNode should update grain parameters when buffer is set after rendering has started
https://bugs.webkit.org/show_bug.cgi?id=216808
Reviewed by Eric Carlson.
Source/WebCore:
AudioBufferSourceNode should update grain parameters when buffer is set after rendering has
started. The grain parameters need to be adjusted so that they make sense given the buffer
length. Previously, we would only update grain parameters in AudioBufferSourceNode::startPlaying(),
when a buffer is set. We would fail to update those grain parameters when the buffer is set,
in setBuffer(), if startPlaying() has already been called.
No new tests, rebaselined existing test.
- Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::setBuffer):
(WebCore::AudioBufferSourceNode::startLater):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::updateGrainParameters):
- Modules/webaudio/AudioBufferSourceNode.h:
LayoutTests:
Rebaseline test that is now passing.
- webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration-expected.txt:
- 4:49 PM Changeset in webkit [267385] by
-
- 3 edits in trunk/Source/WebKit
Make accessibility isolated tree a non-experimental feature.
https://bugs.webkit.org/show_bug.cgi?id=216792
Reviewed by Chris Fleizach.
Promote accessibility isolated tree from an experimental feature to a
non-experimental one. This avoids the problem where a user can turn off
the feature through the Safari > Develop > Experimental Features submenu,
while the accessibility request are still coming on a secondary thread,
which leads to random crashes.
- Shared/WebPreferences.yaml:
- Shared/WebPreferencesExperimental.yaml:
- 4:42 PM Changeset in webkit [267384] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, unskip webaudio/Analyser/handle-silent-inputs.html.
This test should no longer be flaky now that it is passing.
- 4:27 PM Changeset in webkit [267383] by
-
- 14 edits2 deletes in trunk
Values returned by FFTFrame::doFFT() are twice as large as they should be
https://bugs.webkit.org/show_bug.cgi?id=216781
Reviewed by Darin Adler.
Source/WebCore:
To provide the best possible execution speeds, the vDSP library's functions don't always adhere strictly
to textbook formulas for Fourier transforms, and must be scaled accordingly [1].
In the case of a Real forward Transform like in FFTFrame::doFFT(): RFimp = RFmath * 2 so we need to
divide the output by 2 to get the correct value. We were failing to do this scaling and this was causing
AnalyserNode tests to fail.
[1] See https://developer.apple.com/library/archive/documentation/Performance/Conceptual/vDSP_Programming_Guide/UsingFourierTransforms/UsingFourierTransforms.html#//apple_ref/doc/uid/TP40005147-CH3-SW5
No new tests, rebaselined existing tests.
- Modules/webaudio/PeriodicWave.cpp:
(WebCore::PeriodicWave::createBandLimitedTables):
Update normalization factor now that FFTFrame::doInverseFFT() has been fixed. The new normalization factor
matches the value used by blink at:
- platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::multiply):
We were applying a 0.5 scaling factor to the output of vDSP_zvmul(). However, the documentation for vDSP_zvmul()
does not indicate that its output is twice as large as expected. Odds are that this was done because we used
to have a bug in FFTFrame::doFFT() that was returning values twice as large as expected. SInce this function
relies on VectorMath, there is no need for its implementation to be platform-specific.
- platform/audio/FFTFrameStub.cpp:
- platform/audio/gstreamer/FFTFrameGStreamer.cpp:
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
Drop 2 factor in the GStreamer implementation that was added to try and be consistent with the incorrect Mac
implementation.
- platform/audio/mac/FFTFrameMac.cpp:
(WebCore::FFTFrame::doFFT):
Fix issue where the values returned by doFFT() were twice as large as expected due to the odd behavior of
vDSP_fft_zrip().
(WebCore::FFTFrame::doInverseFFT):
Drop 2 factor in doInverseFFT that was added because the output of doFFT() was twice as large as expected
and we wanted x == InverseFFT(FFT(x)).
LayoutTests:
- webaudio/Analyser/realtimeanalyser-downmix-expected.txt:
- webaudio/Analyser/realtimeanalyser-freq-data-expected.txt:
- webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt:
- webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt:
Rebaseline tests that are passing now that the bug has been fixed.
- webaudio/realtimeanalyser-fft-scaling-expected.txt: Removed.
- webaudio/realtimeanalyser-fft-scaling.html: Removed.
Drop outdated test. This test was imported into WPT and now resides at:
- imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/realtimeanalyser-fft-scaling.html
- 4:25 PM Changeset in webkit [267382] by
-
- 2 edits in trunk/Source/WebCore
[GPU Process] Several tests in canvas/philip/tests are failing with text diffs
https://bugs.webkit.org/show_bug.cgi?id=216800
Reviewed by Darin Adler.
When using the GPU process to render canvas elements, we currently fail the 7 tests in
canvas/philip/tests
below, due to gradient and pattern fill/stroke styles lingering on the 2D graphics context state after a fill or
stroke color is set, respectively.
This happens when:
- The fill color is set to a color
C. - A fill pattern or gradient is applied.
- The fill color is set to the color
Cagain.
In this case, after step (2), we propagate a graphics context state change indicating that the fill pattern has
changed, but we leave the fill color unchanged (i.e., it remains equal toC). In step (3), we then set the
fill color toCagain, which doesn't propagate a state change to the GPU process, since the fill color is the
same (C). As such, the state in the GPU process keeps its fill gradient, and we end up filling with this old
gradient instead of the fill colorC.
To fix this, we simply revert
fillColorandstrokeColorto the invalid color when setting a gradient or
pattern in the same way that we currently clear out the fill/stroke gradient and pattern when setting a fill/
stroke color, which ensures that a state change will be sent to the GPU process during step (3).
Fixes the following canvas-related layout tests when using the GPU process:
- canvas/philip/tests/2d.gradient.radial.cone.shape2.html
- canvas/philip/tests/2d.pattern.basic.nocontext.html
- canvas/philip/tests/2d.pattern.paint.norepeat.coord3.html
- canvas/philip/tests/2d.pattern.paint.repeatx.coord1.html
- canvas/philip/tests/2d.pattern.paint.repeatx.outside.html
- canvas/philip/tests/2d.pattern.paint.repeaty.coord1.html
- canvas/philip/tests/2d.pattern.paint.repeaty.outside.html
The entire canvas/ directory is currently skipped when enabling the GPU process for canvas rendering, but once
we're down to a smaller number of failures, I intend to unskip these directories for GPU process, and
individually track any remaining test failures.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::setStrokePattern):
(WebCore::GraphicsContext::setFillPattern):
(WebCore::GraphicsContext::setStrokeGradient):
(WebCore::GraphicsContext::setFillGradient):
- 4:14 PM Changeset in webkit [267381] by
-
- 5 edits in trunk
Properly handle AudioParam.setTargetAtTime() followed by a ramp
https://bugs.webkit.org/show_bug.cgi?id=216804
Reviewed by Darin Adler.
Source/WebCore:
Properly handle AudioParam.setTargetAtTime() followed by a ramp:
- https://www.w3.org/TR/webaudio/#dom-audioparam-settargetattime
- https://www.w3.org/TR/webaudio/#dom-audioparam-linearramptovalueattime
- https://www.w3.org/TR/webaudio/#dom-audioparam-exponentialramptovalueattime
This is a merge of the following Blink change:
No new tests, rebaselined existing test.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::processSetTargetFollowedByRamp):
- Modules/webaudio/AudioParamTimeline.h:
LayoutTests:
Rebaseline test that is now passing.
- webaudio/AudioParam/audioparam-setTargetAtTime-continuous-expected.txt:
- 4:10 PM Changeset in webkit [267380] by
-
- 4 edits in trunk/Tools
[webkitpy] Use webkitcorepy's auto installer for pytest packages
https://bugs.webkit.org/show_bug.cgi?id=215895
<rdar://problem/67885471>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/init.py: Add pytest and it's dependencies.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module): Remove pytest and pytest_timeout.
(AutoinstallImportHook._install_pytest_timeout): Deleted.
(AutoinstallImportHook._install_pytest): Deleted.
- Scripts/webkitpy/webdriver_tests/pytest_runner.py: Implicitly use webkitcorepy's autoinstaller.
- 4:09 PM Changeset in webkit [267379] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Uncaught Exception: Missing node for given nodeId
https://bugs.webkit.org/show_bug.cgi?id=216067
<rdar://problem/68520144>
Reviewed by Devin Rousso.
- UserInterface/Views/ContentBrowserTabContentView.js:
(WI.ContentBrowserTabContentView.prototype.showDetailsSidebarPanels):
RewriteshowDetailsSidebarPanelsin such way that causes no more than one change of selectedSidebarPanel.
Previously,removeSidebarPanelwould cause the change of selectedSidebarPanel, resulting in showing
a panel with outdatedthis.domNode.
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
Display a useful error with a relevant location instead of a generic Connection.js error.
- UserInterface/Views/Sidebar.js:
(WI.Sidebar.prototype.removeSidebarPanel):
After removing a panel, don't select the nearest panel. There doesn't seem to be a useful case for it.
The selected panel is determined at the removeSidebarPanel callsites.
- 3:59 PM Changeset in webkit [267378] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
REGRESSION (r264117): [ Mac iOS ] imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/blob.https.html
https://bugs.webkit.org/show_bug.cgi?id=214155
Unreviewed test gardening.
- platform/ios/TestExpectations:
- 3:56 PM Changeset in webkit [267377] by
-
- 3 edits in trunk/Source/WebCore
Remove unused NodeFlag::HasCSSAnimation
https://bugs.webkit.org/show_bug.cgi?id=216785
Reviewed by Antti Koivisto.
- dom/Element.h:
(WebCore::Element::hasCSSAnimation const): Deleted.
(WebCore::Element::setHasCSSAnimation): Deleted.
(WebCore::Element::clearHasCSSAnimation): Deleted.
- dom/Node.h:
- 3:50 PM Changeset in webkit [267376] by
-
- 9 edits in trunk
Throw when AudioConnect::connect() is called for an output that has no channels
https://bugs.webkit.org/show_bug.cgi?id=216802
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline existing tests because I improved exception messages.
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-connect-method-chaining-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-expected.txt:
Source/WebCore:
Throw when AudioConnect::connect() is called for an output that has no channels, for consistency
with Blink. The ScriptProcessorNode cannot have an output node that has zero channels.
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::connect):
LayoutTests:
- webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-expected.txt:
- webaudio/dom-exceptions-expected.txt:
Rebaseline existing tests because I improved exception messages.
- webaudio/ScriptProcessor/scriptprocessornode-0-output-channels-expected.txt:
Rebaseline test that is now passing.
- 3:29 PM Changeset in webkit [267375] by
-
- 1 copy in tags/Safari-610.2.7
Tag Safari-610.2.7.
- 3:21 PM Changeset in webkit [267374] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[iOS] Update fast/text/opticalFontWithTextStyle.html for iOS 14
https://bugs.webkit.org/show_bug.cgi?id=215667
Unreviewed test gardening.
- platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt:
- 3:10 PM Changeset in webkit [267373] by
-
- 18 edits3 adds in trunk
[JSC] BigInt should work with Map / Set
https://bugs.webkit.org/show_bug.cgi?id=216667
JSTests:
<rdar://problem/69107221>
Reviewed by Robin Morisset.
- stress/bigint-and-map-set.js: Added.
(shouldBe):
(opaque1n):
(testMap):
(let.set new):
- stress/bigint-string-map-set.js: Added.
(shouldBe):
(testMap):
- stress/bigint32-map-set.js: Added.
(shouldBe):
(testMap):
Source/JavaScriptCore:
Reviewed by Robin Morisset.
This patch makes BigInt supported in Map / Set.
- In NormalizeMapKey, we always attempt to convert HeapBigInt to BigInt32 (if supported). So we ensure that,
normalized BigInt has one unique form for BigInt32 range. This allows us to use hashing for BigInt32 bit pattern directly.
- In MapHash, for BigInt32, we directly has the JSValue bits. For HeapBigInt, we calculate hash via Hasher.
- In GetMapBucket, we consider HeapBigInt case correctly.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupNormalizeMapKey):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileNormalizeMapKey):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMapHash):
(JSC::FTL::DFG::LowerDFGToB3::compileNormalizeMapKey):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMapBucket):
- runtime/HashMapImpl.h:
(JSC::normalizeMapKey):
(JSC::jsMapHash):
(JSC::concurrentJSMapHash):
- runtime/JSBigInt.cpp:
(JSC::JSBigInt::concurrentHash):
- runtime/JSBigInt.h:
(JSC::tryConvertToBigInt32):
Source/WebCore:
<rdar://problem/69107221>
Reviewed by Robin Morisset.
Strongly ensure that BigInt32 is always selected since Map / Set could use it as a key.
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readBigInt):
Source/WTF:
Reviewed by Robin Morisset.
- wtf/Hasher.h:
(WTF::Hasher::hash const):
(WTF::add):
- 3:03 PM Changeset in webkit [267372] by
-
- 2 edits in trunk/Source/WebCore
Tapping to zoom in and out causes video to become very small on some iPhone models
https://bugs.webkit.org/show_bug.cgi?id=216635
Reviewed by Jer Noble.
- platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer resolveBounds]): On some iPhone models, AVKit does not
change "bounds" of WebAVPlayerLayer after changing its video gravity. Therefore,
in this function, "modelVideoLayerFrame" and "bounds" might be the same. But we
still need to update the video layer frame in the Web process.
(-[WebAVPlayerLayer setVideoGravity:]): On some iPhone models, AVKit does
not call -[WebAVPlayerLayer:layoutSublayers] immediately after changing
the video gravity. Forcing a layout can fix that.
- 3:01 PM Changeset in webkit [267371] by
-
- 21 edits in trunk/Source
Move some LLInt globals into JSC::Config.
https://bugs.webkit.org/show_bug.cgi?id=216685
rdar://68964544
Reviewed by Keith Miller.
Source/bmalloc:
Introduce ConfigAlignment to match WTFConfig.h.
Added BENABLE(UNIFIED_AND_FREEZABLE_CONFIG_RECORD) support to match WTF.
- bmalloc/BPlatform.h:
- bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
- bmalloc/GigacageConfig.h:
- bmalloc/mbmalloc.cpp:
Source/JavaScriptCore:
- Moved the following into g_jscConfig:
Data::s_exceptionInstructions ==> g_jscConfig.llint.exceptionInstructions
Data::s_wasmExceptionInstructions ==> g_jscConfig.llint.wasmExceptionInstructions
g_opcodeMap ==> g_jscConfig.llint.opcodeMap
g_opcodeMapWide16 ==> g_jscConfig.llint.opcodeMapWide16
g_opcodeMapWide32 ==> g_jscConfig.llint.opcodeMapWide32
- Fixed cloop.rb so that it can take an offset for the leap offlineasm instruction.
- Fixed x86.rb so that it can take an offset for the leap offlineasm instruction.
- Fixed arm.rb so that it can take an offset for the leap offlineasm instruction.
Note: arm64.rb already does this right.
- Added JSC::Config::singleton() to return a reference to g_jscConfig. This is useful when debugging with lldb since g_jscConfig is not an actual label, but is a macro that computes the address of the Config record.
This patch has been smoke tested on arm64e, x86_64, and cloop (on x86_64 and armv7k).
- llint/LLIntData.cpp:
(JSC::LLInt::LLIntInitializeAssertScope::LLIntInitializeAssertScope):
(JSC::LLInt::LLIntInitializeAssertScope::~LLIntInitializeAssertScope):
(JSC::LLInt::LLIntInitializeAssertScope::assertInitializationIsAllowed):
(JSC::LLInt::initialize):
- llint/LLIntData.h:
(JSC::LLInt::exceptionInstructions):
(JSC::LLInt::wasmExceptionInstructions):
(JSC::LLInt::opcodeMap):
(JSC::LLInt::opcodeMapWide16):
(JSC::LLInt::opcodeMapWide32):
(JSC::LLInt::getOpcode):
(JSC::LLInt::getOpcodeWide16):
(JSC::LLInt::getOpcodeWide32):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter.cpp:
- llint/LowLevelInterpreter64.asm:
- llint/WebAssembly.asm:
- offlineasm/arm.rb:
- offlineasm/cloop.rb:
- offlineasm/x86.rb:
- runtime/JSCConfig.cpp:
(JSC::Config::singleton):
- runtime/JSCConfig.h:
Source/WTF:
- Introduce ConfigAlignment as a distinct value from ConfigSizeToProtect. This is because ConfigSizeToProtect is now larger than 1 CeilingOnPageSize on some platforms, but ConfigAlignment only needs to match CeilingOnPageSize.
- Introduced ENABLE(UNIFIED_AND_FREEZABLE_CONFIG_RECORD) to disable using the unified g_config record for Windows ports.
This is needed because WTF is built as a DLL on Windows. offlineasm does not
know how to resolve a DLL exported variable. Additionally, the Windows ports
have never supported freezing of the Config record to begin with. So, we're
working around this by disabling ENABLE(UNIFIED_AND_FREEZABLE_CONFIG_RECORD)
for Windows. This allows JSC to have its own g_jscConfig record, which solves
this issue for now.
- wtf/PlatformEnable.h:
- wtf/WTFConfig.cpp:
(WTF::Config::permanentlyFreeze):
- wtf/WTFConfig.h:
- 2:45 PM Changeset in webkit [267370] by
-
- 14 edits in trunk/Source
[WinCairo][PlayStation] Support different instances of listener client.
https://bugs.webkit.org/show_bug.cgi?id=216733
Reviewed by Don Olmstead.
Source/JavaScriptCore:
Currently RemoteInspectorSocketEndpoint support one client instance for all
listeners. This patch allows listeners to create its own listener client on
accept timing.
- inspector/remote/RemoteControllableTarget.h:
- inspector/remote/RemoteInspector.h:
- inspector/remote/socket/RemoteInspectorConnectionClient.cpp:
(Inspector::RemoteInspectorConnectionClient::didReceive):
- inspector/remote/socket/RemoteInspectorConnectionClient.h:
- inspector/remote/socket/RemoteInspectorServer.cpp:
(Inspector::RemoteInspectorServer::start):
(Inspector::RemoteInspectorServer::doAccept):
- inspector/remote/socket/RemoteInspectorServer.h:
- inspector/remote/socket/RemoteInspectorSocket.cpp:
(Inspector::RemoteInspector::didClose):
- inspector/remote/socket/RemoteInspectorSocket.h:
- inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
(Inspector::RemoteInspectorSocketEndpoint::RemoteInspectorSocketEndpoint):
(Inspector::RemoteInspectorSocketEndpoint::~RemoteInspectorSocketEndpoint):
(Inspector::RemoteInspectorSocketEndpoint::listenInet):
(Inspector::RemoteInspectorSocketEndpoint::workerThread):
(Inspector::RemoteInspectorSocketEndpoint::generateConnectionID):
(Inspector::RemoteInspectorSocketEndpoint::createClient):
(Inspector::RemoteInspectorSocketEndpoint::disconnect):
(Inspector::RemoteInspectorSocketEndpoint::createListener):
(Inspector::RemoteInspectorSocketEndpoint::invalidateClient):
(Inspector::RemoteInspectorSocketEndpoint::invalidateListener):
(Inspector::RemoteInspectorSocketEndpoint::getPort const):
(Inspector::RemoteInspectorSocketEndpoint::recvIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::sendIfEnabled):
(Inspector::RemoteInspectorSocketEndpoint::send):
(Inspector::RemoteInspectorSocketEndpoint::acceptInetSocketIfEnabled):
- inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
Source/WebKit:
Follows the change of RemoteInspectorSocketEndpoint::Client interface change.
No new tests because there's no behaivior change.
- UIProcess/Inspector/socket/RemoteInspectorClient.cpp:
(WebKit::RemoteInspectorClient::didClose):
- UIProcess/Inspector/socket/RemoteInspectorClient.h:
- 2:32 PM Changeset in webkit [267369] by
-
- 13 edits in trunk
[WebAuthn] Don't set the UV option if the authenticator doesn't support it
https://bugs.webkit.org/show_bug.cgi?id=215836
<rdar://problem/67817359>
Reviewed by Darin Adler.
Source/WebCore:
Covered by new API tests.
UV in the the CTAP 2.0 spec only means internal UV:
https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#authenticatorGetInfo
If an authenticator supports ClientPin, it can set the uv bit in the responses to true but it
will not advertise itself supporting internal UV, which is the uv in the options.
https://fidoalliance.org/specs/fido-v2.0-ps-20190130/fido-client-to-authenticator-protocol-v2.0-ps-20190130.html#authenticatorMakeCredential
Hence, setting it to true could result in error if the authenticator doesn't support internal UV even if it supports ClientPin.
It's not a way to ask the authenticator to set the uv bit in the response.
- Modules/webauthn/fido/DeviceRequestConverter.cpp:
(fido::encodeMakeCredenitalRequestAsCBOR):
(fido::encodeGetAssertionRequestAsCBOR):
Tools:
- TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
(TestWebKitAPI::TEST):
LayoutTests:
- http/wpt/webauthn/public-key-credential-create-failure-hid-silent.https.html:
- http/wpt/webauthn/public-key-credential-create-failure-hid.https.html:
- http/wpt/webauthn/public-key-credential-get-failure-hid-silent.https.html:
- http/wpt/webauthn/public-key-credential-get-failure-hid.https.html:
- 2:20 PM Changeset in webkit [267368] by
-
- 4 edits in trunk/Tools
[webkitpy] Use webkitcorepy's auto installer for moz* packages
https://bugs.webkit.org/show_bug.cgi?id=215889
<rdar://problem/67877935>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/init.py: Add mozprocess, mozlog and mozterm to AutoInstalled packages.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module): Remove mozlog and mozprocess.
(AutoinstallImportHook._install_mozlog): Deleted.
(AutoinstallImportHook._install_mozprocess): Deleted.
- Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py: Implicitly use webkitcorepy's auto-installer.
- 2:17 PM Changeset in webkit [267367] by
-
- 6 edits in trunk
AudioParam.exponentialRampToValueAtTime() does not properly deal with negative values
https://bugs.webkit.org/show_bug.cgi?id=216790
Reviewed by Eric Carlson.
Source/WebCore:
AudioParam.exponentialRampToValueAtTime() does not properly deal with negative values.
The specification [1] says:
"If V0 and V1 have opposite signs or if V0 is zero, then v(t) = V0 for T0 <= t < T1."
Our implementation did not match the specification and would just special-case if either
V0 or V1 was negative.
[1] https://www.w3.org/TR/webaudio/#dom-audioparam-exponentialramptovalueattime
No new tests, rebaselined existing test.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
LayoutTests:
Rebaseline test that is now passing.
- webaudio/AudioParam/audioparam-negative-exponentialRamp-expected.txt:
- 1:57 PM Changeset in webkit [267366] by
-
- 7 edits2 adds in trunk
[iOS] MediaRecorder incorrect screen orientation handling
https://bugs.webkit.org/show_bug.cgi?id=198912
<rdar://problem/51802521>
Reviewed by Eric Carlson.
Source/WebCore:
Update MediaRecorderPrivateWriterCocoa to pass a MediaSample down to handle rotation.
Set AVAssetWriterInput transform according the first MediaSample rotation value.
Test: http/wpt/mediarecorder/video-rotation.html
- platform/mediarecorder/MediaRecorderPrivateAVFImpl.cpp:
(WebCore::MediaRecorderPrivateAVFImpl::videoSampleAvailable):
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.h:
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
Source/WebKit:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
(WebKit::RemoteMediaRecorder::videoSampleAvailable):
LayoutTests:
- http/wpt/mediarecorder/video-rotation-expected.txt: Added.
- http/wpt/mediarecorder/video-rotation.html: Added.
- 1:55 PM Changeset in webkit [267365] by
-
- 2 edits in trunk/Tools
[webkitpy] Use webkitcorepy's auto installer for six
https://bugs.webkit.org/show_bug.cgi?id=215770
<rdar://problem/67683133>
Rubber-stamped by Aakash Jain.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook._install_mechanize): Remove six.
(AutoinstallImportHook._install_pytest): Ditto.
(AutoinstallImportHook._install_six): Deleted.
- 1:41 PM Changeset in webkit [267364] by
-
- 56 edits in trunk/Source
Functions should consistently enumerate length before name
https://bugs.webkit.org/show_bug.cgi?id=216789
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
In https://github.com/tc39/ecma262/pull/2116, which has been
approved to be merged into the main JS spec, it's expected that
all functions should have their length property enumerated before
the name property. To ensure this invariant, this patch moves the
length set into InternalFunction::finishCreation.
There are no new tests since tests will be added to test262 when
the spec PR is merged. Adding tests to stress just means we will
have the same test twice, which seems like a waste.
- API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::finishCreation):
- API/ObjCCallbackFunction.mm:
(JSC::ObjCCallbackFunction::create):
- API/glib/JSCCallbackFunction.cpp:
(JSC::JSCCallbackFunction::create):
- runtime/AggregateErrorConstructor.cpp:
(JSC::AggregateErrorConstructor::finishCreation):
- runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::finishCreation):
- runtime/AsyncFunctionConstructor.cpp:
(JSC::AsyncFunctionConstructor::finishCreation):
- runtime/AsyncGeneratorFunctionConstructor.cpp:
(JSC::AsyncGeneratorFunctionConstructor::finishCreation):
- runtime/BigIntConstructor.cpp:
(JSC::BigIntConstructor::finishCreation):
- runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::finishCreation):
- runtime/DateConstructor.cpp:
(JSC::DateConstructor::finishCreation):
- runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::finishCreation):
- runtime/FinalizationRegistryConstructor.cpp:
(JSC::FinalizationRegistryConstructor::finishCreation):
- runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::finishCreation):
- runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::finishCreation):
- runtime/GeneratorFunctionConstructor.cpp:
(JSC::GeneratorFunctionConstructor::finishCreation):
- runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::createFunctionThatMasqueradesAsUndefined):
- runtime/InternalFunction.h:
- runtime/IntlCollatorConstructor.cpp:
(JSC::IntlCollatorConstructor::finishCreation):
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::IntlDateTimeFormatConstructor::finishCreation):
- runtime/IntlDisplayNamesConstructor.cpp:
(JSC::IntlDisplayNamesConstructor::finishCreation):
- runtime/IntlLocaleConstructor.cpp:
(JSC::IntlLocaleConstructor::finishCreation):
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::IntlNumberFormatConstructor::finishCreation):
- runtime/IntlPluralRulesConstructor.cpp:
(JSC::IntlPluralRulesConstructor::finishCreation):
- runtime/IntlRelativeTimeFormatConstructor.cpp:
(JSC::IntlRelativeTimeFormatConstructor::finishCreation):
- runtime/IntlSegmenterConstructor.cpp:
(JSC::IntlSegmenterConstructor::finishCreation):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::JSGenericArrayBufferConstructor<sharingMode>::finishCreation):
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
- runtime/JSTypedArrayViewConstructor.cpp:
(JSC::JSTypedArrayViewConstructor::finishCreation):
- runtime/MapConstructor.cpp:
(JSC::MapConstructor::finishCreation):
- runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructorBase::finishCreation):
- runtime/NullGetterFunction.h:
- runtime/NullSetterFunction.h:
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation):
- runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::finishCreation):
- runtime/ProxyConstructor.cpp:
(JSC::ProxyConstructor::finishCreation):
- runtime/ProxyRevoke.cpp:
(JSC::ProxyRevoke::finishCreation):
- runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::finishCreation):
- runtime/SetConstructor.cpp:
(JSC::SetConstructor::finishCreation):
- runtime/StringConstructor.cpp:
(JSC::StringConstructor::finishCreation):
- runtime/SymbolConstructor.cpp:
(JSC::SymbolConstructor::finishCreation):
- runtime/WeakMapConstructor.cpp:
(JSC::WeakMapConstructor::finishCreation):
- runtime/WeakObjectRefConstructor.cpp:
(JSC::WeakObjectRefConstructor::finishCreation):
- runtime/WeakSetConstructor.cpp:
(JSC::WeakSetConstructor::finishCreation):
- wasm/js/WebAssemblyCompileErrorConstructor.cpp:
(JSC::WebAssemblyCompileErrorConstructor::finishCreation):
- wasm/js/WebAssemblyGlobalConstructor.cpp:
(JSC::WebAssemblyGlobalConstructor::finishCreation):
- wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::WebAssemblyInstanceConstructor::finishCreation):
- wasm/js/WebAssemblyLinkErrorConstructor.cpp:
(JSC::WebAssemblyLinkErrorConstructor::finishCreation):
- wasm/js/WebAssemblyMemoryConstructor.cpp:
(JSC::WebAssemblyMemoryConstructor::finishCreation):
- wasm/js/WebAssemblyModuleConstructor.cpp:
(JSC::WebAssemblyModuleConstructor::finishCreation):
- wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:
(JSC::WebAssemblyRuntimeErrorConstructor::finishCreation):
- wasm/js/WebAssemblyTableConstructor.cpp:
(JSC::WebAssemblyTableConstructor::finishCreation):
Source/WebCore:
RuntimeMethod inherits from InternalFunction which now sets length by default.
RuntimeMethod intercepts length in getOwnPropertySlot so the value we pick
doesn't actually matter. Technically, this uses a little extra memory but
that's not too big of a deal because RuntimeMethod's are rare (and I believe
deprecated).
- bridge/runtime_method.cpp:
(JSC::RuntimeMethod::finishCreation):
Source/WebKit:
JSNPMethod inherits from InternalFunction which now sets length by default.
I chose 0 because it looks like this function doesn't directly look at any
arguments and I doubt anyone is looking at the length anyway.
- WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::finishCreation):
- 1:28 PM Changeset in webkit [267363] by
-
- 41 edits in trunk/Source
Next step towards eliminating deprecated legacy positions
https://bugs.webkit.org/show_bug.cgi?id=216751
Reviewed by Sam Weinig.
Source/WebCore:
Eliminating our old deprecated legacy editing positions is probably a relatively long
road. This next step starts using the makeContainerOffsetPosition function in more
places, requesting that we not use any of the deprecated legacy position logic. Also
renames createLegacyEditingPosition to makeDeprecatedLegacyPosition. The hard part of
this project will be removing code that is not inside Position that depends on the old
style of position/offset pairs. For this patch, tried to stick to converting cases
where it seems clear we don't depend on the legacy behavior. Flaw in that is that we
might still depend on legacy behavior where it's unconditionally implemented, without
checking the flag on the m_isLegacyEditingPosition Position class; that will be a
problem long term, should not be in this patch.
- dom/Position.h:
(WebCore::createLegacyEditingPosition): Deleted.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::visiblePositionForTextMarkerData):
(WebCore::AXObjectCache::rangeMatchesTextNearRange):
(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):
(WebCore::AXObjectCache::localCaretRectForCharacterOffset):
(WebCore::AXObjectCache::indexForCharacterOffset):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::stringForRange const):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::linkClickPoint):
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper arrayOfTextForTextMarkers:attributed:]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:spellCheck:]):
- dom/Position.cpp:
(WebCore::Position::previous const):
(WebCore::Position::next const):
(WebCore::Position::downstream const):
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::operator Position const):
- dom/Range.cpp:
(WebCore::Range::expand):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAutocorrectionBeforeTypingIfAppropriate):
(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/Editing.cpp:
(WebCore::visiblePositionForIndex):
(WebCore::visiblePositionForIndexUsingCharacterIterator):
(WebCore::isNodeVisiblyContainedWithin):
- editing/Editor.cpp:
(WebCore::Editor::canDeleteRange const):
(WebCore::Editor::selectComposition):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::Editor::markAndReplaceFor):
(WebCore::Editor::firstRectForRange const):
(WebCore::extendSelection):
(WebCore::Editor::adjustedSelectionRange):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::elementRangeContainingCaretSelection const):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApplyForSingleParagraph):
- editing/RenderedPosition.cpp:
(WebCore::RenderedPosition::positionAtLeftBoundaryOfBiDiRun const):
(WebCore::RenderedPosition::positionAtRightBoundaryOfBiDiRun const):
- editing/TextCheckingHelper.cpp:
(WebCore::expandToParagraphBoundary):
(WebCore::TextCheckingParagraph::expandRangeToNextEnd):
(WebCore::TextCheckingHelper::findFirstMisspelledWordOrUngrammaticalPhrase const):
- editing/TextIterator.cpp:
(WebCore::resolveCharacterRange):
- editing/VisiblePosition.cpp:
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate const):
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate const):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::appendTrailingWhitespace):
- editing/VisibleUnits.cpp:
(WebCore::previousRootInlineBoxCandidatePosition):
(WebCore::nextRootInlineBoxCandidatePosition):
(WebCore::previousBoundary):
(WebCore::nextBoundary):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::closestWordBoundaryForPosition):
(WebCore::wordBoundaryForPositionWithoutCrossingLine):
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::HTMLConverter):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAsChildOfElement):
- editing/markup.cpp:
(WebCore::serializePreservingVisualAppearance):
(WebCore::contextPreservesNewline):
(WebCore::createFragmentFromText):
- page/DragController.cpp:
(WebCore::DragController::insertDroppedImagePlaceholdersAtCaret):
- page/Page.cpp:
(WebCore::Page::replaceRangesWithText):
- page/ios/FrameIOS.mm:
(WebCore::Frame::interpretationsForCurrentRoot const):
- platform/DragImage.cpp:
(WebCore::createDragImageForRange):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::positionForBox const):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::createVisiblePosition const):
(WebCore::RenderObject::collectSelectionRectsInternal):
- testing/Internals.cpp:
(WebCore::Internals::setSelectionWithoutValidation):
Replaced calls to createLegacyEditingPosition with calls to
makeDeprecatedLegacyPosition or makeContainerOffsetPosition.
Source/WebKit:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::extendSelection):
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPage::requestAutocorrectionData):
(WebKit::WebPage::applyAutocorrectionInternal):
(WebKit::focusedElementPositionInformation):
(WebKit::dataDetectorLinkPositionInformation):
(WebKit::WebPage::requestDocumentEditingContext):
Replaced calls to createLegacyEditingPosition with calls to
makeDeprecatedLegacyPosition or makeContainerOffsetPosition.
Source/WebKitLegacy/ios:
- WebCoreSupport/WebVisiblePosition.mm:
(-[DOMNode startPosition]):
(-[DOMNode endPosition]):
Replaced calls to createLegacyEditingPosition with calls to
makeDeprecatedLegacyPosition or makeContainerOffsetPosition.
Source/WebKitLegacy/mac:
- DOM/DOMUIKitExtensions.mm:
(-[DOMNode rangeOfContainingParagraph]):
- WebView/WebFrame.mm:
(-[WebFrame spaceFollowsWordInRange:]):
(-[WebFrame caretRectAtNode:offset:affinity:]):
(-[WebFrame focusedNodeHasContent]):
Replaced calls to createLegacyEditingPosition with calls to
makeDeprecatedLegacyPosition or makeContainerOffsetPosition.
- 1:23 PM Changeset in webkit [267362] by
-
- 6 edits in trunk
Selection API: A few more refinements to DOMSelection and VisibleSelection to pass all WPT tests
https://bugs.webkit.org/show_bug.cgi?id=216756
Reviewed by Ryosuke Niwa.
Source/WebCore:
After these changes, we pass all the tests in imported/w3c/web-platform-tests/selection
with no failures except for one due to the rules about absorbing newlines at the start
and end <style> and <script> elements.
However, that's with the live selection range feature enabled, and there are likely issues
with other tests in that mode, so that testing still needs to be done. Then we also have to
decide how we are going to deal with the compatibility risk of changing the behavior to
match the standard.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::VisibleSelection): Updated to rename m_baseIsFirst to
m_anchorIsFirst. Not required for the fix, but helpful for clarity.
(WebCore::VisibleSelection::uncanonicalizedStart const): Ditto.
(WebCore::VisibleSelection::uncanonicalizedEnd const): Ditto.
(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents): Compute whether
the anchor is first *before* canonicalization, otherwise we will reverse the two
if their canonical values are equal. Canonicalization is not allowed to change
the ordering other than making two values equal.
(WebCore::VisibleSelection::validate): Updated for name.
(WebCore::VisibleSelection::setWithoutValidation): Ditto, also tweaked other names in the
function and removed an if statement.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries): Ditto.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Ditto.
- editing/VisibleSelection.h: Renamed m_baseIsFirst to m_anchorIsFirst and improved the
comment about m_isDirectional.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::anchorPosition const): Removed use of parentAnchoredEquivalent.
The name makes it sound like it would be useful, but really it just triggers some
editing behaviors that don't belong in Position code.
(WebCore::DOMSelection::focusPosition const): Ditto.
(WebCore::DOMSelection::basePosition const): Ditto.
(WebCore::DOMSelection::extentPosition const): Ditto.
(WebCore::DOMSelection::collapse): Reversed the order of the document check and the
check for invalid nodes and offsets. There are some inconsistencies between the
specification and WPT but for now matching WPT seems like the way to go.
(WebCore::DOMSelection::setBaseAndExtent): Ditto.
(WebCore::DOMSelection::extend): Use VisibleSelection::setExtent, which does exactly
what we want, rather than FrameSelection::setExtent, which does not. In the future
we may want to cut down on the number of subtly-different selection functions,
like these two, but for now this fixes this DOM method to work as specified.
LayoutTests:
- editing/inserting/insert-list-in-table-cell-07-expected.txt: Updated results
for a slight change in where the insertion point ends up. This is neither a
progression nor a regression, but this is also a very strange edge case. It
would be better at some point to enhance the editing code so the selection stays
intact, which I think means that the entire table body would be selected, but
the current behavior, before this patch and after, yields an insertion point.
- 1:22 PM Changeset in webkit [267361] by
-
- 9 edits in trunk
Remove emphasis/de-emphasis filters from DynamicsCompressor
https://bugs.webkit.org/show_bug.cgi?id=216796
Reviewed by Darin Adler.
Source/WebCore:
Remove emphasis/de-emphasis filters from DynamicsCompressor as these have been removed
from the specification.
This is a merge of the following Blink change:
No new tests, rebaselined existing tests.
- platform/audio/DynamicsCompressor.cpp:
(WebCore::DynamicsCompressor::DynamicsCompressor):
(WebCore::DynamicsCompressor::process):
(WebCore::DynamicsCompressor::reset):
(WebCore::DynamicsCompressor::setNumberOfChannels):
- platform/audio/DynamicsCompressor.h:
- platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::process):
(WebCore::DynamicsCompressorKernel::tailTime const):
- platform/audio/DynamicsCompressorKernel.h:
LayoutTests:
Rebaseline tests that are now passing.
- webaudio/AudioParam/audioparam-processing-expected.txt:
- webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state-expected.txt:
- webaudio/DynamicsCompressor/dynamicscompressor-simple-expected.txt:
- 1:08 PM Changeset in webkit [267360] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Timelines: remove "stop requested" marker
https://bugs.webkit.org/show_bug.cgi?id=216423
Patch by Patrick Angle <Patrick Angle> on 2020-09-21
Reviewed by Devin Rousso.
Removed the "Stop Requested" timeline marker, which was made unneccesary in r267038 which makes the recording
head marker stop at the moment the stop was requested, even if more time is required to complete the processing
of incoming data.
- UserInterface/Models/TimelineMarker.js:
- UserInterface/Views/TimelineOverview.js:
(WI.TimelineOverview):
(WI.TimelineOverview.prototype._recordingReset):
(WI.TimelineOverview.prototype._handleTimelineCapturingStateChanged):
- UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .markers > .marker.current-time::after):
(.timeline-ruler > .markers > .marker.stopping-time): Deleted.
(.timeline-ruler > .markers > .marker:matches(.stopping-time, .current-time)::after): Deleted.
(@media (prefers-color-scheme: dark) .timeline-ruler > .markers > .marker.stopping-time): Deleted.
- UserInterface/Views/TimelineRuler.js:
(WI.TimelineRuler.prototype.addMarker):
- 1:07 PM Changeset in webkit [267359] by
-
- 2 edits in trunk/Source/WebKit
Adjust the human readable names some GPU process internal feature flags
https://bugs.webkit.org/show_bug.cgi?id=216794
Reviewed by Darin Adler.
Change the human readable names so that all the GPU-process-specific internal features start are of the form
"Use GPU Process…".
- Shared/WebPreferencesInternal.yaml:
- 1:02 PM Changeset in webkit [267358] by
-
- 3 edits in trunk/Tools
Enable AddressSanitizer in C++ std library templates
<https://webkit.org/b/216746>
Reviewed by Darin Adler.
This change also prevents duplicate command-line switches from
being passed to clang since OTHER_CFLAGS is used when compiling
C++ sources.
- sanitizer/asan.xcconfig:
(WK_SANITIZER_OTHER_CPLUSPLUSFLAGS_YES): Add.
- Undefines _LIBCPP_HAS_NO_ASAN macro to enable ASan for C++ std library templates.
- sanitizer/sanitizer.xcconfig:
(WK_SANITIZER_OTHER_CPLUSPLUSFLAGS_YES): Add.
- Provide placeholder.
(OTHER_CPLUSPLUSFLAGS):
- Switch from WK_SANITIZER_OTHER_CFLAGS_ prefix to WK_SANITIZER_OTHER_CPLUSPLUSFLAGS_ prefix.
- 12:51 PM Changeset in webkit [267357] by
-
- 14 edits2 deletes in trunk
Vectorize linearRampToValueAtTime processing in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=216788
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-linearRampToValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/retrospective-setValueAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
Source/WebCore:
Vectorize linearRampToValueAtTime processing in AudioParamTimeline. This patch is based on
the Blink implementation at [1] but updated to use VectorMath to work on more platforms.
We were failing some tests due to precision issues in our linearRampToValueAtTime implementation.
Those tests are now passing since our implementation matches Blink's more closely.
[1] https://github.com/chromium/chromium/blob/master/third_party/blink/renderer/modules/webaudio/audio_param_timeline.cc
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::processLinearRamp):
- Modules/webaudio/AudioParamTimeline.h:
LayoutTests:
- webaudio/AudioParam/audioparam-cancel-and-hold-expected.txt:
- webaudio/AudioParam/audioparam-negative-exponentialRamp-expected.txt:
- webaudio/AudioParam/audioparam-setTargetAtTime-continuous-expected.txt:
Rebaseline existing tests now that more checks are passing.
- webaudio/audioparam-linearRampToValueAtTime-expected.txt: Removed.
- webaudio/audioparam-linearRampToValueAtTime.html: Removed.
Drop outdated test. This test was imported into WPT and now resides at:
- imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-linearRampToValueAtTime.html
- 12:34 PM Changeset in webkit [267356] by
-
- 1 copy in releases/WPE WebKit/webkit-2.30.1
WPE WebKit 2.30.1
- 12:34 PM Changeset in webkit [267355] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.30.1 release
.:
- Source/cmake/OptionsWPE.cmake: Bump version numbers.
Source/WebKit:
- wpe/NEWS: Add release notes for 2.30.1.
- 12:31 PM Changeset in webkit [267354] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Increase the maximum number of open files for wpt's servers
https://bugs.webkit.org/show_bug.cgi?id=215829
Patch by Sam Sneddon <Sam Sneddon> on 2020-09-21
Reviewed by Youenn Fablet.
macOS has a much lower limits than other OSes by default, and the iOS bots often run into it with their level of parallel test execution. This bumps the limit for each wptserve process up to 2048, which is double the limit on Debian, and should probably be safe.
- web-platform-tests/tools/serve/serve.py:
(ServerProc.create_daemon):
- 12:18 PM Changeset in webkit [267353] by
-
- 2 edits in trunk/Tools
Make ews-app robust against config.json issues (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=216705
Unreviewed follow-up fix to change a log statement.
- BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.update_icons_for_queues_mapping):
- 12:17 PM Changeset in webkit [267352] by
-
- 3 edits2 adds in trunk/Source/WebKit
WKWebView Swift overlay has mis-annotated nullability for evaluateJavaScript
<http://webkit.org/b/216198>
<rdar://problem/68035950>
Reviewed by Darin Adler.
Due to a mistranslation of evaluateJavaScript, we are vending an API which does not expect
to receive nil as a valid result value. This change fixes the crash, but does not yet fix
the API to have the correct signature. That will come in a later patch.
To fix the crash, we need to produce a valid Result<Any, Error> to pass back to clients.
Fortunately, instead of inventing something clever, we can just use nil. It's valid to box
optional values into Any, and clients can technically retrieve them with the right dynamic cast
as well. Since client code must be using dynamic casting to convert the result Any to a usable
type, and because in the case where we now return a new value at runtime we would have previously
crashed, this shouldn't have any binary compatibility impact either.
To better validate these changes, I also add new unit tests for the conversion of JavaScript
results into Swift values, including a test for the deprecated API.
- SwiftOverlay/SwiftOverlay/ObjectiveCBlockConversions.swift: Added. For clarity I'm factoring
helper methods into a single namespace, as it also makes a nice place to document their expectations.
(ObjectiveCBlockConversion.exclusive.exclusive(_:)): This is renamed from the free function,
makeResultHandler(_:). It still has the same fatalError (now precondition) as before, but
hopefully a better name to clarify that it expects exactly-one value.
(ObjectiveCBlockConversions.boxingNilAsAnyForCompatibility(_:)): This is a variant of exclusive(_:)
that makes the tradeoff of boxing any nil values as Any to avoid crashing. This is still safe,
since as mentioned our clients will need to cast the value they recieve to do anything with it,
and since the deprecated API expectsAny, no one could have been successfully comparing it
toniltoday anyways.
- SwiftOverlay/Tests/JavaScriptToSwiftTypeConversions.swift: Added.
(JavaScriptToSwiftConversions.setUp): Construct a new web view, and add it to a window so that it is
in an expected state. I'm using about:blank as the URL, since page content doesn't matter for
these tests and I want the web content to be ready immediately.
(JavaScriptToSwiftConversions.tearDown): Just perform some window cleanup.
(JavaScriptToSwiftConversions.evaluateJavaScript(_:andExpect:)): Helper method to evaluate script and
check its result. I'm using String.debugDescription because it escapes quotes and special characters
which makes the readout easier to parse.
(JavaScriptToSwiftConversions.testNull): JavaScript's null is actually mapped to NSNull, not nil.
(JavaScriptToSwiftConversions.testInteger): Some standard type coercion tests. The underlying value for
all number types should be NSNumber, so this is actually check against a float or integer type
without issue.
(JavaScriptToSwiftConversions.testDecimal): Ditto.
(JavaScriptToSwiftConversions.testBoolean): Ditto.
(JavaScriptToSwiftConversions.testString): Ditto.
(JavaScriptToSwiftConversions.testArray): Ditto.
(JavaScriptToSwiftConversions.testDictionary): Ditto, only you can't evaluate an object literal directly
so I need to store it in a temporary location first.
(JavaScriptToSwiftConversions.testUndefined): Test our boxing of nil. The exact value matters less than
not crashing at all.
- SwiftOverlay/WebKitSwiftOverlay.xcodeproj/project.pbxproj: Added new files to project. I kept the
new test file and helper files within the SwiftOverlay group, because they do not contribute any API.
- UIProcess/API/Cocoa/WebKitSwiftOverlay.swift:
(WKWebView.callAsyncJavaScript(_:arguments:in:in:completionHandler:)): Switch to a conversion which does
not trap on nil.
(WKWebView.createPDF(_:completionHandler:)): Updated to use new helper method name.
(WKWebView.createWebArchiveData(_:)): Ditto.
(WKWebView.evaluateJavaScript(_:in:in:completionHandler:Error:)): See above.
(makeResultHandler(_:): This has been subsumed by ObjCBlockConversions.
- 12:00 PM Changeset in webkit [267351] by
-
- 3 edits in trunk/Tools
[GTK][WPE] WKTR has lost access to Pulseaudio
https://bugs.webkit.org/show_bug.cgi?id=216745
Patch by Philippe Normand <pnormand@igalia.com> on 2020-09-21
Reviewed by Carlos Garcia Campos.
Let Pulseaudio env vars pass through in the test environment, this is specially needed when
the test harness runs in the Flatpak sandbox.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
- Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):
- 11:58 AM Changeset in webkit [267350] by
-
- 3 edits in trunk/Tools
[GTK][WPE] Missing support for multi-word $WEBKIT_MINI_BROWSER_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=216604
Patch by Philippe Normand <pnormand@igalia.com> on 2020-09-21
Reviewed by Adrian Perez de Castro.
Gracefully handle cases where the env var contains multiple words, by splitting its contents
to a list and inserting it at the beginning of the final minibrowser command.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.run_minibrowser):
- Scripts/webkitpy/port/wpe.py:
(WPEPort.run_minibrowser):
- 11:56 AM Changeset in webkit [267349] by
-
- 6 edits in trunk
AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only do FFT analysis once per render quantum
https://bugs.webkit.org/show_bug.cgi?id=216735
Reviewed by Darin Adler.
Source/WebCore:
AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only do FFT analysis once per render quantum:
"""
If another call to getByteFrequencyData() or getFloatFrequencyData() occurs within the same render quantum as a
previous call, the current frequency data is not updated with the same data. Instead, the previously computed data
is returned.
"""
No new tests, rebaselined existing test.
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::writeInput):
(WebCore::RealtimeAnalyser::doFFTAnalysisIfNecessary):
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
(WebCore::RealtimeAnalyser::getByteFrequencyData):
- Modules/webaudio/RealtimeAnalyser.h:
LayoutTests:
Rebaseline webaudio tests now that more checks are passing.
- webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt:
- webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt:
- 11:28 AM Changeset in webkit [267348] by
-
- 5 edits1 add in trunk
[JSC] Proxy should be trapped if base value is primitive
https://bugs.webkit.org/show_bug.cgi?id=216764
Reviewed by Darin Adler.
JSTests:
- stress/proxy-trap-in-primitive.js: Added.
(shouldBe):
- test262/expectations.yaml:
Source/JavaScriptCore:
While we have special care in JSObject::putInline etc., we missed it in JSValue::putToPrimitive.
So, if proxy exists in the prototype chain for the primitive values (e.g. StringPrototype -> Proxy chain),
we miss the Proxy trap. We should have ProxyObject special check in JSValue::putToPrimitive too.
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- 9:13 AM Changeset in webkit [267347] by
-
- 4 edits in trunk/Source/WebCore
Remove dedicated HashSet<Element*> for DocumentTimeline::runningAnimationsForElementAreAllAccelerated()
https://bugs.webkit.org/show_bug.cgi?id=216775
Reviewed by Antti Koivisto.
- animation/AnimationTimeline.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::detachFromDocument):
(WebCore::DocumentTimeline::animationAcceleratedRunningStateDidChange):
(WebCore::DocumentTimeline::runningAnimationsForElementAreAllAccelerated const):
(WebCore::DocumentTimeline::animationWasAddedToElement): Deleted.
(WebCore::DocumentTimeline::animationWasRemovedFromElement): Deleted.
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement): Deleted.
- animation/DocumentTimeline.h:
- 8:34 AM Changeset in webkit [267346] by
-
- 5 edits in trunk
AnalyserNode should downmix input audio to mono
https://bugs.webkit.org/show_bug.cgi?id=216736
Reviewed by Sam Weinig.
Source/WebCore:
AnalyserNode should downmix input audio to mono:
This patch is based on the following Blink change:
No new tests, rebaselined existing test.
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::RealtimeAnalyser):
(WebCore::RealtimeAnalyser::writeInput):
- Modules/webaudio/RealtimeAnalyser.h:
LayoutTests:
Rebaseline test now that more checks are passing.
- webaudio/Analyser/realtimeanalyser-downmix-expected.txt:
- 8:11 AM Changeset in webkit [267345] by
-
- 3 edits2 adds in trunk
REGRESSION (r257839): Can't add a memo when transferring funds in First Tech Credit Union App
https://bugs.webkit.org/show_bug.cgi?id=216754
<rdar://problem/67045862>
Reviewed by Antti Koivisto.
Source/WebCore:
After r257839, attempting to add a memo by tapping on a text box in the First Tech Credit Union app on iOS fails
to cause the text box (atextareaelement) to be focused. This is because thetextareais initially hidden
away in adisplay: none;parent container, which becomesdisplay: block;immediately beforefocus()is
called from the page's script.
Augment the mechanism added in r266887, so that we avoid consulting stale computed styles when checking for
hidden ancestors inElement::isVisibleWithoutResolvingFullStyle(). To do this, we pull logic to get or compute
theRenderStylefor the current element or one of its composed ancestors (which respects
IsComputedStyleInvalidFlag) into a lambda function, and use this lambda function below, when we walk up the
ancestor chain in search of a hidden element.
Note that in Speedometer 2.0, this change does not have any significant impact on the number of partial (i.e.
RenderedOnly) style resolutions we attempt to perform underneathElement::resolveComputedStyle(a little
over 3000 before and after this change).
Test: fast/forms/programmatic-focus-after-displaying-parent.html
- dom/Element.cpp:
(WebCore::Element::isVisibleWithoutResolvingFullStyle const):
LayoutTests:
Add a new layout test to exercise the bug by programmatically focusing a textarea element that was just shown by
settingdisplay: block;on a parent container that was previouslydisplay: none;.
- fast/forms/programmatic-focus-after-displaying-parent-expected.txt: Added.
- fast/forms/programmatic-focus-after-displaying-parent.html: Added.
- 7:57 AM Changeset in webkit [267344] by
-
- 6 edits in trunk
Allow about:blank subframe loads for non app-bound top frames
https://bugs.webkit.org/show_bug.cgi?id=216715
<rdar://problem/69070720>
Reviewed by Darin Adler.
Source/WebKit:
In the original implementation of App Bound Domains, any loads using
certain protocols like about: were automatically considered app-bound.
When a subframe loads about:blank for example, this forces web views
into app-bound mode even if the top frame is not app-bound, which
should not be the case.
These special protocols inherit security origins from their top-frame
loads, so we can refer to those to determine whether subframe loads
should be considered app-bound. For about: loads in a main frame there
is no behavior change and WKWebViews will still automatically be considered
app-bound in this case.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomainAndCheckIfPermitted):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
Refer to the security origin if the subframe load is one of the
special protocols caught by the shouldTreatURLProtocolAsAppBound() function.
- UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:
(WebKit::schemeOrDomainIsAppBound):
(WebKit::WebsiteDataStore::beginAppBoundDomainCheck):
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
Two new tests for about:blank loaded under an app-bound domain and
non-app bound domain respectively. Tests that the subframe load
has the same app-bound status as the parent frame by testing script
injection powers.
- TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
Fixed two test names that didn't make sense.
(-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
(TEST):
- 6:49 AM Changeset in webkit [267343] by
-
- 6 edits in trunk/Source/WebCore
[LFC][BFC] Move hasClearance out of BoxGeometry
https://bugs.webkit.org/show_bug.cgi?id=216757
Reviewed by Antti Koivisto.
Do not cache the hasClearance state in BoxGeometry.
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear):
(WebCore::Layout::BlockFormattingContext::verticalPositionWithMargin const):
- layout/blockformatting/BlockFormattingState.h:
(WebCore::Layout::BlockFormattingState::setHasClearance):
(WebCore::Layout::BlockFormattingState::clearClearance):
(WebCore::Layout::BlockFormattingState::hasClearance const):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::hasClearance const):
- layout/layouttree/LayoutBoxGeometry.cpp:
(WebCore::Layout::BoxGeometry::BoxGeometry):
- layout/layouttree/LayoutBoxGeometry.h:
(WebCore::Layout::BoxGeometry::hasClearance const): Deleted.
(WebCore::Layout::BoxGeometry::setHasClearance): Deleted.
- 6:34 AM Changeset in webkit [267342] by
-
- 3 edits in trunk/Source/WebCore
[LFC] Remove unused EscapeReason::StrokeOverflowNeedsViewportGeometry
https://bugs.webkit.org/show_bug.cgi?id=216759
Reviewed by Antti Koivisto.
This escape reason was used to read ICB geometry to compute ink overflow (prior to r267325).
- layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::geometryForBox const):
- layout/FormattingContext.h:
- 6:32 AM Changeset in webkit [267341] by
-
- 2 edits in trunk/Source/WebCore
[LFC][MarginCollapse] The block level box passed in to MarginCollapse::positiveNegativeValues is in the current formatting context
https://bugs.webkit.org/show_bug.cgi?id=216758
Reviewed by Antti Koivisto.
Let's use the current formatting state when grabbing vertical margin values.
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::positiveNegativeValues const):
- 6:27 AM Changeset in webkit [267340] by
-
- 2 edits in trunk/LayoutTests
[GTK] media/media-can-play-mp3.html is failing since added in r267210
https://bugs.webkit.org/show_bug.cgi?id=216765
Unreviewed, unflag now-passing test, since r267335.
- platform/gtk/TestExpectations: Unflag now-passing test.
- 3:42 AM Changeset in webkit [267339] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Adjust test expectations of several tests failing.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 2:49 AM Changeset in webkit [267338] by
-
- 3 edits in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Gardened several failures of new tests added.
- platform/glib/TestExpectations:
- platform/gtk/TestExpectations:
- 2:43 AM Changeset in webkit [267337] by
-
- 1 copy in releases/WebKitGTK/webkit-2.30.1
WebKitGTK 2.30.1
- 2:42 AM Changeset in webkit [267336] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.30.1 release
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.30.1.
- 1:42 AM WebKitGTK/2.30.x edited by
- (diff)
- 1:26 AM Changeset in webkit [267335] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] media/media-can-play-mp3.html fails
https://bugs.webkit.org/show_bug.cgi?id=216692
Patch by Philippe Normand <pnormand@igalia.com> on 2020-09-21
Reviewed by Darin Adler.
Add mp3 to supported codecs map when a valid decoder has been
found by the GStreamer registry scanner.
- platform/graphics/gstreamer/GStreamerRegistryScanner.cpp:
(WebCore::GStreamerRegistryScanner::initialize):
- 12:42 AM Changeset in webkit [267334] by
-
- 1 edit3 adds in trunk/LayoutTests
[GLIB] Unreviewed test gardening. Emit new baselines for WebAudio tests after r267307.
The results are slightly different in GLIB ports.
- platform/glib/webaudio/BiquadFilter/tail-time-lowpass-expected.txt: Added.
- platform/glib/webaudio/BiquadFilter/tail-time-peaking-expected.txt: Added.
Sep 20, 2020:
- 4:07 PM Changeset in webkit [267333] by
-
- 6 edits in trunk
Performance.navigation and Performance.timing are incorrectly exposed to workers
https://bugs.webkit.org/show_bug.cgi?id=216732
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
- web-platform-tests/workers/worker-performance.worker-expected.txt:
Update results now that Performance.navigation and Performance.timing are no longer
exposed to workers.
Source/WebCore:
- page/Performance.idl:
Only expose Performance.navigation and Performance.timing to the Window.
LayoutTests:
Remove flaky annotation for imported/w3c/web-platform-tests/workers/worker-performance.worker.html. The
test was fixed in upstream WPT as dab9c45, and has since been updated in the WebKit tree as well.
It now also passes.
- 3:58 PM Changeset in webkit [267332] by
-
- 193 edits947 adds43 deletes in trunk/JSTests
Test262 update
https://bugs.webkit.org/show_bug.cgi?id=216753
Reviewed by Darin Adler.
- 3:26 PM Changeset in webkit [267331] by
-
- 7 edits3 adds in trunk/Source/WebCore
Using [Exposed=Window] with [Default] object toJSON() doesn't work
https://bugs.webkit.org/show_bug.cgi?id=216731
Reviewed by Simon Fraser.
Fixes filtering an attribute out of [Default] toJSON operation based
on which which global objects it is exposed to by ensuring we always
pass a global object pointer accessor function to
GenerateRuntimeEnableConditionalStringForExposed. For good measure,
we now always pass the global object object pointer to
GenerateRuntimeEnableConditionalString as well so that it is always
explicit.
This is needed to support filtering out Performance.navigation and
Performance.timing from the Performance interface's toJSON implementation
which will be addressed in a separate change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateRuntimeEnableConditionalString):
Remove implicit global object accessor string construction by always
requiring it to be passed.
- bindings/scripts/test/DOMWindowConstructors.idl:
- bindings/scripts/test/JS/JSDOMWindow.cpp:
- bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.cpp: Added.
- bindings/scripts/test/JS/JSTestDefaultToJSONFilteredByExposed.h: Added.
- bindings/scripts/test/JS/JSWorkerGlobalScope.cpp:
- bindings/scripts/test/SupplementalDependencies.dep:
- bindings/scripts/test/TestDefaultToJSONFilteredByExposed.idl: Added.
- bindings/scripts/test/WorkerGlobalScopeConstructors.idl:
Add new test for updated behavior. I couldn't add it to the existing
TestDefaultToJSON.idl test as that test requires the interface only be exposed
to Window to support testing EnabledBySetting.
- 1:44 PM Changeset in webkit [267330] by
-
- 179 edits1 delete in trunk
[JSC] Drop Options::useBigInt
https://bugs.webkit.org/show_bug.cgi?id=216743
Reviewed by Darin Adler.
JSTests:
- bigIntTests.yaml: Removed.
- stress/big-int-add-wrapped-value.js:
- stress/big-int-addition-basic.js:
- stress/big-int-addition-jit.js:
- stress/big-int-addition-memory-stress.js:
- stress/big-int-addition-string-coercion.js:
- stress/big-int-addition-to-primitive-precedence.js:
- stress/big-int-addition-to-primitive.js:
- stress/big-int-addition-type-error.js:
- stress/big-int-arithmetic-return-big-int.js:
- stress/big-int-as-key.js:
- stress/big-int-as-property-name.js:
- stress/big-int-bit-not-general.js:
- stress/big-int-bitwise-and-general.js:
- stress/big-int-bitwise-and-jit.js:
- stress/big-int-bitwise-and-memory-stress.js:
- stress/big-int-bitwise-and-to-primitive-precedence.js:
- stress/big-int-bitwise-and-type-error.js:
- stress/big-int-bitwise-and-wrapped-value.js:
- stress/big-int-bitwise-not-jit.js:
- stress/big-int-bitwise-not-wrapped-value.js:
- stress/big-int-bitwise-or-general.js:
- stress/big-int-bitwise-or-jit-untyped.js:
- stress/big-int-bitwise-or-jit.js:
- stress/big-int-bitwise-or-memory-stress.js:
- stress/big-int-bitwise-or-to-primitive-precedence.js:
- stress/big-int-bitwise-or-type-error.js:
- stress/big-int-bitwise-or-wrapped-value.js:
- stress/big-int-bitwise-xor-general.js:
- stress/big-int-bitwise-xor-jit.js:
- stress/big-int-bitwise-xor-memory-stress.js:
- stress/big-int-bitwise-xor-to-primitive-precedence.js:
- stress/big-int-bitwise-xor-type-error.js:
- stress/big-int-bitwise-xor-untyped.js:
- stress/big-int-bitwise-xor-wrapped-value.js:
- stress/big-int-boolean-proven-type.js:
- stress/big-int-branch-usage.js:
- stress/big-int-constructor-gc.js:
- stress/big-int-constructor-oom.js:
- stress/big-int-constructor-properties.js:
- stress/big-int-constructor-prototype-prop-descriptor.js:
- stress/big-int-constructor-prototype.js:
- stress/big-int-constructor.js:
- stress/big-int-div-jit-osr.js:
- stress/big-int-div-jit-untyped.js:
- stress/big-int-div-jit.js:
- stress/big-int-div-memory-stress.js:
- stress/big-int-div-to-primitive.js:
- stress/big-int-div-type-error.js:
- stress/big-int-div-wrapped-value.js:
- stress/big-int-division.js:
- stress/big-int-equals-basic.js:
- stress/big-int-equals-to-primitive-precedence.js:
- stress/big-int-equals-wrapped-value.js:
- stress/big-int-exp-basic.js:
- stress/big-int-exp-jit-osr.js:
- stress/big-int-exp-jit-untyped.js:
- stress/big-int-exp-jit.js:
- stress/big-int-exp-negative-exponent.js:
- stress/big-int-exp-to-primitive.js:
- stress/big-int-exp-type-error.js:
- stress/big-int-exp-wrapped-value.js:
- stress/big-int-function-apply.js:
- stress/big-int-greater-than-general.js:
- stress/big-int-greater-than-jit.js:
- stress/big-int-greater-than-or-equal-jit.js:
- stress/big-int-greater-than-or-equal-order-of-evaluation.js:
- stress/big-int-greater-than-or-equal-wrapped-values.js:
- stress/big-int-greater-than-or-equal.js:
- stress/big-int-greater-than-order-of-evaluation.js:
- stress/big-int-greater-than-wrapped-values.js:
- stress/big-int-json-stringify-to-json.js:
- stress/big-int-json-stringify.js:
- stress/big-int-left-shift-general.js:
- stress/big-int-left-shift-range-error.js:
- stress/big-int-left-shift-type-error.js:
- stress/big-int-left-shift-untyped.js:
- stress/big-int-left-shift-wrapped-value.js:
- stress/big-int-length.js:
- stress/big-int-less-than-general.js:
- stress/big-int-less-than-jit.js:
- stress/big-int-less-than-or-equal-general.js:
- stress/big-int-less-than-or-equal-jit.js:
- stress/big-int-less-than-or-equal-order-of-evaluation.js:
- stress/big-int-less-than-or-equal-wrapped-values.js:
- stress/big-int-less-than-order-of-evaluation.js:
- stress/big-int-less-than-wrapped-values.js:
- stress/big-int-literal-inside-literal-object.js:
- stress/big-int-literal-line-terminator.js:
- stress/big-int-literals.js:
- stress/big-int-logical-and.js:
- stress/big-int-logical-not.js:
- stress/big-int-logical-or.js:
- stress/big-int-mod-jit.js:
- stress/big-int-mod-memory-stress.js:
- stress/big-int-mod-osr.js:
- stress/big-int-mod-to-primitive-precedence.js:
- stress/big-int-mod-to-primitive.js:
- stress/big-int-mod-type-error.js:
- stress/big-int-mod-wrapped-value.js:
- stress/big-int-mod.js:
- stress/big-int-mul-jit-osr.js:
- stress/big-int-mul-jit-untyped.js:
- stress/big-int-mul-jit.js:
- stress/big-int-mul-to-primitive-precedence.js:
- stress/big-int-mul-to-primitive.js:
- stress/big-int-mul-type-error.js:
- stress/big-int-mul-wrapped-value.js:
- stress/big-int-multiplication.js:
- stress/big-int-multiply-memory-stress.js:
- stress/big-int-negate-basic.js:
- stress/big-int-no-conversion-to-number.js:
- stress/big-int-operations-error.js:
- stress/big-int-out-of-memory-tests.js:
- stress/big-int-prop-descriptor.js:
- stress/big-int-proto-constructor.js:
- stress/big-int-proto-name.js:
- stress/big-int-prototype-properties.js:
- stress/big-int-prototype-proto.js:
- stress/big-int-prototype-symbol-to-string-tag.js:
- stress/big-int-prototype-to-string-apply.js:
- stress/big-int-prototype-to-string-cast-overflow.js:
- stress/big-int-prototype-to-string-exception.js:
- stress/big-int-prototype-to-string-wrong-values.js:
- stress/big-int-prototype-value-of.js:
- stress/big-int-right-shift-general.js:
- stress/big-int-right-shift-jit-osr.js:
- stress/big-int-right-shift-jit-untyped.js:
- stress/big-int-right-shift-jit.js:
- stress/big-int-right-shift-type-error.js:
- stress/big-int-right-shift-wrapped-value.js:
- stress/big-int-spec-to-primitive.js:
- stress/big-int-spec-to-this.js:
- stress/big-int-strict-equals-jit.js:
- stress/big-int-strict-spec-to-this.js:
- stress/big-int-sub-wrapped-value.js:
- stress/big-int-subtraction-basic.js:
- stress/big-int-subtraction-jit.js:
- stress/big-int-subtraction-type-error.js:
- stress/big-int-to-object.js:
- stress/big-int-to-string.js:
- stress/big-int-type-of-proven-type-non-constant-including-symbol.js:
- stress/big-int-type-of-proven-type-non-constant.js:
- stress/big-int-type-of-proven-type.js:
- stress/big-int-type-of.js:
- stress/big-int-unary-plus.js:
- stress/big-int-value-op-update-gc-rules.js:
- stress/big-int-white-space-trailing-leading.js:
- stress/bigint-toLocaleString.js:
- stress/bitwise-not-fixup-rules.js:
- stress/delete-property-inline-cache.js:
- stress/inc-osr-exit-from-big-int.js:
- stress/inc-osr-exit-to-big-int.js:
- stress/left-shift-to-primitive-precedence.js:
- stress/numeric-literal-separators.js:
- stress/object-create-non-object-properties-parameter.js:
- stress/proxy-call-apply-handler-to-this.js:
- stress/right-shift-to-primitive-precedence.js:
- stress/value-add-big-int-and-string.js:
- stress/value-add-big-int-prediction-propagation.js:
- stress/value-add-big-int-untyped.js:
- stress/value-bit-and-ai-rule.js:
- stress/value-bit-lshift-ai-rule.js:
- stress/value-bit-not-ai-rule.js:
- stress/value-bit-or-ai-rule.js:
- stress/value-bit-xor-ai-rule.js:
- stress/value-div-fixup-int32-big-int.js:
- stress/value-mul-fixup-int32-big-int.js:
- stress/value-sub-big-int-prediction-propagation.js:
- stress/value-sub-big-int-untyped.js:
- test262/config.yaml:
Source/JavaScriptCore:
Now BigInt is shipped. Let's just remove Options::useBigInt.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitEqualityOpImpl):
- parser/Lexer.cpp:
(JSC::Lexer<T>::parseHex):
(JSC::Lexer<T>::parseBinary):
(JSC::Lexer<T>::parseOctal):
(JSC::Lexer<T>::parseDecimal):
- runtime/JSGlobalObject.h:
- runtime/OptionsList.h:
Tools:
- Scripts/run-jsc-benchmarks:
- Scripts/run-jsc-stress-tests:
- 12:37 PM Changeset in webkit [267329] by
-
- 8 edits in trunk
Selection API: Further improvements to VisibleSelection, FrameSelection, and DOMSelection to preserve anchor and focus
https://bugs.webkit.org/show_bug.cgi?id=216739
Reviewed by Ryosuke Niwa.
Source/WebCore:
If done correctly, these changes should have almost no effect unless live range selection
is enabled. This adds a feature where VisibleSelection tracks the original points,
before the VisiblePosition-style canonicalization. It also starts a transition from
the base/extent terminology to the slightly-easier-to-understand anchor/focus terminology
that is used in the selection specification. New functions name them anchor and focus,
even though we still have some old ones that call them base and extent. In addition,
made some other small related improvements to live range selection mode, without changing
behavior when not in that mode. Have been testing these locally by turning on that mode
and running various tests.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::isInDocumentTree const): Added. Used by DOMSelection to
correctly handle cases where the selection is in a shadow tree without requiring it
actually create the associated live range just to query.
(WebCore::FrameSelection::associatedLiveRange): Use the new VisibleSelection::range,
which gives us non-canonicalized points, rather than the deprecated
VisibleSelection::firstRange, which we will eventually be renaming or deleting.
(WebCore::FrameSelection::updateFromAssociatedLiveRange): Use
makeContainerOffsetPosition instead of implicitly using makeDeprecatedLegacyPosition.
Also removed the FIXME about normalization of endpoints, which is what this patch
mostly addresses; no need to track with a comment now.
(WebCore::FrameSelection::updateAssociatedLiveRange): Use VisibleSelection::range
for the same reason as above.
- editing/FrameSelection.h: Added isInDocumentTree.
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::VisibleSelection): Updated the primary constructor to set
m_anchor/focus and let the validate function set m_base/extent/start/end/baseIsFirst.
Changed most other constructors to call that primary one.
(WebCore::VisibleSelection::anchor const): Added. This is a non-canonicalized position.
(WebCore::VisibleSelection::focus const): Ditto.
(WebCore::VisibleSelection::uncanonicalizedStart const): Added. This non-canonicalized
version of start is used by new DOMSelection code, but eventually should be used
elsewhere as well, and we may eventually eliminate the canonicalized version.
(WebCore::VisibleSelection::uncanonicalizedEnd const): Ditto.
(WebCore::VisibleSelection::range const): Added. This non-canonicalized version of
firstRange has many of the same considerations as the other four functions above.
(WebCore::VisibleSelection::setBase): Set m_anchor instead of m_base. Eventually we
will want to rename this function, too, but there is no need to do that now.
(WebCore::VisibleSelection::setExtent): Ditto.
(WebCore::VisibleSelection::setBaseAndExtentToDeepEquivalents): Rewrote to take
m_anchor and m_focus as inputs and now m_base and m_extent are pure outputs.
May want to rename this later, because "deep equivalents" is a funny way to say
that this function sets base and extent to canonicalized values.
(WebCore::VisibleSelection::adjustSelectionRespectingGranularity): Renamed from
setStartAndEndFromBaseAndExtentRespectingGranularity. This now takes m_start/end
as input as well as output, because the validate function needs to check
if the function changes m_start/end so it can update m_anchor/focus. Also did a tiny
bit of refactoring to use std::swap.
(WebCore::VisibleSelection::validate): Refined the code to handle canonicalization
differently from expanding due to granularity. Canonicalization is done preserving
the original m_anchor/focus as it mostly always has been. But expansion due to
granularity now changes m_anchor/focus/base/extent rather than just m_start/end.
This makes sense because granularity changes actually affect what is selected,
while canonicalization just changes how the selection is expressed and tracked.
(WebCore::VisibleSelection::setWithoutValidation): Set m_anchor/focus. In the future,
we can probably get rid of this eventually, because the "validation" talked about
here is the unwanted canonicalization. But that's a refinement for the future.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingShadowBoundaries):
Update m_focus, not just m_extent, if we have to adjust. Also removed an unnnecessary
null check from the start of the function.
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries): Ditto.
Also removed the assertions because these situations can indeed arise and it's not
necessarily an indication of a bug in editing code.
- editing/VisibleSelection.h: Rearranged constructors to make it slightly more clear
which is the main one and that the others are simply convenience shorthands. Might
want to come back later and remove some unused ones. Added uncanonicalizedStart,
uncanonicalizedEnd, anchor, focus, and range. Renamed the private function called
setStartAndEndFromBaseAndExtentRespectingGranularity to the new name
adjustSelectionRespectingGranularity. Added m_anchor and m_focus and refined the
comments about the position data members. We should eventually be able to cut down
on the number of these again, but it's fine to have two more for now.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::range const): Use range rather than firstRange when live
range selection is enabled, for proper round-tripping of selection endpoints,
unaffected by canonicalization. The other changes below are for the same reason.
(WebCore::DOMSelection::anchorPosition const): Use anchor.
(WebCore::DOMSelection::focusPosition const): Use focus.
(WebCore::DOMSelection::basePosition const): Use anchor.
(WebCore::DOMSelection::extentPosition const): Use focus.
(WebCore::DOMSelection::type const): Use isInDocumentTree and range rather than
isNone/isCaret/isRange when live range selection is enabled, because this needs
to report "Caret" when the range is not collapsed, even if the canonicalized
range is collapsed and "None" when the selection is in a shadow tree.
(WebCore::DOMSelection::rangeCount const): Use isInDocumentTree to check if
there is a selection rather than isNone to correctly handle the shadow tree case.
(WebCore::DOMSelection::collapseToEnd): Use uncanonicalizedEnd.
(WebCore::DOMSelection::collapseToStart): Use uncanonicalizedStart.
(WebCore::DOMSelection::containsNode const): Updated the comment for clarity.
LayoutTests:
- editing/execCommand/insert-list-nested-with-orphaned-expected.txt: This test
result reflected incorrrect behavior where the selection changed from a range
to a caret in a certain unusual case. The new behavior of leaving the text
selected is consistent with how the command works in normal cases, and was an
accidental progression from the improvements to the selection code. Was able
to reproduce this all in Safari and after experimenting with different
selections, it's clear this is an improvement.
- 12:21 PM Changeset in webkit [267328] by
-
- 7 edits4 copies1 add1 delete in trunk/Source/WebCore
[LFC Display] Move LFC Display infrastructure files into a new 'display' directory
https://bugs.webkit.org/show_bug.cgi?id=216747
Reviewed by Zalan Bujtas.
WebCore/Source/display will become the home for all the LFC painting code; move
DisplayView and DisplayLayerController into it.
Also fix some unified build include issues.
- CMakeLists.txt:
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- display/DisplayLayerController.cpp: Renamed from Source/WebCore/layout/display/DisplayLayerController.cpp.
- display/DisplayLayerController.h: Renamed from Source/WebCore/layout/display/DisplayLayerController.h.
- display/DisplayView.cpp: Renamed from Source/WebCore/layout/display/DisplayView.cpp.
- display/DisplayView.h: Renamed from Source/WebCore/layout/display/DisplayView.h.
- layout/flexformatting/FlexFormattingContext.cpp:
- layout/inlineformatting/InlineLineBox.cpp:
- 11:10 AM Changeset in webkit [267327] by
-
- 4 edits in trunk/Source/WebCore
Selection API: Fix selectAllChilden to return InvalidNodeTypeError when passed a DocumentType node
https://bugs.webkit.org/show_bug.cgi?id=216741
Reviewed by Ryosuke Niwa.
This is covered by tests, but the fix itself is only testable when live range
selection is enabled. So for now the other tests are simply checking that no
regression or behavior change was introduced by accident.
- page/DOMSelection.cpp:
(WebCore::DOMSelection::selectAllChildren): Return the value returned by
setBaseAndExtent so we don't discard any exception it might throw. In
practice, that's only this one.
- page/DOMSelection.h: Updated return type so we can throw an exception.
- page/DOMSelection.idl: Added MayThrowException.
- 10:51 AM Changeset in webkit [267326] by
-
- 2 edits in trunk/Source/WebKit
Sort the project file.
- WebKit.xcodeproj/project.pbxproj:
- 8:01 AM Changeset in webkit [267325] by
-
- 19 edits1 add in trunk
[LFC][IFC] InlineFormattingState should not store display lines and runs
https://bugs.webkit.org/show_bug.cgi?id=216742
Reviewed by Antti Koivisto.
Source/WebCore:
In this patch,
- Display related structures are completely moved out from Layout namespace
- InlineFormattingContext does not generate display structures.
- InlineFormattingState only stores layout data.
- Layout tree verification works on layout geometry.
- Layout structures do not embed Display types.
- LayoutIntegration creates and maintains the required Display structures for painting and hittesting.
- Display::Run does not use Layout types (InlineLayoutRect, InlineLayoutUnit).
FIXME: We need to start constructing display content for the Display::Painter.
- WebCore.xcodeproj/project.pbxproj:
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::checkForMatchingNonTextRuns):
(WebCore::Layout::checkForMatchingTextRuns):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree):
- layout/displaytree/DisplayInlineContent.h:
(WebCore::Display::InlineContent::shrinkToFit):
- layout/displaytree/DisplayLine.h:
(WebCore::Display::Line::horizontalAlignmentOffset const):
(WebCore::Display::Line::Line):
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintInlineContent):
- layout/displaytree/DisplayRun.h:
(WebCore::Display::Run::TextContent::start const):
(WebCore::Display::Run::TextContent::end const):
(WebCore::Display::Run::TextContent::length const):
(WebCore::Display::Run::TextContent::content const):
(WebCore::Display::Run::TextContent::needsHyphen const):
(WebCore::Display::Run::rect const):
(WebCore::Display::Run::inkOverflow const):
(WebCore::Display::Run::Run):
(WebCore::Display::Run::TextContent::TextContent):
(WebCore::Display::Run::TextContent::setNeedsHyphen): Deleted.
(WebCore::Display::Run::TextContent::expand): Deleted.
(WebCore::Display::Run::TextContent::shrink): Deleted.
(WebCore::Display::Run::topLeft const): Deleted.
(WebCore::Display::Run::left const): Deleted.
(WebCore::Display::Run::right const): Deleted.
(WebCore::Display::Run::top const): Deleted.
(WebCore::Display::Run::bottom const): Deleted.
(WebCore::Display::Run::width const): Deleted.
(WebCore::Display::Run::height const): Deleted.
(WebCore::Display::Run::moveVertically): Deleted.
- layout/flexformatting/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::sizeAndPlaceFlexItems):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::lineRuns const):
(WebCore::Layout::InlineFormattingState::lineRuns):
(WebCore::Layout::InlineFormattingState::addLineRun):
(WebCore::Layout::InlineFormattingState::clearLineAndRuns):
(WebCore::Layout::InlineFormattingState::shrinkToFit):
(WebCore::Layout::InlineFormattingState::displayInlineContent const): Deleted.
(WebCore::Layout::InlineFormattingState::ensureDisplayInlineContent): Deleted.
(WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent): Deleted.
- layout/inlineformatting/InlineLine.h:
(WebCore::Layout::Line::Run::textContent const):
(WebCore::Layout::Line::Run::expansion const):
- layout/inlineformatting/InlineLineGeometry.h:
(WebCore::Layout::InlineLineGeometry::horizontalAlignmentOffset const):
(WebCore::Layout::InlineLineGeometry::InlineLineGeometry):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
(WebCore::LayoutIntegration::LineLayout::constructDisplayContent):
(WebCore::LayoutIntegration::LineLayout::ensureDisplayInlineContent):
(WebCore::LayoutIntegration::LineLayout::paint):
(WebCore::LayoutIntegration::LineLayout::displayInlineContent const): Deleted.
- layout/integration/LayoutIntegrationLineLayout.h:
(WebCore::LayoutIntegration::LineLayout::displayInlineContent const):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputInlineRuns):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
- rendering/line/LineLayoutTraversalDisplayRunPath.h:
(WebCore::LineLayoutTraversal::DisplayRunPath::rect const):
LayoutTests:
This directory is about verifying layout correctness
by calling LayoutContext::verifyAndOutputMismatchingLayoutTree on every layout frame
and assert in case of mismatching trees.
The test coverage does not suffer by [ ImageOnlyFailure ] it.
(We need to start generating display boxes for the Display::Painter.)
- 2:14 AM Changeset in webkit [267324] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, use RELEASE_AND_RETURN to suppress exception verification failure
https://bugs.webkit.org/show_bug.cgi?id=216686
<rdar://problem/69157632>
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::defineOwnProperty):
Sep 19, 2020:
- 9:32 PM Changeset in webkit [267323] by
-
- 2 edits in trunk/Tools
[GLIB] Merge API test expectations
Unreviewed test gardening.
Two TestUIClient sections were causing the first one to be ignored.
- TestWebKitAPI/glib/TestExpectations.json:
- 9:30 PM Changeset in webkit [267322] by
-
- 2 edits in trunk/LayoutTests
[GLIB] Unreviewed gardening.
- platform/glib/TestExpectations:
- 7:51 PM Changeset in webkit [267321] by
-
- 20 edits in trunk/LayoutTests
Selection API: Update some more tests so they don't accidentally rely on flaws in WebKit's old implementation
https://bugs.webkit.org/show_bug.cgi?id=216737
Reviewed by Sam Weinig.
Like the three tests I modified in r267220, these tests are accidentally
depending on the fact that our selection object implementation currently
allows invalid indexes. It's clear that these are mistakes in the tests,
not intentional, and fixing these does not change the test expectations,
only the tests themselves.
- accessibility/mac/select-text-should-match-whole-words.html: Set the selection
with separate calls to the collapse function. The old code tried to reuse the
same range to set the selection back to an old value, but that won't work if
the selection updates the range (as it is supposed to do).
- editing/execCommand/indent-selection.html: Pass a valid index, 1, instead of
an invalid one, 2.
- editing/pasteboard/paste-visible-script.html: Ditto.
- editing/pasteboard/replacement-fragment-remove-unrendered-node-crash.html:
Pass a valid index, 0, instead of an invalid one, 10500000000. Also fixed line
endings in this file, which were all Windows-style CR/LF pairs to be Unix-style
LF like most of our other files.
- editing/pasteboard/testcase-9507.html: Use childNodes.length to compute a
valid index instead of passing 5, which was an invalid one.
- editing/style/apply-style-crash2.html: Pass a valid index, 0, instead of
an invalid one, 4.
- editing/style/query-typing-style.html: Pass a valid index, 0, instead of
an invalid one, 1.
- editing/undo/undo-paste-when-caret-is-not-in-range.html: Pass valid index
1 instead of invalid ones, 3 and 4.
- fast/block/float/float-list-changed-before-layout-crash.html: Pass a valid
index, 0, instead of an invalid one, 1.
- fast/dynamic/checkbox-selection-crash.html: Use childNodes.length to compute
a valid index instead of passing 1000, which was an invalid one.
- fast/repaint/selection-gap-absolute-child.html: Pass a valid index, 0, instead
of an invalid one, 1.
- fast/repaint/selection-gap-fixed-child.html: Ditto.
- fast/repaint/selection-gap-flipped-absolute-child.html: Ditto.
- fast/repaint/selection-gap-flipped-fixed-child.html: Ditto.
- fast/repaint/selection-gap-transformed-absolute-child.html: Ditto.
- fast/repaint/selection-gap-transformed-fixed-child.html: Ditto.
- fast/replaced/selection-rect.html: Select the image with a range in its
parent node with valid indices instead of relying WebKit's quirky way of
expressing selections of replaced elements, which involves an invalid index
of 1 for an image element with no children. This test has nothing to do with
the particular selection range technique used, so it's fine to change it.
- http/tests/security/resources/foreign-domain-iframe-for-selection-test.html:
Use childNodes.length to compute a valid index instead of passing 10, which was
an invalid one.
- imported/blink/editing/apply-inline-style-to-element-with-no-renderer-crash.html:
Use a valid index, 0, instead of an invalid one, 4.
- 11:52 AM Changeset in webkit [267320] by
-
- 5 edits in trunk/Source/WebCore
Implementation for AXIsolatedObject::nextSibling and previousSibling.
https://bugs.webkit.org/show_bug.cgi?id=216710
Reviewed by Chris Fleizach.
Implementation for AXIsolatedObject::previousSibling and nextSibling which
are invoked by VoiceOver in Safari Reader mode.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::previousSibling const):
- Fixed crash caused by dereferencing m_renderer->parent() which can be null.
- Added check for the AXObjectCache that can become null.
(WebCore::AccessibilityRenderObject::nextSibling const):
- Code style cleanup.
- accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
- Added caching of next/previousSiblling objects.
(WebCore::AXIsolatedObject::previousSibling const): Inlined in header..
(WebCore::AXIsolatedObject::nextSibling const): Inlined in header.
- accessibility/isolatedtree/AXIsolatedObject.h:
- accessibility/isolatedtree/AXIsolatedTree.h:
- 10:43 AM Changeset in webkit [267319] by
-
- 1 copy in tags/Safari-610.2.6.1.3
Tag Safari-610.2.6.1.3.
- 10:39 AM Changeset in webkit [267318] by
-
- 1 edit in branches/safari-610.2.6.1-branch/Source/WebKit/UIProcess/mac/DisplayLink.cpp
Cherry-pick r266958. rdar://problem/69202514
Unreviewed build fix for r266771. An include is missing which causes the build to fail flakily depending on the position of the cpp in the unified source file.
- UIProcess/mac/DisplayLink.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:37 AM Changeset in webkit [267317] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.3
- 10:07 AM Changeset in webkit [267316] by
-
- 10 edits in trunk
Performance and PerformanceNavigation interfaces are missing toJSON operations
https://bugs.webkit.org/show_bug.cgi?id=216728
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Update results now that we pass more subtests.
- web-platform-tests/hr-time/idlharness.any-expected.txt:
- web-platform-tests/hr-time/idlharness.any.worker-expected.txt:
- web-platform-tests/hr-time/performance-tojson-expected.txt:
Source/WebCore:
Add missing toJSON operations to Performance and PerformanceNavigation and update
comments in related IDLs.
Updates results for existing tests, more of which now pass.
- page/Performance.idl:
- page/PerformanceMark.idl:
- page/PerformanceMeasure.idl:
- page/PerformanceNavigation.idl:
- page/PerformanceTiming.idl:
- 9:46 AM Changeset in webkit [267315] by
-
- 5 edits in trunk/Source/WebCore
[LFC][IFC] InlineFormattingContext::computeGeometryForLineContent should not construct Display::Lines
https://bugs.webkit.org/show_bug.cgi?id=216723
Reviewed by Antti Koivisto.
Display::Lines construction should live in the display builder. However currently we don't yet have a real builder, so let's
just use the integration layer.
This is also in preparation for removing all the Display::InlineContent code from the Layout namespace.
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintInlineContent):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::layout):
(WebCore::LayoutIntegration::LineLayout::constructDisplayContent):
- layout/integration/LayoutIntegrationLineLayout.h:
- 8:05 AM Changeset in webkit [267314] by
-
- 8 edits1 copy1 move12 adds2 deletes in trunk/LayoutTests
Resync web-platform-tests/hr-time from upstream
https://bugs.webkit.org/show_bug.cgi?id=216724
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Resync web-platform-tests/hr-time from upstream.
- web-platform-tests/hr-time/META.yml: Added.
- web-platform-tests/hr-time/OWNERS: Removed.
- web-platform-tests/hr-time/idlharness-expected.txt: Removed.
- web-platform-tests/hr-time/idlharness.any-expected.txt: Added.
- web-platform-tests/hr-time/idlharness.any.html: Added.
- web-platform-tests/hr-time/idlharness.any.js: Added.
- web-platform-tests/hr-time/idlharness.any.worker-expected.txt: Added.
- web-platform-tests/hr-time/idlharness.any.worker.html: Added.
- web-platform-tests/hr-time/idlharness.html: Removed.
- web-platform-tests/hr-time/monotonic-clock.any.js:
- web-platform-tests/hr-time/performance-tojson-expected.txt: Added.
- web-platform-tests/hr-time/performance-tojson.html: Added.
- web-platform-tests/hr-time/resources/unload-a.html: Added.
- web-platform-tests/hr-time/resources/unload-b.html: Added.
- web-platform-tests/hr-time/resources/unload-c.html: Added.
- web-platform-tests/hr-time/resources/unload.js: Added.
- web-platform-tests/hr-time/resources/w3c-import.log:
- web-platform-tests/hr-time/timeOrigin-expected.txt:
- web-platform-tests/hr-time/w3c-import.log:
- web-platform-tests/hr-time/window-worker-timeOrigin.window-expected.txt: Added.
- web-platform-tests/hr-time/window-worker-timeOrigin.window.html: Added.
LayoutTests:
- platform/ios/TestExpectations:
- platform/mac/TestExpectations:
Update paths in expectations.
- 7:48 AM Changeset in webkit [267313] by
-
- 8 edits2 adds in trunk
Selection API: Extend lifetime of selection live range to preserve expando properties
https://bugs.webkit.org/show_bug.cgi?id=216721
Reviewed by Ryosuke Niwa.
Source/WebCore:
Test: editing/selection/expando.html
- dom/Range.cpp:
(WebCore::Range::window): Added. Returns window if range is associated with selection.
- dom/Range.h: Added window.
- dom/Range.idl: Added GenerateIsReachable=ReachableFromDOMWindow.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::disassociateLiveRange): Removed a FIXME comment about the
need for this fix.
(WebCore::FrameSelection::updateAssociatedLiveRange): Added a comment explaining
why an associated live range might not be contained in the document.
LayoutTests:
- editing/selection/expando-expected.txt: Added.
- editing/selection/expando.html: Added.
- TestExpectations: Skip the new test since DumpRenderTree doesn't support enabling
internal properties.
- platform/wk2/TestExpectations: Unskip the new test since WebKitTestRunner does.
- 7:22 AM Changeset in webkit [267312] by
-
- 8 edits3 adds in trunk/Source/WebCore
Add support for Settings equivilent of RuntimeConditionallyReadWrite
https://bugs.webkit.org/show_bug.cgi?id=216697
Reviewed by Darin Adler.
Adds a new extended attribute, [SettingsConditionallyReadWrite] to allow users of
[RuntimeConditionallyReadWrite] to convert from RuntimeEnabledFeatures to Settings.
- bindings/scripts/CodeGeneratorJS.pm:
(NeedsRuntimeReadWriteCheck):
(GeneratePropertiesHashTable):
(GenerateRuntimeEnableConditionalString):
(GenerateImplementation):
- bindings/scripts/IDLAttributes.json:
Adds new extended attribute.
- bindings/scripts/test/DOMWindowConstructors.idl:
- bindings/scripts/test/JS/JSDOMWindow.cpp:
- bindings/scripts/test/JS/JSTestConditionallyReadWrite.cpp: Added.
- bindings/scripts/test/JS/JSTestConditionallyReadWrite.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/SupplementalDependencies.dep:
- bindings/scripts/test/TestConditionallyReadWrite.idl: Added.
- bindings/scripts/test/TestObj.idl:
Move conditionally read-write tests to a new test, TestConditionallyReadWrite.idl and
update results.
- 7:20 AM Changeset in webkit [267311] by
-
- 7 edits in trunk/Source
Remove runtime setting for enabling/disabling the CrossOriginResourcePolicy API
https://bugs.webkit.org/show_bug.cgi?id=216561
Reviewed by Darin Adler.
Remove runtime setting for enabling/disabling CrossOriginResourcePolicy. It has been
enabled by default for a while and there are no known reasons one would need to
disable it.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCrossOriginResourcePolicyEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::crossOriginResourcePolicyEnabled const): Deleted.
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetCrossOriginResourcePolicyEnabled):
(WKPreferencesGetCrossOriginResourcePolicyEnabled):
- UIProcess/API/C/WKPreferencesRef.h:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
- 5:54 AM Changeset in webkit [267310] by
-
- 7 edits in trunk/Source/WebCore
ASSERTION FAILED: &formattingContextRoot == m_rootContainer.get() in WebCore::Layout::LayoutState::establishedInlineFormattingState
https://bugs.webkit.org/show_bug.cgi?id=216668
Reviewed by Zalan Bujtas.
Display::View didn't unparent the GraphicsLayers when Document::documentWillBecomeInactive() was called,
so a layer pointing to an old LayoutState would try to paint.
Fix by plumbing setIsInWindow() through to Display::View and using it to detach the root layer.
- dom/Document.cpp:
(WebCore::Document::documentWillBecomeInactive): The ASSERT_IMPLIES() is there to ensure that this isn't
a behavior change; we used to go to RenderView directly, and now go via FrameView.
- layout/display/DisplayLayerController.cpp:
(WebCore::Display::LayerController::detachRootLayer):
(WebCore::Display::LayerController::setIsInWindow):
- layout/display/DisplayLayerController.h:
- layout/display/DisplayView.cpp:
(WebCore::Display::View::setIsInWindow):
- layout/display/DisplayView.h:
- page/FrameView.cpp:
(WebCore::FrameView::setIsInWindow):
Sep 18, 2020:
- 11:42 PM Changeset in webkit [267309] by
-
- 2 edits in trunk/Tools
[GTK] API test /webkit/WebKitWebView/usermedia-enumeratedevices-permission-check is crashing
- TestWebKitAPI/glib/TestExpectations.json:
- 7:52 PM Changeset in webkit [267308] by
-
- 18 edits1 add in trunk/Source/WebCore
[LFC][IFC] Do not use Display::Line geometry in layout
https://bugs.webkit.org/show_bug.cgi?id=216711
Reviewed by Simon Fraser.
This patch introduces Layout::LineGeometry.
LineGeometry is used to hold the logical geometry of line and it is input to subsequent layouts.
This patch is also in preparation for moving out the "displayInlineItem" construction from Layout::InlineFormattingContext.
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::contentHeightForFormattingContextRoot const):
- layout/Verification.cpp:
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- layout/blockformatting/BlockMarginCollapse.cpp:
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginsCollapseThrough const):
- layout/displaytree/DisplayLine.h:
(WebCore::Display::Line::rect const):
(WebCore::Display::Line::scrollableOverflow const):
(WebCore::Display::Line::inkOverflow const):
(WebCore::Display::Line::baseline const):
(WebCore::Display::Line::Line):
(WebCore::Display::Line::left const): Deleted.
(WebCore::Display::Line::right const): Deleted.
(WebCore::Display::Line::top const): Deleted.
(WebCore::Display::Line::bottom const): Deleted.
(WebCore::Display::Line::width const): Deleted.
(WebCore::Display::Line::height const): Deleted.
(WebCore::Display::Line::moveVertically): Deleted.
- layout/displaytree/DisplayPainter.cpp:
(WebCore::Display::paintInlineContent):
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::lineLayout):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::invalidateFormattingState):
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):
- layout/inlineformatting/InlineFormattingState.h:
(WebCore::Layout::InlineFormattingState::lines const):
(WebCore::Layout::InlineFormattingState::lines):
(WebCore::Layout::InlineFormattingState::addLine):
(WebCore::Layout::InlineFormattingState::clearLineAndRuns):
(WebCore::Layout::InlineFormattingState::shrinkDisplayInlineContent):
(WebCore::Layout::InlineFormattingState::clearDisplayInlineContent): Deleted.
- layout/inlineformatting/InlineLineBuilder.cpp:
- layout/inlineformatting/InlineLineBuilder.h:
- layout/inlineformatting/InlineLineGeometry.h: Added.
(WebCore::Layout::InlineLineGeometry::logicalLeft const):
(WebCore::Layout::InlineLineGeometry::logicalRight const):
(WebCore::Layout::InlineLineGeometry::logicalTop const):
(WebCore::Layout::InlineLineGeometry::logicalBottom const):
(WebCore::Layout::InlineLineGeometry::logicalWidth const):
(WebCore::Layout::InlineLineGeometry::logicalHeight const):
(WebCore::Layout::InlineLineGeometry::logicalRect const):
(WebCore::Layout::InlineLineGeometry::lineBoxLogicalRect const):
(WebCore::Layout::InlineLineGeometry::baseline const):
(WebCore::Layout::InlineLineGeometry::moveVertically):
(WebCore::Layout::InlineLineGeometry::InlineLineGeometry):
- layout/inlineformatting/InlineTextItem.h:
- layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::contentLogicalHeight const):
(WebCore::LayoutIntegration::LineLayout::lineCount const):
(WebCore::LayoutIntegration::LineLayout::firstLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::lastLineBaseline const):
(WebCore::LayoutIntegration::LineLayout::paint):
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputInlineRuns):
- layout/tableformatting/TableFormattingContext.cpp:
(WebCore::Layout::TableFormattingContext::setUsedGeometryForCells):
- layout/tableformatting/TableFormattingContextGeometry.cpp:
(WebCore::Layout::TableFormattingContext::Geometry::usedBaselineForCell):
- 7:20 PM Changeset in webkit [267307] by
-
- 5 edits4 copies12 moves110 adds22 deletes in trunk/LayoutTests
Import remaining webaudio layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216719
Reviewed by Darin Adler.
Import remaining webaudio tests from Blink that we had not imported yet.
- TestExpectations:
- webaudio/BiquadFilter/biquad-829349-expected.txt: Added.
- webaudio/BiquadFilter/biquad-829349.html: Added.
- webaudio/BiquadFilter/tail-time-allpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-allpass.html: Added.
- webaudio/BiquadFilter/tail-time-bandpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-bandpass.html: Added.
- webaudio/BiquadFilter/tail-time-highpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-highpass.html: Added.
- webaudio/BiquadFilter/tail-time-highshelf-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-highshelf.html: Added.
- webaudio/BiquadFilter/tail-time-lowpass-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-lowpass.html: Added.
- webaudio/BiquadFilter/tail-time-lowshelf-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-lowshelf.html: Added.
- webaudio/BiquadFilter/tail-time-notch-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-notch.html: Added.
- webaudio/BiquadFilter/tail-time-peaking-expected.txt: Added.
- webaudio/BiquadFilter/tail-time-peaking.html: Added.
- webaudio/BiquadFilter/test-tail-time.js: Added.
(testTailTime):
- webaudio/BiquadFilter/unstable-filter-warning-expected.txt: Added.
- webaudio/BiquadFilter/unstable-filter-warning.html: Added.
- webaudio/ChannelMerger/audiochannelmerger-cycle-expected.txt: Added.
- webaudio/ChannelMerger/audiochannelmerger-cycle.html: Added.
- webaudio/Convolver/unmmodified-buffer-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/Convolver/unmmodified-buffer.html: Renamed from LayoutTests/webaudio/convolvernode-unmodified-buffer.html.
- webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state-expected.txt: Added.
- webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state.html: Added.
- webaudio/DynamicsCompressor/dynamicscompressor-simple-expected.txt: Added.
- webaudio/DynamicsCompressor/dynamicscompressor-simple.html: Added.
- webaudio/IIRFilter/iir-tail-time-expected.txt: Added.
- webaudio/IIRFilter/iir-tail-time.html: Added.
- webaudio/IIRFilter/iir-unstable-expected.txt: Added.
- webaudio/IIRFilter/iir-unstable.html: Added.
- webaudio/IIRFilter/unstable-filter-warning-expected.txt: Added.
- webaudio/IIRFilter/unstable-filter-warning.html: Added.
- webaudio/MediaElementAudioSource/mediaelementaudiosourcenode-expected.txt: Added.
- webaudio/MediaElementAudioSource/mediaelementaudiosourcenode.html: Added.
- webaudio/MediaElementAudioSource/resampling-crash-expected.txt: Added.
- webaudio/MediaElementAudioSource/resampling-crash.html: Added.
- webaudio/MediaStreamAudioDestination/create-in-destroyed-context-expected.txt: Added.
- webaudio/MediaStreamAudioDestination/create-in-destroyed-context.html: Added.
- webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode-expected.txt: Added.
- webaudio/MediaStreamAudioDestination/mediastreamaudiodestinationnode.html: Added.
- webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource-expected.txt: Added.
- webaudio/MediaStreamAudioSource/ctor-mediastreamaudiosource.html: Added.
- webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode-expected.txt: Added.
- webaudio/MediaStreamAudioSource/mediastreamaudiosourcenode.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-constructor-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-constructor.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-event-listener-gc.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise-basic.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-promise.html: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-basic.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-basic.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-eventhandler.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-eventhandler.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-graph-manipulation.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-graph-manipulation.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-promise.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-promise.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence-expected.txt: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence-expected.txt.
- webaudio/OfflineAudioContext/offlineaudiocontext-suspend-resume-sequence.html: Renamed from LayoutTests/webaudio/offlineaudiocontext-suspend-resume-sequence.html.
- webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test-expected.txt: Added.
- webaudio/OfflineAudioContext/offlineaudiocontext-thread-smoke-test.html: Added.
- webaudio/OfflineAudioContext/onstatechange-expected.txt: Added.
- webaudio/OfflineAudioContext/onstatechange.html: Added.
- webaudio/Panner/hrtf-database-expected.txt: Added.
- webaudio/Panner/hrtf-database.html: Added.
- webaudio/Panner/panner-loop-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/Panner/panner-loop.html: Added.
- webaudio/Panner/panner-set-position-expected.txt: Added.
- webaudio/Panner/panner-set-position.html: Added.
- webaudio/PeriodicWave/ctor-periodicwave-expected.txt: Added.
- webaudio/PeriodicWave/ctor-periodicwave.html: Added.
- webaudio/PeriodicWave/periodicwave-contexts-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-contexts.html: Added.
- webaudio/PeriodicWave/periodicwave-exceptions-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-exceptions.html: Added.
- webaudio/PeriodicWave/periodicwave-lengths-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-lengths.html: Added.
- webaudio/PeriodicWave/periodicwave-normalization-expected.txt: Added.
- webaudio/PeriodicWave/periodicwave-normalization.html: Added.
- webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessor-offlineaudiocontext.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-0-output-channels-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-0-output-channels.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-downmix8-2channel-input.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-upmix2-8channel-input.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels-expected.txt: Added.
- webaudio/ScriptProcessor/scriptprocessornode-zero-input-channels.html: Added.
- webaudio/ScriptProcessor/scriptprocessornode.html: Added.
- webaudio/WaveShaper/waveshaper-364379-expected.txt: Added.
- webaudio/WaveShaper/waveshaper-364379.html: Added.
- webaudio/WaveShaper/waveshaper-oversample-2x-expected.txt: Copied from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/WaveShaper/waveshaper-oversample-2x.html: Added.
- webaudio/WaveShaper/waveshaper-oversample-4x-expected.txt: Renamed from LayoutTests/webaudio/convolvernode-unmodified-buffer-expected.txt.
- webaudio/WaveShaper/waveshaper-oversample-4x.html: Added.
- webaudio/audio-scheduled-source-basic-expected.txt: Added.
- webaudio/audio-scheduled-source-basic.html: Added.
- webaudio/javascriptaudionode-downmix8-2channel-input-expected.txt: Removed.
- webaudio/javascriptaudionode-downmix8-2channel-input.html: Removed.
- webaudio/javascriptaudionode-expected.txt: Removed.
- webaudio/javascriptaudionode-upmix2-8channel-input-expected.txt: Removed.
- webaudio/javascriptaudionode-upmix2-8channel-input.html: Removed.
- webaudio/javascriptaudionode-zero-input-channels-expected.txt: Removed.
- webaudio/javascriptaudionode-zero-input-channels.html: Removed.
- webaudio/javascriptaudionode.html: Removed.
- webaudio/mediastreamaudiodestinationnode-expected.txt: Removed.
- webaudio/mediastreamaudiodestinationnode.html: Removed.
- webaudio/mediastreamaudiosourcenode-expected.txt: Removed.
- webaudio/mediastreamaudiosourcenode.html: Removed.
- webaudio/offlineaudiocontext-constructor-expected.txt: Removed.
- webaudio/offlineaudiocontext-constructor.html: Removed.
- webaudio/panner-loop-expected.txt: Removed.
- webaudio/panner-loop.html: Removed.
- webaudio/periodicwave-lengths-expected.txt: Removed.
- webaudio/periodicwave-lengths.html: Removed.
- webaudio/resources/audionodeoptions.js: Added.
(testAudioNodeOptions):
(initializeContext):
(testInvalidConstructor):
(testDefaultConstructor):
(testDefaultAttributes):
- webaudio/resources/biquad-filters.js: Added.
(createLowpassFilter):
(createHighpassFilter):
(normalizeFilterCoefficients):
(createBandpassFilter):
(createLowShelfFilter):
(createHighShelfFilter):
(createPeakingFilter):
(createNotchFilter):
(createAllpassFilter):
(filterData):
(createFilter):
- webaudio/resources/hrtf/Composite.flac: Added.
- webaudio/resources/hrtf/Composite.wav: Added.
- webaudio/resources/hrtf/README: Added.
- webaudio/resources/scriptprocessornode-testing-audit.js: Added.
(createBuffer):
(processAudioData):
(fillData):
(checkStereoOnlyData):
(runJSNodeTest):
- webaudio/resources/scriptprocessornode-testing.js: Added.
(createBuffer):
(processAudioData):
(fillData):
(checkStereoOnlyData):
(runJSNodeTest):
- webaudio/resources/waveshaper-testing.js:
(T0):
(T1):
(T2):
(T3):
(T4):
(generateWaveShapingCurve):
(checkShapedCurve):
(createImpulseBuffer):
(runWaveShaperOversamplingTest):
- webaudio/waveshaper-oversample-2x-expected.txt: Removed.
- webaudio/waveshaper-oversample-2x.html: Removed.
- webaudio/waveshaper-oversample-4x-expected.txt: Removed.
- webaudio/waveshaper-oversample-4x.html: Removed.
- 7:19 PM Changeset in webkit [267306] by
-
- 6 edits in trunk
[JSC] Generator declaration should not be allowed in single statement context
https://bugs.webkit.org/show_bug.cgi?id=216720
Reviewed by Ross Kirsling.
JSTests:
- stress/generator-syntax.js:
(testSyntaxError.gen):
- test262/expectations.yaml:
Source/JavaScriptCore:
Generator declaration in single statement context (like the following code) should be syntax error.
We already made async function / async generator function syntax error. We should apply the same rule
to generator declaration too.
if (false)
function * gen() { }
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFunctionDeclarationStatement):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseExportDeclaration):
- parser/Parser.h:
- 6:34 PM Changeset in webkit [267305] by
-
- 4 edits in trunk
[macOS] REGRESSION (r265702): System Services receive 0 bytes when extracting selected content as rich text data
https://bugs.webkit.org/show_bug.cgi?id=216718
<rdar://problem/69150358>
Reviewed by Tim Horton.
Source/WebKit:
Test: CopyHTML.WriteRichTextSelectionToPasteboard
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
After r265702, the
IPCHandlereceived in the UI process was always being converted into a buffer of size 0,
due to using thesizelocal variable (which is no longer set as an outparam of the sync IPC message). Instead,
useipcHandle.dataSize.
Tools:
Add a new API test to verify that we get non-empty web archive data when using
-writeSelectionToPasteboard:types:to grab selected content as rich text data.
- TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
- 6:22 PM Changeset in webkit [267304] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] PreciseAllocation's isNewlyAllocated flag should be propagated from isMarked at GC begin phase to make isLive correct
https://bugs.webkit.org/show_bug.cgi?id=216717
Reviewed by Mark Lam.
When starting full GC, at beginMarking, PreciseAllocation's mark bit is cleared to be usable for upcoming marking.
However, this means that HeapCell::isLive will see this object as dead until it is marked.
Let's consider that this object is not newly allocated one. Then, its isNewlyAllocated is false. And now mark bit
is also cleared. Since PreciseAllocation::isLive is isNewlyAllocated isMarked, then it looks dead, while it is live. This confuses HeapCell:isLive function and makes some of watchpoints perform wrong decisions (e.g. this condition is
no longer valid, let's just discard it).
At the beginning of full collection, we should propagate the old mark bit to isNewlyAllocated so that it looks live
during marking. This is similar trick to MarkedBlock::aboutToMark.
- heap/PreciseAllocation.cpp:
(JSC::PreciseAllocation::flip):
- 5:40 PM Changeset in webkit [267303] by
-
- 2 edits in trunk/Source/WebCore
[LFC][FFC] Add flex box/item to showLayoutTree
https://bugs.webkit.org/show_bug.cgi?id=216694
Reviewed by Sam Weinig.
- layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::outputLayoutBox): 'Table principal' -> 'Table wrapper box' for consistency sake.
- 5:40 PM Changeset in webkit [267302] by
-
- 1 copy in tags/Safari-610.2.6.1.2
Tag Safari-610.2.6.1.2.
- 5:27 PM Changeset in webkit [267301] by
-
- 9 edits2 adds in trunk
console APIs shouldn't crash making a string that's too long for a console warning when using user provided labels
https://bugs.webkit.org/show_bug.cgi?id=216709
<rdar://problem/68275357>
Reviewed by Mark Lam and Devin Rousso.
Source/JavaScriptCore:
Various console APIs send warnings when a label can't be found. These warnings
include the label itself. If this label has a long enough length, when we make
these warning strings, we can crash, because we exceed max string length.
This patch fixes this by truncating the label everywhere it's used if it
exceeds a length of 10000.
- inspector/JSGlobalObjectConsoleClient.cpp:
(Inspector::JSGlobalObjectConsoleClient::profile):
- inspector/ScriptArguments.h:
- inspector/agents/InspectorConsoleAgent.cpp:
(Inspector::InspectorConsoleAgent::startTiming):
(Inspector::InspectorConsoleAgent::logTiming):
(Inspector::InspectorConsoleAgent::stopTiming):
(Inspector::InspectorConsoleAgent::count):
(Inspector::InspectorConsoleAgent::countReset):
Source/WebCore:
Test: inspector/console/console-oom.html
- inspector/agents/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
- inspector/agents/WebConsoleAgent.cpp:
(WebCore::WebConsoleAgent::didReceiveResponse):
LayoutTests:
- TestExpectations:
- inspector/console/console-oom-expected.txt: Added.
- inspector/console/console-oom.html: Added.
- 5:17 PM Changeset in webkit [267300] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.2
- 4:29 PM Changeset in webkit [267299] by
-
- 1 copy in tags/Safari-610.2.6.1.1
Tag Safari-610.2.6.1.1.
- 4:20 PM Changeset in webkit [267298] by
-
- 2 edits in trunk/Source/WebKit
Remove unneeded respondsToSelector staging for keyboard.
https://bugs.webkit.org/show_bug.cgi?id=216421
Staging needed for dual work in UIKit in 2019, no longer needed.
Reviewed by Tim Horton.
No behavior change, covered by existing tests.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView insertText:]):
(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
- 4:18 PM Changeset in webkit [267297] by
-
- 5 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266797. rdar://problem/68732167
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195
Reviewed by Simon Fraser.
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.
After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.
Source/WebCore:
- platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
- platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):
Source/WebKit:
- UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
- UIProcess/mac/DisplayLink.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267296] by
-
- 9 edits in branches/safari-610.2.6.1-branch/Source/WebKit
Cherry-pick r266771. rdar://problem/68732073
Regression(r260614) Power usage has increased due to extra thread hopping
https://bugs.webkit.org/show_bug.cgi?id=216296
<rdar://problem/67719299>
Reviewed by Simon Fraser.
Power usage has increased after r260614 due to extra thread hopping. To recover,
we now process the DisplayWasRefreshed IPC to a background queue if there is
scrolling going on and responsiveness is thus critical. In the common case, where
the user is not scrolling, we keep processing the IPC on the main thread, like
before r260614. This avoids extra thread hopping and saves power.
- UIProcess/WebPageProxy.cpp: (WebKit::ScrollingObserver::willSendWheelEvent): (WebKit::ScrollingObserver::ScrollingObserver): (WebKit::ScrollingObserver::singleton): (WebKit::WebPageProxy::sendWheelEvent):
- UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::displayLinkCallback):
- UIProcess/mac/DisplayLink.h: (WebKit::DisplayLink::setShouldSendIPCOnBackgroundQueue):
- WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::notifyScrollingTreesDisplayWasRefreshed): (WebKit::EventDispatcher::displayWasRefreshed):
- WebProcess/WebPage/EventDispatcher.h:
- WebProcess/WebProcess.cpp: (WebKit::WebProcess::displayWasRefreshed):
- WebProcess/WebProcess.h:
- WebProcess/WebProcess.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267295] by
-
- 6 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266710. rdar://problem/68732167
Unreviewed, reverting r266645.
https://bugs.webkit.org/show_bug.cgi?id=216251
Caused MotionMark regression
Reverted changeset:
"Move lazy DisplayLink tear down logic from the WebProcess to
the UIProcess"
https://bugs.webkit.org/show_bug.cgi?id=216195
https://trac.webkit.org/changeset/266645
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267294] by
-
- 6 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266645. rdar://problem/68732167
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=216195
Reviewed by Simon Fraser.
Move lazy DisplayLink tear down logic from the WebProcess to the UIProcess, now that the
DisplayLink has been moved to the UIProcess due to sandboxing.
After a DisplayLink no longer has any clients, we keep it firing up to 20 times without
any clients in case a new client gets added shortly after. The idea was to avoid killing
and respawning too many threads when adding and removing clients in quick succession.
However, now that the DisplayLink lives in the UIProcess side and sends IPC to the
WebProcesses every time it fires, it makes a lot more sense to implement this logic in
the UIProcess side, to avoid sending unnecessary IPC to processes that do not care about
it.
Source/WebCore:
- platform/graphics/DisplayRefreshMonitor.cpp: (WebCore::DisplayRefreshMonitor::displayDidRefresh):
- platform/graphics/DisplayRefreshMonitor.h: (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):
Source/WebKit:
- UIProcess/mac/DisplayLink.cpp: (WebKit::DisplayLink::addObserver): (WebKit::DisplayLink::removeObserver): (WebKit::DisplayLink::removeObservers): (WebKit::DisplayLink::displayLinkCallback): (WebKit::DisplayLink::hasObservers const): Deleted.
- UIProcess/mac/DisplayLink.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267293] by
-
- 9 edits in branches/safari-610.2.6.1-branch/Source/WebKit
Revert r266771. rdar://problem/68732073
- 4:18 PM Changeset in webkit [267292] by
-
- 5 edits in branches/safari-610.2.6.1-branch/Source
Revert r266797. rdar://problem/68732167
- 4:18 PM Changeset in webkit [267291] by
-
- 26 edits1 copy3 adds in branches/safari-610.2.6.1-branch
Cherry-pick r266846. rdar://problem/68740516
Don't create event regions when the page has no subscrollers
https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/scrolling/mac/event-region-subscroller-frame.html
fast/scrolling/mac/event-region-subscroller-overflow.html
Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
- page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):
Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):
Don't maintain event region if there are no subscrollers and none of the other reasons were hit.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):
Invalidate event regions if a subscroller appears.
(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Add overflow scrollers to some existing tests so they still generate event regions.
- fast/scrolling/ios/border-radius-event-region-expected.txt:
- fast/scrolling/ios/border-radius-event-region.html:
- fast/scrolling/ios/event-region-float-expected.txt:
- fast/scrolling/ios/event-region-float.html:
- fast/scrolling/ios/event-region-pointer-events-expected.txt:
- fast/scrolling/ios/event-region-pointer-events.html:
- fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-scale-transform-shared.html:
- fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-translate-transform-shared.html:
- fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
- fast/scrolling/ios/event-region-visibility-hidden.html:
- fast/scrolling/mac/border-radius-event-region-expected.txt:
- fast/scrolling/mac/border-radius-event-region.html:
- fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-frame.html: Added.
- fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
- fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
- fast/scrolling/mac/event-region-visibility-hidden.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267290] by
-
- 10 edits in branches/safari-610.2.6.1-branch/Source
Cherry-pick r266677. rdar://problem/68740526
[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
https://bugs.webkit.org/show_bug.cgi?id=216190
Reviewed by Darin Adler.
Source/WebCore:
In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContentsdue to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time viaMonotonicTime::now().
We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable onPage. See below for more details, as well as
the WebKit2 ChangeLog.
- page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):
Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.
- page/Page.cpp: (WebCore::Page::updateRendering):
Update
m_lastRenderingUpdateTimestamp.
- page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
- rendering/PaintFrequencyTracker.h:
Drive-by cleanup: narrow the
PaintFrequencyenum toboolwidth.
(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):
Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.
(WebCore::RenderLayer::simulateFrequentPaint):
- rendering/RenderLayer.h:
Source/WebKit:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):
In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).
Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions inSinglePaintFrequencyTracking::end(). As such, we
stick withMonotonicTime::now()in WebKit1.
- WebProcess/WebCoreSupport/WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 4:18 PM Changeset in webkit [267289] by
-
- 4 edits in branches/safari-610.2.6.1-branch
Cherry-pick r266232. rdar://problem/68732143
Step animations invalidate style on every rendering update whether or not they need to
https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>
Reviewed by Antoine Quint.
Source/WebCore:
Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
- animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):
Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.
LayoutTests:
- animations/steps-transform-rendering-updates-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:54 PM Changeset in webkit [267288] by
-
- 180 edits in trunk/Source
[WebGPU] Add ENABLE(WHLSL_COMPILER) guard
https://bugs.webkit.org/show_bug.cgi?id=216713
Reviewed by Myles C. Maxfield.
Source/WebCore:
Replaces the ENABLE(WEBGPU) guards in the Modules/webgpu/WHLSL with ENABLE(WHLSL_COMPILER)
since not all ports need a WHLSL compiler to support WebGPU.
- Modules/webgpu/WHLSL/AST/WHLSLAST.h:
- Modules/webgpu/WHLSL/AST/WHLSLAddressEscapeMode.h:
- Modules/webgpu/WHLSL/AST/WHLSLAddressSpace.h:
- Modules/webgpu/WHLSL/AST/WHLSLArrayReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLArrayType.h:
- Modules/webgpu/WHLSL/AST/WHLSLAssignmentExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLBaseFunctionAttribute.h:
- Modules/webgpu/WHLSL/AST/WHLSLBaseSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLBlock.h:
- Modules/webgpu/WHLSL/AST/WHLSLBooleanLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLBreak.h:
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLBuiltInSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLCallExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLCommaExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLConstantExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLContinue.h:
- Modules/webgpu/WHLSL/AST/WHLSLDefaultDelete.h:
- Modules/webgpu/WHLSL/AST/WHLSLDereferenceExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLDoWhileLoop.h:
- Modules/webgpu/WHLSL/AST/WHLSLDotExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLEffectfulExpressionStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLEntryPointType.h:
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationMember.h:
- Modules/webgpu/WHLSL/AST/WHLSLEnumerationMemberLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLExpression.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLFallthrough.h:
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLFloatLiteralType.h:
- Modules/webgpu/WHLSL/AST/WHLSLForLoop.h:
- Modules/webgpu/WHLSL/AST/WHLSLFunctionAttribute.h:
- Modules/webgpu/WHLSL/AST/WHLSLFunctionDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLFunctionDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLGlobalVariableReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLIfStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLIndexExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLIntegerLiteralType.h:
- Modules/webgpu/WHLSL/AST/WHLSLLogicalExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLLogicalNotExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLMakeArrayReferenceExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLMakePointerExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLNameSpace.h:
- Modules/webgpu/WHLSL/AST/WHLSLNamedType.h:
- Modules/webgpu/WHLSL/AST/WHLSLNativeFunctionDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLNativeTypeDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLNumThreadsFunctionAttribute.h:
- Modules/webgpu/WHLSL/AST/WHLSLPointerType.h:
- Modules/webgpu/WHLSL/AST/WHLSLPropertyAccessExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLQualifier.h:
- Modules/webgpu/WHLSL/AST/WHLSLReadModifyWriteExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLReferenceType.h:
- Modules/webgpu/WHLSL/AST/WHLSLReplaceWith.h:
- Modules/webgpu/WHLSL/AST/WHLSLResolvableType.h:
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLResourceSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLReturn.h:
- Modules/webgpu/WHLSL/AST/WHLSLSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLSpecializationConstantSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLStageInOutSemantic.h:
- Modules/webgpu/WHLSL/AST/WHLSLStatement.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLStatementList.h:
- Modules/webgpu/WHLSL/AST/WHLSLStructureDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLStructureElement.h:
- Modules/webgpu/WHLSL/AST/WHLSLSwitchCase.h:
- Modules/webgpu/WHLSL/AST/WHLSLSwitchStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLTernaryExpression.h:
- Modules/webgpu/WHLSL/AST/WHLSLType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLType.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLTypeArgument.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeDefinition.h:
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLTypeReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedType.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnnamedTypeHash.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteral.h:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.cpp:
- Modules/webgpu/WHLSL/AST/WHLSLUnsignedIntegerLiteralType.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclaration.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableDeclarationsStatement.h:
- Modules/webgpu/WHLSL/AST/WHLSLVariableReference.h:
- Modules/webgpu/WHLSL/AST/WHLSLWhileLoop.h:
- Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLEntryPointScaffolding.h:
- Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.h:
- Modules/webgpu/WHLSL/Metal/WHLSLMangledNames.h:
- Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLMetalCodeGenerator.h:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeFunctionWriter.h:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLNativeTypeWriter.h:
- Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.h:
- Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.cpp:
- Modules/webgpu/WHLSL/Metal/WHLSLVertexBufferIndexCalculator.h:
- Modules/webgpu/WHLSL/WHLSLASTDumper.cpp:
- Modules/webgpu/WHLSL/WHLSLASTDumper.h:
- Modules/webgpu/WHLSL/WHLSLBuildStandardLibraryFunctionMap.py:
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLCheckDuplicateFunctions.h:
- Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp:
- Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.h:
- Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.cpp:
- Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.h:
- Modules/webgpu/WHLSL/WHLSLChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLChecker.h:
- Modules/webgpu/WHLSL/WHLSLCodeLocation.h:
- Modules/webgpu/WHLSL/WHLSLComputeDimensions.cpp:
- Modules/webgpu/WHLSL/WHLSLComputeDimensions.h:
- Modules/webgpu/WHLSL/WHLSLError.h:
- Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLFunctionStageChecker.h:
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp:
- Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.h:
- Modules/webgpu/WHLSL/WHLSLHighZombieFinder.cpp:
- Modules/webgpu/WHLSL/WHLSLHighZombieFinder.h:
- Modules/webgpu/WHLSL/WHLSLInferTypes.cpp:
- Modules/webgpu/WHLSL/WHLSLInferTypes.h:
- Modules/webgpu/WHLSL/WHLSLIntrinsics.cpp:
- Modules/webgpu/WHLSL/WHLSLIntrinsics.h:
- Modules/webgpu/WHLSL/WHLSLLexer.cpp:
- Modules/webgpu/WHLSL/WHLSLLexer.h:
- Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLLiteralTypeChecker.h:
- Modules/webgpu/WHLSL/WHLSLNameContext.cpp:
- Modules/webgpu/WHLSL/WHLSLNameContext.h:
- Modules/webgpu/WHLSL/WHLSLNameResolver.cpp:
- Modules/webgpu/WHLSL/WHLSLNameResolver.h:
- Modules/webgpu/WHLSL/WHLSLParser.cpp:
- Modules/webgpu/WHLSL/WHLSLParser.h:
- Modules/webgpu/WHLSL/WHLSLParsingMode.h:
- Modules/webgpu/WHLSL/WHLSLPipelineDescriptor.h:
- Modules/webgpu/WHLSL/WHLSLPrepare.cpp:
- Modules/webgpu/WHLSL/WHLSLPrepare.h:
- Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.cpp:
- Modules/webgpu/WHLSL/WHLSLPreserveVariableLifetimes.h:
- Modules/webgpu/WHLSL/WHLSLProgram.cpp:
- Modules/webgpu/WHLSL/WHLSLProgram.h:
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.cpp:
- Modules/webgpu/WHLSL/WHLSLPropertyResolver.h:
- Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.h:
- Modules/webgpu/WHLSL/WHLSLRecursionChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLRecursionChecker.h:
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLRecursiveTypeChecker.h:
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.cpp:
- Modules/webgpu/WHLSL/WHLSLResolveOverloadImpl.h:
- Modules/webgpu/WHLSL/WHLSLResolvingType.h:
- Modules/webgpu/WHLSL/WHLSLScopedSetAdder.h:
- Modules/webgpu/WHLSL/WHLSLSemanticMatcher.cpp:
- Modules/webgpu/WHLSL/WHLSLSemanticMatcher.h:
- Modules/webgpu/WHLSL/WHLSLStandardLibraryFunctionMap.h:
- Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.cpp:
- Modules/webgpu/WHLSL/WHLSLStandardLibraryUtilities.h:
- Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp:
- Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.h:
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeConstructors.h:
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.cpp:
- Modules/webgpu/WHLSL/WHLSLSynthesizeEnumerationFunctions.h:
- Modules/webgpu/WHLSL/WHLSLVisitor.cpp:
- Modules/webgpu/WHLSL/WHLSLVisitor.h:
Source/WTF:
Adds a default for ENABLE_WHLSL_COMPILER on Cocoa platforms.
- wtf/PlatformEnable.h:
- wtf/PlatformEnableCocoa.h:
- 3:50 PM Changeset in webkit [267287] by
-
- 2 edits in trunk/Source/WebCore
Crash under WebCore::shouldResetFocusNavigationStartingNode()
https://bugs.webkit.org/show_bug.cgi?id=216714
<rdar://problem/68132047>
Reviewed by Darin Adler.
Protect anchorElement in FrameView::scrollToFragmentInternal() to make sure
it stays alive until the time we pass it to setFocusNavigationStartingNode().
- page/FrameView.cpp:
(WebCore::FrameView::scrollToFragmentInternal):
- 3:27 PM Changeset in webkit [267286] by
-
- 2 edits in branches/safari-610-branch/Source/WebKit
Cherry-pick r267208. rdar://problem/69178138
Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0
https://bugs.webkit.org/show_bug.cgi?id=216655
<rdar://problem/69081227>
Reviewed by Brent Fulgham.
Apps with the full browser entitlement who are not linked to iOS 14.0
should have ITP enabled in WKWebViews by default.
No new tests, no way currently to test apps with different iOS
versions. Tested manually.
- Shared/Cocoa/DefaultWebBrowserChecks.mm: (WebKit::determineITPStateInternal): Ignore the early return for the linked-on-or-after check if the app has the default browser entitlement so we still enable ITP based on the user's preference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:27 PM Changeset in webkit [267285] by
-
- 3 edits1 add in branches/safari-610-branch
Cherry-pick r266907. rdar://problem/69178126
[JSC] unshift / shift should take structure lock
https://bugs.webkit.org/show_bug.cgi?id=216378
<rdar://problem/68496096>
Reviewed by Mark Lam.
JSTests:
- stress/unshift-and-concurrent-access.js: Added.
Source/JavaScriptCore:
When unshifting / shifting butterfly, we need to move property storage values too.
If property storage values are moved while concurrent JIT compiler is accessing it, it could include garbage value.
For example, concurrent JIT compiler is accessing [2] property storage.
1 2 3
[ JSValue ][ JSValue ][ Header ]
But unshift moved it like this.
1 2 3
[ JSValue ][ JSValue ][ Header ]
Since butterfly pointer held by JSObject is not updated yet, concurrent JIT compiler will read [ Header ] as JSValue and crash.
In this patch, we take structure lock when shifting existing butterfly since this affect on property storage. Since JSObject::getDirectConcurrently
takes a structure lock, this locking prevents concurrent compilers from getting an invalid value.
- runtime/JSArray.cpp: (JSC::JSArray::unshiftCountSlowCase): (JSC::JSArray::shiftCountWithArrayStorage): (JSC::JSArray::unshiftCountWithArrayStorage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:25 PM Changeset in webkit [267284] by
-
- 9 edits in trunk
REGRESSION (r266634): fast/selectors/text-field-selection-stroke-color.html and fast/selectors/text-field-selection-window-inactive-stroke-color.html are flaky failures with pixel noise
https://bugs.webkit.org/show_bug.cgi?id=216394
<rdar://problem/68679551>
Reviewed by Tim Horton.
Source/WebKit:
In WebKitTestRunner, we reset the states and load about:blank page between tests. The resetting may cause some
activity state changes of web page, like WindowIsActive. Before r266634, these changes will be dispatched
quickly enough (before runloop waits or when runloop exits) to web process, so web process can do rendering with
updated activity state. After r266634, dispatch of the changes may be delayed (until CATransaction commits).
Page activity state can affect scrollability (in FrameView::computeScrollability()) and scrollability can affect
tiling size (in TileController::computeTileSize()). Different tilings may cause the tiny pixel difference we see
in the test results.
To fix this, create an SPI for sending out activity state updates in next runloop cycle and adopt it in WTR.
- UIProcess/API/C/WKPage.cpp:
(WKPageDispatchActivityStateUpdateForTesting):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::dispatchActivityStateUpdateForTesting):
- UIProcess/WebPageProxy.h:
Tools:
Make sure activity state changes for window updates in resetStateToConsistentValues are dispatched in time.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Update test expectations as tests should be passing.
- platform/mac-wk2/TestExpectations:
- 2:18 PM Changeset in webkit [267283] by
-
- 5 edits1 add in trunk
Date/time inputs should not use user-specified formats
https://bugs.webkit.org/show_bug.cgi?id=216484
<rdar://problem/68864815>
Reviewed by Wenson Hsieh.
Source/WebCore:
On macOS, users can specify custom date and time formats through System
Preferences. These formats can be different from the default for the
user’s current locale. Using these formats when rendering date and time
inputs is a potential fingerprinting vector, as sites can apply CSS to
components of the input, and measure the size of the input.
To fix, we create a new NSLocale even if the identifier matches
[NSLocale currentLocale]. This ensures that m_locale does not contain
the user's changes to the locale.
- platform/text/cocoa/LocaleCocoa.h:
- platform/text/cocoa/LocaleCocoa.mm:
(WebCore::Locale::create):
(WebCore::LocaleCocoa::LocaleCocoa):
Tools:
Added a test which sets a custom date format using "defaults write"
and verifies that the width is indistinguishable from the default
format.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/mac/DateInputTests.mm: Added.
(createWebViewForTest):
(DateInputsTests.IgnoresUserEditsToLocale):
- 1:50 PM Changeset in webkit [267282] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline test after r266816 changed wptserve output.
- web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing-expected.txt:
- 1:34 PM Changeset in webkit [267281] by
-
- 11 edits in trunk
[macOS] Date/time inputs should focus the next editable component when entering a separator key
https://bugs.webkit.org/show_bug.cgi?id=216661
<rdar://problem/69091856>
Reviewed by Wenson Hsieh.
Source/WebCore:
NSDatePicker focuses the next editable field when entering a separator
key. We should match this behavior to be consistent with the rest of
the system.
- html/shadow/DateTimeFieldElement.cpp:
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
Tools:
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::keyDown):
Add support for colon, semicolon, and comma keys. The keycode values are
taken from the virtual keycode values in HIToolbox/Events.h.
Note that the keycode for colon and semicolon is the same, as there is
no distinct value for colon. This is safe as it matches the Javascript
behavior.
LayoutTests:
Added new test cases to the existing set of keyboard tests for date/time inputs.
- fast/forms/date/date-editable-components/date-editable-components-keyboard-events-expected.txt:
- fast/forms/date/date-editable-components/date-editable-components-keyboard-events.html:
- fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events-expected.txt:
- fast/forms/datetimelocal/datetimelocal-editable-components/datetimelocal-editable-components-keyboard-events.html:
- fast/forms/time/time-editable-components/time-editable-components-keyboard-events-expected.txt:
- fast/forms/time/time-editable-components/time-editable-components-keyboard-events.html:
- 1:28 PM Changeset in webkit [267280] by
-
- 5 edits in trunk/JSTests
[ARMv7][MIPS] Test gaderning September version
https://bugs.webkit.org/show_bug.cgi?id=216699
Unreviewed test gardening.
- stress/array-species-create-should-handle-masquerader.js:
- stress/compare-eq-should-use-known-other-use.js:
- stress/ftl-reflect-get-prototype-of.js:
- stress/typedarray-access-neutered.js:
- 1:17 PM Changeset in webkit [267279] by
-
- 5 edits in trunk
WKWebView._tryClose should return whether it succeeded or not
https://bugs.webkit.org/show_bug.cgi?id=216660
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.
Source/WebKit:
The return value of WKPageTryClose is used by Safari.
In order to migrate to WKWebView _tryClose, we need to expose this return value.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _tryClose]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
(TEST):
- 1:15 PM Changeset in webkit [267278] by
-
- 2 edits in trunk/Tools
Make TLSVersion.NetworkSession API test more robust
https://bugs.webkit.org/show_bug.cgi?id=216704
<rdar://problem/68643674>
Patch by Alex Christensen <achristensen@webkit.org> on 2020-09-18
Reviewed by Tim Horton.
r265573 made preconnect attempts to legacy TLS servers fail.
This caused the TLSVersion.NetworkSession to assert because the first connection attempt would fail
(and the second would succeed if it was supposed to succeed with the conditions in the test).
The test calls waitForDidFailProvisionalNavigation in cases where it is supposed to fail and
waitForDidFinishNavigation in cases where it supposed to succeed.
Like I did in r266100 with another test, use HTTPServer which allows a variable number of connection attempts.
- TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
(TestWebKitAPI::TEST):
- 12:46 PM Changeset in webkit [267277] by
-
- 2 edits in trunk/Tools
Make ews-app robust against config.json issues
https://bugs.webkit.org/show_bug.cgi?id=216705
Reviewed by Jonathan Bedard.
- BuildSlaveSupport/ews-app/ews/common/buildbot.py:
(Buildbot.fetch_config):
(Buildbot.update_icons_for_queues_mapping):
- 12:36 PM Changeset in webkit [267276] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266619. rdar://problem/69101154
Add a fast path in TransformationMatrix::mapRect(const FloatRect&) for affine transformations
https://bugs.webkit.org/show_bug.cgi?id=216139
Reviewed by Tim Horton.
Add a fast path when mapping 2D points through affine transformation matrices that takes advantage of both:
- The predetermined 0 and 1 values in affine transformation matrices.
- The fact that points in the FloatRect are aligned with x and y axes (as opposed to a FloatQuad of 4 arbitrary
points), which allows us to avoid mapping all 4 corners of the rect through the matrix.
The current implementation of this method maps each of the 4 corners through the transformation matrix, creates
a FloatQuad using these 4 transformed points, and then asks the FloatQuad for its bounding box. This requires
a total of 26 floating point additions, 24 multiplications and 20 comparisons, as well as a small (but
measurable) amount of overhead when creating the FloatPoints and FloatQuad and asking for the bounding rect.
We can pare this down to just 8 additions, 8 multiplications, and 4 comparisons by using a different strategy
that instead branches on the 4 relevant matrix coefficientsa, b, c, d(rather than the each of the final x
and y coordinates) to determine which of the min or max x and y values to multiply in order to compute the min
and max x and y coordinates in the final bounding rect.
In a quick microbenchmark that maps FloatRects through an affine TransformationMatrix, this roughly halves the
time spent inTransformationMatrix::mapRect; on the Multiply subtest of MotionMark (which invokes this method
~17 million times, almost entirely with affine transformation matrices), I measured a ~1% improvement.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::mapRect const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267275] by
-
- 3 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266513. rdar://problem/69153717
Make TransformationMatrix::inverse() faster in the case of affine transformation matrices
https://bugs.webkit.org/show_bug.cgi?id=216101
Reviewed by Tim Horton.
The Multiply subtest of MotionMark places a large number of elements that are all rotated by some angle; when
painting these, we currently spend about 7% of the time underRenderLayer::paintLayerByApplyingTransformjust
inverting the transformation matrix (underneathTransformationMatrix::inverse()) so that we can map the bounds
of the dirty rect through this inverse.
TransformationMatrix::inverse()currently has a fast path for identity and translation matrices that avoids
having to fall back to the generalized 4-by-4 matrix inverse equation; this generalized algorithm works by
dividing the entire adjoint matrix by the determinant, a process that involves nearly 1000 floating point
additions and multiplications.
However, in this case, all of the matrices are a combination of translations and rotations, which all result in
affine transformations. As such, there's no need to fall back to the generalized algorithm for computing the
inverse; instead, we can bail early with simpler strategy that only requires 15 floating point additions and
multiplications.
We can also take advantange of the fact that we currently go through most of the entries in the 4x4 matrix to
determine whether the matrix is an identity or translation matrix, by introducing a new helper method that
returns not only whether the matrix is the identity matrix or translation, but also whether the matrix is affine
(by the definition ofTransformationMatrix::isAffine()). Since most of the entries that need to be 1 or 0 in
order for a matrix to be a translation matrix vs. just an affine transformation matrix are the same, this helps
avoid some redundant checks inTransformationMatrix::inverse().
We also apply a similar optimization to
TransformationMatrix::isInvertible(), reducing the multiplications and
additions from roughly 200 to just 3.
I measured this locally to be a (statistically significant) 2% improvement on Multiply.
- platform/graphics/transforms/TransformationMatrix.cpp: (WebCore::TransformationMatrix::isInvertible const): (WebCore::TransformationMatrix::inverse const):
- platform/graphics/transforms/TransformationMatrix.h: (WebCore::TransformationMatrix::type const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267274] by
-
- 4 edits2 adds in branches/safari-610-branch
Cherry-pick r266834. rdar://problem/69101124
REGRESSION (r260360): Ionic modal dialog doesn't animate correctly when dragged and released
https://bugs.webkit.org/show_bug.cgi?id=216308
<rdar://problem/68567444>
Reviewed by Simon Fraser.
Source/WebCore:
We fixed seeking for animations with a reversed playback rate in r261637, the fix for bug 204717,
but only looked at the animation's playback rate. However, an animation can also play in reverse
using the "direction" property of the timing object passed to updateTiming(), so we should also
check that it's playing forwards in order to be seeked.
Test: webanimations/accelerated-animation-easing-and-direction-update.html
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::animationCanBeAccelerated const):
LayoutTests:
Add a new test that updates the "easing" and "direction" timing properties of a playing animation
and checks that it matches the display of another animation with similar timing properties from
the start.
- platform/win/TestExpectations:
- webanimations/accelerated-animation-easing-and-direction-update-expected.html: Added.
- webanimations/accelerated-animation-easing-and-direction-update.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267273] by
-
- 8 edits in branches/safari-610-branch/Source
Cherry-pick r266802. rdar://problem/69101097
Text copied and pasted from Mac Catalyst apps appears larger than expected
https://bugs.webkit.org/show_bug.cgi?id=215971
<rdar://problem/65768907>
Reviewed by Tim Horton.
Source/WebKit:
Various pieces of platform logic in Mac Catalyst depend on the user interface idiom (i.e. Mac or iPad) of the
app, as well as the application-wide "scale factor". In the context of this bug, NSAttributedString to RTF data
conversion methods inUIFoundationconsult the scale factor ofUIiOSMacIdiomManagerto determine whether to
emit 0 (standard) or 1 (iOS) for the\cocoatextscalingattribute. The fact that the web process' scale factor
may be out of sync with the UI process' scale factor leads to copied RTF data in the web process appearing
either larger or smaller than expected, due to an incorrectNSTextScalingTypevalue.
To mitigate this (as well as any other issues), we add a mechanism for the UI process to forward the global
scale factor and user interface idiom to the web process inside of the web process creation parameters, and then
use new UIKit SPI to override the scale factor and idiom within the web process.
- Scripts/process-entitlements.sh:
Add a new entitlement needed to use
_UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::WebProcessPool::platformInitializeWebProcess):
Use
_UIApplicationCatalystUserInterfaceIdiomand_UIApplicationCatalystScaleFactorto grab the global user
interface idiom and scale factor, respectively.
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
Override the idiom and scale factor in the web process with the idiom and scale factor from the UI process,
using the new SPI_UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor. As this function hasn't landed
yet, we soft link the function for now to avoid causing the web process to instantly crash on any builds without
the fix for <rdar://problem/68524148>.
Source/WTF:
Add a new flag to guard the presence of
_UIApplicationCatalystUserInterfaceIdiom,
_UIApplicationCatalystScaleFactor, and_UIApplicationCatalystRequestViewServiceIdiomAndScaleFactor.
- wtf/PlatformHave.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267272] by
-
- 5 edits4 adds in branches/safari-610-branch
Cherry-pick r266789. rdar://problem/69101080
REGRESSION (r264856): updating easing on accelerated animation results in incorrect playback
https://bugs.webkit.org/show_bug.cgi?id=215853
<rdar://problem/67815853>
Reviewed by Simon Fraser.
Source/WebCore:
Stop accelerated animations if the timing function has changed in a way that makes it so that it should
no longer play accelerated, but otherwise simply update their timing properties such that may keep
playing.
Test: webanimations/accelerated-animation-easing-update-after-pause.html
webanimations/accelerated-animation-easing-update-steps-after-pause.html
- animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::canBeAccelerated const): (WebCore::KeyframeEffect::updateAcceleratedActions): (WebCore::KeyframeEffect::animationDidChangeTimingProperties):
- animation/KeyframeEffect.h:
LayoutTests:
Add new tests that check that updating an animation's easing does not stop it.
- platform/win/TestExpectations:
- webanimations/accelerated-animation-easing-update-after-pause-expected.html: Added.
- webanimations/accelerated-animation-easing-update-after-pause.html: Added.
- webanimations/accelerated-animation-easing-update-steps-after-pause-expected.html: Addded.
- webanimations/accelerated-animation-easing-update-steps-after-pause.html: Addded.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267271] by
-
- 26 edits1 copy3 adds in branches/safari-610-branch
Cherry-pick r266846. rdar://problem/68740511
Don't create event regions when the page has no subscrollers
https://bugs.webkit.org/show_bug.cgi?id=216355
<rdar://problem/67900642>
Reviewed by Simon Fraser.
Source/WebCore:
Tests: fast/scrolling/mac/event-region-subscroller-frame.html
fast/scrolling/mac/event-region-subscroller-overflow.html
Unless the page uses features like touch-action we don't need event regions for plain main frame scrolling.
- page/scrolling/AsyncScrollingCoordinator.cpp: (WebCore::AsyncScrollingCoordinator::hasSubscrollers const):
- page/scrolling/AsyncScrollingCoordinator.h:
- page/scrolling/ScrollingCoordinator.h: (WebCore::ScrollingCoordinator::hasSubscrollers const):
- page/scrolling/ScrollingStateScrollingNode.cpp: (WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): (WebCore::ScrollingStateScrollingNode::~ScrollingStateScrollingNode):
- page/scrolling/ScrollingStateTree.h: (WebCore::ScrollingStateTree::scrollingNodeCount const): (WebCore::ScrollingStateTree::scrollingNodeAdded): (WebCore::ScrollingStateTree::scrollingNodeRemoved):
Count scrolling nodes in the state tree. It is updated during updateCompositingLayers, before event region generation.
- rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::maintainsEventRegion const):
Don't maintain event region if there are no subscrollers and none of the other reasons were hit.
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateCompositingLayers):
Invalidate event regions if a subscroller appears.
(WebCore::RenderLayerCompositor::invalidateEventRegionForAllFrames):
- rendering/RenderLayerCompositor.h:
LayoutTests:
Add overflow scrollers to some existing tests so they still generate event regions.
- fast/scrolling/ios/border-radius-event-region-expected.txt:
- fast/scrolling/ios/border-radius-event-region.html:
- fast/scrolling/ios/event-region-float-expected.txt:
- fast/scrolling/ios/event-region-float.html:
- fast/scrolling/ios/event-region-pointer-events-expected.txt:
- fast/scrolling/ios/event-region-pointer-events.html:
- fast/scrolling/ios/event-region-scale-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-scale-transform-shared.html:
- fast/scrolling/ios/event-region-translate-transform-shared-expected.txt:
- fast/scrolling/ios/event-region-translate-transform-shared.html:
- fast/scrolling/ios/event-region-visibility-hidden-expected.txt:
- fast/scrolling/ios/event-region-visibility-hidden.html:
- fast/scrolling/mac/border-radius-event-region-expected.txt:
- fast/scrolling/mac/border-radius-event-region.html:
- fast/scrolling/mac/event-region-subscroller-frame-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-frame.html: Added.
- fast/scrolling/mac/event-region-subscroller-overflow-expected.txt: Added.
- fast/scrolling/mac/event-region-subscroller-overflow.html: Copied from LayoutTests/fast/scrolling/ios/event-region-visibility-hidden.html.
- fast/scrolling/mac/event-region-visibility-hidden-expected.txt:
- fast/scrolling/mac/event-region-visibility-hidden.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267270] by
-
- 10 edits in branches/safari-610-branch/Source
Cherry-pick r266677. rdar://problem/68740521
[MotionMark] RenderLayer::paintLayerContents spends ~5% of the time in MonotonicTime::now() in Multiply
https://bugs.webkit.org/show_bug.cgi?id=216190
Reviewed by Darin Adler.
Source/WebCore:
In several of MotionMark's subtests (for instance, Multiply), we spent a large amount of time underneath
RenderLayer::paintLayerContentsdue to both the large number of layers and the need to frequently repaint
each layer (all of which are constantly being animated). Underneath this method, a nontrivial amount of time
(~5%) is then spent grabbing the system time viaMonotonicTime::now().
We can avoid this extra work by instead using the timestamp of the last rendering update (before we started
painting), which we keep track of using a new member variable onPage. See below for more details, as well as
the WebKit2 ChangeLog.
- page/ChromeClient.h: (WebCore::ChromeClient::timestampForPaintFrequencyTracking const):
Add a client hook to fetch the timestamp to use when tracking painting frequency. See the WebKit2 ChangeLog for
more details.
- page/Page.cpp: (WebCore::Page::updateRendering):
Update
m_lastRenderingUpdateTimestamp.
- page/Page.h: (WebCore::Page::lastRenderingUpdateTimestamp const):
- rendering/PaintFrequencyTracker.h:
Drive-by cleanup: narrow the
PaintFrequencyenum toboolwidth.
(WebCore::PaintFrequencyTracker::begin):
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayerContents):
Call out to the client layer to return a timestamp for tracking painting frequency. By default, this is simply
the current time (MonotonicTime::now()), but ports (namely, WebKit2) may opt for a coarser granularity.
(WebCore::RenderLayer::simulateFrequentPaint):
- rendering/RenderLayer.h:
Source/WebKit:
- WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::timestampForPaintFrequencyTracking const):
In WebKit2, we can assume (with the exception of SVG pages) that we must've performed a rendering update prior
to tracking painting frequencies. As such, we can use the page's rendering update timestamp instead of the real
current time (MonotonicTime::now()).
Note that in WebKit1, it is possible for any client to force a synchronous paint of the page before the page has
performed a rendering update, which triggers assertions inSinglePaintFrequencyTracking::end(). As such, we
stick withMonotonicTime::now()in WebKit1.
- WebProcess/WebCoreSupport/WebChromeClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267269] by
-
- 4 edits in branches/safari-610-branch
Cherry-pick r266232. rdar://problem/68178664
Step animations invalidate style on every rendering update whether or not they need to
https://bugs.webkit.org/show_bug.cgi?id=215229
<rdar://problem/66636153>
Reviewed by Antoine Quint.
Source/WebCore:
Step timing functions with transforms try and fail to start accelerated which causes them to repeatedly schedule unnecessary rendering updates.
- animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::updateAcceleratedActions):
Step timing functions are never accelerated so don't bother trying to start them in accelerated state.
This is similar to treatmeant of unaccelerated properties.
LayoutTests:
- animations/steps-transform-rendering-updates-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267268] by
-
- 11 edits5 adds in branches/safari-610-branch
Cherry-pick r267057. rdar://problem/69101182
[Cocoa,HDR] HLS streams with HDR variants will not select HDR.
https://bugs.webkit.org/show_bug.cgi?id=216203
<rdar://problem/67438626>
Reviewed by Darin Adler.
Source/WebCore:
Test: http/tests/media/hls/hls-hdr-switch.html
In r264710, we adopted a new API to set the preferred HDR mode for every AVPlayer created by an HTMLMediaElement. The
MediaPlayerPrivateAVFoundationObjC object will query its parent when it creates an AVPlayer, or the MediaPlayer will
tell the MediaPlayerPrivate... that the HDR mode changes if the AVPlayer is already created. However, in r264710, we
neglected to cache the new value of the preferred HDR mode, so subsequent queries will just return "Standard". This means
HDR mode will correctly be applied if it changes after the AVPlayer has been created, but not initially.
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::setPreferredDynamicRangeMode):
LayoutTests:
- http/tests/media/hls/hls-hdr-switch-expected.txt: Added.
- http/tests/media/hls/hls-hdr-switch.html: Added.
- http/tests/media/resources/hls/green-bip.ts: Added.
- http/tests/media/resources/hls/hdr.m3u8: Added.
- http/tests/media/resources/hls/red-bip.ts: Added.
- http/tests/media/resources/hls/test-live.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267267] by
-
- 4 edits in branches/safari-610-branch/Source
Cherry-pick r267031. rdar://problem/69101165
Web Inspector: docking buttons don't work when already docked if window is too small
https://bugs.webkit.org/show_bug.cgi?id=216488
<rdar://problem/68242717>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
- UserInterface/Base/Main.js: (WI.updateDockingAvailability): (WI.updateDockedState): (WI._updateDockNavigationItems): Always be sure to update the docking navigation items when docking becomes unavailable instead of just forcing Web Inspector to undock as if Web Inspector is already undocked then none of the docking navigation items will be updated. This makes it so that the docking navigation items are hidden when docking becomes unavailable while undocked.
Source/WebKit:
- UIProcess/Inspector/WebInspectorProxy.cpp: (WebKit::WebInspectorProxy::attach): (WebKit::WebInspectorProxy::attachAvailabilityChanged): If Web Inspector is already attached, it can re-attach with a different configuration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267266] by
-
- 3 edits1 add in branches/safari-610-branch
Cherry-pick r267017. rdar://problem/69100994
Don't assume byte code operands are uint32 JSValues
https://bugs.webkit.org/show_bug.cgi?id=216386
Reviewed by Yusuke Suzuki.
JSTests:
- stress/dont-assume-bytecode-operand-is-uint32.js: Added. (async foo):
Source/JavaScriptCore:
The slow path for enumerator_generic_pname was assuming that its input index operand
would always be a UInt32 JSValue boxed as int32. However, this assumption isn't true
because that value can have double format in the DFG, and remain in that format when
we exit from the DFG to baseline/LLInt code.
This was found via the widening number fuzzing agent.
I also audited two more places that seem like they suffer from the same issue,
and also switched them to using the asUInt32AsAnyInt function:
- enumerator_structure_pname
- create_rest
- runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:36 PM Changeset in webkit [267265] by
-
- 3 edits2 adds in branches/safari-610-branch
Cherry-pick r266972. rdar://problem/69101020
REGRESSION (r255383): Transition from email to password field on login.live.com stutters after going back and forth
https://bugs.webkit.org/show_bug.cgi?id=216368
<rdar://problem/67019460>
Reviewed by Simon Fraser.
Source/WebCore:
Ensure we repaint before disconnecting from the backing provider layer.
Test: compositing/animation/repaint-after-clearing-shared-backing.html
- rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::updateBacking):
LayoutTests:
- compositing/animation/repaint-after-clearing-shared-backing-expected.html: Added.
- compositing/animation/repaint-after-clearing-shared-backing.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267264] by
-
- 6 edits in branches/safari-610-branch
Cherry-pick r266827. rdar://problem/69101047
[CG] REGRESSION (Big Sur): A GIF image with a finite loopCount loops an extra cycle
https://bugs.webkit.org/show_bug.cgi?id=216018
<rdar://problem/68304035>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-10
Reviewed by Tim Horton.
Source/WebCore:
Remove the extra 'one' we used to add to the GIF loopCount since it is
now added by the underlying frameworks. But make sure we are compatible
with the older versions of macOS and iOS.
- platform/graphics/cg/ImageDecoderCG.cpp: (WebCore::ImageDecoderCG::repetitionCount const):
Source/WTF:
Add a new macro for the new accurate behavior of CGImageSource.
Unrelated change: Fix the conditions for enabling the WebP images.
- wtf/PlatformHave.h:
LayoutTests:
- platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267263] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266752. rdar://problem/69101201
Web process crashes at WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby
https://bugs.webkit.org/show_bug.cgi?id=216283
Reviewed by Alex Christensen.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::prepareForVideoFullscreenStandby):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267262] by
-
- 2 edits in branches/safari-610-branch/Source/JavaScriptCore
Cherry-pick r266747. rdar://problem/69101160
re-enable TCSM on all OSs
https://bugs.webkit.org/show_bug.cgi?id=216281
Reviewed by Tadeu Zagallo.
- runtime/Options.cpp: (JSC::defaultTCSMValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267261] by
-
- 12 edits in branches/safari-610-branch/Source
Cherry-pick r266745. rdar://problem/69100985
Tighten checks when creating an audio buffer list
https://bugs.webkit.org/show_bug.cgi?id=216237
<rdar://problem/68271376>
Reviewed by Geoffrey Garen.
Source/WebCore:
Add a routine to check there is no multiplication integer overflow.
- platform/audio/cocoa/WebAudioBufferList.cpp: (WebCore::computeBufferSize): (WebCore::WebAudioBufferList::isSupportedDescription): (WebCore::WebAudioBufferList::setSampleCount):
- platform/audio/cocoa/WebAudioBufferList.h:
Source/WebKit:
Add message checks to verify that no message integer overflows happen when processing audio buffer list messages.
- GPUProcess/GPUConnectionToWebProcess.cpp: (WebKit::GPUConnectionToWebProcess::audioTrackRendererManager):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp: (WebKit::RemoteAudioMediaStreamTrackRenderer::RemoteAudioMediaStreamTrackRenderer): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesStorageChanged): (WebKit::RemoteAudioMediaStreamTrackRenderer::audioSamplesAvailable):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.h:
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.cpp: (WebKit::RemoteAudioMediaStreamTrackRendererManager::RemoteAudioMediaStreamTrackRendererManager): (WebKit::RemoteAudioMediaStreamTrackRendererManager::createRenderer):
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererManager.h:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp: (WebKit::RemoteMediaRecorder::audioSamplesStorageChanged): (WebKit::RemoteMediaRecorder::audioSamplesAvailable):
- GPUProcess/webrtc/RemoteMediaRecorder.h:
- WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::RemoteAudio::audioSamplesAvailable):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266745 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267260] by
-
- 2 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266375. rdar://problem/69101035
Avoid computing metadata for idempotent text autosizing on macOS
https://bugs.webkit.org/show_bug.cgi?id=216011
Reviewed by Darin Adler.
Avoids an unnecessary call to
adjustForTextAutosizingduring style resolution on macOS, where idempotent text
autosizing is disabled. This function call populates theAutosizeStatusfields onRenderStylethat are used
by the idempotent text autosizing heuristic. This function call appears consistently in traces taken while
running the Multiply subtest of MotionMark, if only for a relatively small number of samples. While
AutosizeStatus::computeStatusis designed to be very cheap, it ends up being called around 1.6 million times
over the course of the subtest.
- style/StyleAdjuster.cpp: (WebCore::Style::Adjuster::adjust const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267259] by
-
- 9 edits in branches/safari-610-branch/Source/WebCore
Cherry-pick r266344. rdar://problem/69101085
Make StyleRareNonInheritedData::mask and StyleBackgroundData::background DataRefs
https://bugs.webkit.org/show_bug.cgi?id=215942
Reviewed by Darin Adler.
A significant amount of time in MotionMark's Multiply subtest is spent underneath the copy constructor
StyleRareNonInheritedData, and a significant amount of time underneath this copy constructor is spent copying
the rare non-inherited data's mask (aFillLayer).
This
FillLayeris currently inline data inStyleRareNonInheritedData; to reduce the cost of copying rare
non-inherited data, we can instead make this aDataRef<FillLayer>, such that copying rare data will only copy
the reference to theFillLayerrather than theFillLayeritself.
Upon mutating the
FillLayer, we now useDataRef::access()to ensure that theseFillLayers are copied
before writing. See below for more details.
- css/makeprop.pl: (generateFillLayerPropertyInheritValueSetter): (generateFillLayerPropertyValueSetter):
- rendering/style/FillLayer.cpp: (WebCore::FillLayer::create): (WebCore::FillLayer::FillLayer):
Deeply copy the
FillLayer's linked list ofFillLayers. This preserves existing behavior, which currently
usesstd::unique_ptrto store the pointer to the nextFillLayer(and therefore, requires a deep copy of the
linked list when copyingFillLayer).
In a future patch, we could probably further optimize this as well to behave in a copy-on-write way, by turning
theRefPtr<FillLayer> m_next;into anOptional<DataRef<FillLayer>>instead (and then useaccess()to copy
the nextFillLayerprior to writing).
(WebCore::FillLayer::~FillLayer):
(WebCore::FillLayer::operator=):
- rendering/style/FillLayer.h:
Make
FillLayerref-counted, and introduce newcreatemethods for constructingFillLayers. Use these
methods in several places where we currently call the constructors directly, viamakeUnique.
(WebCore::FillLayer::copy const):
(WebCore::FillLayer::setNext):
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::hasBackgroundImage const): (WebCore::RenderStyle::hasFixedBackgroundImage const): (WebCore::RenderStyle::backgroundRepeatX const): (WebCore::RenderStyle::backgroundRepeatY const): (WebCore::RenderStyle::backgroundComposite const): (WebCore::RenderStyle::backgroundAttachment const): (WebCore::RenderStyle::backgroundClip const): (WebCore::RenderStyle::backgroundOrigin const): (WebCore::RenderStyle::backgroundXPosition const): (WebCore::RenderStyle::backgroundYPosition const): (WebCore::RenderStyle::backgroundSizeType const): (WebCore::RenderStyle::backgroundSizeLength const): (WebCore::RenderStyle::ensureBackgroundLayers): (WebCore::RenderStyle::maskImage const): (WebCore::RenderStyle::maskRepeatX const): (WebCore::RenderStyle::maskRepeatY const): (WebCore::RenderStyle::maskComposite const): (WebCore::RenderStyle::maskClip const): (WebCore::RenderStyle::maskOrigin const): (WebCore::RenderStyle::maskXPosition const): (WebCore::RenderStyle::maskYPosition const): (WebCore::RenderStyle::maskSizeType const): (WebCore::RenderStyle::maskSizeLength const): (WebCore::RenderStyle::ensureMaskLayers): (WebCore::RenderStyle::hasMask const): (WebCore::RenderStyle::setBackgroundXPosition): (WebCore::RenderStyle::setBackgroundYPosition): (WebCore::RenderStyle::setBackgroundSize): (WebCore::RenderStyle::setBackgroundSizeLength): (WebCore::RenderStyle::clearBackgroundLayers): (WebCore::RenderStyle::inheritBackgroundLayers): (WebCore::RenderStyle::clearMaskLayers): (WebCore::RenderStyle::inheritMaskLayers): (WebCore::RenderStyle::setMaskImage): (WebCore::RenderStyle::setMaskXPosition): (WebCore::RenderStyle::setMaskYPosition): (WebCore::RenderStyle::setMaskSize):
- rendering/style/StyleBackgroundData.cpp: (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleBackgroundData::dump const):
- rendering/style/StyleBackgroundData.h:
Since
FillLayeris now ref-counted,StyleBackgroundData::backgroundneeds to be aDataRefas well.
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
- rendering/style/StyleRareNonInheritedData.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267258] by
-
- 5 edits2 adds in branches/safari-610-branch
Cherry-pick r266290. rdar://problem/69101142
[iOS] Vertical text's logical width calculation is stale from the previous height of the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=215910
Reviewed by Simon Fraser.
Source/WebCore:
When there is vertical text (really: orthogonal flows) in the content, the available width of the vertical
text is the height of its containing block. However, the height of the containing block (indeed: all ancestors)
may be "auto", in which case the CSS spec says the available width of the element should be "the initial
containing block's size."[1]
Previously, we were using the FrameView's visibleHeight as this metric. However, the visibleHeight is calculated
asynchronously, after layout, after a round-trip from the Web Process to the UI Process and back to the Web
Process. Therefore, if content changes the WKWebView's size and the web view immediatey re-lays-out, this
visibleHeight metric is stale from whatever the previous height of the WKWebView was. In addition, the
visibleHeight metric isn't even supposed to be used inside layout; it's instead only supposed to be used for
things like position: fixed elements.
Instead, we should use FrameView::layoutSize(), which is set before layout to the size of the WKWebView. The
name even indicates that it should be used for layout purposes.
[1] https://drafts.csswg.org/css-writing-modes-4/#orthogonal-auto
Test: WebKit.OrthogonalFlowAvailableSize
- rendering/RenderBox.cpp: (WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
- rendering/RenderView.cpp: (WebCore::RenderView::availableLogicalHeight const):
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit/OrthogonalFlowAvailableSize.mm: Added. (TEST):
- TestWebKitAPI/Tests/WebKit/orthogonal-flow-available-size.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267257] by
-
- 4 edits in branches/safari-610-branch
Cherry-pick r266244. rdar://problem/69101147
REGRESSION (r264790): IndexedDB may abort transactions of in-memory databases
https://bugs.webkit.org/show_bug.cgi?id=215855
<rdar://problem/67418574>
Reviewed by Youenn Fablet.
Source/WebCore:
We don't abort transactions on in-memory database before process suspension because they don't hold database
file lock. Before r264790, only ephemeral session would use in-memory databases, so we only checked session. Now
persistent session also uses in-memory databases for third-party storage, so we need to add another check.
API test: IndexedDB.SuspendImminentlyForThirdPartyDatabases
- Modules/indexeddb/server/IDBServer.cpp: (WebCore::IDBServer::IDBServer::stopDatabaseActivitiesOnMainThread):
Tools:
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: (postResult): (catch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:35 PM Changeset in webkit [267256] by
-
- 5 edits in branches/safari-610-branch/Source/WebKit
Cherry-pick r266411. rdar://problem/68300959
[iOS] AGX compiler service sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=216042
<rdar://problem/68111667>
Reviewed by Brent Fulgham.
For a set of devices, mach-lookup sandbox violations have been observed for an AGX compiler service. For these devices,
we currently issue an extension for one AGX compiler service, but this is not sufficient since there is a similar
service name that needs to be added as well.
- Shared/WebProcessCreationParameters.cpp: (WebKit::WebProcessCreationParameters::encode const): (WebKit::WebProcessCreationParameters::decode):
- Shared/WebProcessCreationParameters.h:
- UIProcess/Cocoa/WebProcessPoolCocoa.mm: (WebKit::agxCompilerServices): (WebKit::WebProcessPool::platformInitializeWebProcess):
- WebProcess/cocoa/WebProcessCocoa.mm: (WebKit::WebProcess::platformInitializeWebProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:34 PM Changeset in webkit [267255] by
-
- 3 edits1 add in trunk
DFG should ensure there are PhantomLocals for the taken block of op_jneq_ptr
https://bugs.webkit.org/show_bug.cgi?id=216669
Reviewed by Saam Barati.
JSTests:
- stress/jneq-ptr-opcode-variable-only-live-on-taken-branch.js: Added.
(bar):
(foo):
Source/JavaScriptCore:
Right now, if there is a local that is live on the taken branch but dead on
not-taken branch then nothing will preserve it for OSR exit. This patch simply
adds a PhantomLocal for each live operand for the first bytecode of the taken block.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- 12:30 PM Changeset in webkit [267254] by
-
- 5 edits in trunk/Source/WebCore
REGRESSION(r267137): PaintFrequencyTracker needs to track all the painting
https://bugs.webkit.org/show_bug.cgi?id=216677
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2020-09-18
Reviewed by Simon Fraser.
r267137 removed all the optimizations which the Design test got from
r230544 because it resets the renderingUpdateTimestamp to zero when it
exists. This makes RenderLayer always retrieves this timestamp with value
equal to zero. There is no direct call from Page::updateRendering() to
RenderLayer::paintLayerContents(). Painting has to be scheduled to the
next run-loop. Because SinglePaintFrequencyTracking tracks only the painting
whose timestamp is not zero, SinglePaintFrequencyTracking has not been
tracking any painting.
The solution is to track all the painting. When renderingUpdateTimestamp()
is zero, SinglePaintFrequencyTracking will use MonotonicTime::now() instead.
This will happen in cases like calling updateControlTints() before calling
Page::updateRendering().
- page/Page.cpp:
(WebCore::Page::updateRendering):
- page/Page.h:
(WebCore::Page::lastRenderingUpdateTimestamp const):
(WebCore::Page::renderingUpdateTimestamp const): Deleted.
- rendering/PaintFrequencyTracker.h:
(WebCore::SinglePaintFrequencyTracking::SinglePaintFrequencyTracking):
(WebCore::SinglePaintFrequencyTracking::~SinglePaintFrequencyTracking):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::calculateClipRects const):
- 12:18 PM Changeset in webkit [267253] by
-
- 6 edits1 copy4 moves60 adds in trunk/LayoutTests
Import AudioContext / AudioListener / AudioNode / AudioParam layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216706
Reviewed by Eric Carlson.
Import AudioContext / AudioListener / AudioNode / AudioParam layout tests from Blink.
- webaudio/AudioContext/audiocontext-close-basic-expected.txt: Added.
- webaudio/AudioContext/audiocontext-close-basic.html: Added.
- webaudio/AudioContext/audiocontext-listener-should-not-crash-expected.txt: Added.
- webaudio/AudioContext/audiocontext-listener-should-not-crash.html: Added.
- webaudio/AudioListener/audiolistener-automation-position-expected.txt: Added.
- webaudio/AudioListener/audiolistener-automation-position.html: Added.
- webaudio/AudioListener/audiolistener-set-position-expected.txt: Added.
- webaudio/AudioListener/audiolistener-set-position.html: Added.
- webaudio/AudioNode/tail-connections-expected.txt: Added.
- webaudio/AudioNode/tail-connections.html: Added.
- webaudio/AudioNode/tail-processing-expected.txt: Added.
- webaudio/AudioNode/tail-processing.html: Added.
- webaudio/AudioParam/audioparam-automation-clamping-expected.txt: Added.
- webaudio/AudioParam/audioparam-automation-clamping.html: Added.
- webaudio/AudioParam/audioparam-cancel-and-hold-expected.txt: Renamed from LayoutTests/webaudio/audioparam-cancel-and-hold-expected.txt.
- webaudio/AudioParam/audioparam-cancel-and-hold.html: Renamed from LayoutTests/webaudio/audioparam-cancel-and-hold.html.
- webaudio/AudioParam/audioparam-clamp-time-to-current-time-expected.txt: Added.
- webaudio/AudioParam/audioparam-clamp-time-to-current-time.html: Added.
- webaudio/AudioParam/audioparam-initial-event-expected.txt: Added.
- webaudio/AudioParam/audioparam-initial-event.html: Added.
- webaudio/AudioParam/audioparam-k-rate-expected.txt: Added.
- webaudio/AudioParam/audioparam-k-rate.html: Added.
- webaudio/AudioParam/audioparam-linearRamp-value-attribute-expected.txt: Added.
- webaudio/AudioParam/audioparam-linearRamp-value-attribute.html: Added.
- webaudio/AudioParam/audioparam-negative-exponentialRamp-expected.txt: Added.
- webaudio/AudioParam/audioparam-negative-exponentialRamp.html: Added.
- webaudio/AudioParam/audioparam-nominal-range-expected.txt: Renamed from LayoutTests/webaudio/audioparam-nominal-range-expected.txt.
- webaudio/AudioParam/audioparam-nominal-range.html: Renamed from LayoutTests/webaudio/audioparam-nominal-range.html.
- webaudio/AudioParam/audioparam-processing-expected.txt: Added.
- webaudio/AudioParam/audioparam-processing.html: Added.
- webaudio/AudioParam/audioparam-sampling-expected.txt: Added.
- webaudio/AudioParam/audioparam-sampling.html: Added.
- webaudio/AudioParam/audioparam-setTarget-timeConstant-0-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTarget-timeConstant-0.html: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-continuous-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-continuous.html: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-limit-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-limit.html: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-sampling-expected.txt: Added.
- webaudio/AudioParam/audioparam-setTargetAtTime-sampling.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-copy-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurve-copy.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-duration-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurve-duration.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-end-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurve-end.html: Added.
- webaudio/AudioParam/audioparam-setValueCurve-exceptions-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation-expected.txt: Added.
- webaudio/AudioParam/audioparam-setValueCurveAtTime-interpolation.html: Added.
- webaudio/AudioParam/audioparam-update-value-attribute-expected.txt: Added.
- webaudio/AudioParam/audioparam-update-value-attribute.html: Added.
- webaudio/AudioParam/audioparam-value-setter-error-expected.txt: Added.
- webaudio/AudioParam/audioparam-value-setter-error.html: Added.
- webaudio/AudioParam/cancel-values-crash-913217-expected.txt: Added.
- webaudio/AudioParam/cancel-values-crash-913217.html: Added.
- webaudio/AudioParam/value-setter-warnings-expected.txt: Added.
- webaudio/AudioParam/value-setter-warnings.html: Added.
- webaudio/AudioParam/worklet-warnings-expected.txt: Added.
- webaudio/AudioParam/worklet-warnings.html: Added.
- webaudio/audioparam-exponentialRampToValueAtTime.html:
- webaudio/audioparam-linearRampToValueAtTime.html:
- webaudio/audioparam-setValueAtTime.html:
- webaudio/resources/audioparam-testing-legacy.js: Copied from LayoutTests/webaudio/resources/audioparam-testing.js.
(renderLength):
(createConstantBuffer):
(createConstantArray):
(createLinearRampArray):
(createExponentialRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createSineWaveArray):
(endValueDelta):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/audioparam-testing.js:
(renderLength):
(createConstantArray):
(getStartEndFrames):
(createLinearRampArray):
(createExponentialRampArray):
(discreteTimeConstantForSampleRate):
(createExponentialApproachArray):
(createReferenceSineArray):
(createSineWaveArray):
(endValueDelta):
(relativeErrorMetric):
(differenceErrorMetric):
(valueUpdate):
(comparePartialSignals):
(verifyDiscontinuities):
(compareSignals):
(checkResultFunction):
(doAutomation):
(createAudioGraphAndTest):
- webaudio/resources/set-position-vs-curve-test.js: Added.
(testPositionSetterVsCurve):
- 11:55 AM Changeset in webkit [267252] by
-
- 7 edits in trunk
webaudio/Analyser/handle-silent-inputs.html test is failing
https://bugs.webkit.org/show_bug.cgi?id=216708
Reviewed by Geoffrey Garen.
Source/WebCore:
Merge the following fix to AnalyserNode from Blink so that webaudio/Analyser/handle-silent-inputs.html
layout test starts passing:
No new tests, rebaselined existing test.
- Modules/webaudio/AnalyserNode.cpp:
(WebCore::AnalyserNode::process):
(WebCore::AnalyserNode::updatePullStatus):
(WebCore::AnalyserNode::tailTime const):
- Modules/webaudio/AnalyserNode.h:
- Modules/webaudio/AudioBasicInspectorNode.h:
LayoutTests:
Rebaseline test that is now passing.
- webaudio/Analyser/handle-silent-inputs-expected.txt:
- 10:53 AM Changeset in webkit [267251] by
-
- 10 edits9 adds in trunk/LayoutTests/imported/w3c
Resync web-platform-tests/webaudio from upstream
https://bugs.webkit.org/show_bug.cgi?id=216700
Reviewed by Sam Weinig.
Resync web-platform-tests/webaudio from upstream 175a1086e0061c75d1.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontext-not-fully-active.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/resources/not-fully-active-helper.sub.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/resources/w3c-import.log: Added.
- web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/extended-audioworkletnode-with-parameters.https.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/w3c-import.log:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-convolvernode-interface/realtime-conv.html:
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delay-test-expected.txt: Added.
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/delay-test.html: Added.
- web-platform-tests/webaudio/the-audio-api/the-delaynode-interface/w3c-import.log:
- 10:52 AM Changeset in webkit [267250] by
-
- 4 edits in trunk/Source/WebKit
Webpages flash when getting closed
https://bugs.webkit.org/show_bug.cgi?id=216131
<rdar://problem/62264106>
Reviewed by Chris Dumez.
Closing a page in web process will detach root CA layer and clears content in view immediately. If this happens
in web process before transaction, which contains view hierachy change or layer change, is committed in UI
process, we would see a white flash. To try fixing this issue, we explicitly delay sending the close message
to next runloop cycle.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
- UIProcess/WebProcessProxy.cpp:
(WebKit::m_shutdownPreventingScopeCounter):
(WebKit::WebProcessProxy::canTerminateAuxiliaryProcess):
- UIProcess/WebProcessProxy.h: remove class ScopePreventingShutdown and use RefCounter to prevent process
shutdown.
(WebKit::WebProcessProxy::shutdownPreventingScope):
(WebKit::WebProcessProxy::ScopePreventingShutdown::ScopePreventingShutdown): Deleted.
(WebKit::WebProcessProxy::ScopePreventingShutdown::~ScopePreventingShutdown): Deleted.
(WebKit::WebProcessProxy::makeScopePreventingShutdown): Deleted.
- 10:26 AM Changeset in webkit [267249] by
-
- 9 edits in trunk/Source
Add internal flag to enable/disable H264 hardware encoder
https://bugs.webkit.org/show_bug.cgi?id=216534
Reviewed by Eric Carlson.
Source/WebCore:
Update process-wide hardware H264 boolean flag based on internal feature flag.
No change of behavior.
- platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
(WebCore::LibWebRTCProvider::setH264HardwareEncoderAllowed):
- platform/mediastream/libwebrtc/LibWebRTCProvider.h:
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.cpp:
(WebCore::LibWebRTCProvider::setH264HardwareEncoderAllowed):
(WebCore::LibWebRTCProviderCocoa::~LibWebRTCProviderCocoa):
(WebCore::LibWebRTCProviderCocoa::setH264HardwareEncoderAllowed): Deleted.
- platform/mediastream/libwebrtc/LibWebRTCProviderCocoa.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setH264HardwareEncoderAllowed):
Source/WebKit:
- Shared/WebPreferencesInternal.yaml:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
- 10:19 AM Changeset in webkit [267248] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[ iOS wk2 ] compositing/clipping/border-radius-on-webgl.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215324
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 10:18 AM Changeset in webkit [267247] by
-
- 8 edits in branches/safari-610.2.6.1-branch/Source
Versioning.
WebKit-7610.2.6.1.1
- 10:15 AM Changeset in webkit [267246] by
-
- 10 edits in trunk
Hash deviceIds in WebProcess instead of UIProcess to allow audio output device IDs in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=216693
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/mediacapture-streams/MediaDevices-enumerateDevices-returned-objects.https-expected.txt:
Source/WebCore:
Make sure to create new MediaDeviceInfo objects everytime enumerateDevices is called.
Covered by updated tests.
- Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::computeDevices):
(WebCore::MediaDevices::enumerateDevices):
(WebCore::MediaDevices::refreshDevices): Deleted.
- Modules/mediastream/MediaDevices.h:
Source/WebKit:
- UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):
- UIProcess/UserMediaPermissionRequestManagerProxy.h:
LayoutTests:
- fast/mediastream/device-change-event-2.html:
- 10:13 AM Changeset in webkit [267245] by
-
- 11 edits1 copy53 adds5 deletes in trunk/LayoutTests
Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink
https://bugs.webkit.org/show_bug.cgi?id=216649
Reviewed by Eric Carlson.
Import Analyser / AudioBuffer / AudioBufferSource layout tests from Blink to extend
webaudio test coverage.
- webaudio/Analyser/automatic-pull-node-expected.txt: Added.
- webaudio/Analyser/automatic-pull-node.html: Added.
- webaudio/Analyser/handle-silent-inputs-expected.txt: Added.
- webaudio/Analyser/handle-silent-inputs.html: Added.
- webaudio/Analyser/realtimeanalyser-byte-data-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-byte-data.html: Added.
- webaudio/Analyser/realtimeanalyser-downmix-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-downmix.html: Added.
- webaudio/Analyser/realtimeanalyser-fftsize-reset-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-fftsize-reset.html: Added.
- webaudio/Analyser/realtimeanalyser-float-data-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-float-data.html: Added.
- webaudio/Analyser/realtimeanalyser-freq-data-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-freq-data-smoothing-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-freq-data-smoothing.html: Added.
- webaudio/Analyser/realtimeanalyser-freq-data.html: Added.
- webaudio/Analyser/realtimeanalyser-multiple-calls-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-multiple-calls.html: Added.
- webaudio/Analyser/realtimeanalyser-zero-expected.txt: Added.
- webaudio/Analyser/realtimeanalyser-zero.html: Added.
- webaudio/AudioBuffer/audiobuffer-resample-expected.txt: Added.
- webaudio/AudioBuffer/audiobuffer-resample.html: Added.
- webaudio/AudioBuffer/huge-buffer-expected.txt: Added.
- webaudio/AudioBuffer/huge-buffer.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulated-impulse.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulation-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-late-start-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-late-start.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-comprehensive.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-grain-no-duration.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-points-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-loop-points.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulated-impulse.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-playbackrate.html: Added.
- webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop-expected.txt: Added.
- webaudio/AudioBufferSource/audiobuffersource-premature-loop-stop.html: Added.
- webaudio/AudioBufferSource/resources/audiobuffersource-detune-modulation-expected.wav: Added.
- webaudio/AudioBufferSource/resources/audiobuffersource-loop-points-expected.wav: Added.
- webaudio/AudioBufferSource/resources/audiobuffersource-playbackrate-modulation-expected.wav: Added.
- webaudio/audiobuffersource-loop-comprehensive-expected.txt: Removed.
- webaudio/audiobuffersource-loop-comprehensive.html: Removed.
- webaudio/audiobuffersource-loop-points-expected.wav: Removed.
- webaudio/audiobuffersource-loop-points.html: Removed.
- webaudio/audiobuffersource-negative-playbackrate-interpolated-loop.html:
- webaudio/audiobuffersource-negative-playbackrate-interpolated.html:
- webaudio/audiobuffersource-negative-playbackrate-loop.html:
- webaudio/audiobuffersource-negative-playbackrate.html:
- webaudio/audiobuffersource-playbackrate-expected.wav: Removed.
- webaudio/audiobuffersource-start.html:
- webaudio/resources/audiobuffersource-testing-legacy.js: Copied from LayoutTests/webaudio/resources/audiobuffersource-testing.js.
(createTestBuffer):
(createRamp):
(checkSingleTest):
(checkAllTests):
- webaudio/resources/audiobuffersource-testing.js:
(createTestBuffer):
(checkSingleTest):
(checkAllTests):
(createSawtoothWithModulation):
- webaudio/resources/buffer-loader.js:
(BufferLoader):
(request.onload):
(request.onerror):
(BufferLoader.prototype.loadBuffer):
(BufferLoader.prototype.load):
- webaudio/resources/fft.js: Added.
(FFT):
(this.toString):
(FFT.prototype.FFTException):
(FFT.prototype.FFTRadix2Core):
(FFT.prototype.fft):
(FFT.prototype.iFFTRadix2Core):
(FFT.prototype.ifft):
(FFT.prototype.ifftScale):
(FFT.prototype.RFFTRadix2CoreStage1):
(FFT.prototype.rfft):
- webaudio/resources/realtimeanalyser-testing.js: Added.
(createGraph):
(applyWindow):
(computeFFTMagnitude):
(dbToLinear):
(linearToDb):
(clipMagnitude):
(compareFloatFreq):
(smoothFFT):
(convertFloatToByte):
- 10:08 AM Changeset in webkit [267244] by
-
- 1 copy in branches/safari-610.2.6.1-branch
New branch.
- 10:03 AM Changeset in webkit [267243] by
-
- 12 edits1 delete in trunk
REGRESSION(r254031): Captions fail to load on jw.org
https://bugs.webkit.org/show_bug.cgi?id=216672
<rdar://problem/69016059>
Reviewed by Eric Carlson.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/cloneNode-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-data-url-expected.txt:
- web-platform-tests/service-workers/service-worker/webvtt-cross-origin.https-expected.txt:
Source/WebCore:
Revert r254031.
- loader/TextTrackLoader.cpp:
(WebCore::TextTrackLoader::load):
LayoutTests:
- http/tests/security/contentSecurityPolicy/resources/track.php: Removed.
- http/tests/security/contentSecurityPolicy/track-redirect-allowed.html:
- http/tests/security/contentSecurityPolicy/track-redirect-allowed2.html:
- http/tests/security/contentSecurityPolicy/track-redirect-blocked.html:
- http/tests/security/text-track-crossorigin-expected.txt:
- http/tests/security/text-track-crossorigin.html:
- 10:02 AM Changeset in webkit [267242] by
-
- 2 edits in branches/safari-610-branch/Tools
Cherry-pick r267224. rdar://problem/57029120
Unreviewed test gardening for rdar://57029120.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:43 AM Changeset in webkit [267241] by
-
- 2 edits in trunk/Source/WebCore
[macOS Big Sur] ASSERTION FAILED: !m_gamepadMap.get(device)./platform/gamepad/mac/HIDGamepadProvider.mm(233) under WebCore::HIDGamepadProvider::deviceAdded
https://bugs.webkit.org/show_bug.cgi?id=216665
<rdar://problem/68641574>
Reviewed by Alex Christensen.
On macOS Big Sur, it appears we get notified multiple times that the Shenzhen Longshengwei Technology Gamepad
is getting added during Gamepad.GCFVersusHID API test. This was causing an assertion to be hit under
HIDGamepadProvider::deviceAdded() where we expected the device not not already be in the map. In this patch,
we work around this HID quirk on Big Sur by ignoring the notification if we already know about the device.
No new tests, fixes existing API test.
- platform/gamepad/mac/HIDGamepadProvider.mm:
(WebCore::HIDGamepadProvider::deviceAdded):
- 9:43 AM Changeset in webkit [267240] by
-
- 2 edits in trunk/Source/WebCore
Vectorize SetTargetAtTime processing in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=216673
<rdar://problem/69111432>
Reviewed by Sam Weinig.
Fix the SSE implementation of VectorMath::vsadd() to properly deal with source
and destination alignment, similarly to what is done in other VectorMath functions.
No new tests, fixes existing crash on GTK bots.
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsadd):
- 9:32 AM Changeset in webkit [267239] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unified build fixes from ARMv7 build failures
https://bugs.webkit.org/show_bug.cgi?id=216698
Reviewed by Adrian Perez de Castro.
- llint/LLIntThunks.cpp:
- runtime/FileBasedFuzzerAgent.cpp:
- runtime/FunctionExecutableDump.cpp:
- runtime/NativeExecutable.cpp:
- runtime/WeakMapImpl.cpp:
- 8:24 AM Changeset in webkit [267238] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline imported/w3c/web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest.html.
- web-platform-tests/webaudio/the-audio-api/the-mediaelementaudiosourcenode-interface/mediaElementAudioSourceToScriptProcessorTest-expected.txt:
- 8:13 AM Changeset in webkit [267237] by
-
- 6 edits in trunk/Source/WebKit
Unified build fixes in media code
https://bugs.webkit.org/show_bug.cgi?id=216691
Reviewed by Sam Weinig.
Add missing includes and/or missing undef.
No change of behavior.
- GPUProcess/webrtc/RemoteAudioMediaStreamTrackRenderer.cpp:
- GPUProcess/webrtc/RemoteMediaRecorder.cpp:
- WebProcess/WebPage/WebPageOverlay.h:
- WebProcess/cocoa/RemoteRealtimeMediaSource.cpp:
- WebProcess/cocoa/RemoteRealtimeMediaSource.h:
- 5:15 AM Changeset in webkit [267236] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Move computedLineLogicalRect to InlineFormattingContext::Geometry
https://bugs.webkit.org/show_bug.cgi?id=216680
Reviewed by Simon Fraser.
This function computes line geometry. It belongs in InlineFormattingContext::Geometry.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const): Deleted.
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::computedLineLogicalRect const):
- 4:23 AM Changeset in webkit [267235] by
-
- 2 edits in trunk/Source/WebKit
Enable paint timing by default
https://bugs.webkit.org/show_bug.cgi?id=211736
Reviewed by Simon Fraser.
- Shared/WebPreferencesExperimental.yaml:
PaintTimingEnabled default to true.
- 4:16 AM Changeset in webkit [267234] by
-
- 9 edits in trunk/Source/WebCore
[LFC][IFC] Move inline box constructing and alignment logic to LineBoxBuilder
https://bugs.webkit.org/show_bug.cgi?id=216678
Reviewed by Simon Fraser.
Move the LineBox related logic out of the LineBox class to InlineFormattingContext::Geometry::LineBoxBuilder.
This makes the LineBox class a light, box like class that we can cache in the InlineFormattingState.
- layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computedLineLogicalRect const):
(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):
- layout/inlineformatting/InlineFormattingContext.h:
- layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::LineBoxBuilder::formattingContext const):
(WebCore::Layout::LineBoxBuilder::root const):
(WebCore::Layout::LineBoxBuilder::layoutState const):
(WebCore::Layout::HangingContent::width const):
(WebCore::Layout::HangingContent::isConditional const):
(WebCore::Layout::HangingContent::setIsConditional):
(WebCore::Layout::HangingContent::expand):
(WebCore::Layout::HangingContent::reset):
(WebCore::Layout::collectHangingContent):
(WebCore::Layout::horizontalAlignmentOffset):
(WebCore::Layout::LineBoxBuilder::LineBoxBuilder):
(WebCore::Layout::LineBoxBuilder::build):
(WebCore::Layout::LineBoxBuilder::constructInlineBoxes):
(WebCore::Layout::LineBoxBuilder::computeInlineBoxesLogicalHeight):
(WebCore::Layout::LineBoxBuilder::alignInlineBoxesVerticallyAndComputeLineBoxHeight):
(WebCore::Layout::InlineFormattingContext::Geometry::lineBoxForLineContent):
- layout/inlineformatting/InlineLine.cpp:
- layout/inlineformatting/InlineLineBox.cpp:
(WebCore::Layout::LineBox::InlineBox::InlineBox):
(WebCore::Layout::LineBox::LineBox):
(WebCore::Layout::m_isLineVisuallyEmpty):
(WebCore::Layout::LineBox::addRootInlineBox):
(WebCore::Layout::LineBox::addInlineBox):
(WebCore::Layout::HangingContent::width const): Deleted.
(WebCore::Layout::HangingContent::isConditional const): Deleted.
(WebCore::Layout::HangingContent::setIsConditional): Deleted.
(WebCore::Layout::HangingContent::expand): Deleted.
(WebCore::Layout::HangingContent::reset): Deleted.
(WebCore::Layout::collectHangingContent): Deleted.
(WebCore::Layout::horizontalAlignmentOffset): Deleted.
(WebCore::Layout::m_inlineFormattingContext): Deleted.
(WebCore::Layout::LineBox::constructInlineBoxes): Deleted.
(WebCore::Layout::LineBox::computeInlineBoxesLogicalHeight): Deleted.
(WebCore::Layout::LineBox::alignInlineBoxesVerticallyAndComputeLineBoxHeight): Deleted.
(WebCore::Layout::LineBox::formattingContext const): Deleted.
(WebCore::Layout::LineBox::root const): Deleted.
(WebCore::Layout::LineBox::layoutState const): Deleted.
- layout/inlineformatting/InlineLineBox.h:
(WebCore::Layout::LineBox::alignmentBaseline const):
(WebCore::Layout::LineBox::setLogicalHeight):
(WebCore::Layout::LineBox::setHorizontalAlignmentOffset):
(WebCore::Layout::LineBox::rootInlineBox):
(WebCore::Layout::LineBox::nonRootInlineBoxes const):
(WebCore::Layout::LineBox::inlineBoxForLayoutBox):
- layout/inlineformatting/InlineLineBuilder.cpp:
(WebCore::Layout::LineBuilder::layoutInlineContent):
- layout/inlineformatting/InlineLineBuilder.h:
- 4:10 AM Changeset in webkit [267233] by
-
- 2 edits in trunk/LayoutTests
[WPE] Unreviewed test gardening. Mark several fast/layoutformattingcontext as failure after r267024.
- platform/wpe/TestExpectations:
- 3:35 AM WebKitGTK/2.30.x edited by
- (diff)
- 2:18 AM Changeset in webkit [267232] by
-
- 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebCore/platform/gtk/po
Merge r267228 - [l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=216436
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2020-09-18
Rubber-stamped by Carlos Garcia Campos.
- pt_BR.po:
- 2:18 AM Changeset in webkit [267231] by
-
- 4 edits in releases/WebKitGTK/webkit-2.30
Merge r267226 - [GTK] Epiphany does not make connections in Incognito Mode after clearing .cache
https://bugs.webkit.org/show_bug.cgi?id=216430
Reviewed by Adrian Perez de Castro.
Source/WebKit:
The problem is that when using an ephemeral context, the download is started before the ephemeral session has
been registered in the network process, so it's just ignored.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createDownloadProxy): Pass the given WebsiteDataStore to ensureNetworkProcess().
Tools:
Add unit test to check we can start downloads in ephemeral sessions before a web view is created.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadEphemeralContext):
(beforeAll):
- 2:17 AM Changeset in webkit [267230] by
-
- 2 edits in releases/WebKitGTK/webkit-2.30/Source/WebKit
Unreviewed. [GTK] Add an env var to force single process model
WEBKIT_USE_SINGLE_WEB_PROCESS=1 can be used to force the single process model when PSON is disabled. This is a
temporary solution for applications still depending on the single process mode behavior. It will be only
available in 2.28 series.
- UIProcess/API/glib/WebKitWebContext.cpp:
(webkitWebContextConstructed):
- 1:20 AM Changeset in webkit [267229] by
-
- 2 edits in trunk/Tools
[ews] Set only one worker for JSC ARMv7 builder and tester queues
https://bugs.webkit.org/show_bug.cgi?id=216476
Reviewed by Aakash Jain.
Currently many builds are failing in EWS JSC ARMv7 tester queue due to
a linking error in libicu. The problem lies on the boards that are
used to run the tests which have different system libraries.
Temporarily use one single builder and tester producing binaries compatible
with the boards.
- BuildSlaveSupport/ews-build/config.json:
- 1:19 AM Changeset in webkit [267228] by
-
- 2 edits in trunk/Source/WebCore/platform/gtk/po
[l10n] [pt_BR] Updated Brazilian Portuguese translation
https://bugs.webkit.org/show_bug.cgi?id=216436
Patch by Rafael Fontenelle <rafaelff@gnome.org> on 2020-09-18
Rubber-stamped by Carlos Garcia Campos.
- pt_BR.po:
- 1:15 AM Changeset in webkit [267227] by
-
- 23 edits5 adds in trunk
XHR.timeout is affected by long tasks
https://bugs.webkit.org/show_bug.cgi?id=216266
<rdar://problem/68908150>
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/xhr/xhr-timeout-longtask.any-expected.txt: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.html: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.js: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.worker-expected.txt: Added.
- web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html: Added.
Source/WebCore:
Long tasks may block the main thread, which may block IPC processing of load messages.
In that case, even though the load is finished, WebProcess did not know that yet and will cancel the load.
To prevent that, in case of XHR timeout, do an explicit check to compute the done flag.
https://fetch.spec.whatwg.org/#done-flag
Tests: imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.html
imported/w3c/web-platform-tests/xhr/xhr-timeout-longtask.any.worker.html
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::computeIsDone):
- loader/DocumentThreadableLoader.h:
- loader/LoaderStrategy.h:
- loader/ThreadableLoader.h:
- loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::notifyIsDone):
- loader/ThreadableLoaderClientWrapper.h:
(WebCore::ThreadableLoaderClientWrapper::notifyIsDone):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::computeIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::computeIsDone):
(WebCore::WorkerThreadableLoader::MainThreadBridge::notifyIsDone):
- loader/WorkerThreadableLoader.h:
(WebCore::WorkerThreadableLoader::MainThreadBridge::loaderProxy):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReachTimeout):
(WebCore::XMLHttpRequest::notifyIsDone):
- xml/XMLHttpRequest.h:
Source/WebKit:
Go to network process to know whether a load is finished or not.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::isResourceLoadFinished):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkConnectionToWebProcess.messages.in:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::isResourceLoadFinished):
- WebProcess/Network/WebLoaderStrategy.h:
Source/WebKitLegacy:
- WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::isResourceLoadFinished):
- WebCoreSupport/WebResourceLoadScheduler.h:
LayoutTests:
platform/mac-wk1/TestExpectations: Skip WK1 test.
- 1:14 AM Changeset in webkit [267226] by
-
- 4 edits in trunk
[GTK] Epiphany does not make connections in Incognito Mode after clearing .cache
https://bugs.webkit.org/show_bug.cgi?id=216430
Reviewed by Adrian Perez de Castro.
Source/WebKit:
The problem is that when using an ephemeral context, the download is started before the ephemeral session has
been registered in the network process, so it's just ignored.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::createDownloadProxy): Pass the given WebsiteDataStore to ensureNetworkProcess().
Tools:
Add unit test to check we can start downloads in ephemeral sessions before a web view is created.
- TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
(testDownloadEphemeralContext):
(beforeAll):
- 12:38 AM Changeset in webkit [267225] by
-
- 4 edits in trunk/Source/WebKit
Enable MediaRecorder by default on MacOS
https://bugs.webkit.org/show_bug.cgi?id=216663
Reviewed by Eric Carlson.
- Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultMediaRecorderEnabled):
- Shared/WebPreferencesDefaultValues.h:
- Shared/WebPreferencesExperimental.yaml:
Sep 17, 2020:
- 9:54 PM Changeset in webkit [267224] by
-
- 2 edits in trunk/Tools
Unreviewed test gardening for rdar://57029120.
- TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
- 9:11 PM Changeset in webkit [267223] by
-
- 2 edits in branches/safari-610-branch/Tools
Cherry-pick r266182. rdar://problem/66950074
TestWebKitAPI.AudioRoutingArbitration.Deletion is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=215856
<rdar://problem/66950074>
Reviewed by Jer Noble.
This test deletes a video element by removing it from the DOM, and verifies that
arbitration status changes appropriately. Arbitration status isn't changed until
the element's destructor runs, and that doesn't happen until it is garbage collected
so force GC while waiting for the status to change.
- TestWebKitAPI/Tests/WebKitCocoa/AudioRoutingArbitration.mm: (AudioRoutingArbitration::statusShouldBecomeEqualTo): Add optional parameter to force GC while waiting for status to change. (TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266182 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 7:08 PM Changeset in webkit [267222] by
-
- 31 edits in trunk
Remove runtime setting for enabling/disabling the UserTiming and ResourceTiming APIs
https://bugs.webkit.org/show_bug.cgi?id=216556
Reviewed by Darin Adler.
Remove runtime setting for enabling/disabling UserTiming and ResourceTiming
APIs. They have both been on for a while in WebKit2 and there aren't any
known uses cases for disabling them. In addition to removing the setting,
they are now enabled in LegacyWebKit as well.
Source/WebCore:
In addition to removing UserTiming and ResourceTiming, we can also remove the
checks for PerformanceTimelineEnabled, as that was defined entirely in terms
of the former.
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
(WebCore::ResourceTimingInformation::storeResourceTimingInitiatorInformation):
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportResourceTiming):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
- page/Performance.idl:
- page/PerformanceEntry.cpp:
(WebCore::PerformanceEntry::parseEntryTypeString):
- page/PerformanceEntry.idl:
- page/PerformanceObserver.idl:
- page/PerformanceObserverEntryList.idl:
- page/PerformanceResourceTiming.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setResourceTimingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::resourceTimingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setUserTimingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::userTimingEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::performanceTimelineEnabled const): Deleted.
Source/WebKit:
- Shared/WebPreferences.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetUserTimingEnabled):
(WKPreferencesGetUserTimingEnabled):
(WKPreferencesSetResourceTimingEnabled):
(WKPreferencesGetResourceTimingEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
Source/WebKitLegacy/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences setUserTimingEnabled:]):
(-[WebPreferences userTimingEnabled]):
(-[WebPreferences setResourceTimingEnabled:]):
(-[WebPreferences resourceTimingEnabled]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setUserTimingEnabled):
(WebPreferences::userTimingEnabled):
(WebPreferences::setResourceTimingEnabled):
(WebPreferences::resourceTimingEnabled):
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
- 7:06 PM Changeset in webkit [267221] by
-
- 2 edits in trunk/Source/JavaScriptCore
Use OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) in speculationFromCell()'s isSanePointer().
https://bugs.webkit.org/show_bug.cgi?id=216638
Reviewed by Saam Barati.
We should be using OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) instead of assuming the
width of the pointer address bits.
- bytecode/SpeculatedType.cpp:
(JSC::isSanePointer):
- 6:45 PM Changeset in webkit [267220] by
-
- 23 edits in trunk
Selection API: Introduce LiveRangeSelectionEnabled, off by default
https://bugs.webkit.org/show_bug.cgi?id=216656
Reviewed by Sam Weinig.
Source/WebCore:
For interoperability, the Selection API requires behavior that is quite different
from how our Selection object has behaves historically. Specifically, the range
returned is a live range that update as the selection updates and the selection,
in turn, is updated if the returned range is modified.
This significant change will have compatibility impact on websites and other
content that assumes the legacy WebKit behavior, so we are developing it behind
a feature flag, LiveRangeSelectionEnabled.
This patch introduces the live range selection behind the flag, but leaves one
significant area unresolved, changing selection to keep track of the original
endpoints rather than only canonicalized endpoints, and a couple of loose ends,
lifetime of ride-along properties on the live range object, and updating test
expectations for the new behavior.
- dom/CharacterData.cpp:
(WebCore::CharacterData::setData): Fixed timing of call to Document::textRemoved
by letting setDataAndUpdate do it; otherwise it can be called after the selection
has been updated, and the range gets updated twice.
(WebCore::CharacterData::appendData): Pass UpdateLiveRanges::No to setDataAndUpdate,
to preserve the existing "don't update ranges" behavior for now at least.
(WebCore::CharacterData::insertData): Fixed timing of call to Document::textInserted
by letting setDataAndUpdate do it, for the same reason as above.
(WebCore::CharacterData::deleteData): Ditto, for textRemoved.
(WebCore::CharacterData::replaceData): Ditto, for textRemoved and textInserted.
(WebCore::CharacterData::setDataAndUpdate): Added UpdateLiveRanges argument and
calls to textRemoved and textInserted, after setting data, but before other updates.
- dom/CharacterData.h: Made setDataAndUpdate protected and added UpdateLiveRanges.
- dom/Document.h: Added optimized version of the Node::contains function. When the
node in question is the document we can just check treeScope and isConnected
rather than walking up the tree.
- dom/Node.cpp:
(WebCore::Node::isDescendantOf const): Moved special case for document to the top
of the function; seems a more important special case than disconnected nodes and
nodes with no children.
(WebCore::Node::isDescendantOrShadowDescendantOf const): Reworded the FIXME for clarity.
(WebCore::Node::contains const): Changed this to toke a reference instead of a pointer.
The pointer flavor is now inlined in the header.
- dom/Node.h: Added an overload of contains that takes a reference, analogous to what
we already have for isDescendantOf.
- dom/Position.cpp:
(WebCore::Position::Position): Removed too-strict assertions. When we start using
positions to represent arbitrary DOM positions for things outside editing we won't
want these assertions any more, and we hit them when we use Position in a more
straightforward way, like some cases in this patch.
(WebCore::Position::primaryDirection const): Added a missing null check. This case
is hit in some test cases in the new mode.
- dom/Range.cpp: Removed some, but probably not all, of the unneeded headers.
(WebCore::Range::~Range): Added an assertion.
(WebCore::Range::updateAssociatedSelection): Added. Tells FrameSelection to update
the selection when this is the live range associated with the selection.
(WebCore::Range::updateDocument): Added an assertion.
(WebCore::Range::setStart): Call updateAssociatedSelection.
(WebCore::Range::setEnd): Ditto.
(WebCore::Range::collapse): Ditto.
(WebCore::Range::processContents): Call collapse here to share slightly more
code so we don't have to call updateAssociatedSelection here.
(WebCore::Range::checkNodeOffsetPair): Made this a static function so it can
be used outside the Range class. Also fixed indentation of the switch statement.
(WebCore::Range::selectNodeContents): Call updateAssociatedSelection and
updateDocument.
(WebCore::setBothEndpoints): Added.
(WebCore::Range::updateFromSelection): Added. Uses setBothEndpoints.
(WebCore::createLiveRange): Refactored to call setBothEndpoints.
- dom/Range.h: Added didAssociateWithSelection, didDisassociateFromSelection,
updateFromSelection, updateAssociatedSelection, and m_isAssociatedWithSelection.
Also made checkNodeOffsetPair a public static member function instead of a
private non-static member function.
- dom/Text.cpp:
(WebCore::Text::setDataAndUpdate): Update to pass along UpdateLiveRanges argument.
- dom/Text.h: Ditto. Also made the override of setDataAndUpdate private.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::setSelectionWithoutUpdatingAppearance): Call
updateAssociatedLiveRange after updating the selection.
(WebCore::containsEndpoints): Added. Used to check if a live range still has the
document as its root node so it can remain associated this with the selection.
(WebCore::FrameSelection::associatedLiveRange): Added.
(WebCore::FrameSelection::disassociateLiveRange): Added.
(WebCore::FrameSelection::associateLiveRange): Added.
(WebCore::FrameSelection::updateFromAssociatedLiveRange): Added.
(WebCore::FrameSelection::updateAssociatedLiveRange): Added.
- editing/FrameSelection.h: Added associatedLiveRange, associateLiveRange,
disassociateLiveRange, updateFromAssociatedLiveRange, updateAssociatedLiveRange,
and m_associatedLiveRange. Also change m_document to a WeakPtr and do some
tidying up.
- page/DOMSelection.cpp:
(WebCore::selectionShadowAncestor): Assert the live range setting is false,
since this code is not used in that case. Changed the return type to RefPtr.
Address the FIXME here by getting the document in a simpler way.
(WebCore::DOMSelection::create): Moved here from the header.
(WebCore::DOMSelection::frame const): Added. Returns a RefPtr. This gets rid
of the need for various instances of the "protector" pattern in this file.
(WebCore::DOMSelection::range const): Added. Returns the selected range, but
checks for the shadow tree case and returns null in that case.
(WebCore::DOMSelection::anchorPosition const): Redid as a member function.
(WebCore::DOMSelection::focusPosition const): Ditto.
(WebCore::DOMSelection::basePosition const): Ditto.
(WebCore::DOMSelection::extentPosition const): Ditto.
(WebCore::DOMSelection::anchorNode const): Rewrote to be simpler using the
functions above.
(WebCore::DOMSelection::anchorOffset const): Ditto.
(WebCore::DOMSelection::focusNode const): Ditto.
(WebCore::DOMSelection::focusOffset const): Ditto.
(WebCore::DOMSelection::baseNode const): Ditto.
(WebCore::DOMSelection::baseOffset const): Ditto.
(WebCore::DOMSelection::extentNode const): Ditto.
(WebCore::DOMSelection::extentOffset const): Ditto.
(WebCore::DOMSelection::isCollapsed const): Rewrote using DOMSelection::range
and SimpleRange::collapsed.
(WebCore::DOMSelection::type const): Updated since frame returns RefPtr.
(WebCore::DOMSelection::rangeCount const): Ditto.
(WebCore::DOMSelection::collapse): Added new corrected checking for special
cases, guarded by the setting.
(WebCore::DOMSelection::collapseToEnd): Updated since frame returns RefPtr.
way to do protection. Added a call to disassociateLiveRange. No need to put
under a setting guard since it does nothing if feature is not enabled.
(WebCore::DOMSelection::collapseToStart): Ditto.
(WebCore::DOMSelection::empty): Call removeAllRanges so we don't have two
copies of the same function to maintain.
(WebCore::DOMSelection::setBaseAndExtent): Use makeRefPtr, added corrected
checking for special cases guarded by the setting.
(WebCore::DOMSelection::setPosition): Call collapse so we don't have two
copies of the same function to maintain.
(WebCore::DOMSelection::modify): Updated since frame returns RefPtr.
(WebCore::DOMSelection::extend): Ditto. Also added corrected checking for
special cases guarded by the setting.
(WebCore::DOMSelection::getRangeAt): Added a version of this function that
simply returns the associated live range, creating one if needed, guarded
by the setting.
(WebCore::DOMSelection::removeAllRanges): Updated since frame returns RefPtr.
(WebCore::DOMSelection::addRange): Added a version of this function that
matches the specification, guarded by the setting.
(WebCore::DOMSelection::removeRange): Added.
(WebCore::DOMSelection::deleteFromDocument): Added a version of this
function that simply calls deleteContents on the associated live range,
guarded by the setting.
(WebCore::DOMSelection::containsNode const): Put the text node workaround
inside a setting check. I also figured out why workaround was added: it
works around unwanted range canonicalization in various tests, but also
introduces incorrect behavior. Also rewrote to use DOMSelection::range.
(WebCore::DOMSelection::toString): Use DOMSelection::range, guarded by
the setting, so we return empty string when selection is in the shadow tree.
(WebCore::DOMSelection::shadowAdjustedNode const): When the live range
setting is enabled, adjust by changing the node to nullptr, not finding an
ancestor in the document.
(WebCore::DOMSelection::shadowAdjustedOffset const): Ditto, but offset 0.
(WebCore::DOMSelection::isValidForPosition const): Assert that the live range
selection setting is disabled, because this incorrect check should only be
used to preserve legacy behavior until we are ready to turn it on.
- page/DOMSelection.h: Updated since setBaseAndExtent, setPosition, and
collapse can raise exceptions, although they only do so when the live range
selection setting is on. Added removeRange. Moved the create function
out of the class definition into the .cpp file. Made return values of
baseNode, extentNode, anchorNode, focusNode, and shadowAdjustedNode RefPtr.
Made toString const. Added frame, range, anchorPosition, focusPosition,
basePosition, and extentPosition private functions. Removed visibleSelection.
- page/DOMSelection.idl: Updated file to match a recent draft of the
Selection standard, reordering things to match the order they appear there.
Added removeRange, guarded by the setting. Also got rid of the
unncecessary "undefined" string defaults for the arguments to the modify
method since they have no effect on observed behavior anyway.
- page/Settings.yaml: Added liveRangeSelectionEnabled.
Source/WebKit:
- Shared/WebPreferencesInternal.yaml: Added LiveRangeSelectionEnabled.
LayoutTests:
- editing/selection/move-to-line-boundary-clear-selection.html: Fix test that accidentally
relied on our non-standard behavior of clamping a too-high offset to a valid value. This
was not what we were trying to test. Without this change, the test fails in the new mode.
The offset was "5", which seems to be a character count, rather than "1", meaning "after
the text node".
- editing/selection/toString-1.html: Ditto. The offset here was 3, but the HTML element
has only 2 children, the head and the body.
- editing/selection/user-select-all-selection.html: Ditto. The code was passing the wrong
container by acccident, the parent of the text node rather than the text node.
- 6:44 PM Changeset in webkit [267219] by
-
- 5 edits in trunk/Source
Web Inspector: REGRESSION(r266885): fix open source build
https://bugs.webkit.org/show_bug.cgi?id=216675
Reviewed by Timothy Hatcher.
Add back methods used by
WebInspector.framework.
Source/JavaScriptCore:
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::getInteger): Added.
(Inspector::BackendDispatcher::getDouble): Added.
(Inspector::BackendDispatcher::getString): Added.
Source/WTF:
- wtf/JSONValues.h:
- wtf/JSONValues.cpp:
(WTF::JSONImpl::Value::asDouble const): Added.
(WTF::JSONImpl::Value::asInteger const): Added.
(WTF::JSONImpl::Value::asString const): Added.
(WTF::JSONImpl::ObjectBase::getBoolean const): Added.
(WTF::JSONImpl::ObjectBase::getString const): Added.
(WTF::JSONImpl::ObjectBase::getObject const): Added.
(WTF::JSONImpl::ObjectBase::getArray const): Added.
(WTF::JSONImpl::ObjectBase::getValue const): Added.
- 6:33 PM Changeset in webkit [267218] by
-
- 11 edits2 deletes in trunk
Vectorize SetTargetAtTime processing in AudioParamTimeline
https://bugs.webkit.org/show_bug.cgi?id=216673
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline WPT tests now that more checks are passing.
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setTargetAtTime-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/event-insertion-expected.txt:
- web-platform-tests/webaudio/the-audio-api/the-constantsourcenode-interface/test-constantsourcenode-expected.txt:
Source/WebCore:
Vectorize SetTargetAtTime processing in AudioParamTimeline.
The patch is based on the Blink implementation at:
I have however added the USE(ACCELERATE) and HAVE(ARM_NEON_INTRINSICS) implementations
for DARWIN and non-SSE platforms.
This allows us to pass some more tests that we were failing merely due to precision
issues. Now that our implemention matches Blink's, our results are consistent
with Blink.
No new tests, rebaselined existing tests.
- Modules/webaudio/AudioParamTimeline.cpp:
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):
(WebCore::AudioParamTimeline::processSetTarget):
- Modules/webaudio/AudioParamTimeline.h:
- platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsadd):
(WebCore::VectorMath::vsmul):
- platform/audio/VectorMath.h:
LayoutTests:
- webaudio/audioparam-cancel-and-hold-expected.txt:
Rebaseline test now that one more subtest is passing.
- webaudio/audioparam-setTargetAtTime-expected.txt: Removed.
- webaudio/audioparam-setTargetAtTime.html: Removed.
Remove outdated test now that it was upstreamed to WPT. The updated
copy resides at:
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/audioparam-setTargetAtTime.html
- 6:32 PM Changeset in webkit [267217] by
-
- 2 edits in branches/safari-610-branch/LayoutTests
[ iOS wk2 ] http/tests/websocket/tests/hybi/client-close-2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=215773
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- 6:17 PM Changeset in webkit [267216] by
-
- 3 edits1 add in trunk
Inconsistent loop exit assertion in B3ReduceLoopStrength
https://bugs.webkit.org/show_bug.cgi?id=216274
<rdar://problem/68513573>
Reviewed by Keith Miller.
JSTests:
- stress/reduce-loop-strength-multiple-exits.js: Added.
(build_array):
(main):
Source/JavaScriptCore:
On B3ReduceLoopStrength, we first calculate where the loop exits to, and ensure there's only
one exit target. Later on, we compute how many places within the loop exit to that single exit
target. Currently, we assume that having a single target implies that we'll only ever have one
exit point, which is incorrect. To fix it, instead of asserting there should only be one exit
point, we just bail if we find more than one.
- b3/B3ReduceLoopStrength.cpp:
(JSC::B3::ReduceLoopStrength::reduceByteCopyLoopsToMemcpy):
- 5:50 PM Changeset in webkit [267215] by
-
- 4 edits in trunk/Source
Per-app accent color overrides are broken
https://bugs.webkit.org/show_bug.cgi?id=216674
<rdar://problem/67745464>
Reviewed by Wenson Hsieh.
Source/WebCore/PAL:
- pal/spi/mac/NSApplicationSPI.h:
Source/WebKit:
No new tests; I've no idea how to write a test that would have caught this;
any test I can imagine would have also written to _accentColor and worked fine.
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::accentColor):
AppKit changed the meaning of the IPI. Use the correct version.
We still write to _accentColor; it is now purely an override.
- 5:33 PM Changeset in webkit [267214] by
-
- 3 edits in branches/safari-610-branch
Cherry-pick r267162. rdar://problem/69104937
REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216619
Reviewed by Chris Dumez.
Tools:
In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.
- WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
LayoutTests:
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@267162 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 3:50 PM Changeset in webkit [267213] by
-
- 1 copy in tags/Safari-610.2.6
Tag Safari-610.2.6.
- 3:50 PM Changeset in webkit [267212] by
-
- 1 delete in tags/Safari-610.2.6
Delete tag.
- 3:46 PM Changeset in webkit [267211] by
-
- 1 copy in tags/Safari-610.2.6
Tag Safari-610.2.6.
- 3:36 PM Changeset in webkit [267210] by
-
- 4 edits2 adds in trunk
[Cocoa] canPlayType('audio/mpeg; codecs="mp3"') returns ""
https://bugs.webkit.org/show_bug.cgi?id=147309
Reviewed by Darin Adler.
Source/WebCore:
'audio/mpeg; codecs="mp3"' is not an RFC 3003 compliant MIME type but some big
web sites use it. AVFoundation says the type is not supported, but MediaPlayerPrivateMediaSourceAVFObjC
previously returned "maybe" for all extended types where the container type is
supported. This bug was fixed when we moved the MIME type logic from MediaPlayerPrivateMediaSourceAVFObjC
to MIMETypeCache, so add a mechanism to override extended types and use it to
support 'audio/mpeg; codecs="mp3"'.
Test: media/media-can-play-mp3.html
- platform/graphics/MIMETypeCache.cpp:
(WebCore::MIMETypeCache::canDecodeType):
(WebCore::MIMETypeCache::overrideExtendedType):
- platform/graphics/MIMETypeCache.h:
LayoutTests:
- media/media-can-play-mp3-expected.txt: Added.
- media/media-can-play-mp3.html: Added.
- 2:45 PM Changeset in webkit [267209] by
-
- 8 edits in branches/safari-610-branch/Source
Versioning.
WebKit-7610.2.7
- 1:42 PM Changeset in webkit [267208] by
-
- 2 edits in trunk/Source/WebKit
Enable ITP in WKWebViews for apps with the full browser entitlement who are not linked to iOS 14.0
https://bugs.webkit.org/show_bug.cgi?id=216655
<rdar://problem/69081227>
Reviewed by Brent Fulgham.
Apps with the full browser entitlement who are not linked to iOS 14.0
should have ITP enabled in WKWebViews by default.
No new tests, no way currently to test apps with different iOS
versions. Tested manually.
- Shared/Cocoa/DefaultWebBrowserChecks.mm:
(WebKit::determineITPStateInternal):
Ignore the early return for the linked-on-or-after check if the
app has the default browser entitlement so we still enable ITP based
on the user's preference.
- 1:33 PM Changeset in webkit [267207] by
-
- 3 edits in branches/safari-610-branch/LayoutTests
Cherry-pick r266772. rdar://problem/69087333
[ iOS wk2 ] fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html is a constant failure
https://bugs.webkit.org/show_bug.cgi?id=216300
<rdar://problem/68542670>
Reviewed by Wenson Hsieh.
- fast/attachment/attachment-thumbnail-preserves-aspect-ratio.html: shouldBecomeDifferent only works if both of the strings it evals are evaluable in the global scope.
- platform/ios-wk2/TestExpectations: Remove the failure expectation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@266772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 1:21 PM Changeset in webkit [267206] by
-
- 2 edits in trunk/Source/WebKit
WebKit::XPCServiceEventHandler block should call exit() on the main thread
<https://webkit.org/b/216594>
<rdar://problem/68053217>
Reviewed by Chris Dumez.
- Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- Call exit() on the main thread. I chose dispatch_sync() here so that if other crashes occur on the main thread, we will know if this background thread is waiting to call exit() at the same time. Also, if a different background thread calls exit() in the future with this block running on the main thread, we'll know where the block came from since the XPC handler thread will be waiting for the dispatch_sync() to return (instead of having a mysterious block calling exit() on the main thread and not knowing where it came from).
- Add logging (including simulated crash logs) when either of these exit() code paths is taken.
- 12:52 PM Changeset in webkit [267205] by
-
- 3 edits2 adds in trunk
Segfault in WebCore::IDBKey::createBinary
https://bugs.webkit.org/show_bug.cgi?id=216501
Reviewed by Youenn Fablet.
Source/WebCore:
If we can't get a copy of the JSBufferView, return an invalid IDBKey.
This can happen if we are low on memory. The existing calling code already
handles the case where we might produce an invalid IDBKey.
Test: storage/indexeddb/IDBKey-create-array-buffer-view-oom.html
- Modules/indexeddb/IDBKey.cpp:
(WebCore::IDBKey::createBinary):
LayoutTests:
New test. Since this test is looking for the out of memory condition, the test is written
to avoid false failures in the case we can't achieve out of memory. That is when the
expected exception is not thrown.
- storage/indexeddb/IDBKey-create-array-buffer-view-oom-expected.txt: Added.
- storage/indexeddb/IDBKey-create-array-buffer-view-oom.html: Added.
- 12:28 PM Changeset in webkit [267204] by
-
- 7 edits in trunk/Source/WebCore
Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData
https://bugs.webkit.org/show_bug.cgi?id=216654
Reviewed by Simon Fraser.
Before we implemented the correct way to sort animations using KeyframeEffectStack, we relied on distinct animation collections
for CSS Transtions and CSS Animations and remaining Web Animations on ElementAnimationRareData. We don't need those anymore and
we can use a single collection which we can now name animations() for all animations.
Additionally, the AnimationTimeline::animationsForElement() method where these collections were used when requesting unsorted
animations was unnecessary and an incorrect design. Animations do not belong to a given timeline, so we now use the accessors
on ElementAnimationRareData directly to get the sorted list of effects or the single animations collection.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::willChangeRendererForElement):
(WebCore::AnimationTimeline::cancelDeclarativeAnimationsForElement):
(WebCore::AnimationTimeline::animationsForElement const): Deleted.
- animation/AnimationTimeline.h:
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::animationCanBeRemoved):
(WebCore::DocumentTimeline::computeExtentOfAnimation const):
(WebCore::DocumentTimeline::isRunningAnimationOnRenderer const):
(WebCore::DocumentTimeline::isRunningAcceleratedAnimationOnRenderer const):
(WebCore::DocumentTimeline::animatedStyleForRenderer):
(WebCore::DocumentTimeline::updateListOfElementsWithRunningAcceleratedAnimationsForElement):
- animation/ElementAnimationRareData.h:
(WebCore::ElementAnimationRareData::animations):
(WebCore::ElementAnimationRareData::webAnimations): Deleted.
(WebCore::ElementAnimationRareData::cssAnimations): Deleted.
(WebCore::ElementAnimationRareData::transitions): Deleted.
- dom/Element.cpp:
(WebCore::Element::animations const):
(WebCore::Element::ensureAnimations):
(WebCore::Element::getAnimations):
(WebCore::Element::webAnimations const): Deleted.
(WebCore::Element::cssAnimations const): Deleted.
(WebCore::Element::transitions const): Deleted.
(WebCore::Element::ensureWebAnimations): Deleted.
(WebCore::Element::ensureCSSAnimations): Deleted.
(WebCore::Element::ensureTransitions): Deleted.
- dom/Element.h:
- 11:54 AM Changeset in webkit [267203] by
-
- 10 edits in trunk/Source
Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks to clarify what this enum value is for.
https://bugs.webkit.org/show_bug.cgi?id=216651
Patch by Hoa Dinh <dvh@apple.com> on 2020-09-17
Reviewed by Alex Christensen.
Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks and reflects the change where it's used.
Source/WebCore:
Source/WebCore:
- loader/FrameLoaderTypes.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
Source/WebKit:
Source/WebKit:
- Shared/SessionState.cpp:
(WebKit::isValidEnum):
- UIProcess/API/APINavigationAction.h:
- UIProcess/API/glib/WebKitWebViewSessionState.cpp:
(toExternalURLsPolicy):
(toWebCoreExternalURLsPolicy):
- UIProcess/WebPageProxy.h:
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::decodeSessionHistoryEntry):
- WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
- 11:39 AM Changeset in webkit [267202] by
-
- 7 edits in trunk
AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent
https://bugs.webkit.org/show_bug.cgi?id=216629
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Rebaseline WPT test that is now passing.
- web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/test-analyser-minimum-expected.txt:
Source/WebCore:
AnalyserNode.getFloatFrequencyData() should fill array with -Infinity when input is silent.
This behavior is consistent with Gecko and Blink. Previously, we'd use AnalyserNode.minDecibels
instead.
No new tests, rebaselined existing test.
- Modules/webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::getFloatFrequencyData):
- platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::linearToDecibels):
- 11:10 AM Changeset in webkit [267201] by
-
- 7 edits1 add in trunk/LayoutTests
Regression(r267144) 4 webaudio/oscillator tests are broken
https://bugs.webkit.org/show_bug.cgi?id=216625
<rdar://problem/69024624>
Reviewed by Darin Adler.
- webaudio/oscillator-custom.html:
- webaudio/oscillator-sawtooth.html:
- webaudio/oscillator-sine.html:
- webaudio/oscillator-square.html:
- webaudio/oscillator-triangle.html:
Update tests to use oscillator-testing-legacy.js since they are not compatible
with the newer oscillator-testing.js that was resync'd from Blink.
- webaudio/oscillator-triangle-expected.wav:
Rebaseline test that has different output due to the fix in r267153.
- webaudio/resources/oscillator-testing-legacy.js: Added.
Restore old copy of oscillator-testing.js and rename it to oscillator-testing-legacy.js.
- 11:07 AM Changeset in webkit [267200] by
-
- 2 edits in trunk/Tools
[Flatpak SDK] bwrap: add pipewire socket as bind mount
https://bugs.webkit.org/show_bug.cgi?id=216606
Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2020-09-17
Reviewed by Philippe Normand.
Add pipewire socket to bwrap as a try binding mount.
- flatpak/webkit-bwrap:
- 10:54 AM Changeset in webkit [267199] by
-
- 4 edits3 adds in trunk
[JSC] Async generator default-export is not handled
https://bugs.webkit.org/show_bug.cgi?id=216643
Reviewed by Ross Kirsling.
JSTests:
- modules/async-generator-default.js: Added.
(from.string_appeared_here.import.test.from.string_appeared_here.async test2):
- modules/async-generator-default/module.js: Added.
(export.default.async test):
- test262/expectations.yaml:
Source/JavaScriptCore:
export default async function * test() { }syntax should be correctly handled.
This patch adds the code retrieving "test" name from the above declaration correctly.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseExportDeclaration):
- 10:47 AM Changeset in webkit [267198] by
-
- 2 edits in trunk/Source/WebCore
[iOS] YouTube does not route video to AirPlay the first time
https://bugs.webkit.org/show_bug.cgi?id=216626
<rdar://problem/62222846>
Reviewed by Eric Carlson.
Difficult to test this, since it requires an live AppleTV device.
During a refactor, the order of a couple calls changed. A MediaPlaybackTarget needs to be in place before the MediaPlayer can
be told to start playing to that target. Once the target is in-place, subsequent requests to start playing to that target succeed,
which explains the "only initial AirPlay fails" behavior.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(WebCore::MediaSessionManageriOS::activeVideoRouteDidChange):
- 10:45 AM Changeset in webkit [267197] by
-
- 3 edits in trunk/Tools
[ews] Re-enable api-gtk queue
https://bugs.webkit.org/show_bug.cgi?id=216647
Reviewed by Aakash Jain.
The queue was disabled temporarily in r266956.
- BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
- BuildSlaveSupport/ews-build/config.json:
- 10:17 AM Changeset in webkit [267196] by
-
- 4 edits3 adds in trunk
[JSC] Update JSModuleNamespaceObject::defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=216640
Reviewed by Ross Kirsling.
JSTests:
- modules/module-namespace-object-define-own-property.js: Added.
(from.string_appeared_here.import.as.ns.from.string_appeared_here.shouldThrow):
(shouldThrow):
(shouldThrow.):
(get TypeError):
- modules/module-namespace-object-define-own-property/module.js: Added.
- test262/expectations.yaml:
Source/JavaScriptCore:
This patch implements spec update of JSModuleNamespaceObject::defineOwnProperty.
We implement https://tc39.es/ecma262/#sec-module-namespace-exotic-objects-defineownproperty-p-desc precisely.
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
(JSC::JSModuleNamespaceObject::deleteProperty):
(JSC::JSModuleNamespaceObject::getOwnPropertyNames):
(JSC::JSModuleNamespaceObject::defineOwnProperty):
- 10:08 AM Changeset in webkit [267195] by
-
- 2 edits in trunk/LayoutTests
[WPE] Unreviewed gardening. Several fast/events/mouse-* tests are flaky after r264117.
The test started failing somewhere between r264103-r264117.
- platform/wpe/TestExpectations:
- 9:17 AM Changeset in webkit [267194] by
-
- 5 edits in trunk/Source/WebKit
We shouldn't need to specify a category for preferences now that they are split into separate files
https://bugs.webkit.org/show_bug.cgi?id=216648
Reviewed by Tim Horton.
Remove need / ability to specify a category in the yaml, rather, infer the category
from which file it is in.
- Scripts/GeneratePreferences.rb:
- Shared/WebPreferencesDebug.yaml:
- Shared/WebPreferencesExperimental.yaml:
- Shared/WebPreferencesInternal.yaml:
- 8:59 AM Changeset in webkit [267193] by
-
- 4 edits in trunk/LayoutTests
[WPE] Unreviewed gardening. Update baselines after r20056.
- platform/glib/imported/w3c/web-platform-tests/selection/selection-select-all-move-input-crash-expected.txt:
- platform/wpe/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt: Updated after r266510.
- platform/wpe/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt: Updated after r266399.
- 8:43 AM Changeset in webkit [267192] by
-
- 4 edits in trunk/Source/JavaScriptCore
Add some pointer sanity checks to speculationFromCell().
https://bugs.webkit.org/show_bug.cgi?id=216638
rdar://23226333
Reviewed by Yusuke Suzuki.
Add some sanity checks to mitigate against some potential pointer corruptions
from profiling data. The goal here is not to exhaustively filter out all possible
bad pointers, but simply to filter out as many as possible to reduce crashes from
such bad pointers, and to do so with the least possible performance impact.
It is OK to do such filtering here because we're only trying to compute a
SpeculatedType from the pointer. If the pointer is bad, we can just return
SpecNone indicating that we don't have any info to speculate on.
- bytecode/SpeculatedType.cpp:
(JSC::isSanePointer):
(JSC::speculationFromCell):
- runtime/StructureIDTable.h:
(JSC::StructureIDTable::tryGet):
- runtime/VM.h:
(JSC::VM::tryGetStructure):
- 8:07 AM Changeset in webkit [267191] by
-
- 12 edits in trunk/Source/WebCore
Style::Change should be enum class
https://bugs.webkit.org/show_bug.cgi?id=216644
Reviewed by Sam Weinig.
Also improve the names of the values.
- dom/Document.cpp:
(WebCore::Document::resolveStyle):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::willRecalcStyle):
- rendering/updating/RenderTreeBuilderFirstLetter.cpp:
(WebCore::RenderTreeBuilder::FirstLetter::updateStyle):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateAfterDescendants):
(WebCore::RenderTreeUpdater::updateElementRenderer):
- rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::updatePseudoElement):
- style/StyleChange.cpp:
(WebCore::Style::determineChange):
- style/StyleChange.h:
(): Deleted.
- style/StyleTreeResolver.cpp:
(WebCore::Style::computeDescendantsToResolve):
(WebCore::Style::TreeResolver::resolveElement):
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
(WebCore::Style::TreeResolver::resolveComposedTree):
- style/StyleTreeResolver.h:
- style/StyleUpdate.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::willRecalcStyle):
- 7:44 AM Changeset in webkit [267190] by
-
- 2 edits in trunk/Tools
[GTK] Unreviewed gardening. API test WebKitWebInspectorServer/test-page-list is flaky.
- TestWebKitAPI/glib/TestExpectations.json:
- 7:11 AM Changeset in webkit [267189] by
-
- 4 edits in trunk/LayoutTests
[GLIB] Unreviewwed test gardening. Update baselines after WPT update in r267167.
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-connections-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioparam-interface/k-rate-panner-expected.txt:
- platform/glib/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-biquadfilternode-interface/biquad-automation-expected.txt:
- 5:39 AM Changeset in webkit [267188] by
-
- 153 edits2 copies2 deletes in trunk
Remove the legacy animation code
https://bugs.webkit.org/show_bug.cgi?id=216608
Reviewed by Dean Jackson.
Source/WebCore:
We remove the legacy animation code found in Source/WebCore/page/animation/, save for CSSPropertyAnimation which
is also used by the new Web Animations engine and now moved to Source/WebCore/animation/. Since we now have a single
animation engine, the runtime flags to optionally enable the Web Animations engine are not needed anymore and removed
as well.
We also remove some testing utilities and some RenderLayerBacking methods specific to accelerated transitions which
the new animation engine does not use.
- CMakeLists.txt:
- Headers.cmake:
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- animation/Animatable.idl:
- animation/AnimationEffect.idl:
- animation/AnimationPlaybackEvent.idl:
- animation/AnimationPlaybackEventInit.idl:
- animation/AnimationTimeline.idl:
- animation/CSSAnimation.idl:
- animation/CSSPropertyAnimation.cpp: Renamed from Source/WebCore/page/animation/CSSPropertyAnimation.cpp.
(WebCore::PropertyWrapperVisitedAffectedColor::PropertyWrapperVisitedAffectedColor):
- animation/CSSPropertyAnimation.h: Renamed from Source/WebCore/page/animation/CSSPropertyAnimation.h.
- animation/CSSTransition.idl:
- animation/DocumentAnimations.idl:
- animation/DocumentOrShadowRootAnimations.idl:
- animation/DocumentTimeline.idl:
- animation/KeyframeEffect.idl:
- animation/WebAnimation.idl:
- animation/WebAnimationTypes.h:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::computeRenderStyleForProperty):
- dom/Document.cpp:
(WebCore::Document::resolveStyle):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::willBeRemovedFromFrame):
(WebCore::Document::implicitClose):
(WebCore::Document::resume):
- dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
- dom/PseudoElement.cpp:
(WebCore::PseudoElement::clearHostElement):
- history/CachedFrame.cpp:
(WebCore::CachedFrame::destroy):
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::clearTimers):
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations):
- page/Frame.h:
- page/FrameView.cpp:
(WebCore::FrameView::didDestroyRenderTree):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
- page/FrameViewLayoutContext.cpp:
(WebCore::FrameViewLayoutContext::layout):
- page/Page.cpp:
(WebCore::Page::handleLowModePowerChange):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setWebAnimationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsEnabled const): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebAnimationsCSSIntegrationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webAnimationsCSSIntegrationEnabled const): Deleted.
- page/animation/AnimationBase.cpp: Removed.
- page/animation/AnimationBase.h: Removed.
- page/animation/CSSAnimationController.cpp: Removed.
- page/animation/CSSAnimationController.h: Removed.
- page/animation/CSSAnimationControllerPrivate.h: Removed.
- page/animation/CompositeAnimation.cpp: Removed.
- page/animation/CompositeAnimation.h: Removed.
- page/animation/ImplicitAnimation.cpp: Removed.
- page/animation/ImplicitAnimation.h: Removed.
- page/animation/KeyframeAnimation.cpp: Removed.
- page/animation/KeyframeAnimation.h: Removed.
- platform/graphics/GraphicsLayer.h:
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::isKeyframe):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::animatedStyle):
- rendering/RenderElement.h:
(WebCore::RenderElement::startTransition): Deleted.
(WebCore::RenderElement::transitionPaused): Deleted.
(WebCore::RenderElement::transitionFinished): Deleted.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform const):
(WebCore::RenderLayer::calculateClipRects const):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::notifyAnimationStarted):
(WebCore::RenderLayerBacking::startTransition): Deleted.
(WebCore::RenderLayerBacking::transitionPaused): Deleted.
(WebCore::RenderLayerBacking::transitionFinished): Deleted.
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
(WebCore::RenderLayerCompositor::isRunningTransformAnimation const):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::startTransition): Deleted.
(WebCore::RenderLayerModelObject::transitionPaused): Deleted.
(WebCore::RenderLayerModelObject::transitionFinished): Deleted.
- rendering/RenderLayerModelObject.h:
- rendering/RenderObject.h:
(WebCore::RenderObject::legacyAnimation const): Deleted.
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):
- style/StyleAdjuster.cpp:
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::webAnimationsCSSIntegrationEnabled): Deleted.
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
(WebCore::Internals::numberOfActiveAnimations const):
(WebCore::Internals::animationsAreSuspended const):
(WebCore::Internals::animationsInterval const):
(WebCore::Internals::suspendAnimations const):
(WebCore::Internals::resumeAnimations const):
(WebCore::Internals::acceleratedAnimationsForElement):
(WebCore::Internals::numberOfAnimationTimelineInvalidations const):
(WebCore::Internals::pauseAnimationAtTimeOnElement): Deleted.
(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement): Deleted.
(WebCore::Internals::pauseTransitionAtTimeOnElement): Deleted.
(WebCore::Internals::pauseTransitionAtTimeOnPseudoElement): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- Shared/WebPreferencesExperimental.yaml:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetWebAnimationsEnabled): Deleted.
(WKPreferencesGetWebAnimationsEnabled): Deleted.
(WKPreferencesSetWebAnimationsCSSIntegrationEnabled): Deleted.
(WKPreferencesGetWebAnimationsCSSIntegrationEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setWebAnimationsCSSIntegrationEnabled:]): Deleted.
(-[WKPreferences _webAnimationsCSSIntegrationEnabled]): Deleted.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
(WebKit::InjectedBundle::setWebAnimationsEnabled): Deleted.
(WebKit::InjectedBundle::setWebAnimationsCSSIntegrationEnabled): Deleted.
- WebProcess/InjectedBundle/InjectedBundle.h:
Source/WebKitLegacy/mac:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences webAnimationsEnabled]): Deleted.
(-[WebPreferences setWebAnimationsEnabled:]): Deleted.
(-[WebPreferences webAnimationsCSSIntegrationEnabled]): Deleted.
(-[WebPreferences setWebAnimationsCSSIntegrationEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKitLegacy/win:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- Interfaces/IWebFramePrivate.idl:
- Interfaces/IWebPreferencesPrivate.idl:
- WebFrame.cpp:
(WebFrame::resumeAnimations): Deleted.
(WebFrame::suspendAnimations): Deleted.
(WebFrame::pauseAnimation): Deleted.
(WebFrame::pauseTransition): Deleted.
(WebFrame::numberOfActiveAnimations): Deleted.
- WebFrame.h:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::webAnimationsCSSIntegrationEnabled): Deleted.
(WebPreferences::setWebAnimationsCSSIntegrationEnabled): Deleted.
(WebPreferences::setWebAnimationsEnabled): Deleted.
(WebPreferences::webAnimationsEnabled): Deleted.
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Tools:
Since we now have a single animation engine, the runtime flags to optionally enable the Web Animations engine are
not needed anymore and are now removed.
- DumpRenderTree/TestOptions.cpp:
(TestOptions::TestOptions):
(TestOptions::webViewIsCompatibleWithOptions const):
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):
- DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):
LayoutTests:
Remove any use of now-removed testing methods and some runtime flags from layout tests.
- animations/legacy-encoding-timing-function.html:
- animations/resources/animation-test-helpers.js:
(pauseAnimationAtTimeOnElement):
- http/tests/contentextensions/css-display-none-keyframe.html:
- imported/blink/transitions/resources/opacity-transform-transitions-inside-iframe-inner.html: Removed.
- transitions/background-position-transitions.html:
- transitions/background-transitions.html:
- transitions/blendmode-transitions.html:
- transitions/border-radius-transition.html:
- transitions/clip-path-path-transitions.html:
- transitions/clip-path-transitions.html:
- transitions/clip-transition.html:
- transitions/color-transition-all.html:
- transitions/color-transition-premultiplied.html:
- transitions/color-transition-rounding.html:
- transitions/cross-fade-background-image.html:
- transitions/cross-fade-border-image.html:
- transitions/cubic-bezier-overflow-color.html:
- transitions/cubic-bezier-overflow-length.html:
- transitions/cubic-bezier-overflow-shadow.html:
- transitions/cubic-bezier-overflow-svg-length.html:
- transitions/cubic-bezier-overflow-transform.html:
- transitions/default-timing-function.html:
- transitions/delay.html:
- transitions/flex-transitions.html:
- transitions/font-family-during-transition.html:
- transitions/frames-timing-function.html:
- transitions/interrupted-all-transition.html:
- transitions/longhand-vs-shorthand-initial.html:
- transitions/mask-transitions.html:
- transitions/min-max-width-height-transitions.html:
- transitions/mismatched-shadow-styles.html:
- transitions/mismatched-shadow-transitions.html:
- transitions/mixed-type.html:
- transitions/move-after-transition.html:
- transitions/multiple-background-size-transitions.html:
- transitions/multiple-background-transitions.html:
- transitions/multiple-mask-transitions.html:
- transitions/multiple-shadow-transitions.html:
- transitions/negative-delay.html:
- transitions/opacity-transition-zindex.html:
- transitions/resources/transition-test-helpers.js:
- transitions/shape-outside-transitions.html:
- transitions/shorthand-border-transitions.html:
- transitions/shorthand-transitions.html:
- transitions/steps-timing-function.html:
- transitions/svg-layout-transition.html:
- transitions/svg-text-shadow-transition.html:
- transitions/svg-transitions.html:
- transitions/text-indent-transition.html:
- transitions/transform-op-list-match.html:
- transitions/transform-op-list-no-match.html:
- transitions/transition-end-event-rendering.html:
- transitions/transition-hit-test-transform.html:
- transitions/transition-hit-test.html:
- transitions/transition-in-delay-phase.html:
- transitions/transition-on-element-with-content.html:
- transitions/transition-shorthand-delay.html:
- transitions/transition-timing-function.html:
- transitions/transition-to-from-auto.html:
- transitions/transition-to-from-undefined.html:
- transitions/visited-link-color.html:
- transitions/zero-duration-in-list.html:
- transitions/zero-duration-with-non-zero-delay-start.html:
- webanimations/accelerated-animation-interruption-display-none.html:
- webanimations/accelerated-animation-removal-upon-transition-completion.html:
- webanimations/accelerated-animation-suspension.html:
- webanimations/accelerated-transition-by-removing-property.html:
- webanimations/accessing-current-time-after-clearing-css-animation-effect.html:
- webanimations/accessing-current-time-after-finished-css-animation-target-removal.html:
- webanimations/css-animation-effect-target-change-and-animation-removal-crash.html:
- webanimations/css-animation-effect-target-change-and-get-keyframes-crash.html:
- webanimations/css-animations.html:
- webanimations/css-transition-in-flight-reversal-accelerated.html:
- webanimations/empty-keyframes-crash.html:
- webanimations/partly-accelerated-transition-by-removing-property.html:
- webanimations/setting-css-animation-none-after-clearing-effect.html:
- webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html:
- 5:12 AM Changeset in webkit [267187] by
-
- 4 edits in trunk
Clean up lazy frame loading
https://bugs.webkit.org/show_bug.cgi?id=216560
Patch by Rob Buis <rbuis@igalia.com> on 2020-09-17
Reviewed by Youenn Fablet.
Source/WebKit:
Allow web preference to be consistent with lazy image loading.
- Shared/WebPreferencesExperimental.yaml:
LayoutTests:
Remove WPT specific custom code to set the
lazy frame loading setting, not needed since
experimental features will be enabled for WPT
runs and that will set this setting.
- resources/testharnessreport.js:
- 3:30 AM Changeset in webkit [267186] by
-
- 17 edits in trunk
Support export namespace
export * as ns
https://bugs.webkit.org/show_bug.cgi?id=214379
Reviewed by Ross Kirsling.
JSTests:
- stress/modules-syntax-error.js:
- stress/modules-syntax.js:
- test262/expectations.yaml:
Source/JavaScriptCore:
This patch supports
export * as ns from "module"syntax. If it is used, we expose "module"'s namespace object as "ns".
For each module environment, we create *namespace* (starNamespace) private symbol scope variable. And we fill it later
with module namespace object. This way allows us to use module namespace object IC and super fast imported module binding
lookup though environment variable lookup mechanism.
- builtins/BuiltinNames.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
- parser/NodesAnalyzeModule.cpp:
(JSC::ExportNamedDeclarationNode::analyzeModule):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseExportDeclaration):
- runtime/AbstractModuleRecord.cpp:
(JSC::AbstractModuleRecord::ExportEntry::createNamespace):
(JSC::AbstractModuleRecord::resolveExportImpl):
(JSC::AbstractModuleRecord::getModuleNamespace):
(JSC::AbstractModuleRecord::setModuleEnvironment):
(JSC::AbstractModuleRecord::dump):
- runtime/AbstractModuleRecord.h:
- runtime/CommonIdentifiers.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::name):
(JSC::JSFunction::reifyName):
- runtime/JSModuleNamespaceObject.cpp:
(JSC::JSModuleNamespaceObject::getOwnPropertySlotCommon):
- runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::instantiateDeclarations):
(JSC::JSModuleRecord::evaluate):
- wasm/js/JSWebAssemblyModule.cpp:
(JSC::JSWebAssemblyModule::finishCreation):
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):
- 2:19 AM Changeset in webkit [267185] by
-
- 11 edits in trunk/Source
Unified build fix for "redefinition of 'kCMVideoCodecType_VP9"
https://bugs.webkit.org/show_bug.cgi?id=216205
Reviewed by Youenn Fablet.
Source/WebCore:
kCMVideoCodecType_VP9 is present in the macOS Big Sur SDK, so the redeclaration can
be removed. To protect builds using prior OS SDKs, wrap the entire VP9 implementation
in ENABLE(VP9) checks.
- platform/graphics/VP9Utilities.cpp:
- platform/graphics/VP9Utilities.h:
- platform/graphics/cocoa/MediaEngineConfigurationFactoryCocoa.cpp:
(WebCore::videoCodecTypeFromRFC4281Type):
(WebCore::createMediaPlayerDecodingConfigurationCocoa):
(): Deleted.
- platform/graphics/cocoa/SourceBufferParserWebM.cpp:
(WebCore::SourceBufferParserWebM::isContentTypeSupported):
- platform/graphics/cocoa/VP9UtilitiesCocoa.h:
- platform/graphics/cocoa/VP9UtilitiesCocoa.mm:
- testing/Internals.cpp:
(WebCore::Internals::Internals):
(WebCore::Internals::parseVPCodecParameters):
(WebCore::Internals::setHardwareVP9DecoderDisabledForTesting):
(WebCore::Internals::setVP9ScreenSizeAndScaleForTesting):
Source/WebKit:
Wrap calls to WebCore VP9 functions in ENABLE(VP9) checks.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- 1:05 AM Changeset in webkit [267184] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Optimize Promise#finally by avoiding creating multiple environments
https://bugs.webkit.org/show_bug.cgi?id=216637
Reviewed by Ross Kirsling.
Let's just create functions inside Promise#finally. This avoids creating
multiple lexical environments that are captured by each function.
- builtins/PromisePrototype.js:
(finally):
(globalPrivate.getThenFinally): Deleted.
(globalPrivate.getCatchFinally): Deleted.
- 1:01 AM Changeset in webkit [267183] by
-
- 5 edits in trunk
[css-flex] Remove flexbox's specific computePreferredLogicalWidths()
https://bugs.webkit.org/show_bug.cgi?id=216577
Reviewed by Darin Adler.
Source/WebCore:
Remove the flexbox override of computePreferredLogicalWidths() because it's essentially the same as RenderBlock's
but worst because it was missing some cases that were properly handled in the superclass.
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths): Deleted.
- rendering/RenderFlexibleBox.h: Ditto.
LayoutTests:
- TestExpectations: Removed flexbox_stf-table-singleline.html and flexbox_stf-table-singleline-2.html that are now passing.
