Context Navigation

← Previous Period
Next Period →

Timeline

Feb 17, 2022:

11:55 PM Changeset in webkit [290116] by Megan Gardner

23 edits
1 copy
1 add in trunk

Draw highlights for Scroll To Text Fragment
https://bugs.webkit.org/show_bug.cgi?id=236693

Reviewed by Tim Horton.

Source/WebCore:

Implement a very basic search for text fragments (this will be properly implemented later)
and leverage our Highlight and AppHighlight infrastructures to draw the found ranges for
Scroll to Text Fragment and scroll so they are guaranteed to be in view.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/Document.cpp:

(WebCore::Document::commonTeardown):
(WebCore::Document::fragmentHighlightRegister):
(WebCore::Document::updateHighlightPositions):

dom/Document.h:

(WebCore::Document::fragmentHighlightRegisterIfExists):

page/FrameView.cpp:

(WebCore::FrameView::scrollToFragment):

rendering/MarkedText.cpp:

(WebCore::MarkedText::collectForHighlights):

rendering/MarkedText.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::calculateHighlightColor const):

rendering/StyledMarkedText.cpp:

(WebCore::resolveStyleForMarkedText):

Tools:

TestWebKitAPI/Tests/WebCore/MarkedText.cpp:

(WebCore::operator<<):

11:45 PM Changeset in webkit [290115] by sihui_liu@apple.com

2 edits in trunk/Source/WebKit

Exclude new LocalStorage directory from backup on iOS
https://bugs.webkit.org/show_bug.cgi?id=236423
<rdar://problem/89060863>

Reviewed by Chris Dumez.

We've been excluding LocalStorage data from backup on iOS since r212555, and we need to make sure this applies
to new LocalStorage directory after migration (r289878).

Manually tested on iOS device.

NetworkProcess/storage/OriginStorageManager.cpp:

(WebKit::OriginStorageManager::StorageBucket::resolvedLocalStoragePath):

9:41 PM Changeset in webkit [290114] by Kocsen Chung

1 edit in branches/safari-613.1.17.1-branch/Source/WTF/Scripts/Preferences/WebPreferences.yaml

Apply patch. rdar://problem/89126114

9:34 PM Changeset in webkit [290113] by Kocsen Chung

9 edits in branches/safari-613.1.17.1-branch/Source

Versioning.

WebKit-7613.1.17.1.6

9:21 PM Changeset in webkit [290112] by Patrick Angle

5 edits in trunk/Source/WebCore

Web Inspector: [Flexbox] Add indicators for layout context in element tooltips
https://bugs.webkit.org/show_bug.cgi?id=236738

Reviewed by Devin Rousso.

en.lproj/Localizable.strings:
inspector/InspectorOverlay.cpp:

(WebCore::rendererIsFlexboxItem):
(WebCore::rendererIsGridItem):
(WebCore::InspectorOverlay::drawElementTitle):

Add new Flex Item, Flex, Grid Item, and Grid bubblea to element tooltips to allow provide more

context about layout while selecting nodes on a page.

Move the role into its own bubble with special color (based on the previous coloring of the Role text).

inspector/InspectorOverlayLabel.cpp:

(WebCore::InspectorOverlayLabel::draw):

inspector/InspectorOverlayLabel.h:

(WebCore::InspectorOverlayLabel::Content::encode const):
(WebCore::InspectorOverlayLabel::Content::decode):
(WebCore::InspectorOverlayLabel::Content::Decoration::encode const):
(WebCore::InspectorOverlayLabel::Content::Decoration::decode):

Add the concept of text decoration (currently just bordered text).
Create an intermediate ComputedContentRun to hold the intermediate representation of content with the

computed attributes of each piece of text. This allows us to better scale with the addition of the new text
decorations and other configuration properties instead of having to create even more Vectors of things that need
to be kept in sync with each other.

8:52 PM Changeset in webkit [290111] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Enable subgrid by default.
https://bugs.webkit.org/show_bug.cgi?id=236821

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-17
Reviewed by Alan Bujtas.

Scripts/Preferences/WebPreferencesExperimental.yaml:

8:16 PM Changeset in webkit [290110] by ysuzuki@apple.com

2 edits in trunk/Source/bmalloc

[libpas] scavenger should not call pthread_mach_thread_np after suspension
https://bugs.webkit.org/show_bug.cgi?id=236798
rdar://89020902

Reviewed by Mark Lam and Keith Miller.

pthread_mach_thread_np can take a lock internally. So we should not call it after suspending a thread.
This patch refactors libpas scavenger so that we call pthread_mach_thread_np before suspending a thread.
We also avoid calling pthread_self() after suspension to make suspending safer (while it does not take
a lock, it also depends on an internal implementation).

libpas/src/libpas/pas_thread_local_cache.c:

(scavenger_thread_suspend_data_create):
(suspend):
(resume):
(stop_allocator):
(pas_thread_local_cache_for_all):

7:55 PM Changeset in webkit [290109] by Simon Fraser

2 edits in trunk/Source/WebCore

Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
https://bugs.webkit.org/show_bug.cgi?id=236810
<rdar://89072235>

Reviewed by Dean Jackson.

Crash data suggests that r288933 didn't fix the crash entirely.

Although the code paths I can find appear to hold the lock, there may be an
opportunity for m_scrollingCoordinator to get nulled out after we null-check it
but before the copy for the main thread dispatch.

So make a RefPtr on the stack, null-check it, and then move it into the callback.

page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ThreadedScrollingTree::reportExposedUnfilledArea):
(WebCore::ThreadedScrollingTree::currentSnapPointIndicesDidChange):
(WebCore::ThreadedScrollingTree::handleWheelEventPhase):
(WebCore::ThreadedScrollingTree::setActiveScrollSnapIndices):
(WebCore::ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged):

7:46 PM Changeset in webkit [290108] by Chris Dumez

19 edits in trunk/Source

Clean up / optimize call sites constructing vectors
https://bugs.webkit.org/show_bug.cgi?id=236748
<rdar://problem/89090710>

Reviewed by Darin Adler.

Follow-up to r290026 to address feedback from Darin.

Source/JavaScriptCore:

b3/air/AirCode.cpp:

(JSC::B3::Air::Code::setNumEntrypoints):

Source/WebCore:

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::updateKeyStatuses):

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::currentData):

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setMathscripts):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readString):

css/StyleProperties.cpp:

(WebCore::DeferredStyleProperties::DeferredStyleProperties):

css/StyleRule.cpp:

(WebCore::DeferredStyleGroupRuleList::DeferredStyleGroupRuleList):

dom/ElementData.cpp:

(WebCore::UniqueElementData::UniqueElementData):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createFromSelection):

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::responseHeaders const):

platform/encryptedmedia/CDMProxy.cpp:

(WebCore::KeyStore::convertToJSKeyStatusVector const):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):

platform/text/LocaleICU.cpp:

(WebCore::createFallbackMonthLabels):

platform/text/LocaleNone.cpp:

(WebCore::LocaleNone::shortMonthLabels):

platform/text/cocoa/LocaleCocoa.mm:

(WebCore::LocaleCocoa::monthLabels):
(WebCore::LocaleCocoa::shortMonthLabels):
(WebCore::LocaleCocoa::standAloneMonthLabels):
(WebCore::LocaleCocoa::shortStandAloneMonthLabels):

testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstanceSession::updateLicense):
(WebCore::MockCDMInstanceSession::removeSessionData):

7:37 PM Changeset in webkit [290107] by Diego Pino Garcia

2 edits in trunk/Source/WebCore

[WPE] Unreviewed, fix non-unified build after r290089

html/PDFDocument.cpp:

7:31 PM Changeset in webkit [290106] by Diego Pino Garcia

2 edits in trunk/Source/WebKit

[GTK] Debian Stable build is broken after r290026
https://bugs.webkit.org/show_bug.cgi?id=236819

Unreviewed build fix.

UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::copy const):

6:51 PM Changeset in webkit [290105] by Alan Bujtas

4 edits
2 adds in trunk

[LFC][IFC] 'vertical-align: bottom' makes inline level boxes stick out of their parent block box
https://bugs.webkit.org/show_bug.cgi?id=236677

Reviewed by Antti Koivisto.

Source/WebCore:

'vertical-align: bottom' pushes the root inline box's baseline down as it stretches the line box downwards.
In most cases this makes the root inline box sit at the bottom of the line box e.g.

<div>

some text
<img style="vertical-align: bottom; height: 100px; width: 10px;">

</div>
forms a 100px tall block box where the "some text" sits at the bottom of the line and the tall image fills the rest of the line box all the way to the top.

Now if we add another inline level box with e.g. middle alignment.
<div>

some text
<img style="vertical-align: middle; height: 80px; width: 10px;">
<img style="vertical-align: bottom; height: 100px; width: 10px;">

</div>
We still form a 100px tall block box where the "some text" content sits at the bottom and the middle aligned box stick out of the block box by about 40px (middle alignment -> 80px/2) as it is aligned based
on the root inline box's position (which is at the very bottom of the block container).
Instead the root inline box's baseline should be pull up to make room for the middle aligned image box.

This patch fixes this incorrect behavior by removing the line box relative alignment types from the regular alignment logic and offsetting the root inline box's baseline position at a later step.
What we do here is we simply compute the root inline box's baseline position as if there were no line box relative aligned boxes present and offset the final result if such box happens to stretch the line box.
(going back to the example: without the tall, bottom aligned image box, we compute the root inline box's baseline position to be around 40px to
ensure that the 80px image box fits and later we push it down to 60px (as the 100px image box stretches the line box by 20px).)

Test: fast/inline/vertical-align-bottom.html

layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:

(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):

layout/formattingContexts/inline/InlineLineBoxVerticalAligner.h:

(WebCore::Layout::LineBoxVerticalAligner::LineBoxHeight::value const):

LayoutTests:

fast/inline/vertical-align-bottom-expected.html: Added.
fast/inline/vertical-align-bottom.html: Added.

6:46 PM Changeset in webkit [290104] by Fujii Hironori

2 edits in trunk/Source/WTF

GeneratePreferences.rb: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated
https://bugs.webkit.org/show_bug.cgi?id=236684

Reviewed by Yusuke Suzuki.

With Ruby 3.1.0, GeneratePreferences.rb reported the following warnings.

GeneratePreferences.rb:235: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments.
GeneratePreferences.rb:235: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Use keyword argument like ERB.new(str, trim_mode: ...) instead.

Scripts/GeneratePreferences.rb: Changed to use the keyword argument for ERB.new.

6:31 PM Changeset in webkit [290103] by Kate Cheney

6 edits in trunk/Source

Refactor share menu item presentation
https://bugs.webkit.org/show_bug.cgi?id=236806
<rdar://problem/88858606>

Reviewed by Aditya Keerthi.

Source/WebCore:

page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

Source/WebCore/PAL:

pal/spi/mac/NSSharingServicePickerSPI.h:

Source/WebKit:

UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::setupServicesMenu):
(WebKit::WebContextMenuProxyMac::getShareMenuItem):

5:56 PM Changeset in webkit [290102] by jonlee@apple.com

7 edits in trunk/LayoutTests

LayoutTests/imported/w3c:
Unreviewed gardening. Update fuzzy data.

web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003.html:

LayoutTests:
Unreviewed gardening for iOS GPU Process bots.

TestExpectations:
gpu-process/TestExpectations: Triage remaining failures.

css3/masking/clip-path-border-radius-border-box-000.html: Add fuzzy data.
imported/blink/svg/paintorder/paintorder.svg:

5:18 PM Changeset in webkit [290101] by Kocsen Chung

1 copy in tags/Safari-614.1.3.4

Tag Safari-614.1.3.4.

5:17 PM Changeset in webkit [290100] by Kocsen Chung

1 delete in tags/Safari-614.1.3.4

Delete tag.

5:10 PM Changeset in webkit [290099] by Kocsen Chung

1 copy in tags/Safari-614.1.3.4

Tag Safari-614.1.3.4.

5:03 PM Changeset in webkit [290098] by Aditya Keerthi

30 edits
6 adds in trunk

'-webkit-user-select: all' is not respected in editable views
https://bugs.webkit.org/show_bug.cgi?id=190977
rdar://34945944

Reviewed by Wenson Hsieh.

Source/WebCore:

Original patch by Tim Horton.

Currently, if the web view's editable bit is set to true, all nodes are
made editable via a short circuit. However, the content of nodes with
'-webkit-user-select: all' should not be editable. To fix, remove the
short circuit and allow '-webkit-user-select' to take precedence.

'-webkit-user-modify: read-only' and 'contenteditable=false' elements
remain editable in editable web views.

Tests: editing/editability/contenteditable-false-in-editable-view.html

editing/editability/user-modify-read-only-in-editable-view.html
editing/editability/user-select-all-in-editable-view.html

dom/Node.cpp:

(WebCore::computeEditabilityFromComputedStyle):
(WebCore::Node::computeEditability const):

html/HTMLElement.cpp:

(WebCore::HTMLElement::editabilityFromContentEditableAttr):
(WebCore::HTMLElement::matchesReadWritePseudoClass const):

html/HTMLElement.h:
page/Page.h:

Source/WebKit:

Add methods for testing the GTK port.

UIProcess/API/C/gtk/WKView.cpp:

(WKViewSetEditable):

UIProcess/API/C/gtk/WKViewPrivate.h:
UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseSetEditable):

UIProcess/API/gtk/WebKitWebViewBasePrivate.h:

Tools:

Add a UIScriptController method to make web views editable.

Remove TestRunner::setWebViewEditable as it is unused.

DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setWebViewEditableCallback): Deleted.

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setWebViewEditable): Deleted.

DumpRenderTree/mac/UIScriptControllerMac.h:
DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptControllerMac::setWebViewEditable):

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::~TestRunner):
(TestRunner::setWebViewEditable): Deleted.

DumpRenderTree/win/UIScriptControllerWin.cpp:

(WTR::UIScriptControllerWin::setWebViewEditable):

DumpRenderTree/win/UIScriptControllerWin.h:
TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::setWebViewEditable):

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:

(WTR::UIScriptControllerCocoa::setWebViewEditable):

WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::platformResetStateToConsistentValues):

WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:

(WTR::UIScriptControllerGtk::setWebViewEditable):

WebKitTestRunner/gtk/UIScriptControllerGtk.h:

LayoutTests:

Add tests to verify the behavior of -[WKWebView _setEditable:] with
'-webkit-user-select: all', '-webkit-user-modify: none', and
'contenteditable=false'. Elements with '-webkit-user-select: all' should
not be editable.

editing/editability/contenteditable-false-in-editable-view-expected.txt: Added.
editing/editability/contenteditable-false-in-editable-view.html: Added.
editing/editability/user-modify-read-only-in-editable-view-expected.txt: Added.
editing/editability/user-modify-read-only-in-editable-view.html: Added.
editing/editability/user-select-all-in-editable-view-expected.txt: Added.
editing/editability/user-select-all-in-editable-view.html: Added.
editing/input/ios/rtl-keyboard-input-on-focus-in-editable-page.html:

Replace the test option with the new UIHelper method.

resources/ui-helper.js:

(window.UIHelper.setWebViewEditable):

5:00 PM Changeset in webkit [290097] by Kocsen Chung

9 edits in branches/safari-614.1.3-branch/Source

Versioning.

WebKit-7614.1.3.4

4:54 PM Changeset in webkit [290096] by commit-queue@webkit.org

14 edits in trunk

Account for subgrid MBP when sizing
https://bugs.webkit.org/show_bug.cgi?id=236338

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-17
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

web-platform-tests/css/css-grid/subgrid/abs-pos-002-expected.html:
web-platform-tests/css/css-grid/subgrid/abs-pos-003-expected.html:
web-platform-tests/css/css-grid/subgrid/line-names-008.html:
web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-001.html:
web-platform-tests/css/css-grid/subgrid/parent-repeat-auto-fit-002.html:

Source/WebCore:

Adds extra margin to subgrid items participating in the sizing of an outer
grid's tracks to account for the margin/border/padding of the intermediate
subgrid item itself.
Also contributes the subgrid's m/b/p to the edge tracks it cover, even
if no inner items occupy that track.

rendering/GridLayoutFunctions.cpp:

(WebCore::GridLayoutFunctions::directionFromSide):
(WebCore::GridLayoutFunctions::hasRelativeOrIntrinsicSizeForChild):
(WebCore::GridLayoutFunctions::extraMarginForSubgridChild):
(WebCore::GridLayoutFunctions::gapDifferenceForSubgridChild):
(WebCore::GridLayoutFunctions::marginLogicalSizeForChild):

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::setOverridingContainingBlockContentSizeForChild):
(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::updateOverridingContainingBlockContentSizeForChild const):
(WebCore::DefiniteSizeStrategy::minLogicalSizeForChild const):
(WebCore::DefiniteSizeStrategy::minContentForChild const):
(WebCore::addSubgridMarginBorderPadding):
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::isSubgrid const):
(WebCore::RenderGrid::mayBeSubgridExcludingAbsPos const):
(WebCore::RenderGrid::gridSpanCoversRealTracks const):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
(WebCore::RenderGrid::gridSpanForChild const):

rendering/RenderGrid.h:
rendering/style/GridPositionsResolver.cpp:

(WebCore::adjustGridPositionsFromStyle):

LayoutTests:

Account for subgrid MBP when sizing

TestExpectations:

4:53 PM Changeset in webkit [290095] by Kocsen Chung

1 copy in tags/Safari-613.1.17.3.2

Tag Safari-613.1.17.3.2.

4:53 PM Changeset in webkit [290094] by Kocsen Chung

1 copy in tags/Safari-613.1.17.2.2

Tag Safari-613.1.17.2.2.

4:52 PM Changeset in webkit [290093] by Kocsen Chung

1 copy in tags/Safari-613.1.17.0.5

Tag Safari-613.1.17.0.5.

4:45 PM Changeset in webkit [290092] by Kocsen Chung

1 copy in tags/Safari-613.1.17.1.5

Tag Safari-613.1.17.1.5.

4:42 PM Changeset in webkit [290091] by Devin Rousso

8 edits in trunk/Source/WebKit

[MacCatalyst] improve support for resizing
https://bugs.webkit.org/show_bug.cgi?id=236745
<rdar://problem/86494393>

Reviewed by Tim Horton.

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView setFrame:]):
(-[WKWebView setBounds:]):
(-[WKWebView _acquireResizeAssertionForReason:]): Added.
Acquire a UIKit assertion whenever the frame/bounds of the WKWebView is changed that
is invalidate once the visible contect rect has been updated. UIKit can use this to know
both when WebKit is processing WKWebView resize changes and get notified once it's done.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Added.

UIProcess/API/Cocoa/WKWebViewPrivateForTesting.h:
UIProcess/API/Cocoa/WKWebViewTesting.mm:

(-[WKWebView _doAfterNextVisibleContentRectUpdate:]): Deleted.
Allow this to be used outside of testing code (just like -[WKWebView _doAfterNextPresentationUpdate:]).

Platform/spi/ios/UIKitSPI.h:

4:39 PM Changeset in webkit [290090] by Kocsen Chung

1 copy in tags/Safari-614.1.3.3

Tag Safari-614.1.3.3.

4:27 PM Changeset in webkit [290089] by J Pascoe

4 edits in trunk/Source/WebCore

PDF.js viewer should work for all kinds of URLs
https://bugs.webkit.org/show_bug.cgi?id=236525
rdar://problem/88832961

Reviewed by Tim Nguyen.

This patch starts loading the pdf as an array buffer after it's recieved
by calling the PDFJS viewer's open function through the content script's
wrapper. More work is needed to potentially present the data as a
PDFDataRangeTransport.

Modules/pdfjs-extras/content-script.js:

(const.PDFJSContentScript.init):
(const.PDFJSContentScript.open):

html/PDFDocument.cpp:

(WebCore::PDFDocumentEventListener::handleEvent):
(WebCore::PDFDocument::createDocumentStructure):
(WebCore::PDFDocument::updateDuringParsing):
(WebCore::PDFDocument::finishedParsing):
(WebCore::PDFDocument::sendPDFArrayBuffer):
(WebCore::PDFDocument::injectContentScript):

html/PDFDocument.h:

(WebCore::PDFDocumentEventListener::handleEvent):

4:14 PM Changeset in webkit [290088] by Chris Dumez

2 edits in trunk/Source/WebCore

Pass registrable domain to CoreLocation API
https://bugs.webkit.org/show_bug.cgi?id=236803
<rdar://88761413>

Reviewed by Darin Adler.

Pass registrable domain to CoreLocation API when the Geolocation API is used.
Note that the code is guarded on a CL_HAS_RADAR_88834301 define from CoreLocation
since the initWithWebsiteIdentifier is currently present in the SDK but not
functional.

platform/cocoa/CoreLocationGeolocationProvider.mm:

(-[WebCLLocationManager initWithWebsiteIdentifier:client:]):

4:09 PM Changeset in webkit [290087] by dino@apple.com

4 edits
2 adds in trunk

Source/ThirdParty/ANGLE:
Metal ANGLE: vertex array does not correctly observe contents of data buffers
https://bugs.webkit.org/show_bug.cgi?id=236733
<rdar://problem/88713302>
<rdar://problem/88499073>

Patch by Kyle Piddington <Kyle Piddington> on 2022-02-17
Reviewed by Dean Jackson.

Similar to previous bug (236427), we were not correctly observing changes to the
vertex buffer data. This caused us to miss rebinding vertex buffers
when data was updated without causing conversion

src/libANGLE/renderer/metal/VertexArrayMtl.h:
src/libANGLE/renderer/metal/VertexArrayMtl.mm:

(rx::VertexArrayMtl::syncState):
(rx::VertexArrayMtl::setupDraw):
(rx::VertexArrayMtl::syncDirtyAttrib):

4:01 PM Changeset in webkit [290086] by Cameron McCormack

16 edits in trunk/Source/WebCore

Always use ChildChange::Source::Parser when creating input element UA shadow tree contents
https://bugs.webkit.org/show_bug.cgi?id=236740

Reviewed by Dean Jackson.

When creating an input element's UA shadow tree, we currently use a
ChildChange::Source value that depends on whether the input element
itself was parser- or script-inserted. But since UA shadow trees are
not exposed to content, and we don't have any dependency on the extra
work that inserting using ChildChange::Source::API does, we can use
ChildChange::Source::Parser unconditionally.

Local testing shows this scores a 0.1% Speedometer 2 improvement.

html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/BaseDateAndTimeInputType.h:
html/ColorInputType.cpp:

(WebCore::ColorInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/ColorInputType.h:
html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):
(WebCore::FileInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/FileInputType.h:
html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/InputType.cpp:

(WebCore::InputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/InputType.h:
html/RangeInputType.cpp:

(WebCore::RangeInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/RangeInputType.h:
html/SearchInputType.cpp:

(WebCore::SearchInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/SearchInputType.h:
html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createShadowSubtreeAndUpdateInnerTextElementEditability):

html/TextFieldInputType.h:

3:48 PM Changeset in webkit [290085] by Simon Fraser

12 edits in trunk/Source/WebKit

Move setting RemoteLayerBackingStore surfaces volatile into the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=236791

Reviewed by Tim Horton.

Setting RemoteLayerBackingStore IOSurfaces volatile has to happen in the GPU process with
DOM rendering enabled. Add overrides in RemoteLayerWithRemoteRenderingBackingStoreCollection
to handle this, sending batches of buffer identifiers to RemoteRenderingBackend. Because
surface in-use counts can cause this to fail, we return a list of identifiers that we failed
to mark volatile. A future patch will use these to maintain web process-side buffer volatile
status.

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::markSurfacesVolatile):

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Platform/Logging.h:
Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:

(WebKit::RemoteLayerBackingStoreCollection::markBackingStoreVolatile):

Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::backingStoreBecameUnreachable):
(WebKit::RemoteLayerBackingStoreCollection::markBackingStoreVolatileAfterReachabilityChange):
(WebKit::RemoteLayerBackingStoreCollection::markAllBackingStoreVolatileFromTimer):
(WebKit::RemoteLayerBackingStoreCollection::volatilityTimerFired):

Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h:
Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:

(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::collectBackingStoreBufferIdentifiersToMarkVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::collectAllBufferIdentifiersToMarkVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::markBackingStoreVolatileAfterReachabilityChange):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::tryMarkAllBackingStoreVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::markAllBackingStoreVolatileFromTimer):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::sendMarkBuffersVolatile):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::markSurfacesVolatile):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:

3:39 PM Changeset in webkit [290084] by Diego Pino Garcia

4 edits in trunk/Source/WebKit

[macOS] Non-unified build fixes
https://bugs.webkit.org/show_bug.cgi?id=236752

Reviewed by Darin Adler.

UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::requestTextRecognition):
(WebKit::WebViewImpl::showSafeBrowsingWarning):
(WebKit::toWKRectEdge):
(WebKit::toRectEdges):

UIProcess/mac/WKSharingServicePickerDelegate.h:

3:29 PM Changeset in webkit [290083] by Kocsen Chung

4 edits in branches/safari-614.1.4-branch/Source

Cherry-pick r290076. rdar://problem/89076606

[Cocoa] Make AVFoundationSPI.h robust against changes in system headers
https://bugs.webkit.org/show_bug.cgi?id=236787

Reviewed by Eric Carlson.

Source/WebCore/PAL:

Only re-declare classes and add categories for non-Apple Internal builds, or when those
definitions would be missing from system headers. The presence of the classes and their
methods are already checked at runtime, so this is a build-only change.

pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:25 PM Changeset in webkit [290082] by Jean-Yves Avenard

2 edits in trunk/Source/WebKitLegacy/mac

Unnecessary copy/memory allocation
https://bugs.webkit.org/show_bug.cgi?id=236749
rdar://problem/89064893

Reviewed by Dean Jackson.

WebView/WebHTMLView.mm:

(createShareMenuItem): Shared NSData constructed from a SharedBuffer instead

3:16 PM Changeset in webkit [290081] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Unreviewed, reverting r289974.
https://bugs.webkit.org/show_bug.cgi?id=236804

Should not have been reverted on trunk

Reverted changeset:

"Unreviewed, reverting r286874."
https://bugs.webkit.org/show_bug.cgi?id=236734
https://commits.webkit.org/r289974

3:13 PM Changeset in webkit [290080] by Noam Rosenthal

42 edits
1 copy
7 adds in trunk/LayoutTests/imported/w3c

Resync web-platform-tests/paint-timing from upstream
https://bugs.webkit.org/show_bug.cgi?id=236717

Reviewed by Simon Fraser.

Resync to af3b9946eb6f0955360282176848af4be7e58304

web-platform-tests/paint-timing/fcp-only/buffered-flag.window.html: Added.
web-platform-tests/paint-timing/fcp-only/buffered-flag.window.js: Added.
web-platform-tests/paint-timing/fcp-only/fcp-background-size.html:
web-platform-tests/paint-timing/fcp-only/fcp-bg-image-set.html:
web-platform-tests/paint-timing/fcp-only/fcp-bg-image-two-steps-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-bg-image-two-steps.html:
web-platform-tests/paint-timing/fcp-only/fcp-canvas-context-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-canvas-context.html:
web-platform-tests/paint-timing/fcp-only/fcp-gradient-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-gradient.html:
web-platform-tests/paint-timing/fcp-only/fcp-iframe-expected.txt: Added.
web-platform-tests/paint-timing/fcp-only/fcp-iframe.html: Copied from LayoutTests/imported/w3c/web-platform-tests/paint-timing/fcp-only/fcp-ignore-from-subframe.html.
web-platform-tests/paint-timing/fcp-only/fcp-ignore-from-subframe.html:
web-platform-tests/paint-timing/fcp-only/fcp-invisible-3d-rotate-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale-transition-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-invisible-scale.html:
web-platform-tests/paint-timing/fcp-only/fcp-invisible-text-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-opacity-descendant-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-opacity-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-opacity.html:
web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds-translate-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-out-of-bounds.html:
web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-display-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-image-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-image.html:
web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-opacity-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-text-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-pseudo-element-visibility-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-svg-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-text-input-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-text-input.html:
web-platform-tests/paint-timing/fcp-only/fcp-typographic-pseudo-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-video-frame-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-video-frame.html:
web-platform-tests/paint-timing/fcp-only/fcp-video-poster-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-video-poster.html:
web-platform-tests/paint-timing/fcp-only/fcp-whitespace-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-whitespace.html:
web-platform-tests/paint-timing/fcp-only/fcp-with-rtl-expected.txt:
web-platform-tests/paint-timing/fcp-only/fcp-with-rtl.html:
web-platform-tests/paint-timing/fcp-only/svg-in-iframe-expected.txt: Added.
web-platform-tests/paint-timing/fcp-only/svg-in-iframe.html: Added.
web-platform-tests/paint-timing/resources/svg.html: Added.
web-platform-tests/paint-timing/resources/utils.js:

(async assertFirstContentfulPaint.return.new.Promise):
(async assertFirstContentfulPaint):
(async test_fcp):

2:58 PM Changeset in webkit [290079] by Mikhail R. Gadelha

8 edits in trunk

[32bit] Increase fixedExecutableMemoryPoolSize on ARM to 32MB
https://bugs.webkit.org/show_bug.cgi?id=236606

Reviewed by Mark Lam.

Increased executable memory on ARM to 32MB and make it consistent with
other 32 bit platforms (MIPS and x86). This patch also enables some
tests that now pass because of the increased memory; each test was
executed 1000 times and there was no failure.

let-const-tdz-environment-parsing-and-hash-consing-speed.js was disabled
on MIPS because the jitted code is still a bit too bigger for the 32MB,
but it can probably be enable when the EXTRA_CTI_THUNKS patch lands.

microbenchmarks/let-const-tdz-environment-parsing-and-hash-consing-speed.js:
stress/arrowfunction-lexical-bind-superproperty.js:
stress/proxy-revoke.js:
stress/regress-169445.js:
stress/tagged-template-object-collect.js:

2:54 PM Changeset in webkit [290078] by Kocsen Chung

4 edits in branches/safari-614.1.3-branch/Source

Cherry-pick r290076. rdar://problem/89076606

[Cocoa] Make AVFoundationSPI.h robust against changes in system headers
https://bugs.webkit.org/show_bug.cgi?id=236787

Reviewed by Eric Carlson.

Source/WebCore/PAL:

Only re-declare classes and add categories for non-Apple Internal builds, or when those
definitions would be missing from system headers. The presence of the classes and their
methods are already checked at runtime, so this is a build-only change.

pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

wtf/PlatformHave.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2:53 PM Changeset in webkit [290077] by Truitt Savell

9 edits in trunk

Include sub grid items in the track sizing algorithm of the outer grid
https://bugs.webkit.org/show_bug.cgi?id=236337

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-17
Reviewed by Dean Jackson.

Source/WebCore:

resolveIntrinsicTrackSizes and findUsedFlexFraction now recurse into subgridded items
to iterate the children sa if they were directly part of the outer grid.
New constructor added to GridIterator for constructing a new iterator for the subgrid items,
which adjusts the row/column indices into the local coordinate space of the subgrid.
Adds a new method to renderGrid 'placeItems' so that we can ensure subgrid items have finished placement
when doing sizing for the outer grid.

Existing test expectations updated.

rendering/Grid.cpp:

(WebCore::GridIterator::createForSubgrid):

rendering/Grid.h:

(WebCore::GridIterator::direction const):

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithm::isIntrinsicSizedGridArea const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithm::updateBaselineAlignmentContext):
(WebCore::GridTrackSizingAlgorithm::baselineOffsetForChild const):
(WebCore::IndefiniteSizeStrategy::accumulateFlexFraction const):
(WebCore::IndefiniteSizeStrategy::findUsedFlexFraction const):
(WebCore::GridTrackSizingAlgorithm::accumulateIntrinsicSizesForTrack):
(WebCore::GridTrackSizingAlgorithm::resolveIntrinsicTrackSizes):

rendering/GridTrackSizingAlgorithm.h:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeItems):
(WebCore::insertIntoGrid):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid const):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid const):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::isSubgridInParentDirection const):

rendering/RenderGrid.h:

LayoutTests:

Existing test expectations updated.

TestExpectations:

2:41 PM Changeset in webkit [290076] by jer.noble@apple.com

4 edits in trunk/Source

[Cocoa] Make AVFoundationSPI.h robust against changes in system headers
https://bugs.webkit.org/show_bug.cgi?id=236787

Reviewed by Eric Carlson.

Source/WebCore/PAL:

Only re-declare classes and add categories for non-Apple Internal builds, or when those
definitions would be missing from system headers. The presence of the classes and their
methods are already checked at runtime, so this is a build-only change.

pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

wtf/PlatformHave.h:

2:39 PM Changeset in webkit [290075] by Kocsen Chung

9 edits in branches/safari-614.1.3-branch/Source

Versioning.

WebKit-7614.1.3.3

2:20 PM Changeset in webkit [290074] by Alan Coon

6 edits in branches/safari-613.1.17.0-branch

Apply patch. rdar://problem/89009881

2:19 PM Changeset in webkit [290073] by Alan Coon

6 edits in branches/safari-613.1.17.1-branch

Apply patch. rdar://problem/89009881

1:52 PM Changeset in webkit [290072] by jonlee@apple.com

6 edits in trunk/LayoutTests

Unreviewed gardening. Add fuzzy data.

LayoutTests/imported/w3c:

web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003.html:
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-001.html:

LayoutTests:

fast/borders/border-radius-on-html.html:
fast/images/exif-orientation-svg-feimage.html:

1:45 PM Changeset in webkit [290071] by Nikos Mouchtaris

2 edits in trunk/Source/WTF

Enable CSS Motion Path by default
https://bugs.webkit.org/show_bug.cgi?id=236681

Unreviewed enable of WebKitLegacy.

Scripts/Preferences/WebPreferencesExperimental.yaml:

1:38 PM Changeset in webkit [290070] by Alan Coon

7 edits
2 adds in branches/safari-613.1.17.1-branch

Cherry-pick r289693. rdar://problem/88264857

Suppress style invalidation when matching :checked
https://bugs.webkit.org/show_bug.cgi?id=235910

Patch by Rob Buis <rbuis@igalia.com> on 2022-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Suppress style invalidation when matching :checked for option elements.

Test: fast/selectors/has-select-option-crash.html

css/SelectorCheckerTestFunctions.h: (WebCore::isChecked):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected const): (WebCore::HTMLOptionElement::setSelectedState):
html/HTMLOptionElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListItemSelectedStates): (WebCore::HTMLSelectElement::recalcListItems const):
html/HTMLSelectElement.h:

LayoutTests:

fast/selectors/has-select-option-crash-expected.txt: Added.
fast/selectors/has-select-option-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:32 PM Changeset in webkit [290069] by mmaxfield@apple.com

3 edits
3 adds in trunk/Source/WebGPU

[WebGPU] Add a playground example target
https://bugs.webkit.org/show_bug.cgi?id=236742

Reviewed by Dean Jackson.

It's just a little playground where you can call WebGPU functions.
It's not built by any script or included in any other targets - it's
just for the WebGPU developers to play around with WebGPU functions.

CommandLinePlayground/main.swift: Added.
Configurations/CommandLinePlayground.xcconfig: Added.
WebGPU.xcodeproj/project.pbxproj:
WebGPU/WebGPU.modulemap:

1:31 PM Changeset in webkit [290068] by Alan Coon

2 edits in branches/safari-613.1.17.1-branch/Source/WebKit

Cherry-pick r290066. rdar://problem/89072361

[macOS][WP] Add required syscall to sandbox
https://bugs.webkit.org/show_bug.cgi?id=236781
<rdar://89072361>

Reviewed by Chris Dumez.

Add required syscall to the WebContent process' sandbox on macOS. This patch also adds back a set of
syscalls that were removed in https://commits.webkit.org/r286778 for current and previous versions
of macOS. These syscalls will be denied going forward.

WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:29 PM Changeset in webkit [290067] by Nikos Mouchtaris

2 edits in trunk/Source/WTF

[Web Animations] Enable Composite Animations
https://bugs.webkit.org/show_bug.cgi?id=236682

Reviewed by Dean Jackson.

Scripts/Preferences/WebPreferencesExperimental.yaml:

1:27 PM Changeset in webkit [290066] by pvollan@apple.com

2 edits in trunk/Source/WebKit

[macOS][WP] Add required syscall to sandbox
https://bugs.webkit.org/show_bug.cgi?id=236781
<rdar://89072361>

Reviewed by Chris Dumez.

Add required syscall to the WebContent process' sandbox on macOS. This patch also adds back a set of
syscalls that were removed in https://commits.webkit.org/r286778 for current and previous versions
of macOS. These syscalls will be denied going forward.

WebProcess/com.apple.WebProcess.sb.in:

1:19 PM Changeset in webkit [290065] by Nikita Vasilyev

5 edits in trunk/Source/WebInspectorUI

Web Inspector: [Flexbox] Enable Flexbox Inspector feature
https://bugs.webkit.org/show_bug.cgi?id=235820
<rdar://87886409>

Reviewed by Patrick Angle.

Remove the engineering setting and enable the feature by default.

UserInterface/Base/Setting.js:
UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement.prototype._updateLayoutBadge):

UserInterface/Views/LayoutDetailsSidebarPanel.js:

(WI.LayoutDetailsSidebarPanel.prototype.initialLayout):
(WI.LayoutDetailsSidebarPanel.prototype.layout):
(WI.LayoutDetailsSidebarPanel.prototype._refreshNodeSets):
(WI.LayoutDetailsSidebarPanel):

UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createEngineeringSettingsView):

1:13 PM Changeset in webkit [290064] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

[GTK][WPE] Make proper ANGLE context configuration for some of the expected features
https://bugs.webkit.org/show_bug.cgi?id=236664

Patch by Alejandro G. Castro <alex@igalia.com> on 2022-02-17
Reviewed by Žan Doberšek.

Add some missing ANGLE GL context configuration options to respect
some of the expected requirements of the WebGL standard.

Fixing multiple layout tests for the ANGLE backend, we can not
modify them for the moment because this is not the default option
in the compilation.

platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.cpp:

(Nicosia::GCGLANGLELayer::ANGLEContext::createContext): Add a new
parameter to detect WebGL2 context and modify context configuration.
(Nicosia::GCGLANGLELayer::GCGLANGLELayer): Ditto.

platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h: Ditto.
platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::GraphicsContextGLANGLE): Enable
GL_OES_EGL_image required for the coordinated graphics texture rendering.

1:12 PM Changeset in webkit [290063] by Ryan Haddad

2 edits in trunk/LayoutTests

[iOS] css/css-color/t422-rgba-onscreen-b.xht and css/css-color/t425-hsla-onscreen-b.xht are consistently failing
https://bugs.webkit.org/show_bug.cgi?id=236802

Unreviewed test gardening.

platform/ios/TestExpectations: Mark tests as failing.

1:01 PM Changeset in webkit [290062] by Alan Coon

3 edits in branches/safari-613.1.17.1-branch/Source/WebCore

Cherry-pick r290054. rdar://problem/89093315

[macOS] Light appearance text fields are invisible in Increased Contrast mode
https://bugs.webkit.org/show_bug.cgi?id=236753
rdar://89093315

Reviewed by Wenson Hsieh.

In Big Sur, the artwork for many form controls, including text fields, was
changed at the system level. When painting native text fields, WebKit has
long used the "borders only" option to support painting custom background
colors. System-level changes in Big Sur broke the behavior of light appearance
"borders only" text fields in Increased Contrast mode.

Until the artwork is updated at the system-level, work around the issue
in WebKit by painting our own borders for text fields under the necessary
conditions.

No new tests, as tests that change system preferences are often unreliable,
and we do not have existing hooks to toggle Increased Contrast mode.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::shouldPaintCustomTextField const): (WebCore::RenderThemeMac::paintTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:01 PM Changeset in webkit [290061] by Alan Coon

2 edits in branches/safari-613.1.17.1-branch/Source/ThirdParty/ANGLE

Cherry-pick r290011. rdar://problem/89024095

REGRESSION (iOS 15.4b3): Catastrophic (20x) performance regression in texImage2D from mp4 video
https://bugs.webkit.org/show_bug.cgi?id=236699

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Darin Adler.

Disable the validation for IOSurface pixel formats.
We might pass non-public formats that do not have sensible IOSurfaceGetBytesPerElementOfPlane
to verify with this logic.

Will add test in bug 236759.

Previous bugs of the same:
EAGL:
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
bug 218637, r273582, 234632@main
CGL:
REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
bug 232235, r286960, 245183@main

src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm: (rx::IOSurfaceSurfaceMtl::ValidateAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:01 PM Changeset in webkit [290060] by Alan Coon

18 edits in branches/safari-613.1.17.1-branch/Source

Cherry-pick r290005. rdar://problem/87596724

CrashTracer: com.apple.WebKit.WebContent at JavaScriptCore: bmalloc_allocate_impl_impl_slow
https://bugs.webkit.org/show_bug.cgi?id=236695
rdar://87596724

Reviewed by Jer Noble.

Source/WebCore:

When a new FragmentedSharedBuffer is received from the network process, it is proactively coalesced
into a SharedBuffer during each call to CachedResource::updateBuffer(). This causes a large number
of re-allocations and copies; essentially re-allocating each time the resource's buffer receives
one more chunk of data.
Instead we only flatten the data buffer once all data have been received.

Running speedtest.net with a gigabit link, we see a reduction of peak
memory use in the content process by about 40% (from 740MB to under 440MB of
physical memory, 1.7GB of memory allocation vs 535MB)

Covered by existing tests.

editing/ios/EditorIOS.mm: (WebCore::Editor::writeImageToPasteboard):
editing/mac/EditorMac.mm: (WebCore::Editor::writeImageToPasteboard):
loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didFinishLoading):
loader/cache/CachedApplicationManifest.cpp: (WebCore::CachedApplicationManifest::finishLoading):
loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::finishLoading):
loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData):
loader/cache/CachedImage.cpp: (WebCore::CachedImage::updateImageData):
loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::calculateIncrementalDataChunk const): (WebCore::CachedRawResource::updateBuffer): (WebCore::CachedRawResource::finishLoading):
loader/cache/CachedRawResource.h:
loader/cache/CachedResource.h: (WebCore::CachedResource::resourceBuffer const):
loader/cache/CachedScript.cpp: (WebCore::CachedScript::script):
loader/cache/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::finishLoading):

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading): Fly-by fix, the IPC::DataReference would reference a SharedBuffer going out of scope before it was sent over IPC.

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:01 PM Changeset in webkit [290059] by Alan Coon

3 edits
2 adds in branches/safari-613.1.17.1-branch

Cherry-pick r289995. rdar://problem/87462825

REGRESSION(r285885) Unable to exit Trip Details in Amtrak app
https://bugs.webkit.org/show_bug.cgi?id=236732
<rdar://87462825>

Reviewed by Simon Fraser.

Source/WebCore:

Starting from r285885 an (effective)”overflow: clip” value is set on any block box with “contain: paint”.
It is supposed to ensure we don’t paint outside of the box’s border box (note that "contain: paint", as the name implies, should only affect painting).

However this effective value trickles in to layout affecting certain layout constraints.
In case of flex, it makes the flex layout think that the box is really a clipped box and it starts flexing it accordingly producing incorrect size.
What it means is that the minimum preferred size ends up being 0px because now with "let's clip all the overflow content"
0px is indeed the smallest size a box could take that does not produce overflow (while with the initial, “overflow: visible” value,
its minimum width would likely be > 0px -provided it has some content. Also note that setting “overflow: clip” on the box in the markup
(so it becomes an explicit clip value and not just an “effective” implicit clip through “contain: paint”) produces
the exact same rendering meaning that this effective property value does affect layout).

This is a partial revert of r285885 (focusing on where the flex algorithm consults with the flex items' overflow values).

Test: fast/flexbox/incorrect-min-size-with-paint-contain.html

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::mainAxisOverflowForChild const): (WebCore::RenderFlexibleBox::crossAxisOverflowForChild const):

LayoutTests:

fast/flexbox/incorrect-min-size-with-paint-contain-expected.html: Added.
fast/flexbox/incorrect-min-size-with-paint-contain.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:01 PM Changeset in webkit [290058] by Alan Coon

2 edits in branches/safari-613.1.17.1-branch/Source/WTF

Cherry-pick r289974. rdar://problem/89008799

Unreviewed, reverting r286874.
https://bugs.webkit.org/show_bug.cgi?id=236734

Broke Apple Music pages which use the resolution media query

Reverted changeset:

"Enable the 'resolution' media query by default"
https://bugs.webkit.org/show_bug.cgi?id=78087
https://commits.webkit.org/r286874

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:00 PM Changeset in webkit [290057] by Alan Coon

4 edits in branches/safari-613.1.17.1-branch/Source/WebCore

Cherry-pick r289942. rdar://problem/88827167

[Cocoa] Update audio session category before setting NowPlaying status
https://bugs.webkit.org/show_bug.cgi?id=236620
rdar://88827167

Reviewed by Jer Noble.

NowPlaying doesn't update correctly when the audio category changes from Ambient
to Playback after becoming active, so always set the category first.

Tested manually.

platform/audio/PlatformMediaSession.cpp: (WebCore::PlatformMediaSession::clientWillBeginPlayback): Set "preparingToPlay" before calling sessionWillBeginPlayback so updateSessionState can tell that playback is about to begin.
platform/audio/PlatformMediaSession.h:

platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::updateSessionState): Consider a session to potentially have audio if it is preparing to play.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:53 PM Changeset in webkit [290056] by Alan Coon

7 edits
2 adds in branches/safari-613.1.17.2-branch

Cherry-pick r289693. rdar://problem/88264857

Suppress style invalidation when matching :checked
https://bugs.webkit.org/show_bug.cgi?id=235910

Patch by Rob Buis <rbuis@igalia.com> on 2022-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Suppress style invalidation when matching :checked for option elements.

Test: fast/selectors/has-select-option-crash.html

css/SelectorCheckerTestFunctions.h: (WebCore::isChecked):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected const): (WebCore::HTMLOptionElement::setSelectedState):
html/HTMLOptionElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListItemSelectedStates): (WebCore::HTMLSelectElement::recalcListItems const):
html/HTMLSelectElement.h:

LayoutTests:

fast/selectors/has-select-option-crash-expected.txt: Added.
fast/selectors/has-select-option-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:47 PM Changeset in webkit [290055] by Alan Coon

9 edits in branches/safari-613.1.17.2-branch/Source

Versioning.

WebKit-7613.1.17.2.2

12:41 PM Changeset in webkit [290054] by Aditya Keerthi

3 edits in trunk/Source/WebCore

[macOS] Light appearance text fields are invisible in Increased Contrast mode
https://bugs.webkit.org/show_bug.cgi?id=236753
rdar://89093315

Reviewed by Wenson Hsieh.

In Big Sur, the artwork for many form controls, including text fields, was
changed at the system level. When painting native text fields, WebKit has
long used the "borders only" option to support painting custom background
colors. System-level changes in Big Sur broke the behavior of light appearance
"borders only" text fields in Increased Contrast mode.

Until the artwork is updated at the system-level, work around the issue
in WebKit by painting our own borders for text fields under the necessary
conditions.

No new tests, as tests that change system preferences are often unreliable,
and we do not have existing hooks to toggle Increased Contrast mode.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldPaintCustomTextField const):
(WebCore::RenderThemeMac::paintTextField):

12:33 PM Changeset in webkit [290053] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, reverting r290052.
https://bugs.webkit.org/show_bug.cgi?id=236799

Broke the Mac Catalina build

Reverted changeset:

"[macOS] Light appearance text fields are invisible in
Increased Contrast mode"
https://bugs.webkit.org/show_bug.cgi?id=236753
https://commits.webkit.org/r290052

12:27 PM Changeset in webkit [290052] by Aditya Keerthi

3 edits in trunk/Source/WebCore

[macOS] Light appearance text fields are invisible in Increased Contrast mode
https://bugs.webkit.org/show_bug.cgi?id=236753
rdar://89093315

Reviewed by Wenson Hsieh.

Until the artwork is updated at the system-level, work around the issue
in WebKit by painting our own borders for text fields under the necessary
conditions.

No new tests, as tests that change system preferences are often unreliable,
and we do not have existing hooks to toggle Increased Contrast mode.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldPaintCustomTextField const):
(WebCore::RenderThemeMac::paintTextField):

12:27 PM Changeset in webkit [290051] by Nikos Mouchtaris

2 edits in trunk/Source/WTF

Enable CSS Motion Path by default
https://bugs.webkit.org/show_bug.cgi?id=236681

Reviewed by Dean Jackson.

Scripts/Preferences/WebPreferencesExperimental.yaml:

12:21 PM Changeset in webkit [290050] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

Unreviewed, reverting r290046.
https://bugs.webkit.org/show_bug.cgi?id=236797

Broke the macOS build

Reverted changeset:

"[macOS] Light appearance text fields are invisible in
Increased Contrast mode"
https://bugs.webkit.org/show_bug.cgi?id=236753
https://commits.webkit.org/r290046

12:19 PM Changeset in webkit [290049] by Alan Coon

7 edits
2 adds in branches/safari-613.1.17.3-branch

Cherry-pick r289693. rdar://problem/88264857

Suppress style invalidation when matching :checked
https://bugs.webkit.org/show_bug.cgi?id=235910

Patch by Rob Buis <rbuis@igalia.com> on 2022-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Suppress style invalidation when matching :checked for option elements.

Test: fast/selectors/has-select-option-crash.html

css/SelectorCheckerTestFunctions.h: (WebCore::isChecked):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected const): (WebCore::HTMLOptionElement::setSelectedState):
html/HTMLOptionElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListItemSelectedStates): (WebCore::HTMLSelectElement::recalcListItems const):
html/HTMLSelectElement.h:

LayoutTests:

fast/selectors/has-select-option-crash-expected.txt: Added.
fast/selectors/has-select-option-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12:16 PM Changeset in webkit [290048] by Alan Coon

9 edits in branches/safari-613.1.17.3-branch/Source

Versioning.

WebKit-7613.1.17.3.2

12:05 PM Changeset in webkit [290047] by Patrick Angle

3 edits in trunk/Source/WebCore

Web Inspector: [Flexbox] Gaps and free space do not have pattern fills when navigating to a page with Web Inspector already open
https://bugs.webkit.org/show_bug.cgi?id=236741

Reviewed by Devin Rousso.

Because calls to getDocument actually resets the InspectorDOMAgent, we don't want to clear cached layout
information inside reset. The cached layout information is in a WeakHashMap, we aren't going to end up keeping
stale references around anyways, and the under most circumstances the map will clean itself up as it is used.
We should, however go ahead and clear the cached layout information when we are forcing a re-layout to collect
the information again for a new document.

Additionally, if a new document is set, we want to trigger a layout just like we did for a fresh
InspectorDOMAgent.

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):
(WebCore::InspectorDOMAgent::reset):
(WebCore::InspectorDOMAgent::setDocument):
(WebCore::InspectorDOMAgent::relayoutDocument):

inspector/agents/InspectorDOMAgent.h:

12:04 PM Changeset in webkit [290046] by Aditya Keerthi

3 edits in trunk/Source/WebCore

[macOS] Light appearance text fields are invisible in Increased Contrast mode
https://bugs.webkit.org/show_bug.cgi?id=236753
rdar://89093315

Reviewed by Wenson Hsieh.

Until the artwork is updated at the system-level, work around the issue
in WebKit by painting our own borders for text fields under the necessary
conditions.

No new tests, as tests that change system preferences are often unreliable,
and we do not have existing hooks to toggle Increased Contrast mode.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::shouldPaintCustomTextField const):
(WebCore::RenderThemeMac::paintTextField):

12:02 PM Changeset in webkit [290045] by Alexander Mikhaylenko

5 edits in trunk/Source/WebCore

[GTK] REGRESSION: Cumulative velocity for scrolling doesn't work
https://bugs.webkit.org/show_bug.cgi?id=235507

Reviewed by Chris Lord.

ScrollAnimationKinetic can accumulate velocity from the previous scroll
animation. This relies on reusing the same animation every time, so it can
pick up the previous scroll data.

However, ScrollingEffectsController now creates and destroys ScrollAnimationKinetic
every time now, we can't rely on that.

Instead, save and propagate the data manually, same as the macOS port.

platform/ScrollAnimationKinetic.cpp:

(WebCore::ScrollAnimationKinetic::startAnimatedScrollWithInitialVelocity):
(WebCore::ScrollAnimationKinetic::accumulateVelocityFromPreviousGesture):

platform/ScrollAnimationKinetic.h:
platform/ScrollingEffectsController.cpp:

(WebCore::ScrollingEffectsController::processWheelEventForKineticScrolling):

platform/ScrollingEffectsController.h:

11:59 AM Changeset in webkit [290044] by Alan Coon

7 edits
2 adds in branches/safari-613.1.17.0-branch

Cherry-pick r289693. rdar://problem/88264857

Suppress style invalidation when matching :checked
https://bugs.webkit.org/show_bug.cgi?id=235910

Patch by Rob Buis <rbuis@igalia.com> on 2022-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Suppress style invalidation when matching :checked for option elements.

Test: fast/selectors/has-select-option-crash.html

css/SelectorCheckerTestFunctions.h: (WebCore::isChecked):
html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::selected const): (WebCore::HTMLOptionElement::setSelectedState):
html/HTMLOptionElement.h:
html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::updateListItemSelectedStates): (WebCore::HTMLSelectElement::recalcListItems const):
html/HTMLSelectElement.h:

LayoutTests:

fast/selectors/has-select-option-crash-expected.txt: Added.
fast/selectors/has-select-option-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 AM Changeset in webkit [290043] by Alan Coon

2 edits in branches/safari-613.1.17.0-branch/Source/ThirdParty/ANGLE

Cherry-pick r290011. rdar://problem/89024095

REGRESSION (iOS 15.4b3): Catastrophic (20x) performance regression in texImage2D from mp4 video
https://bugs.webkit.org/show_bug.cgi?id=236699

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Darin Adler.

Disable the validation for IOSurface pixel formats.
We might pass non-public formats that do not have sensible IOSurfaceGetBytesPerElementOfPlane
to verify with this logic.

Will add test in bug 236759.

Previous bugs of the same:
EAGL:
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
bug 218637, r273582, 234632@main
CGL:
REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
bug 232235, r286960, 245183@main

src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm: (rx::IOSurfaceSurfaceMtl::ValidateAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 AM Changeset in webkit [290042] by Alan Coon

18 edits in branches/safari-613.1.17.0-branch/Source

Cherry-pick r290005. rdar://problem/87596724

CrashTracer: com.apple.WebKit.WebContent at JavaScriptCore: bmalloc_allocate_impl_impl_slow
https://bugs.webkit.org/show_bug.cgi?id=236695
rdar://87596724

Reviewed by Jer Noble.

Source/WebCore:

When a new FragmentedSharedBuffer is received from the network process, it is proactively coalesced
into a SharedBuffer during each call to CachedResource::updateBuffer(). This causes a large number
of re-allocations and copies; essentially re-allocating each time the resource's buffer receives
one more chunk of data.
Instead we only flatten the data buffer once all data have been received.

Running speedtest.net with a gigabit link, we see a reduction of peak
memory use in the content process by about 40% (from 740MB to under 440MB of
physical memory, 1.7GB of memory allocation vs 535MB)

Covered by existing tests.

editing/ios/EditorIOS.mm: (WebCore::Editor::writeImageToPasteboard):
editing/mac/EditorMac.mm: (WebCore::Editor::writeImageToPasteboard):
loader/DocumentThreadableLoader.cpp: (WebCore::DocumentThreadableLoader::didFinishLoading):
loader/cache/CachedApplicationManifest.cpp: (WebCore::CachedApplicationManifest::finishLoading):
loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::finishLoading):
loader/cache/CachedFont.cpp: (WebCore::CachedFont::ensureCustomFontData):
loader/cache/CachedImage.cpp: (WebCore::CachedImage::updateImageData):
loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::calculateIncrementalDataChunk const): (WebCore::CachedRawResource::updateBuffer): (WebCore::CachedRawResource::finishLoading):
loader/cache/CachedRawResource.h:
loader/cache/CachedResource.h: (WebCore::CachedResource::resourceBuffer const):
loader/cache/CachedScript.cpp: (WebCore::CachedScript::script):
loader/cache/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::finishLoading):

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::finishedLoading): Fly-by fix, the IPC::DataReference would reference a SharedBuffer going out of scope before it was sent over IPC.

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 AM Changeset in webkit [290041] by Alan Coon

3 edits
2 adds in branches/safari-613.1.17.0-branch

Cherry-pick r289995. rdar://problem/87462825

REGRESSION(r285885) Unable to exit Trip Details in Amtrak app
https://bugs.webkit.org/show_bug.cgi?id=236732
<rdar://87462825>

Reviewed by Simon Fraser.

Source/WebCore:

Starting from r285885 an (effective)”overflow: clip” value is set on any block box with “contain: paint”.
It is supposed to ensure we don’t paint outside of the box’s border box (note that "contain: paint", as the name implies, should only affect painting).

However this effective value trickles in to layout affecting certain layout constraints.
In case of flex, it makes the flex layout think that the box is really a clipped box and it starts flexing it accordingly producing incorrect size.
What it means is that the minimum preferred size ends up being 0px because now with "let's clip all the overflow content"
0px is indeed the smallest size a box could take that does not produce overflow (while with the initial, “overflow: visible” value,
its minimum width would likely be > 0px -provided it has some content. Also note that setting “overflow: clip” on the box in the markup
(so it becomes an explicit clip value and not just an “effective” implicit clip through “contain: paint”) produces
the exact same rendering meaning that this effective property value does affect layout).

This is a partial revert of r285885 (focusing on where the flex algorithm consults with the flex items' overflow values).

Test: fast/flexbox/incorrect-min-size-with-paint-contain.html

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::mainAxisOverflowForChild const): (WebCore::RenderFlexibleBox::crossAxisOverflowForChild const):

LayoutTests:

fast/flexbox/incorrect-min-size-with-paint-contain-expected.html: Added.
fast/flexbox/incorrect-min-size-with-paint-contain.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 AM Changeset in webkit [290040] by Alan Coon

2 edits in branches/safari-613.1.17.0-branch/Source/WTF

Cherry-pick r289974. rdar://problem/89008799

Unreviewed, reverting r286874.
https://bugs.webkit.org/show_bug.cgi?id=236734

Broke Apple Music pages which use the resolution media query

Reverted changeset:

"Enable the 'resolution' media query by default"
https://bugs.webkit.org/show_bug.cgi?id=78087
https://commits.webkit.org/r286874

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:51 AM Changeset in webkit [290039] by Alan Coon

4 edits in branches/safari-613.1.17.0-branch/Source/WebCore

Cherry-pick r289942. rdar://problem/88827167

[Cocoa] Update audio session category before setting NowPlaying status
https://bugs.webkit.org/show_bug.cgi?id=236620
rdar://88827167

Reviewed by Jer Noble.

NowPlaying doesn't update correctly when the audio category changes from Ambient
to Playback after becoming active, so always set the category first.

Tested manually.

platform/audio/PlatformMediaSession.cpp: (WebCore::PlatformMediaSession::clientWillBeginPlayback): Set "preparingToPlay" before calling sessionWillBeginPlayback so updateSessionState can tell that playback is about to begin.
platform/audio/PlatformMediaSession.h:

platform/audio/cocoa/MediaSessionManagerCocoa.mm: (WebCore::MediaSessionManagerCocoa::updateSessionState): Consider a session to potentially have audio if it is preparing to play.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@289942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:38 AM Changeset in webkit [290038] by Robert Jenner

2 edits in trunk/LayoutTests

[css-grid] Incorrectly stretched SVGs without an aspect-ratio.
https://bugs.webkit.org/show_bug.cgi?id=216145

Unreviewed test gardening.

Patch by Matteo Flores <Matteo Flores> on 2022-02-17

TestExpectations: Adding failure expectation for tests that were missed.

11:38 AM Changeset in webkit [290037] by Antti Koivisto

8 edits in trunk

[CSS Container Queries] Support full range notation in size queries
https://bugs.webkit.org/show_bug.cgi?id=236771

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

web-platform-tests/css/css-contain/container-queries/at-container-parsing-expected.txt:

Source/WebCore:

Parse and evaluate notations like (100px < width) and (100px < width < 200px).

css/ContainerQuery.h:

There are now optional left and right comparisons.

css/ContainerQueryParser.cpp:

(WebCore::ContainerQueryParser::consumeSizeQuery):
(WebCore::ContainerQueryParser::consumeSizeFeature):
(WebCore::ContainerQueryParser::consumePlainSizeFeature):

Evaluate the plain (foo: value) notation.

(WebCore::ContainerQueryParser::consumeRangeSizeFeature):

Evaluate range notation.

(WebCore::ContainerQueryParser::consumeValue):

css/ContainerQueryParser.h:
style/ContainerQueryEvaluator.cpp:

(WebCore::Style::ContainerQueryEvaluator::evaluateSizeFeature const):

Evaluate both comparisons if they exist.

style/ContainerQueryEvaluator.h:

(WebCore::Style::toEvaluationResult):
(WebCore::Style::operator|):

11:05 AM Changeset in webkit [290036] by Alan Coon

9 edits in branches/safari-613.1.17.1-branch/Source

Versioning.

WebKit-7613.1.17.1.5

11:05 AM Changeset in webkit [290035] by Alan Coon

9 edits in branches/safari-613.1.17.0-branch/Source

Versioning.

WebKit-7613.1.17.0.5

10:23 AM Changeset in webkit [290034] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

ASSERTION FAILED: Thread::current().uid() == threadAssertion.m_uid for RemoteVideoFrameObjectHeap
https://bugs.webkit.org/show_bug.cgi?id=236786

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Antti Koivisto.

The object is ok to destroy from any thread.
Reset the thread assertion.

GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:

(WebKit::RemoteVideoFrameObjectHeap::~RemoteVideoFrameObjectHeap):

10:19 AM Changeset in webkit [290033] by sihui_liu@apple.com

8 edits in trunk

Ensure NetworkStorageManager::moveData performs move operation based on data types
https://bugs.webkit.org/show_bug.cgi?id=236727
rdar://89009881

Reviewed by Chris Dumez.

Source/WebKit:

In r286936, we introduced NetworkStorageManager::moveData to move data from one origin to another. However, the
function does not take dataTypes parameter as NetworkProcess::renameOriginInWebsiteData does, and
NetworkStorageManager would try to move every storage type it manages. This has caused an unexpected failure, as
FileSystem storage needs special handling before data can be moved. To address the regression, let's revert
the behavior change by making sure NetworkStorageManager checks the types value, and only performs move
operation for IndexedDB and LocalStorage data.

Updated existing API test to ensure only expected data types are moved.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::renameOriginInWebsiteData):

NetworkProcess/storage/NetworkStorageManager.cpp:

(WebKit::NetworkStorageManager::moveData):

NetworkProcess/storage/NetworkStorageManager.h:
NetworkProcess/storage/OriginStorageManager.cpp:

(WebKit::OriginStorageManager::StorageBucket::moveData):
(WebKit::OriginStorageManager::StorageBucket::resolvedLocalStoragePath):
(WebKit::OriginStorageManager::StorageBucket::deleteIDBStorageData):
(WebKit::OriginStorageManager::resolvedLocalStoragePath):
(WebKit::OriginStorageManager::resolvedIDBStoragePath):
(WebKit::OriginStorageManager::moveData):

NetworkProcess/storage/OriginStorageManager.h:

Tools:

TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:

(TEST):

9:57 AM Changeset in webkit [290032] by commit-queue@webkit.org

3 edits
2 adds in trunk

Fix abs-pos breadth issue when using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=236626

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-17
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Adds new test that uses RTL and abs-pos items over the padding area, with
padding defined in physical coords.

web-platform-tests/css/css-grid/abspos/positioned-grid-items-025-expected.html: Added.
web-platform-tests/css/css-grid/abspos/positioned-grid-items-025.html: Added.

Source/WebCore:

The value returned when resolving an 'auto' start/end is in logical coords, but the line
positions are in a hybrid space using logical column sizes, but physical border/padding offset.
This adjusts for this, so that we can compute the breadth correctly.

Adds new test that uses RTL and abs-pos items over the padding area, with
padding defined in physical coords.

Test: imported/w3c/web-platform-tests/css/css-grid/abspos/positioned-grid-items-025.html

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):

9:56 AM Changeset in webkit [290031] by commit-queue@webkit.org

35 edits
2 adds
2 deletes in trunk/Source

MediaPlayer::videoFrameForCurrentTime() should return VideoFrame
https://bugs.webkit.org/show_bug.cgi?id=236701

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Eric Carlson.
Source/WebCore:

Rename CV specific parts of MediaSampleVideoFrame to VideoFrameCV.
Use VideoFrame base class instead of MediaSampleVideoFrame.
VideoFrame supports multiple polymorphic subclasses. One such
is RemoteVideoFrameProxy, which will be used in the future to
return remote proxy objects in these locations.

This patch is only a rename. It concerns only the in-process
usage of video frames via in-process VideoFrameCV.

No new tests, refactor.

Headers.cmake:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/MediaSample.h:

(WebCore::MediaSample::videoPixelFormat const):

platform/VideoFrame.cpp:

(WebCore::VideoFrame::VideoFrame):
(WebCore::VideoFrame::presentationTime const):
(WebCore::VideoFrame::videoRotation const):
(WebCore::VideoFrame::videoMirrored const):
(WebCore::VideoFrame::platformSample const):

platform/VideoFrame.h:

(WebCore::VideoFrame::isRemoteProxy const):
This leaks "remote" concept to WebCore level. Hopefully
in the future this can be solved in another way.
(WebCore::VideoFrame::isCV const):
(isType):

platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::videoFrameForCurrentTime):

platform/graphics/MediaPlayer.h:
platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::videoFrameForCurrentTime):

platform/graphics/MediaSampleVideoFrame.h: Removed.
platform/graphics/avfoundation/MediaSampleVideoFrameAVF.mm: Removed.
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::videoFrameForCurrentTime):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::videoFrameForCurrentTime):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::videoFrameForCurrentTime):

platform/graphics/avfoundation/objc/MediaSampleAVFObjC.h:
platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::videoFrame const):

platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::copyTextureFromMedia):

platform/graphics/cv/GraphicsContextGLCV.h:
platform/graphics/cv/GraphicsContextGLCVCocoa.cpp:

(WebCore::GraphicsContextGLCVCocoa::copyVideoSampleToTexture):

platform/graphics/cv/GraphicsContextGLCVCocoa.h:
platform/graphics/cv/VideoFrameCV.h: Added.

(WebCore::VideoFrameCV::pixelBuffer const):
(WebCore::VideoFrameCV::encode const):
(WebCore::VideoFrameCV::decode):
(isType):

platform/graphics/cv/VideoFrameCV.mm: Added.

(WebCore::VideoFrameCV::create):
(WebCore::VideoFrameCV::VideoFrameCV):
(WebCore::VideoFrameCV::presentationSize const):
(WebCore::VideoFrameCV::videoPixelFormat const):
(WebCore::VideoFrameCV::orientation const):

Source/WebKit:

Use added VideoFrameCV instead of removed MediaSampleVideoFrame.

GPUProcess/graphics/RemoteGraphicsContextGL.cpp:

(WebKit::RemoteGraphicsContextGL::copyTextureFromMedia):

GPUProcess/media/RemoteMediaPlayerProxy.cpp:

(WebKit::RemoteMediaPlayerProxy::invalidate):
(WebKit::RemoteMediaPlayerProxy::videoFrameForCurrentTimeIfChanged):

GPUProcess/media/RemoteMediaPlayerProxy.h:
GPUProcess/media/RemoteMediaPlayerProxy.messages.in:
Platform/IPC/ArgumentCoders.h:

(IPC::ArgumentCoder<RefPtr<T>>::encode):
(IPC::ArgumentCoder<RefPtr<T>>::decode):

WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:

(WebKit::MediaPlayerPrivateRemote::videoFrameForCurrentTime):

WebProcess/GPU/media/MediaPlayerPrivateRemote.h:
WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:

(WebKit::RemoteVideoFrameProxy::RemoteVideoFrameProxy):

WebProcess/GPU/media/RemoteVideoFrameProxy.h:

(isType):

9:45 AM Changeset in webkit [290030] by Simon Fraser

16 edits
1 copy in trunk/Source/WebKit

Add support for setting RemoteLayerBackingStore buffers non-volatile in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=236731

Reviewed by Tim Horton.

Calls to setVolatile() and isInUse() on IOSurface need to happen in the GPU Process,
so when RemoteLayerBackingStore swaps buffers in display(), and makes the front buffer
non-volatile, those things need to go via RemoteRenderingBackend.

So plumb markSurfaceNonVolatile() and swapToValidFrontBuffer() through RemoteLayerBackingStoreCollection
and RemoteRenderingBackend, both as sync messages.

In both cases, if the surface was purged (i.e. setNonVolatile returned Empty) we need
to trigger a setNeedsDisplay(), wired through RemoteLayerBackingStore::didMakeFrontBufferNonVolatile()
so there's only one call site.

We also need to always send the ImageBufferBackendHandle back from the GPU Process for
the front buffer, since a future patch will clear these out in the web process when
making buffers volatile.

GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::handleFromBuffer):
(WebKit::RemoteRenderingBackend::markSurfaceNonVolatile):
(WebKit::RemoteRenderingBackend::swapToValidFrontBuffer):

GPUProcess/graphics/RemoteRenderingBackend.h:
GPUProcess/graphics/RemoteRenderingBackend.messages.in:
Shared/RemoteLayerTree/RemoteLayerBackingStore.h:
Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::swapToValidFrontBuffer):
(WebKit::RemoteLayerBackingStore::applySwappedBuffers):
(WebKit::RemoteLayerBackingStore::swapBuffers):
(WebKit::RemoteLayerBackingStore::supportsPartialRepaint const):
(WebKit::RemoteLayerBackingStore::display):
(WebKit::RemoteLayerBackingStore::setBufferVolatile):
(WebKit::RemoteLayerBackingStore::setBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::willMakeBufferVolatile):
(WebKit::RemoteLayerBackingStore::didMakeFrontBufferNonVolatile):
(WebKit::RemoteLayerBackingStore::setBufferVolatility):
(WebKit::RemoteLayerBackingStore::bufferForType const):
(WebKit::RemoteLayerBackingStore::supportsPartialRepaint): Deleted.

Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.h:
Shared/RemoteLayerTree/RemoteLayerBackingStoreCollection.mm:

(WebKit::RemoteLayerBackingStoreCollection::makeFrontBufferNonVolatile):
(WebKit::RemoteLayerBackingStoreCollection::swapToValidFrontBuffer):

Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.h:
Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm:

(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::makeFrontBufferNonVolatile):
(WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::swapToValidFrontBuffer):

WebProcess/GPU/graphics/ImageBufferBackendHandleSharing.h:

(WebKit::ImageBufferBackendHandleSharing::setBackendHandle):
(WebKit::ImageBufferBackendHandleSharing::clearBackendHandle):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::getPixelBufferForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::putPixelBufferForImageBuffer):
(WebKit::RemoteRenderingBackendProxy::swapToValidFrontBuffer):
(WebKit::RemoteRenderingBackendProxy::markSurfaceNonVolatile):

WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.cpp:

(WebKit::ImageBufferRemoteIOSurfaceBackend::setBackendHandle):
(WebKit::ImageBufferRemoteIOSurfaceBackend::clearBackendHandle):

WebProcess/GPU/graphics/cocoa/ImageBufferRemoteIOSurfaceBackend.h:

9:42 AM Changeset in webkit [290029] by Truitt Savell

1 edit
1 delete in trunk/LayoutTests

Remove the Catalina specific expectation added in r289834
https://bugs.webkit.org/show_bug.cgi?id=236619

Unreviewed test gardening.

platform/mac-catalina/fonts/monospace-expected.txt: Removed.

9:38 AM Changeset in webkit [290028] by jonlee@apple.com

2 edits in trunk/LayoutTests

Unreviewed GPU Process bot gardening.

gpu-process/TestExpectations:

9:18 AM Changeset in webkit [290027] by Adrian Perez de Castro

2 edits in trunk/Source/ThirdParty/ANGLE

[GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present
https://bugs.webkit.org/show_bug.cgi?id=236770

Reviewed by Alejandro G. Castro.

PlatformGTK.cmake: The USE_SYSTEM_EGL definition detaches the type definitions

from the EGL headers generic and prevents ANGLE's headers from including system X11
or Wayland headers from the system, so apply it always independently of whether the
USE_ANGLE_{EGL,WEBGL} options are enabled. While at it, fix a missing dollar sign in
the expansion of the ${GBM_INCLUDE_DIR} variable.

9:17 AM Changeset in webkit [290026] by Chris Dumez

155 edits in trunk/Source

Clean up / optimize call sites constructing vectors
https://bugs.webkit.org/show_bug.cgi?id=236748

Reviewed by Dean Jackson.

Clean up / optimize call sites constructing vectors:

Use Vector::map() / WTF::map() where appropriate

Source/JavaScriptCore:

Replace Vector::reserveCapacity() with Vector::reserveInitialCapacity() where appropriate
Replace Vector::append() with Vector::uncheckedAppend() where appropriate
Leverage the fact that Vector<Ref<Foo>> is now copyable (Because Ref<> now has a copy constructor)
Call crossThreadCopy() to isolate-copy a Vector() without iterating.
Leverage Vector constructor that takes in an intialization list in more cases
Leverage Vector::from() in more cases to simplify vector construction in some case.
Drop unnecessary calls to Vector::reserve*Capacity() before calling Vector::append(T*, size_t) since the append() implementation already does this for us.
Leverage copyToVector() and copyToVectorOf<> in more cases
Call shrinkToFit() in some cases where we reserve capacity and then append() but may not append() as much as we reserved.

b3/air/AirCode.cpp:

(JSC::B3::Air::Code::setNumEntrypoints):

bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::setLiveValues):

dfg/DFGLivenessAnalysisPhase.cpp:
dfg/DFGScoreBoard.h:

(JSC::DFG::ScoreBoard::ScoreBoard):

inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::parseBreakpointOptions):

inspector/remote/socket/RemoteInspectorMessageParser.cpp:

(Inspector::MessageParser::pushReceivedData):

parser/VariableEnvironment.cpp:

(JSC::CompactTDZEnvironment::CompactTDZEnvironment):

wasm/WasmWorklist.cpp:

(JSC::Wasm::Worklist::Worklist):

Source/WebCore:

Replace Vector::reserveCapacity() with Vector::reserveInitialCapacity() where appropriate
Replace Vector::append() with Vector::uncheckedAppend() where appropriate
Leverage the fact that Vector<Ref<Foo>> is now copyable (Because Ref<> now has a copy constructor)
Call crossThreadCopy() to isolate-copy a Vector() without iterating.
Leverage Vector constructor that takes in an intialization list in more cases
Leverage Vector::from() in more cases to simplify vector construction in some case.
Drop unnecessary calls to Vector::reserve*Capacity() before calling Vector::append(T*, size_t) since the append() implementation already does this for us.
Leverage copyToVector() and copyToVectorOf<> in more cases
Call shrinkToFit() in some cases where we reserve capacity and then append() but may not append() as much as we reserved.

Modules/async-clipboard/Clipboard.cpp:

(WebCore::Clipboard::read):
(WebCore::Clipboard::ItemWriter::didSetAllData):

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::updateKeyStatuses):

Modules/entriesapi/FileSystemEntriesCallback.cpp:

(WebCore::FileSystemEntriesCallback::scheduleCallback):
(WebCore::copyVector): Deleted.

Modules/entriesapi/HTMLInputElementEntriesAPI.cpp:

(WebCore::HTMLInputElementEntriesAPI::webkitEntries):

Modules/geolocation/GeolocationController.cpp:

(WebCore::GeolocationController::positionChanged):
(WebCore::GeolocationController::errorOccurred):

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::stop):

Modules/indexeddb/IDBGetAllResult.cpp:

(WebCore::IDBGetAllResult::isolatedCopy):

Modules/indexeddb/IDBGetResult.cpp:

(WebCore::IDBGetResult::isolatedCopy):

Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::isolatedCopy): Deleted.

Modules/indexeddb/IDBKeyPath.h:

(WebCore::isolatedCopy): Deleted.

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::abortInProgressOperations):

Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::removeItemsMatchingCurrentThread):

Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::deleteAllIndexes):

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::currentData):

Modules/indexeddb/shared/IDBDatabaseInfo.cpp:

(WebCore::IDBDatabaseInfo::objectStoreNames const):

Modules/indexeddb/shared/IDBIndexInfo.cpp:

(WebCore::IDBIndexInfo::isolatedCopy const):

Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:

(WebCore::IDBObjectStoreInfo::isolatedCopy const):
(WebCore::IDBObjectStoreInfo::indexNames const):

Modules/indexeddb/shared/IDBTransactionInfo.cpp:

(WebCore::IDBTransactionInfo::isolatedCopy):

Modules/indexeddb/shared/IndexKey.cpp:

(WebCore::IndexKey::isolatedCopy const):

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::clone):

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::capabilityStringVector):

Modules/mediastream/MediaTrackConstraints.cpp:

(WebCore::convertAdvancedToInternalForm):

Modules/mediastream/SFrameUtils.cpp:

(WebCore::toRbsp):

Modules/remoteplayback/RemotePlayback.cpp:

(WebCore::RemotePlayback::availabilityChanged):

Modules/speech/SpeechRecognition.cpp:

(WebCore::SpeechRecognition::didReceiveResult):

Modules/webauthn/cbor/CBORValue.cpp:

(cbor::CBORValue::CBORValue):

Modules/webauthn/fido/AuthenticatorGetInfoResponse.cpp:

(fido::toArrayValue):

Modules/webauthn/fido/DeviceRequestConverter.cpp:

(fido::convertParametersToCBOR):

Modules/webauthn/fido/Pin.cpp:

(fido::pin::encodeRawPublicKey):

Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::databaseNames):
(WebCore::isolatedCopy): Deleted.

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::setMathscripts):
(WebCore::AXIsolatedObject::setObjectVectorProperty):

accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::objectsForIDs const):
(WebCore::AXIsolatedTree::collectNodeChangesForSubtree):

animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readString):
(WebCore::SerializedScriptValue::blobURLs const):

crypto/mac/CryptoAlgorithmECDSAMac.cpp:

(WebCore::signECDSA):
(WebCore::verifyECDSA):

crypto/mac/CryptoKeyECMac.cpp:

(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):

crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::exportSpki const):
(WebCore::CryptoKeyRSA::exportPkcs8 const):

css/CSSBasicShapes.cpp:

(WebCore::CSSBasicShapePolygon::cssText const):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::copyPropertiesInSet):
(WebCore::ComputedStyleExtractor::copyProperties):

css/CSSFontFace.cpp:

(WebCore::iterateClients):

css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::matchingFacesExcludingPreinstalledFonts):
(WebCore::CSSFontFaceSet::fontFace):

css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):

css/StyleProperties.cpp:

(WebCore::StyleProperties::copyPropertiesInSet const):
(WebCore::DeferredStyleProperties::DeferredStyleProperties):

css/StyleRule.cpp:

(WebCore::DeferredStyleGroupRuleList::DeferredStyleGroupRuleList):
(WebCore::StyleRuleGroup::StyleRuleGroup):

css/calc/CSSCalcOperationNode.h:
css/calc/CSSCalcValue.cpp:

(WebCore::createCSS):

display/css/DisplayBoxDecorationPainter.cpp:

(WebCore::Display::BorderPainter::clipBorderSidePolygon const):
(WebCore::Display::BorderPainter::drawLineForBoxSide const):

dom/DOMRectList.cpp:

(WebCore::DOMRectList::DOMRectList):

dom/Document.cpp:

(WebCore::Document::updateElementsAffectedByMediaQueries):
(WebCore::Document::didAssociateFormControlsTimerFired):

dom/ElementData.cpp:

(WebCore::UniqueElementData::UniqueElementData):

dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::eventTypes const):

dom/TreeScopeOrderedMap.cpp:

(WebCore::TreeScopeOrderedMap::keys const):

editing/CompositeEditCommand.cpp:

(WebCore::copyMarkers):

editing/Editor.cpp:

(WebCore::editableTextListsAtPositionInDescendingOrder):

fileapi/FileList.cpp:

(WebCore::FileList::paths const):

history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::m_formData):
(WebCore::m_identifier):

html/FileInputType.cpp:

(WebCore::FileInputType::setFiles):
(WebCore::FileInputType::filesChosen):

html/LinkIconCollector.cpp:

(WebCore::LinkIconCollector::iconsOfTypes):

html/URLSearchParams.cpp:

(WebCore::URLSearchParams::getAll const):

layout/formattingContexts/inline/InlineLineBuilder.cpp:

(WebCore::Layout::LineBuilder::layoutInlineContent):

loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startIconLoading):
(WebCore::DocumentLoader::setActiveContentRuleListActionPatterns):

loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::getNewCues):

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createFromSelection):

page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::preferredAudioCharacteristics const):

page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):

page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::create):

page/Page.cpp:

(WebCore::Page::replaceRangesWithText):

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::responseHeaders const):

page/csp/ContentSecurityPolicyResponseHeaders.cpp:

(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy const):

page/mac/ImageOverlayControllerMac.mm:

(WebCore::ImageOverlayController::updateDataDetectorHighlights):

page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::buildSelectionHighlight):
(WebCore::ServicesOverlayController::handleClick):

page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::childrenOfNode const):

page/scrolling/ScrollSnapOffsetsInfo.cpp:

(WebCore::convertOffsetInfo):

platform/Length.cpp:

(WebCore::makeCalculated):

platform/animation/AnimationList.cpp:

(WebCore::AnimationList::AnimationList):

platform/cocoa/PlaybackSessionModelMediaElement.mm:

(WebCore::PlaybackSessionModelMediaElement::audioMediaSelectionOptions const):

platform/encryptedmedia/CDMProxy.cpp:

(WebCore::KeyStore::convertToJSKeyStatusVector const):

platform/graphics/FloatPolygon.cpp:

(WebCore::FloatPolygon::overlappingEdges const):

platform/graphics/FloatQuad.cpp:

(WebCore::boundingBoxes):

platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):

platform/graphics/ca/TileGrid.cpp:

(WebCore::TileGrid::removeTiles):
(WebCore::TileGrid::removeAllTiles):

platform/graphics/ca/TileGrid.h:
platform/graphics/cg/ImageUtilitiesCG.cpp:

(WebCore::findImagesForTranscoding):
(WebCore::transcodeImages):

platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::findClosestFont):
(WebCore::FontCache::getFontSelectionCapabilitiesInFamily):

platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::fitnessDistance):

platform/network/CacheValidation.cpp:

(WebCore::collectVaryingRequestHeadersInternal):

platform/network/FormData.cpp:

(WebCore::FormData::isolatedCopy const):

platform/network/SocketStreamHandleImpl.cpp:

(WebCore::SocketStreamHandleImpl::platformSendHandshake):

platform/network/cocoa/NetworkStorageSessionCocoa.mm:
platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::createLabelVector):
(WebCore::createFallbackMonthLabels):
(WebCore::createFallbackAMPMLabels):

platform/text/LocaleNone.cpp:

(WebCore::LocaleNone::monthLabels):
(WebCore::LocaleNone::shortMonthLabels):
(WebCore::LocaleNone::timeAMPMLabels):

platform/text/cocoa/LocaleCocoa.mm:

(WebCore::LocaleCocoa::monthLabels):
(WebCore::LocaleCocoa::shortMonthLabels):
(WebCore::LocaleCocoa::standAloneMonthLabels):
(WebCore::LocaleCocoa::shortStandAloneMonthLabels):
(WebCore::LocaleCocoa::timeAMPMLabels):

plugins/DOMMimeTypeArray.cpp:

(WebCore::DOMMimeTypeArray::supportedPropertyNames const):
(WebCore::DOMMimeTypeArray::supportedPropertyNames): Deleted.

plugins/DOMMimeTypeArray.h:
plugins/DOMPlugin.cpp:

(WebCore::makeMimeTypes):
(WebCore::DOMPlugin::supportedPropertyNames const):
(WebCore::DOMPlugin::supportedPropertyNames): Deleted.

plugins/DOMPlugin.h:
plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::supportedPropertyNames const):
(WebCore::DOMPluginArray::supportedPropertyNames): Deleted.

plugins/DOMPluginArray.h:
rendering/LayerAncestorClippingStack.cpp:

(WebCore::LayerAncestorClippingStack::LayerAncestorClippingStack):
(WebCore::LayerAncestorClippingStack::compositedClipData const):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

rendering/RenderElement.cpp:

(WebCore::RenderElement::drawLineForBoxSide const):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::trackSizesForComputedStyle const):

style/ClassChangeInvalidation.cpp:

(WebCore::Style::collectClasses):

style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertTo100PercentMinusLength):

testing/MockCDMFactory.cpp:

(WebCore::MockCDMInstanceSession::updateLicense):
(WebCore::MockCDMInstanceSession::removeSessionData):

workers/service/server/SWServer.cpp:

(WebCore::SWServer::getRegistrations):

Source/WebKit:

Replace Vector::reserveCapacity() with Vector::reserveInitialCapacity() where appropriate
Replace Vector::append() with Vector::uncheckedAppend() where appropriate
Leverage the fact that Vector<Ref<Foo>> is now copyable (Because Ref<> now has a copy constructor)
Call crossThreadCopy() to isolate-copy a Vector() without iterating.
Leverage Vector constructor that takes in an intialization list in more cases
Leverage Vector::from() in more cases to simplify vector construction in some case.
Drop unnecessary calls to Vector::reserve*Capacity() before calling Vector::append(T*, size_t) since the append() implementation already does this for us.
Leverage copyToVector() and copyToVectorOf<> in more cases
Call shrinkToFit() in some cases where we reserve capacity and then append() but may not append() as much as we reserved.

NetworkProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::originDetailsCrossThreadCopy):

NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::Caches::cacheInfos):

Shared/API/APIArray.cpp:

(API::Array::createStringArray):
(API::Array::copy):

Shared/API/APIDictionary.cpp:

(API::Dictionary::keys const):

Shared/UserData.cpp:

(WebKit::transformGraph):

Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::create):
(WebKit::WebContextMenuItem::submenuItemsAsAPIArray const):

Shared/WebContextMenuItemData.cpp:

(WebKit::kitItems):
(WebKit::coreItems):

UIProcess/API/APIWebAuthenticationPanel.cpp:

(API::WebAuthenticationPanel::WebAuthenticationPanel):

UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::copy const):
(API::WebsitePolicies::data):

UIProcess/API/C/WKPage.cpp:

(API::toAPIObjectVector):
(WKPageSetPageContextMenuClient):
(WKPageSetPageFindMatchesClient):
(WKPageSetPageLoaderClient):

UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::forEachSession):

UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::snapshotGamepads):

UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::allNetworkProcesses):
(WebKit::NetworkProcessProxy::updatePrevalentDomainsToBlockCookiesFor):

UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):

UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::clearNotifications):

UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

UIProcess/UserContent/WebUserContentControllerProxy.cpp:

(WebKit::WebUserContentControllerProxy::removeAllUserScripts):
(WebKit::WebUserContentControllerProxy::removeAllUserStyleSheets):

UIProcess/WebAuthentication/Cocoa/WebAuthenticationPanelClient.mm:

(WebKit::WebAuthenticationPanelClient::selectAssertionResponse const):

UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp:

(WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived):

UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::clear):
(WebKit::WebBackForwardList::restoreFromState):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptInFrameInScriptWorld):
(WebKit::WebPageProxy::speechSynthesisVoiceList):

UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::parametersFromEachWebsiteDataStore):

UIProcess/mac/WKTextFinderClient.mm:

(-[WKTextFinderClient replaceMatches:withString:inSelectionOnly:resultCollector:]):

WebProcess/GPU/media/RemoteRemoteCommandListener.cpp:

(WebKit::RemoteRemoteCommandListener::updateSupportedCommands):

WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(contextMenuItems):
(WKBundlePageCopyOriginsWithApplicationCache):

WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):

WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::networkProcessCrashed):

WebProcess/Network/webrtc/WebRTCResolver.cpp:

(WebKit::WebRTCResolver::setResolvedAddress):

WebProcess/WebCoreSupport/WebResourceLoadObserver.cpp:

(WebKit::WebResourceLoadObserver::takeStatistics):

WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::replaceMatches):

WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::toKeyframeValueVector):
(WebKit::PlatformCAAnimationRemote::setValues):
(WebKit::PlatformCAAnimationRemote::setTimingFunctions):

WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::computeTextLegibilityScales):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):
(WebKit::dumpHistoryItem):

Source/WTF:

Replace Vector::reserveCapacity() with Vector::reserveInitialCapacity() where appropriate
Replace Vector::append() with Vector::uncheckedAppend() where appropriate
Leverage the fact that Vector<Ref<Foo>> is now copyable (Because Ref<> now has a copy constructor)
Call crossThreadCopy() to isolate-copy a Vector() without iterating.
Leverage Vector constructor that takes in an intialization list in more cases
Leverage Vector::from() in more cases to simplify vector construction in some case.
Drop unnecessary calls to Vector::reserve*Capacity() before calling Vector::append(T*, size_t) since the append() implementation already does this for us.
Leverage copyToVector() and copyToVectorOf<> in more cases
Call shrinkToFit() in some cases where we reserve capacity and then append() but may not append() as much as we reserved.

wtf/Language.cpp:

(WTF::userPreferredLanguages):
(WTF::isolatedCopy): Deleted.

9:14 AM Changeset in webkit [290025] by Antti Koivisto

2 edits in trunk/Source/WTF

[CSS Container Queries] Enable by default
https://bugs.webkit.org/show_bug.cgi?id=236776

Reviewed by Sam Weinig.

Flip the switch.

Scripts/Preferences/WebPreferencesExperimental.yaml:

8:56 AM Changeset in webkit [290024] by ysuzuki@apple.com

2 edits in trunk/Source/bmalloc

Unreviewed, fix heap enumeration
https://bugs.webkit.org/show_bug.cgi?id=236662

libpas/src/libpas/pas_enumerate_segregated_heaps.c:

(pas_enumerate_segregated_heaps):

7:30 AM Changeset in webkit [290023] by commit-queue@webkit.org

3 edits in trunk/Source/WebCore

[GTK] Build failure when building with ANGLE enabled since r289912
https://bugs.webkit.org/show_bug.cgi?id=236773

Patch by Alejandro G. Castro <alex@igalia.com> on 2022-02-17
Reviewed by Adrian Perez de Castro.

Avoid including GLContext in the ANGLE classes.

No new tests, it is a building error.

platform/graphics/nicosia/texmap/NicosiaGCGLANGLELayer.h:
platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

7:27 AM Changeset in webkit [290022] by Adrian Perez de Castro

1 copy in releases/WPE WebKit/webkit-2.34.6

WPE WebKit 2.34.6

7:27 AM Changeset in webkit [290021] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.34

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.34.6 release

Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

wpe/NEWS: Add release notes for 2.34.6

7:27 AM Changeset in webkit [290020] by Adrian Perez de Castro

1 copy in releases/WebKitGTK/webkit-2.34.6

WebKitGTK 2.34.6

7:26 AM Changeset in webkit [290019] by Adrian Perez de Castro

4 edits in releases/WebKitGTK/webkit-2.34

Unreviewed. Update OptionsGTK.cmake and NEWS for the 2.34.6 release

Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

gtk/NEWS: Add release notes for 2.34.6

7:26 AM Changeset in webkit [290018] by Adrian Perez de Castro

2 edits in releases/WebKitGTK/webkit-2.34/Source/ThirdParty/ANGLE

[GTK] Build broken with ENABLE_X11_TARGET=OFF and no X11 headers present

Unreviewed build fix.

This is a fix in the same vein as the one in https://bugs.webkit.org/show_bug.cgi?id=236770
for the stable 2.34 release branch.

PlatformGTK.cmake: Make sure that ANGLE_USE_X11, WL_EGL_PLATFORM, or USE_SYSTEM_EGL

are always defined independently of the USE_ANGLE_EGL and USE_ANGLE_WEBGL options.

7:26 AM Changeset in webkit [290017] by Adrian Perez de Castro

11 edits in releases/WebKitGTK/webkit-2.34

Merge r289949 - [CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc
https://bugs.webkit.org/show_bug.cgi?id=236592

Reviewed by Don Olmstead.

Source/cmake/FindOpenGL.cmake: Rewrite to use imported targets, try the "opengl" and "glx"

pkg-config modules first, otherwise keep the existing logic that tried the "gl" pkg-config
module with fallbacks to find_path/find_library.

Source/cmake/OptionsGTK.cmake: Check for the presence of the OpenGL::GLX target instead of

te GLX_FOUND variable.

Source/ThirdParty/ANGLE:

PlatformGTK.cmake: Use the OpenGL::OpenGL imported target instead of the

OPENGL_LIBRARIES variable.

PlatformWPE.cmake: Ditto, plus replace a spurious use of OPENGLES_LIBRARIES

with the OpenGL::GLES target.

Source/WebCore:

CMakeLists.txt: Use the OpenGL::OpenGL and OpenGL::GLX imported targets instead of variables.
platform/graphics/GLContext.cpp: Move here includes for the GL headers.
platform/graphics/GLContext.h: Remove includes for the GL headers, none of their

declarations are used here; instead include only the needed EGL headers to get the
definition of EGLNativeWindowType.

Source/WebKit:

CMakeLists.txt: Remove usage of the OPENGL_ variables for the WebKit target, which is

uneeded because it links to WebCore, which transitively pulls the needed libraries now
that imported targets are being used.

7:02 AM Changeset in webkit [290016] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][IFC] Decouple line box relative alignment types when computing the root inline box's baseline position
https://bugs.webkit.org/show_bug.cgi?id=236675

Reviewed by Antti Koivisto.

Line box relative alignments (top/bottom) impact on the root inline box's baseline is slightly different from
the rest of the alignments (baseline etc). In these patch these alignment type are moved out of the main loop where
all the other alignments are handled (this is similar to what we do at other placed e.g. LineBoxVerticalAligner::computeLineBoxLogicalHeight).
This patch is in preparation for fixing the bug where the 'vertical-bottom' aligned box makes other inline level boxes stick out of their parent block.

layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:

(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):

6:54 AM Changeset in webkit [290015] by Chris Lord

3 edits in trunk/Source/WebCore

[WPE] Build failure when building with ANGLE enabled since r289912
https://bugs.webkit.org/show_bug.cgi?id=236768

Reviewed by Alejandro G. Castro.

Fix build after regression caused by r289912.

platform/graphics/angle/GraphicsContextGLANGLE.h:
platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp:

(WebCore::GraphicsContextGLANGLE::EGLImageBacking::EGLImageBacking):

5:38 AM Changeset in webkit [290014] by Angelos Oikonomopoulos

2 edits in trunk/Tools

[JSC] Increase timeout to account for MIPS slowness
https://bugs.webkit.org/show_bug.cgi?id=236763

Reviewed by Adrian Perez de Castro.

Commit https://commits.webkit.org/247272@main parallelized the
status fetching but also introduced a timeout. Unfortunately, the
MIPS boards used in the build.webkit.org buildbot are not fast
enough to gather the test results in this timeout, so the bot can
never complete its testing. This wasn't caught in EWS as the
buildbots use faster MIPS hardware there.

Significantly bump the timeout when fetching results.

Scripts/run-jsc-stress-tests:

5:36 AM Changeset in webkit [290013] by Lauro Moura

2 edits in trunk/Source/WebCore

Unreviewed, non-unified build fix after r290003
https://bugs.webkit.org/show_bug.cgi?id=236774

animation/FrameRateAligner.h:

5:32 AM Changeset in webkit [290012] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit

Crash while destroying RemoteVideoFrameObjectHeap
https://bugs.webkit.org/show_bug.cgi?id=236765
<rdar://89003650>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Antti Koivisto.

Add virtual destructor to ThreadSafeObjectHeap. (ThreadSafe)RefCounted<T> deletes
the object through the T pointer. In this case, T is ThreadSafeObjectHeap, but
the underlying type is RemoteVideoFrameObjectHeap. This causes delete through non-virtual
pointer and skips ~ThreadSafeObjectHeap().

No new tests, tested by existing tests under ASAN.

Shared/ThreadSafeObjectHeap.h:

5:13 AM Changeset in webkit [290011] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/ANGLE

REGRESSION (iOS 15.4b3): Catastrophic (20x) performance regression in texImage2D from mp4 video
https://bugs.webkit.org/show_bug.cgi?id=236699

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Darin Adler.

Disable the validation for IOSurface pixel formats.
We might pass non-public formats that do not have sensible IOSurfaceGetBytesPerElementOfPlane
to verify with this logic.

Will add test in bug 236759.

Previous bugs of the same:
EAGL:
Textures Fail to Render in WebGL from HLS Stream on iPhone 12 [iOS 14.2]
bug 218637, r273582, 234632@main
CGL:
REGRESSION(Safari 15, BigSur): Poor video texture upload performance with MacBook M1, ANGLE OpenGL backend
bug 232235, r286960, 245183@main

src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:

(rx::IOSurfaceSurfaceMtl::ValidateAttributes):

4:53 AM Changeset in webkit [290010] by graouts@webkit.org

3 edits
2 adds in trunk

LayoutTests/imported/w3c:
SVG SMIL restart="never" does not behave correctly
https://bugs.webkit.org/show_bug.cgi?id=236491

Reviewed by Antti Koivisto.

Add a new test that checks whether restart="never" is respected when
begin="click" is set on an SVG <animate> element.

web-platform-tests/svg/animations/restart-never-and-begin-click-expected.txt: Added.
web-platform-tests/svg/animations/restart-never-and-begin-click.html: Added.

Source/WebCore:
[LBSE] Apply SVG specific changes to RenderLayer painting
https://bugs.webkit.org/show_bug.cgi?id=236191

Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2022-02-17
Reviewed by Rob Buis.

This patch summarizes three small SVG specific changes regarding painting, not justifying
more atomic patches, since it's the same context of changes: painting + SVG layer.

SVG container repainting

Layers associated with SVG container elements (<g> / <defs> (!)) should never trigger repaints,
unless they are filtered. Adapt RenderLayer::shouldRepaintAfterLayout() to enforce this.

SVG viewport clipping

Assure that RenderSVGRoot viewport clipping is applied _before_ the SVG viewBox transformation
is applied (soon to be handled by RenderLayer for SVG).

SVG clip-path handling

Add a stub implementation of RenderLayer::computeClipPath(). There are more important parts
to upstream, before adding clipping support for SVG - however this stub serves as reminder
for upcoming patches -- this strategy works well so far.

Covered by existing tests, no change in behaviour.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldRepaintAfterLayout const):
(WebCore::RenderLayer::paintLayerWithEffects):
(WebCore::RenderLayer::computeClipPath const):

3:18 AM Changeset in webkit [290009] by timothy_horton@apple.com

8 edits in trunk/Source/WebKit

Add some more debug triggers for WKHoverPlatter
https://bugs.webkit.org/show_bug.cgi?id=236761

Reviewed by Darin Adler.

UIProcess/API/ios/WKWebViewIOS.mm:

(-[WKWebView _allowsDoubleTapGestures]):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _singleTapIdentified:]):
(-[WKContentView _singleTapRecognized:]):
(-[WKContentView _doubleTapRecognized:]):
Make it possible to use single tap as a two-step tap with WKHoverPlatter.
Make it possible to use double tap as an invocation gesture for WKHoverPlatter.

UIProcess/ios/WKHoverPlatter.h:
UIProcess/ios/WKHoverPlatter.mm:

(-[WKHoverPlatter initWithView:delegate:]):
Use WKHoverPlatterParameters.enabled instead of duplicating the set of enablement bits here.

(-[WKHoverPlatter isVisible]):
(-[WKHoverPlatter didReceiveMouseEvent:]):
(-[WKHoverPlatter didLongPressAtPoint:]):
(-[WKHoverPlatter didSingleTapAtPoint:]):
(-[WKHoverPlatter didDoubleTapAtPoint:]):
(-[WKHoverPlatter platterBoundingRect]):
(-[WKHoverPlatter linkSearchRect]):
(-[WKHoverPlatter adjustedPointForPoint:]):
(-[WKHoverPlatter hoverPoint]): Deleted.

UIProcess/ios/WKHoverPlatterParameters.h:
UIProcess/ios/WKHoverPlatterParameters.mm:

(-[WKHoverPlatterParameters setDefaultValues]):
Read prototyping default ... defaults ... from NSUserDefaults.

(-[WKHoverPlatterParameters enabled]):
(+[WKHoverPlatterParameters settingsControllerModule]):

UIProcess/ios/WKMouseGestureRecognizer.mm:

(-[WKMouseGestureRecognizer _shouldReceiveTouch:forEvent:recognizerView:]):
Only accept touch-phase touches from UITouchTypeIndirectPointer.
Otherwise synthetic direct touches continue through WKMouseGestureRecognizer
*and* trigger other gestures. This is a follow-up from r289785 that became more
obvious while writing this patch (and is a strict dependency of the other changes here).

3:15 AM Changeset in webkit [290008] by Nikolas Zimmermann

2 edits in trunk/Source/WebCore

[LBSE] Apply SVG specific changes to RenderLayer painting
https://bugs.webkit.org/show_bug.cgi?id=236191

Reviewed by Rob Buis.

This patch summarizes three small SVG specific changes regarding painting, not justifying
more atomic patches, since it's the same context of changes: painting + SVG layer.

SVG container repainting

Layers associated with SVG container elements (<g> / <defs> (!)) should never trigger repaints,
unless they are filtered. Adapt RenderLayer::shouldRepaintAfterLayout() to enforce this.

SVG viewport clipping

Assure that RenderSVGRoot viewport clipping is applied _before_ the SVG viewBox transformation
is applied (soon to be handled by RenderLayer for SVG).

SVG clip-path handling

Covered by existing tests, no change in behaviour.

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldRepaintAfterLayout const):
(WebCore::RenderLayer::paintLayerWithEffects):
(WebCore::RenderLayer::computeClipPath const):

1:53 AM Changeset in webkit [290007] by commit-queue@webkit.org

10 edits in trunk

Copy track sizes from parent grid into subgrid
https://bugs.webkit.org/show_bug.cgi?id=236336

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-17
Reviewed by Dean Jackson.

Source/WebCore:

Copies track sizes from the parent RenderGrid's track sizing algorithm for axes
that are subgridded, rather than doing its own sizing.
Accounts for differences between the subgrid's grid-gap and the parent's grid gap,
as well as space occupied by the subgrid element's margin/border/padding.

Existing test expectations updated.

rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithm::run):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::gridGap const):
(WebCore::RenderGrid::populateGridPositionsForDirection):

rendering/RenderGrid.h:

LayoutTests:

Existing test expectations updated.

TestExpectations:

1:49 AM Changeset in webkit [290006] by Angelos Oikonomopoulos

2 edits in trunk/JSTests

[JSC] Unskip test on mips
https://bugs.webkit.org/show_bug.cgi?id=236645

Unreviewed gardening.

Can't reproduce this locally after 20 iterations.

stress/sampling-profiler-richards.js:

1:30 AM WebKitEnablingFlatpakClangd edited by Martin Robinson

(diff)

1:25 AM Changeset in webkit [290005] by Jean-Yves Avenard

18 edits in trunk/Source

CrashTracer: com.apple.WebKit.WebContent at JavaScriptCore: bmalloc_allocate_impl_impl_slow
https://bugs.webkit.org/show_bug.cgi?id=236695
rdar://87596724

Reviewed by Jer Noble.

Source/WebCore:

When a new FragmentedSharedBuffer is received from the network process, it is proactively coalesced
into a SharedBuffer during each call to CachedResource::updateBuffer(). This causes a large number
of re-allocations and copies; essentially re-allocating each time the resource's buffer receives
one more chunk of data.
Instead we only flatten the data buffer once all data have been received.

Running speedtest.net with a gigabit link, we see a reduction of peak
memory use in the content process by about 40% (from 740MB to under 440MB of
physical memory, 1.7GB of memory allocation vs 535MB)

Covered by existing tests.

editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard):

editing/mac/EditorMac.mm:

(WebCore::Editor::writeImageToPasteboard):

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didFinishLoading):

loader/cache/CachedApplicationManifest.cpp:

(WebCore::CachedApplicationManifest::finishLoading):

loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::finishLoading):

loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::updateImageData):

loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::calculateIncrementalDataChunk const):
(WebCore::CachedRawResource::updateBuffer):
(WebCore::CachedRawResource::finishLoading):

loader/cache/CachedRawResource.h:
loader/cache/CachedResource.h:

(WebCore::CachedResource::resourceBuffer const):

loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):

loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::finishLoading):

Source/WebKit:

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::finishedLoading): Fly-by fix, the
IPC::DataReference would reference a SharedBuffer going
out of scope before it was sent over IPC.

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm:

(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):

1:11 AM Changeset in webkit [290004] by commit-queue@webkit.org

12 edits in trunk/Source/WebKit

RemoteVideoFrameProxy should use RemoteVideoFrameObjectHeapProxy to get the pixel buffer representation
https://bugs.webkit.org/show_bug.cgi?id=236704

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2022-02-17
Reviewed by Antti Koivisto.

Currently RemoteVideoFrameProxy uses RemoteVideoFrameObjectHeapProxy to transfer the pixel buffer
from GPU process to Web process in scenarios where the pixel buffer is used in Web process.

Previously RemoteVideoFrameProxy client would have to provide a thread-safe function that
should call RemoteVideoFrameObjectHeapProxy::getPixelBuffer().
Current clients do not provide a thread-safe function.

Instead, RemoteVideoFrameProxy should provide just the RemoteVideoFrameObjectHeapProxy reference,
since this is the only way to get the pixel buffer anyway. This simplifies the call sites, makes
the implementation more correct and avoids the use of ifdefs.

Make the code consistent with ifdefs. This is platform-independent code, so remove COCOA ifdefs.
All platforms that transfer pixels would need to have RemoteVideoFrameObjectHeapProxy.
This is media stream specific code, so add MEDIA_STREAM ifdefs.

To be consistent with existing GPUP side code, do not use "remote" prefix on the
variable names. E.g. use "videoFrameObjectHeapProxy" to refer to the proxy. The remote part
is redundant, as this is implied.

Clean up related RemoteVideoFrameProxy::pixelBuffer() function to not store unneeded semaphores
as instance variables or use duplicate helper functions.

No new tests, a refactor.

GPUProcess/media/RemoteMediaPlayerManagerProxy.cpp:

(WebKit::RemoteMediaPlayerManagerProxy::createMediaPlayer):

WebProcess/GPU/GPUProcessConnection.cpp:

(WebKit::GPUProcessConnection::videoFrameObjectHeapProxy):

WebProcess/GPU/GPUProcessConnection.h:
WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.cpp:

(WebKit::RemoteGraphicsContextGLProxy::paintCompositedResultsToMediaSample):

WebProcess/GPU/media/RemoteVideoFrameProxy.cpp:

(WebKit::RemoteVideoFrameProxy::create):
(WebKit::RemoteVideoFrameProxy::RemoteVideoFrameProxy):
(WebKit::RemoteVideoFrameProxy::pixelBuffer const):

WebProcess/GPU/media/RemoteVideoFrameProxy.h:
WebProcess/GPU/webrtc/LibWebRTCCodecs.cpp:

(WebKit::LibWebRTCCodecs::ensureGPUProcessConnectionOnMainThreadWithLock):
(WebKit::LibWebRTCCodecs::completedDecoding):

WebProcess/GPU/webrtc/RemoteVideoFrameObjectHeapProxy.h:

(WebKit::RemoteVideoFrameObjectHeapProxy::RemoteVideoFrameObjectHeapProxy):

WebProcess/cocoa/RemoteCaptureSampleManager.cpp:

(WebKit::RemoteCaptureSampleManager::setVideoFrameObjectHeapProxy):
(WebKit::RemoteCaptureSampleManager::videoSampleAvailable):

WebProcess/cocoa/RemoteCaptureSampleManager.h:
WebProcess/cocoa/UserMediaCaptureManager.cpp:

(WebKit::UserMediaCaptureManager::VideoFactory::createVideoCaptureSource):

1:05 AM WebKitEnablingFlatpakClangd created by Martin Robinson

12:57 AM WebKitFlatpakSDK edited by Martin Robinson

(diff)

12:14 AM Changeset in webkit [290003] by graouts@webkit.org

13 edits
1 copy
1 add in trunk

Use the animation frame rate during animation resolution and scheduling
https://bugs.webkit.org/show_bug.cgi?id=234202
rdar://85983678

Reviewed by Simon Fraser.

Source/WebCore:

We've previously added properties to DocumentTimeline to expose the maximum frame rate supported
by the display (bug 234161) and to Animation to let animations specify the frame rate at which
they would like to be updated (bug 234174).

In this patch we add support for accounting for the frame rate set on animations to ensure they
are updated at a cadence close to the one requested, with the following provisions:

we do our best to match the frame rate provided by the animation but account for the display's refresh rate to only ever update animations when the display is being refreshed,
we update all animations sharing the same frame rate in the same updates,
we schedule updates sparingly accounting for the frame rate of animation such that a page only containing animations that are running at, for instance, 15fps only result in calls to DocumentTimelinesController::updateAnimationsAndSendEvents() at 15fps,
other factors may impact the animation frame rate, such as low power mode.

There is no test for this code currently. It is not possible to test for the actual
rate at which animations are updated in a testing environment, since there are too
many variables to ensure consistent results. However, future patches will look into
adding internals code such that tests may inspect the update cadence set on the timeline
and frame rates at which animations are optimistically scheduled to update.

The FrameRateAligner class provides a supporting object for DocumentTimelinesController
which contains the data related to the frame rates currently in use by all animations in
the document. This class will be updated in future patches to better handle alignment of
animations added dynamically with previously unused frame rates.

Note that all of those changes to scheduling only affects page rendering updates triggered
by animations. Page rendering updates continue to be scheduled by calls to requestAnimationFrame()
independently from the frame rate specified on animations.

Headers.cmake:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::animationInterval const):
(WebCore::DocumentTimeline::scheduleNextTick):

animation/DocumentTimelinesController.cpp:

(WebCore::DocumentTimelinesController::DocumentTimelinesController):
(WebCore::DocumentTimelinesController::updateAnimationsAndSendEvents):
(WebCore::DocumentTimelinesController::timeUntilNextTickForAnimationsWithFrameRate const):

animation/DocumentTimelinesController.h:

(WebCore::DocumentTimelinesController::maximumAnimationFrameRate const):

animation/FrameRateAligner.cpp: Added.

(WebCore::idealTimeForNextUpdate):
(WebCore::FrameRateAligner::beginUpdate):
(WebCore::FrameRateAligner::updateFrameRate):
(WebCore::FrameRateAligner::timeUntilNextUpdateForFrameRate const):
(WebCore::FrameRateAligner::maximumFrameRate const):

animation/FrameRateAligner.h: Copied from Source/WebCore/animation/DocumentTimelinesController.h.
animation/WebAnimation.cpp:

(WebCore::WebAnimation::setEffectiveFrameRate):

page/Page.cpp:

(WebCore::Page::timelineControllerMaximumAnimationFrameRateDidChange):
(WebCore::Page::preferredRenderingUpdateFramesPerSecond const):

page/Page.h:

LayoutTests:

Update this test to not rely on hard values but rather check that throttling
has the expected effect of doubling the interval between frames.

fast/animation/css-animation-throttling-lowPowerMode-expected.txt:
fast/animation/css-animation-throttling-lowPowerMode.html:

12:08 AM Changeset in webkit [290002] by commit-queue@webkit.org

12 edits in trunk

Unreviewed, reverting r289949.
https://bugs.webkit.org/show_bug.cgi?id=236757

Breaks WPE builds with -DUSE_ANGLE_WEBGL=ON

Reverted changeset:

"[CMake] Cannot find OpenGL when system provides opengl.pc
instead of gl.pc"
https://bugs.webkit.org/show_bug.cgi?id=236592
https://commits.webkit.org/r289949

12:00 AM Changeset in webkit [290001] by timothy@apple.com

8 edits in trunk/Source

Add -[WKWebProcessPlugInFrame lookUpFrameFromJSValue:].
https://bugs.webkit.org/show_bug.cgi?id=236714
rdar://problem/89030846

Reviewed by Chris Dumez.

Source/WebCore:

page/Frame.cpp:

(WebCore::Frame::contentFrameFromWindowOrFrameElement): Added.

page/Frame.h:

Source/WebKit:

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.mm:

(+[WKWebProcessPlugInFrame lookUpContentFrameFromWindowOrFrameElement:]): Added.

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFramePrivate.h:
WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::contentFrameForWindowOrFrameElement): Added.

WebProcess/WebPage/WebFrame.h:

Feb 16, 2022:

11:42 PM Changeset in webkit [290000] by ysuzuki@apple.com

18 edits
2 deletes in trunk/Source/bmalloc

[libpas] Use segmented vector for TLC layout list
https://bugs.webkit.org/show_bug.cgi?id=236662

Reviewed by Saam Barati.

We add segmented vector for pas_thread_local_cache_layout_node iteration instead of using
linked-list of that to accelerate iteration performance. It does not affect on Speedometer2,
JetStream2, PLT5 etc., but we do this iteration frequently in scavenger thread, and reducing
time of this makes it efficient. While speeding up scavenger does not matter for throughput
of non scavenger threads since libpas works well without taking a lock in most times which
is blocked by scavenger, making scavenger faster is good for energy efficiency.

Use segmented vector for (concurrently read) pas_thread_local_cache_layout_node list. We still keep nice for-loop abstraction for list of pas_thread_local_cache_layout_node.
Remove pas_local_view_cache_node since we no longer need it. It was introduced just to make it linked-list node for pas_thread_local_cache_layout_node. But now, segmented vector is holding it separately.
Move pas_segregated_size_directory_data's allocator_index to pas_segregated_size_directory. Because of (1) change, we can make pas_segregated_size_directory linked-list-node, which saves 4 bytes. So we can move pas_segregated_size_directory_data's allocator_index to pas_segregated_size_directory since it is heavily accessed from the scavenger.

CMakeLists.txt:
bmalloc.xcodeproj/project.pbxproj:
libpas/libpas.xcodeproj/project.pbxproj:
libpas/src/libpas/pas_designated_intrinsic_heap.c:

(set_up_range):

libpas/src/libpas/pas_enumerate_segregated_heaps.c:

(pas_enumerate_segregated_heaps):

libpas/src/libpas/pas_local_view_cache_node.c: Removed.
libpas/src/libpas/pas_local_view_cache_node.h: Removed.
libpas/src/libpas/pas_redundant_local_allocator_node.c:

(pas_redundant_local_allocator_node_create):

libpas/src/libpas/pas_redundant_local_allocator_node.h:
libpas/src/libpas/pas_root.c:

(pas_root_construct):

libpas/src/libpas/pas_root.h:
libpas/src/libpas/pas_segregated_heap.c:

(recompute_size_lookup):
(pas_segregated_heap_ensure_allocator_index):

libpas/src/libpas/pas_segregated_size_directory.c:

(pas_segregated_size_directory_create):
(pas_segregated_size_directory_ensure_data):
(pas_segregated_size_directory_create_tlc_allocator):
(pas_segregated_size_directory_get_allocator_from_tlc):

libpas/src/libpas/pas_segregated_size_directory.h:

(pas_segregated_size_directory_has_tlc_allocator):
(pas_segregated_size_directory_get_tlc_allocator_index):

libpas/src/libpas/pas_thread_local_cache.c:

(decommit_allocator_range):
(pas_thread_local_cache_for_all):

libpas/src/libpas/pas_thread_local_cache_layout.c:

(pas_thread_local_cache_layout_add_node):
(pas_thread_local_cache_layout_add_view_cache):
(pas_thread_local_cache_layout_get_last_node):

libpas/src/libpas/pas_thread_local_cache_layout.h:

(pas_thread_local_cache_layout_segment_get_node):
(pas_thread_local_cache_layout_segment_next_node):

libpas/src/libpas/pas_thread_local_cache_layout_node.c:

(pas_thread_local_cache_layout_node_get_directory):
(allocator_index_ptr):
(next_ptr): Deleted.
(pas_thread_local_cache_layout_node_get_next): Deleted.
(pas_thread_local_cache_layout_node_set_next): Deleted.

libpas/src/libpas/pas_thread_local_cache_layout_node.h:

(pas_wrap_local_view_cache_node):
(pas_unwrap_local_view_cache_node):

11:30 PM Changeset in webkit [289999] by timothy_horton@apple.com

7 edits in trunk

Revert r275772: inflated FloatSize memory layout unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=236743

Reviewed by Simon Fraser.

Source/WebCore:

platform/graphics/FloatSize.h:
rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeReplacedLogicalWidth const):
(WebCore::RenderReplaced::computeReplacedLogicalHeight const):

rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation const):

LayoutTests:

TestExpectations:

10:24 PM Changeset in webkit [289998] by commit-queue@webkit.org

12 edits in trunk

Lookup line names for sub grids using line names from ancestor grids
https://bugs.webkit.org/show_bug.cgi?id=236287

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-16
Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/css/css-grid/subgrid/grid-subgridded-axis-auto-repeater-crash-001-expected.txt:
web-platform-tests/css/css-grid/subgrid/line-names-005-expected.html:
web-platform-tests/css/css-grid/subgrid/line-names-005.html:

Make line-names-005.html slightly harder by having the multiple definitions of the 'a' grid area be different at both edges.

Source/WebCore:

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::populateExplicitGridAndOrderIterator const):

rendering/style/GridArea.h:

(WebCore::GridSpan::clamp):

rendering/style/GridPositionsResolver.cpp:

(WebCore::explicitGridSizeForSide):
(WebCore::transposedSide):
(WebCore::clampedImplicitLineForArea):
(WebCore::NamedLineCollectionBase::NamedLineCollectionBase):
(WebCore::NamedLineCollectionBase::ensureLocalStorage):
(WebCore::NamedLineCollectionBase::contains const):
(WebCore::NamedLineCollection::NamedLineCollection):
(WebCore::NamedLineCollection::hasExplicitNamedLines const):
(WebCore::NamedLineCollection::hasNamedLines const):
(WebCore::NamedLineCollection::lastLine const):
(WebCore::NamedLineCollection::contains const):
(WebCore::NamedLineCollection::firstExplicitPosition const):
(WebCore::NamedLineCollection::firstPosition const):
(WebCore::adjustGridPositionsFromStyle):
(WebCore::lookAheadForNamedGridLine):
(WebCore::lookBackForNamedGridLine):
(WebCore::resolveNamedGridLinePositionFromStyle):
(WebCore::definiteGridSpanWithNamedLineSpanAgainstOpposite):
(WebCore::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveGridPositionFromStyle):

Splits NamedLineCollection into two classes, where the base class only handles
a single grid, and the subclass handles inheriting lines from ancestor grids.
Loops over ancestor grids, looking for named lines that are shared with the initial
grid, and if found, adds them (using the local line number) to a local copy of the line
names array.

Also handles the cases where a named grid area spans outside of the subgrid area, by
clamping the area to the explicit grid (since subgrid can't generate implicit grid lines),
and then generating new implicit grid lines. These lines are added to the same local line
name array as is used for inherited ancestor lines. This clamping and regeneration of implicit
lines works for both areas defined on the subgrid, as well as on ancestors.

rendering/style/GridPositionsResolver.h:
style/StyleBuilderCustom.h:

(WebCore::Style::BuilderCustom::applyValueGridTemplateColumns):
(WebCore::Style::BuilderCustom::applyValueGridTemplateRows):

Removes these calls to add the implicit lines to the normal line lists, since
they're already in the implicit line lists and having them in both stops us from
being able to regenerate them for subgrids.

LayoutTests:

Update expectations for newly passing tests.

TestExpectations:

10:05 PM Changeset in webkit [289997] by jh718.park@samsung.com

13 edits in trunk

Change the canonical unit for time category from ms to s.
https://bugs.webkit.org/show_bug.cgi?id=236631

Reviewed by Darin Adler.

According to the spec, https://drafts.csswg.org/css-values-4/#time,
the canonical unit for <time> is Seconds.

LayoutTests/imported/w3c:

web-platform-tests/css/css-values/minmax-time-serialize-expected.txt:

Source/WebCore:

css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):

css/CSSUnits.cpp:

(WebCore::canonicalUnitTypeForCategory):

css/calc/CSSCalcCategoryMapping.cpp:

(WebCore::canonicalUnitTypeForCalculationCategory):

LayoutTests:

fast/css/calc-with-angle-time-frequency-expected.txt:
fast/css/calc-with-angle-time-frequency.html:
fast/css/getFloatValueForUnit-expected.txt:
fast/css/getFloatValueForUnit.html:
fast/css/transition-delay-calculated-value-expected.txt:
fast/css/transition-delay-calculated-value.html:

8:25 PM Changeset in webkit [289996] by sihui_liu@apple.com

5 edits in trunk

Use FileSystem::readEntireFile everywhere
https://bugs.webkit.org/show_bug.cgi?id=233818
<rdar://problem/86324895>

Reviewed by Chris Dumez.

Source/WebKit:

NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::readSizeFile):

Shared/PersistencyUtils.cpp:

(WebKit::createForFile):

Tools:

TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::readContentsOfFile):

8:23 PM Changeset in webkit [289995] by Alan Bujtas

3 edits
2 adds in trunk

REGRESSION(r285885) Unable to exit Trip Details in Amtrak app
https://bugs.webkit.org/show_bug.cgi?id=236732
<rdar://87462825>

Reviewed by Simon Fraser.

Source/WebCore:

Starting from r285885 an (effective)”overflow: clip” value is set on any block box with “contain: paint”.
It is supposed to ensure we don’t paint outside of the box’s border box (note that "contain: paint", as the name implies, should only affect painting).

However this effective value trickles in to layout affecting certain layout constraints.
In case of flex, it makes the flex layout think that the box is really a clipped box and it starts flexing it accordingly producing incorrect size.
What it means is that the minimum preferred size ends up being 0px because now with "let's clip all the overflow content"
0px is indeed the smallest size a box could take that does not produce overflow (while with the initial, “overflow: visible” value,
its minimum width would likely be > 0px -provided it has some content. Also note that setting “overflow: clip” on the box in the markup
(so it becomes an explicit clip value and not just an “effective” implicit clip through “contain: paint”) produces
the exact same rendering meaning that this effective property value does affect layout).

This is a partial revert of r285885 (focusing on where the flex algorithm consults with the flex items' overflow values).

Test: fast/flexbox/incorrect-min-size-with-paint-contain.html

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisOverflowForChild const):
(WebCore::RenderFlexibleBox::crossAxisOverflowForChild const):

LayoutTests:

fast/flexbox/incorrect-min-size-with-paint-contain-expected.html: Added.
fast/flexbox/incorrect-min-size-with-paint-contain.html: Added.

7:46 PM Changeset in webkit [289994] by pvollan@apple.com

25 edits
4 adds in trunk/Source

Send icons to the WebContent process for rendering of the attachment element
https://bugs.webkit.org/show_bug.cgi?id=236386

Reviewed by Darin Adler.

In order to avoid connecting to the Icon Services daemon in the WebContent process, we should send the icons for the attachment
Source/WebCore:

element to the WebContent process from the UI process. When the icon is being painted in the WebContent process, it is getting
the icon from the HTML attachment element, instead of creating it by connecting to Icon Services. The icon in the attachment
element is received from the UI process. A new AttachmentElementClient class is created to forward the messages to the UI
process.

WebCore.xcodeproj/project.pbxproj:
html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::updateIcon):
(WebCore::HTMLAttachmentElement::icon const):
(WebCore::HTMLAttachmentElement::iconSize const):

html/HTMLAttachmentElement.h:
loader/EmptyClients.cpp:

(WebCore::pageConfigurationWithEmptyClients):

page/AttachmentElementClient.h: Added.

(WebCore::AttachmentElementClient::~AttachmentElementClient):

page/EmptyAttachmentElementClient.h: Added.
page/Page.cpp:

(WebCore::m_attachmentElementClient):
(WebCore::m_modelPlayerProvider): Deleted.

page/Page.h:

(WebCore::Page::attachmentElementClient):

page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

page/PageConfiguration.h:
platform/graphics/Icon.h:

(WebCore::Icon::nsImage const):

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::iconForAttachment):
(WebCore::RenderAttachmentInfo::RenderAttachmentInfo):
(WebCore::paintAttachmentIcon):
(WebCore::iconForAttachment): Deleted.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::iconForAttachment):
(WebCore::paintAttachmentIcon):
(WebCore::iconForAttachment): Deleted.

Source/WebKit:

element to the WebContent process from the UI process. The icon will be sent to the WebContent process when the attachment
attributes are updated, or the WebContent process has requested the icon. The new client class WebAttachmentElementClient is
responsible for requesting icons from the UI process.

Sources.txt:
UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::convertPlatformImageToBitmap):
(WebKit::WebPageProxy::iconForAttachment):
(WebKit::WebPageProxy::requestThumbnailWithOperation):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestAttachmentIcon):
(WebKit::WebPageProxy::updateAttachmentAttributes):
(WebKit::WebPageProxy::updateAttachmentThumbnail):
(WebKit::WebPageProxy::updateAttachmentIcon): Deleted.

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebKit.xcodeproj/project.pbxproj:
WebProcess/WebCoreSupport/WebAttachmentElementClient.cpp: Added.

(WebKit::WebAttachmentElementClient::WebAttachmentElementClient):
(WebKit::WebAttachmentElementClient::requestAttachmentIcon):

WebProcess/WebCoreSupport/WebAttachmentElementClient.h: Added.
WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::didInsertAttachmentWithIdentifier):

WebProcess/WebPage/WebPage.cpp:

(WebKit::m_appHighlightsVisible):
(WebKit::WebPage::updateAttachmentThumbnail):
(WebKit::WebPage::updateAttachmentIcon):
(WebKit::WebPage::requestAttachmentIcon):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

7:40 PM Changeset in webkit [289993] by commit-queue@webkit.org

7 edits
2 adds in trunk

Implement getComputedStyle for subgrids
https://bugs.webkit.org/show_bug.cgi?id=236148

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-16
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Adds OrderedNamedLinesCollectorInSubgridLayout to iterate the subgrid names list, stopping
at the number of actual tracks in the grid.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::OrderedNamedLinesCollectorInSubgridLayout::OrderedNamedLinesCollectorInSubgridLayout):
(WebCore::OrderedNamedLinesCollectorInGridLayout::collectLineNamesForIndex const):
(WebCore::OrderedNamedLinesCollectorInSubgridLayout::collectLineNamesForIndex const):
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::populateSubgridTrackList):
(WebCore::valueForGridTrackList):

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeAutoRepeatTracksCount const):

rendering/RenderGrid.h:
rendering/style/GridPositionsResolver.cpp:

(WebCore::NamedLineCollection::contains const):

style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::createGridTrackList):

LayoutTests:

Mark tests as no longer crashing.

TestExpectations:

7:35 PM Changeset in webkit [289992] by Fujii Hironori

5 edits in trunk/Source/WebCore

Use OptionSet for TextureMapperShaderProgram::Options
https://bugs.webkit.org/show_bug.cgi?id=236689

Reviewed by Don Olmstead.

platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:

(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):

platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:
platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::getShaderProgram):
Use unsigned for the HashMap key since OptionSet can't be used as a key.
(WebCore::optionsForFilterType):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTexturePlanarYUV):
(WebCore::TextureMapperGL::drawTextureSemiPlanarYUV):
(WebCore::TextureMapperGL::drawTexturePackedYUV):
(WebCore::TextureMapperGL::drawSolidColor):

platform/graphics/texmap/TextureMapperShaderProgram.h:

7:21 PM Changeset in webkit [289991] by Cameron McCormack

7 edits
1 move
1 add
1 delete in trunk/Source/WebCore

Cache an entire attribute QualifiedName when parsing HTML, not just its local name AtomString
https://bugs.webkit.org/show_bug.cgi?id=236570
<rdar://problem/88876545>

Reviewed by Darin Adler.

Bug 229907 added HTMLAtomStringCache, which uses a fast to compute hash
that works well to cache HTML tag names, attribute names, and attribute
values. When AtomHTMLToken initializes its list of Attributes, it uses
HTMLAtomStringCache to look up or create an AtomString for the
attribute's local name, and then creates a QualifiedName to wrap it.
QualifiedName construction involves looking up QualifiedNameCache, which
is a thread-specific cache of QualifiedNameImpl objects. If we make
HTMLAtomStringCache responsible for caching an attribute's QualifiedName
instead of just its local name AtomString, we can avoid the work of
looking up the QualifiedNameCache.

To reflect its broader responsibilities, HTMLAtomStringCache is renamed
to HTMLNameCache.

Doing this results in a 0.2-0.3% improvement on Speedometer 2, and a
0.3-0.4% improvement on PLT5 (with the lower end of those ranges being
on Apple Silicon and the higher end on Intel).

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedName):

html/parser/AtomHTMLToken.h:

(WebCore::AtomHTMLToken::initializeAttributes):
(WebCore::AtomHTMLToken::AtomHTMLToken):

html/parser/HTMLAtomStringCache.h: Removed.

(WebCore::HTMLAtomStringCache::makeTagOrAttributeName): Deleted.
(WebCore::HTMLAtomStringCache::makeAttributeValue): Deleted.
(WebCore::HTMLAtomStringCache::clear): Deleted.
(WebCore::HTMLAtomStringCache::make): Deleted.
(WebCore::HTMLAtomStringCache::cacheSlot): Deleted.

html/parser/HTMLNameCache.cpp: Renamed from Source/WebCore/html/parser/HTMLAtomStringCache.cpp.

(WebCore::HTMLNameCache::atomStringCache):
(WebCore::HTMLNameCache::qualifiedNameCache):

html/parser/HTMLNameCache.h: Added.

(WebCore::HTMLNameCache::makeTagName):
(WebCore::HTMLNameCache::makeAttributeQualifiedName):
(WebCore::HTMLNameCache::makeAttributeValue):
(WebCore::HTMLNameCache::clear):
(WebCore::HTMLNameCache::makeAtomString):
(WebCore::HTMLNameCache::makeQualifiedName):
(WebCore::HTMLNameCache::slotIndex):
(WebCore::HTMLNameCache::atomStringCacheSlot):
(WebCore::HTMLNameCache::qualifiedNameCacheSlot):

page/MemoryRelease.cpp:

(WebCore::releaseNoncriticalMemory):

page/cocoa/MemoryReleaseCocoa.mm:

(WebCore::jettisonExpensiveObjectsOnTopLevelNavigation):

7:19 PM Changeset in webkit [289990] by jonlee@apple.com

47 edits in trunk/LayoutTests

Add fuzzy data for test failures seen on the iOS GPU Process bot
Unreviewed.

LayoutTests/imported/mozilla:

svg/blend-exclusion.svg:
svg/blend-overlay.svg:
svg/text-gradient-01.svg:

LayoutTests/imported/w3c:

web-platform-tests/css/css-backgrounds/background-rounded-image-clip.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-001.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-002.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-003.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-004.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-005.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-006.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-007.html:
web-platform-tests/css/css-masking/clip-path/clip-path-circle-008.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-001.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-002.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-003.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-004.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-005.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-006.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-007.html:
web-platform-tests/css/css-masking/clip-path/clip-path-ellipse-008.html:
web-platform-tests/css/css-transforms/css-skew-002.html:
web-platform-tests/css/css-transforms/transforms-skewY.html:

LayoutTests:

compositing/backgrounds/fixed-backgrounds.html:
compositing/images/positioned-image-content-rect.html:
css3/background/background-repeat-space-border.html:
css3/background/background-repeat-space-content.html:
css3/background/background-repeat-space-padding.html:
css3/masking/clip-path-ellipse.html:
css3/masking/clip-path-inset-corners.html:
css3/masking/clip-path-restore.html:
fast/backgrounds/gradient-background-shadow.html:
fast/filter-image/filter-image-blur.html:
fast/layers/overflow-scroll-transform-border-radius.html:
fast/masking/clip-path-inset-large-radii.html:
fast/overflow/line-clamp-with-text-shadow.html:
fast/text/decorations-vertical-underline.html:
fast/text/fitzpatrick-combination.html:
fast/text/simple-line-layout-text-position-with-stroke.html:
gpu-process/TestExpectations:
svg/clip-path/clip-opacity.html:
svg/clip-path/clip-path-objectboundingbox-003.svg:
svg/clip-path/svg-in-html.html:
svg/clip-path/webkit-clip-path-after.svg:
svg/clip-path/webkit-clip-path-before.svg:

6:19 PM Changeset in webkit [289989] by Megan Gardner

2 edits in trunk/Source/WebCore

REGRESSION: TestWebKitAPI.WKWebViewDisableSelection.DoubleClickDoesNotSelectWhenTextInteractionsAreDisabled is failing
https://bugs.webkit.org/show_bug.cgi?id=236718

Reviewed by Wenson Hsieh.

A check got missed when refactoring code for 289818.

page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEventDoubleClick):

5:59 PM Changeset in webkit [289988] by Jonathan Bedard

2 edits in trunk/Tools

Broken pipes during iOS simulator testing
https://bugs.webkit.org/show_bug.cgi?id=230513
<rdar://problem/83325409>

Reviewed by Dewei Zhu.

Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.Popen.poll): Close stdin, stdout and stderr when process ends.

5:31 PM Changeset in webkit [289987] by Jonathan Bedard

4 edits in trunk/Tools

[EWS] Rename 'patch' to 'change' in transfer-archive-to-s3
https://bugs.webkit.org/show_bug.cgi?id=236706
<rdar://problem/89025868>

Reviewed by Aakash Jain.

Tools/CISupport/Shared/transfer-archive-to-s3: Change --patch_id argument

to --change-id.

Tools/CISupport/ews-build/steps.py:

(TransferToS3): Invoke transfer-archive-to-s3 with --change-id.

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/247372@main

5:31 PM Changeset in webkit [289986] by commit-queue@webkit.org

13 edits in trunk

Inherit track count from parent grid for subgridded axes and clamp item placement to that explicit grid.
https://bugs.webkit.org/show_bug.cgi?id=236122

Patch by Matt Woodrow <Matt Woodrow> on 2022-02-16
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Test changes to match latest spec, submitted upstream as https://github.com/web-platform-tests/wpt/pull/32629

web-platform-tests/css/css-grid/subgrid/line-names-002-expected.html:
web-platform-tests/css/css-grid/subgrid/line-names-005-expected.html:

Source/WebCore:

Changes GridPositionsResolver::explicitGrid<>Count to return the number of tracks
spanned in the parent grid, for axes that are a subgrid.

Updates adjustGridPositionsForStyle to use the number of lines specified in the
subgrid property, for grid items that are also a subgrid and have an otherwise
indefinite span.

Adds clamping support to Grid so that we can prevent subgrids from ever adding
new implicit tracks.

rendering/Grid.cpp:

(WebCore::Grid::insert):
(WebCore::Grid::setClampingForSubgrid):
(WebCore::Grid::clampAndTranslateToImplicitGrid):
(WebCore::Grid::setNeedsItemsPlacement):

rendering/Grid.h:
rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeIntrinsicLogicalWidths const):
(WebCore::RenderGrid::placeItemsOnGrid const):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator const):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid const):
(WebCore::RenderGrid::isSubgrid const):
(WebCore::RenderGrid::isSubgridRows const):
(WebCore::RenderGrid::isSubgridColumns const):
(WebCore::RenderGrid::gridAreaBreadthForOutOfFlowChild):
(WebCore::RenderGrid::numTracks const):
(WebCore::transposedDirection):
(WebCore::RenderGrid::computeGridSpanForOutOfFlowChild const):
(WebCore::RenderGrid::gridSpanForOutOfFlowChild const):
(WebCore::RenderGrid::gridSpanForChild const):

rendering/RenderGrid.h:
rendering/style/GridArea.h:

(WebCore::GridSpan::integerSpan const):
(WebCore::GridSpan::translateTo):
(WebCore::GridSpan::clamp):

rendering/style/GridPositionsResolver.cpp:

(WebCore::isIndefiniteSpan):
(WebCore::adjustGridPositionsFromStyle):
(WebCore::GridPositionsResolver::explicitGridColumnCount):
(WebCore::GridPositionsResolver::explicitGridRowCount):
(WebCore::explicitGridSizeForSide):
(WebCore::resolveNamedGridLinePositionFromStyle):
(WebCore::resolveNamedGridLinePositionAgainstOppositePosition):
(WebCore::resolveGridPositionAgainstOppositePosition):
(WebCore::resolveGridPositionFromStyle):
(WebCore::GridPositionsResolver::resolveGridPositionsFromStyle):

rendering/style/GridPositionsResolver.h:

5:25 PM Changeset in webkit [289985] by Jonathan Bedard

4 edits in trunk/Tools

[git-webkit] Comment and close issue when landing PR (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=236715
<rdar://problem/89031529>

Unreviewed follow-up fix.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version instead of decrement.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:

(Land.main): Grab log of commit, which may contain revision, if there is one.

5:18 PM Changeset in webkit [289984] by Jonathan Bedard

3 edits in trunk/Tools

[EWS] Rename 'patch' to 'change' in layout-test steps
https://bugs.webkit.org/show_bug.cgi?id=236674
<rdar://problem/88992222>

Reviewed by Aakash Jain.

Tools/CISupport/ews-build/steps.py:

(RunWebKitTestsWithoutChange.setLayoutTestCommand):
(AnalyzeLayoutTestsResults.report_failure):
(AnalyzeLayoutTestsResults.retry_build):
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.commandComplete):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree): Renamed.
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresWithoutChangeRedTree.commandComplete):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree): Renamed.
(AnalyzeLayoutTestsResultsRedTree.report_infrastructure_issue_and_maybe_retry_build):
(AnalyzeLayoutTestsResultsRedTree.start):

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/247370@main

5:10 PM Changeset in webkit [289983] by Jonathan Bedard

5 edits in trunk/Tools

[git-webkit] Comment and close issue when landing PR
https://bugs.webkit.org/show_bug.cgi?id=236715
<rdar://problem/89031529>

Reviewed by Ryan Haddad.

When we land pull requests, we should make a comment on the associated issue
indicating where the code change is and close that issue.

Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Ditto.
Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/land.py:

(Land.main): Comment on and close issue associated with the final commit in
the landed series, shorten displayed hash to 12 characters.

Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/land_unittest.py:

(repository): Allow caller to specify issue URL in commit message, append git-svn
tag if in a git-svn repository.
(TestLand):
(TestLand.test_default):
(TestLand.test_canonicalize):
(TestLand.test_svn):
(TestLand.test_default_with_radar):
(TestLand.test_canonicalize_with_bugzilla):
(TestLand.test_svn_with_bugzilla):

Canonical link: https://commits.webkit.org/247369@main

4:40 PM Changeset in webkit [289982] by Diego Pino Garcia

2 edits in trunk/Tools

[GTK][WPE] Execute API test by name
https://bugs.webkit.org/show_bug.cgi?id=236623

Reviewed by Carlos Garcia Campos.

When running either run-gtk-tests or run-wpe-tests, let them take a test name and build
the path to the test.

glib/api_test_runner.py:

(TestRunner._get_tests):

4:11 PM Changeset in webkit [289981] by Said Abou-Hallawa

16 edits in trunk

[GPU Process] Enable drawing the SVGImage in the GPU Process
https://bugs.webkit.org/show_bug.cgi?id=227748
rdar://80582699

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

This sub-test was originally failing and this is why the bug
https://bugs.webkit.org/show_bug.cgi?id=231001 was filed.

After https://trac.webkit.org/changeset/279722/webkit, it got fixed because
SVGImage was rendered to a NativeImage and the NativeImage is rendered
to the destination GraphicsContext. GraphicsContext::drawNativeImage()
handles the image orientation properly.

Because this change will be reverted, the result of this test has to be
rebaselined with the failure message.

web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt:

Source/WebCore:

This patch reverts the revisions r279722, r284740 and r283531. So it will
enable drawing the SVGImage in GPU Process if GPU Process for "canvas" or
for "DOM rendering" is enabled

We fix the scratch ImageBuffer in SVGImage::nativeImage() to be accelerated
if acceleratedDrawingEnabled() is true. We also create a remote one if
GPUProcess for DOM rendering is enabled.

We also allow passing a ColorSpace to SVGImage::nativeImage() to control
the colorSpace of the resulted NativeImage. Because this function overrides
the base class method Image::nativeImage() we have to pass a ColorSpace
to BitmapImage also. A FIXME comment is added to BitmapImage::nativeImage()
to handle this argument in a future patch.

html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2DBase::fullCanvasCompositedDrawImage):

platform/graphics/BifurcatedGraphicsContext.cpp:

(WebCore::BifurcatedGraphicsContext::drawImageForCanvas): Deleted.

platform/graphics/BifurcatedGraphicsContext.h:
platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::nativeImage):

platform/graphics/BitmapImage.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImageForCanvas): Deleted.

platform/graphics/GraphicsContext.h:
platform/graphics/Image.cpp:

(WebCore::Image::drawForCanvas): Deleted.

platform/graphics/Image.h:

(WebCore::Image::nativeImage):
(WebCore::Image::draw):

svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawForContainer):
(WebCore::SVGImage::nativeImage):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::drawForCanvasForContainer): Deleted.
(WebCore::SVGImage::drawForContainerInternal): Deleted.
(WebCore::SVGImage::drawForCanvas): Deleted.
(WebCore::SVGImage::drawInternal): Deleted.
(WebCore::SVGImage::drawAsNativeImage): Deleted.

svg/graphics/SVGImage.h:
svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawForCanvas): Deleted.

svg/graphics/SVGImageForContainer.h:

4:10 PM Changeset in webkit [289980] by Jonathan Bedard

3 edits in trunk/Tools

[EWS] Rename 'patch' to 'change' in api-test steps
https://bugs.webkit.org/show_bug.cgi?id=236676
<rdar://problem/88993105>

Reviewed by Aakash Jain.

Tools/CISupport/ews-build/steps.py:

(ReRunAPITests.evaluateCommand): Renamed RunAPITestsWithoutPatch to RunAPITestsWithoutChange.
(RunAPITestsWithoutChange): Ditto.
(AnalyzeAPITestsResults.start): Ditto.
(AnalyzeAPITestsResults.analyzeResults): Ditto.
(RunAPITestsWithoutChange): Renamed from RunAPITestsWithoutPatch.
(RunAPITestsWithoutPatch): Renamed to RunAPITestsWithoutChange.

Tools/CISupport/ews-build/steps_unittest.py:

Canonical link: https://commits.webkit.org/247366@main

4:03 PM Changeset in webkit [289979] by Ryan Haddad

2 edits in trunk/Tools/CISupport/build-webkit-org

Set up a post-commit bot to test workspace builds
https://bugs.webkit.org/show_bug.cgi?id=236726

Reviewed by Jonathan Bedard.

CISupport/build-webkit-org/config.json:
CISupport/build-webkit-org/factories_unittest.py:

(TestExpectedBuildSteps):

Canonical link: https://commits.webkit.org/247365@main

3:49 PM Changeset in webkit [289978] by mmaxfield@apple.com

151 edits
7 copies
3 deletes in trunk/Source

[WebGPU] Update IDLs and stubs to latest version of the spec
https://bugs.webkit.org/show_bug.cgi?id=236639

Reviewed by Dean Jackson.

Source/WebCore:

This updates our WebGPU infrastructure to spec revision 626f8c05c8e67b54159e93ae7c3699a889f0b115. This
is just the plumbing that connects IDL -> WebCore C++ -> PAL virtual methods -> WebKit Web process ->
WebKit GPU process -> PAL virtual methods -> PAL WebGPU implementation -> WebGPU.framework. This also
updates the WebGPU.h shared header to revision 08ef57733503b8fb504e0681a8db650c88225947. This is just
plumbing - the actual implementation of this stuff is still just stubs in WebGPU.framework.

There have been a few various changes:

A viewFormats array has been added to GPUCanvasConfiguration and GPUTextureDescriptor
fillBuffer() has been renamed to clearBuffer()
Pipeline statistics queries have been deleted
A few refactorings to turn Vector<Foo> things into Vector<std::optional<Foo>>
flipY has been added to GPUImageCopyExternalImage
Load operations have been redesigned on both GPURenderPassColorAttachment and

GPURenderPassDepthStencilAttachment

endPass() has been renamed to end()
Shader compilation now takes a record<entry point name, GPUShaderModuleCompilationHint>

No new tests because the implementation is still just stubs.

CMakeLists.txt:
DerivedSources-input.xcfilelist:
DerivedSources-output.xcfilelist:
DerivedSources.make:
Headers.cmake:
Modules/WebGPU/GPUBuffer.cpp:

(WebCore::GPUBuffer::mapAsync):
(WebCore::GPUBuffer::getMappedRange):

Modules/WebGPU/GPUBuffer.h:
Modules/WebGPU/GPUCanvasConfiguration.h:

(WebCore::GPUCanvasConfiguration::convertToBacking const):

Modules/WebGPU/GPUCanvasConfiguration.idl:
Modules/WebGPU/GPUCommandEncoder.cpp:

(WebCore::GPUCommandEncoder::clearBuffer):
(WebCore::GPUCommandEncoder::fillBuffer): Deleted.

Modules/WebGPU/GPUCommandEncoder.h:
Modules/WebGPU/GPUCommandEncoder.idl:
Modules/WebGPU/GPUCommandsMixin.idl: Copied from Source/WebCore/Modules/WebGPU/GPULoadOp.idl.
Modules/WebGPU/GPUComputePassEncoder.cpp:

(WebCore::GPUComputePassEncoder::dispatch):
(WebCore::GPUComputePassEncoder::end):
(WebCore::GPUComputePassEncoder::beginPipelineStatisticsQuery): Deleted.
(WebCore::GPUComputePassEncoder::endPipelineStatisticsQuery): Deleted.
(WebCore::GPUComputePassEncoder::endPass): Deleted.

Modules/WebGPU/GPUComputePassEncoder.h:
Modules/WebGPU/GPUComputePassEncoder.idl:
Modules/WebGPU/GPUDebugCommandsMixin.idl: Copied from Source/WebCore/Modules/WebGPU/GPUFragmentState.idl.
Modules/WebGPU/GPUFeatureName.h:

(WebCore::convertToBacking):

Modules/WebGPU/GPUFeatureName.idl:
Modules/WebGPU/GPUFragmentState.h:

(WebCore::GPUFragmentState::convertToBacking const):

Modules/WebGPU/GPUFragmentState.idl:
Modules/WebGPU/GPUImageCopyExternalImage.h:

(WebCore::GPUImageCopyExternalImage::convertToBacking const):

Modules/WebGPU/GPUImageCopyExternalImage.idl:
Modules/WebGPU/GPULoadOp.h:

(WebCore::convertToBacking):

Modules/WebGPU/GPULoadOp.idl:
Modules/WebGPU/GPUObjectBase.idl:
Modules/WebGPU/GPUPipelineStatisticName.h: Removed.
Modules/WebGPU/GPUPipelineStatisticName.idl: Removed.
Modules/WebGPU/GPUProgrammablePassEncoder.idl:
Modules/WebGPU/GPUQuerySetDescriptor.h:

(WebCore::GPUQuerySetDescriptor::convertToBacking const):

Modules/WebGPU/GPUQuerySetDescriptor.idl:
Modules/WebGPU/GPUQueryType.h:

(WebCore::convertToBacking):

Modules/WebGPU/GPUQueryType.idl:
Modules/WebGPU/GPUQueue.cpp:

(WebCore::GPUQueue::writeBuffer):

Modules/WebGPU/GPUQueue.h:
Modules/WebGPU/GPURenderBundleEncoder.idl:
Modules/WebGPU/GPURenderBundleEncoderDescriptor.h:

(WebCore::GPURenderBundleEncoderDescriptor::convertToBacking const):

Modules/WebGPU/GPURenderPassColorAttachment.h:

(WebCore::GPURenderPassColorAttachment::convertToBacking const):

Modules/WebGPU/GPURenderPassColorAttachment.idl:
Modules/WebGPU/GPURenderPassDepthStencilAttachment.h:

(WebCore::GPURenderPassDepthStencilAttachment::convertToBacking const):

Modules/WebGPU/GPURenderPassDepthStencilAttachment.idl:
Modules/WebGPU/GPURenderPassDescriptor.h:

(WebCore::GPURenderPassDescriptor::convertToBacking const):

Modules/WebGPU/GPURenderPassDescriptor.idl:
Modules/WebGPU/GPURenderPassEncoder.cpp:

(WebCore::GPURenderPassEncoder::end):
(WebCore::GPURenderPassEncoder::beginPipelineStatisticsQuery): Deleted.
(WebCore::GPURenderPassEncoder::endPipelineStatisticsQuery): Deleted.
(WebCore::GPURenderPassEncoder::endPass): Deleted.

Modules/WebGPU/GPURenderPassEncoder.h:
Modules/WebGPU/GPURenderPassEncoder.idl:
Modules/WebGPU/GPURenderPassLayout.h:

(WebCore::GPURenderPassLayout::convertToBacking const):

Modules/WebGPU/GPURenderPassLayout.idl:
Modules/WebGPU/GPUShaderModuleCompilationHint.h: Copied from Source/WebCore/Modules/WebGPU/GPULoadOp.h.

(WebCore::GPUShaderModuleCompilationHint::convertToBacking const):

Modules/WebGPU/GPUShaderModuleCompilationHint.idl: Copied from Source/WebCore/Modules/WebGPU/GPUQueryType.idl.
Modules/WebGPU/GPUShaderModuleDescriptor.h:

(WebCore::GPUShaderModuleDescriptor::convertToBacking const):

Modules/WebGPU/GPUShaderModuleDescriptor.idl:
Modules/WebGPU/GPUTextureDescriptor.h:

(WebCore::GPUTextureDescriptor::convertToBacking const):

Modules/WebGPU/GPUTextureDescriptor.idl:
Modules/WebGPU/GPUTextureFormat.h:

(WebCore::convertToBacking):

Modules/WebGPU/GPUTextureFormat.idl:
Modules/WebGPU/GPUUncapturedErrorEvent.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:

Source/WebCore/PAL:

PAL.xcodeproj/project.pbxproj:
pal/graphics/WebGPU/Impl/WebGPUAdapterImpl.cpp:

(PAL::WebGPU::supportedFeatures):
(PAL::WebGPU::AdapterImpl::requestDevice):

pal/graphics/WebGPU/Impl/WebGPUBufferImpl.cpp:

(PAL::WebGPU::BufferImpl::mapAsync):
(PAL::WebGPU::BufferImpl::getMappedRange):

pal/graphics/WebGPU/Impl/WebGPUBufferImpl.h:
pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.cpp:

(PAL::WebGPU::CommandEncoderImpl::beginRenderPass):
(PAL::WebGPU::CommandEncoderImpl::beginComputePass):
(PAL::WebGPU::CommandEncoderImpl::clearBuffer):
(PAL::WebGPU::CommandEncoderImpl::fillBuffer): Deleted.

pal/graphics/WebGPU/Impl/WebGPUCommandEncoderImpl.h:
pal/graphics/WebGPU/Impl/WebGPUComputePassEncoderImpl.cpp:

(PAL::WebGPU::ComputePassEncoderImpl::dispatch):
(PAL::WebGPU::ComputePassEncoderImpl::end):
(PAL::WebGPU::ComputePassEncoderImpl::beginPipelineStatisticsQuery): Deleted.
(PAL::WebGPU::ComputePassEncoderImpl::endPipelineStatisticsQuery): Deleted.
(PAL::WebGPU::ComputePassEncoderImpl::endPass): Deleted.

pal/graphics/WebGPU/Impl/WebGPUComputePassEncoderImpl.h:
pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.cpp:

(PAL::WebGPU::ConvertToBackingContext::convertToBacking):

pal/graphics/WebGPU/Impl/WebGPUConvertToBackingContext.h:
pal/graphics/WebGPU/Impl/WebGPUDeviceImpl.cpp:

(PAL::WebGPU::DeviceImpl::createTexture):
(PAL::WebGPU::DeviceImpl::createShaderModule):
(PAL::WebGPU::convertToBacking):
(PAL::WebGPU::DeviceImpl::createRenderBundleEncoder):
(PAL::WebGPU::DeviceImpl::createQuerySet):

pal/graphics/WebGPU/Impl/WebGPUImpl.cpp:

(PAL::WebGPU::GPUImpl::requestAdapter):

pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.cpp:

(PAL::WebGPU::RenderPassEncoderImpl::end):
(PAL::WebGPU::RenderPassEncoderImpl::beginPipelineStatisticsQuery): Deleted.
(PAL::WebGPU::RenderPassEncoderImpl::endPipelineStatisticsQuery): Deleted.
(PAL::WebGPU::RenderPassEncoderImpl::endPass): Deleted.

pal/graphics/WebGPU/Impl/WebGPURenderPassEncoderImpl.h:
pal/graphics/WebGPU/WebGPUBuffer.h:
pal/graphics/WebGPU/WebGPUCanvasConfiguration.h:
pal/graphics/WebGPU/WebGPUCommandEncoder.h:
pal/graphics/WebGPU/WebGPUComputePassEncoder.h:
pal/graphics/WebGPU/WebGPUFeatureName.h:
pal/graphics/WebGPU/WebGPUFragmentState.h:
pal/graphics/WebGPU/WebGPUImageCopyExternalImage.h:
pal/graphics/WebGPU/WebGPULoadOp.h:
pal/graphics/WebGPU/WebGPUPipelineStatisticName.h: Removed.
pal/graphics/WebGPU/WebGPUQuerySetDescriptor.h:
pal/graphics/WebGPU/WebGPUQueryType.h:
pal/graphics/WebGPU/WebGPUQueue.h:
pal/graphics/WebGPU/WebGPURenderPassColorAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDepthStencilAttachment.h:
pal/graphics/WebGPU/WebGPURenderPassDescriptor.h:
pal/graphics/WebGPU/WebGPURenderPassEncoder.h:
pal/graphics/WebGPU/WebGPURenderPassLayout.h:
pal/graphics/WebGPU/WebGPUShaderModuleCompilationHint.h: Copied from Source/WebCore/PAL/pal/graphics/WebGPU/WebGPUImageCopyExternalImage.h.
pal/graphics/WebGPU/WebGPUShaderModuleDescriptor.h:
pal/graphics/WebGPU/WebGPUTextureDescriptor.h:
pal/graphics/WebGPU/WebGPUTextureFormat.h:

Source/WebGPU:

WebGPU/Adapter.h:
WebGPU/Adapter.mm:

(WebGPU::Adapter::enumerateFeatures):
(wgpuAdapterEnumerateFeatures):
(WebGPU::Adapter::getFeatureAtIndex): Deleted.
(wgpuAdapterGetFeatureAtIndex): Deleted.

WebGPU/CommandEncoder.h:
WebGPU/CommandEncoder.mm:

(WebGPU::CommandEncoder::clearBuffer):
(wgpuCommandEncoderClearBuffer):
(WebGPU::CommandEncoder::fillBuffer): Deleted.
(wgpuCommandEncoderFillBuffer): Deleted.

WebGPU/ComputePassEncoder.h:
WebGPU/ComputePassEncoder.mm:

(WebGPU::ComputePassEncoder::writeTimestamp): Deleted.
(wgpuComputePassEncoderWriteTimestamp): Deleted.

WebGPU/Device.h:
WebGPU/Device.mm:

(WebGPU::Device::enumerateFeatures):
(WebGPU::Device::hasFeature):
(wgpuDeviceEnumerateFeatures):
(wgpuDeviceHasFeature):

WebGPU/Instance.mm:

(wgpuGetProcAddress):

WebGPU/RenderPassEncoder.h:
WebGPU/RenderPassEncoder.mm:

(WebGPU::RenderPassEncoder::writeTimestamp): Deleted.
(wgpuRenderPassEncoderWriteTimestamp): Deleted.

WebGPU/ShaderModule.h:
WebGPU/ShaderModule.mm:

(WebGPU::ShaderModule::getCompilationInfo):
(wgpuShaderModuleGetCompilationInfo):

WebGPU/WebGPU.h:
WebGPU/WebGPUExt.h:

Source/WebKit:

GPUProcess/graphics/WebGPU/RemoteBuffer.cpp:

(WebKit::RemoteBuffer::mapAsync):

GPUProcess/graphics/WebGPU/RemoteBuffer.h:
GPUProcess/graphics/WebGPU/RemoteBuffer.messages.in:
GPUProcess/graphics/WebGPU/RemoteCommandEncoder.cpp:

(WebKit::RemoteCommandEncoder::clearBuffer):
(WebKit::RemoteCommandEncoder::fillBuffer): Deleted.

GPUProcess/graphics/WebGPU/RemoteCommandEncoder.h:
GPUProcess/graphics/WebGPU/RemoteCommandEncoder.messages.in:
GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.cpp:

(WebKit::RemoteComputePassEncoder::dispatch):
(WebKit::RemoteComputePassEncoder::end):
(WebKit::RemoteComputePassEncoder::beginPipelineStatisticsQuery): Deleted.
(WebKit::RemoteComputePassEncoder::endPipelineStatisticsQuery): Deleted.
(WebKit::RemoteComputePassEncoder::endPass): Deleted.

GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.h:
GPUProcess/graphics/WebGPU/RemoteComputePassEncoder.messages.in:
GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp:

(WebKit::RemoteRenderPassEncoder::end):
(WebKit::RemoteRenderPassEncoder::beginPipelineStatisticsQuery): Deleted.
(WebKit::RemoteRenderPassEncoder::endPipelineStatisticsQuery): Deleted.
(WebKit::RemoteRenderPassEncoder::endPass): Deleted.

GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.h:
GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.messages.in:
Shared/WebGPU/WebGPUCanvasConfiguration.cpp: