Changes between Version 34 and Version 35 of CommitterTips


Ignore:
Timestamp:
Apr 7, 2015 11:49:22 AM (9 years ago)
Author:
Michael Catanzaro
Comment:

WebKit2 owners exist now, so don't advise reviewers otherwise

Legend:

Unmodified
Added
Removed
Modified

  • CommitterTips

    v34 v35  
    126126
    127127== Guidelines for reviewers ==
    128  * There are no "protected areas" of the code.  No areas where only one reviewer has say.  Reviewers should review anything they feel comfortable reviewing.  If you are looking for experts in a certain area, trac and svn's annotate feature can help show you who has changed the relevant lines of code recently.
     128 * Get approval from a WebKit2 owner before giving r+ to a WebKit2 patch.
     129 * With that in mind, reviewers should review anything they feel comfortable reviewing.  If you are looking for experts in a certain area, trac and svn's annotate feature can help show you who has changed the relevant lines of code recently.
    129130 * Reviewers should come to consensus before landing.  If another reviewer objects, it's better to mark the patch r- and discuss than to land a patch without consensus.