161 | | '''The objective of run-bindings-tests is to show you and reviewers how the code generation is changed by your patch. |
162 | | If you change the behavior of code generators, please update the results of run-bindings-tests'''. |
163 | | |
164 | | That being said, people |
165 | | |
| 161 | The objective of run-bindings-tests is to show you and reviewers how the code generation is changed by your patch. |
| 162 | '''If you change the behavior of code generators, please update the results of run-bindings-tests'''. |
| 163 | |
| 164 | That being said, run-bindings-tests is just for showing the change to you and reviewers, |
| 165 | and the test failure is not critical for the WebKit build. |
| 166 | People have been likely to forget to update the run-bindings-tests results in fact. |
| 167 | Therefore, build bots do not treat the test failure as a failure. |
| 168 | In this way, the run-bindings-tests results in the WebKit repository are sometimes wrong. |
| 169 | If you find it, please rebaseline the run-bindings-tests before making your patch. |
| 170 | If you make your patch without rebaselining the test results, |
| 171 | the run-bindings-tests results will include the changes that had been caused by previous patches, |
| 172 | which would be unreadable for you and reviewers. |
| 173 | |
| 174 | Anyway, ideally all people should update the run-bindings-tests results if their patch changes the behavior of code generators. |