Timeline



Nov 29, 2021: Today

9:58 AM Changeset in webkit [286219] by Brent Fulgham
  • 4 edits
    1 add in trunk/Source/WebKit

Create a new XPC service with specific entitlements to support Captive Portal use cases
https://bugs.webkit.org/show_bug.cgi?id=233388
<rdar://problem/84481565>

Reviewed by Per Arne Vollan.

This initial patch builds a new XPC service with entitlements tailored to our Captive Portal
use case.

  • Configurations/WebContentService.CaptivePortal.xcconfig: Added.
  • Configurations/WebContentService.xcconfig:
  • Scripts/process-entitlements.sh: Add new sections for captive portal mode
  • WebKit.xcodeproj/project.pbxproj: Add new configuration file.
9:18 AM Changeset in webkit [286218] by youenn@apple.com
  • 17 edits in trunk

Apply WebPreferences on ServiceWorker settings
https://bugs.webkit.org/show_bug.cgi?id=233466
LayoutTests/imported/w3c:

<rdar://problem/85719388>

Reviewed by Chris Dumez.

  • web-platform-tests/html/cross-origin-embedder-policy/cross-origin-isolated-permission.https-expected.txt:

Source/WebCore:

Reviewed by Chris Dumez.

Migrate WebLock flag to a page setting.
Update ServiceWorkerThreadProxy to expose its method to create a service worker dummy page.
Covered by existing web lock service worker tests.

  • Modules/web-locks/NavigatorLocks.idl:
  • Modules/web-locks/WebLock.idl:
  • Modules/web-locks/WebLockManager.idl:
  • page/RuntimeEnabledFeatures.h:
  • workers/service/context/ServiceWorkerThreadProxy.cpp:
  • workers/service/context/ServiceWorkerThreadProxy.h:

Source/WebKit:

Reviewed by Chris Dumez.

Make WebPage::updateSettingsGenerated as static to reuse it in service worker code path
just after creation of the dummy Page attached to each service worker.
This allows correct initialization of the settings that are then used by the service worker.

  • Scripts/PreferencesTemplates/WebPageUpdatePreferences.cpp.erb:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:
  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

Source/WTF:

Reviewed by Chris Dumez.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
9:14 AM Changeset in webkit [286217] by Lauro Moura
  • 2 edits in trunk/Tools

[webkitflaskpy] Make sure flask is registered before importing webkitflaskpy
https://bugs.webkit.org/show_bug.cgi?id=233561

Reviewed by Jonathan Bedard.

bug233339 moved AuthedBlueprint to webkitflaskpy, but flask needs to
be registered before being imported to make sure AutoInstall takes
care of it. This avoids ModuleNotFound: flask errors running the
tests from a clean tree.

  • Scripts/libraries/webkitflaskpy/webkitflaskpy/init.py:
8:54 AM Changeset in webkit [286216] by Russell Epstein
  • 9 edits in trunk/Source

Versioning.

WebKit-7613.1.11

8:50 AM Changeset in webkit [286215] by Russell Epstein
  • 1 copy in branches/safari-613.1.10-branch

New branch.

8:42 AM Changeset in webkit [286214] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

Make WebKitCaptivePortalModeEnabled user default work on macOS
https://bugs.webkit.org/show_bug.cgi?id=233560

Reviewed by Anders Carlsson.

Make WebKitCaptivePortalModeEnabled user default work on macOS, not just iOS. This helps with testing.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:
  • UIProcess/WebProcessPool.cpp:
8:03 AM Changeset in webkit [286213] by Angelos Oikonomopoulos
  • 2 edits in trunk/Tools

Consider Source/cmake relevant for JSC
https://bugs.webkit.org/show_bug.cgi?id=233552

Reviewed by Aakash Jain.

Changes in Source/cmake may well be relevant for JSC.

  • CISupport/ews-build/steps.py:

(CheckPatchRelevance):

7:34 AM Changeset in webkit [286212] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[RISCV64] Populate RISCV64Assembler with instruction-generation methods
https://bugs.webkit.org/show_bug.cgi?id=233256

Patch by Zan Dobersek <zdobersek@igalia.com> on 2021-11-29
Reviewed by Yusuke Suzuki.

Sprinkle RISCV64Assembler class with helper methods for generating the
desired instruction values.

Immediate types from the RISCV64Instructions namespace are introduced
into the class for easier usage here and in the MacroAssemblerRISCV64
class. Instruction-generating methods roughly match the different
instruction types in the RISCV64Instructions namespace.

A few optimizations are done around floating-point instructions. We can
use one base method which expects the desired FP size as a template
parameter, and the appropriate RISCV64Instructions type can then be
selected based on that size value. Different combinations for FP move
and conversion instructions are also grouped behind a single method,
with thorough compile-time validation done to prevent generating
invalid instructions.

A few helper methods intended for masking, sign-extension and
zero-extension are also added. The Condition enum is fixed to list only
RISCV-viable conditions, with the values ordered so that a simple
XOR-by-one of a given value will produce the value of the inverted
condition.

  • assembler/RISCV64Assembler.h:

(JSC::RISCV64Assembler::invert):
(JSC::RISCV64Assembler::luiInsn):
(JSC::RISCV64Assembler::auipcInsn):
(JSC::RISCV64Assembler::jalInsn):
(JSC::RISCV64Assembler::jalrInsn):
(JSC::RISCV64Assembler::beqInsn):
(JSC::RISCV64Assembler::bneInsn):
(JSC::RISCV64Assembler::bltInsn):
(JSC::RISCV64Assembler::bgeInsn):
(JSC::RISCV64Assembler::bltuInsn):
(JSC::RISCV64Assembler::bgeuInsn):
(JSC::RISCV64Assembler::lbInsn):
(JSC::RISCV64Assembler::lhInsn):
(JSC::RISCV64Assembler::lwInsn):
(JSC::RISCV64Assembler::ldInsn):
(JSC::RISCV64Assembler::lbuInsn):
(JSC::RISCV64Assembler::lhuInsn):
(JSC::RISCV64Assembler::lwuInsn):
(JSC::RISCV64Assembler::sbInsn):
(JSC::RISCV64Assembler::shInsn):
(JSC::RISCV64Assembler::swInsn):
(JSC::RISCV64Assembler::sdInsn):
(JSC::RISCV64Assembler::addiInsn):
(JSC::RISCV64Assembler::sltiInsn):
(JSC::RISCV64Assembler::sltiuInsn):
(JSC::RISCV64Assembler::xoriInsn):
(JSC::RISCV64Assembler::oriInsn):
(JSC::RISCV64Assembler::andiInsn):
(JSC::RISCV64Assembler::slliInsn):
(JSC::RISCV64Assembler::srliInsn):
(JSC::RISCV64Assembler::sraiInsn):
(JSC::RISCV64Assembler::addInsn):
(JSC::RISCV64Assembler::subInsn):
(JSC::RISCV64Assembler::sllInsn):
(JSC::RISCV64Assembler::sltInsn):
(JSC::RISCV64Assembler::sltuInsn):
(JSC::RISCV64Assembler::xorInsn):
(JSC::RISCV64Assembler::srlInsn):
(JSC::RISCV64Assembler::sraInsn):
(JSC::RISCV64Assembler::orInsn):
(JSC::RISCV64Assembler::andInsn):
(JSC::RISCV64Assembler::ecallInsn):
(JSC::RISCV64Assembler::ebreakInsn):
(JSC::RISCV64Assembler::addiwInsn):
(JSC::RISCV64Assembler::slliwInsn):
(JSC::RISCV64Assembler::srliwInsn):
(JSC::RISCV64Assembler::sraiwInsn):
(JSC::RISCV64Assembler::addwInsn):
(JSC::RISCV64Assembler::subwInsn):
(JSC::RISCV64Assembler::sllwInsn):
(JSC::RISCV64Assembler::srlwInsn):
(JSC::RISCV64Assembler::srawInsn):
(JSC::RISCV64Assembler::mulInsn):
(JSC::RISCV64Assembler::mulhInsn):
(JSC::RISCV64Assembler::mulhsuInsn):
(JSC::RISCV64Assembler::mulhuInsn):
(JSC::RISCV64Assembler::divInsn):
(JSC::RISCV64Assembler::divuInsn):
(JSC::RISCV64Assembler::remInsn):
(JSC::RISCV64Assembler::remuInsn):
(JSC::RISCV64Assembler::mulwInsn):
(JSC::RISCV64Assembler::divwInsn):
(JSC::RISCV64Assembler::divuwInsn):
(JSC::RISCV64Assembler::remwInsn):
(JSC::RISCV64Assembler::remuwInsn):
(JSC::RISCV64Assembler::flwInsn):
(JSC::RISCV64Assembler::fldInsn):
(JSC::RISCV64Assembler::fswInsn):
(JSC::RISCV64Assembler::fsdInsn):
(JSC::RISCV64Assembler::fmaddInsn):
(JSC::RISCV64Assembler::fmsubInsn):
(JSC::RISCV64Assembler::fnmsubInsn):
(JSC::RISCV64Assembler::fnmaddInsn):
(JSC::RISCV64Assembler::faddInsn):
(JSC::RISCV64Assembler::fsubInsn):
(JSC::RISCV64Assembler::fmulInsn):
(JSC::RISCV64Assembler::fdivInsn):
(JSC::RISCV64Assembler::fsqrtInsn):
(JSC::RISCV64Assembler::fsgnjInsn):
(JSC::RISCV64Assembler::fsgnjnInsn):
(JSC::RISCV64Assembler::fsgnjxInsn):
(JSC::RISCV64Assembler::fminInsn):
(JSC::RISCV64Assembler::fmaxInsn):
(JSC::RISCV64Assembler::feqInsn):
(JSC::RISCV64Assembler::fltInsn):
(JSC::RISCV64Assembler::fleInsn):
(JSC::RISCV64Assembler::fclassInsn):
(JSC::RISCV64Assembler::fcvtInsn):
(JSC::RISCV64Assembler::fmvInsn):
(JSC::RISCV64Assembler::fenceInsn):
(JSC::RISCV64Assembler::lrwInsn):
(JSC::RISCV64Assembler::scwInsn):
(JSC::RISCV64Assembler::lrdInsn):
(JSC::RISCV64Assembler::scdInsn):
(JSC::RISCV64Assembler::amoswapwInsn):
(JSC::RISCV64Assembler::amoaddwInsn):
(JSC::RISCV64Assembler::amoxorwInsn):
(JSC::RISCV64Assembler::amoandwInsn):
(JSC::RISCV64Assembler::amoorwInsn):
(JSC::RISCV64Assembler::amoswapdInsn):
(JSC::RISCV64Assembler::amoadddInsn):
(JSC::RISCV64Assembler::amoxordInsn):
(JSC::RISCV64Assembler::amoanddInsn):
(JSC::RISCV64Assembler::amoordInsn):
(JSC::RISCV64Assembler::nop):
(JSC::RISCV64Assembler::maskRegister):
(JSC::RISCV64Assembler::signExtend):
(JSC::RISCV64Assembler::zeroExtend):
(JSC::RISCV64Assembler::insn):
(JSC::RISCV64Assembler::insnFP):
(JSC::RISCV64Assembler::isValidShiftAmount):

7:08 AM Changeset in webkit [286211] by mmaxfield@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Cocoa] Stop linking JavaScriptCore.framework with libz because it doesn't use any symbols from it
https://bugs.webkit.org/show_bug.cgi?id=233550

Reviewed by Anders Carlsson.

Every compile produces a message like:

Ld /Users/mmaxfield/Build/Products/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore normal (in target 'JavaScriptCore' from project 'JavaScriptCore')
ld: warning: linking with (/usr/lib/libz.1.dylib) but not using any symbols from it

6:32 AM Changeset in webkit [286210] by eocanha@igalia.com
  • 2 edits in trunk/Source/WebCore

[GStreamer][WPE] Control on-disk multimedia buffering via the WPE_SHELL_DISABLE_MEDIA_DISK_CACHE environment variable
https://bugs.webkit.org/show_bug.cgi?id=233492

Reviewed by Xabier Rodriguez-Calvar.

Embedded platforms often don't have a persistent storage suitable for repetitive writes (eg: caching
media files may wear out a flash drive, and RAM memory is scarce enough to use a tmpfs for caching).
Those platforms need a way to disable on-disk caching.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Honor environment variable.
5:05 AM Changeset in webkit [286209] by commit-queue@webkit.org
  • 14 edits in trunk/Source

GPUP GraphicsContextGL creation failure cannot be detected
https://bugs.webkit.org/show_bug.cgi?id=233517

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-11-29
Reviewed by Antti Koivisto.

Source/WebCore:

Before, concrete GraphicsContextGL instance was created with GraphicsContextGL::create()
which would internally use host window as a factory if possible. If this produced null, it would
create the "default" GraphicsContextGL subclass instance.
With GPUP, it does not make sense to create "default" type, as that in-process contexts should never
be used.
It also does not make sense to create "default", as it's unclear what the "default" type is.
Instead, use the host window, i.e. the chrome client, to always create the GraphicsContextGL instance
to WebGL. If this fails, the WebGL should be unavailable.
Remove GraphicsContextGL::create() as that is not useful. The callers should either
explicitly specify what subclass to use, for example in testing, or use the polymorhpic factory
(ChromeClient) which knows the policy.

Fix a bug where GPUP WebGL would use in-process context if the lost context would be recreated.

No new tests, a refactor.

  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):

  • page/ChromeClient.h:

(WebCore::ChromeClient::createGraphicsContextGL const):

  • platform/graphics/WebProcessGraphicsContextGL.h: Added.
  • platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm:

(WebCore::createWebProcessGraphicsContextGL):
(WebCore::GraphicsContextGLOpenGL::create): Deleted.

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
  • platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::createWebProcessGraphicsContextGL):
(WebCore::GraphicsContextGLOpenGL::create): Deleted.

  • platform/xr/openxr/PlatformXROpenXR.cpp:

(PlatformXR::OpenXRDevice::initializeTrackingAndRendering):

  • testing/WebFakeXRDevice.cpp:

(WebCore::SimulatedXRDevice::initializeTrackingAndRendering):

Source/WebKit:

If GPUP GraphicsContextGL creation fails, return nullptr instead of
trying to create a in-process context.

Enable WebChromeClient::createGraphicsContextGL() call for non-GPU process
compilation, as the function is now always called. Returning nullptr signifies failure
to create the context, not a signal to retry some other type.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createGraphicsContextGL const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
3:21 AM Changeset in webkit [286208] by Angelos Oikonomopoulos
  • 2 edits in trunk

Fix ATOMICS_REQUIRE_LIBATOMIC testcase on 32-bits
https://bugs.webkit.org/show_bug.cgi?id=233551

Unreviewed build fix.

There's a syntax error when compiling the test program
on 32-bits. This was not an issue on ARM as atomics are
built in on that platform, but broke the MIPS build.

  • Source/cmake/WebKitCompilerFlags.cmake:
2:29 AM Changeset in webkit [286207] by svillar@igalia.com
  • 4 edits in trunk

[css-flexbox] Do not shrink tables bellow their intrinsic sizes
https://bugs.webkit.org/show_bug.cgi?id=232383

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

Flex layout algorithm uses the flex items min|max sizes to compute the hypothetical main size which
will be used to clamp the size of the items when flexed. In the case of tables as flex items, we were
using the min-size straight away whenever that was definite. However we cannot do that because tables
must not shrink bellow their intrinsic sizes. That's why we should select the maximum of the intrinsic
size and the min-size.

This fixes a WPT test covering this case.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeFlexItemMinMaxSizes): Do not select a min-size smaller than the
table intrinsic size in the main axis.

LayoutTests:

  • TestExpectations: Unskip table-as-item-fixed-min-width-3.html which works fine now.
2:00 AM Changeset in webkit [286206] by svillar@igalia.com
  • 6 edits in trunk

[css-flexbox] Add support for replaced elements with intrinsic ratio and no intrinsic size
https://bugs.webkit.org/show_bug.cgi?id=231952
<rdar://problem/84662305>

Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

It might be the case that replaced elements have intrinsic aspect ratio but no
intrinsic dimensions. Actually that's quite common for SVGs for example. We're
incorrectly assuming that flex items with no intrinsic dimensions didn't have
intrinsic aspect ratios which is wrong.

Added new checks that are able to detect those cases were we have an intrinsic
aspect ratio even though there are no intrinsic dimensions.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::isRenderReplacedWithIntrinsicAspectRatio):
(WebCore::childHasAspectRatio):
Consider replaced elements with intrinsic ratios and no intrinsic dimensions.
(WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const):
Let replaced elements compute the aspect ratio by themselves.
(WebCore::RenderFlexibleBox::childHasComputableAspectRatio const):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::computeIntrinsicAspectRatio const): New method that
computes the aspect ratio for replaced elements.

  • rendering/RenderReplaced.h:

LayoutTests:

1:41 AM Changeset in webkit [286205] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk/Source/WebCore

GraphicsContextGLANGLE.cpp has platform specific code
https://bugs.webkit.org/show_bug.cgi?id=233515

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-11-29
Reviewed by Antti Koivisto.

GraphicsContextGLANGLE.cpp has platform specific code for modifying
the display buffer backing storage (IOSurface on Cocoa,
normal texture on TextureMapper variants).
This modification should be done through the reshapeDisplayBufferBacking
method call for all implementations, so that in the future
GraphicsContextGLOpenGL ANGLE variant can be renamed GraphicsContextGLANGLE
and still invoke that functionality.

No new tests, refactor.

  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):
(WebCore::GraphicsContextGLOpenGL::platformReleaseThreadResources): Deleted.

  • platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLOpenGL::bindDisplayBufferBacking):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
  • platform/graphics/texmap/GraphicsContextGLTextureMapperANGLE.cpp: Added.

(WebCore::GraphicsContextGLOpenGL::reshapeDisplayBufferBacking):
(WebCore::GraphicsContextGLOpenGL::platformReleaseThreadResources):

12:27 AM Changeset in webkit [286204] by commit-queue@webkit.org
  • 14 edits in trunk

[LBSE] Add runtime flag for Layer-based SVG engine (LBSE)
https://bugs.webkit.org/show_bug.cgi?id=233211
<rdar://problem/85711597>

Patch by Nikolas Zimmermann <nzimmermann@igalia.com> on 2021-11-29
Reviewed by Sam Weinig.

Add build option ('build-webkit --(no-)layer-based-svg-engine') and
runtime flag ('LayerBasedSVGEngineEnabled' in LBSE enabled builds) to
switch between the SVG engines.

The actual SVG code changes will follow in subsequent patches,
this just adds the infrastructure for LBSE.

.:

  • Source/cmake/OptionsFTW.cmake:
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsPlayStation.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WTF:

  • Scripts/Preferences/WebPreferencesInternal.yaml: Add 'LayerBasedSVGEngineEnabled' option.
  • wtf/PlatformEnable.h: Disable LBSE by default. (Toggable with build settings in CMake-based builds)
  • wtf/PlatformEnableCocoa.h: Enable for PLATFORM(MAC).

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add mapping from 'layer-based-svg-engine' -> 'ENABLE_LAYER_BASED_SVG_ENGINE'.

Nov 28, 2021: Yesterday

10:08 PM Changeset in webkit [286203] by Said Abou-Hallawa
  • 21 edits
    1 add in trunk/Source/WebCore

[GPU Process] Apply the filter to an ImageBuffer through GraphicsContext and ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=232843

Reviewed by Cameron McCormack.

This step will allow sending the Filter to GPUProcess and applying it to
a remote ImageBuffer.

In this patch, managing the sourceImageBuffer of the CSSFilter is moved
to RenderLayerFilters. This is similar to what RenderSVGResourceFilter
does by maintaining the sourceImage for the SVGFilter.

  • Headers.cmake:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

  • platform/graphics/ConcreteImageBuffer.h:
  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawFilteredImageBuffer):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageBuffer.h:
  • platform/graphics/filters/Filter.cpp: Added.

(WebCore::Filter::Filter):
(WebCore::Filter::apply):

  • platform/graphics/filters/Filter.h:

(WebCore::Filter::renderingMode const):
(WebCore::Filter::setRenderingMode):
(WebCore::Filter::scaledByFilterScale const):
(WebCore::Filter::Filter): Deleted.

  • platform/graphics/filters/FilterImage.h:
  • platform/graphics/filters/software/FETileSoftwareApplier.cpp:
  • platform/graphics/filters/software/SourceAlphaSoftwareApplier.cpp:
  • platform/graphics/filters/software/SourceGraphicSoftwareApplier.cpp:
  • rendering/CSSFilter.cpp:

(WebCore::CSSFilter::apply):
(WebCore::CSSFilter::setSourceImageRect):
(WebCore::CSSFilter::inputContext): Deleted.
(WebCore::CSSFilter::allocateBackingStoreIfNeeded): Deleted.
(WebCore::CSSFilter::output): Deleted.
(WebCore::CSSFilter::outputRect): Deleted.

  • rendering/CSSFilter.h:
  • rendering/RenderLayerFilters.cpp:

(WebCore::RenderLayerFilters::inputContext):
(WebCore::RenderLayerFilters::allocateBackingStore):
(WebCore::RenderLayerFilters::beginFilterEffect):
(WebCore::RenderLayerFilters::applyFilterEffect):

  • rendering/RenderLayerFilters.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • svg/graphics/filters/SVGFilter.cpp:

(WebCore::SVGFilter::apply):

  • svg/graphics/filters/SVGFilter.h:
9:11 PM Changeset in webkit [286202] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit

[WebGPU] Add WebKit DerivedSources to Xcode project
https://bugs.webkit.org/show_bug.cgi?id=233544

Reviewed by Simon Fraser.

This allows for things like searching from the UI to work.

No new tests because there is no behavior change.

  • WebKit.xcodeproj/project.pbxproj:
2:35 PM Changeset in webkit [286201] by commit-queue@webkit.org
  • 2 edits in trunk

Add mattwoodrow to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=233301

Patch by Matt Woodrow <matt.woodrow@gmail.com> on 2021-11-28
Reviewed by Cameron McCormack.

  • metadata/contributors.json:
2:24 PM Changeset in webkit [286200] by commit-queue@webkit.org
  • 6 edits in trunk

Serialize computed style of background shorthand with multiple layers correctly.
https://bugs.webkit.org/show_bug.cgi?id=111121

Patch by Matt Woodrow <matt.woodrow@gmail.com> on 2021-11-28
Reviewed by Cameron McCormack.

Source/WebCore:

New subtests added to getComputedStyle-background-shorthand

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-background-shorthand-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-background-shorthand.html:
1:28 PM Changeset in webkit [286199] by mmaxfield@apple.com
  • 2 edits in trunk

[WebGPU] Add WebGPU to the "All Source" scheme in WebKit.xcworkspace
https://bugs.webkit.org/show_bug.cgi?id=233542

Reviewed by Dean Jackson.

This scheme should build WebGPU.

  • WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:
12:34 PM Changeset in webkit [286198] by sihui_liu@apple.com
  • 12 edits
    1 add in trunk/LayoutTests

Convert error to string before passing to testFailed() in FileSystemAccess layout tests
https://bugs.webkit.org/show_bug.cgi?id=233241

Reviewed by Youenn Fablet.

testFailed() in js-test.js expects string, but finishTest() may receive Error object as parameter.

  • storage/filesystemaccess/directory-handle-basics.html:
  • storage/filesystemaccess/directory-handle-iteration.html:
  • storage/filesystemaccess/file-handle-getfile.html:
  • storage/filesystemaccess/handle-move.html:
  • storage/filesystemaccess/resources/directory-handle-basics.js:

(getDirectory):
(finishTest): Deleted.

  • storage/filesystemaccess/resources/directory-handle-iteration.js:

(finishTest): Deleted.

  • storage/filesystemaccess/resources/file-handle-getfile.js:

(async read):
(async test):
(finishTest): Deleted.

  • storage/filesystemaccess/resources/handle-move.js:

(async test):
(finishTest): Deleted.

  • storage/filesystemaccess/resources/shared.js: Added. Move finishTest() function here so the code can be shared.

(finishTest):

  • storage/filesystemaccess/resources/sync-access-handle-basics.js:

(getDirectory):
(finishTest): Deleted.

  • storage/filesystemaccess/resources/sync-access-handle-close.js:

(finishTest): Deleted.

  • storage/filesystemaccess/resources/sync-access-handle-read-write.js:

(async test):
(finishTest): Deleted.

11:15 AM Changeset in webkit [286197] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[WebGPU] Add derived sources to Xcode project
https://bugs.webkit.org/show_bug.cgi?id=233533

Reviewed by Simon Fraser.

This allows for things like searching within Xcode to work.

No new tests because there is no behavior change.

  • WebCore.xcodeproj/project.pbxproj:
10:55 AM Changeset in webkit [286196] by weinig@apple.com
  • 8 edits
    2 adds in trunk

[CSS Color 5] Update color-mix() to latest spec (again)
https://bugs.webkit.org/show_bug.cgi?id=233527

Reviewed by Dean Jackson.

Source/WebCore:

Updates color-mix() implementation with support for hue interpolation methods and
addresses various other spec changes (detailed below).

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:

Add ColorInterpolation.h/cpp

  • css/CSSValueKeywords.in:

Add keywords need for the <color-space-interpolation> production. Separated out
from color-mix as these will be used for other CSS properties as well.

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeHueInterpolationMethod):
(WebCore::CSSPropertyParserHelpers::consumeColorInterpolationMethod):
(WebCore::CSSPropertyParserHelpers::consumeColorMixComponent):
(WebCore::CSSPropertyParserHelpers::normalizedMixPercentages):
(WebCore::CSSPropertyParserHelpers::makeColorTypeByNormalizingComponentsAfterMix<HWBA<float>>):
(WebCore::CSSPropertyParserHelpers::makeColorTypeByNormalizingComponentsAfterMix<HSLA<float>>):
(WebCore::CSSPropertyParserHelpers::makeColorTypeByNormalizingComponentsAfterMix<LCHA<float>>):
(WebCore::CSSPropertyParserHelpers::makeColorTypeByNormalizingComponentsAfterMix<OKLCHA<float>>):
(WebCore::CSSPropertyParserHelpers::mixColorComponentsUsingColorInterpolationMethod):
(WebCore::CSSPropertyParserHelpers::mixColorComponents):
(WebCore::CSSPropertyParserHelpers::parseColorMixFunctionParameters):
(WebCore::CSSPropertyParserHelpers::consumeColorMixColorSpaceAndComma): Deleted.
(WebCore::CSSPropertyParserHelpers::fixupHueComponentsPriorToMix): Deleted.
(WebCore::CSSPropertyParserHelpers::mixColorComponentsInColorSpace): Deleted.
Rework color-mix to support the hue interpolation method specification for polor color spaces
like lch, oklch, hsl and hwb. Also update implementation to match the current spec by restricting
mix percentages to between 0 and 100 and applying alpha multiplier when the mix percentages add
up to less than 100.

  • platform/graphics/ColorInterpolation.cpp: Added.
  • platform/graphics/ColorInterpolation.h: Added.

Add structures to represent color interpolation methods including optional hue
interpolation parameters for color spaces that require it and provides prenormalization
that fixes up hue angles depending on the method selected. Over time, more aspects of
interpolation should be moved here as we figure out what can be shared.

LayoutTests:

  • fast/css/parsing-color-mix-expected.txt:
  • fast/css/parsing-color-mix.html:

Update tests to include testing of hue interpolation methods, new
restrictions on percentage ranges and the new alpha multiplier.

10:32 AM Changeset in webkit [286195] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][IFC] Visual ordering may require multiple display box instances for a single inline box
https://bugs.webkit.org/show_bug.cgi?id=233538

Reviewed by Antti Koivisto.

This patch implements the multiple display box setup for cases when the visually re-ordered content escapes
the logical inline box boundaries.

a<span>bg</span>f<span>ec</span>d -> "abgfecd"

Introduce RTL/LTR overrides:

a<span>b&#8238;g</span>f<span>e&#8237;c</span>d -> "abcdefg"

current direction: left-to-right.
take: 'a'
take: 'b'
take: RTL override (current direction: right-to-left, ie jump to the right end of the override content unless there's a nested override)
take: (nested)LTR override (current direction: left-to-right, ie jump to the left end of the override content)
take: 'c'
take: 'd' (end of nested LTR override)
take: 'e' (in RTL direction)
take: 'f'
take: 'g'

By jumping between these bidi runs, we may end up going back and forth between various inline boxes.
Each time we "leave" an inline box (e.g. going from 'b' to 'c'), we need to close the current inline box(es)
and "open" new one(s) for the content.
This patch implements the jumping logic but it does not yet compute geometry for each of these fragmented inline boxes.

  • layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBoxForBidiBoundary):
(WebCore::Layout::InlineDisplayContentBuilder::adjustInlineBoxDisplayBoxForBidiBoundary):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent): "Open" and "close" inline boxes based on the content
and not based on the [inline box start]/[inline box end] runs (ie content where logical order == visual order can use those explicit markers to
construct the associated display boxes but with re-ordering we need to rely on the content itself)

(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):

  • layout/formattingContexts/inline/InlineDisplayContentBuilder.h:
10:19 AM Changeset in webkit [286194] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Weird JS usage in webrtc/multi-video.html
https://bugs.webkit.org/show_bug.cgi?id=233540

Patch by Philippe Normand <pnormand@igalia.com> on 2021-11-28
Reviewed by Youenn Fablet.

  • webrtc/multi-video.html: MediaStream.getVideoTracks() accepts no argument and returns a

sequence. The MediaStream constructor needs a sequence of tracks.

Nov 27, 2021:

8:28 PM Changeset in webkit [286193] by Said Abou-Hallawa
  • 22 edits
    7 adds
    4 deletes in trunk/Source/WebCore

[GPU Process] Implement FilterEffect CoreImage appliers
https://bugs.webkit.org/show_bug.cgi?id=232831

Reviewed by Cameron McCormack.

This will allow applying the CoreImage filters through FilterEffect::apply().
It will also allow passing FilterImages to the FilterEffect CoreImage
appliers. This will require adding a CIImage as a possible result to
FilterImage.

If the CoreImage filters are enabled, the Filter will check if all the
FilterEffects supports CoreImage rendering. And if one if them does not
support it, the renderingMode will be switched to Unaccelerated.

  • Sources.txt:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/coreimage/FEColorMatrixCoreImageApplier.h: Copied from Source/WebCore/platform/graphics/filters/FilterEffectRenderer.cpp.
  • platform/graphics/coreimage/FEColorMatrixCoreImageApplier.mm: Added.

(WebCore::FEColorMatrixCoreImageApplier::FEColorMatrixCoreImageApplier):
(WebCore::FEColorMatrixCoreImageApplier::supportsCoreImageRendering):
(WebCore::FEColorMatrixCoreImageApplier::apply const):

  • platform/graphics/coreimage/FEComponentTransferCoreImageApplier.h: Renamed from Source/WebCore/platform/graphics/filters/FilterEffectRenderer.h.
  • platform/graphics/coreimage/FEComponentTransferCoreImageApplier.mm: Added.

(WebCore::FEComponentTransferCoreImageApplier::FEComponentTransferCoreImageApplier):
(WebCore::FEComponentTransferCoreImageApplier::supportsCoreImageRendering):
(WebCore::FEComponentTransferCoreImageApplier::apply const):

  • platform/graphics/coreimage/FilterEffectRendererCoreImage.h: Removed.
  • platform/graphics/coreimage/FilterEffectRendererCoreImage.mm: Removed.
  • platform/graphics/coreimage/FilterImageCoreImage.mm: Added.

(WebCore::sharedCIContext):
(WebCore::FilterImage::setCIImage):
(WebCore::FilterImage::imageBufferFromCIImage):

  • platform/graphics/coreimage/SourceGraphicCoreImageApplier.h: Copied from Source/WebCore/platform/graphics/filters/FilterEffectRenderer.cpp.
  • platform/graphics/coreimage/SourceGraphicCoreImageApplier.mm: Renamed from Source/WebCore/platform/graphics/filters/FilterEffectRenderer.cpp.

(WebCore::SourceGraphicCoreImageApplier::apply const):

  • platform/graphics/cv/CVUtilities.mm:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::supportsCoreImageRendering const):
(WebCore::FEColorMatrix::createApplier const):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::supportsCoreImageRendering const):
(WebCore::FEComponentTransfer::createApplier const):

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/Filter.h:

(WebCore::Filter::Filter):
(): Deleted.

  • platform/graphics/filters/FilterFunction.h:

(WebCore::FilterFunction::supportsCoreImageRendering const):

  • platform/graphics/filters/FilterImage.cpp:

(WebCore::FilterImage::imageBuffer):
(WebCore::FilterImage::imageBufferFromPixelBuffer):

  • platform/graphics/filters/FilterImage.h:

(WebCore::FilterImage::ciImage const):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::createApplier const):

  • platform/graphics/filters/SourceGraphic.h:
  • platform/mac/ScrollingEffectsController.mm:
  • rendering/CSSFilter.cpp:

(WebCore::CSSFilter::create):
(WebCore::CSSFilter::CSSFilter):
(WebCore::createSVGFilter):
(WebCore::CSSFilter::buildFilterFunctions):
(WebCore::CSSFilter::allocateBackingStoreIfNeeded):
(WebCore::CSSFilter::supportsCoreImageRendering const):
(WebCore::CSSFilter::apply):
(WebCore::CSSFilter::output):
(WebCore::CSSFilter::outputRect):

  • rendering/CSSFilter.h:
  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • svg/graphics/filters/SVGFilter.cpp:

(WebCore::SVGFilter::create):
(WebCore::SVGFilter::SVGFilter):
(WebCore::SVGFilter::supportsCoreImageRendering const):

  • svg/graphics/filters/SVGFilter.h:
7:43 PM Changeset in webkit [286192] by ysuzuki@apple.com
  • 2 edits in trunk

Unreviewed, update atomics detection to make libpas built on Linux

  • Source/cmake/WebKitCompilerFlags.cmake:
12:54 PM Changeset in webkit [286191] by weinig@apple.com
  • 22 edits
    32 adds in trunk

[CSS Color 4] Add support for oklab() and oklch() colors
https://bugs.webkit.org/show_bug.cgi?id=233507

Reviewed by Cameron McCormack.

LayoutTests/imported/w3c:

Add new tests for oklab() and oklch() based on the existing lab()
and lch() tests.

  • web-platform-tests/css/css-color/oklab-001-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-001.html: Added.
  • web-platform-tests/css/css-color/oklab-002-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-002.html: Added.
  • web-platform-tests/css/css-color/oklab-003-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-003.html: Added.
  • web-platform-tests/css/css-color/oklab-004-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-004.html: Added.
  • web-platform-tests/css/css-color/oklab-005-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-005.html: Added.
  • web-platform-tests/css/css-color/oklab-006-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-006.html: Added.
  • web-platform-tests/css/css-color/oklab-007-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-007.html: Added.
  • web-platform-tests/css/css-color/oklab-008-expected.html: Added.
  • web-platform-tests/css/css-color/oklab-008.html: Added.
  • web-platform-tests/css/css-color/oklch-001-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-001.html: Added.
  • web-platform-tests/css/css-color/oklch-002-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-002.html: Added.
  • web-platform-tests/css/css-color/oklch-003-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-003.html: Added.
  • web-platform-tests/css/css-color/oklch-004-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-004.html: Added.
  • web-platform-tests/css/css-color/oklch-005-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-005.html: Added.
  • web-platform-tests/css/css-color/oklch-006-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-006.html: Added.
  • web-platform-tests/css/css-color/oklch-007-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-007.html: Added.
  • web-platform-tests/css/css-color/oklch-008-expected.html: Added.
  • web-platform-tests/css/css-color/oklch-008.html: Added.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/css/css-color/oklab-001.html

imported/w3c/web-platform-tests/css/css-color/oklab-002.html
imported/w3c/web-platform-tests/css/css-color/oklab-003.html
imported/w3c/web-platform-tests/css/css-color/oklab-004.html
imported/w3c/web-platform-tests/css/css-color/oklab-005.html
imported/w3c/web-platform-tests/css/css-color/oklab-006.html
imported/w3c/web-platform-tests/css/css-color/oklab-007.html
imported/w3c/web-platform-tests/css/css-color/oklab-008.html
imported/w3c/web-platform-tests/css/css-color/oklch-001.html
imported/w3c/web-platform-tests/css/css-color/oklch-002.html
imported/w3c/web-platform-tests/css/css-color/oklch-003.html
imported/w3c/web-platform-tests/css/css-color/oklch-004.html
imported/w3c/web-platform-tests/css/css-color/oklch-005.html
imported/w3c/web-platform-tests/css/css-color/oklch-006.html
imported/w3c/web-platform-tests/css/css-color/oklch-007.html
imported/w3c/web-platform-tests/css/css-color/oklch-008.html

Adds support for oklab() and oklch() CSS colors and as interpolation
parameters for color-mix().

OKLab (and its polar form OKLCH) is a relatively new Lab-like colorspace that aims
to be an improved (improved hue linearity, hue uniformity, and chroma uniformity)
Lab. It was create by Björn Ottosson and is documented at https://bottosson.github.io/posts/oklab/.

  • css/CSSValueKeywords.in:

Add 'oklab' and 'oklch' to the keyword list so they can be used as function
identifiers. Remove old mention of 'lab' in the color() function section,
since 'lab' is no longer a valid colorspace to use in the color() function
(rather, only lab() is supported).

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseLabParameters):
(WebCore::CSSPropertyParserHelpers::parseRelativeLabParameters):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeLabParameters):
(WebCore::CSSPropertyParserHelpers::parseLCHParameters):
(WebCore::CSSPropertyParserHelpers::parseRelativeLCHParameters):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeLCHParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
Generalize lab and lch function parsing to also support the oklab and
oklch variants (they have the same parsing rules).

(WebCore::CSSPropertyParserHelpers::consumeColorMixColorSpaceAndComma):
(WebCore::CSSPropertyParserHelpers::mixColorComponents):
Add support for using oklab and oklch as the interpolation space of a color-mix().
This was already generalized so all it meant doing was adding mappings of the
new identifiers to enums and mixColorComponentsInColorSpace calls.

  • platform/graphics/ColorComponents.h:

(WebCore::ColorComponents::subset const):
Fix compile error (no one had used subset yet it seems). 'std::remove_const_t<decltype(T::Size)>'
was likely copied from mapColorComponents() where it is templatized and needs to deduce the loop
variable, but that is not needed here.

  • platform/graphics/ColorConversion.cpp:

(WebCore::convertToPolarForm):
(WebCore::convertToRectangularForm):
Move conversion to/from polar/rectangular forms from the LCHA conversion
code here, so that it can be reused for OKLCHA.

(WebCore::OKLab<float>>::convert):
Add support for converting OKLab to/from XYZ D65. Matrix values come from https://bottosson.github.io/posts/oklab/
with updates from https://github.com/w3c/csswg-drafts/issues/6642#issuecomment-943521484

(WebCore::OKLCHA<float>>::convert):
Add support for converting OKLCHA. This is identical to the LCHA code above.

(WebCore::converColorComponents):
Add cases for new colorspaces.

  • platform/graphics/ColorConversion.h:

Add converters for new colorspaces. Update diagram with them as well.

  • platform/graphics/ColorMatrix.h:

(WebCore::ColorMatrix::transformedColorComponents const):
Generalize transformedColorComponents to work with any size ColorComponents object. This allows
the OKLab conversion code to be a bit simpler as it can operate on just the non-alpha components
in a more systematic way.

  • platform/graphics/ColorModels.h:

Add new predicate template variables to help when needing to check what model a particular
color type uses.

  • platform/graphics/ColorSerialization.cpp:

(WebCore::serialization):
(WebCore::serializationForCSS):
(WebCore::serializationForHTML):
(WebCore::serializationForRenderTreeAsText):
Add serialization support for new colorspaces. Also removes unused support for serializing lab
colors using the color(lab ...) syntax which has not been supported for some time.

  • platform/graphics/ColorSpace.cpp:
  • platform/graphics/ColorSpace.h:
  • platform/graphics/cg/ColorSpaceCG.h:

Add OKLab and OKLCH to the list of enumerated colorspaces and add mappings to their
newly defined types OKLab<T> and OKLCHA<T>.

  • platform/graphics/ColorTypes.h:

(WebCore::OKLab::OKLab):
(WebCore::OKLCHA::OKLCHA):
Add new types OKLab<T> and OKLCHA<T> (it looks like at some point an earlier version of this
must have partially landed as there were existing forward declarations). Like Lab<T> and LCHA<T>,
these new types use the LabModel<T> and LCHModel<T> models, but unlike them they use a whitepoint
of D65.

  • platform/graphics/ColorUtilities.h:

Generalize isBlack and isWhite to have a variant that works with Lab, LCH, OKLab and OKLCH (as they
all are identical) using SFINAE, use the new model predicates to make this more clear.

LayoutTests:

Update existing tests for lab() and lch() to also test oklab() and oklch().
As they have the same parsing rules, this is mostly done by templatizing
the tests and running them in a loop.

  • fast/css/parsing-color-mix-expected.txt:
  • fast/css/parsing-color-mix.html:
  • fast/css/parsing-lab-colors-expected.txt:
  • fast/css/parsing-lab-colors.html:
  • fast/css/parsing-relative-color-syntax-expected.txt:
  • fast/css/parsing-relative-color-syntax.html:
9:52 AM Changeset in webkit [286190] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC][IFC] Decouple display box construction for bidi and non-bidi content
https://bugs.webkit.org/show_bug.cgi?id=233531

Reviewed by Antti Koivisto.

Having a common display box creation codepath for both bidi and non-bidi content worked out well this far
but the upcoming inline box visual ordering will certainly make the common codepath unnecessarily confusing
for the non-bidi case.
In this patch the newly introduced append* functions manage the display box creation and
their callers (processNonBidiContent/processBidiContent) deal with the visual ordering details.
It means that the non-bidi codepath simply loops through the line runs and calls the append* functions,
while the bidi codepath keeps track of the visual ordering and calls the append* functions accordingly.

  • layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSoftLineBreakDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendHardLineBreakDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendAtomicInlineLevelDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::processNonBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processBidiContent):
(WebCore::Layout::InlineDisplayContentBuilder::processOverflownRunsForEllipsis):
(WebCore::Layout::InlineDisplayContentBuilder::createBoxesAndUpdateGeometryForLineContent): Deleted.

  • layout/formattingContexts/inline/InlineDisplayContentBuilder.h:
8:41 AM Changeset in webkit [286189] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK][a11y] Signal state-changed:selected is not emitted for listbox elements when building with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=233521

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Post a selected change notification for option elements when the state changes.

  • accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setSelectedState):

Tools:

Add test cases to check that the signal is now emitted as expected.

  • TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(AccessibilityTest::isSelected):
(testAccessibleStateChanged):
(testSelectionListBox):
(testSelectionMenuList):

1:44 AM Changeset in webkit [286188] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

[:has() pseudo-class] Invalidation support for adding and removing elements
https://bugs.webkit.org/show_bug.cgi?id=233489
<rdar://problem/85754298>

Unreviewed followup.

Some unitialized bits caused us to do unnecessary work and regressed Speedometer.

  • style/RuleFeature.h:

Initialize the usedMatchElements array.

Nov 26, 2021:

6:43 PM Changeset in webkit [286187] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Typo in ColorConversion code: converColorComponents
https://bugs.webkit.org/show_bug.cgi?id=233497

Reviewed by Ryosuke Niwa.

Fix typo in ColorConversion code. converColorComponents -> convertColorComponents

  • platform/graphics/Color.cpp:

(WebCore::Color::toColorComponentsInColorSpace const):

  • platform/graphics/ColorConversion.cpp:

(WebCore::convertColorComponents):
(WebCore::converColorComponents): Deleted.

  • platform/graphics/ColorConversion.h:
3:51 PM Changeset in webkit [286186] by Said Abou-Hallawa
  • 74 edits in trunk/Source/WebCore

[GPU Process] Make FilterEffects create FilterEffectAppliers which will be used by FilterEffect::apply()
https://bugs.webkit.org/show_bug.cgi?id=233516

Reviewed by Cameron McCormack.

This step is required to allow integrating CoreImage FilterEffect appliers
in FilterEffect::apply(). Currently applying CoreImage FilterEffect has
to go to a different code path in FilterEffectRendererCoreImage.

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::createApplier const):
(WebCore::FEBlend::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::createApplier const):
(WebCore::FEColorMatrix::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::createApplier const):
(WebCore::FEComponentTransfer::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::createApplier const):
(WebCore::FEComposite::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::createApplier const):
(WebCore::FEConvolveMatrix::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::createApplier const):
(WebCore::FEDisplacementMap::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::createApplier const):
(WebCore::FEDropShadow::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::createApplier const):
(WebCore::FEFlood::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::createApplier const):
(WebCore::FEGaussianBlur::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::createApplier const):
(WebCore::FELighting::platformApplySoftware): Deleted.

  • platform/graphics/filters/FELighting.h:
  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::createApplier const):
(WebCore::FEMerge::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::createApplier const):
(WebCore::FEMorphology::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::createApplier const):
(WebCore::FEOffset::platformApplySoftware): Deleted.

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::createApplier const):
(WebCore::FETile::platformApplySoftware): Deleted.

  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::createApplier const):
(WebCore::FETurbulence::platformApplySoftware): Deleted.

  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):

  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterEffectApplier.h:

(WebCore::FilterEffectApplier::create):
(WebCore::FilterEffectConcreteApplier::FilterEffectConcreteApplier):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::createApplier const):
(WebCore::SourceAlpha::platformApplySoftware): Deleted.

  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::createApplier const):
(WebCore::SourceGraphic::platformApplySoftware): Deleted.

  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/filters/software/FEBlendSoftwareApplier.cpp:

(WebCore::FEBlendSoftwareApplier::apply const):
(WebCore::FEBlendSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEBlendSoftwareApplier.h:
  • platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp:

(WebCore::FEColorMatrixSoftwareApplier::FEColorMatrixSoftwareApplier):
(WebCore::FEColorMatrixSoftwareApplier::apply const):
(WebCore::FEColorMatrixSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEColorMatrixSoftwareApplier.h:
  • platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp:

(WebCore::FEComponentTransferSoftwareApplier::apply const):
(WebCore::FEComponentTransferSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEComponentTransferSoftwareApplier.h:
  • platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:

(WebCore::FECompositeSoftwareApplier::applyArithmetic const):
(WebCore::FECompositeSoftwareApplier::applyNonArithmetic const):
(WebCore::FECompositeSoftwareApplier::apply const):
(WebCore::FECompositeSoftwareApplier::applyArithmetic): Deleted.
(WebCore::FECompositeSoftwareApplier::applyNonArithmetic): Deleted.
(WebCore::FECompositeSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FECompositeSoftwareApplier.h:
  • platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:

(WebCore::FEConvolveMatrixSoftwareApplier::apply const):
(WebCore::FEConvolveMatrixSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h:
  • platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp:

(WebCore::FEDisplacementMapSoftwareApplier::FEDisplacementMapSoftwareApplier):
(WebCore::FEDisplacementMapSoftwareApplier::apply const):
(WebCore::FEDisplacementMapSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.h:
  • platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp:

(WebCore::FEDropShadowSoftwareApplier::apply const):
(WebCore::FEDropShadowSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEDropShadowSoftwareApplier.h:
  • platform/graphics/filters/software/FEFloodSoftwareApplier.cpp:

(WebCore::FEFloodSoftwareApplier::apply const):
(WebCore::FEFloodSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEFloodSoftwareApplier.h:
  • platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

(WebCore::FEGaussianBlurSoftwareApplier::apply const):
(WebCore::FEGaussianBlurSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h:
  • platform/graphics/filters/software/FELightingSoftwareApplier.cpp:

(WebCore::FELightingSoftwareApplier::apply const):
(WebCore::FELightingSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FELightingSoftwareApplier.h:
  • platform/graphics/filters/software/FEMergeSoftwareApplier.cpp:

(WebCore::FEMergeSoftwareApplier::apply const):
(WebCore::FEMergeSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEMergeSoftwareApplier.h:
  • platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:

(WebCore::FEMorphologySoftwareApplier::apply const):
(WebCore::FEMorphologySoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEMorphologySoftwareApplier.h:
  • platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp:

(WebCore::FEOffsetSoftwareApplier::apply const):
(WebCore::FEOffsetSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FEOffsetSoftwareApplier.h:
  • platform/graphics/filters/software/FETileSoftwareApplier.cpp:

(WebCore::FETileSoftwareApplier::apply const):
(WebCore::FETileSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FETileSoftwareApplier.h:
  • platform/graphics/filters/software/FETurbulenceSoftwareApplier.cpp:

(WebCore::FETurbulenceSoftwareApplier::apply const):
(WebCore::FETurbulenceSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/FETurbulenceSoftwareApplier.h:
  • platform/graphics/filters/software/SourceAlphaSoftwareApplier.cpp:

(WebCore::SourceAlphaSoftwareApplier::apply const):
(WebCore::SourceAlphaSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/SourceAlphaSoftwareApplier.h:
  • platform/graphics/filters/software/SourceGraphicSoftwareApplier.cpp:

(WebCore::SourceGraphicSoftwareApplier::apply const):
(WebCore::SourceGraphicSoftwareApplier::apply): Deleted.

  • platform/graphics/filters/software/SourceGraphicSoftwareApplier.h:
  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImageSoftwareApplier::apply const):
(WebCore::FEImage::createApplier const):
(WebCore::FEImageSoftwareApplier::apply): Deleted.
(WebCore::FEImage::platformApplySoftware): Deleted.

  • svg/graphics/filters/SVGFEImage.h:
2:19 PM Changeset in webkit [286185] by Lauro Moura
  • 2 edits in trunk/Tools

[GTK] Gardening API test WebKit.OnDeviceChangedCrash as flaky timeout

Unreviewed test gardening.

Flakiness seems to have been introduced between 243131@main and
243249@main.

  • TestWebKitAPI/glib/TestExpectations.json:
2:10 PM Changeset in webkit [286184] by Adrian Perez de Castro
  • 1 copy in releases/WPE WebKit/webkit-2.35.1

WPE WebKit 2.35.1

2:09 PM Changeset in webkit [286183] by Adrian Perez de Castro
  • 4 edits in trunk

Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.35.1 release

.:

  • Source/cmake/OptionsWPE.cmake: Bump version numbers.

Source/WebKit:

  • wpe/NEWS: Add release notes for 2.35.1.
1:45 PM Changeset in webkit [286182] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

Unreviewed non-unified build fix.

No new tests needed.

  • css/SelectorChecker.cpp: Add missin StyleRule.h header inclusion.
11:36 AM Changeset in webkit [286181] by ntim@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

Remove focus-after-close-expected.txt for glib as it is identical as the cross-platform file

Unreviewed test gardening

  • platform/glib/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/focus-after-close-expected.txt: Removed.
7:13 AM Changeset in webkit [286180] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

[:has() pseudo-class] Don't traverse descendants during selector matching unless needed
https://bugs.webkit.org/show_bug.cgi?id=233520

Reviewed by Alan Bujtas.

It is sufficient to traverse direct children to match something like :has(> foo).

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne const):
(WebCore::SelectorChecker::matchHasPseudoClass const):

Factor into a function.
Compute the match element for the :has() argument and use it to choose what to traverse.

  • css/SelectorChecker.h:
  • style/RuleFeature.cpp:

(WebCore::Style::computeNextMatchElement):
(WebCore::Style::computeHasPseudoClassMatchElement):
(WebCore::Style::computeSubSelectorMatchElement):

Make these free-standing functions and expose computeHasPseudoClassMatchElement.

(WebCore::Style::RuleFeatureSet::computeNextMatchElement): Deleted.
(WebCore::Style::RuleFeatureSet::computeSubSelectorMatchElement): Deleted.

  • style/RuleFeature.h:
7:01 AM Changeset in webkit [286179] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION(r286112): Style invalidation for text mutation happening after event dispatch
https://bugs.webkit.org/show_bug.cgi?id=233501
<rdar://problem/85754810>

Reviewed by Alan Bujtas.

Source/WebCore:

Test: fast/events/mutation-in-DOMCharacterDataModified.html

  • dom/CharacterData.cpp:

(WebCore::CharacterData::setDataAndUpdate):

Scope ChildChangeInvalidation more narrowly.

LayoutTests:

  • fast/events/mutation-in-DOMCharacterDataModified-expected.txt: Added.
  • fast/events/mutation-in-DOMCharacterDataModified.html: Added.
6:42 AM Changeset in webkit [286178] by Alan Bujtas
  • 8 edits in trunk/Source/WebCore

[LFC][IFC] Generate ellipsis boxes for tex-overflow: ellipsis
https://bugs.webkit.org/show_bug.cgi?id=233508

Reviewed by Antti Koivisto.

  1. Check for overflowing inline content
  2. Truncate runs to make room for the ellipsis content

(https://drafts.csswg.org/css-overflow/#text-overflow)

  • layout/formattingContexts/inline/InlineDisplayContentBuilder.cpp:

(WebCore::Layout::InlineDisplayContentBuilder::build):
(WebCore::Layout::InlineDisplayContentBuilder::processOverflownRunsForEllipsis):

  • layout/formattingContexts/inline/InlineDisplayContentBuilder.h:
  • layout/formattingContexts/inline/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeGeometryForLineContent):

  • layout/formattingContexts/inline/InlineRect.h:

(WebCore::Layout::InlineRect::setRight):

  • layout/formattingContexts/inline/display/InlineDisplayBox.h:

(WebCore::InlineDisplay::Box::isEllipsis const):
(WebCore::InlineDisplay::Box::moveHorizontally):
(WebCore::InlineDisplay::Box::truncate):

  • layout/formattingContexts/inline/text/TextUtil.cpp:

(WebCore::Layout::TextUtil::breakWord):

  • layout/formattingContexts/inline/text/TextUtil.h:
5:35 AM Changeset in webkit [286177] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK][a11y] MenuListPopup elements should implement selection interface too when building with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=233519

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Add an implementation of canHaveSelectedChildren() to AccessibilityMenuListPopup that returns true for
ATSPI. Also implement selectedChildren() which is enough to share the same selection interface implementation
with list box elements. This is consistent with chromium.

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::canHaveSelectedChildren const):
(WebCore::AccessibilityMenuListPopup::selectedChildren):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

Tools:

Add a test case for menu list.

  • TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(testSelectionListBox):
(testSelectionMenuList):
(beforeAll):

5:17 AM Changeset in webkit [286176] by Adrian Perez de Castro
  • 14 edits in trunk/Source

Non-unified build fixes, late November 2021 edition
https://bugs.webkit.org/show_bug.cgi?id=233493

Unreviewed non-unified build fixes.

Source/JavaScriptCore:

  • jit/ThunkGenerators.h: Add missing inclusion of CallMode.h header, move header

inclusions inside the ENABLE(JIT) guard.

Source/WebCore:

No new tests needed.

  • Modules/mediastream/RTCDataChannelRemoteHandler.cpp: Add missing ProcessQualified.h and

ScriptExecutionContextIdentifier.h headers.

  • Modules/mediastream/RTCDataChannelRemoteSource.cpp: Ditto.
  • contentextensions/ContentExtensionActions.cpp: Add missing ResourceRequest.h header.
  • platform/graphics/filters/FilterImage.h: Add missing forward declarations for the Filter

and FloatRect types.

  • platform/graphics/filters/software/FEColorMatrixSoftwareApplier.h: Add missing forward

declaration for the PixelBuffer type.

  • platform/graphics/filters/software/FEComponentTransferSoftwareApplier.h: Ditto.
  • platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h: Add missing

IntPoint.h, IntSize.h, and JavaScriptCore/TypedArrayAdaptersForwardDeclarations.h headers.

  • platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h: Add missing

IntSize.h header.

  • platform/graphics/filters/software/FELightingSoftwareApplier.h: Add missing

FilterEffect.h and FilterImageVector.h headers.

Source/WebKit:

  • WebProcess/Network/webrtc/RTCDataChannelRemoteManager.h: Add missing

WebCore/ProcessQualified.h header.

3:11 AM Changeset in webkit [286175] by commit-queue@webkit.org
  • 13 edits in trunk/Source/WebCore

GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code
https://bugs.webkit.org/show_bug.cgi?id=233513

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-11-26
Reviewed by Antti Koivisto.

Move duplicate functionality of "context changed, context not changed" from

  • GraphicsContextGLOpenGL ANGLE variant
  • GraphicsContextGLOpenGL OpenGL, OpenGL ES variant
  • RemoteGraphicsContextGLProxyBase

to base class GraphicsContextGL. In order to do this, add few WEBCORE_EXPORTs to
GraphicsContextGL.h, since RemoteGraphicsContextGLProxyBase is in WebKit and needs to call
the base-class versions as well as use vtable.

Move ANGLE-specific functions from GraphicsContextGLOpenGL.cpp to GraphicsContextGLANGLE.cpp.
Move TextureMapper-specific functions from GraphicsContextGLOpenGL.cpp to GraphicsContextGLTextureMapper.cpp.
Move OpenGL, OpenGL ES specific functions from GraphicsContextGLOpenGL.cpp to GraphicsContextGLOpenGLCommon.cpp.

This works towards being able to separate ANGLE and OpenGL, OpenGL ES implementations to different classes,
reducing the ifdeffing in GraphicsContextGLOpenGL.h.

No new tests, refactor.

  • platform/graphics/GraphicsContextGL.cpp:

(WebCore::GraphicsContextGL::markContextChanged):
(WebCore::GraphicsContextGL::layerComposited const):
(WebCore::GraphicsContextGL::setBuffersToAutoClear):
(WebCore::GraphicsContextGL::getBuffersToAutoClear const):
(WebCore::GraphicsContextGL::markLayerComposited):

  • platform/graphics/GraphicsContextGL.h:

(WebCore::GraphicsContextGL::Client::~Client): Deleted.

  • platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:

(WebCore::RemoteGraphicsContextGLProxyBase::markContextChanged):
(WebCore::RemoteGraphicsContextGLProxyBase::markLayerComposited): Deleted.
(WebCore::RemoteGraphicsContextGLProxyBase::layerComposited const): Deleted.
(WebCore::RemoteGraphicsContextGLProxyBase::setBuffersToAutoClear): Deleted.
(WebCore::RemoteGraphicsContextGLProxyBase::getBuffersToAutoClear const): Deleted.

  • platform/graphics/RemoteGraphicsContextGLProxyBase.h:
  • platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::markContextChanged): Deleted.
(WebCore::GraphicsContextGLOpenGL::markLayerComposited): Deleted.
(WebCore::GraphicsContextGLOpenGL::layerComposited const): Deleted.

  • platform/graphics/cocoa/GraphicsContextGLCocoa.h:
  • platform/graphics/cocoa/GraphicsContextGLCocoa.mm:

(WebCore::GraphicsContextGLCocoa::copyTextureFromMedia):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::resetBuffersToAutoClear): Deleted.
(WebCore::GraphicsContextGLOpenGL::setBuffersToAutoClear): Deleted.
(WebCore::GraphicsContextGLOpenGL::getBuffersToAutoClear const): Deleted.
(WebCore::GraphicsContextGLOpenGL::releaseThreadResources): Deleted.
(WebCore::GraphicsContextGLOpenGL::platformReleaseThreadResources): Deleted.
(WebCore::GraphicsContextGLOpenGL::texImage2DResourceSafe): Deleted.
(WebCore::GraphicsContextGLOpenGL::setContextVisibility): Deleted.
(WebCore::GraphicsContextGLOpenGL::simulateEventForTesting): Deleted.
(WebCore::GraphicsContextGLOpenGL::prepareForDisplay): Deleted.
(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample): Deleted.
(WebCore::GraphicsContextGLOpenGL::readCompositedResults): Deleted.
(WebCore::GraphicsContextGLOpenGL::copyTextureFromMedia): Deleted.

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
  • platform/graphics/opengl/GraphicsContextGLOpenGLCommon.cpp:

(WebCore::GraphicsContextGLOpenGL::texImage2DResourceSafe):
(WebCore::GraphicsContextGLOpenGL::markContextChanged): Deleted.
(WebCore::GraphicsContextGLOpenGL::markLayerComposited): Deleted.
(WebCore::GraphicsContextGLOpenGL::layerComposited const): Deleted.

  • platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLOpenGL::setContextVisibility):
(WebCore::GraphicsContextGLOpenGL::simulateEventForTesting):
(WebCore::GraphicsContextGLOpenGL::prepareForDisplay):
(WebCore::GraphicsContextGLOpenGL::paintCompositedResultsToMediaSample):
(WebCore::GraphicsContextGLOpenGL::readCompositedResults):
(WebCore::GraphicsContextGLTextureMapper::copyTextureFromMedia):

  • platform/graphics/texmap/GraphicsContextGLTextureMapper.h:
1:22 AM Changeset in webkit [286174] by ntim@apple.com
  • 8 edits in trunk

Update dialog focusing steps inert/disconnected handling
https://bugs.webkit.org/show_bug.cgi?id=233514

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Updated tests to reflect new behavior.

  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focus-shadow-expected.txt:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusing-steps-disconnected-expected.txt:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusing-steps-disconnected.html:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusing-steps-inert-expected.txt:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-focusing-steps-inert.html:

Source/WebCore:

After discussing with Domenic Denicola, we resolved on stopping early return in case of inert <dialog>,
and disconnected <dialog> will just do nothing at the "focus the control" step.

The focus fixup rule still applies, meaning the focus is still moved to the viewport in case of modal <dialog>,
given everything else is non-focusable.

https://github.com/whatwg/html/commit/08b4033db249ea0c63fd35f4e8fa06e85ec20a6f

https://html.spec.whatwg.org/multipage/interaction.html#focus-fixup-rule

  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::runFocusingSteps):

12:41 AM Changeset in webkit [286173] by Carlos Garcia Campos
  • 11 edits
    1 add in trunk

[GTK][a11y] Add implementation of selection interface when building with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=233494

Reviewed by Adrian Perez de Castro.

Source/WebCore:

  • SourcesGTK.txt:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::deferSelectedChildrenChangedIfNeeded):

  • accessibility/atspi/AXObjectCacheAtspi.cpp:

(WebCore::AXObjectCache::postPlatformNotification):

  • accessibility/atspi/AccessibilityAtspi.cpp:

(WebCore::AccessibilityAtspi::selectionChanged):

  • accessibility/atspi/AccessibilityAtspi.h:
  • accessibility/atspi/AccessibilityObjectAtspi.cpp:

(WebCore::AccessibilityObjectAtspi::interfacesForObject):
(WebCore::AccessibilityObjectAtspi::path):
(WebCore::AccessibilityObjectAtspi::name const):
(WebCore::AccessibilityObjectAtspi::buildInterfaces const):

  • accessibility/atspi/AccessibilityObjectAtspi.h:
  • accessibility/atspi/AccessibilityObjectSelectionAtspi.cpp: Added.

(WebCore::AccessibilityObjectAtspi::selectionCount const):
(WebCore::AccessibilityObjectAtspi::selectedChild const):
(WebCore::AccessibilityObjectAtspi::setChildSelected const):
(WebCore::AccessibilityObjectAtspi::deselectSelectedChild const):
(WebCore::AccessibilityObjectAtspi::isChildSelected const):
(WebCore::AccessibilityObjectAtspi::selectAll const):
(WebCore::AccessibilityObjectAtspi::clearSelection const):
(WebCore::AccessibilityObjectAtspi::selectionChanged):

Tools:

Add tests case for selection interface and WTR implementation.

  • TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:

(testSelectionListBox):
(beforeAll):

  • WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:

(WTR::AccessibilityUIElement::selectedChildAtIndex const):
(WTR::AccessibilityUIElement::selectedChildrenCount const):
(WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
(WTR::AccessibilityUIElement::removeSelectionAtIndex const):
(WTR::AccessibilityUIElement::clearSelectedChildren const):

Nov 25, 2021:

11:53 PM Changeset in webkit [286172] by Said Abou-Hallawa
  • 21 edits in trunk/Source/WebCore

[GPU Process] Move FilterEffect relative absolutePaintRect calculation to FilterImage
https://bugs.webkit.org/show_bug.cgi?id=233510

Reviewed by Cameron McCormack.

drawingRegionOfInputImage() and requestedRegionOfInputPixelBuffer() will
be removed from FilterEffect and will be replaced by FilterImage::
absoluteImageRectRelativeTo(). Both of the removed function were just
getting the absolutePaintRect of a FilterEffect relative to a specified
FilterImage. Also there is o need for scaling because of clamping since
the areas of all FilterImages have to be less than MaxClampedArea.

  • platform/graphics/filters/Filter.h:

(WebCore::Filter::maxEffectRect const): Deleted.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::requestedRegionOfInputPixelBuffer const): Deleted.
(WebCore::FilterEffect::drawingRegionOfInputImage const): Deleted.

  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterImage.cpp:

(WebCore::FilterImage::maxEffectRect const):
(WebCore::FilterImage::absoluteImageRectRelativeTo const):

  • platform/graphics/filters/FilterImage.h:
  • platform/graphics/filters/software/FEBlendSoftwareApplier.cpp:

(WebCore::FEBlendSoftwareApplier::apply):

  • platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp:

(WebCore::FEColorMatrixSoftwareApplier::apply):

  • platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp:

(WebCore::FEComponentTransferSoftwareApplier::apply):

  • platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:

(WebCore::FECompositeSoftwareApplier::applyArithmetic):
(WebCore::FECompositeSoftwareApplier::applyNonArithmetic):

  • platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:

(WebCore::FEConvolveMatrixSoftwareApplier::apply):

  • platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp:

(WebCore::FEDisplacementMapSoftwareApplier::apply):

  • platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp:

(WebCore::FEDropShadowSoftwareApplier::apply):

  • platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

(WebCore::FEGaussianBlurSoftwareApplier::apply):

  • platform/graphics/filters/software/FELightingSoftwareApplier.cpp:

(WebCore::FELightingSoftwareApplier::apply):

  • platform/graphics/filters/software/FEMergeSoftwareApplier.cpp:

(WebCore::FEMergeSoftwareApplier::apply):

  • platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:

(WebCore::FEMorphologySoftwareApplier::apply):

  • platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp:

(WebCore::FEOffsetSoftwareApplier::apply):

  • platform/graphics/filters/software/FETileSoftwareApplier.cpp:

(WebCore::FETileSoftwareApplier::apply):

  • rendering/CSSFilter.cpp:

(WebCore::CSSFilter::outputRect):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImageSoftwareApplier::apply):

9:04 PM Changeset in webkit [286171] by Jean-Yves Avenard
  • 10 edits in trunk

Avoid flattening a SharedBuffer when reading reading it through SharedBufferChunkReader.
https://bugs.webkit.org/show_bug.cgi?id=233481
rdar://problem/85733358

Source/WebCore:

Reviewed by Cameron McCormack

SharedBufferChunkReader required the SharedBuffer to be flattened which
would mutate the underlying SharedBuffer.
The peek method was also incorrect if the data read overlapped multiple
segments (it would return too many characters) and some members were used
without being initialised.

Additionally, add a similar read method in SharedBuffer that will be used
in bug 233030.

Covered in existing tests, API tests added.

  • Headers.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::getSomeData const):
(WebCore::SharedBuffer::getSegmentForPosition const):
(WebCore::SharedBuffer::read const):

  • platform/SharedBuffer.h:
  • platform/SharedBufferChunkReader.cpp:

(WebCore::SharedBufferChunkReader::SharedBufferChunkReader):
(WebCore::SharedBufferChunkReader::nextChunk):
(WebCore::SharedBufferChunkReader::peek):

  • platform/SharedBufferChunkReader.h:

Tools:

Reviewed by Cameron McCormack.

Add API tests.
API tests original data come from the original bug that added
SharedBufferChunkReader (bug 59946) and then expanded.

  • TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:

(TestWebKitAPI::TEST_F):
(TestWebKitAPI::readAllChunks):
(TestWebKitAPI::checkChunks):
(TestWebKitAPI::checkDataInRange):

  • TestWebKitAPI/Tests/WebCore/SharedBufferTest.h:
8:15 PM Changeset in webkit [286170] by Lauro Moura
  • 2 edits in trunk/Tools

[GTK] Gardening API test authentication-success flaky timeout

Unreviewed test gardening.

  • TestWebKitAPI/glib/TestExpectations.json:
1:14 PM Changeset in webkit [286169] by Antti Koivisto
  • 10 edits in trunk

[:has() pseudo-class] Invalidation support for adding and removing nodes
https://bugs.webkit.org/show_bug.cgi?id=233489

Reviewed by Alan Bujtas.

LayoutTests/imported/w3c:

Add some additional cases to an existing test.

  • web-platform-tests/css/selectors/invalidation/attribute-or-elemental-selectors-in-has-expected.txt:
  • web-platform-tests/css/selectors/invalidation/attribute-or-elemental-selectors-in-has.html:

Source/WebCore:

We need to invalidate style when added or removed elements match :has() arguments.

This patch adds tag name invalidation rulesets for :has() case, along with the existing class
and attribute rulesets. It is still missing support for #id invalidation.

  • style/ChildChangeInvalidation.cpp:

(WebCore::Style::ChildChangeInvalidation::ChildChangeInvalidation):

See if we need to invalidate for the elements being removed before the mutation.

(WebCore::Style::ChildChangeInvalidation::~ChildChangeInvalidation):

See if we need to invalidate for the elements being added after the mutation.

(WebCore::Style::ChildChangeInvalidation::invalidateForChangedElement):

Find the relevant invalidation rulesets for attributes, classes and tags and invalidate using them.

(WebCore::Style::needsTraversal):

We only need to do anything in the presence of :has() rules.

(WebCore::Style::needsDescendantTraversal):

Full traversal is only needed in case there are :has() rules using descendant combinator.

(WebCore::Style::ChildChangeInvalidation::traverseRemovedElements):
(WebCore::Style::ChildChangeInvalidation::traverseAddedElements):

  • style/ChildChangeInvalidation.h:
  • style/RuleFeature.cpp:

(WebCore::Style::isHasPseudoClassMatchElement):
(WebCore::Style::RuleFeatureSet::recursivelyCollectFeaturesFromSelector):
(WebCore::Style::RuleFeatureSet::collectFeatures):

Collect tag invalidation rulesets for :has case only.

(WebCore::Style::RuleFeatureSet::add):
(WebCore::Style::RuleFeatureSet::clear):
(WebCore::Style::RuleFeatureSet::shrinkToFit):

  • style/RuleFeature.h:

(WebCore::Style::RuleFeatureSet::usesMatchElement const):
(WebCore::Style::RuleFeatureSet::setUsesMatchElement):

Keep track of what sort of match elements are being used.

  • style/StyleScopeRuleSets.cpp:

(WebCore::Style::ScopeRuleSets::collectFeatures const):
(WebCore::Style::ScopeRuleSets::tagInvalidationRuleSets const):

  • style/StyleScopeRuleSets.h:
7:24 AM Changeset in webkit [286168] by weinig@apple.com
  • 25 edits
    19 copies
    9 adds in trunk

[CSS Color 4] Add support for new srgb-linear, xyz-d50 and xyz-d65 colorspaces
https://bugs.webkit.org/show_bug.cgi?id=233475

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Update existing color(xyz ...) tests for new d65 whitepoint and add new tests
for color(srgb-linear ...), color(xyz-d50 ...) and color(xyz-d65 ...).

  • web-platform-tests/css/css-color/predefined-016.html:
  • web-platform-tests/css/css-color/srgb-linear-001-expected.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-001.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-002-expected.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-002.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-003-expected.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-003.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-004-expected.html: Added.
  • web-platform-tests/css/css-color/srgb-linear-004.html: Added.
  • web-platform-tests/css/css-color/xyz-001.html:
  • web-platform-tests/css/css-color/xyz-003-expected.html:
  • web-platform-tests/css/css-color/xyz-003.html:
  • web-platform-tests/css/css-color/xyz-004-expected.html:
  • web-platform-tests/css/css-color/xyz-004.html:
  • web-platform-tests/css/css-color/xyz-005.html:
  • web-platform-tests/css/css-color/xyz-d50-001-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-001.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-002-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-002.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-003-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-003.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-004-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-004.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-005-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d50-005.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-001-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-001.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-002-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-002.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-003-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-003.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-004-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-004.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-005-expected.html: Added.
  • web-platform-tests/css/css-color/xyz-d65-005.html: Added.

Source/WebCore:

Updates existing tests to add cases for the new colorspaces.

  • Adds support for color(srgb-linear ...), color(xyz-d50 ...) and color(xyz-d65 ...)
  • Updates color(xyz ...) to be an alias of color(xyz-d65 ...), which is a breaking change both because previously it used the d50 white point and because we now serialize it as color(xyz-d65 ...). We think this is acceptable as we just shipped the feature and no other browsers yet support it.
  • Adds support for color-mix(in xyz-d50, ...) and color-mix(in xyz-d65, ...).
  • Updates color-mix(in xyz, ...) to use the d65 white point (like above). We have not shipped color-mix enabled, so this should even less controvertial.
  • css/CSSValueKeywords.in:

Add new keywords.

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseRelativeColorFunctionForRGBTypes):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForRGBTypes):
(WebCore::CSSPropertyParserHelpers::parseColorFunctionForXYZTypes):
(WebCore::CSSPropertyParserHelpers::parseRelativeColorFunctionForXYZTypes):
(WebCore::CSSPropertyParserHelpers::parseRelativeColorFunctionParameters):
(WebCore::CSSPropertyParserHelpers::parseNonRelativeColorFunctionParameters):
(WebCore::CSSPropertyParserHelpers::consumeColorMixColorSpaceAndComma):
(WebCore::CSSPropertyParserHelpers::mixColorComponents):
Add/update parsing support for new/updated colorspaces. parseColorFunctionForXYZTypes
is now templatized like parseColorFunctionForRGBTypes to allow reusing it for each
of the XYZ types.

  • platform/graphics/ColorSpace.h:

(WebCore::callWithColorType):

  • platform/graphics/ColorSpace.cpp:

(WebCore::operator<<):

  • platform/graphics/ColorConversion.cpp:

(WebCore::converColorComponents):
Add new "named" colorspace, XYZ_D65, so that color(xyz-d65 ...) can be piped through
and serialized correctly. We already had a name for srgb-linear (though it was not
possible to create it from css previously) so no new name was needed for it.

  • platform/graphics/ColorSerialization.cpp:

(WebCore::serialization):
(WebCore::serializationForCSS):
(WebCore::serializationForHTML):
(WebCore::serializationForRenderTreeAsText):
Add serialization specialization for xyz-d50/xyz-d65 and update name of LinearSRGBA
to "srgb-linear" to match the now defined name in css.

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::Color::createAndLosslesslyConvertToSupportedColorSpace):

  • platform/graphics/cg/ColorSpaceCG.cpp:

(WebCore::xyzD50ColorSpaceRef):
(WebCore::colorSpaceForCGColorSpace):
(WebCore::xyzColorSpaceRef): Deleted.

  • platform/graphics/cg/ColorSpaceCG.h:

(WebCore::cachedNullableCGColorSpace):
Updates xyzColorSpaceRef() function to be named xyzD50ColorSpaceRef() to more accurately
state what it is. It is not yet clear how or if an xyz-d65 colorspace can be created in
CoreGraphics, so we return nullptr when requested. This does not change any rendered values
as we can convert to extended-srgb in that case (as we do with lab and lch) without any loss.

LayoutTests:

Update tests for new srgb-linear, xyz-d50 and xyz-d65 colorspaces

  • fast/css/parsing-color-function-expected.txt:
  • fast/css/parsing-color-function.html:
  • fast/css/parsing-color-mix-expected.txt:
  • fast/css/parsing-color-mix.html:
  • fast/css/parsing-relative-color-syntax-expected.txt:
  • fast/css/parsing-relative-color-syntax.html:
5:22 AM Changeset in webkit [286167] by commit-queue@webkit.org
  • 17 edits
    3 moves
    2 adds
    1 delete in trunk

GraphicsContextGL implementations should have separate class definitions
https://bugs.webkit.org/show_bug.cgi?id=233491

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-11-25
Reviewed by Antti Koivisto.

Source/WebCore:

Add new concrete classes GraphicsContextGLCocoa and
GraphicsContextGLTextureMapper.
In the future, the platform-specific functionality can be moved
to these classes, reducing the GraphicsContextGLOpenGL #ifdefs.

No new tests, a refactor.

  • Modules/webxr/WebXROpaqueFramebuffer.cpp:

(WebCore::WebXROpaqueFramebuffer::startFrame):
(WebCore::WebXROpaqueFramebuffer::endFrame):

  • PlatformMac.cmake:
  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/TextureMapper.cmake:
  • platform/graphics/cocoa/GraphicsContextGLCocoa.h: Added.
  • platform/graphics/cocoa/GraphicsContextGLCocoa.mm: Renamed from Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm.

(WebCore::GraphicsContextGLCocoa::create):
(WebCore::GraphicsContextGLCocoa::displayBuffer):
(WebCore::GraphicsContextGLCocoa::markDisplayBufferInUse):
(WebCore::GraphicsContextGLCocoa::GraphicsContextGLCocoa):
(WebCore::GraphicsContextGLCocoa::isValid const):
(WebCore::GraphicsContextGLCocoa::createPbufferAndAttachIOSurface):
(WebCore::GraphicsContextGLCocoa::destroyPbufferAndDetachIOSurface):
(WebCore::GraphicsContextGLCocoa::attachIOSurfaceToSharedTexture):
(WebCore::GraphicsContextGLCocoa::detachIOSurfaceFromSharedTexture):

  • platform/graphics/cocoa/WebProcessGraphicsContextGLCocoa.mm: Renamed from Source/WebCore/platform/graphics/cocoa/WebProcessGraphicsContextGLOpenGLCocoa.mm.

(WebCore::GraphicsContextGLOpenGL::create):

  • platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:

(WebCore::GraphicsContextGLOpenGL::isValid const): Deleted.

  • platform/graphics/opengl/GraphicsContextGLOpenGL.h:
  • platform/graphics/opengl/GraphicsContextGLOpenGLBase.cpp:

(WebCore::GraphicsContextGLOpenGL::reshapeFBOs):

  • platform/graphics/texmap/GraphicsContextGLTextureMapper.cpp:

(WebCore::GraphicsContextGLTextureMapper::create):
(WebCore::GraphicsContextGLTextureMapper::GraphicsContextGLTextureMapper):
(WebCore::GraphicsContextGLOpenGL::create):

  • platform/graphics/texmap/GraphicsContextGLTextureMapper.h: Added.

Source/WebKit:

Use the new concrete classes GraphicsContextGLCocoa and
GraphicsContextGLTextureMapper in GPUP WebGL implemetation.

Remove GPUProcessGraphicsContextGL as the added functionality is
now in the GraphicsContextGLCocoa.

  • GPUProcess/graphics/GPUProcessGraphicsContextGL.h: Removed.
  • GPUProcess/graphics/RemoteGraphicsContextGL.h:
  • GPUProcess/graphics/RemoteGraphicsContextGLCocoa.cpp:

(WebKit::RemoteGraphicsContextGLCocoa::platformWorkQueueInitialize):

  • GPUProcess/graphics/RemoteGraphicsContextGLWin.cpp:

(WebKit::RemoteGraphicsContextGLWin::platformWorkQueueInitialize):

  • WebKit.xcodeproj/project.pbxproj:

Tools:

Adjust TestGraphicsContextGLOpenGLCocoa to
TestGraphicsContextGLCocoa after GraphicsContextGLOpenGL
Cocoa variant rename to GraphicsContextGLCocoa.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLCocoa.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLOpenGLCocoa.mm.

(TestWebKitAPI::createDefaultTestContext):
(TestWebKitAPI::changeContextContents):
(TestWebKitAPI::TEST_F):

4:34 AM Changeset in webkit [286166] by eocanha@igalia.com
  • 2 edits in trunk/Source/WebCore

[GStreamer][WPE] Use WPE_SHELL_MEDIA_DISK_CACHE_PATH env var to customize media disk cache path
https://bugs.webkit.org/show_bug.cgi?id=233477

Reviewed by Xabier Rodriguez-Calvar.

"/var/tmp" isn't always the best place to store the media download cache generated by GstDownloadBuffer
on embedded platforms. Each of those downloads can hold up to a whole movie (Gigabytes) and "/var/tmp"
is sometimes a memory based tmpfs. Some way to control the cache path is needed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Honor environment variable.
4:02 AM Changeset in webkit [286165] by eocanha@igalia.com
  • 5 edits in trunk/LayoutTests

[GTK] Layout Test http/tests/media/video-play-waiting.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=142489

Reviewed by Philippe Normand.

The test was failing with a timeout even after properly calling TestRunner.notifyDone()
internally because there was still an injectedBundle.topLoadingFrame() in InjectedBundlePage,
which means that the web page hadn't completely finished to be downloaded. This was caused
by the stalled video download that the test wants to exercise.

The solution is to set the video src to empty in order to convince TestRunner that the page
has finished downloading.

  • http/tests/media/video-play-waiting.html: Set the video src to empty.
  • platform/mac/TestExpectations: The test now just fails (for reasons unrelated to this fix) on mac instead of timing out.
  • platform/glib/TestExpectations: Unskipped test.
  • platform/win/TestExpectations: Unskipped test.
3:44 AM Changeset in webkit [286164] by Said Abou-Hallawa
  • 67 edits
    1 copy in trunk/Source/WebCore

[GPU Process] Make FilterEffect appliers take FilterImages in their apply() methods
https://bugs.webkit.org/show_bug.cgi?id=233487

Reviewed by Cameron McCormack.

Eventually the FilterImage will be removed from FilterEffect. So this is
a step towards making the FilterEffect hold the effect data only. To do
his change, FilterImage needs to hold two new members: primitiveSubregion
and isAlphaImage.

FilterEffect::setIsAlphaImage() is not needed and isAlphaImage() will be
a virtual function but it will be renamed resultIsAlphaImage(). The result
of this function will be stored in the result FilterImage.

FEGaussianBlurSoftwareApplier::apply() is the only user of isAlphaImage.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::resultIsAlphaImage const):
(WebCore::FEColorMatrix::platformApplySoftware):

  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:

(WebCore::FEComponentTransfer::platformApplySoftware):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/FEConvolveMatrix.cpp:

(WebCore::FEConvolveMatrix::platformApplySoftware):

  • platform/graphics/filters/FEDisplacementMap.cpp:

(WebCore::FEDisplacementMap::platformApplySoftware):

  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

  • platform/graphics/filters/FEFlood.cpp:

(WebCore::FEFlood::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::FEGaussianBlur::resultIsAlphaImage const):
(WebCore::FEGaussianBlur::platformApplySoftware):

  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::platformApplySoftware):

  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

  • platform/graphics/filters/FEMorphology.cpp:

(WebCore::FEMorphology::resultIsAlphaImage const):
(WebCore::FEMorphology::platformApplySoftware):

  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::resultIsAlphaImage const):
(WebCore::FEOffset::platformApplySoftware):

  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::resultIsAlphaImage const):
(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::platformApplySoftware):

  • platform/graphics/filters/Filter.h:

(WebCore::Filter::maxEffectRect const):

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::apply):
(WebCore::FilterEffect::inputFilterImages const):
(WebCore::FilterEffect::externalRepresentation const):
(WebCore::FilterEffect::createResult): Deleted.
(WebCore::FilterEffect::imageBufferResult): Deleted.
(WebCore::FilterEffect::pixelBufferResult): Deleted.
(WebCore::FilterEffect::getPixelBufferResult): Deleted.
(WebCore::FilterEffect::copyPixelBufferResult const): Deleted.

  • platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::filterImage const):
(WebCore::FilterEffect::resultIsAlphaImage const):
(WebCore::FilterEffect::isAlphaImage const): Deleted.
(WebCore::FilterEffect::setIsAlphaImage): Deleted.
(WebCore::FilterEffect::normalizedFloats): Deleted.

  • platform/graphics/filters/FilterEffectApplier.h:
  • platform/graphics/filters/FilterImage.cpp:

(WebCore::FilterImage::create):
(WebCore::FilterImage::FilterImage):

  • platform/graphics/filters/FilterImage.h:

(WebCore::FilterImage::primitiveSubregion const):
(WebCore::FilterImage::isAlphaImage const):

  • platform/graphics/filters/FilterImageVector.h: Copied from Source/WebCore/platform/graphics/filters/FilterEffectApplier.h.
  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::platformApplySoftware):

  • platform/graphics/filters/software/FEBlendSoftwareApplier.cpp:

(WebCore::FEBlendSoftwareApplier::apply):

  • platform/graphics/filters/software/FEBlendSoftwareApplier.h:
  • platform/graphics/filters/software/FEColorMatrixSoftwareApplier.cpp:

(WebCore::FEColorMatrixSoftwareApplier::apply):

  • platform/graphics/filters/software/FEColorMatrixSoftwareApplier.h:
  • platform/graphics/filters/software/FEComponentTransferSoftwareApplier.cpp:

(WebCore::FEComponentTransferSoftwareApplier::apply):

  • platform/graphics/filters/software/FEComponentTransferSoftwareApplier.h:
  • platform/graphics/filters/software/FECompositeSoftwareApplier.cpp:

(WebCore::FECompositeSoftwareApplier::applyArithmetic):
(WebCore::FECompositeSoftwareApplier::applyNonArithmetic):
(WebCore::FECompositeSoftwareApplier::apply):

  • platform/graphics/filters/software/FECompositeSoftwareApplier.h:
  • platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.cpp:

(WebCore::FEConvolveMatrixSoftwareApplier::apply):

  • platform/graphics/filters/software/FEConvolveMatrixSoftwareApplier.h:
  • platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.cpp:

(WebCore::FEDisplacementMapSoftwareApplier::apply):

  • platform/graphics/filters/software/FEDisplacementMapSoftwareApplier.h:
  • platform/graphics/filters/software/FEDropShadowSoftwareApplier.cpp:

(WebCore::FEDropShadowSoftwareApplier::apply):

  • platform/graphics/filters/software/FEDropShadowSoftwareApplier.h:
  • platform/graphics/filters/software/FEFloodSoftwareApplier.cpp:

(WebCore::FEFloodSoftwareApplier::apply):

  • platform/graphics/filters/software/FEFloodSoftwareApplier.h:
  • platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.cpp:

(WebCore::FEGaussianBlurSoftwareApplier::apply):

  • platform/graphics/filters/software/FEGaussianBlurSoftwareApplier.h:
  • platform/graphics/filters/software/FELightingSoftwareApplier.cpp:

(WebCore::FELightingSoftwareApplier::apply):

  • platform/graphics/filters/software/FELightingSoftwareApplier.h:
  • platform/graphics/filters/software/FEMergeSoftwareApplier.cpp:

(WebCore::FEMergeSoftwareApplier::apply):

  • platform/graphics/filters/software/FEMergeSoftwareApplier.h:
  • platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:

(WebCore::FEMorphologySoftwareApplier::apply):

  • platform/graphics/filters/software/FEMorphologySoftwareApplier.h:
  • platform/graphics/filters/software/FEOffsetSoftwareApplier.cpp:

(WebCore::FEOffsetSoftwareApplier::apply):

  • platform/graphics/filters/software/FEOffsetSoftwareApplier.h:
  • platform/graphics/filters/software/FETileSoftwareApplier.cpp:

(WebCore::FETileSoftwareApplier::apply):

  • platform/graphics/filters/software/FETileSoftwareApplier.h:
  • platform/graphics/filters/software/FETurbulenceSoftwareApplier.cpp:

(WebCore::FETurbulenceSoftwareApplier::apply):

  • platform/graphics/filters/software/FETurbulenceSoftwareApplier.h:
  • platform/graphics/filters/software/SourceAlphaSoftwareApplier.cpp:

(WebCore::SourceAlphaSoftwareApplier::apply):

  • platform/graphics/filters/software/SourceAlphaSoftwareApplier.h:
  • platform/graphics/filters/software/SourceGraphicSoftwareApplier.cpp:

(WebCore::SourceGraphicSoftwareApplier::apply):

  • platform/graphics/filters/software/SourceGraphicSoftwareApplier.h:
  • rendering/CSSFilter.cpp:

(WebCore::CSSFilter::output):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImageSoftwareApplier::apply):
(WebCore::FEImage::platformApplySoftware):

1:58 AM Changeset in webkit [286163] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.35.1

WebKitGTK 2.35.1

1:57 AM Changeset in webkit [286162] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.1 release

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.35.1.
1:27 AM Changeset in webkit [286161] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

Unreviewed. Fix GTK distcheck build

Remove platform specific file from cross-platform makefile.

  • CMakeLists.txt: Add WebCoreTestSupport_PRIVATE_HEADERS and use it in WEBKIT_COPY_FILES.
  • PlatformMac.cmake: Append testing/cocoa/WebArchiveDumpSupport.h to WebCoreTestSupport_PRIVATE_HEADERS.
1:17 AM Changeset in webkit [286160] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

ANGLE Metal: The memory backing IOSurfaces of former client buffer pbuffers is leaked
https://bugs.webkit.org/show_bug.cgi?id=233328
<rdar://problem/85563187>

Patch by Kimmo Kinnunen <kkinnunen@apple.com> on 2021-11-25
Reviewed by Antti Koivisto.

Source/WebCore:

Fix a bug where recycling GraphicsContextGLOpenGL display buffers would
leak the spare buffer pbuffer handle. This would happen if the
display buffer was marked as "in use", so that the IOSurface reference
would be dropped immediately in order to not use it as next drawing buffer.
However, the IOSurface is still bound in ANGLE and as such, the pbuffer handle
must be returned during GraphicsContextGLIOSurfaceSwapChain::recycleBuffer`
call.

Adds API tests for testing the leak.

  • platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.cpp:

(WebCore::GraphicsContextGLIOSurfaceSwapChain::recycleBuffer):
(WebCore::GraphicsContextGLIOSurfaceSwapChain::present):

Source/WebCore/PAL:

Add prototype for IOSurfaceIncrementUseCount.
Currently used for a test, in simulating CA behavior.

  • pal/spi/cocoa/IOSurfaceSPI.h:

Tools:

Add tests testing Cocoa GraphicsContextGLOpenGL drawing buffer
recycling behavior.

  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • TestWebKitAPI/Sources.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/ImageBufferTests.cpp:

(TestWebKitAPI::imageBufferPixelIs):
(TestWebKitAPI::memoryFootprintChangedBy): Deleted.

  • TestWebKitAPI/Tests/WebCore/cocoa/TestGraphicsContextGLOpenGLCocoa.mm:

(TestWebKitAPI::createDefaultTestContext):
(TestWebKitAPI::changeContextContents):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/TestUtilities.h: Added.
  • TestWebKitAPI/TestUtilities.cpp: Added.

Add few useful functions to TestUtilities.h so that different
tests can use them.

Note: See TracTimeline for information about the timeline view.