Timeline


and

04/02/15: Today

01:51 Changeset [182270] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

[CSS MultiColumn] Parse "columns: auto <length>" shorthand property value properly
https://bugs.webkit.org/show_bug.cgi?id=143248

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-04-02
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/multicol/columns-shorthand-parsing-2.html

The two longhands for the 'columns' property ('column-count' and
'column-width') may both take 'auto' as a value. When we encounter
'auto' during parsing the value list of a declaration, we cannot just
make a guess at which property/properties that's meant for. Instead,
don't assign anything to 'auto' right away, but wait until all values
have been processed and at that point set the still unassigned
properties to 'auto'. If 'auto' isn't in the value list at all, set
unassigned properties to 'initial' for the 'columns' property, just
like we do for any other property.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseColumnWidth):
(WebCore::CSSParser::parseColumnCount):
(WebCore::CSSParser::parseColumnsShorthand):

  • css/CSSParser.h:

LayoutTests:

  • fast/css/getPropertyValue-columns-expected.txt:
  • fast/css/getPropertyValue-columns.html:
  • fast/multicol/columns-shorthand-parsing-2-expected.txt: Added.
  • fast/multicol/columns-shorthand-parsing-2.html: Added.

04/01/15: Yesterday

23:29 Changeset [182269] by ap@apple.com
  • 2 edits in trunk/Tools

filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
https://bugs.webkit.org/show_bug.cgi?id=143282

Reviewed by Daniel Bates.

  • Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
23:28 Changeset [182268] by ap@apple.com
  • 5 edits in trunk/Tools

When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
https://bugs.webkit.org/show_bug.cgi?id=143240
rdar://problem/19990425

Reviewed by Tim Horton.

  • DumpRenderTree/mac/LayoutTestHelper.m:

(colorProfileURLForDisplay):
(saveDisplayColorProfiles):
Gracefully handle it when the current profile cannot be retrieved, fixing at
least one case when LayoutTestHelper couldn't start.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._set_up_run):
(Manager._force_pixel_tests_if_needed):

  • Scripts/webkitpy/port/base.py: (Port.to.start_helper):
  • Scripts/webkitpy/port/mac.py: (MacPort.start_helper):

Return and check an error from start_helper().

22:58 Changeset [182267] by cdumez@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2][Cocoa] Add didFailProvisionalLoadWithErrorForFrame callback to WKWebProcessPlugInLoadDelegate
https://bugs.webkit.org/show_bug.cgi?id=143319
<rdar://problem/19463834>

Reviewed by Dan Bernstein.

Add didFailProvisionalLoadWithErrorForFrame callback to
WKWebProcessPlugInLoadDelegate so that the client side can track all
types page load completions:

  • didFailProvisionalLoadWithErrorForFrame
  • didFailLoadWithErrorForFrame
  • didFinishLoadForFrame

Note that this event is already exposed on UIProcess side via the
WKPageLoaderClient.didFailLoadWithErrorForFrame callback.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didFailProvisionalLoadWithErrorForFrame):
(setUpPageLoaderClient):

17:22 Changeset [182266] by commit-queue@webkit.org
  • 24 edits
    4 deletes in trunk

Unreviewed, rolling out r182247.
https://bugs.webkit.org/show_bug.cgi?id=143326

unfortunately broke some tests (Requested by dino on #webkit).

Reverted changeset:

"Async loading of image resources"
https://bugs.webkit.org/show_bug.cgi?id=134488
http://trac.webkit.org/changeset/182247

17:16 Changeset [182265] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Content Extensions] Only add unique universal action locations.
https://bugs.webkit.org/show_bug.cgi?id=143325

Reviewed by Benjamin Poulain.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):
Use a HashSet instead of a Vector for the universal action locations to remove duplicates.

16:59 Changeset [182264] by dino@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/mouse-cursor-image-set.html is timing out on Apple platforms
https://bugs.webkit.org/show_bug.cgi?id=143323

Removing old flakiness setting now that we should be skipping.

  • platform/mac/TestExpectations:
16:47 Changeset [182263] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebCore

Fixes to material of inline media controls on OSX.
https://bugs.webkit.org/show_bug.cgi?id=143317
<rdar://problem/20357847>

Reviewed by Dean Jackson.

There are many existing tests for the media controls appearance.
They are currently skipped while we are still updating the controls.

Expand backgrounds of control panel and volume box.
Clip the darker edges away.

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel):
(audio::-webkit-media-controls-panel-background-container):
(audio::-webkit-media-controls-panel-tint):
(audio::-webkit-media-controls-panel-background):
(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-volume-slider-container-background):
(audio::-webkit-media-controls-volume-slider-container-tint):
(audio::-webkit-media-controls-panel .volume-box:active):
(video::-webkit-media-controls-volume-slider):
This needs to be above the background so it can be interacted with.
(video:-webkit-full-screen::-webkit-media-controls-panel .volume-box):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls): Create a new div for the control material.
We need to clip the material and not the controls themselves.
(Controller.prototype.configureInlineControls): Use new div.
Remove some unnecessary logic involving hiding materials here.
It just causes the materials to turn on and off at the wrong times.
(Controller.prototype.handlePanelTransitionEnd):
(Controller.prototype.setPlaying):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):

16:43 Changeset [182262] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Media controls should not always auto-hide
https://bugs.webkit.org/show_bug.cgi?id=143322

Reviewed by Dean Jackson.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller): Intialize new properties.
(Controller.prototype.hideControls): Do nothing if controlsAlwaysVisible() returns true;
(Controller.prototype.controlsAlwaysVisible): New.
(Controller.prototype.controlsAreHidden): Consult controlsAlwaysVisible().
(Controller.prototype.currentPlaybackTargetIsWireless): Use new properties.
(Controller.prototype.updateWirelessTargetAvailable): Cache video.webkitCurrentPlaybackTargetIsWireless

and video.webkitWirelessVideoPlaybackDisabled because we know when they change and
use them frequently.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.controlsAlwaysVisible): New.

  • platform/graphics/MediaPlaybackTarget.h:
16:43 Changeset [182261] by bfulgham@apple.com
  • 2 edits in trunk/Tools

[Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
https://bugs.webkit.org/show_bug.cgi?id=143321

Reviewed by Alexey Proskuryakov.

  • EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
16:22 Changeset [182260] by enrica@apple.com
  • 22 edits
    3 adds in trunk

Injected bundle messages should be at the page level.
https://bugs.webkit.org/show_bug.cgi?id=143283

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

All the messages between the injected bundle and the UI
process should be page level messages instead of context.
The author of this patch is Tim Horton, I just finished it.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageInjectedBundleClient):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPageInjectedBundleClient.h: Added.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pageForTesting]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/WebPageInjectedBundleClient.cpp: Added.

(WebKit::WebPageInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebPageInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):

  • UIProcess/WebPageInjectedBundleClient.h: Added.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setInjectedBundleClient):
(WebKit::WebPageProxy::handleMessage):
(WebKit::WebPageProxy::handleSynchronousMessage):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::injectedBundleClient):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::handleMessage):

  • WebKit2.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePagePostMessage):
(WKBundlePagePostSynchronousMessage):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::postMessage):
(WebKit::WebPage::postSynchronousMessage):

  • WebProcess/WebPage/WebPage.h:

Tools:

Updating WebKitTestRunner to use the new page level messaging.
The author of this patch is Tim Horton, I just finished it.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::mouseDown):
(WTR::EventSendingController::mouseUp):
(WTR::EventSendingController::mouseMoveTo):
(WTR::EventSendingController::leapForward):
(WTR::EventSendingController::scheduleAsynchronousClick):
(WTR::EventSendingController::keyDown):
(WTR::EventSendingController::scheduleAsynchronousKeyDown):
(WTR::EventSendingController::mouseScrollBy):
(WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSendingController::continuousMouseScrollBy):
(WTR::EventSendingController::addTouchPoint):
(WTR::EventSendingController::updateTouchPoint):
(WTR::EventSendingController::setTouchModifier):
(WTR::EventSendingController::setTouchPointRadius):
(WTR::EventSendingController::touchStart):
(WTR::EventSendingController::touchMove):
(WTR::EventSendingController::touchEnd):
(WTR::EventSendingController::touchCancel):
(WTR::EventSendingController::clearTouchPoints):
(WTR::EventSendingController::releaseTouchPoint):
(WTR::EventSendingController::cancelTouchPoint):

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessage):
(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::done):
(WTR::InjectedBundle::outputText):
(WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
(WTR::InjectedBundle::postAddChromeInputField):
(WTR::InjectedBundle::postRemoveChromeInputField):
(WTR::InjectedBundle::postFocusWebView):
(WTR::InjectedBundle::postSetBackingScaleFactor):
(WTR::InjectedBundle::postSetWindowIsKey):
(WTR::InjectedBundle::postSimulateWebNotificationClick):
(WTR::InjectedBundle::postSetAddsVisitedLinks):
(WTR::InjectedBundle::setGeolocationPermission):
(WTR::InjectedBundle::setMockGeolocationPosition):
(WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
(WTR::InjectedBundle::setUserMediaPermission):
(WTR::InjectedBundle::setCustomPolicyDelegate):
(WTR::InjectedBundle::setHidden):
(WTR::InjectedBundle::setCacheModel):
(WTR::InjectedBundle::shouldProcessWorkQueue):
(WTR::InjectedBundle::processWorkQueue):
(WTR::InjectedBundle::queueBackNavigation):
(WTR::InjectedBundle::queueForwardNavigation):
(WTR::InjectedBundle::queueLoad):
(WTR::InjectedBundle::queueLoadHTMLString):
(WTR::InjectedBundle::queueReload):
(WTR::InjectedBundle::queueLoadingScript):
(WTR::InjectedBundle::queueNonLoadingScript):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setHandlesAuthenticationChallenges):
(WTR::TestRunner::setAuthenticationUsername):
(WTR::TestRunner::setAuthenticationPassword):
(WTR::TestRunner::secureEventInputIsEnabled):
(WTR::TestRunner::setBlockAllPlugins):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::resetStateToConsistentValues):
(WTR::TestController::didReceivePageMessageFromInjectedBundle):
(WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

15:50 Changeset [182259] by ap@apple.com
  • 10 edits in trunk/Source/WebKit2

[iOS] WebContent should have access to the entirety of its caches directory
https://bugs.webkit.org/show_bug.cgi?id=143312
rdar://problem/20314916

Reviewed by Oliver Hunt.

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode):
(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::networkingCachesDirectory):
(WebKit::WebProcessPool::webContentCachesDirectory):
(WebKit::WebProcessPool::openGLCacheDirectory): Deleted.
(WebKit::WebProcessPool::networkingHSTSDatabasePath): Deleted.
(WebKit::WebProcessPool::webContentHSTSDatabasePath): Deleted.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):
(WebKit::WebProcessPool::createNewWebProcess):

  • UIProcess/WebProcessPool.h:
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

15:48 Changeset [182258] by dino@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/mouse-cursor-image-set.html is timing out on Apple platforms
https://bugs.webkit.org/show_bug.cgi?id=143323

The change r182247 has caused this test to timeout. Rather than rollout
the commit I'm skipping the test and will contact Yoav.

  • platform/mac/TestExpectations:
15:37 Changeset [182257] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.25/Source/WebCore

Merged r182255. rdar://problem/19130597

15:13 Changeset [182256] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r182121): SVG animation macros cause warnings in MSVC
https://bugs.webkit.org/show_bug.cgi?id=143313

Reviewed by Darin Adler.

  • svg/SVGExternalResourcesRequired.h: Undo the change that caused a type mismatch.
14:26 Changeset [182255] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Another attempt to fixi the iOS build after r182240.

Reviewed by Dean Jackson.

  • platform/graphics/MediaPlaybackTarget.h:

(WebCore::MediaPlaybackTarget::hasActiveRoute):

14:01 Changeset [182254] by antti@apple.com
  • 2 edits in trunk/Source/WTF

015-04-01 Antti Koivisto <antti@apple.com>

Value assignment operator of Optional should be stricter
https://bugs.webkit.org/show_bug.cgi?id=143303

Reviewed by Andreas Kling.

struct Foo { mutable Optional<std::chrono::seconds> s; };
Foo foo, foo2;
foo = foo2;

doesn't build because it tries to use wrong operator=.

  • wtf/Optional.h:

Add enable_if test similar to std::experimental::optional.

12:58 Changeset [182253] by bshafiei@apple.com
  • 2 edits in tags/Safari-601.1.25/Source/WebCore

Merged r182250. rdar://problem/19130597

12:55 Changeset [182252] by dino@apple.com
  • 2 edits in trunk/LayoutTests

accessibility/textarea-selected-text-range.html failing on Windows WK1 Release
https://bugs.webkit.org/show_bug.cgi?id=143315

Removing clashing entry but changing the old entry to Skip.

  • platform/win/TestExpectations:
12:51 Changeset [182251] by bshafiei@apple.com
  • 27 edits in tags/Safari-601.1.25/Source/WebCore

Merged r182240. rdar://problem/19130597

12:49 Changeset [182250] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after r182240.

  • platform/graphics/MediaPlaybackTarget.h:
12:33 Changeset [182249] by dino@apple.com
  • 2 edits in trunk/LayoutTests

accessibility/textarea-selected-text-range.html failing on Windows WK1 Release
https://bugs.webkit.org/show_bug.cgi?id=143315

Skipping this on Windows.

  • platform/win/TestExpectations:
12:20 Changeset [182248] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Tools

Unreviewed, rolling out r182174 and r182177.
https://bugs.webkit.org/show_bug.cgi?id=143314

Try to correct EWS failures (Requested by bfulgham on
#webkit).

Reverted changesets:

"Python SCM should be able to retrieve untracked files"
https://bugs.webkit.org/show_bug.cgi?id=143135
http://trac.webkit.org/changeset/182174

"[buildbot] clean-build script should remove untracked files
and revert local changes too"
https://bugs.webkit.org/show_bug.cgi?id=142400
http://trac.webkit.org/changeset/182177

12:02 Changeset [182247] by yoav@yoav.ws
  • 24 edits
    4 adds in trunk

Async loading of image resources
https://bugs.webkit.org/show_bug.cgi?id=134488

Reviewed by Dean Jackson.

Source/WebCore:

This patch changes image loading to be asynchronous (per spec), in order
for it to be agnostic to property setting order when it comes to src, srcset and crossorigin,
as well as to enable future hooking of the <picture>-based selection logic on top of it.

Tests: fast/dom/HTMLImageElement/image-load-post-onload.html
fast/dom/HTMLImageElement/sizes/image-sizes-js-change-reverse.html

  • WebCore.xcodeproj/project.pbxproj: Change MicroTask.h to be private.
  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent): Add a microtask checkpoint after event handling.

  • bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::execute): Add a microtask checkpoint after running of a scheduled action.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished): Avoid a crash when notifyFinished is called and there's no CachedImage.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd): Add a microtask checkpoint.

  • loader/ImageLoader.cpp: Move image resource loading to be asynchronous.

(WebCore::ImageLoader::ImageLoaderTask::create):
(WebCore::ImageLoader::ImageLoaderTask::run): Run the image loading microtask and called doUpdateFromElement.
(WebCore::ImageLoader::ImageLoaderTask::ImageLoaderTask):
(WebCore::ImageLoader::ImageLoader):
(WebCore::ImageLoader::doUpdateFromElement): This is split from the previous updateFromElement, and performs the actual resource loading.
(WebCore::ImageLoader::updateFromElement): Now only prepares the stage for the actual image resource loading.
(WebCore::ImageLoader::shouldLoadImmediately): If this returns true, the image resource is loaded immediately, without queueing a microtask.
(WebCore::ImageLoader::notifyFinished): Add asserts.
(WebCore::ImageLoader::elementDidMoveToNewDocument): Handle document load event counters decrementing and incrementing.

  • loader/ImageLoader.h:

(WebCore::ImageLoader::imageComplete): Make sure that the image is complete only if there aren't any pending tasks.
(WebCore::ImageLoader::hasPendingActivity): Make sure that pending activity takes pending tasks into account.
(WebCore::ImageLoader::hasPendingTask): Getter to know if an ImageLoader has a pending task. (Used by the image loading microtask)
(WebCore::ImageLoader::createWeakPtr): Create a weakPtr to be used by the microtask, so it can called back the loader if it's still alive.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag and act upon it.
(WebCore::CachedResourceLoader::requestImage): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.
(WebCore::CachedResourceLoader::requestResource): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.

  • loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::canRequest): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag and act upon it.
(WebCore::CachedResourceLoader::requestImage): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.
(WebCore::CachedResourceLoader::requestResource): Add a 'shouldBypassMainWorldContentSecurityPolicy' flag.

  • svg/SVGImageElement.cpp:

(WebCore::SVGImageElement::didMoveToNewDocument): Add the old document to call of elementDidMoveToNewDocument.

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::end): Add a microtask checkpoint after XML finishes parsing.

LayoutTests:

  • fast/dom/HTMLImageElement/image-load-post-onload-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-load-post-onload.html: Added.
  • fast/dom/HTMLImageElement/image-loading-gc.html: Cosmetic changes.
  • fast/dom/HTMLImageElement/sizes/image-sizes-js-change-reverse-expected.txt: Added.
  • fast/dom/HTMLImageElement/sizes/image-sizes-js-change-reverse.html: Added.
  • fast/dom/image-object.html: Cosmetic changes.
  • http/tests/misc/image-blocked-src-change-expected.txt: Removed line numbers from console.
  • http/tests/misc/image-blocked-src-no-change-expected.txt: Removed line numbers from console.
  • http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed line numbers from console.
  • http/tests/security/frame-loading-via-document-write-expected.txt: Removed line numbers from console.
  • http/tests/security/local-image-from-remote-expected.txt: Removed line numbers from console.
12:00 Changeset [182246] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit/win

Fix Windows build.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient::numWheelEventHandlersChanged): Deleted.

11:57 Changeset [182245] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Smart magnification gesture sometimes shoots to the middle of the page
https://bugs.webkit.org/show_bug.cgi?id=143296
<rdar://problem/18209280>

Reviewed by Dean Jackson.

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::didCollectGeometryForSmartMagnificationGesture):
Constrain the target rect to the viewport, and if it had overflowed the viewport,
scroll halfway towards the gesture origin.

11:42 Changeset [182244] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix when using content extensions performance reporting.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):
Time how long it takes to build the DFAs.

11:36 Changeset [182243] by achristensen@apple.com
  • 35 edits
    1 add in trunk

Progress towards CMake on Windows and Mac.
https://bugs.webkit.org/show_bug.cgi?id=143293

Reviewed by Filip Pizlo.

.:

  • CMakeLists.txt:

Set DERIVED_SOURCES_WTF_DIR for Windows.

  • Source/CMakeLists.txt:

Don't compile bmalloc on Windows.

  • Source/cmake/OptionsCommon.cmake:

Use the absolute path of the C preprocessor.

  • Source/cmake/OptionsWinCairo.cmake:

Added needed definitions.

  • Source/cmake/OptionsWindows.cmake:

Set some default values and removed support for old Visual Studio versions before /MP.

  • Source/cmake/WebKitFS.cmake:

Make WTF DerivedSources directory.

  • Source/cmake/WebKitMacros.cmake:

Added ADD_PRECOMPILED_HEADER macro based on
http://stackoverflow.com/questions/148570/using-pre-compiled-headers-with-cmake

Source/bmalloc:

  • bmalloc/BAssert.h:

Removed ellipses from macros to appease Visual Studio.

Source/JavaScriptCore:

  • CMakeLists.txt:

Enabled using assembly on Windows.
Replaced unix commands with CMake commands.

  • PlatformMac.cmake:

Tell open source builders where to find unicode headers.

Source/ThirdParty/ANGLE:

  • include/GLES2/gl2.h:

Temporarily disabled WebGL on Windows CMake builds.

Source/WebCore:

  • PlatformMac.cmake:

Tell open source builders where to find unicode headers.

  • PlatformWin.cmake:

Include PlatformWinCairo.cmake.

  • PlatformWinCairo.cmake:

Added from bug 115944 by Patrick Gansterer.

  • bindings/js/JSDOMStringListCustom.cpp:
  • bindings/js/JSDOMWrapper.cpp:
  • bindings/js/JSMessageChannelCustom.cpp:
  • bindings/js/JSPopStateEventCustom.cpp:
  • bindings/js/JSReadableStreamCustom.cpp:
  • bindings/js/ReadableStreamJSSource.cpp:
  • bindings/js/ScriptController.cpp:
  • css/CSSComputedStyleDeclaration.cpp:
  • dom/Attr.cpp:
  • dom/CollectionIndexCache.cpp:
  • platform/graphics/ANGLEWebKitBridge.h:

Fixed include quirks.

Source/WebKit:

  • PlatformMac.cmake:

Fixed some include directories.

Source/WTF:

  • wtf/CMakeLists.txt:

Don't use bmalloc on Windows yet.

  • wtf/FeatureDefines.h:

Temporarily disabled WebGL on Windows CMake builds.

  • wtf/PlatformMac.cmake:

Tell open source builders where to find unicode headers.

11:30 Changeset [182242] by simon.fraser@apple.com
  • 29 edits in trunk

Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
https://bugs.webkit.org/show_bug.cgi?id=143288
rdar://problem/16049624

Reviewed by Beth Dakin.

Remove the wheel event counting that Document does, and passes into the scrolling tree.
The ScrollingTree now just uses the non-fast scrollable region to determine when to
fast scroll on pages with wheel event handlers.

If a handler includes position:fixed renderers, we just cover the whole document
with the slow-scrolling region currently. This could be improved.

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::wheelEventHandlersChanged):
(WebCore::Document::didAddWheelEventHandler):
(WebCore::Document::didRemoveWheelEventHandler):
(WebCore::Document::wheelEventHandlerCount):
(WebCore::Document::touchEventHandlerCount):
(WebCore::Document::absoluteRegionForEventTargets): Changed to return a pair<Region, bool>
where the bool indicates whether any handler includes position:fixed content.
(WebCore::pageWheelEventHandlerCountChanged): Deleted.
(WebCore::wheelEventHandlerCountChanged): Deleted.

  • dom/Document.h:

(WebCore::Document::wheelEventHandlerCount): Deleted.

  • loader/EmptyClients.h:
  • page/ChromeClient.h:
  • page/DebugPageOverlays.cpp:

(WebCore::MouseWheelRegionOverlay::updateRegion):

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView): Deleted.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::computeCurrentWheelEventHandlerCount): Deleted.
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged): Deleted.

  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView): Deleted.

  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::ScrollingStateFrameScrollingNode):
(WebCore::ScrollingStateFrameScrollingNode::setWheelEventHandlerCount): Deleted.

  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree):
(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::commitNewTreeState):

  • page/scrolling/ScrollingTree.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateTiledScrollingIndicator):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::updateBeforeChildren):
(WebCore::logWheelEventHandlerCountChanged): Deleted.

  • testing/Internals.cpp:

(WebCore::Internals::touchEventHandlerCount):

Source/WebKit/mac:
Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
https://bugs.webkit.org/show_bug.cgi?id=143288

Reviewed by Beth Dakin.

Remove the wheel event counting that Document does, and passes into the scrolling tree.
The ScrollingTree now just uses the non-fast scrollable region to determine when to
fast scroll on pages with wheel event handlers.

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit2:
Remove scrolling tree dependency on wheel event handler counts, and use fast scrolling even when there are wheel handlers
https://bugs.webkit.org/show_bug.cgi?id=143288
rdar://problem/16049624

Reviewed by Beth Dakin.

Remove the wheel event counting that Document does, and passes into the scrolling tree.
The ScrollingTree now just uses the non-fast scrollable region to determine when to
fast scroll on pages with wheel event handlers.

If a handler includes position:fixed renderers, we just cover the whole document
with the slow-scrolling region currently. This could be improved.

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateFrameScrollingNode>::encode):
(ArgumentCoder<ScrollingStateFrameScrollingNode>::decode):
(WebKit::RemoteScrollingTreeTextStream::dump):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::wheelEventHandlersChanged):
(WebKit::WebChromeClient::numWheelEventHandlersChanged): Deleted.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::wheelEventHandlersChanged):
(WebKit::WebPage::recomputeShortCircuitHorizontalWheelEventsState):
(WebKit::WebPage::numWheelEventHandlersChanged): Deleted.

  • WebProcess/WebPage/WebPage.h:

LayoutTests:
Make it possible to compute a region for elements on the page that have wheel event handlers
https://bugs.webkit.org/show_bug.cgi?id=142807

Reviewed by Beth Dakin.

Update results, since any handler with position:fixed now causes the region to cover the document.

  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt:
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt:
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt:
11:10 Changeset [182241] by hyatt@apple.com
  • 9 edits
    4 adds in trunk

[New Block-Inside-Inline Model] Floats need to be allowed to intrude into anonymous inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=143307

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/block/inside-inlines/basic-float-intrusion.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
Make sure to exclude the margins of an anonymous inline-block when considering the height of the line.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::baselinePosition):
Anonymous inline-block lines ignore line-height and just return the height of the block. For baseline position, the baseline
is considered to be at the bottom border edge of the anonymous inline-block.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::addIntrudingFloats):

  • rendering/RenderBlockFlow.h:

Patch float intrusion to handle the case of anonymous inline-blocks. Instead of collecting the floats from our parent(), we
collect them from the containingBlock() in the anonymous inline-block case. Patch addIntrudingFloats to pass in the container
that acts as the "parent", since it is not the parent() in the anonymous inline-block case.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalInlinePositions):
Make sure to use the full available width for content always in the anonymous inline-block case, since we don't avoid the
floats, but instead let them intrude into the inline-block.

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
Patch callers of updateLogicalInlinePositions to pass in the root line box that we're checking for.

(WebCore::RenderBlockFlow::layoutLineBoxes):
Defer the layout of anonymous inline-blocks, since they need to only lay out once the vertical position to lay them out
at is known.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::createsNewFormattingContext):
(WebCore::RenderBox::avoidsFloats):
Anonymous inline-blocks do not establish a new block formatting context, nor do they avoid floats.

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleReplaced):
Add code to do a just-in-time layout of the anonymous inline-block at the time it is being examined (after the break before
it was handled).

LayoutTests:

  • fast/block/inside-inlines/basic-float-intrusion-expected.html: Added.
  • fast/block/inside-inlines/basic-float-intrusion.html: Added.
  • fast/block/inside-inlines/new-model/basic-float-intrusion-expected.html: Added.
  • fast/block/inside-inlines/new-model/basic-float-intrusion.html: Added.
11:07 Changeset [182240] by eric.carlson@apple.com
  • 27 edits in trunk/Source/WebCore

[Mac] Do not include route button if element does not support target playback
https://bugs.webkit.org/show_bug.cgi?id=143251

Reviewed by Jer Noble.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.currentPlaybackTargetIsWireless): Return false if target playback is disabled.
(Controller.prototype.updateWirelessTargetAvailable): Do not show the picker if target

playback is disabled.

(Controller.prototype.handleWirelessPlaybackChange): Call updateWirelessTargetAvailable.

  • dom/Document.cpp:

(WebCore::Document::showPlaybackTargetPicker): Update for Page::showPlaybackTargetPicker change.
(WebCore::Document::didChoosePlaybackTarget): Notify clients in vector-order, lower level code

now tracks which one requested the picker.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Don't call applyMediaPlayerRestrictions, it is done

in mediaPlayerEngineFailedToLoad.

(WebCore::HTMLMediaElement::setReadyState): Enqueue a target availability event if there are

listeners readyState reaches HAVE_METADATA so controls are setup correctly.

(WebCore::HTMLMediaElement::mediaPlayerEngineFailedToLoad): Call applyMediaPlayerRestrictions.
(WebCore::HTMLMediaElement::clearMediaPlayer): Enqueue a target availability event in so controls

have a chance to hide the picker.

(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsSupported): New, passthrough to the

media engine.

(WebCore::HTMLMediaElement::canPlayToWirelessPlaybackTarget): Ditto.
(WebCore::HTMLMediaElement::startPlayingToPlaybackTarget): Ditto.
(WebCore::HTMLMediaElement::stopPlayingToPlaybackTarget): Ditto.

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElement.idl:
  • html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::HTMLMediaSession): Initialize m_playbackTarget.
(WebCore::HTMLMediaSession::currentPlaybackTargetIsSupported): New.
(WebCore::HTMLMediaSession::showPlaybackTargetPicker): Pull logic from showingPlaybackTargetPickerPermitted

inline. Don't refuse to show a picker if the element doesn't support target playback, it is up
to script to decide which elements can display a picker.

(WebCore::HTMLMediaSession::wirelessVideoPlaybackDisabled): Return true if there is no player.
(WebCore::HTMLMediaSession::didChoosePlaybackTarget): Call startPlayingToPlaybackTarget or

stopPlayingToPlaybackTarget because setWirelessPlaybackTarget doesn't apply the target.

(WebCore::HTMLMediaSession::externalOutputDeviceAvailableDidChange): Add logging.
(WebCore::HTMLMediaSession::showingPlaybackTargetPickerPermitted): Deleted.

  • html/HTMLMediaSession.h:
  • page/Page.cpp:

(WebCore::Page::Page): Initialize m_playbackTarget.
(WebCore::Page::showPlaybackTargetPicker): Don't set m_documentRequestingPlaybackTargetPicker.
(WebCore::Page::didChoosePlaybackTarget): Notify Pages in vector-order, lower level code

now tracks which one requested the picker.

(WebCore::Page::configurePlaybackTargetMonitoring): Don't track m_requiresPlaybackTargetMonitoring, it

is too easy for it to get out of sync with the UI process state.

  • page/Page.h:
  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::canPlayToWirelessPlaybackTarget): New, client passthrough.
(WebCore::MediaSession::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaSession::stopPlayingToPlaybackTarget): Ditto.

  • platform/audio/MediaSession.h:

(WebCore::MediaSessionClient::canPlayToWirelessPlaybackTarget):
(WebCore::MediaSessionClient::startPlayingToPlaybackTarget):
(WebCore::MediaSessionClient::stopPlayingToPlaybackTarget):

  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::sessionWillBeginPlayback): Call startPlayingToPlaybackTarget &

stopPlayingToPlaybackTarget as necessary.

  • platform/audio/MediaSessionManager.h:
  • platform/graphics/MediaPlaybackTarget.h:

(WebCore::MediaPlaybackTarget::hasActiveRoute): New.

  • platform/graphics/MediaPlaybackTargetPickerClient.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::isCurrentPlaybackTargetSupported): New, engine passthrough.
(WebCore::MediaPlayer::canPlayToWirelessPlaybackTarget): Ditto.
(WebCore::MediaPlayer::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayer::stopPlayingToPlaybackTarget): Ditto.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::isCurrentPlaybackTargetSupported):
(WebCore::MediaPlayerPrivateInterface::wirelessVideoPlaybackDisabled):
(WebCore::MediaPlayerPrivateInterface::canPlayToWirelessPlaybackTarget):
(WebCore::MediaPlayerPrivateInterface::startPlayingToPlaybackTarget):
(WebCore::MediaPlayerPrivateInterface::stopPlayingToPlaybackTarget):

  • platform/graphics/avfoundation/MediaPlaybackTargetMac.mm:

(WebCore::MediaPlaybackTarget::hasActiveRoute): New.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::canPlayToWirelessPlaybackTarget):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Use playerKVOProperties. Drive-by

code cleanup.

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Use playerKVOProperties.
(WebCore::MediaPlayerPrivateAVFoundationObjC::wirelessPlaybackTargetName): Implement for Mac.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessVideoPlaybackDisabled): Delay callbacks

while setting AVPlayer property.

(WebCore::MediaPlayerPrivateAVFoundationObjC::setWirelessPlaybackTarget): Add logging. Don't set

the AVPlayer outputContext immediately.

(WebCore::MediaPlayerPrivateAVFoundationObjC::startPlayingToPlaybackTarget): New.
(WebCore::MediaPlayerPrivateAVFoundationObjC::stopPlayingToPlaybackTarget): New.
(WebCore::playerKVOProperties): New.
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]): Notify when

allowsExternalPlayback changes.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isCurrentPlaybackTargetSupported): New.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setWirelessPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::togglePlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::stopPlayingToPlaybackTarget): Ditto.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::isCurrentPlaybackTargetSupported): Ditto.
(WebCore::MediaPlayerPrivateQTKit::setWirelessPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateQTKit::togglePlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateQTKit::startPlayingToPlaybackTarget): Ditto.
(WebCore::MediaPlayerPrivateQTKit::stopPlayingToPlaybackTarget): Ditto.

10:48 Changeset [182239] by achristensen@apple.com
  • 6 edits in trunk

[Content Extensions] Properly handle regexes that match everything.
https://bugs.webkit.org/show_bug.cgi?id=143281

Reviewed by Benjamin Poulain.

Source/WebCore:

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):
Make sure we always have at least one NFA for rule lists with triggers that all match everything.

  • contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
Add helper functions to reduce duplicate code.
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot):
Get all actions without flags from the DFA root.
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
Remove branches when interpreting.

  • contentextensions/DFABytecodeInterpreter.h:

Add helper functions to reduce duplicate code.

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::testRequest):
(TestWebKitAPI::makeBackend):
(TestWebKitAPI::TEST_F):
Removed duplicate code and added test.

10:43 Changeset [182238] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Addressing post-review comments.
https://bugs.webkit.org/show_bug.cgi?id=143292

Unreviewed.

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::leadingExpansionOpportunity):
(WebCore::FontCascade::trailingExpansionOpportunity):

10:32 Changeset [182237] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

[WinCairo] Link errors, unresolved texture mapper methods.
https://bugs.webkit.org/show_bug.cgi?id=143308

Patch by Per Arne Vollan <peavo@outlook.com> on 2015-04-01
Reviewed by Alex Christensen.

New texture mapper files should be included in the project.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
09:58 Changeset [182236] by mmaxfield@apple.com
  • 13 edits in trunk/Source/WebCore

Support forcing expansion opportunities at the beginning and ending of a run
https://bugs.webkit.org/show_bug.cgi?id=143292

Reviewed by David Hyatt.

Migrate ExpansionBehavior to an enum comprised of two values: one for leading behavior
and one for trailing behavior. Each of these two values can take on a value of
"force," "forbid," and neither. All calls that interact with justification are
migrated to use this new structure.

Note that in this terminology, "leading" and "trailing" are with respect to the order
that elements get laid out in a line. Therefore, leading is always on the left, since
lines get laid out that way regardless of their bidi attributes.

This is getting ready for https://bugs.webkit.org/show_bug.cgi?id=142608

No new tests because there is no behavior change.

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::expansionOpportunityCountInternal): Migrate to these new
values.
(WebCore::FontCascade::expansionOpportunityCount): Ditto.
(WebCore::FontCascade::leadingExpansionOpportunity): Returns whether one is present
or not.
(WebCore::FontCascade::trailingExpansionOpportunity): Ditto.

  • platform/graphics/FontCascade.h:
  • platform/graphics/GlyphBuffer.h: New leading expansion field.

(WebCore::GlyphBuffer::setLeadingExpansion):
(WebCore::GlyphBuffer::leadingExpansion):

  • platform/graphics/TextRun.h: m_expansionBehavior needs more bits.

(WebCore::TextRun::expansionBehavior):
(WebCore::TextRun::allowsLeadingExpansion): Deleted.
(WebCore::TextRun::allowsTrailingExpansion): Deleted.

  • platform/graphics/WidthIterator.cpp: Update to support new type.

(WebCore::WidthIterator::WidthIterator):
(WebCore::expansionLocation): Where should we insert expansions?
(WebCore::WidthIterator::advanceInternal): Use expansionLocation()

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):

  • platform/graphics/mac/ComplexTextController.cpp: Same as WidthIterator

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::advance):
(WebCore::expansionLocation):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::leadingExpansion):

  • platform/text/TextFlags.h: Add new enum values
  • rendering/InlineBox.h: Update to include new values.

(WebCore::InlineBox::InlineBoxBitfields::InlineBoxBitfields):
(WebCore::InlineBox::canHaveTrailingExpansion):
(WebCore::InlineBox::setCanHaveTrailingExpansion):
(WebCore::InlineBox::setForceTrailingExpansion):
(WebCore::InlineBox::forceTrailingExpansion):
(WebCore::InlineBox::setForceLeadingExpansion):
(WebCore::InlineBox::forceLeadingExpansion):

  • rendering/InlineTextBox.h:
  • rendering/RenderBlockLineLayout.cpp: Update to use new FontCascade signatures.

(WebCore::expansionBehaviorForInlineTextBox):
(WebCore::applyExpansionBehavior):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

08:56 Changeset [182235] by zalan@apple.com
  • 9 edits in trunk/Source/WebCore

Lots of time spent querying table cell borders, when there are none.
https://bugs.webkit.org/show_bug.cgi?id=143277

Reviewed by Simon Fraser.

This patch speeds up collapsed border queries by using existing collapsed border
cache to calculate repaint rects and by introducing a fast path for zero width collapsed borders.

It reduces the number of calls to recompute collapsed borders from 36 000 to 1 600, while loading a page with a table of 400 rows (1 cell per row).
When scrolling the same page all the way down to the bottom, the number of calls to recompute collapsed borders falls from 290 000 to 0.

Covered by existing tests.

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::styleDidChange): This moves invalidation time from RenderTable::layout() to styleDidChange().
(WebCore::RenderTable::invalidateCollapsedBorders):
(WebCore::RenderTable::recalcCollapsedBorders):

  • rendering/RenderTable.h:

(WebCore::RenderTable::collapsedBordersAreValid):
(WebCore::RenderTable::invalidateCollapsedBorders): Deleted.

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::RenderTableCell):
(WebCore::RenderTableCell::willBeRemovedFromTree): Invalidate caches so that when repaint rect is calculated, we don't end up using stale values.
(WebCore::RenderTableCell::styleDidChange): Same as willBeRemovedFromTree.
(WebCore::RenderTableCell::collapsedStartBorder): Check if collapsed border is zero -also query cache.
(WebCore::RenderTableCell::collapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
(WebCore::RenderTableCell::cachedCollapsedRightBorder):
(WebCore::RenderTableCell::cachedCollapsedTopBorder):
(WebCore::RenderTableCell::cachedCollapsedBottomBorder):
(WebCore::RenderTableCell::paintCollapsedBorders):
(WebCore::RenderTableCell::cellAtLeft): Deleted.
(WebCore::RenderTableCell::cellAtRight): Deleted.
(WebCore::RenderTableCell::cellAtTop): Deleted.
(WebCore::RenderTableCell::cellAtBottom): Deleted.

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::invalidateHasEmptyCollapsedBorders):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::styleDidChange):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::clearCachedCollapsedBorders): This is just an extra safety to invalidate collapsed border cache. This is always
called together with RenderTable::invalidateCollapsedBorders() -and that should prevent the RenderCells to use the cache.
(WebCore::RenderTableSection::removeCachedCollapsedBorders):
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderTableSection.h:
08:41 Changeset [182234] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.25

New tag.

08:39 Changeset [182233] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

07:30 Changeset [182232] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore

[CMake][GTK] Use the right variable to include the Wayland headers.
https://bugs.webkit.org/show_bug.cgi?id=143304

Reviewed by Carlos Garcia Campos.

No new tests, no behavior changes.

  • PlatformGTK.cmake: Use the right variable WAYLAND_INCLUDE_DIRS.
06:39 Changeset [182231] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening. Remove warning message in layoutTest.
https://bugs.webkit.org/show_bug.cgi?id=143268

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-04-01

  • platform/efl/TestExpectations:
04:15 Changeset [182230] by yoon@igalia.com
  • 2 edits in trunk

Use colored diagnostics when building with cmake + ninja + clang
https://bugs.webkit.org/show_bug.cgi?id=143297

Reviewed by Žan Doberšek.

Because that ninja sets subprocess stdout/stderr to a pipe, clang
disables colored output.
This patch forces clang to use colored diagnostics when we are using
the ninja.

  • Source/cmake/OptionsCommon.cmake:
03:46 Changeset [182229] by philn@webkit.org
  • 5 edits in trunk/Source/WebCore

[GStreamer] Move synchronous message handler to MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=143218

Reviewed by Carlos Garcia Campos.

Moved the pipeline pointer to the base class, sub-classes should
now invoke setPipeline() when loading a resource. The base class
now takes care of configuring the GL shared context, this is more
logical because video rendering is also managed by this class.

No new tests, this is only a code refactoring.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load):
(WebCore::MediaPlayerPrivateGStreamer::playbackPosition):
(WebCore::MediaPlayerPrivateGStreamer::changePipelineState):
(WebCore::MediaPlayerPrivateGStreamer::pause):
(WebCore::MediaPlayerPrivateGStreamer::duration):
(WebCore::MediaPlayerPrivateGStreamer::currentTime):
(WebCore::MediaPlayerPrivateGStreamer::seek):
(WebCore::MediaPlayerPrivateGStreamer::doSeek):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::paused):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::buffered):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
(WebCore::MediaPlayerPrivateGStreamer::sourceChanged):
(WebCore::MediaPlayerPrivateGStreamer::cancelLoad):
(WebCore::MediaPlayerPrivateGStreamer::asyncStateChangeDone):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):
(WebCore::MediaPlayerPrivateGStreamer::cacheDuration):
(WebCore::MediaPlayerPrivateGStreamer::setDownloadBuffering):
(WebCore::MediaPlayerPrivateGStreamer::audioSink):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
(WebCore::MediaPlayerPrivateGStreamer::simulateAudioInterruption):
(WebCore::mediaPlayerPrivateSyncMessageCallback): Deleted.
(WebCore::MediaPlayerPrivateGStreamer::handleSyncMessage): Deleted.
(WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): Deleted.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::mediaPlayerPrivateNeedContextMessageCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::setPipeline):
(WebCore::MediaPlayerPrivateGStreamerBase::handleNeedContextMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
03:38 Changeset [182228] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty

[CMake] Make gtest/CMakeLists.txt more readable
https://bugs.webkit.org/show_bug.cgi?id=143295

Patch by Gyuyoung Kim <gyuyoung.kim@webkit.org> on 2015-04-01
Reviewed by Csaba Osztrogonác.

gtest/CMakeLists.txt has used add_library() and include_directory() directly.
This patch adds GTEST_INCLUDE_DIRECTORIES and GTEST_SOURCES, and use it.

  • gtest/CMakeLists.txt:
03:19 Changeset [182227] by philn@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] GstGL support in the video sink
https://bugs.webkit.org/show_bug.cgi?id=138562

Use GStreamer's glimagesink for video rendering instead of our
custom video sink if a recent-enough version of GstGL is found
during the build. When glimagesink is used it passes a texture to
the media player which then wraps it inside a TextureMapper
texture later used for actual rendering.

Using this new code path will allow us to remove our custom sink
entirely in the long term.

Patch by Philippe Normand <philn@igalia.com> on 2015-03-24
Reviewed by Carlos Garcia Campos.

No new test, existing media tests cover video rendering already.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::mediaPlayerPrivateDrawCallback): client-draw signal callback.
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize): Better
check for sample validity.
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture): Ditto.
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint): Trigger a
repaint and wait its completion.
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
Extract texture ID and video dimensions from the sample and do actual paint.
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink): Use
glimagesink if GstGL is available.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
02:36 Changeset [182226] by utatane.tea@gmail.com
  • 4 edits
    2 adds in trunk/Source/JavaScriptCore

IteratorClose should be called when jumping over the target for-of loop
https://bugs.webkit.org/show_bug.cgi?id=143140

Reviewed by Geoffrey Garen.

This patch fixes labeled break/continue behaviors with for-of and iterators.

  1. Support IteratorClose beyond multiple loop contexts

Previously, IteratorClose is only executed in for-of's breakTarget().
However, this misses IteratorClose execution when statement roll-ups multiple control flow contexts.
For example,
outer: for (var e1 of outer) {

inner: for (var e2 of inner) {

break outer;

}

}
In this case, return method of inner should be called.
We leverage the existing system for finally to execute inner.return method correctly.
Leveraging finally system fixes break, continue and return cases.
throw case is already supported by emitting try-catch handlers in for-of.

  1. Incorrect LabelScope creation is done in ForOfNode

ForOfNode creates duplicated LabelScope.
It causes infinite loop when executing the following program that contains
explicitly labeled for-of loop.
For example,
inner: for (var elm of array) {

continue inner;

}

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::pushFinallyContext):
(JSC::BytecodeGenerator::pushIteratorCloseContext):
(JSC::BytecodeGenerator::popFinallyContext):
(JSC::BytecodeGenerator::popIteratorCloseContext):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIteratorClose):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ForOfNode::emitBytecode):

  • tests/stress/iterator-return-beyond-multiple-iteration-scopes.js: Added.

(createIterator.iterator.return):
(createIterator):

  • tests/stress/raise-error-in-iterator-close.js: Added.

(createIterator.iterator.return):
(createIterator):

02:03 Changeset [182225] by utatane.tea@gmail.com
  • 6 edits
    2 adds in trunk/Source/JavaScriptCore

[ES6] Implement Symbol.unscopables
https://bugs.webkit.org/show_bug.cgi?id=142829

Reviewed by Geoffrey Garen.

This patch introduces Symbol.unscopables functionality.
In ES6, some generic names (like keys, values) are introduced
as Array's method name. And this breaks the web since some web sites
use like the following code.

var values = ...;
with (array) {

values; This values is trapped by array's method "values".

}

To fix this, Symbol.unscopables introduces blacklist
for with scope's trapping. When resolving scope,
if name is found in the target scope and the target scope is with scope,
we check Symbol.unscopables object to filter generic names.

This functionality is only active for with scopes.
Global scope does not have unscopables functionality.

And since
1) op_resolve_scope for with scope always return Dynamic resolve type,
2) in that case, JSScope::resolve is always used in JIT and LLInt,
3) the code which contains op_resolve_scope that returns Dynamic cannot be compiled with DFG and FTL,
to implement this functionality, we just change JSScope::resolve and no need to change JIT code.
So performance regression is only visible in Dynamic resolving case, and it is already much slow.

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::runtimeFlags):

  • runtime/JSScope.cpp:

(JSC::isUnscopable):
(JSC::JSScope::resolve):

  • runtime/JSScope.h:

(JSC::ScopeChainIterator::scope):

  • tests/stress/global-environment-does-not-trap-unscopables.js: Added.

(test):

  • tests/stress/unscopables.js: Added.

(test):
(.):

00:24 Changeset [182224] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

nullptr cleanup in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=143260

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-04-01
Reviewed by Ryosuke Niwa.

No new tests, no behavior changes

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initForStyleResolve):
(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::findFromMatchedPropertiesCache):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::MatchedProperties::MatchedProperties):

  • css/StyleResolver.h:

(WebCore::PseudoStyleRequest::PseudoStyleRequest):
(WebCore::StyleResolverParentPusher::StyleResolverParentPusher):

00:07 Changeset [182223] by ap@apple.com
  • 6 edits in trunk/LayoutTests

REGRESSION (r179820): accessibility/textarea-selected-text-range.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=142976

Reviewed by Chris Fleizach.

  • platform/mac/TestExpectations: Removed an expectation.
  • accessibility/textarea-selected-text-range-expected.txt:
  • accessibility/textarea-selected-text-range.html:

Don't race a timer with an internal dispatch_async.

  • platform/mac/accessibility/select-element-selection-with-optgroups-expected.txt:
  • platform/mac/accessibility/select-element-selection-with-optgroups.html:

This test had the same issue.

03/31/15:

23:18 Changeset [182222] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Fix the build after <http://trac.webkit.org/changeset/182205>.

  • wtf/text/StringImpl.h: (WTF::StringImpl::extractFoldedStringInSymbol):

A function cannot be both exported and inline.

23:16 Changeset [182221] by nvasilyev@apple.com
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: console.error(object) has double disclosure triangles
https://bugs.webkit.org/show_bug.cgi?id=142069

Use inline-block instead of "float: left" or "position: absolute" to
make layout more predictable and easier to understand.

Reviewed by Timothy Hatcher.

  • UserInterface/Views/LogContentView.css:

(.outline-disclosure, .outline-disclosure ol):
(.outline-disclosure > li.parent):
(.outline-disclosure > li.parent::before):
(.outline-disclosure li.parent): Deleted.
(.outline-disclosure li.parent::before): Deleted.

  • UserInterface/Views/ObjectTreePropertyTreeElement.css:

(.object-tree-property > .titles):
(.object-tree-property > .disclosure-button):
(.object-tree-property > .icon):

  • UserInterface/Views/ObjectTreeView.css:

(.object-tree > :matches(.title, .object-preview)::before):
(.object-tree:not(.lossless-preview) > :matches(.title, .object-preview)):

22:00 Changeset [182220] by jonowells@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Filtering no longer works
https://bugs.webkit.org/show_bug.cgi?id=143099

Reviewed by Brian Burg.

Add a check for an empty array of filter functions and return true in this case to ensure text
and timeline filters work correctly.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.matchTreeElementAgainstFilterFunctions):

21:06 Changeset [182219] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/20365675> [iOS] Include Add to Reading List link action only where supported
https://bugs.webkit.org/show_bug.cgi?id=143289

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/_WKElementAction.h: Excluded _WKElementActionTypeAddToReadingList from

the _WKElementActionType enum when Reading List is not supported.

  • UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction elementActionWithType:customTitle:]): Made Add to Reading List code
conditional on HAVE(SAFARI_SERVICES_FRAMEWORK).

  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]): Ditto.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.

  • config.h: Defined HAVE_SAFARI_SERVICES_FRAMEWORK.
19:35 Changeset [182218] by rniwa@webkit.org
  • 7 edits in trunk

ES6 class syntax should allow static setters and getters
https://bugs.webkit.org/show_bug.cgi?id=143180

Source/JavaScriptCore:

Reviewed by Filip Pizlo

Apparently I misread the spec when I initially implemented parseClass.
ES6 class syntax allows static getters and setters so just allow that.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

LayoutTests:

Reviewed by Filip Pizlo.

Added test cases.

  • js/class-syntax-declaration-expected.txt:
  • js/class-syntax-expression-expected.txt:
  • js/script-tests/class-syntax-declaration.js:
  • js/script-tests/class-syntax-expression.js:
19:05 Changeset [182217] by timothy_horton@apple.com
  • 4 edits in trunk/Source

TextIndicator for <span> inside an <a> only highlights the <span>, should highlight the whole <a>
https://bugs.webkit.org/show_bug.cgi?id=143287
<rdar://problem/20318342>

Reviewed by Beth Dakin.

  • WebView/WebImmediateActionController.mm:

(-[WebImmediateActionController _defaultAnimationController]):
Instead of just highlighting the hit element, highlight the whole
element that the link URL comes from.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performActionMenuHitTestAtLocation):
Instead of just highlighting the hit element, highlight the whole
element that the link URL comes from.

18:51 EFLWebKitReleasePlan edited by ryuan.choi@navercorp.com
(diff)
18:15 Changeset [182216] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

WKView should stop using endGestureWithEvent
https://bugs.webkit.org/show_bug.cgi?id=143285
<rdar://problem/20357007>

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm:

(-[WKView magnifyWithEvent:]):
(-[WKView endGestureWithEvent:]): Deleted.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::endMagnificationGesture):
(WebKit::ViewGestureController::endActiveGesture): Deleted.
While there is no visible symptom, it is recommended that we check
the phase of normal magnification events instead of using the
special gesture end events.

16:42 Changeset [182215] by simon.fraser@apple.com
  • 12 edits
    23 adds in trunk

Make it possible to compute a region for elements on the page that have wheel event handlers
https://bugs.webkit.org/show_bug.cgi?id=142807

Reviewed by David Hyatt.

Source/WebCore:

Make it possible to compute a region that covers the elements on the page that have
a wheel event handler. This region may overestimate, but must not underestimate the area.

Elements with wheel handlers are registered on the document, and when a document gains
its first wheel handler, it registers the ownerElement in the parent document. Thus, on
the main frame, the region encompasses elements with handlers, and iframes whose subdocuments
have handlers.

Element gains some functions that allow it to return a rect which is the bounds of the element's
renderer, and renders for its descendant elements, which is the size or larger than the event
handling region for that element. Some configurations (e.g. position:fixed) require special
treatment.

Document::absoluteRegionForEventTargets() can then iterate over all elements in the given set,
and build a Region for those (short-circuiting if the document itself has a handler).

The new code is exercised for the debug MouseWheelRegionOverlay, and also added to the
non-fast scrollable region, used by threaded scrolling.

Tests: platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html

platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html
platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html

  • dom/ContainerNode.h:

(WebCore::ContainerNode::absoluteEventHandlerBounds): Base class implementation; returns empty rect.

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction): Unregister from the parent document.
(WebCore::Document::didAddWheelEventHandler): Add to the wheel handler set. Tell the parent
document if we are adding wheel handlers for the first time. Eventually the wheelEventHandlerCountChanged()
code will be removed, now we have the set. Tell debug overlays that we changed.
(WebCore::Document::didRemoveWheelEventHandler): Remove from the set, and unregister with the parent
document if necessary. Tell debug overlays that we changed.
(WebCore::Document::didAddTouchEventHandler): Minor cleanup.
(WebCore::Document::didRemoveTouchEventHandler): Ditto.
(WebCore::Document::didRemoveEventTargetNode): Remove from wheel targets.
(WebCore::Document::absoluteEventHandlerBounds): Implementation of the ContainerNode
function, just return the document bounds.
(WebCore::Document::absoluteRegionForEventTargets): Iterate over the given event targets,
and call absoluteEventHandlerBounds() on each.

  • dom/Document.h:

(WebCore::Document::wheelEventTargets):

  • dom/Element.cpp:

(WebCore::layoutOverflowRectContainsAllDescendants): Return true if we can determine that the
layoutOverflow bounds of the given renderer contains the renderers of all descendant elements.
(WebCore::Element::eventBounds): Get the "event handling" bounds of this element (excluding
descendants), and while doing so, compute whether any descendants are position:fixed, and whether
these bounds are known to include descendants.
(WebCore::Element::eventBoundsOfElementAndDescendants): Recursive function that short-circuits
if it can determine that descendants are enclosed by the bounds.
(WebCore::Element::absoluteEventHandlerBounds):

  • dom/Element.h:
  • page/DebugPageOverlays.cpp:

(WebCore::MouseWheelRegionOverlay::updateRegion): Ask the document for the region of wheel
event handlers.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion): Add the wheel handler region
to the non-fast scrollable region.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo): Overflow scrolling needs to dirty event regions.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::absoluteBoundingBoxRect): Need to pass the "wasFixed" flag out
of this function.
(WebCore::RenderObject::localToAbsolute): Ditto.

  • rendering/RenderObject.h:

LayoutTests:

Tests that dump the non-fast-scrollable region, for various rendering configurations.

  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/gain-wheel-handler.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/lose-wheel-handler.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/resources/wheel-handler-region-helper.js: Added.

(rectsAsString):
(dumpRegion):

  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-fixed-child.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-columns.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-in-region.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-inside-fixed.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-document.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-on-fixed.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic.html: Added.
16:38 Changeset [182214] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Swipes occur in the wrong direction in RTL
https://bugs.webkit.org/show_bug.cgi?id=143257
<rdar://problem/20300862>

Reviewed by Simon Fraser.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(-[WKSwipeTransitionController gestureRecognizerForInteractiveTransition:WithTarget:action:]):
When choosing which edge to attach our gesture recognizers to,
flip them in RTL.

(-[WKSwipeTransitionController directionForTransition:]):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::canSwipeInDirection):

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::scrollEventCanBecomeSwipe):
(WebKit::ViewGestureController::trackSwipeGesture):
(WebKit::ViewGestureController::determineLayerAdjacentToSnapshotForParent):
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::handleSwipeGesture):
Adjust SwipeDirection to be in logical back-forward list direction
instead of physical edge direction.

16:15 Changeset [182213] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

PutClosureVar CSE def() rule has a wrong base
https://bugs.webkit.org/show_bug.cgi?id=143280

Reviewed by Michael Saboff.

I think that this code was incorrect in a benign way, since the base of a
PutClosureVar is not a JS-visible object. But it was preventing some optimizations.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

16:07 Changeset [182212] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix bindings tests results after <http://trac.webkit.org/changeset/182205>.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjReplaceableAttribute):

15:59 Changeset [182211] by benjamin@webkit.org
  • 10 edits
    3 adds in trunk

Content Extensions: split the state machines to minimize prefix states
https://bugs.webkit.org/show_bug.cgi?id=143253

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-03-31
Reviewed by Alex Christensen.

Source/WebCore:

With this patch, we refine how the URLs are partitioned to make
multiple small machines instead of a big one.

Here, considering each pattern as a language, I took the simplest
partitioning: take the union minimizing the states
that differentiate languages.

The idea is the following: every time a subgraph can be skipped
or repeated, it is an opportunity for a merged language to start
with a distinguishable state.
To avoid accumulating those differences, we only merge languages
that share the exact same "variable" subgraph as a prefix.

A side effect is that we could create as many machines as we have patterns.
We'll have to address that in a follow-up by merging small machines
until they reach a certain size.
In the common cases, patterns look very much alike so that is not a problem
at the moment.

  • WebCore.xcodeproj/project.pbxproj:
  • contentextensions/CombinedURLFilters.cpp: Added.

I moved the prefix tree and graph construction out of URLFilterParser for clarity.

CombinedURLFilters maintain the term prefix tree. Instead of generating on the fly
as we build the prefix tree, we first generate the entire tree of terms, then generate
NFAs for each branch without a variable prefix.

(WebCore::ContentExtensions::CombinedURLFilters::CombinedURLFilters):
(WebCore::ContentExtensions::CombinedURLFilters::~CombinedURLFilters):

(WebCore::ContentExtensions::CombinedURLFilters::addPattern):
Note here that we keep track of which subtree contains a any variable length term.
Instead of anotating the edges, the destination vertex is anotated with the information
from the edge.

The flag "inVariableLengthPrefix" is there to simplify traversal.

(WebCore::ContentExtensions::generateNFAForSubtree):
(WebCore::ContentExtensions::CombinedURLFilters::createNFAs):
Since we are traversing a tree generated by string, using the stack for recursion
is out of the question.

Fortunately, the entire state is very simple when going depth first: we only need
the active vertex and edge, and traverse the edges in order.

To do keep track of the edges, I used the HashTable iterator on the current term.
Since no vertex is modified for generation, storing the iterators is safe.

  • contentextensions/CombinedURLFilters.h:
  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::compileRuleList):

  • contentextensions/NFA.cpp:

(WebCore::ContentExtensions::NFA::setActions):
(WebCore::ContentExtensions::NFA::debugPrintDot):
(WebCore::ContentExtensions::NFA::setFinal): Deleted.
(WebCore::ContentExtensions::NFA::addRuleId): Deleted.

  • contentextensions/NFA.h:
  • contentextensions/NFAGraphBuilder.cpp: Added.
  • contentextensions/NFAGraphBuilder.h: Added.
  • contentextensions/NFANode.h:
  • contentextensions/Term.h: Added.

Move the Term to its own file since it is now shared between the parser
and the CombinedURLFilters.

(WebCore::ContentExtensions::Term::CharacterSet::operator==):
(WebCore::ContentExtensions::Term::CharacterSet::hash):
(WebCore::ContentExtensions::Term::Group::operator==):
(WebCore::ContentExtensions::Term::Group::hash):
(WebCore::ContentExtensions::TermHash::hash):
(WebCore::ContentExtensions::TermHash::equal):
(WebCore::ContentExtensions::Term::Term):
(WebCore::ContentExtensions::Term::~Term):
(WebCore::ContentExtensions::Term::isValid):
(WebCore::ContentExtensions::Term::addCharacter):
(WebCore::ContentExtensions::Term::extendGroupSubpattern):
(WebCore::ContentExtensions::Term::quantify):
(WebCore::ContentExtensions::Term::Term::generateGraph):
(WebCore::ContentExtensions::Term::isEndOfLineAssertion):
(WebCore::ContentExtensions::Term::matchesAtLeastOneCharacter):
(WebCore::ContentExtensions::Term::isKnownToMatchAnyString):
(WebCore::ContentExtensions::Term::hasFixedLength):
(WebCore::ContentExtensions::Term::operator=):
(WebCore::ContentExtensions::Term::operator==):
(WebCore::ContentExtensions::Term::hash):
(WebCore::ContentExtensions::Term::isEmptyValue):
(WebCore::ContentExtensions::Term::isDeletedValue):
(WebCore::ContentExtensions::Term::isUniversalTransition):
(WebCore::ContentExtensions::Term::generateSubgraphForAtom):
(WebCore::ContentExtensions::Term::destroy):

  • contentextensions/URLFilterParser.cpp:

(WebCore::ContentExtensions::PatternParser::PatternParser):
(WebCore::ContentExtensions::PatternParser::finalize):
(WebCore::ContentExtensions::PatternParser::assertionBOL):
(WebCore::ContentExtensions::URLFilterParser::URLFilterParser):
(WebCore::ContentExtensions::URLFilterParser::addPattern):
(WebCore::ContentExtensions::Term::Term): Deleted.
(WebCore::ContentExtensions::Term::~Term): Deleted.
(WebCore::ContentExtensions::Term::isValid): Deleted.
(WebCore::ContentExtensions::Term::addCharacter): Deleted.
(WebCore::ContentExtensions::Term::extendGroupSubpattern): Deleted.
(WebCore::ContentExtensions::Term::quantify): Deleted.
(WebCore::ContentExtensions::Term::generateGraph): Deleted.
(WebCore::ContentExtensions::Term::isEndOfLineAssertion): Deleted.
(WebCore::ContentExtensions::Term::matchesAtLeastOneCharacter): Deleted.
(WebCore::ContentExtensions::Term::isKnownToMatchAnyString): Deleted.
(WebCore::ContentExtensions::Term::operator=): Deleted.
(WebCore::ContentExtensions::Term::operator==): Deleted.
(WebCore::ContentExtensions::Term::hash): Deleted.
(WebCore::ContentExtensions::Term::isEmptyValue): Deleted.
(WebCore::ContentExtensions::Term::isDeletedValue): Deleted.
(WebCore::ContentExtensions::Term::isUniversalTransition): Deleted.
(WebCore::ContentExtensions::Term::generateSubgraphForAtom): Deleted.
(WebCore::ContentExtensions::Term::destroy): Deleted.
(WebCore::ContentExtensions::Term::CharacterSet::operator==): Deleted.
(WebCore::ContentExtensions::Term::CharacterSet::hash): Deleted.
(WebCore::ContentExtensions::Term::Group::operator==): Deleted.
(WebCore::ContentExtensions::Term::Group::hash): Deleted.
(WebCore::ContentExtensions::TermHash::hash): Deleted.
(WebCore::ContentExtensions::TermHash::equal): Deleted.
(WebCore::ContentExtensions::GraphBuilder::GraphBuilder): Deleted.
(WebCore::ContentExtensions::GraphBuilder::finalize): Deleted.
(WebCore::ContentExtensions::GraphBuilder::assertionBOL): Deleted.

  • contentextensions/URLFilterParser.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):
(TestWebKitAPI::testPatternStatus):

15:58 Changeset [182210] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.5.17

New tag.

15:45 Changeset [182209] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r182200.
https://bugs.webkit.org/show_bug.cgi?id=143279

Probably causing assertion extravaganza on bots. (Requested by
kling on #webkit).

Reverted changeset:

"Logically empty WeakBlocks should not pin down their
MarkedBlocks indefinitely."
https://bugs.webkit.org/show_bug.cgi?id=143210
http://trac.webkit.org/changeset/182200

15:15 Changeset [182208] by bshafiei@apple.com
  • 2 edits in branches/safari-600.5-branch/Source/WebCore

Merged r182204. rdar://problem/20371107

14:34 Changeset [182207] by mmaxfield@apple.com
  • 47 edits
    1 move in trunk/Source

Move ExpansionBehaviorFlags and TextDirection to their own file
https://bugs.webkit.org/show_bug.cgi?id=143273

Reviewed by Simon Fraser.

This is a mechanical change. It just moves code around.

This is getting ready for https://bugs.webkit.org/show_bug.cgi?id=142608

Source/WebCore:

No new tests because there is no behavior change.

  • Modules/notifications/Notification.h:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPrimitiveValueMappings.h:
  • css/CSSProperty.h:
  • dom/Position.h:
  • editing/VisiblePosition.h:
  • editing/VisibleUnits.h:
  • editing/htmlediting.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • platform/LengthBox.h:
  • platform/PopupMenuStyle.h:
  • platform/graphics/FontCascade.h:
  • platform/graphics/LayoutBoxExtent.h:
  • platform/graphics/TextRun.h:
  • platform/ios/SelectionRect.h:
  • platform/text/BidiResolver.h:
  • platform/text/StringWithDirection.h:
  • platform/text/TextHelpers.h: Renamed from Source/WebCore/platform/text/TextDirection.h.

(WebCore::isLeftToRightDirection):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::paint):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):

  • rendering/HitTestLocation.h:
  • rendering/HitTestResult.h:
  • rendering/InlineBox.h:
  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::expansionBehavior):

  • rendering/RenderBlock.cpp:

(WebCore::constructTextRunInternal):
(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderBlock.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::getRelativeMarkerRect):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::updateOptionsWidth):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAverageCharWidth):

  • rendering/RenderThemeIOS.mm:
  • rendering/style/RenderStyle.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::constructTextRun):

Source/WebKit/ios:

  • WebCoreSupport/WebFrameIOS.mm:
  • WebCoreSupport/WebVisiblePosition.mm:

Source/WebKit2:

  • Shared/WebPopupItem.h:
  • UIProcess/API/C/efl/WKAPICastEfl.h:
  • UIProcess/API/efl/EwkView.h:
  • UIProcess/WebPopupMenuProxy.h:
  • UIProcess/efl/WebUIPopupMenuClient.h:
14:34 Changeset [182206] by jonowells@apple.com
  • 2 deletes in trunk/Source/WebInspectorUI/WebInspectorUI.esproj

Remove user project file left in tree by accident.

  • WebInspectorUI.esproj/Project.espressostorage: Removed.
  • WebInspectorUI.esproj/user.jonowells.espressostorage: Removed.
14:25 Changeset [182205] by utatane.tea@gmail.com
  • 119 edits in trunk

Clean up Identifier factories to clarify the meaning of StringImpl*
https://bugs.webkit.org/show_bug.cgi?id=143146

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

In the a lot of places, Identifier(VM*/ExecState*, StringImpl*) constructor is used.
However, it's ambiguous because StringImpl* has 2 different meanings.
1) normal string, it is replacable with WTFString and
2) uid, which holds isSymbol information to represent Symbols.
So we dropped Identifier constructors for strings and instead, introduced 2 factory functions.
+ Identifier::fromString(VM*/ExecState*, const String&).
Just construct Identifier from strings. The symbol-ness of StringImpl* is not kept.
+ Identifier::fromUid(VM*/ExecState*, StringImpl*).
This function is used for 2) uid. So symbol-ness of StringImpl* is kept.

And to clean up StringImpl which is used as uid,
we introduce StringKind into StringImpl. There's 3 kinds

  1. StringNormal (non-atomic, non-symbol)
  2. StringAtomic (atomic, non-symbol)
  3. StringSymbol (non-atomic, symbol)

They are mutually exclusive. And (atomic, symbol) case should not exist.

  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::getOwnNonIndexPropertyNames):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunction):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::identifier):

  • bindings/ScriptFunctionCall.cpp:

(Deprecated::ScriptFunctionCall::call):

  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createExecutableInternal):

  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::BuiltinNames):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitThrowTypeError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
(JSC::BytecodeGenerator::emitEnumeration):

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::reallyAdd):

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::functionDetails):
(Inspector::constructInternalProperty):
(Inspector::JSInjectedScriptHost::weakMapEntries):
(Inspector::JSInjectedScriptHost::iteratorEntries):

  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):

  • inspector/JSJavaScriptCallFramePrototype.cpp:
  • inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

  • jit/JITOperations.cpp:
  • jsc.cpp:

(GlobalObject::finishCreation):
(GlobalObject::addFunction):
(GlobalObject::addConstructableFunction):
(functionRun):
(runWithScripts):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LowLevelInterpreter.asm:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::addVar):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::createBindingPattern):

  • parser/ParserArena.h:

(JSC::IdentifierArena::makeIdentifier):
(JSC::IdentifierArena::makeIdentifierLCharFromUChar):
(JSC::IdentifierArena::makeNumericIdentifier):

  • runtime/ArgumentsIteratorPrototype.cpp:

(JSC::ArgumentsIteratorPrototype::finishCreation):

  • runtime/ArrayIteratorPrototype.cpp:

(JSC::ArrayIteratorPrototype::finishCreation):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):
(JSC::arrayProtoFuncPush):

  • runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::getOwnPropertySlot):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers):

  • runtime/CommonIdentifiers.h:
  • runtime/Error.cpp:

(JSC::addErrorInfo):
(JSC::hasErrorInfo):

  • runtime/ExceptionHelpers.cpp:

(JSC::createUndefinedVariableError):

  • runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::getOwnPropertySlot):

  • runtime/Identifier.h:

(JSC::Identifier::isSymbol):
(JSC::Identifier::Identifier):
(JSC::Identifier::from): Deleted.

  • runtime/IdentifierInlines.h:

(JSC::Identifier::Identifier):
(JSC::Identifier::fromUid):
(JSC::Identifier::fromString):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpInContextAssumingStructure):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::toPropertyKey):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSLexicalEnvironment.cpp:

(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):

  • runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::reifyStaticFunctionsForDelete):

  • runtime/JSObject.h:

(JSC::makeIdentifier):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructorFuncRace):
(JSC::JSPromiseConstructorFuncAll):

  • runtime/JSString.h:

(JSC::JSString::toIdentifier):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::tryJSONPParse):
(JSC::LiteralParser<CharType>::makeIdentifier):

  • runtime/Lookup.h:

(JSC::reifyStaticProperties):

  • runtime/MapConstructor.cpp:

(JSC::constructMap):

  • runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototype::finishCreation):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

  • runtime/MathObject.cpp:

(JSC::MathObject::finishCreation):

  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

  • runtime/PrivateName.h:

(JSC::PrivateName::PrivateName):

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyTable::find):
(JSC::PropertyTable::get):

  • runtime/PropertyName.h:

(JSC::PropertyName::PropertyName):
(JSC::PropertyName::publicName):
(JSC::PropertyName::asIndex):

  • runtime/PropertyNameArray.cpp:

(JSC::PropertyNameArray::add):

  • runtime/PropertyNameArray.h:

(JSC::PropertyNameArray::addKnownUnique):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):

  • runtime/SetConstructor.cpp:

(JSC::constructSet):

  • runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototype::finishCreation):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

  • runtime/StringIteratorPrototype.cpp:

(JSC::StringIteratorPrototype::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

  • runtime/Structure.cpp:

(JSC::Structure::getPropertyNamesFromStructure):

  • runtime/SymbolConstructor.cpp:
  • runtime/VM.cpp:

(JSC::VM::throwException):

  • runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

Source/WebCore:

Just change Identifier creations.

  1. If the code creates Identifier from StringImpl*

which is treated as symbol or string(unique id), use Identifier::fromUid.

  1. If the code creates Identifier from string, use Identifier::fromString.
  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::ensureReplacementScriptInjected):
(WebCore::QuickTimePluginReplacement::installReplacement):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):

  • bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::getOwnPropertyNames):

  • bindings/js/JSCallbackData.cpp:

(WebCore::JSCallbackData::invokeCallback):

  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::getJSListenerFunctions):
(WebCore::JSCommandLineAPIHost::getEventListeners):

  • bindings/js/JSCryptoAlgorithmBuilder.cpp:

(WebCore::JSCryptoAlgorithmBuilder::add):

  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::getProperty):
(WebCore::getHashAlgorithm):

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::getJSArrayFromJSON):
(WebCore::getStringFromJSON):
(WebCore::getBooleanFromJSON):
(WebCore::addToJSON):
(WebCore::buildJSONForRSAComponents):
(WebCore::addBoolToJSON):
(WebCore::addUsagesToJSON):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::defineOwnProperty):
(WebCore::JSDOMWindow::setLocation):
(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::readAccelerationArgument):
(WebCore::readRotationRateArgument):
(WebCore::createAccelerationObject):
(WebCore::createRotationRateObject):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::tryGetProperty):

  • bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

  • bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::item):
(WebCore::JSHTMLAllCollection::namedItem):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::all):
(WebCore::JSHTMLDocument::setAll):
(WebCore::JSHTMLDocument::open):

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::JSHTMLFormControlsCollection::namedItem):

  • bindings/js/JSIDBDatabaseCustom.cpp:

(WebCore::JSIDBDatabase::createObjectStore):

  • bindings/js/JSIDBObjectStoreCustom.cpp:

(WebCore::JSIDBObjectStore::createIndex):

  • bindings/js/JSImageDataCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

  • bindings/js/JSLazyEventListener.cpp:

(WebCore::JSLazyEventListener::initializeJSFunction):

  • bindings/js/JSNodeFilterCondition.cpp:

(WebCore::JSNodeFilterCondition::acceptNode):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/ReadableStreamJSSource.cpp:

(WebCore::setInternalSlotToObject):
(WebCore::getInternalSlotFromObject):

  • bindings/js/ScriptGlobalObject.cpp:

(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::deserialize):

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject callWebScriptMethod:withArguments:]):
(-[WebScriptObject setValue:forKey:]):
(-[WebScriptObject valueForKey:]):
(-[WebScriptObject removeWebScriptKey:]):
(-[WebScriptObject hasWebScriptKey:]):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64Array::getOwnPropertyNames):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertyNames):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjTestSubObjEnabledBySettingConstructor):
(WebCore::setJSTestObjConditionalAttr4Constructor):
(WebCore::setJSTestObjConditionalAttr5Constructor):
(WebCore::setJSTestObjConditionalAttr6Constructor):
(WebCore::setJSTestObjReplaceableAttribute):

  • bridge/c/c_utility.cpp:

(JSC::Bindings::identifierFromNPIdentifier):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcFallbackObjectImp::defaultValue):

  • bridge/testbindings.cpp:

(main):

  • bridge/testbindings.mm:

(main):

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadTrigger):
(WebCore::ContentExtensions::loadAction):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::injectInternalsObject):

Source/WebKit/mac:

Just change to Identifier::fromString.

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(identifierFromIdentifierRep):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::getPropertyNames):

Source/WebKit2:

Just change to Identifier::fromString.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::getOwnPropertyNames):

  • WebProcess/Plugins/Netscape/NPJSObject.cpp:

(WebKit::identifierFromIdentifierRep):

Source/WTF:

Introduce StringKind into StringImpl. There's 3 kinds

  1. StringNormal (non-atomic, non-symbol)
  2. StringAtomic (atomic, non-symbol)
  3. StringSymbol (non-atomic, symbol)

They are mutually exclusive.

  • wtf/text/AtomicString.cpp:

(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::findSlowCase):
When registering a string into AtomicStringTable,
it should not be a symbol string
because symbol and atomic types are mutually exclusive.
When a symbol string comes, we extract an owner string
from a symbol string by using StringImpl::extractFoldedStringInSymbol().
It always succeeds because a symbol (non empty) string
is always BufferSubstring and has an owner string.
Empty symbol string doesn't have an owner string.
This case is filtered by !string.length() guard.

  • wtf/text/AtomicString.h:

(WTF::AtomicString::add):
(WTF::AtomicString::addWithStringTableProvider):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::~StringImpl):
(WTF::StringImpl::createSymbol):
(WTF::StringImpl::createUnique): Deleted.

  • wtf/text/StringImpl.h:

(WTF::StringImpl::StringImpl):
(WTF::StringImpl::createSymbolEmpty):
(WTF::StringImpl::flagIsAtomic):
(WTF::StringImpl::flagIsSymbol):
(WTF::StringImpl::maskStringKind):
(WTF::StringImpl::stringKind):
(WTF::StringImpl::isSymbol):
(WTF::StringImpl::isAtomic):
(WTF::StringImpl::setIsAtomic):
(WTF::StringImpl::extractFoldedStringInSymbol):
(WTF::StringImpl::createUniqueEmpty): Deleted.
(WTF::StringImpl::flagIsUnique): Deleted.
(WTF::StringImpl::isUnique): Deleted.

  • wtf/text/StringStatics.cpp:

(WTF::StringImpl::hashAndFlagsForSymbol):
(WTF::StringImpl::hashAndFlagsForUnique): Deleted.

Tools:

Simple API tests for StringImpl are added.

  • TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

14:18 Changeset [182204] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Songza.com fails to play; QTKit path reports it is always "seeking".
https://bugs.webkit.org/show_bug.cgi?id=143274

Rubber-stamped by Eric Carlson.

MediaTime::invalidTime() is always greater than any valid time. So when
checking to see if MediaPlayerPrivateQTKit is seeking, first check if the
m_seekTo time is valid before checking whether it's > 0.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::seeking):

13:53 Changeset [182203] by timothy_horton@apple.com
  • 16 edits in trunk/Source/WebKit2

WebKit briefly shows wrong webpage after swiping back (gigaom.com, or any site on a slow network)
https://bugs.webkit.org/show_bug.cgi?id=143256
<rdar://problem/19458648>

Reviewed by Dan Bernstein.

Instead of allowing a flash of the previous page when the swipe snapshot
timeouts fire (removing the snapshot before the new page is loaded), show
the snapshotted background color.

This fixes the problem on iOS, where UI-side compositing makes it easy to fix,
but not yet on OS X.

  • UIProcess/API/Cocoa/WKWebView.mm:

(baseScrollViewBackgroundColor):
(scrollViewBackgroundColor):
If the ViewGestureController returns a valid background color, use that
instead of the page's background color.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:

Expose _updateScrollViewBackground.

  • UIProcess/PageClient.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didChangeBackgroundColor):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didChangeBackgroundColor):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeBackgroundColor):

  • UIProcess/WebPageProxy.h:

Add and plumb didChangeBackgroundColor, which calls
_updateScrollViewBackground on iOS.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::endSwipeGesture):
Hide the content of the drawing area until the next commit. This way,
even if the snapshot is removed (say, because a timeout fired), we won't
ever show the old page content (but we will show background color).

Store the background color associated with the current snapshot.

Let WKWebView know that it needs to recompute the background color.

(WebKit::ViewGestureController::removeSwipeSnapshot):
Clear the background color so that the next time we commit, WKWebView
will get an invalid color from ViewGestureController and fall back
to the page's extended background color instead.

  • UIProcess/mac/ViewGestureController.h:

(WebKit::ViewGestureController::backgroundColorForCurrentSnapshot):

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Keep backgroundColorForCurrentSnapshot up to date on Mac too, even
though we don't use it yet.

13:50 Changeset [182202] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Rotating PDF in Safari scrolls to the wrong position
https://bugs.webkit.org/show_bug.cgi?id=143259
<rdar://problem/19872693>

Reviewed by Dan Bernstein.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_setMinimumSize:]):
Maintan the relative top/left within the rescaled document.

13:37 Changeset [182201] by dino@apple.com
  • 2 edits in trunk/LayoutTests

accessibility/aria-hidden-hides-all-elements.html fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=143275

Mark as Pass/Fail.

  • platform/win/TestExpectations:
13:01 Changeset [182200] by akling@apple.com
  • 8 edits in trunk/Source/JavaScriptCore

Logically empty WeakBlocks should not pin down their MarkedBlocks indefinitely.
<https://webkit.org/b/143210>

Reviewed by Geoffrey Garen.

Since a MarkedBlock cannot be destroyed until all the WeakBlocks pointing into it are gone,
we had a little problem where WeakBlocks with only null pointers would still keep their
MarkedBlock alive.

This patch fixes that by detaching WeakBlocks from their MarkedBlock once a sweep discovers
that the WeakBlock contains no pointers to live objects. Ownership of the WeakBlock is passed
to the Heap, which will sweep the list of these detached WeakBlocks as part of a full GC,
destroying them once they're fully dead.

This allows the garbage collector to reclaim the 64kB MarkedBlocks much sooner, and resolves
a mysterious issue where doing two full garbage collections back-to-back would free additional
memory in the second collection.

Management of detached WeakBlocks is implemented as a Vector<WeakBlock*> in Heap, along with
an index of the next block in that vector that needs to be swept. The IncrementalSweeper then
calls into Heap::sweepNextLogicallyEmptyWeakBlock() to sweep one block at a time.

  • heap/Heap.h:
  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage): Add a final pass where we sweep the logically empty WeakBlocks
owned by Heap, after everything else has been swept.

(JSC::Heap::notifyIncrementalSweeper): Set up an incremental sweep of logically empty WeakBlocks
after a full garbage collection ends. Note that we don't do this after Eden collections, since
they are unlikely to cause entire WeakBlocks to go empty.

(JSC::Heap::addLogicallyEmptyWeakBlock): Added. Interface for passing ownership of a WeakBlock
to the Heap when it's detached from a WeakSet.

(JSC::Heap::sweepAllLogicallyEmptyWeakBlocks): Helper for collectAllGarbage() that sweeps all
of the logically empty WeakBlocks owned by Heap.

(JSC::Heap::sweepNextLogicallyEmptyWeakBlock): Sweeps one logically empty WeakBlock if needed
and updates the next-logically-empty-weak-block-to-sweep index.

(JSC::Heap::lastChanceToFinalize): call sweepAllLogicallyEmptyWeakBlocks() here, since there
won't be another chance after this.

  • heap/IncrementalSweeper.h:

(JSC::IncrementalSweeper::hasWork): Deleted.

  • heap/IncrementalSweeper.cpp:

(JSC::IncrementalSweeper::fullSweep):
(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::sweepNextBlock): Restructured IncrementalSweeper a bit to simplify
adding a new sweeping stage for the Heap's logically empty WeakBlocks. sweepNextBlock() is
changed to return a bool (true if there's more work to be done.)

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::sweep): This now figures out if the WeakBlock is logically empty, i.e doesn't
contain any pointers to live objects. The answer is stored in a new SweepResult member.

  • heap/WeakBlock.h:

(JSC::WeakBlock::isLogicallyEmptyButNotFree): Added. Can be queried after a sweep to determine
if the WeakBlock could be detached from the MarkedBlock.

(JSC::WeakBlock::SweepResult::SweepResult): Deleted in favor of initializing member variables
when declaring them.

12:43 Changeset [182199] by rniwa@webkit.org
  • 4 edits in trunk/Websites/perf.webkit.org

REGRESSION: Searching commits can highlight wrong data points
https://bugs.webkit.org/show_bug.cgi?id=143272

Reviewed by Antti Koivisto.

The bug was caused by /api/commits returning commit times with millisecond precision whereas /api/runs
return commit times with only second precision. This resulted in the frontend code to match a commit
with the data point that included the next commit when the millisecond component of commit's timestamp
wasn't identically 0.

This discrepancy was caused by the fact PHP's strtotime only ignores milliseconds and /api/commits
was returning timestamp as string instead of parsing via Database::to_js_time as done in /api/runs
so miliseconds component was only preserved in /api/commits.

Fixed the bug by always using Database::to_js_time to return commit time. Also fixed to_js_time so that
it returns time in milisecond precision.

  • public/api/commits.php:

(fetch_commits_between): Use Database::to_js_time for format commit times.
(format_commit): Ditto.

  • public/include/db.php:

(Database::to_js_time): Parse and append millisecond component. Ignore sub-milliseconds for simplicity.

  • public/v2/data.js:

(CommitLogs.fetchForTimeRange): The commit time is now an integer so don't call "replace" on it.

12:42 Changeset [182198] by rniwa@webkit.org
  • 19 edits
    2 adds in trunk/Source/JavaScriptCore

eval("this.foo") causes a crash if this had not been initialized in a derived class's constructor
https://bugs.webkit.org/show_bug.cgi?id=142883

Reviewed by Filip Pizlo.

The crash was caused by eval inside the constructor of a derived class not checking TDZ.

Fixed the bug by adding a parser flag that forces the TDZ check to be always emitted when accessing "this"
in eval inside a derived class' constructor.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::getSlow):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ThisNode::emitBytecode):

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluate):

  • interpreter/Interpreter.cpp:

(JSC::eval):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::thisExpr):

  • parser/NodeConstructors.h:

(JSC::ThisNode::ThisNode):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parsePrimaryExpression):

  • parser/Parser.h:

(JSC::parse):

  • parser/ParserModes.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::thisExpr):

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):

  • runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey):

  • runtime/Executable.cpp:

(JSC::EvalExecutable::create):

  • runtime/Executable.h:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createEvalCodeBlock):

  • runtime/JSGlobalObject.h:
  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

  • tests/stress/class-syntax-no-tdz-in-eval.js: Added.
  • tests/stress/class-syntax-tdz-in-eval.js: Added.
12:32 Changeset [182197] by commit-queue@webkit.org
  • 8 edits
    7 adds in trunk

border-image with 'fill' keyword does not fill the middle area unless the border width is greater than zero.
https://bugs.webkit.org/show_bug.cgi?id=142650.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-03-31
Reviewed by Simon Fraser.

Source/WebCore:

The decoration of a RenderBox, a RenderTable or an InlineFlowBox should be
drawn if its RenderStyle has a non-zero width border or the border-image
has the keyword fill.

Tests: fast/borders/border-image-fill-inline-no-border.html

fast/borders/border-image-fill-no-border.html

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintBoxDecorations):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasBoxDecorationStyle):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::paintBoxDecorations):

  • rendering/style/BorderData.h:

(WebCore::BorderData::hasFill):

  • rendering/style/RenderStyle.h:

LayoutTests:

Add tests to ensure the middle area of a RenderBox is going to be drawn
even if the border width is not greater than zero.

  • fast/borders/border-image-fill-inline-no-border-expected.html: Added.
  • fast/borders/border-image-fill-inline-no-border.html: Added.
  • fast/borders/border-image-fill-no-border-expected.html: Added.
  • fast/borders/border-image-fill-no-border.html: Added.
  • fast/borders/resources/button-border-cropped.svg: Added.
  • fast/borders/resources/button-border.svg: Added.
  • fast/borders/resources/svg-100x100-intrinsic.svg: Added.
12:25 Changeset [182196] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed build fix.

  • WebCore.vcxproj/WebCore.vcxproj:

Don't include inspector files twice in debug builds.
InspectorAllInOne.cpp is now used on debug builds.

12:14 Changeset [182195] by hyatt@apple.com
  • 3 edits
    4 adds in trunk

[New Block-Inside-Inline Model] Anonymous inline-blocks should size as though they are block-level.
https://bugs.webkit.org/show_bug.cgi?id=143271

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/block/inside-inlines/block-width-check.html.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent):
Return false when an anonymous inline-block is encountered, since we want to treat it like a regular
block instead.

LayoutTests:

  • fast/block/inside-inlines/block-width-check-expected.html: Added.
  • fast/block/inside-inlines/block-width-check.html: Added.
  • fast/block/inside-inlines/new-model/block-width-check-expected.html: Added.
  • fast/block/inside-inlines/new-model/block-width-check.html: Added.
12:03 Changeset [182194] by cdumez@apple.com
  • 14 edits
    1 add in trunk/Source/WebKit2

[WK2][iOS] Extend ProcessThrottler use to the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=143249
<rdar://problem/20231539>

Reviewed by Gavin Barraclough.

Extend ProcessThrottler use to the NetworkProcess instead of only the
WebProcesses. This is needed so that the NetworkProcess gets notified
before suspension. We now use this notification to free-up memory
before suspending by calling the critical memory pressure handler, as
we already do for WebProcesses (rdar://problem/20231539). In the
future, this infrastructure will be used to delay suspension until the
pending SQL transactions are done as well (rdar://problem/20180799).

Previously, the NetworkProcessProxy would hold a foreground assertion
on behalf of the NetworkProcess but would never release that assertion.
In this patch, we change this so that WebProcessProxies hold assertions
on behalf of the NetworkProcess, and release those assertions before
suspending. As a result, the NetworkProcess gets suspended when all
WebProcesses are suspended.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::processWillSuspend):
(WebKit::NetworkProcess::cancelProcessWillSuspend):
(WebKit::NetworkProcess::processDidResume):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::didFinishLaunching):
(WebKit::NetworkProcessProxy::sendProcessWillSuspend):
(WebKit::NetworkProcessProxy::sendCancelProcessWillSuspend):
(WebKit::NetworkProcessProxy::didCancelProcessSuspension):
(WebKit::NetworkProcessProxy::sendProcessDidResume):
(WebKit::NetworkProcessProxy::processReadyToSuspend):

  • UIProcess/Network/NetworkProcessProxy.h:

(WebKit::NetworkProcessProxy::throttler):

  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::ProcessThrottler):
(WebKit::ProcessThrottler::didConnectToProcess):
(WebKit::ProcessThrottler::didConnnectToProcess): Deleted.

  • UIProcess/ProcessThrottler.h:
  • UIProcess/ProcessThrottlerClient.h: Added.

(WebKit::ProcessThrottlerClient::~ProcessThrottlerClient):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):
(WebKit::WebProcessProxy::initializeNetworkProcessActivityToken):
(WebKit::WebProcessProxy::sendProcessDidResume):
(WebKit::WebProcessProxy::processReadyToSuspend):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
12:01 Changeset [182193] by commit-queue@webkit.org
  • 27 edits
    13 deletes in trunk/Source

Unreviewed, rolling out r182186.
https://bugs.webkit.org/show_bug.cgi?id=143270

it crashes all the WebGL tests on the Debug bots (Requested by
dino on #webkit).

Reverted changeset:

"Web Inspector: add 2D/WebGL canvas instrumentation
infrastructure"
https://bugs.webkit.org/show_bug.cgi?id=137278
http://trac.webkit.org/changeset/182186

11:53 Changeset [182192] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Crash in CGContextShowGlyphsWithAdvances when passing kCGFontIndexInvalid
https://bugs.webkit.org/show_bug.cgi?id=143114

This is a workaround for <rdar://problem/20230073>. Please remove when it is no longer necessary.

Reviewed by Alexey Proskuryakov.

Covered by:
compositing/regions/floated-region-with-transformed-child.html
compositing/regions/floated-region-with-transformed-child-expected.html
fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html
fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html
fast/regions/overflow/overflow-content-transform-rotate.html
fast/regions/overflow/overflow-content-transform-rotate-expected.html

  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::shrink): Performing shaping may remove glyphs, so we need to shrink the GlyphBuffer.

  • platform/graphics/WidthIterator.cpp:

(WebCore::applyFontTransforms): Filter out kCGFontIndexInvalid.
(WebCore::WidthIterator::advanceInternal): Moved code into applyFontTransforms, and trigger the
shrink of the GlyphBuffer.

11:26 Changeset [182191] by bdakin@apple.com
  • 3 edits
    4 adds in trunk

REGRESSION (r173484): Reducing content of scrollable region does not reset scroll
position
https://bugs.webkit.org/show_bug.cgi?id=138525
-and corresponding-
rdar://problem/18166043

Reviewed by Simon Fraser.

Source/WebCore:

The change that caused this regression was correct. That change does not allow
RenderLayer to update scroll position after a layout if a rubber-band is currently
happening. The change caused this regression because all of the member variables
in ScrollController that attempt to keep track of the current state of the scroll
gesture (m_inScrollGesture, m_momentumScrollInProgress, and
m_snapRubberbandTimerIsActive) all indicated that a momentum scroll gesture was
still in action for this div even though it very much is not when the bug happens.
Those variables were never properly re-set because the
PlatformWheelEventPhaseEnded events never got dispatched to the ScrollController,
which brought the investigation back to Element.

We must still dispatch events that have zero delta so that the default event
handlers can handle them, but we should stopPropagation() so that these events are
not sent to the DOM. Websites will break if they get wheel events with no delta.

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

LayoutTests:

  • platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-reduced-content-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-reduced-content.html: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/scrolling/overflow-scroll-zero-delta-wheel-events.html: Added.
11:22 Changeset [182190] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed debug build fix after r182186.

  • WebCore.vcxproj/WebCore.vcxproj:

Include InspectorAllInOne.cpp in debug builds.

10:44 Changeset [182189] by utatane.tea@gmail.com
  • 8 edits
    10 adds in trunk

[ES6] Object type restrictions on a first parameter of several Object.* functions are relaxed
https://bugs.webkit.org/show_bug.cgi?id=142937

Reviewed by Darin Adler.

Source/JavaScriptCore:

In ES6, Object type restrictions on a first parameter of several Object.* functions are relaxed.
In ES5 or prior, when a first parameter is not object type, these functions raise TypeError.
But now, several functions perform ToObject onto a non-object parameter.
And others behaves as if a parameter is a non-extensible ordinary object with no own properties.
It is described in ES6 Annex E.
Functions different from ES5 are following.

  1. An attempt is make to coerce the argument using ToObject.

Object.getOwnPropertyDescriptor
Object.getOwnPropertyNames
Object.getPrototypeOf
Object.keys

  1. Treated as if it was a non-extensible ordinary object with no own properties.

Object.freeze
Object.isExtensible
Object.isFrozen
Object.isSealed
Object.preventExtensions
Object.seal

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructorGetPrototypeOfFunctor::operator()):
(JSC::objectConstructorGetPrototypeOf):
(JSC::objectConstructorGetOwnPropertyDescriptor):
(JSC::objectConstructorGetOwnPropertyNames):
(JSC::objectConstructorKeys):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):
(JSC::objectConstructorPreventExtensions):
(JSC::objectConstructorIsSealed):
(JSC::objectConstructorIsFrozen):
(JSC::objectConstructorIsExtensible):

  • tests/stress/object-freeze-accept-non-object.js: Added.
  • tests/stress/object-get-own-property-descriptor-perform-to-object.js: Added.

(canary):

  • tests/stress/object-get-own-property-names-perform-to-object.js: Added.

(compare):

  • tests/stress/object-get-prototype-of-perform-to-object.js: Added.
  • tests/stress/object-is-extensible-accept-non-object.js: Added.
  • tests/stress/object-is-frozen-accept-non-object.js: Added.
  • tests/stress/object-is-sealed-accept-non-object.js: Added.
  • tests/stress/object-keys-perform-to-object.js: Added.

(compare):

  • tests/stress/object-prevent-extensions-accept-non-object.js: Added.
  • tests/stress/object-seal-accept-non-object.js: Added.

LayoutTests:

Several LayoutTests are updated with the new behavior.
Test cases in IETestCenter contain test for the outdated behavior.
But IETestCenter is brought from the external source, so instead of modifying it,
we mark them as Failure in TestExpectations.

  • TestExpectations:
  • js/dom/getOwnPropertyDescriptor-expected.txt:
  • js/prototypes-expected.txt:
  • js/resources/getOwnPropertyDescriptor.js:
  • js/script-tests/prototypes.js:
10:42 Changeset [182188] by hyatt@apple.com
  • 8 edits
    4 adds in trunk

[New Block-Inside-Inline Model] Make sure line breaks occur before and after the anonymous inline-block.
https://bugs.webkit.org/show_bug.cgi?id=143238.

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/blocks/inside-inlines/breaking-behavior.html (and new-model equivalent).

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):
(WebCore::InlineFlowBox::hasAnonymousInlineBlock):
(WebCore::InlineFlowBox::setHasAnonymousInlineBlock):
Add a bit to root line boxes (stored in the InlineFlowBox since it has free bits) that indicates whether
or not a line is an anonymous inline-block line.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths):
Patch the preferred logical width computation to break both before and after an anonymous inline-block.
Also make sure to strip trailing spaces from the line before the anonymous inline-block.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::constructLine):
Patch line construction so that no intermediate boxes are constructed between the InlineBox for the anonymous
inline-block and the root line box.

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::ascentAndDescentForBox):
The height of a "line" that holds an anonymous inline-block should ignore line-box-contain and also make sure
that the margins of the replaced element are "outside" the line, since those margins will collapse.

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleReplaced):
Patch handleReplaced to make sure breaks occur both before and after an anonymous inline-block. In the case of
a break after the block, we setPreviousLineBrokeCleanly to true so that <br>s that follow the anonymous inline-block
are respected.

LayoutTests:

  • fast/block/inside-inlines/breaking-behavior-expected.html: Added.
  • fast/block/inside-inlines/breaking-behavior.html: Added.
  • fast/block/inside-inlines/new-model/breaking-behavior-expected.html: Added.
  • fast/block/inside-inlines/new-model/breaking-behavior.html: Added.
  • fast/block/inside-inlines/new-model/empty-block.html:
10:32 Changeset [182187] by ossy@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Add nullptr check to GraphicsContext3D::makeContextCurrent()
https://bugs.webkit.org/show_bug.cgi?id=143214

Reviewed by Žan Doberšek.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::makeContextCurrent):

10:23 Changeset [182186] by commit-queue@webkit.org
  • 27 edits
    13 adds in trunk/Source

Web Inspector: add 2D/WebGL canvas instrumentation infrastructure
https://bugs.webkit.org/show_bug.cgi?id=137278

Patch by Matt Baker <mattbaker@apple.com> on 2015-03-31
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Added Canvas protocol which defines types used by InspectorCanvasAgent.

  • CMakeLists.txt:
  • DerivedSources.make:
  • inspector/protocol/Canvas.json: Added.
  • inspector/scripts/codegen/generator.py:

(Generator.stylized_name_for_enum_value):
Added special handling for 2D (always uppercase) and WebGL (rename mapping) enum strings.

Source/WebCore:

Added backend agent for canvas inspection. A canvas is instrumented once its CanvasRenderingContext has been
created. WebGLRenderingContext is instrumented to track the lifetime of shader program objects.

To instrument off-screen rendering contexts (CSS canvases and detached canvas elements), the canvas agent must
track all CanvasRenderingContexts as they are created, even in the absense of the frontend. As far as I know,
there is no practical way to identify rendering contexts belonging to a frame that are not in the DOM. In the
absence of the inspector frontend the agent does only the minimum required to track the lifetime of rendering
contexts and their resources, to avoid creating a negative performance impact.

Tests: inspector/canvas/canvas-add-remove-events.html

inspector/canvas/canvas-context-attributes.html
inspector/canvas/canvas-css-name.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::getCSSCanvasElement):
Instrumentation for CSS canvases.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):
Instrumentation for context creation.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::attachShader):
(WebCore::WebGLRenderingContextBase::createProgram):
(WebCore::WebGLRenderingContextBase::deleteProgram):
(WebCore::WebGLRenderingContextBase::detachShader):
Instrumentation for programs and shaders.

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorCanvasAgent.cpp: Added.

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::didCreateFrontendAndBackend):
(WebCore::InspectorCanvasAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorCanvasAgent::frameNavigated):
(WebCore::InspectorCanvasAgent::didCreateCSSCanvas):
(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
(WebCore::InspectorCanvasAgent::didAttachShader):
(WebCore::InspectorCanvasAgent::didDetachShader):
(WebCore::InspectorCanvasAgent::didCreateProgram):
(WebCore::InspectorCanvasAgent::didDeleteProgram):
(WebCore::InspectorCanvasAgent::getCanvases):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::canvasDestroyedTimerFired):
(WebCore::InspectorCanvasAgent::reset):
(WebCore::InspectorCanvasAgent::getCanvasEntry):
(WebCore::InspectorCanvasAgent::getProgramEntry):
(WebCore::InspectorCanvasAgent::removeShaderFromShaderMap):
(WebCore::InspectorCanvasAgent::contextTypeJson):
(WebCore::InspectorCanvasAgent::buildObjectForCanvas):

  • inspector/InspectorCanvasAgent.h: Added.

New backend agent.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Support for new backend agent.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didCreateCSSCanvasImpl):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContextImpl):
(WebCore::InspectorInstrumentation::didAttachShaderImpl):
(WebCore::InspectorInstrumentation::didDetachShaderImpl):
(WebCore::InspectorInstrumentation::didCreateProgramImpl):
(WebCore::InspectorInstrumentation::didDeleteProgramImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderingContext):
Plumbing for canvas instrumentation.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didCreateCSSCanvas):
(WebCore::InspectorInstrumentation::didCreateCanvasRenderingContext):
(WebCore::InspectorInstrumentation::didAttachShader):
(WebCore::InspectorInstrumentation::didDetachShader):
(WebCore::InspectorInstrumentation::didCreateProgram):
(WebCore::InspectorInstrumentation::didDeleteProgram):

  • inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::InstrumentingAgents):
(WebCore::InstrumentingAgents::reset):

  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorCanvasAgent):
(WebCore::InstrumentingAgents::setInspectorCanvasAgent):
Support for new backend agent.

Source/WebInspectorUI:

Added models, views, and controller classes for 2D and WebGL canvas inspection. Each canvas is shown in the
Resources navigation sidebar under its parent frame. Shader programs are displayed as child nodes of
their respective canvas. Canvases will get an associated content view and details sidebar in a later patch
(see https://bugs.webkit.org/show_bug.cgi?id=138941).

Shader programs will get an associated content view for editing shader source in a later patch (see
https://bugs.webkit.org/show_bug.cgi?id=138593). Individual shaders are not shown in the Resource navigation
sidebar, and at this time there are no plans to instrument shaders that aren't attached to a program.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.sidebarPanelForRepresentedObject):

  • UserInterface/Base/Test.js:

(WebInspector.loaded):

  • UserInterface/Main.html:
  • UserInterface/Test.html:

Updated for new canvas/shader program types.

  • UserInterface/Controllers/CanvasManager.js: Added.

(WebInspector.CanvasManager):
(WebInspector.CanvasManager.prototype.canvasesForFrame):
(WebInspector.CanvasManager.prototype.canvasAdded.set this):
(WebInspector.CanvasManager.prototype.canvasAdded):
(WebInspector.CanvasManager.prototype.canvasRemoved):
(WebInspector.CanvasManager.programDeleted.get console):
(WebInspector.CanvasManager.prototype.programCreated.get console):
(WebInspector.CanvasManager.prototype.programCreated):
(WebInspector.CanvasManager.prototype._mainResourceDidChange):
Frontend controller for canvases and their shader programs.

  • UserInterface/Images/Canvas.svg: Added.
  • UserInterface/Images/DocumentGL.png: Added.
  • UserInterface/Images/DocumentGL@2x.png: Added.

New art for canvas and shader program tree elements.

  • UserInterface/Models/Canvas.js: Added.

(WebInspector.Canvas):
(WebInspector.Canvas.prototype.set fromPayload):
(WebInspector.Canvas.displayNameForContextType):
(WebInspector.Canvas.resetUniqueDisplayNameNumbers):
(WebInspector.Canvas.prototype.get id):
(WebInspector.Canvas.prototype.get parentFrame):
(WebInspector.Canvas.prototype.get name):
(WebInspector.Canvas.prototype.get cssCanvas):
(WebInspector.Canvas.prototype.get contextType):
(WebInspector.Canvas.prototype.get contextAttributes):
(WebInspector.Canvas.prototype.get programs):
(WebInspector.Canvas.prototype.get displayName):
(WebInspector.Canvas.programForId):
(WebInspector.Canvas.get programWasCreated.set this):
(WebInspector.Canvas.prototype.get programWasCreated):
(WebInspector.Canvas.prototype.programWasDeleted):
(WebInspector.Canvas.prototype.saveIdentityToCookie):
Model for DOM or CSS canvas (2D or WebGL).

  • UserInterface/Models/ShaderProgram.js: Added.

(WebInspector.ShaderProgram):
(WebInspector.ShaderProgram.prototype.get id):
(WebInspector.ShaderProgram.prototype.get canvas):
(WebInspector.ShaderProgram.prototype.get displayName):
(WebInspector.ShaderProgram.prototype.saveIdentityToCookie):
(WebInspector.ShaderProgram.prototype.updateCanvas):

  • UserInterface/Models/WebGLContextAttributes.js: Added.

(WebInspector.WebGLContextAttributes):
(WebInspector.WebGLContextAttributes.fromPayload):
(WebInspector.WebGLContextAttributes.prototype.get alpha):
(WebInspector.WebGLContextAttributes.prototype.get depth):
(WebInspector.WebGLContextAttributes.prototype.get stencil):
(WebInspector.WebGLContextAttributes.prototype.get antialias):
(WebInspector.WebGLContextAttributes.prototype.get premultipliedAlpha):
(WebInspector.WebGLContextAttributes.prototype.get preserveDrawingBuffer):
Model for WebGL canvas context attributes.

  • UserInterface/Protocol/CanvasObserver.js: Added.

(WebInspector.CanvasObserver.prototype.canvasAdded):
(WebInspector.CanvasObserver.prototype.canvasRemoved):
(WebInspector.CanvasObserver.prototype.programCreated):
(WebInspector.CanvasObserver.prototype.programDeleted):
(WebInspector.CanvasObserver):
Model for WebGL canvas shader program.

  • UserInterface/Views/CanvasTreeElement.js: Added.

(WebInspector.CanvasTreeElement.validateRepresentedObject):
(WebInspector.CanvasTreeElement.countChildren):
(WebInspector.CanvasTreeElement):
(WebInspector.CanvasTreeElement.prototype.onexpand):
(WebInspector.CanvasTreeElement.prototype.oncollapse):
(WebInspector.CanvasTreeElement.prototype.onpopulate):
(WebInspector.CanvasTreeElement.prototype._programWasCreated):
(WebInspector.CanvasTreeElement.prototype._programWasDeleted):
Folderized tree element for canvases and their child objects (shader programs).

  • UserInterface/Views/FrameTreeElement.js:

(WebInspector.FrameTreeElement.prototype.onattach):
(WebInspector.FrameTreeElement.prototype.ondetach):
(WebInspector.FrameTreeElement.prototype.onpopulate):
(WebInspector.FrameTreeElement.prototype._canvasesAvailable):
(WebInspector.FrameTreeElement.prototype._canvasWasAdded):
(WebInspector.FrameTreeElement.prototype._canvasWasRemoved):
Updated to support canvas tree elements.

  • UserInterface/Views/ResourceIcons.css:

(.canvas-icon .icon):
(.shader-program-icon .icon):
Styles for new canvas and shader program icons.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
Updated for new tree element types.

  • UserInterface/Views/ShaderProgramTreeElement.js: Added.

(WebInspector.ShaderProgramTreeElement):
Tree element for shader programs. Shown as children of CanvasTreeElement.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
10:17 Changeset [182185] by rniwa@webkit.org
  • 4 edits in trunk/Websites/perf.webkit.org

Perf dashboard should show relative change in values
https://bugs.webkit.org/show_bug.cgi?id=143252

Reviewed by Antti Koivisto.

When a range of values are selected, show the percentage difference between the start and the end
in addition to the absolute value difference. When a single point is selected, show the relative
difference with respect to the previous point. Use two significant figures and always show plus sign
when the difference is positive.

  • public/v2/app.js: Compute and format the relative difference.
  • public/v2/chart-pane.css: Don't let commits view shrink itself when they're all collapsed.
  • public/v2/index.html: Show the relative difference.
10:16 Changeset [182184] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

REGRESSION(r180000): Changing moving average or enveloping strategy doesn't update the graph
https://bugs.webkit.org/show_bug.cgi?id=143254

Reviewed by Antti Koivisto.

The bug was caused by App.Pane no longer replacing 'chartData' property when updating the moving average
or the enveloping values. Fixed the bug by creating a new chartData object when the strategy is changed
so that the interactive chart component will observe a change to 'chartData'.

  • public/v2/app.js:

(App.Pane._movingAverageOrEnvelopeStrategyDidChange): Added.

05:35 Changeset [182183] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

GTK+ Gardening 30th March
https://bugs.webkit.org/show_bug.cgi?id=143220

Unreviewed.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-31

  • platform/gtk/TestExpectations:
05:23 Changeset [182182] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, revert accidental change by r182138.

  • Scripts/generate-forwarding-headers.pl:

(createForwardingHeadersForFramework):

03:59 Changeset [182181] by antti@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html failing on Mavericks wk2 debug
https://bugs.webkit.org/show_bug.cgi?id=143258

The test relies on resource priorities. Those don't roundtrip when serializing via NSURLRequest on Mavericks due
to ResourceRequest::resourcePrioritiesEnabled() returning false.

It is bit surprising it works on release but not on debug. I suspect some debug code forces NSURLRequest construction
and so we end up on the roundtrip code path.

  • platform/mac-mavericks/TestExpectations: Added.

Skip the test on Mavericks.

03:09 Changeset [182180] by youenn.fablet@crf.canon.fr
  • 20 edits
    3 copies
    3 adds in trunk

[Streams API] Implement a barebone ReadableStreamReader interface
https://bugs.webkit.org/show_bug.cgi?id=142866

Reviewed by Benjamin Poulain.

Source/WebCore:

This patch implements a barebone ReadableStreamReader as described in https://streams.spec.whatwg.org/#reader-class.
It implements the IDL without implementing most of the functionality behind.
It implements ReadableStreamReader JS constructor and the link with ReadableStream.getReader:

  • Raise an error if stream is already locked
  • Set the stream reader to the newly created ReadableStreamReader instance.

Test: streams/readablestreamreader-constructor.html

  • CMakeLists.txt: Adding ReadableStreamReader files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • Modules/streams/ReadableStream.cpp:

(WebCore::ReadableStream::createReader): Used by JS binding to get access to the reader.

  • Modules/streams/ReadableStream.h: Declaration of createReader, reader and lock.

(WebCore::ReadableStream::reader):
(WebCore::ReadableStream::lock):

  • Modules/streams/ReadableStream.idl: Cleaning-up the IDL.
  • Modules/streams/ReadableStreamReader.cpp: Added.

(WebCore::ReadableStreamReader::create):
(WebCore::ReadableStreamReader::ReadableStreamReader):
(WebCore::ReadableStreamReader::~ReadableStreamReader):
(WebCore::ReadableStreamReader::closed):
(WebCore::ReadableStreamReader::activeDOMObjectName):
(WebCore::ReadableStreamReader::canSuspend):

  • Modules/streams/ReadableStreamReader.h: Added.

(WebCore::ReadableStreamReader::stream):

  • Modules/streams/ReadableStreamReader.idl: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::JSReadableStream::getReader):

  • bindings/js/JSReadableStreamReaderCustom.cpp: Added.

(WebCore::JSReadableStreamReader::read):
(WebCore::getOrCreatePromiseDeferredFromObject):
(WebCore::closedPromiseSlotName):
(WebCore::JSReadableStreamReader::closed):
(WebCore::JSReadableStreamReader::cancel):
(WebCore::JSReadableStreamReader::releaseLock):
(WebCore::constructJSReadableStreamReader):

LayoutTests:

Adding tests to check API, constructor and link with ReadableStream.getReader.
Rebasing of global-constructors-attributes.html to include ReadableStreamReader.

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
  • streams/readablestreamreader-constructor-expected.txt: Added.
  • streams/readablestreamreader-constructor.html: Added.
03:05 Changeset [182179] by lforschler@apple.com
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

unreviewed config fix after r182178.

02:19 Changeset [182178] by ossy@webkit.org
  • 4 edits in trunk/Tools

[EFL] Add AArch64 builder and tester bot to build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=143092

Reviewed by Gyuyoung Kim.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
01:58 Changeset [182177] by youenn.fablet@crf.canon.fr
  • 4 edits
    1 add in trunk/Tools

[buildbot] clean-build script should remove untracked files and revert local changes too
https://bugs.webkit.org/show_bug.cgi?id=142400

Reviewed by Ryosuke Niwa.

This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
A helper routine SCM.discard_untracked_files is added for that purpose.

  • BuildSlaveSupport/clean-build:

(main): Making call to Scripts/clean-webkit

  • Scripts/clean-webkit: Added.

(main): Revert changes and delete untracked files.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_discard_untracked_files):
(test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.

01:37 Changeset [182176] by carlosgc@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix GTK+ build with REDIRECTED_XCOMPOSITE_WINDOW disabled in X11 platform.

Also fix some unused parameter warnings when
REDIRECTED_XCOMPOSITE_WINDOW is disabled.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewRenderAcceleratedCompositingResults):
(resizeWebKitWebViewBaseFromAllocation):

00:49 Changeset [182175] by carlosgc@webkit.org
  • 6 edits
    2 deletes in trunk/Source

[GTK] DnD icon/widget has odd background
https://bugs.webkit.org/show_bug.cgi?id=143217

Reviewed by Martin Robinson.

Source/WebCore:

Remove DragIcon class since it's no longer needed with GTK+3 and
the GTK+2 code there is unused. GTK+ knows what to do with a cairo
surface, I guess we migrated the GTK+2 code to GTK+3 without
realizing that using the surface was enough.

  • PlatformGTK.cmake:
  • platform/gtk/DragIcon.cpp: Removed.
  • platform/gtk/DragIcon.h: Removed.

Source/WebKit2:

Use gtk_drag_set_icon_surface() to set the drag icon image,
instead of DragIcon class.

  • UIProcess/API/gtk/WebKitWebView.cpp:
  • UIProcess/gtk/DragAndDropHandler.cpp:

(WebKit::DragAndDropHandler::startDrag):

  • UIProcess/gtk/DragAndDropHandler.h:
00:34 Changeset [182174] by youenn.fablet@crf.canon.fr
  • 5 edits in trunk/Tools

Python SCM should be able to retrieve untracked files
https://bugs.webkit.org/show_bug.cgi?id=143135

Reviewed by Ryosuke Niwa.

This patch introduces SCM.untracked_files to retrieve a list of untracked files.
Ignored files may be included or not in this list according boolean passed to the function.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.untracked_files):

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.untracked_files):

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_untracked_files):
(test_untracked_files):
(GitSVNTest.test_untracked_files):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.untracked_files):

03/30/15:

20:27 Changeset [182173] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r182172.
https://bugs.webkit.org/show_bug.cgi?id=143250

Since this class is an API object, we don't know for sure when
it will be destroyed. (Requested by kling on #webkit).

Reverted changeset:

"WebBackForwardList doesn't need to manually clear the
snapshot of an entry when removing it."
https://bugs.webkit.org/show_bug.cgi?id=143231
http://trac.webkit.org/changeset/182172

20:02 Changeset [182172] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

WebBackForwardList doesn't need to manually clear the snapshot of an entry when removing it.
<https://webkit.org/b/143231>

Reviewed by Tim Horton.

Now that we don't keep WebBackForwardListItem objects alive forever, it's not necessary
to clear the snapshot when removing them from the WebBackForwardList, since the entire
object will be deleted shortly after that anyway.

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::didRemoveItem):

18:59 Changeset [182171] by rniwa@webkit.org
  • 9 edits in trunk

Extending null should set proto to null
https://bugs.webkit.org/show_bug.cgi?id=142882

Reviewed by Geoffrey Garen and Benjamin Poulain.

Source/JavaScriptCore:

Set Derived.prototype.proto to null when extending null.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

LayoutTests:

Added more test cases for extending from null, and added checks for prototypes.

Also rebaselined existing tests.

  • js/class-syntax-call-expected.txt:
  • js/class-syntax-extends-expected.txt:
  • js/class-syntax-super-expected.txt:
  • js/script-tests/class-syntax-call.js:
  • js/script-tests/class-syntax-extends.js:
  • js/script-tests/class-syntax-super.js:
18:21 Changeset [182170] by msaboff@apple.com
  • 2 edits in trunk/PerformanceTests/SunSpider

Fix failing v8-deltablue.js for ARM
https://bugs.webkit.org/show_bug.cgi?id=138392

Rubber-stamped by Mark Lam.

Re-enable this test for ARM32 on iOS as the tests now run without issues.

  • tests/v8-v6/v8-deltablue.js:
18:09 Changeset [182169] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r182168.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
Explicitly cast to unsigned.

17:48 Changeset [182168] by achristensen@apple.com
  • 13 edits
    3 adds in trunk

[Content Extensions] Correctly handle regular expressions matching everything
https://bugs.webkit.org/show_bug.cgi?id=143235

Reviewed by Benjamin Poulain.

Source/WebCore:

Test: http/tests/contentextensions/whitelist.html

  • contentextensions/CompiledContentExtension.cpp:

(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors):
Global actions can have non-css actions. Only put the selectors into the list of selectors.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeSelector):
(WebCore::ContentExtensions::serializeActions):
Merge sequential css selectors with identical triggers (usually .*) into one action to reduce the number of actions.
(WebCore::ContentExtensions::compileRuleList):
Fail if a regular expression matches everything after ignore-previous-rules.

  • contentextensions/ContentExtensionError.cpp:

(WebCore::ContentExtensions::contentExtensionErrorCategory):

  • contentextensions/ContentExtensionError.h:

Add more failure cases.

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Trigger::operator==):
Allow comparing of Triggers to determine if sequential triggers are equal.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
Put non-css actions that match everything into the list of actions if ignore-previous-rules was not hit.
These actions will be out of order, but order only matters when determining if ignore-previous-rules, and this case is handled correctly.

  • contentextensions/DFABytecodeInterpreter.cpp:

(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
Added an assertion that all actions that match everything should be in the first DFA root.
We should catch them all with URLFilterParser::MatchesEverything.

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::checkCompilerError):
(TestWebKitAPI::TEST_F):
Test ContentExtensionErrors.

LayoutTests:

  • http/tests/contentextensions/css-display-none.html:
  • http/tests/contentextensions/css-display-none.html.json:

Test multiple selectors with triggers that match everything.

  • http/tests/contentextensions/whitelist-expected.txt: Added.
  • http/tests/contentextensions/whitelist.html: Added.
  • http/tests/contentextensions/whitelist.html.json: Added.
17:43 Changeset [182167] by mark.lam@apple.com
  • 8 edits in trunk

REGRESSION (r181993): inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html crashes.
<https://webkit.org/b/143105>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

With r181993, the DFG and FTL may elide the storing of the scope register. As a result,
on OSR exits from DFG / FTL frames where this elision has take place, we may get baseline
JIT frames that may have its scope register not set. The Debugger's current implementation
which relies on the scope register is not happy about this. For example, this results in a
crash in the layout test inspector-protocol/debugger/setBreakpoint-dfg-and-modify-local.html.

The fix is to disable inlining when the debugger is in use. Also, we add Flush nodes to
ensure that the scope register value is flushed to the register in the stack frame.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::setLocal):
(JSC::DFG::ByteCodeParser::flush):

  • Add code to flush the scope register.

(JSC::DFG::ByteCodeParser::inliningCost):

  • Pretend that all codeBlocks are too expensive to inline if the debugger is in use, thereby disabling inlining whenever the debugger is in use.
  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::hasDebuggerEnabled):

  • dfg/DFGStackLayoutPhase.cpp:

(JSC::DFG::StackLayoutPhase::run):

  • Update the DFG codeBlock's scopeRegister since it can be moved during stack layout.
  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • Update the FTL codeBlock's scopeRegister since it can be moved during stack layout.

LayoutTests:

17:33 Changeset [182166] by ap@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
https://bugs.webkit.org/show_bug.cgi?id=143241
rdar://problem/20351297

Reviewed by Mark Lam.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
17:29 Changeset [182165] by gyuyoung.kim@samsung.com
  • 4 edits in trunk

[CMake][EFL] Remove redundant library link and include path
https://bugs.webkit.org/show_bug.cgi?id=143221

Reviewed by Csaba Osztrogonác.

Source/WTF:

  • wtf/PlatformEfl.cmake: Remove unnecessary library link and include path.

Tools:

  • ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
16:59 Changeset [182164] by mmaxfield@apple.com
  • 7 edits
    1 move in trunk/Source/WebCore

Allow building on Windows without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=143219

Reviewed by Brent Fulgham.

  • AVFoundationSupport.py: Renamed from Source/WebCore/WebCore.vcxproj/MigrateScripts.

Move logic from DerivedSources.make to its own script
(lookFor):

  • DerivedSources.make: Paths like /usr/bin don't exist on Windows.

Windows uses del instead of rm -f
Windows doesn't have printf

  • WebCore.vcxproj/WebCoreGenerated.make: Pass the CC executable to

build-generated-files.pl

  • WebCore.vcxproj/build-generated-files.pl: Export the CC executable as an environment

variable. Don't use /usr/bin.

  • WebCore.vcxproj/migrate-scripts.pl: Deleted the MigrateScripts makefile. We don't

need a whole Makefile just to copy 5 files. Moved this logic into migrate-scripts.pl.
(copyFile):

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): Support passing preprocessing flags to the Visual Studio
compiler.

  • dom/make_names.pl: Ditto.
16:54 Changeset [182163] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/spi/mac/AVFoundationSPI.h:
16:25 Changeset [182162] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] WebContent crashing at WebCore: WebCore::Range::collectSelectionRects.
https://bugs.webkit.org/show_bug.cgi?id=143234
<rdar://problem/18571345>

Reviewed by Tim Horton.

This is a speculative fix that adds a null check before referencing the range.
In both places where the check has been added the range returned by the call
that should create it could be null.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState):

16:22 Changeset [182161] by commit-queue@webkit.org
  • 18 edits
    2 copies
    1 add in trunk

[Content Extensions] Flesh out the UserContentExtensionStore
https://bugs.webkit.org/show_bug.cgi?id=143123

Patch by Sam Weinig <sam@webkit.org> on 2015-03-30
Reviewed by Benjamin Poulain.

Source/WebCore:

  • Adds a variant of getFileSize() that takes a PlatformFileHandle.
  • Adds a new file system function, rename() which operates as the POSIX rename function does.
  • platform/FileSystem.h:

Add new functions.

  • platform/posix/FileSystemPOSIX.cpp:

(WebCore::renameFile):
(WebCore::getFileSize):
Add implementations.

  • platform/gtk/FileSystemGtk.cpp:

(WebCore::renameFile):
(WebCore::getFileSize):

  • platform/win/FileSystemWin.cpp:

(WebCore::getFileSize):
(WebCore::renameFile):
Add stubs.

Source/WebKit2:

  • Shared/WebCompiledContentExtension.cpp:

(WebKit::WebCompiledContentExtension::createFromCompiledContentExtensionData):

  • Shared/WebCompiledContentExtensionData.cpp:

(WebKit::WebCompiledContentExtensionData::encode):
(WebKit::WebCompiledContentExtensionData::decode):

  • Shared/WebCompiledContentExtensionData.h:

(WebKit::WebCompiledContentExtensionData::WebCompiledContentExtensionData):
Switch the order in memory of actions and bytecode (and switch the order of the
variables as well, to keep it clear). This will become necessary when streaming
the data to disk, as actions are created before the bytecode and we would have to keep them
in memory until the bytecode was finished compiling if they didn't come before in the file.

  • UIProcess/API/APIUserContentExtensionStore.h:
  • UIProcess/API/APIUserContentExtensionStore.cpp:

(API::UserContentExtensionStore::defaultStore):
Add accessor for the processes default shared store.

(API::constructedPath):
Helper for constructing the path to a file in the store based on identifier.

(API::encodeContentExtensionMetaData):
(API::decodeContentExtensionMetaData):
Helpers for encoding/decoding the file metadata (version, bytecode size, actions size).

(API::openAndMapContentExtension):
Helper to open and map a filed back content extension.

(API::writeDataToFile):
Helper to write a Data object to a file.

(API::compiledToFile):
Helper to run the content extension compiler and write it to disk. It first
writes it to a temporary file and then does an atomic rename operation to put
the file in the final location. Doing this means that if the process crashes while
the compile is taking place, the partially written file won't end up in the cache,
but rather, will be cleaned up by the OS.

(API::UserContentExtensionStore::lookupContentExtension):
API entry point to lookup an extension that has been compiled to disk. On a background queue,
it attempts to open and map the extension (based on the identifier passed in) and return it
to the caller via the callback function passed in.

(API::UserContentExtensionStore::compileContentExtension):
API entry point to compile an extension and write it to store. On a background queue, it
compiles the file to disk and if successful, returns the memory mapped data via the callback
function passed in.

(API::UserContentExtensionStore::removeContentExtension):
API entry point to remove an extension from the store. On a background queue, it
unlinks the extension (based on the identifier passed in) and tells the caller it completed
the action vial the callback function passed in.

(API::UserContentExtensionStore::synchronousRemoveAllContentExtensions):
Helper for testing which synchronously unlinks all the files in the store.

(API::userContentExtensionStoreErrorCategory):
std::error_code adaptor for some generic errors that can happen in the store. We will want
to flesh these out further.

  • UIProcess/API/Cocoa/APIUserContentExtensionStoreCocoa.mm: Added.

(API::UserContentExtensionStore::defaultStorePath):
Helper to get the platform specific path for the store.

  • UIProcess/API/C/WKUserContentExtensionStoreRef.cpp:

(WKUserContentExtensionStoreGetTypeID):
Add ENABLE(CONTENT_EXTENSIONS) guards.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStore.mm:

(-[_WKUserContentExtensionStore dealloc]):
(+[_WKUserContentExtensionStore defaultStore]):
(-[_WKUserContentExtensionStore compileContentExtensionForIdentifier:encodedContentExtension:completionHandler:]):
(-[_WKUserContentExtensionStore lookupContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore removeContentExtensionForIdentifier:completionHandler:]):
(-[_WKUserContentExtensionStore _removeAllContentExtensions]):
(-[_WKUserContentExtensionStore init]): Deleted.

  • UIProcess/API/Cocoa/_WKUserContentExtensionStoreInternal.h:
  • UIProcess/API/Cocoa/_WKUserContentExtensionStorePrivate.h: Added.

SPI wrappers for the store.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.

Add tests for _WKUserContentExtensionStore.

16:01 Changeset [182160] by peavo@outlook.com
  • 3 edits in trunk/Source/WebCore

[WinCairo] Crash when closing window while video is loading
https://bugs.webkit.org/show_bug.cgi?id=143088

Reviewed by Mark Lam.

When the media player is destroyed, we have to cancel possible calls on the
main thread made by a worker thread. Otherwise the destroyed media player
will be accessed when performing the call.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::~MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::endCreatedMediaSource):
(WebCore::MediaPlayerPrivateMediaFoundation::endGetEvent):
(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySet):
(WebCore::MediaPlayerPrivateMediaFoundation::onCreatedMediaSourceCallback):
(WebCore::MediaPlayerPrivateMediaFoundation::onTopologySetCallback):

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
15:59 Changeset [182159] by yoon@igalia.com
  • 13 edits in trunk/Source/WebCore

[Threaded Compositor] Crash when animation changes frequently.
https://bugs.webkit.org/show_bug.cgi?id=143213

Reviewed by Simon Fraser.

CompositingCoordinator copies CoordinatedGraphicsLayerState when
flushing GraphicsLayer changes, and ThreadedCoordinatedCompositor passes
it to compositing thread.

To ensure thread-safety, we need to provide copy constructor to copy
Animation object in TextureMapperAnimation instead of referencing it.

Since TimingFunction and TransformOperation used by KeyframeValueList are
not ThreadSafeRefCounted, these should be cloned also.

No new tests needed.

  • platform/graphics/GraphicsLayer.h:

(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::FilterAnimationValue):
Adds deep copy constructor.

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::TextureMapperAnimation::TextureMapperAnimation):
Because the name of the animation can be AtomicString, we need to create
isolated version of string to ensure thread safty.

  • platform/graphics/texmap/TextureMapperAnimation.h:
  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TranslateTransformOperation.h:

Adds TransformOperation::clone() for threadsafety.

15:58 Changeset [182158] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix flakey float32-repeat-out-of-bounds.js and int8-repeat-out-of-bounds.js tests for ARM64
https://bugs.webkit.org/show_bug.cgi?id=138391

Reviewed by Mark Lam.

Re-enabling these tests as I can't get them to fail on local iOS test devices.
There have been many changes since these tests were disabled.
I'll watch automated test results for failures. If there are failures running automated
testing, it might be due to the device's relative CPU performance.

  • tests/stress/float32-repeat-out-of-bounds.js:
  • tests/stress/int8-repeat-out-of-bounds.js:
15:47 Changeset [182157] by cdumez@apple.com
  • 5 edits
    2 adds in trunk

Cached "Expires" header is not updated upon successful resource revalidation
https://bugs.webkit.org/show_bug.cgi?id=143228
<rdar://problem/20348059>

Reviewed by Antti Koivisto.

Source/WebCore:

Cached "Expires" header was not updated upon successful resource
revalidation. This affected both our disk cache and our memory cache.
This was caused by shouldUpdateHeaderAfterRevalidation() in
CacheValidation.cpp returning false for the "Expires" header.

There is a comment there stating that the list of ignored headers
matches Chromium's net library but that's not the case, at least not
anymore:
http://osxr.org/android/source/external/chromium/net/http/http_response_headers.cc

HTTP servers such as Apache return an "Expires" header in their 304
responses and the "Expires" header is potentially a new one. However,
our caches were ignoring the updated expiration date and kept using the
old one, which meant that the cached resource expired sooner than it
should have.

See the following Apache bugs that explain the issue:
https://bz.apache.org/bugzilla/show_bug.cgi?id=24884
https://bz.apache.org/bugzilla/show_bug.cgi?id=25123

Test: http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html

  • platform/network/CacheValidation.cpp:

LayoutTests:

Add layout test to check that a cached response's "Expires" header is
updated from the 304 response's headers upon successful revalidation.

  • http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-revalidation-new-expire-header.html: Added.
  • http/tests/cache/disk-cache/resources/cache-test.js:

(generateTestURL):
(loadResource):

  • http/tests/cache/disk-cache/resources/generate-response.cgi:
15:43 Changeset [182156] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: Regression: Preview for null? shouldn't be []
https://bugs.webkit.org/show_bug.cgi?id=143208

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-30
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • inspector/InjectedScriptSource.js:

Handle null when generating simple object previews.

LayoutTests:

  • inspector/model/remote-object-expected.txt:
  • inspector/model/remote-object.html:
15:41 Changeset [182155] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Regression: null shouldn't be expandable in object outline
https://bugs.webkit.org/show_bug.cgi?id=143209

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-03-30
Reviewed by Mark Lam.

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createObjectTreeOrFormattedValueForRemoteObject):
When creating an object tree or formatted value, choose just a formatted value
for "null", since it does not have properties.

15:00 Changeset [182154] by antti@apple.com
  • 4 edits in trunk

Don't cache resources that are very unlikely to be reused
https://bugs.webkit.org/show_bug.cgi?id=143226

Reviewed by Chris Dumez.

Source/WebKit2:

Follow-up to cover Cache-control: no-cache case which also has zero cache lifetime.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeStoreDecision):

LayoutTests:

  • http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy-expected.txt:
14:25 Changeset [182153] by antti@apple.com
  • 2 edits in trunk/Source/WebKit2

Include cache entry worth to json dump
https://bugs.webkit.org/show_bug.cgi?id=143202

Follow-up fix.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::computeRecordWorth):

This accidentally gave the error case worth 1 rather than 0 as it should be.

14:09 Changeset [182152] by antti@apple.com
  • 17 edits in trunk

Don't cache resources that are very unlikely to be reused
https://bugs.webkit.org/show_bug.cgi?id=143226
<rdar://problem/20347160>

Reviewed by Geoff Garen.

Source/WebCore:

Allow overriding resource load priorities via Internals for testing.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::FrameLoader::clearTestingOverrides):

  • loader/FrameLoader.h:

(WebCore::FrameLoader::setOverrideResourceLoadPriorityForTesting):
(WebCore::FrameLoader::clearOverrideCachePolicyForTesting): Deleted.

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):

  • page/DiagnosticLoggingKeys.h:

Add a key.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::stringToResourceLoadPriority):
(WebCore::Internals::setOverrideResourceLoadPriority):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

We are writing lots of resources to the cache that are never used again.

In browse-around-randomly test this reduced number of cache entries created by ~20% and bytes written by ~5%.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):

Rename for clarity.

(WebKit::NetworkCache::makeStoreDecision):

Store only if the resource has non-zero expiration or has validation headers.

Very High priority resources (main resources) keep the existing policy to minimize impact
on back navigation and tab restore.

(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::canUse): Deleted.
(WebKit::NetworkCache::canRetrieve): Deleted.
(WebKit::NetworkCache::canStore): Deleted.

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::storeDecisionToDiagnosticKey):

LayoutTests:

  • http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.txt:
  • http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.html:

Keep max-age: 0 cacheable in this test by adding a validation header.

  • http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy-expected.txt:
  • http/tests/cache/disk-cache/disk-cache-validation-back-navigation-policy.html:

Rebase and expand to cover the high priority resource case.

13:12 Changeset [182151] by peavo@outlook.com
  • 3 edits in trunk/Source/JavaScriptCore

Avoid using hardcoded values for JSValue::Int32Tag, if possible.
https://bugs.webkit.org/show_bug.cgi?id=143134

Reviewed by Geoffrey Garen.

  • jit/JSInterfaceJIT.h:
  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):

12:52 WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
12:02 Changeset [182150] by timothy_horton@apple.com
  • 7 edits in trunk/Source/WebKit2

Swipe snapshot removed too early (jumps around) on arstechnica and NYT
https://bugs.webkit.org/show_bug.cgi?id=143199
<rdar://problem/18420467>

Reviewed by Dan Bernstein.

Make ViewGestureControllerIOS's snapshot removal timing behave more like the Mac version.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
Let ViewGestureController know when the page has finished state restoration.

(-[WKWebView _didFinishLoadForMainFrame]):
(-[WKWebView _didSameDocumentNavigationForMainFrame:]):
Forward these to ViewGestureController.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::didFinishLoadForMainFrame):
Forward didFinishLoadForMainFrame to WKWebView.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::ViewGestureController):
(WebKit::ViewGestureController::endSwipeGesture):
Split the swipe snapshot removal state into a bunch of bools.

(WebKit::ViewGestureController::willCommitPostSwipeTransitionLayerTree):
(WebKit::ViewGestureController::setRenderTreeSize):
(WebKit::ViewGestureController::removeSwipeSnapshotIfReady):
(WebKit::ViewGestureController::removeSwipeSnapshot):
Unify the snapshot removal logic into one function; removeSwipeSnapshotIfReady
completely owns the decision. For now, we're waiting for everything, but
we can do better in the future (using firstVisuallyNonEmptyLayout like Mac used to).

(WebKit::ViewGestureController::didRestoreScrollPosition):
(WebKit::ViewGestureController::didFinishLoadForMainFrame):
(WebKit::ViewGestureController::didSameDocumentNavigationForMainFrame):
(WebKit::ViewGestureController::activeLoadMonitoringTimerFired):
Add more conditions for swipe snapshot removal. We'll now wait for
didFinishLoadForMainFrame (or didSameDocumentNavigationForMainFrame),
for active loads to finish, and for the scroll position to be restored.
This brings the iOS implementation in line with the slightly better Mac
implementation, and also sets the stage for deduplication of all of this code.

  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::ViewGestureController):

11:58 Changeset [182149] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Rebaseline accessibility/aria-toggle-button-with-title.html
https://bugs.webkit.org/show_bug.cgi?id=143229

Unreviewed.

Revision r182012 updates the way a role=button + aria-pressed object should be exposed as AXCheckbox. We need to create a new baseline.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30

  • platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Added.
11:52 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
11:36 Changeset [182148] by fpizlo@apple.com
  • 4 edits
    5 adds in trunk/Source/JavaScriptCore

REGRESSION: js/regress/inline-arguments-local-escape.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=143104

Reviewed by Geoffrey Garen.

Created a test that is a 100% repro of the flaky failure. This test is called
get-my-argument-by-val-for-inlined-escaped-arguments.js. It fails all of the time because it
always causes the compiler to emit a GetMyArgumentByVal of the arguments object returned by
the inlined function. Other than that, it's the same as inline-arguments-local-escape.

Also created three more tests for three similar, but not identical, failures.

Then fixed the bug: PreciseLocalClobberize was assuming that if we read(Stack) then we are
only reading those parts of the stack that are relevant to the current semantic code origin.
That's false after ArgumentsEliminationPhase - we might have operations on phantom arguments,
like GetMyArgumentByVal, ForwardVarargs, CallForwardVarargs, and ConstructForwardVarargs, that
read parts of the stack associated with the inline call frame for the phantom arguments. This
may not be subsumed by the current semantic origin's stack area in cases that the arguments
were allowed to "locally" escape.

The higher-order lesson here is that in DFG SSA IR, the current semantic origin's stack area
is not really a meaningful concept anymore. It is only meaningful for nodes that will read
the stack due to function.arguments, but there are a bunch of other ways that we could also
read the stack and those operations may read any stack slot. I believe that this change makes
PreciseLocalClobberize right: it will refine a read(Stack) from Clobberize correctly by casing
on node type. In future, if we add a read(Stack) to Clobberize, we'll have to make sure that
readTop() in PreciseLocalClobberize does the right thing.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

  • dfg/DFGPutStackSinkingPhase.cpp:
  • tests/stress/call-forward-varargs-for-inlined-escaped-arguments.js: Added.
  • tests/stress/construct-forward-varargs-for-inlined-escaped-arguments.js: Added.
  • tests/stress/forward-varargs-for-inlined-escaped-arguments.js: Added.
  • tests/stress/get-my-argument-by-val-for-inlined-escaped-arguments.js: Added.
  • tests/stress/real-forward-varargs-for-inlined-escaped-arguments.js: Added.
11:33 Changeset [182147] by jfernandez@igalia.com
  • 34 edits
    5 adds in trunk

[CSS Grid Layout] Upgrade align-self and align-items parsing to CSS 3
https://bugs.webkit.org/show_bug.cgi?id=133359

Reviewed by David Hyatt.

From Blink r164817 and r165264 by <jchaffraix@chromium.org>

Source/WebCore:

Broaden justify-self's parsing name

This is in preparation of migrating align-self, align-items
and justify-items to the CSS 3 Alignment syntax.

The current naming was too tied to justify-self and needs to
be broadened. This will reduce the follow-up implementations'
patches.

Upgrade align-self and align-items parsing to CSS 3

This change migrates the 2 properties to the CSS 3 Alignment
parsing. The new parsing is identical to how we parse
'justify-self'. The 2 properties need to be migrated together
as they are used in tandem in CSSComputedStyleDeclaration.

This change also removes EAlignItems as it is now unused.

Tests: css3/parse-align-items.html

css3/parse-align-self.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::resolveAlignmentAuto): Added. Resolves the "auto" value for the alignment properties.
(WebCore::valueForItemPositionWithOverflowAlignment): Added. Builds the CSSValue for the for the alignment properties.
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp: (WebCore::isValidKeywordPropertyAndValue): Removed align-self, align-items and justify-items.

(WebCore::isKeywordPropertyID): Removed align-self, align-items and justify-items.
(WebCore::isBaselinePositionKeyword): Added. Set of keywords related to baseline value.
(WebCore::CSSParser::parseItemPositionOverflowPosition): Generic parsing fuction for the alignment properties.
(WebCore::CSSParser::parseJustifySelf): Deleted.
(WebCore::CSSParser::parseValue): Added align-items and align-self to the list and call to the generic parsing fuction for the alignment properties.

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added.
(WebCore::CSSPrimitiveValue::operator ItemPosition): Added. Replace the old EAlignItems enumeration.
(WebCore::CSSPrimitiveValue::operator OverflowAlignment): Added.
(WebCore::CSSPrimitiveValue::operator EAlignItems): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelf): Deleted.
(WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment): Deleted.

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInheritAlignSelf): Added.
(WebCore::StyleBuilderCustom::applyInitialAlignSelf): Added.
(WebCore::StyleBuilderCustom::applyValueAlignSelf): Added.
(WebCore::StyleBuilderCustom::applyInheritAlignItems): Added.
(WebCore::StyleBuilderCustom::applyInitialAlignItems): Added.
(WebCore::StyleBuilderCustom::applyValueAlignItems): Added.
(WebCore::StyleBuilderCustom::applyInheritJustifySelf): Added.
(WebCore::StyleBuilderCustom::applyInitialJustifySelf): Added.
(WebCore::StyleBuilderCustom::applyValueJustifySelf): Added.
(WebCore::StyleBuilderCustom::applyValueWebkitJustifySelf): Deleted.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle): isDisplayFlexibleOrGridBox now a RenderStyle function.
(WebCore::isDisplayFlexibleBox): Deleted. Moved to RenderStyle.
(WebCore::isDisplayGridBox): Deleted. Moved to RenderStyle.
(WebCore::isDisplayFlexibleOrGridBox): Deleted. Moved to RenderStyle.

  • rendering/RenderBox.cpp:

(WebCore::flexItemHasStretchAlignment): Adapted to the new ItemPostition enum.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::styleDidChange): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::alignmentForChild): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::needToStretchChild): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren): Adapted to the new ItemPostition enum.
(WebCore::RenderFlexibleBox::alignChildren): Adapted to the new ItemPostition enum.
(WebCore::resolveAlignment): Deleted. Moved to RenderStyle.

  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFullScreen.cpp:

(WebCore::createFullScreenStyle): Adapted to the new ItemPostition enum.

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Adapted to the new ItemPostition enum.

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::updateStyle): Adapted to the new ItemPostition enum.

  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::fixAnonymousStyleForSubSupPair): Adapted to the new ItemPostition enum.
(WebCore::RenderMathMLScripts::fixAnonymousStyles): Adapted to the new ItemPostition enum.

  • rendering/style/ContentData.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::resolveAlignment): Added.

  • rendering/style/RenderStyle.h: Adapted to the new ItemPostition enum.
  • rendering/style/RenderStyleConstants.h: Adapted to the new ItemPostition enum.
  • rendering/style/StyleRareNonInheritedData.cpp: Adapted to the new ItemPostition enum.

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): Adapted to the new ItemPostition enum.
(WebCore::StyleRareNonInheritedData::operator==): Adapted to the new ItemPostition enum.

  • rendering/style/StyleRareNonInheritedData.h: Adapted to the new ItemPostition enum.
  • style/StyleResolveTree.cpp:

(WebCore::Style::determineChange): Changes in the alignItems property cause a Detach.

LayoutTests:

Broaden justify-self's parsing name and upgrade align-self and
align-items parsing to CSS 3.

  • TestExpectations:
  • css3/flexbox/css-properties-expected.txt:
  • css3/flexbox/css-properties.html:
  • css3/parse-align-items-expected.txt: Added.
  • css3/parse-align-items.html: Added.
  • css3/parse-align-self-expected.txt: Added.
  • css3/parse-align-self.html: Added.
  • css3/resources/alignment-parsing-utils.js: Added.

(checkValues):
(checkBadValues):
(checkInitialValues):
(checkInheritValues):
(checkLegacyValues):

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/css/parse-justify-self-expected.txt:
  • fast/css/parse-justify-self.html:
  • svg/css/getComputedStyle-basic-expected.txt:
11:02 Changeset [182146] by hyatt@apple.com
  • 5 edits
    6 adds in trunk

[New Block-Inside-Inline Model] Create anonymous inline blocks to hold blocks-inside-inlines.
https://bugs.webkit.org/show_bug.cgi?id=143145

Reviewed by Dean Jackson.

Source/WebCore:

Added fast/block/inside-inlines/ tests.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::renderName):
Add support for labeling anonymous inline-blocks when dumped by the render tree.

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):
When the pref is set to use the new block-inside-inline model, create an anonymous inline block to
hold block children of RenderInlines instead of splitting flows or creating continuations.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isAnonymousInlineBlock):
Add the definition of isAnonymousInlineBlock (note the exclusion of Ruby, since Ruby creates anonymous
inline-blocks also).

LayoutTests:

  • fast/block/inside-inlines: Added.
  • fast/block/inside-inlines/empty-block-expected.html: Added.
  • fast/block/inside-inlines/empty-block.html: Added.
  • fast/block/inside-inlines/new-model: Added.
  • fast/block/inside-inlines/new-model/empty-block-expected.html: Added.
  • fast/block/inside-inlines/new-model/empty-block.html: Added.
10:35 Changeset [182145] by cdumez@apple.com
  • 6 edits
    2 adds in trunk

[WK2][NetworkCache] Add support for "Cache-Control: max-stale" request header
https://bugs.webkit.org/show_bug.cgi?id=143159
<rdar://problem/20333296>

Reviewed by Antti Koivisto.

Source/WebCore:

Add support for "Cache-Control: max-stale" request header:
https://tools.ietf.org/html/rfc7234#section-5.2.1.2

Test: http/tests/cache/disk-cache/disk-cache-request-max-stale.html

  • platform/network/CacheValidation.cpp:

(WebCore::parseCacheControlDirectives):

  • platform/network/CacheValidation.h:

Source/WebKit2:

Add support for "Cache-Control: max-stale" request header:
https://tools.ietf.org/html/rfc7234#section-5.2.1.2

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::responseHasExpired):
(WebKit::NetworkCache::requestRequiresRevalidation):
(WebKit::NetworkCache::canUse):

LayoutTests:

Add layout test to cover support for "Cache-Control: max-stale" request
header.

  • http/tests/cache/disk-cache/disk-cache-request-max-stale-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-request-max-stale.html: Added.
10:06 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
10:04 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
10:01 Changeset [182144] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Update install-dependencies Fedora packages after r181624
https://bugs.webkit.org/show_bug.cgi?id=143215

Add json-glib, libv4l, openssl and pulseaudio development packages to
the Fedora list providing we need them to build WebKit dependencies
for this distribution.

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
Reviewed by Philippe Normand.

  • gtk/install-dependencies:
10:01 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
09:45 Changeset [182143] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebCore

Fix iOS internal build after r182132.

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):

09:34 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
09:30 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
09:29 Changeset [182142] by commit-queue@webkit.org
  • 20 edits in trunk/Source/WebInspectorUI

Web Inspector: Add more ESLint rules that reflect the current state of the code base
https://bugs.webkit.org/show_bug.cgi?id=143212

Patch by Tobias Reiss <tobi+webkit@basecode.de> on 2015-03-30
Reviewed by Timothy Hatcher.

  • .eslintrc:

Define some utilities as globals.
Replace "no-comma-dangle" with "comma-dangle". "no-comma-dangle" is deprecated and does not trigger in ESLint v.0.17.1
Set "new-cap" to 0 due to the usage of "WebInspector.UIString".
Disable "no-redeclare" for now and enable it back as soon as block scoped let is used.
Disable "dot-notation", "no-shadow" and "no-use-before-define" due to a lot of hits.
Disable "no-inner-declarations" as this is a common pattern to save memory.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:
  • UserInterface/Models/SourceCodeLocation.js:

It's not necessary to initialize x to undefined.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:
  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
  • UserInterface/Views/TextEditor.js:
  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

Remove unused variable x.

  • UserInterface/Views/ObjectTreeMapEntryTreeElement.js:
  • UserInterface/Models/PropertyPath.js:
  • UserInterface/Views/RadioButtonNavigationItem.js:
  • UserInterface/Views/ReplayDashboardView.js:
  • UserInterface/Models/ScriptSyntaxTree.js:
  • UserInterface/Views/SourceCodeTextEditor.js:
  • UserInterface/Views/SourceCodeTreeElement.js:

Remove trailing and unexpected whitespace.

  • UserInterface/Views/ProbeSetDataGrid.js:
  • UserInterface/Views/TimelineRuler.js:

Add missing semicolon.

  • UserInterface/Views/TimelineDataGrid.js:
  • UserInterface/Views/TimelineRecordFrame.js:

Add missing var statement.

  • UserInterface/Views/TypeTokenView.js:

Remove unnecessary bind.

09:15 Changeset [182141] by jer.noble@apple.com
  • 31 edits
    4 adds in trunk

[iOS] When Web Audio is interrupted by a phone call, it cannot be restarted.
https://bugs.webkit.org/show_bug.cgi?id=143190

Reviewed by Darin Adler.

Source/WebCore:

Tests: webaudio/audiocontext-state-interrupted.html

webaudio/audiocontext-state.html

Implement the following methods and properties from the Web Audio spec:
close(), suspend(), resume(), onstatechange.

AudioContext will take more responsibility for tracking state and interruptions (and
AudioDestination will give up that responsibility). This means AudioContext must be a
MediaSessionClient, and own its own MediaSession. In return, AudioDestinationIOS and
AudioDestinationMac relinquish both.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext): Set default values in header.
(WebCore::AudioContext::uninitialize): Call setState() instead of setting m_state.
(WebCore::AudioContext::addReaction): Added. Append the callback to the appropriate vector for the state.
(WebCore::AudioContext::setState): Added. Fire events and resolve the appropriate reaction callbacks for the new state.
(WebCore::AudioContext::state): Return a string representing the context's state.
(WebCore::AudioContext::stop): Close the event queue.
(WebCore::AudioContext::startRendering): Call setState().
(WebCore::AudioContext::fireCompletionEvent): Call setState().
(WebCore::AudioContext::suspendContext): Added. Add reaction callback and call suspend() on the destination node.
(WebCore::AudioContext::resumeContext): Added. Add reaction callback and call resume() on the destination node.
(WebCore::AudioContext::closeContext): Added. Add reaction callback and call close() on the destination node.
(WebCore::AudioContext::suspendPlayback): Added. Suspend playback and set state to interrupted.
(WebCore::AudioContext::mayResumePlayback): Added. Conditionally resume playback.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::JSAudioContext::suspend): Added. Create and return a new Promise object.
(WebCore::JSAudioContext::resume): Ditto.
(WebCore::JSAudioContext::close): Ditto.

  • Modules/webaudio/AudioContext.idl: Add new methods and properties.

Extensive organizational changes were made to AudioContext.h to group instance
variables together and add C++11 initializers in their declarations:

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::mediaType): Moved from AudioDestinationNode.
(WebCore::AudioContext::presentationType): Ditto.
(WebCore::AudioContext::canReceiveRemoteControlCommands): Ditto.
(WebCore::AudioContext::didReceiveRemoteControlCommand): Ditto.
(WebCore::AudioContext::overrideBackgroundPlaybackRestriction): Ditto.

Other changes to support the new AudioContext methods:

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::resume): Add empty default virtual method.
(WebCore::AudioDestinationNode::suspend): Ditto.
(WebCore::AudioDestinationNode::close): Ditto.

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume): Added. Pass to AudioDestination.
(WebCore::DefaultAudioDestinationNode::suspend): Ditto.
(WebCore::DefaultAudioDestinationNode::close): Ditto.

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • bindings/js/JSDOMPromise.h:

(WebCore::DeferredWrapper::resolve): Add an overload for a nullptr resolve value.

  • dom/EventNames.h: Added 'statechange'.
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::Task::Task): Add a constructor which takes a void() callback.

Modify MediaSession, AudioSession, and MediaSessionManager to support the new
interruption behavior.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspendPlayback): Renamed from pausePlayback().
(WebCore::HTMLMediaElement::mayResumePlayback): Renamed from resumePlayback().

  • html/HTMLMediaElement.h:
  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::tryToSetActive): Renamed from setActive. Return true by default.
(WebCore::AudioSession::setActive): Deleted.

  • platform/audio/AudioSession.h:
  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::beginInterruption): pausePlayback() was renamed to suspendPlayback().
(WebCore::MediaSession::endInterruption): Always notify the client, telling it whether to resume.
(WebCore::MediaSession::clientWillBeginPlayback): Bail early if reentrant. Check the (new)

return value of sessionWillBeginPlayback() and remember to resume once the interruption ends.

(WebCore::MediaSession::clientWillPausePlayback): Bail early if reentrant.
(WebCore::MediaSession::pauseSession): pausePlayback() was renamed to suspendPlayback().

  • platform/audio/MediaSession.h:
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::sessionWillBeginPlayback): Return false if not allowed to break interruption or

if activating the audio session failed. Otherwise, end the interruption.

  • platform/audio/MediaSessionManager.h:
  • platform/audio/ios/AudioDestinationIOS.cpp:

(WebCore::AudioDestinationIOS::AudioDestinationIOS): m_mediaSession was removed.
(WebCore::AudioDestinationIOS::start): Ditto.

  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSession::tryToSetActive): Renamed from setActive. Return false if the AVAudioSession could not be activated.
(WebCore::AudioSession::setActive): Deleted.

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback): Do not update the now playing info if session playback was blocked.

  • platform/audio/mac/AudioDestinationMac.cpp:

(WebCore::AudioDestinationMac::AudioDestinationMac): m_mediaSession was removed.

  • platform/audio/mac/AudioDestinationMac.h:
  • platform/audio/mac/AudioSessionMac.cpp:

(WebCore::AudioSession::tryToSetActive): Renamed from setActive(). Return true by default.
(WebCore::AudioSession::setActive): Deleted.

  • platform/audio/mac/MediaSessionManagerMac.cpp:

(MediaSessionManager::updateSessionState): No longer attempt to activate the session, as this is done

MediaSessionManager::sessionWillBeginPlayback().

  • testing/Internals.cpp:

(WebCore::Internals::setMediaSessionRestrictions): Add "InterruptedPlaybackNotPermitted".

LayoutTests:

  • webaudio/audiocontext-state-expected.txt: Added.
  • webaudio/audiocontext-state-interrupted-expected.txt: Added.
  • webaudio/audiocontext-state-interrupted.html: Added.
  • webaudio/audiocontext-state.html: Added.
08:32 WebKitGTK/Gardening/Calendar edited by chavarria1991@gmail.com
(diff)
08:23 Changeset [182140] by youenn.fablet@crf.canon.fr
  • 7 edits in trunk

[Streams API] Error storage should be moved from source to stream/reader
https://bugs.webkit.org/show_bug.cgi?id=143048

Reviewed by Benjamin Poulain.

This patch removes error storage from the source as it should be stored at the stream level as error access goes through the reader.
It removes abstract ReadableStreamSource::isErrored and the storage of JavaScript errors from ReadableStreamJSSource.

Existing tests cover most of the changes.
Added test case for creating readable stream from empty JS object.

  • Modules/streams/ReadableStreamSource.h: Removing isErrored().
  • bindings/js/JSReadableStreamCustom.cpp:

(WebCore::constructJSReadableStream): Added JS stream constructor parameters checking.

  • bindings/js/ReadableStreamJSSource.cpp:

(WebCore::ReadableStreamJSSource::ReadableStreamJSSource): Removed JS stream constructor parameters checking.
(WebCore::ReadableStreamJSSource::start): Changed prototype of start so that start can throw errors directly.
(WebCore::ReadableStreamJSSource::setInternalError): Deleted.

  • bindings/js/ReadableStreamJSSource.h: Removed m_error, setInternalError and updated start declaration.
08:22 Changeset [182139] by philn@webkit.org
  • 5 edits in trunk/Source/WebCore

[GStreamer] More GL shared context fixes
https://bugs.webkit.org/show_bug.cgi?id=143216

Reviewed by Carlos Garcia Campos.

Moved the GLX/EGL context tests to be done at runtime rather than
using build-time macros because in the GTK port at least, both EGL
and GLX support are mutually exclusive. Also fixed a couple wrong
defines (USE(GLES2) doesn't exist).

  • platform/graphics/GLContext.h: Simple utility method to check if

the platform context is compatible with EGL APIs or not.

  • platform/graphics/egl/GLContextEGL.h:

(WebCore::GLContextEGL::isEGLContext):

  • platform/graphics/glx/GLContextGLX.h:

(WebCore::GLContextGLX::isEGLContext):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::ensureGstGLContext): Do
runtime checks and properly ensure GLES2/GL API usage.

06:17 Changeset [182138] by ossy@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][GTK] WebKit2's generate-forwarding-headers.pl should fail if clashing headers found
https://bugs.webkit.org/show_bug.cgi?id=142909

Reviewed by Philippe Normand.

  • Scripts/generate-forwarding-headers.pl:

(createForwardingHeadersForFramework):

05:41 Changeset [182137] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore:
Add support for deleting emoji on GTK
https://bugs.webkit.org/show_bug.cgi?id=141419

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.

The code for deleting special group of characters was specific for
COCOA and EFL platforms. The fix consists on add GTK to the #if
preprocessor directive.

  • rendering/RenderText.cpp:

(WebCore::RenderText::previousOffsetForBackwardDeletion):

LayoutTests:
Update expectations for delete-emoji test since the bug is fixed now.
https://bugs.webkit.org/show_bug.cgi?id=141419

Patch by Marcos Chavarría Teijeiro <chavarria1991@gmail.com> on 2015-03-30
Reviewed by Gustavo Noronha Silva.

  • platform/gtk/TestExpectations:
05:22 Changeset [182136] by antti@apple.com
  • 6 edits in trunk/Source/WebKit2

Include cache entry worth to json dump
https://bugs.webkit.org/show_bug.cgi?id=143202

Reviewed by Darin Adler.

This is useful for analyzing cache performance.
Also include the body size, total item count and average worth.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::traverse):
(WebKit::NetworkCache::Cache::dumpContentsToFile):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::asJSON):

  • NetworkProcess/cache/NetworkCacheEntry.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::traverse):

Add flags for specificying what sort of information is needed.

(WebKit::NetworkCache::computeRecordWorth):

Factor to a function.

(WebKit::NetworkCache::deletionProbability):

  • NetworkProcess/cache/NetworkCacheStorage.h:
00:25 Changeset [182135] by commit-queue@webkit.org
  • 6 edits
    1 delete in trunk/Tools

Unreviewed, rolling out r182119.
https://bugs.webkit.org/show_bug.cgi?id=143196

problem with syntax (Requested by youenn on #webkit).

Reverted changeset:

"[buildbot] clean-build script should remove untracked files
and revert local changes too"
https://bugs.webkit.org/show_bug.cgi?id=142400
http://trac.webkit.org/changeset/182119

00:20 Changeset [182134] by benjamin@webkit.org
  • 5 edits
    2 adds in trunk

Start the features.json files
https://bugs.webkit.org/show_bug.cgi?id=143207

Reviewed by Darin Adler.

Source/JavaScriptCore:

Start the features.json files to have something to experiment
with for the UI.

  • features.json: Added.

Source/WebCore:

  • features.json: Added.

Tools:

I kept the style checking light. We'll have to figure
what is the best format for each field.

  • Scripts/webkitpy/style/checker.py:

(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/jsonchecker.py:

(JSONContributorsChecker.check):
(JSONFeaturesChecker):
(JSONFeaturesChecker.check):

00:11 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)

03/29/15:

21:17 Changeset [182133] by simon.fraser@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix iOS scrollperf crash after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=143110

Reviewed by Dean Jackson.

When we destroy the drawing area after a web process crash, we also need to destroy
the scrollingPerformanceData which has a reference to the drawing area.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

21:13 Changeset [182132] by simon.fraser@apple.com
  • 24 edits in trunk/Source

Convert arguments to ScrollingCoordinator functions to references
https://bugs.webkit.org/show_bug.cgi?id=143198

Reviewed by Darin Adler.

Convert all the FrameView* and ScrollableArea* arguments to ScrollingCoordinator functions to
references, and use references in a few other places.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::wheelEventHandlerCountChanged):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):

  • page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

  • page/Frame.cpp:

(WebCore::Frame::willDetachPage):

  • page/FrameView.cpp:

(WebCore::FrameView::prepareForDetach):
(WebCore::FrameView::addSlowRepaintObject):
(WebCore::FrameView::removeSlowRepaintObject):
(WebCore::FrameView::addViewportConstrainedObject):
(WebCore::FrameView::removeViewportConstrainedObject):
(WebCore::FrameView::requestScrollPositionUpdate):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::scrollableAreaSetChanged):
(WebCore::FrameView::wheelEvent):

  • page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

  • page/Page.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::AsyncScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::AsyncScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll):
(WebCore::AsyncScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):
(WebCore::AsyncScrollingCoordinator::updateMainFrameScrollLayerPosition):
(WebCore::AsyncScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::pageDestroyed):
(WebCore::ScrollingCoordinator::coordinatesScrollingForFrameView):
(WebCore::ScrollingCoordinator::computeNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::frameViewWheelEventHandlerCountChanged):
(WebCore::ScrollingCoordinator::frameViewHasSlowRepaintObjectsDidChange):
(WebCore::ScrollingCoordinator::frameViewFixedObjectsDidChange):
(WebCore::ScrollingCoordinator::scrollLayerForScrollableArea):
(WebCore::ScrollingCoordinator::scrollLayerForFrameView):
(WebCore::ScrollingCoordinator::headerLayerForFrameView):
(WebCore::ScrollingCoordinator::footerLayerForFrameView):
(WebCore::ScrollingCoordinator::counterScrollingLayerForFrameView):
(WebCore::ScrollingCoordinator::insetClipLayerForFrameView):
(WebCore::ScrollingCoordinator::contentShadowLayerForFrameView):
(WebCore::ScrollingCoordinator::rootContentLayerForFrameView):
(WebCore::ScrollingCoordinator::frameViewRootLayerDidChange):
(WebCore::ScrollingCoordinator::hasVisibleSlowRepaintViewportConstrainedObjects):
(WebCore::ScrollingCoordinator::synchronousScrollingReasons):
(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons):
(WebCore::ScrollingCoordinator::setForceSynchronousScrollLayerPositionUpdates):
(WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionSynchronously):
(WebCore::ScrollingCoordinator::replaySessionStateDidChange):
(WebCore::ScrollingCoordinator::synchronousScrollingReasonsAsText):

  • page/scrolling/ScrollingCoordinator.h: Align the bitmask enums to make mistakes easier to spot.

(WebCore::ScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::ScrollingCoordinator::frameViewNonFastScrollableRegionChanged):
(WebCore::ScrollingCoordinator::requestScrollPositionUpdate):
(WebCore::ScrollingCoordinator::handleWheelEvent):
(WebCore::ScrollingCoordinator::willDestroyScrollableArea):
(WebCore::ScrollingCoordinator::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange):
(WebCore::ScrollingCoordinator::recomputeWheelEventHandlerCountForFrameView):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:

(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::requestScrollPositionUpdate):

  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::handleWheelEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::~RenderLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateOverflowControlsLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::hasCoordinatedScrolling):
(WebCore::RenderLayerCompositor::scrollingLayerDidChange):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):
(WebCore::RenderLayerCompositor::destroyRootLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
(WebCore::RenderLayerCompositor::didAddScrollingLayer):

  • testing/Internals.cpp:

(WebCore::Internals::nonFastScrollableRects):

Source/WebKit2:

  • WebProcess/Scrolling/RemoteScrollingCoordinator.h:
  • WebProcess/Scrolling/RemoteScrollingCoordinator.mm:

(WebKit::RemoteScrollingCoordinator::coordinatesScrollingForFrameView):

20:43 WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
20:12 Changeset [182131] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Use :matches() instead of :-webkit-any() for the sections and headings default style
https://bugs.webkit.org/show_bug.cgi?id=143197

Reviewed by Darin Adler.

We no longer need to use the :-webkit-any() hack in the default stylesheet.

The pseudo class :matches() also support correct specificity. This is not observable
since those selector do not conflict with any other rule in the default stylesheet.

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::determineLinkMatchType):

  • css/html.css:

(:matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) :matches(article, aside, nav, section) h1):
(:-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.
(:-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) :-webkit-any(article,aside,nav,section) h1): Deleted.

20:10 Changeset [182130] by benjamin@webkit.org
  • 5 edits
    6 adds in trunk

currentColor computes to the same colour on all elements, even if 'color' is inherited differently
https://bugs.webkit.org/show_bug.cgi?id=133420

Reviewed by Darin Adler.

Source/WebCore:

When resolving a style with the help of the property cache, we were
completely ignoring currentColor.

Since you can set currentColor on properties that are not inherited,
those properties would just be copied from the cached style, which
may have a completely different inherited color.

This pacth fixes the issue by preventing any MatchResult from hitting
the cache if it contains any non-inherited property that would require
resolution by the cache:
-Using the inherit value.
-Using the currentColor value.

Tests: fast/css/currentColor-on-before-after-pseudo-elements.html

fast/css/currentColor-style-update-reftest.html
fast/css/currentColor-value-style-update.html

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::matchUARules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::findFromMatchedPropertiesCache):
(WebCore::StyleResolver::addToMatchedPropertiesCache):
(WebCore::extractDirectionAndWritingMode):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::CascadedProperties::addStyleProperties):
(WebCore::StyleResolver::CascadedProperties::addMatches):

  • css/StyleResolver.h:

(WebCore::StyleResolver::MatchResult::matchedProperties):

LayoutTests:

  • fast/css/currentColor-on-before-after-pseudo-elements-expected.html: Added.
  • fast/css/currentColor-on-before-after-pseudo-elements.html: Added.
  • fast/css/currentColor-style-update-reftest-expected.html: Added.
  • fast/css/currentColor-style-update-reftest.html: Added.
  • fast/css/currentColor-value-style-update-expected.txt: Added.
  • fast/css/currentColor-value-style-update.html: Added.
20:05 Changeset [182129] by benjamin@webkit.org
  • 10 edits in trunk/Source/WebCore

Enable :any-link by default
https://bugs.webkit.org/show_bug.cgi?id=143201

Reviewed by Sam Weinig.

The pseudo class :any-link has been stable for a while. This patch enables
it by default and remove the -webkit- prefix on the default style.

  • css/CSSDefaultStyleSheets.cpp:
  • css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/RuleSet.cpp:

(WebCore::RuleSet::addRule):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorChecker.h:

(WebCore::SelectorChecker::isCommonPseudoClassSelector):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • css/html.css:

(a:any-link):
(a:any-link:active):
(:any-link img):
(a:-webkit-any-link): Deleted.
(a:-webkit-any-link:active): Deleted.
(:-webkit-any-link img): Deleted.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementLinkMatching):

19:27 Changeset [182128] by gyuyoung.kim@samsung.com
  • 4 edits
    1 delete in trunk

[CMake] Update old CMakeList.txt in gtest
https://bugs.webkit.org/show_bug.cgi?id=143192

Reviewed by Darin Adler.

CMake ports have used cmake/gtest/CMakeLists.txt instead of ThirdParty/test/CMakeLists.txt
in order to build gtest. However it looks ThirdParty/test/CMakeLists.txt won't be used anymore.
So this patch moves cmake/gtest/CMakeLists.txt to ThirdPart/test/CMakeLists.txt, and use it.

.:

  • Source/CMakeLists.txt:
  • Source/cmake/gtest/CMakeLists.txt: Removed.

Source/ThirdParty:

  • gtest/CMakeLists.txt:
19:00 Changeset [182127] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

nullptr cleanup in RenderFooBox classes
https://bugs.webkit.org/show_bug.cgi?id=143182

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-03-29
Reviewed by Ryosuke Niwa.

No new tests, no behavior changes

Replace 0 with nullptr in RenderFooBox classes.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::paintFillLayer):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::positionForPoint):
(WebCore::RenderBox::layoutOverflowRectForPropagation):

  • rendering/RenderBox.h:

(WebCore::RenderBox::setMarginBefore):
(WebCore::RenderBox::setMarginAfter):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::createAnonymousBoxWithSameTypeAs):
(WebCore::RenderBox::setInlineBoxWrapper):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::willBeDestroyed):
(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintBorderSides):
(WebCore::RenderBoxModelObject::firstLetterRemainingText):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::moveChildTo):
(WebCore::RenderBoxModelObject::moveAllChildrenTo):
(WebCore::RenderBoxModelObject::moveChildrenTo):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):
(WebCore::FlexBoxIterator::next):

  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):

  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::deleteLineBoxTree):
(WebCore::RenderLineBoxList::extractLineBox):
(WebCore::RenderLineBoxList::deleteLineBoxes):
(WebCore::RenderLineBoxList::checkConsistency):

  • rendering/RenderLineBoxList.h:

(WebCore::RenderLineBoxList::RenderLineBoxList):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::enclosingScrollableArea):
(WebCore::RenderListBox::setHasVerticalScrollbar):

  • rendering/RenderListBox.h:
18:03 Changeset [182126] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS WK2] WKContentView should implement _selectionClipRect
https://bugs.webkit.org/show_bug.cgi?id=143143
rdar://problem/20330075

Reviewed by Benjamin Poulain.

UIKit checks if the text delegate responds to this selector
to retrieve the clipping rectangle for the editable element
where the selection is being create.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _selectionClipRect]):

17:33 Changeset [182125] by darin@apple.com
  • 3 edits
    2 adds in trunk

HTMLCollection caches incorrect length if item(0) is called before length on an empty collection
https://bugs.webkit.org/show_bug.cgi?id=143203
Source/WebCore:

rdar://problem/18460462

Reviewed by Antti Koivisto.

Test: fast/dom/htmlcollection-length-after-item-2.html

  • dom/CollectionIndexCache.h:

(CollectionIndexCache::nodeAt): If we hit the end looking for index 0, cache a length
of 0, not a length of 1.

LayoutTests:

Reviewed by Antti Koivisto.

  • fast/dom/htmlcollection-length-after-item-2-expected.txt: Added.
  • fast/dom/htmlcollection-length-after-item-2.html: Added.
16:43 Changeset [182124] by antti@apple.com
  • 4 edits in trunk/Source/WebKit2

Use st_mtime instead of st_atime to track file access time
https://bugs.webkit.org/show_bug.cgi?id=143200

Reviewed by Darin Adler.

On OS X atime updates automatically on read so calling Storage::traverse() would always ends up updating access times
for all cache entries to the current time. This would make entry worth computation produce unexpected results.
We update mtime manually on successful cache retrieve only so switching to it fixes the problem.

  • NetworkProcess/cache/NetworkCacheFileSystemPosix.h:

(WebKit::NetworkCache::fileTimes):
(WebKit::NetworkCache::updateFileModificationTimeIfNeeded):
(WebKit::NetworkCache::updateFileAccessTimeIfNeeded): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::updateFileModificationTime):
(WebKit::NetworkCache::Storage::dispatchReadOperation):
(WebKit::NetworkCache::deletionProbability):
(WebKit::NetworkCache::Storage::updateFileAccessTime): Deleted.

  • NetworkProcess/cache/NetworkCacheStorage.h:
14:54 Changeset [182123] by mmaxfield@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Addresing post-review comment after r182122
https://bugs.webkit.org/show_bug.cgi?id=143189

Unreviewed.

13:56 Changeset [182122] by mmaxfield@apple.com
  • 8 edits
    1 copy in trunk/Source/JavaScriptCore

[Win] Allow building JavaScriptCore without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=143189

Reviewed by Brent Fulgham.

Paths like /usr/bin/ don't exist on Windows.
Hashbangs don't work on Windows. Instead we must explicitly call the executable.
Prefixing commands with environment variables doesn't work on Windows.
Windows doesn't have 'cmp'
Windows uses 'del' instead of 'rm'
Windows uses 'type NUL' intead of 'touch'

  • DerivedSources.make:
  • JavaScriptCore.vcxproj/JavaScriptCoreGenerated.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntAssembly/build-LLIntAssembly.pl:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.make:
  • JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl:
  • JavaScriptCore.vcxproj/build-generated-files.pl:
  • UpdateContents.py: Copied from Source/JavaScriptCore/JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/build-LLIntDesiredOffsets.pl.
13:40 Changeset [182121] by darin@apple.com
  • 124 edits in trunk/Source/WebCore

Remove unneeded SVG code, including most isSupportedAttribute functions
https://bugs.webkit.org/show_bug.cgi?id=143194

Reviewed by Antti Koivisto.

  • Removed most implementations of isSupportedAttribute. Others can be removed in future patches. The ones left behind are now all private static member functions. It's dangerous for them to be public because they tend to indicate which attributes are supported at a particular level in the class hierarchy and they are not virtual functions; might want to rethink the function name if we keep any of these long term.
  • Removed unneeded includes, especially of Attr.h and Attribute.h.
  • Changed most parseAttribute and svgAttributeChanged functions so they no longer rely on checking attribute names against a set. Also removed lots of unneeded calls to SVGLangSpace::parseAttribute, which is called by SVGElement::parseAttribute and need not be called by derived classes.
  • Removed return values from parseAttribute functions. Skipping other parseAttribute logic is not an important optimization and makes functions needlessly complex.
  • Moved use of InstanceInvalidationGuard closer to where they are needed. Eventually we may be able to remove many of these.
  • Used auto in a few places where the same type is repeated twice on the same line of code, and auto makes it a bit smaller.
  • Got rid of protected sections in some final classes; doesn't make sense to combine these two. Also moved a few functions from protected to private in other classes.
  • Made a number of functions into static member functions in the base classes such as SVGLangSpace; they were not making any use of the object, and so it was wasteful to compile them as non-static member functions.
  • rendering/svg/RenderSVGImage.cpp: Removed unneeded includes.
  • svg/SVGAElement.cpp: Removed unneeded includes.

(WebCore::SVGAElement::isSupportedAttribute): Deleted.
(WebCore::SVGAElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGAElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGAElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimateMotionElement.cpp: Removed unneeded includes.

(WebCore::SVGAnimateMotionElement::isSupportedAttribute): Deleted.
(WebCore::SVGAnimateMotionElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGAnimateMotionElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimateTransformElement.cpp:

(WebCore::SVGAnimateTransformElement::isSupportedAttribute): Deleted.
(WebCore::SVGAnimateTransformElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGAnimateTransformElement.h: Removed isSupportedAttribute.
  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGCircleElement.cpp:

(WebCore::SVGCircleElement::isSupportedAttribute): Deleted.
(WebCore::SVGCircleElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGCircleElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGCircleElement.h: Removed isSupportedAttribute.
  • svg/SVGClipPathElement.cpp: Removed unneeded includes.

(WebCore::SVGClipPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGComponentTransferFunctionElement.cpp:

(WebCore::SVGComponentTransferFunctionElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGCursorElement.cpp: Removed unneeded includes.

(WebCore::SVGCursorElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGCursorElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGElement.cpp: Removed unneeded includes.
  • svg/SVGEllipseElement.cpp: Removed unneeded includes.

(WebCore::SVGEllipseElement::isSupportedAttribute): Deleted.
(WebCore::SVGEllipseElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGEllipseElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGEllipseElement.h: Removed isSupportedAttribute.
  • svg/SVGExternalResourcesRequired.cpp: Removed unneeded includes.

(WebCore::SVGExternalResourcesRequired::parseAttribute): Don't return a boolean.

  • svg/SVGExternalResourcesRequired.h: Don't return a boolean.
  • svg/SVGFEBlendElement.cpp: Removed unneeded includes.

(WebCore::SVGFEBlendElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEBlendElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEBlendElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEBlendElement.h: Removed isSupportedAttribute.
  • svg/SVGFEColorMatrixElement.cpp: Removed unneeded includes.

(WebCore::SVGFEColorMatrixElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEColorMatrixElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEColorMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEColorMatrixElement.h: Removed isSupportedAttribute.
  • svg/SVGFEComponentTransferElement.cpp: Removed unneeded includes.

(WebCore::SVGFEComponentTransferElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEComponentTransferElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFEComponentTransferElement.h: Removed unneeded includes.
  • svg/SVGFECompositeElement.cpp: Removed unneeded includes.

(WebCore::SVGFECompositeElement::isSupportedAttribute): Deleted.
(WebCore::SVGFECompositeElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFECompositeElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp: Removed unneeded includes.

(WebCore::SVGFEConvolveMatrixElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEConvolveMatrixElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEConvolveMatrixElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDiffuseLightingElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDiffuseLightingElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDiffuseLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDisplacementMapElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDisplacementMapElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDisplacementMapElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.cpp: Removed unneeded includes.

(WebCore::SVGFEDropShadowElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEDropShadowElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEDropShadowElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEFloodElement.cpp: Removed unneeded includes.
  • svg/SVGFEGaussianBlurElement.cpp: Removed unneeded includes.

(WebCore::SVGFEGaussianBlurElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEGaussianBlurElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEGaussianBlurElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.cpp: Removed unneeded includes.

(WebCore::SVGFEImageElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEImageElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEImageElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.cpp: Removed unneeded includes.

(WebCore::SVGFELightElement::isSupportedAttribute): Deleted.
(WebCore::SVGFELightElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFELightElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.cpp: Removed unneeded includes.

(WebCore::SVGFEMergeNodeElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEMergeNodeElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.cpp: Removed unneeded includes.

(WebCore::SVGFEMorphologyElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEMorphologyElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEMorphologyElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.cpp: Removed unneeded includes.

(WebCore::SVGFEOffsetElement::isSupportedAttribute): Deleted.
(WebCore::SVGFEOffsetElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFEOffsetElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.cpp: Removed unneeded includes.

(WebCore::SVGFESpecularLightingElement::isSupportedAttribute): Deleted.
(WebCore::SVGFESpecularLightingElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFESpecularLightingElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.cpp: Removed unneeded includes.

(WebCore::SVGFETileElement::isSupportedAttribute): Deleted.
(WebCore::SVGFETileElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFETileElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.cpp: Removed unneeded includes.

(WebCore::SVGFETurbulenceElement::isSupportedAttribute): Deleted.
(WebCore::SVGFETurbulenceElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGFETurbulenceElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.cpp: Removed unneeded includes.

(WebCore::SVGFilterElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFilterPrimitiveStandardAttributes.cpp: Removed unneeded includes.

(WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGFilterPrimitiveStandardAttributes.h: Removed isSupportedAttribute and also moved a

couple functions out of the class definition.

  • svg/SVGFitToViewBox.cpp: Removed unneeded includes.
  • svg/SVGFontFaceElement.cpp: Removed unneeded includes.
  • svg/SVGFontFaceUriElement.cpp: Removed unneeded includes.
  • svg/SVGForeignObjectElement.cpp: Removed unneeded includes.

(WebCore::SVGForeignObjectElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGElement.cpp: Removed unneeded includes.

(WebCore::SVGGElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGlyphElement.cpp: Removed unneeded includes.
  • svg/SVGGlyphRefElement.cpp: Removed unneeded includes.

(WebCore::SVGGlyphRefElement::hasValidGlyphElement): Rewrote to use is<> instead of hasTagName.
(WebCore::SVGGlyphRefElement::parseAttribute): Don't use return value from SVGURIReference::parseAttribute.

  • svg/SVGGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGGraphicsElement.cpp: Removed unneeded includes.

(WebCore::SVGGraphicsElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGImageElement.cpp: Removed unneeded includes.

(WebCore::SVGImageElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGLangSpace.cpp: Removed unneeded includes.

(WebCore::SVGLangSpace::parseAttribute): Removed the return value.

  • svg/SVGLangSpace.h: Converted functions to static member functions and removed the

return value from parseAttribute.

  • svg/SVGLineElement.cpp: Removed unneeded includes.

(WebCore::SVGLineElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGLinearGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGLinearGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGMPathElement.cpp: Removed unneeded includes.

(WebCore::SVGMPathElement::isSupportedAttribute): Deleted.
(WebCore::SVGMPathElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGMPathElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGMPathElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions

private instead of protected.

  • svg/SVGMarkerElement.cpp: Removed unneeded includes.

(WebCore::SVGMarkerElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGMaskElement.cpp: Removed unneeded includes.

(WebCore::SVGMaskElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPathElement.cpp: Removed unneeded includes.

(WebCore::SVGPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPatternElement.cpp: Removed unneeded includes.

(WebCore::SVGPatternElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGPolyElement.cpp: Removed unneeded includes.

(WebCore::SVGPolyElement::isSupportedAttribute): Deleted.
(WebCore::SVGPolyElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGPolyElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.cpp: Removed unneeded includes.

(WebCore::SVGRadialGradientElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGRectElement.cpp: Removed unneeded includes.

(WebCore::SVGRectElement::isSupportedAttribute): Deleted.
(WebCore::SVGRectElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGRectElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.cpp: Removed unneeded includes.

(WebCore::SVGSVGElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGScriptElement.cpp: Removed unneeded includes.
  • svg/SVGStopElement.cpp: Removed unneeded includes.

(WebCore::SVGStopElement::isSupportedAttribute): Deleted.
(WebCore::SVGStopElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGStopElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGStopElement.h: Removed isSupportedAttribute.
  • svg/SVGStyleElement.cpp: Removed unneeded includes.

(WebCore::SVGStyleElement::isSupportedAttribute): Deleted.
(WebCore::SVGStyleElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGStyleElement.h: Removed isSupportedAttribute.
  • svg/SVGSymbolElement.cpp: Removed unneeded includes.

(WebCore::SVGSymbolElement::isSupportedAttribute): Deleted.
(WebCore::SVGSymbolElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGSymbolElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGSymbolElement.h: Removed isSupportedAttribute.
  • svg/SVGTRefElement.cpp: Removed unneeded includes.

(WebCore::SVGTRefElement::isSupportedAttribute): Deleted.
(WebCore::SVGTRefElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTRefElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTRefElement.h: Removed isSupportedAttribute and made didNotifySubtreeInsertions

private instead of protected.

  • svg/SVGTests.cpp: Removed unneeded includes.

(WebCore::SVGTests::parseAttribute): Removed return value.

  • svg/SVGTests.h: Removed return value of parseAttribute.
  • svg/SVGTextContentElement.cpp: Removed unneeded includes.

(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute): Don't use
isSupportedAttribute. Also removed global to optimize comparing attribute value against
the string "preserve".
(WebCore::SVGTextContentElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTextContentElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTextContentElement.h: Made isSupportedAttribute private instead of protected.
  • svg/SVGTextElement.cpp: Removed unneeded includes.
  • svg/SVGTextPathElement.cpp: Removed unneeded includes.

(WebCore::SVGTextPathElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGTextPositioningElement.cpp: Removed unneeded includes.

(WebCore::SVGTextPositioningElement::isSupportedAttribute): Deleted.
(WebCore::SVGTextPositioningElement::parseAttribute): Don't use isSupportedAttribute.
(WebCore::SVGTextPositioningElement::svgAttributeChanged): Don't use isSupportedAttribute.

  • svg/SVGTextPositioningElement.h: Removed isSupportedAttribute and made some functions

private insetad of protected.

  • svg/SVGURIReference.cpp: Removed unneeded includes.

(WebCore::SVGURIReference::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGURIReference.h:

(WebCore::SVGURIReference::isExternalURIReference):

  • svg/SVGUseElement.cpp: Removed unneeded includes.

(WebCore::SVGUseElement::parseAttribute): Don't use isSupportedAttribute.

  • svg/SVGViewElement.h: Removed isSupportedAttribute.
  • svg/animation/SVGSMILElement.cpp: Removed unneeded includes.
13:38 Changeset [182120] by darin@apple.com
  • 42 edits in trunk/Source/WebCore

Remove unneeded includes of "Attribute.h"
https://bugs.webkit.org/show_bug.cgi?id=143195

Reviewed by Antti Koivisto.

  • css/StyleResolver.cpp:
  • html/HTMLAnchorElement.cpp:
  • html/HTMLAreaElement.cpp:
  • html/HTMLBRElement.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLBodyElement.cpp:
  • html/HTMLButtonElement.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLDivElement.cpp:
  • html/HTMLElement.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFontElement.cpp:
  • html/HTMLFormControlElement.cpp:
  • html/HTMLFormElement.cpp:
  • html/HTMLFrameElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLFrameSetElement.cpp:
  • html/HTMLHRElement.cpp:
  • html/HTMLIFrameElement.cpp:
  • html/HTMLImageElement.cpp:
  • html/HTMLOListElement.cpp:
  • html/HTMLOptionElement.cpp:
  • html/HTMLParagraphElement.cpp:
  • html/HTMLParamElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPreElement.cpp:
  • html/HTMLProgressElement.cpp:
  • html/HTMLScriptElement.cpp:
  • html/HTMLSelectElement.cpp:
  • html/HTMLStyleElement.cpp:
  • html/HTMLTableCaptionElement.cpp:
  • html/HTMLTableCellElement.cpp:
  • html/HTMLTableColElement.cpp:
  • html/HTMLTableElement.cpp:
  • html/HTMLTablePartElement.cpp:
  • html/HTMLTextAreaElement.cpp:
  • html/HTMLTextFormControlElement.cpp:
  • html/HTMLUListElement.cpp:
  • html/HTMLVideoElement.cpp:
  • html/parser/HTMLScriptRunner.cpp:
  • inspector/InspectorNodeFinder.cpp:

Removed includes of "Attribute.h".

11:47 Changeset [182119] by youenn.fablet@crf.canon.fr
  • 6 edits
    1 add in trunk/Tools

[buildbot] clean-build script should remove untracked files and revert local changes too
https://bugs.webkit.org/show_bug.cgi?id=142400

Reviewed by Ryosuke Niwa.

This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.

  • BuildSlaveSupport/clean-build:

(main): Adding call to Tools/Scripts/clean-webkit.

  • Scripts/clean-webkit: Added.

(main): Removes untracked and changed files.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.untracked_files): Retrieves GIT untracked files.

  • Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.untracked_files): Retrieves SVN untracked files.
(SCM):
(SCM.discard_untracked_files): Deletes untracked files/folders.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_untracked_files): Unit testing for untracked files.
(test_untracked_files):
(GitSVNTest.test_untracked_files):

  • Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.untracked_files):

Note: See TracTimeline for information about the timeline view.