Changeset 100385 in webkit

Timestamp:

Nov 15, 2011, 5:53:29 PM (14 years ago)

Author:

ggaren@apple.com

Message:

Removed another use of ArgList that baked in the assumption that arguments
are forward in the regiter file.

Reviewed by Sam Weinig.

• dfg/DFGOperations.cpp:
• jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
working through ArgList.

• runtime/ArgList.h: Removed!

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGOperations.cpp (modified) (1 diff)
• jit/JITStubs.cpp (modified) (1 diff)
• runtime/ArgList.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-11-15  Geoffrey Garen  <ggaren@apple.com>
+
+        Removed another use of ArgList that baked in the assumption that arguments
+        are forward in the regiter file.
+
+        Reviewed by Sam Weinig.
+
+        * dfg/DFGOperations.cpp:
+        * jit/JITStubs.cpp:
+        (JSC::DEFINE_STUB_FUNCTION): Use our new array creation API, instead of
+        working through ArgList.
+
+        * runtime/ArgList.h: Removed!
+
 2011-11-15  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

@@ -774 +774 @@
 EncodedJSValue DFG_OPERATION operationNewArray(ExecState* exec, void* start, size_t size)
 {
-    ArgList argList(static_cast<Register*>(start), size);
-    return JSValue::encode(constructArray(exec, argList));
+    return JSValue::encode(constructArray(exec, static_cast<JSValue*>(start), size));
 }
 

trunk/Source/JavaScriptCore/jit/JITStubs.cpp

@@ -2433 +2433 @@
     STUB_INIT_STACK_FRAME(stackFrame);
 
-    ArgList argList(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()], stackFrame.args[1].int32());
-    return constructArray(stackFrame.callFrame, argList);
+    return constructArray(stackFrame.callFrame, reinterpret_cast<JSValue*>(&stackFrame.callFrame->registers()[stackFrame.args[0].int32()]), stackFrame.args[1].int32());
 }
 

trunk/Source/JavaScriptCore/runtime/ArgList.h

@@ -192 +192 @@
         }
         
-        ArgList(Register* args, int argCount)
-            : m_args(reinterpret_cast<JSValue*>(args))
-            , m_argCount(argCount)
-        {
-            ASSERT(argCount >= 0);
-        }
-
         ArgList(const MarkedArgumentBuffer& args)
             : m_args(reinterpret_cast<JSValue*>(const_cast<Register*>(args.begin())))