Changeset 100569 in webkit

Timestamp:

Nov 16, 2011, 11:59:04 PM (14 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Use a URI instead of local path to create download destination in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=72500

Reviewed by Philippe Normand.

• WebProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): Use
g_file_new_for_uri() instad of g_file_new_for_path(). Also use
adoptGRef to fix a memory leak.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Downloads/soup/DownloadSoup.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-11-16  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Use a URI instead of local path to create download destination in WebKit2
+        https://bugs.webkit.org/show_bug.cgi?id=72500
+
+        Reviewed by Philippe Normand.
+
+        * WebProcess/Downloads/soup/DownloadSoup.cpp:
+        (WebKit::DownloadClient::didReceiveResponse): Use
+        g_file_new_for_uri() instad of g_file_new_for_path(). Also use
+        adoptGRef to fix a memory leak.
+
 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 

trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp

@@ -65 +65 @@
 
         bool overwrite;
-        String filename = m_download->decideDestinationWithSuggestedFilename(suggestedFilename.utf8().data(), overwrite);
-        if (filename.isEmpty()) {
-            downloadFailed(downloadDestinationError(response, _("Cannot determine destination filename")));
+        String destinationURI = m_download->decideDestinationWithSuggestedFilename(suggestedFilename.utf8().data(), overwrite);
+        if (destinationURI.isEmpty()) {
+            GOwnPtr<char> errorMessage(g_strdup_printf(_("Cannot determine destination URI for download with suggested filename %s"),
+                                                       suggestedFilename.utf8().data()));
+            downloadFailed(downloadDestinationError(response, errorMessage.get());
             return;
         }
 
-        GRefPtr<GFile> file(g_file_new_for_path(filename.utf8().data()));
+        GRefPtr<GFile> file = adoptGRef(g_file_new_for_uri(destinationURI.utf8().data()));
         GOwnPtr<GError> error;
         m_outputStream = adoptGRef(g_file_replace(file.get(), 0, TRUE, G_FILE_CREATE_NONE, 0, &error.outPtr()));