Changeset 100580 in webkit


Ignore:
Timestamp:
Nov 17, 2011, 1:10:53 AM (14 years ago)
Author:
commit-queue@webkit.org
Message:

[WebKit2][gtk] Add few more properties to WebKitSettings
​https://bugs.webkit.org/show_bug.cgi?id=72468

Patch by Nayan Kumar K <​nayankk@motorola.com> on 2011-11-17
Reviewed by Martin Robinson.

Add 'enable-private-browsing', 'enable-developer-extras, 'enable-resizable-text-areas'
and 'enable-tabs-to-links' properties to WebKitSettings.

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsSetProperty): Add new set functions.
(webKitSettingsGetProperty): Add new get functions.
(webkit_settings_class_init): Add new properties.
(webkit_settings_get_enable_private_browsing): Get 'enable-private-browsing' property.
(webkit_settings_set_enable_private_browsing): Set 'enable-private-browsing' property.
(webkit_settings_get_enable_developer_extras): Get 'enable-developer-extras' property.
(webkit_settings_set_enable_developer_extras): Set 'enable-developer-extras' property.
(webkit_settings_get_enable_resizable_text_areas): Get 'enable-resizable-text-areas' property.
(webkit_settings_set_enable_resizable_text_areas): Set 'enable-resizable-text-areas' property.
(webkit_settings_get_enable_tabs_to_links): Get 'enable-tabs-to-links' property.
(webkit_settings_set_enable_tabs_to_links): Set 'enable-tabs-to-links' property.

  • UIProcess/API/gtk/WebKitSettings.h: New public APIs added.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New APIs added.
  • UIProcess/API/gtk/tests/TestWebKitSettings.cpp:

(testWebKitSettings): Add new tests.

Location:
trunk/Source/WebKit2
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r100579 r100580  
     12011-11-17  Nayan Kumar K  <nayankk@motorola.com>
     2
     3        [WebKit2][gtk] Add few more properties to WebKitSettings
     4        https://bugs.webkit.org/show_bug.cgi?id=72468
     5
     6        Reviewed by Martin Robinson.
     7
     8        Add 'enable-private-browsing', 'enable-developer-extras, 'enable-resizable-text-areas'
     9        and 'enable-tabs-to-links' properties to WebKitSettings.
     10
     11        * UIProcess/API/gtk/WebKitSettings.cpp:
     12        (webKitSettingsSetProperty): Add new set functions.
     13        (webKitSettingsGetProperty): Add new get functions.
     14        (webkit_settings_class_init): Add new properties.
     15        (webkit_settings_get_enable_private_browsing): Get 'enable-private-browsing' property.
     16        (webkit_settings_set_enable_private_browsing): Set 'enable-private-browsing' property.
     17        (webkit_settings_get_enable_developer_extras): Get 'enable-developer-extras' property.
     18        (webkit_settings_set_enable_developer_extras): Set 'enable-developer-extras' property.
     19        (webkit_settings_get_enable_resizable_text_areas): Get 'enable-resizable-text-areas' property.
     20        (webkit_settings_set_enable_resizable_text_areas): Set 'enable-resizable-text-areas' property.
     21        (webkit_settings_get_enable_tabs_to_links): Get 'enable-tabs-to-links' property.
     22        (webkit_settings_set_enable_tabs_to_links): Set 'enable-tabs-to-links' property.
     23        * UIProcess/API/gtk/WebKitSettings.h: New public APIs added.
     24        * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: New APIs added.
     25        * UIProcess/API/gtk/tests/TestWebKitSettings.cpp:
     26        (testWebKitSettings): Add new tests.
     27
    1282011-11-17  Carlos Garcia Campos  <cgarcia@igalia.com>
    229

  • trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp

    r100248 r100580  
    9898    PROP_MINIMUM_FONT_SIZE,
    9999    PROP_DEFAULT_CHARSET,
     100    PROP_ENABLE_PRIVATE_BROWSING,
     101    PROP_ENABLE_DEVELOPER_EXTRAS,
     102    PROP_ENABLE_RESIZABLE_TEXT_AREAS,
     103    PROP_ENABLE_TABS_TO_LINKS,
    100104    PROP_ENABLE_CARET_BROWSING,
    101105};
    … …  
    175179        webkit_settings_set_default_charset(settings, g_value_get_string(value));
    176180        break;
     181    case PROP_ENABLE_PRIVATE_BROWSING:
     182        webkit_settings_set_enable_private_browsing(settings, g_value_get_boolean(value));
     183        break;
     184    case PROP_ENABLE_DEVELOPER_EXTRAS:
     185        webkit_settings_set_enable_developer_extras(settings, g_value_get_boolean(value));
     186        break;
     187    case PROP_ENABLE_RESIZABLE_TEXT_AREAS:
     188        webkit_settings_set_enable_resizable_text_areas(settings, g_value_get_boolean(value));
     189        break;
     190    case PROP_ENABLE_TABS_TO_LINKS:
     191        webkit_settings_set_enable_tabs_to_links(settings, g_value_get_boolean(value));
     192        break;
    177193    case PROP_ENABLE_CARET_BROWSING:
    178194        webkit_settings_set_enable_caret_browsing(settings, g_value_get_boolean(value));
    … …  
    257273    case PROP_DEFAULT_CHARSET:
    258274        g_value_set_string(value, webkit_settings_get_default_charset(settings));
     275        break;
     276    case PROP_ENABLE_PRIVATE_BROWSING:
     277        g_value_set_boolean(value, webkit_settings_get_enable_private_browsing(settings));
     278        break;
     279    case PROP_ENABLE_DEVELOPER_EXTRAS:
     280        g_value_set_boolean(value, webkit_settings_get_enable_developer_extras(settings));
     281        break;
     282    case PROP_ENABLE_RESIZABLE_TEXT_AREAS:
     283        g_value_set_boolean(value, webkit_settings_get_enable_resizable_text_areas(settings));
     284        break;
     285    case PROP_ENABLE_TABS_TO_LINKS:
     286        g_value_set_boolean(value, webkit_settings_get_enable_tabs_to_links(settings));
    259287        break;
    260288    case PROP_ENABLE_CARET_BROWSING:
    … …  
    612640
    613641    /**
     642     * WebKitSettings:enable-private-browsing:
     643     *
     644     * Determines whether or not private browsing is enabled. Private browsing
     645     * will disable history, cache and form auto-fill for any pages visited.
     646     */
     647    g_object_class_install_property(gObjectClass,
     648                                    PROP_ENABLE_PRIVATE_BROWSING,
     649                                    g_param_spec_boolean("enable-private-browsing",
     650                                                         _("Enable private browsing"),
     651                                                         _("Whether to enable private browsing"),
     652                                                         FALSE,
     653                                                         readWriteConstructParamFlags));
     654
     655    /**
     656     * WebKitSettings:enable-developer-extras:
     657     *
     658     * Determines whether or not developer tools, such as the Web Inspector, are enabled.
     659     */
     660    g_object_class_install_property(gObjectClass,
     661                                    PROP_ENABLE_DEVELOPER_EXTRAS,
     662                                    g_param_spec_boolean("enable-developer-extras",
     663                                                         _("Enable developer extras"),
     664                                                         _("Whether to enable developer extras"),
     665                                                         FALSE,
     666                                                         readWriteConstructParamFlags));
     667
     668    /**
     669     * WebKitSettings:enable-resizable-text-areas:
     670     *
     671     * Determines whether or not text areas can be resized.
     672     */
     673    g_object_class_install_property(gObjectClass,
     674                                    PROP_ENABLE_RESIZABLE_TEXT_AREAS,
     675                                    g_param_spec_boolean("enable-resizable-text-areas",
     676                                                         _("Enable resizable text areas"),
     677                                                         _("Whether to enable resizable text areas"),
     678                                                         TRUE,
     679                                                         readWriteConstructParamFlags));
     680
     681    /**
     682     * WebKitSettings:enable-tabs-to-links:
     683     *
     684     * Determines whether the tab key cycles through the elements on the page.
     685     * When this setting is enabled, users will be able to focus the next element
     686     * in the page by pressing the tab key. If the selected element is editable,
     687     * then pressing tab key will insert the tab character.
     688     */
     689    g_object_class_install_property(gObjectClass,
     690                                    PROP_ENABLE_TABS_TO_LINKS,
     691                                    g_param_spec_boolean("enable-tabs-to-links",
     692                                                         _("Enable tabs to links"),
     693                                                         _("Whether to enable tabs to links"),
     694                                                         FALSE,
     695                                                         readWriteConstructParamFlags));
     696
     697    /**
    614698     * WebKitSettings:enable-caret-browsing:
    615699     *
    … …  
    15331617
    15341618/**
     1619 * webkit_settings_get_enable_private_browsing:
     1620 * @settings: a #WebKitSettings
     1621 *
     1622 * Get the #WebKitSettings:enable-private-browsing property.
     1623 *
     1624 * Returns: %TRUE If private browsing is enabled or %FALSE otherwise.
     1625 */
     1626gboolean webkit_settings_get_enable_private_browsing(WebKitSettings* settings)
     1627{
     1628    g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE);
     1629
     1630    return WKPreferencesGetPrivateBrowsingEnabled(settings->priv->preferences.get());
     1631}
     1632
     1633/**
     1634 * webkit_settings_set_private_caret_browsing:
     1635 * @settings: a #WebKitSettings
     1636 * @enabled: Value to be set
     1637 *
     1638 * Set the #WebKitSettings:enable-private-browsing property.
     1639 */
     1640void webkit_settings_set_enable_private_browsing(WebKitSettings* settings, gboolean enabled)
     1641{
     1642    g_return_if_fail(WEBKIT_IS_SETTINGS(settings));
     1643
     1644    WebKitSettingsPrivate* priv = settings->priv;
     1645    bool currentValue = WKPreferencesGetPrivateBrowsingEnabled(priv->preferences.get());
     1646    if (currentValue == enabled)
     1647        return;
     1648
     1649    WKPreferencesSetPrivateBrowsingEnabled(priv->preferences.get(), enabled);
     1650    g_object_notify(G_OBJECT(settings), "enable-private-browsing");
     1651}
     1652
     1653/**
     1654 * webkit_settings_get_enable_developer_extras:
     1655 * @settings: a #WebKitSettings
     1656 *
     1657 * Get the #WebKitSettings:enable-developer-extras property.
     1658 *
     1659 * Returns: %TRUE If developer extras is enabled or %FALSE otherwise.
     1660 */
     1661gboolean webkit_settings_get_enable_developer_extras(WebKitSettings* settings)
     1662{
     1663    g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE);
     1664
     1665    return WKPreferencesGetDeveloperExtrasEnabled(settings->priv->preferences.get());
     1666}
     1667
     1668/**
     1669 * webkit_settings_set_enable_developer_extras:
     1670 * @settings: a #WebKitSettings
     1671 * @enabled: Value to be set
     1672 *
     1673 * Set the #WebKitSettings:enable-developer-extras property.
     1674 */
     1675void webkit_settings_set_enable_developer_extras(WebKitSettings* settings, gboolean enabled)
     1676{
     1677    g_return_if_fail(WEBKIT_IS_SETTINGS(settings));
     1678
     1679    WebKitSettingsPrivate* priv = settings->priv;
     1680    bool currentValue = WKPreferencesGetDeveloperExtrasEnabled(priv->preferences.get());
     1681    if (currentValue == enabled)
     1682        return;
     1683
     1684    WKPreferencesSetDeveloperExtrasEnabled(priv->preferences.get(), enabled);
     1685    g_object_notify(G_OBJECT(settings), "enable-developer-extras");
     1686}
     1687
     1688/**
     1689 * webkit_settings_get_enable_resizable_text_areas:
     1690 * @settings: a #WebKitSettings
     1691 *
     1692 * Get the #WebKitSettings:enable-resizable-text-areas property.
     1693 *
     1694 * Returns: %TRUE If text areas can be resized or %FALSE otherwise.
     1695 */
     1696gboolean webkit_settings_get_enable_resizable_text_areas(WebKitSettings* settings)
     1697{
     1698    g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE);
     1699
     1700    return WKPreferencesGetTextAreasAreResizable(settings->priv->preferences.get());
     1701}
     1702
     1703/**
     1704 * webkit_settings_set_enable_resizable_text_areas:
     1705 * @settings: a #WebKitSettings
     1706 * @enabled: Value to be set
     1707 *
     1708 * Set the #WebKitSettings:enable-resizable-text-areas property.
     1709 */
     1710void webkit_settings_set_enable_resizable_text_areas(WebKitSettings* settings, gboolean enabled)
     1711{
     1712    g_return_if_fail(WEBKIT_IS_SETTINGS(settings));
     1713
     1714    WebKitSettingsPrivate* priv = settings->priv;
     1715    bool currentValue = WKPreferencesGetTextAreasAreResizable(priv->preferences.get());
     1716    if (currentValue == enabled)
     1717        return;
     1718
     1719    WKPreferencesSetTextAreasAreResizable(priv->preferences.get(), enabled);
     1720    g_object_notify(G_OBJECT(settings), "enable-resizable-text-areas");
     1721}
     1722
     1723/**
     1724 * webkit_settings_get_enable_tabs_to_links:
     1725 * @settings: a #WebKitSettings
     1726 *
     1727 * Get the #WebKitSettings:enable-tabs-to-links property.
     1728 *
     1729 * Returns: %TRUE If tabs to link is enabled or %FALSE otherwise.
     1730 */
     1731gboolean webkit_settings_get_enable_tabs_to_links(WebKitSettings* settings)
     1732{
     1733    g_return_val_if_fail(WEBKIT_IS_SETTINGS(settings), FALSE);
     1734
     1735    return WKPreferencesGetTabsToLinks(settings->priv->preferences.get());
     1736}
     1737
     1738/**
     1739 * webkit_settings_set_enable_tabs_to_links:
     1740 * @settings: a #WebKitSettings
     1741 * @enabled: Value to be set
     1742 *
     1743 * Set the #WebKitSettings:enable-tabs-to-links property.
     1744 */
     1745void webkit_settings_set_enable_tabs_to_links(WebKitSettings* settings, gboolean enabled)
     1746{
     1747    g_return_if_fail(WEBKIT_IS_SETTINGS(settings));
     1748
     1749    WebKitSettingsPrivate* priv = settings->priv;
     1750    bool currentValue = WKPreferencesGetTabsToLinks(priv->preferences.get());
     1751    if (currentValue == enabled)
     1752        return;
     1753
     1754    WKPreferencesSetTabsToLinks(priv->preferences.get(), enabled);
     1755    g_object_notify(G_OBJECT(settings), "enable-tabs-to-links");
     1756}
     1757
     1758/**
    15351759 * webkit_settings_get_enable_caret_browsing:
    15361760 * @settings: a #WebKitSettings

  • trunk/Source/WebKit2/UIProcess/API/gtk/WebKitSettings.h

    r100248 r100580  
    239239
    240240WEBKIT_API gboolean
     241webkit_settings_get_enable_private_browsing                    (WebKitSettings* settings);
     242
     243WEBKIT_API void
     244webkit_settings_set_enable_private_browsing                    (WebKitSettings* settings,
     245                                                                gboolean        enabled);
     246
     247WEBKIT_API gboolean
     248webkit_settings_get_enable_developer_extras                    (WebKitSettings* settings);
     249
     250WEBKIT_API void
     251webkit_settings_set_enable_developer_extras                    (WebKitSettings* settings,
     252                                                                gboolean        enabled);
     253
     254WEBKIT_API gboolean
     255webkit_settings_get_enable_resizable_text_areas                (WebKitSettings* settings);
     256
     257WEBKIT_API void
     258webkit_settings_set_enable_resizable_text_areas                (WebKitSettings* settings,
     259                                                                gboolean        enabled);
     260
     261WEBKIT_API gboolean
     262webkit_settings_get_enable_tabs_to_links                       (WebKitSettings* settings);                             
     263
     264WEBKIT_API void
     265webkit_settings_set_enable_tabs_to_links                       (WebKitSettings* settings,
     266                                                                gboolean        enabled);
     267
     268WEBKIT_API gboolean
    241269webkit_settings_get_enable_caret_browsing                      (WebKitSettings* settings);
    242270

  • trunk/Source/WebKit2/UIProcess/API/gtk/docs/webkit2gtk-sections.txt

    r100414 r100580  
    205205webkit_settings_get_default_charset
    206206webkit_settings_set_default_charset
     207webkit_settings_get_enable_private_browsing
     208webkit_settings_set_enable_private_browsing
     209webkit_settings_get_enable_developer_extras
     210webkit_settings_set_enable_developer_extras
     211webkit_settings_get_enable_resizable_text_areas
     212webkit_settings_set_enable_resizable_text_areas
     213webkit_settings_get_enable_tabs_to_links
     214webkit_settings_set_enable_tabs_to_links
    207215webkit_settings_get_enable_caret_browsing
    208216webkit_settings_set_enable_caret_browsing

  • trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp

    r100578 r100580  
    158158    g_assert_cmpstr(webkit_settings_get_default_charset(settings), ==, "utf8");
    159159
     160    g_assert(!webkit_settings_get_enable_private_browsing(settings));
     161    webkit_settings_set_enable_private_browsing(settings, TRUE);
     162    g_assert(webkit_settings_get_enable_private_browsing(settings));
     163
     164    g_assert(!webkit_settings_get_enable_developer_extras(settings));
     165    webkit_settings_set_enable_developer_extras(settings, TRUE);
     166    g_assert(webkit_settings_get_enable_developer_extras(settings));
     167
     168    g_assert(webkit_settings_get_enable_resizable_text_areas(settings));
     169    webkit_settings_set_enable_resizable_text_areas(settings, FALSE);
     170    g_assert(!webkit_settings_get_enable_resizable_text_areas(settings));
     171
     172    g_assert(!webkit_settings_get_enable_tabs_to_links(settings));
     173    webkit_settings_set_enable_tabs_to_links(settings, TRUE);
     174    g_assert(webkit_settings_get_enable_tabs_to_links(settings));
     175
    160176    // Caret browsing is disabled by default.
    161177    g_assert(!webkit_settings_get_enable_caret_browsing(settings));
Note: See TracChangeset for help on using the changeset viewer.