Changeset 10061 in webkit

Timestamp:

Aug 5, 2005, 6:16:25 PM (20 years ago)

Author:

ggaren

Message:

-fixed <rdar://problem/4207220> REGRESSION (DENVER): Crash occurs
after clicking on Hangman applet

Reviewed by darin.

• kjs/object.cpp: (KJS::ObjectImp::hasProperty): added check for null prototype.

FIXME: The long-term plan is to make runtime objects use JS Null()
instead of null pointers, which will allow us to eliminate null
checks, improving performance.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• kjs/object.cpp (modified) (2 diffs)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2005-08-05  Geoffrey Garen  <ggaren@apple.com>
+
+        -fixed <rdar://problem/4207220> REGRESSION (DENVER): Crash occurs 
+        after clicking on Hangman applet
+
+        Reviewed by darin.
+
+        * kjs/object.cpp:
+        (KJS::ObjectImp::hasProperty): added check for null prototype.
+
+        FIXME: The long-term plan is to make runtime objects use JS Null()
+        instead of null pointers, which will allow us to eliminate null
+        checks, improving performance.
+
 2005-08-05  Geoffrey Garen  <ggaren@apple.com>
 

trunk/JavaScriptCore/kjs/object.cpp

@@ -327 +327 @@
     return true;
 
-  if (_proto->dispatchType() != ObjectType) {
+  if (!_proto || _proto->dispatchType() != ObjectType) {
     return false;
   }
@@ -340 +340 @@
       return true;
 
-    if (_proto->dispatchType() != ObjectType) {
+    if (!_proto || _proto->dispatchType() != ObjectType) {
       return false;
     }