Changeset 101452 in webkit

Timestamp:

Nov 29, 2011, 11:56:23 PM (14 years ago)

Author:

commit-queue@webkit.org

Message:

Fix for fill color not being applied inside visited links
​https://bugs.webkit.org/show_bug.cgi?id=70434

Patch by Philip Rogers <​pdr@google.com> on 2011-11-29
Reviewed by Antti Koivisto.

Source/WebCore:

Test: svg/custom/visited-link-color.svg

• rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::setFillPaint):
(WebCore::SVGRenderStyle::setStrokePaint):

LayoutTests:

• svg/custom/visited-link-color-expected.png: Added.
• svg/custom/visited-link-color-expected.txt: Added.
• svg/custom/visited-link-color.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/custom/visited-link-color-expected.png (added)
• LayoutTests/svg/custom/visited-link-color-expected.txt (added)
• LayoutTests/svg/custom/visited-link-color.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/style/SVGRenderStyle.h (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-29  Philip Rogers  <pdr@google.com>
+
+        Fix for fill color not being applied inside visited links
+        https://bugs.webkit.org/show_bug.cgi?id=70434
+
+        Reviewed by Antti Koivisto.
+
+        * svg/custom/visited-link-color-expected.png: Added.
+        * svg/custom/visited-link-color-expected.txt: Added.
+        * svg/custom/visited-link-color.svg: Added.
+
 2011-11-29  Hayato Ito  <hayato@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-29  Philip Rogers  <pdr@google.com>
+
+        Fix for fill color not being applied inside visited links
+        https://bugs.webkit.org/show_bug.cgi?id=70434
+
+        Reviewed by Antti Koivisto.
+
+        Test: svg/custom/visited-link-color.svg
+
+        * rendering/style/SVGRenderStyle.h:
+        (WebCore::SVGRenderStyle::setFillPaint):
+        (WebCore::SVGRenderStyle::setStrokePaint):
+
 2011-11-29  David Levin  <levin@chromium.org>
 

trunk/Source/WebCore/rendering/style/SVGRenderStyle.h

@@ -165 +165 @@
         }
         if (applyToVisitedLinkStyle) {
-            if (!(fill->paintType == type))
+            if (!(fill->visitedLinkPaintType == type))
                 fill.access()->visitedLinkPaintType = type;
-            if (!(fill->paintColor == color))
+            if (!(fill->visitedLinkPaintColor == color))
                 fill.access()->visitedLinkPaintColor = color;
-            if (!(fill->paintUri == uri))
+            if (!(fill->visitedLinkPaintUri == uri))
                 fill.access()->visitedLinkPaintUri = uri;
         }
@@ -191 +191 @@
         }
         if (applyToVisitedLinkStyle) {
-            if (!(stroke->paintType == type))
+            if (!(stroke->visitedLinkPaintType == type))
                 stroke.access()->visitedLinkPaintType = type;
-            if (!(stroke->paintColor == color))
+            if (!(stroke->visitedLinkPaintColor == color))
                 stroke.access()->visitedLinkPaintColor = color;
-            if (!(stroke->paintUri == uri))
+            if (!(stroke->visitedLinkPaintUri == uri))
                 stroke.access()->visitedLinkPaintUri = uri;
         }