Changeset 101979 in webkit

Timestamp:

Dec 5, 2011, 1:28:10 AM (14 years ago)

Author:

kkristof@inf.u-szeged.hu

Message:

NRWT should handle duplicated expectations
​https://bugs.webkit.org/show_bug.cgi?id=69750

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/models/test_expectations.py (modified) (3 diffs)
• Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/base.py (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/webkit.py (modified) (2 diffs)
• Scripts/webkitpy/layout_tests/port/webkit_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
+
+        NRWT should handle duplicated expectations
+        https://bugs.webkit.org/show_bug.cgi?id=69750
+
+        Reviewed by Dirk Pranke.
+
+        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+        (TestExpectations.__init__):
+        (TestExpectations._report_errors):
+        (TestExpectations._add_expectations):
+        * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
+        (test_add_skipped_tests):
+        * Scripts/webkitpy/layout_tests/port/base.py:
+        (Port.skipped_tests):
+        * Scripts/webkitpy/layout_tests/port/webkit.py:
+        (WebKitPort.test_expectations):
+        (WebKitPort.skipped_tests):
+        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
+        (test_test_expectations):
+
 2011-12-04  Eric Seidel  <eric@webkit.org>
 

trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

@@ -698 +698 @@
         self._port = port
         self._test_configuration_converter = TestConfigurationConverter(port.all_test_configurations(), port.configuration_specifier_macros())
+        self._skipped_tests_warnings = []
 
         self._expectations = TestExpectationParser.tokenize_list(expectations)
         self._add_expectations(self._expectations, overrides_allowed=False)
+        self._add_skipped_tests(port.skipped_tests())
 
         if overrides:
@@ -784 +786 @@
                 warnings.append("Line:%s %s %s" % (expectation.line_number, warning, expectation.name if expectation.expectations else expectation.original_string))
 
+        for warning in self._skipped_tests_warnings:
+            warnings.append(warning)
+
         if len(errors) or len(warnings):
             webkit_base_path = self._port.webkit_base()
@@ -827 +832 @@
             if self._test_config in expectation_line.matching_configurations:
                 self._model.add_expectation_line(expectation_line, overrides_allowed)
+
+    def _add_skipped_tests(self, tests_to_skip):
+        if not tests_to_skip:
+            return
+        for index, test in enumerate(self._expectations, start=1):
+            if test.name and test.name in tests_to_skip:
+                self._skipped_tests_warnings.append('The %s test from test_expectations.txt in line %d is also in Skipped!' %
+                            (test.name, index))
+        skipped_tests = '\n'.join(map(lambda test_path: 'BUG_SKIPPED SKIP : %s = FAIL' % test_path, tests_to_skip))
+        for test in TestExpectationParser.tokenize_list(skipped_tests):
+            self._parser.parse(test)
+            self._model.add_expectation_line(test, overrides_allowed=True)

trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py

@@ -257 +257 @@
                          self._exp.get_tests_with_result_type(SKIP))
 
+    def test_add_skipped_tests(self):
+        port = MockHost().port_factory.get('qt')
+        port._filesystem.files[port._filesystem.join(port.layout_tests_dir(), 'platform/qt/Skipped')] = 'failures/expected/text.html'
+        port._filesystem.files[port._filesystem.join(port.layout_tests_dir(), 'failures/expected/text.html')] = 'foo'
+        self.assertRaises(ParseError, TestExpectations, port, 'failures/expected/text.html\n', 'BUGX : failures/expected/text.html = text\n', None, True)
+
+
 class ExpectationSyntaxTests(Base):
     def test_missing_expectation(self):

trunk/Tools/Scripts/webkitpy/layout_tests/port/base.py

@@ -610 +610 @@
         return []
 
+    def skipped_tests(self):
+        return []
+
     def skips_layout_test(self, test_name):
         """Figures out if the givent test is being skipped or not.

trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py

@@ -361 +361 @@
     def test_expectations(self):
         # This allows ports to use a combination of test_expectations.txt files and Skipped lists.
-        expectations = self._skipped_list_as_expectations()
+        expectations = ''
         expectations_path = self.path_to_test_expectations_file()
         if self._filesystem.exists(expectations_path):
             _log.debug("Using test_expectations.txt: %s" % expectations_path)
-            expectations = self._filesystem.read_text_file(expectations_path) + '\n' + expectations
+            expectations = self._filesystem.read_text_file(expectations_path)
         return expectations
-
-    def _skipped_list_as_expectations(self):
-        # Each Skipped file contains a list of files
-        # or directories to be skipped during the test run. The total list
-        # of tests to skipped is given by the contents of the generic
-        # Skipped file found in platform/X plus a version-specific file
-        # found in platform/X-version. Duplicate entries are allowed.
-        # This routine reads those files and turns contents into the
-        # format expected by test_expectations.
-
-        tests_to_skip = self.skipped_layout_tests()
-        skip_lines = map(lambda test_path: "BUG_SKIPPED SKIP : %s = FAIL" % test_path, tests_to_skip)
-        return "\n".join(skip_lines)
 
     def skipped_layout_tests(self):
@@ -387 +374 @@
         tests_to_skip.update(self._skipped_tests_for_unsupported_features())
         return tests_to_skip
+
+    def skipped_tests(self):
+        return self.skipped_layout_tests()
 
     def _build_path(self, *comps):

trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py

@@ -149 +149 @@
 
     def test_test_expectations(self):
-        # Check that we read both the expectations file and anything in a
-        # Skipped file, and that we include the feature and platform checks.
+        # Check that we read the expectations file
         files = {
             '/mock-checkout/LayoutTests/platform/testwebkitport/test_expectations.txt': 'BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL\n',
-            '/mock-checkout/LayoutTests/platform/testwebkitport/Skipped': 'fast/html/keygen.html',
         }
         mock_fs = MockFileSystem(files)
         port = TestWebKitPort(filesystem=mock_fs)
-        self.assertEqual(port.test_expectations(),
-        """BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL\n
-BUG_SKIPPED SKIP : fast/html/keygen.html = FAIL
-BUG_SKIPPED SKIP : media = FAIL""")
-        files = {
-            '/mock-checkout/LayoutTests/platform/testwebkitport/test_expectations.txt': 'BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL',
-            '/mock-checkout/LayoutTests/platform/testwebkitport/Skipped': 'fast/html/keygen.html',
-        }
-        mock_fs = MockFileSystem(files)
-        port = TestWebKitPort(filesystem=mock_fs)
-        self.assertEqual(port.test_expectations(),
-        """BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL
-BUG_SKIPPED SKIP : fast/html/keygen.html = FAIL
-BUG_SKIPPED SKIP : media = FAIL""")
-
+        self.assertEqual(port.test_expectations(), 'BUG_TESTEXPECTATIONS SKIP : fast/html/article-element.html = FAIL\n')
 
     def test_build_driver(self):